From patchwork Thu Mar 13 10:17:42 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stanislaw Gruszka X-Patchwork-Id: 14014633 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 41D4C264630 for ; Thu, 13 Mar 2025 10:17:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=192.198.163.7 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741861075; cv=none; b=aQbKQnEERqCdCgj/NTy2ajfrT0AjIWyAUujLDU1Dvaph61+K+zIM0K/hOdaKrHLMy+mttADLXv4YN/YuZkaDP++gkNHCeJgQGuK91iT/fGFN4oVSKwf1iZnGYlHOAH8tcKpPmhUiV4i9Imd6AGy54jy2725jQs8AB2TeOJF1J4o= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741861075; c=relaxed/simple; bh=7P40b1sMECSGgLNwTax97WcROk49V7Ejaqzj+d4qmno=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=GkUR8Ez9StCKCsJWl6YzRzcONc9YcKQt5DwZV6I3oF7HsijcUo1Y10woqTNkmV4XsZDx3EkDYx44KkRQlr+NTTAY0jseM/SeRxjGH3a6unea32XgI3D18RhBEPTS8k12KmjgKp4RdAMtDLgTvqZ5IOiImE5KOEvKj+w8r7Cp1eQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com; spf=none smtp.mailfrom=linux.intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=MWSnxAQS; arc=none smtp.client-ip=192.198.163.7 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="MWSnxAQS" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1741861074; x=1773397074; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=7P40b1sMECSGgLNwTax97WcROk49V7Ejaqzj+d4qmno=; b=MWSnxAQSeW2y7MJkUowrMIbTCSp8k+xTssXQEyQJvVGYYIVXUNCA0zap Hbp3pZnvL+VqlmjrFjyf7KDBDQmBYb2uc1C+4tb15ZDXPtJN8bMt6Tbph pOhn2mXvR/kRlT3+v46n+b29Qap8tPjx59W4+zYylElebolxBkwuwABCg IBubaestrrK9bkmJNZXwDk7ZG6q6ykn0FJDS58q6MppuWqvGHtUU/H6jd XhuybPk4HztN2Os9550i1p4CnuEmCtsIge/MkqoksKEqL07wpCdCypjZ+ 0ykkUadUqWdaEwuObihF8EHM1wDNe/W7XREBgitQY1YqSh+kkWaMRvDrb A==; X-CSE-ConnectionGUID: KdJ/Tg5nSKKPqZcPCZOFRw== X-CSE-MsgGUID: kg/oOOoxSYC8/MI4MzCi5A== X-IronPort-AV: E=McAfee;i="6700,10204,11371"; a="68324598" X-IronPort-AV: E=Sophos;i="6.14,244,1736841600"; d="scan'208";a="68324598" Received: from orviesa004.jf.intel.com ([10.64.159.144]) by fmvoesa101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 Mar 2025 03:17:52 -0700 X-CSE-ConnectionGUID: P792BxmpRdCoX5QyWVZVYg== X-CSE-MsgGUID: P944Jz/DTN+xtzicfnT3ng== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.14,244,1736841600"; d="scan'208";a="125983377" Received: from sgruszka-mobl.ger.corp.intel.com (HELO localhost) ([10.245.81.114]) by orviesa004-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 Mar 2025 03:17:51 -0700 From: Stanislaw Gruszka To: linux-media@vger.kernel.org Cc: Sakari Ailus , Bingbu Cao , Hans de Goede Subject: [PATCH v2 1/3] media: intel/ipu6: Remove unused IPU6_BUS_NAME Date: Thu, 13 Mar 2025 11:17:42 +0100 Message-Id: <20250313101744.128564-2-stanislaw.gruszka@linux.intel.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20250313101744.128564-1-stanislaw.gruszka@linux.intel.com> References: <20250313101744.128564-1-stanislaw.gruszka@linux.intel.com> Precedence: bulk X-Mailing-List: linux-media@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Remove unused define. Reviewed-by: Hans de Goede Signed-off-by: Stanislaw Gruszka --- drivers/media/pci/intel/ipu6/ipu6-bus.h | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/media/pci/intel/ipu6/ipu6-bus.h b/drivers/media/pci/intel/ipu6/ipu6-bus.h index bb4926dfdf08..ebf470806a74 100644 --- a/drivers/media/pci/intel/ipu6/ipu6-bus.h +++ b/drivers/media/pci/intel/ipu6/ipu6-bus.h @@ -15,8 +15,6 @@ struct firmware; struct pci_dev; -#define IPU6_BUS_NAME IPU6_NAME "-bus" - struct ipu6_buttress_ctrl; struct ipu6_bus_device { From patchwork Thu Mar 13 10:17:43 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stanislaw Gruszka X-Patchwork-Id: 14014634 Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.20]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 15C88265630 for ; Thu, 13 Mar 2025 10:17:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.175.65.20 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741861078; cv=none; b=f/+7Uu0QULEnvaf5YfJg5vQ8MGcdmae5el0zqmCeX/rQjc9kOyQ+rzFbxWGXfKLv4E+2FIZ62U6dlGuGozrh8ptHqMqn8Um/znq0Xyhea79apRjeerqcnXB6xqA00mOAJhNrgGakDcQ6HhJUN3co8LtVBfm7zXlsAW3J/HITENE= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741861078; c=relaxed/simple; bh=LAeRJMtm1uvG/j8zE5Ns5HJwd0CFWkXNdT2kDLMfMx0=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=R4Lxoo5RapNRda+B+uQuixe6f4WioOL5tbAPBznI3YUVZ+YP8bCzLbnvMy4DFVO9rxd3urZGifu9cCr+ssev+q251bb8GZMgdIWX83JmOTpm1cNYx9+Q6Kjp/+h98ELBhb2RDlOoEim1i8oNgf1vQki/1cbqxb7D9ZyE1bng0kM= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com; spf=none smtp.mailfrom=linux.intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=dMD/KwaB; arc=none smtp.client-ip=198.175.65.20 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="dMD/KwaB" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1741861077; x=1773397077; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=LAeRJMtm1uvG/j8zE5Ns5HJwd0CFWkXNdT2kDLMfMx0=; b=dMD/KwaBa8V3apfjHl6li8L46bprBzNyakaLLvcd4yGUMnXkzB/+OURh WuVIH75CT+3x43Yg/Fl/jTyUnxrCMjNuUWO/JlMGS8z4laBXoGo/F7EzS HyXbKHxOqxYIBwo/VGypF5XgR0e5PFttNIQpqmKj8nhDr7REFHKgHMISm hi1BAFbu82woEB44D7Me5dcoBg/chmb3e1GUZPCR5dkeeQrhK6yyTzQbh yJqDlnA1k9oXdVN3L8x1kAAZJFJMNxSn+sn7C/iPJ49Psm/8mKDqAOxDL Qff4q1nf3CaXdae9uMd6gRKWdgw7jC3AxC9652MsTgf0Eocfe/K464qNB g==; X-CSE-ConnectionGUID: Z4eZS2ShTC6DIhBP7KfCwQ== X-CSE-MsgGUID: 4s2/HYd3QUexYirPsshpjg== X-IronPort-AV: E=McAfee;i="6700,10204,11371"; a="42700009" X-IronPort-AV: E=Sophos;i="6.14,244,1736841600"; d="scan'208";a="42700009" Received: from orviesa001.jf.intel.com ([10.64.159.141]) by orvoesa112.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 Mar 2025 03:17:57 -0700 X-CSE-ConnectionGUID: UsIyinIpRpqYj7oXLzSo9g== X-CSE-MsgGUID: 9yemRalhR76XA/KKF0Gfdw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.14,244,1736841600"; d="scan'208";a="158070742" Received: from sgruszka-mobl.ger.corp.intel.com (HELO localhost) ([10.245.81.114]) by smtpauth.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 Mar 2025 03:17:54 -0700 From: Stanislaw Gruszka To: linux-media@vger.kernel.org Cc: Sakari Ailus , Bingbu Cao , Hans de Goede Subject: [PATCH v2 2/3] media: intel/ipu6: Remove ipu6_buttress_ctrl started field Date: Thu, 13 Mar 2025 11:17:43 +0100 Message-Id: <20250313101744.128564-3-stanislaw.gruszka@linux.intel.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20250313101744.128564-1-stanislaw.gruszka@linux.intel.com> References: <20250313101744.128564-1-stanislaw.gruszka@linux.intel.com> Precedence: bulk X-Mailing-List: linux-media@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 We assign to ->started field but newer read back, the field can be removed. Reviewed-by: Hans de Goede Signed-off-by: Stanislaw Gruszka --- drivers/media/pci/intel/ipu6/ipu6-buttress.c | 2 -- drivers/media/pci/intel/ipu6/ipu6-buttress.h | 1 - 2 files changed, 3 deletions(-) diff --git a/drivers/media/pci/intel/ipu6/ipu6-buttress.c b/drivers/media/pci/intel/ipu6/ipu6-buttress.c index d8db5aa5d528..787fcbd1df09 100644 --- a/drivers/media/pci/intel/ipu6/ipu6-buttress.c +++ b/drivers/media/pci/intel/ipu6/ipu6-buttress.c @@ -478,8 +478,6 @@ int ipu6_buttress_power(struct device *dev, struct ipu6_buttress_ctrl *ctrl, dev_err(&isp->pdev->dev, "Change power status timeout with 0x%x\n", val); - ctrl->started = !ret && on; - mutex_unlock(&isp->buttress.power_mutex); return ret; diff --git a/drivers/media/pci/intel/ipu6/ipu6-buttress.h b/drivers/media/pci/intel/ipu6/ipu6-buttress.h index 482978c2a09d..4b9763acdfdd 100644 --- a/drivers/media/pci/intel/ipu6/ipu6-buttress.h +++ b/drivers/media/pci/intel/ipu6/ipu6-buttress.h @@ -26,7 +26,6 @@ struct ipu6_buttress_ctrl { u32 freq_ctl, pwr_sts_shift, pwr_sts_mask, pwr_sts_on, pwr_sts_off; unsigned int ratio; unsigned int qos_floor; - bool started; }; struct ipu6_buttress_ipc { From patchwork Thu Mar 13 10:17:44 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stanislaw Gruszka X-Patchwork-Id: 14014635 Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.20]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 30A74264F86 for ; Thu, 13 Mar 2025 10:18:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.175.65.20 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741861082; cv=none; b=IAVSSOke5RuZ8/8EZ+HNFX+0G4epGb8QiHBCKxEvyVJK9UWd3ZTE5Omru8reptWTLSNOgibe1JVDmbylPqGFqOyXY9Owqguf9ZQbhEG9Bkgv7w7B5kG4ZYb5rIVAZQUkalvb4BAXjXM2MeIzLRlEIbcA3gthqXhzrf2p1lUqEyQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741861082; c=relaxed/simple; bh=AxL6DPhFsh4HbSOCV6i8kruFeQznEnHw9qZalgjMWts=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=NBo3k8nTvmilzeHG5X/LdnPjjrE1IxM3GTuRFIxiu0XHeruoV0dYIOnQ2PX2q8O8d0HDhYr1lbWoX5Hlw17MLy4TV3DgL/NBN/tk7lRaLT5M2rUg5o5EdnNa8CrsCxJ7GpcARwMcno5HczswyqeA2xGmW8ln/PhhmAr2PkcsO04= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com; spf=none smtp.mailfrom=linux.intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=Xixkgq0c; arc=none smtp.client-ip=198.175.65.20 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="Xixkgq0c" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1741861082; x=1773397082; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=AxL6DPhFsh4HbSOCV6i8kruFeQznEnHw9qZalgjMWts=; b=Xixkgq0cwb6DTKQiQ5nq5IvTKRnUFzhoiyCijXBchVWLqFojT1f9l9EZ xYOYRCZto99Xpx7WyN7ehKWX614iGdoUgwTYktohmZYHDxefujaukFG1P /mRrkHBBgA4ieTvE4Z11mwfJs7pyG4qy9Vtk2xNbQZoduKRzYZbzdHd4X Whm92rxd1XdB5+cgPdG/+Ly0x8V7zGliDn2Xmk/rbjGXS0V6CAYenRkf7 kf/UtfuktdxzltgbGB4R7hzuHZ3s1cUJK2AVcHDxtOFImpdw7b8xe/NW7 JtgcsM/sIvawWPkd0/mTp+WWYrM/5vFoOucyWg5ObhEfPiMbgmwuWAumm A==; X-CSE-ConnectionGUID: ZNPgG7ObR3WfRjYUqysakw== X-CSE-MsgGUID: 7ush/AP/SjqRqNThq62+og== X-IronPort-AV: E=McAfee;i="6700,10204,11371"; a="42700014" X-IronPort-AV: E=Sophos;i="6.14,244,1736841600"; d="scan'208";a="42700014" Received: from orviesa001.jf.intel.com ([10.64.159.141]) by orvoesa112.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 Mar 2025 03:18:01 -0700 X-CSE-ConnectionGUID: CgTiMC8CQF2nqIF80ohwrQ== X-CSE-MsgGUID: 9M55EjpMTcORRAnlO3S2Hw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.14,244,1736841600"; d="scan'208";a="158070753" Received: from sgruszka-mobl.ger.corp.intel.com (HELO localhost) ([10.245.81.114]) by smtpauth.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 Mar 2025 03:17:59 -0700 From: Stanislaw Gruszka To: linux-media@vger.kernel.org Cc: Sakari Ailus , Bingbu Cao , Hans de Goede Subject: [PATCH v2 3/3] media: intel/ipu6: Constify ipu6_buttress_ctrl structure Date: Thu, 13 Mar 2025 11:17:44 +0100 Message-Id: <20250313101744.128564-4-stanislaw.gruszka@linux.intel.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20250313101744.128564-1-stanislaw.gruszka@linux.intel.com> References: <20250313101744.128564-1-stanislaw.gruszka@linux.intel.com> Precedence: bulk X-Mailing-List: linux-media@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Make ipu6_buttress_ctrl constant since it is not modified any longer. Reviewed-by: Hans de Goede Signed-off-by: Stanislaw Gruszka --- drivers/media/pci/intel/ipu6/ipu6-bus.c | 2 +- drivers/media/pci/intel/ipu6/ipu6-bus.h | 4 ++-- drivers/media/pci/intel/ipu6/ipu6-buttress.c | 4 ++-- drivers/media/pci/intel/ipu6/ipu6-buttress.h | 4 ++-- 4 files changed, 7 insertions(+), 7 deletions(-) diff --git a/drivers/media/pci/intel/ipu6/ipu6-bus.c b/drivers/media/pci/intel/ipu6/ipu6-bus.c index 37d88ddb6ee7..5cee2748983b 100644 --- a/drivers/media/pci/intel/ipu6/ipu6-bus.c +++ b/drivers/media/pci/intel/ipu6/ipu6-bus.c @@ -82,7 +82,7 @@ static void ipu6_bus_release(struct device *dev) struct ipu6_bus_device * ipu6_bus_initialize_device(struct pci_dev *pdev, struct device *parent, - void *pdata, struct ipu6_buttress_ctrl *ctrl, + void *pdata, const struct ipu6_buttress_ctrl *ctrl, char *name) { struct auxiliary_device *auxdev; diff --git a/drivers/media/pci/intel/ipu6/ipu6-bus.h b/drivers/media/pci/intel/ipu6/ipu6-bus.h index ebf470806a74..b790f9cc37e3 100644 --- a/drivers/media/pci/intel/ipu6/ipu6-bus.h +++ b/drivers/media/pci/intel/ipu6/ipu6-bus.h @@ -25,7 +25,7 @@ struct ipu6_bus_device { void *pdata; struct ipu6_mmu *mmu; struct ipu6_device *isp; - struct ipu6_buttress_ctrl *ctrl; + const struct ipu6_buttress_ctrl *ctrl; u64 dma_mask; const struct firmware *fw; struct sg_table fw_sgt; @@ -48,7 +48,7 @@ struct ipu6_auxdrv_data { struct ipu6_bus_device * ipu6_bus_initialize_device(struct pci_dev *pdev, struct device *parent, - void *pdata, struct ipu6_buttress_ctrl *ctrl, + void *pdata, const struct ipu6_buttress_ctrl *ctrl, char *name); int ipu6_bus_add_device(struct ipu6_bus_device *adev); void ipu6_bus_del_devices(struct pci_dev *pdev); diff --git a/drivers/media/pci/intel/ipu6/ipu6-buttress.c b/drivers/media/pci/intel/ipu6/ipu6-buttress.c index 787fcbd1df09..103386c4f6ae 100644 --- a/drivers/media/pci/intel/ipu6/ipu6-buttress.c +++ b/drivers/media/pci/intel/ipu6/ipu6-buttress.c @@ -443,8 +443,8 @@ irqreturn_t ipu6_buttress_isr_threaded(int irq, void *isp_ptr) return ret; } -int ipu6_buttress_power(struct device *dev, struct ipu6_buttress_ctrl *ctrl, - bool on) +int ipu6_buttress_power(struct device *dev, + const struct ipu6_buttress_ctrl *ctrl, bool on) { struct ipu6_device *isp = to_ipu6_bus_device(dev)->isp; u32 pwr_sts, val; diff --git a/drivers/media/pci/intel/ipu6/ipu6-buttress.h b/drivers/media/pci/intel/ipu6/ipu6-buttress.h index 4b9763acdfdd..51e5ad48db82 100644 --- a/drivers/media/pci/intel/ipu6/ipu6-buttress.h +++ b/drivers/media/pci/intel/ipu6/ipu6-buttress.h @@ -65,8 +65,8 @@ int ipu6_buttress_map_fw_image(struct ipu6_bus_device *sys, struct sg_table *sgt); void ipu6_buttress_unmap_fw_image(struct ipu6_bus_device *sys, struct sg_table *sgt); -int ipu6_buttress_power(struct device *dev, struct ipu6_buttress_ctrl *ctrl, - bool on); +int ipu6_buttress_power(struct device *dev, + const struct ipu6_buttress_ctrl *ctrl, bool on); bool ipu6_buttress_get_secure_mode(struct ipu6_device *isp); int ipu6_buttress_authenticate(struct ipu6_device *isp); int ipu6_buttress_reset_authentication(struct ipu6_device *isp);