From patchwork Thu Mar 13 11:19:33 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Aditya Garg X-Patchwork-Id: 14014758 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id DDC04C282DE for ; Thu, 13 Mar 2025 11:19:46 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 497CE10E848; Thu, 13 Mar 2025 11:19:46 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=live.com header.i=@live.com header.b="CoEmhtgV"; dkim-atps=neutral Received: from PNYPR01CU001.outbound.protection.outlook.com (mail-centralindiaazolkn19010011.outbound.protection.outlook.com [52.103.68.11]) by gabe.freedesktop.org (Postfix) with ESMTPS id 0F00B10E848 for ; Thu, 13 Mar 2025 11:19:45 +0000 (UTC) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=TCMrrIM3fSV/7ZyMC3bP4Yd382j1uLTDgMY9tU38kjpNw9N4zCG8lqpOHo+Ptqpw3eDclmvYOJCBcGRHWylrObaVAWQ1jC4Lar5wy17RzqYHOCMPkkbR8NMIxKlK57uAMJZH8CbYROD5BtPRXPnyfUxLYD3sJV4RbKmEeNCCrf7orHymMmj9U6+5AsH5omBVGczIarHwMs4ey9+ds5y21ZImhlPFyJ5Q2xLohR7U7qDqyjMyNT3aPJVyGMtNwaitQkFhV2Ddol2ie4XHamo/LPNMCkcFAN4650G6yuQZEEuyT3qmJIoYhBtccdmAvOiFoxKKNDgNVckI2MgLYANr1g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=kzJM5vyMl3s56WJMhq6BZAyalpNM5Q0ZF/PIrKBcI9g=; b=ueN5dnbaIC6AaEjyItPLP7oEIkxsdqk1MhAlP2GTM1mW8p3hL8I8etS2fGWZUIxIETapHFCU7wD3SJ1PWsC5IZuDwI2Wrx3Xb1GIBwGhENxUQrCAJeCoNAj/BNSpUCVByOluUMGQDOIQotqOEmIsdtVl4qSyNtCf/i6+GfORGrGcU2iOp3KLrNK/pp2iM5pVmZQkyKlY0G82j7EJFdXxfdm9AA4CCFwXfM4EgSpLyP/lnsBO/BzTKRqdBQdGcNVYmI1l28Brp96ZXQgBXklkGdAaYMx5oPX3cheUOrvSS0ImkmLRvCoYFikQk2d1puHdylE2ufGUlG9SONjcfXtrFA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=live.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=kzJM5vyMl3s56WJMhq6BZAyalpNM5Q0ZF/PIrKBcI9g=; b=CoEmhtgV/99hO117FlahxRRFn3t0Mecr9amCYmBIHA3uCprcOyFN8k3tdVlFApTX8CdcFGh4VBnCGfYYuJ+0UF8xKN515TpSu0IndNkhRptVS9Omalp3BpqkzBET4RRN8qe1gyoa6sUYK5oN2hgWldcbUgz4qlMG5kPnN/qC7goPO0wsEP4uMYJ1E0M8d63WvBFmPBicFWqWXblwvICHwBOtBVbFmgj414skQR6Thto3QW2u/fQLD20DvCWQPkiZWRKElWzhijUzdVQUgYaD0BaUmALZhsLeaqg3Se4aY7HhpPN1llxE7tslXwiFumUMlqjZvc06Ycxkj7Rpobo03A== Received: from PN3PR01MB9597.INDPRD01.PROD.OUTLOOK.COM (2603:1096:c01:f7::14) by MA1PPFE52A1FAE5.INDPRD01.PROD.OUTLOOK.COM (2603:1096:a04::331) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8534.25; Thu, 13 Mar 2025 11:19:33 +0000 Received: from PN3PR01MB9597.INDPRD01.PROD.OUTLOOK.COM ([fe80::324:c085:10c8:4e77]) by PN3PR01MB9597.INDPRD01.PROD.OUTLOOK.COM ([fe80::324:c085:10c8:4e77%7]) with mapi id 15.20.8534.025; Thu, 13 Mar 2025 11:19:33 +0000 From: Aditya Garg To: Petr Mladek , "keescook@chromium.org" , Andy Shevchenko , Sven Peter , Thomas Zimmermann , Aun-Ali Zaidi , Maxime Ripard , "airlied@redhat.com" , Simona Vetter , Steven Rostedt , Rasmus Villemoes , Sergey Senozhatsky , Jonathan Corbet , Andrew Morton , "apw@canonical.com" , "joe@perches.com" , "dwaipayanray1@gmail.com" , "lukas.bulwahn@gmail.com" CC: Linux Kernel Mailing List , "dri-devel@lists.freedesktop.org" , "linux-doc@vger.kernel.org" , Hector Martin , Asahi Linux Mailing List Subject: [PATCH v2 1/2] lib/vsprintf: Add support for generic FourCCs by extending %p4cc Thread-Topic: [PATCH v2 1/2] lib/vsprintf: Add support for generic FourCCs by extending %p4cc Thread-Index: AQHblAnLqD345R2rs0audT7tx610NQ== Date: Thu, 13 Mar 2025 11:19:33 +0000 Message-ID: <79FA3F41-FD7A-41D9-852B-D32606AF5EB4@live.com> References: In-Reply-To: Accept-Language: en-IN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-exchange-messagesentrepresentingtype: 1 x-ms-publictraffictype: Email x-ms-traffictypediagnostic: PN3PR01MB9597:EE_|MA1PPFE52A1FAE5:EE_ x-ms-office365-filtering-correlation-id: cc35713d-f2ee-4127-eb85-08dd6220ee3e x-microsoft-antispam: BCL:0; ARA:14566002|461199028|19110799003|8062599003|8060799006|15080799006|7092599003|440099028|3412199025|41001999003|102099032; x-microsoft-antispam-message-info: CiYjPsJTeqfvDsJJrle9AhJTBovu2ldZFkFWWu9Spa+a+R3i02B/3Wbe1UL7iMjoczQXbwWFKXCRAcgCmmM22REiID1IIbIhq4JFSz6whInSWnpGzYlrkqooaZJc+rqa9MHPGmwLjFDNdk7l3cPkyDG1XyRYqhhCD0XLoHn3oWkOANZLoAox7V9FWfoF3Pi3iIzNFJ8a6t9nxPuOCXPbmrKxJZy1iz2gEVNsJSNbyaulmO3RbNHN+KV9MZ3/IWddvLRUyRr8dsmOOcK1j4MsVzHzUId80CredmdHWHYGP6abkimWfPhwt5792JJGYJF6yL81jRH5FcRzAwjQxb4tkl4mwmv28B98GdKyJiWrXthKntkQYs6BMYDImMF5l3+cOFeyr/8ATfnpN99R12pBVCjegN0Yr+0I2rBeZZyr+P67eKo3vbOBLza5gqTff7Qegyo8uEtgLCGAN3xcg2qwIaPINocuv4lTfByPiAbaU1f/TZ8MkkdEJ1MGB9JWfzJXUK3fjU15lq7focWSwdtoZ4cU2/AwKiUzQnEawrhrEYaO3e3NZH5olU9ZLBn+Ygn8pJMuEx401SW1Mq0F+r5I4c8PGmJbOr7K6lgGSwq+vPxP7GdRtjxpCGspVW9ghQC7AQYm1nyz1/e2VvmA1gXiDWk0/9SfuECvn7Cn8MWCHQ+3tWc+o//9aEuWLWBKfJs9E06GzgaPvkToC+dKP//Mm1nGz/cTTnOpBDw5f852YINPvw8oX3/oR4l1GZDppABstszoepTkU1pYyw2P/TUP+hnllCl9llLu30rXTwftsv2syykqqZFmN2Qo0oYdZENuYiYcIbULCo372nxOyhr59UGAgpWpK69EKBOTVQK876U+E3aOpweCnXjObJ6luRGir0s7fp2ypPWnlE0zWLQ5JhUH+R0SznU6cV39hy2DvyRVx/H139ygPDSBn1eYLFy2wBBFBxN215pBTHrMZa7yaaf8SwaUEHeZ5rsLjE92WnxKWc+kmKiFH0M0elWjuv12MKLw4PLo/QunxM/zxtSY36quTWkrgA0uBV9oF4V1+zhWLpMccE1f6Au+Uq56c99BLw36enjVzykX7oQ1sC7ItnSvWSKrmTwkdLZvKbEGcQY= x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: eqTG1vlJx7OFjhs290fO2l8GCDvG3MOr6hzP0QJ3KRXJbd7UxjVCXz/5//HAsweCqUG0YarX47Q8qmrCvVMrySXOTzBX4p+tnhIAXyFvdPFxvyDnbBuYYXhYFSubbtOLX7RgCsAbyQD2K9lm2cM8+pV8tvrzKsrL8Vw82gwmTqvzQ1pZJjIXOIsp7ts6BLSgudEdnsvJ49zT3GceN+ov9lzEeuZKWHAa8L1YAxo6MoMsxXWcjFiqU65F02d+yWZidugjaprnZcS4TqTf4wEQkOH1D8nD9SZ64utWGPquW61O+M0NJs/m24GVF3PKJuEIenK1/6eDCDCt3DdOiYz2+U5jZsqz9iI4ZMvLq3G2p7tdsDcldJCfvahHnNELiJyHah7vnGmMFITESmRqRNS+bACRyQ+/YbxPuUXsPSxMaausWaOEZuIs9xW6Xr7yIHM9aY3Q6S00A2VxGKvfdOJppYadnaZRWWW/IxZjuCWlu4DbJUdka/DwX5HZir3lE+StS2K9qdJcfgksD1yVCf26/O1FJWY3TXAjKkrdxKGKH9y511iuId7O4KtVDf3CiFz8DoZqHNa+28Br6zNdWj2rZje1IlIdpkQduQzkBhabYczBWHY6V8k7JbXXxkjozrLA8EmeenQZ7hVQHBDFXgJ37HlkRBuq+yl3CokPGSQAgj49AJyeyXQ/HY3Ioskb7wcebYFqFCG9R3hNK79kCgNTOmt6z4taq3Es7f40IbcI56UlT4Ulk10JkHexNP80tXPZQruXF7aV1SNUkfXOqhZG3ANeAlj3bLVuK9cdpe+4zno+YDu963dwuu6xsENGlAe3DSpukt5iBGhRcn5+IVLdbt7N9CiU5Rh3yQC9Pj/5pGD3n71VeFpNolKNn2FSCbSpo4oPa2YZ+qkVWZcpBIiWLDVxHebcHvfqXIP5cVvY9JKnpSiLhOm8xVfv7a/GCzRMhHUn0YLBt82EUuVH4pHyfrYhr9V1zhv8cjmQ4IIhzTpc1XUmVkDRgrYM3pp7LEEjF6bVvkTVix9B4OHq5ifW3zDrb8Y/WBOZc0UnceNHbRlZuDwm9ikvtXVIIr4XbgaACgEmN0nST5c9rR6Yx+G4HufGFeOqXVjwbYUZzmvscLxGRd4KYxIKOMB7/BRsWFDx0RbX1vl8wtZwhFNlMhpZPr6wBVpPvjlX3X22F9uiljsvahuWX9xqSOoiQRr+1VKue7/mu68cTWYz7rO4peGzP8i7bf1fuse5m5dXK1NXkaDk1J7VBnsYgF9Qf3H0FLwgPoV6bXBoKRBDEnNNp9HNoIpOY0htMdVjU70T9+5UFqaKafPelC1IAW6knsuE8CQ3 Content-ID: <38ED7DEC3CF38D45B6B5CB0C6589AAEE@INDPRD01.PROD.OUTLOOK.COM> MIME-Version: 1.0 X-OriginatorOrg: sct-15-20-7719-20-msonline-outlook-ae5c4.templateTenant X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: PN3PR01MB9597.INDPRD01.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-CrossTenant-Network-Message-Id: cc35713d-f2ee-4127-eb85-08dd6220ee3e X-MS-Exchange-CrossTenant-originalarrivaltime: 13 Mar 2025 11:19:33.1855 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-rms-persistedconsumerorg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: MA1PPFE52A1FAE5 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" From: Hector Martin %p4cc is designed for DRM/V4L2 FourCCs with their specific quirks, but it's useful to be able to print generic 4-character codes formatted as an integer. Extend it to add format specifiers for printing generic 32-bit FourCCs with various endian semantics: %p4ch Host byte order %p4cn Network byte order %p4cl Little-endian %p4cb Big-endian The endianness determines how bytes are interpreted as a u32, and the FourCC is then always printed MSByte-first (this is the opposite of V4L/DRM FourCCs). This covers most practical cases, e.g. %p4cn would allow printing LSByte-first FourCCs stored in host endian order (other than the hex form being in character order, not the integer value). Acked-by: Rasmus Villemoes Reviewed-by: Andy Shevchenko Reviewed-by: Petr Mladek Tested-by: Petr Mladek Signed-off-by: Hector Martin Signed-off-by: Aditya Garg --- Documentation/core-api/printk-formats.rst | 32 +++++++++++++++++++++ lib/vsprintf.c | 35 +++++++++++++++++++---- scripts/checkpatch.pl | 2 +- 3 files changed, 62 insertions(+), 7 deletions(-) diff --git a/Documentation/core-api/printk-formats.rst b/Documentation/core-api/printk-formats.rst index ecccc0473..bd420e8aa 100644 --- a/Documentation/core-api/printk-formats.rst +++ b/Documentation/core-api/printk-formats.rst @@ -648,6 +648,38 @@ Examples:: %p4cc Y10 little-endian (0x20303159) %p4cc NV12 big-endian (0xb231564e) +Generic FourCC code +------------------- + +:: + %p4c[hnlb] gP00 (0x67503030) + +Print a generic FourCC code, as both ASCII characters and its numerical +value as hexadecimal. + +The generic FourCC code is always printed in the big-endian format, +the most significant byte first. This is the opposite of V4L/DRM FourCCs. + +The additional ``h``, ``n``, ``l``, and ``b`` specifiers define what +endianness is used to load the stored bytes. The data might be interpreted +using the host byte order, network byte order, little-endian, or big-endian. + +Passed by reference. + +Examples for a little-endian machine, given &(u32)0x67503030:: + + %p4ch gP00 (0x67503030) + %p4cn 00Pg (0x30305067) + %p4cl gP00 (0x67503030) + %p4cb 00Pg (0x30305067) + +Examples for a big-endian machine, given &(u32)0x67503030:: + + %p4ch gP00 (0x67503030) + %p4cn 00Pg (0x30305067) + %p4cl 00Pg (0x30305067) + %p4cb gP00 (0x67503030) + Rust ---- diff --git a/lib/vsprintf.c b/lib/vsprintf.c index 56fe96319..56511a994 100644 --- a/lib/vsprintf.c +++ b/lib/vsprintf.c @@ -1781,27 +1781,50 @@ char *fourcc_string(char *buf, char *end, const u32 *fourcc, char output[sizeof("0123 little-endian (0x01234567)")]; char *p = output; unsigned int i; + bool pixel_fmt = false; u32 orig, val; - if (fmt[1] != 'c' || fmt[2] != 'c') + if (fmt[1] != 'c') return error_string(buf, end, "(%p4?)", spec); if (check_pointer(&buf, end, fourcc, spec)) return buf; orig = get_unaligned(fourcc); - val = orig & ~BIT(31); + switch (fmt[2]) { + case 'h': + break; + case 'n': + orig = swab32(orig); + break; + case 'l': + orig = (__force u32)cpu_to_le32(orig); + break; + case 'b': + orig = (__force u32)cpu_to_be32(orig); + break; + case 'c': + /* Pixel formats are printed LSB-first */ + pixel_fmt = true; + break; + default: + return error_string(buf, end, "(%p4?)", spec); + } + + val = pixel_fmt ? swab32(orig & ~BIT(31)) : orig; for (i = 0; i < sizeof(u32); i++) { - unsigned char c = val >> (i * 8); + unsigned char c = val >> ((3 - i) * 8); /* Print non-control ASCII characters as-is, dot otherwise */ *p++ = isascii(c) && isprint(c) ? c : '.'; } - *p++ = ' '; - strcpy(p, orig & BIT(31) ? "big-endian" : "little-endian"); - p += strlen(p); + if (pixel_fmt) { + *p++ = ' '; + strcpy(p, orig & BIT(31) ? "big-endian" : "little-endian"); + p += strlen(p); + } *p++ = ' '; *p++ = '('; diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl index 7b28ad331..5595a0898 100755 --- a/scripts/checkpatch.pl +++ b/scripts/checkpatch.pl @@ -6904,7 +6904,7 @@ sub process { ($extension eq "f" && defined $qualifier && $qualifier !~ /^w/) || ($extension eq "4" && - defined $qualifier && $qualifier !~ /^cc/)) { + defined $qualifier && $qualifier !~ /^c[hnlbc]/)) { $bad_specifier = $specifier; last; } From patchwork Thu Mar 13 11:20:24 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Aditya Garg X-Patchwork-Id: 14014759 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 24326C282DE for ; Thu, 13 Mar 2025 11:20:37 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 94C7110E849; Thu, 13 Mar 2025 11:20:36 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=live.com header.i=@live.com header.b="LVOB1pKp"; dkim-atps=neutral Received: from PNYPR01CU001.outbound.protection.outlook.com (mail-centralindiaazolkn19010003.outbound.protection.outlook.com [52.103.68.3]) by gabe.freedesktop.org (Postfix) with ESMTPS id 9034E10E849 for ; Thu, 13 Mar 2025 11:20:35 +0000 (UTC) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=VAFCExGC/L9pUYGqtrYrGw0senoBiT+hCBmpdYXmbWEjmzKy8oXGalDs5qE3EG06DLJqqwtKjUEdDeQjxdBj30sFRr5SaTNnQVPhzk/UZt62q4xh6eXGWQFjQsgsM3gscY5sTlaDY00vSx14XXSrTuU4ocbfECXnEhSRuFBU8qLZXrCdO7a0nVqlxhxHWH67jH9wNioNpfUPpPYZPVlgOQ/L2hnFdJP9gfI5QV6Ze4oXJv6PO23zMuY+nSI01TCMYNI+Li/JkRL74SfFML5P+exrHkYAWWwlWd2vxE/i7n7IP6vdSyE1Sz5xGPQaIeB4e3DJcZ802Tyr59OlKKbGNg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=PWytK++w7efVge2S3HCDfNc7xFUv7xIt7O1G0q5iL4I=; b=pcwbR2hNILu4dSgSvHIkTd6eDmh2umPLwl3OJpGWIH6wzmUbLOpMisrs7KGEytLwtXEKmG+xoeps4qB+0RYI7AtPNT9W+bUOULhIzMGiGhxNoQTHfjRE6NVUGZy0iP9CejmZIyK+D/tXzEPTYIA7KOv2Iwp5cCw/GCTnaqg8At8IaugKQ2HtyVI3nf2ZDgzNPOleJV9s1yAEyULz1l3blYNo/VL8kR2NBH1Is8gNRLTrmC11yLwn0TYbgeX93EufW9BRBlQb0nTMMRxnQJWEJe40Asa8y2NzkloD3qr3KvNMau6EVPKo+8Ylrze976BbD19zcLnCZP7vNoufJ0edeg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=live.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=PWytK++w7efVge2S3HCDfNc7xFUv7xIt7O1G0q5iL4I=; b=LVOB1pKpK51+nYgMCPLF/iVQ9ptQ0/3n/710E3scm1+XbX0DUbLdJ8c0oI7rYACg6IY+u/83Uj+RG1RVkYnK0s6OpG6t61nE3Kjwu5n5BQY1pscuNuijMyCGqh0ZjCWMi9ezxwHf7vk7AkGNzuMCXn4sod9kswwWHaJG9MLB8k9zzS3drJi5IEw0RKFlWopyex3XMRfoHNyxqublyFa3dapQohIs+Wxs3JBA5+hjBKpKQ8pMTGSwuGuOxAp0XcvU8Z6uir0Z6h27duwWdNisy+Anke2sA/gRvFzuVwPqnIZAkeIAKkfx98+V4D1BO8Ezqxl4WbU4PYDjcwchhyQjbg== Received: from PN3PR01MB9597.INDPRD01.PROD.OUTLOOK.COM (2603:1096:c01:f7::14) by MA1PPFE52A1FAE5.INDPRD01.PROD.OUTLOOK.COM (2603:1096:a04::331) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8534.25; Thu, 13 Mar 2025 11:20:24 +0000 Received: from PN3PR01MB9597.INDPRD01.PROD.OUTLOOK.COM ([fe80::324:c085:10c8:4e77]) by PN3PR01MB9597.INDPRD01.PROD.OUTLOOK.COM ([fe80::324:c085:10c8:4e77%7]) with mapi id 15.20.8534.025; Thu, 13 Mar 2025 11:20:24 +0000 From: Aditya Garg To: Petr Mladek , "keescook@chromium.org" , Andy Shevchenko , Sven Peter , Thomas Zimmermann , Aun-Ali Zaidi , Maxime Ripard , "airlied@redhat.com" , Simona Vetter , Steven Rostedt , Rasmus Villemoes , Sergey Senozhatsky , Jonathan Corbet , Andrew Morton , "apw@canonical.com" , "joe@perches.com" , "dwaipayanray1@gmail.com" , "lukas.bulwahn@gmail.com" CC: Linux Kernel Mailing List , "dri-devel@lists.freedesktop.org" , "linux-doc@vger.kernel.org" , Hector Martin , Asahi Linux Mailing List Subject: [PATCH v2 2/2] drm/appletbdrm: use %p4cl instead of %p4cc Thread-Topic: [PATCH v2 2/2] drm/appletbdrm: use %p4cl instead of %p4cc Thread-Index: AQHblAnqlC9D7gQL3UuCo+FWtohJUg== Date: Thu, 13 Mar 2025 11:20:24 +0000 Message-ID: References: In-Reply-To: Accept-Language: en-IN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-exchange-messagesentrepresentingtype: 1 x-ms-publictraffictype: Email x-ms-traffictypediagnostic: PN3PR01MB9597:EE_|MA1PPFE52A1FAE5:EE_ x-ms-office365-filtering-correlation-id: 1aeb4397-93e0-4eeb-e6db-08dd62210c91 x-microsoft-antispam: BCL:0; ARA:14566002|461199028|19110799003|8062599003|8060799006|15080799006|7092599003|440099028|3412199025|12091999003|41001999003|102099032; x-microsoft-antispam-message-info: S+kcc90AozqBl2GOKBgtHnY8nYtP5bw3hmgIRz7RgiG2dAPROkolF9n92tK8gu19mcJDsymDvWTyhRnsCLYuH6HoTUrN5QHE14Gud3sADRfqU1jF9TKf990x3AT7dt63TSXyw4RMB9VxcJGHUJOkIpFHSygEGa6bjK10xsvqkXEg6xvE/g3AaHTykuvjEtNxIabz62dNUaK/EZoAMV6G3zmh0upJBUUtyz9WUSJkdJRnye7t2Z6IGTV0gPQZLjwQTXxrwtV8/wCQBUltdQZywcqqqtajFkQY7ruRfvcaqNkKtJXhp9vwXk2FmF3fSa7mQI17z786uPTnxhsX9tW5igqq5aSuc+UF4PhBqVxQlxAaY0DHtMXNwukadJToljm2j3orl6EYMn796ZkSgfrid/uXc/gd5vEllAYWjlxVNiegjXY58qr7TV3ne6DAuGupHDicJOYWvtoOob7laK4I68jFrNo79g2S+wVowmKZPk5qIYXEINpYdH8nWhMJZYPmBs47VMh/0RFbg1gZfzdxXUcTbQCxV5yd+azcK4xAnF5sMR7mg8MPh+BjIRZcg+1Qn9wOnsuh20WFLJ/XdKTlgGeLeMOz+yBWqXRMXEFj3XLFS66HRt38TCPEKbz0Z90o/O4jT1rZtQRW4yEppJ4uIA+Hgmg4HUtXY5pW85B5+60h8eHnShy9XiSviQpsberSuNRRWFDDTeWOuMhU1Kby1Cr43q/HGoeLZMULYbzJfAHtpVwxUlAEBRp94uRlRmIDZSxh1dKY1qjEnFn50YoLUENXCRGgZBjKCe+ilpqEBhJi83Pi+1TLi5caHZQd3hJ6/pkWtEW3VTzha4ZGB5oSiKNINq89WfrEyodi2z8u9kDtdLMNbF7EBh2UaBOyqMi1JhNwIV2UXQn5LhItex7POmH6pkzjEyGCtLUhn8kn4BBsvdJO9JfHivfJZebFEeKPKnRA0RoI7oQjn6j9Pr6eAXWYuBXmq9cWFw7ENqkR72k/D9nK6eN2xGF7myvHi6VnRVaJixo97IDniTDtSqfI+zdOd97fAPvm75KQyJvR7ci5UrBguQ0fbxrt+vpsbjE/nkPehi/vc/aA680K6vqfb69xevRold9Zq/WKyWBZTRtNVPylBfyesyVj/2CvnGqU x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: zfxSafilkAcBAjJXpsK9yAT/y5PwjRz/EeIs8rhfRyCYMvGJa1H570EHu509WWhR+b/gFL7Rob8U3nE7tEIcYupV5rj3BtQ916ukmJrpJALD+LYPK2+lHu6W6z+Md6UqTQHFdW45fsFUrYxwBk1vqJYRWswvvxx5c35nYcKEGpVAOHWDD0nODdrsYB6AAtW7GlchnAh0vYSVB+15y5d9VTTZbkfo9gfyx3GKGHtIoMguCKU6p1IenbeX1o/FHDkLxBz2CqdkIeG6y9+sDXMUAePJMqoZBdgowNWD97qDBzbZwSkPjdpZm1GekZw4OVcqFsSUG0ViqudTBup6EFlvv+ZfQFjHdDqCXHfTow8GZfMFm361jBZsaIYe5HHAoMvvTWQL/oFtDzEtSAmXxlFWurt15YbTcNeeD8lY2GY6slbkn4AN+4lIWiCEoRSLmNvRKysoCMi50W7bCusB0XvT2e1lNdSaDKkt98+5Npf6ELdpt5lKCh53oc6hn7xhlhbTWGQeXYe7Nlx0+3dZO2q11MbApvmrHfa2AbfaevoT3MHO3c143GteYIth3sqPx5MQVFElB6Ovc6Gc5Wu4qWVwe96TeEkfqY1NBhraNx+fMm7iE2nwG0NHOZPBtt+jEBlUGPxCmjRafVZsrzGys0zH9Gnib5z5EsqWHqLA4Tyc0OcgVpAVJejdIDr2/QqKw2oxnvTOwnlBjG/Twp5/Z5yW/qbUMKMFQz6D2x7gJDNVZBqXjidEgo6nX2icqpwB2YraQhRAnekL/6PITY6QZP1ha/HIoVYOkn55VEWXp8OCyHmHSGSCEtwWQqfFzXh7ME4IzL5oqIpeGUa0h0egQvHAjsMIc2GIE4D86bZDGoy0xgBE7udumV2xZsHVbwzf9xecsS5Yh2xEr+nTlVHdP704gQKEn5xpOouz6v+wlFQihDQ5lDb15iS/p4Is8rklrYN29Az1A2sY9fVCGQfZezHSztic/ZDjoK9UHVtODwBxvVj849y5UTwx/tw8WyFqeyN2hlBi11LZadwhJCn/ehk7wXHfvLweyeDewrRnmJ0ea4KIiaMnn6GNmlg9t6r3FVIfK36LiHA/9iv5Z/hSKJWz/bRmMRPeMGo1fPBm2x97mp71OMn5PxI/1OxOqSUA5dF9n9SagK5d/WAFpX9yk9Yvs9/ToN05S+S+KIbpGg6iRA/G5aVkqLHTUxtLS1i7dvgQH5+QPzbzuKWewuKvaqgrszrkjrsWlkAmrReLbiQSq+DQgo1olEOk2ybCooxtKCxVyiIN5gxh7+3env8B/LOYOhojQUboRjh+m/Esoj3PWs3bItPrbvjs4lb4MHrCumaV Content-ID: <68094B59B1007749B5316D61992F3EB1@INDPRD01.PROD.OUTLOOK.COM> MIME-Version: 1.0 X-OriginatorOrg: sct-15-20-7719-20-msonline-outlook-ae5c4.templateTenant X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: PN3PR01MB9597.INDPRD01.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-CrossTenant-Network-Message-Id: 1aeb4397-93e0-4eeb-e6db-08dd62210c91 X-MS-Exchange-CrossTenant-originalarrivaltime: 13 Mar 2025 11:20:24.0603 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-rms-persistedconsumerorg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: MA1PPFE52A1FAE5 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" From: Aditya Garg Due to lack of a proper printk format, %p4cc was being used instead of %p4cl for the purpose of printing FourCCs. But the disadvange was that they were being printed in a reverse order. %p4cl should correct this issue. Signed-off-by: Aditya Garg --- drivers/gpu/drm/tiny/appletbdrm.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/tiny/appletbdrm.c b/drivers/gpu/drm/tiny/appletbdrm.c index 703b9a41a..751b05753 100644 --- a/drivers/gpu/drm/tiny/appletbdrm.c +++ b/drivers/gpu/drm/tiny/appletbdrm.c @@ -212,7 +212,7 @@ static int appletbdrm_read_response(struct appletbdrm_device *adev, } if (response->msg != expected_response) { - drm_err(drm, "Unexpected response from device (expected %p4cc found %p4cc)\n", + drm_err(drm, "Unexpected response from device (expected %p4cl found %p4cl)\n", &expected_response, &response->msg); return -EIO; } @@ -286,7 +286,7 @@ static int appletbdrm_get_information(struct appletbdrm_device *adev) } if (pixel_format != APPLETBDRM_PIXEL_FORMAT) { - drm_err(drm, "Encountered unknown pixel format (%p4cc)\n", &pixel_format); + drm_err(drm, "Encountered unknown pixel format (%p4cl)\n", &pixel_format); ret = -EINVAL; goto free_info; }