From patchwork Thu Mar 13 16:35:37 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Rodrigo Vivi X-Patchwork-Id: 14015418 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C398BC282EC for ; Thu, 13 Mar 2025 16:35:50 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 3089A10E8EF; Thu, 13 Mar 2025 16:35:50 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=intel.com header.i=@intel.com header.b="BwWg2O6J"; dkim-atps=neutral Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.16]) by gabe.freedesktop.org (Postfix) with ESMTPS id E89A410E8E9; Thu, 13 Mar 2025 16:35:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1741883749; x=1773419749; h=date:from:to:cc:subject:message-id: content-transfer-encoding:mime-version; bh=w+iU6yuh8nOFCfVg+v+H5LjlqLVwLA7DMWwRMVz2eiE=; b=BwWg2O6JYyHpI/+a5gDFlglGvS3U/UETIjsdpW+QAZQI5aYAYijxcljn O3bZEv+4+nBP4pZRHNH6JlbIT3C8CNN5t1NuIglKxZP6vNwU1DVp9O6gf U7S+yjS8BrAsQjQ61pg04UrZljl4J9TwYd2SL5H1Nbda4rf3Axv2aAIIv Up7jO2WzCsyYdrjqP97xxo8QNTFE1s2g+N4cXH86JNYnIjZlK1WqnOyrq lxm7ekgJhuiA6/sg65nSscn+jmSA76RvsRkJzW954WF1oaQLCRPFQDAmh kQqBa9YhzD4q1G9DTClj6uIt5AODIrTf8NRd2YBWz2Pmp5EQ6bCZEZuOU g==; X-CSE-ConnectionGUID: 801Q2nY4RCu483TUeOKU5w== X-CSE-MsgGUID: +dMR1nm7QPyigDtqoWjPqw== X-IronPort-AV: E=McAfee;i="6700,10204,11372"; a="30604862" X-IronPort-AV: E=Sophos;i="6.14,245,1736841600"; d="scan'208";a="30604862" Received: from orviesa002.jf.intel.com ([10.64.159.142]) by fmvoesa110.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 Mar 2025 09:35:48 -0700 X-CSE-ConnectionGUID: AxSACT44RliTk630MNpudg== X-CSE-MsgGUID: p2KrXdexTMyo+HqUqiZ1VQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.14,245,1736841600"; d="scan'208";a="151864985" Received: from orsmsx601.amr.corp.intel.com ([10.22.229.14]) by orviesa002.jf.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 13 Mar 2025 09:35:46 -0700 Received: from ORSMSX901.amr.corp.intel.com (10.22.229.23) by ORSMSX601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.44; Thu, 13 Mar 2025 09:35:45 -0700 Received: from orsedg603.ED.cps.intel.com (10.7.248.4) by ORSMSX901.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.14 via Frontend Transport; Thu, 13 Mar 2025 09:35:45 -0700 Received: from NAM10-DM6-obe.outbound.protection.outlook.com (104.47.58.42) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.44; Thu, 13 Mar 2025 09:35:45 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=qkH5t4Xm+dhDUXJZTDZitQxtYCOZ7JZfeshlepDUMZPal/HgkzR0g5rGT0rUt7jNsufYO5cVmsOJAlSpq5S6JpDPA2iS/Vi2emBnTeIl37E31oAi/TfFxv2sxB2HRSKToeNrkglaJMtWgzA5ZzdMNYk/6+4KOK8A4MpVqcYLaYA2eRc2UuDdih8cZJdwCZWpGewGKfa49KPw0Cj9+TNcp+PsUcZET2tx0EAGIHvmzXkOwzRilivRJ5TilXG+r8LSeFqrzjXbX30MBzAHNgAqzbXARjDdblUGUKLlDhf/6hu8xDiHrHr1ygwfe69cYvvuzqxGYbZogRDaNb7cCgSE/A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=lqSkVw5PVGfFnTIiv+LjzfRbqyExRDSidL2FgHXKLCA=; b=drhjOegAZ4X+u6GY5WCa/W45PoBt++kCMOuGo2B5ougqGa4hqXBHELjNSbCU6jbfvy9sQvsx7yXIurg1qj4fV9mtgbTKlZgtW0B7J1R9Bxphuy/Z8MKsShQY8LBZjHfjFUlwntPaKXlzG0ZZquuBUixGLEN0zjm4gVR1b7zmtY+tv3eR6jiQaoigb5SLbsuv1E0PUSizBAvHZGemRmruja/orfPofN4/ewI1/0V+e1W4EIn4Ff7csAFKGCwG/IvsCzR2oYYzbnvSd1uK++iG3wEh0NRD5Uq8PQ18aSEYwrypbXr3uTt2+h4pGYGIDq4tlfEKyn0e/uN6onfRxy/X2g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from CYYPR11MB8430.namprd11.prod.outlook.com (2603:10b6:930:c6::19) by PH7PR11MB7075.namprd11.prod.outlook.com (2603:10b6:510:20e::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8534.28; Thu, 13 Mar 2025 16:35:43 +0000 Received: from CYYPR11MB8430.namprd11.prod.outlook.com ([fe80::76d2:8036:2c6b:7563]) by CYYPR11MB8430.namprd11.prod.outlook.com ([fe80::76d2:8036:2c6b:7563%4]) with mapi id 15.20.8511.026; Thu, 13 Mar 2025 16:35:43 +0000 Date: Thu, 13 Mar 2025 12:35:37 -0400 From: Rodrigo Vivi To: Dave Airlie , Simona Vetter CC: Jani Nikula , Joonas Lahtinen , Tvrtko Ursulin , Rodrigo Vivi , Thomas Zimmermann , Maarten Lankhorst , Maxime Ripard , Thomas =?iso-8859-1?q?Hellstr=F6m?= , Oded Gabbay , "Lucas De Marchi" , , , , Subject: [PULL] drm-xe-fixes Message-ID: Content-Disposition: inline X-ClientProxiedBy: MW4PR03CA0154.namprd03.prod.outlook.com (2603:10b6:303:8d::9) To CYYPR11MB8430.namprd11.prod.outlook.com (2603:10b6:930:c6::19) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CYYPR11MB8430:EE_|PH7PR11MB7075:EE_ X-MS-Office365-Filtering-Correlation-Id: 0f20cb35-ab2e-4e4f-b567-08dd624d192e X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|366016|376014|7416014; X-Microsoft-Antispam-Message-Info: =?iso-8859-1?q?n96cSgpcQJmfqwyFo0WciNauaq?= =?iso-8859-1?q?B8G6sFnXBKe8emAGWXB7kM5ohSzmuW9Y6aCuZbbLA5yuBzXbFSw7vLnEvSRq?= =?iso-8859-1?q?Y2KVVkwSgZInpQ3AlkoHJv8YU8Wzc5v5RP+I91cG7PCp8J3GuplWAbF1rJ7k?= =?iso-8859-1?q?cSR2oGdGd9uQ5j83MKVIlYA90/qykioKWr30w2o/t0o1714cpkEIH3JQkck9?= =?iso-8859-1?q?otZWUfRtFdhqKvgSFIS/qRBrmYPrSRKOtu9K5NGtkjzjS/V45LeAYlebuqsl?= =?iso-8859-1?q?0mEWoojYv9lkAIkm2qkv2DF+OmlFnfKAxbR4BDsF+g4A+dmObsjv4qjyvjcP?= =?iso-8859-1?q?AbPS/8idZoOFiufYjIdWnpuhpwHhn82m9/5AaM+dNWJ8GEAsck/+yNPj33za?= =?iso-8859-1?q?aIF4Sjlo/x7SmPMlJERbFi20W7ELue7xPRp4xFh4tkUmf6CKKzzCcAqJLMPm?= =?iso-8859-1?q?wGFCsPEHsrG3GduUyac2jTXpfEiDQEYKlUa6D/6X7YKPUWuQO3e5Zkf1yRBn?= =?iso-8859-1?q?1WVOHe2rNVT1DYjaLe5BC+uPurVTjq0g5Y9MURYNsnT5ICFEPHwq7oDaGpYF?= =?iso-8859-1?q?Os6nODbQm3fRCGnZGZNzy/whwblx6R/a49jW6ZlEC8DBHH6s37mxrLgbVXZ1?= =?iso-8859-1?q?Tf0/3j1ygRNoILVRlAnx+noTIo4KnQb3aPVmzqzlct21Ds/QQAYrZ6czp1wh?= =?iso-8859-1?q?81wLCw5lODkra1w9SprPcaBrmLOhkqtijUuVi+NwU04LOhSAIeYsoKLO81xL?= =?iso-8859-1?q?oAXGnDjrPJiIDuw14ERI7snqBNCOrSQ/6R+9TOTnYlGPEVj/M/9OlfX0Otw+?= =?iso-8859-1?q?2f0a/KbUWY6c3DakpkJ0gpiflXq3jMXkhSRgIv+TwwEpg4FwbED7xtONL8GE?= =?iso-8859-1?q?uNrwpnZen96LeurGoM6eP8KZwoF7b+bdVoc9Sq21I0KR7XBGOz2A5R3LQ2cp?= =?iso-8859-1?q?xNQB6UtExUSQ/oOmhbTmPZdGS7wQLd65wuhs9d1HGRCnzKK7MsxrqxsG+wqZ?= =?iso-8859-1?q?CLXTO/pW6s8F6Utq8lRImlakaxaoyZ35Q1mWC4LMCoSxhq7DkdHga2a7uS8K?= =?iso-8859-1?q?KQcsbHiSDUgfExaP7wkH9lBFe//7wHTbx2FspQR+EzYW+Sle0TDl+ZKF14Ij?= =?iso-8859-1?q?KeMfTbXl+CgguzCvwIrE1nDRxeyTDXfd0J9HelZVWFEykx9FUqV5AoPoR3JO?= =?iso-8859-1?q?GKL/xwR6BgG1ocaYNiFPblqfzWQ6joikdIkWqZh5zlSDBXRLT+9VCJ7wiUfn?= =?iso-8859-1?q?ABWVHqVvlM5JLpR4CnvSO8hLaki5tNxLRkSCegmE7Q441ocOa5tAqDATGc1u?= =?iso-8859-1?q?slueo9qKW1yp2OlmZM4Yg7QxbWmIrM8jKkuIwo/8U5m0bhCjvCh9hMRoo2?= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CYYPR11MB8430.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(1800799024)(366016)(376014)(7416014); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?iso-8859-1?q?zHfXgVS4WUlokA2z0qX+mAj?= =?iso-8859-1?q?7e6sWF7pr9wv6kbmjJf5eEAbwoKgpJiTchFzVauGfsKLkzf6WJU6oTMh0be8?= =?iso-8859-1?q?zd31AW/9gb1l8Ljm4nLIa6yjGehOFVORQ3bP4/+Lr2b8IFGr1PsJvihP7lxF?= =?iso-8859-1?q?ckxLCgKWRahDwwdWpnuldP3hUUJ+zJ9N5SsdYsam8sDGGdDYNSSUWZH98kD+?= =?iso-8859-1?q?O1BEMhNVUSDljo+z0IXXveSlzbfKTqFx33bikG1HNEqmTQBjngGy9Ao6ypPO?= =?iso-8859-1?q?tEeH/wvDjjdpWrXVns+SmhIeoFt5bzsKgHO7w7NWQjZMB34Q+8M4Fpytk/nk?= =?iso-8859-1?q?9XljQ7Xj4bHwbJ3sRXwwV43ZVQTyaLmeJ2HmUoLGzWYnyTcpd7rwr/WvtrOe?= =?iso-8859-1?q?wgy9zHbkJ5kuze3xYzFe3ALlFGkaTltza0w1DbCi9payYBYCLXYxJLBilBV9?= =?iso-8859-1?q?FJ7kDh+67tKRt2JburrpOkzFW9MYZvXXNEP3i4zEoGx5gOVe+x8L6IZ+eT+9?= =?iso-8859-1?q?9P9R14R9a1gtcWTBANOeYKluzHexSAMNpRYjSeTjWJkhUCqMq8oOv1SDThhr?= =?iso-8859-1?q?DSJVRp80LfbL9+SuGIgxD0UDZsydoHBaywlKN6Yp6iS3VDSFLaPjzsmhscL4?= =?iso-8859-1?q?t286VXbEhG98YYjq2lGpbo+bTpBHaFWW+qm+cPJnP3Zm8mjzUpe9U2T76BjT?= =?iso-8859-1?q?MuKFEjx5T7RmkxKPhpo9wyWkM9MWIt8V3Dgy8O5MQvy+SXcFUa3pul+/NFNh?= =?iso-8859-1?q?88GNjSnuDNMlyV0hnZp1nObKGx2zuH74ilNcbUJHqLrWTl/7a+3f+XPgovqF?= =?iso-8859-1?q?333TGpoGYUAqzhT9Pb2p44k/5cYvmhcAySyExxc8mEtAxp7uHB2qfRJLjcfU?= =?iso-8859-1?q?NIUyzYI6gAs+le0iq9ETMZj6Bdk1OLA1JJkgp6JIo07THjZD0kjWmISKQh0Q?= =?iso-8859-1?q?jS3FdBhIxaUN2yBxTLVrOba5+y74Fe/TeLdY7amva36R9H7rIf3Rr17xKCmx?= =?iso-8859-1?q?HMcZj3BDp11+tpT5xAP4u37/+07TYFSXoDuixj3kqs48M6fK1NwNLwu30DKW?= =?iso-8859-1?q?UX/pwNt7tAKLgCyAFrUKx5h/ZUIQqGsG4aOVklAvzG6krc9Ww1ho2iu2XYTt?= =?iso-8859-1?q?h4Gza2Am3dA8eN7fa60e7V4/fwZ0j/Z+yA8nAY645KNeR4uJwsnTlrK5/uhC?= =?iso-8859-1?q?taGE2LcRr362O0e+u8ttys/rc1d1hgJEm4NahyTTr5y/mEaDRAsNHxRIkEzn?= =?iso-8859-1?q?nWdDeB/fa88DXwWcZkW0or0wCk5cwtaogIpJ2cEchCly4ld1R6IJs21QOF3X?= =?iso-8859-1?q?Bno9lzcKmawGjMiI/ryhZkk9t/02Saw5z6LhIteKTFjkFRWsG4TReTBxVcu4?= =?iso-8859-1?q?ttxN85Swe73xcSN1xahzXahob+0FO3p7OfIDN2OII2m5u6kyMaBFaOZjux7y?= =?iso-8859-1?q?WFm1zzQ82KoQkawb5cScUnWZyo2L0wt4cNU8yTPH0lBUMFBgvRhzP1XSJ6Da?= =?iso-8859-1?q?G5CVYjUaj9Vap5TkpgkCoOpuOrlt53NNz6E0h5jOjvUeXq8QpEjhKWRG8JHU?= =?iso-8859-1?q?mDhU+boiXuNwedm2rjomfN5kYrXG4LUCN6/i9OmO1dvAKPp1h65ph8Qr8P7y?= =?iso-8859-1?q?YFWeeHuth4C0O3L9G0Z5Xi+zkJD9xaBsWai5T4A=3D=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: 0f20cb35-ab2e-4e4f-b567-08dd624d192e X-MS-Exchange-CrossTenant-AuthSource: CYYPR11MB8430.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Mar 2025 16:35:43.3157 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: rsAA2Z1RsMXoxm/ugYnz9D7jBeJnaCh9MBHFmZayEBECqfkI2fqGq/aM33mPfwgRVAPWeWGByFnOZYMVyER3+w== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR11MB7075 X-OriginatorOrg: intel.com X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" Hi Dave and Sima, Here goes xe fixes for this week. It is worth mention that we are disabling D3Cold on BMG because we found some bugs where depending on the combination of BMG card and the host, the PCI upstream port link port re-training might fail on D3Cold -> D0 blowing things up. But while we work with that and propagating this protection to the end users, we are not disabling in our drm-tip to ensure that our developers and CI can continue working with D3Cold enabled. Everything we disable behind flags for developers will likely be forgotten and regressions will pile up and be harder later to re-enable it. So, topic/xe-for-CI re-enables D3Cold. If developers ends up having a bad combination they can workaround it by boot parameter pcie_port_pm=off or with echo 0 > /sys/bus/pci/devices//vram_d3cold_threshold Also, the topic branch solution helps us to avoid adding the controversial module parameters. But if there's any concern or issues with this approach, please let me know. Thanks, Rodrigo. drm-xe-fixes-2025-03-13: - Release guc ids before cancelling work (Tejas) - Fix new warnings around userptr (Thomas) - Temporaritly disable D3Cold on BMG (Rodrigo) - Retry and wait longer for GuC PC to start (Rodrigo) - Remove redundant check in xe_vm_create_ioctl (Xin) The following changes since commit 80e54e84911a923c40d7bee33a34c1b4be148d7a: Linux 6.14-rc6 (2025-03-09 13:45:25 -1000) are available in the Git repository at: https://gitlab.freedesktop.org/drm/xe/kernel.git tags/drm-xe-fixes-2025-03-13 for you to fetch changes up to f5d4e81774c42d9c2ea3980e570f3330ff2ed5d2: drm/xe: remove redundant check in xe_vm_create_ioctl() (2025-03-10 14:01:43 -0400) ---------------------------------------------------------------- - Release guc ids before cancelling work (Tejas) - Fix new warnings around userptr (Thomas) - Temporaritly disable D3Cold on BMG (Rodrigo) - Retry and wait longer for GuC PC to start (Rodrigo) - Remove redundant check in xe_vm_create_ioctl (Xin) ---------------------------------------------------------------- Rodrigo Vivi (2): drm/xe/pm: Temporarily disable D3Cold on BMG drm/xe/guc_pc: Retry and wait longer for GuC PC start Tejas Upadhyay (1): drm/xe: Release guc ids before cancelling work Thomas Hellström (1): drm/xe/userptr: Fix an incorrect assert Xin Wang (1): drm/xe: remove redundant check in xe_vm_create_ioctl() drivers/gpu/drm/xe/xe_guc_pc.c | 53 ++++++++++++++++++++++++++++---------- drivers/gpu/drm/xe/xe_guc_submit.c | 2 +- drivers/gpu/drm/xe/xe_hmm.c | 6 ++++- drivers/gpu/drm/xe/xe_pm.c | 13 +++++++++- drivers/gpu/drm/xe/xe_vm.c | 3 --- 5 files changed, 58 insertions(+), 19 deletions(-)