From patchwork Fri Mar 14 03:33:50 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Zhongkun He X-Patchwork-Id: 14016179 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8AAE9C282DE for ; Fri, 14 Mar 2025 03:34:05 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 04F08280003; Thu, 13 Mar 2025 23:34:04 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id F4016280001; Thu, 13 Mar 2025 23:34:03 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E09EB280003; Thu, 13 Mar 2025 23:34:03 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id C4D70280001 for ; Thu, 13 Mar 2025 23:34:03 -0400 (EDT) Received: from smtpin03.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 5AC821C8F71 for ; Fri, 14 Mar 2025 03:34:04 +0000 (UTC) X-FDA: 83218738008.03.A848158 Received: from mail-pl1-f181.google.com (mail-pl1-f181.google.com [209.85.214.181]) by imf05.hostedemail.com (Postfix) with ESMTP id A257E100005 for ; Fri, 14 Mar 2025 03:34:01 +0000 (UTC) Authentication-Results: imf05.hostedemail.com; dkim=pass header.d=bytedance.com header.s=google header.b=Qea4ksrk; dmarc=pass (policy=quarantine) header.from=bytedance.com; spf=pass (imf05.hostedemail.com: domain of hezhongkun.hzk@bytedance.com designates 209.85.214.181 as permitted sender) smtp.mailfrom=hezhongkun.hzk@bytedance.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1741923242; a=rsa-sha256; cv=none; b=I/unuofV0YmRnags3MIxUh0rU3ppYdHr3eQxdJM+Llw50q5tEBe79uv7ycS7HvpDwrKpiX At9ONislG331GjGLbfMlHozb4Y6daOl6yyLiExdz3XVr/Ss1GTycYX4RCUJ9aKrZ/66dAp fqj1LkQb0h68cfjblo2HVO/rJzCNX84= ARC-Authentication-Results: i=1; imf05.hostedemail.com; dkim=pass header.d=bytedance.com header.s=google header.b=Qea4ksrk; dmarc=pass (policy=quarantine) header.from=bytedance.com; spf=pass (imf05.hostedemail.com: domain of hezhongkun.hzk@bytedance.com designates 209.85.214.181 as permitted sender) smtp.mailfrom=hezhongkun.hzk@bytedance.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1741923242; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:references:dkim-signature; bh=IzLcC8Eyie0MxthBF09QbNl/508C79rEY+M+4zhfqEc=; b=p2xYIOAoOzQdUN0ojEpr4+4K2zrwj2ZS/PTxr4V5l4tneYlFh5q9qtGV4kVpYt0BX9PqNp aGwurMGBHwIq7ntBXPqZZJ9mSQy1SwaEQhFBWd4gk2YWD5OH6fjusS2NMzMmjETWILMT7v 3iCGwOhkGAUU+Rcco/Sb29vgj8a1R5k= Received: by mail-pl1-f181.google.com with SMTP id d9443c01a7336-22423adf751so26787135ad.2 for ; Thu, 13 Mar 2025 20:34:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytedance.com; s=google; t=1741923240; x=1742528040; darn=kvack.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=IzLcC8Eyie0MxthBF09QbNl/508C79rEY+M+4zhfqEc=; b=Qea4ksrk2KN6EmH+Yoe7y3Gh9aLJm0QdKPlsTFnX2HJtIknNr05op04Tt0Li20QM1q T4JfAhO3yAySwOaKVbHu71bpdfnYGmh15/ZM0zsyNEH+ibIfMmTi2qtuA7GN247Lydom vdOjdz3XCY4SupUABuaf6E7GjtT5jd6t5jaszQ/BQI+HiUNgyRsbDXmIglS2r1beM+Xm H/rv9HBrB4YII8Z8CMHXmlmQv1YAg086OW50gi471QaGX2P7SBZY5RTFSJfMz8PPKS+6 k9HECOBY7gvQiBKc6UVYF8ON62dgPeG/+6a4Woe7IAFoeRDmVFq6FMpRrWdSv+9TNPAJ 23TQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1741923240; x=1742528040; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=IzLcC8Eyie0MxthBF09QbNl/508C79rEY+M+4zhfqEc=; b=SZZ5Xw6rZxhB1rZFsVlVwtRlzOVlIJt93AF37MqknOS8URQDL89BLLqnvfDK/FZNiC 173djJn9TWceJBxgggS5rD6ooaDcjRQJkK8yw00pO7y/5mmrhhtin84jGkXFfXVlxMGm WbFojPttRVpJV/PpeXV7cbBPRCfEQEOMlKHcjWgoQWVit8nXxZqCtUl8k6LMu1FPNRaz emF3ZCNxEJ4BHCES5xMEQLzlvBpgneQrVYUvQPVUs/sYse+3MSSoHkxfLgFIae2l4Q8n JdjAT3KPrlW9XQ3utEKIKb4qQ+ulJDm4uJg/Xz85GlWh40fDY6h/fF5b4HASk4Nm77JX dZKA== X-Forwarded-Encrypted: i=1; AJvYcCUiNPRGEpQMgdDN39fSjvaNrrCnjviC+0YHlG3CckE8tuH6R4sBx0KppBVpTC5p+5DUmF2Yoaebdw==@kvack.org X-Gm-Message-State: AOJu0YxCDIWN2k2rC5SbSi5BBXNjj3qRiF5Fs7JqYy+z5sIeCKaNbs9M Dk2QZZKzPcRF7dGDyY7TfhZoSrxqkONN4azsIHUkNdaFZ4VTVmsAm3iM5jp8EcRWIsuzcI3cQYV C X-Gm-Gg: ASbGncvqr8lHw6TjkwdEXhM9P9NBe96liwkibZq/0m0Ut/r/f/iGhwBu3G1bmnm7yFx flTmgtJmN0w5HX+zQuMMK8nN71eOfShTK5svhjLjTUTx/BqVpUsXKibRGfSvCE1yqaXfVBibuy2 1gEll483oqx4sGM9PHos2p/t4QEsRhKYiKkIIDQxwyTtaj4+NLoTsWy4qPFQs1IVnt0dV2C1wxd 4sHrLj17qyR6ws1C6NKJA5nBeLggZonJWbnMZPzk449iaSgFODRW2HUBlqBoDQ9VH33RUmMcv4Q 8eKtMCrrjKre6HHT04FXOHEXMKHlqKN9VcfCoyZnyRBUiyJen6tc8v9OuF19ESkRT9/9JQ== X-Google-Smtp-Source: AGHT+IHkTtLpiPRh154rWR23c7s/Wqh+tHJT7UX/rACxgzWzyRfgJ2LXZqS2mjILyRieWR053xia7g== X-Received: by 2002:a17:902:e802:b0:216:3466:7414 with SMTP id d9443c01a7336-225e0b094dcmr14270625ad.44.1741923240169; Thu, 13 Mar 2025 20:34:00 -0700 (PDT) Received: from n37-069-081.byted.org ([115.190.40.12]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-225c6bbed72sm21295845ad.197.2025.03.13.20.33.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 13 Mar 2025 20:33:59 -0700 (PDT) From: Zhongkun He To: akpm@linux-foundation.org Cc: mhocko@suse.com, hannes@cmpxchg.org, muchun.song@linux.dev, yosry.ahmed@linux.dev, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Zhongkun He Subject: [PATCH V2] mm: vmscan: skip the file folios in proactive reclaim if swappiness is MAX Date: Fri, 14 Mar 2025 11:33:50 +0800 Message-Id: <20250314033350.1156370-1-hezhongkun.hzk@bytedance.com> X-Mailer: git-send-email 2.39.5 MIME-Version: 1.0 X-Rspamd-Server: rspam07 X-Rspam-User: X-Stat-Signature: s3mq4mbij83urd83un8655bkjzjcfebp X-Rspamd-Queue-Id: A257E100005 X-HE-Tag: 1741923241-330100 X-HE-Meta: U2FsdGVkX18KJVSNrgGOQLjo1DByDD5rMFlBN/fQ0FU6/fEDgin++9QFn+cThlH6oveVz2leJgdOwHU1ksCF2EhVfaY51Ux7zL/QCT0CNMCfrHMotYl7O89ygSy3KAwXNfaHf1tF9w64IVzAqvL5Wk7RXm69D5NcjN2+DExwAAEXBjYrVBP/KsgPEG26GnWcLIjtZ4USpZgVaE/oT1hrvro1Dr8Vux+hdhpaBGbFFme4St0xcp4cs/35/8vFXcnxsUO2SqNAbMeU9c2K9DmHLiMDNf8JHZ3TBYm6yvCwcJQEK/N+zDshyQC8ix3AgBw31EGWlQAA5MYGBxp1r5vnGAjE2adNvLXaxmIbDDTuk5Tk90qhOsCWjD1VeBvdNl3idp5OezuQp1JcS8NKIK/dSxO1+/+dQpXgIoGfYqBruEsZVlQwtip0jUNeHCOH1pZ9dVqu2eqYXVjdNJeWHpdzN/vLgUf4LgPKpA9uqVFZ0OScUxzB039ATKw8SQq0Ffvp5zReKp+6Ncsw6PdBCJ5ns0JgKh+cfTm8nehKhq7hZfmgNnbSICBkrJ+9Qyqr0ACPHa7TYNKmQgvCMHhjVBfI1c30Z/LDSfFEqjYrBL9a7rg4TlAOsO/QpeWBcCFpxUTnkZXCFFqNGKSYt+wsqt5SV8fCKpifY2nLgFQXdzZDd7PEsBQq69Q1hpa8qPf1xvdGFDbOaZEAYygrS+4Yw8rmM+Jf3h9e6K3RhtpW2xFTxDKMXZzHtKaQHg44iORENFqw1chCDp2ihYG5mf9krL3McaqEWSYjBaL1GGQXZBjaNFEGmdSDKc+vADtTRjJKQsyZhtH2TdL0W7cqjUGNyua8htZXf3iXDKcxXkkiSN5xB17Re4Iufup3HLnjq/3i/psccGcIew/eOLsROdUvJlqsWT3JDW+C839QsYh/bSpmiYhbrprtOoqPSOubvwxhmaMLiucbVEKwZU80fUMBB6k xyJ1iMJz USegrK7qsUDpMA0+iKOr5nPy3NPrYGDmJGf+o4kHYQ2kXK2JFMTCtprI8sxwbTL4qbbP2+ZxbJC4AS156axhmZkXEVA8mJm/78pwwjYw3GywYPCyBK5sU/HghsB8YojQAWUIGR8VJu74ht8xxR/YbilnhTwhmJQUBkDFHa4oGfPAIeQm7nl47zdetC4uyGwaLqTvik28oScp9gxSSl3siuVgCMiQ2Y2nRr6UXkmHpxPBYRk8S/ftrPFMOjj91ExcbWG8tUxlbxRrTYlk6IkyTQUeFAhDj+qdeElfGVQDv5hTtm2jPr8y9eew8yVIAujojtcM7JfmYsZ3ckDUg3fBhiIvRqt9Q3HD/ElTU37TyW+qW4ok= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: With this patch 'commit <68cd9050d871> ("mm: add swappiness= arg to memory.reclaim")', we can submit an additional swappiness= argument to memory.reclaim. It is very useful because we can dynamically adjust the reclamation ratio based on the anonymous folios and file folios of each cgroup. For example,when swappiness is set to 0, we only reclaim from file folios. However,we have also encountered a new issue: when swappiness is set to the MAX_SWAPPINESS, it may still only reclaim file folios. This is due to the knob of cache_trim_mode, which depends solely on the ratio of inactive folios, regardless of whether there are a large number of cold folios in anonymous folio list. So, we hope to add a new control logic where proactive memory reclaim only reclaims from anonymous folios when swappiness is set to MAX_SWAPPINESS. For example, something like this: echo "2M swappiness=200" > /sys/fs/cgroup/memory.reclaim will perform reclaim on the rootcg with a swappiness setting of 200 (max swappiness) regardless of the file folios. Users have a more comprehensive view of the application's memory distribution because there are many metrics available. For example, if we find that a certain cgroup has a large number of inactive anon folios, we can reclaim only those and skip file folios, because with the zram/zswap, the IO tradeoff that cache_trim_mode is making doesn't hold - file refaults will cause IO, whereas anon decompression will not. With this patch, the swappiness argument of memory.reclaim has a more precise semantics: 0 means reclaiming only from file pages, while 200 means reclaiming just from anonymous pages. V1: Update Documentation/admin-guide/cgroup-v2.rst --from Andrew Morton Add more descriptions in the comment. --from Johannes Weiner V2: Add reviewed from Yosry Ahmed. Signed-off-by: Zhongkun He Reviewed-by: Yosry Ahmed Acked-by: Johannes Weiner Acked-by: Muchun Song --- Documentation/admin-guide/cgroup-v2.rst | 4 ++++ mm/vmscan.c | 10 ++++++++++ 2 files changed, 14 insertions(+) diff --git a/Documentation/admin-guide/cgroup-v2.rst b/Documentation/admin-guide/cgroup-v2.rst index cb1b4e759b7e..6a4487ead7e0 100644 --- a/Documentation/admin-guide/cgroup-v2.rst +++ b/Documentation/admin-guide/cgroup-v2.rst @@ -1343,6 +1343,10 @@ The following nested keys are defined. same semantics as vm.swappiness applied to memcg reclaim with all the existing limitations and potential future extensions. + The swappiness have the range [0, 200], 0 means reclaiming only + from file folios, 200 (MAX_SWAPPINESS) means reclaiming just from + anonymous folios. + memory.peak A read-write single value file which exists on non-root cgroups. diff --git a/mm/vmscan.c b/mm/vmscan.c index c767d71c43d7..f4312b41e0e0 100644 --- a/mm/vmscan.c +++ b/mm/vmscan.c @@ -2438,6 +2438,16 @@ static void get_scan_count(struct lruvec *lruvec, struct scan_control *sc, goto out; } + /* + * Do not bother scanning file folios if the memory reclaim + * invoked by userspace through memory.reclaim and the + * swappiness is MAX_SWAPPINESS. + */ + if (sc->proactive && (swappiness == MAX_SWAPPINESS)) { + scan_balance = SCAN_ANON; + goto out; + } + /* * Do not apply any pressure balancing cleverness when the * system is close to OOM, scan both anon and file equally