From patchwork Sat Mar 15 06:12:49 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: xie.ludan@zte.com.cn X-Patchwork-Id: 14017722 Received: from mxhk.zte.com.cn (mxhk.zte.com.cn [63.216.63.40]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3296C1917CD; Sat, 15 Mar 2025 06:12:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=63.216.63.40 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1742019177; cv=none; b=IZIkCCt2k3Hi8m7tix0CZcM3xQZ1h+XXU17gPi7QIMTpBH0SmbUDZkPw7FBBwSRlBXtWsS5xEM7/mUUzi/SKTTJW7VDhlgvo97AHFGk+PTfXnSCfzKgI2X/PXmOV/UMapW1O1KRTF8fNsu9uBbyrvwRs8AcdAJWKxBZjR1uDpd4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1742019177; c=relaxed/simple; bh=Q9mtuujs0t4bKLAofmt2scm+ezjUA7Mj2N7W2T8m2DQ=; h=Date:Message-ID:Mime-Version:From:To:Cc:Subject:Content-Type; b=q8SM5rbYNI2JFfW0f+cygHm49QhV0p3iacmwPVVlhBWKB4qmyQa8X0lw3LokdFMP17co+HptqHzM3tqGBLawjkH2Ob+ccLcbzApuRb9vWjhyNM9sAUzAJFNnW4HbIohW5ATfUZlN5VbT5ymmlC0rApYzkqgg59eYh+Bm6G6GE0c= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=zte.com.cn; spf=pass smtp.mailfrom=zte.com.cn; arc=none smtp.client-ip=63.216.63.40 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=zte.com.cn Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=zte.com.cn Received: from mse-fl2.zte.com.cn (unknown [10.5.228.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mxhk.zte.com.cn (FangMail) with ESMTPS id 4ZF9rd4Nqtz8QrkZ; Sat, 15 Mar 2025 14:12:49 +0800 (CST) Received: from xaxapp04.zte.com.cn ([10.99.98.157]) by mse-fl2.zte.com.cn with SMTP id 52F6CleG053818; Sat, 15 Mar 2025 14:12:47 +0800 (+08) (envelope-from xie.ludan@zte.com.cn) Received: from mapi (xaxapp02[null]) by mapi (Zmail) with MAPI id mid32; Sat, 15 Mar 2025 14:12:49 +0800 (CST) Date: Sat, 15 Mar 2025 14:12:49 +0800 (CST) X-Zmail-TransId: 2afa67d51a611c9-69fbb X-Mailer: Zmail v1.0 Message-ID: <20250315141249338P9_QqSBAnqEi-DZYDTtR5@zte.com.cn> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 From: To: Cc: , , , , , Subject: =?utf-8?q?=5BPATCH_linux-next=5D_net=3A_atm=3A_use_sysfs=5Femit=28?= =?utf-8?q?=29_instead_of_scnprintf=28=29=2E?= X-MAIL: mse-fl2.zte.com.cn 52F6CleG053818 X-Fangmail-Anti-Spam-Filtered: true X-Fangmail-MID-QID: 67D51A61.001/4ZF9rd4Nqtz8QrkZ From: XieLudan Follow the advice in Documentation/filesystems/sysfs.rst: show() should only use sysfs_emit() or sysfs_emit_at() when formatting the value to be returned to user space. Signed-off-by: XieLudan --- net/atm/atm_sysfs.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/net/atm/atm_sysfs.c b/net/atm/atm_sysfs.c index 54e7fb1a4ee5..0aab1c3c05de 100644 --- a/net/atm/atm_sysfs.c +++ b/net/atm/atm_sysfs.c @@ -16,7 +16,7 @@ static ssize_t type_show(struct device *cdev, { struct atm_dev *adev = to_atm_dev(cdev); - return scnprintf(buf, PAGE_SIZE, "%s\n", adev->type); + return sysfs_emit(buf, "%s\n", adev->type); } static ssize_t address_show(struct device *cdev, @@ -24,7 +24,7 @@ static ssize_t address_show(struct device *cdev, { struct atm_dev *adev = to_atm_dev(cdev); - return scnprintf(buf, PAGE_SIZE, "%pM\n", adev->esi); + return sysfs_emit(buf, "%pM\n", adev->esi); } static ssize_t atmaddress_show(struct device *cdev, @@ -37,7 +37,7 @@ static ssize_t atmaddress_show(struct device *cdev, spin_lock_irqsave(&adev->lock, flags); list_for_each_entry(aaddr, &adev->local, entry) { - count += scnprintf(buf + count, PAGE_SIZE - count, + count += sysfs_emit(buf + count, "%1phN.%2phN.%10phN.%6phN.%1phN\n", &aaddr->addr.sas_addr.prv[0], &aaddr->addr.sas_addr.prv[1], @@ -55,7 +55,7 @@ static ssize_t atmindex_show(struct device *cdev, { struct atm_dev *adev = to_atm_dev(cdev); - return scnprintf(buf, PAGE_SIZE, "%d\n", adev->number); + return sysfs_emit(buf, "%d\n", adev->number); } static ssize_t carrier_show(struct device *cdev, @@ -63,7 +63,7 @@ static ssize_t carrier_show(struct device *cdev, { struct atm_dev *adev = to_atm_dev(cdev); - return scnprintf(buf, PAGE_SIZE, "%d\n", + return sysfs_emit(buf, "%d\n", adev->signal == ATM_PHY_SIG_LOST ? 0 : 1); } @@ -87,7 +87,7 @@ static ssize_t link_rate_show(struct device *cdev, default: link_rate = adev->link_rate * 8 * 53; } - return scnprintf(buf, PAGE_SIZE, "%d\n", link_rate); + return sysfs_emit(buf, "%d\n", link_rate); } static DEVICE_ATTR_RO(address);