From patchwork Sat Mar 15 13:40:06 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bryan O'Donoghue X-Patchwork-Id: 14018034 Received: from mail-ed1-f50.google.com (mail-ed1-f50.google.com [209.85.208.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BCFE61DC98B for ; Sat, 15 Mar 2025 13:40:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.50 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1742046036; cv=none; b=J36IxFMgGgwerJqPo9P7RnxfHHXKbdyvW/BtNdw3wBEUl1DbsavCsYRXkRO+aTmjBhxr4yyr6mJD3enZtfoJ9fCydxGOWK89cl92ojS4ckqzbZCuf7deFaRqx13RbI67sfCmuQ+A/v64dDJ9aRDveJxgBwP0NGtQ/Bb5cPyxHHE= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1742046036; c=relaxed/simple; bh=1XzDpE1/D6IJ+IhyW7rBh+iAYRrgUqa+4yROfrx/T4w=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=P4Bx4867GNTaoauyzKp5PCXlZVYNzNnequkEuwXGao/Cf00pHk2Wt1tnqmesEduy3ucNakLjDxBFkTvSefSbucYREDJHd+jVbbRK1OnTAmEq2ywQIw8okbwFeAzVks7utBcbgD9iBYt2h/4l2S69b0u6UQ7YcRH/iKTGyJEZVLc= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=hY9TLbWD; arc=none smtp.client-ip=209.85.208.50 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="hY9TLbWD" Received: by mail-ed1-f50.google.com with SMTP id 4fb4d7f45d1cf-5e614da8615so5920582a12.1 for ; Sat, 15 Mar 2025 06:40:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1742046033; x=1742650833; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=XvZDJMEISGf5fCXl6E/RBM62Xi8DcR35PaTbtSWcpYU=; b=hY9TLbWDCeQtEST21KFDuqLowhIC0mZkPCuv+SwAzP+OpjDrMyVltvwvBVUToRSTT1 KmE+tS1OllC7z09ruJ+Chi+B+mlVa/I0ncfJ1Ca/TuNU00v5lzZJsjGrSIdv6cz223Gj iEGMa07qfNw3MGom/xi6AZ3S2hDZzrw2dLpTpMaO6Eq9I3FTrrKd0gLVrKKaic5jLqAC Kjf6kUCMrB2tXu5fOrZcraBtoUXcwciSk4NO8iEiR1j03LTmTBABUns6WYs0MCM51mVw H0ScOuJWd3a+Dbk2S+/tJwOBAq91OSQWKMaoEB0Bv28pcrcLESYSqK6FAGDxu/S2DB+h rl3Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1742046033; x=1742650833; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=XvZDJMEISGf5fCXl6E/RBM62Xi8DcR35PaTbtSWcpYU=; b=ZHtl/asj00J0GKJaNHVTklWW+lyvsoc7BB85r5lzxZ/C9tky9X8ZHqYNDWFOf3lx8g WvZQpOKPdOEEJBN9BHwkZLReeqcilGFzS2MwpyogsQyF7ZpnHAXVY46JaTpukYZwhLTw 2CQ1tmchaMm1NquzKQ/Ucy8NF3ICmCS6/fQVSGR3iuetXMYSL6GmvsLQegwiJPiMJP1j vn8+J9w0MPtkc+vxRL48jIpLTjXH6fridBJbddP0joy4TMrx6HKqHULe5vo/8CnJG5T6 jjRS3iowFr7jKWoZY2ZF9qlyWD0DXO2wkBIusxShwiZWvtjrNfUTBITNL+wloAqJVGr4 pYfg== X-Forwarded-Encrypted: i=1; AJvYcCV5Jod9p1LJ8rWZ2EPhFxLNoj7R1V4AsBYCmjH7wFl2xfuBrHwCQz/gPCDEuAi9Rlho6T24XKsWw6uz4g==@vger.kernel.org X-Gm-Message-State: AOJu0YxrAgB2aVfPxjwTH/RQrVTccxXMU20a8NjyVgQM7hQlOIPLJ9kb mQt23T4DlFmVThEhbnCJgHzCcGiCPSxC7nsMrwS/ZMZj+C5sBdnjA4sC8jJJtJrbG/PVNRsg1kW 5vAsB7g== X-Gm-Gg: ASbGnctkaOhCtg6BPEJczVHJ5x3CjuNVs40NL1npBxpaOwLDD4ygP2IruQWj/LejxGy q2Ch3rZ6JrCVP634jsIZPPi54ziBdFhfvO7pG18oVZq0WbrcbakaN048AS9Lb46iIkCNaTGDZ8P s5b1+1xDtGj2X6Z7KxW6lfco04JEnwOHx2Y5ZF+t5d4ODBm9iR9MIlFtsmbD2vtlPDhw0EXTtPh 0kkpMNAACadjLc1Kp8ZPWHGuv/YZgMuxFpRTabJVWdgdXJFuAKPcz0lwR0ZVTwnGITGBGjlwk5q FMnOreiUs86RYEmLZnN86BNqwQxWaA4WLyVQV1z4RDtBmiQw0NyXO0qMyRzCvNNTQYleuSYrhZl PFJciTRjVb8TJbl+V4ACZHPfyE1c+1GvHT3TvOc9vk3ViIyyEu92N+1/i4nZyREKp4urnLIdwTQ == X-Google-Smtp-Source: AGHT+IFbvEViF6AXQfG3vWS7Xzhn98DgiMNvXmFjFpcyhvF4ZT4wUR3UkucbCDz6eC3awDjd7SulNA== X-Received: by 2002:a05:6402:5192:b0:5e0:8a27:cd36 with SMTP id 4fb4d7f45d1cf-5e814dec3f9mr11108451a12.8.1742046032930; Sat, 15 Mar 2025 06:40:32 -0700 (PDT) Received: from localhost.localdomain (2001-1c06-2302-5600-7555-cca3-bbc4-648b.cable.dynamic.v6.ziggo.nl. [2001:1c06:2302:5600:7555:cca3:bbc4:648b]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-5e8169b009fsm3378824a12.34.2025.03.15.06.40.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 15 Mar 2025 06:40:32 -0700 (PDT) From: Bryan O'Donoghue To: hdegoede@redhat.com Cc: sakari.ailus@linux.intel.com, heimir.sverrisson@gmail.com, linux-media@vger.kernel.org, stanislaw.gruszka@linux.intel.com, ingvar@redpill-linpro.com, hao.yao@intel.com, mchehab@kernel.org, Bryan O'Donoghue Subject: [PATCH 1/4] media: i2c: ov02c10: Support full range of power rails Date: Sat, 15 Mar 2025 13:40:06 +0000 Message-ID: <20250315134009.157132-2-bryan.odonoghue@linaro.org> X-Mailer: git-send-email 2.48.1 In-Reply-To: <20250315134009.157132-1-bryan.odonoghue@linaro.org> References: <20250314101125.9853-1-hdegoede@redhat.com> <20250315134009.157132-1-bryan.odonoghue@linaro.org> Precedence: bulk X-Mailing-List: linux-media@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Use regulator_bulk_* to get the array of potential power rails for the ov02c10. The original IPU6 sensor from Intel only has code for avdd but on other systems such as Qualcomm Co-Pilot laptops we need to manage avdd, dvdd and dovdd with regulator_bulk_enable/disable. Signed-off-by: Bryan O'Donoghue --- drivers/media/i2c/ov02c10.c | 38 ++++++++++++++++++++----------------- 1 file changed, 21 insertions(+), 17 deletions(-) diff --git a/drivers/media/i2c/ov02c10.c b/drivers/media/i2c/ov02c10.c index 5626aa2fe62c..f6542cdf7472 100644 --- a/drivers/media/i2c/ov02c10.c +++ b/drivers/media/i2c/ov02c10.c @@ -366,6 +366,12 @@ static const struct ov02c10_mode supported_modes[] = { }, }; +static const char * const ov02c10_supply_names[] = { + "dovdd", /* Digital I/O power */ + "avdd", /* Analog power */ + "dvdd", /* Digital core power */ +}; + struct ov02c10 { struct v4l2_subdev sd; struct media_pad pad; @@ -380,8 +386,8 @@ struct ov02c10 { struct v4l2_ctrl *exposure; struct clk *img_clk; - struct regulator *avdd; struct gpio_desc *reset; + struct regulator_bulk_data supplies[ARRAY_SIZE(ov02c10_supply_names)]; /* Current mode */ const struct ov02c10_mode *cur_mode; @@ -632,6 +638,7 @@ static int ov02c10_get_pm_resources(struct device *dev) { struct v4l2_subdev *sd = dev_get_drvdata(dev); struct ov02c10 *ov02c10 = to_ov02c10(sd); + int i; ov02c10->reset = devm_gpiod_get_optional(dev, "reset", GPIOD_OUT_HIGH); if (IS_ERR(ov02c10->reset)) @@ -645,28 +652,26 @@ static int ov02c10_get_pm_resources(struct device *dev) return dev_err_probe(dev, PTR_ERR(ov02c10->img_clk), "failed to get imaging clock\n"); - ov02c10->avdd = devm_regulator_get(dev, "avdd"); - if (IS_ERR(ov02c10->avdd)) - return dev_err_probe(dev, PTR_ERR(ov02c10->avdd), - "failed to get avdd regulator\n"); + for (i = 0; i < ARRAY_SIZE(ov02c10_supply_names); i++) + ov02c10->supplies[i].supply = ov02c10_supply_names[i]; - return 0; + return devm_regulator_bulk_get(dev, ARRAY_SIZE(ov02c10_supply_names), + ov02c10->supplies); } static int ov02c10_power_off(struct device *dev) { struct v4l2_subdev *sd = dev_get_drvdata(dev); struct ov02c10 *ov02c10 = to_ov02c10(sd); - int ret = 0; gpiod_set_value_cansleep(ov02c10->reset, 1); - if (ov02c10->avdd) - ret = regulator_disable(ov02c10->avdd); + regulator_bulk_disable(ARRAY_SIZE(ov02c10_supply_names), + ov02c10->supplies); clk_disable_unprepare(ov02c10->img_clk); - return ret; + return 0; } static int ov02c10_power_on(struct device *dev) @@ -681,13 +686,12 @@ static int ov02c10_power_on(struct device *dev) return ret; } - if (ov02c10->avdd) { - ret = regulator_enable(ov02c10->avdd); - if (ret < 0) { - dev_err(dev, "failed to enable avdd: %d", ret); - clk_disable_unprepare(ov02c10->img_clk); - return ret; - } + ret = regulator_bulk_enable(ARRAY_SIZE(ov02c10_supply_names), + ov02c10->supplies); + if (ret < 0) { + dev_err(dev, "failed to enable regulators: %d", ret); + clk_disable_unprepare(ov02c10->img_clk); + return ret; } gpiod_set_value_cansleep(ov02c10->reset, 0); From patchwork Sat Mar 15 13:40:07 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bryan O'Donoghue X-Patchwork-Id: 14018035 Received: from mail-ed1-f49.google.com (mail-ed1-f49.google.com [209.85.208.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C20D21FCCEA for ; Sat, 15 Mar 2025 13:40:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.49 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1742046037; cv=none; b=YOoHaIfkHEcDElyErT6ITWlLRG5jg/kKjYXSetYDXOSgPxY59fN0UHtN0CA7zlOcfTMTgE5jKYb0br/TzYu4Nbg/b/Ogwe+lOc4gxlBXPPpRBORBo8Qr00O+KOdR2vimtye3KRgNzeyzOefGgyFcalMDAHVyBnFn8QdusBijNik= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1742046037; c=relaxed/simple; bh=6LjldgotJJNlrPKOC6hW99wE+ZsCOEnLmJ5pw/S2NtM=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=hUtAxFs1rKBAj8xX9QJxhNu7z41iGhSODR2sj+kWlqMH++ER0n4ijjx9iNboCOLi7Kht7PqP2zjRlEx9nt2KyIFjSCkZ7SGY2U4Z8jGXPdYFyKgEkbpLgCGZn4dRosaYl0k/6saVyC0TcxCi9svoFIUpRloKXUqERgoXeYATrwI= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=y8qG25cD; arc=none smtp.client-ip=209.85.208.49 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="y8qG25cD" Received: by mail-ed1-f49.google.com with SMTP id 4fb4d7f45d1cf-5dca468c5e4so5232466a12.1 for ; Sat, 15 Mar 2025 06:40:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1742046034; x=1742650834; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=uDqwhYPsBFyy6vhaJJj0lCmkZup6HPmlAlZHVtXyE6M=; b=y8qG25cD/cAnrWzD04ZG577x6Eo9yt4e89Oxqs6zuDf33fT4cnClTmL1t4z1es/Uk9 r5O7r6Ras/U4ubt6x8id3Qo9PjUEftPFVHQKFtv4jjrb4ZoeWHKldjg6jAjJIQW2cm/5 yJXj2HOr/Mh4fYMz4J5oi9HL6ic5PYtjsBZPKH2wJdpwjcm2IMHLbqfU7yYU5dIJiTfK 4SFG5o/hpJq2qhpNEdORJ3hVzdcfqPfx6XgzzfPKlNgcppP7MDIuqAGD/KoLJPxdJwgp mL5EEfWyg1TxG8kpjaNJUfqBMuILA/QtJRSveWRenHGUZDFs8qKxANK+TbTRHu0d2Vgv 6sCQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1742046034; x=1742650834; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=uDqwhYPsBFyy6vhaJJj0lCmkZup6HPmlAlZHVtXyE6M=; b=gwzKSBSXPYZukd39uCLtLG5RwTEd5IUsgvLGxJcYp7K57CHoot8SNIjWTW618CEf3+ nieOuilukAATdROtE8oQ/zlXtC2+seOWQW8an7RdMLHwFjYyo87a8NLegqh47sHc+/or N8+ehP6tWeLEI00Jz8jlY/XdaBQXzSvXhL6/+RrxAaNnH6/Y7nr3YDh+6YKnwjmQKU85 pat9GMoUoJ0HH0Z0Gj4oHC2Mz0u31Fud9uuE8ln3KINZDHM0YNq4RuBcUPk3OkMqSP1M 00lylagWpHLkhRbOI4M7fiLC+yS8tVogV9uN1F42sMiRqkaRPF8RUZzBah6nzWP56AaG +wbg== X-Forwarded-Encrypted: i=1; AJvYcCVNlPCD0yKrVe9Zb16TRswivSiVcIU5rNg7lPTcBfUugF4OXzAM9e5SVceO3o5nVw0A+mjJS8tS/S/Usg==@vger.kernel.org X-Gm-Message-State: AOJu0Yx0pmGS3/RziC8007JtiKtFw+T/4SSoYgeQjK6SmVP1HRg/SX1T K7/BZHF8SqUahQk7Cuc7VfYjwxtszxxbC5sl875DLo089/B6xf3wcQgnczq8JcU= X-Gm-Gg: ASbGncuAR+xDaqGPkr66xC8u5It9AazT2blI7AYDro1qNAeJqLX0TWdyLLSuB2fZG50 YHl7bmQ2YwEPpQUjrVPBS2Xucb2WIdrQPIGEzivZe8RQrywfr3oKy2WRusoLcLY5MtDaSSbzJ5b tPfo/dQuQ9TkaXuM/AbaUDDoLeL2uJ4gd21Eyd06TvtUABL824y4lghpR9oKwrkFiphnkx5IwNb fbMgqvRyEXPQ0hpJ0UScYfTYp5y1u13y8RoAomfBXUuGovc7yoWHRCYYly/Q/4gekkxbJaNgXf+ JZU57JX8FFc2X//EorjojkGgDJGsjBwrneFcWwvvm26rGcDWytY3sD9ugPoNy1Z9c+jErfYJgzW geb7Tcl8IzaU/h5cn3AGPyCqdItIfXJfkWr9j7ylqGeXWmbiuytjMiG8Wxt96xmUkT8/sNM7WWQ == X-Google-Smtp-Source: AGHT+IGU+E3i9PkeNS0G/C6UZWdMxGBZZpyNAF02ok3x29buow9pjUrs52yeB10Liv3HVPxhYHSPjw== X-Received: by 2002:a05:6402:42c2:b0:5e7:8501:8c86 with SMTP id 4fb4d7f45d1cf-5e8a09fa617mr6135415a12.22.1742046034152; Sat, 15 Mar 2025 06:40:34 -0700 (PDT) Received: from localhost.localdomain (2001-1c06-2302-5600-7555-cca3-bbc4-648b.cable.dynamic.v6.ziggo.nl. [2001:1c06:2302:5600:7555:cca3:bbc4:648b]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-5e8169b009fsm3378824a12.34.2025.03.15.06.40.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 15 Mar 2025 06:40:33 -0700 (PDT) From: Bryan O'Donoghue To: hdegoede@redhat.com Cc: sakari.ailus@linux.intel.com, heimir.sverrisson@gmail.com, linux-media@vger.kernel.org, stanislaw.gruszka@linux.intel.com, ingvar@redpill-linpro.com, hao.yao@intel.com, mchehab@kernel.org, Bryan O'Donoghue Subject: [PATCH 2/4] media: i2c: ov02c10: Make reset gpio logic optional Date: Sat, 15 Mar 2025 13:40:07 +0000 Message-ID: <20250315134009.157132-3-bryan.odonoghue@linaro.org> X-Mailer: git-send-email 2.48.1 In-Reply-To: <20250315134009.157132-1-bryan.odonoghue@linaro.org> References: <20250314101125.9853-1-hdegoede@redhat.com> <20250315134009.157132-1-bryan.odonoghue@linaro.org> Precedence: bulk X-Mailing-List: linux-media@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 The reset gpio is optional. Only trigger the reset logic if the reset gpio pin is valid. Signed-off-by: Bryan O'Donoghue --- drivers/media/i2c/ov02c10.c | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/drivers/media/i2c/ov02c10.c b/drivers/media/i2c/ov02c10.c index f6542cdf7472..595998e60b22 100644 --- a/drivers/media/i2c/ov02c10.c +++ b/drivers/media/i2c/ov02c10.c @@ -664,7 +664,8 @@ static int ov02c10_power_off(struct device *dev) struct v4l2_subdev *sd = dev_get_drvdata(dev); struct ov02c10 *ov02c10 = to_ov02c10(sd); - gpiod_set_value_cansleep(ov02c10->reset, 1); + if (ov02c10->reset) + gpiod_set_value_cansleep(ov02c10->reset, 1); regulator_bulk_disable(ARRAY_SIZE(ov02c10_supply_names), ov02c10->supplies); @@ -694,8 +695,10 @@ static int ov02c10_power_on(struct device *dev) return ret; } - gpiod_set_value_cansleep(ov02c10->reset, 0); - usleep_range(1500, 1800); + if (ov02c10->reset) { + gpiod_set_value_cansleep(ov02c10->reset, 0); + usleep_range(1500, 1800); + } return 0; } From patchwork Sat Mar 15 13:40:08 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bryan O'Donoghue X-Patchwork-Id: 14018036 Received: from mail-ej1-f50.google.com (mail-ej1-f50.google.com [209.85.218.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0E3A11FCD00 for ; Sat, 15 Mar 2025 13:40:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.50 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1742046039; cv=none; b=kTJLYrlOsF3KIdbsenN4OUHpN2QRzgVfmSQ3fsIPOSAA9ZVTI2ITKPsb+pA9V0B4Y5fcj1BJ/E6kx+XbkjYeEp9nc2+h5mHrV4yRxkcexotqin3U6kU6i9756OTXDHDi/NKNY7ZOIllCtBX2EU14pWApFn+aIwYL71Ri0d4UNKY= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1742046039; c=relaxed/simple; bh=ob7EuhXpGnktGfDcOTWv+3MsFvXv3RvEalxeOvINqTA=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=RzHeOpCuMZUeMpXKMClM4Y0ZWibsuPUgeOl5JbxFTWJ7O8kekEFhkpjhqEDo7hIVpPZ6A4bMhPzBiLcA12R51ObsLUBpBiAoj2g3y2cey0Oq0BwL7Lqkj+Tq2whqhQCvYG5sE2FBRVAgUVpQ7CvXWjN9qUEKv4W6LsM1RaK65gE= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=NNZdh92u; arc=none smtp.client-ip=209.85.218.50 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="NNZdh92u" Received: by mail-ej1-f50.google.com with SMTP id a640c23a62f3a-ac345bd8e13so109544266b.0 for ; Sat, 15 Mar 2025 06:40:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1742046036; x=1742650836; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=uZKOsr5RYKkjXg4DicEjwNb17WMUuY3yeez9AejhVeU=; b=NNZdh92uXLHVYcbIDJqL0HU0oLZr8OnB3s6WHXHrNFtUfk7IphrYAZaEjpquvrU7lE 3VdFI4kfpGAsbigwhCdHXt/UvL0gvj1md7zfzaTnCK8kzaUW1hfVFKrSM8wan4xkWIhB +iQHYagPBh8eK/LgkLinsHvVkbMCjXoUzAg3vF/p5Tke+XGL/VgPU+JBnIf67rvu3SG2 mOyXljpW7njtTuQ0LgAC81+JzrhqB+Y7VMHP5CeUj5+HbTwM1nq5YsveOL/VQRgWx1sX EsOVx3SHfZBgGXvR+iQecCTIgg/9bcmW+V1uC/+s20eqMADfJuWx2vA4HUwvpZWUlhBA b/+w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1742046036; x=1742650836; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=uZKOsr5RYKkjXg4DicEjwNb17WMUuY3yeez9AejhVeU=; b=DoCM8tsO/7jL2h+e8MwhA+yu9YfOKPSJQSlIekPRaznMDEODSNgTbzgio5YUwpJkhZ 48YHR4ZMmC6Mcz7RnI3O7mbmi/ajJSDOyOXhr68CjvCaUX/MmclLmjybUdrszmFQLMc6 5Ozp2q0T84/4+qtiz4PPoFyGEc2CYFdHG0qoLebhonB93GvwwyELI80hKlg3+822Cu8Z bcZR+JbLw+1iDjOk79iI/Gp9h3Xk7TEOul2CYs+MFLhWXGBf1oRxX2ntY4X+279HZeVD 9aHqFEPyOINsAjgZ4hcELKAvhHk5hRo+adwh1c6in7ej/5EDPpYX9s9+u6HiktfkYkoA oZ9g== X-Forwarded-Encrypted: i=1; AJvYcCWeqiUFFa/f6CYo1PfN2JqPNS4rTiZmGCcdVK+v8N2Gnv/dgXLlj/lYP3zv81B8kYkYXL8EZTUmTQ2paA==@vger.kernel.org X-Gm-Message-State: AOJu0YxiPjzS/QX5ORRTo/CjP7nPYroEams2i0FskxEVZm9pYknFah22 McK/lfgQXQHMfMTLOOso76dwDqo20h2F2jVcSEKlUg0mJOxHaOg7ZJqfMAV/m8xm1m8p/MKeLbe ANxwbeg== X-Gm-Gg: ASbGncv79CWgrMDj/2xZP2x+3fb+zJ+ADP7k015BmGOFF9BjoW+7PbQXZKDxsZiQcIf 0kB2bR0AMy7C8x7k/bdwEdApTokX7tcXbIIYsko3RgI6CQa6/HqkBHO/N8Ukd95x4FceRHyR3Yu XTxXOGhG8rwjUDhsVpMoZuEyP0m8NtpDgF53ldBN/yeKKZWjieR/Xp8BXQsMqP25feqJj8+vWyK kd3x/ZLaE31GGNoSVxtI5FuVsBkz0G5i3ZFcnxPpFpAgySKIGxlP23suW102/5BF6rRIvqixEIf 2BJkLAFWnZfwNir6pLkvY/28/3ZKCv310iEY46JzlANKfZGyP22f3RCg83hGFUKyKfnGLpvY/KW mVsokEZkMwdZAij2H2YON30mPDrVbLFW9WPctUnb+8bA02imlGXiC6Y+952L+IChz1jgtMpN8hQ == X-Google-Smtp-Source: AGHT+IEryYAH4U5xOlJZ0FtsmMv+Gy8KrllKo4b7oROpG2tcDnL7/rwT07hALb3ex+6PnWMyNDc53A== X-Received: by 2002:a17:907:96a1:b0:ac1:fb60:2269 with SMTP id a640c23a62f3a-ac3301e8eb6mr659028366b.27.1742046036348; Sat, 15 Mar 2025 06:40:36 -0700 (PDT) Received: from localhost.localdomain (2001-1c06-2302-5600-7555-cca3-bbc4-648b.cable.dynamic.v6.ziggo.nl. [2001:1c06:2302:5600:7555:cca3:bbc4:648b]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-5e8169b009fsm3378824a12.34.2025.03.15.06.40.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 15 Mar 2025 06:40:35 -0700 (PDT) From: Bryan O'Donoghue To: hdegoede@redhat.com Cc: sakari.ailus@linux.intel.com, heimir.sverrisson@gmail.com, linux-media@vger.kernel.org, stanislaw.gruszka@linux.intel.com, ingvar@redpill-linpro.com, hao.yao@intel.com, mchehab@kernel.org, Bryan O'Donoghue Subject: [PATCH 3/4] media: i2c: ov02c10: Implement power-on reset Date: Sat, 15 Mar 2025 13:40:08 +0000 Message-ID: <20250315134009.157132-4-bryan.odonoghue@linaro.org> X-Mailer: git-send-email 2.48.1 In-Reply-To: <20250315134009.157132-1-bryan.odonoghue@linaro.org> References: <20250314101125.9853-1-hdegoede@redhat.com> <20250315134009.157132-1-bryan.odonoghue@linaro.org> Precedence: bulk X-Mailing-List: linux-media@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Implement recommended power-on reset. ov02c10 documentation states that the hardware reset is active low and that the reset pulse should be greater than 2 milliseconds. The power-on timing tables shows that t5 the time between XSHUTDOWN deassert to system ready is a minimum 5 millseconds. Implement the recommended power-on reset minimums. Signed-off-by: Bryan O'Donoghue --- drivers/media/i2c/ov02c10.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/media/i2c/ov02c10.c b/drivers/media/i2c/ov02c10.c index 595998e60b22..d3dc614a3c01 100644 --- a/drivers/media/i2c/ov02c10.c +++ b/drivers/media/i2c/ov02c10.c @@ -696,8 +696,10 @@ static int ov02c10_power_on(struct device *dev) } if (ov02c10->reset) { + gpiod_set_value_cansleep(ov02c10->reset, 1); + usleep_range(2000, 2200); gpiod_set_value_cansleep(ov02c10->reset, 0); - usleep_range(1500, 1800); + usleep_range(5000, 5100); } return 0; From patchwork Sat Mar 15 13:40:09 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bryan O'Donoghue X-Patchwork-Id: 14018037 Received: from mail-ed1-f48.google.com (mail-ed1-f48.google.com [209.85.208.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 418981FCCF9 for ; Sat, 15 Mar 2025 13:40:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.48 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1742046042; cv=none; b=fXttMUsVK9ktTuzv2Pv211uHfOVZ+TARo59asUtUgEc4EhtaGXuPA0vDQXV+7axCDqVtpvP6i88EyCs+c13YpmqZ8Ebd6o+vlhTkL/CJcAtWGNtR7arqYqeST1XsxbURH6HVsPzfMdk/D+YsYtbiBQJ1RXHQGNB+G2rnslifNLw= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1742046042; c=relaxed/simple; bh=E8jocHu5wWsMxvcoCmPKc+TA3pYPbkfWJvR/i7m4LdQ=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=HHtpLGX9OI4/ID84pIEy7OcHlR0SGuzh4yATLCrzM9vphsc3CPS7i6MgAHzEitfLOQyuhlwPzenRFf789IFMy1eTcHPX3vIrEmnazKTJK2ANqymZCt1xlKI3U/5SuyXRLNdkqAjyRnsSK8cWSVkpyG3twKsMXfGuIZ5t8xT7UyU= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=BO/qv1CH; arc=none smtp.client-ip=209.85.208.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="BO/qv1CH" Received: by mail-ed1-f48.google.com with SMTP id 4fb4d7f45d1cf-5dca468c5e4so5232526a12.1 for ; Sat, 15 Mar 2025 06:40:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1742046038; x=1742650838; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=RD11mzJFRq6d0T7pDKGqoqCjyj5QqJtchVCr8n4C52w=; b=BO/qv1CHEC/eE/AHEEbZSxgFTuUL2vufOZJ0SEjYaqp4pKN90u9NAD/K33Xe6WBn0c S93C1zNuhM24bDxgud8C3EpMMNKVsJu3LAJXcJ0iwnSrw05fTn3004e+STblm/qM5tBp 3SF+pmeImwwvWDj7SzHdmytIDVAcBJsHkH0MHnMckUfUTtrj9Unpc9AtlR5tCucRWdEq PAwAkxqDfIcxsKq8WRlKDO+tl1GrBMgxtCveO9Xkm1MpqiD8xdoWbay2G3AyYw8E+cf2 Et1o0XBRYVGEZ113iZoAaY8MG3/Nk2gA9Vv4TTDOrdL946GyZJz40tCZv2PRYGYr3CX/ +tcQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1742046038; x=1742650838; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=RD11mzJFRq6d0T7pDKGqoqCjyj5QqJtchVCr8n4C52w=; b=sUJGWwaIq4tdZeHTrtyVv0PqyKAkkTqr85iXbm49rwiCN+RldiOEvbk44F0Ap9kfGw +Xr4h2NHd2msREET+isrfU8nQjtyxzujlfwYeFOrrJ2y2Rv3/DepBJxcxBZG/ZBiv6gJ ItZIavmGWD+D/1FsrgUIoQOYAj4mUytsa6zo56sXNYKkWX9xaWPObAbTShvz0Mq/Uf5Z /hJkc6a6CjPUge5LYKasWJFFP4iETs+1Nrpst+kyFLIw9EJJRtfdbZpgFmSSeiSn6Z2W Ic7p9OQBZ9HNltRd/7KmHMdD/r2mP+8UUUvkk/DI/Gj0lz+/GutJ/sj39pKB2+G3l+DC GiFw== X-Forwarded-Encrypted: i=1; AJvYcCUjD5eOU8/GuR69wisAdUsPqmos36TrXvg5NVq3QazRReRUxQlcMIW0UK3AMwp+cec7O3+dmySgcS0wEw==@vger.kernel.org X-Gm-Message-State: AOJu0YwPmOFno9qNonN3SFlSdid2y5u9Je7p3oW1/5gUOI2xhDE5NMvx /kauoN/fexKbnCu9NsEv2/RuG0xG2AjaX2U7sX4RczyBDiCv0hdUViYlwdXHa7updR6yxT4KPFU ra3Nw/g== X-Gm-Gg: ASbGnct0EPMYvTGgtWB8093EZnRlXDUsrusfPjRw+BBJkLrApaL8xdNEMYI4GzlhhJG 4krh1NCjVT8UF2K/9W5OucD4w6YyykmjUZP4GUrskjDCpgivdiHey1RIM0GNjbb8c4L3wwXUKWm snzNm92TSBdTNLBh366BvNg5DkfOvzM7QUVu2eFxNjWsnhPAnHSBlfYbydskkg6C15JA03/SZWr 8RY1A4Wc0mctT3UftXmHlDyEfq1Y4gu7u5qUxpCEZE4LpoFeII0xppuot3vk7nqEtA56sTkvU9o vRYdgn4Dr8rCeUqNGlRPaDpcpaRY0YAUDSgjJ9MuYKUTExK9j+tSUWxiZkwZ+/b9jdq+HhRij4c FYXssWKIz0KRFYkDMokoFOy4PMK+SgOAfYcJqTo/gdppBYq5IS92IJh1ZMkbAGT9jQpIMQoxKpA == X-Google-Smtp-Source: AGHT+IF94uOzzvBdoGEe8hOCEMQD4gwFpdgpulBXsezhA1kwIkTQSRXsrr++z9Inem7QZTmL2Bzr1w== X-Received: by 2002:a05:6402:50d0:b0:5e4:b66f:880e with SMTP id 4fb4d7f45d1cf-5e89f24f5e8mr4840870a12.7.1742046038528; Sat, 15 Mar 2025 06:40:38 -0700 (PDT) Received: from localhost.localdomain (2001-1c06-2302-5600-7555-cca3-bbc4-648b.cable.dynamic.v6.ziggo.nl. [2001:1c06:2302:5600:7555:cca3:bbc4:648b]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-5e8169b009fsm3378824a12.34.2025.03.15.06.40.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 15 Mar 2025 06:40:37 -0700 (PDT) From: Bryan O'Donoghue To: hdegoede@redhat.com Cc: sakari.ailus@linux.intel.com, heimir.sverrisson@gmail.com, linux-media@vger.kernel.org, stanislaw.gruszka@linux.intel.com, ingvar@redpill-linpro.com, hao.yao@intel.com, mchehab@kernel.org, Bryan O'Donoghue Subject: [PATCH 4/4] media: i2c: ov02c10: Add OF probe support Date: Sat, 15 Mar 2025 13:40:09 +0000 Message-ID: <20250315134009.157132-5-bryan.odonoghue@linaro.org> X-Mailer: git-send-email 2.48.1 In-Reply-To: <20250315134009.157132-1-bryan.odonoghue@linaro.org> References: <20250314101125.9853-1-hdegoede@redhat.com> <20250315134009.157132-1-bryan.odonoghue@linaro.org> Precedence: bulk X-Mailing-List: linux-media@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Supply OF probe matching table and enumeration structure hook. Signed-off-by: Bryan O'Donoghue --- drivers/media/i2c/ov02c10.c | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/drivers/media/i2c/ov02c10.c b/drivers/media/i2c/ov02c10.c index d3dc614a3c01..094651228763 100644 --- a/drivers/media/i2c/ov02c10.c +++ b/drivers/media/i2c/ov02c10.c @@ -1004,11 +1004,18 @@ static const struct acpi_device_id ov02c10_acpi_ids[] = { MODULE_DEVICE_TABLE(acpi, ov02c10_acpi_ids); #endif +static const struct of_device_id ov02c10_of_match[] = { + { .compatible = "ovti,ov02c10" }, + { /* sentinel */ } +}; +MODULE_DEVICE_TABLE(of, ov02c10_of_match); + static struct i2c_driver ov02c10_i2c_driver = { .driver = { .name = "ov02c10", .pm = pm_sleep_ptr(&ov02c10_pm_ops), .acpi_match_table = ACPI_PTR(ov02c10_acpi_ids), + .of_match_table = ov02c10_of_match, }, .probe = ov02c10_probe, .remove = ov02c10_remove,