From patchwork Mon Mar 17 05:19:49 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stanley Chu X-Patchwork-Id: 14018641 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 637EBC35FF6 for ; Mon, 17 Mar 2025 05:20:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=hh+SUf829uT0cjZhjCJGiZ8xvBt72RNNPYOt19l0wl0=; b=LEQww2rjoVPBSH rUqeLIWLlrM92xM69GviZPIaI8s99/RH5a9BpAMg3EBMdbD+pG4zqf5zC5vc2Ftk42AL+T34aoXfj UoRRlYltoZgbguQuHEOEBDCiopBxChQPWlWR6xbDDWTpJW+Mk173jOxyanwmmy1MrQDC/J/fmrItQ Jg9OvATmli2Z2UIuEnPoDGQHVM2g1tVr9mFHUP5ogy/yXMEstwY6E92MlGoQNfLcjJgTDgTw0f+V4 7N0BvI5yoUq/bTx7ghzXES7fesF5/Y4GU+6KP8+j3c+ELC3yjfjLPG6/jWPNwRfuPxlXyfoGNDohu a8z2gMyMamB5vftnTHng==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1tu2tP-00000001G70-0Lbn; Mon, 17 Mar 2025 05:20:03 +0000 Received: from mail-pl1-x62a.google.com ([2607:f8b0:4864:20::62a]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1tu2tM-00000001G5q-2mh8 for linux-i3c@lists.infradead.org; Mon, 17 Mar 2025 05:20:01 +0000 Received: by mail-pl1-x62a.google.com with SMTP id d9443c01a7336-225e3002dffso33005865ad.1 for ; Sun, 16 Mar 2025 22:20:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1742188800; x=1742793600; darn=lists.infradead.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=8hHpeaAz642MIL/iezdA9kA+qz/7ACYSpLAAklsJNG0=; b=DUReHNw/f8ZUgWy2FPA3Qk3BFUAKOV/6Io/G0kQwY7y2KelfbjLkC8SQzexNDTZHmT m9DgRf27z9JgyQVj8495CzNqsU2tREueMoHbLY+dusxZHaWeQYOjJxZv9dIFu66C09Ex M4nXo69+zHoRNYju9bGrwC6sFk/f0CoGsLmH0PJrsoaLFrHE8FSZ61ha+kSi7LLv3q2Z 6fb7QJa3xkIVgY7zNwG0SJRNGbeqgkCvidYC8MJKOOF94UWfVSpNNei95yap+WzxCWgR M1tYbweqG3JH2lhQ6Rqdd4uq0U5aGQrfC7PFFf3CvNf1vshc99e/zhzY1loA0slo9xTX uG6A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1742188800; x=1742793600; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=8hHpeaAz642MIL/iezdA9kA+qz/7ACYSpLAAklsJNG0=; b=qpm3cS212QEeViFCQS+YjQn8h051aMIZdsohN0625RDvdr4x+2SPXTElG/BSO7Lp74 mR3JgdcCeVTGXJngslEv5SWFEfd1cgzZcFosG9GQsGogPiqdeGJO2ovwa1V0FkocMq16 iVRZ15O81JtbOol58sqHi67PGOnxMJN6OJMr/gxPnPP4f867YXcSRbgee+lxpeXUBq5d cFz/5nC8OLqMUUHVjS+hZW00CvcJU0VfX3OwOawNJBbLct981Q+gMuL71Pf0dt5SvAIm 6scYR99C6JjNbWgfvLuL0eAHF5cPHPowcEd6LWpnQHPMfgn4wlW6S4xK6vYJHToHVPnJ OxzQ== X-Forwarded-Encrypted: i=1; AJvYcCXoj3viYvwhBJCqXZlGl8z+WWcuCi4GD3Hm0hJm+RbEBsiHRFx3JKd46K10B9Pnrzb2p9/2KkQx/eU=@lists.infradead.org X-Gm-Message-State: AOJu0YyReVYE3Is+oUcsvDjLQ/O31oZmceZouWNpJ8Q17ZBww5tvu8i0 28VrvpVNKvziH5kUfSpusx44X5esCukMWSpJicuibe2NvF5VDGZnCnxTaAbb X-Gm-Gg: ASbGncseXJMiT059RSYPz4XVhb8mSKd5M9PTvhZtzJdCosU9aV7ekyb9THWFneqbW3u 7bC26m6KQ2AEhy25G0HH8pcRkOaw0ILsemrBkDuMcEd1dib44d6t8onqHBfvg7gB8PlIm6GDI5r etd6DmWFO5B5Gt5SggVVOlqsKJgSS1Y3ZTudtko4RZGF8yRVPsQwC+00E0FDvG/XFj+43SSp9F2 jVS9KYhC6Stfdu224X/YcFydQIsSohjcRfEKxu0+3VsbEsmtCW7PUnFouOYLlmiXMFpWcfhZBLA 1orY6ZNqrEKdXQ8I3XtzD/yjKYcAiI14QoLlblOFJiJ6ThY0IEH1Dlz3uKlw7x+isQ== X-Google-Smtp-Source: AGHT+IEV6Wz5E1OsOPUft0kE2VrP4XoFNpoRQ5PM0M1BZxRJlTEp2VRWJHVmkulPVIEYr2uaQc1eAg== X-Received: by 2002:a17:902:ce8f:b0:220:c63b:d93c with SMTP id d9443c01a7336-225e0b07523mr139991475ad.44.1742188799683; Sun, 16 Mar 2025 22:19:59 -0700 (PDT) Received: from cs20-buildserver.lan ([2403:c300:df04:8817:2e0:4cff:fe68:863]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-225c6ba721esm66029975ad.149.2025.03.16.22.19.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 16 Mar 2025 22:19:59 -0700 (PDT) From: Stanley Chu X-Google-Original-From: Stanley Chu To: frank.li@nxp.com, miquel.raynal@bootlin.com, alexandre.belloni@bootlin.com, linux-i3c@lists.infradead.org Cc: linux-kernel@vger.kernel.org, tomer.maimon@nuvoton.com, kwliu@nuvoton.com, yschu@nuvoton.com Subject: [PATCH v1 1/3] i3c: master: svc: Fix missing the IBI rules Date: Mon, 17 Mar 2025 13:19:49 +0800 Message-Id: <20250317051951.3065011-2-yschu@nuvoton.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20250317051951.3065011-1-yschu@nuvoton.com> References: <20250317051951.3065011-1-yschu@nuvoton.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250316_222000_714917_D4E62275 X-CRM114-Status: GOOD ( 11.27 ) X-BeenThere: linux-i3c@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-i3c" Errors-To: linux-i3c-bounces+linux-i3c=archiver.kernel.org@lists.infradead.org From: Stanley Chu The code does not add IBI rules for devices with controller capability. However, some target devices, such as secondary controller, also have the controller capability. Modify the code to add rules for devices capable of sending IBI requests. Fixes: dd3c52846d59 ("i3c: master: svc: Add Silvaco I3C master driver") Signed-off-by: Stanley Chu Reviewed-by: Frank Li --- drivers/i3c/master/svc-i3c-master.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/i3c/master/svc-i3c-master.c b/drivers/i3c/master/svc-i3c-master.c index 1d1f351b9a85..a72ba5a7edd4 100644 --- a/drivers/i3c/master/svc-i3c-master.c +++ b/drivers/i3c/master/svc-i3c-master.c @@ -1106,7 +1106,7 @@ static int svc_i3c_update_ibirules(struct svc_i3c_master *master) /* Create the IBIRULES register for both cases */ i3c_bus_for_each_i3cdev(&master->base.bus, dev) { - if (I3C_BCR_DEVICE_ROLE(dev->info.bcr) == I3C_BCR_I3C_MASTER) + if (!(dev->info.bcr & I3C_BCR_IBI_REQ_CAP)) continue; if (dev->info.bcr & I3C_BCR_IBI_PAYLOAD) { From patchwork Mon Mar 17 05:19:50 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stanley Chu X-Patchwork-Id: 14018642 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 9E0A0C282EC for ; Mon, 17 Mar 2025 05:20:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=bf1KLproqskSf2erFXK3Pw2XjyctBNbY4zFuogFGFZ4=; b=T89a6YV5Vr05Cp VjGp/HJ4bQh88RDbRMSKWiZIoXxKP1Bkub9O7EiqaJI9YpxRNI/ddRgSsmlffMeNBioJ8z6mlFnw7 w5v+7FGmXr/NSIEXSyU8mXmvq+H/JIV2aBf62ValXPwQ4EkfkptCIuPIzzkPt6RvkG3CRfkf5PC1E Wm7XRxBmqmQ3SMv+yMLguPMFpAeu2wv6/6AqE6KUF6ujx9TK2+/IQx4C+vArjvNbZiai0ThybMYvT 2S5O8XzRio4BIjWjYTITgK5zDaXJ3+XrJXAC0ciHBkUhiln4g0O87h+e1K23ShqH0lbD6yNiTIdvy W9j/zujxsWvG+dtpmZTw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1tu2tR-00000001G83-1ZRM; Mon, 17 Mar 2025 05:20:05 +0000 Received: from mail-pl1-x629.google.com ([2607:f8b0:4864:20::629]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1tu2tO-00000001G6g-293S for linux-i3c@lists.infradead.org; Mon, 17 Mar 2025 05:20:03 +0000 Received: by mail-pl1-x629.google.com with SMTP id d9443c01a7336-2235189adaeso65345235ad.0 for ; Sun, 16 Mar 2025 22:20:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1742188802; x=1742793602; darn=lists.infradead.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=aAEvizj50eAxWAKykJSsmzW28jqssjw0r0XHccdzS7k=; b=Rl2pfn5otczjD5mNFJxVHOo7lLeHlRue+aKAoXyWnh35D/ae/pNtRMntPtCpi2piDH iC+F+EeUCmJ2VYB7VUDBUPKtEDu1lIW19EoPv7Jt0bMeGudv7agz4heUIAffAj/Pnaq7 HgCrXh9wd3gS8JpTtXFF2VM1N5KDZio1He0d/SG3t2+l/tE9txcdABXNOB+37ZfDzsV5 Fgz3o4IscxWRvMGBAkF3bYquBnbYWrUvR+COatoBzPKWI3iniOFeUwMhFteAW4OexZA2 4e8nvvvuxZE2Br5cxpBsZ59vEc+BnHZ141T9A8cC1t210z4zK2KZCayHUxF7Nd2HChYQ SDmg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1742188802; x=1742793602; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=aAEvizj50eAxWAKykJSsmzW28jqssjw0r0XHccdzS7k=; b=gIDJPVvDpnSKu4/6RibhRcgeWdlcd/JrYw6WknwzFSQjvyeM5Fv6p4nMiliqWvnIOq 5rJjCWd+/k/AP9ivwhIoD3oO62QPkP9O6zfxXtywHOdb43slgKSC4uj9bx2nlqwVs/ba OMfIO36WSjYhyk/2UmXFk5GZYOj78FM9sNfRTZCoLFFgs8XLIUtKjUg3Mqz9S+7KAnWe YrxkKOEpBlSH7LSLXOaWkP5/CIcreTMFQe5C9Auijt9qnCqdMDSrgc+NSZLhxagB9ISy Umwh0ghc2cdQIxyGqd6V5vFDgZHiBBlWKvyEwypeuy3LxByqfBLkTFE46bCk+KZYJG2m IxOw== X-Forwarded-Encrypted: i=1; AJvYcCVxXCCZX+XKlJb3b43fusUnpsSc1AkUoWeO/C20fCU74sMZG0TnjTDrCgtOicOyckgRQlaP8FUH7QM=@lists.infradead.org X-Gm-Message-State: AOJu0YxJPIsmyEhK3cOSgVXsRcX5GkEJS0fiy7MNaDFr3RHkXsVC2K61 91QuopyMsYY97gUyK3Hq8fIdJEkdSSmUAwWEBICtGoEOqYBSDbcTCVUKimgT X-Gm-Gg: ASbGnctjppaCHsBpkOICw7g74xdWLd/Rt9Ee9ZuRdQHZjIIYUqKRY57lBQXuM25iCio WH4n6sYoWvbXAQUOlXskwxL8+rIKTyCnzVbEpSpYxQ/cioI1oL6N0iZ9/jhXaEceg8rj6QvjjPf 6sz6TCFGKnty8iwM8d3NEmUj3H234HxRFJahEA16PjKbt7ZowtIt0fN1s5k90InyWejNowQx0Im Vm9/MrDFsF96ZoYm/226C9BL+JtNY8FAnbEGYHBG9lJRkl+xs9XbzeFyxacyt2Wxy/74qhA1Rus C2Xd+aswhKMEvl6qGTcya6O8FELbeyQ3SsyUwrCek/ydnBee9qc4/Sw= X-Google-Smtp-Source: AGHT+IEHB6SBZYCHYVZ9nI0CRHRWXDHgiOP2L/CSK0IC9gfbmhq+cygXWU14lVnZh41QKkaCLFkxmQ== X-Received: by 2002:a17:902:e750:b0:223:607c:1d99 with SMTP id d9443c01a7336-225e1594eacmr155354065ad.0.1742188801791; Sun, 16 Mar 2025 22:20:01 -0700 (PDT) Received: from cs20-buildserver.lan ([2403:c300:df04:8817:2e0:4cff:fe68:863]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-225c6ba721esm66029975ad.149.2025.03.16.22.19.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 16 Mar 2025 22:20:01 -0700 (PDT) From: Stanley Chu X-Google-Original-From: Stanley Chu To: frank.li@nxp.com, miquel.raynal@bootlin.com, alexandre.belloni@bootlin.com, linux-i3c@lists.infradead.org Cc: linux-kernel@vger.kernel.org, tomer.maimon@nuvoton.com, kwliu@nuvoton.com, yschu@nuvoton.com Subject: [PATCH v1 2/3] i3c: master: svc: Use readsb helper for reading MDB Date: Mon, 17 Mar 2025 13:19:50 +0800 Message-Id: <20250317051951.3065011-3-yschu@nuvoton.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20250317051951.3065011-1-yschu@nuvoton.com> References: <20250317051951.3065011-1-yschu@nuvoton.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250316_222002_553767_9B2F77C1 X-CRM114-Status: GOOD ( 10.47 ) X-BeenThere: linux-i3c@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-i3c" Errors-To: linux-i3c-bounces+linux-i3c=archiver.kernel.org@lists.infradead.org From: Stanley Chu The target can send the MDB byte followed by additional data bytes. The readl on MRDATAB reads one actual byte, but the readsl advances the destination pointer by 4 bytes. This causes the subsequent payload to be copied to wrong position in the destination buffer. Fixes: dd3c52846d59 ("i3c: master: svc: Add Silvaco I3C master driver") Signed-off-by: Stanley Chu Reviewed-by: Frank Li --- drivers/i3c/master/svc-i3c-master.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/i3c/master/svc-i3c-master.c b/drivers/i3c/master/svc-i3c-master.c index a72ba5a7edd4..57b9dec6b5a8 100644 --- a/drivers/i3c/master/svc-i3c-master.c +++ b/drivers/i3c/master/svc-i3c-master.c @@ -425,7 +425,7 @@ static int svc_i3c_master_handle_ibi(struct svc_i3c_master *master, slot->len < SVC_I3C_FIFO_SIZE) { mdatactrl = readl(master->regs + SVC_I3C_MDATACTRL); count = SVC_I3C_MDATACTRL_RXCOUNT(mdatactrl); - readsl(master->regs + SVC_I3C_MRDATAB, buf, count); + readsb(master->regs + SVC_I3C_MRDATAB, buf, count); slot->len += count; buf += count; } From patchwork Mon Mar 17 05:19:51 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stanley Chu X-Patchwork-Id: 14018643 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E09B1C35FF3 for ; Mon, 17 Mar 2025 05:20:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=zWSJG+ybhzl/gUqU9WXtyR8znGnj2DhwAMahSChaoq4=; b=27eL4kDAqEuUsD ctVXHEkHvEGBks+zlqiO5uBvm/sLJHg9JcyelwSXR85FS/inqzP/LPsTn8vFqGsfRPqsqF1xXAYcS x1Q1O1ujNuqyBXT5ZhZHs82OkrHag9t6t4OFgkGPCu/JVtXPINd9qT6HV4Y0IMonnsuUijogYOW6v az2yIgOKMU0KfGp995xCLNAf+wzvVgEu4v5N6kPXixXw9SR+CQnU3ny3U/qffhxH7k8S4tsuTyOIz 0lUro+Xo24mCh62MxQigHXLT2RXabXB/6TlgHxGVWwNSKFm6ED+qiVEKkgi7PbQp2uhNtvukS/hM0 Lcqbs2MFxXB1Zr8m9pBw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1tu2tS-00000001G8a-2opa; Mon, 17 Mar 2025 05:20:06 +0000 Received: from mail-pl1-x62c.google.com ([2607:f8b0:4864:20::62c]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1tu2tQ-00000001G7a-3T2f for linux-i3c@lists.infradead.org; Mon, 17 Mar 2025 05:20:05 +0000 Received: by mail-pl1-x62c.google.com with SMTP id d9443c01a7336-2235189adaeso65345575ad.0 for ; Sun, 16 Mar 2025 22:20:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1742188804; x=1742793604; darn=lists.infradead.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=T18/LmksYiI2JDaALAx8F0tVbVplhY6o09bZJuKtckw=; b=keVVfH9QFRo9MR98uDMQPSgfAblDsjs90jOTQOX8zRvwF9ZXJblruMIJ4Sm/9ZL5wq 9Q7pFRMX2nrjR5IH4YH4AG/syeb3e0Hq9NhuI2Z+m4zyTLdj16Eltg9Vgp/we1a+EmPS +QEkxcfuSz9y+7nkwjkl4ark9ffSvsS80KQN98yUwgh93NOuox81gWbxSdRUnL8VIU5N 405UFFeKmpxuP+EAsgOZzQnYjPwphO2hcIJEDGAr8ALa2ew7IH3EpzvAfo5JxrXQ2IHf sLZ4EB5nDLDX73xGSnDgzdqSm+t945s23tywANPUYPlJARM4E5nRUtDKoU6msAgUvOSt ZXFw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1742188804; x=1742793604; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=T18/LmksYiI2JDaALAx8F0tVbVplhY6o09bZJuKtckw=; b=IdHRQUcokYBlF1kaHiUb6qzrgvHZciKOCj8ZzNHALafvBnM4jueHMvYvU0UOtEfBPG bAir0FPY6wn76bOMwCntGE3zxuyeu3LrA8pRtvdXUnCELGX9gDHd++NE8iB532AMjy4v xIaVAzcw8IpkpTiHYsQmVQRdsVRE6Bhf7Eif/fX5mBleesyEerDcxMb+QrVM3LQfljbw oYOAQUqGi2R5ztuu3oamzzORwui3wdAR0SquaiGQ8yUxXL5i0wdiXbHuc/lWZKr2+hR2 uYbzM2it3A/jBgwO6z0keRLfjOYRRgGc/glbG/dsKt4lYPnEjgf0wrRlIYXoyB6v3h7J UNmw== X-Forwarded-Encrypted: i=1; AJvYcCXGfRs8ztyRbnfvBIPyXUydinE2OXu9dSt2akecWpqPt23taxPGqJH6VSuxYnvJur8EvY/+zbWkGC8=@lists.infradead.org X-Gm-Message-State: AOJu0YyCwrOBKIm+CFP6zLGFdA3XuL6i4HBKWWefXT4j8g6Hk+n+sybl UZNWdJiEPxuIupXQCiG2l91HWoXt3j45iBKHuAlheBwe+CLsdHrP X-Gm-Gg: ASbGncs4MFwx28Ps4tmdKcwSWYoLZFggGN8u/DADAJz4u0/AZ3qqr/D9BnLIs3lmtWH +Dv2rtsDFFBoHqXVEcc4E1kHS/+FZ+7V+dvvFOJSFrGaY2O/vx9r7pLEarahTRJDUgdA67rDpW6 P/EuyjaASRsy3UG/8k0FE8mErNBcmx7QjzgBbT+iwZDTVKCfwM6+tk4XyS/d6MAQBHLTmNpQY9N 1ja/nheUsTDDaCqw8T08AIHX3zuM8U7EYoBGJcwNcVac7Cwq4NDstXFTKmmARtEo4/dVFwIRY8z YuSPTBxWYs8KQACFm8j9rObyzvvcq2VSCW85M1//2ZlLxE1oUXY8Cy0= X-Google-Smtp-Source: AGHT+IFAseff1yIkZHzc1rGdhQPKl7uycYfsnTrI/GVu4JilKm2nddWrecFI4sABECPAMNZYRmECeA== X-Received: by 2002:a17:903:41d0:b0:220:fe36:650c with SMTP id d9443c01a7336-225e1782e22mr164178955ad.23.1742188803960; Sun, 16 Mar 2025 22:20:03 -0700 (PDT) Received: from cs20-buildserver.lan ([2403:c300:df04:8817:2e0:4cff:fe68:863]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-225c6ba721esm66029975ad.149.2025.03.16.22.20.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 16 Mar 2025 22:20:03 -0700 (PDT) From: Stanley Chu X-Google-Original-From: Stanley Chu To: frank.li@nxp.com, miquel.raynal@bootlin.com, alexandre.belloni@bootlin.com, linux-i3c@lists.infradead.org Cc: linux-kernel@vger.kernel.org, tomer.maimon@nuvoton.com, kwliu@nuvoton.com, yschu@nuvoton.com Subject: [PATCH v1 3/3] i3c: master: svc: Fix missing STOP for master request Date: Mon, 17 Mar 2025 13:19:51 +0800 Message-Id: <20250317051951.3065011-4-yschu@nuvoton.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20250317051951.3065011-1-yschu@nuvoton.com> References: <20250317051951.3065011-1-yschu@nuvoton.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250316_222004_867668_6C8F9071 X-CRM114-Status: UNSURE ( 8.77 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-i3c@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-i3c" Errors-To: linux-i3c-bounces+linux-i3c=archiver.kernel.org@lists.infradead.org From: Stanley Chu The controller driver nacked the master request but didn't emit a STOP to end the transaction. The driver shall refuse the unsupported requests and return the controller state to IDLE by emitting a STOP. Fixes: dd3c52846d59 ("i3c: master: svc: Add Silvaco I3C master driver") Signed-off-by: Stanley Chu Reviewed-by: Frank Li --- drivers/i3c/master/svc-i3c-master.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/i3c/master/svc-i3c-master.c b/drivers/i3c/master/svc-i3c-master.c index 57b9dec6b5a8..e0cd3ce28b7f 100644 --- a/drivers/i3c/master/svc-i3c-master.c +++ b/drivers/i3c/master/svc-i3c-master.c @@ -592,6 +592,7 @@ static void svc_i3c_master_ibi_work(struct work_struct *work) queue_work(master->base.wq, &master->hj_work); break; case SVC_I3C_MSTATUS_IBITYPE_MASTER_REQUEST: + svc_i3c_master_emit_stop(master); default: break; }