From patchwork Mon Mar 17 10:27:25 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bharath SM X-Patchwork-Id: 14018806 Received: from mail-pj1-f43.google.com (mail-pj1-f43.google.com [209.85.216.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1945D21ABBD for ; Mon, 17 Mar 2025 10:27:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.43 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1742207279; cv=none; b=unRV84Ck08zJUErbyjDYrZvW2913sE6FAgIuCG3/86qxAbGTemv/xU5PEMJ3h6x3Zz36ezPUaa3komVy4TzLSGFdq9UnqSxgnEJ8w0VkUaRE3apq+2lLh7c1AeEVrGZ+IKwYMSUglUOFr5nzi/PLh20ma2R54YTaT5hw7IJQGao= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1742207279; c=relaxed/simple; bh=joC0FfI9R/zsaj2hUG7YGS6cm0VTcOFbBDbIVtP4Js8=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=JaRlW939tfvpXrsak+unr/0tEuqUkqp3djnW21sZsSTwm4oEZzy8D7FmMNeUX1yQdlB+ZOafvSX3YPpG/Ny9pfNTrzOWn9NsaJuLIB3xyOk9C2ihmbSlQLfLUEAvSsIoW0s4gA4d08vkgaX0RGX+sgItgxmYxEpEGWMeoPoybK0= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Wmxq2naq; arc=none smtp.client-ip=209.85.216.43 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Wmxq2naq" Received: by mail-pj1-f43.google.com with SMTP id 98e67ed59e1d1-3014cb646ecso2060152a91.1 for ; Mon, 17 Mar 2025 03:27:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1742207277; x=1742812077; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=LvZLK1SD9HMrEMDfOJB8gpe5ENAtsg0cbaNhdl8V7fc=; b=Wmxq2naqoWmpWKek9i4t2UB6LPBFGX196MMaZA2qhfa8s9acp1ND3j0lK6V1s6ot9x l7c+JGgceh0fMPj2c3Y3a+3d74sJHIzfmgkQyWMW9hbR6X18yxZTbmaOaH1zFbgCWOTB FwWfFxxWV+Zgs1ynBx/VD9ZCYY6re3wdmuUGiZYJzhPhFPWwbWrsTwj5b3G4eFOV38Hv Q3jTStlVcq24iXd1VYP0Krus8PysSFcRSuzsvIRPMTFO9ICVHJKY53yYbs59XV3t4X5Y /WWzGkJHPWOeH4MDL/YJ2jpDaouTxibyVNmgn1o4h52qVE/YXPz1GwUOna+zPK/1xYRP /CJg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1742207277; x=1742812077; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=LvZLK1SD9HMrEMDfOJB8gpe5ENAtsg0cbaNhdl8V7fc=; b=Q3CrQMembcPQd0UMMvqynTVrw7JOPDovcSK2445Xe6VuMsErqjfSu6nfx3xEa2FnfV 8RlFVpIT1qZgE+yPI+WgbP2k4js4UxYBUEsAYsQwlvJJySpMPXahzGldXVkRjLlt1trv vS/pm7fGawownQiPR4cvLpG6GfbgbJ7Sa2AEUXfH4FgynD/s0hHDqqv8A5oSalOmt+FB TZx1NXEG/2aPn/36DbyyhFuTI3ZjfsowrNp6w+u2cSWz4U1HfHWTp6gPfOezFZkyfWYY TLMQceWdKbeOEAmtjGNHjxW4nVherRpI1PK3cUqvJSmk2M5yzMzkFBLWj2PDJby6ylcR n7FQ== X-Gm-Message-State: AOJu0YyzOdPw+8FJATZLPPuM8IaoNjXLpQ/RQLGYlFGRNSA6fMU7CR/F vfRhAhZtSAu3h2CVn+oT9OmNdDNh5VdQWJJTczxATKRLndbnD49oUYFrcfoM X-Gm-Gg: ASbGncuZ8J8kSsNj4eYw0RDoKnhcAR9VgfVRo7vN2nn7yD7BOZ5gMD9mTepslDNzy3W 2vIujPX7/Sbs/aM/OFEAifIT0EMTLOO3cXTP+qu/ejqr4LDaU0w0B4f0u/RjPdLPx2Z2P6mw+vd rO4+kBP9AtwQ9ZngtqFGhlggtwOl7FPrYG+Ivcz//8togG9w6PLFo3zyJHsCch3jCu3ditCG/+O RdkuH1AN9DcgO+lNuEqIr81ZouxyJRayBFLXHbvjGlGYMLIsATOKy2KC2a2giP0prVjP8x2Ia5X w6orm5qy/zeopsaWOr8J/1EInlJMGiaraRTIuJM1e0vq7Ven+m0Ocm/dFRzDihIYv2yR8A== X-Google-Smtp-Source: AGHT+IFNMpNep8CylO6nSTPrUBdLJZgVg1ao0/qupUL3Ri0yMrvb2nsaO7Itxbk0jokBRWnH+xoD6Q== X-Received: by 2002:a17:90a:fc43:b0:2ff:5357:1c7e with SMTP id 98e67ed59e1d1-30151d049ffmr14809235a91.20.1742207277084; Mon, 17 Mar 2025 03:27:57 -0700 (PDT) Received: from bharathsm-Virtual-Machine.. ([131.107.1.189]) by smtp.googlemail.com with ESMTPSA id 98e67ed59e1d1-301539ed069sm5738238a91.17.2025.03.17.03.27.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 17 Mar 2025 03:27:56 -0700 (PDT) From: Bharath SM X-Google-Original-From: Bharath SM To: linux-cifs@vger.kernel.org, smfrench@gmail.com, sprasad@microsoft.com, pc@manguebit.com Cc: Bharath SM Subject: [PATCH 1/3] smb: minor cleanup to remove unused function declaration Date: Mon, 17 Mar 2025 15:57:25 +0530 Message-ID: <20250317102727.176918-1-bharathsm@microsoft.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-cifs@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 remove cifs_writev_complete declaration from header file Signed-off-by: Bharath SM --- fs/smb/client/cifsproto.h | 1 - 1 file changed, 1 deletion(-) diff --git a/fs/smb/client/cifsproto.h b/fs/smb/client/cifsproto.h index 81680001944d..39322b4931da 100644 --- a/fs/smb/client/cifsproto.h +++ b/fs/smb/client/cifsproto.h @@ -592,7 +592,6 @@ int cifs_async_readv(struct cifs_io_subrequest *rdata); int cifs_readv_receive(struct TCP_Server_Info *server, struct mid_q_entry *mid); void cifs_async_writev(struct cifs_io_subrequest *wdata); -void cifs_writev_complete(struct work_struct *work); int cifs_query_mf_symlink(unsigned int xid, struct cifs_tcon *tcon, struct cifs_sb_info *cifs_sb, const unsigned char *path, char *pbuf, From patchwork Mon Mar 17 10:27:26 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bharath SM X-Patchwork-Id: 14018807 Received: from mail-pj1-f47.google.com (mail-pj1-f47.google.com [209.85.216.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C1DBF221558 for ; Mon, 17 Mar 2025 10:28:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.47 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1742207307; cv=none; b=g84d0jl83PfV8lR83IglRiRs1zUtuHsvtjzretWErUgGSYODoCEUfVmOGgA7qxZnARhpCbxmyRRjNCXz3H6NXBTv0JmGOTpl98nY/mceKO68kOdCejiy0+e1hm7A0aYuANdcfdyVaAmaJ3vLzB0wjgdV6D/ueEZZUgDOULtYzg4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1742207307; c=relaxed/simple; bh=5tQorah1bZetOU4OzdKCRbF00BfGQ1JP7Ey3lXryNCw=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=J0KeP0SFvW2XgnkOruMnlNrw7rhwCuAN6xSFm5SDMtC8xqAymDi/gkPkkyvQVB+vXHEo+7FZseOk/oUEAonEW1p4KTOzO3+gWwTpgBPxpeSgRqvIOBG1J41m7l9G8oJ2Zztc1KHy8jAKwjeTq/9RQrj2M/fZJCzSa5zKJeMZfjo= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=kqnJvhMW; arc=none smtp.client-ip=209.85.216.47 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="kqnJvhMW" Received: by mail-pj1-f47.google.com with SMTP id 98e67ed59e1d1-2fecba90cc3so4164123a91.2 for ; Mon, 17 Mar 2025 03:28:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1742207305; x=1742812105; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=4/mRydKfbUvIsMpF7WoACoY6ufihfwIRFP8PTW9XM5Y=; b=kqnJvhMW3l9e8ZLo5dkbVjnvPwo196lL29QDnkKCto/73fJzf0rgtvCTEwXkkzeqA2 mn/F1SnJUQnpkkUtAUolnr5uLUIJFxqu+my0v2Oa4Ro78CnZhTsUhEjfm8S0BXlegGFG DQBGqW3eQDhrZVdW3lvZgNArpwK1OCWXX4pxftISsl07lCTnOuT7bHqGtCB51d+9o3Ad Mbx66DFfJY+OAOLucgfREc8YF896n4RxIj8/AJ1dEb/KY6JRi4rYTEcB+uphGKEI+f9Q iyvednRSNNvClGsC3SKVGn6HngXjdrU0VSH8ifmMeawbhotiVfXxccwXdwZezJzb0Mnw F5fw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1742207305; x=1742812105; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=4/mRydKfbUvIsMpF7WoACoY6ufihfwIRFP8PTW9XM5Y=; b=jx2KFxLm7XIRnc3xhVafrMF8LHg2JkK/B74HIJfnPnP58iw/f/diJa26SOjLQ9/YAn gvWoRsrIqjSUH8a7wlez90A+/McgR6/m0nrP/Nj5AeQvreqN3aMgZfW56YE8LrELzrMK tYsbGK0iOWH5VhZ2csq+JkG9Tp+kaD0giR9OkAg8hE/rI1Dbwe+zdcVV6ZwiO/h59VZ5 ujFFEevky2S6DddbfQNArKEfuaSdPXNd63qwDRWXpP9gOo1BGYoUF2aHc9c25MWdItKM Ex7i0Y6cbDtxIoCIimKRWwr0z/CAe4RE6KwjIidPcyB8LoQR81Dvuop4OlyY8PPOJj6L RwqQ== X-Gm-Message-State: AOJu0YzEouevFZMXSNvtHdwv6o7bGIFLX1nIuQrVkPzc45ikIwjCcKwS 2bJK7EBYbGGbUD9/jDqgVUILLmutg9lT86dZ0ungDwzrs9cPkmbW0JJx1feY X-Gm-Gg: ASbGncsrDLaiyHPZ62gpcp+6Ksw/xFMPnOnwjS3XIP04h4BidfT23ITDSlWtU7F5+Nn piN/y0h/N5am72B2allyJgPcVYSiACJLxo59MF2DG+TLfsF0f9j7x1yecHxvhk8RzmkY6QnhHAu OlNRzTQQHCaoDqe6DYpzTDyY1p7k8lcjHanO243lqLewknmfMV6i9bUj3fWYcHi7HpaxqihtSzW ubUHgoEk5xcPyKuz5h93G6pMmEVyX+Gt/sz+sWW1Ee1RPJCJ7jlGG2Kk03tbVfLrPc20O95pH9W PJP0Qsk4HQbFEPCy67wREaPCQmxplnSeuu4o8YN55fSHjsvZkg/ycnIabYVYqDpb+SJrjw== X-Google-Smtp-Source: AGHT+IHjab6X+dG6QiPdEALqTQFguxgH4ebzhIukB7NrHmf22QA320jvlRcF7X1qDtbiPNcEEkIFEA== X-Received: by 2002:a17:90b:520e:b0:2ff:6a5f:9b39 with SMTP id 98e67ed59e1d1-30151ca8599mr16162749a91.18.1742207304807; Mon, 17 Mar 2025 03:28:24 -0700 (PDT) Received: from bharathsm-Virtual-Machine.. ([131.107.1.189]) by smtp.googlemail.com with ESMTPSA id 98e67ed59e1d1-301539ed069sm5738238a91.17.2025.03.17.03.28.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 17 Mar 2025 03:28:24 -0700 (PDT) From: Bharath SM X-Google-Original-From: Bharath SM To: linux-cifs@vger.kernel.org, smfrench@gmail.com, sprasad@microsoft.com, pc@manguebit.com Cc: Bharath SM Subject: [PATCH 2/3] smb: mark the new channel addition log as informational log with cifs_info Date: Mon, 17 Mar 2025 15:57:26 +0530 Message-ID: <20250317102727.176918-2-bharathsm@microsoft.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250317102727.176918-1-bharathsm@microsoft.com> References: <20250317102727.176918-1-bharathsm@microsoft.com> Precedence: bulk X-Mailing-List: linux-cifs@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 For multichannel mounts, when a new channel is successfully opened we currently log 'successfully opened new channel on iface: <>' as cifs_dbg(VFS..) which is eventually translated into a pr_err log. Marking these informational logs as error logs may lead to confusion for users so they will now be logged as info logs instead. Signed-off-by: Bharath SM --- fs/smb/client/sess.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/smb/client/sess.c b/fs/smb/client/sess.c index faa80e7d54a6..b45b46b1b792 100644 --- a/fs/smb/client/sess.c +++ b/fs/smb/client/sess.c @@ -242,7 +242,7 @@ int cifs_try_adding_channels(struct cifs_ses *ses) iface->num_channels++; iface->weight_fulfilled++; - cifs_dbg(VFS, "successfully opened new channel on iface:%pIS\n", + cifs_info("successfully opened new channel on iface:%pIS\n", &iface->sockaddr); break; } From patchwork Mon Mar 17 10:27:27 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bharath SM X-Patchwork-Id: 14018808 Received: from mail-pj1-f48.google.com (mail-pj1-f48.google.com [209.85.216.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9B38823496F for ; Mon, 17 Mar 2025 10:28:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.48 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1742207314; cv=none; b=gKtfckPllJjn4c5UEQ/hTESOEZzA7Ir28yZjobAxD9OFzzSCovlcv72hA7T0bo8JuBbj+iw6pbfApgFxJU/wRm2A2ZK3fLESnDCZRlcxMaPHWxSVptxVRZP1zwxIMy3kb/PeSjfr6mjPz6W40OasmqMq56imUSBWIYm0FpC971w= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1742207314; c=relaxed/simple; bh=oOR7y8/Uzgm9Nii989X69pYFZDHK3+S1uw6RWMhMgps=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=M4vq7RvhdqwqMIRvZE+qi+iByCOkYGslqwrXoZIuMPaNAiRjNJQfLJCwi9/UWPHaq1FARjUJSh6hU6CUH/O5JwGPQY394W1xzrzuv3KI6Dz58TdXXCpK8zH8eCOt8PVLS10ctvUWwsI2wlWPT3RtPnzFXywX88GwHMxV1iqV+Ck= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=GvkabXKu; arc=none smtp.client-ip=209.85.216.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="GvkabXKu" Received: by mail-pj1-f48.google.com with SMTP id 98e67ed59e1d1-3018e2d042bso741921a91.2 for ; Mon, 17 Mar 2025 03:28:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1742207310; x=1742812110; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=hSSv2FJT3eg7+0pK21SUTeg+hNLf5nMrrWUyhSxCCqc=; b=GvkabXKuQnimx5qFaK7MrmDc77MePgQikgPjhcOYIeKXKXesrbeubx6Ybdz77uNdT+ AsvoDxMgDFL1XV3F4v6KmJpGmzzS0+ph4YuqifBuxcKibZ569/mhoe045zRk4lxARR26 Gk4eiUCfOMbpsV9voQ1vpQ3tRnisKCMSsR/BAqPRc5PNlV8LNX4UTRoZmuBDrlnQv+NM FCNRESh7JAiwkJcHi1g87v5cWaYiNXsbaplagoOjZbWDlEEXJ+XO5xqRfYND/al4NDQW O2z74KD33IfCAfAYMlotwuLwVm5aW454Uo5eDJp7wDo6Hrh2g4Zc3icoQuxf7BOP5F7n 1mSQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1742207310; x=1742812110; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=hSSv2FJT3eg7+0pK21SUTeg+hNLf5nMrrWUyhSxCCqc=; b=lr1J7Ut3HjJ/vemGwNBYYW+0prEyWr6NLlIpwB11en9CsuYpWLhUSg2cm1jkMXwMy5 n34mfQdv1RKqWg6/d5lyA1Dny7sFRmVlwiMAgLJMxkYVl0fGnhQSD/kQrJxXbfcwafhD 7gCi5xkzXiUFl4O+49OCXM/pA73ideC6I+80Wp20JNfGyPQAqvsUJA/NUZZauqaWm4Y6 7ZBt0vHxXvvVd4z+v64+2Hn8IuTX/8/de/b8V2Su7ZiBicpGmKxiHIK0mrgK3Ks8Rluu jh71X9HuSVzdrgqoFRtoAIHLXLSeozQ219gHaZ76vGKNJvVBJL+HTLaq+CkZBKHKseGj 5zQA== X-Gm-Message-State: AOJu0YzohnNIgbr5DxbMYJiNkw8ckV20gC19SZXoB/JixNZaz0IN9eU3 as19twfOV1UN2/f+73I99paGJbT9cygb73R3nX1MCES+GBdwPV4HyLOS0AQR X-Gm-Gg: ASbGncsTP+tlqCg1hAGAmdaJw3eHlvkELZLpSrkwqjoXM6OCxNLy9J9qNhYyJ306toc d3C8KyzbVmA2Ko8SSoT5eRBnZnjXNdaKTw+zNpo5FkITZ9LXiCtTrQ+91o6q10ogUHGQsaomK20 popfSF6WFR9/kvW29vu9pCXCbnZUBWryiqsSEu3zF41sb6UaJKpsdDEuIRdJAhzKigTcShoqwAs d7YqcztR3CiuOSZCLiipGc5s7U6eWeNQsU3pNd/mqvpK7aYI4RrcnLzsTc8BY7LsRL5HqkxrEht SjZORCZKmbtIeG6mfVzhnnsPNZ/urdD34AvM3VHVGM+9JmqOlMTh2yTQ0ZuBhdqBpsB1hg== X-Google-Smtp-Source: AGHT+IH4HSGCwVo6FvnQgN3z62IoMYqQ08omofIxdqH7BTnYmYVYEZXlT0p1SYa1nGOzNfr7xMNBdA== X-Received: by 2002:a17:90b:51c3:b0:2ff:6ac2:c5a6 with SMTP id 98e67ed59e1d1-30151dc757dmr13474777a91.31.1742207310489; Mon, 17 Mar 2025 03:28:30 -0700 (PDT) Received: from bharathsm-Virtual-Machine.. ([131.107.1.189]) by smtp.googlemail.com with ESMTPSA id 98e67ed59e1d1-301539ed069sm5738238a91.17.2025.03.17.03.28.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 17 Mar 2025 03:28:30 -0700 (PDT) From: Bharath SM X-Google-Original-From: Bharath SM To: linux-cifs@vger.kernel.org, smfrench@gmail.com, sprasad@microsoft.com, pc@manguebit.com Cc: Bharath SM , xfuren Subject: [PATCH 3/3] smb: fix secondary channel creation issue with kerberos by populating hostname when adding channels Date: Mon, 17 Mar 2025 15:57:27 +0530 Message-ID: <20250317102727.176918-3-bharathsm@microsoft.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250317102727.176918-1-bharathsm@microsoft.com> References: <20250317102727.176918-1-bharathsm@microsoft.com> Precedence: bulk X-Mailing-List: linux-cifs@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 When mounting a share with kerberos authentication with multichannel support, share mounts correctly, but fails to create secondary channels. This occurs because the hostname is not populated when adding the channels. The hostname is necessary for the userspace cifs.upcall program to retrieve the required credentials and pass it back to kernel, without hostname secondary channels fails establish. Signed-off-by: Bharath SM Reported-by: xfuren Link: https://bugzilla.samba.org/show_bug.cgi?id=15824 --- fs/smb/client/sess.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/fs/smb/client/sess.c b/fs/smb/client/sess.c index b45b46b1b792..f2ab8513c3ed 100644 --- a/fs/smb/client/sess.c +++ b/fs/smb/client/sess.c @@ -494,8 +494,7 @@ cifs_ses_add_channel(struct cifs_ses *ses, ctx->domainauto = ses->domainAuto; ctx->domainname = ses->domainName; - /* no hostname for extra channels */ - ctx->server_hostname = ""; + ctx->server_hostname = ses->server->hostname; ctx->username = ses->user_name; ctx->password = ses->password;