From patchwork Mon Mar 17 15:44:01 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Breno Leitao X-Patchwork-Id: 14019596 Received: from mail-ed1-f43.google.com (mail-ed1-f43.google.com [209.85.208.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 678222459DE; Mon, 17 Mar 2025 15:44:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.43 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1742226267; cv=none; b=nX1eu/1OqLP4BfxPWv3CdDxpprWc/pbzHjHZqC9uj8JwZ07Rgm/Yx8p2oixCovUoHGiHT0KD/NBj/05izObPkI3gGUu47A6EMQscO2qA+Hu15Mvl5PB2wJzsU8iQ5zBrpBEkt5V33oyn+p/VKaX+vEe/BL1MxHlCQURsoRWGJoI= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1742226267; c=relaxed/simple; bh=7lqJsGwVtb8Js7p+GzX5jgzbAm4CExvrwoXmyc966GE=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=uNwQXyQkwMmNuXPHBI08mGRAgCb5abdzI9+scetfjL0AhQ2s3BIw2lEBn9wd3AY7n2exTRvIXNF8mjJtF+eccQiDf0TevXTMiVSYPrprUfZPL17G11Iyo6VdeqQPvs/PcSFUntSTmn7t7TDOq/ov65YsZxDrzcfUzwlNTbmnFvE= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=debian.org; spf=pass smtp.mailfrom=gmail.com; arc=none smtp.client-ip=209.85.208.43 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=debian.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-ed1-f43.google.com with SMTP id 4fb4d7f45d1cf-5e673822f76so7614625a12.2; Mon, 17 Mar 2025 08:44:25 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1742226263; x=1742831063; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=amP3yIokAbOD+ubVkl63TWa65eOoOccbBKc0TbdlwY8=; b=WjfTiuI0cYtfd8Mzd5JdOOuURBjCOwQr/4PTJfjPHaRKQ8ntVPjttp9ENac2OEo+SY cdW05C6zkRRZRlKDnCcYQD++/TA5WRMXy7xucArCMXXgUX0r80nmM6NkfiDhLxvVsQ8b ey2bP3aiOeEGBoq+W0dIrcBjoBR/enNU69YJCaTOH78W8EcNjvujizrvmAp6hA+Tk4iL cxd8dHB78QQi+nlfRsVJP83U7EObYMm3uovZ7RlgWfwP2QzgNjfEGs+y7UXBuBDRwYoL Km7Zp8Ts3p2/QpbfBgfurqN1rIJEJ7tec8uRVpHzeach7mZ1Q2o2UNFxGc6oHLf1jJRT 52Jw== X-Forwarded-Encrypted: i=1; AJvYcCVY7f2/ypqKanrepKWCmlyxBVIG4kSexCBuk6udR25Tk7IIzZE0R/Ne1UxMyxYRBPhjDHIFDROEURqZ1yE=@vger.kernel.org, AJvYcCWrUOFm7d/N8BSvJx/RoWjOIltBlHAYw+uhsW2n0bVDE9lZdIaC2aEvWLvunpbvjVtbFfIUnbzuA+kA@vger.kernel.org X-Gm-Message-State: AOJu0Yx96VY4AitlvkeBN7cnQ2N6jdhiyVL8s+F5668tCq1HMIXAt8bH rUJr7sPLnXX625UabzBaJ8c/MAZwSGK2j6/HWOFRKGXgUICvm52I8yGq/g== X-Gm-Gg: ASbGnct1Sds7OLBxyUdykIK92ly6yD2K8/830LRi9SMVK5VG3wIVyK5cLxIlCzzSbWz WR+s4K8xIWUf8AG0dPi2h8a4+yxBV+AN2+G897z0QFUC/kGga0EX0SpexnnyAcin5siNxGpBDQ8 goKXRHq1oVU+KAdIboNZqYRxxskSJG9cxZKJn4QqiMEwI1cdjwJAOgqWUIlV8qzhFP/ygsq9dja yZq69xQluBiiOJw6z27Bz6Dk1OWEVcA5cE7Yp+sG6dUz5C45CxRNwVNHpKNDwWJW1I9Qqlbr0Oh hX2eW9zRgDinDwXHtLll9ZDEbp3vviFV5GA= X-Google-Smtp-Source: AGHT+IGq7DZ5UNLafXVHskpiX36HCMaCB8WgZvhYhy7rMQH4hd6SMHH5LtASdYBOdAjFfzFj0Ob8Kg== X-Received: by 2002:a05:6402:278a:b0:5e7:e3f3:8647 with SMTP id 4fb4d7f45d1cf-5e89f645652mr13935469a12.19.1742226263097; Mon, 17 Mar 2025 08:44:23 -0700 (PDT) Received: from localhost ([2a03:2880:30ff:7::]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-5e81692e69csm6060797a12.3.2025.03.17.08.44.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 17 Mar 2025 08:44:22 -0700 (PDT) From: Breno Leitao Date: Mon, 17 Mar 2025 08:44:01 -0700 Subject: [PATCH 1/3] spi: tegra210-quad: use device_reset_optional() instead of device_reset() Precedence: bulk X-Mailing-List: linux-spi@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-Id: <20250317-tegra-v1-1-78474efc0386@debian.org> References: <20250317-tegra-v1-0-78474efc0386@debian.org> In-Reply-To: <20250317-tegra-v1-0-78474efc0386@debian.org> To: Thierry Reding , Jonathan Hunter , Sowjanya Komatineni , Laxman Dewangan , Mark Brown Cc: linux-tegra@vger.kernel.org, linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org, rmikey@meta.com, Breno Leitao , kernel-team@meta.com X-Mailer: b4 0.15-dev-42535 X-Developer-Signature: v=1; a=openpgp-sha256; l=1828; i=leitao@debian.org; h=from:subject:message-id; bh=7lqJsGwVtb8Js7p+GzX5jgzbAm4CExvrwoXmyc966GE=; b=owEBbQKS/ZANAwAIATWjk5/8eHdtAcsmYgBn2ENTdHMnT2BPgxtv6falAa6UurBPSw/ItM5zr C8t8T0iQ/yJAjMEAAEIAB0WIQSshTmm6PRnAspKQ5s1o5Of/Hh3bQUCZ9hDUwAKCRA1o5Of/Hh3 bZZDD/0Rq+kMnPCrxh9sAeXLJ0DccZnOBpN+rSXFlmJYC3HJdss2iNkYYyxcRga8Pkf61PUbofa 31E6oZ7NyjJsw7/Ay+5scN0ii+GUFq2bhU8UOX4YfjlL7/4VT7I57vhMoqEQDuBkzCJ9XG7nPyd 5Zkzpe2KBMo9uDPaWBdP/86jrxFBJMi7ElyaV+mwZuBhZ3tn1mpUJrRFnul7XgR6zIvHJgjOO57 UcOjFvMgb+ZiEcNSUTqo6kKhI283DsoIasokRnbO2EW/Vn+6BJQ0rfSuKTAk0svc66u3HsPjILw q0Y92qtqokaXZVTUigtLCPFxOo8fq6SWSnrgWzNi9+jD7Be+JlGpIAfGX0Rcupoi5AwUnQTGSXT 5B0BSkZcZyiQ0EXMcPUh9gtgMhqYxxlQU4c+hrpkjT0MNdSoX9HeONlMtiz1Eb4/gVpf144FSY0 p4yKtmX1o9JCpajIvGZEeo40uyyLVmYjqiPfJPwmBqICSZJb+sVjxV6XdMqi/A9ngsMSjjdtTri B8SGVNtv19AWPozbvOoDgL6n+bRTomTCbSloca5QjshHlbyE2gvwfgQYUr5SMrNYPu97VDsim60 s6s4glHEMPSDZ2aQqBRTWVN+fo2rS+I3XAiNqKulHtv61M8EDzLSw0dBr0oQSUCgWLeDpSxX+5/ K83x1Hhz06tFVhA== X-Developer-Key: i=leitao@debian.org; a=openpgp; fpr=AC8539A6E8F46702CA4A439B35A3939FFC78776D My UEFI machines with tegra210-quad consistently report "device reset failed". Investigation showed this isn't an actual failure - __device_reset() returns -ENOENT because ACPI has no "*_RST" method. Replace device_reset() with device_reset_optional() to prevent errors when the reset method doesn't exist. With this change, the function only fails if the actual device reset operation fails when called. Signed-off-by: Breno Leitao --- drivers/spi/spi-tegra210-quad.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/spi/spi-tegra210-quad.c b/drivers/spi/spi-tegra210-quad.c index 08e49a8768943..9027f995a6669 100644 --- a/drivers/spi/spi-tegra210-quad.c +++ b/drivers/spi/spi-tegra210-quad.c @@ -999,7 +999,7 @@ static void tegra_qspi_handle_error(struct tegra_qspi *tqspi) dev_err(tqspi->dev, "error in transfer, fifo status 0x%08x\n", tqspi->status_reg); tegra_qspi_dump_regs(tqspi); tegra_qspi_flush_fifos(tqspi, true); - if (device_reset(tqspi->dev) < 0) + if (device_reset_optional(tqspi->dev) < 0) dev_warn_once(tqspi->dev, "device reset failed\n"); } @@ -1149,7 +1149,7 @@ static int tegra_qspi_combined_seq_xfer(struct tegra_qspi *tqspi, } /* Reset controller if timeout happens */ - if (device_reset(tqspi->dev) < 0) + if (device_reset_optional(tqspi->dev) < 0) dev_warn_once(tqspi->dev, "device reset failed\n"); ret = -EIO; @@ -1606,7 +1606,7 @@ static int tegra_qspi_probe(struct platform_device *pdev) goto exit_pm_disable; } - if (device_reset(tqspi->dev) < 0) + if (device_reset_optional(tqspi->dev) < 0) dev_warn_once(tqspi->dev, "device reset failed\n"); tqspi->def_command1_reg = QSPI_M_S | QSPI_CS_SW_HW | QSPI_CS_SW_VAL; From patchwork Mon Mar 17 15:44:02 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Breno Leitao X-Patchwork-Id: 14019597 Received: from mail-ej1-f42.google.com (mail-ej1-f42.google.com [209.85.218.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F1FDE24C667; Mon, 17 Mar 2025 15:44:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.42 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1742226268; cv=none; b=cECtLRk1hRjl0CvOsYBnOFK9+Rm4XPCFLz6BNgjQkJBMRwhRO+pV4WHzgPT4jcl051Y57P9yIYajdgzCvpPcbyWLdycNPYb3b/NyeyPfp/sxpJXIpIZLTIMZqGeRjxT1k00ZYO/OYr8SolI9rFvpmGnLJAAptUz21shCE+MEiG4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1742226268; c=relaxed/simple; bh=KnmPwZPonz8hMJ2ZmfE0STnrpgQvBXeXDMZ0NetHK1w=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=bwtfUCNzm0noR1glTAOH1OMEUPlwFYCQFjxBnCIfPX3PePbDSQUbVwLwDlmp9Fg/L8yheOvIilmmZul5P1gUfysOXQkVg7aS4YC+mCSk3PRCgJdj/c6ceXQMv8ssUrFtDOhm5qDPtfU2ezq+WowCVKUU/+gqeSN84SXybB13+pM= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=debian.org; spf=pass smtp.mailfrom=gmail.com; arc=none smtp.client-ip=209.85.218.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=debian.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-ej1-f42.google.com with SMTP id a640c23a62f3a-ac28e66c0e1so718607666b.0; Mon, 17 Mar 2025 08:44:26 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1742226265; x=1742831065; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Wu4Tx1ZJPWIifFTi2LSxfn6zGS2x4Ovj/eqL/dD7jbA=; b=ZglrWnV6LqgRA6d6m/519utOHtMF37ogYf+Tu4m1R0grqMUa+50kmOpQ72u3r+siS+ PmeTMP0lqVXP2fzr077VKmJJ4+RViEuFkwX7fGOwBh8FXcl1+n+HsW0YgnMj5IWfln7G 7QPCRR9mHwAhuCgTXwOMx+XjQrpqk1AGV5yGBi14Lv0UiTQfD5JAzek1T+Mv4H0NCZPT F6D0lqdc5WVrglpNhzEbWL+npADXgC/s/t3pDbj+DvbVRWCwC9YjBvrrR1aOhgZcSC+4 xekQDrQSSPsL3lUN1/1/y9n9FolM2AOuFuqd6sDboYLX2pCY/yJ/0pak0M/IJ09WJQyp ZtBw== X-Forwarded-Encrypted: i=1; AJvYcCUkfO+r0rbyMlIYqMSZeuUMam3U1YmQY8jRtzR0dgHOtxUtW4/lFTySWv+2zlzi0XZe2nOHv0UMhTOG@vger.kernel.org, AJvYcCXvCQRr/AW3Qsy1KmSIQ47dHiXDdFGYBGd2XxvDYwEZ0MXR5Npasf0maKaeNrujWcuMGUPgIejs2Afrb1g=@vger.kernel.org X-Gm-Message-State: AOJu0YyZSeUqMC2ZCzYlTBvca3Eme0XjkRuoKOnM76Az9NlteLLgqX2B aDZ4Vq/JqCsdbEU7vujpnjmqjt1GGpILoURtrFIMZ4r3zk6FEbA+r4JWJw== X-Gm-Gg: ASbGnctWPaCe+PGvfteQI3TaIy6hVECPnXTlRNsLISeYI0Mlse7t1wL6hSdOwEoFUh5 Vqy7JhpDeRWYIfZOQNGNa6b5e+DpgfkXuI6g61nLtGISIDatH7nJ33oWoL2zPCeUSfvKwaR9jCP 3X2IgFI020vb1bJ+rpWIqMmJ7vRrIKaVrbZvgiIsgcODMxraajvY6MF8jMPk8nK4j0mM3/g9qaW Pk3+HzQmqHxdQXW9I1TRy2Z7MKTMhm9W4xeVYdUQWqVWtTgQ+pJqWydiDJ84XTnnB2/fEfvm08H Abus+Xuqed/1ay4ozPF8mtkjvdv3jisT0Nz+ X-Google-Smtp-Source: AGHT+IF+xcwfIlvZljdbNfQRt+4Wxw3YDNhCG1PLNNFJmgb7XIzzBn0XKBKv+bCq5ve72xib8nYc3A== X-Received: by 2002:a17:907:3d8c:b0:ac2:fd70:dda4 with SMTP id a640c23a62f3a-ac330272d02mr1213168266b.19.1742226264776; Mon, 17 Mar 2025 08:44:24 -0700 (PDT) Received: from localhost ([2a03:2880:30ff:72::]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-ac314aa6209sm677874866b.184.2025.03.17.08.44.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 17 Mar 2025 08:44:24 -0700 (PDT) From: Breno Leitao Date: Mon, 17 Mar 2025 08:44:02 -0700 Subject: [PATCH 2/3] spi: tegra210-quad: use WARN_ON_ONCE instead of WARN_ON for timeouts Precedence: bulk X-Mailing-List: linux-spi@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-Id: <20250317-tegra-v1-2-78474efc0386@debian.org> References: <20250317-tegra-v1-0-78474efc0386@debian.org> In-Reply-To: <20250317-tegra-v1-0-78474efc0386@debian.org> To: Thierry Reding , Jonathan Hunter , Sowjanya Komatineni , Laxman Dewangan , Mark Brown Cc: linux-tegra@vger.kernel.org, linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org, rmikey@meta.com, Breno Leitao , kernel-team@meta.com X-Mailer: b4 0.15-dev-42535 X-Developer-Signature: v=1; a=openpgp-sha256; l=1190; i=leitao@debian.org; h=from:subject:message-id; bh=KnmPwZPonz8hMJ2ZmfE0STnrpgQvBXeXDMZ0NetHK1w=; b=owEBbQKS/ZANAwAIATWjk5/8eHdtAcsmYgBn2ENTKwjEDi8uLoqKSvtLECgSBQwZnewajleHL CltFG22h/qJAjMEAAEIAB0WIQSshTmm6PRnAspKQ5s1o5Of/Hh3bQUCZ9hDUwAKCRA1o5Of/Hh3 ba9yEACBzsI+EPDFnrTMOTvWGdAV6J/1I8wmT/sbR/mEmzeA4Og+DxNN2z2mrxrISoP3fXlhc4F iFFiwp5QRC+wdczrgNU1maVPYGNImq5lTECqmWilecGB2fS29ExK6U2POrgDDtruA0rtfPgZVcp hV6jEITJ4dJhdPY5XaymeTDYHNfQh/40/p95QYDGEJe1bQ++OYKfEt/GTpqT8ln6mSG8i8Xe6IS a6mdPdgQxzMnUsDTK5bXDNXZh7/wi9oHCuAUVSbki60b+awSRrcqLY29An5uYsP/i/fh2MwsPHJ S7Ts09SWc0Zbs091TzM9DeKsW85VTYkAzSC4dAaSl5L03pjKVf/cV1LwAvCucf9craMoMq4KhlZ uNbAdxGymuPrTp3SfPps+hZsLP6hLxRH2PT1jYNa90GCeyZLc4NY8rYy1sD5fO7evLk6UoBt9W9 SgNBmTT8D0oyHyKS6Gr0osEHLZvTZEMU6+XpWCumu43AFYEF2gvv1K1pP3JX+lt5dAl9x5eYjlL kfHJL2MoQHXyDxwPMFfJh8m1xnK+U/EYBfEgG/oSH6LWOD5JmJamR5AuPy7iwxBgNXskjjTKV2Y WtS5uLKRWFjUgWAx1/38Usw6FOJBO7kN2Brh7jZhnu3tShofaMhshOnLQv9q++ciUOlEXFAk52A 78v5OzCwgxEYuTQ== X-Developer-Key: i=leitao@debian.org; a=openpgp; fpr=AC8539A6E8F46702CA4A439B35A3939FFC78776D Some machines with tegra_qspi_combined_seq_xfer hardware issues generate excessive kernel warnings, severely polluting the logs: dmesg | grep -i "WARNING:.*tegra_qspi_transfer_one_message" | wc -l 94451 This patch replaces WARN_ON with WARN_ON_ONCE for timeout conditions to reduce log spam. The subsequent error message still prints on each occurrence, providing sufficient information about the failure, while the stack trace is only needed once for debugging purposes. Signed-off-by: Breno Leitao --- drivers/spi/spi-tegra210-quad.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/spi/spi-tegra210-quad.c b/drivers/spi/spi-tegra210-quad.c index 9027f995a6669..7c10b1272b0ad 100644 --- a/drivers/spi/spi-tegra210-quad.c +++ b/drivers/spi/spi-tegra210-quad.c @@ -1117,7 +1117,7 @@ static int tegra_qspi_combined_seq_xfer(struct tegra_qspi *tqspi, (&tqspi->xfer_completion, QSPI_DMA_TIMEOUT); - if (WARN_ON(ret == 0)) { + if (WARN_ON_ONCE(ret == 0)) { dev_err(tqspi->dev, "QSPI Transfer failed with timeout: %d\n", ret); if (tqspi->is_curr_dma_xfer && From patchwork Mon Mar 17 15:44:03 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Breno Leitao X-Patchwork-Id: 14019598 Received: from mail-ej1-f43.google.com (mail-ej1-f43.google.com [209.85.218.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A4F962505B5; Mon, 17 Mar 2025 15:44:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.43 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1742226271; cv=none; b=sCIxbJTCB5m4TFbkQve8OTr39zSZQIXWn5M6B9cVarn4B7d5RcVedq+XlmYj7UnW98g4FMSjDIpg4HQIGr8imUAQE+NEm9kFjD/03VOHzUOHAHf4bbHas2QvXhAuI3Hc79xChhHO2xCLLdGRbIyPRmtq/sx+KZjPDXwXNW3cguA= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1742226271; c=relaxed/simple; bh=WyIjFqDA0OchucxTCZDGUZ2QgD0RxUJoq9iXFhWFCNo=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=r9zrNuX8Bsb05sriuE8ZmT4marAMVcKAox5fo4kYvhjAU6QNg0Q2RPhrinlzTJvFeWId9d7cf54qwRvDDe82ACjIBSz74QMcw+JaBEKDjAULLBf6dwDNV6d4Zx88p5W2uk+xa9JHPeIFlbLdwuhTffYdyImCfR/PDFFHq/qZQJI= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=debian.org; spf=pass smtp.mailfrom=gmail.com; arc=none smtp.client-ip=209.85.218.43 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=debian.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-ej1-f43.google.com with SMTP id a640c23a62f3a-ac298c8fa50so866267166b.1; Mon, 17 Mar 2025 08:44:28 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1742226267; x=1742831067; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=CRcg98y2/1oq0RZEVoLNyWmHQX4gLm604iL8gAD8krU=; b=NZcRKOWfSOqm7CGZ78yqCYF2cTntQIysbKOC1NVOW7dp9YssdXY4msKw4XGWxYm2J5 LhFPZWGbdL+xROijdZgYQxp1Ko4DpEB5RvR6KlPPhh0mBc1GgJqYoQUKg0+yzOXT5bdz iCE17IORwtICTkNldARkBrTTs9Z8d2ePluO0ub14yOyBijvqKQ2xXv6QTWcDr4/2B0Ry 9GZNltxa6E5CLfPT+zV6jh2Oed3CWrSMguwgeerZ44+wVJ6BIrlNFgWDuDuwgAP60D17 ZJft+tCpQGNNDwsN8kks93nRMpR6rfLPrwmj84yLt7RuARL/POTjzWD+M5t6AsolSzrU EqKQ== X-Forwarded-Encrypted: i=1; AJvYcCUYinfpNng/IVim5RfUp2I+pYBpKMyUtMlcZrAKKyChdF7memMpYmSgqqb8GbUWxr9KrOI7oWLrsgn/@vger.kernel.org, AJvYcCUuf0t3tBDg3ZmhXcX7NpFc3CXqvR07yrVq2JIgiKko8lHhpldS0Yybf/T3HrLtfhIJ/FRq0U02R5WbGv4=@vger.kernel.org X-Gm-Message-State: AOJu0YwdclZxH6hnJ5cTU50lKfFDvnnUID9R7UMSws/PIhTPGuFQvRo7 MzNFUVKjlg0OGzSKC08pEfcmU8pOeyen5W1Jtw8DICZbqSX95VO34i/28A== X-Gm-Gg: ASbGncs0Er2DShe2LilN7p2cfT4YodCTI3PMQwI7BPkSqhiwbJEx+Vw4dEYbPAIUROR MkJs/xf2nItjXb2P0eFMPVmFOix4H1RtZK+mR1KjsKKluWsqI5XS38pTA03odq/OW30x7A/dB2V KiFuqBO6wCy4wZ/CUJYOmSWqaZo8Va+tR8fnn6fNLehnrIMQvjQs1uWyAuAe4s2kbIFB7kRu/Bl 1J5JW3JZ972JVEXE6VJaxVzo+RVQIlm7/V9cqf0ES7O7wt6TfDgXqXycLPBoj4n855aK/QVIJbM nTbLnDLdP42fnjcTPAtZk/4I+4ObwR9AmqR98fECHxJAug== X-Google-Smtp-Source: AGHT+IGqLbl9tzol5xcJL1DfDVzWxoUxYy7s3L3Wp0YjYGnU6jZxgvzHOMioKRcjJjto3DRrI4We7w== X-Received: by 2002:a17:907:7fa6:b0:abf:7636:3cab with SMTP id a640c23a62f3a-ac3302ef9ccmr1336856666b.29.1742226266664; Mon, 17 Mar 2025 08:44:26 -0700 (PDT) Received: from localhost ([2a03:2880:30ff:9::]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-ac3147f1424sm681386266b.71.2025.03.17.08.44.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 17 Mar 2025 08:44:25 -0700 (PDT) From: Breno Leitao Date: Mon, 17 Mar 2025 08:44:03 -0700 Subject: [PATCH 3/3] spi: tegra210-quad: add rate limiting and simplify timeout error message Precedence: bulk X-Mailing-List: linux-spi@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-Id: <20250317-tegra-v1-3-78474efc0386@debian.org> References: <20250317-tegra-v1-0-78474efc0386@debian.org> In-Reply-To: <20250317-tegra-v1-0-78474efc0386@debian.org> To: Thierry Reding , Jonathan Hunter , Sowjanya Komatineni , Laxman Dewangan , Mark Brown Cc: linux-tegra@vger.kernel.org, linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org, rmikey@meta.com, Breno Leitao , kernel-team@meta.com X-Mailer: b4 0.15-dev-42535 X-Developer-Signature: v=1; a=openpgp-sha256; l=1318; i=leitao@debian.org; h=from:subject:message-id; bh=WyIjFqDA0OchucxTCZDGUZ2QgD0RxUJoq9iXFhWFCNo=; b=owEBbQKS/ZANAwAIATWjk5/8eHdtAcsmYgBn2ENTKQMkvIQrh+iXkg6r9au+2udMhyjkmn81o CmmsG1MoXeJAjMEAAEIAB0WIQSshTmm6PRnAspKQ5s1o5Of/Hh3bQUCZ9hDUwAKCRA1o5Of/Hh3 bdo9D/0f+uO6luC6Qtl/JwTpaj0+B5upTtHWBf9YPz/ufurSH5jIhqX3uIcxeYCxq9arzsU2pv+ HU6WPANpZrnNI67LEqDERkut3HSO3a8oVaPJeZYKVY4zc/qwjfUzTTl3tKmQW1glVY/IDIBdUwb mn6TwqnyGgWYUeuy10cNmyLVJUCC0oJBwtCNHU0zkUR2vfWv0UCJc29ZEO6aVqWMkvnY39I9nZB m5gjPuqQuzRaFQFLRR/aiVOuNBXnm1xj2ZD5GyfbSf6F9rM91xQ+X29Dp4iiBFeSOEiPQKr1jYN aDOFfq0adBYgO+mLXrmO6w0FsDqZzaPxRTwMFmCxmfN+ONGh+GDcnhMUe3kVhFX8nTP0IGvonlW DV7oxKZJQSkuU6vcPF+isxGiYyjqQcIfCPSAx3rcW3Fh7i6oK6j0mN5HFDixSmMci4wtgSHINjl HqPKdKqSVrZI0MzT6u830Jk0j2seabRO2K6gk04An/T++9idksoF9ziDFULEvTwuRuhWZ1YqNoZ AFmupizgRyhRrDPifjqAbzuSNjWOWzFzNP2iHlt3HlFjeYnHjDi+yNIatJ1f10UiyYL0nIxPby/ +0M7XusDie03x55/tYZRXk50kvhEk/1NbbFjTGHlwWKr9xlisapw2+z+Jfe3CJBbnbXJJSzuTdD fvVBhyMSf7LxKXw== X-Developer-Key: i=leitao@debian.org; a=openpgp; fpr=AC8539A6E8F46702CA4A439B35A3939FFC78776D On malfunctioning hardware, timeout error messages can appear thousands of times, creating unnecessary system pressure and log bloat. This patch makes two improvements: 1. Replace dev_err() with dev_err_ratelimited() to prevent log flooding when hardware errors persist 2. Remove the redundant timeout value parameter from the error message, as 'ret' is always zero in this error path These changes reduce logging overhead while maintaining necessary error reporting for debugging purposes. Signed-off-by: Breno Leitao --- drivers/spi/spi-tegra210-quad.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/spi/spi-tegra210-quad.c b/drivers/spi/spi-tegra210-quad.c index 7c10b1272b0ad..e8dd1c061a49b 100644 --- a/drivers/spi/spi-tegra210-quad.c +++ b/drivers/spi/spi-tegra210-quad.c @@ -1118,8 +1118,8 @@ static int tegra_qspi_combined_seq_xfer(struct tegra_qspi *tqspi, QSPI_DMA_TIMEOUT); if (WARN_ON_ONCE(ret == 0)) { - dev_err(tqspi->dev, "QSPI Transfer failed with timeout: %d\n", - ret); + dev_err_ratelimited(tqspi->dev, + "QSPI Transfer failed with timeout\n"); if (tqspi->is_curr_dma_xfer && (tqspi->cur_direction & DATA_DIR_TX)) dmaengine_terminate_all