From patchwork Tue Mar 18 05:36:04 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stanley Chu X-Patchwork-Id: 14020328 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 6E3F7C282EC for ; Tue, 18 Mar 2025 05:36:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=9m007aedgV1jJYJv/1CxXPTsB9kRLg5v2AukT7SOmM0=; b=l5UIVzPY8KH3FJ rn0MYa4weg9BLdtdmQVazGdPZsUn9kg/9sh/LHJmxV/iuCsm0QFKDFEqScnlk2gAID6CNxi7LqMMO mDVM/IlXo0rU3E/8pgpdA0hIhqurvbGdnSQZzZSynjbLGTtKFe6FRnFcRCdXUEIvdJOEsSnVHOqSn WQ6zwQwJ+EGzkEKZ/TBv6/gHgY7sgcHT3CSJiOmGn/qSKcTzh2PYB8sFIZpil/EZUYDFItSar3KPC Tb3Cto1vp3nmNH8u3VS9+v3Kg5sS41GM0suAcRvJluN9BFkKnCVYdjZyNONDTJONA9SpzYRZ2AeAo HrQmj/m3Au4ZVLbiypSA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1tuPd1-00000004j9y-0ond; Tue, 18 Mar 2025 05:36:39 +0000 Received: from mail-pl1-x635.google.com ([2607:f8b0:4864:20::635]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1tuPcz-00000004j9B-1fLB for linux-i3c@lists.infradead.org; Tue, 18 Mar 2025 05:36:38 +0000 Received: by mail-pl1-x635.google.com with SMTP id d9443c01a7336-224100e9a5cso99471385ad.2 for ; Mon, 17 Mar 2025 22:36:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1742276197; x=1742880997; darn=lists.infradead.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=JAXz5zFV/dNZck8AAhHpDywdjolmlMduTc9D2SMrXCY=; b=lCF1UtiZn3fPGZz01R7gX7AuZO37pMUatK1UTEeLbygmNKc3+Nu4C83AveHtuW5jUp h9M2bOaWluBs9ix8nkbvvmRbMgzqF8tOQCeKHpj7ItYnWWa0z+v662swumKi+7r68hCu YNzzGE6REFE9sEVc9O/guY+c4ub1QN2hZfxZb9sAZSi+e4XhLKZ0EdjOn9IkfwVRa/+u kSA3DWy6vC3469EbWjQDZm3UywHmYFohAtV4UqrgnFaS/ExQdG6Zshaom2YL1PgOmobv yrf7LI7scSaQl0y6TENuvJkXFG3YQ4KmNIDokTA+v4/xFPcbVLwR4dBCdwFW6nv/M+gp iFFA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1742276197; x=1742880997; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=JAXz5zFV/dNZck8AAhHpDywdjolmlMduTc9D2SMrXCY=; b=jhjbl1EBr+7MyUK3IM7hr4RJ1vQA8XnjMScOH9ft90ISDo11oSiGI2ejQ2sGEo60vh uOwymFnGOh1ZSYeds2Dz3lgPSCuuN7RBoQLW1LWa4nm33cKuPAImyifrdJ00aF/yY49j aHBG/WFF97AGhb1h7xgEE3mxPAgesABT/mytdv9iDrnlmAGKaw5gKNx8sweWnYwbW2RX cIaYwoKOraD8ntNSUI4y1joJM1VY27GtuDgMv1Qg1jC6ABGNkmt7SnKRdtsdptFgq61S RqSNNmnatYqFwIWiQZDIgCdZV3J87i7A4ZvJ6tmQebC92S5rhMgYUSo5S/duUZG79zW/ EumA== X-Forwarded-Encrypted: i=1; AJvYcCX05H1GFaEQSCpafVdvNWPLmp6ok7TZbAMYCHke+8ms9dYgL0dlaYz+4QpT622ACRtZzfFwyOP5MGg=@lists.infradead.org X-Gm-Message-State: AOJu0YzDanLQ0EodDQkjxS281cRl5fNwCmz+3dND4Wad4UBil/fpmNie 7sZkvppbLk4fz4Yskq7vfdIp4BYvMkk0EgMb+X3nJA4DUn9fOPRb21CkY1zr X-Gm-Gg: ASbGncukOMctg702CdWNa8t4fco+RxhJaz1DJUGelmEjQm3NJz1qqZY77SAhYkGckGe dXRRBnoTenv4XLuR6lj7CQFwm/bEzO5R9cuKkmtWaz8eFZ97eSj3H4OU7ey+dPV08K4Urjuxq9x Lfp8nQBjM2YFxjMxGqhuh4KGjyF0COrfK1ldy8408x9slf/5m3rNHH3J7iRQPmYABK62d0Am/14 KfxmOe4DsXAH/7/ta6nMO39y1Y7I01uctVZ/gEi/tNfbGnQG4+qNt1wSOypFGaM8n8BxnqrgjqO OAXOxywcchA4mA1oTBo1H2Q2yvPHzO+ZithkfVjjXFQWRUEjZ640JpQ= X-Google-Smtp-Source: AGHT+IH8K71L41KaQuidRb124ubL5NH0GzYCl4FWRdtxSZGd+wGA+J5yLIlXt4vfeFTUswsRyFIAtg== X-Received: by 2002:a17:902:ce8d:b0:224:721:ed9 with SMTP id d9443c01a7336-225e0b118ebmr195585385ad.44.1742276196636; Mon, 17 Mar 2025 22:36:36 -0700 (PDT) Received: from cs20-buildserver.lan ([2403:c300:dc02:2d2e:2e0:4cff:fe68:863]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-225c6ba6f09sm85299905ad.133.2025.03.17.22.36.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 17 Mar 2025 22:36:36 -0700 (PDT) From: Stanley Chu X-Google-Original-From: Stanley Chu To: frank.li@nxp.com, miquel.raynal@bootlin.com, alexandre.belloni@bootlin.com, linux-i3c@lists.infradead.org Cc: linux-kernel@vger.kernel.org, tomer.maimon@nuvoton.com, kwliu@nuvoton.com, yschu@nuvoton.com Subject: [PATCH v2 1/3] i3c: master: svc: Fix missing the IBI rules Date: Tue, 18 Mar 2025 13:36:04 +0800 Message-Id: <20250318053606.3087121-2-yschu@nuvoton.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20250318053606.3087121-1-yschu@nuvoton.com> References: <20250318053606.3087121-1-yschu@nuvoton.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250317_223637_434398_78D8E965 X-CRM114-Status: GOOD ( 12.09 ) X-BeenThere: linux-i3c@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-i3c" Errors-To: linux-i3c-bounces+linux-i3c=archiver.kernel.org@lists.infradead.org From: Stanley Chu The code does not add IBI rules for devices with controller capability. However, the secondary controller has the controller capability and works at target mode when the device is probed. Therefore, add IBI rules for such devices. Fixes: dd3c52846d59 ("i3c: master: svc: Add Silvaco I3C master driver") Signed-off-by: Stanley Chu Reviewed-by: Frank Li --- drivers/i3c/master/svc-i3c-master.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/i3c/master/svc-i3c-master.c b/drivers/i3c/master/svc-i3c-master.c index 1d1f351b9a85..a72ba5a7edd4 100644 --- a/drivers/i3c/master/svc-i3c-master.c +++ b/drivers/i3c/master/svc-i3c-master.c @@ -1106,7 +1106,7 @@ static int svc_i3c_update_ibirules(struct svc_i3c_master *master) /* Create the IBIRULES register for both cases */ i3c_bus_for_each_i3cdev(&master->base.bus, dev) { - if (I3C_BCR_DEVICE_ROLE(dev->info.bcr) == I3C_BCR_I3C_MASTER) + if (!(dev->info.bcr & I3C_BCR_IBI_REQ_CAP)) continue; if (dev->info.bcr & I3C_BCR_IBI_PAYLOAD) { From patchwork Tue Mar 18 05:36:05 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stanley Chu X-Patchwork-Id: 14020329 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id EA15CC282EC for ; Tue, 18 Mar 2025 05:36:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=e3WIlqfMker9TN10I5zT3jEtWdpE9ZTEPZN6Xf4BkGM=; b=a6tnXDa9AHOF2Y 5tyDMj1BnPswIaS12ZWjYCh+agun57z5lZTxj1KYSmiiqntj/KPyj+rMBEYx63yhVboFgKBgoOK39 YsvoBdvJ/ptY33ugSKLnfxLZvHHzeqLSkEjAksdL2fO3JWc4ZOtImNQpuIUGEdXZAjF6xneYyUAoF Hk8MN6Pz+NXMev8heg3lzhNauaTmBq3L9CsJAXPWUw5SIvQoZnFEYoDZzjE1FlRum1wdB9cEzffMj CPHWC7whGyL1XU3qXWuihYHevz42ytIWj+yWn4rmi6IIESqCgKBOotLwnJbUrmqzp55uAUxSEEOss XoEa5h5IZLoDmdypRgJg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1tuPdH-00000004jEI-31EY; Tue, 18 Mar 2025 05:36:55 +0000 Received: from mail-pl1-x635.google.com ([2607:f8b0:4864:20::635]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1tuPdF-00000004jDv-0m5o for linux-i3c@lists.infradead.org; Tue, 18 Mar 2025 05:36:54 +0000 Received: by mail-pl1-x635.google.com with SMTP id d9443c01a7336-2260c91576aso31970245ad.3 for ; Mon, 17 Mar 2025 22:36:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1742276212; x=1742881012; darn=lists.infradead.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=0rhPbDd0rp/+eHjWfo/oyKCU6wF9P8ggGmtlZyVMevo=; b=ayPGrsIpNWVECbN9EmOjsdDyjntZbHBq0aJ6QPZ2FDxQqXr90Lz4cm4xS7Spy/yhv7 We8iBPfgjfh3EWydxI3Svk2AKpjhbTKPm4aJdtKfD0VMS3quHSBHo1BVTEuqsbV2iN/O dhbmAHrdSNAQ7U/qXURUehk3+mD5OJl9+ppKXo4xWrsGUkRlRyPoSjtdsMB4Loty3CfS 0vwX6JbJTwJ/c2HghnmfqMOFx45GSN+tcviNUN+eHxA7FlOUgAFqPENR2udLetsa4b4N VzZIvFYgv1u9Xd5DEJ1w7CZUdSpCUqtqkLVymWE1zRzq7yBnnO6ikHIzS6U0yRgEopMn IjZQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1742276212; x=1742881012; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=0rhPbDd0rp/+eHjWfo/oyKCU6wF9P8ggGmtlZyVMevo=; b=Rd0mC9clS5bvL27fu2R6c1jXuwM0Oc7x7HeVv+Nur6pK3+mdki4wi9batYMLw43RwY weHpjX09eHqH3ugXvdNQYKHsl8N7ahktrC6aqUNASv3JW6mhIkZexrScYXVO9abzE9Qt aEuKRgSDpwanhpor1UygDwji5T5c5YlrLELb5BcrVp7a7pxZWMbiG3wD5148eJ4tEUcp BF50X6INJCSyABBZ3qFlZmWkWI6fxe0AMGeTmyFZ/1Cv3XaguWFfCkc/NRn4BI7NGtcs BgCWIb8v0pMbWWDtuRURPlkwbpaghJ33UBJnMeg06cRsaAc/1qUg36o67SBg+V9e7CP5 PCwQ== X-Forwarded-Encrypted: i=1; AJvYcCVrKs0cmcHEwUQL0KbmkAs8PNs0vofitfrgEP+QYVQ4AAE/zGEIelpvkDY6YsVE/kmhx7qzSOadUbI=@lists.infradead.org X-Gm-Message-State: AOJu0YweiB3ZBnFQli5t72TcDXJC4iDV8UFPZmcVThzKIiK4vwjD+GHI ZwG0EXOFceVNqwmMkLVM00PtPZIFZBcshUfinDb6tzkEAnPW6wDx X-Gm-Gg: ASbGnctf68YzV78qy7ZXW7+9trF7QBGEEb0erwcfawawE29jogR5YPNbDPOpR3aNvy0 RenFemd3B01DugyL67Nni7uIGs4Dw6N/Dmxt6+mlTxEWzF0f3fVAp7zxtF6Yk4p/4ZgK9ZZWY46 rqyOT4ZgTL95cg7HrkdGS5dfEtzSUzJqDmPuOEI6P6h3re6D9CpstSyGZBw8d3FDDyQfPbR/t/4 E59q+KZKd+jB8kCXJP69Q1sAs+pb9xjnv50jkK8Srau9kjn6Hkdp322qVEYQG76fpjEltF8l+N0 n+HdJcLnIjxq1Mpy5yLFueLY1fzI7p2Y0hq3HLRVe3A0uOPH6EA0anNtXdfr9tpU8w== X-Google-Smtp-Source: AGHT+IEQ5Xvf+rbEz83j21PmQVZJa1tTQ+KrF/RyhHQ1rBe5bD51Nx04dUVCxZ5zSSVIrBohADEJzg== X-Received: by 2002:a17:902:ef48:b0:221:85:f384 with SMTP id d9443c01a7336-225e0a3fbc1mr197525795ad.16.1742276212613; Mon, 17 Mar 2025 22:36:52 -0700 (PDT) Received: from cs20-buildserver.lan ([2403:c300:dc02:2d2e:2e0:4cff:fe68:863]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-225c6ba6f09sm85299905ad.133.2025.03.17.22.36.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 17 Mar 2025 22:36:52 -0700 (PDT) From: Stanley Chu X-Google-Original-From: Stanley Chu To: frank.li@nxp.com, miquel.raynal@bootlin.com, alexandre.belloni@bootlin.com, linux-i3c@lists.infradead.org Cc: linux-kernel@vger.kernel.org, tomer.maimon@nuvoton.com, kwliu@nuvoton.com, yschu@nuvoton.com, stable@kernel.org Subject: [PATCH v2 2/3] i3c: master: svc: Use readsb helper for reading MDB Date: Tue, 18 Mar 2025 13:36:05 +0800 Message-Id: <20250318053606.3087121-3-yschu@nuvoton.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20250318053606.3087121-1-yschu@nuvoton.com> References: <20250318053606.3087121-1-yschu@nuvoton.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250317_223653_222596_3C518C84 X-CRM114-Status: GOOD ( 10.74 ) X-BeenThere: linux-i3c@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-i3c" Errors-To: linux-i3c-bounces+linux-i3c=archiver.kernel.org@lists.infradead.org From: Stanley Chu The target can send the MDB byte followed by additional data bytes. The readl on MRDATAB reads one actual byte, but the readsl advances the destination pointer by 4 bytes. This causes the subsequent payload to be copied to wrong position in the destination buffer. Cc: stable@kernel.org Fixes: dd3c52846d59 ("i3c: master: svc: Add Silvaco I3C master driver") Signed-off-by: Stanley Chu Reviewed-by: Frank Li --- drivers/i3c/master/svc-i3c-master.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/i3c/master/svc-i3c-master.c b/drivers/i3c/master/svc-i3c-master.c index a72ba5a7edd4..57b9dec6b5a8 100644 --- a/drivers/i3c/master/svc-i3c-master.c +++ b/drivers/i3c/master/svc-i3c-master.c @@ -425,7 +425,7 @@ static int svc_i3c_master_handle_ibi(struct svc_i3c_master *master, slot->len < SVC_I3C_FIFO_SIZE) { mdatactrl = readl(master->regs + SVC_I3C_MDATACTRL); count = SVC_I3C_MDATACTRL_RXCOUNT(mdatactrl); - readsl(master->regs + SVC_I3C_MRDATAB, buf, count); + readsb(master->regs + SVC_I3C_MRDATAB, buf, count); slot->len += count; buf += count; } From patchwork Tue Mar 18 05:36:06 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stanley Chu X-Patchwork-Id: 14020330 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 7484BC282EC for ; Tue, 18 Mar 2025 05:37:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=FMkt0QK/n8lhDC5NhNAW1gpfvJIe53k/XoQ3K9pyhsA=; b=RanwgdSPS5S03E AF6qPJtztSOh20mwr2qbFR3Gz5S+LlCbeiX37u2ZQ9tbxWV33KCr5aLIrzBRyfV2GMcBS7DM325rv 9qN8uEAUiFAf0EWXU0nYmEeYX3Xa8lAzir5fXp+gqYp3b63zvcxMJ7DwbB210FgQTv/P3XU1RrRKA TPYd1KlR7a0+DjzwHiKEzlwIhYVFkkQ9Q9MOca4k5m2YsyPh4w0mffPoIX1Y4+LfJjYNtiHx/eTfd cSpO4OHFWjkb0mLPgAnj6AQ2CC/NhzBTYs6g7N9I8nrQpcBcOnk/+YJs3eMR8kwSJjg2z/1/NXWXY tY7cf81Hd0bapgHTVZFQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1tuPdN-00000004jFc-10Yd; Tue, 18 Mar 2025 05:37:01 +0000 Received: from mail-pl1-x62a.google.com ([2607:f8b0:4864:20::62a]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1tuPdK-00000004jEx-33I7 for linux-i3c@lists.infradead.org; Tue, 18 Mar 2025 05:36:59 +0000 Received: by mail-pl1-x62a.google.com with SMTP id d9443c01a7336-2239c066347so107901555ad.2 for ; Mon, 17 Mar 2025 22:36:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1742276218; x=1742881018; darn=lists.infradead.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=t2l70gmWLq1u+RsRNabUWN7Xz1zqqPiMQOA3ywbVZDU=; b=IjOtPjaBn3N9CdU5oztEO0JTkomWGCRmC+Q0zRvbXvJ0cg1+l9X0kSQ2vwrfQqxp2D OAbPM0bfoZps70v12RLCYMzmYxPCrIcyvHkLiMtiIhOCKCCcP5nMlSnYuMYO6Sv1X2h0 AUjSRsgreWpRY7mneGzYbOCR6DLKodcOiCcCUbSxW+UAllcbU6ALplWK7pil6HA4x0zY CA7eEjK8Ix6jhsbMSm0tUg2IsATQIW3gsDnxSi3HcRu3ifvD8A/m97c9MH9XdT+CCbGK 0d+cHv2k1n88yZhuPIcAD7CdXtVeQap2R+z/Hf2l6QRCvO+KZs39jieTcr9wBSNUvqwS TEGA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1742276218; x=1742881018; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=t2l70gmWLq1u+RsRNabUWN7Xz1zqqPiMQOA3ywbVZDU=; b=jhrCrLC+KbUyq5yYt9JSP9zYR/HkzvNLXIv8r7iwhNzZk3KeaJyiVXNqdgopJO8cck JFlQKnxEHiLxRp/LEkDZKGCrKjdjO24UzAs9uU3tEcRdFRbD7Bs+IZwgtVBb32ylUAOM RponkYNO232VPYwc/jrz1N3FlHxwrLsXFpFPrzoFzE0LAbDkQy+7uahnJ+MSEwA2ClOM VsmjW2q9NPocp+OfF3mL95AuRK9JWAXXezm0NZJV19KY65j1yfEnE6FRABG5ScEiMc2u Y+gsZyNVvDHcCAwPosAUKCWGZWnF4Mmq70cZ44N7s2r9h5wtxQk7c+UlPOs8RKs+oDGz GrRQ== X-Forwarded-Encrypted: i=1; AJvYcCXMh37IFAzV+lB0Cd/vmZcsRYmN1bVwpkGDr/tSPkZYD1OI7AI3OnNV7gP2XXMOHpwjqfV6t8X84aQ=@lists.infradead.org X-Gm-Message-State: AOJu0YxIZbQ5WAKYvjqO0VrGrxD+PsX35bLFeHNJRzl8SL92IMHV+bsG jn2ZTB1qAhMu0H/fViJapYiwh7Ncjp0iXCRVcEE+F/DrrljcuPWi X-Gm-Gg: ASbGncve0GEvLuG4ykWKzeW+Xp9IBlFotrthF5RkScdO8Wg8OcYFv3ncnQ7NYFve/g/ WFzx8EODEE+pyyZo5inqDVwJGvghwKq71HDHx3QU8XAymZCIbFPzz5kWGcIJ1puA2Bgp58x1Rxq +Mvsn9YvvfCRypQ7SQryOKp1qoA75WLHJyt56cFa5zrqgLDZPWkbbFupWmcg8ITmwXdyse1omVM JFMWk1ZnfG305fAbHCKUTNVu03PbVS80DpMB6cgcQB1d3o1v2fjW3zNovxIEkhct0tTt1/1BzP0 ZSfQRc1QuWZPz5A3eWrlWUxkNzBG5K/0O3Z3fl7IarUZZYkHvNxTWpc= X-Google-Smtp-Source: AGHT+IHh61jHEle2cIzLwjfMURMV6oyMDvmV3DsO5QwJwWAe5RRi+4NcIIvl2m8zXZrzfh21OGTCZA== X-Received: by 2002:a17:902:e545:b0:224:2384:5b40 with SMTP id d9443c01a7336-225e0aa0c3fmr202843365ad.24.1742276217919; Mon, 17 Mar 2025 22:36:57 -0700 (PDT) Received: from cs20-buildserver.lan ([2403:c300:dc02:2d2e:2e0:4cff:fe68:863]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-225c6ba6f09sm85299905ad.133.2025.03.17.22.36.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 17 Mar 2025 22:36:57 -0700 (PDT) From: Stanley Chu X-Google-Original-From: Stanley Chu To: frank.li@nxp.com, miquel.raynal@bootlin.com, alexandre.belloni@bootlin.com, linux-i3c@lists.infradead.org Cc: linux-kernel@vger.kernel.org, tomer.maimon@nuvoton.com, kwliu@nuvoton.com, yschu@nuvoton.com Subject: [PATCH v2 3/3] i3c: master: svc: Fix missing STOP for master request Date: Tue, 18 Mar 2025 13:36:06 +0800 Message-Id: <20250318053606.3087121-4-yschu@nuvoton.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20250318053606.3087121-1-yschu@nuvoton.com> References: <20250318053606.3087121-1-yschu@nuvoton.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250317_223658_767226_5F20AF2A X-CRM114-Status: UNSURE ( 9.03 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-i3c@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-i3c" Errors-To: linux-i3c-bounces+linux-i3c=archiver.kernel.org@lists.infradead.org From: Stanley Chu The controller driver nacked the master request but didn't emit a STOP to end the transaction. The driver shall refuse the unsupported requests and return the controller state to IDLE by emitting a STOP. Signed-off-by: Stanley Chu Reviewed-by: Frank Li --- drivers/i3c/master/svc-i3c-master.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/i3c/master/svc-i3c-master.c b/drivers/i3c/master/svc-i3c-master.c index 57b9dec6b5a8..e0cd3ce28b7f 100644 --- a/drivers/i3c/master/svc-i3c-master.c +++ b/drivers/i3c/master/svc-i3c-master.c @@ -592,6 +592,7 @@ static void svc_i3c_master_ibi_work(struct work_struct *work) queue_work(master->base.wq, &master->hj_work); break; case SVC_I3C_MSTATUS_IBITYPE_MASTER_REQUEST: + svc_i3c_master_emit_stop(master); default: break; }