From patchwork Tue Mar 18 15:36:24 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jiri Pirko X-Patchwork-Id: 14021178 X-Patchwork-Delegate: kuba@kernel.org Received: from mail-wr1-f50.google.com (mail-wr1-f50.google.com [209.85.221.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7063120F078 for ; Tue, 18 Mar 2025 15:36:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.50 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1742312201; cv=none; b=lYKlXKTAu9iwpS4SOG9o47ZntSQDSIGYEq41Jw4/+NgI3JNwC1r+tjv42bE6PDvaBUE7P7dXEqCLe6N2wZbBcmC6Q8eSwb5GTueJ25/SG5KjGTkNj2G1glQN+rbs/UkIwoPA8E+rdo9QT+TD4UNfqNoauSQr0iw1tXYMrtoKldo= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1742312201; c=relaxed/simple; bh=+OW+RtgKsRJs1bzFMDq5bzw99FZCh7zsF6Y14sSOP+s=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=MUW5+CshBDN5VdIrPJArAydNlUtYAFC90IYGq1J6E5M+ynBUyAEqGT9pR1K0RAMf5TQkl4IaipwFeMYl+yZ471vdhZoSuP19zWPm/cNiyizdqRzbp4CdRuyS/BbgX7hwRA5sOze+yUvZMlOMgRJA96DyBpb8QVHoHL2oJnYjMQ4= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=resnulli.us; spf=none smtp.mailfrom=resnulli.us; dkim=pass (2048-bit key) header.d=resnulli-us.20230601.gappssmtp.com header.i=@resnulli-us.20230601.gappssmtp.com header.b=UHCvKf9m; arc=none smtp.client-ip=209.85.221.50 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=resnulli.us Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=resnulli.us Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=resnulli-us.20230601.gappssmtp.com header.i=@resnulli-us.20230601.gappssmtp.com header.b="UHCvKf9m" Received: by mail-wr1-f50.google.com with SMTP id ffacd0b85a97d-3912c09be7dso3935317f8f.1 for ; Tue, 18 Mar 2025 08:36:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=resnulli-us.20230601.gappssmtp.com; s=20230601; t=1742312195; x=1742916995; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=a128zcZc5YRGP5mY1JEmfIr8nMkvTHKg1+rmTOEaIJM=; b=UHCvKf9m4ONRBp7gNpP6ubvj20nI0TKA3XQJ/ev2vsb5Jw4O1qAlC2avbQzVKTXSzW LQje3G14CuwyArRFYq3wkcz3CFc56YnSkUT5AzgG8aJ+MglP3nslknBDsh/PHup2hHgW bIYXiw0F9W2Leu2hNKBqeXQmSbkAJwNV4ComPZW8PeyV15ZcCGScoW82jrLAyHXUOh+D tdImoB3feD/KA8X5ktAkg8vAERFVKkOQp5ZRFvLThMvnZTwQLCLuz/uLaQZkcyJAwb1D 3wZY9jpuAnHMMdknABZ3jrkxMwLGFfF5tcWC9Xu8O/8XqR155oSw4HEqPRJjBoqOED/E KUEA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1742312195; x=1742916995; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=a128zcZc5YRGP5mY1JEmfIr8nMkvTHKg1+rmTOEaIJM=; b=ZMBqUyoCh613Zb3tgD/bbJGLc/+g1lqbNrMje/FSqBAynPZ7dt0mlmWaXEPrPVdra4 mu3jAzTVF0sVEbqf89mB0+gibCd1s5GNN8/B+dHcZnI0cbc6+9DMk7VAC2I5E4chNw7/ igX3Nml1sEj6OOAiHQ4jTEuWMFvqUlg3HZfgtS8f5QTGO28iHv61QXrZdHQ3KzbvXPpC OmoyCqy64sXsh55b+neCVI9nP2zhct762BLwlV2uAVhW2vA2RVM0LIeFi9oQcrVpBn/5 B20dZbkPSnDSlRlivaRs8dcexnALuxNtftP8FQhy3n3JA2UdeZIbcGPGtHCnR/aVsBUR NxHQ== X-Gm-Message-State: AOJu0YxYU0oTUhChIdbW38R0SXMruOmnSKhZb+eelzvGX6tsEXcCq3FK GNqLCb14NFOAUp6jmuuNeWZ4Q/OoxIUYAFD44qmMvOVDEKQzf4kTO5cFwe9CgvJfdB+7EzoS+oR N X-Gm-Gg: ASbGncth5y8p2gHQb7yKeYmRoJbctiGtAIuhd+68Eul9gF2KDzUJylWq368HHB+UQ5N l2XIhkmKP9q4VF8k7w4d9UuNswuxy5Sk83tpP5Mln3uNVlKKC3uaAwPQH18sOeRg/mM46PYp7BQ hQU+kwj3WuFSvS+ovBeeq68/w3ucM0CBakwPaR7RSam25cqCkGhMYSjk1jSd0USyvW2Fnm8rJR/ 52SuyXVwrO+ocgX+xYftpbZoIoBjYQdduM1pRBwRVvgxESyVNmSwyHKNndBM+Jlxr0vt41m4sZE WcTvoIDeBScwXrS5huV9a7GFsa4pzst/HVFQGQ== X-Google-Smtp-Source: AGHT+IGWJxy6nSnJUDah4rsKdnxjkwL9AkkDpmXb53JRF/p5WyC8VVDPVxtF494WtRd8LMsSaOQVxQ== X-Received: by 2002:a5d:588b:0:b0:391:4674:b136 with SMTP id ffacd0b85a97d-3971ded2b2dmr17193156f8f.29.1742312194518; Tue, 18 Mar 2025 08:36:34 -0700 (PDT) Received: from localhost ([193.47.165.251]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-395c7df344dsm19001100f8f.10.2025.03.18.08.36.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 18 Mar 2025 08:36:34 -0700 (PDT) From: Jiri Pirko To: netdev@vger.kernel.org Cc: davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, saeedm@nvidia.com, leon@kernel.org, tariqt@nvidia.com, andrew+netdev@lunn.ch, horms@kernel.org, donald.hunter@gmail.com, parav@nvidia.com Subject: [PATCH net-next 1/4] ynl: devlink: add missing board-serial-number Date: Tue, 18 Mar 2025 16:36:24 +0100 Message-ID: <20250318153627.95030-2-jiri@resnulli.us> X-Mailer: git-send-email 2.48.1 In-Reply-To: <20250318153627.95030-1-jiri@resnulli.us> References: <20250318153627.95030-1-jiri@resnulli.us> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Patchwork-Delegate: kuba@kernel.org From: Jiri Pirko Add a missing attribute of board serial number. Signed-off-by: Jiri Pirko --- Documentation/netlink/specs/devlink.yaml | 1 + 1 file changed, 1 insertion(+) diff --git a/Documentation/netlink/specs/devlink.yaml b/Documentation/netlink/specs/devlink.yaml index 09fbb4c03fc8..bd9726269b4f 100644 --- a/Documentation/netlink/specs/devlink.yaml +++ b/Documentation/netlink/specs/devlink.yaml @@ -1868,6 +1868,7 @@ operations: - info-version-fixed - info-version-running - info-version-stored + - info-board-serial-number dump: reply: *info-get-reply From patchwork Tue Mar 18 15:36:25 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jiri Pirko X-Patchwork-Id: 14021179 X-Patchwork-Delegate: kuba@kernel.org Received: from mail-wm1-f49.google.com (mail-wm1-f49.google.com [209.85.128.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5C2FC20F080 for ; Tue, 18 Mar 2025 15:36:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.49 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1742312202; cv=none; b=AvYsWJf5x7IV0CbX8q7U1mSVfbJYzmlX7w6obKT7I7dneScqAmMqhYuk5mm/+mcPi77pD9eJYG1EN0z7uYw4xps7INVhKtrjcgkIYYBCDiFdIDGYeu8PqKMCEstXb7UJlrOJC5DkvSPKReK7yohpj+rHkh39TS4EqjSKIlBmCRI= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1742312202; c=relaxed/simple; bh=7ymDDFxx34gx35rocJ+N5kMEVcblCf9p5CMo54B2U80=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=uaj6dcFsEAoCS4Trfd8UuWdwjVfghzYmeOyuWZ0elmFk8okKDzb0ZNtje//DHKMTwq7JrBIKnQJ/VkHzGUP0hktZ2zYPteFSOvdOptcAD+5QtI//9ehIJ8cRBTY82zwW2xuUm2G+Z3sQKa7k0BYXfAHlu99DeZQJkx98jQ2D/s0= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=resnulli.us; spf=none smtp.mailfrom=resnulli.us; dkim=pass (2048-bit key) header.d=resnulli-us.20230601.gappssmtp.com header.i=@resnulli-us.20230601.gappssmtp.com header.b=GzJDFQQ3; arc=none smtp.client-ip=209.85.128.49 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=resnulli.us Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=resnulli.us Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=resnulli-us.20230601.gappssmtp.com header.i=@resnulli-us.20230601.gappssmtp.com header.b="GzJDFQQ3" Received: by mail-wm1-f49.google.com with SMTP id 5b1f17b1804b1-43d04dc73b7so35614055e9.3 for ; Tue, 18 Mar 2025 08:36:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=resnulli-us.20230601.gappssmtp.com; s=20230601; t=1742312198; x=1742916998; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=hyb1qp9YAp8Vcuqhs/UTA4yMykiwjQ9hNBOz2naJw2U=; b=GzJDFQQ30ixR37hnQEQ1eS4ch/50cVuVdsuIuusC3AxCuvueFGYWvKL6CU4NoI8zpg AVodlxiUYZb+FawYODocsX2XtnamvpPgZZidxKUGS9JH1ZQqunNvNphDnPo9nju2GTGN FNGJJkT+He5QByTJC1cn4kh3b6t25i7Cfvc352ig882JEwULSFfzEz9vQ7FErW+Xgy7i GeRda5Zk2U6LWQl597u7mZoVRJOECAxKh7NYrDOifNyBW/o/pGG0gRXFxpaLNE/gcbby UbeGPsAxkycOBhXAUQLlMEKYkMIGbVFzno4bE9sWPi4VRHt4SSwvhu+rLf1yx/OyxHga 8yZQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1742312198; x=1742916998; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=hyb1qp9YAp8Vcuqhs/UTA4yMykiwjQ9hNBOz2naJw2U=; b=j41C3/ZWf2EwEqBac4113+dd4CWdI9v5kp67PrBHUmzvinE95OjRu8oeC6uC4pMtct aY3JHX1HDd3mPiDN0zyGSiNRInrMP9hHOA19LG3MXqY/C+dncWfiSZFbFHBAC/7eLFSF 1umJ55TmgJBaazU4etCz35MOgycNGNBF4NtDt6cshpMpIdlMPL9h8Thb9jADHS9IstaX Oe6dV0NYPLsfvjhMfjapZN46rPk8tw+OHJKuuOgsHpoCI7yFfvdzmNxIQLy5aq4zcJzx G55PSLnt2g2lnEpzBrx8xMGLP+eLqyVgazXID9v3g9Tt6qWrqT8FS14jsviAS/gs6Cu8 O7wg== X-Gm-Message-State: AOJu0YzHsb9paYj8Nm37uWPo9Ez42TxTkFV0Rvyv7qH+5AB35q2mq+b9 RaMQgwZ55nHlvms/K1zX2nnx0vEolQEAl117tusG/4Qal+NCxRvz5jH/1ubOKPj0NYzS+G06XkQ j X-Gm-Gg: ASbGncvR7WUCyHdVTwRqmgt8csxY57rn7oXEMoMtEJ1m3ULCok6hh/h46taYUpQM7Xk G8sYZOEg63vpsSsjq3hofWVr+4UitnWPM+m5ALxjeJ7bxvhxulilcsxkdeNUbsDHci124zmj1kA MA3Cdq7+ACEfecIuZALvdjKyn6zUoaPsd/NFpIHs33yF/4AgbJT9XCUM3NZWVB0CspItS8K0Atj X+Hcp2ru9Dp2kBEutOxuv+wQ0ll5u/BSfINPcaoJ7hmQ5Epaf5DEzj7GBWr0r1wSDRhQBq0Zfxs 6GWmLq5QT9gTbbiUBNL5z2tKPlrWnqFV6UydtMurMJHQQC2p X-Google-Smtp-Source: AGHT+IGcnSItZQd+6FisW0GV3iQhp54/kcszXeTE186KEKzazJuLoncasKd8qhKyBILmiJYYoClL8A== X-Received: by 2002:a05:600c:1da6:b0:43d:b51:46fb with SMTP id 5b1f17b1804b1-43d3b950d25mr28262965e9.2.1742312198584; Tue, 18 Mar 2025 08:36:38 -0700 (PDT) Received: from localhost ([193.47.165.251]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-43d1fe294b5sm138391765e9.21.2025.03.18.08.36.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 18 Mar 2025 08:36:38 -0700 (PDT) From: Jiri Pirko To: netdev@vger.kernel.org Cc: davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, saeedm@nvidia.com, leon@kernel.org, tariqt@nvidia.com, andrew+netdev@lunn.ch, horms@kernel.org, donald.hunter@gmail.com, parav@nvidia.com Subject: [PATCH net-next 2/4] net/mlx5: Expose serial numbers in devlink info Date: Tue, 18 Mar 2025 16:36:25 +0100 Message-ID: <20250318153627.95030-3-jiri@resnulli.us> X-Mailer: git-send-email 2.48.1 In-Reply-To: <20250318153627.95030-1-jiri@resnulli.us> References: <20250318153627.95030-1-jiri@resnulli.us> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Patchwork-Delegate: kuba@kernel.org From: Jiri Pirko Devlink info allows to expose serial number and board serial number Get the values from PCI VPD and expose it. $ devlink dev info pci/0000:08:00.0: driver mlx5_core serial_number e4397f872caeed218000846daa7d2f49 board.serial_number MT2314XZ00YA versions: fixed: fw.psid MT_0000000894 running: fw.version 28.41.1000 fw 28.41.1000 stored: fw.version 28.41.1000 fw 28.41.1000 auxiliary/mlx5_core.eth.0: driver mlx5_core.eth pci/0000:08:00.1: driver mlx5_core serial_number e4397f872caeed218000846daa7d2f49 board.serial_number MT2314XZ00YA versions: fixed: fw.psid MT_0000000894 running: fw.version 28.41.1000 fw 28.41.1000 stored: fw.version 28.41.1000 fw 28.41.1000 auxiliary/mlx5_core.eth.1: driver mlx5_core.eth Signed-off-by: Jiri Pirko Reviewed-by: Parav Pandit --- .../net/ethernet/mellanox/mlx5/core/devlink.c | 49 +++++++++++++++++++ 1 file changed, 49 insertions(+) diff --git a/drivers/net/ethernet/mellanox/mlx5/core/devlink.c b/drivers/net/ethernet/mellanox/mlx5/core/devlink.c index 73cd74644378..be0ae26d1582 100644 --- a/drivers/net/ethernet/mellanox/mlx5/core/devlink.c +++ b/drivers/net/ethernet/mellanox/mlx5/core/devlink.c @@ -35,6 +35,51 @@ static u16 mlx5_fw_ver_subminor(u32 version) return version & 0xffff; } +static int mlx5_devlink_serial_numbers_put(struct mlx5_core_dev *dev, + struct devlink_info_req *req, + struct netlink_ext_ack *extack) +{ + struct pci_dev *pdev = dev->pdev; + unsigned int vpd_size, kw_len; + char *str, *end; + u8 *vpd_data; + int start; + int err; + + vpd_data = pci_vpd_alloc(pdev, &vpd_size); + if (IS_ERR(vpd_data)) + return 0; + + start = pci_vpd_find_ro_info_keyword(vpd_data, vpd_size, + PCI_VPD_RO_KEYWORD_SERIALNO, &kw_len); + if (start >= 0) { + str = kstrndup(vpd_data + start, kw_len, GFP_KERNEL); + if (!str) { + err = -ENOMEM; + goto end; + } + end = strchrnul(str, ' '); + *end = '\0'; + err = devlink_info_board_serial_number_put(req, str); + kfree(str); + } + + start = pci_vpd_find_ro_info_keyword(vpd_data, vpd_size, "V3", &kw_len); + if (start >= 0) { + str = kstrndup(vpd_data + start, kw_len, GFP_KERNEL); + if (!str) { + err = -ENOMEM; + goto end; + } + err = devlink_info_serial_number_put(req, str); + kfree(str); + } + +end: + kfree(vpd_data); + return err; +} + #define DEVLINK_FW_STRING_LEN 32 static int @@ -49,6 +94,10 @@ mlx5_devlink_info_get(struct devlink *devlink, struct devlink_info_req *req, if (!mlx5_core_is_pf(dev)) return 0; + err = mlx5_devlink_serial_numbers_put(dev, req, extack); + if (err) + return err; + err = devlink_info_version_fixed_put(req, "fw.psid", dev->board_id); if (err) return err; From patchwork Tue Mar 18 15:36:26 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jiri Pirko X-Patchwork-Id: 14021181 X-Patchwork-Delegate: kuba@kernel.org Received: from mail-wm1-f52.google.com (mail-wm1-f52.google.com [209.85.128.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A53D720FA98 for ; Tue, 18 Mar 2025 15:36:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.52 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1742312209; cv=none; b=MUVJfDhP+uN2b+tqQ/5MMAtlnRyXoxt4ypdEuKZzjdpBMBKK8yIEnnk0gdL2uwSF7btwkM3sb3mWoPceof4+tlP5qF0X46R6y2ZxkVAf9OEmiZhIwfh1z0C99Hme/k3QjyrT8pZ7MvvmUEERda+yNc+Xe1Oe/+3GcKftHGuwy7k= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1742312209; c=relaxed/simple; bh=PGlbXScemvaDyH4TxR4GSRe6Njs2b8zlIwIBZVQwo18=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=fyQHnUrzvLwSeNpAl10OQTTdNY7qmPz+xxZ/85it/7snttD5bJVP3wlc1ayTm/9oie3+FTfcfHnBSDFRNvJu4R18zhq0sbAvrWMUL9tTAoApl9k+JC9ith8OhuX78W05AlstdMBzFX6hwvBv/iOgNZhvlqDzdMWrHhyFHXy//Ic= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=resnulli.us; spf=none smtp.mailfrom=resnulli.us; dkim=pass (2048-bit key) header.d=resnulli-us.20230601.gappssmtp.com header.i=@resnulli-us.20230601.gappssmtp.com header.b=JOImvvIX; arc=none smtp.client-ip=209.85.128.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=resnulli.us Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=resnulli.us Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=resnulli-us.20230601.gappssmtp.com header.i=@resnulli-us.20230601.gappssmtp.com header.b="JOImvvIX" Received: by mail-wm1-f52.google.com with SMTP id 5b1f17b1804b1-43d0618746bso27065905e9.2 for ; Tue, 18 Mar 2025 08:36:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=resnulli-us.20230601.gappssmtp.com; s=20230601; t=1742312202; x=1742917002; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=u8j6HJ/LXsaiiYYsFgCSAtpRLzT4odfs6A0txp6rEV8=; b=JOImvvIXDgK9FsiI3B2mG8MJ9+FNuCK2NjDjYuavhyXcDY9r2A4uBJRJlyQGyQdD1r HpSsCxeQRkTkDEN5oXp7JcoNsmeSPOGl+nMeQCDP6TCKUzcng5e7WfbQiVhHo/yerB60 htVEwbIUzh8/VpToHyAf37+e4EWlql+nKPDJe7yRcO5s2SINGurXBHNWRBB6HG/xLDW5 Jv/7sHq1BYSlctj4fdS9reGnGTk9SvEx6dvFydHatm5S3KlQlt0D+eC6TFNiQW0NNlhm tkix/VTI6WUrBPiQL4RSBunN7Gu/QpfpCbAmpIC+VHDRDJHxFFImeAuxyC1hFydei9x4 gnXQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1742312202; x=1742917002; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=u8j6HJ/LXsaiiYYsFgCSAtpRLzT4odfs6A0txp6rEV8=; b=UGbMb4lQuuQTGGwCFNIE2xuSYe6kprpCcCEgqiu2SXGj394HFcvCehuuMi3DnrOBfp Kft1AkkEJ9B4diTjtKMOc+srGwGRBiua2eHiZzjvTYmcYhGHbVnUW/E85PQqToiQBtrm 8Zk0h2q7y6A1pNRoVAQVp5YX8VDnVmT+ZKFisrhn2cr9p0tOZsghawHsL2X83zke1zGd jw0wEwUtBaLg4ll+fcbb7/k+aAczKY3HCmLnrJYBKfoEcgE8vjUfg7o6UsbNyoUX0yMK MvJg/2RLW1GHojySp2Zl3g0nZglcEUwVbT9RlXpxG4v6WIzI4ShgpWlyBLjYUboPwfdx eMDw== X-Gm-Message-State: AOJu0Ywnh1+73yRfKRTd0YPn+0ivGevEZI/wcgNKDgSuAQpxTkRSMzyv GAc3qFpb6CPpkUAI5AAQ4UqRoWVgtox+RMCuYF+yebiX+oMPpDZyjaJ0npWz8yFWsB8patj9MWQ c X-Gm-Gg: ASbGncshDn6KF1a9/NBPVvXWIju3xyEPmg6IX1MCy/LUTuT29Ao0hvf90m13tCkTzeq XUwjOje2bqnLvaPlUKQDsURSL6xUKXb0hwL47OjcgLR8pdJ4T7s/8zC+VbUJCmB0IRB1Dhkm0qi rbRZyZa+r/4KWfp4x6t3Vsx5RIztIylRkS9HK+kPTcRgLf09zo/yvav0lKrQra1LPcd6cNvNXNZ 0oTbZaJyBgpWVqINp8x+9QGG4POOR/FT85gkU6e0w8F0byw/y9FdHYHRR07xaJqk0m7qSAyTzLJ kovNI+A7+bJR90tknbWJH+bUaiXDx44S7DVcgw== X-Google-Smtp-Source: AGHT+IEBGGYzQbEmEn90xv9VamN9pFtpDpHco/XFe0t/mH4e0dpEJ1hbJBX6QSfTRqr1d2r9mBtSaw== X-Received: by 2002:a05:600c:4fc3:b0:43d:ce4:ef3f with SMTP id 5b1f17b1804b1-43d3b9a9571mr26048635e9.12.1742312201855; Tue, 18 Mar 2025 08:36:41 -0700 (PDT) Received: from localhost ([193.47.165.251]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-43d1fdda2dbsm138634165e9.2.2025.03.18.08.36.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 18 Mar 2025 08:36:41 -0700 (PDT) From: Jiri Pirko To: netdev@vger.kernel.org Cc: davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, saeedm@nvidia.com, leon@kernel.org, tariqt@nvidia.com, andrew+netdev@lunn.ch, horms@kernel.org, donald.hunter@gmail.com, parav@nvidia.com Subject: [PATCH net-next 3/4] devlink: add function unique identifier to devlink dev info Date: Tue, 18 Mar 2025 16:36:26 +0100 Message-ID: <20250318153627.95030-4-jiri@resnulli.us> X-Mailer: git-send-email 2.48.1 In-Reply-To: <20250318153627.95030-1-jiri@resnulli.us> References: <20250318153627.95030-1-jiri@resnulli.us> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Patchwork-Delegate: kuba@kernel.org From: Jiri Pirko Presently, for multi-PF NIC each PF reports the same serial_number and board.serial_number. To universally identify a function, add function unique identifier (uid) to be obtained from the driver as a string of arbitrary length. Signed-off-by: Jiri Pirko Reviewed-by: Parav Pandit --- Documentation/netlink/specs/devlink.yaml | 4 ++++ Documentation/networking/devlink/devlink-info.rst | 5 +++++ include/net/devlink.h | 2 ++ include/uapi/linux/devlink.h | 2 ++ net/devlink/dev.c | 9 +++++++++ 5 files changed, 22 insertions(+) diff --git a/Documentation/netlink/specs/devlink.yaml b/Documentation/netlink/specs/devlink.yaml index bd9726269b4f..5d39eb68aefb 100644 --- a/Documentation/netlink/specs/devlink.yaml +++ b/Documentation/netlink/specs/devlink.yaml @@ -820,6 +820,9 @@ attribute-sets: - name: region-direct type: flag + - + name: info-function-uid + type: string - name: dl-dev-stats @@ -1869,6 +1872,7 @@ operations: - info-version-running - info-version-stored - info-board-serial-number + - info-function-uid dump: reply: *info-get-reply diff --git a/Documentation/networking/devlink/devlink-info.rst b/Documentation/networking/devlink/devlink-info.rst index 23073bc219d8..04afceee0c03 100644 --- a/Documentation/networking/devlink/devlink-info.rst +++ b/Documentation/networking/devlink/devlink-info.rst @@ -50,6 +50,11 @@ versions is generally discouraged - here, and via any other Linux API. This is usually the serial number of the board, often available in PCI *Vital Product Data*. + * - ``function.uid`` + - Function uniqueue identifier. + + Vendor defined uniqueue identifier of a function. + * - ``fixed`` - Group for hardware identifiers, and versions of components which are not field-updatable. diff --git a/include/net/devlink.h b/include/net/devlink.h index b8783126c1ed..a0b84efd4740 100644 --- a/include/net/devlink.h +++ b/include/net/devlink.h @@ -1846,6 +1846,8 @@ int devlink_info_serial_number_put(struct devlink_info_req *req, const char *sn); int devlink_info_board_serial_number_put(struct devlink_info_req *req, const char *bsn); +int devlink_info_function_uid_put(struct devlink_info_req *req, + const char *fuid); enum devlink_info_version_type { DEVLINK_INFO_VERSION_TYPE_NONE, diff --git a/include/uapi/linux/devlink.h b/include/uapi/linux/devlink.h index 9401aa343673..816339790409 100644 --- a/include/uapi/linux/devlink.h +++ b/include/uapi/linux/devlink.h @@ -614,6 +614,8 @@ enum devlink_attr { DEVLINK_ATTR_REGION_DIRECT, /* flag */ + DEVLINK_ATTR_INFO_FUNCTION_UID, /* string */ + /* Add new attributes above here, update the spec in * Documentation/netlink/specs/devlink.yaml and re-generate * net/devlink/netlink_gen.c. diff --git a/net/devlink/dev.c b/net/devlink/dev.c index d6e3db300acb..6c442549722c 100644 --- a/net/devlink/dev.c +++ b/net/devlink/dev.c @@ -763,6 +763,15 @@ int devlink_info_board_serial_number_put(struct devlink_info_req *req, } EXPORT_SYMBOL_GPL(devlink_info_board_serial_number_put); +int devlink_info_function_uid_put(struct devlink_info_req *req, + const char *fuid) +{ + if (!req->msg) + return 0; + return nla_put_string(req->msg, DEVLINK_ATTR_INFO_FUNCTION_UID, fuid); +} +EXPORT_SYMBOL_GPL(devlink_info_function_uid_put); + static int devlink_info_version_put(struct devlink_info_req *req, int attr, const char *version_name, const char *version_value, From patchwork Tue Mar 18 15:36:27 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jiri Pirko X-Patchwork-Id: 14021180 X-Patchwork-Delegate: kuba@kernel.org Received: from mail-wm1-f52.google.com (mail-wm1-f52.google.com [209.85.128.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CE95828FD for ; Tue, 18 Mar 2025 15:36:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.52 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1742312208; cv=none; b=eD4jsYF51PaYjhaekljaT6ZAeDgCJWUl2EaEeNWqNMl8aqQJ38W3P4Bl6VvQKSlVWbVF6GkqFWWZfwcH05p0fMWAzMMufF0QPAN1dyujS8q8qhgoFNgm3X6SDLLUutKbPLl8+4MqMyHwn0JeOlz75OKdfoz9n9mh1xfdsCR2FbI= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1742312208; c=relaxed/simple; bh=hCzI46TOxf0whbHlZzAK7Y9ErzVtzl/XtM9h25zqMm0=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=rjVZg2jKQJuiUQ7WpjnORU6lG5cOp8Enlkv0qL6UdVQTnF4NVuGaYRRopKMUlM92q6AmFqGGxWnXz1KH5UyoVm3Kz7Naw70Hlljy9/SVpRi0hjA34+BjbrXg75+Z/DvgN96y/mJy+PUVva0x4b25KvP6BvWyUINcno3kfJ30Tjs= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=resnulli.us; spf=none smtp.mailfrom=resnulli.us; dkim=pass (2048-bit key) header.d=resnulli-us.20230601.gappssmtp.com header.i=@resnulli-us.20230601.gappssmtp.com header.b=xAoEVvyf; arc=none smtp.client-ip=209.85.128.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=resnulli.us Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=resnulli.us Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=resnulli-us.20230601.gappssmtp.com header.i=@resnulli-us.20230601.gappssmtp.com header.b="xAoEVvyf" Received: by mail-wm1-f52.google.com with SMTP id 5b1f17b1804b1-43cfba466b2so35788625e9.3 for ; Tue, 18 Mar 2025 08:36:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=resnulli-us.20230601.gappssmtp.com; s=20230601; t=1742312205; x=1742917005; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=At6+XYAcNE+hfaNmHjS9408JCFLx8zx4kdKac5P8Z8M=; b=xAoEVvyfRD/c0DkOceXESGVx8Shd9gF+iIlkz1yXTSZLCjz8efxFIOIL3zmbTb0dwi XZGv2lpPU2c7sdWuPl1IHGP38A8Mp66ylbrLC3pLJcM1snRxWYMJHPlMriIwkSTCyiQ7 jhq21ZICgwxBxCVxZ6RF43FPj09hiEPsc6984vkqU6nsxyF5Ogg4LoHs8tDJBYSsAjqA GMZkdoefejJfYWFanABQbOGjogBg/JHiZJXD6W9JhNJ9NYB9fh+ic6DEFB11GjL2iJO6 rZCvrZN4GOarxUFJYbKS7WdXOrIJ84NOGtvJ9+YUO98PKcfPpEbGQrnqookotLxsURZ2 LETA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1742312205; x=1742917005; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=At6+XYAcNE+hfaNmHjS9408JCFLx8zx4kdKac5P8Z8M=; b=lxoUyTFxESGmkHz1lsV7XJOsr0/fiWPCDrqRbn0TEPnSLeUFX3t6HlitL997YuoC1g w4Qb6yX/2SvgYo59+d/1D7jD8EykDC7GpVP7VzvccD93ZTnVzxZOOcNlVYRu3ZenIo1u 6UUfta7WPfl4U1aGYucZpbwBPlON08htryeSZ0hPx4GRrFdG5X/LBczVHdBI6fvGello ia/vRi3K3pMCL9wm1L0fwU9+mnT6HSaYq8u0zYMnlGQ0SpHCzAZlw9hDIaL1rpT/BDPT jZA4ae/+Ja8c7di0JR5be7pcZ5SQTlmpxGELvosDa8Hr/jpTPa/NK+7u7jaovqpJCYHn eing== X-Gm-Message-State: AOJu0YwKVpBPnsdAhFsgTWGwV0qJNu8488GB5w0EFYXkRKFxOUHI1TZu bFKrvYprkcXm8+aXFI0bcoyuRrCYVuVp7czgWGpyYieon8ON2AGW6Uxqol5P2Ls6pZe7H2kpjSk U X-Gm-Gg: ASbGncuaEg4CRSCveaK3kyzOf/dhtr+0J9GXNWIvIBz9x9Z3iFrGRST50mfhEuVgzy2 8b8go6ikiJsTaTPoS24+sDImsgdjyZAUvWKByQS1lDa0TrcSGgNxLN2rDdJqvUnApebGWYdqmjm zX2iHclTCCVTNiwLLM6AOJ0uThDg34hnfzoRDhIrf/991Zlhda6ke1XJORX8wArVWv6fnRzA+wi xqsoMyMk9MyRoQSFKWTN+BnzyPDdvRXJYXzxreeHNIQcmOHMXb0TAHcUI0MEHeNljxbwgHCt0wU olxNAzEASdimN16/k8Q3iTYlR+lxDgGPNC7RDg== X-Google-Smtp-Source: AGHT+IFAHyg7X6M0U1I6d9cr5SNMGMLTLyD4bdbfak2m4L4DZOyzdIG49U9HDVuL7Qll8MwGOQs7Cg== X-Received: by 2002:a5d:6d08:0:b0:391:4940:45c3 with SMTP id ffacd0b85a97d-39720e3c9bcmr18462645f8f.54.1742312205214; Tue, 18 Mar 2025 08:36:45 -0700 (PDT) Received: from localhost ([193.47.165.251]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-395cb7ea16csm18289257f8f.82.2025.03.18.08.36.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 18 Mar 2025 08:36:44 -0700 (PDT) From: Jiri Pirko To: netdev@vger.kernel.org Cc: davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, saeedm@nvidia.com, leon@kernel.org, tariqt@nvidia.com, andrew+netdev@lunn.ch, horms@kernel.org, donald.hunter@gmail.com, parav@nvidia.com Subject: [PATCH net-next 4/4] net/mlx5: Expose function UID in devlink info Date: Tue, 18 Mar 2025 16:36:27 +0100 Message-ID: <20250318153627.95030-5-jiri@resnulli.us> X-Mailer: git-send-email 2.48.1 In-Reply-To: <20250318153627.95030-1-jiri@resnulli.us> References: <20250318153627.95030-1-jiri@resnulli.us> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Patchwork-Delegate: kuba@kernel.org From: Jiri Pirko Devlink info allows to expose function UID. Get the value from PCI VPD and expose it. $ devlink dev info pci/0000:08:00.0: driver mlx5_core serial_number e4397f872caeed218000846daa7d2f49 board.serial_number MT2314XZ00YA function.uid MT2314XZ00YAMLNXS0D0F0 versions: fixed: fw.psid MT_0000000894 running: fw.version 28.41.1000 fw 28.41.1000 stored: fw.version 28.41.1000 fw 28.41.1000 auxiliary/mlx5_core.eth.0: driver mlx5_core.eth pci/0000:08:00.1: driver mlx5_core serial_number e4397f872caeed218000846daa7d2f49 board.serial_number MT2314XZ00YA function.uid MT2314XZ00YAMLNXS0D0F1 versions: fixed: fw.psid MT_0000000894 running: fw.version 28.41.1000 fw 28.41.1000 stored: fw.version 28.41.1000 fw 28.41.1000 auxiliary/mlx5_core.eth.1: driver mlx5_core.eth Signed-off-by: Jiri Pirko Reviewed-by: Parav Pandit --- drivers/net/ethernet/mellanox/mlx5/core/devlink.c | 13 +++++++++++++ 1 file changed, 13 insertions(+) diff --git a/drivers/net/ethernet/mellanox/mlx5/core/devlink.c b/drivers/net/ethernet/mellanox/mlx5/core/devlink.c index be0ae26d1582..6caaf174f44d 100644 --- a/drivers/net/ethernet/mellanox/mlx5/core/devlink.c +++ b/drivers/net/ethernet/mellanox/mlx5/core/devlink.c @@ -75,6 +75,19 @@ static int mlx5_devlink_serial_numbers_put(struct mlx5_core_dev *dev, kfree(str); } + start = pci_vpd_find_ro_info_keyword(vpd_data, vpd_size, "VU", &kw_len); + if (start >= 0) { + str = kstrndup(vpd_data + start, kw_len, GFP_KERNEL); + if (!str) { + err = -ENOMEM; + goto end; + } + end = strchrnul(str, ' '); + *end = '\0'; + err = devlink_info_function_uid_put(req, str); + kfree(str); + } + end: kfree(vpd_data); return err;