From patchwork Tue Mar 18 18:45:49 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= X-Patchwork-Id: 14021421 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 32DDAC28B2F for ; Tue, 18 Mar 2025 18:49:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-ID:Date:Subject:Cc :To:From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=g2WQ9fFDohBqiB1cjt/SGhFoyI1qDltTVB+2A1ZFdJI=; b=XH3rQYvUJdplqr qifW/4MwiM+yc4l8bwJfOgvVEAgCxJ4kyufVnB8vtEafTke90tSdJ635ac+vmy6/WocZOJhgTo6iI LE19GlI24CHibhx9dztKrwmZiev6ywRTPWYTyRkt6TbPC9JIr5HN7viyUsmY+QD/oL6+eTNeDJC9B F0Oq4d25uiXvOIHbUKYWAgxqan8+afdSt41QiWza0okXpByXlSZXXdwoGBNx0QFGIKMZxkw/cJmkH rbEjB46jfxEORDQ4dkvAW+lbcKHTzyjaDvCxDavG8JPUiYsD2/G9CMK7b/KkkTf5wCQpS93QeWTDn 0jcWJmnYMi5Y7xpxjzSA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1tubzz-00000006q9d-3wN1; Tue, 18 Mar 2025 18:49:11 +0000 Received: from algol.kleine-koenig.org ([2a01:4f8:c010:8611::2]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1tubwx-00000006ppH-39MS; Tue, 18 Mar 2025 18:46:08 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kleine-koenig.org; s=2022; t=1742323559; bh=SIYP7xVZV3lmgBMVLByXJICeBe4GP9DuYdjQ55XLqPA=; h=From:To:Cc:Subject:Date:From; b=gBD6wl8/L9k6WBaLBrJWyZ2squ8iBYPKQP0Ygpy6l3Hs9Ym+RHZtG9CpVzHQ97FhN cdq+jLr5gb8oVdsUDCm9/Lqv7lvXuzu5tZ/byw/tT8u22TJZPnmaAKLibhnOHDl9OL zbgs8kTxww7PPQKwPgKEnXWefFIsns4nKu4o0pe2Odh+qgjnbXKthHm+TWo1xhOEXh noxSgxxBrMmuCQ4E2GJh41/fISWYyYFq9YvemE+IS3DcNI4gDBSA7Pg/nl2mF15vin eRKRC1F2cgeTlG+5n6WmBjjcEuIoPT1P6suHQQHWFds8Py9G3TMMLuhs77tf14Z4KZ sKnL0wRIPb+pQ== Received: by algol.kleine-koenig.org (Postfix, from userid 1000) id C1A50FC57DD; Tue, 18 Mar 2025 19:45:59 +0100 (CET) From: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= To: Heiko Stuebner , Andrew Lunn Cc: Rob Herring , Krzysztof Kozlowski , Conor Dooley , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org Subject: [PATCH] arm64: dts: rockchip: Improve gmac phy setup for QNAP-TS433 Date: Tue, 18 Mar 2025 19:45:49 +0100 Message-ID: <20250318184550.47642-2-uwe@kleine-koenig.org> X-Mailer: git-send-email 2.47.1 MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1452; i=uwe@kleine-koenig.org; h=from:subject; bh=SIYP7xVZV3lmgBMVLByXJICeBe4GP9DuYdjQ55XLqPA=; b=owEBbQGS/pANAwAKAY+A+1h9Ev5OAcsmYgBn2b9eGjQYxA360+FfA+V4SDGvIdwQVyFQYDmUI RlbkAY3wP+JATMEAAEKAB0WIQQ/gaxpOnoeWYmt/tOPgPtYfRL+TgUCZ9m/XgAKCRCPgPtYfRL+ TgMfB/9UMa+vPPygl9iWkXvL5g8ULT0onyQk+mJ7inIUeSMhJs8sORjSJfzePW7viN/txkh8wkH uM7C+sR83bIUdoDdkUQTEMlS2+4eAoL6V2wMADbcrQFqUzE4iLzlJzj0EKd7CVYCp/XOBvWYqww IHLrAlQl4/xWW709iHH1QSGrOalcMZ4DaubVangBfQyVqVSE0zmeYU3ktKaMd1lsjy3WFHkdhl9 f35FUGov7FTWh2rogn/E6/EGXLwIucCM7N/ZFnhqP89OSESnd3HSoCE3hQpYQSNMUzs9Jpqklt4 3ijdgyKUpUxRa2F9OrxTYC7Qi1NlTzZfe8VHd65VnlxqA/vM X-Developer-Key: i=uwe@kleine-koenig.org; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250318_114603_933826_9A99BF5B X-CRM114-Status: UNSURE ( 9.98 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-rockchip@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Upstream kernel work for Rockchip platforms List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Linux-rockchip" Errors-To: linux-rockchip-bounces+linux-rockchip=archiver.kernel.org@lists.infradead.org Instead of relying on the MDIO broadcast address (0) talk to the phy on its configured address. Also add the phy reset gpio which was found by Heiko inspecting the U-Boot vendor source code. He is still trying to recover. Signed-off-by: Uwe Kleine-König --- .../arm64/boot/dts/rockchip/rk3568-qnap-ts433.dts | 15 +++++++++++++-- 1 file changed, 13 insertions(+), 2 deletions(-) base-commit: 2014c95afecee3e76ca4a56956a936e23283f05b diff --git a/arch/arm64/boot/dts/rockchip/rk3568-qnap-ts433.dts b/arch/arm64/boot/dts/rockchip/rk3568-qnap-ts433.dts index 7bd32d230ad2..411f8ac7994b 100644 --- a/arch/arm64/boot/dts/rockchip/rk3568-qnap-ts433.dts +++ b/arch/arm64/boot/dts/rockchip/rk3568-qnap-ts433.dts @@ -481,9 +481,14 @@ eeprom@56 { }; &mdio0 { - rgmii_phy0: ethernet-phy@0 { + rgmii_phy0: ethernet-phy@3 { + /* Motorcomm YT8521 phy */ compatible = "ethernet-phy-ieee802.3-c22"; - reg = <0x0>; + reg = <0x3>; + pinctrl-0 = <ð_phy0_reset_pin>; + pinctrl-names = "default"; + reset-assert-us = <10000>; + reset-gpios = <&gpio0 RK_PC6 GPIO_ACTIVE_LOW>; }; }; @@ -556,6 +561,12 @@ &pcie3x2 { }; &pinctrl { + gmac0 { + eth_phy0_reset_pin: eth-phy0-reset-pin { + rockchip,pins = <0 RK_PC6 RK_FUNC_GPIO &pcfg_pull_up>; + }; + }; + keys { copy_button_pin: copy-button-pin { rockchip,pins = <0 RK_PB6 RK_FUNC_GPIO &pcfg_pull_up>;