From patchwork Tue Mar 18 20:57:32 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Prabhakar X-Patchwork-Id: 14021554 X-Patchwork-Delegate: kuba@kernel.org Received: from mail-wr1-f46.google.com (mail-wr1-f46.google.com [209.85.221.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7AD3817A30D; Tue, 18 Mar 2025 20:57:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.46 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1742331475; cv=none; b=MsgIyeSwJoIhJn8oj8y9+ZWLiKmWlrhcxtvSEM6TkCYnUaSvAdaES9QHTA0OtWi3F8NnSEAN6AaWMXIbIN0x+Xr9wMwwQQpqO046y+6NW/4ammYCEL81UeabewDTBibnFpN4PDZz+fBrAC8pyqhpr8AS6z3wshdTeFf7HKM1e/0= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1742331475; c=relaxed/simple; bh=D8zXftmgooMNEuXwEGXh7eQ5bSdZLKmudwqSE6iqe3w=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=mzYkNo1zUxNQd1nX1W1315aK1Z4whJ8WERviZb3Kg/6Zf2VHQQMS/xULPrW1ah3rnL5jDS4kkrRsbOC/hS2wzooQhEmzIVneLS1y/YJq+zmfnDN/SJCxQn31O8PZaEAffAikXNSfNhAQPvuU0lGhnjR05VdUKRrnF5rhazVxrhs= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=LuoIWmfo; arc=none smtp.client-ip=209.85.221.46 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="LuoIWmfo" Received: by mail-wr1-f46.google.com with SMTP id ffacd0b85a97d-39104c1cbbdso3532055f8f.3; Tue, 18 Mar 2025 13:57:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1742331472; x=1742936272; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=rOqWRXBRe2pqifdU7Acak1KZR++C20ubnAdFSNcNptk=; b=LuoIWmfonpAZbHQjnGPcMmhpZ4Fi86XUIcDd5gi04UR70ia7bVc37lmPC5SDNkK4Sp JVb2q75eWwWZGEa35JGezZL/pXjGYjWAhm0N+LeM3K56rG90npIiFoMM2Xwh6GhxTR1e 6gHT3NVnlwzBGPvPS+kYzcd5Vhrmi1CUjKzxVbqe1ID3pGmHbWbbCcEMW+/lrrMDFnSG VYtJ7o9FM2Vw0KofzXru/Eorbuu0k72P/EhPAMEoo3wTrg8qIsYXtzrbZ5XT05FTQwus gjF+Msftuw1gA9IoFU1gmYd3bptihLCOjkpenCZBRUMjGJQh6QPdeuUPgpxf+CLLOn4u ub3A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1742331472; x=1742936272; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=rOqWRXBRe2pqifdU7Acak1KZR++C20ubnAdFSNcNptk=; b=ck48YGo2nBgeWFTELOPaxAo6XTsJnAlC9ppOBAfczKL9htGjktHZ11A+3+Fp+qJdNe NjoRRMEtfVHthpsQTl2UBD2PunxDwdRyIfJEw8iC/YS/4+Q/WIlxdKxUsGYNP+oPOp7o 6AdJl7MSfxbUSTqKqDlIPbAZUuGYOslUDVRNdB0/Z2r2vp1m98HY/B9UcTJSYR3IbdmW A+uaP7UP0kOx/eGpjdq2vgpESIkNsCI+DiRQKTJqru0SvPb1nqrMB+GHzrc3nR9CspFZ fCj3g8d6KlhDWJZzX47ZG9+4boWCNeYNXUOREUvZScGqNkBc40dJMcsdCVodDxtyzGxL kPeA== X-Forwarded-Encrypted: i=1; AJvYcCU7f9svMDrV6ExP0NHep/AFNH4x7AboEvFtnUyjoqMTzo3SOq3rb3e3WzTVzh2qRt3ucMiz1wXK@vger.kernel.org, AJvYcCUIg/UnsQTn+T2LqGBhH8AqYEvIvoQl295+TKA+aVaUELa1ytwX/KMI90pdhaKKxKgaIpvdrUr/jUj2xH0FBoKBsqE=@vger.kernel.org, AJvYcCWjVdj7/cJhne5h8TR5ZVGS8z7flp6sifPOU7osIKIZVBQzwerCe8jwr74EC9BvhkIovz5db5LL3aM/XN0=@vger.kernel.org X-Gm-Message-State: AOJu0Ywlt2K8NpH5/LGdSvnIiNOGJR4UkQya79MyQi4GkwcjsosnzQ/v uN38q6bgAcnDd+HcYte4skUtSb5EVZAd2Wuyh2aoZdzg04jNk+Nu X-Gm-Gg: ASbGncuv0tBnCpout/+roa/EYuARit9c6Lg263pvqjSgJ594nuw8B55dOCXR+95qrww axyrozOR21Uk9L/D3EZVd6fwSuEt9B1hjfK4787iVzdTDl2DIXocE+GMlHUcBmhpGEhq71TPwE2 iYHfACtWcMLukOzQajMD0Hkzz3+PVf2oxnHhUXZ8O/WLIhyHcxxujMIZTt3mTN7/MPy4g1ROoGS TEWtWwzDylg02jpGCwe5/GAEqdDmfxMCXXBn0DfUlzquC5cfigQDNqOuWOimrw+xEjwHy7AGaBj 8oWF+zwJitGo6o5S/kpFXP/d03U0ZI8CEEu+ZwYWSSGZX+Qf38jmc9/nJDq74po5zklMHw== X-Google-Smtp-Source: AGHT+IHdGog0XJhc86+9+5MvyCOjHWnyT0IqtRxaIhNO99BGj46bimLiGEem31ojE8KbEcAcoXE7Qg== X-Received: by 2002:a5d:5f49:0:b0:391:27f1:fbf8 with SMTP id ffacd0b85a97d-399739b4becmr176145f8f.4.1742331471565; Tue, 18 Mar 2025 13:57:51 -0700 (PDT) Received: from iku.Home ([2a06:5906:61b:2d00:9ebf:9797:69d8:2d33]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-395c7df3537sm19212864f8f.8.2025.03.18.13.57.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 18 Mar 2025 13:57:51 -0700 (PDT) From: Prabhakar X-Google-Original-From: Prabhakar To: Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Philipp Zabel , Geert Uytterhoeven , Magnus Damm , "Russell King (Oracle)" , Giuseppe Cavallaro , Jose Abreu , netdev@vger.kernel.org Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-renesas-soc@vger.kernel.org, Prabhakar , Biju Das , Fabrizio Castro , Lad Prabhakar Subject: [PATCH net-next v4 1/3] dt-bindings: net: dwmac: Increase 'maxItems' for 'interrupts' and 'interrupt-names' Date: Tue, 18 Mar 2025 20:57:32 +0000 Message-ID: <20250318205735.122590-2-prabhakar.mahadev-lad.rj@bp.renesas.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250318205735.122590-1-prabhakar.mahadev-lad.rj@bp.renesas.com> References: <20250318205735.122590-1-prabhakar.mahadev-lad.rj@bp.renesas.com> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Patchwork-Delegate: kuba@kernel.org From: Lad Prabhakar Increase the `maxItems` value for the `interrupts` and `interrupt-names` properties to 11 to support additional per-channel Tx/Rx completion interrupts on the Renesas RZ/V2H(P) SoC, which features the `snps,dwmac-5.20` IP. Refactor the `interrupt-names` property by replacing repeated `enum` entries with a `oneOf` list. Add support for per-channel receive and transmit completion interrupts using regex patterns. Signed-off-by: Lad Prabhakar Reviewed-by: Rob Herring (Arm) --- v3->v4 - Fixed maxItems for interrupt-names property - Added RB tag from Rob v2->v3 - Dropped adding `additionalItems` - Moved interrupts description into interrupt-names - Replaced enum with a oneOf and added Rx/Tx regex patterns v1->v2 - No change --- .../devicetree/bindings/net/snps,dwmac.yaml | 24 ++++++++++++------- 1 file changed, 15 insertions(+), 9 deletions(-) diff --git a/Documentation/devicetree/bindings/net/snps,dwmac.yaml b/Documentation/devicetree/bindings/net/snps,dwmac.yaml index 78b3030dc56d..4d4fcaeca8a8 100644 --- a/Documentation/devicetree/bindings/net/snps,dwmac.yaml +++ b/Documentation/devicetree/bindings/net/snps,dwmac.yaml @@ -114,19 +114,25 @@ properties: interrupts: minItems: 1 - items: - - description: Combined signal for various interrupt events - - description: The interrupt to manage the remote wake-up packet detection - - description: The interrupt that occurs when Rx exits the LPI state - - description: The interrupt that occurs when HW safety error triggered + maxItems: 11 interrupt-names: minItems: 1 + maxItems: 11 items: - - const: macirq - - enum: [eth_wake_irq, eth_lpi, sfty] - - enum: [eth_wake_irq, eth_lpi, sfty] - - enum: [eth_wake_irq, eth_lpi, sfty] + oneOf: + - description: Combined signal for various interrupt events + const: macirq + - description: The interrupt to manage the remote wake-up packet detection + const: eth_wake_irq + - description: The interrupt that occurs when Rx exits the LPI state + const: eth_lpi + - description: The interrupt that occurs when HW safety error triggered + const: sfty + - description: Per channel receive completion interrupt + pattern: '^rx-queue-[0-3]$' + - description: Per channel transmit completion interrupt + pattern: '^tx-queue-[0-3]$' clocks: minItems: 1 From patchwork Tue Mar 18 20:57:33 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Prabhakar X-Patchwork-Id: 14021555 X-Patchwork-Delegate: kuba@kernel.org Received: from mail-wm1-f54.google.com (mail-wm1-f54.google.com [209.85.128.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B36612135BC; Tue, 18 Mar 2025 20:57:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.54 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1742331476; cv=none; b=gFfu5oKX9n87Ib80t9+e82Gv9WuCOI0ZTVITG9Km8XlNa2LoKza/RKlhRUGu3bjWRDL+RYFcymbzUq+VUTFDsJOHtmB8LxzqMpS9yNaG2CcejfOW2TfAfIyfVrzrsvQBtMTqOjwB3/6vigeNFIszXYI62Foq6qHYYH7Z0OTfDc8= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1742331476; c=relaxed/simple; bh=iSX683jIYJ5Nbv8GosXqC/1aA+Rmp/P6MFB3vJYXDXI=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=XduZrlBLTT/TOA47VWje0M/6x0mJFQGB0iqvCsIeKY36FcIEK+vVaAw+ytpelhJ4CL7BSlPMSYfa5h94jTdxZEnJ96ufg+b2L0PuXz77soZgQ7ymUxTgmUOytR0l7KaGz6YPkwhfZ3dc5itW66buRydBnVqk1VASZfjCzhWTACw= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=m+5OoxQ6; arc=none smtp.client-ip=209.85.128.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="m+5OoxQ6" Received: by mail-wm1-f54.google.com with SMTP id 5b1f17b1804b1-43cfe63c592so42040085e9.2; Tue, 18 Mar 2025 13:57:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1742331473; x=1742936273; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=Xs7vUt1wverkf1Iu/m6fNn9VLl/O1RwCIir4usjCQLk=; b=m+5OoxQ6PlL6hAXkSv4JtEonFwC+v329SyhueC8p/LQD94gD0raUUzr9WpSbTKiNcZ vGTXvVbhGu1pKbHhUSqD3FkKr8gMwrWcHNWqE5zuEu9qRI0IpwEOU8wYxGJQpPbsiHdE BsZbPCV3wDqAT4nuIaaII30jxHccq84l5yXTTIBD7WBjPpoYoWq4a5XgbkH5xWUcVUut sYsZIpxn1EFYpdQbT9PTleTjh75ETKTdwE0Qxx896yPBy/kQJQT5jzGhWiiz9fO3Kg2c So5fAvWU7oQNzAz9ZjA+pkmdNbayiOYGDOtJ8TkXN2inQUyO+TJIlif0C0XmONFDWgfx QWAg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1742331473; x=1742936273; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Xs7vUt1wverkf1Iu/m6fNn9VLl/O1RwCIir4usjCQLk=; b=uKK0EjLhH0bVE9CnLyW0h8OxjePsSCQ4L8/s+mTVQpvU+w0qH/TsdNH0O611qSH1gE 3yJTss9Acv7fKFmy4v4RaYwnJQATYdnluWAGh/fnP4O+NTKt8+qptkwfO9+jKmXAl9FE qh9u6jKlbS2zUpY4Ght+9wku1m1HKT0T5ReQTTK5NcrocB0gLFItzIWVAG/BKax0TuBC ubLdISAKfwjf5aqy4oYF25uBPJ3wtbocwJopvXHy2U3LhpxSElBp2RjaGIS8icUSOlq9 KyJQcNJWxQSkBC18hJDuVzQJ4NKvnRdEPAJiRXwFJPnqzcTE0ZEDGycfXP2kpcI3jGXL 9wfw== X-Forwarded-Encrypted: i=1; AJvYcCVAtxSjsanKNVYT2MR/AlhAbMjtei81CRbU2gj9pZ90QbEx1qADkzPrpnwPb8AxA+vr/nlgyqMi/dSijYssI409w4k=@vger.kernel.org, AJvYcCXR+9d5KsAVDWUu+yNuluEqemJQMYQiDRnpwDXQ+KQ8ytlvWZVlQm77Xh27WjW9IoVf+/3b7ID+@vger.kernel.org, AJvYcCXoWRiVasF1aj5rNHUAnKdrDRm9kyjt0Cy6W7h2ENxaGZvjInj8wYWFyMOB9YuX55JYZopl6oLQyh9uuEo=@vger.kernel.org X-Gm-Message-State: AOJu0Yx2egeCHClSgl7lM3ZCzK52kgl+eMb7kRkI4lAsuVGem7Il3/1Q 2bK0BZhOX+BgqGatOpEkZqZwmy8wBpG6JIfi2lHEgZCpj1lPZoPP X-Gm-Gg: ASbGncvClyX60pKUfRwl3iVtRbKmeT76KJ/2BIo869ZZuU5SIZKj5TwhyBvGk1NqKll HOtR93um/cGoe8esbNa1ShzOyMtC0PonNsJ8t2YJndFLUkaE/Bs/FaIT5dNVynFryH8LrWTvpsA zRg2fmLEJ6XP7qM8rHvKL/m1ZKIon+bF3XZOmGD5RR23n5r+Bzh1RbD5BaWJnsNKz3D0XA459w3 /nRQhmDPgzLWGb9xUC7at55mImMKtT/CKfzuoWBhq4HtMybfCGkp06y4T138n3aqjjIIGJQoGKp bE76IM4PmtWZJ7WR9aTFbkIDZb5SAVqZmU91QsA69NSvBGQTicyEPvQeK0+ZJ/iYxz274w== X-Google-Smtp-Source: AGHT+IH9BhQMKh8BMydKoTUyoWRGW65UGlZYRSRUKhZ3QhlmVeX23Bpkmn2is3XEJmZ8mKDebYhAJw== X-Received: by 2002:a05:6000:21c7:b0:399:728f:4673 with SMTP id ffacd0b85a97d-399739cbd2amr171087f8f.33.1742331472830; Tue, 18 Mar 2025 13:57:52 -0700 (PDT) Received: from iku.Home ([2a06:5906:61b:2d00:9ebf:9797:69d8:2d33]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-395c7df3537sm19212864f8f.8.2025.03.18.13.57.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 18 Mar 2025 13:57:52 -0700 (PDT) From: Prabhakar X-Google-Original-From: Prabhakar To: Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Philipp Zabel , Geert Uytterhoeven , Magnus Damm , "Russell King (Oracle)" , Giuseppe Cavallaro , Jose Abreu , netdev@vger.kernel.org Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-renesas-soc@vger.kernel.org, Prabhakar , Biju Das , Fabrizio Castro , Lad Prabhakar Subject: [PATCH net-next v4 2/3] dt-bindings: net: Document support for Renesas RZ/V2H(P) GBETH Date: Tue, 18 Mar 2025 20:57:33 +0000 Message-ID: <20250318205735.122590-3-prabhakar.mahadev-lad.rj@bp.renesas.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250318205735.122590-1-prabhakar.mahadev-lad.rj@bp.renesas.com> References: <20250318205735.122590-1-prabhakar.mahadev-lad.rj@bp.renesas.com> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Patchwork-Delegate: kuba@kernel.org From: Lad Prabhakar GBETH IP on the Renesas RZ/V2H(P) SoC is integrated with Synopsys DesignWare MAC (version 5.20). Document the device tree bindings for the GBETH glue layer. Generic compatible string 'renesas,rzv2h-gbeth' is added since this module is identical on both the RZ/V2H(P) and RZ/G3E SoCs. The Rx/Tx clocks supplied for GBETH on the RZ/V2H(P) SoC is depicted below: Rx / Tx -------+------------- on / off ------- | | Rx-180 / Tx-180 +---- not ---- on / off ------- Signed-off-by: Lad Prabhakar Reviewed-by: Rob Herring (Arm) --- v3->v4 - No change v2->v3 - Dropped interrupts description from interrupts property as snps,dwmac.yaml already describes it. - Dropped snps,en-tx-lpi-clockgating as this is being marked as deprecated. - Updated Rx/Tx interrupt names to match the regex from patch 1/3 - Listed Rx interrupts before Tx interrupts in example node for consistency. v1->v2 - Updated commit description - Updated interrupts description for clarity - Updated interrupt-names for clarity - Updated example node --- .../bindings/net/renesas,r9a09g057-gbeth.yaml | 201 ++++++++++++++++++ .../devicetree/bindings/net/snps,dwmac.yaml | 1 + 2 files changed, 202 insertions(+) create mode 100644 Documentation/devicetree/bindings/net/renesas,r9a09g057-gbeth.yaml diff --git a/Documentation/devicetree/bindings/net/renesas,r9a09g057-gbeth.yaml b/Documentation/devicetree/bindings/net/renesas,r9a09g057-gbeth.yaml new file mode 100644 index 000000000000..02a6793c26f5 --- /dev/null +++ b/Documentation/devicetree/bindings/net/renesas,r9a09g057-gbeth.yaml @@ -0,0 +1,201 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/net/renesas,r9a09g057-gbeth.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: GBETH glue layer for Renesas RZ/V2H(P) (and similar SoCs) + +maintainers: + - Lad Prabhakar + +select: + properties: + compatible: + contains: + enum: + - renesas,r9a09g057-gbeth + - renesas,rzv2h-gbeth + required: + - compatible + +properties: + compatible: + items: + - enum: + - renesas,r9a09g057-gbeth # RZ/V2H(P) + - const: renesas,rzv2h-gbeth + - const: snps,dwmac-5.20 + + reg: + maxItems: 1 + + clocks: + items: + - description: CSR clock + - description: AXI system clock + - description: PTP clock + - description: TX clock + - description: RX clock + - description: TX clock phase-shifted by 180 degrees + - description: RX clock phase-shifted by 180 degrees + + clock-names: + items: + - const: stmmaceth + - const: pclk + - const: ptp_ref + - const: tx + - const: rx + - const: tx-180 + - const: rx-180 + + interrupts: + minItems: 11 + + interrupt-names: + items: + - const: macirq + - const: eth_wake_irq + - const: eth_lpi + - const: rx-queue-0 + - const: rx-queue-1 + - const: rx-queue-2 + - const: rx-queue-3 + - const: tx-queue-0 + - const: tx-queue-1 + - const: tx-queue-2 + - const: tx-queue-3 + + resets: + items: + - description: AXI power-on system reset + +required: + - compatible + - reg + - clocks + - clock-names + - interrupts + - interrupt-names + - resets + +allOf: + - $ref: snps,dwmac.yaml# + +unevaluatedProperties: false + +examples: + - | + #include + #include + + ethernet@15c30000 { + compatible = "renesas,r9a09g057-gbeth", "renesas,rzv2h-gbeth", "snps,dwmac-5.20"; + reg = <0x15c30000 0x10000>; + clocks = <&cpg CPG_MOD 0xbd>, <&cpg CPG_MOD 0xbc>, + <&ptp_clock>, <&cpg CPG_MOD 0xb8>, + <&cpg CPG_MOD 0xb9>, <&cpg CPG_MOD 0xba>, + <&cpg CPG_MOD 0xbb>; + clock-names = "stmmaceth", "pclk", "ptp_ref", + "tx", "rx", "tx-180", "rx-180"; + resets = <&cpg 0xb0>; + interrupts = , + , + , + , + , + , + , + , + , + , + ; + interrupt-names = "macirq", "eth_wake_irq", "eth_lpi", + "rx-queue-0", "rx-queue-1", "rx-queue-2", + "rx-queue-3", "tx-queue-0", "tx-queue-1", + "tx-queue-2", "tx-queue-3"; + phy-mode = "rgmii-id"; + snps,multicast-filter-bins = <256>; + snps,perfect-filter-entries = <128>; + rx-fifo-depth = <8192>; + tx-fifo-depth = <8192>; + snps,fixed-burst; + snps,force_thresh_dma_mode; + snps,axi-config = <&stmmac_axi_setup>; + snps,mtl-rx-config = <&mtl_rx_setup>; + snps,mtl-tx-config = <&mtl_tx_setup>; + snps,txpbl = <32>; + snps,rxpbl = <32>; + phy-handle = <&phy0>; + + stmmac_axi_setup: stmmac-axi-config { + snps,lpi_en; + snps,wr_osr_lmt = <0xf>; + snps,rd_osr_lmt = <0xf>; + snps,blen = <16 8 4 0 0 0 0>; + }; + + mtl_rx_setup: rx-queues-config { + snps,rx-queues-to-use = <4>; + snps,rx-sched-sp; + + queue0 { + snps,dcb-algorithm; + snps,priority = <0x1>; + snps,map-to-dma-channel = <0>; + }; + + queue1 { + snps,dcb-algorithm; + snps,priority = <0x2>; + snps,map-to-dma-channel = <1>; + }; + + queue2 { + snps,dcb-algorithm; + snps,priority = <0x4>; + snps,map-to-dma-channel = <2>; + }; + + queue3 { + snps,dcb-algorithm; + snps,priority = <0x8>; + snps,map-to-dma-channel = <3>; + }; + }; + + mtl_tx_setup: tx-queues-config { + snps,tx-queues-to-use = <4>; + + queue0 { + snps,dcb-algorithm; + snps,priority = <0x1>; + }; + + queue1 { + snps,dcb-algorithm; + snps,priority = <0x2>; + }; + + queue2 { + snps,dcb-algorithm; + snps,priority = <0x4>; + }; + + queue3 { + snps,dcb-algorithm; + snps,priority = <0x1>; + }; + }; + + mdio { + #address-cells = <1>; + #size-cells = <0>; + compatible = "snps,dwmac-mdio"; + + phy0: ethernet-phy@0 { + reg = <0>; + }; + }; + }; diff --git a/Documentation/devicetree/bindings/net/snps,dwmac.yaml b/Documentation/devicetree/bindings/net/snps,dwmac.yaml index 4d4fcaeca8a8..b525eca53850 100644 --- a/Documentation/devicetree/bindings/net/snps,dwmac.yaml +++ b/Documentation/devicetree/bindings/net/snps,dwmac.yaml @@ -75,6 +75,7 @@ properties: - qcom,sm8150-ethqos - renesas,r9a06g032-gmac - renesas,rzn1-gmac + - renesas,rzv2h-gbeth - rockchip,px30-gmac - rockchip,rk3128-gmac - rockchip,rk3228-gmac From patchwork Tue Mar 18 20:57:34 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Prabhakar X-Patchwork-Id: 14021556 X-Patchwork-Delegate: kuba@kernel.org Received: from mail-wm1-f52.google.com (mail-wm1-f52.google.com [209.85.128.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DC6C2213E81; Tue, 18 Mar 2025 20:57:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.52 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1742331478; cv=none; b=Ii5y0vEP7r/qOQL/FPsYP7AZcemhzKjeTCQ/0vvW7VIaC3MJG5UKTwd0kNbbYiSiQIkxkLtQ75GubgrlM/1nMKSh7UN/ePeYSF1ehmlNho6FZj04Nlr3dG/3eOn6nQfJtL0xj27NByUU/p1R5YHY4ldVeOr1iN9vzQnJTdE1Rts= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1742331478; c=relaxed/simple; bh=/ZzZVPTFxEf4L1cxrnhQomHyB3nsg72CEN1d/OvJQMk=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=ULTlEnwGpP5Bx8XBa4ttOui6jHT7mO+2m3aRazoNbfM/jjG0a7SWII1eRSANG5BnrA+YaQn3A56F49dTSHfABzUB373CUSbH13QH9yNPl/5olD5lkuzc1JX1+j7EMSQD53wTCuQTg+aAT3hYZzl2cPDoZ7SrdHzgdE9X8ursDWw= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=IKUG50hP; arc=none smtp.client-ip=209.85.128.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="IKUG50hP" Received: by mail-wm1-f52.google.com with SMTP id 5b1f17b1804b1-43d04ea9d9aso17926715e9.3; Tue, 18 Mar 2025 13:57:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1742331474; x=1742936274; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=tpoJIhKMPnnM9yksAMFgRv5MdInAsPZ0FiZCrfV1NNw=; b=IKUG50hPMhZP3iVz4+TwqeXPnPbqHN6rqx7Q1ulzKskpg9Vz8QE+it8M66OOojALKJ F8kFdWlOl6eQPyiI7mWLv7TqRuKpouBKSezTu/4F/zPJA0bRaMW/rTSh9MOeuzHB37OJ fypfpB2hJQXf+dpB4GUqYXlefkmLiHjkO9VZuKZL4X7X7WqIO1ASnL6X6zJw37p4jgcT ZeYUoNYmhQ7PM+XdMXQoBgeF+Lmv4dw0lqQmEsJUz+WM0JqpIdVGCwh29jVojnfHCPcy 6L2TqEckePKS5URZ0SQViCIarWdR1IgCf6u0J+tFTQUIOcJeixEHHRlyTyfyft14Pkw7 QL1g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1742331474; x=1742936274; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=tpoJIhKMPnnM9yksAMFgRv5MdInAsPZ0FiZCrfV1NNw=; b=HRym0nU+VIq0d8CLL1jpmCisa6vqep/bwQ0dL+Z777SCuaeSbe47SCglXjyP4ZqgPy Ldd9tTWvb7hVNBuPuzTcoAdb/JgK7G9yFObnkUMtEsueCJ4/SOISxKp4+Ajs413Cy4oP nnjB5l2Y/EJwT1uUDgij3YvX3yw1nDmRDZ9zxO0V0FM4stkPgr36jPtqlohGrAa63pPP GXwnuxCQ+VNMnypf4rtm2/zVIjeTtEPqgVLJ64LmOD6NzGqIMvfbAWv2IQSEbqTWyR7B 8p5DQqueKEMWR29vZPeIiVlbDvtbXd5YNbQkixeOKXYhi+gGqR66p9UHb0QiYMNqJV+K VVzA== X-Forwarded-Encrypted: i=1; AJvYcCUGuTn/Jq4Mgd4/D/caWa3mqCp128j1CXNKD1Gh3HtZH+ysjD21eh7TKk3lfqCRDalbHn40fR/fo5u14SvCrC7mY8o=@vger.kernel.org, AJvYcCV69IXRYfO8/FiHnLqKyVXx9psQ2c++A7mviy/9drKVRqjWs5vgoXpApijlymWEyAdCpMPcF+2E3soUMCk=@vger.kernel.org, AJvYcCWUIMUIfeiJtl/O6ELS6MOQqPYUrRc6WulYf6Uzs/8dH1gwciYVWWnQ+z9IwANTqtKVfZ7VLAKZ@vger.kernel.org X-Gm-Message-State: AOJu0Ywe7i9Hv1nc3cpiZxRD9xyCQ/J/Oa61+0zb3zXcNDEiZ1NiWEen QOiNnqO/F2/faUqnBv5XgR7q9Bn+1p/k0yhGfAbKwE8cM0DgSrgU X-Gm-Gg: ASbGncvcpqKwp1RoStaC1iZm6sExurtvwBY7igdj/Hi+3nExzezyp6mAnfj32q0yCH6 NlL29hjDFZ+zsiY3UtmszcZIsYotUKORTKbB8RNDZIJQ2i4EjhWrRoFiqBbviJRgwk7U0hSJ0lm hGdNE7C3WrNknZHWoI8BBHedPb0yQMYmiNElJL5bxzYp2kXA0tS0HQCkgPruJgOKYbN2y5tlY/X HK1f9mRhX0tPzfHcAhGBCAoWtUlO1QtBXi0hrpRAEi8J6PZqeasxEjzSlQVymuQjk7bk8bnVF4l o2TkMh0agmYPoVaKGUrDOsakZnQrmMVqRfXlE8Thq8OOi8m1w3vFA5ObrI7ESh9MOEQCaSkWJYC DswqP X-Google-Smtp-Source: AGHT+IFQBVuKDQ5gUzwfhz+BtiK96m2NzR/BDMphjisz10gvNtP+w7/6t5edGmm0J4kKTd0rzBmf2Q== X-Received: by 2002:a5d:5886:0:b0:391:3915:cfea with SMTP id ffacd0b85a97d-39973af6db5mr222148f8f.38.1742331473992; Tue, 18 Mar 2025 13:57:53 -0700 (PDT) Received: from iku.Home ([2a06:5906:61b:2d00:9ebf:9797:69d8:2d33]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-395c7df3537sm19212864f8f.8.2025.03.18.13.57.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 18 Mar 2025 13:57:53 -0700 (PDT) From: Prabhakar X-Google-Original-From: Prabhakar To: Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Philipp Zabel , Geert Uytterhoeven , Magnus Damm , "Russell King (Oracle)" , Giuseppe Cavallaro , Jose Abreu , netdev@vger.kernel.org Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-renesas-soc@vger.kernel.org, Prabhakar , Biju Das , Fabrizio Castro , Lad Prabhakar Subject: [PATCH net-next v4 3/3] net: stmmac: Add DWMAC glue layer for Renesas GBETH Date: Tue, 18 Mar 2025 20:57:34 +0000 Message-ID: <20250318205735.122590-4-prabhakar.mahadev-lad.rj@bp.renesas.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250318205735.122590-1-prabhakar.mahadev-lad.rj@bp.renesas.com> References: <20250318205735.122590-1-prabhakar.mahadev-lad.rj@bp.renesas.com> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Patchwork-Delegate: kuba@kernel.org From: Lad Prabhakar Add the DWMAC glue layer for the GBETH IP found in the Renesas RZ/V2H(P) SoC. Signed-off-by: Lad Prabhakar --- v3->v4 - Maintained reverse christmas tree order in renesas_gbeth_clks_config - Returned err in case of success in renesas_gbeth_probe() v2->v3 - Handle clks from plat_dat - Replaced STMMAC_FLAG_EN_TX_LPI_CLOCKGATING flag with STMMAC_FLAG_EN_TX_LPI_CLK_PHY_CAP. v1->v2 - Dropped __initconst for renesas_gbeth_clks array - Added clks_config callback - Dropped STMMAC_FLAG_RX_CLK_RUNS_IN_LPI flag as this needs investigation. --- drivers/net/ethernet/stmicro/stmmac/Kconfig | 11 ++ drivers/net/ethernet/stmicro/stmmac/Makefile | 1 + .../stmicro/stmmac/dwmac-renesas-gbeth.c | 165 ++++++++++++++++++ 3 files changed, 177 insertions(+) create mode 100644 drivers/net/ethernet/stmicro/stmmac/dwmac-renesas-gbeth.c diff --git a/drivers/net/ethernet/stmicro/stmmac/Kconfig b/drivers/net/ethernet/stmicro/stmmac/Kconfig index 3c820ef56775..2c99b23f0faa 100644 --- a/drivers/net/ethernet/stmicro/stmmac/Kconfig +++ b/drivers/net/ethernet/stmicro/stmmac/Kconfig @@ -131,6 +131,17 @@ config DWMAC_QCOM_ETHQOS This selects the Qualcomm ETHQOS glue layer support for the stmmac device driver. +config DWMAC_RENESAS_GBETH + tristate "Renesas RZ/V2H(P) GBETH support" + default ARCH_RENESAS + depends on OF && (ARCH_RENESAS || COMPILE_TEST) + help + Support for Gigabit Ethernet Interface (GBETH) on Renesas + RZ/V2H(P) SoCs. + + This selects the Renesas RZ/V2H(P) Soc specific glue layer support + for the stmmac device driver. + config DWMAC_ROCKCHIP tristate "Rockchip dwmac support" default ARCH_ROCKCHIP diff --git a/drivers/net/ethernet/stmicro/stmmac/Makefile b/drivers/net/ethernet/stmicro/stmmac/Makefile index 594883fb4164..91050215511b 100644 --- a/drivers/net/ethernet/stmicro/stmmac/Makefile +++ b/drivers/net/ethernet/stmicro/stmmac/Makefile @@ -20,6 +20,7 @@ obj-$(CONFIG_DWMAC_LPC18XX) += dwmac-lpc18xx.o obj-$(CONFIG_DWMAC_MEDIATEK) += dwmac-mediatek.o obj-$(CONFIG_DWMAC_MESON) += dwmac-meson.o dwmac-meson8b.o obj-$(CONFIG_DWMAC_QCOM_ETHQOS) += dwmac-qcom-ethqos.o +obj-$(CONFIG_DWMAC_RENESAS_GBETH) += dwmac-renesas-gbeth.o obj-$(CONFIG_DWMAC_ROCKCHIP) += dwmac-rk.o obj-$(CONFIG_DWMAC_RZN1) += dwmac-rzn1.o obj-$(CONFIG_DWMAC_S32) += dwmac-s32.o diff --git a/drivers/net/ethernet/stmicro/stmmac/dwmac-renesas-gbeth.c b/drivers/net/ethernet/stmicro/stmmac/dwmac-renesas-gbeth.c new file mode 100644 index 000000000000..a0f7cacea810 --- /dev/null +++ b/drivers/net/ethernet/stmicro/stmmac/dwmac-renesas-gbeth.c @@ -0,0 +1,165 @@ +// SPDX-License-Identifier: GPL-2.0+ +/* + * dwmac-renesas-gbeth.c - DWMAC Specific Glue layer for Renesas GBETH + * + * The Rx and Tx clocks are supplied as follows for the GBETH IP. + * + * Rx / Tx + * -------+------------- on / off ------- + * | + * | Rx-180 / Tx-180 + * +---- not ---- on / off ------- + * + * Copyright (C) 2025 Renesas Electronics Corporation + */ + +#include +#include +#include +#include +#include + +#include "dwmac4.h" +#include "stmmac_platform.h" + +struct renesas_gbeth { + struct plat_stmmacenet_data *plat_dat; + struct reset_control *rstc; + struct device *dev; + void __iomem *regs; +}; + +static const char *const renesas_gbeth_clks[] = { + "tx", "tx-180", "rx", "rx-180", +}; + +static struct clk *renesas_gbeth_find_clk(struct plat_stmmacenet_data *plat_dat, + const char *name) +{ + for (unsigned int i = 0; i < plat_dat->num_clks; i++) + if (!strcmp(plat_dat->clks[i].id, name)) + return plat_dat->clks[i].clk; + + return NULL; +} + +static int renesas_gbeth_clks_config(void *priv, bool enabled) +{ + struct plat_stmmacenet_data *plat_dat; + struct renesas_gbeth *gbeth = priv; + int ret; + + plat_dat = gbeth->plat_dat; + if (enabled) { + ret = reset_control_deassert(gbeth->rstc); + if (ret) { + dev_err(gbeth->dev, "Reset deassert failed\n"); + return ret; + } + + ret = clk_bulk_prepare_enable(plat_dat->num_clks, plat_dat->clks); + if (ret) + reset_control_assert(gbeth->rstc); + } else { + clk_bulk_disable_unprepare(plat_dat->num_clks, plat_dat->clks); + ret = reset_control_assert(gbeth->rstc); + if (ret) + dev_err(gbeth->dev, "Reset assert failed\n"); + } + + return ret; +} + +static int renesas_gbeth_probe(struct platform_device *pdev) +{ + struct plat_stmmacenet_data *plat_dat; + struct stmmac_resources stmmac_res; + struct device *dev = &pdev->dev; + struct renesas_gbeth *gbeth; + unsigned int i; + int err; + + err = stmmac_get_platform_resources(pdev, &stmmac_res); + if (err) + return dev_err_probe(dev, err, + "failed to get resources\n"); + + plat_dat = devm_stmmac_probe_config_dt(pdev, stmmac_res.mac); + if (IS_ERR(plat_dat)) + return dev_err_probe(dev, PTR_ERR(plat_dat), + "dt configuration failed\n"); + + gbeth = devm_kzalloc(dev, sizeof(*gbeth), GFP_KERNEL); + if (!gbeth) + return -ENOMEM; + + plat_dat->num_clks = ARRAY_SIZE(renesas_gbeth_clks); + plat_dat->clks = devm_kcalloc(dev, plat_dat->num_clks, + sizeof(*plat_dat->clks), GFP_KERNEL); + if (!plat_dat->clks) + return -ENOMEM; + + for (i = 0; i < plat_dat->num_clks; i++) + plat_dat->clks[i].id = renesas_gbeth_clks[i]; + + err = devm_clk_bulk_get(dev, plat_dat->num_clks, plat_dat->clks); + if (err < 0) + return err; + + plat_dat->clk_tx_i = renesas_gbeth_find_clk(plat_dat, "tx"); + if (!plat_dat->clk_tx_i) + return dev_err_probe(dev, -EINVAL, + "error finding tx clock\n"); + + gbeth->rstc = devm_reset_control_get_exclusive(dev, NULL); + if (IS_ERR(gbeth->rstc)) + return PTR_ERR(gbeth->rstc); + + gbeth->dev = dev; + gbeth->regs = stmmac_res.addr; + gbeth->plat_dat = plat_dat; + plat_dat->bsp_priv = gbeth; + plat_dat->set_clk_tx_rate = stmmac_set_clk_tx_rate; + plat_dat->clks_config = renesas_gbeth_clks_config; + plat_dat->flags |= STMMAC_FLAG_HWTSTAMP_CORRECT_LATENCY | + STMMAC_FLAG_EN_TX_LPI_CLK_PHY_CAP | + STMMAC_FLAG_SPH_DISABLE; + + err = renesas_gbeth_clks_config(gbeth, true); + if (err) + return err; + + err = stmmac_dvr_probe(dev, plat_dat, &stmmac_res); + if (err) + renesas_gbeth_clks_config(gbeth, false); + + return err; +} + +static void renesas_gbeth_remove(struct platform_device *pdev) +{ + stmmac_dvr_remove(&pdev->dev); + + renesas_gbeth_clks_config(get_stmmac_bsp_priv(&pdev->dev), false); +} + +static const struct of_device_id renesas_gbeth_match[] = { + { .compatible = "renesas,rzv2h-gbeth", }, + { /* Sentinel */ } +}; +MODULE_DEVICE_TABLE(of, renesas_gbeth_match); + +static struct platform_driver renesas_gbeth_driver = { + .probe = renesas_gbeth_probe, + .remove = renesas_gbeth_remove, + .driver = { + .name = "renesas-gbeth", + .pm = &stmmac_pltfr_pm_ops, + .of_match_table = renesas_gbeth_match, + }, +}; +module_platform_driver(renesas_gbeth_driver); + +MODULE_AUTHOR("Lad Prabhakar "); +MODULE_DESCRIPTION("Renesas GBETH DWMAC Specific Glue layer"); +MODULE_LICENSE("GPL");