From patchwork Wed Mar 19 19:22:28 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Grant Erickson X-Patchwork-Id: 14023066 Received: from mail5.g24.pair.com (mail5.g24.pair.com [66.39.139.36]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6B6B820F070 for ; Wed, 19 Mar 2025 19:30:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=66.39.139.36 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1742412624; cv=none; b=VdzyydaiwwMq3KowQeGK4kn55/vSB5LC6xlaFyTTOB+3cW/9eRHfYkFFOhXBUNx8FgVkGoS+Z+VoJo6i8CX7bjYHcLAyQ6UtTMsGZN8u4Kvo03CoQL2296Fze8kje3XkbLg7EsNX4ljlLy+Q4WS7VoKI1ZCj5DAwVw6pdZ6QfWM= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1742412624; c=relaxed/simple; bh=Zv4RA/sY6txtwuaBhWqF/sIrPbIIQMK3UhHs9h1Vs0M=; h=From:To:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=HBpoRSJANvsTDHuFg6s/MXIcisJRJ7LENU46YcyjXVYBTxeUDqwkT++m5tRcxqebuEZrfguEgaoKokgRZimbZux0VPlOs6eWaGrCXznxWg1DaIfZ7X6sNEzjUVukCKhFqX5Q2m0qZ24V8qMCqNiLJ3UXSs/gIA2bziHj9/weW48= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=nuovations.com; spf=pass smtp.mailfrom=nuovations.com; dkim=pass (2048-bit key) header.d=nuovations.com header.i=@nuovations.com header.b=tLGerych; arc=none smtp.client-ip=66.39.139.36 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=nuovations.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=nuovations.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=nuovations.com header.i=@nuovations.com header.b="tLGerych" Received: from mail5.g24.pair.com (localhost [127.0.0.1]) by mail5.g24.pair.com (Postfix) with ESMTP id 59AA0164A99 for ; Wed, 19 Mar 2025 15:22:36 -0400 (EDT) Received: from localhost.localdomain (c-73-202-173-252.hsd1.ca.comcast.net [73.202.173.252]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mail5.g24.pair.com (Postfix) with ESMTPSA id 096151262B6 for ; Wed, 19 Mar 2025 15:22:35 -0400 (EDT) From: Grant Erickson To: ofono@lists.linux.dev Subject: [PATCH v6 1/7] qmi: Added enumeration for device quirk flags. Date: Wed, 19 Mar 2025 12:22:28 -0700 Message-ID: <75813bdb479c8abf6206be99b7c45a7cd73e73fd.1742411889.git.gerickson@nuovations.com> X-Mailer: git-send-email 2.45.0 In-Reply-To: References: Precedence: bulk X-Mailing-List: ofono@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nuovations.com; h=from:to:subject:date:message-id:in-reply-to:references:mime-version:content-transfer-encoding; s=pair-202401062137; bh=5RkJRnoVHnJwZCzxHGA2QOPk/DensYYgENGrNo82m/E=; b=tLGerychACP1K/I8342dy1uZF+a49g0pkk7Gf8D5+3nnHCGB2jQ0v4HPBFsKuxS2rj1b7+jOnbZ1Ozjpf3qocZDTfDkeYZ1rrbmhEJi8z2xC7mZc9ZsWlVvwmG4hbnEupr4jH7bgYl0/LUhkZrU5WYz1yICg55Two3xalzYiO9B2Dg/c9REA0ffKj8elx9zrDbCxrA/W6gQhMCF2T8Gpf4PMun3wlIU5wxBkjxtJPtrIqrM8z+Ars/CFgH/9MXvwWA16P0tndJ3/lJJwMgD3u1gi3lzpb8+2kSscNW3hEB48mnVQ7j0vGrjgPmcJKtxXkMx80A0e9XY+Z/iLwcR/lw== X-Scanned-By: mailmunge 3.10 on 66.39.139.36 Defines device-specific "quirks" that may alter the default behavior of the QMI driver for a specific, instantiated device. --- drivers/qmimodem/qmi.h | 18 ++++++++++++++++++ 1 file changed, 18 insertions(+) diff --git a/drivers/qmimodem/qmi.h b/drivers/qmimodem/qmi.h index 69698ee049c6..e74ff3feaeec 100644 --- a/drivers/qmimodem/qmi.h +++ b/drivers/qmimodem/qmi.h @@ -56,6 +56,24 @@ enum qmi_error { QMI_ERROR_INVALID_QMI_COMMAND = 71, }; +/** + * This defines device-specific "quirks" that may alter the default + * behavior of the QMI driver for a specific, instantiated device. + */ +enum qmi_qmux_device_quirk { + /** + * The device has no "quirks". + */ + QMI_QMUX_DEVICE_QUIRK_NONE = 0x00, + + /** + * The device has a "quirk" where it can lock up and hang (not + * responding to subsequent commands) due to high QMI service + * request arrival rates. + */ + QMI_QMUX_DEVICE_QUIRK_REQ_RATE_LIMIT = 0x01 +}; + typedef void (*qmi_destroy_func_t)(void *user_data); struct qmi_service; From patchwork Wed Mar 19 19:22:29 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Grant Erickson X-Patchwork-Id: 14023069 Received: from mail5.g24.pair.com (mail5.g24.pair.com [66.39.139.36]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6B66020E704 for ; Wed, 19 Mar 2025 19:30:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=66.39.139.36 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1742412625; cv=none; b=D1KotpzssWztthLlDjfYgpDiWLBkSuIWpEZTbFiJqVPALd2MJn4ch1yHsvJj/DH8q8YI6DVZ3gAbrKwa2u1shBeyNHdH2bZSTrs726dQxbOJhWB1IJHibYjPYhG3pn7MKhBAZMSOblL6u2CFUaUywLYM3UMS43C7tbhC3t9AhL8= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1742412625; c=relaxed/simple; bh=M5Yt+XgkEhwDsBif7PeTj7L8IDaWFyPdeokkm14HJmE=; h=From:To:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=XFHGEOZPWHv/PwlpGaa8+psi92VaxJulS8GMZXdVPIRI1CthYwa3hEgFYOERGZ/AA6lzVuFcen9+gYKpg2wD/lpT9NDTzaggTFEsb3Ufl70DSSBDndHnYvQ2q80GUPHNy37ITyqzlkhWErdC2klQgQ6P+GwHxCfLfwRhHTUkFbk= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=nuovations.com; spf=pass smtp.mailfrom=nuovations.com; dkim=pass (2048-bit key) header.d=nuovations.com header.i=@nuovations.com header.b=NxHe8Laz; arc=none smtp.client-ip=66.39.139.36 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=nuovations.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=nuovations.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=nuovations.com header.i=@nuovations.com header.b="NxHe8Laz" Received: from mail5.g24.pair.com (localhost [127.0.0.1]) by mail5.g24.pair.com (Postfix) with ESMTP id C4851164A9A for ; Wed, 19 Mar 2025 15:22:36 -0400 (EDT) Received: from localhost.localdomain (c-73-202-173-252.hsd1.ca.comcast.net [73.202.173.252]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mail5.g24.pair.com (Postfix) with ESMTPSA id 7C8AA1262BA for ; Wed, 19 Mar 2025 15:22:36 -0400 (EDT) From: Grant Erickson To: ofono@lists.linux.dev Subject: [PATCH v6 2/7] qmi: Added structure for device options. Date: Wed, 19 Mar 2025 12:22:29 -0700 Message-ID: X-Mailer: git-send-email 2.45.0 In-Reply-To: References: Precedence: bulk X-Mailing-List: ofono@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nuovations.com; h=from:to:subject:date:message-id:in-reply-to:references:mime-version:content-transfer-encoding; s=pair-202401062137; bh=fHma6eg08g0rSRzjb2Szp8dq8ebKa/ez0Aq5JPdNAGU=; b=NxHe8LazRyG8cdHDgHgN95FGUAo2ZeDTBSCIjLzv+kL/6dv1/vOGNfdNG+swExIx0D1ahX/qEme0rHIjrOSdaOqSAXPgpkguPho6jj+dIXajY4CBHgPlupqR5dthaiNuEotsAc7QuUVSnXxBnkXMNIaVgiVgH1DIAfOp+pdhXYvOJLhHlvljeXR/1vYzYJVF/zeboN1zH7ALabnMlugsSKd0oqBZOVhjz5m33ysEmayeEBCofLkR7R6jG5dmaOljBtbM+j1ql8THqHXE+2jIykHGs2WpLXmsDA7G2LJgPDBaTNpm4oTc5f8baOZGDi10xtlYcGz9r3KzISVXgIILrQ== X-Scanned-By: mailmunge 3.10 on 66.39.139.36 Defines options that may alter the default behavior of the QMI driver for a specific, instantiated device. --- drivers/qmimodem/qmi.h | 19 +++++++++++++++++++ 1 file changed, 19 insertions(+) diff --git a/drivers/qmimodem/qmi.h b/drivers/qmimodem/qmi.h index e74ff3feaeec..4ba27847176f 100644 --- a/drivers/qmimodem/qmi.h +++ b/drivers/qmimodem/qmi.h @@ -74,6 +74,25 @@ enum qmi_qmux_device_quirk { QMI_QMUX_DEVICE_QUIRK_REQ_RATE_LIMIT = 0x01 }; +/** + * Defines options that may alter the default behavior of the QMI + * driver for a specific, instantiated device. + */ +struct qmi_qmux_device_options { + /** + * Device-specific "quirk". + */ + enum qmi_qmux_device_quirk quirks; + + /** + * If quirks has #QMI_QMUX_DEVICE_QUIRK_REQ_RATE_LIMIT set, this + * is the minimum period, in microseconds, in which back-to-back + * QMI service requests may be sent to avoid triggering a + * firmware lock up and hang. + */ + unsigned int min_req_period_us; +}; + typedef void (*qmi_destroy_func_t)(void *user_data); struct qmi_service; From patchwork Wed Mar 19 19:22:30 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Grant Erickson X-Patchwork-Id: 14023065 Received: from mail5.g24.pair.com (mail5.g24.pair.com [66.39.139.36]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6B60320C49E for ; Wed, 19 Mar 2025 19:30:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=66.39.139.36 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1742412624; cv=none; b=rLWx6gu1v6SMTS77H4pE6UFDooKknQ+PGxuPWwcONSbbbHU2LnquaomXIgg1zPvqR6BrG4wVunlnMy5+y1kQEQJOBZWgYJO6zKrNzqn6ohnEtdi+adRiapIkO7ds3P2qIy3HsKyNVayZBbt2nPdZFiZFvPaFvFViA/56GNwHroc= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1742412624; c=relaxed/simple; bh=BOjh6BbY3gmEz2aVzixjVsKqCAX013D8zE0gTMLRqds=; h=From:To:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=pUNF0BZEyg79fUZToGwO9rw5tGrUhi3rX6A3x4I/TUrnRxLNzGhMuImzPDCWhwMtW5Vjn3S1KyoA0nWl7anZrMk5cuxE2pruRx49WV8aveJn0yCrtQnDZhqvJwq6uWUK94GINlk/X9FjcnXe6RjB2JeL3pIaPdYxNmVKVo45kX8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=nuovations.com; spf=pass smtp.mailfrom=nuovations.com; dkim=pass (2048-bit key) header.d=nuovations.com header.i=@nuovations.com header.b=GQHwGfBS; arc=none smtp.client-ip=66.39.139.36 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=nuovations.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=nuovations.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=nuovations.com header.i=@nuovations.com header.b="GQHwGfBS" Received: from mail5.g24.pair.com (localhost [127.0.0.1]) by mail5.g24.pair.com (Postfix) with ESMTP id 3FD0A164AA0 for ; Wed, 19 Mar 2025 15:22:37 -0400 (EDT) Received: from localhost.localdomain (c-73-202-173-252.hsd1.ca.comcast.net [73.202.173.252]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mail5.g24.pair.com (Postfix) with ESMTPSA id E776712635B for ; Wed, 19 Mar 2025 15:22:36 -0400 (EDT) From: Grant Erickson To: ofono@lists.linux.dev Subject: [PATCH v6 3/7] qmi: Added device options parameter to 'qmi_qmux_device_new'. Date: Wed, 19 Mar 2025 12:22:30 -0700 Message-ID: X-Mailer: git-send-email 2.45.0 In-Reply-To: References: Precedence: bulk X-Mailing-List: ofono@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nuovations.com; h=from:to:subject:date:message-id:in-reply-to:references:mime-version:content-transfer-encoding; s=pair-202401062137; bh=BzRC/MPEuWrn1WIK740cPG2Pr1K+5r5gWLIEtdkDGqY=; b=GQHwGfBS3RvCfrO46cFYJGeI8dkrKSIUt+k0eKM8iztSKIVsF9jHadwPPGCVU2z8wnp6jb70s8Znw03TxSq29acVpjdXoboKrDKtI1W7SziwNbU9e6+SWd7+meF+h0PS6ssvwDPTVrBm8GJJIdyuekknj4gxEwxj8lYMfbxStDl8WtDgeY6/AnfunwE4KMqZJQW3mS4FTWwCyW14FoMkJcgiLFc667SkEmEifG/Q30wVUHnW4FgvJU80v8Fb6TzqZmqwvB2VMQEI2uwOrsok/5TqBjN3glM+m2XhFBkFu+dlHZSr3FByU+5XtWfUhZUdTAEi2OQto23LTOUisUA0iA== X-Scanned-By: mailmunge 3.10 on 66.39.139.36 An optional pointer to immutable device options that may alter the default behavior of the QMI driver for the instantiated device. --- drivers/qmimodem/qmi.c | 3 ++- drivers/qmimodem/qmi.h | 3 ++- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/qmimodem/qmi.c b/drivers/qmimodem/qmi.c index 10dbdaac8bf6..bbe6440abe0f 100644 --- a/drivers/qmimodem/qmi.c +++ b/drivers/qmimodem/qmi.c @@ -1567,7 +1567,8 @@ static const struct qmi_transport_ops qmux_ops = { .write = qmi_qmux_device_write, }; -struct qmi_qmux_device *qmi_qmux_device_new(const char *device) +struct qmi_qmux_device *qmi_qmux_device_new(const char *device, + const struct qmi_qmux_device_options *options) { struct qmi_qmux_device *qmux; int fd; diff --git a/drivers/qmimodem/qmi.h b/drivers/qmimodem/qmi.h index 4ba27847176f..09b551d74823 100644 --- a/drivers/qmimodem/qmi.h +++ b/drivers/qmimodem/qmi.h @@ -107,7 +107,8 @@ typedef void (*qmi_qrtr_node_lookup_done_func_t)(void *); typedef void (*qmi_service_result_func_t)(struct qmi_result *, void *); -struct qmi_qmux_device *qmi_qmux_device_new(const char *device); +struct qmi_qmux_device *qmi_qmux_device_new(const char *device, + const struct qmi_qmux_device_options *options); void qmi_qmux_device_free(struct qmi_qmux_device *qmux); void qmi_qmux_device_set_debug(struct qmi_qmux_device *qmux, qmi_debug_func_t func, void *user_data); From patchwork Wed Mar 19 19:22:31 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Grant Erickson X-Patchwork-Id: 14023067 Received: from mail5.g24.pair.com (mail5.g24.pair.com [66.39.139.36]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6B71B211707 for ; Wed, 19 Mar 2025 19:30:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=66.39.139.36 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1742412624; cv=none; b=dcGLf18bkH0KEIOCx+dMHlRfm60GV0METFjSVylz0mXQ1LRgl36kwzSb5SCR1IXDQlBMdZL2TUlZeLDYBndNmvGnR9hW7JySi8LRgrg6y8xo/FB7IKboqzVuVgCPo8bSnf+tHAdxzBOTS2tz7UyXSbWpxTk6SCfxqJz6/lScbrQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1742412624; c=relaxed/simple; bh=MSorLqobb9OQwVoC74blqqM3HX30zMCYyhfYvQK+C2s=; h=From:To:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=P9PoS9+KnI1dXtXp0FDuWA6wUEuQog5JPp7cE7zS17QXmDswx5/IM8eMhLXpj/JTpY5stGhhCsqhdWnkDeXHhjFCNUen1CrCT7pdzk+O04w62rjCfK3ScNlVZNSN8Ghlq8FzgzlTySzxnlqnAqQS/2jN32wVy9nMB/asXzkwI7c= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=nuovations.com; spf=pass smtp.mailfrom=nuovations.com; dkim=pass (2048-bit key) header.d=nuovations.com header.i=@nuovations.com header.b=qinEzhD3; arc=none smtp.client-ip=66.39.139.36 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=nuovations.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=nuovations.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=nuovations.com header.i=@nuovations.com header.b="qinEzhD3" Received: from mail5.g24.pair.com (localhost [127.0.0.1]) by mail5.g24.pair.com (Postfix) with ESMTP id B0B3A164AA2 for ; Wed, 19 Mar 2025 15:22:37 -0400 (EDT) Received: from localhost.localdomain (c-73-202-173-252.hsd1.ca.comcast.net [73.202.173.252]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mail5.g24.pair.com (Postfix) with ESMTPSA id 62372126374 for ; Wed, 19 Mar 2025 15:22:37 -0400 (EDT) From: Grant Erickson To: ofono@lists.linux.dev Subject: [PATCH v6 4/7] qmi: Implement QMI service request rate limiting in 'can_write_data'. Date: Wed, 19 Mar 2025 12:22:31 -0700 Message-ID: X-Mailer: git-send-email 2.45.0 In-Reply-To: References: Precedence: bulk X-Mailing-List: ofono@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nuovations.com; h=from:to:subject:date:message-id:in-reply-to:references:mime-version:content-transfer-encoding; s=pair-202401062137; bh=gTner/89Vv1FmtWUBekDe8cuJ1Y7ghgt7kQLUgESQjw=; b=qinEzhD3mLciAKN00LSlF/Efccv4NwbQv7hZLStl0/iGwwmJi5RDLwRodYym8Clr+3vm7Xzux1Ts7IVTnzwx9q03ZwEbGe3mhK7VPHMYw2uTCSBeKApbm3PiUAiwSdhafADzNCPOF0dISgudTv11TaJu+10jb8MLCrZBJLHImpBFZC07e1NXR2HfJTIpOkM6WML4VvOXeLsAxP/nJpm0zDoqqAHyp9JBpcJT4AzuG0kkeBlgbjyOYr/QW/8eyyhOv9K5E9HKABWetK2kRDWHIpL4hTTTRuez6NZ0cllPU0rD/nlbI4G6AK97kGq580hwj/B+pviNOwwTcjWItYKg0w== X-Scanned-By: mailmunge 3.10 on 66.39.139.36 Determine if we need to rate-limit QMI services requests to a transport-specific minimum request period. If so, return true so that the queue can be retried again later. Adds the following data members to 'qmi_transport': * Minimum request period - The minimum period, in microseconds, for back-to-back QMI service requests. * Last request time - Time, in microseconds, when the last QMI service request was sent. to support the implementation. --- drivers/qmimodem/qmi.c | 38 ++++++++++++++++++++++++++++++++++++++ 1 file changed, 38 insertions(+) diff --git a/drivers/qmimodem/qmi.c b/drivers/qmimodem/qmi.c index bbe6440abe0f..33063483692e 100644 --- a/drivers/qmimodem/qmi.c +++ b/drivers/qmimodem/qmi.c @@ -92,6 +92,18 @@ struct qmi_transport { const struct qmi_transport_ops *ops; struct debug_data debug; bool writer_active : 1; + + /** + * If specified via qmi_qmux_device_options, the minimum period + * for back-to-back QMI service requests. + */ + unsigned int min_req_period_us; + + /** + * The time, in microseconds, when the last QMI service request + * was sent. + */ + uint64_t last_req_sent_time_us; }; struct qmi_qmux_device { @@ -653,8 +665,28 @@ static bool can_write_data(struct l_io *io, void *user_data) { struct qmi_transport *transport = user_data; struct qmi_request *req; + const bool throttle_enabled = transport->min_req_period_us > 0; + uint64_t now; int r; + /* + * Determine if we need to rate-limit commands to a + * transport-specific minimum request period. If so, + * return true so that the queue can be retried again + * later. + */ + if (throttle_enabled) { + now = l_time_now(); + + if (transport->last_req_sent_time_us != 0) { + const uint64_t delta = l_time_diff(now, + transport->last_req_sent_time_us); + + if (delta < transport->min_req_period_us) + return true; + } + } + req = l_queue_pop_head(transport->req_queue); if (!req) return false; @@ -665,6 +697,12 @@ static bool can_write_data(struct l_io *io, void *user_data) return false; } +_Pragma("GCC diagnostic push") +_Pragma("GCC diagnostic ignored \"-Wmaybe-uninitialized\"") + if (throttle_enabled) + transport->last_req_sent_time_us = now; +_Pragma("GCC diagnostic pop") + if (l_queue_length(transport->req_queue) > 0) return true; From patchwork Wed Mar 19 19:22:32 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Grant Erickson X-Patchwork-Id: 14023044 Received: from mail5.g24.pair.com (mail5.g24.pair.com [66.39.139.36]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 78C56211704 for ; Wed, 19 Mar 2025 19:22:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=66.39.139.36 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1742412165; cv=none; b=aeLwceQoZSojsj4+j5HfbcPV4YKfEjMo5URpJ7Srw2LeBKt54iFfigy45cIcsI66vYZxMOqYMK/TS7NEMlIqLDbuLQHq1W4n+V8Mj0+E6M8FNtZ5PF8SphQBSE/o667V6gSKPbmUgXK9nqRcjHwuctVF5jaABm/5X1LLYvVIGWk= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1742412165; c=relaxed/simple; bh=Gla3QDfQpwYfBE0H1upc/z8z+HBxqpDE+5Uis8dotlA=; h=From:To:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=Agq7QFyvKvqIINqTRbZP50SddEAy2V9QsP/ZUBmjsw0QDkMHaSZpfXQkpTBYk3KyQ0fPe9nM6wm+98rn6vklXjBTvnk6t78EV7XZqyL85dDet8+RyK/HcF3Vnb9IoOYVRWvdn3SkYLxTv61w+Kq3zIpTdsewPEiLXpew4XNTG/8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=nuovations.com; spf=pass smtp.mailfrom=nuovations.com; dkim=pass (2048-bit key) header.d=nuovations.com header.i=@nuovations.com header.b=QlSB62A5; arc=none smtp.client-ip=66.39.139.36 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=nuovations.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=nuovations.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=nuovations.com header.i=@nuovations.com header.b="QlSB62A5" Received: from mail5.g24.pair.com (localhost [127.0.0.1]) by mail5.g24.pair.com (Postfix) with ESMTP id 28FE5164AA4 for ; Wed, 19 Mar 2025 15:22:38 -0400 (EDT) Received: from localhost.localdomain (c-73-202-173-252.hsd1.ca.comcast.net [73.202.173.252]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mail5.g24.pair.com (Postfix) with ESMTPSA id D35BF126374 for ; Wed, 19 Mar 2025 15:22:37 -0400 (EDT) From: Grant Erickson To: ofono@lists.linux.dev Subject: [PATCH v6 5/7] qmi: Handle request rate limit option in 'qmi_qmux_device_new'. Date: Wed, 19 Mar 2025 12:22:32 -0700 Message-ID: <71d090b67ed601fafd157064f9350b6786491fe1.1742411889.git.gerickson@nuovations.com> X-Mailer: git-send-email 2.45.0 In-Reply-To: References: Precedence: bulk X-Mailing-List: ofono@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nuovations.com; h=from:to:subject:date:message-id:in-reply-to:references:mime-version:content-transfer-encoding; s=pair-202401062137; bh=Ehm/m6dCTq2BpLAzOl6CoCiPO5KjzL0sCZtU08LEFC0=; b=QlSB62A5lW6r52Ulk8m7j9M1wYKkex0hj4cUGGSbS0HmmetP8pdDdDbxlmoDRJ3Mrd9jcl2e21l7nw782ISfrdaMIWQ/yThLuEomrX5QBlrss5FBT5gkbaX62w51BqLbLOzjsC2y95xQW5gMneY1TQ/XqYPo+8tpExsvTaWCD0WkyrTKFTW7hnrTxzWjufuYgwUbZvd5m5OhqZW1mk493laMNujclRX8kv6CEmHccs6ULjHTlK+VOoRoYy8QochQa5ycrvlq3vc79aGCbSclaTz73awHMKA6NgC26JW5EmNBtY/A8V8Om8vEOaIT9E8ThkptTPG4t8JCh+RzAcX8ew== X-Scanned-By: mailmunge 3.10 on 66.39.139.36 If options are specified and QMI_QMUX_DEVICE_QUIRK_REQ_RATE_LIMIT is asserted, set the qmux transport minimum service request period from the specified options. --- drivers/qmimodem/qmi.c | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/drivers/qmimodem/qmi.c b/drivers/qmimodem/qmi.c index 33063483692e..9f3db6bd4d84 100644 --- a/drivers/qmimodem/qmi.c +++ b/drivers/qmimodem/qmi.c @@ -1617,6 +1617,16 @@ struct qmi_qmux_device *qmi_qmux_device_new(const char *device, qmux = l_new(struct qmi_qmux_device, 1); + if (options != NULL) { + if ((options->quirks & QMI_QMUX_DEVICE_QUIRK_REQ_RATE_LIMIT) + == QMI_QMUX_DEVICE_QUIRK_REQ_RATE_LIMIT) { + qmux->transport.min_req_period_us = options->min_req_period_us; + + ofono_info("QMI minimum service request period %u us", + qmux->transport.min_req_period_us); + } + } + if (qmi_transport_open(&qmux->transport, fd, &qmux_ops) < 0) { close(fd); l_free(qmux); From patchwork Wed Mar 19 19:22:33 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Grant Erickson X-Patchwork-Id: 14023045 Received: from mail5.g24.pair.com (mail5.g24.pair.com [66.39.139.36]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 78BFA20C49E for ; Wed, 19 Mar 2025 19:22:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=66.39.139.36 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1742412166; cv=none; b=pPyjb8aPSZYo4JMu/kkGcebk0Ul07ELF8U4VeJM/K9Nt9yBGP7UKJEx9isMY+6EfF8Ib+bHvjvF29ulgtICt3vkewOy45pN4+93BIcSuMkvLiyPfu51biJUauf4+WqY3s987OyZ99X8oKG7lAbpwK0TP4uqa6UVhKjL8Zwasv+k= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1742412166; c=relaxed/simple; bh=4r8w3BB1akA9ViycLhH6r9nNTeF+K4NnxLI7QZhqfeU=; h=From:To:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=ptU73rQ2wbqjyeXHwXUlVfGHH/weaVZiUg9jQWJrJ4siT/dT2K8nyowZ+a7vRx3KO3OwP7BU5Jxttu99UsaAcuYMAm52h8HxiffTtsY7otr8QKbjYr7Spjw0lFfYger02VhExRkqUIZVVbrgVIhv7v+C3SyeGz4hWCrBSUu3jyI= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=nuovations.com; spf=pass smtp.mailfrom=nuovations.com; dkim=pass (2048-bit key) header.d=nuovations.com header.i=@nuovations.com header.b=kYi9/T6O; arc=none smtp.client-ip=66.39.139.36 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=nuovations.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=nuovations.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=nuovations.com header.i=@nuovations.com header.b="kYi9/T6O" Received: from mail5.g24.pair.com (localhost [127.0.0.1]) by mail5.g24.pair.com (Postfix) with ESMTP id 971D3164AA7 for ; Wed, 19 Mar 2025 15:22:38 -0400 (EDT) Received: from localhost.localdomain (c-73-202-173-252.hsd1.ca.comcast.net [73.202.173.252]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mail5.g24.pair.com (Postfix) with ESMTPSA id 4BB20124FD0 for ; Wed, 19 Mar 2025 15:22:38 -0400 (EDT) From: Grant Erickson To: ofono@lists.linux.dev Subject: [PATCH v6 6/7] udevng: Set the QMI minimum service request period for Quectel BG96 modems. Date: Wed, 19 Mar 2025 12:22:33 -0700 Message-ID: <0845d591dde762644f32e36ecdd6c6e98d3e336a.1742411889.git.gerickson@nuovations.com> X-Mailer: git-send-email 2.45.0 In-Reply-To: References: Precedence: bulk X-Mailing-List: ofono@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nuovations.com; h=from:to:subject:date:message-id:in-reply-to:references:mime-version:content-transfer-encoding; s=pair-202401062137; bh=HY5EY2ISZixz3Mr7Wq0vZ6BjK6Xua0OSEwuqX7gyeJ8=; b=kYi9/T6OXRCcsaUY32n56k3O4SfQEp4w4spDqaTbJAOgd+wljgASeIMfrGVCOmByaTR9gRMWCQ/ygY1oejpttFWMiR+RbbnIqMxKA6uE1bg9aCQ4eQhYiwjXI2wVbZRyE+gVsWewQ66nXsFrbs3sr7HmR9QrniSOKvw7tb9ShjO0l5FPvpwsF+Zs9WPAbnmECBhey+ARCabGjG/Vt9KUoR0np0MydLy9w0rW1MG9LYB8QfPOlXejpMpaG1dS150hqYA7XI7eVf+0cEYdGFEXVntSak19PNr+drYl3RFyPS+Bh2IPMHMOMH3AKp16BbzY3ltgib0xiue6+YONXm4WMQ== X-Scanned-By: mailmunge 3.10 on 66.39.139.36 The Quectel Wireless Solutions Co., Ltd. (2c7c) BG96 CAT-M1/NB-IoT modem (0296) has a firmware issue where it can lock up and hang (not responding to subsequent commands) due to high QMI service request arrival rates. If the vendor and model match those, then rate limit QMI service requests to no more than one every 2,000 us. --- plugins/udevng.c | 14 ++++++++++++++ 1 file changed, 14 insertions(+) diff --git a/plugins/udevng.c b/plugins/udevng.c index 64875a47752b..b8df66de5c71 100644 --- a/plugins/udevng.c +++ b/plugins/udevng.c @@ -1118,6 +1118,20 @@ static gboolean setup_quectelqmi(struct modem_info *modem) DBG("%s", modem->syspath); + /* + * The Quectel Wireless Solutions Co., Ltd. (2c7c) BG96 + * CAT-M1/NB-IoT modem (0296) has a firmware issue where it can + * lock up and hang (not responding to subsequent commands) due to + * high QMI service request arrival rates. If the vendor and model + * match those, then rate limit QMI service requests to no more + * than one every 2,000 us. + */ + if (l_streq0(modem->vendor, "2c7c")) { + if (l_streq0(modem->model, "0296")) + ofono_modem_set_integer(modem->modem, + "RequestThrottleTimeUs", 2000); + } + for (list = modem->devices; list; list = g_slist_next(list)) { const struct device_info *info = list->data; const char *subsystem = From patchwork Wed Mar 19 19:22:34 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Grant Erickson X-Patchwork-Id: 14023046 Received: from mail5.g24.pair.com (mail5.g24.pair.com [66.39.139.36]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 78B821DF258 for ; Wed, 19 Mar 2025 19:22:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=66.39.139.36 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1742412167; cv=none; b=nK/bCZbOThSQZSyYoMOMJybYqUR2THj9NsLNf3Mo7iUTopKFpYHqAFOWKBQDUyPlHJvaHKX8SyT8K/ilWMCHAgszz070CPj0DxnlRQdhRwYbcWJ52C6NLlO67YV4dg265s+63j4bSSIst4U0bjzKGngD2PBPL+yn6gasDbifIxI= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1742412167; c=relaxed/simple; bh=/zRBuxHb1YZadUGBY2Vcl0+bBcgHqG51e5rh5Q3mXrI=; h=From:To:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=sPZSbfs5CfR3mGFZn6iKSe5Y7OfK3kzmd8MhDLY8mounhKBfG6RJtHJX+T1mdEo3AbMT52OuCBov+ox3LGQON6TpKcyh9k9irgREvDPyy4J0F62rJoeNzBKOGouF6v07F0wtm8sk4PPDC2kiTrkoIWFyrpg/yQJqDVc8hcp9c4U= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=nuovations.com; spf=pass smtp.mailfrom=nuovations.com; dkim=pass (2048-bit key) header.d=nuovations.com header.i=@nuovations.com header.b=pHXnc6vo; arc=none smtp.client-ip=66.39.139.36 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=nuovations.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=nuovations.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=nuovations.com header.i=@nuovations.com header.b="pHXnc6vo" Received: from mail5.g24.pair.com (localhost [127.0.0.1]) by mail5.g24.pair.com (Postfix) with ESMTP id 103CC164AA9 for ; Wed, 19 Mar 2025 15:22:39 -0400 (EDT) Received: from localhost.localdomain (c-73-202-173-252.hsd1.ca.comcast.net [73.202.173.252]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mail5.g24.pair.com (Postfix) with ESMTPSA id B9F0F124C24 for ; Wed, 19 Mar 2025 15:22:38 -0400 (EDT) From: Grant Erickson To: ofono@lists.linux.dev Subject: [PATCH v6 7/7] gobi: Pass QMI qmux device options to 'qmi_qmux_device_new'. Date: Wed, 19 Mar 2025 12:22:34 -0700 Message-ID: X-Mailer: git-send-email 2.45.0 In-Reply-To: References: Precedence: bulk X-Mailing-List: ofono@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nuovations.com; h=from:to:subject:date:message-id:in-reply-to:references:mime-version:content-transfer-encoding; s=pair-202401062137; bh=Vxp+G+wWuhPQL8Dt96ps2vexl5kKWAzJ+wzPwtwjdmc=; b=pHXnc6voaqbd34UjKR887xHbWo8kawn5F7Uy1kXyjL1S9yGVxAa8v9pSpkragZ5LgCNpbh9+qrG2bNurQD9BpnWYbdPZo7Ipz+gS2aXffXBcPJOKPfYBXQ//4okNl3Rj2tQ+D9UsF+5/TC6PkRHRKC+/zB9dV32pG8AvXdEA5KlfY1AyhjN3vYF4MQ6HKC78bnAEgbEpLdynwERw/ZRs9JCQYKa07mDTHYAucpqtyWEd7YTIhx3xQmzS28WLi8y3UX7BlTO72UsCi/HgrTjUXwUmM1V19hu02cAVEMHLzIUjoabIBPGzWKDYLfpxzjXye4KW07sb4VJjDkMYAU+X1g== X-Scanned-By: mailmunge 3.10 on 66.39.139.36 If the QMI minimum service request period property is set on the modem object, then set the appropriate QMI QMUX device option quirk and value. --- plugins/gobi.c | 22 +++++++++++++++++++++- 1 file changed, 21 insertions(+), 1 deletion(-) diff --git a/plugins/gobi.c b/plugins/gobi.c index 027aa91d6ade..dfc7402e36aa 100644 --- a/plugins/gobi.c +++ b/plugins/gobi.c @@ -842,9 +842,19 @@ error: __shutdown_device(modem); } +/* + * Enable the modem. The following modem properties are optionally set: + * + * RequestThrottleTimeUs + * The minimum period, in microseconds, in which back-to-back * + * modem service requests may be sent. + * + */ static int gobi_enable(struct ofono_modem *modem) { struct gobi_data *data = ofono_modem_get_data(modem); + struct qmi_qmux_device_options options = { QMI_QMUX_DEVICE_QUIRK_NONE, 0 }; + int min_req_period_us; const char *device; DBG("%p", modem); @@ -853,7 +863,17 @@ static int gobi_enable(struct ofono_modem *modem) if (!device) return -EINVAL; - data->device = qmi_qmux_device_new(device); + /* + * If the QMI minimum service request period property is set, then + * set the appropriate QMI QMUX device quirk and value. + */ + min_req_period_us = ofono_modem_get_integer(modem, "RequestThrottleTimeUs"); + if (min_req_period_us > 0) { + options.quirks |= QMI_QMUX_DEVICE_QUIRK_REQ_RATE_LIMIT; + options.min_req_period_us = min_req_period_us; + } + + data->device = qmi_qmux_device_new(device, &options); if (!data->device) return -EIO;