From patchwork Wed Mar 19 20:59:40 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: David Heidelberg X-Patchwork-Id: 14023107 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9788D2135DE; Wed, 19 Mar 2025 20:59:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1742417985; cv=none; b=gId5BCO7iC6FurmN3SB4g7byehIZpyNV330ffB9du6yu3fru4sxZDLYkHD2lorMVnp1M9snzzH2alBDUONd+cCQ6u32zlTqtWZkXs2M0zglbyD7qkXwpEigvUa0fIsbund3iX3kf3KXXCCoTat269kuoPMCIMI3qeYQdesezqdE= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1742417985; c=relaxed/simple; bh=euz6il6nXV6p1paK6FZ1GDbp+BIc+6JBLiJ8M+pD1yQ=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=kE3rwT6t2CAHZVsEYnfAkCsGztdBYO/ZXx4sjN3rd0DPd0WyPYsUahJh3oPlxmtQKWDaHusqMXlnkZcoEh5xh20sy9gk7cM0VGhBU5GLNLynA259p4b11i2cD99opIKvHhD/5j3ObElBkiVKB+abwdm/y+rmfSyGsNZ4b4rkTsc= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=Hqh2XRon; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="Hqh2XRon" Received: by smtp.kernel.org (Postfix) with ESMTPS id 1A186C4CEEA; Wed, 19 Mar 2025 20:59:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1742417985; bh=euz6il6nXV6p1paK6FZ1GDbp+BIc+6JBLiJ8M+pD1yQ=; h=From:Date:Subject:References:In-Reply-To:To:Cc:Reply-To:From; b=Hqh2XRon0kWo1EEfuMoIEwOAYWGC3e9QqRnAv+RrWwpYY88Gw+eCuqeQk7EH2TU4g V98n8D8IF1ByZp8iBN9YT7zRco9RViRRb/2VXgi7AG95TojSrDR9Gypd8R+cB8dYKY 54vVaP6/CSxtS7Jgw+ALZrt8nYY+/SD8WdMzDN3BA+x0C4R4tMaWSB4ePJycNozZeV fZjFn4i70eOLsEWihoX4oTMlJgIlIrukke3RdmGtCoe2jOYgLNLesat9x/hCOl7WPR b6RYI4IVqwSXaRcw9YeAI5p4l8EgzkE2Y1yROgdhGWmNDJG/ugAFQVeZNQSDN23712 5hhnIzU/HrxKQ== Received: from aws-us-west-2-korg-lkml-1.web.codeaurora.org (localhost.localdomain [127.0.0.1]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0B6A6C36000; Wed, 19 Mar 2025 20:59:45 +0000 (UTC) Date: Wed, 19 Mar 2025 21:59:40 +0100 Subject: [PATCH v2 01/13] iio: light: al3010: Use unsigned int for the indexing Precedence: bulk X-Mailing-List: linux-iio@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-Id: <20250319-al3010-iio-regmap-v2-1-1310729d0543@ixit.cz> References: <20250319-al3010-iio-regmap-v2-0-1310729d0543@ixit.cz> In-Reply-To: <20250319-al3010-iio-regmap-v2-0-1310729d0543@ixit.cz> To: Jonathan Cameron , Lars-Peter Clausen Cc: Svyatoslav Ryhel , Robert Eckelmann , linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, David Heidelberg X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=695; i=david@ixit.cz; h=from:subject:message-id; bh=10RW+w/I6ilKLev9SA61EnDHTOc4Fb07ecKF8eR6P2k=; b=owEBbQKS/ZANAwAIAWACP8TTSSByAcsmYgBn2zA9nvfVsg54dt4iRBKJw7MJR9M/9KEpGtost aKxsPesBrKJAjMEAAEIAB0WIQTXegnP7twrvVOnBHRgAj/E00kgcgUCZ9swPQAKCRBgAj/E00kg cjiVD/9/dzEsrY+MLXY7m/lJf+McDISs1NNYlOQTF0sQLMx+jQueAxoG6UVqyrPN2O6w5zhISxt Zq92t+hu3JqLGS9sAMx974Kpeix1Ja4MFblYtXygFd4XEYEWI+gcZYzHZl2KbE8xKBlyc/mEN2+ oD67aKLjyJg6/G6v5IfbPc3B7vJzBf2/lMNUO4B00wuwUWfeaCyFhCurPTHMvdaT61IBo/6m12n IY2FLCU1yokyDskmoOEDUDGd3Q30mp+sSGlZ4fsuy34fvYMksEkFmL1EsyhgYLeVNcN5DM1C4jO n2dVJf1HDHpgQSYrvOVx/PxXpvmqglUuQCe6fedNzqSCqD6bSHxWYbQPzEVg7CTb5bnHYOu4H9S Lb3W+oOf4hpcIfoNDlt4O3oCPdr24whirSwtFnrEYmy3kerS5N3FnapngONcJGiWbASdRNfsNhu 6H8MqY7WF3jnKSSbhQYPIaLasr6T5NJ+3OXwXV/udEqlNDB1HEHshI9q80Nyt7n8K90jR/qwQYT JeZfwk6YypAwGqM8zeuPVO5Kn3RhSAnPL1Nj9IyBZ6RZCViLaohKrCaWcAC1suExEy1mPyvsei3 rJ4k2tO2MTi5sJ8OooIb9z5SDwacIJZW1B2CX8Lvs6juNa8+yYzncc+LTI057Qz59ZF5KU6bn77 rew6XGe6F7cTOHw== X-Developer-Key: i=david@ixit.cz; a=openpgp; fpr=D77A09CFEEDC2BBD53A7047460023FC4D3492072 X-Endpoint-Received: by B4 Relay for david@ixit.cz/default with auth_id=355 X-Original-From: David Heidelberg Reply-To: david@ixit.cz From: David Heidelberg From: David Heidelberg The integer is used as array index which cannot be negative. Signed-off-by: David Heidelberg --- drivers/iio/light/al3010.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/iio/light/al3010.c b/drivers/iio/light/al3010.c index 7cbb8b203300907a88f4a0ab87da89cabdd087f3..4c2fd88ab32cd73f4735b0fa3014af084037c94d 100644 --- a/drivers/iio/light/al3010.c +++ b/drivers/iio/light/al3010.c @@ -145,7 +145,7 @@ static int al3010_write_raw(struct iio_dev *indio_dev, int val2, long mask) { struct al3010_data *data = iio_priv(indio_dev); - int i; + unsigned int i; switch (mask) { case IIO_CHAN_INFO_SCALE: From patchwork Wed Mar 19 20:59:41 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: David Heidelberg X-Patchwork-Id: 14023103 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 975E620C003; Wed, 19 Mar 2025 20:59:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1742417985; cv=none; b=eDgqyeVstr5JE0Soe5E59G9F5AAiHo5FE6yxMHYQpC5TbTVBYRXC/tKNLyLNrYVNAquFLlrtOa3h+64XtbA7hLOfGbD2Y7X5m7oCoPDsubzaW1cHgRgaw1br6Z5vsvuVAL3pf+Z29++k7vMbhlfKBEjTCIIKns9zIRDTVNQq8yI= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1742417985; c=relaxed/simple; bh=CT7ZJ/uDIYrIVA8eQYfKWvBAY6EzcaAv4fqcrOVsHQw=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=uob9lL1QNS6gpko+WclydouZKH3zYpewqTik9LYTFsgaWvvn+f/GMIVavsKQ5dM/O62xiyl6aVAW53kTL0zKlMErmXUXE8t5oo0+iP/y7cx7dpu/L0KuKWk/l62pudq8nB63i7UxwxG8Hvbfmohd9NKbFeqgznN8CDcI6JJs+gU= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=eNLXQdTu; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="eNLXQdTu" Received: by smtp.kernel.org (Postfix) with ESMTPS id 2BB33C4CEE7; Wed, 19 Mar 2025 20:59:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1742417985; bh=CT7ZJ/uDIYrIVA8eQYfKWvBAY6EzcaAv4fqcrOVsHQw=; h=From:Date:Subject:References:In-Reply-To:To:Cc:Reply-To:From; b=eNLXQdTuT3CO1oGsuYUNUnN3MpW4+lRMQDGQDeiOh9hV9EA8IGHeqV64aOngfnLfs rpa2dejB//oDQu/yPP/4F0pOnP0uTPHJ4+3gd+SrWIFk2shyZsbf9N8e4tw0oNTvHP QMbYhR8z8Ha9oIb7t34aghxXwO9bDuJQt43HGkhcxVlbPUHzGXMbZmZGL06w56IqFK iQmxik9Sgs+uHN4BrZAc/9nxkv0KV7CYlZxtuFoQg/9nrjYqbAtM4Rp5AJq/bX569R At1VBhKFu4cxvNB+mS3dQHz0DZ5ZFFpFQeB4OVRc2vLqvHeQQ7iveS0cC8hUmBnGkr 0+W6zotV6EQMg== Received: from aws-us-west-2-korg-lkml-1.web.codeaurora.org (localhost.localdomain [127.0.0.1]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1A15DC36001; Wed, 19 Mar 2025 20:59:45 +0000 (UTC) Date: Wed, 19 Mar 2025 21:59:41 +0100 Subject: [PATCH v2 02/13] iio: light: al3320a: Use unsigned int for the indexing Precedence: bulk X-Mailing-List: linux-iio@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-Id: <20250319-al3010-iio-regmap-v2-2-1310729d0543@ixit.cz> References: <20250319-al3010-iio-regmap-v2-0-1310729d0543@ixit.cz> In-Reply-To: <20250319-al3010-iio-regmap-v2-0-1310729d0543@ixit.cz> To: Jonathan Cameron , Lars-Peter Clausen Cc: Svyatoslav Ryhel , Robert Eckelmann , linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, David Heidelberg X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=703; i=david@ixit.cz; h=from:subject:message-id; bh=ynRSZu6nJx2UyMC/JZCn2Zq/vADVq3GqxbyApWvpw90=; b=owEBbQKS/ZANAwAIAWACP8TTSSByAcsmYgBn2zA9h4KIyY+7mFaql0PaaN5PNdcRvG54s2agu Skraz0efHKJAjMEAAEIAB0WIQTXegnP7twrvVOnBHRgAj/E00kgcgUCZ9swPQAKCRBgAj/E00kg cgB0EAC99yluiJrwzBdA3295VR1ghmmPqKqo3Kl7bxmKVdCv58MD418/Olkv3lQsF+Q5vbaktUw d5E6TaZG3blEcVIVU3XVzDHzE2Dss3vsVlngwO8m71fNCvPr2q4b5xo95SvHDL2i/8ihveYdgbd avPvXf8PlcAS2uxpsGAhPUkY9D/3qOjkyI9xZF7t9WMqgyMvAUsCZK5TIijGMGTA82Li5G3qYER IPTrkKnthER17g5HNdNXvYm94RWaMZ9q4xzP0zhOiTi7CfZr14s4vwoJes0k32IWfqsmvq3yxSt S4HaBucpBGazvYHriPStmCbKMqz+9Ey0Apq+vcNhYmAqMTNY+zgJduWt0LllHg7EQwkMdG8I9WA ZfxsQaQYx721hQygeRkrWSNTfVVUQXSCBlSqEoDfsYojOJMjuhE4K+oG34cpq5veQmSo9s/NlvH afBMNExYEqLUWWLcOh56qms9IFASDKmR/GuVooFQButX8KIcZm3DaAHBN591+3WhU5JWKpAX6gd bSkY+/h02Yuv7c36of7FsHw0EzZpBpedWhR4Yydn5xkdGTVHoFpP89aR+DwBhAtyzl8rNu0Zf2q G+d5+nJY1kPvgNQ3bC2CYkePeZ3BDhiZ/gWdps8uxwhoN8L+7ygbd6E1NqrlGZ8gM2MvfxoIO+w EfKmAaDyuAFsxVQ== X-Developer-Key: i=david@ixit.cz; a=openpgp; fpr=D77A09CFEEDC2BBD53A7047460023FC4D3492072 X-Endpoint-Received: by B4 Relay for david@ixit.cz/default with auth_id=355 X-Original-From: David Heidelberg Reply-To: david@ixit.cz From: David Heidelberg From: David Heidelberg The integer is used as array index which cannot be negative. Signed-off-by: David Heidelberg --- drivers/iio/light/al3320a.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/iio/light/al3320a.c b/drivers/iio/light/al3320a.c index 497ea3fe337775b07efdfc56c80beb1aa55e394c..bceda71517c8180dff76db311aa3591ab9846156 100644 --- a/drivers/iio/light/al3320a.c +++ b/drivers/iio/light/al3320a.c @@ -163,7 +163,7 @@ static int al3320a_write_raw(struct iio_dev *indio_dev, int val2, long mask) { struct al3320a_data *data = iio_priv(indio_dev); - int i; + unsigned int i; switch (mask) { case IIO_CHAN_INFO_SCALE: From patchwork Wed Mar 19 20:59:42 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: David Heidelberg X-Patchwork-Id: 14023106 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 97832212FA0; Wed, 19 Mar 2025 20:59:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1742417985; cv=none; b=JODHDH9uDMCDhun999pOVt36HODUbO2NIXHWBZFCoz2mZKf5GwtEkSpikjlcn0Sb6SLsN7WirWSRPQFpiFKuhavtHWLhT4cv0WXxky7NXMKZZuuUZtzF/hXlwAanuqaUFtEWgRrcmVrOQbfR0IIFS620ekRapzip/gyQ2OZ33rk= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1742417985; c=relaxed/simple; bh=74QYptDcZNP8BaAZ/7MDrHdtgAQUOZcKjmL3HZn5Uk0=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=n9p4RahNgrCoIHVR4OG462iHaf5OHq2fupj7GwJ8bZVCJs7y4A5LJObiPeb+jSQzicI7UDTMnAFCnO13kQAAWHC0uTDn6VIx3InYNU4Ams9JZ6KDHT/zX/K4fnPVkwN9UpZTdBSabMMck1tg3pa9ZhhD5qHwym386Ysl7mWvoRg= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=iyUnKf16; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="iyUnKf16" Received: by smtp.kernel.org (Postfix) with ESMTPS id 309F3C4AF09; Wed, 19 Mar 2025 20:59:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1742417985; bh=74QYptDcZNP8BaAZ/7MDrHdtgAQUOZcKjmL3HZn5Uk0=; h=From:Date:Subject:References:In-Reply-To:To:Cc:Reply-To:From; b=iyUnKf167lC/tdyndLz8CKiRo96Tj22uXH3pB6B21RtlYbLoqwW+mQPcQCkMkCXCX mEsYK03K+XtD9u4oYYV/T+rQOElde0pzbfziBUXGrWRjaKjFbrYLL6le2U2Zd3+RO2 5FIbIEng/CZgX/2pDCVrErX/GvoNn8L7z5HXy0Wb6MMjGH/jKoePaRWAKJQuNqc6j7 ybUD9aqdTG82+JS5wa0zxtmGQ9sIaBibrp52Y1AVpK54STEIsqks3TsM7OaZreN1f2 QwOtrm3ygx1Q2T0izQDM6vfvN5zMQ674Lk7qYmvi8dWhiWZVqm4dW1Uk1T/XMpVWML uVy2zk17ilpGw== Received: from aws-us-west-2-korg-lkml-1.web.codeaurora.org (localhost.localdomain [127.0.0.1]) by smtp.lore.kernel.org (Postfix) with ESMTP id 26FCCC36003; Wed, 19 Mar 2025 20:59:45 +0000 (UTC) Date: Wed, 19 Mar 2025 21:59:42 +0100 Subject: [PATCH v2 03/13] iio: light: al3010: Remove DRV_NAME definition Precedence: bulk X-Mailing-List: linux-iio@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-Id: <20250319-al3010-iio-regmap-v2-3-1310729d0543@ixit.cz> References: <20250319-al3010-iio-regmap-v2-0-1310729d0543@ixit.cz> In-Reply-To: <20250319-al3010-iio-regmap-v2-0-1310729d0543@ixit.cz> To: Jonathan Cameron , Lars-Peter Clausen Cc: Svyatoslav Ryhel , Robert Eckelmann , linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, David Heidelberg X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=1274; i=david@ixit.cz; h=from:subject:message-id; bh=rjD7NN5hHGkzdwx0H9EXzCR9U7T+XzOGq1m3plbXlAM=; b=owEBbQKS/ZANAwAIAWACP8TTSSByAcsmYgBn2zA9al3AYypMpivfMaBR1hM1f2Y7pM8bS3dry CzxjkJTbj2JAjMEAAEIAB0WIQTXegnP7twrvVOnBHRgAj/E00kgcgUCZ9swPQAKCRBgAj/E00kg cpucEACjlvOHIMuHfuq5nzpaSfeMcnWUsm5WePgke94UZjrUunMzIVhjS7MpzSKu5Kq7YNSiOI9 n5PEZNW/bq4tAme726JfDF4A9hveQhHEOwJmj3pa81Or8SBXiA5pp2PJY2IfoYM6KN/rh7W9Rzf x6XsfdXq0NI9m3X1zztyK/oK5VGYA/67UaShLtFKH6s4r/gxp+iyHvE86dO88NBtZQnTngQGXVR FNC4fKZK/Plt7ImP66lhFxbqmHW3Jg4PV7dktE7Vf0+g2pz4H1tG93Uq94UzIHuh0FK94x/Fifp MZjEdOowVt9bDYakZTfABwVUO3CYpgTe/DUTvp/Gt2rxr3aMDqkvUIsvLJDEIfRDBfcLLez98lA EjZ8UCNdpJX6MxBoUkkuJWC0F2Df8dytkngAOzSaBYULlXO4otgwxoxvwty4jMZ+Y/MER8wEY7Y iBomR+fWFX8s1eexbUj966X21OVtUj8HjNPsOy7XdVYUx502pmBrxszX1ApCoT2ONv+BD7kBa1p JdtkCqMDkt8/03bAhKvh2PO0P7HLaTXBaPNWR79oG52ZbIQK4p5aj55YXy69RxMkBRoRJilcDej dPR84mpC+wYUuzJ9maV7hJurJFNoR0HDuh9r4qAIq+OMhP9iu3AWijzRtkT1ccVP/5nCPaS7GNP 56GijoWPvme8d3A== X-Developer-Key: i=david@ixit.cz; a=openpgp; fpr=D77A09CFEEDC2BBD53A7047460023FC4D3492072 X-Endpoint-Received: by B4 Relay for david@ixit.cz/default with auth_id=355 X-Original-From: David Heidelberg Reply-To: david@ixit.cz From: David Heidelberg From: David Heidelberg The driver name should be passed directly. Signed-off-by: David Heidelberg --- drivers/iio/light/al3010.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/iio/light/al3010.c b/drivers/iio/light/al3010.c index 4c2fd88ab32cd73f4735b0fa3014af084037c94d..7fe91049b55e57558aef69d088d168437a6819ec 100644 --- a/drivers/iio/light/al3010.c +++ b/drivers/iio/light/al3010.c @@ -22,8 +22,6 @@ #include #include -#define AL3010_DRV_NAME "al3010" - #define AL3010_REG_SYSTEM 0x00 #define AL3010_REG_DATA_LOW 0x0c #define AL3010_REG_CONFIG 0x10 @@ -184,7 +182,7 @@ static int al3010_probe(struct i2c_client *client) data->client = client; indio_dev->info = &al3010_info; - indio_dev->name = AL3010_DRV_NAME; + indio_dev->name = "al3010"; indio_dev->channels = al3010_channels; indio_dev->num_channels = ARRAY_SIZE(al3010_channels); indio_dev->modes = INDIO_DIRECT_MODE; @@ -224,7 +222,7 @@ MODULE_DEVICE_TABLE(of, al3010_of_match); static struct i2c_driver al3010_driver = { .driver = { - .name = AL3010_DRV_NAME, + .name = "al3010", .of_match_table = al3010_of_match, .pm = pm_sleep_ptr(&al3010_pm_ops), }, From patchwork Wed Mar 19 20:59:43 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: David Heidelberg X-Patchwork-Id: 14023105 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9764520C486; Wed, 19 Mar 2025 20:59:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1742417985; cv=none; b=VnJER+oEx2ZQ3dcLWpLOToKfaHT1HX9sejBtUHGmA7OSY8gb0ifGT9f5rMO9Yz6YMYvu8Bf/NsYBUbSlj0ANZmg7j5pOO64ZSIQpkXEslZSQM3m9yumaCmUUKLki+S/sM8PCx3dis7kKoGrY0DLhYD0WzREiHhr9bQmIxaNX7cg= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1742417985; c=relaxed/simple; bh=w7HnRxljEAVoN34ETPZRC9dbPekRdsP4k7Kni7Ao/TA=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=Q73e4O1szdK80RS3n7PhBAEGf3JY1y0nUbSH9uaYdO52HTJCaHjebnsoO0KYzz7V+wfIhUwPOzo8WAuM6FVX5HjsshEvVMopM7RvgOLrosi0UY7KdWtmCfpYzGNqWMRmomLgdpPt/a5KE6w62YZfxsjoxHB1U+bSgmAjt5DTtC8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=r/ORuewH; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="r/ORuewH" Received: by smtp.kernel.org (Postfix) with ESMTPS id 3F82FC4CEEF; Wed, 19 Mar 2025 20:59:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1742417985; bh=w7HnRxljEAVoN34ETPZRC9dbPekRdsP4k7Kni7Ao/TA=; h=From:Date:Subject:References:In-Reply-To:To:Cc:Reply-To:From; b=r/ORuewHifwBOkIQsr+x8fCUbXMjayBPN02YAoCfgrPWziLMxThqvAlr/xbto1rL8 RgXdxAXTZWcqabUuIPFY8CTOtAG37xTlrGeD+o1wAE1ff3BOcgx3ZqIksUxw/94uwR UOkyCVxqHNRPfCi+vqJrY8DOFm8k1SyRDDXZwIu3FAVziTlRPYD8+8EXcqyS+2iiJn ws1oU33pSIT0aDP7M9nbdMTH8TlWvw9SW0WbNG3YYsb3Xny4GCsiBLYZHA3Y4L4L6E 32IM9Y+eZXnUHv/Gl4oTeyM1rPX2+1ZrlgfEB/U19LeQCYY5ZKIRjbpv4ZDg+azSoN 87yOw8uplRK/w== Received: from aws-us-west-2-korg-lkml-1.web.codeaurora.org (localhost.localdomain [127.0.0.1]) by smtp.lore.kernel.org (Postfix) with ESMTP id 359B0C36002; Wed, 19 Mar 2025 20:59:45 +0000 (UTC) Date: Wed, 19 Mar 2025 21:59:43 +0100 Subject: [PATCH v2 04/13] iio: light: al3320a: Remove DRV_NAME definition Precedence: bulk X-Mailing-List: linux-iio@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-Id: <20250319-al3010-iio-regmap-v2-4-1310729d0543@ixit.cz> References: <20250319-al3010-iio-regmap-v2-0-1310729d0543@ixit.cz> In-Reply-To: <20250319-al3010-iio-regmap-v2-0-1310729d0543@ixit.cz> To: Jonathan Cameron , Lars-Peter Clausen Cc: Svyatoslav Ryhel , Robert Eckelmann , linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, David Heidelberg X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=1334; i=david@ixit.cz; h=from:subject:message-id; bh=podRMdd7qcZVHdZFZlFuKdLaKGh8xBj/PEa8jmahNxc=; b=owEBbQKS/ZANAwAIAWACP8TTSSByAcsmYgBn2zA9cxcPFjtvjXTo2zRB3fD1q7ZuoiU+RRJno RP4FiMUKOWJAjMEAAEIAB0WIQTXegnP7twrvVOnBHRgAj/E00kgcgUCZ9swPQAKCRBgAj/E00kg chtoD/0UL3tEWdE/eR7ZJj3B2TYv5nY9R1jIfhmtSA6d7/vWvxDnZlTctMQFuEC+Sw7TSPboe/H wSRNval/DE5ZmtGULxquuCHXWl2npgbGVKqmos5/HXdbGzCx+2UXehtGn9TaQWRlVY0TbY6i3yS EkdTJdZ6mMYDdMjDOsokHk+0rDg9/y+0gcnFJEgxFKejXRRbitjNffGHH5c+If21LpoQX6+Q1NG VB4gcJtwOW3h3aqM6mYjiWhWB5CqF+bMKk/iVE8LsesT9+AWTAnSBk5x21RlN/LlV5HnG487LRZ OwKMuqjXq0riAJPGZrN3GZjDZZt8Esmuj+ULKe2mM/Zp1/AKaU3PCSSS3v+O6AQYLfjz88OiDW9 ssyU8OVnWm9rPtXOdTJH75sLgxLA8WIesECZz7rPxXbX+RSRfkmiX8m5OSQMMuQz83CZGhp8BD0 lpYCYn7K5BgTkFbuB1TCZKsYem83He3euoQ3M4AiYvXpDnrlUUrtvN9amkuwMVA9em6vMDvvZJe AoCzvCmGH4qJMvfFgKPANfoRVx958VFOAdrfZQcj/EZqExzAPkHnZs1HOFIM7cm0j8v7oLXGNXs ImFkn6ODHCrPeE4/BsFivr5XgdsoIvulsMLG9nrzgTDP2349wSx11ZmQeao9bghuF8h3XjdVfC8 Rrve+tcAJlETOAg== X-Developer-Key: i=david@ixit.cz; a=openpgp; fpr=D77A09CFEEDC2BBD53A7047460023FC4D3492072 X-Endpoint-Received: by B4 Relay for david@ixit.cz/default with auth_id=355 X-Original-From: David Heidelberg Reply-To: david@ixit.cz From: David Heidelberg From: David Heidelberg The driver name should be passed directly. Signed-off-by: David Heidelberg --- drivers/iio/light/al3320a.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/iio/light/al3320a.c b/drivers/iio/light/al3320a.c index bceda71517c8180dff76db311aa3591ab9846156..93416f3bd7fbb0a75bef17949725d0d40b9b93ea 100644 --- a/drivers/iio/light/al3320a.c +++ b/drivers/iio/light/al3320a.c @@ -20,8 +20,6 @@ #include #include -#define AL3320A_DRV_NAME "al3320a" - #define AL3320A_REG_CONFIG 0x00 #define AL3320A_REG_STATUS 0x01 #define AL3320A_REG_INT 0x02 @@ -202,7 +200,7 @@ static int al3320a_probe(struct i2c_client *client) data->client = client; indio_dev->info = &al3320a_info; - indio_dev->name = AL3320A_DRV_NAME; + indio_dev->name = "al3320a"; indio_dev->channels = al3320a_channels; indio_dev->num_channels = ARRAY_SIZE(al3320a_channels); indio_dev->modes = INDIO_DIRECT_MODE; @@ -255,7 +253,7 @@ MODULE_DEVICE_TABLE(acpi, al3320a_acpi_match); static struct i2c_driver al3320a_driver = { .driver = { - .name = AL3320A_DRV_NAME, + .name = "al3320a", .of_match_table = al3320a_of_match, .pm = pm_sleep_ptr(&al3320a_pm_ops), .acpi_match_table = al3320a_acpi_match, From patchwork Wed Mar 19 20:59:44 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: David Heidelberg X-Patchwork-Id: 14023114 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F27BB21577D; Wed, 19 Mar 2025 20:59:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1742417986; cv=none; b=PpxqA+4SP9iMqX4x9S/WKW0XDVltkkVIWD777V/7DZtXpAmiIHbhUK2XVciukUZluFxFf+9NtZ77PJRNu/JIphwdsgECD5O43vtzEF06rDHbJuLze0YxxGBsOP85H+apdlFbkXw/0fj6hHkz4C7ytLtaQ2VcyzpNk4dPIPK8BwA= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1742417986; c=relaxed/simple; bh=xsuhm4qHLly8ULEOehp66neM7rdUKva1w2y08MB6ShI=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=OhwZfPFx+2dZQ+gCtSYOtuICNW7yumgf5/1QjEYloB7yMciJq7SNCVZFy9+qIJrdQp0OO64dgXQx1h1osUbg9u4nu1P4hZZTBQDSQwXRHnvSpWLYKacq8XiKX4MN8ye0sHaNl7dev+qx8oy48sXrG99dG73OMZuk/cekyLrCn5k= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=ACi2HBr5; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="ACi2HBr5" Received: by smtp.kernel.org (Postfix) with ESMTPS id 4BEC7C4CEF1; Wed, 19 Mar 2025 20:59:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1742417985; bh=xsuhm4qHLly8ULEOehp66neM7rdUKva1w2y08MB6ShI=; h=From:Date:Subject:References:In-Reply-To:To:Cc:Reply-To:From; b=ACi2HBr5CWjTlbclWaKUhhPSHZB0Hsr33aWYMbDgvN/ZUrLeUEE1Fi1SlvZXE4jFA GYMJEw+pER6AjFIwDaa+EmF/TrZc1/88g0yRfu9gy1MQMURaCJM2Pcib9Rc1zuqJhD yom4VvzlBmtyKUOBWpHh92Sm62BWYaWCQxjuNxKpmwD13flfVdRJVzQ1hzKCOVll6L ywxqqDHTLKCgWz7BnZaXiTcV3zefPOUVGoykzBqk1U8CHvXSku+Bhm5icoQRjeVCZ9 B7PKVYQCfYp5+58Dl0oib7Ihl4wpDEEZk1zDyqYu1jJKo3D12uO0V0q6hsc+xqmTEN 7diGvcRlPiULA== Received: from aws-us-west-2-korg-lkml-1.web.codeaurora.org (localhost.localdomain [127.0.0.1]) by smtp.lore.kernel.org (Postfix) with ESMTP id 42D46C35FFA; Wed, 19 Mar 2025 20:59:45 +0000 (UTC) Date: Wed, 19 Mar 2025 21:59:44 +0100 Subject: [PATCH v2 05/13] iio: light: al3010: Abstract device reference in the probe function Precedence: bulk X-Mailing-List: linux-iio@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-Id: <20250319-al3010-iio-regmap-v2-5-1310729d0543@ixit.cz> References: <20250319-al3010-iio-regmap-v2-0-1310729d0543@ixit.cz> In-Reply-To: <20250319-al3010-iio-regmap-v2-0-1310729d0543@ixit.cz> To: Jonathan Cameron , Lars-Peter Clausen Cc: Svyatoslav Ryhel , Robert Eckelmann , linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, David Heidelberg X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=1322; i=david@ixit.cz; h=from:subject:message-id; bh=X7k3nG8St4YffEhl0mBYetKomz7otdLVmRWRQD0F640=; b=owEBbQKS/ZANAwAIAWACP8TTSSByAcsmYgBn2zA9XOyrnm7ZpJDYqVGomOPKxao6IZma8EtDZ LIuHwfzhOKJAjMEAAEIAB0WIQTXegnP7twrvVOnBHRgAj/E00kgcgUCZ9swPQAKCRBgAj/E00kg cjCCD/9OmxKSxOpC69ZSJCmuOzJpi11TytIbokCL99Grr8+Nxdc8ZzZBOL9aXg5zNHa01dabyPh rC7qX7buuUyjEFxtm3gyIlPKU6qUNL6hsaIaWC02/fVX5rUtxgUhIauJ+4yYjHqaL/xJxSw1o2W aTXsFAW36ACb2K3A01KnFwWDYx2FEDMGxK/qdmMBfodcbx3SiAo0JT7LLlVvbaVaDSJgQNeRY3S OjLD0Q7og92GtxVKZk4u7/cZp5MJQzIXYFYRZl9q0jgz8rw4KePXGhbQzpZ2Lqw6xXTe3l+cJwU sYw2CYJmJdak3poNhl6Epme6VMhL+trkJPl+5UC8Yel2USEvZ7/a9+dfSpB63E5Nf6OVUWBJanF Qk9En5mPoNAYuuyMawqEyIKBwfeV0HDAuYY6zNI3SPp5ew4Ay4/zztTVdDToloP3ohZ33dEgDxa NjiwU72sBhHGi0QYNxSkNk60Z30RRSEJVM+0hlbSv1VBhJSIbvjGl8WzVmKofi+f2wvsggPQHUY aJIzZ0H3K9i6LH/J96HxRZbXl3uao1P006Ux9o3Yr+Nb8Lxhocis++NMUkACwMP5Z1FXAIMTTsG Xrq2MUWQ2sBCsgnJK19PlBV0jsUyxp9uwypMdkaY9SfKJw2bQoVFkx6ved3KadkKJQMqDJ9HRPq 87wvMjZ8JBMh41Q== X-Developer-Key: i=david@ixit.cz; a=openpgp; fpr=D77A09CFEEDC2BBD53A7047460023FC4D3492072 X-Endpoint-Received: by B4 Relay for david@ixit.cz/default with auth_id=355 X-Original-From: David Heidelberg Reply-To: david@ixit.cz From: David Heidelberg From: David Heidelberg Introduce a local variable reducing redundancy and improving readability. No functional changes. Signed-off-by: David Heidelberg --- drivers/iio/light/al3010.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/drivers/iio/light/al3010.c b/drivers/iio/light/al3010.c index 7fe91049b55e57558aef69d088d168437a6819ec..c8f528f3636a2eb0f0c9586da64a6560d4b42e29 100644 --- a/drivers/iio/light/al3010.c +++ b/drivers/iio/light/al3010.c @@ -170,10 +170,11 @@ static const struct iio_info al3010_info = { static int al3010_probe(struct i2c_client *client) { struct al3010_data *data; + struct device *dev = &client->dev; struct iio_dev *indio_dev; int ret; - indio_dev = devm_iio_device_alloc(&client->dev, sizeof(*data)); + indio_dev = devm_iio_device_alloc(dev, sizeof(*data)); if (!indio_dev) return -ENOMEM; @@ -189,11 +190,11 @@ static int al3010_probe(struct i2c_client *client) ret = al3010_init(data); if (ret < 0) { - dev_err(&client->dev, "al3010 chip init failed\n"); + dev_err(dev, "al3010 chip init failed\n"); return ret; } - return devm_iio_device_register(&client->dev, indio_dev); + return devm_iio_device_register(dev, indio_dev); } static int al3010_suspend(struct device *dev) From patchwork Wed Mar 19 20:59:45 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: David Heidelberg X-Patchwork-Id: 14023109 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CBAE2215049; Wed, 19 Mar 2025 20:59:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1742417985; cv=none; b=SN14Oeg0aoMH1GDIMMqct1RMbvko7cCpoI3bThfO2naN0autFeLIMPwcAlDw1F4p6araVlMHHZD9Af2h6Vs33yWqbpA1g5YCPPIRQY7qeOoEwkz3iqO7CpfpPZAK8bENDyW9YryFuuEtPbtzvaP7Dqn1d2MGeR7ScNZuNPVmCTA= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1742417985; c=relaxed/simple; bh=I1QudRTcRzar5C3WjocpB9UgOXiwRUlIuiV6ZhxQUAk=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=WWlUn8ITFX4njqmY0jFn8yZXyY0NBY9H/2PCySLyHnGxXSVQ8mXfzlpc31s8wbiFkVYc35pWVSitznCl7qb5rVnkS5KYh5tzGcIDFe8Y+gtbMDWsp4wRYrBcDNEh4+HG59YHIFNQoBafJJpIURReykpAVLyk1kzNAXfxlqkZ1xE= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=oQ+nMc4L; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="oQ+nMc4L" Received: by smtp.kernel.org (Postfix) with ESMTPS id 58F87C4CEF2; Wed, 19 Mar 2025 20:59:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1742417985; bh=I1QudRTcRzar5C3WjocpB9UgOXiwRUlIuiV6ZhxQUAk=; h=From:Date:Subject:References:In-Reply-To:To:Cc:Reply-To:From; b=oQ+nMc4LxswyJpIkMWdMDaczauypeDn4xdtRsjlzcb1/ybGIR3ICsF/nMp06umn5r nCdPn5IaBmhTKKIi1Nf8rDJpR//HrdSkJg4O0jKNqLjrOIegYAfye6fig/8jCG4aBS mdUsEc2xyY8vAtP3HgjiL5kDOAiGbQ8gPgizcg4WIuj85JWAnz0qdKEJtf1NntCL8l 7ZSYrdYDHmX2zb4iEExWOBljZBchphzl+8ayzVyID7Zpe2LraK9OmaChO7GcYAI2Dv gtUZu4jsPkGw2N48v8tvQVVxqBgBtDMKglXe5fJexqmKxLfIs/z/gtHtxLJQjwgrB3 8kdRfpCELmCkg== Received: from aws-us-west-2-korg-lkml-1.web.codeaurora.org (localhost.localdomain [127.0.0.1]) by smtp.lore.kernel.org (Postfix) with ESMTP id 51124C36001; Wed, 19 Mar 2025 20:59:45 +0000 (UTC) Date: Wed, 19 Mar 2025 21:59:45 +0100 Subject: [PATCH v2 06/13] iio: light: al3320a: Abstract device reference in the probe function Precedence: bulk X-Mailing-List: linux-iio@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-Id: <20250319-al3010-iio-regmap-v2-6-1310729d0543@ixit.cz> References: <20250319-al3010-iio-regmap-v2-0-1310729d0543@ixit.cz> In-Reply-To: <20250319-al3010-iio-regmap-v2-0-1310729d0543@ixit.cz> To: Jonathan Cameron , Lars-Peter Clausen Cc: Svyatoslav Ryhel , Robert Eckelmann , linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, David Heidelberg X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=1532; i=david@ixit.cz; h=from:subject:message-id; bh=Ct1gfcrjZUKbkM919cRcq2ZoAee3rgE77Wd7D0kN4IQ=; b=owEBbQKS/ZANAwAIAWACP8TTSSByAcsmYgBn2zA9d5MI7y5r0Kp+Il39GDvhw+GAXO+1U68D8 cpoGkCO4B2JAjMEAAEIAB0WIQTXegnP7twrvVOnBHRgAj/E00kgcgUCZ9swPQAKCRBgAj/E00kg cgrED/0aXuYXLYx7Lx1WaDZQ9DPGyQQuMmWIU6B2lm3T7Wc+VGSAv1FN+d+t1eXoosMwqbSgztF ixW6pL4d4YJOsCaYg1FWaWPeNKAo4lxXkMrAinWNqCZck2RohshLweIkbQqG/q1C0vNJeswbo6p +6XsHms6myzLQpEZPPkkYKReWBgsOfA/bq38nWXjsAEMMq6hAw/7szTtMsug50DhhKXOeSch0fZ M9CIGIcDVlLAPb0wWjWYsmvSuGZ1nlwMLQC+l4j6jEkyzkTzlBP6ByzrlOgArYL/EixHBGgelEj 9WNbi10ESDReQnx43zVcfX9Auffypjg7Q9ZxZjhk/g2NzySAG/yNJnWRcQPVwqoF0YfgZ1Sd94W Flyl+sXMEBPrrOdcJI89H8Q3s+4HM68spBPQHy8B2au5ICMw5woSMgp5H61xN809rPVPXDNvH35 DoPYHbd7epzP6g0qaaphNylFXVzYFFbHQ5tH0L0inYRbYSa9JIaXpyv9l4rXp+mb+nOF2WT+GK6 heDYoDCpI3oluivR4XJnzGiFXIKVly6ygBUyBiyTA+iTngC9N3UfBF654wnpnjJUc7372iXLkDv NHdsGIvb02tAHf2/RAopJZ/dr5hi2zhVD7UKPXnRbfMtMfvlaXqEe4/Ft1nGpORJP+2jPh+l2ol kDa/bDqdbRBqOag== X-Developer-Key: i=david@ixit.cz; a=openpgp; fpr=D77A09CFEEDC2BBD53A7047460023FC4D3492072 X-Endpoint-Received: by B4 Relay for david@ixit.cz/default with auth_id=355 X-Original-From: David Heidelberg Reply-To: david@ixit.cz From: David Heidelberg From: David Heidelberg Introduce a local variable reducing redundancy and improving readability. No functional changes. Signed-off-by: David Heidelberg --- drivers/iio/light/al3320a.c | 11 +++++------ 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/drivers/iio/light/al3320a.c b/drivers/iio/light/al3320a.c index 93416f3bd7fbb0a75bef17949725d0d40b9b93ea..9817cfe8ae18a8e27c82e7362481ebd32a41f8ec 100644 --- a/drivers/iio/light/al3320a.c +++ b/drivers/iio/light/al3320a.c @@ -188,10 +188,11 @@ static const struct iio_info al3320a_info = { static int al3320a_probe(struct i2c_client *client) { struct al3320a_data *data; + struct device *dev = &client->dev; struct iio_dev *indio_dev; int ret; - indio_dev = devm_iio_device_alloc(&client->dev, sizeof(*data)); + indio_dev = devm_iio_device_alloc(dev, sizeof(*data)); if (!indio_dev) return -ENOMEM; @@ -207,17 +208,15 @@ static int al3320a_probe(struct i2c_client *client) ret = al3320a_init(data); if (ret < 0) { - dev_err(&client->dev, "al3320a chip init failed\n"); + dev_err(dev, "al3320a chip init failed\n"); return ret; } - ret = devm_add_action_or_reset(&client->dev, - al3320a_set_pwr_off, - data); + ret = devm_add_action_or_reset(dev, al3320a_set_pwr_off, data); if (ret < 0) return ret; - return devm_iio_device_register(&client->dev, indio_dev); + return devm_iio_device_register(dev, indio_dev); } static int al3320a_suspend(struct device *dev) From patchwork Wed Mar 19 20:59:46 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: David Heidelberg X-Patchwork-Id: 14023111 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CFB51215078; Wed, 19 Mar 2025 20:59:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1742417985; cv=none; b=DowmQCTxZwlL9cyt0VSd+ApN5c3ig3qE4fQUhEZe9Tjf9zmKWOJEQ3cSAiYO62IwFcPV9tu/pU/K49kc0D/LOQZ0uqIErAsACqxc6BkOy1uHeAAfkr77LRsbU7QAHbS6dh0vpG1aVJfWtlu/hs6f/4uBGxJGpbb5DtEO39Vjb0Y= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1742417985; c=relaxed/simple; bh=cQ8+Op3kRLvwmiWD71YC8C5zKQ3WJ+UymbQfnjWKQ+w=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=YpuqVge+fWwTE38kw3WuKvgLS+RULePr/UV68alPJ0J+raES4kjul/qwotBLGw+lbc+zPighWHAPZiOdrdUaEcyEdMV4yObTD6YEon8oqZ23lS61JEYuzckSa7dvF8qJ8xctY06UmjKa/szLH8IZN2vpSJgWITXBvAJZS3JPttI= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=IlPFTgNx; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="IlPFTgNx" Received: by smtp.kernel.org (Postfix) with ESMTPS id 66868C4CEF5; Wed, 19 Mar 2025 20:59:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1742417985; bh=cQ8+Op3kRLvwmiWD71YC8C5zKQ3WJ+UymbQfnjWKQ+w=; h=From:Date:Subject:References:In-Reply-To:To:Cc:Reply-To:From; b=IlPFTgNxKkNiS/SLjpvObGhiv+jntc1NU1m6/v4CA3QOwuxbCj3IMP/DgyJx3z0uM hQmdNMIFD01um1kDTaaoXTbLmR44T7ottO63+7DHpvq3/FLiZKzaR5Np7u8bymL57I Ba2UwrqvgZFaS4kun97yPdw/H4G1KXooKoCIN+e4Dl90w0EhySYXK2bWJGnpcyfTTb 8X2JoyNuywIX1MA5WUp8Legk18W4UL/J+NupmeUlanCk7JJdok3r+LCXIcDMWfUtw+ TlGdOalHvwGvtZhycZ382p2z9K0V7qgIyHjS4ea55fVAjvOnDMCxJ3mLyCSWWuY7VH MPynZYAdj6zbg== Received: from aws-us-west-2-korg-lkml-1.web.codeaurora.org (localhost.localdomain [127.0.0.1]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5DBFFC36002; Wed, 19 Mar 2025 20:59:45 +0000 (UTC) Date: Wed, 19 Mar 2025 21:59:46 +0100 Subject: [PATCH v2 07/13] iio: light: al3010: Split set_pwr function into set_pwr_on and _off Precedence: bulk X-Mailing-List: linux-iio@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-Id: <20250319-al3010-iio-regmap-v2-7-1310729d0543@ixit.cz> References: <20250319-al3010-iio-regmap-v2-0-1310729d0543@ixit.cz> In-Reply-To: <20250319-al3010-iio-regmap-v2-0-1310729d0543@ixit.cz> To: Jonathan Cameron , Lars-Peter Clausen Cc: Svyatoslav Ryhel , Robert Eckelmann , linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, David Heidelberg X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=1909; i=david@ixit.cz; h=from:subject:message-id; bh=vOib51/xpneU1DtWyRjsNY1gpYkAaqRHzYSkX1BUJo4=; b=owEBbQKS/ZANAwAIAWACP8TTSSByAcsmYgBn2zA+WhBZQES0+91AU6m/fyiF7GLrpJGg7rPU1 6XKQBu1L5WJAjMEAAEIAB0WIQTXegnP7twrvVOnBHRgAj/E00kgcgUCZ9swPgAKCRBgAj/E00kg cmZXEAC7DBAsyzOMQiY4z3k4WVrDST/JuGR/9IbmZR5bsN+EolCvK/H5ebgdwn+vv9f9wRtriwZ OSFAwwe3dA1ukqDpX/LHSnMKJkglDtJA74Fz+nY+Ekj50U0YNw2D0BFY/dvpvgMlmyjSTNufdVJ +riBrfQW5odlIrMSR9WpzItSc5Zc771yUSOwYwa1l11JXTCyLS+SMo9o2SskhqLwnfbYi0v20kl aQaw+weS54MsuX4JKI6zEaiqKWwlE39JIQWVlxYakPiG9y4LvR0v7A88ssfBb+zoYiGYT4CD6Nh sRYJeVnylBfWWJ42ttQMPlju9FDQtpt4CBIUyWTlPaedtSEahIIRHH+OWCHmrVJi/nbhqiRvN4M kmkeMLboSRbE6bDovJF6fQAcNh4ZFHDTEupZSl/bmV5RmfyjwHzRT3m84R8J/Q0HBtXfXuydYbN v/WQhzYWmchBJurPLyWvTDVi02OzBj3q36wvhtvujqDMXGY3ua85KuOjX85rqG6Cz+9k76tgs6D 5Mm7Dkf2QRDBqUbS0WYKJMeODbYtMv9Kr0NVBHeRLH/RBYgPVDrg84RWAVvyYESTvCJj7Dd3FNd VyLm4No5LRQBv6ukxvpLzK5O/c8Uf2CNnG5yIUSjnwOZu5Ye4KsonP64qrKWnVvaQuWMlWtlIT8 jW4K0/0RXq0cP3g== X-Developer-Key: i=david@ixit.cz; a=openpgp; fpr=D77A09CFEEDC2BBD53A7047460023FC4D3492072 X-Endpoint-Received: by B4 Relay for david@ixit.cz/default with auth_id=355 X-Original-From: David Heidelberg Reply-To: david@ixit.cz From: David Heidelberg From: David Heidelberg Simplifies later conversion to the regmap framework. Signed-off-by: David Heidelberg --- drivers/iio/light/al3010.c | 18 +++++++++++------- 1 file changed, 11 insertions(+), 7 deletions(-) diff --git a/drivers/iio/light/al3010.c b/drivers/iio/light/al3010.c index c8f528f3636a2eb0f0c9586da64a6560d4b42e29..8c004a9239aef246a8c6f6c3f4acd6b760ee8249 100644 --- a/drivers/iio/light/al3010.c +++ b/drivers/iio/light/al3010.c @@ -67,24 +67,25 @@ static const struct attribute_group al3010_attribute_group = { .attrs = al3010_attributes, }; -static int al3010_set_pwr(struct i2c_client *client, bool pwr) +static int al3010_set_pwr_on(struct i2c_client *client) { - u8 val = pwr ? AL3010_CONFIG_ENABLE : AL3010_CONFIG_DISABLE; - return i2c_smbus_write_byte_data(client, AL3010_REG_SYSTEM, val); + return i2c_smbus_write_byte_data(client, AL3010_REG_SYSTEM, + AL3010_CONFIG_ENABLE); } static void al3010_set_pwr_off(void *_data) { struct al3010_data *data = _data; - al3010_set_pwr(data->client, false); + i2c_smbus_write_byte_data(data->client, AL3010_REG_SYSTEM, + AL3010_CONFIG_DISABLE); } static int al3010_init(struct al3010_data *data) { int ret; - ret = al3010_set_pwr(data->client, true); + ret = al3010_set_pwr_on(data->client); if (ret < 0) return ret; @@ -199,12 +200,15 @@ static int al3010_probe(struct i2c_client *client) static int al3010_suspend(struct device *dev) { - return al3010_set_pwr(to_i2c_client(dev), false); + struct al3010_data *data = iio_priv(dev_get_drvdata(dev)); + + al3010_set_pwr_off(data); + return 0; } static int al3010_resume(struct device *dev) { - return al3010_set_pwr(to_i2c_client(dev), true); + return al3010_set_pwr_on(to_i2c_client(dev)); } static DEFINE_SIMPLE_DEV_PM_OPS(al3010_pm_ops, al3010_suspend, al3010_resume); From patchwork Wed Mar 19 20:59:47 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: David Heidelberg X-Patchwork-Id: 14023108 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CD08D21506D; Wed, 19 Mar 2025 20:59:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1742417985; cv=none; b=AAyqVDLwSfEMoMHogaKLwOwqM3y5ym2Y1m+f6nGHxX8o8KdwocbBx9U9k4q3PvLWiqFfHsTuczgUI+BnMj1d92CWdWbgsqHEfGlKcnE/gO8yjLo5JQLkd2XGM5IaZTncOwNkqOWdJR80oZAe9zAsoLfKWSq0FxXeLYVN1ZR6GhU= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1742417985; c=relaxed/simple; bh=Nb40p3Xs+C8O0Jlm8TgZdUhNJU4aeXieAVS9NlYFhio=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=Phpvtt47WUkuGEOU8wy0SbRkr5P/L3PNC28sw5FCdERIk4q1DxuEw3/qqCfjps48YDM08owDOKjupT8tQ03OkGgO4D0a9Qk5r+BbfFJ2kXYkNEbzvMrd+c2EgwIMRebhSG1eY9RprsfmjhukMRNPGYYNfpAR5TlYxiP9O/kIsqw= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=GgzJC+ch; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="GgzJC+ch" Received: by smtp.kernel.org (Postfix) with ESMTPS id 73655C4CEF8; Wed, 19 Mar 2025 20:59:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1742417985; bh=Nb40p3Xs+C8O0Jlm8TgZdUhNJU4aeXieAVS9NlYFhio=; h=From:Date:Subject:References:In-Reply-To:To:Cc:Reply-To:From; b=GgzJC+chMe/PsMvNd2bTCrzIl9wymaVOrGaLXMqZV1R0ccCBIuZzIcsYeIlUg+ItR L88pFNq+6K6EUxAuZVbLaHqfMBm5uWo2Mkt9XDWB48248KZfIIz1vQxLOv+pE/EuY8 uVNtGXpZKrFJITs+V2zzx/UJojkKbjpJSxZxqSI3oxuzMCKdX4pK6esxwEqreaZ/t5 Kd4Zywfi4GQaZ72qj5I0kVOwXUeb3CieUpuHcEzWwhnHHhtJMzPIsWkJeyTvU5RKwT 1jXH+HzgJyp9dF89Y4LtvpEHrxSVnKCjkH1ECcwh2/39QBG963wrg9NFMtq0YC3k9L V1GNJsIJ5bvAg== Received: from aws-us-west-2-korg-lkml-1.web.codeaurora.org (localhost.localdomain [127.0.0.1]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6BC14C36000; Wed, 19 Mar 2025 20:59:45 +0000 (UTC) Date: Wed, 19 Mar 2025 21:59:47 +0100 Subject: [PATCH v2 08/13] iio: light: al3320a: Split set_pwr function into set_pwr_on and _off Precedence: bulk X-Mailing-List: linux-iio@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-Id: <20250319-al3010-iio-regmap-v2-8-1310729d0543@ixit.cz> References: <20250319-al3010-iio-regmap-v2-0-1310729d0543@ixit.cz> In-Reply-To: <20250319-al3010-iio-regmap-v2-0-1310729d0543@ixit.cz> To: Jonathan Cameron , Lars-Peter Clausen Cc: Svyatoslav Ryhel , Robert Eckelmann , linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, David Heidelberg X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=1907; i=david@ixit.cz; h=from:subject:message-id; bh=HtZAIFM4U29a78slhT7/fEE0u86xMj9t3tNcfonMUX0=; b=owEBbQKS/ZANAwAIAWACP8TTSSByAcsmYgBn2zA+gZJMvBcHRhctyGlYIGPDCoOcnA+hgNZDL BhKUlf9MX6JAjMEAAEIAB0WIQTXegnP7twrvVOnBHRgAj/E00kgcgUCZ9swPgAKCRBgAj/E00kg cp3vD/9cGsLoHMdrpZmfC8d7vIDOY+sacH5u6txMWtgL6Q//iL6/XQEb/W/ulfGuSaSzxbm4/2O v5wrBclpvbT5tu/K5kIpFJoFj14BQOW0tQAokJJAU0ww9R1EyVafl5wEZv2ZyepQPjzrhSqu7X8 F5ALt12d4UyyOsHDaAzb3anNPefcmZxz3KAfZ9cMfsg/R246MaPROwQrqF5DWQj0h3hnEkVO2cw lUi256s3qYzusVxviSkN+zzxVj+IqbGJ5HYz82/OvzsfML7ikdAYwWZiq5Q4UsaVEjGSykXPS3m O1/A61rTnTwVdmbtAUQtbw6S1lPWQHWfhscA+sNj2pysBvt1jXc+1bcwqiSO5a/3d1PCqtChrhM 7OXRU5Pn8Dr5kI1aOMNpc0b1qKtHOo2auNeSZHR4OGfrYwStE7PU/Lqfz9cyfm+8P9PuOukPMKc lJ7AtXFsKZ3zEAck+OoZK783pBlgHn4s297oAabEXjTLI9EQ/7swV69IkkjcqbmPI+IHum2JPnH HAbT6feCT/fmvUCQssjaMh2giWdQehD1/itC4l1rBBRFoKfdHU7NYcW0IRMjOCwMYLXo8AHsNN6 TILHB9yQK1LOqVaatPPA8uepA4gGUz8CY7CQ1dxKqH4sWC3OL/SguhaQlWsoudx4R07Nde+0HRb mVR04zjgWKDyNCA== X-Developer-Key: i=david@ixit.cz; a=openpgp; fpr=D77A09CFEEDC2BBD53A7047460023FC4D3492072 X-Endpoint-Received: by B4 Relay for david@ixit.cz/default with auth_id=355 X-Original-From: David Heidelberg Reply-To: david@ixit.cz From: David Heidelberg From: David Heidelberg Simplifies later conversion to the regmap framework. Signed-off-by: David Heidelberg --- drivers/iio/light/al3320a.c | 16 +++++++++------- 1 file changed, 9 insertions(+), 7 deletions(-) diff --git a/drivers/iio/light/al3320a.c b/drivers/iio/light/al3320a.c index 9817cfe8ae18a8e27c82e7362481ebd32a41f8ec..1b2b0359ed5dad5e00d2fe584f8f3495c13c997e 100644 --- a/drivers/iio/light/al3320a.c +++ b/drivers/iio/light/al3320a.c @@ -80,24 +80,23 @@ static const struct attribute_group al3320a_attribute_group = { .attrs = al3320a_attributes, }; -static int al3320a_set_pwr(struct i2c_client *client, bool pwr) +static int al3320a_set_pwr_on(struct i2c_client *client) { - u8 val = pwr ? AL3320A_CONFIG_ENABLE : AL3320A_CONFIG_DISABLE; - return i2c_smbus_write_byte_data(client, AL3320A_REG_CONFIG, val); + return i2c_smbus_write_byte_data(client, AL3320A_REG_CONFIG, AL3320A_CONFIG_ENABLE); } static void al3320a_set_pwr_off(void *_data) { struct al3320a_data *data = _data; - al3320a_set_pwr(data->client, false); + i2c_smbus_write_byte_data(data->client, AL3320A_REG_CONFIG, AL3320A_CONFIG_DISABLE); } static int al3320a_init(struct al3320a_data *data) { int ret; - ret = al3320a_set_pwr(data->client, true); + ret = al3320a_set_pwr_on(data->client); if (ret < 0) return ret; @@ -221,12 +220,15 @@ static int al3320a_probe(struct i2c_client *client) static int al3320a_suspend(struct device *dev) { - return al3320a_set_pwr(to_i2c_client(dev), false); + struct al3320a_data *data = iio_priv(dev_get_drvdata(dev)); + + al3320a_set_pwr_off(data); + return 0; } static int al3320a_resume(struct device *dev) { - return al3320a_set_pwr(to_i2c_client(dev), true); + return al3320a_set_pwr_on(to_i2c_client(dev)); } static DEFINE_SIMPLE_DEV_PM_OPS(al3320a_pm_ops, al3320a_suspend, From patchwork Wed Mar 19 20:59:48 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: David Heidelberg X-Patchwork-Id: 14023110 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CE5E0215076; Wed, 19 Mar 2025 20:59:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1742417985; cv=none; b=tSh1kUSWePuTkIBoE9ri5SdhD34+hvioCh2DjN1YAvUJNjZJMBxGRwI3fTiXlKTIOhhcp+Wo5mCN4mV/SvnvSgbAR9h/KlOKPqNfHunsuJP1h7At0WdJRK0Sw8KZPkazWlMN7lPANzs5jq/v6JTrwGScu6PoFfHi8gIVMWvwbDI= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1742417985; c=relaxed/simple; bh=nue0fWqXOhNi8JxvPMC3lwGb88sVJDfxNM2KXh2T670=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=RmeiotgqDPv/RQPhCn3gslgyBlW22T5o2CsbFrVENRZ+ugb+DPss+AozvL662GLZDqay/Ye1HGvYzyp7VL6S08AfxUiH0G6FsJEHcPeOQ0NqFs9/qV52s/O1FTxy4TSWcXo4iN4khkUGTXKJNXCkBAP6GhvPjKKtQODpVMRJ8Zw= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=aJDsbHo3; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="aJDsbHo3" Received: by smtp.kernel.org (Postfix) with ESMTPS id 82C4EC4CEF9; Wed, 19 Mar 2025 20:59:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1742417985; bh=nue0fWqXOhNi8JxvPMC3lwGb88sVJDfxNM2KXh2T670=; h=From:Date:Subject:References:In-Reply-To:To:Cc:Reply-To:From; b=aJDsbHo3M8/6ANZDs+WPbuwUAI8FNg5YVmqZXYrUKIKo/A2ANaxtIPnwpR8/2GAF7 tKBKF/oDruqDuxLDhRej5D2ZyEwV/3J+SpsFi032qz2T73DAb967nhT8E8MtPvAV0V JQd+5/gB0g6QGR2M7jvQIu91kmBPxTBwPVa1GGbni0we3klgl0vTAOuxTLt7YkBlsf 6E7Qbv820ysLK9IIji5obvWw8L0u37t9P3gT8fs7zO9n3pCKiY78YnFpaG1OPGsE1Z 50kZX9UHczDEowzjC+2R9bdQ0ioZkoQJ1+KJS8sHh6ievI4AcKpb61M3fQp/LDos6p PA4eY8/NBuaVQ== Received: from aws-us-west-2-korg-lkml-1.web.codeaurora.org (localhost.localdomain [127.0.0.1]) by smtp.lore.kernel.org (Postfix) with ESMTP id 78ECEC35FFA; Wed, 19 Mar 2025 20:59:45 +0000 (UTC) Date: Wed, 19 Mar 2025 21:59:48 +0100 Subject: [PATCH v2 09/13] iio: light: al3010: Move devm_add_action_or_reset back to _probe Precedence: bulk X-Mailing-List: linux-iio@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-Id: <20250319-al3010-iio-regmap-v2-9-1310729d0543@ixit.cz> References: <20250319-al3010-iio-regmap-v2-0-1310729d0543@ixit.cz> In-Reply-To: <20250319-al3010-iio-regmap-v2-0-1310729d0543@ixit.cz> To: Jonathan Cameron , Lars-Peter Clausen Cc: Svyatoslav Ryhel , Robert Eckelmann , linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, David Heidelberg X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=1174; i=david@ixit.cz; h=from:subject:message-id; bh=lxmXVhzbE/KiGpK6qJA+6k8UM9RsJY9i0gVwY5uqpFA=; b=owEBbQKS/ZANAwAIAWACP8TTSSByAcsmYgBn2zA+2mIlnZ7Ts//k4qsOCt/jeIP0gzh0IYaBJ SKZzJPlZdaJAjMEAAEIAB0WIQTXegnP7twrvVOnBHRgAj/E00kgcgUCZ9swPgAKCRBgAj/E00kg cm9jD/9j8a2y5krkAfkMDghPKwG65bzMOGiMfuuCIj5JD2TbLRz8zuMrmp7TXNnbecdfO8VVP34 RkndudsNxfztde/l1Z4vXf0BOTsuBDUYNOsjgvSXS2TxXpodcyP/dzjtgeYAnPSaA6rsdn1QqAD NvSEyZ6Z49Ql/tuet6ogK3kJkDg6NsafIh4FrzRsVEAyWowO4kix60tiX/LyNqo6dzcpaDTGuFO rGINVyJ06M3+/2FxxOK6ceQbak99dX3k5pOxYhTn30gz5aCk3ZTrG25QisQJ+S8gR8RHJ1QibV5 ytcFVvdNQCsCwxvng3bWYvH1WolzkTNzBB6QYMxREjMGDDP75oFANs6HhpTYt26WWkkkeyzow2h 0XZg74JHa4mZObQ+/5TP9XOB5Ep54ZYZHSAJvcfEBNNutKg6ZX5+6FsDDCuQMV49UIu/H0juEuL KfgW0qpAFaPGRudUGIhtG3OPjCBchGny1w1AOqizDbTbWof86QxAmsQ58rGMGCgnuuHAS+ZLNR0 ycIwkUmdkB9LPN25slW8f1e/o1ngR32FcMn8giN7+4mRvMkKcO1VhUsNgxJPahPslfXSaAhV7+O dO3V8cqRhY89drdgrTUrDOeeqLxJHkpcQVrj6R/CD9QV0sYO7wPUy7Q5TEH6ZGeAtKnXm4ktDwY ijmMGMJqyF8drWQ== X-Developer-Key: i=david@ixit.cz; a=openpgp; fpr=D77A09CFEEDC2BBD53A7047460023FC4D3492072 X-Endpoint-Received: by B4 Relay for david@ixit.cz/default with auth_id=355 X-Original-From: David Heidelberg Reply-To: david@ixit.cz From: David Heidelberg From: David Heidelberg In a preparation to the regmap transition. Improve error handling using dev_err_probe(). Signed-off-by: David Heidelberg --- drivers/iio/light/al3010.c | 10 ++++------ 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/drivers/iio/light/al3010.c b/drivers/iio/light/al3010.c index 8c004a9239aef246a8c6f6c3f4acd6b760ee8249..8098c92c9572befe92d00ef0785ded5e1a08d587 100644 --- a/drivers/iio/light/al3010.c +++ b/drivers/iio/light/al3010.c @@ -89,12 +89,6 @@ static int al3010_init(struct al3010_data *data) if (ret < 0) return ret; - ret = devm_add_action_or_reset(&data->client->dev, - al3010_set_pwr_off, - data); - if (ret < 0) - return ret; - ret = i2c_smbus_write_byte_data(data->client, AL3010_REG_CONFIG, FIELD_PREP(AL3010_GAIN_MASK, AL3XXX_RANGE_3)); @@ -195,6 +189,10 @@ static int al3010_probe(struct i2c_client *client) return ret; } + ret = devm_add_action_or_reset(dev, al3010_set_pwr_off, data); + if (ret) + return dev_err_probe(dev, ret, "failed to add action\n"); + return devm_iio_device_register(dev, indio_dev); } From patchwork Wed Mar 19 20:59:49 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: David Heidelberg X-Patchwork-Id: 14023116 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0B34B215F78; Wed, 19 Mar 2025 20:59:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1742417986; cv=none; b=Jq1kdDUqdD3XR4EESWejX5ft0sNQBN5iF+XdP7LUgMBjsZgJGniSqkdUUADIKmE8MXw40BdzlLFzzw0gMY/7/OMyoYAvgiw0IHmfTDKe9tmSIxny7TeJzYQNnHOFDJ3fhCCPGSZo5+dflcRKUVsmnZwf8b3ZOuUZQ2rG0Fl5dEY= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1742417986; c=relaxed/simple; bh=dcbJNZwgOgHVewbA7jxz5V0OKX/waleHhfwZA91/I1A=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=q7XfYIIjeYg53AENJnZBc1azAdfCMvhaAGNDxQvxFRduqtX1fF2K0ZhPMYaOGA22Ef9xh2eS9TKs9qP2AnsCJWfkWKDZiAgA1tGUvvWeTacRZ4xx1jLnoRk7mF/oMD21O0ttL9UlIqRU+Exfd742AW7I2A0QZG2yalUcsDXKVJ4= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=McREUvBj; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="McREUvBj" Received: by smtp.kernel.org (Postfix) with ESMTPS id 912C9C4CEFA; Wed, 19 Mar 2025 20:59:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1742417985; bh=dcbJNZwgOgHVewbA7jxz5V0OKX/waleHhfwZA91/I1A=; h=From:Date:Subject:References:In-Reply-To:To:Cc:Reply-To:From; b=McREUvBj8O2I/I4KZXr0OS3FD/2sr/Nj0ax6EAOtd2TaDPgwkKRE6Nh+x29NmLbnP vjV8rdfY/nGkMTlRxRxJXUuJpUp8labbvd8CZ/I8kezM9+mKqTmNk8FQvpwTst3UAP vSyA/Rnw9lCvMBjEgOW9as8lQffU/Tc5K23R6YWWfZtMvF+7cfaaqN+J8urddJ3eyu G1WmV/ktzbD3HPeTbBnsoD96MQHOj6yLnN7VO8jwo7BM1vtYH/ZvYQ3LfU2YGD/s/F tPyWfIO6GzlC2Rs2/K5gsJaY96uIQiPVpojDQV/q8095IvUUS4hpCAlfu6gC8z5QQ0 2RnAG0rLzP67w== Received: from aws-us-west-2-korg-lkml-1.web.codeaurora.org (localhost.localdomain [127.0.0.1]) by smtp.lore.kernel.org (Postfix) with ESMTP id 87649C36002; Wed, 19 Mar 2025 20:59:45 +0000 (UTC) Date: Wed, 19 Mar 2025 21:59:49 +0100 Subject: [PATCH v2 10/13] iio: light: al3010: Improve al3010_init error handling with dev_err_probe Precedence: bulk X-Mailing-List: linux-iio@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-Id: <20250319-al3010-iio-regmap-v2-10-1310729d0543@ixit.cz> References: <20250319-al3010-iio-regmap-v2-0-1310729d0543@ixit.cz> In-Reply-To: <20250319-al3010-iio-regmap-v2-0-1310729d0543@ixit.cz> To: Jonathan Cameron , Lars-Peter Clausen Cc: Svyatoslav Ryhel , Robert Eckelmann , linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, David Heidelberg X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=818; i=david@ixit.cz; h=from:subject:message-id; bh=U+gyu2giS4hLLAaP3knPJNMAi2dd0lLS/xGNscKmGCc=; b=owEBbQKS/ZANAwAIAWACP8TTSSByAcsmYgBn2zA+6UW4pTZ7TSIE2lofczNz+g9UJ/qu6PDg5 aBmh+cDYR6JAjMEAAEIAB0WIQTXegnP7twrvVOnBHRgAj/E00kgcgUCZ9swPgAKCRBgAj/E00kg co5NEACXcv0zPgnlpV8JIFGudofxcsi1tp9n1jUHFFlcZ9D7hvRgidJZqmmX6P1/XMYvaHW0PLM 0kg8ZEFUy4YmewBfM/FUMIygQLM7HjiwyQ3VP/TOelKD37GA6CORJ7WLo7WifL5oRuNjWcAmS/X 3Lz7/Lr3rCG1ohB8KCRIituClAVaJD2V/my1pxNmkqlmec0U2pFRo7fbeDn1tmlmPtyYrUw7M48 SlIsv1kQWukdo/zvIBadYuIzE4H415FlTKDv1mzcKzW5syFsrzMgbAeKOZCixZhMJyjToch5vmv mdGAsXiuHIZjNYCVUrAksdSeOsJzFViBMBaUfgdW14fj2iFttJ811vIxFheMYiOggTGpeK/zZDP wDZ3Q3269sLlwbP472fOl1RZ56G1lz4cKcQhB4pUN5vdWIH/ytWMoKzANcJb39lg7xffpJaHgoh 0j3xSAtyoWofcYxToFYCtl6WZJfwO3rW+Pets6Dw+jHlHk3ZOGx8jK7QkFIvGpXDezprWWhKafD +7WSUCET5aON3NPOpynrSp0YZw4eTCdQqkyNHiVE5iCGVRw9cGcCWGulO5rdnkKcINfbWQLKwZ2 JrcrL9CR7vQjTxqeOQkM+bcp1k/kJDe68r3TdLN4mejN+XORme3kA2gINXte9Z7HDBUEix7IRoP AhMxf/nKn9vArUQ== X-Developer-Key: i=david@ixit.cz; a=openpgp; fpr=D77A09CFEEDC2BBD53A7047460023FC4D3492072 X-Endpoint-Received: by B4 Relay for david@ixit.cz/default with auth_id=355 X-Original-From: David Heidelberg Reply-To: david@ixit.cz From: David Heidelberg From: David Heidelberg Slight simplification of the code. Signed-off-by: David Heidelberg --- drivers/iio/light/al3010.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/iio/light/al3010.c b/drivers/iio/light/al3010.c index 8098c92c9572befe92d00ef0785ded5e1a08d587..af7ed028259837f2232f30072b87cc0da7c77f37 100644 --- a/drivers/iio/light/al3010.c +++ b/drivers/iio/light/al3010.c @@ -184,10 +184,8 @@ static int al3010_probe(struct i2c_client *client) indio_dev->modes = INDIO_DIRECT_MODE; ret = al3010_init(data); - if (ret < 0) { - dev_err(dev, "al3010 chip init failed\n"); - return ret; - } + if (ret) + return dev_err_probe(dev, ret, "failed to init ALS\n"); ret = devm_add_action_or_reset(dev, al3010_set_pwr_off, data); if (ret) From patchwork Wed Mar 19 20:59:50 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: David Heidelberg X-Patchwork-Id: 14023115 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0B2CE215F76; Wed, 19 Mar 2025 20:59:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1742417986; cv=none; b=Kyj2qi0PT7MyNUQS6eHN5IBmW0FCVIG+yKrtbdW7kLr4tXuja4Vl7Ik0MrYHU5yciLKiMmbIYWlxsxQQlpxzmwKsnAMs8xWCX9THu1pMugX+QKjtLyfzQwoHgSolsNZ/UhiiSm5wPDpqXIrlhHarSzX0FNiTITvOIs0xYHjJPPw= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1742417986; c=relaxed/simple; bh=gnwvgtMN52Pwrzg0aedlK+V9BrQs7Wx7efOOAr2gKvM=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=ZBtyb2R0sA/pnsKkKAldw4ETMybm/qeZS1I5sXSYN2+bPMlW88zIPqqy6BaZOGNkEYNbQZjBl6p0tQ5iaOUfNm1qziX3GFPWRCHqPQ7UrpQ5YWRaEJdtyIZbTuEJGaEDJ7pcX77bNTnK+1u+whK/wvsJGIo1nWkKmrNdeZS+6wY= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=pixjo4KT; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="pixjo4KT" Received: by smtp.kernel.org (Postfix) with ESMTPS id 9D0DFC4CEFC; Wed, 19 Mar 2025 20:59:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1742417985; bh=gnwvgtMN52Pwrzg0aedlK+V9BrQs7Wx7efOOAr2gKvM=; h=From:Date:Subject:References:In-Reply-To:To:Cc:Reply-To:From; b=pixjo4KTEufcmpXB6JwW9OPQly0GJXLmAKRbZxCIm9yRUfCotbNW9ig4yRAVV9ydW slozjkw9EiS89dSAJxpb1F5C6nPdTTIsopTyPhnWh+WBnyT+VFMQG/0RYDNrgNNwMw V1vwv9l9GwvJaUAgHwtXnFcyZLEif5ESdLmBsgq17K2hwe2gcnTDKzCKlTjpp6enBA vN1J3ai0fcQKYsvECXJ1T5jIWo2j8jn+316D13TgXtRlbD5YXZLijzA1bbwGZzEvvu VNP/goh8DSgpQqd4f/liKfjw3vPFz4add9U2HN93o5t/KbE9Kysa0oOGzUBBjfptP9 Nrgnc897mQIlg== Received: from aws-us-west-2-korg-lkml-1.web.codeaurora.org (localhost.localdomain [127.0.0.1]) by smtp.lore.kernel.org (Postfix) with ESMTP id 94560C36001; Wed, 19 Mar 2025 20:59:45 +0000 (UTC) Date: Wed, 19 Mar 2025 21:59:50 +0100 Subject: [PATCH v2 11/13] iio: light: al3320a: Improve error handling with dev_err_probe Precedence: bulk X-Mailing-List: linux-iio@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-Id: <20250319-al3010-iio-regmap-v2-11-1310729d0543@ixit.cz> References: <20250319-al3010-iio-regmap-v2-0-1310729d0543@ixit.cz> In-Reply-To: <20250319-al3010-iio-regmap-v2-0-1310729d0543@ixit.cz> To: Jonathan Cameron , Lars-Peter Clausen Cc: Svyatoslav Ryhel , Robert Eckelmann , linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, David Heidelberg X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=986; i=david@ixit.cz; h=from:subject:message-id; bh=ZDkoBVIulq1cvMnCXDseiCDdnOJkjxiu1pAE5heNCiI=; b=owEBbQKS/ZANAwAIAWACP8TTSSByAcsmYgBn2zA+9HVHS3Gw6TUynM2zoj665kSVRiBUCkb9H ihXRUBd0keJAjMEAAEIAB0WIQTXegnP7twrvVOnBHRgAj/E00kgcgUCZ9swPgAKCRBgAj/E00kg cqWNEADLu6eFtloKSuyFWtEppBrRsu1TKUXzpTfpo/P9eGjGYtMmCY0Jvm8naaouakGmp+nQkqa lzw0DvPSztb4ztCj69KIRtOufEq1grItt1iH15FENy8c1a8UK4r9MDAoeFWz3/XlgTHIyFvtm9g SDA269/5WKaOMn2Key85mDl8oED1heoTyjHsQC5SnAs/auP38xZakWlTDPEFrAjGluUpV9Gxi65 9bAXXb2V98w6s+VvsQ45Lo5j38XglCvnslweAjfdyH6iqOEHqzKDtqASNlzLoEmX46AlYDMjKTe 1V63VCeYVjifmVlC6nR+lkT5FXgW2tR8rgWqilsqieFxbpuqz2ny+KHgLPcQjaFU6UQqJnfKuGq bYWafQz3UCMpYZ/n5N9xEFelOnfIeBsHBXkV6vs2mT3dMCBHQ1IP8byxt34xelrKjHarDHPGPmi Wv0zr8Qz/Q7nhj3TtjyG+CiYamj1MIO93igJ2W8PWLC+WFPMGN4ujaq64jNAk0VYGDRgcTMlDJm xSUbtAVvJV+p6JGqrxuQflqdLFLLa8H0bIc/LGJBCqxllMcVhv/9q8NKbEDFJOOMQvKqkfWWYO3 PJQHj4QJZjmN4yUbkwRparMw8qhksECejnPDuCp6z9CVsWZCPFj8YfjtSRhpaMM7j/Xios2QfHb 0dwlvYQo9SuSueg== X-Developer-Key: i=david@ixit.cz; a=openpgp; fpr=D77A09CFEEDC2BBD53A7047460023FC4D3492072 X-Endpoint-Received: by B4 Relay for david@ixit.cz/default with auth_id=355 X-Original-From: David Heidelberg Reply-To: david@ixit.cz From: David Heidelberg From: David Heidelberg Slight simplification of the code. Signed-off-by: David Heidelberg --- drivers/iio/light/al3320a.c | 10 ++++------ 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/drivers/iio/light/al3320a.c b/drivers/iio/light/al3320a.c index 1b2b0359ed5dad5e00d2fe584f8f3495c13c997e..1943e6f34a70b00b5d732dbf4ae6ccb4376303b7 100644 --- a/drivers/iio/light/al3320a.c +++ b/drivers/iio/light/al3320a.c @@ -206,14 +206,12 @@ static int al3320a_probe(struct i2c_client *client) indio_dev->modes = INDIO_DIRECT_MODE; ret = al3320a_init(data); - if (ret < 0) { - dev_err(dev, "al3320a chip init failed\n"); - return ret; - } + if (ret) + return dev_err_probe(dev, ret, "failed to init ALS\n"); ret = devm_add_action_or_reset(dev, al3320a_set_pwr_off, data); - if (ret < 0) - return ret; + if (ret) + return dev_err_probe(dev, ret, "failed to add action\n"); return devm_iio_device_register(dev, indio_dev); } From patchwork Wed Mar 19 20:59:51 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: David Heidelberg X-Patchwork-Id: 14023112 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EC9EA2153FC; Wed, 19 Mar 2025 20:59:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1742417986; cv=none; b=g1oONO5oByQ048j+UMXpy4h6Q9DuuteCjC/nluF7gm244X4WVhCiBtDpF5O28h+pc+VHvcbI2PHpGDkinN4FhkFZCKs5VoiMcb9H/ear+8mRiYv2+C+dNz/rHHqgkBVvjgNQ6g/zMgk2JK7NuemMzqGUXLcIji+cP7lyMp42qJw= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1742417986; c=relaxed/simple; bh=IGkg4ybk/fFAAJaDocAv5wPTYmjsGrL/ufyf1jfMDio=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=ledt3jyi6gbLe/3FM7FViuksE2RQLbxQs27KUlLV0TAMyhrI7Tli+xkvdhsmfRj6ExBxtFNVDMFGBrTka+vOpWZxAb4cxHrwRaVV/7DGKAcrHezCpxBa5N7ngEzK0X2gXsgQqR36OdannSAQfe4ZulN9IdBwiijl14p7A7Izcrk= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=bFIaRP/m; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="bFIaRP/m" Received: by smtp.kernel.org (Postfix) with ESMTPS id AB0D9C4CEFE; Wed, 19 Mar 2025 20:59:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1742417985; bh=IGkg4ybk/fFAAJaDocAv5wPTYmjsGrL/ufyf1jfMDio=; h=From:Date:Subject:References:In-Reply-To:To:Cc:Reply-To:From; b=bFIaRP/maoKhPB4AzcxGkefv3fKrgz7hDKK0vB2W91+O8j6wwO0Fx19FPGsClfhVk 59fV/BHZZa584Gt6kdOZfBFUWxzaUt8jX4kmN2D0sb3yfVlIxzAwTbSob9O2IiYW75 TB8QhyWFHLjjDB4Vm35O1NgdWCH+UWa8sn7huO+tLqt1XvppEoaJuYxyVSsj3Mx4vo PKE3vSRSo1U4LnOpzh2yvx4RMFS8PHF2Rdr7OVz4TyxXGgbiohy7F0KkQavwR/vRyv g5Q0u12lMHZhOEKVJHj42JFiSn5B0mp6WUCs41EPQqkAIyW13hvTsDNeGBIQZy+Jh/ HpCZUdhxINEHg== Received: from aws-us-west-2-korg-lkml-1.web.codeaurora.org (localhost.localdomain [127.0.0.1]) by smtp.lore.kernel.org (Postfix) with ESMTP id A1DB1C36000; Wed, 19 Mar 2025 20:59:45 +0000 (UTC) Date: Wed, 19 Mar 2025 21:59:51 +0100 Subject: [PATCH v2 12/13] iio: light: al3010: Implement regmap support Precedence: bulk X-Mailing-List: linux-iio@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-Id: <20250319-al3010-iio-regmap-v2-12-1310729d0543@ixit.cz> References: <20250319-al3010-iio-regmap-v2-0-1310729d0543@ixit.cz> In-Reply-To: <20250319-al3010-iio-regmap-v2-0-1310729d0543@ixit.cz> To: Jonathan Cameron , Lars-Peter Clausen Cc: Svyatoslav Ryhel , Robert Eckelmann , linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, David Heidelberg X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=4984; i=david@ixit.cz; h=from:subject:message-id; bh=si5i/P1Y4ZQEes9Htrsr4D8xcLlkLp6GlW5byhVEUIE=; b=owEBbQKS/ZANAwAIAWACP8TTSSByAcsmYgBn2zA+qJJaVc2brmiCAtLHdeOmMKYWWqoS1BKoN K5dgXgAVU6JAjMEAAEIAB0WIQTXegnP7twrvVOnBHRgAj/E00kgcgUCZ9swPgAKCRBgAj/E00kg cnubD/9t4zOwfIXNrdNxXqi/xfxbkZh2H2KzL7Lmcz0pfAelXcPo1Fx8LG1rFpkw8+oCa/JVkLy lNUBQH5mntARqP52dFutobvYv5fNYA5LgP9uu0l8l86ostuKUyQpY5Np/bhFP55w3vWxfpI1Fn4 f/fBhY1Wk8u9kRDeXirh5y1Cdt8JWC37w4xZ1eLPhb+h8ZLNbB6fMesACDW/yOkQ3OYLC+QAKY/ RDqsXW7/nOaWnHImK6fMNl/6NYSSc4vxykhfgF0e0SCv+e/eFUOE78P+JWzSuJ8QBpgpBMn4tvR sUh/pPfeEwxPr+GHQNF79Njym4QeorNWZhZlbgo7co9C2okenoC5uOg4KTgVujilmslKGYc+z1i /aargYf7Vx0bBkBNh/owhQ3v12ksrU4nexcxl3nQElgODEspetNmyQiZG12Dpl6/8ekmitEd4wW iir1miFaW/NMObiEEJn8Eyb5+hmPDEp+wEoD3II5BvgYGFRz0a10aZG7tHPd1v6UOc3fMmLHc0x wkdm5vXK73/S/i0oQtRncqrOJ/WRG/2BvIOA2lB5pwQS8nNx7IouFeVebAqW7fIliLbSaUrR2/0 NFxdKxbudoNRJj7pGAnuPumJ17KAGLglIRntXI5yHlf2nSpKSIW2GuU6F731kkYnp+gjObNUcF2 obIZjyUH9GReFgg== X-Developer-Key: i=david@ixit.cz; a=openpgp; fpr=D77A09CFEEDC2BBD53A7047460023FC4D3492072 X-Endpoint-Received: by B4 Relay for david@ixit.cz/default with auth_id=355 X-Original-From: David Heidelberg Reply-To: david@ixit.cz From: David Heidelberg From: David Heidelberg Modernize and make driver a bit cleaner. After the regmap implementation, the compiler is able to produce much smaller module. Size before: 72 kB Size after: 58 kB Signed-off-by: David Heidelberg --- drivers/iio/light/al3010.c | 70 ++++++++++++++++++++++++++-------------------- 1 file changed, 39 insertions(+), 31 deletions(-) diff --git a/drivers/iio/light/al3010.c b/drivers/iio/light/al3010.c index af7ed028259837f2232f30072b87cc0da7c77f37..04d9d49ef20930f47b642ef118514be6e016368a 100644 --- a/drivers/iio/light/al3010.c +++ b/drivers/iio/light/al3010.c @@ -17,6 +17,7 @@ #include #include #include +#include #include #include @@ -44,8 +45,14 @@ static const int al3010_scales[][2] = { {0, 1187200}, {0, 296800}, {0, 74200}, {0, 18600} }; +static const struct regmap_config al3010_regmap_config = { + .reg_bits = 8, + .val_bits = 8, + .max_register = AL3010_REG_CONFIG, +}; + struct al3010_data { - struct i2c_client *client; + struct regmap *regmap; }; static const struct iio_chan_spec al3010_channels[] = { @@ -67,35 +74,32 @@ static const struct attribute_group al3010_attribute_group = { .attrs = al3010_attributes, }; -static int al3010_set_pwr_on(struct i2c_client *client) +static int al3010_set_pwr_on(struct al3010_data *data) { - return i2c_smbus_write_byte_data(client, AL3010_REG_SYSTEM, - AL3010_CONFIG_ENABLE); + return regmap_write(data->regmap, AL3010_REG_SYSTEM, AL3010_CONFIG_ENABLE); } static void al3010_set_pwr_off(void *_data) { struct al3010_data *data = _data; + struct device *dev = regmap_get_device(data->regmap); + int ret; - i2c_smbus_write_byte_data(data->client, AL3010_REG_SYSTEM, - AL3010_CONFIG_DISABLE); + ret = regmap_write(data->regmap, AL3010_REG_SYSTEM, AL3010_CONFIG_DISABLE); + if (ret) + dev_err(dev, "failed to write system register\n"); } static int al3010_init(struct al3010_data *data) { int ret; - ret = al3010_set_pwr_on(data->client); - if (ret < 0) - return ret; - - ret = i2c_smbus_write_byte_data(data->client, AL3010_REG_CONFIG, - FIELD_PREP(AL3010_GAIN_MASK, - AL3XXX_RANGE_3)); - if (ret < 0) + ret = al3010_set_pwr_on(data); + if (ret) return ret; - return 0; + return regmap_write(data->regmap, AL3010_REG_CONFIG, + FIELD_PREP(AL3010_GAIN_MASK, AL3XXX_RANGE_3)); } static int al3010_read_raw(struct iio_dev *indio_dev, @@ -103,7 +107,7 @@ static int al3010_read_raw(struct iio_dev *indio_dev, int *val2, long mask) { struct al3010_data *data = iio_priv(indio_dev); - int ret; + int ret, gain, raw; switch (mask) { case IIO_CHAN_INFO_RAW: @@ -112,21 +116,21 @@ static int al3010_read_raw(struct iio_dev *indio_dev, * - low byte of output is stored at AL3010_REG_DATA_LOW * - high byte of output is stored at AL3010_REG_DATA_LOW + 1 */ - ret = i2c_smbus_read_word_data(data->client, - AL3010_REG_DATA_LOW); - if (ret < 0) + ret = regmap_read(data->regmap, AL3010_REG_DATA_LOW, &raw); + if (ret) return ret; - *val = ret; + + *val = raw; + return IIO_VAL_INT; case IIO_CHAN_INFO_SCALE: - ret = i2c_smbus_read_byte_data(data->client, - AL3010_REG_CONFIG); - if (ret < 0) + ret = regmap_read(data->regmap, AL3010_REG_CONFIG, &gain); + if (ret) return ret; - ret = FIELD_GET(AL3010_GAIN_MASK, ret); - *val = al3010_scales[ret][0]; - *val2 = al3010_scales[ret][1]; + gain = FIELD_GET(AL3010_GAIN_MASK, gain); + *val = al3010_scales[gain][0]; + *val2 = al3010_scales[gain][1]; return IIO_VAL_INT_PLUS_MICRO; } @@ -147,9 +151,8 @@ static int al3010_write_raw(struct iio_dev *indio_dev, val2 != al3010_scales[i][1]) continue; - return i2c_smbus_write_byte_data(data->client, - AL3010_REG_CONFIG, - FIELD_PREP(AL3010_GAIN_MASK, i)); + return regmap_write(data->regmap, AL3010_REG_CONFIG, + FIELD_PREP(AL3010_GAIN_MASK, i)); } break; } @@ -175,7 +178,10 @@ static int al3010_probe(struct i2c_client *client) data = iio_priv(indio_dev); i2c_set_clientdata(client, indio_dev); - data->client = client; + data->regmap = devm_regmap_init_i2c(client, &al3010_regmap_config); + if (IS_ERR(data->regmap)) + return dev_err_probe(dev, PTR_ERR(data->regmap), + "cannot allocate regmap\n"); indio_dev->info = &al3010_info; indio_dev->name = "al3010"; @@ -204,7 +210,9 @@ static int al3010_suspend(struct device *dev) static int al3010_resume(struct device *dev) { - return al3010_set_pwr_on(to_i2c_client(dev)); + struct al3010_data *data = iio_priv(dev_get_drvdata(dev)); + + return al3010_set_pwr_on(data); } static DEFINE_SIMPLE_DEV_PM_OPS(al3010_pm_ops, al3010_suspend, al3010_resume); From patchwork Wed Mar 19 20:59:52 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: David Heidelberg X-Patchwork-Id: 14023113 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 00F5B215792; Wed, 19 Mar 2025 20:59:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1742417986; cv=none; b=IYrJvFG8wdSn9OmMa3GHi6QeRPu1sthMcHmM0DVx5MNsIDrYF/GXhV96BYUPsBsegKjFjpjdlQ87Eohqqxb7R+IsgFYEn+67pRCUHNN7sFRreePOHHS9J+whHIFt0Rw+Mp25Dym0aO/YUEEml2WlNTbwkMVvwArVm6cTfgjHTZE= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1742417986; c=relaxed/simple; bh=HlqGSpQH8OKsmLbqZc6BB4OlujKzK+8Vy2q3EvYfcic=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=cV12weSEHfJNNTTd4GT9uQMrYhot+CwSdMkREP5mUz86wuT90I35D0SHqPvz5mpfxtIKKxNwYYlVU+AQmJ16INSNTlz/W4kvPrB3O+DscRYKtuBAbz8NEr7noPbGa81tqf5k2vDTdwJt3TSwMAuvANlsYGCGBPgljOAIqZYCPj4= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=UAg8szp0; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="UAg8szp0" Received: by smtp.kernel.org (Postfix) with ESMTPS id B9ECDC4CEFF; Wed, 19 Mar 2025 20:59:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1742417985; bh=HlqGSpQH8OKsmLbqZc6BB4OlujKzK+8Vy2q3EvYfcic=; h=From:Date:Subject:References:In-Reply-To:To:Cc:Reply-To:From; b=UAg8szp0Yj6j0B1RM1vDs3/LykoppwNLG21/hY9j0wBMJtgoFu7kcGxw0ZWnh+Hr/ HYVB57AVa5dw+7E6qBZfVqJDVIK1b2hTqutp5z3GbtUUSd6JTidtztWza+Z1CWCd8v eouaNFQVrAcbcJXcBhzrn2YiRCvrbtxPa4MxLbPgZg/OAGgMYCIHtrs9fnYkI22ynU 19GqcogaZHgOMmxhkDA2WHkXgawVTNJVYzYLJpIJpYlHjsll6u38H6xrPpsyvC3bE6 F27Ccfezksy7t89CRpet6a377A6FQXBqeQo9Epq8SBuJTsxL7BhQe/YNg7Q75lrBXs b5b/VOI+G8JBA== Received: from aws-us-west-2-korg-lkml-1.web.codeaurora.org (localhost.localdomain [127.0.0.1]) by smtp.lore.kernel.org (Postfix) with ESMTP id B0FB7C35FFA; Wed, 19 Mar 2025 20:59:45 +0000 (UTC) Date: Wed, 19 Mar 2025 21:59:52 +0100 Subject: [PATCH v2 13/13] iio: light: al3320a: Implement regmap support Precedence: bulk X-Mailing-List: linux-iio@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-Id: <20250319-al3010-iio-regmap-v2-13-1310729d0543@ixit.cz> References: <20250319-al3010-iio-regmap-v2-0-1310729d0543@ixit.cz> In-Reply-To: <20250319-al3010-iio-regmap-v2-0-1310729d0543@ixit.cz> To: Jonathan Cameron , Lars-Peter Clausen Cc: Svyatoslav Ryhel , Robert Eckelmann , linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, David Heidelberg X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=5559; i=david@ixit.cz; h=from:subject:message-id; bh=bnMzXmnoT68yZfBO8ZVJqfaFZx4Hg8RoMkkxAEWajno=; b=owEBbQKS/ZANAwAIAWACP8TTSSByAcsmYgBn2zA+aaQy4IJXR6bGl8obK0Hj1/nZ+/reD0Ilu 01/9BrmahOJAjMEAAEIAB0WIQTXegnP7twrvVOnBHRgAj/E00kgcgUCZ9swPgAKCRBgAj/E00kg cjI7EACs3xekAQOLmIXXZwlMeXBMghSmyBpQx/e1qzrkgVc+xbJ5JOVgamKIkD8WGJG+0CDhN7A Qyr3ur6KBOvEkLkoJWW0oyv54k6CIWGhcYNLPQBh1TBEiByIavO30hdM1cFbE68pDCFSzdoOFco 6jeczP3Zenopo8HL//LyZJ+wWcqpyHj42MWe1czChocgBY+oY4oLuPP7Tkm7wY+AtLuxnir3K4l qZ1hpMLfQFVAmcXipxwx2RQqajGvL+l5Z8p+jiqDnKhfkfi/8TLm6M7z8mzB2IBB/wvCIH9QSWD afuvvjSXpC4+A2tI1CbOv56WB/xK9IPsLGvmqmhyqqI7JIQfoDmTlJmk3v8VcWSMEwnstr5EWxj qiXro/a+qedPecj8XsVzAY6QLkBt00/Gh+gDzElgCUaS74pLkiBPIwaYjuNxQtEzU/YgY4PoATx sSsQ6Gce7w3xb3OIsoyTkUZOrp57tzc4SK+yjreZyLhnZALLXMt3ER1Z18XAGEHY2uz0gDzS87z LtEVBRL77YDiMlkieqY/3Az4YaX9wCFkhIvyVvhpTP/A47DA18pCmWNt8AWnFUz6EgbI0SUHaui SiCRVqt4qQFGNezxYQ2nkxDStuSpyu0MDdtGKxJD6JiU1/d86p1+e5vibH/zuDeaVdqXZBawGg9 5LulEQf5/vR3s2g== X-Developer-Key: i=david@ixit.cz; a=openpgp; fpr=D77A09CFEEDC2BBD53A7047460023FC4D3492072 X-Endpoint-Received: by B4 Relay for david@ixit.cz/default with auth_id=355 X-Original-From: David Heidelberg Reply-To: david@ixit.cz From: David Heidelberg From: David Heidelberg Modernize and make driver a bit cleaner. After the regmap implementation, the compiler is able to produce much smaller module. Size before: 72 kB Size after: 58 kB Signed-off-by: David Heidelberg --- drivers/iio/light/al3320a.c | 82 +++++++++++++++++++++++++-------------------- 1 file changed, 46 insertions(+), 36 deletions(-) diff --git a/drivers/iio/light/al3320a.c b/drivers/iio/light/al3320a.c index 1943e6f34a70b00b5d732dbf4ae6ccb4376303b7..dc9534195e1db9366a5307b84eeab96b99f16b96 100644 --- a/drivers/iio/light/al3320a.c +++ b/drivers/iio/light/al3320a.c @@ -15,6 +15,7 @@ #include #include #include +#include #include #include @@ -57,8 +58,14 @@ static const int al3320a_scales[][2] = { {0, 512000}, {0, 128000}, {0, 32000}, {0, 10000} }; +static const struct regmap_config al3320a_regmap_config = { + .reg_bits = 8, + .val_bits = 8, + .max_register = AL3320A_REG_HIGH_THRESH_HIGH, +}; + struct al3320a_data { - struct i2c_client *client; + struct regmap *regmap; }; static const struct iio_chan_spec al3320a_channels[] = { @@ -80,44 +87,42 @@ static const struct attribute_group al3320a_attribute_group = { .attrs = al3320a_attributes, }; -static int al3320a_set_pwr_on(struct i2c_client *client) +static int al3320a_set_pwr_on(struct al3320a_data *data) { - return i2c_smbus_write_byte_data(client, AL3320A_REG_CONFIG, AL3320A_CONFIG_ENABLE); + return regmap_write(data->regmap, AL3320A_REG_CONFIG, AL3320A_CONFIG_ENABLE); } static void al3320a_set_pwr_off(void *_data) { struct al3320a_data *data = _data; + struct device *dev = regmap_get_device(data->regmap); + int ret; - i2c_smbus_write_byte_data(data->client, AL3320A_REG_CONFIG, AL3320A_CONFIG_DISABLE); + ret = regmap_write(data->regmap, AL3320A_REG_CONFIG, AL3320A_CONFIG_DISABLE); + if (ret) + dev_err(dev, "failed to write system register\n"); } static int al3320a_init(struct al3320a_data *data) { int ret; - ret = al3320a_set_pwr_on(data->client); - - if (ret < 0) - return ret; - - ret = i2c_smbus_write_byte_data(data->client, AL3320A_REG_CONFIG_RANGE, - FIELD_PREP(AL3320A_GAIN_MASK, - AL3320A_RANGE_3)); - if (ret < 0) + ret = al3320a_set_pwr_on(data); + if (ret) return ret; - ret = i2c_smbus_write_byte_data(data->client, AL3320A_REG_MEAN_TIME, - AL3320A_DEFAULT_MEAN_TIME); - if (ret < 0) + ret = regmap_write(data->regmap, AL3320A_REG_CONFIG_RANGE, + FIELD_PREP(AL3320A_GAIN_MASK, AL3320A_RANGE_3)); + if (ret) return ret; - ret = i2c_smbus_write_byte_data(data->client, AL3320A_REG_WAIT, - AL3320A_DEFAULT_WAIT_TIME); - if (ret < 0) + ret = regmap_write(data->regmap, AL3320A_REG_MEAN_TIME, + AL3320A_DEFAULT_MEAN_TIME); + if (ret) return ret; - return 0; + return regmap_write(data->regmap, AL3320A_REG_WAIT, + AL3320A_DEFAULT_WAIT_TIME); } static int al3320a_read_raw(struct iio_dev *indio_dev, @@ -125,7 +130,7 @@ static int al3320a_read_raw(struct iio_dev *indio_dev, int *val2, long mask) { struct al3320a_data *data = iio_priv(indio_dev); - int ret; + int ret, gain, raw; switch (mask) { case IIO_CHAN_INFO_RAW: @@ -134,21 +139,21 @@ static int al3320a_read_raw(struct iio_dev *indio_dev, * - low byte of output is stored at AL3320A_REG_DATA_LOW * - high byte of output is stored at AL3320A_REG_DATA_LOW + 1 */ - ret = i2c_smbus_read_word_data(data->client, - AL3320A_REG_DATA_LOW); - if (ret < 0) + ret = regmap_read(data->regmap, AL3320A_REG_DATA_LOW, &raw); + if (ret) return ret; - *val = ret; + + *val = raw; + return IIO_VAL_INT; case IIO_CHAN_INFO_SCALE: - ret = i2c_smbus_read_byte_data(data->client, - AL3320A_REG_CONFIG_RANGE); - if (ret < 0) + ret = regmap_read(data->regmap, AL3320A_REG_CONFIG_RANGE, &gain); + if (ret) return ret; - ret = FIELD_GET(AL3320A_GAIN_MASK, ret); - *val = al3320a_scales[ret][0]; - *val2 = al3320a_scales[ret][1]; + gain = FIELD_GET(AL3320A_GAIN_MASK, gain); + *val = al3320a_scales[gain][0]; + *val2 = al3320a_scales[gain][1]; return IIO_VAL_INT_PLUS_MICRO; } @@ -169,9 +174,8 @@ static int al3320a_write_raw(struct iio_dev *indio_dev, val2 != al3320a_scales[i][1]) continue; - return i2c_smbus_write_byte_data(data->client, - AL3320A_REG_CONFIG_RANGE, - FIELD_PREP(AL3320A_GAIN_MASK, i)); + return regmap_write(data->regmap, AL3320A_REG_CONFIG_RANGE, + FIELD_PREP(AL3320A_GAIN_MASK, i)); } break; } @@ -197,7 +201,11 @@ static int al3320a_probe(struct i2c_client *client) data = iio_priv(indio_dev); i2c_set_clientdata(client, indio_dev); - data->client = client; + + data->regmap = devm_regmap_init_i2c(client, &al3320a_regmap_config); + if (IS_ERR(data->regmap)) + return dev_err_probe(dev, PTR_ERR(data->regmap), + "cannot allocate regmap\n"); indio_dev->info = &al3320a_info; indio_dev->name = "al3320a"; @@ -226,7 +234,9 @@ static int al3320a_suspend(struct device *dev) static int al3320a_resume(struct device *dev) { - return al3320a_set_pwr_on(to_i2c_client(dev)); + struct al3320a_data *data = iio_priv(dev_get_drvdata(dev)); + + return al3320a_set_pwr_on(data); } static DEFINE_SIMPLE_DEV_PM_OPS(al3320a_pm_ops, al3320a_suspend,