From patchwork Fri Mar 21 06:40:11 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ye Liu X-Patchwork-Id: 14024889 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id BCB78C35FFF for ; Fri, 21 Mar 2025 06:40:26 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 7DC45280002; Fri, 21 Mar 2025 02:40:25 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 78C92280001; Fri, 21 Mar 2025 02:40:25 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 67B0A280002; Fri, 21 Mar 2025 02:40:25 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 4DBBB280001 for ; Fri, 21 Mar 2025 02:40:25 -0400 (EDT) Received: from smtpin22.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 3BC9FAC6A2 for ; Fri, 21 Mar 2025 06:40:25 +0000 (UTC) X-FDA: 83244609210.22.78ABE0F Received: from out-189.mta1.migadu.com (out-189.mta1.migadu.com [95.215.58.189]) by imf06.hostedemail.com (Postfix) with ESMTP id 877A6180003 for ; Fri, 21 Mar 2025 06:40:23 +0000 (UTC) Authentication-Results: imf06.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=bQ0HJL6l; dmarc=pass (policy=none) header.from=linux.dev; spf=pass (imf06.hostedemail.com: domain of ye.liu@linux.dev designates 95.215.58.189 as permitted sender) smtp.mailfrom=ye.liu@linux.dev ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1742539223; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:references:dkim-signature; bh=wfCxnUDZ4/a0LOQ7Hfhp9OJ19Sm5M7MD6UuIrGvTujE=; b=04eDlYwrwVoSlN8L7URdAeCZ3fDnOwwKrVDCUP8NoU+CIP3GzunIfCqfd7PZA+0H/DgTVc Z09Jj+SRhLX/5TiP7+ktvxE5ljRruJYdok9PMf9w9zx1bnagFXCYc6065Q0D3ciBVoZnR9 UV8RcKh85pNHexT0a4K5QCNC3syc1PI= ARC-Authentication-Results: i=1; imf06.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=bQ0HJL6l; dmarc=pass (policy=none) header.from=linux.dev; spf=pass (imf06.hostedemail.com: domain of ye.liu@linux.dev designates 95.215.58.189 as permitted sender) smtp.mailfrom=ye.liu@linux.dev ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1742539223; a=rsa-sha256; cv=none; b=TErqWBiO3uVsR7VxFq+lFDHu2dY6oYc8RaNaDOrScYVaCdMQLDVeK07rX2uvH/q5XFZ1/O bsVdvWiUx15rIiK9IErI13kM+KXudmkU+gVwvxwAsw5r+LgXbwyINKNnAv9DbfryP02cfq IrZ3UNSGsyK7gwNDhDOvBpQw/ZLybrs= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1742539221; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=wfCxnUDZ4/a0LOQ7Hfhp9OJ19Sm5M7MD6UuIrGvTujE=; b=bQ0HJL6lWhxf0MXlS5Sc2TmSh9daaF0DUMA76BE77ARg2roC+WQEGTAC7x7yYuoyhVSy1s jpjLZwq6AZ9yOV0A5XZOxyZhHoJ/FC44KE8lzZai9RHbw79zSWr8XosyGvmHj+dm6z6BC4 g4fngpFJeObDWDcRbin6VTHgpLB8Ps4= From: Ye Liu To: akpm@linux-foundation.org Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, Ye Liu , Anshuman Khandual Subject: [PATCH v2] mm/page_alloc: Simplify free_page_is_bad by removing free_page_is_bad_report Date: Fri, 21 Mar 2025 14:40:11 +0800 Message-Id: <20250321064011.612336-1-ye.liu@linux.dev> MIME-Version: 1.0 X-Migadu-Flow: FLOW_OUT X-Rspamd-Server: rspam01 X-Stat-Signature: u7xcaya7a9zn87th3pwa9kyird18btnp X-Rspam-User: X-Rspamd-Queue-Id: 877A6180003 X-HE-Tag: 1742539223-499465 X-HE-Meta: U2FsdGVkX18Mo7FmEzzHR4dryi4ZA7vqxx+6iCGSGn8F0To4rCio3b0d3r039VIpotVY3hF21Nkl46LwBvb1ttJtrcVGXLlOURWaZweeL77dOmp3Ke2KNADmiqRvUSOCa8+QfeKUXjsTMFe8h0/mk91L+e098Eng4VCQ4KgAkP2dS4+TmltAds3xaSIAo9hr05T43QX2L2OF+oi24/HJHPU1GlYm0m+q8gZDitbwAfm3l8kBaegaYtlVrFELDUmXxYIXpdF3eA1OrWFLRsvtANUcOaoeag4qQMlotqFF/yPaf1jqIlAy6SI0Hh0PL95oCwSjCBF0Eo58hN17NambKCVgQruFriVyEKtXUIYVXgUVPXfF6jztzUWpc8T748iQkMMMe7iUVD30IJTcK5TqB6/MV+pxC+dqmEZ2DDlivFA4FGUfhJng6Lr4nuNGaOfdq25fb+gYZU/5k8FrTl4N0zpvpeKAWMka9f6P2xzdK0WkrIrD6oJ7b9ERcEYXiiLt5xp3c/mDBDquIADj4SfSDrZm0Yju67rtAuIjvFXqufV29XZ0sHVOH45YrHi3mN4P8LaT8B07JsPNrKOREm5mCm7OLZj/oqrwnuuejAb4MjIQesoIJFsQR6As5x/e6ORzldhY/d4Pdu1JGcDmdKyAqTFq+cEO0QvAp86nOJvaTiiJjdrnL6xinzifV4CBsTr8LXsXsWsP5J51x87oOK+p1sylHdNK+2jPT9HJkU7jXaM+Q1V5aRFWX8719L6Ayi9oq7ryN6kFV+77o2PXC0W/kJ8+SAvO3gwn9kF3ze6ire2n7eIIFBapMA5c/TrK1gqc/p6RYiSpI07UjzUwbW0cE+YtATrtHNcVgFExeym8tfsgvp9SwRYfLigMJmC2rk/vnhy00b0HPcslDOuzc6wkAJXD9tuyiZ2zrIG7JfjQj28/+Bs+v1PuC1gpI+/Fe7Xy72xSQn7dDtVoptTeQjo e7097+AX DGR5VtGJlnQXmO8HD1igwxz2oqnUcYn5omCclv8d9AcsT9vLj3BZ1VBFcgLQU41gbpdifEBnzV50/86hpbDkSVW5FccAvHusQXT19lp6G+DpOMFlKhPg3SNPZS0q554heqzrKd4e1Q6UVnCNsZywgC+Ol990rjN640tuN/vQh2C2okchepdnK71Z55PfJN25zFSo58EBX1tngPMLfscuZZRZ4p+VL8R+RGnmufAQgCXF9mCHl3gaemKQXNSePslnQ/+fMiMJfEqv2bQC63dJ0JrjWTQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: From: Ye Liu This patch refactors the free_page_is_bad function by directly calling bad_page() instead of using the intermediary function free_page_is_bad_report(). The removal of free_page_is_bad_report() reduces unnecessary indirection, making the code cleaner and easier to read. The functionality remains the same, as free_page_is_bad_report() was merely a wrapper for the bad_page() call. The patch also improves maintainability by reducing the function call depth. Signed-off-by: Ye Liu Reviewed-by: Anshuman Khandual --- V2: Simplify the code by removing unnecessary line breaks. --- --- mm/page_alloc.c | 8 +------- 1 file changed, 1 insertion(+), 7 deletions(-) diff --git a/mm/page_alloc.c b/mm/page_alloc.c index 61d6a3b1b286..60c54ba78a11 100644 --- a/mm/page_alloc.c +++ b/mm/page_alloc.c @@ -933,19 +933,13 @@ static const char *page_bad_reason(struct page *page, unsigned long flags) return bad_reason; } -static void free_page_is_bad_report(struct page *page) -{ - bad_page(page, - page_bad_reason(page, PAGE_FLAGS_CHECK_AT_FREE)); -} - static inline bool free_page_is_bad(struct page *page) { if (likely(page_expected_state(page, PAGE_FLAGS_CHECK_AT_FREE))) return false; /* Something has gone sideways, find it */ - free_page_is_bad_report(page); + bad_page(page, page_bad_reason(page, PAGE_FLAGS_CHECK_AT_FREE)); return true; }