From patchwork Fri Mar 21 14:35:35 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dan Carpenter X-Patchwork-Id: 14025557 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 48B39C36001 for ; Fri, 21 Mar 2025 14:41:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Type:MIME-Version: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References:List-Owner; bh=3PPRppdrVJ7KjI6wixZGEvPAU+S5utOovE0gqiXmI0c=; b=Av+Fpvkm4jD79zdjLq9b1c+oxH nmg3NTjRB27ne+YCrfHpILmOa7JYg0v6gxHyCKiEXpcl/24Sc1gjzK51MCPOz/6zMFeZUaxQMn8WN r2s23KORDYDDVlluLd93imso1xNHv9jk9LRAIKPIT2++0uW75Sq7X4tHVPQSVlHMDIJNB9YSrnsRs +unn5vz5Uq84EhRvM53HS2uiVQlTpPcCCGyYHEuMXMer2t53waJmZX1hejwmAPcwLNcUg8lBmn6Lg 7P2v2CXuXwvLuWB1hN7j2vGrP4T0PPNJ7G/lNSTtG0W9I9wUzVUOOAdfH71T2GQhghmNgrRsjYS9A nirFnp6g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1tvdZD-0000000F9y4-1faY; Fri, 21 Mar 2025 14:41:47 +0000 Received: from mail-wr1-x433.google.com ([2a00:1450:4864:20::433]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1tvdTI-0000000F8Oi-0caC for linux-mediatek@lists.infradead.org; Fri, 21 Mar 2025 14:35:41 +0000 Received: by mail-wr1-x433.google.com with SMTP id ffacd0b85a97d-3996af42857so2085092f8f.0 for ; Fri, 21 Mar 2025 07:35:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1742567739; x=1743172539; darn=lists.infradead.org; h=content-disposition:mime-version:message-id:subject:cc:to:from:date :from:to:cc:subject:date:message-id:reply-to; bh=3PPRppdrVJ7KjI6wixZGEvPAU+S5utOovE0gqiXmI0c=; b=Bo3W+DExYpWbfpLyc+Tz82GyVTvCLnJZbZuJKOw6A6mCOIJ9sPOIGrk6gqMVnWUPML a21DHPq6477/m145DiJeOD9mCaQvVCmDPsciQi6r36RkJUvY96tPUEO6KzjWC9rDDbT8 XXoZNIdjkwqMx/IOTceik9mZ2a9cUY4RpFJ7O7O5J/uZS17pdgtwwYEqjdiWMm8YKE7X zp4S/SFnmDoskSnVe4KctOxw0CyeM4bkCI2ZXFn6hAWInBbi+eN3791sVVKG6R8LuCne TqbbT5vd8BC+yEjYVA6K6+kgD8rnsSQeqqYTEX2KbDLr+4nFJHjD0nsoKR4MZNR5Vqll 0NjQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1742567739; x=1743172539; h=content-disposition:mime-version:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=3PPRppdrVJ7KjI6wixZGEvPAU+S5utOovE0gqiXmI0c=; b=TgJfsEUt/0HbtXzX8gWV9Ve5/4N9vVhfp6mkZ0+QEJ/QSpPeWLbiJ55x0KJF4O+c9f 5mSWtMFr6heb5/pfICOMHPFkZHAObbgoN/Uf7+6iclIbndipmlLCugxdulr1F98GZ2sO n/XiPBb940YAysmQyyc/ieZrH7j6TMJ2P3Z9xCjmRMrGZH6NDxLzL+vE3uIEIzuooXVN ZSsny5vD97wli7RoAUGXKgpmQkRz4oigrtqCvamjk7RKZRxPtTKbCHLImr4KDyYDuyEM QM6r9vfz2Z145Z+qpxgOnoRcDNxZNR5h1qbYWArtR8sUzfei5SvX9EnrLlJflTCXZaVR 2M5Q== X-Forwarded-Encrypted: i=1; AJvYcCWkDld3p/phkkiDsxhjDe1k75+a8MEz2FHe5t+DX8OE1pNEyU+P675MhvyN/9QA5xY9dHCKnnv2y+P7xaNHMQ==@lists.infradead.org X-Gm-Message-State: AOJu0YxNQDm5hJr6aA/mnHyTL8Q+iciS2ConZPCFW59ohrEfE53gHhWg xeY2SYFfp0d/oAfqt16nYe3PoHX8yHbsW3K2QBPQaAGZJlKP+KYhSzGeeUGYn5c= X-Gm-Gg: ASbGncsIdSzCXB1h1jX6rWMeCuB53HK6V9PdjaZq2zFC4TSgV8B20uuLnGhV57+et8q qZmzgUrZJlkfvwEwT7d9adD0JIZ0btYbkx20aof/ebvzIzF4wsgbBmC5a1+sVO4LjkdTip4w/il d9zKHuDFLauqlwggrtt8QFO1pZXVe8w26rGMDCLfZxT0fbZuxHh2jmYBz/zX8GS0WCYdEDckvKL IzxLK01q/42MMkOHLwGBJ8eAJoozImVBRfoz7y1JXlOdRK1BNVsxnqd0GhB8/GGafUm8PyhJfL5 6znNOf/RYR/fKlgKi0ygZg0WFeTsVPVKWxGCTLnoQZPzkeOZEA== X-Google-Smtp-Source: AGHT+IF2afE+amq9nc4FEedeUCaZRhGRjLvVfJvTuEgevNOAdUUfdZR/acRzOI2V9GG7bPnUNFsa8Q== X-Received: by 2002:a05:6000:1fa9:b0:390:e9ee:f27a with SMTP id ffacd0b85a97d-3997f93e053mr3439159f8f.28.1742567738601; Fri, 21 Mar 2025 07:35:38 -0700 (PDT) Received: from localhost ([196.207.164.177]) by smtp.gmail.com with UTF8SMTPSA id ffacd0b85a97d-3997f9b26a6sm2493540f8f.44.2025.03.21.07.35.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 21 Mar 2025 07:35:38 -0700 (PDT) Date: Fri, 21 Mar 2025 17:35:35 +0300 From: Dan Carpenter To: Shayne Chen Cc: Felix Fietkau , Lorenzo Bianconi , Ryder Lee , Sean Wang , Matthias Brugger , AngeloGioacchino Del Regno , Peter Chiu , Bo Jiao , Howard Hsu , linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, kernel-janitors@vger.kernel.org Subject: [PATCH] wifi: mt76: mt7996: remove duplicate check in mt7996_mcu_sta_mld_setup_tlv() Message-ID: MIME-Version: 1.0 Content-Disposition: inline X-Mailer: git-send-email haha only kidding X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250321_073540_189455_0C502335 X-CRM114-Status: UNSURE ( 7.21 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org The "msta_link" pointer has two NULL checks. Delete the second check. Signed-off-by: Dan Carpenter Acked-by: Lorenzo Bianconi --- drivers/net/wireless/mediatek/mt76/mt7996/mcu.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/net/wireless/mediatek/mt76/mt7996/mcu.c b/drivers/net/wireless/mediatek/mt76/mt7996/mcu.c index ddd555942c73..03539e20f5c5 100644 --- a/drivers/net/wireless/mediatek/mt76/mt7996/mcu.c +++ b/drivers/net/wireless/mediatek/mt76/mt7996/mcu.c @@ -2242,9 +2242,6 @@ mt7996_mcu_sta_mld_setup_tlv(struct mt7996_dev *dev, struct sk_buff *skb, if (!link) continue; - if (!msta_link) - continue; - mld_setup_link->wcid = cpu_to_le16(msta_link->wcid.idx); mld_setup_link->bss_idx = link->mt76.idx; mld_setup_link++;