From patchwork Sat Mar 22 02:17:08 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tamir Duberstein X-Patchwork-Id: 14026137 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 45FB3C36001 for ; Sat, 22 Mar 2025 02:17:19 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B3D86280002; Fri, 21 Mar 2025 22:17:16 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id AED2C280001; Fri, 21 Mar 2025 22:17:16 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9B614280002; Fri, 21 Mar 2025 22:17:16 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 805E2280001 for ; Fri, 21 Mar 2025 22:17:16 -0400 (EDT) Received: from smtpin14.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id E86481A0B1E for ; Sat, 22 Mar 2025 02:17:17 +0000 (UTC) X-FDA: 83247574914.14.5C42B88 Received: from mail-qt1-f176.google.com (mail-qt1-f176.google.com [209.85.160.176]) by imf13.hostedemail.com (Postfix) with ESMTP id 394A520003 for ; Sat, 22 Mar 2025 02:17:16 +0000 (UTC) Authentication-Results: imf13.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=bGxui0db; spf=pass (imf13.hostedemail.com: domain of tamird@gmail.com designates 209.85.160.176 as permitted sender) smtp.mailfrom=tamird@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1742609836; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:in-reply-to: references:dkim-signature; bh=5F/pLJt3JZA19sCPSEyxqNC6dnLnvJyR1Rh8BramFHU=; b=GD1qsatbvqviYiDBJNi5Q/aq2VW/IlQAISuj4t5o4BXB7MQs92EIoZ+jeAMVu20JklHFU1 C6f7pW7i6vP06XqgUFYy8CpuE2o0nMZ1li9m+2n1bo5gqFQ/zR6mnHqy9DGrmrwiatgqq7 dSK79+81OJbABYb5dnTTpJ+3oY3sSVs= ARC-Authentication-Results: i=1; imf13.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=bGxui0db; spf=pass (imf13.hostedemail.com: domain of tamird@gmail.com designates 209.85.160.176 as permitted sender) smtp.mailfrom=tamird@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1742609836; a=rsa-sha256; cv=none; b=GmzipzLbf0eBm9Z0fwE7mUxn2Kzs0SVuJDSL96wK3gJOgb3Aht8V1/hy972LoAQiPax5C8 CEoVeQ7NwvZXfL0HuDsDmzTRun0DNmpjb32VNCI45X42XEL7EufTIeMWiMAOW9ZH1hFgn0 9PRNhGeCWRbdSjtKWf6Lip3W+cn8HY4= Received: by mail-qt1-f176.google.com with SMTP id d75a77b69052e-4767e969b94so48659391cf.2 for ; Fri, 21 Mar 2025 19:17:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1742609835; x=1743214635; darn=kvack.org; h=cc:to:message-id:content-transfer-encoding:mime-version:subject :date:from:from:to:cc:subject:date:message-id:reply-to; bh=5F/pLJt3JZA19sCPSEyxqNC6dnLnvJyR1Rh8BramFHU=; b=bGxui0dbXNY1nQfJp6h4U7TjVrs29UCVAaSuR0FS9J7Y7sXi8x9Qi4ezaqcrr12L99 LSogi6yxL3KxzRlG7kai6VJlKKhXVIxKqes0EgClioM7gjQUSbSHCxC7GmNWvbn0fiDn 9GJRmfjvNgTCnlQ96aCT4oDUSdPBxZkS3b7FV1EaNuy6PLRhgYHSs0od91lxNc5CYoXR faENOV4ZdOqwVRtbEsyWvWI1xxUnT8NwvpufWU9umEjHgH3ByPwR3zfsyfZGtcI+2ygl ql0G2c8wGfzwfT8WlVf7ZxA5QEJ6BQBWDE4h6R9hVeAwjD6EFW2WJ0z6lpTT6VCBPmSW uWgA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1742609835; x=1743214635; h=cc:to:message-id:content-transfer-encoding:mime-version:subject :date:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=5F/pLJt3JZA19sCPSEyxqNC6dnLnvJyR1Rh8BramFHU=; b=EICZEdx6SQiY+pJadlJN/kx92WpK5rMDUzq/GmZe4aFfjI9ymWUFe/iNewW8JIHy/e agxCUDr4IhdTp0bSmKsPSHIXfluRjRAt9f1xAvNec7ReG1FR1XTKiSNiJCLx3YGZCWr5 1mT3+qTtW6KjJmUtrMaa+KjwDpJFA7KdNZgNxn/dZWl7QPx93LlklJp8TxpdqkMfcRVO JD4+E99+5ScF9hCjdR/HfgcuEZH3qBJWpxVQGU6shAIMMix1eP/NZTBGy31O+7aOiLDV l8yXD5q9fjqZ8irjcHzahm8jNMvMPf/t7PWbB+ivgLCCyCeQQtaBgN5FJ1GEN2nbGlHn wopQ== X-Forwarded-Encrypted: i=1; AJvYcCXemLbM9PPC02Ebo2v01gqZ/DUe19cQ1Qm5y0HCSR2DW9jo1uAa85kq/RrSI+aXiZ1xBt37DARWRA==@kvack.org X-Gm-Message-State: AOJu0Yw9R07RdlkLXVYXuVziu0QZ+Yao+ClS6h0MiiLqTGmjirJmxB1F y1OLJFG+osg4nvXckHu2bUwpEU/KeTnWz8B/xMg0i4FwGJyh4zRQ X-Gm-Gg: ASbGncuSH5sh6NeBLc70qIcDl7IaOJzuSIwqdy/sgseMajQrqgZ8ranvO42KBPipaI1 LQVzLR8aLrCwv02Cmrl7E61CM9Qxa6lv4pS1ezfekDbgDpZm9LBNuvN0x3SGqTgXAbuRvSYxxAr MFWI1dpq0v8W8ZQRyD/6wanMIaZAv8bjK25lwWQDc93PuAWGik5ikrn3FGZ030oNN86jhc00XgN r+pbviNVXkLkZhHXC1e1K7elp/KfSUGBURQkHNbgJ0639enoVh2ozYdufG0K2pCpX8YghtbXtsF LsYroOXEQT5karNMaVDd7f2AjdIqkSylR4ElQw9xwNZtcvfkQBYu76nXUJA5SPEZQ6uITiKo3jm pE7+6tdw= X-Google-Smtp-Source: AGHT+IFytUdCmElhe+7B2ZUaP/mpqLWoB6dC5TkFuyYHraKooqK1huwn1jqfYfHLtiEZIiqFCjuAnA== X-Received: by 2002:a05:622a:5e13:b0:476:add4:d2cf with SMTP id d75a77b69052e-4771dd89822mr88321391cf.16.1742609835298; Fri, 21 Mar 2025 19:17:15 -0700 (PDT) Received: from tamird-mac.local ([2600:4041:5be7:7c00:5ff:9758:a8dd:1917]) by smtp.gmail.com with ESMTPSA id d75a77b69052e-4771d192090sm19395131cf.46.2025.03.21.19.17.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 21 Mar 2025 19:17:14 -0700 (PDT) From: Tamir Duberstein Date: Fri, 21 Mar 2025 22:17:08 -0400 Subject: [PATCH] XArray: revert (unintentional?) behavior change MIME-Version: 1.0 Message-Id: <20250321-xarray-fix-destroy-v1-1-7154bed93e84@gmail.com> X-B4-Tracking: v=1; b=H4sIAKQd3mcC/x2MQQ5AMBAAvyJ7tklbpPiKOCwWeynZihDxd43jZ DLzQGQVjtBmDyifEmULCWyewbhSWBhlSgzOuMoUzuJFqnTjLBdOHA/dbnS+NI0hT7YeIIW7ctL /tOvf9wNL5UPMZAAAAA== X-Change-ID: 20250321-xarray-fix-destroy-274090a7a18b To: Andrew Morton , Matthew Wilcox , Stephen Rothwell Cc: linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, Tamir Duberstein X-Mailer: b4 0.15-dev X-Rspam-User: X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: 394A520003 X-Stat-Signature: 7nsgydwce9uocq8zcm6jkoofzmgmf6ix X-HE-Tag: 1742609836-556456 X-HE-Meta: U2FsdGVkX18s4F7996HyPdlj3GOoLStegQ1C6obeV+s4IMeQtSBhCcllHFH4vPc03TemcGD3yeSWL7NRpttLN7m9yOHW4AvUhFQ6dRPDCOYBHO0FEG+7wIO8YhpabdtyHTyQsZzigoDfj+eqts+7d2hW8ce+G2c2rOL5rep+zZ55DvsxCl3XsBRiJOn3vbh2Rs1cZqm8NjopBEQ48rNMLwCyE0P5XW5HwqBfhR8Ypi0uLPpw/O4sbERJ0axy936mJ92/x/xKfXGADAF0iJPTnLqbDwEU78y/9wJ3R9i27mc7zibstzNPZUUiMsVwLii2QX4FgL6etgCWOdSe73PUxNTFRmKzRabb4ecFhR+LW0Eo1J4zLV27W94yXFJKR+FUKxbmPMNxd6bb77rzhjfVTaIFcERPbB5RGdZGShCgpikh593mlVptQ+Tc0jWsm9GqT/7ON9Ll7wCU3VM3b/aB4gojqj1+sbu95Z5dZCI1eJeWI5pfjXMgKXtIqaW5DmsZwBnZO63G2ZJkADm5Bz+kDU9IWfjQvzXXPIGsaffCGyh01D3MaL18ncnG6dTdiEY7BR9Mw7KYxNoPYmcizBv5fsNyPrpZnbUYqTzgcw2huwRnYjahobZHgoZBU2RmhpcusPeIMsQphb/gERz7TMtTkK0CJcmwyhdhbmJgsNHcP1rCf1EYrah1LT6Zw0qAAr8l6SDY32c+38WDxaeVAhaYAgbN/qqhgYMYxlEYpbuI9YEjbU1wYNsk6fow/z7H/JPh+PAK4an+ourCO9hhRVkri5+dAUEs2AlvU4x0BtDg40WIoFcHKLHJlmlhCRHZdxHldNk/aYVYXwoUxpF02rEUsw4DBffcradnYR1eX2XEHo/tI2CTccdTY8+Lc8ualpABc3YCOvHU94dpykza3opXCVDg6DAE9aO7EbUUzzV1o2JhjVoLFCTc00sRAYaVPausdwhvNQGgSzHRBf3UYFP Mn9yQe7c DmsQaJwxSAcr0nzJONkUY2RYAhQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Partially revert commit 6684aba0780d ("XArray: Add extra debugging check to xas_lock and friends"), fixing test failures in check_xa_alloc. Fixes: 6684aba0780d ("XArray: Add extra debugging check to xas_lock and friends") Signed-off-by: Tamir Duberstein --- Before this change: BUG at xa_alloc_index:57 CPU: 0 UID: 0 PID: 1 Comm: swapper/0 Not tainted 6.14.0-rc7-next-20250321-00001-gf45bb5d4b2e8 #854 NONE Hardware name: linux,dummy-virt (DT) Call trace: show_stack+0x18/0x24 (C) dump_stack_lvl+0x40/0x84 dump_stack+0x18/0x24 xa_alloc_index+0x118/0x15c check_xa_alloc_1+0x114/0x6e8 check_xa_alloc+0x24/0x78 xarray_checks+0x58/0xd4 do_one_initcall+0x74/0x168 do_initcall_level+0x8c/0xac do_initcalls+0x54/0x94 do_basic_setup+0x18/0x24 kernel_init_freeable+0xb8/0x120 kernel_init+0x20/0x198 ret_from_fork+0x10/0x20 BUG at xa_alloc_index:57 CPU: 0 UID: 0 PID: 1 Comm: swapper/0 Not tainted 6.14.0-rc7-next-20250321-00001-gf45bb5d4b2e8 #854 NONE Hardware name: linux,dummy-virt (DT) Call trace: show_stack+0x18/0x24 (C) dump_stack_lvl+0x40/0x84 dump_stack+0x18/0x24 xa_alloc_index+0x118/0x15c check_xa_alloc_1+0x120/0x6e8 check_xa_alloc+0x24/0x78 xarray_checks+0x58/0xd4 do_one_initcall+0x74/0x168 do_initcall_level+0x8c/0xac do_initcalls+0x54/0x94 do_basic_setup+0x18/0x24 kernel_init_freeable+0xb8/0x120 kernel_init+0x20/0x198 ret_from_fork+0x10/0x20 BUG at xa_erase_index:62 CPU: 0 UID: 0 PID: 1 Comm: swapper/0 Not tainted 6.14.0-rc7-next-20250321-00001-gf45bb5d4b2e8 #854 NONE Hardware name: linux,dummy-virt (DT) Call trace: show_stack+0x18/0x24 (C) dump_stack_lvl+0x40/0x84 dump_stack+0x18/0x24 xa_erase_index+0xb0/0xd8 check_xa_alloc_1+0x12c/0x6e8 check_xa_alloc+0x24/0x78 xarray_checks+0x58/0xd4 do_one_initcall+0x74/0x168 do_initcall_level+0x8c/0xac do_initcalls+0x54/0x94 do_basic_setup+0x18/0x24 kernel_init_freeable+0xb8/0x120 kernel_init+0x20/0x198 ret_from_fork+0x10/0x20 BUG at xa_erase_index:62 CPU: 0 UID: 0 PID: 1 Comm: swapper/0 Not tainted 6.14.0-rc7-next-20250321-00001-gf45bb5d4b2e8 #854 NONE Hardware name: linux,dummy-virt (DT) Call trace: show_stack+0x18/0x24 (C) dump_stack_lvl+0x40/0x84 dump_stack+0x18/0x24 xa_erase_index+0xb0/0xd8 check_xa_alloc_1+0x160/0x6e8 check_xa_alloc+0x24/0x78 xarray_checks+0x58/0xd4 do_one_initcall+0x74/0x168 do_initcall_level+0x8c/0xac do_initcalls+0x54/0x94 do_basic_setup+0x18/0x24 kernel_init_freeable+0xb8/0x120 kernel_init+0x20/0x198 ret_from_fork+0x10/0x20 XArray: 6782365 of 6782369 tests passed --- lib/xarray.c | 1 + 1 file changed, 1 insertion(+) --- base-commit: 9388ec571cb1adba59d1cded2300eeb11827679c change-id: 20250321-xarray-fix-destroy-274090a7a18b Best regards, diff --git a/lib/xarray.c b/lib/xarray.c index 261814d170d8..638c4c90e5b2 100644 --- a/lib/xarray.c +++ b/lib/xarray.c @@ -2380,6 +2380,7 @@ void xa_destroy(struct xarray *xa) unsigned long flags; void *entry; + xas.xa_node = NULL; xas_lock_irqsave(&xas, flags); entry = xa_head_locked(xa); RCU_INIT_POINTER(xa->xa_head, NULL);