From patchwork Mon Mar 24 11:51:27 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Peng Fan X-Patchwork-Id: 14027136 Received: from EUR03-AM7-obe.outbound.protection.outlook.com (mail-am7eur03on2055.outbound.protection.outlook.com [40.107.105.55]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E88D325E47D; Mon, 24 Mar 2025 11:52:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.105.55 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1742817162; cv=fail; b=sHjEwIPQVonVgjEVyZ1zqdtaWhVnuF6DdDVmuHuKx2m3lepvCfn2Ppm8VYu2yURB4E0bWtf+dZAYPKLHhJht2cTG0gERvvkh4mP6cAbyfDukBMKDcCuKJAy4lF9Szn2h3Dj3ynVyvaIVtEzZzx5axWMnk2zK4jC9OihEULncKDk= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1742817162; c=relaxed/simple; bh=clBLY6CTjup4wOQ0/L626b6aymnbE1kq3ZpcfBvAZPs=; h=From:Date:Subject:Content-Type:Message-Id:References:In-Reply-To: To:Cc:MIME-Version; b=qAHi8yk2bbpBWnvTXwRfsl9FguYMEchHxqp5XIH9Lo9rMUSXfxcl0pQF5gcBuhPYPZQBSpq5ImUF4/96q/qGvgHMUqDC4aYtCFtozTqn8sale7joii0MelhwLnb/bnuL9n3z3nCgO7eHogUe5D+VzEmLdWxZraiBU7P4x1I+xwc= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=oss.nxp.com; spf=pass smtp.mailfrom=oss.nxp.com; dkim=pass (2048-bit key) header.d=NXP1.onmicrosoft.com header.i=@NXP1.onmicrosoft.com header.b=TdDvLfVd; arc=fail smtp.client-ip=40.107.105.55 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=oss.nxp.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.nxp.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=NXP1.onmicrosoft.com header.i=@NXP1.onmicrosoft.com header.b="TdDvLfVd" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=toamur910b67lVJWdRmWQsmJLEsJoeU92Vt8NIS5Kba+Uno+qh6TiljgikMZuLbYEtCGvm+n/Xa5UqByt293puGZ2PGTm0ZhINuBvyeBKahRecYW9hXEMazaJ+JAlR/hvQPfUZKYb/RC+prqTocx5wq/6myJeLatb8uOoxbC/R5dlWmPoEv5amcwiNl67XFgwpSW14bSml9PycLxkek8/iR65qSaVfvDvc+udN+NbwHddkXoJVQDsYI/2GTvggqWplWhYbT7ksKZc2JcYXcev175Ytcz80yEc/TjqxMp4xmchCKWcgSjZ7lzSUK76lDL/k77su0ksjvmH0/5xlDN3w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=FAgBNSK4ySIw3VgQKwYgVCvAqc9nYi/Toq0XR0gV2Rc=; b=I6H42Rp9dM9McFbOpug+fgt8D4q7sB4OMoJyRlebPmevrDQumQeTsDgNT7WRgKbQ0Wxd8IPQ7VFRzKPdNW7dCpOSCnI5cym3/jPzqyqeCbJagYRsOcuTh5In2Iz56FLwwSNdGAO4Q/ZJn+PfnuobuFRS7lAOqh7RQlQ3UwatE4WGk+sUfCGoWNpNdqwm5E5u/BjvNiXVQY766ffEeZuVxb2Il3tHJ8v2tNdMDEiEGC3vlkAbu3jr6R4WNcd39MZN0F64huIzq4bfwknYHK0UmWMZnMHJO5zKhWVT4wSknPjQ0D7DS0+gK2lgjLdafxQxkeeiN309+zVTGG96ozuztA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oss.nxp.com; dmarc=pass action=none header.from=oss.nxp.com; dkim=pass header.d=oss.nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=NXP1.onmicrosoft.com; s=selector1-NXP1-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=FAgBNSK4ySIw3VgQKwYgVCvAqc9nYi/Toq0XR0gV2Rc=; b=TdDvLfVdFoA0hKJraW1C8g5v6NjwrvFwN1PmNAIv9k6eqaMmYm/ShFWaHEqznqAF+MWJoDQ3bK4g4tf6M7pgUNe8dKrEgfTStOQltorwKLXfecIZ5XJgorhjn/vFcVI2/beX5rPMP/bxEv0jZj3ER8O5bf+1A16rj15yti0wkkpNhy75h4BsQ9wbjXlldcI90+rBP19+vKIsPsY6eU1zri8oYktdMlQsX0r2bLF++wIMvwjZIcxR2Gsz+RUokLPW7GijtFzFZmvtKy7lPUqmt/QupJFbcRDLpEEDGe4+bU5zN9/+zECwT/CPvqn+dH4opbFfkBOgxF86riYxNZHlnw== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=oss.nxp.com; Received: from PAXPR04MB8459.eurprd04.prod.outlook.com (2603:10a6:102:1da::15) by PA1PR04MB10793.eurprd04.prod.outlook.com (2603:10a6:102:485::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8534.42; Mon, 24 Mar 2025 11:52:36 +0000 Received: from PAXPR04MB8459.eurprd04.prod.outlook.com ([fe80::165a:30a2:5835:9630]) by PAXPR04MB8459.eurprd04.prod.outlook.com ([fe80::165a:30a2:5835:9630%5]) with mapi id 15.20.8534.040; Mon, 24 Mar 2025 11:52:36 +0000 From: "Peng Fan (OSS)" Date: Mon, 24 Mar 2025 19:51:27 +0800 Subject: [PATCH v2 1/3] ASoC: codec: wcd939x: Convert to GPIO descriptors Message-Id: <20250324-wcd-gpiod-v2-1-773f67ce3b56@nxp.com> References: <20250324-wcd-gpiod-v2-0-773f67ce3b56@nxp.com> In-Reply-To: <20250324-wcd-gpiod-v2-0-773f67ce3b56@nxp.com> To: Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai , Linus Walleij , Bartosz Golaszewski , Srinivas Kandagatla , Steev Klimaszewski , Johan Hovold Cc: linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org, linux-arm-msm@vger.kernel.org, Peng Fan X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1742817094; l=2626; i=peng.fan@nxp.com; s=20230812; h=from:subject:message-id; bh=70jr6uAvczABhCM5Jlgve8nrHarquKaD/mWAZ0z+24s=; b=IeaXLnWbBlYiwkkX700XtWUHNv9wjbI3oxxTyXqVppIyVHKJKg3w/Do1t7iGx+LGQqNeujLq+ di1keOpsT33ADLuAI+mnbJA71SU1fPQc65q0qBF62gIRhscJWjFS55/ X-Developer-Key: i=peng.fan@nxp.com; a=ed25519; pk=I4sJg7atIT1g63H7bb5lDRGR2gJW14RKDD0wFL8TT1g= X-ClientProxiedBy: SI1PR02CA0057.apcprd02.prod.outlook.com (2603:1096:4:1f5::10) To PAXPR04MB8459.eurprd04.prod.outlook.com (2603:10a6:102:1da::15) Precedence: bulk X-Mailing-List: linux-sound@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PAXPR04MB8459:EE_|PA1PR04MB10793:EE_ X-MS-Office365-Filtering-Correlation-Id: 6399d413-c25d-4631-9a69-08dd6aca5ec8 X-MS-Exchange-SharedMailbox-RoutingAgent-Processed: True X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|366016|1800799024|376014|7416014|52116014|38350700014; X-Microsoft-Antispam-Message-Info: =?utf-8?q?2fKxuIrOtHhLve/NFv+gYqwIUxFRyAa?= =?utf-8?q?hKYhwHkaGfG0RA0/iL/3GqwMbwvwIFx1zQjYByl6THLoPJx20yAbLDVXq95wr9xtG?= =?utf-8?q?tDcNn+67xr9X1OSLuDujIwl80qqUGNvWwx/WOYVuyWVvM/hkKjwkCeGehAmxE31go?= =?utf-8?q?iaEl0XwVcDZA2wSbYmsUkaCOOj8E3alc+gOAiUjhaBIsKxXMryk0R3ArfaAsCgtmx?= =?utf-8?q?UM5dK51P36GqRZGnr5yHKo3cVRQZWMLF642TX2d/uduBKVZLKhiuV8LvTmZ2xaDoK?= =?utf-8?q?HXKi1yz/ed3VgTjiew1iG4mU8BOGz09tm4hkHFl7GIZf8wzJychMp0ReoanH+87Qg?= =?utf-8?q?eA+pejsP8rtP4/Io3umZl+hgZ14eTdwoJi5lvegbijWdRf2dAixtN1uxWMEzx8ZD3?= =?utf-8?q?gg03x1YFWOqr2wUWXTX7wec+QvZeBLLHZ74ZNddjlYMqElczd/3MxmxgyXHbFREED?= =?utf-8?q?GUgHr1OvgWjlRyotNsS32HrL2ODXp52g3e6G74C7bRhGPyKlI410sGqIGwcYiiQ1A?= =?utf-8?q?Nhy3WlpZQrJz6Feaxzk+4dhhrU3Pr8eJGZ9XmJimnKgeXTUi2Z1fSnO0o616CU/Dz?= =?utf-8?q?lFVGQDZBTggv/kk/Io0Ti/W3/aZ010RoICZNkVtAgm4GxG2bkkco2ADOe9xK+MYKT?= =?utf-8?q?IsqIpZ+2iNcwezIyIa80I/Ms5Nmu29oF24A90U4s+q27RGaAnAIT+xf83vFoBMIz+?= =?utf-8?q?4G3C3qUX3l7m8sxl/TDfdeL8b59e7E2xfAmIzSnnfQ6aqjsMRY5gAwzixmootK4h/?= =?utf-8?q?95rDaZar2YHSQhgixAtgdzCDU9nVM8ML3Vdx75GepSy0c6AgqeJAbQrKQE3ubLPtD?= =?utf-8?q?d/n5UBC5ltSAa3iw8VUZAR1ILnsgHJUCjoIfL/9buxlKbaM+GhEURLC+o2FP43D73?= =?utf-8?q?LxtESVQFFC8HJlQbh5cgDqKAHGxycuhiHVQNu30vbwTJXM/PNabMKcdMPISOTg0Q+?= =?utf-8?q?E/NUsklEbZHFH0gQnYDLRLdr2DOgRqwGZZxscchwv3W/DEzRDXJ7Ykf/D1hfbOwyl?= =?utf-8?q?X0T1SIprC2ezhBEGskEC9siacPAajVdxgLKVoXCCpgiT6C8cfOeF5HREGtff00EbX?= =?utf-8?q?Bfuzb+iGkmsJfv/5fdGZLbvCErFRmOe0N0stn0PuGqMt5K8cKoqUQ32XAAmi7aCXs?= =?utf-8?q?Mnf3LBOReAIlnNLtiKwrUItaVWB4Knmag1RDO2JhPePIKhDcskCvv7QG7dSL+LlB0?= =?utf-8?q?ClBpoF8OTXR66ba0XOt/gSUvz42HxaOoexoOOHrt2y+y2Io99h9SGNAk3acq6NwC0?= =?utf-8?q?79eBaKCeSnhaalZqDyckghR/vG+bYoauGE2xSaKERyl16cZxzxpAzU3fG+ljMfVQk?= =?utf-8?q?lsVq+cpCSFvHNR58maI4lF+TEKlRtDTA9INrP6VTY40LwXYqPvEypVI0N3tZVBa2l?= =?utf-8?q?iNY+38dPI/b?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PAXPR04MB8459.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(366016)(1800799024)(376014)(7416014)(52116014)(38350700014);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?q?aEl8siaAEhozcaQXIyhbJAUqFazI?= =?utf-8?q?qv0E0DsxEUFLOtt2w+KhOyahU1wzM1SZRLf5rmjGKnzUGLBhKmSdUpDSOf9e31N06?= =?utf-8?q?DeyypunbspuOd0laCSBr1+CXtEMCKoEOJQ/kWpUGopadqFdUhnMqhb6zjxmBNAKCS?= =?utf-8?q?11dc0CAjjpzJ7cVTrf/fUPaGjBVaDmJcSH0WGLJnfYh/IQskWcIHYwau2TepJavAu?= =?utf-8?q?ZSKjXRAss1q+uc8YYB7M01oLWFbEz7uM9da+M60YCLIT9lixqU1JDaLTHuRtr5Swp?= =?utf-8?q?RlyaQyMMTyMiLlCAGvl+vN55BnKCrAQAcSxC71SnqwUD4Z82Jrjw8UPLTJcd1+Mp7?= =?utf-8?q?2zpRR0/3M0Plz+2/d9fkHRY1LxPP3soopHjRwE7PyDSpvp0ZM5+reNj79AaFETPqQ?= =?utf-8?q?jdYbHU2s8fKpzmJbipORtqPkC6oFidtfbk9fVpSgTq/AoqmyEgHjBB9fFhBeCMQjc?= =?utf-8?q?qJqxfqAmzC8JqsXiDbK/e9XXsqS/K8E+0zoeU5JaTYCtjUXVpSSchF3NxO5k/6umI?= =?utf-8?q?eMoWIH27w/CoCGqT6m9ZfiqR2rcxsEiKBI7o+FoqLfFgLC8IhLvvRPKuPg5yAyGqj?= =?utf-8?q?k5HxlI4slbd0XvbdCYLTYkH8YxRrykokb5xTtz1QI3jfcByIxYFLOzlU/QX7yk+h/?= =?utf-8?q?io01n3UV9o7PJQDaAfLNQsUD1Z5NmFQDyiP0Px9c7kbMpR9znEbMJaxQJy3pbCPsW?= =?utf-8?q?KGs+GyNRpFnci6gKHgtB4A12s8SdyYYtWvTTrzw81vhm4vDNqdVj45o9bmY/NPuxO?= =?utf-8?q?akW9HS1iyEwjgqEWHmkZG1Q0qKJHTkOowUw5f2hT5EDm4KsoGJMTpcEiJhOxKUdSl?= =?utf-8?q?c7nIDdjy4J4awt3Qpg5if61ec2oIybodsC9FDETqSptKnDfY5nSFmiBvOyX6tNaJM?= =?utf-8?q?v7JHtohaF4rAZFGjb/n8YtQIN8+ubMNxaniNNR1Na0mq9MLGOb7yb6N3stsAOhp4A?= =?utf-8?q?SiMG+Rg9OgVmbQTlgr7yc9PKAFzXt2ZJEK5qNkvIy/ZVjAhb69GD6Ahyr/bWLlg2k?= =?utf-8?q?nfdoEdTPYe34ZDoXUEe8T7f5K1w5N1WlymxKF+dU5m1Rjf56ygETlHVInG2ngWDbY?= =?utf-8?q?vGFxO0sQcYawHyW/VLPp8WZMFiT785Ig40kRWTLTTg6SikidfCG54pFsPy34Htpc9?= =?utf-8?q?2W7t6ASyOqIM1wYmkO0pOkpc0WGmBzZ32AXgRDXSVYNr1idYnN5dpOk0EP+wxZXVL?= =?utf-8?q?dkYZ4Rsvb1L45FV4QFKpsI5qReyuWdymCJXLoa/aHPtP5hiHvs2BYuYv58hGR6Bbn?= =?utf-8?q?Wj3HQRvkiaECoA2qlfADNTqzBblYzw6m8aLMj/tyN6sw0DdKgzKHnRqZpmDUnkwpx?= =?utf-8?q?18NxVVMNzBRnf/lXYcmltVN5Ppe9TzpqWXJ8x6YLekThOLpNtu2Z48Wqtyt9wz8CU?= =?utf-8?q?azhEMsduJ0idNEljT3NOX6J3JFhjyC/fbpgV+QsIhDeQj4uqYgOMA07nq598WZ63v?= =?utf-8?q?l/59/bDEqcMJxTmLPp3V4S25iYkreWGtE99Npg+LbfBQ2AL15Oi0wc7TG+mf5b/yg?= =?utf-8?q?ls+xgmSinjG7?= X-OriginatorOrg: oss.nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 6399d413-c25d-4631-9a69-08dd6aca5ec8 X-MS-Exchange-CrossTenant-AuthSource: PAXPR04MB8459.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Mar 2025 11:52:36.4562 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: RltyDcxBctdLFSBfyWVLVr2nD+Sem+9VutHhkfVeOe/XZeTKx9ORe9V9R0e8QEF8FRt3zwXKz0Mqn8fsQDCGzw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PA1PR04MB10793 From: Peng Fan of_gpio.h is deprecated, update the driver to use GPIO descriptors. - Use dev_gpiod_get to get GPIO descriptor. - Use gpiod_set_value to configure output value. With legacy of_gpio API, the driver set gpio value 0 to assert reset, and 1 to deassert reset. And the reset-gpios use GPIO_ACTIVE_LOW flag in DTS, so set GPIOD_OUT_LOW when get GPIO descriptors, and set value 1 means output low, set value 0 means output high with gpiod API. The in-tree DTS files have the right polarity set up already so we can expect this to "just work". Reviewed-by: Linus Walleij Signed-off-by: Peng Fan Reviewed-by: Bartosz Golaszewski --- sound/soc/codecs/wcd939x.c | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/sound/soc/codecs/wcd939x.c b/sound/soc/codecs/wcd939x.c index 0a87a79772da6c0ed3c7dd7d098e949b9cead2a4..837c86ceb1097254f4029087ce401c5a8645bf21 100644 --- a/sound/soc/codecs/wcd939x.c +++ b/sound/soc/codecs/wcd939x.c @@ -15,7 +15,6 @@ #include #include #include -#include #include #include #include @@ -201,7 +200,7 @@ struct wcd939x_priv { u32 hph_mode; u32 tx_mode[TX_ADC_MAX]; int variant; - int reset_gpio; + struct gpio_desc *reset_gpio; u32 micb1_mv; u32 micb2_mv; u32 micb3_mv; @@ -3239,10 +3238,11 @@ static int wcd939x_populate_dt_data(struct wcd939x_priv *wcd939x, struct device #endif /* CONFIG_TYPEC */ int ret; - wcd939x->reset_gpio = of_get_named_gpio(dev->of_node, "reset-gpios", 0); - if (wcd939x->reset_gpio < 0) - return dev_err_probe(dev, wcd939x->reset_gpio, - "Failed to get reset gpio\n"); + wcd939x->reset_gpio = devm_gpiod_get(dev, "reset", GPIOD_OUT_LOW); + if (IS_ERR(wcd939x->reset_gpio)) { + ret = PTR_ERR(wcd939x->reset_gpio); + return dev_err_probe(dev, ret, "Failed to get reset gpio\n"); + } wcd939x->supplies[0].supply = "vdd-rxtx"; wcd939x->supplies[1].supply = "vdd-io"; @@ -3290,10 +3290,10 @@ static int wcd939x_populate_dt_data(struct wcd939x_priv *wcd939x, struct device static int wcd939x_reset(struct wcd939x_priv *wcd939x) { - gpio_direction_output(wcd939x->reset_gpio, 0); + gpiod_set_value(wcd939x->reset_gpio, 1); /* 20us sleep required after pulling the reset gpio to LOW */ usleep_range(20, 30); - gpio_set_value(wcd939x->reset_gpio, 1); + gpiod_set_value(wcd939x->reset_gpio, 0); /* 20us sleep required after pulling the reset gpio to HIGH */ usleep_range(20, 30); From patchwork Mon Mar 24 11:51:28 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Peng Fan X-Patchwork-Id: 14027137 Received: from EUR03-AM7-obe.outbound.protection.outlook.com (mail-am7eur03on2055.outbound.protection.outlook.com [40.107.105.55]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8048E25E834; Mon, 24 Mar 2025 11:52:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.105.55 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1742817164; cv=fail; b=k5iZXEDUyPiR3R8ttd0qtrUL6jirj/SnALS5UAxQbaICvDKEJiajZfo0oMTGCJNG7UY1sqRBseM2LquPZtAvQ3FaR6TcNDux5TwUnL8Q1Fm36AyVsRj0XAS8HDsQ8Ozn4Dqd5bI3H2pb1MY0cHM6rLsav+GB1BBEEcNeaKF0wko= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1742817164; c=relaxed/simple; bh=tEh8xndEV4DzAQiz5Ev7QRAHEmx0QSyxe4RRnt2cTY0=; h=From:Date:Subject:Content-Type:Message-Id:References:In-Reply-To: To:Cc:MIME-Version; b=hBdSgsgM3b+/ZdHkXUbSijUZDMu54qZvdY0kJRlfFprJppWFrC5dXB+vsY/AFCMiv/5iCUpWxtkl6dTIe7cCKTmLENX70K4SbCZ44y0qLegKuZaDp/I5QBPYI4LBss2AcEjDoXNxoUmAthMTZHYImYGaw9RMVm4nX/qe29YpcMc= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=oss.nxp.com; spf=pass smtp.mailfrom=oss.nxp.com; dkim=pass (2048-bit key) header.d=NXP1.onmicrosoft.com header.i=@NXP1.onmicrosoft.com header.b=aWZZAK3h; arc=fail smtp.client-ip=40.107.105.55 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=oss.nxp.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.nxp.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=NXP1.onmicrosoft.com header.i=@NXP1.onmicrosoft.com header.b="aWZZAK3h" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=XnLOBppDMsMm4EjYewp6jzINLyHop25jLzdwNT4Ov+QYKZrhvu3+nwUeNvxkfc540rs7i8yiAB83rUrygU5GDmTygAV0TOMpAi+RApSYqq1VT9T8Gx9qGPiYF5Lh36pbT9u3/OFwvHrmqEEX3Lm/smCCKF9M81hIl6XsSyWZqqU9shrqLtQZ0f0RcRicuZDNJxde2cDQynuhkKpywMfEovvvpW7+z0sb87y4anY1mar+/JDiTaLh/AmfmD9hPsImAoy1KTr0boatOQ+jhuBjs27YlSb2Mk/ECOnUuFZtiIweJ0Ab/wLTDjEP8AH6gQpqQHo9seFZng12goQqMnpzzw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=6Z66TkoJaOB2GgBs3x7C09pBu6O01+YtSgB1JDK+/gs=; b=eflcUA8n+ma8yCbEYhdHG/5cUH388C4RoK7R4AefBT6zwPw9a7kIdTYZptv8C0D7i56Igm+2p4EKiLRXV0Qq385hCJciVh0qdkFDu7DbaHNQjd2FtJUtQIdEUiAYhmTstYNRfSEcRo9A+fZE/ZsoA85SAGiIHv0PD9NW8nXzRko49uWH8ol90jnNVYS1+/duziHNx8V7BB5NZsKboo9eBUQruOUwlNzeV6wPPjPdw6MCi+oeikM6HPttSVBqeakDPmTZpHTMvM+hFr/Yi2a4881UkHp9HEkIA5VfvJPSk2Ffy02pbV9tc811ivTWdA8bpxO3yv2kU6vmm0iuBxqsdg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oss.nxp.com; dmarc=pass action=none header.from=oss.nxp.com; dkim=pass header.d=oss.nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=NXP1.onmicrosoft.com; s=selector1-NXP1-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=6Z66TkoJaOB2GgBs3x7C09pBu6O01+YtSgB1JDK+/gs=; b=aWZZAK3h/p3pswtYTH/SEwXOKlEv8kMag2UNGtfncS88m/TZFYyhWUBaLS6XC1gcucRd595bnBMY+8lPDDMP+EgP7rxGIfkXyWmd8GVRM/m7fXs8M3+aH9fWdvZkQrsSs9VmBmDbHB7fkdI8QjJEZospGsib5RJnHLQLCHeZkw5e6K1KPjX40X/6ji4AQz9+ZSGEhDr7J4MxNNCzYU4saX8Bjj8efuDl1IYK+8j3va0IRrtwwhZiQBmMhVd1BuCLiNhLSbGGyYgYx+1p4ecHGFNef+DzASVT482gGfIVcM0ZtLIJ4zb+vKVAbiOG61UpBczKhCm7kA0twH+ePZZWuQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=oss.nxp.com; Received: from PAXPR04MB8459.eurprd04.prod.outlook.com (2603:10a6:102:1da::15) by PA1PR04MB10793.eurprd04.prod.outlook.com (2603:10a6:102:485::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8534.42; Mon, 24 Mar 2025 11:52:40 +0000 Received: from PAXPR04MB8459.eurprd04.prod.outlook.com ([fe80::165a:30a2:5835:9630]) by PAXPR04MB8459.eurprd04.prod.outlook.com ([fe80::165a:30a2:5835:9630%5]) with mapi id 15.20.8534.040; Mon, 24 Mar 2025 11:52:40 +0000 From: "Peng Fan (OSS)" Date: Mon, 24 Mar 2025 19:51:28 +0800 Subject: [PATCH v2 2/3] ASoC: codec: wcd938x: Convert to GPIO descriptors Message-Id: <20250324-wcd-gpiod-v2-2-773f67ce3b56@nxp.com> References: <20250324-wcd-gpiod-v2-0-773f67ce3b56@nxp.com> In-Reply-To: <20250324-wcd-gpiod-v2-0-773f67ce3b56@nxp.com> To: Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai , Linus Walleij , Bartosz Golaszewski , Srinivas Kandagatla , Steev Klimaszewski , Johan Hovold Cc: linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org, linux-arm-msm@vger.kernel.org, Peng Fan X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1742817094; l=2592; i=peng.fan@nxp.com; s=20230812; h=from:subject:message-id; bh=KSNVXc7VPsbNPc5hvKvI9fW2pZtagLee72i+Ls0pits=; b=eLTZNwa1m4W/6cgx7DG8GkY0x4wlSm9QZHXfTAGsttxLL9XulTTc5OH1f4VK0T9CzT7YaqMFB EDNpy+aVzbXBXarIrBQor1tuMvqddQ7EnqfNgEhLHFJYbD2SOV3xhTK X-Developer-Key: i=peng.fan@nxp.com; a=ed25519; pk=I4sJg7atIT1g63H7bb5lDRGR2gJW14RKDD0wFL8TT1g= X-ClientProxiedBy: SI1PR02CA0057.apcprd02.prod.outlook.com (2603:1096:4:1f5::10) To PAXPR04MB8459.eurprd04.prod.outlook.com (2603:10a6:102:1da::15) Precedence: bulk X-Mailing-List: linux-sound@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PAXPR04MB8459:EE_|PA1PR04MB10793:EE_ X-MS-Office365-Filtering-Correlation-Id: 6c37ad15-525e-4c4b-3753-08dd6aca6140 X-MS-Exchange-SharedMailbox-RoutingAgent-Processed: True X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|366016|1800799024|376014|7416014|52116014|38350700014; X-Microsoft-Antispam-Message-Info: =?utf-8?q?kFuk017/gr9GugyFbTXh9bTdkwZDzHo?= =?utf-8?q?loZAoOzrREwBNXok/vcPeCbzBZ08fP2dhZrSt+rF9QcrTAhGCXDj+1bJ9iPOK+4kz?= =?utf-8?q?HKlN1Zbwb7wERAHhUyqtt6SXDdMLLwo+lVD9vddt6WvcAYF9Qmd4fsf8b+aDKKVtO?= =?utf-8?q?3FMfmhLP/7SoYODmlrnB1o/d0Drd2MrI6EXOvgE5JlnuB2uON42upH66DJaUJYVyP?= =?utf-8?q?5ifKT8x8acQlTkYUu7hMTAzrk2DVL+2KgPDVNVJ36cVH6PhCLUdL5gJ1Js4OXIFco?= =?utf-8?q?uBb1Gu0bmIArKbwW3J4c5mAL7e5IexThFs87JCuiJJSenN/9IxiGmHUN/EoCdUqZU?= =?utf-8?q?E9SVVfedXnOdzr7DeUzEVgik8dzmg8o0Nwv4nK7xZZppgkKu1/fqqFDOf12e/OC1k?= =?utf-8?q?Xm0UQPGjY+kstB4fYg397LnvMwnPv77g5Ht7BWaB3lWaIUQzq23alWrTZNjPI5T4H?= =?utf-8?q?C+o05ts3e3wxfc4W5vkA8xb7qlpXEb0pCYezSzVXaep1aopbEx47NBsdZSJhEL8QT?= =?utf-8?q?HvwwIlzh/0tg1IM9DbynSkYK4AS+c2h5XbhpJ7SmUbTD/CTkvqISDdO2Iwm6kswtS?= =?utf-8?q?VJkLR9TASIKw51V9I6yfTDiaw42eonpptSj0siOda5yrhw2+sb6KdFxtw/UQToICU?= =?utf-8?q?IdhcMxsT3H7RtVaSE1o8r3Hq+BqODpIbqjNUrdSox3atLVNHrLYRWG7GsXz7iq1GS?= =?utf-8?q?Dp2tjS9Ae9/7x0uPXlQ+qUtQBhw9N1uLYITrBelvZmqvK23Kg4muRRRFMs85yWs5P?= =?utf-8?q?KYT8IrWC0fH7l/C6hvFQtNHhANHMhS/CyZrNRZipOFIW8czpcopgTp1OEN1OESb0g?= =?utf-8?q?aPsWWk1y3abSpysrL/lS4n2h9hhVixRjF5nqV6DfL5gmyCzSm/IF0uALHCGk38pPX?= =?utf-8?q?ueP1dXzkHn/bsDa78Kd5Y//yPHJj1Jb2o371XIhpmCvXZXwsGNUq2LY1rXzIK7WIj?= =?utf-8?q?rPlVbI5Q/ZTCKrqwv0vkUK8OBorMenC/8NSseoQ8lIND4Bnfy9V9WfObQLm3INayx?= =?utf-8?q?HUuTo8b95kCSK5j2U9trPtBUkYB1BgLC/XKGUfBzgG29kCgMFD2Yi2eZVWNsZWloi?= =?utf-8?q?7q8QIjTmdy4Pv4zyWrZpPGOl2bkcJC6TsgcQitlX8BVvKbqJ8OraV3/9fCiiYD8eT?= =?utf-8?q?r+TWGWgcjcZywLyEaTCwRXiNvWMsHoyGmyXCgRaCeTKTcDvuAlYHShcAL38fLln+m?= =?utf-8?q?J3Glr9fDnr0dxOM7K2cb1stJuPP8koqDudbQp/atVMMQd6z8r8xoeSgXgyovcHRbk?= =?utf-8?q?uY0BCAW5sw2jsOvQg80r9GqfuuCPXv67c5tB3pWEhjA+LxeZFvDu3sXpboapIRWq3?= =?utf-8?q?cPrOg0hKqk/DrS2PpbNxZ196pgYhKYylsdVHBzYPY9O6y1AXeymsyUT9gyiGMKqQU?= =?utf-8?q?kMawQAAV8so?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PAXPR04MB8459.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(366016)(1800799024)(376014)(7416014)(52116014)(38350700014);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?q?LyoLiqcRtkVlsUskYDwCsUqO5kBT?= =?utf-8?q?mw8ZhRo6MfpEP+9xcBQJUXvfONECgDgfIHyYzxzqi4RbYLDylgIGQsbJ7tIXh9Yu8?= =?utf-8?q?8j1MqUQKfxGUmaeMa34IvPXb1OklofRkwxoU+w8dRJUrQ/xfWL53fBmqt73vTtC2x?= =?utf-8?q?AmXBBTeJP56FX1XFiWxGwpcEyBi+vZX+bh+B5ak4Sj68wzTSMtSe+fTSLAIl15vyO?= =?utf-8?q?OvnSE/E0busLt9J9653Pf2Y+mmaowk+KVVHVchVLDISbV+11QJ5rfxYU3JI0JCNAN?= =?utf-8?q?8qAmJOgRhYt+vPhW8JD8Qd6g0oJ8Ceesbk0gH1jh0ewaQycxvocm0Bb65q/K0lmoS?= =?utf-8?q?uxua6zQvQqusZWquE3Sv0gvD3IWKIwVf1+tYKPJgXmxtJ/0KBH3l5ZnZrY9468LpV?= =?utf-8?q?DyqwPRER7wxzZw0/ajL445zYlioOfrrCmppmmjmwm8Ku3gfOMGrhNyeraE9qxzSAq?= =?utf-8?q?4lE/klGQUZSIv7XYG8TeD8SBOpAkU8QcNj9boiJ/z9Nyij9DZL9pN3UWBveL4UMJz?= =?utf-8?q?EQazndxJRfHhW7ZimpaKghfh8AL3yjBj767NiB1XnbXXMLTq4I04PnwKfO7M53mJc?= =?utf-8?q?Wcauhydb7bLDESCBEGehSKhrdYPm2NB/UYOwEG71zGY4n6sbgr8lZHeVByb0GG1WH?= =?utf-8?q?roExA1aHuezj3FzXdbZeZ/6QOo9RLGx+1U/QHnDgNF54cTjOgXupgQazsa5e5LE6Z?= =?utf-8?q?xSrsfh3W8Gwq+qX2sL3WCIERxY0Jo+3he/QaJOcjLrsezdQY6OZK9/YqietOGAOE8?= =?utf-8?q?wzdhNT3UAKrHwKw5bVdc66mF55CTlBl/Oq2RvJ8Etaqp7v6z/3L6k64AO8FAeJG2U?= =?utf-8?q?b/HHvHjTcppedgCox7Yc+BQi1eIXup9j8JwHM2kHu7+k+PbeWRV3jPZRO0pKuYx2+?= =?utf-8?q?jJOyMitchBnevUAB8MlshS9uaXpfhqL/31rL6PKan2KQIa8CDfAax4PPzvwpk+w1c?= =?utf-8?q?hiF+FMHyb2bPjuRDcVCtN6HqISTLkBKUxs8IhXjhZKqIeltcaJJDjoEZMlMSLxHhu?= =?utf-8?q?W6dsll3OFjRIw4b05XW98HkJ6et+co73Nx+76plkqCcsEHJ3KiTcYeH0y3GykEJRQ?= =?utf-8?q?BfQ5emdVBYpNDIKfC8RqWyKbkSAQpplAtPAMecTLZxxFlNWCFSGgizUfIkiefR1Qn?= =?utf-8?q?DArdWmml9W+kL522N4AcsYtQ5t5iD36QcnP1iyxjoBWTecGe/JqwGCpo/3+YP+eL8?= =?utf-8?q?aisobXOJg7smyy7O/itQiAl1YXDw+PaDxUNZ3Z/3vi57YQ+nyyMCMKZe1NSd9R1Z0?= =?utf-8?q?dYAyt+Jr8ZbLhATwlXmaVasbOLjKx/COMweBquyjRS/QzLeDFPlRwT++za3o+VGJa?= =?utf-8?q?NeRyap0V1rzL91mfJqiuh4EXKsT5YDDe8KOoX4e3edbSrwRiGMWz24fEvsAt7X/Yr?= =?utf-8?q?NTAgUwb480l0LtwcmmuY2GR/ChBIxtQ3Jzei9GnycYmeZ8DOWDxsUsZ7cnisgfqiF?= =?utf-8?q?z7DrtARtEgjwa7my8X7atAM2WjlNhboiSzCcl/APiFmXc2S2zwus2jGXvCEuLO0aW?= =?utf-8?q?gMpI81n/LEhd?= X-OriginatorOrg: oss.nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 6c37ad15-525e-4c4b-3753-08dd6aca6140 X-MS-Exchange-CrossTenant-AuthSource: PAXPR04MB8459.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Mar 2025 11:52:40.5009 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: EcF9i7kwwWdIzPXgB2VzrQOKM3AD0bGz2Z/AS1Odu9lFP/oRvogaKtSqRW7E/7Kol95ouiiqDfm/P91OK0mLzg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PA1PR04MB10793 From: Peng Fan of_gpio.h is deprecated, update the driver to use GPIO descriptors. - Use dev_gpiod_get to get GPIO descriptor. - Use gpiod_set_value to configure output value. With legacy of_gpio API, the driver set gpio value 0 to assert reset, and 1 to deassert reset. And the reset-gpios use GPIO_ACTIVE_LOW flag in DTS, so set GPIOD_OUT_LOW when get GPIO descriptors, and set value 1 means output low, set value 0 means output high with gpiod API. The in-tree DTS files have the right polarity set up already so we can expect this to "just work". Reviewed-by: Linus Walleij Signed-off-by: Peng Fan Tested-by: Steev Klimaszewski Reviewed-by: Bartosz Golaszewski --- sound/soc/codecs/wcd938x.c | 13 ++++++------- 1 file changed, 6 insertions(+), 7 deletions(-) diff --git a/sound/soc/codecs/wcd938x.c b/sound/soc/codecs/wcd938x.c index 1ae498c323912ed799dcc033e7777936d90c9284..955a0d3a77d7cb45932faa0c7a6f5060232d33b4 100644 --- a/sound/soc/codecs/wcd938x.c +++ b/sound/soc/codecs/wcd938x.c @@ -11,7 +11,6 @@ #include #include #include -#include #include #include #include @@ -171,7 +170,7 @@ struct wcd938x_priv { int flyback_cur_det_disable; int ear_rx_path; int variant; - int reset_gpio; + struct gpio_desc *reset_gpio; struct gpio_desc *us_euro_gpio; u32 micb1_mv; u32 micb2_mv; @@ -3251,9 +3250,9 @@ static int wcd938x_populate_dt_data(struct wcd938x_priv *wcd938x, struct device struct wcd_mbhc_config *cfg = &wcd938x->mbhc_cfg; int ret; - wcd938x->reset_gpio = of_get_named_gpio(dev->of_node, "reset-gpios", 0); - if (wcd938x->reset_gpio < 0) - return dev_err_probe(dev, wcd938x->reset_gpio, + wcd938x->reset_gpio = devm_gpiod_get(dev, "reset", GPIOD_OUT_LOW); + if (IS_ERR(wcd938x->reset_gpio)) + return dev_err_probe(dev, PTR_ERR(wcd938x->reset_gpio), "Failed to get reset gpio\n"); wcd938x->us_euro_gpio = devm_gpiod_get_optional(dev, "us-euro", @@ -3297,10 +3296,10 @@ static int wcd938x_populate_dt_data(struct wcd938x_priv *wcd938x, struct device static int wcd938x_reset(struct wcd938x_priv *wcd938x) { - gpio_direction_output(wcd938x->reset_gpio, 0); + gpiod_set_value(wcd938x->reset_gpio, 1); /* 20us sleep required after pulling the reset gpio to LOW */ usleep_range(20, 30); - gpio_set_value(wcd938x->reset_gpio, 1); + gpiod_set_value(wcd938x->reset_gpio, 0); /* 20us sleep required after pulling the reset gpio to HIGH */ usleep_range(20, 30); From patchwork Mon Mar 24 11:51:29 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Peng Fan X-Patchwork-Id: 14027138 Received: from EUR03-VI1-obe.outbound.protection.outlook.com (mail-vi1eur03on2058.outbound.protection.outlook.com [40.107.103.58]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AFF9D25EFA2; Mon, 24 Mar 2025 11:52:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.103.58 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1742817169; cv=fail; b=sz55Nb+RPmnL09DjdR59r7YOBsl5hTzWzMeRQD+33SxddUUcPydiaB34sbSGLPwCxqzSPsdDdqT7SKyu6XbXKwtAA9i5aECL9A1WlY7cfIe7gMpxV+FxnwzHQw6jzAd8pO3BakTIRxbxOXHHWA2qxaZMnq8CT67S5DFC6W1kBG0= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1742817169; c=relaxed/simple; bh=8lqloYOCi2lS15i/mVpCiuhpzEslgQDTnHHBRmj9IGU=; h=From:Date:Subject:Content-Type:Message-Id:References:In-Reply-To: To:Cc:MIME-Version; b=KPzIXxB1nRTrV/jyGU3eCaTmDWdMt8eUjImGPRkuNrsxR0AvNUKklmnNLYaiO9upvLJOqxch3cmzeWC1IyENSAijVnCEjblbdFZF123eUUPupMS6lNhT/TqXASLB4407u4Sq6MQ+nvhwKyVc8jK6k07SEarDdpB12wPulIO6ABA= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=oss.nxp.com; spf=pass smtp.mailfrom=oss.nxp.com; dkim=pass (2048-bit key) header.d=NXP1.onmicrosoft.com header.i=@NXP1.onmicrosoft.com header.b=IFNzURFH; arc=fail smtp.client-ip=40.107.103.58 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=oss.nxp.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.nxp.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=NXP1.onmicrosoft.com header.i=@NXP1.onmicrosoft.com header.b="IFNzURFH" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=Hq5dIgb1B2tOS5ylAfB9dGV4rLDtsaVzljrCwDe32voKRhqkj5AimGpR8Q2X60n6h7sCnrPicRoGePHZQP6JBsa8cfz4kzGKTpPpwcR40c7gUM3+AVz1wTsfGirvcZz8YsIgk0FQSKj+M1idfmtY6Gbx212HeCyeFGX5NY/JYAeqcEAcgHzwrKuBh4+nsSpRV03RGVPLVXgqNWM1PUuqv54VWTJRuKLBNUdMmJl8V9/bMLFsJ/f4vZ7AzYQM2ZWb+ctal7HwZOEvVxZkQ3ULYTSRrXaHGt35+Gmd7ho2G+cOCg3ti4Od/Aqe/4FFMoHmTMyHxbaiQpcmbp9N/kulPg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=kS+KFdX/62KQA61insdOu5dnTsYuS2Hy6x2nmZkHz+s=; b=QDkC9xx6DhULmC+F3nJhU8NQ/OH8DYXe+M+mNscm1EHIZe4RU5YBRw/fyXzLl1Uqb2Xv+rAcWeWvF7ZJMaAa3GU0JY7ZpCMNsWWYPba7+w3GmCg/PdfnVsG8XVFKGpB8wUaX5SfHAba+hzF6VWXHoAzxmuk3N+HDpg7Q/1tW+b3Y79zk/z8LnPza5WcAStDwU3n627f7JVoCjfeR8GhHcttrqT9/jOo4wnzShLpNZINMQEmizEilNUH50QfIHN6Fs6et7NY85rB47dvk3kO25L22Ux5b8UjPufSZJ2ekdgmOy0oHYV22MnCq5QxHyVn2u0DytarIdb/Cj82V/nYGGg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oss.nxp.com; dmarc=pass action=none header.from=oss.nxp.com; dkim=pass header.d=oss.nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=NXP1.onmicrosoft.com; s=selector1-NXP1-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=kS+KFdX/62KQA61insdOu5dnTsYuS2Hy6x2nmZkHz+s=; b=IFNzURFHO9lPiMNT73bXuYzoqVeiBXGx9ItIbVM8Y4t5BVn2KWkzk2CmBNru8x8Q6Gl3EU3yTxa3Wmn3AUygCrJVG+4wJZGc2qpQo2o00mXgeZtBSyeKXhwZAccZZyGGw+yqpMLEXiypWNHYcdRyKRE0QF2k9h5DkXEfcfzxES0kOYMvmCyqMabgrcOyatRdzbU16RW2H++XK5qRK3dyb1JWH7LKa4buhtjdTa6WW7SjdzI9297Xg0wp/AZIaIlA4ENGFLtVdVw28N2Hn8OeRVBHZLTx2oSnFmIRDtKVXVOXhjn2XpeNj84DlSOk367hJbWBQBE0tb4q59n0XKyNOw== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=oss.nxp.com; Received: from PAXPR04MB8459.eurprd04.prod.outlook.com (2603:10a6:102:1da::15) by PA1PR04MB10793.eurprd04.prod.outlook.com (2603:10a6:102:485::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8534.42; Mon, 24 Mar 2025 11:52:44 +0000 Received: from PAXPR04MB8459.eurprd04.prod.outlook.com ([fe80::165a:30a2:5835:9630]) by PAXPR04MB8459.eurprd04.prod.outlook.com ([fe80::165a:30a2:5835:9630%5]) with mapi id 15.20.8534.040; Mon, 24 Mar 2025 11:52:44 +0000 From: "Peng Fan (OSS)" Date: Mon, 24 Mar 2025 19:51:29 +0800 Subject: [PATCH v2 3/3] ASoC: codec: wcd9335: Convert to GPIO descriptors Message-Id: <20250324-wcd-gpiod-v2-3-773f67ce3b56@nxp.com> References: <20250324-wcd-gpiod-v2-0-773f67ce3b56@nxp.com> In-Reply-To: <20250324-wcd-gpiod-v2-0-773f67ce3b56@nxp.com> To: Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai , Linus Walleij , Bartosz Golaszewski , Srinivas Kandagatla , Steev Klimaszewski , Johan Hovold Cc: linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org, linux-arm-msm@vger.kernel.org, Peng Fan X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1742817094; l=2514; i=peng.fan@nxp.com; s=20230812; h=from:subject:message-id; bh=4mUyoIQOgr7LboU+OHDfVwrt16rnj5LwQLXfpKlgYHY=; b=zY9CbRM1ubURRwHAnynCEUrP6uTcXu1lbsA7IlzHvLVI4Zy0njFoGFWYPK48dARNcwCrWGlK0 qzQ0pBFKYFuDZ0j5uw+GTbH+5ovc+oXvvdQF6qfCpQiYeYBXGXir/4c X-Developer-Key: i=peng.fan@nxp.com; a=ed25519; pk=I4sJg7atIT1g63H7bb5lDRGR2gJW14RKDD0wFL8TT1g= X-ClientProxiedBy: SI1PR02CA0057.apcprd02.prod.outlook.com (2603:1096:4:1f5::10) To PAXPR04MB8459.eurprd04.prod.outlook.com (2603:10a6:102:1da::15) Precedence: bulk X-Mailing-List: linux-sound@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PAXPR04MB8459:EE_|PA1PR04MB10793:EE_ X-MS-Office365-Filtering-Correlation-Id: f62432f0-2ab2-4f7a-e28a-08dd6aca63ab X-MS-Exchange-SharedMailbox-RoutingAgent-Processed: True X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|366016|1800799024|376014|7416014|52116014|38350700014; X-Microsoft-Antispam-Message-Info: =?utf-8?q?q4+e8bXO5iqCxnB4PNJruTcf1/O6OY5?= =?utf-8?q?3SWM47XarhrdccmgIWsHxYxsRMCf2wihtAeAvBYvJLkdF7wbqDYkI+4Qv3k+8+Ir8?= =?utf-8?q?LIMqofnqrSMhqIHK1tzlldmSEdXMSkb6dnAhqDRFxD5W3v20SarW7ZRRv06RMIRZo?= =?utf-8?q?A6pAoQCU985wUaBeZKJuppaqGx3aNWu43K6WObhz38NbmqaB9zP583QdrcKpEViu8?= =?utf-8?q?hIajfgYPzuTAXyXVoQidJ4u2wlYxexLouzFgIj3tvoHgE7A6tT1meb6yrO2vZr5TI?= =?utf-8?q?ZfGTR7bmTXHDM+VlC/QXoU2r9lAVJ7xOIwQoy+jJzRmGrVJ6zddALmF9NZqIi+lXq?= =?utf-8?q?URU5joGm/AKHe+vX3j6YpysxdMTNlcwlVVBzT5c63rRsGwDmECgzqAlMs1UlWt2Ar?= =?utf-8?q?SWO0e/9S0zZ/9Op0n4DgOvcYbP/PiX8D/1nM0T4MhsKKZdqzbRwWhniDh3+VX7eTg?= =?utf-8?q?nxp18mwt+jXJ4ceE+ZT2uB+4C6aG2B1evkDliBbJ+k1UPhjKlfUD2e8/5CW/eZJiJ?= =?utf-8?q?bE5sBQToU97cJWyP4ItlqYEjrfKNcUqiqsCUI1/yFsYDnQiN1a8jcJvVgQtuMlhHd?= =?utf-8?q?MQnfnUTMLZHZfC2B0JDu2a34SgSlDuof5wKKKl6MUa8Jdjs8t5OlyIz6nJLELYFm6?= =?utf-8?q?/TGsvoCS2An4W2gnMpDl5o7+mSLKh7my9z+MjPzvF2UXw6qeWwEV/2CEndoGqN6XM?= =?utf-8?q?5XpsfyaGfMy+AqVec/Qz7ANdPvaeEtL2eSvi/K7DgP8WzAH4b1kCzsY8Zs7c8R6Og?= =?utf-8?q?j4XMKiFhrKT+4wxQsTD9lelUIJFFtE50R7OeGH9RQ1WpH9ZU70DAv7RSXlKgUg0k2?= =?utf-8?q?ewawpNzlwMv6B3349LX4JcmRNyoWnJ6m/qEDmRx3NQTx+DGywmC47e+E9UlwTHNWS?= =?utf-8?q?bPh7/8QG2Mt1Z5DrT6XSY7fElRA3/rB9reli7ADdPCXy6V1KCxdCB4S8Ivb9Cr8E1?= =?utf-8?q?0SNJT1/+SdZ/XslqEag64fiNruQI7x6i/GlSCCjmDyQA/t139PMLbyf+0B9Y6dHca?= =?utf-8?q?A+I6dCmLVV1weSV44cjtrboSGTmqMh9Y1RiuZmSrjLqe1wPGq6TgiCDaU3wPN0XUJ?= =?utf-8?q?L7UW+kbJJ3AhrXVo+s+xdr71bjFg17xezObHzspS4CK4Z6saDQCjWxt4IemHMSEJw?= =?utf-8?q?vui9B7G/mfuEme6CosdaVzBj1bZySjUT2eLp/fOzrwIRc6TaZGZAK1mAejGXGYnWu?= =?utf-8?q?yVhcwt8TPK+aleXZFc2CE4N/ctzpZh9oZlPZ4uISjbv2OuDs0x0J3aGVa1lSgU0o4?= =?utf-8?q?jjxrSRTS9QFTUCcQ20XJhv9kWJAGHOSUZH1hH+LfHs6XlEKRHfCHtMv+vZKIi8tDD?= =?utf-8?q?Alw4lcs65ki+22Gm6qaLzR4PZB2wPQJmgN69J9nrHmTdpblKFyUdjqp+3UqOdYOEp?= =?utf-8?q?6/oONJZGPAM?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PAXPR04MB8459.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(366016)(1800799024)(376014)(7416014)(52116014)(38350700014);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?q?3/PLaztksu8DJF3q20uSbnFejdeO?= =?utf-8?q?/jtte8dt5NWl/3eTFGTtKpT5NhshEDpUsVELwshtTE+Quq6EYSnj/yNfH7F6YcKGj?= =?utf-8?q?tDJ3WSy0c7lAtl/95z3RxQLc+L+lt8bKfzIaiuRbzWlmuDjlkl6A1bm9djDGtnVqV?= =?utf-8?q?pxIcYp406Ju4+9QBldRXroLmhJtFfnuqaOh1FNSEfaHnRq29VgGJFIhQqVk6lVMSy?= =?utf-8?q?XLY3IhWWtMU7uE3pFCLIwx1hnOfoId8Y3Ig4+MhhFnQLNn28uvH8dNkGN665uhlon?= =?utf-8?q?r5IDXwxTRrDFjHaeXyuVPmvHOuFrW6AkDGQNhhFxTXgqnTvK018yxaXKKrsGBiIih?= =?utf-8?q?VAGyw7XMmAs5DEH8p24Xm9jyN2ytxHd9UtcKanWjJFZely24pEW4yvCAvLPIP1foh?= =?utf-8?q?eha4BTw4DJ40Zt2Jl8h6cb3Kt6XiYPb3PPNlu8HTsn8igGwMJrBOZTMfBcTmvuV8j?= =?utf-8?q?Q9LjWUrexTlD6n5EXcY1mBwBomCRJHJq1FQO7vUtAls0liWkpR+kZKzbkkhw1TtrP?= =?utf-8?q?B5b3MGbEjcwZ4NsulspB1B/KyR6uanDj8pBIFVRxs2RSy8x2+U0mx2VKf+4ZjoJqX?= =?utf-8?q?YHgFDj8j0hLUfKGtVbMx0S9UQqt2UJsis7LreC6QroDmokjbwnrkAGo/i0I0F0blr?= =?utf-8?q?CR6nWaxHESe3TQgwDSOgAlmczaI5Cq7PHHeoyoabjewSLBvFJTP86b35hekvOTbRJ?= =?utf-8?q?R86fZakndyz2b4k5fhcsZ28wAbY7nFjl5X3Eo5crdidw60CU1cBHujGVaqduicYOT?= =?utf-8?q?hvqjnGrxiEjoP6bAuVF2+tzKQaawYJxURUawCNATH/ts09JAzZ7k/bU0G6BXv5KwE?= =?utf-8?q?Z/YO9KBm3Unw+v9GmZ8gCAs5CXcAGEzxHdMrdcGRaTPrP3V6bBji3ZOREt4Rn5bxX?= =?utf-8?q?hU2VCoHC/FcrtOTmeTyno1za6MvLH6yESUcQ7pE4QGB1ZgOdkYbz46gQ5fx4OhuSp?= =?utf-8?q?QjpPpTo5rNSkIlD/EUPxC1U7ZxVhwdXJp21kz+IJMxvhEyHTpjxcUvppowouZBHbo?= =?utf-8?q?QN1CcQEgtqoavbT7A/8iSVcNuBV67jzdcI1KRbgSzgxEYrTZSzB4RHoo9Mk+VZo/L?= =?utf-8?q?LwYv7YWC1WLET4o4RGSgtdNjd9n3MP5NtzhOeo/QxNXMUrWZd61sTU4opPSSLj8vI?= =?utf-8?q?tbrosoG6W8mGtIDgp7GyGbvVgLYk3LEX4Lq4+4fSPaRrxCqc+JRzJFS2mnJpg+X/L?= =?utf-8?q?Disz2JDkM50wd1PBn7afgJY7XX4ais9PL6b0wrRA9CxbYJmsEsR9KsuTbRu6J49Ju?= =?utf-8?q?Y6CZCr0db3q+JiVrcmLrzx5PbQEiu9TTAVAiFLXeKV+G086TFrYyxeMuEjaG1PGlD?= =?utf-8?q?Z8kHN+E5KAA5hBL2QjozoeDjPeYn7MbAYySHRoQTURESTSRIt/RvNAePPCXqCADnB?= =?utf-8?q?utOXwqo64LhoWbXD07RPiX+9xpo7rl5Wzyx+2K/qfrwKUiPHewun4ODBxeTDG0LEs?= =?utf-8?q?ydEFAQeMB2M8Jy3fENCXaR4qWgInuC6FZQai/gtiTs4cNscgPK67NhjbvEp1jAIgh?= =?utf-8?q?zmJGscXlH4d/?= X-OriginatorOrg: oss.nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: f62432f0-2ab2-4f7a-e28a-08dd6aca63ab X-MS-Exchange-CrossTenant-AuthSource: PAXPR04MB8459.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Mar 2025 11:52:44.6516 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: eSChFngBnEma947wTlhZRLQaOihsUiYIHIzmTVOfFFd/tuToE7AcqSA6cW4AuNtudfoTqSAvIMJwjE7uXHuQow== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PA1PR04MB10793 From: Peng Fan of_gpio.h is deprecated, update the driver to use GPIO descriptors. - Use dev_gpiod_get to get GPIO descriptor. - Use gpiod_set_value to configure output value. With legacy of_gpio API, the driver set gpio value 0 to assert reset, and 1 to deassert reset. And the reset-gpios use GPIO_ACTIVE_LOW flag in DTS, so set GPIOD_OUT_LOW when get GPIO descriptors, and set value 1 means output low, set value 0 means output high with gpiod API. The in-tree DTS files have the right polarity set up already so we can expect this to "just work" Reviewed-by: Linus Walleij Signed-off-by: Peng Fan Reviewed-by: Bartosz Golaszewski --- sound/soc/codecs/wcd9335.c | 15 +++++++-------- 1 file changed, 7 insertions(+), 8 deletions(-) diff --git a/sound/soc/codecs/wcd9335.c b/sound/soc/codecs/wcd9335.c index 7cef43bb2a8800971604b0e1ac55aac26c5919bd..8ee4360aff9293178e338e3ef300c37f6f2ac809 100644 --- a/sound/soc/codecs/wcd9335.c +++ b/sound/soc/codecs/wcd9335.c @@ -17,7 +17,7 @@ #include #include #include -#include +#include #include #include #include @@ -331,7 +331,7 @@ struct wcd9335_codec { int comp_enabled[COMPANDER_MAX]; int intr1; - int reset_gpio; + struct gpio_desc *reset_gpio; struct regulator_bulk_data supplies[WCD9335_MAX_SUPPLY]; unsigned int rx_port_value[WCD9335_RX_MAX]; @@ -4975,12 +4975,11 @@ static const struct regmap_irq_chip wcd9335_regmap_irq1_chip = { static int wcd9335_parse_dt(struct wcd9335_codec *wcd) { struct device *dev = wcd->dev; - struct device_node *np = dev->of_node; int ret; - wcd->reset_gpio = of_get_named_gpio(np, "reset-gpios", 0); - if (wcd->reset_gpio < 0) - return dev_err_probe(dev, wcd->reset_gpio, "Reset GPIO missing from DT\n"); + wcd->reset_gpio = devm_gpiod_get(dev, "reset", GPIOD_OUT_LOW); + if (IS_ERR(wcd->reset_gpio)) + return dev_err_probe(dev, PTR_ERR(wcd->reset_gpio), "Reset GPIO missing from DT\n"); wcd->mclk = devm_clk_get(dev, "mclk"); if (IS_ERR(wcd->mclk)) @@ -5023,9 +5022,9 @@ static int wcd9335_power_on_reset(struct wcd9335_codec *wcd) */ usleep_range(600, 650); - gpio_direction_output(wcd->reset_gpio, 0); + gpiod_set_value(wcd->reset_gpio, 1); msleep(20); - gpio_set_value(wcd->reset_gpio, 1); + gpiod_set_value(wcd->reset_gpio, 0); msleep(20); return 0;