From patchwork Tue Mar 25 07:18:25 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Mike Looijmans X-Patchwork-Id: 14028165 X-Patchwork-Delegate: kw@linux.com Received: from AM0PR02CU008.outbound.protection.outlook.com (mail-westeuropeazon11023122.outbound.protection.outlook.com [52.101.72.122]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5E4AF1891A9; Tue, 25 Mar 2025 07:18:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.72.122 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1742887129; cv=fail; b=Lw/OB3eWTnPhr403HdCqZbJX5VyZVrf1CL8wa1K33/szGC35zVeRls2eTwts54DAoZtswHyHI+0fKC+UeVb7U61FM8lqf7cxCoCozGkQS26HxMUF3WjMXcnCs2UVplSylJp/jJMcr6/73/PSxR6RXBKgPlrgOVXE2pxuMXjc/8A= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1742887129; c=relaxed/simple; bh=uVj6NBDJGgAPbEysIw5fhQFau52AWh0K6U9h2HYsaE4=; h=From:To:CC:Subject:Date:Message-ID:Content-Type:MIME-Version: References; b=axSfi75VjpXnSY9rKEKkXfJcYqT4EEvhySHBgDvWpiPX0qMhsKbSUFmVmkDNYI+1BWzQ+9cMNoSulNr/ckDtheMLgKDvh72Q9aHUXtsQVCGSOFRTMJ1YuLw1WJiotz8Jcm0DZ20zEnGvOI1l5lra3Tj+6VE+VR8jgEiupCBlJBA= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=topic.nl; spf=pass smtp.mailfrom=topic.nl; dkim=pass (2048-bit key) header.d=topic.nl header.i=@topic.nl header.b=PD77xtb8; arc=fail smtp.client-ip=52.101.72.122 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=topic.nl Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=topic.nl Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=topic.nl header.i=@topic.nl header.b="PD77xtb8" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=uMDmVexTQd/NkG3sy+mruaiVspkGGLAUf+IvDnFByFSsl2SaYGR4nGOFbB5gx3KOhZFexwZw2V+xzeAzAWWRphMsLBGSAe5YFRH9qeqJuP4S6xPSB8q2kanl5bxnPT4nwISZIvhVVilIYwtM+3dwn+XOW7AMvcIPBi0LLb2KZA6XpuH6//2Sc9YJxIc55AzASIxl/UgdYwFqLrUe04t0kbv/karhPKoWvsTE6eDyDIhsp2Oa2JA+cjN7BGOQImiKQbXLmOWeW30iVL08aH9Bg1BlP2BoKPzm3H9b9K2AXLxIFlKUBmT5j/QdTxLjNKluVSiEyOS/1AjJs+t2XUUwdw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=NBvua+gENZrYzxeXNsdTJXQUC5BEESbKKt6DLEMsFOs=; b=uYpbnLn+gc3C5VS3bFktZMux6LKeF6WS4Hw+5RjJVJPfCOD6hoztnXuynl+1f0eIPEdWBUradV/SIqJioFspUbrkeDijUyjZM2ASvrjODVNF7CHtzkxJskMMKTuNqrBgUGbhYy3DkmrYA3MDOeAyX2EsKTUWi29euG55pw1/hcSI7OHQ1l6cXyj19BQhAjY/kVXgWI8fdM+Dwf4LbvUbPgrEmYMlkesjv7GqLM8z2yMmrDJvhQyXGwVfylRIOIFh1/cMGHTKNCx31uzy1014gm63Kxi1VFTL3rytk7FAWHyS3GhK1lYmzpjP48MPXrICA/gy/+Mmvo4rRHhE/tY8Bw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 13.93.42.39) smtp.rcpttodomain=vger.kernel.org smtp.mailfrom=topic.nl; dmarc=pass (p=none sp=none pct=100) action=none header.from=topic.nl; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=topic.nl; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=NBvua+gENZrYzxeXNsdTJXQUC5BEESbKKt6DLEMsFOs=; b=PD77xtb8Ft62XXW3bOF5jZznVXRKVA1laIokZOT1RqZiEPGd6s0UHc2wkTYb1JJ6EV5/xGiEETpP4BAZ+FGy1aETZHX3DbIyRRdYQDE/CemLX6bdzWEpgLlmGAfSuGqiFkibFSR+3FexwTkUsJyh3xBvMDvmLhpq3IxBoG0cPIX0C/XImKpb4sgd4QjgoRdf3zR9Ep3pHYL3mVq4SqrZaktFDriwHeBWddZuWLmPaLeNqeS9SLHGEFcdn4x0vneND0Z0e4bUF6wY0IMzXlr407g54AdZ7O27UfaJ/la07BWKz+kGIjKI7H6voHZ7U+tBUSqqeVdJ4/+byYApUO0wew== Received: from DB8P191CA0014.EURP191.PROD.OUTLOOK.COM (2603:10a6:10:130::24) by DU0PR04MB9494.eurprd04.prod.outlook.com (2603:10a6:10:32e::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8534.42; Tue, 25 Mar 2025 07:18:43 +0000 Received: from DB3PEPF0000885A.eurprd02.prod.outlook.com (2603:10a6:10:130:cafe::dd) by DB8P191CA0014.outlook.office365.com (2603:10a6:10:130::24) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.8534.42 via Frontend Transport; Tue, 25 Mar 2025 07:18:43 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 13.93.42.39) smtp.mailfrom=topic.nl; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=topic.nl; Received-SPF: Pass (protection.outlook.com: domain of topic.nl designates 13.93.42.39 as permitted sender) receiver=protection.outlook.com; client-ip=13.93.42.39; helo=westeu12-emailsignatures-cloud.codetwo.com; pr=C Received: from westeu12-emailsignatures-cloud.codetwo.com (13.93.42.39) by DB3PEPF0000885A.mail.protection.outlook.com (10.167.242.5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8534.20 via Frontend Transport; Tue, 25 Mar 2025 07:18:42 +0000 Received: from AS8PR03CU001.outbound.protection.outlook.com (40.93.65.54) by westeu12-emailsignatures-cloud.codetwo.com with CodeTwo SMTP Server (TLS12) via SMTP; Tue, 25 Mar 2025 07:18:42 +0000 Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=topic.nl; Received: from AS8PR04MB8644.eurprd04.prod.outlook.com (2603:10a6:20b:42b::12) by DB9PR04MB9353.eurprd04.prod.outlook.com (2603:10a6:10:36d::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8534.42; Tue, 25 Mar 2025 07:18:39 +0000 Received: from AS8PR04MB8644.eurprd04.prod.outlook.com ([fe80::e86d:f110:534e:480a]) by AS8PR04MB8644.eurprd04.prod.outlook.com ([fe80::e86d:f110:534e:480a%5]) with mapi id 15.20.8534.040; Tue, 25 Mar 2025 07:18:38 +0000 From: Mike Looijmans To: linux-pci@vger.kernel.org, devicetree@vger.kernel.org CC: Mike Looijmans , Bjorn Helgaas , =?utf-8?q?Krzysztof_Wilczy=C5=84ski?= , Lorenzo Pieralisi , Manivannan Sadhasivam , Michal Simek , Rob Herring , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH v2 1/3] pcie-xilinx: Wait for link-up status during initialization Date: Tue, 25 Mar 2025 08:18:25 +0100 Message-ID: <20250325071832.21229-1-mike.looijmans@topic.nl> X-Mailer: git-send-email 2.43.0 X-ClientProxiedBy: AM0PR08CA0013.eurprd08.prod.outlook.com (2603:10a6:208:d2::26) To AS8PR04MB8644.eurprd04.prod.outlook.com (2603:10a6:20b:42b::12) Precedence: bulk X-Mailing-List: linux-pci@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-TrafficTypeDiagnostic: AS8PR04MB8644:EE_|DB9PR04MB9353:EE_|DB3PEPF0000885A:EE_|DU0PR04MB9494:EE_ X-MS-Office365-Filtering-Correlation-Id: eef0e732-a619-4ff1-2e5a-08dd6b6d4646 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0;ARA:13230040|366016|1800799024|376014|7416014|52116014|38350700014; X-Microsoft-Antispam-Message-Info-Original: 38JKLL4nQzu5Y1wJMG1fEi8CUCk1HMkJ4pZC9gcEcsv9yPKFujloaCdXoso93WIYNwiknSV1gDo2p8xtIus2TL67JGvU+qqoSJ/udx8qBGpGAUEnwa9vPmTOdW0/iwE1DPv3N8ZZ53uoT7ARlFrqCqEthTsCyNyhvsecmagVoeJ99lsmSiWkRcv27E1OAm5zgYytjZpZYOeAZi+aKJgo0KVgl7R0S2n1jPujUw4jYpu6jI/+c+WNsznjj2MYwax6DqA4O7AK+n9F5N7xk50xdpN2fJTSsSBJwnbezqAKS9BDFJ5HIY3YAP65rRT3J5uacKnbSgR41Q1RXCypUFCzlJ44mXNfLXs9Tat/uE6gkJ1O5e4SdYcNYv6yADgz2PNfhkKQHpqwPIHO3NUCldqjZ4Sp7TVZo1tbVLKr7BeCb4q8uR9lOO52hQOwPKBRJ/nkTVq1k0ea3bIPJqNnh5ic9tqMAMd+bVKSG7bpjNcjDZ8Hjn+FpUuO+CIrnPBd52DP3l3RxdSNrh0utsZ/IbqcK8PrGB79a72EgjGmRngYogMvyrsp3Vrf+dIla8jbrYvy37v7arIpp+kxSHmKE43dXzbKL0oOpg/F41QfbKliy5kLq6+ikz97cSRSPbAYiivB5wjGDpH8l/mfItOO7pBYpAHyn2XVbiYy2k3NoioOxoQtonhtj6S+1CgBjilsEO7iyqwMqu6zgvZD+BIlq1ZzbdIpJP2HLCFG2VAA8zExN04kT7l5EHU+iYb4Ly/r3+maDMzBAtRV02a1EkHggHWc4nbT0cjUWmkKh9EPzib0JJolVFy/EmZtzWIrjftRA3GJrYxq0vfcs7KViOzEqdmwaK/dG540pQtq0c+Hzj0h+XsoRKXQXt1pRjUeUtSEyMkMupzFLKX1WePrO2dPBfs2boFlgX0LHbQ4nXcAXauqan4MWZtO+u64LpBJkRjXY+0IAsEQDhWLOAdd0LmBkr7a7zplKaZwgxmJdigaPkXXdXCEyzv3w26MqPJVKwXJHXQGDLFwM4ZOSYrKD22O9QR1uhLz6y+tiGoJ6uwy+G44XZYurSQCGSiBi0lvitju19RO4W6mqDY5CC1WSeVAkI79EnsGdvCYtST7UFi2xLZHJtozzCbDQqKwPbNnc4ERuhsAmnCxKh1XBbb/qL2yZ4tXcBWi5ynwHtKdf6ThTRnwWAxfniFe1yB36Wglg3dXq9uG8etmUwwiUI3Y2xcVFt2EKJoj99JvPoL005Zga/iPJ7wThAiUa8WNRm0Z28vEMCKUO+6hJmMlSLu/uIDaPm60eujKPAD+TtJTuE7164QDZ3Jf5grgpUppPS+ymwrVgSkRQ5v6Bwp+Vaz+De0xlknWQfPeAlXQzQTpJ1ANnakiy4tB1w/sDJvmU9llanYPcYAW+d6QGi85AgJE8miXtTYKNpUM5UXTPzCGSXsgvX2t3WsenPQ1MrvqaDoe3iVYEvyp X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR04MB8644.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(366016)(1800799024)(376014)(7416014)(52116014)(38350700014);DIR:OUT;SFP:1102; X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9PR04MB9353 X-CodeTwo-MessageID: 80fa15c7-4cbf-4d62-b409-f20133d0a355.20250325071842@westeu12-emailsignatures-cloud.codetwo.com References: <1b153bce-a66a-45ee-a5c6-963ea6fb1c82.949ef384-8293-46b8-903f-40a477c056ae.aa50e046-9cb9-4d7e-b920-ce2956412b9d@emailsignatures365.codetwo.com> X-CodeTwoProcessed: true X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DB3PEPF0000885A.eurprd02.prod.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: aaf6df5c-3bed-419f-5aff-08dd6b6d438c X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|36860700013|82310400026|376014|7416014|35042699022|14060799003; X-Microsoft-Antispam-Message-Info: 7N1QwSaUbq1O8einPbXeq9Q3hcUWKDJ3ArblBQoNBgYy8EDkjBJ87wOTjHAlpLys0LDJzNo4wvW59eDdGARZwTTzoegca4c8hEUNAMkihJnt6p2zEs2/p+7rgtQjoivA492ZQlu5LI2cIwyFotaocj2H8eNwA6Vp/YU676ucgft0VASTqB0sVsEDrs2DM6brh+3bBqcq3KNz4KpwklH6PWNFMrZbVSe4PMWmlKIdT2RMtJsHZ27R+RmeyBprHFDsh8HLbFEhtPXINQgAOnLj2XgWm+Dm8YGB93uaY2yWeYF0rHFUHADoFvCpJ2leT+Vfiai5ulZTTzsaVgoXcue2JNvOjYJLV38uq/PzgakARgEJWQSCitrQvXzn2htbDTl6PTPdByWaO9xsvRCU06ASAfItVuNP/ga8W6kWOllAHvcY3ekZe/JwltOIRaMHhnJTagfSgMK6hz7q9JrQq47YdwOAeF8Vqdid8zca4asS134fORDgE6PAraoTJIZzHsPJ/DokhgYjmDQaod2pw9VzOswIz0mTjIgKYMdQ97weoevbNDPnVJrINwxa36Nr5buDw4xqQyVbnv0U64IAhy0qmITMKGne/DNICtqJ4x91EYoylPr4Mu5c/poX6bt3hrqi52U/7gisaK7hAx2LzEY9FrgkpbxF/r1ahbEjOhayzZdfP8MW7IAPLeUFfFrTd/t3iuo0i3DWGaYfYSFNceTN7pZEvAUxgE3Gug8qpMNgWhHnN/AEMPEgyUNniyCjjDybdIoqkV7TJQCHVs/j01do7ErK2c3Mo1tqT4xEI2RLuoKCiEwC2LvUbw01PA4tjBWCtir7TAkL8hoclu4eENH0TzBKrN0U9XgcA60ftfkKh/wLbKPl577dNJn82wqdbbocKuy7IndkfgR8SpAfUIkspklcd240GjsBkRGgMRZvEohyMZD+D0LgXI/LCHVYF5pMmSk0o40JyrYSI9actAN2vxmD/go4oXRh0sNurp0aYBXyEPFNludDoi9mQ1ZyNt2g2Bo+TJiTfjc9gB7EIKWnXYERds9hhM+2KjVr6S5qIHTGp9I3qD6arC9DY/3+Pa2htqshSp3utccD40YdaXlL8dDCm8fqgY0WXzG19CJ6X7+soj3htZ0kAw3iCQIXe2PaY12zCNxqmhGyflC6kWmNlFKBuPg3/OJ6EQIXhLczaYXJch4BoF5xuriAXMOvTsN0Ufb4jzFkp74KCqkvvIbtW4FXylQE6u/ryHWrAWVPIf+9LIKzb214N4h/SUAYPXkkbeirN7QsBPynwICX6yGp7jv6v5mOQ8CFILV6GoTcjqrbWC8zZs1iOln1XacqrMvjSbrkyva7Q8IFr9Rsd3BgKQnK7xD8EzMV8h3Wm9R7wQop0xgBo22MiOj+nXpsL205jCDsUgGOr2RcH78TPYsOfLoSymDd7AOfbZThTdlk1ro= X-Forefront-Antispam-Report: CIP:13.93.42.39;CTRY:NL;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:westeu12-emailsignatures-cloud.codetwo.com;PTR:westeu12-emailsignatures-cloud.codetwo.com;CAT:NONE;SFS:(13230040)(1800799024)(36860700013)(82310400026)(376014)(7416014)(35042699022)(14060799003);DIR:OUT;SFP:1102; X-OriginatorOrg: topic.nl X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Mar 2025 07:18:42.9371 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: eef0e732-a619-4ff1-2e5a-08dd6b6d4646 X-MS-Exchange-CrossTenant-Id: 449607a5-3517-482d-8d16-41dd868cbda3 X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=449607a5-3517-482d-8d16-41dd868cbda3;Ip=[13.93.42.39];Helo=[westeu12-emailsignatures-cloud.codetwo.com] X-MS-Exchange-CrossTenant-AuthSource: DB3PEPF0000885A.eurprd02.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU0PR04MB9494 When the driver loads, the transceiver may still be in the state of setting up a link. Wait for that to complete before continuing. This fixes that the PCIe core does not work when loading the PL bitstream from userspace. There's only milliseconds between the FPGA boot and the core initializing in that case, and the link won't be up yet. The design only worked when the FPGA was programmed in the bootloader, as that will give the system hundreds of milliseconds to boot. As the PCIe spec allows up to 100 ms time to establish a link, we'll allow up to 200ms before giving up. Signed-off-by: Mike Looijmans --- Changes in v2: Split into "reset GPIO" and "wait for link" patches Add timeout explanation drivers/pci/controller/pcie-xilinx.c | 16 +++++++++++++++- 1 file changed, 15 insertions(+), 1 deletion(-) diff --git a/drivers/pci/controller/pcie-xilinx.c b/drivers/pci/controller/pcie-xilinx.c index 0b534f73a942..2e59b91f43e0 100644 --- a/drivers/pci/controller/pcie-xilinx.c +++ b/drivers/pci/controller/pcie-xilinx.c @@ -15,6 +15,7 @@ #include #include #include +#include #include #include #include @@ -126,6 +127,19 @@ static inline bool xilinx_pcie_link_up(struct xilinx_pcie *pcie) XILINX_PCIE_REG_PSCR_LNKUP) ? 1 : 0; } +static int xilinx_pci_wait_link_up(struct xilinx_pcie *pcie) +{ + u32 val; + + /* + * PCIe r6.0, sec 6.6.1 provides 100ms timeout. Since this is FPGA + * fabric, we're more lenient and allow 200 ms for link training. + */ + return readl_poll_timeout(pcie->reg_base + XILINX_PCIE_REG_PSCR, val, + (val & XILINX_PCIE_REG_PSCR_LNKUP), 2 * USEC_PER_MSEC, + 200 * USEC_PER_MSEC); +} + /** * xilinx_pcie_clear_err_interrupts - Clear Error Interrupts * @pcie: PCIe port information @@ -493,7 +507,7 @@ static void xilinx_pcie_init_port(struct xilinx_pcie *pcie) { struct device *dev = pcie->dev; - if (xilinx_pcie_link_up(pcie)) + if (!xilinx_pci_wait_link_up(pcie)) dev_info(dev, "PCIe Link is UP\n"); else dev_info(dev, "PCIe Link is DOWN\n"); From patchwork Tue Mar 25 07:18:26 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Mike Looijmans X-Patchwork-Id: 14028167 X-Patchwork-Delegate: kw@linux.com Received: from AM0PR02CU008.outbound.protection.outlook.com (mail-westeuropeazon11023108.outbound.protection.outlook.com [52.101.72.108]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DE2D6252914; Tue, 25 Mar 2025 07:18:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.72.108 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1742887133; cv=fail; b=cHEEm1phovfbGp3Gsnz1D/rSE6mrrXU80VH0z9c89jJZikpe/wNcaxu4VtqZP2KeQP8RnVn6og1fOMcdeDB5UhcVaAt8MV5zHVd1ngscPyzoKnrRu91n7f7INhF4mKNA7f+vEgEmEoCkYfgokRKm8W0e29lpTS+KN85C3ZrCJmQ= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1742887133; c=relaxed/simple; bh=2PTkXYsUZRchIzpzuFOUVs3cyj82NePeHpEGM7q5oSc=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: Content-Type:MIME-Version; b=IFgMVQd5pnJ3U1hH1iyBmxX+i/g5z7OK+/r+PzfhNvQvO9Yz7xfylZbzHaFsJ1IXrbGTBEKXYcFWdMo1uM0plVUm3L4SQdfELoaShOmnLyz7K59bET3S54kbR+bw6ERewi3BLFQgHNFiS1EbFlEURJlUrAVTRl9M1LXbCyIVq/I= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=topic.nl; spf=pass smtp.mailfrom=topic.nl; dkim=pass (2048-bit key) header.d=topic.nl header.i=@topic.nl header.b=Hdlxqw0R; arc=fail smtp.client-ip=52.101.72.108 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=topic.nl Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=topic.nl Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=topic.nl header.i=@topic.nl header.b="Hdlxqw0R" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=W0XgJ350JyA5tHkyqGELbKZC+lZZYmc9jGX1vDyYWxkUOsPUWbqw+o+f8qd5HvvnGt/PJ+uDqzv9VCcLn5haM420IwHOnNwir9RcufnjD7s0iobPS9z/TU6zCFqKUSjTAB9P1zN4ZWQLj0tyKqu9JU8TaZ99P9rAEIfO52OAmOc+XK11HH1gC7Tc8gml3Bzr5g12W1+NOUWU9Wp9o3zfSFCZe1w4w0d38gXx3I0Rifb8b8xv805IhH/Cxd3zubzVG4MXwuzpOgQfw/FaOS1h8mYpZ8bhD65x19gCLRB4e8aXZfMbU4+fDw5+bRLXXH5HW0i/jZ+v96cWXh0Iihp5pQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=YhFcQ5xPTvcK2iemGk5D+7nAhQZDbMqMW1Nggha0pzc=; b=lWiPDww2Bguqi/AveiJXoV2NmZYyNpOMDRtivdDweFlPfErY0w0/c+X18ONjZERTZV6mbAoAM9Vq5DHBpHjnuA7x+fN2R7LN9/UOUCV4gUM1NGbdPhbQf3etfWSZmtlBWRkN9KhvoQ/qzGxF5cmogL99QXVPZ+bjJQhhEa1TD2ZxxnLoSZ9/Wz7UJlYHhvRf9Bl0ccQYJEMBeZ766eUdOLfmo8CjmjENlZ6efRJbrOhanDukQfSkuJijB41E64+PqaDxPg21EhP1Qrfyzp0nZtJompkOiyLTgX2K5/GST92e4G70rvslz+LsIq7pD4PoGiy1nBwVDX3BoOWjXrvKjg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 13.93.42.39) smtp.rcpttodomain=vger.kernel.org smtp.mailfrom=topic.nl; dmarc=pass (p=none sp=none pct=100) action=none header.from=topic.nl; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=topic.nl; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=YhFcQ5xPTvcK2iemGk5D+7nAhQZDbMqMW1Nggha0pzc=; b=Hdlxqw0RAugROFNsF/RArgCdFfyp6JvR9hHkPSOXSwdP11DBCb+ghYzjiXwcJ/AejfB40JtvCPKzeGZjETJ0r8OK/jmQOo8IiWvlv2STfVv0JMracjA9mnZl0rix5MGF3Xjzzy3OBuDysYsjSv/hZgM6dAKWkTYERdChymCPtsjGtCwigwCj3qTkaKKq5xJ4YmkWmQgHq91ooysPItvhB/WPKtwuBrNqxI2bdjG+QqkhnD5T7oa/YTzVHH3OEN5aZTP3YMQmx7RI9yQkiYVYpI5McwOmINdfQRQ5v7Q5WILRAmiHuV4HsztAx2OFQFkYriZZEXPh8rDf4+ETdboJlw== Received: from AM8P190CA0026.EURP190.PROD.OUTLOOK.COM (2603:10a6:20b:219::31) by VI0PR04MB11071.eurprd04.prod.outlook.com (2603:10a6:800:262::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8534.42; Tue, 25 Mar 2025 07:18:42 +0000 Received: from AMS0EPF000001A1.eurprd05.prod.outlook.com (2603:10a6:20b:219:cafe::91) by AM8P190CA0026.outlook.office365.com (2603:10a6:20b:219::31) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.8534.42 via Frontend Transport; Tue, 25 Mar 2025 07:18:42 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 13.93.42.39) smtp.mailfrom=topic.nl; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=topic.nl; Received-SPF: Pass (protection.outlook.com: domain of topic.nl designates 13.93.42.39 as permitted sender) receiver=protection.outlook.com; client-ip=13.93.42.39; helo=westeu12-emailsignatures-cloud.codetwo.com; pr=C Received: from westeu12-emailsignatures-cloud.codetwo.com (13.93.42.39) by AMS0EPF000001A1.mail.protection.outlook.com (10.167.16.231) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8534.20 via Frontend Transport; Tue, 25 Mar 2025 07:18:42 +0000 Received: from AS8PR03CU001.outbound.protection.outlook.com (40.93.65.54) by westeu12-emailsignatures-cloud.codetwo.com with CodeTwo SMTP Server (TLS12) via SMTP; Tue, 25 Mar 2025 07:18:41 +0000 Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=topic.nl; Received: from AS8PR04MB8644.eurprd04.prod.outlook.com (2603:10a6:20b:42b::12) by DB9PR04MB9353.eurprd04.prod.outlook.com (2603:10a6:10:36d::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8534.42; Tue, 25 Mar 2025 07:18:39 +0000 Received: from AS8PR04MB8644.eurprd04.prod.outlook.com ([fe80::e86d:f110:534e:480a]) by AS8PR04MB8644.eurprd04.prod.outlook.com ([fe80::e86d:f110:534e:480a%5]) with mapi id 15.20.8534.040; Tue, 25 Mar 2025 07:18:39 +0000 From: Mike Looijmans To: linux-pci@vger.kernel.org, devicetree@vger.kernel.org CC: Mike Looijmans , Bjorn Helgaas , Conor Dooley , Krzysztof Kozlowski , =?utf-8?q?Krzysztof_Wilczy=C5=84s?= =?utf-8?q?ki?= , Lorenzo Pieralisi , Manivannan Sadhasivam , Rob Herring , Thippeswamy Havalige , linux-kernel@vger.kernel.org Subject: [PATCH v2 2/3] dt-bindings: PCI: xilinx-pcie: Add reset-gpios for PERST# Date: Tue, 25 Mar 2025 08:18:26 +0100 Message-ID: <20250325071832.21229-2-mike.looijmans@topic.nl> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250325071832.21229-1-mike.looijmans@topic.nl> References: <20250325071832.21229-1-mike.looijmans@topic.nl> <1b153bce-a66a-45ee-a5c6-963ea6fb1c82.949ef384-8293-46b8-903f-40a477c056ae.7424060c-f116-40af-8bb3-d789f371b07a@emailsignatures365.codetwo.com> X-ClientProxiedBy: AM0PR08CA0013.eurprd08.prod.outlook.com (2603:10a6:208:d2::26) To AS8PR04MB8644.eurprd04.prod.outlook.com (2603:10a6:20b:42b::12) Precedence: bulk X-Mailing-List: linux-pci@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-TrafficTypeDiagnostic: AS8PR04MB8644:EE_|DB9PR04MB9353:EE_|AMS0EPF000001A1:EE_|VI0PR04MB11071:EE_ X-MS-Office365-Filtering-Correlation-Id: 6e701b04-7760-4ed6-fa6c-08dd6b6d4608 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0;ARA:13230040|366016|1800799024|376014|7416014|52116014|38350700014; X-Microsoft-Antispam-Message-Info-Original: CnlR+IyMGz0xGBsgjGJyfZ1puYcK+5Ewc4+QmUaB5NSXiKfI9qec1GFiyt9d4UCqRk1lbs/GdqKsbgJCubXR0Xps4vqlElfo3H6qJ9+G21vKMktjDMx3S1s4eGb4f8ahx6CrKYaT4SPjp4ZTRMs+gZOEvJQUfQD5rv1DbAM+11du/BigwQkvhj1TYJoy4OIvZTz9DxkxfzhkjX6wa00fcVp3qZT3dUsImpKw5Gh5eIgNPIl+DwytWOglFqrYQr272+UT36xz62cr9ieg2kipsbAQpQjdCnoppvxcc29Hiv29ULQxpRBNHfRY8zuIWAvtaljOXkKEVygAz+uO7YZX7byBmlYQ5Tmb6kZ0ocMTPWCjl16AcZmM/b5RSnAirE//7oTkRezEhXSUBzLjg/vYu7HS5iKwtOBCf+BVWDAq9ZlLvdFFxaDAQGj86Kj10hAYowz2GPxzg2j/xZ77gU4wqn7UZrWX4UnO3FEMnXN6XFLWCUrebp/5k8juXOLQzTbGv9tIEzKqbVzNJIngqeqWe/URSATCk9ABjWTLPy3ZORL5yslGv3iQyPWpqFykr210fDHsJH/FuCutOPDuc4cfJg4Avl7HG96zALoBEfMFOrLGLTpJpLohgiApEIp4d62GzPxSqGyIPAxpuK6zhQWBprx4/gdEyoCspq514rNDGGgp0lp6gSQIT44YqQ5DZpoGcaelykh4Ub/SxmDmdEFnlYHtfRO6L3v6msqJMSef3QLXVbVWgbgM50QnrOn9WzlMiOyLmr5IS9fFG4KoWgUvGX7Wl5qOcKZnbE483pbgkA6E7V8BptlAvnImrwbm9t6RD7QajGW2Uqb5rDcu5Z3wgszmLII8r9vAXRaFXD/05h2cwXhCScXNpDqBTKt+d+hqR6t2lfQFPBPbkCOcM3eNuz5F1jbZAkQobexfvuWY0n1eNfFtZyGZ8sFK2KycFnUg3ISX4jZ5Ulqo39EhggubPYy0P54N8USkYRTMlADhGZ/jw/X3MluXB6+sSuALPXUtmUKQZqStYebHG0GbeUhfe+LC9OOnEU3aaRLCU8z0CAVf7Iqf+mWCjm2iTDIfIjIkMGDQZVRwPfmDQrcpeSQmRkL867AS8BtitgJAwI3ucKp/PTNw1mNSLT5jfi26VGQe2K2hGXQ8Z2TqtR+i1udzlhg85TD06ZVcsyhm+teYweH6yj1O/C3WPkRjZc5zUPq8r7le0Vo0CgVYScqNlDtzxbttvCdHwDX4xNuev0PjwXJ+z6M8ZeIenvV146iBX9rUy3ePR4+QDO2Fr8H3bOKUsMoo21YEx9C1tBBoW3oD9zNECwnKx0soiSDNBu4YSpyoUU1FDpqay4guqC8Oh/HgnA7M8gXjf5UQIVoJPT+mWWK/MlUefQ5fJXYwkoHX8S+NNKKOZpflRXu+8Xyc9w6ImcbTb/3R8LbJ1J5wmkUzqFWueLnPqt+C1QrXmJBXKzuQ X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR04MB8644.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(366016)(1800799024)(376014)(7416014)(52116014)(38350700014);DIR:OUT;SFP:1102; X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9PR04MB9353 X-CodeTwo-MessageID: 009c6fe2-c2bf-4351-900e-043b32a9c214.20250325071841@westeu12-emailsignatures-cloud.codetwo.com X-CodeTwoProcessed: true X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AMS0EPF000001A1.eurprd05.prod.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 4160111f-a6f6-4f50-6d67-08dd6b6d43dc X-Microsoft-Antispam: BCL:0;ARA:13230040|82310400026|1800799024|35042699022|36860700013|7416014|376014|14060799003|13003099007; X-Microsoft-Antispam-Message-Info: 9LmJPUyGx6TwrfyYvkJbra4yMqW1KxMfH+Cpp/M2FcYSm6ftfZlYr0tQccD4qGUZyIzyXp1a9edN+Pdd9haFLv3V26qN5alP7a/o8wjpq2wvi/RYJdIHoCxTA2Lg3eoeLAn232UC/Tm4PAHqDhGew9WYa51Vw/sZAZeS4mPkzdqud3Msv5dEVyBzmhyJ+AjRhFvxpU1UYaCEemQkXma42W6tHk7iRaHSVY077XnfeTWnmutk6NrNN4Ukad0zgEwHdCA7SBgghgSp4fVlLNSMoDZ8siwOa1WtOXHyIYhqT1K0dA19eoSOTNJOa+/4OYjH9YYapEpP2COTmnxDzHDO/VJFAYp7SH7P1rq6aNQqaQNJI5O81T4yTz98tOoV71CT+IQPhLxrHPSpTx9xeCaGuKYALen2FFe4oHCKlXxHk8Ar04/HVS+y69NrV6YVxsfQtAMNdrqUVRHiB3aLkQe3ylGN1mZUCIWX2Hg5EK43G2HdvwEEKwFDniX/A3bPWa62iuB9qh1nvru17HqhiArtU0iUr1PHzX6hQXweZSoearAbs/aRZ07Qf/GRxR9r6F3dcoHtkvvCLiGFbMjcwbGC71MQ4k7zZuYuSxMml4GanOE0O1lPC5tXyd0qm8MAWioQYkXbQ0+HTcTMVfkqElQ4JhT7j14NF1Dd3Gd2lqKKUIfv6TUnUpcQcfUH8fsyTJv2i/2+Rsnk9moGPcR45tjXr3XaVaYc8Undz7jnUANacu8wCzSmYXW0r4LfKzjOE4MB1qJLzfyxt3fuu6C1OXKmzRFnHjVc+aVhkH8gr1UIGTf5GJwgJkg/NlLCNVMqWAY95AXKX/RkC99iWW9dgJNPxykS5vtSCm1VhjaV76+J1jXjk25SMm0AAALabDQQu9anGqvSKDXXh/DlYjBKvWTpb+Zk3IEzyT9i3t5twynia58XjHw3OhwrLNONSTADZAsd9VNPbRNx9QxRGScFrm8r6qOnvXkqQqaW8MORuIk1xv7nFoWJYULN34S5ZJ444lBFC3KazZiKDtfGx5m5GhAPyUXo9dJt+e7MkdstU0PUI9y1aKIBLBzeYBaQvc1Nztam3qJf2YMeJivaGSp4McVkNmJ/667xiQMFzMsqpZ/SdKKDSsIv79qsfeDN80HU3Mhxd7HaXWv8oyr31TCH7jaQM1QxysLKXWgd/6Xqvd9MEHevOTyWt3wD5rWo/rhYATRdDuD903zHReeQGFzUMt1XaZJeNY9V8+iilu8LwR0pDU8GRqjsyY9ZCB4fBGoU7bBYUgEow6T4d5sYNx+QvtLE2kZZH7pGEOWFM2hn1HuMpNyPjJbJKXkeu5lppZ1EvTsK8OX2K/wykaoqLDTzlzOo+2f6WrLv2+chdqUNtwLIKOA34JlVvOvINd/cuBowCMUKqTnFjAoK1BkIrhDGU3Zv9/o9flZauazqrkWURKwoyts= X-Forefront-Antispam-Report: CIP:13.93.42.39;CTRY:NL;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:westeu12-emailsignatures-cloud.codetwo.com;PTR:westeu12-emailsignatures-cloud.codetwo.com;CAT:NONE;SFS:(13230040)(82310400026)(1800799024)(35042699022)(36860700013)(7416014)(376014)(14060799003)(13003099007);DIR:OUT;SFP:1102; X-OriginatorOrg: topic.nl X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Mar 2025 07:18:42.6766 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 6e701b04-7760-4ed6-fa6c-08dd6b6d4608 X-MS-Exchange-CrossTenant-Id: 449607a5-3517-482d-8d16-41dd868cbda3 X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=449607a5-3517-482d-8d16-41dd868cbda3;Ip=[13.93.42.39];Helo=[westeu12-emailsignatures-cloud.codetwo.com] X-MS-Exchange-CrossTenant-AuthSource: AMS0EPF000001A1.eurprd05.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI0PR04MB11071 Introduce optional `reset-gpios` property to enable GPIO-based control of the PCIe root port PERST# signal, as described in pci.txt. Signed-off-by: Mike Looijmans --- Changes in v2: Add binding for reset-gpios .../devicetree/bindings/pci/xlnx,axi-pcie-host.yaml | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/Documentation/devicetree/bindings/pci/xlnx,axi-pcie-host.yaml b/Documentation/devicetree/bindings/pci/xlnx,axi-pcie-host.yaml index fb87b960a250..2b0fabdd5e16 100644 --- a/Documentation/devicetree/bindings/pci/xlnx,axi-pcie-host.yaml +++ b/Documentation/devicetree/bindings/pci/xlnx,axi-pcie-host.yaml @@ -28,6 +28,9 @@ properties: ranges for the PCI memory regions (I/O space region is not supported by hardware) + reset-gpios: + maxItems: 1 + "#interrupt-cells": const: 1 @@ -63,6 +66,7 @@ unevaluatedProperties: false examples: - | + #include #include #include @@ -80,6 +84,7 @@ examples: <0 0 0 3 &pcie_intc 3>, <0 0 0 4 &pcie_intc 4>; ranges = <0x02000000 0 0x60000000 0x60000000 0 0x10000000>; + reset-gpios = <&gpio0 9 GPIO_ACTIVE_LOW>; pcie_intc: interrupt-controller { interrupt-controller; #address-cells = <0>; From patchwork Tue Mar 25 07:18:27 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Mike Looijmans X-Patchwork-Id: 14028166 X-Patchwork-Delegate: kw@linux.com Received: from AS8PR03CU001.outbound.protection.outlook.com (mail-westeuropeazon11022083.outbound.protection.outlook.com [52.101.71.83]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EB36419CC2E; Tue, 25 Mar 2025 07:18:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.71.83 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1742887130; cv=fail; b=Tzae+7+DIutvBTc+3teGPupDEnaCZweTakT8GoBPe5NSeHIVRjaQL+m8MsXKJW+0YCVMT9Cjq6MEvRB6EN+dU6AQHngR+kSdzEAgBaXHva1WFS7BwvS68LqbmAg8VtzV9K8Gw3xyKHOeAmIn10+NfSFnty7W8jYO07k7+9d7kVo= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1742887130; c=relaxed/simple; bh=8LrMiQNm+ovk/dvPZpNl1FPBCb4S8ihW8Kx3n1PPp0s=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: Content-Type:MIME-Version; b=gnhfjbOCCrMsH/6IRorlwtt9EwGVdh94+IFwa4e5Xhzc58kKA2EXRSK5cgLlt2zomxAZ6cbDOyVKPFq7crw+tSlb1Da6RZNNOWit/UGlomcQjVgbPNIHpwxcYwKODYWaA60XPQnCnYXIedDBBbCAGU56/lYK2lFqFMuVEvuT15s= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=topic.nl; spf=pass smtp.mailfrom=topic.nl; dkim=pass (2048-bit key) header.d=topic.nl header.i=@topic.nl header.b=cak0Uueu; arc=fail smtp.client-ip=52.101.71.83 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=topic.nl Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=topic.nl Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=topic.nl header.i=@topic.nl header.b="cak0Uueu" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=BMFcD42yw/1K1V61mH4jd2D5VL5migHxBNUZbMPl3ACI8kMn6syNt7zHEt/Z1wD81yGbxmBU6/9xweHl6dfBQwTchEoyw2E67BGmGLnH0gL2uCMudBrSfdVrW6nlwBgzhpDiuqbdBCp8Rue7mfYj0yFkOxYL0stmDGuZ+g0BWUoJPHB5t8PFh8gPIDd+J13ON88ARH4gev0J6ybPfe4F8e+M22bcI3OlIxnuUAJTrdzKMpCaft5J5KZP8GV9fprd+XAEZ953RO3o/euMmo5Byjo1mCsFtETdYzdvVlvqKcug3ULfpvQhTAC4qqFPlEE5DiJrh28/k+edxdDAUBSr2Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=dLo9YkjZ15cy2YtMT5cZ8K1WsUZkZCMJ3QVG6afXiiU=; b=ZJJq6aXyIvgxPkku1BkiWLtDLghSM9OZ6YuqE/8SjbYKjLtN2Rn9vuxq9OrFfvJje9EbBCzyCnLQXrxruiovxcjkwqqjc67kzm2ivV+NXWPZIYBoRS0Dj+zv9S0+l/rISZHm2TPqohQmHrHbE0s4SskZmlv8PYMtTCGerTpSx4L9h1l1JkuWzXhrk24zed/2ZZVCff4m7SkNCY3BEyLgArNpoz/PzgvYjoZ0nnoYb+1/Ff1Vzo4ocben4khILFTkVcI7+SxKzpu6+g2W6EF5qY+ZxNROIC9Xp7SUGkVWtbFLeKZ2mlaaUQFrT4S/tqNF/TUYYCDqiVsewC4HA5QNoQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 13.93.42.39) smtp.rcpttodomain=vger.kernel.org smtp.mailfrom=topic.nl; dmarc=pass (p=none sp=none pct=100) action=none header.from=topic.nl; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=topic.nl; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=dLo9YkjZ15cy2YtMT5cZ8K1WsUZkZCMJ3QVG6afXiiU=; b=cak0UueuwBtqxlLxIkLWpVZmA/Qw0nHkn11ESs4z/qp4TDubES5WLaSCTi7S4/jBjQ8Y5cRp5pncoMKT9FHTXuKQiu8TNz7vrEJDquH74kZv7AfD+xmnTfwxVf51f8Fnf2rYISc+ZmICfMMMNIOZa0qDJnq5+mUGgCfNKXT81iy1tzu5QWNBwJ2iwK0nVvco0M7qkw9bZNmxiW3DM11FePQ7ug2WFuhBYxlWcsrMwu7fW/AttyNcFuK+qDpDq2m6Nlucz+OXYKIGF8bjK+uF/25fYtuPZdzIdo9NT4IqJeJm665epYOPTvvB4DAv19ooWFgXXknmGU2fTymQL4klIg== Received: from AS4P190CA0056.EURP190.PROD.OUTLOOK.COM (2603:10a6:20b:656::27) by DB9PR04MB9234.eurprd04.prod.outlook.com (2603:10a6:10:372::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8534.42; Tue, 25 Mar 2025 07:18:43 +0000 Received: from AMS0EPF00000199.eurprd05.prod.outlook.com (2603:10a6:20b:656:cafe::d2) by AS4P190CA0056.outlook.office365.com (2603:10a6:20b:656::27) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.8534.42 via Frontend Transport; Tue, 25 Mar 2025 07:18:43 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 13.93.42.39) smtp.mailfrom=topic.nl; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=topic.nl; Received-SPF: Pass (protection.outlook.com: domain of topic.nl designates 13.93.42.39 as permitted sender) receiver=protection.outlook.com; client-ip=13.93.42.39; helo=westeu12-emailsignatures-cloud.codetwo.com; pr=C Received: from westeu12-emailsignatures-cloud.codetwo.com (13.93.42.39) by AMS0EPF00000199.mail.protection.outlook.com (10.167.16.245) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8534.20 via Frontend Transport; Tue, 25 Mar 2025 07:18:43 +0000 Received: from AS8PR03CU001.outbound.protection.outlook.com (40.93.65.54) by westeu12-emailsignatures-cloud.codetwo.com with CodeTwo SMTP Server (TLS12) via SMTP; Tue, 25 Mar 2025 07:18:42 +0000 Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=topic.nl; Received: from AS8PR04MB8644.eurprd04.prod.outlook.com (2603:10a6:20b:42b::12) by DB9PR04MB9353.eurprd04.prod.outlook.com (2603:10a6:10:36d::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8534.42; Tue, 25 Mar 2025 07:18:39 +0000 Received: from AS8PR04MB8644.eurprd04.prod.outlook.com ([fe80::e86d:f110:534e:480a]) by AS8PR04MB8644.eurprd04.prod.outlook.com ([fe80::e86d:f110:534e:480a%5]) with mapi id 15.20.8534.040; Tue, 25 Mar 2025 07:18:39 +0000 From: Mike Looijmans To: linux-pci@vger.kernel.org, devicetree@vger.kernel.org CC: Mike Looijmans , Bjorn Helgaas , =?utf-8?q?Krzysztof_Wilczy=C5=84ski?= , Lorenzo Pieralisi , Manivannan Sadhasivam , Michal Simek , Rob Herring , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH v2 3/3] pcie-xilinx: Support reset GPIO for PERST# Date: Tue, 25 Mar 2025 08:18:27 +0100 Message-ID: <20250325071832.21229-3-mike.looijmans@topic.nl> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250325071832.21229-1-mike.looijmans@topic.nl> References: <20250325071832.21229-1-mike.looijmans@topic.nl> <1b153bce-a66a-45ee-a5c6-963ea6fb1c82.949ef384-8293-46b8-903f-40a477c056ae.f2f40822-7953-4b0b-896f-3a325392c185@emailsignatures365.codetwo.com> X-ClientProxiedBy: AM0PR08CA0013.eurprd08.prod.outlook.com (2603:10a6:208:d2::26) To AS8PR04MB8644.eurprd04.prod.outlook.com (2603:10a6:20b:42b::12) Precedence: bulk X-Mailing-List: linux-pci@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-TrafficTypeDiagnostic: AS8PR04MB8644:EE_|DB9PR04MB9353:EE_|AMS0EPF00000199:EE_|DB9PR04MB9234:EE_ X-MS-Office365-Filtering-Correlation-Id: 1cec0869-d94f-4613-0671-08dd6b6d467c X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0;ARA:13230040|366016|1800799024|376014|7416014|52116014|38350700014; X-Microsoft-Antispam-Message-Info-Original: PyXTpevlucM3fvcq+q3UOh+RWB6711Q2tvavSCeFW7w4Dqjr7RtOaRXK0tTJtsQCqlEU2yn4n0si93+IP4dJWmMQZwjh0jUQpJGL9EqTAfpDSEh12MQZ5qdYQUjkxbC78qcA8bsUIAsRSOLc8oxJlRmnSzTpW8nsdJSwRphhv/P4X87Vii8MWQlN8b+avj8/CatJUPw6d0cl2sx3gKwkQ7XRWhFMg79cbOa8Plhhzpj1ljzes3MdOWtc6nBinmLyBgauaoV88m2gPV/GCIL9aqurTmxZsaTwB1kpcF0y7hAVnAC2E1xkAktP5Nl+7VDnkt7nHprHsAAGFaQlx8DH2wT2Lec5+s8m08gDO+UvTHUWwF7+189FGEnLG/KscQSQq4cLTQ+bovZu1nV+omAwhfOHF0vXWYsMZ4iYHiiG7a+zPzUq1zDz80xJfAc5giiLqhVRrh3e+89ZubxtSy2yBWqTBcA6UccW3LAd+mWg57k2PiwGhZ4iugU6111/PTkn+emOSl06SyTgldq8UnivfJjbCpo3QIkY3LC9Q04ySrXo/HMgeBIKfukscVRuc+IP6i37OQEzHzzD6GOp44uhyew0DyKtyhjYpgSnv4rMsq55i/myirL2i3/PnldJggFZvmORoqsVC4aiBgmYArdSmbLpH7sAsPVSmaP0BPkuKz/Q4z6k5TFGkksl0Y2P6glqeqtgIHDgolM2feE4A7XiU3esRJdhDsiCPN55Qau9Nsb6aLJeX9s8ca7m2H3ZLHoNx6NfaGihTbE2KLFj+PqWY0c6MVb81OlrFvxAFYVmfdR27B8mpmygV9KjDQKW2AfUF697U0G+uL2/3/xxlSKgIclWjKK0UN4uVSkyCWlNji0a+WLh0LRBwftmigUu+/OlGUrusXXoYQpNEOmM5DU2NrmH8CyOHBv/W7MrqNB1SPvDY+LguTbIFYtjkncBTUzuUCtmR3lVHgf99ESxzeWNPtF/wbKJANLqeCIU+po07DoaZgHMcRfHnoZAcNyDhuEDfL53DSZ3XWcq3DA/fT5BQ4TYQlVGJslrlPsrd5+70LrG5FJeNz4Pkk8MoK4IAcoE6dPmt4vKE+AtN+6tJJ5xDUlQ57oss8tthRoBSNsgNQsc/8bS9Lrikj+FbPLbWkZ1S4A85s0bODA4Q6LmKJFxF9T1NiH+012blL2+7OaYEBn5a4pBy76P5I5XWSZ+mnMBSAGAvhwqotcl9B5vhcI/Mq2lrKaUzoLMyV6KpNkT+knIQI+kbhUwgzjU+R9i84o5X380MdPUiw6Dt1Z/yGG3EDljEYC5YkUBwNcDeIKM2b/x+aj75jCVmY5IaScbDduT9HzYcLNMMV6KUo+A9EvhRDQbHsPTh5eZ1d65DG0ioRw9p/xxyCMENUNhuhoif5PqR6XjP7WGJ1GrOgIc9YekHc0T6aU126QKIy+E+PSIbBOWfPqriOdoUfY+bOp161wN X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR04MB8644.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(366016)(1800799024)(376014)(7416014)(52116014)(38350700014);DIR:OUT;SFP:1102; X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9PR04MB9353 X-CodeTwo-MessageID: a765cc7c-e15f-4fce-965d-543a995643b2.20250325071842@westeu12-emailsignatures-cloud.codetwo.com X-CodeTwoProcessed: true X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AMS0EPF00000199.eurprd05.prod.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: ced0a7ca-c9f4-47b4-b2b3-08dd6b6d4422 X-Microsoft-Antispam: BCL:0;ARA:13230040|36860700013|35042699022|376014|1800799024|7416014|14060799003|82310400026|13003099007; X-Microsoft-Antispam-Message-Info: VuJeEi8wbVUmyTjjOU6bDsEE9Uoa/vBB2etqR0A+/CKChTfEoaC2yh3QeLMX9s6hsfkmODMsgxchi8nXSUkvC8Cex5HvGlMATmZ09IQjsg228Ey0eabNuRaPfWh6fdnX7ZsgKoEuDG75/rk9Nkvc3Gs2gFrh9u8eNxj/bhQcanlMF0Ds/xeMWUPQEFGQns125/z5pcr5VOjuO/3UisuWkXyRLQDEBUcCzZ+7YYgS98+RhcxxEWTn688fkZBVnFaSid27C/Iolb2kpOix3cwpPiKY57IArRkl2zKDverRVI8TrP5x+jRhCDWmcEUqnHpPkAqO7HGqKYk3y5K5rqUINy8ChIpt/4sBhFNoEyV3TaySzqVpOZgowcJ9Nr9A8xvq++J4sxQhX/otRxLJRgZmNmZME+gq4Qnzfcjc9c7x840id7bkIN5G3OTv1x+ACwYhnJcBYyJei7IgxWxU4uNBTsr0C5ul2VUOPHtUYshigNjbUsqNIqcQ75mhdLsXFhPUnR/fW+DMo8yifjug4dD7GRyZ1Ptl8M5jTG3ovTUusATdnsYqO2iY80Hfk4qeu+N4R38Jo0YXdIuG7ajV2pk7ys+vjBM4j7ExzxtCfhg369SEkilZ/6+6IdiaoBsrNNqsG9kE2c99JXf1ansZEh4rnbraZKGmspMZ87cP4+TXnshlL5KsDqGbJElU/gIwqBxvV1QJvq1jWpF4kGJiW0N467/XqTO5UesszIi7pv3uAW0dGyBfdOUrs5ShnBuIdwj7w1DyneldaRkc4WC8OoKZ+K9VZuLZ+XwDIOhMTgp7SUSVJA08oL4Wb6fOzNHvOs1Q5xBr+hhzkGz3wXwDG5url/SZo1bmGzC1BPQDs7lEkq0hD/211li4sqS7NmRJ+G6UsiJA+j55gu44xHPXyU7li6O2xHUjaHau48X2HGJaD0V7QhbTsXvOeyEw9Y61GEYSlOsM7V+WtQIorn7np7bzBpFxyPUFea38UGCnnOYYhF9HVVr+IDR5hGNy2J+uT3XIedY/x+f2NQkGkY5VX8JpxMWcXp7tXo8G14cMSZYJmZIIaZqvpewY56n1jXNq3FuSUq2Az4s263k8ZNqm5NcyWpW/Jtmgmdt+pagtq/ZlG8i3aHG9pXTKff5NA6Z8sACDeyfgx0V2jBz8vI2bBBuIT7iNsMnz8f5dmjKxz5MMUbE0rcvW+O2dW8JUBjeQdqeF9sewe9iC7Z7MfYQMKK/Re7hBOfKUs3933XEC/xCW9INB8I5iL220NwodXNfiOzHzxXp2B4w4Al4HJUHBRro+EeJQGheKob44JKZFMfGESH3BhG+EqCPhFdLUJRNex+vvGbEgwSygYXh5Z3JAX9FCcd2dG1MN8QgWIfSMw0ajEP3ZVUeKut/twTs3Y58yokU9FZp2tjx7tfVefpxa7JCFU8O1nWbbSDEEkLjvn0KT/PU= X-Forefront-Antispam-Report: CIP:13.93.42.39;CTRY:NL;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:westeu12-emailsignatures-cloud.codetwo.com;PTR:westeu12-emailsignatures-cloud.codetwo.com;CAT:NONE;SFS:(13230040)(36860700013)(35042699022)(376014)(1800799024)(7416014)(14060799003)(82310400026)(13003099007);DIR:OUT;SFP:1102; X-OriginatorOrg: topic.nl X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Mar 2025 07:18:43.4150 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 1cec0869-d94f-4613-0671-08dd6b6d467c X-MS-Exchange-CrossTenant-Id: 449607a5-3517-482d-8d16-41dd868cbda3 X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=449607a5-3517-482d-8d16-41dd868cbda3;Ip=[13.93.42.39];Helo=[westeu12-emailsignatures-cloud.codetwo.com] X-MS-Exchange-CrossTenant-AuthSource: AMS0EPF00000199.eurprd05.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9PR04MB9234 Support providing the PERST# reset signal through a devicetree binding. Thus the system no longer relies on external components to perform the bus reset. Signed-off-by: Mike Looijmans --- Changes in v2: Split into "reset GPIO" and "wait for link" patches Handle GPIO defer and/or errors drivers/pci/controller/pcie-xilinx.c | 14 ++++++++++++++ 1 file changed, 14 insertions(+) diff --git a/drivers/pci/controller/pcie-xilinx.c b/drivers/pci/controller/pcie-xilinx.c index 2e59b91f43e0..e191ab95d669 100644 --- a/drivers/pci/controller/pcie-xilinx.c +++ b/drivers/pci/controller/pcie-xilinx.c @@ -18,6 +18,7 @@ #include #include #include +#include #include #include #include @@ -577,11 +578,17 @@ static int xilinx_pcie_probe(struct platform_device *pdev) struct device *dev = &pdev->dev; struct xilinx_pcie *pcie; struct pci_host_bridge *bridge; + struct gpio_desc *perst_gpio; int err; if (!dev->of_node) return -ENODEV; + perst_gpio = devm_gpiod_get_optional(dev, "reset", GPIOD_OUT_HIGH); + if (IS_ERR(perst_gpio)) + return dev_err_probe(dev, PTR_ERR(perst_gpio), + "reset-gpios request failed\n"); + bridge = devm_pci_alloc_host_bridge(dev, sizeof(*pcie)); if (!bridge) return -ENODEV; @@ -596,6 +603,13 @@ static int xilinx_pcie_probe(struct platform_device *pdev) return err; } + if (perst_gpio) { + usleep_range(10, 20); /* Assert the reset for ~10 us */ + gpiod_set_value_cansleep(perst_gpio, 0); + /* Initial delay to provide endpoint time to restart */ + usleep_range(1000, 2000); + } + xilinx_pcie_init_port(pcie); err = xilinx_pcie_init_irq_domain(pcie);