From patchwork Tue Mar 25 12:30:15 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Prashanth K X-Patchwork-Id: 14028935 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E9D4A267AE1 for ; Tue, 25 Mar 2025 12:30:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1742905838; cv=none; b=iqIOf4ihVpHkGlddUO6YnIh5rEgbNL0lKVeP0cwtMtRdVlPWSmPeEHlHDIV6LqXWITrOYGkniQle6/66FB6DCrImGQqon8FOZFKw+lvJgVdBu7Y2Tlb2ER/gabEUfVrqb6/xXl2KMdV0K0XoBhNNcjv2e2ENkeood1QljE4Oio0= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1742905838; c=relaxed/simple; bh=C6NTSl0+Rao98kSjPlvJlJr9IoIUUdvL89mpuJUpsPw=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=I7ia3/7GbgwoOKbKPuaAr1crHGJQGsAcVuJELJGRcPd66c/dbZqQJSgnDti0Qap8LcncE6VHQYrjSfpblZIaWw8SAXujaRbNhkuWudWqtR/KdIP6ojxdq+SR1RkoqO7duXYz9JRIPhWm5bAm/dOi8dmHPWffxJ6qnDVUqKYoVC0= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=LvU8TgVN; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="LvU8TgVN" Received: from pps.filterd (m0279865.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 52P5vQnD008060 for ; Tue, 25 Mar 2025 12:30:36 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:date:from:in-reply-to:message-id :mime-version:references:subject:to; s=qcppdkim1; bh=Djrd/4JquWX DbU+icEttWqizSKPX1yxwU0bvPWCgU/w=; b=LvU8TgVNJsQgO4qNIXXeQyYTk0o g41uEQteuyHtcgDITr2HwMbcs4g7kouzJPWmO+2pI6/sZySrhtUkv94xrAfi9SD0 1iAjuAZXSSfrFE1m6BA7aQV6K+evsHUcaYQcBKCtTYwQPqDUyqSSHy3K1qFOR3wE ZFac0vkKUioFTWz8jvrnLtyqCTi6z/D6ltBvLlyyW+mKEAGrNyp36VyavVllM5D0 ReE1j7LpUmSPAG4CVSkb2Vj7PR6q8YCP/rBnv3WKJQRHOeAi7RlbPKFmUwtcEslm PISAvteaO0j4CzzrF4QZc5h7F7TIffW4OH+453Zyu0AX3NsovLtRHyJy3uw== Received: from mail-pl1-f198.google.com (mail-pl1-f198.google.com [209.85.214.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 45kjjf1qe5-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT) for ; Tue, 25 Mar 2025 12:30:35 +0000 (GMT) Received: by mail-pl1-f198.google.com with SMTP id d9443c01a7336-227ea16b03dso5990665ad.3 for ; Tue, 25 Mar 2025 05:30:35 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1742905830; x=1743510630; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Djrd/4JquWXDbU+icEttWqizSKPX1yxwU0bvPWCgU/w=; b=nk1MBapWBmVfYdUs1mdM+wsPAtcSpU3IT9QcP0DHN1Pf5agKa+y5E1kZISSXGPEppT /tjW9z1vDugpIUZGd+xWmU3mwea/XTseCKMsaKAqiND4d9+lU9UcIxHAeS7XQaqjo5/j L1twF9RGfe7mXFSNXZLkqFb+neMXVGDTQkZkv3XxK3+DTbtIU5rdMaELwD1Gpz18o5Gr okvF26fREgRzpTJfQqmjAADbBw2O6AANx0CFVTVOCC4nrbz/x+aQYR4T7WY6KZvs7Y94 MFsd63DTCI0RR3L1h5VLbhnEOphGft3H9J5Q0G/qSJu+5jKM1UIgJY2mtN5kXUTCRN79 2esg== X-Forwarded-Encrypted: i=1; AJvYcCWEFl59L+kRTCfSuZervPd/b9j2PwT6AxAVQbHM/k9pReopbaaQDOhVAVt8xGLIiOkBbv5EfMZyr0v/p1vz@vger.kernel.org X-Gm-Message-State: AOJu0YxcGxM2E74WO0Verm46+yfaFrflJ4bw6nsNLh7liz5boUr1x7TR dbEckpsRr7hRU/OCVOqd5kzaDQkJb0Od/1yqv4Vn0W5EQ4lRb2Wv7pALzJ4tIHKFyc46pDHV1rx aDMlns8ux2YdHcUD69jd3jd8kKxvTdc/Ac0mJiRlMr8dAQofpB7/DuXOISHwLZ6Ey X-Gm-Gg: ASbGncvxU8mwuy6nQGXs2fkRin2vi4GJoUC7H9hquLAiQ+AsRLM3bPHUqqlhoQMl/Sb tBCEmpO7me7kM2T39kMPw3KRJWP4lKZSeqp+thNkjeFyWu5hSIdV0IQCkGdRivr9FM3SpFSeLvK +tHW+cphtZ+0VHCcBcRbCw6qUg7lEz3ULztSPXFZBqrVHubk/GXHaOlduUMJm1zACIZ5Rj5OmVz leqKafGQWD9eMHihUSKWysKQ3qUyPxLBTbQx+ujkdtrhYRbvUawgyCtN3zSXJrV+UDUGvCpwx/A cfyXn3RaefWWmtuKyj3HZDCIn6FlxSjE8bU9bTfMx6ms X-Received: by 2002:a05:6a00:a90:b0:736:5664:53f3 with SMTP id d2e1a72fcca58-739059ffb6bmr24495766b3a.15.1742905829536; Tue, 25 Mar 2025 05:30:29 -0700 (PDT) X-Google-Smtp-Source: AGHT+IE1+SzHyug7TlpcnU1WYoJKsScRaV4mu1kQkM4jvBkv9SbhqL2kTaoaLZnX/fcxB9EwTIMLnA== X-Received: by 2002:a05:6a00:a90:b0:736:5664:53f3 with SMTP id d2e1a72fcca58-739059ffb6bmr24495709b3a.15.1742905828883; Tue, 25 Mar 2025 05:30:28 -0700 (PDT) Received: from hu-prashk-hyd.qualcomm.com ([202.46.22.19]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-7390618e4b6sm9987391b3a.180.2025.03.25.05.30.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 25 Mar 2025 05:30:28 -0700 (PDT) From: Prashanth K To: Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Conor Dooley Cc: cros-qcom-dts-watchers@chromium.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Prashanth K Subject: [PATCH v1 1/5] arm64: dts: qcom: sm8150: Add snps,dis_u3_susphy_quirk Date: Tue, 25 Mar 2025 18:00:15 +0530 Message-Id: <20250325123019.597976-2-prashanth.k@oss.qualcomm.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20250325123019.597976-1-prashanth.k@oss.qualcomm.com> References: <20250325123019.597976-1-prashanth.k@oss.qualcomm.com> Precedence: bulk X-Mailing-List: linux-arm-msm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Proofpoint-GUID: J_bNRRITx_OVzWyZkkrA0WM8_pgWaBcy X-Authority-Analysis: v=2.4 cv=Hol2G1TS c=1 sm=1 tr=0 ts=67e2a1ec cx=c_pps a=MTSHoo12Qbhz2p7MsH1ifg==:117 a=fChuTYTh2wq5r3m49p7fHw==:17 a=Vs1iUdzkB0EA:10 a=EUspDBNiAAAA:8 a=2mEde68aHbpXMYUSS8oA:9 a=GvdueXVYPmCkWapjIL-Q:22 X-Proofpoint-ORIG-GUID: J_bNRRITx_OVzWyZkkrA0WM8_pgWaBcy X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1093,Hydra:6.0.680,FMLib:17.12.68.34 definitions=2025-03-25_05,2025-03-25_02,2024-11-22_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 mlxscore=0 mlxlogscore=819 suspectscore=0 lowpriorityscore=0 adultscore=0 clxscore=1011 bulkscore=0 priorityscore=1501 malwarescore=0 impostorscore=0 phishscore=0 spamscore=0 classifier=spam authscore=0 authtc=n/a authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.19.0-2502280000 definitions=main-2503250088 During device mode initialization on certain QC targets, before the runstop bit is set, sometimes it's observed that the GEVNTADR{LO/HI} register write fails. As a result, GEVTADDR registers are still 0x0. Upon setting runstop bit, DWC3 controller attempts to write the new events to address 0x0, causing an SMMU fault and system crash. This was initially observed on SM8450 and later reported on few other targets as well. As suggested by Qualcomm HW team, clearing the GUSB3PIPECTL.SUSPHY bit resolves the issue by preventing register write failures. Address this by setting the snps,dis_u3_susphy_quirk to keep the GUSB3PIPECTL.SUSPHY bit cleared. This change was tested on multiple targets (SM8350, SM8450 QCS615 etc.) for over an year and hasn't exhibited any side effects. Signed-off-by: Prashanth K --- arch/arm64/boot/dts/qcom/sm8150.dtsi | 2 ++ 1 file changed, 2 insertions(+) diff --git a/arch/arm64/boot/dts/qcom/sm8150.dtsi b/arch/arm64/boot/dts/qcom/sm8150.dtsi index 4dbda54b47a5..4477ec14ab1d 100644 --- a/arch/arm64/boot/dts/qcom/sm8150.dtsi +++ b/arch/arm64/boot/dts/qcom/sm8150.dtsi @@ -3657,6 +3657,7 @@ usb_1_dwc3: usb@a600000 { interrupts = ; iommus = <&apps_smmu 0x140 0>; snps,dis_u2_susphy_quirk; + snps,dis_u3_susphy_quirk; snps,dis_enblslpm_quirk; snps,dis-u1-entry-quirk; snps,dis-u2-entry-quirk; @@ -3736,6 +3737,7 @@ usb_2_dwc3: usb@a800000 { interrupts = ; iommus = <&apps_smmu 0x160 0>; snps,dis_u2_susphy_quirk; + snps,dis_u3_susphy_quirk; snps,dis_enblslpm_quirk; snps,dis-u1-entry-quirk; snps,dis-u2-entry-quirk; From patchwork Tue Mar 25 12:30:16 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Prashanth K X-Patchwork-Id: 14028936 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6D52125A62F for ; Tue, 25 Mar 2025 12:30:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1742905844; cv=none; b=WbpYWUi8ahRIDo6QIqsm5Z2xrViSd6czjw64j0ze12PNfXrb/KZX6EFgFJoCRy1rPKMZzML4wguNJnEnrJHU9fWNbnKOo3aYlkjQImSZDE0ZCzZJs7fHt/ScKY0Vlos46lZC2EnG0+yw/mSHzyOYOj9HqRkrHpmONNeYSG11wlM= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1742905844; c=relaxed/simple; bh=EWJKXkB8LgOYgPO2GqjsxkANuQt2ed1jlqMbsU/LlwI=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=rfM4EU5tsWOtbX5OYqbglglPAvwvZHonXSB6w9LvrNMlEG1tEidvp6FRaBl7iBH67uOLyOQjTTm8EBi/1wpWVNqJuhfyWR2vG+tAedpbt0EtK/bZwucPzvt1Wzn/UH5i1WsF+hSvAzm8tezv+PN2ZsNIDaQe295C/ZVIZ7MMuzg= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=B7z/Rtql; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="B7z/Rtql" Received: from pps.filterd (m0279862.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 52P5vnB6028726 for ; Tue, 25 Mar 2025 12:30:43 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:date:from:in-reply-to:message-id :mime-version:references:subject:to; s=qcppdkim1; bh=/EQM6DEoDUu 6zxmdeqRLQ9xyT8MDYjKcZBBXwIJ855Y=; b=B7z/RtqluDa1rImIos/tyMn+Tt/ YhNGPX6sxI4vRWKSlSTbR/BNhIKdpOsdgqjrNozsWKFozs8fKQczvvmjgFfJ23KQ GX5N74aCFVJ5+9Mn+UTULOhThkXvMC+BtSfbpKSr6I3vXJaa02wzH7M4IAn96yFF HtvQ46Lygqt7/it1K3qOK+KUo6UIW+0A3CrFU7sW2wlM4kTtNgn8YDCy30hszN11 rtHzW4ts8HN9erkSmOEwbPTQJq9hb25988OUh4CIPuHQBhS0VdcKtn0IfhQzPqkM pkBCFpHvBloXhHIhvZll/XXR7f1KELvsUdO/zynaphcX/NZBBR5GuHJ1PxQ== Received: from mail-pj1-f69.google.com (mail-pj1-f69.google.com [209.85.216.69]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 45hnyjfmdd-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT) for ; Tue, 25 Mar 2025 12:30:42 +0000 (GMT) Received: by mail-pj1-f69.google.com with SMTP id 98e67ed59e1d1-2ff68033070so8862826a91.2 for ; Tue, 25 Mar 2025 05:30:42 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1742905833; x=1743510633; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=/EQM6DEoDUu6zxmdeqRLQ9xyT8MDYjKcZBBXwIJ855Y=; b=LlENhogcL2i/kIiZJlOGqXDBKS0b4879ZFbP4117pHfXGJGVzX0IzUn8xh4E8rARu5 6+VIArQhPNzyv1eCeyCyhpdFRoL46Ho0oVadbBkZSOhKiUExRIOwxsP72CQ/Ibp89XWZ zGtHLz0xJJKexJYk9KxyXamWiI5lA56kANLuvTLn2WN6jkN955KyhlXX2DiH3f2uhyB5 MiiaEbPRR4TOid5eV5A+JxaHcpYaszhhC9zzMau9Yl/hifPEAVQuqK2DV8iXz7fY4xh7 mhf36q3xbqm5sszeLGHxca/xBTc7Q281aygLHHqKzKsftLHV40H4pQapUBcjL6thROZh HBBg== X-Forwarded-Encrypted: i=1; AJvYcCWwuSmYKp74lcJ5Cbka5sU3vP6TPGRJ8OHXwMEVvp3pR1cnfGiE5kFtAep7ZRUTfmwpnclAIyriQnjjRsi/@vger.kernel.org X-Gm-Message-State: AOJu0YwzBkZtPxTVfsfMAsha3AOsgqad6HvxM8ocE/uZESGZHQidsgA4 gvlUdX1AgXPD0fKcXUtm2DeHSFyxOx5vokGr2uRqUA+BUdOwVKdp/D4r/VCS5/N6dM06QEtzWEz OgdsBNSkla4hgUOkGVe0+N8WLBy0HA3AbYqp6BL05HIydN+HV/XPGOdw2H/xH5+pBOu/zzL3B X-Gm-Gg: ASbGncsxjlJkstmwL+l3lF/HhRkLmrF2FxqVkoUbg2M2uTe+qjjM5iViMNXON3/28km a7vBpwWJIXM6zC3OYdtDTBbYLsJ+GvQC8YYLnwRRTm7+DYBLDBezU1F+5zyu6IWVHITqjNWeJ1p L5+QKqasL7z4qq9XBO6f/Vt0pL6SltIHE6CE69eRO5CG/XiZDkdVkz1/lNpEzLHd4L1dV9j+B5S UNAd5ORRHCnuJEj4biJcJ2XfbVE7NsJwKHHOFP6/lvOjuWuFa4CJkV1HZd2xr1agPmBTgynxkGj 9JNJ/+dXycGupPA6S+T5QpPG2jDgN8awcaLJ9bwhsOHW X-Received: by 2002:a05:6a00:1301:b0:736:5e28:cfba with SMTP id d2e1a72fcca58-739059ffb1amr28507107b3a.18.1742905832863; Tue, 25 Mar 2025 05:30:32 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHouuf4m/7aas0Ea6VvKqkVXtocGxmnrkYVDOh+y2Z/ngsR4dy9YmGQThpYoaWuqqdjbhek2w== X-Received: by 2002:a05:6a00:1301:b0:736:5e28:cfba with SMTP id d2e1a72fcca58-739059ffb1amr28507042b3a.18.1742905832325; Tue, 25 Mar 2025 05:30:32 -0700 (PDT) Received: from hu-prashk-hyd.qualcomm.com ([202.46.22.19]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-7390618e4b6sm9987391b3a.180.2025.03.25.05.30.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 25 Mar 2025 05:30:31 -0700 (PDT) From: Prashanth K To: Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Conor Dooley Cc: cros-qcom-dts-watchers@chromium.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Prashanth K Subject: [PATCH v1 2/5] arm64: dts: qcom: sm8350: Add snps,dis_u3_susphy_quirk Date: Tue, 25 Mar 2025 18:00:16 +0530 Message-Id: <20250325123019.597976-3-prashanth.k@oss.qualcomm.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20250325123019.597976-1-prashanth.k@oss.qualcomm.com> References: <20250325123019.597976-1-prashanth.k@oss.qualcomm.com> Precedence: bulk X-Mailing-List: linux-arm-msm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Authority-Analysis: v=2.4 cv=Ybu95xRf c=1 sm=1 tr=0 ts=67e2a1f2 cx=c_pps a=vVfyC5vLCtgYJKYeQD43oA==:117 a=fChuTYTh2wq5r3m49p7fHw==:17 a=Vs1iUdzkB0EA:10 a=EUspDBNiAAAA:8 a=tc1TWAvYerzeY2VvnAsA:9 a=rl5im9kqc5Lf4LNbBjHf:22 X-Proofpoint-GUID: 81kC5dHXW81qvZJYyODeNefnl2rmDZIZ X-Proofpoint-ORIG-GUID: 81kC5dHXW81qvZJYyODeNefnl2rmDZIZ X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1093,Hydra:6.0.680,FMLib:17.12.68.34 definitions=2025-03-25_05,2025-03-25_02,2024-11-22_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 phishscore=0 impostorscore=0 suspectscore=0 mlxlogscore=816 priorityscore=1501 spamscore=0 lowpriorityscore=0 mlxscore=0 malwarescore=0 bulkscore=0 clxscore=1011 adultscore=0 classifier=spam authscore=0 authtc=n/a authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.19.0-2502280000 definitions=main-2503250088 During device mode initialization on certain QC targets, before the runstop bit is set, sometimes it's observed that the GEVNTADR{LO/HI} register write fails. As a result, GEVTADDR registers are still 0x0. Upon setting runstop bit, DWC3 controller attempts to write the new events to address 0x0, causing an SMMU fault and system crash. This was initially observed on SM8450 and later reported on few other targets as well. As suggested by Qualcomm HW team, clearing the GUSB3PIPECTL.SUSPHY bit resolves the issue by preventing register write failures. Address this by setting the snps,dis_u3_susphy_quirk to keep the GUSB3PIPECTL.SUSPHY bit cleared. This change was tested on multiple targets (SM8350, SM8450 QCS615 etc.) for over an year and hasn't exhibited any side effects. Signed-off-by: Prashanth K --- arch/arm64/boot/dts/qcom/sm8350.dtsi | 2 ++ 1 file changed, 2 insertions(+) diff --git a/arch/arm64/boot/dts/qcom/sm8350.dtsi b/arch/arm64/boot/dts/qcom/sm8350.dtsi index 5f93cae01b06..a4fc3657ff87 100644 --- a/arch/arm64/boot/dts/qcom/sm8350.dtsi +++ b/arch/arm64/boot/dts/qcom/sm8350.dtsi @@ -2651,6 +2651,7 @@ usb_1_dwc3: usb@a600000 { interrupts = ; iommus = <&apps_smmu 0x0 0x0>; snps,dis_u2_susphy_quirk; + snps,dis_u3_susphy_quirk; snps,dis_enblslpm_quirk; snps,dis-u1-entry-quirk; snps,dis-u2-entry-quirk; @@ -2729,6 +2730,7 @@ usb_2_dwc3: usb@a800000 { interrupts = ; iommus = <&apps_smmu 0x20 0x0>; snps,dis_u2_susphy_quirk; + snps,dis_u3_susphy_quirk; snps,dis_enblslpm_quirk; snps,dis-u1-entry-quirk; snps,dis-u2-entry-quirk; From patchwork Tue Mar 25 12:30:17 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Prashanth K X-Patchwork-Id: 14028939 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 87D57267F44 for ; Tue, 25 Mar 2025 12:30:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1742905852; cv=none; b=aWbGkAm9G08BFcbXz5XH+P7GPCoDScNMiJRYVVNFLUv8Ps9ZEbDpRnuxXqNlTJsCugv/kMGS6j5lbdd0etrA6CHxBx2+yFiYbhZnfrZSU4yhyegEMjYf151qLSyrzm2KwKGG6aZj1R5e6d3balKyhDV/4OhLpEFpW4HrgnrfHig= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1742905852; c=relaxed/simple; bh=qilpJ4cjtgqnPO881wZb0am06aM3yLc86r4tD6NpndY=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=qsNBq+fP2KKNQJtpwLLKZaJR9s2ame56IXNZMzCyMH4+faNvnB+s1bWuxElqW/UQJqJblaDe3LRZDCdY8oFUbuPVxy13yseWavg5gl55jLrg8TdeeHQLzsLjX/8AUOfIIAWbaoeq9tws2QpPAia/ap7g6O7I3gykF/B2I1KyJmU= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=F5w7HHvw; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="F5w7HHvw" Received: from pps.filterd (m0279871.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 52PA6YGU006327 for ; Tue, 25 Mar 2025 12:30:49 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:date:from:in-reply-to:message-id :mime-version:references:subject:to; s=qcppdkim1; bh=kPZJqI1uck7 luBRZQDPnKRItuLHLZb+DfwEFnWKYwSI=; b=F5w7HHvwDkZ3EyRhcsddClWWlmL De0g3Jcbk4D4bVmXNhtsmorgoOqS6m9lVda2Je1j83GIh7fHQ1jn0DXMeaVrg3J5 GN9j2GX7oFp4n9gZ/6JmvG380HDgEeN3xBkwFP04iMlm5L96mperhwyBook28AhN ioSV92aMVC7ly/oVzEk/NJh8xajXKEIRlgAhDOORBgDFCEE8LNotrBaG5R7OaKBa dVW7g/IhoRkJdCRMj4adIcBk5eLLwRpSB/7/7dJ5fmkXp7hbw3iSjalRWMkF1y3f 85oROW7yZJqge/mnpf6M70z05UxJb9xefOf4HFMZqHS0iph0KJczU6KhjYA== Received: from mail-pl1-f199.google.com (mail-pl1-f199.google.com [209.85.214.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 45kten8ckw-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT) for ; Tue, 25 Mar 2025 12:30:49 +0000 (GMT) Received: by mail-pl1-f199.google.com with SMTP id d9443c01a7336-227ea16b03dso5992575ad.3 for ; Tue, 25 Mar 2025 05:30:49 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1742905836; x=1743510636; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=kPZJqI1uck7luBRZQDPnKRItuLHLZb+DfwEFnWKYwSI=; b=AirwdCChh5GgKZwMeU6FktVR3qnh/IGOE/lxSwj49hOPJHhWJ6kpJuQ639/FXxTWFw a0LDXHVEAYesH+5q3uf3iWZ6Ac+sIlNX8pxSwgXhwoj88uznXMxMsxDOVpWrF56M1oFH 4lebJDlm2+eFdcC5Ntsq4dNly2WrHu1IXILqi3Gi1pBnGSdOs1JTggT+uP0Bb2kC8FGK 2KNDRC0DSWXb7cLEa8LEwkRiG+4V/eS448kftfFVmqDSjvFXXQK1h6K+9IJs2TNbkLlh p6HsL6ZuJ1O9nrFGmGZ0KijBqaN9E6PvqBvEodZe1efqWROhJyqHshWlHXjLaqqqRqoS vOAQ== X-Forwarded-Encrypted: i=1; AJvYcCWWUXt/pyYBTP0SiHWYnoPdjSFRcw2DKYee1bcirKZRgMGMS672fF8NQy3TYFmYBnSm1C1fhByhP/A73V0J@vger.kernel.org X-Gm-Message-State: AOJu0YzaQIAoVnBZAru2tMnmeEZTEQOoV/zIP+Ec+Au/Nxv0kc/Oley8 poyRMpM7hbxs47lzoAM7lquasZeUOhO1vwxy9RXKKkPQZRl6XDmOwCAfK+OAXu7k59yjxN/jjAd 0mKVziwkhsdPkjxdicIJrovVA8Le3/JDEOYnjl2IppCCpDoE3DRGeTl9X8nRdIaRc X-Gm-Gg: ASbGncsmWUm71LyHsu6AtZZzVUk2hj1YIfTRxMebYCLCKsgy7KCSTyN7HlL//qn3YfK 3x8Kq4ty3BcQW4RPXiK3gPHlV0sU2Qzxobc9DEWNmHOv65iDNbYWG7U4meMJCEvobXsOKBDZhCt h4jVYSqCvPOV0ncBMuZMwC3Tj8I2EtAzqauB3HWW+pUk5bQt/ZiQYk+aEmvOVFifcbgWlLuAgxw CPBP6S1mbteYxFIZetZyUG4xNn4MwxL1i5L2CSlQf+sUby6WE/yCGUkQsMfMVLe2XDKlCzS6LYr A0ZN8E7OlgbUIhLtLBEIVYqPgGDEfwZePOWi6CGqNgHi X-Received: by 2002:a05:6a00:8017:b0:736:4536:26cc with SMTP id d2e1a72fcca58-73905a2786bmr29132417b3a.23.1742905836256; Tue, 25 Mar 2025 05:30:36 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFcDgZuM5dlRYn7F5OTGm0QqT+WC/cQOltrUZIrZSAh8E4Gc4dpW0xBXL4OpnIbD0hldQ5kFw== X-Received: by 2002:a05:6a00:8017:b0:736:4536:26cc with SMTP id d2e1a72fcca58-73905a2786bmr29132315b3a.23.1742905835547; Tue, 25 Mar 2025 05:30:35 -0700 (PDT) Received: from hu-prashk-hyd.qualcomm.com ([202.46.22.19]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-7390618e4b6sm9987391b3a.180.2025.03.25.05.30.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 25 Mar 2025 05:30:35 -0700 (PDT) From: Prashanth K To: Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Conor Dooley Cc: cros-qcom-dts-watchers@chromium.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Prashanth K Subject: [PATCH v1 3/5] arm64: dts: qcom: sm8450: Add snps,dis_u3_susphy_quirk Date: Tue, 25 Mar 2025 18:00:17 +0530 Message-Id: <20250325123019.597976-4-prashanth.k@oss.qualcomm.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20250325123019.597976-1-prashanth.k@oss.qualcomm.com> References: <20250325123019.597976-1-prashanth.k@oss.qualcomm.com> Precedence: bulk X-Mailing-List: linux-arm-msm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Authority-Analysis: v=2.4 cv=TuvmhCXh c=1 sm=1 tr=0 ts=67e2a1f9 cx=c_pps a=JL+w9abYAAE89/QcEU+0QA==:117 a=fChuTYTh2wq5r3m49p7fHw==:17 a=Vs1iUdzkB0EA:10 a=EUspDBNiAAAA:8 a=1HEuz3GWIXJSLhVaKDMA:9 a=324X-CrmTo6CU4MGRt3R:22 X-Proofpoint-GUID: VATWwUNFk3dee77Fxp2IT7goLWCl9205 X-Proofpoint-ORIG-GUID: VATWwUNFk3dee77Fxp2IT7goLWCl9205 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1093,Hydra:6.0.680,FMLib:17.12.68.34 definitions=2025-03-25_05,2025-03-25_02,2024-11-22_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 mlxlogscore=880 malwarescore=0 bulkscore=0 priorityscore=1501 impostorscore=0 suspectscore=0 adultscore=0 phishscore=0 clxscore=1015 lowpriorityscore=0 mlxscore=0 spamscore=0 classifier=spam authscore=0 authtc=n/a authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.19.0-2502280000 definitions=main-2503250088 During device mode initialization on certain QC targets, before the runstop bit is set, sometimes it's observed that the GEVNTADR{LO/HI} register write fails. As a result, GEVTADDR registers are still 0x0. Upon setting runstop bit, DWC3 controller attempts to write the new events to address 0x0, causing an SMMU fault and system crash. This was initially observed on SM8450 and later reported on few other targets as well. As suggested by Qualcomm HW team, clearing the GUSB3PIPECTL.SUSPHY bit resolves the issue by preventing register write failures. Address this by setting the snps,dis_u3_susphy_quirk to keep the GUSB3PIPECTL.SUSPHY bit cleared. This change was tested on multiple targets (SM8350, SM8450 QCS615 etc.) for over an year and hasn't exhibited any side effects. Signed-off-by: Prashanth K --- arch/arm64/boot/dts/qcom/sm8450.dtsi | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm64/boot/dts/qcom/sm8450.dtsi b/arch/arm64/boot/dts/qcom/sm8450.dtsi index 0b36f4cd4497..58c98bffee17 100644 --- a/arch/arm64/boot/dts/qcom/sm8450.dtsi +++ b/arch/arm64/boot/dts/qcom/sm8450.dtsi @@ -5461,6 +5461,7 @@ usb_1_dwc3: usb@a600000 { interrupts = ; iommus = <&apps_smmu 0x0 0x0>; snps,dis_u2_susphy_quirk; + snps,dis_u3_susphy_quirk; snps,dis_enblslpm_quirk; snps,dis-u1-entry-quirk; snps,dis-u2-entry-quirk; From patchwork Tue Mar 25 12:30:18 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Prashanth K X-Patchwork-Id: 14028940 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C0335267F4A for ; Tue, 25 Mar 2025 12:30:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1742905852; cv=none; b=RktASlRPDppbcLsUE7xeBVx/5yhYPwSES4UaYxcAkw+2i3s3yi++omVtY+JExShbiT4/bioRx6D/7VCBjywTQwSCAKDSrvuXC5PWyIAeRQBw8YkhYEQn4V/Un0cv7GZvDn4GZPI64P+fRsDxCkBi9pQZ7lC7Y+bwXj2CJiAa7XA= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1742905852; c=relaxed/simple; bh=ByapJwSaA2JYsoTiCefCg7xWdc4BAw+unYZtlLMXgXc=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=usTezN36v0xQcE890v80GrCZSrHiPSGU3pJHsnWvbQ4N98SA2PPVO3/2OHqH4N/R62OEW4A3afJ0Js7PzZwFQ5kmb7VG1hvFrOUL4Rs7w3vKUUo6emvQi1o4sXPxSXQniiOZUYQwojqzoGHhiv+QeS/7RRjzPO646q1DTupRsK4= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=Qf+BZY1Q; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="Qf+BZY1Q" Received: from pps.filterd (m0279871.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 52PA6Omn006275 for ; Tue, 25 Mar 2025 12:30:49 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:date:from:in-reply-to:message-id :mime-version:references:subject:to; s=qcppdkim1; bh=c4cq5PoeUBT cNntuXgA7GanwXybPSAE6G2RvKQ8Ix2E=; b=Qf+BZY1QkL1WcKl23uKV7ZgMd4x tDxHOc0s0gHSInMrJ0OKi6Tmtncd4igBZ73aIHx7uLJEVA33SJrkXCUrSReCLxsi 5Ben+vnxK0eCTuH6vfO369c5Ak/e1QBoZjpgQNKvl+WQYlbgl0M+nOpD4g3vkt8k 2396zDHSE41TmceC4cLPddq/0LAC2pxm3bHnPZKNlxbEzYB2HzmjpronV4Hrvjtm R/g8RUhqjNDzJ+LOhipu0/Mv9ZjLE2krnnXLYzIsHkJtvQcRGsJKnqAInV0SVkei yC18CGrx+CN8rzdcA16ocloZnK5GxXVcPb7YsW97I3BbW/xQgsooZXTn2rw== Received: from mail-pl1-f200.google.com (mail-pl1-f200.google.com [209.85.214.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 45kten8cm0-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT) for ; Tue, 25 Mar 2025 12:30:49 +0000 (GMT) Received: by mail-pl1-f200.google.com with SMTP id d9443c01a7336-22410b910b0so72335295ad.2 for ; Tue, 25 Mar 2025 05:30:49 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1742905840; x=1743510640; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=c4cq5PoeUBTcNntuXgA7GanwXybPSAE6G2RvKQ8Ix2E=; b=Z9ehGl/3c+h7meUkvWN48s194nGc8c0cUZNDeZZirYssD8O4ffS7Yt+98OYYX5mOgT 8l4Sac4BO3kCerZkHUakPHOCu3nx6nxknD6z8ia8RAM6voJuJRs2RlU8cs9AnDMNm9el 6wU5rTdge8WF/Qv9Eqd8LvCiHYt4spNBRjPaMcXuZreLvBjZIeiDALUWg8SXTFz36z0u Q1Dj3xr3VtydYJ2ItDNU8ULJbI2ChWlIfkURFV3K3kMCipHTlwmYJ2ZBmRNPGeawqax0 7vcw+lunuAiCUxHb7ziB8NKBfwOLU9RzWbRwYlQvRRSlhkIUAAl/g318Yp86U4rrStZf Cmvg== X-Forwarded-Encrypted: i=1; AJvYcCVrlUKUjdaJvWZSdEAIjBSV69ILrK/anh32Gv2QStPK4A0rELWDx6jcyHDQc3hMtPEC+71CLWztRlHareGk@vger.kernel.org X-Gm-Message-State: AOJu0YzgVTyc/YUfhxefB1sG+9/rmVQ66TiG3A79enM5+AY2D+Mg7GXq GmqQdaxDVHcyN4g1UhOi2hqsdHAv2uMJ2iz/687cTrEoZ51pO1FyhW6pYdzr5CBvZ97zMiigcnp 7OtfzR2sbE8pMBm2OVvirKsvfSCbDVfGmHhvr+iRir50zoWaldpvNQE+JA5gKMwZx X-Gm-Gg: ASbGncsN02GRQKBpETqomqTg26lNZNVBwjKIQrM92X86ZGMvgdo5ssKEWbLAJ86N6fv LYs0zDp1+1uSOJN9/RkrWj49dgORCm7SUG/uL9zh3pjdCwk/fXtKeKAQ6nXQ+eU81hAImdGzcZp bOW2TanaAO+eaEXOeODqo2wsVLaCPV7NjGpQMAPBb/3Weq5ycddtmSlDgDIDWX49fffT1Yd82dg Q7TVSvHuzGokzY8i0yMRe3XXOEEI+rFg1ce6Zn9ap6W0mH6nnRtDKf0PB56JQTjAYoSTZQUgu/0 Sw/4is4rvJz2Dvx69Ci4QjTsD4nfBjTcL+8Ojd2i1rvW X-Received: by 2002:a05:6a00:3d0a:b0:736:4d05:2e2e with SMTP id d2e1a72fcca58-739059667damr27448238b3a.6.1742905839751; Tue, 25 Mar 2025 05:30:39 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGQch3AWha2DTxlzFMtC4JDwLKFF9RrWxn4KNzLCG3jKZZdV4T/Tl4Cj9iV3polzJ105XA7xQ== X-Received: by 2002:a05:6a00:3d0a:b0:736:4d05:2e2e with SMTP id d2e1a72fcca58-739059667damr27448188b3a.6.1742905839174; Tue, 25 Mar 2025 05:30:39 -0700 (PDT) Received: from hu-prashk-hyd.qualcomm.com ([202.46.22.19]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-7390618e4b6sm9987391b3a.180.2025.03.25.05.30.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 25 Mar 2025 05:30:38 -0700 (PDT) From: Prashanth K To: Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Conor Dooley Cc: cros-qcom-dts-watchers@chromium.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Pratham Pratap , Prashanth K Subject: [PATCH v1 4/5] arm64: dts: qcom: qcs615: Add snps,dis_u3_susphy_quirk Date: Tue, 25 Mar 2025 18:00:18 +0530 Message-Id: <20250325123019.597976-5-prashanth.k@oss.qualcomm.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20250325123019.597976-1-prashanth.k@oss.qualcomm.com> References: <20250325123019.597976-1-prashanth.k@oss.qualcomm.com> Precedence: bulk X-Mailing-List: linux-arm-msm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Authority-Analysis: v=2.4 cv=TuvmhCXh c=1 sm=1 tr=0 ts=67e2a1f9 cx=c_pps a=IZJwPbhc+fLeJZngyXXI0A==:117 a=fChuTYTh2wq5r3m49p7fHw==:17 a=Vs1iUdzkB0EA:10 a=COk6AnOGAAAA:8 a=EUspDBNiAAAA:8 a=xQyWRTzcSYSkOWr2IqcA:9 a=uG9DUKGECoFWVXl0Dc02:22 a=TjNXssC_j7lpFel5tvFf:22 X-Proofpoint-GUID: _uCL2FI4Jh3FkdVcw2uMzhCNtB79GrH3 X-Proofpoint-ORIG-GUID: _uCL2FI4Jh3FkdVcw2uMzhCNtB79GrH3 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1093,Hydra:6.0.680,FMLib:17.12.68.34 definitions=2025-03-25_05,2025-03-25_02,2024-11-22_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 mlxlogscore=831 malwarescore=0 bulkscore=0 priorityscore=1501 impostorscore=0 suspectscore=0 adultscore=0 phishscore=0 clxscore=1011 lowpriorityscore=0 mlxscore=0 spamscore=0 classifier=spam authscore=0 authtc=n/a authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.19.0-2502280000 definitions=main-2503250088 From: Pratham Pratap During device mode initialization on certain QC targets, before the runstop bit is set, sometimes it's observed that the GEVNTADR{LO/HI} register write fails. As a result, GEVTADDR registers are still 0x0. Upon setting runstop bit, DWC3 controller attempts to write the new events to address 0x0, causing an SMMU fault and system crash. This was initially observed on SM8450 and later reported on few other targets as well. As suggested by Qualcomm HW team, clearing the GUSB3PIPECTL.SUSPHY bit resolves the issue by preventing register write failures. Address this by setting the snps,dis_u3_susphy_quirk to keep the GUSB3PIPECTL.SUSPHY bit cleared. This change was tested on multiple targets (SM8350, SM8450 QCS615 etc.) for over an year and hasn't exhibited any side effects. Signed-off-by: Pratham Pratap Signed-off-by: Prashanth K --- arch/arm64/boot/dts/qcom/qcs615.dtsi | 2 ++ 1 file changed, 2 insertions(+) diff --git a/arch/arm64/boot/dts/qcom/qcs615.dtsi b/arch/arm64/boot/dts/qcom/qcs615.dtsi index edfb796d8dd3..7c377f3402c1 100644 --- a/arch/arm64/boot/dts/qcom/qcs615.dtsi +++ b/arch/arm64/boot/dts/qcom/qcs615.dtsi @@ -3600,6 +3600,7 @@ usb_1_dwc3: usb@a600000 { snps,dis-u1-entry-quirk; snps,dis-u2-entry-quirk; snps,dis_u2_susphy_quirk; + snps,dis_u3_susphy_quirk; snps,dis_enblslpm_quirk; snps,has-lpm-erratum; snps,hird-threshold = /bits/ 8 <0x10>; @@ -3661,6 +3662,7 @@ usb_2_dwc3: usb@a800000 { phy-names = "usb2-phy"; snps,dis_u2_susphy_quirk; + snps,dis_u3_susphy_quirk; snps,dis_enblslpm_quirk; snps,has-lpm-erratum; snps,hird-threshold = /bits/ 8 <0x10>; From patchwork Tue Mar 25 12:30:19 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Prashanth K X-Patchwork-Id: 14028938 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1937F267B88 for ; Tue, 25 Mar 2025 12:30:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1742905847; cv=none; b=sju2w1biFI7UraYzpC+hpPqLvpdLhly6n0hV4/4EXQo7OpRUv0Y161T8qHGP+jlRfTGqLK64z+MufJTOy2YRxqrdVxXtEKqXYgycmJFCw1QByXwr7RsPUHcNFDbk1KD5vWY4k1BbMH59lLDMAXK0goCjY4/fHQiJgk5AXKn7ez4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1742905847; c=relaxed/simple; bh=OPB2Ai+uZO0JN8fesuuuEH/Ql4KaJvx16g8TbS7kDy4=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=KBt6XRu9P0BE+OL80cxqBkVuCRTPcrm62+vzvyWD4dGPnXIoMHUp49QIW4UeVSzIj0NJB7mt8KlFCPVrtoZzeQGPTlkkC0kz/oOLdKWi/zzHebI4YhAGYuOgy+uGwPs4TyQZGRmYfSiRdzPyIlum+9qD8U2J5TBBC82Iv2S2zaA= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=mmbIRFMd; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="mmbIRFMd" Received: from pps.filterd (m0279870.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 52P5vrFn002747 for ; Tue, 25 Mar 2025 12:30:45 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:date:from:in-reply-to:message-id :mime-version:references:subject:to; s=qcppdkim1; bh=cV8GYTdiXT0 TDERwijtWAGMsmtXi/MaMGlqd90S9WIg=; b=mmbIRFMdx00S3E2liQsOzGgqEvK P02eDegng3MohXPNrX+G8pFatT25bPvV4fZHo7HnAcrWNQD4oYG+GZXR8ZPSR2Iq HvVRP3U8jC3to5/PnTQZ18Pl2NPUNI29qTLvB9rKOkEofGX/TyT/3WJIqZom9JqQ Cqls5Q7ivmwc9mHoC8e3F6U7cJzGv6P4t4kHryfdHRrZH9ads+aENE6cjVrFbp0E JOMlZSW5PtuNZC83vWHkXgwzKS6+KIJvz1OESstOfZPx5SeOUFiyshOWP330uX7I zRjgoVyjL+CsvPuUREou/jx82Vx8jOsIeo23EuBwtV0HyTDtyeB258C3DWA== Received: from mail-pl1-f200.google.com (mail-pl1-f200.google.com [209.85.214.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 45hn9wfs8r-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT) for ; Tue, 25 Mar 2025 12:30:44 +0000 (GMT) Received: by mail-pl1-f200.google.com with SMTP id d9443c01a7336-2240a960f9cso91437055ad.0 for ; Tue, 25 Mar 2025 05:30:44 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1742905843; x=1743510643; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=cV8GYTdiXT0TDERwijtWAGMsmtXi/MaMGlqd90S9WIg=; b=vbydodlOryjFVI+huxyiukAGqCCPSNZjg/isE+dJ+qXoitPwgZpvi2hCd4ldL807MG yZIv6ILjaMGfDAiNX+uvxFF1cqZojL4Vt5IIQswEQhJBOPT7OuLY3ifzCbpkH/MiKiJS ef19JcwXf/3OhyUniXVAdUeuknBTnaBRcUITjkFfIgrCgYHs0tSJuKHBLx8Z2cGYQHEQ 6gBYqzsAHUnyHiezyubfwHBE/gWapjBUxrCuYwo9BLUv1H+3OwE6PfdkfnAuhCKGo+CE CHeglzj+jelr6Y7NqUUm60DMfk57jSOHGHLGYWalvjjrtGyzydx/Z2supeuLaamzaI7j Ay+A== X-Forwarded-Encrypted: i=1; AJvYcCWvL3PuVXXWKPMGx5scos4JQSdb65TqIiqe9bFvYPpbAdqj/0KUo6LFbCw6Fdnj5LBqLSEEouSmqlPKhgC/@vger.kernel.org X-Gm-Message-State: AOJu0YwyA4ZuMXQ26Psve+fapR5bSe6PJZ35LKXiegRU+P04jDp5LNjp j/wTCznKYQUD896fDRQmi1ZLBBzLvx+lWY6kOC6ZZRY4CarJuHXhsTFwrC0XIvFjMnic+aM32xB I/GgKlyRI7PUm6fYeB9izf4BKNpyqP10nAdAH/iCbtlfDs4cHPMPQ7gZoMaOZFwdL X-Gm-Gg: ASbGncvcgNv8q10FO2aDGX/kwI/4Sn4QlTt7KAdizE79rRviyyfeW4FzG9RcMWJxxN0 boH+754lSlFudql2PZ436QHgp7MQWSY+7RpQ99oYHBluXOcn+Scp2EA2zjpgMALNu978TMF+EHb nSCqEkalaJg7YCKxfFOSOE1zUf3C+NBHcx9XR5DktKfxSJKr3IjJvb74V+mUX3J80DzD94pA3Ok 6ffv+BXk12c8o8er/E+O3f2Jcwu4pnTJkBq/3ZO6JDP0oWmyYPq22NKB7/qtA6Jb9hFXFZnv/fb XqMAv/MibyK8dSX/0zg+DCLOh1/VOvERNndUMrVRbZCz X-Received: by 2002:a05:6a00:c92:b0:736:3c77:31fd with SMTP id d2e1a72fcca58-73905a364b0mr22153572b3a.23.1742905843277; Tue, 25 Mar 2025 05:30:43 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEjMUj1TLOsrYDkG5M5EtFQfcFnxQW3340OpNyCVSxp8cds6pRnYowPm6jrN3KQxqvr/9ZaFg== X-Received: by 2002:a05:6a00:c92:b0:736:3c77:31fd with SMTP id d2e1a72fcca58-73905a364b0mr22153500b3a.23.1742905842630; Tue, 25 Mar 2025 05:30:42 -0700 (PDT) Received: from hu-prashk-hyd.qualcomm.com ([202.46.22.19]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-7390618e4b6sm9987391b3a.180.2025.03.25.05.30.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 25 Mar 2025 05:30:42 -0700 (PDT) From: Prashanth K To: Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Conor Dooley Cc: cros-qcom-dts-watchers@chromium.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Pratham Pratap , Prashanth K Subject: [PATCH v1 5/5] arm64: dts: qcom: qdu1000: Add snps,dis_u3_susphy_quirk Date: Tue, 25 Mar 2025 18:00:19 +0530 Message-Id: <20250325123019.597976-6-prashanth.k@oss.qualcomm.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20250325123019.597976-1-prashanth.k@oss.qualcomm.com> References: <20250325123019.597976-1-prashanth.k@oss.qualcomm.com> Precedence: bulk X-Mailing-List: linux-arm-msm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Proofpoint-GUID: xWHwCcauh4FovA_QETDtsk0Ppl87DFtx X-Proofpoint-ORIG-GUID: xWHwCcauh4FovA_QETDtsk0Ppl87DFtx X-Authority-Analysis: v=2.4 cv=CPoqXQrD c=1 sm=1 tr=0 ts=67e2a1f4 cx=c_pps a=IZJwPbhc+fLeJZngyXXI0A==:117 a=fChuTYTh2wq5r3m49p7fHw==:17 a=Vs1iUdzkB0EA:10 a=COk6AnOGAAAA:8 a=EUspDBNiAAAA:8 a=1HEuz3GWIXJSLhVaKDMA:9 a=uG9DUKGECoFWVXl0Dc02:22 a=TjNXssC_j7lpFel5tvFf:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1093,Hydra:6.0.680,FMLib:17.12.68.34 definitions=2025-03-25_05,2025-03-25_02,2024-11-22_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 mlxlogscore=893 spamscore=0 priorityscore=1501 suspectscore=0 bulkscore=0 mlxscore=0 lowpriorityscore=0 malwarescore=0 adultscore=0 phishscore=0 impostorscore=0 classifier=spam authscore=0 authtc=n/a authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.19.0-2502280000 definitions=main-2503250088 From: Pratham Pratap During device mode initialization on certain QC targets, before the runstop bit is set, sometimes it's observed that the GEVNTADR{LO/HI} register write fails. As a result, GEVTADDR registers are still 0x0. Upon setting runstop bit, DWC3 controller attempts to write the new events to address 0x0, causing an SMMU fault and system crash. This was initially observed on SM8450 and later reported on few other targets as well. As suggested by Qualcomm HW team, clearing the GUSB3PIPECTL.SUSPHY bit resolves the issue by preventing register write failures. Address this by setting the snps,dis_u3_susphy_quirk to keep the GUSB3PIPECTL.SUSPHY bit cleared. This change was tested on multiple targets (SM8350, SM8450 QCS615 etc.) for over an year and hasn't exhibited any side effects. Signed-off-by: Pratham Pratap Signed-off-by: Prashanth K --- arch/arm64/boot/dts/qcom/qdu1000.dtsi | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm64/boot/dts/qcom/qdu1000.dtsi b/arch/arm64/boot/dts/qcom/qdu1000.dtsi index f973aa8f7477..b3c673e24726 100644 --- a/arch/arm64/boot/dts/qcom/qdu1000.dtsi +++ b/arch/arm64/boot/dts/qcom/qdu1000.dtsi @@ -1022,6 +1022,7 @@ usb_1_dwc3: usb@a600000 { iommus = <&apps_smmu 0xc0 0x0>; snps,dis_u2_susphy_quirk; + snps,dis_u3_susphy_quirk; snps,dis_enblslpm_quirk; snps,dis-u1-entry-quirk; snps,dis-u2-entry-quirk;