From patchwork Fri Mar 28 12:19:08 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Toke_H=C3=B8iland-J=C3=B8rgensen?= X-Patchwork-Id: 14031876 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1352AC36013 for ; Fri, 28 Mar 2025 12:19:29 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 04D0C280138; Fri, 28 Mar 2025 08:19:26 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id DE70D28013B; Fri, 28 Mar 2025 08:19:25 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B9D83280138; Fri, 28 Mar 2025 08:19:25 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 8E685280139 for ; Fri, 28 Mar 2025 08:19:25 -0400 (EDT) Received: from smtpin08.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 56D1F12108A for ; Fri, 28 Mar 2025 12:19:26 +0000 (UTC) X-FDA: 83270865132.08.3D72F90 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf25.hostedemail.com (Postfix) with ESMTP id C5FD2A0008 for ; Fri, 28 Mar 2025 12:19:23 +0000 (UTC) Authentication-Results: imf25.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=iN3RsIT5; dmarc=pass (policy=quarantine) header.from=redhat.com; spf=pass (imf25.hostedemail.com: domain of toke@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=toke@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1743164364; a=rsa-sha256; cv=none; b=ZIcyYLCsAKXRumHxgLlGHJ/NYtMHP7RqKlS0V5YVJdpV7ECJPpfAW68LXaFonba4s/C4XD Xc/yvZkpfgV85e7aO6mPKoplSBewYenJ4Pi85IudE11z4CV/N/u64uvG7Pxes9M2lVM517 w24p0u+80+x7YPDcoDMLUrUCc4xNdcE= ARC-Authentication-Results: i=1; imf25.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=iN3RsIT5; dmarc=pass (policy=quarantine) header.from=redhat.com; spf=pass (imf25.hostedemail.com: domain of toke@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=toke@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1743164364; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=DD6/BKzSTAkniyKROx0SYrtrdsrFKedUxdUETO2d2g0=; b=ttdy02Sqi9dmF1cNjaDSSOS69Tbr34C+2lwDs5f4Q7CjNJE+YmzqGuy2SIYw0VK14rXDtY OUC25z26o0LC62Ugoj8PG9ePWXFMEMwPBCu7qqL4cVbrzyQJbesXJ8N+IxCC4E+HPQ1qRX M+Gy5i+oLcEE9NFCqeb1wTrKJA7wg9Q= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1743164363; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=DD6/BKzSTAkniyKROx0SYrtrdsrFKedUxdUETO2d2g0=; b=iN3RsIT5c0YHwGDxj1+1WXAFfTbkeW7nNyr+IfGG+LljXiDugcpuKcK37y0NY46YNT3Ae5 jId1MJtUQLaTduoY3oetqY/4aRpbiq9n0Xz9rAKvP3pRZLaH3cHOnGmv8ZWLeq1wKQNddW o7HA607vKu4TbhyJUNa2F+O285DiHiU= Received: from mail-ed1-f72.google.com (mail-ed1-f72.google.com [209.85.208.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-286-r_OY83h9OQu_BCy68buM8w-1; Fri, 28 Mar 2025 08:19:22 -0400 X-MC-Unique: r_OY83h9OQu_BCy68buM8w-1 X-Mimecast-MFC-AGG-ID: r_OY83h9OQu_BCy68buM8w_1743164361 Received: by mail-ed1-f72.google.com with SMTP id 4fb4d7f45d1cf-5e5d8a28de7so2354777a12.2 for ; Fri, 28 Mar 2025 05:19:21 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1743164361; x=1743769161; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=DD6/BKzSTAkniyKROx0SYrtrdsrFKedUxdUETO2d2g0=; b=suWNXRZMLA4lY1gGqhU4MIMXw6lW0M6ucNXS4+78XG+cHtjtEePeC6hzSV/fLdhpjn gydb/SjQCZLDJ7YMVUl0Dv/1St2tZki9tUkMSHc+rp9M03IFfFOmJXocp28pXCUNOS3B bKRIQ1+U2DNQVpdZm6i/FTgxs6zz1JN9mhIE7O3SYG+pAHCW2/atspQIehxci8Cyn57X EydaCqzI4lBL+1tuDSC52fpx6pcaI4Z0MbpKJjpFPiyufPm3FZu+5RMXwSHI4RQVHqZU SGBkStM6PzCLptmjwGNbqY3dowImpUJngwN3MMVKUUrb4/WvzxyPdfX01V7O8oqRONON I9rQ== X-Forwarded-Encrypted: i=1; AJvYcCWqeHtiCzG3Hkp7l9Me8vZ2OcG5U+H04SWFY83pWBoZ3690B4z6UeTOlex28UlwztslLKK9X6Tv0Q==@kvack.org X-Gm-Message-State: AOJu0YyiFXawSTb0HTQ6WSL2vVrKAtbJsyMcOz3SUksmQaR5Y4KRzpW0 AoDSIDBXTCSAZPUmdfG9yLmdN86qZLtzf2xmcGYyFFSdsKhxX+0RvwXLEgauoTQIAha8Cy4xUGt 96eqvVxOvngFJv08TmZw/7vE4nf/E3sxJ+qMb1fvM493i8AL4 X-Gm-Gg: ASbGncs04wug6WudCposFnRD2DI9FYdrxomlyvfsWKAQ1GFg+ahv4af1Zj5x2BbptCK V37Eztaubh6S3cJGL+ij8gEy+/Ohhqdbwbg7VFBCDYBUvP5iNrr7VMbQgaKH8gZPSrpSy0/CLAE DOZ40anaQ4tqkpiClk69NOnoB8bKrQTT5mYLxcVi8xU/Ew+/3JXY/kluKLTa13FAAS74viz1W5z 5mXhkKK0nuhOa1xhrTqoEXyhGP6nlLGJ7ACxTrdWAd1qmV8aKUuYpYDyoszf0VgXr5Uik/98ayu Uw6Cqm7c7PCr X-Received: by 2002:a17:907:f213:b0:ac7:150e:8013 with SMTP id a640c23a62f3a-ac7150e8725mr465946066b.15.1743164360607; Fri, 28 Mar 2025 05:19:20 -0700 (PDT) X-Google-Smtp-Source: AGHT+IH2sH2HU5ArIiKzX+0LiYkdqwF13nh1l17P2mIqzHoh6BBNKHd8I1cIquZFx0QCVq5kjgQpAg== X-Received: by 2002:a17:907:f213:b0:ac7:150e:8013 with SMTP id a640c23a62f3a-ac7150e8725mr465941466b.15.1743164360121; Fri, 28 Mar 2025 05:19:20 -0700 (PDT) Received: from alrua-x1.borgediget.toke.dk ([2a0c:4d80:42:443::2]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-ac71922bb65sm152046166b.34.2025.03.28.05.19.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 28 Mar 2025 05:19:18 -0700 (PDT) Received: by alrua-x1.borgediget.toke.dk (Postfix, from userid 1000) id 8A09B18FCDC5; Fri, 28 Mar 2025 13:19:17 +0100 (CET) From: =?utf-8?q?Toke_H=C3=B8iland-J=C3=B8rgensen?= Date: Fri, 28 Mar 2025 13:19:08 +0100 Subject: [PATCH net-next v5 1/2] page_pool: Move pp_magic check into helper functions MIME-Version: 1.0 Message-Id: <20250328-page-pool-track-dma-v5-1-55002af683ad@redhat.com> References: <20250328-page-pool-track-dma-v5-0-55002af683ad@redhat.com> In-Reply-To: <20250328-page-pool-track-dma-v5-0-55002af683ad@redhat.com> To: "David S. Miller" , Jakub Kicinski , Jesper Dangaard Brouer , Saeed Mahameed , Leon Romanovsky , Tariq Toukan , Andrew Lunn , Eric Dumazet , Paolo Abeni , Ilias Apalodimas , Simon Horman , Andrew Morton , Mina Almasry , Yonglong Liu , Yunsheng Lin , Pavel Begunkov , Matthew Wilcox Cc: netdev@vger.kernel.org, bpf@vger.kernel.org, linux-rdma@vger.kernel.org, linux-mm@kvack.org, =?utf-8?q?Toke_H=C3=B8iland-J=C3=B8rgensen?= X-Mailer: b4 0.14.2 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: 7Yit8QotoFdHi8BQ_ncr-r4gMz5Umgax62atc-fq0p4_1743164361 X-Mimecast-Originator: redhat.com X-Rspam-User: X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: C5FD2A0008 X-Stat-Signature: 7cfznap8iy436zmrwfc9165thoc5rfyg X-HE-Tag: 1743164363-852177 X-HE-Meta: U2FsdGVkX1/qxmX+a+svqskSx22QjzqT5cpeEl8wIVbxvYQUN/ftg5fbPGeYgnLV5qw2EuoqIONLbMoSZzSLSDn0jRC/h7w4WS8RwXOhJkreQrhgTGzzIhDhi+Sxbin/4stme34gt2umnfrt2R0bz4fA2V0ChdH4fG1sRGNBoUxZiK09iB4N9+kBywdeV8cAf/y+JuvTuxITV1MxKA+6A/hTtmnjdpagOjyurmgfeshWE6bsx5yc6KKeFWV/c7q0+nd7TMzVSeKFJH+DtL+NuoBN7/Z5C5xjvmaDWMGZs9TXa1j5J2MRTzbFwtpZ62DHWRHewQ8boZ2rqadLESCCmfkke24pJQbiDQNBNTA0Y+/WoIwAucDTZMP+4L9bXveLD7+MNGaXtlmcqRYebg9XDIfeRb9oQeXMpUo6iRFvOh9qVJ5ofwBLTKY0Ss0+k/GvXhFKebVQDRPrXuoqHbWKhnAvl4icp8veErv1ks/9inHfPoUiKGY7rLkZ/AqSjZvFJkWJ+aArL0Pk/aMsLE6GWNloqse7RO2VkZN5bMFw8HokfIf6oRe8K5fdWUxVmAK3GZgtEePqzM1/l0a/7xUIAM995X7dpIlZIeckdgDba61zaqnhMAtaqIDFOapwTMy4qd0lv5aMKpxQwH9UE9KPcNIoNV7Ax+4WXxS7tJYkCfZ4KU7kQxdhUNNBZngBNE1VenzyS5ZYDxlcm9dFqUS6YiGatQmiBl3k/GB8YNijBk0Fm0vc3WtyciELvT2MtVuQ6hTpClzBAcm3IjnMayKbPfE4qkdCVRu6kTzPKKYNxtx5j+1txVpKZVd9GHi/w7yDJM7yDWFTD/Oy5Z2Uw2cwuLv+f0st8iXu5AzsiSDIWeP7yKI9xCBjUTxv9KPIFK+5JZl20tRhfLv2qaWxOOsbJge9JYfCmAphJqB0ivt5VIXOn7N6A7YKU+6SEhMqj2kTTgr+//a3M/OJmlwCdLe UbQF/5hF sxRE6fzz7+XwEQhBEFGbrVnwVr19rP6MRWWwcNjdP6y+2GiGiNk30PiIAI4RghFHUh+ex9gIjZbemUpwT3mDubdMv6qhmakUaewycCls9B/USqiPfTQ7+89l8+OoFIbrnaX6ygAPKB0PZhyJVQha2pTkYaWb1A6DVR+j9st31UgZnBPKKGZn6aEs/NCEuMmMXqrKKALFjkq88su/AQXy4kWh+aQs5gVZY7NI5eqsDaCnmJB2R/SHNgzi3AIbSFAi4QRyxQ6PBge5hO0EWcXQLuxh95XccWZ93PAKoNWXQzvLrlvzVOt0jSFYjNWlY5kdApQoQ5ZhyVHf9iKXz2xLOlnAVDn3QIvjTSJavIwqTDq3gxTFasSBp5Qpr+aaoL3OSVYd5BizZz0jVrQEGGFALCxJwTTwcdmS9GzQED1eHEZwX1rS15R6jpaH3p3CCFjhQ2aPnQHVpVnP/+7cLC7GacMOwyE8zvDzeABOBh7q5+AN//oVh8Tn8m/GEEYR5qy1a/ANcZqYWx0OHv8RvvKuRUtXE6OvLWM+qrLDJ9h2L6mSyLBsa7IUfh1fNi8SU4vMHHxp+wPFOBwdSs6Th8r3QzX4O/ndobpDNf74bJivW56ukxcWul/9APA8XsxB4I4XugxyM8BEHNS0NUdCCDUyGAB9jB7NoQ2xMCUrtLFZ36U5/HXsOr1m2dw8ZE6QCylqOIRCCSSx3kHB2b5hLmyzsrrrlxbZBzLq+tZxo X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Since we are about to stash some more information into the pp_magic field, let's move the magic signature checks into a pair of helper functions so it can be changed in one place. Reviewed-by: Mina Almasry Tested-by: Yonglong Liu Acked-by: Jesper Dangaard Brouer Reviewed-by: Ilias Apalodimas Signed-off-by: Toke Høiland-Jørgensen --- drivers/net/ethernet/mellanox/mlx5/core/en/xdp.c | 4 ++-- include/net/page_pool/types.h | 18 ++++++++++++++++++ mm/page_alloc.c | 9 +++------ net/core/netmem_priv.h | 5 +++++ net/core/skbuff.c | 16 ++-------------- net/core/xdp.c | 4 ++-- 6 files changed, 32 insertions(+), 24 deletions(-) diff --git a/drivers/net/ethernet/mellanox/mlx5/core/en/xdp.c b/drivers/net/ethernet/mellanox/mlx5/core/en/xdp.c index f803e1c93590068d3a7829b0683be4af019266d1..5ce1b463b7a8dd7969e391618658d66f6e836cc1 100644 --- a/drivers/net/ethernet/mellanox/mlx5/core/en/xdp.c +++ b/drivers/net/ethernet/mellanox/mlx5/core/en/xdp.c @@ -707,8 +707,8 @@ static void mlx5e_free_xdpsq_desc(struct mlx5e_xdpsq *sq, xdpi = mlx5e_xdpi_fifo_pop(xdpi_fifo); page = xdpi.page.page; - /* No need to check ((page->pp_magic & ~0x3UL) == PP_SIGNATURE) - * as we know this is a page_pool page. + /* No need to check page_pool_page_is_pp() as we + * know this is a page_pool page. */ page_pool_recycle_direct(page->pp, page); } while (++n < num); diff --git a/include/net/page_pool/types.h b/include/net/page_pool/types.h index 36eb57d73abc6cfc601e700ca08be20fb8281055..df0d3c1608929605224feb26173135ff37951ef8 100644 --- a/include/net/page_pool/types.h +++ b/include/net/page_pool/types.h @@ -54,6 +54,14 @@ struct pp_alloc_cache { netmem_ref cache[PP_ALLOC_CACHE_SIZE]; }; +/* Mask used for checking in page_pool_page_is_pp() below. page->pp_magic is + * OR'ed with PP_SIGNATURE after the allocation in order to preserve bit 0 for + * the head page of compound page and bit 1 for pfmemalloc page. + * page_is_pfmemalloc() is checked in __page_pool_put_page() to avoid recycling + * the pfmemalloc page. + */ +#define PP_MAGIC_MASK ~0x3UL + /** * struct page_pool_params - page pool parameters * @fast: params accessed frequently on hotpath @@ -264,6 +272,11 @@ void page_pool_destroy(struct page_pool *pool); void page_pool_use_xdp_mem(struct page_pool *pool, void (*disconnect)(void *), const struct xdp_mem_info *mem); void page_pool_put_netmem_bulk(netmem_ref *data, u32 count); + +static inline bool page_pool_page_is_pp(struct page *page) +{ + return (page->pp_magic & PP_MAGIC_MASK) == PP_SIGNATURE; +} #else static inline void page_pool_destroy(struct page_pool *pool) { @@ -278,6 +291,11 @@ static inline void page_pool_use_xdp_mem(struct page_pool *pool, static inline void page_pool_put_netmem_bulk(netmem_ref *data, u32 count) { } + +static inline bool page_pool_page_is_pp(struct page *page) +{ + return false; +} #endif void page_pool_put_unrefed_netmem(struct page_pool *pool, netmem_ref netmem, diff --git a/mm/page_alloc.c b/mm/page_alloc.c index 542d25f77be80304b731411ffd29b276ee13be0c..3535ee76afe946cbb042ecbce603bdbedc9233b9 100644 --- a/mm/page_alloc.c +++ b/mm/page_alloc.c @@ -55,6 +55,7 @@ #include #include #include +#include #include #include "internal.h" #include "shuffle.h" @@ -872,9 +873,7 @@ static inline bool page_expected_state(struct page *page, #ifdef CONFIG_MEMCG page->memcg_data | #endif -#ifdef CONFIG_PAGE_POOL - ((page->pp_magic & ~0x3UL) == PP_SIGNATURE) | -#endif + page_pool_page_is_pp(page) | (page->flags & check_flags))) return false; @@ -901,10 +900,8 @@ static const char *page_bad_reason(struct page *page, unsigned long flags) if (unlikely(page->memcg_data)) bad_reason = "page still charged to cgroup"; #endif -#ifdef CONFIG_PAGE_POOL - if (unlikely((page->pp_magic & ~0x3UL) == PP_SIGNATURE)) + if (unlikely(page_pool_page_is_pp(page))) bad_reason = "page_pool leak"; -#endif return bad_reason; } diff --git a/net/core/netmem_priv.h b/net/core/netmem_priv.h index 7eadb8393e002fd1cc2cef8a313d2ea7df76f301..f33162fd281c23e109273ba09950c5d0a2829bc9 100644 --- a/net/core/netmem_priv.h +++ b/net/core/netmem_priv.h @@ -18,6 +18,11 @@ static inline void netmem_clear_pp_magic(netmem_ref netmem) __netmem_clear_lsb(netmem)->pp_magic = 0; } +static inline bool netmem_is_pp(netmem_ref netmem) +{ + return (netmem_get_pp_magic(netmem) & PP_MAGIC_MASK) == PP_SIGNATURE; +} + static inline void netmem_set_pp(netmem_ref netmem, struct page_pool *pool) { __netmem_clear_lsb(netmem)->pp = pool; diff --git a/net/core/skbuff.c b/net/core/skbuff.c index 6cbf77bc61fce74c934628fd74b3a2cb7809e464..74a2d886a35b518d55b6d3cafcb8442212f9beee 100644 --- a/net/core/skbuff.c +++ b/net/core/skbuff.c @@ -893,11 +893,6 @@ static void skb_clone_fraglist(struct sk_buff *skb) skb_get(list); } -static bool is_pp_netmem(netmem_ref netmem) -{ - return (netmem_get_pp_magic(netmem) & ~0x3UL) == PP_SIGNATURE; -} - int skb_pp_cow_data(struct page_pool *pool, struct sk_buff **pskb, unsigned int headroom) { @@ -995,14 +990,7 @@ bool napi_pp_put_page(netmem_ref netmem) { netmem = netmem_compound_head(netmem); - /* page->pp_magic is OR'ed with PP_SIGNATURE after the allocation - * in order to preserve any existing bits, such as bit 0 for the - * head page of compound page and bit 1 for pfmemalloc page, so - * mask those bits for freeing side when doing below checking, - * and page_is_pfmemalloc() is checked in __page_pool_put_page() - * to avoid recycling the pfmemalloc page. - */ - if (unlikely(!is_pp_netmem(netmem))) + if (unlikely(!netmem_is_pp(netmem))) return false; page_pool_put_full_netmem(netmem_get_pp(netmem), netmem, false); @@ -1042,7 +1030,7 @@ static int skb_pp_frag_ref(struct sk_buff *skb) for (i = 0; i < shinfo->nr_frags; i++) { head_netmem = netmem_compound_head(shinfo->frags[i].netmem); - if (likely(is_pp_netmem(head_netmem))) + if (likely(netmem_is_pp(head_netmem))) page_pool_ref_netmem(head_netmem); else page_ref_inc(netmem_to_page(head_netmem)); diff --git a/net/core/xdp.c b/net/core/xdp.c index f86eedad586a77eb63a96a85aa6d068d3e94f077..0ba73943c6eed873b3d1c681b3b9a802b590f2d9 100644 --- a/net/core/xdp.c +++ b/net/core/xdp.c @@ -437,8 +437,8 @@ void __xdp_return(netmem_ref netmem, enum xdp_mem_type mem_type, netmem = netmem_compound_head(netmem); if (napi_direct && xdp_return_frame_no_direct()) napi_direct = false; - /* No need to check ((page->pp_magic & ~0x3UL) == PP_SIGNATURE) - * as mem->type knows this a page_pool page + /* No need to check netmem_is_pp() as mem->type knows this a + * page_pool page */ page_pool_put_full_netmem(netmem_get_pp(netmem), netmem, napi_direct); From patchwork Fri Mar 28 12:19:09 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Toke_H=C3=B8iland-J=C3=B8rgensen?= X-Patchwork-Id: 14031875 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id DA4A0C28B20 for ; Fri, 28 Mar 2025 12:19:27 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id CD77928013A; Fri, 28 Mar 2025 08:19:25 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id C86FB280139; Fri, 28 Mar 2025 08:19:25 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B28AB28013A; Fri, 28 Mar 2025 08:19:25 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 8D80E280138 for ; Fri, 28 Mar 2025 08:19:25 -0400 (EDT) Received: from smtpin14.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 793691CE1E3 for ; Fri, 28 Mar 2025 12:19:26 +0000 (UTC) X-FDA: 83270865132.14.B3F1572 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf22.hostedemail.com (Postfix) with ESMTP id 1D873C0002 for ; Fri, 28 Mar 2025 12:19:23 +0000 (UTC) Authentication-Results: imf22.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=Z1l7PSUe; spf=pass (imf22.hostedemail.com: domain of toke@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=toke@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1743164364; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=t+9WEEZ7nyxEOTwRhLXFY7w9vU1T2eILkruBuK9Xjzs=; b=TFJI/+ic8AuvCEuQgZymtgW9c/jpGYdmEsYYn4XHY1Pu882+46pUJEUGg/o1/puwNIRIWW KTQvblzGlI+dN2RV+PovywF0zi0ahlSoaIYVilynSzmcDfJ0TNXlu1XYIM3JpZ4JFi0PUD b0mvqganH6S6DkWHzTRXEMxVXmbvng8= ARC-Authentication-Results: i=1; imf22.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=Z1l7PSUe; spf=pass (imf22.hostedemail.com: domain of toke@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=toke@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1743164364; a=rsa-sha256; cv=none; b=SjCipSsu87Gux/b7WJhYnVeRtlatVIV1DESJmKOBvEN/m9dUTV/5K8OVmnqCLBSsGS0rK8 /n+2R2ftxori3aa0pNSHgUNXsea++HWVTyzDubeV8U3uW0ukj4+Smy0ETBcMuKtzQhbll7 CenWWivJax25WWHD1hV0ZRh8pwVlpy0= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1743164363; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=t+9WEEZ7nyxEOTwRhLXFY7w9vU1T2eILkruBuK9Xjzs=; b=Z1l7PSUeKVP9Wy0gRO2fIPtdm954zvPNcw8y/CB3s+EkZLHXCiVrm1lOmcYxqyNx/wrOl5 Unsp6Hbpwi/BEAuEL8+2X4V1TJkLp0UTME+8g6P/C6aci22ul3wK1joLJDY5fX2F1VRUyW iyp4YhV19HtDegTj3MzauHarik4v8mE= Received: from mail-ej1-f72.google.com (mail-ej1-f72.google.com [209.85.218.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-260-iXG_GZmoP9yi92s4nL8jNA-1; Fri, 28 Mar 2025 08:19:22 -0400 X-MC-Unique: iXG_GZmoP9yi92s4nL8jNA-1 X-Mimecast-MFC-AGG-ID: iXG_GZmoP9yi92s4nL8jNA_1743164361 Received: by mail-ej1-f72.google.com with SMTP id a640c23a62f3a-ac6ce5fe9bfso240488166b.1 for ; Fri, 28 Mar 2025 05:19:21 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1743164361; x=1743769161; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=t+9WEEZ7nyxEOTwRhLXFY7w9vU1T2eILkruBuK9Xjzs=; b=mwkz2yz6D8BbVFsSaMOxowhaJuAOH9dM8jVDEZ//xD+xeewyQlrXZMcFHLyyJkEIyi RqHqvAYtOIS8V2s+aC0gLnZvluCFw5UWdvy8iWVkmubSAc60oR/ngAQnRbq9w/kaSITF 2gxH9MvzSJzHGOiQ9qCcYpLR7thPGwaI1K1RgASeC26NxW/pnCyYC4Ql9QwmOpeCMp3V U29FJD5fZ0c2WFhyuwIkt0Mj5oJ/tQtmqW5cXf03qkFy4TsHDQhOKRBjIaOwxcoyPwP0 2Bf8xsMibQcTUmUWmaexEFht+bXGp04zJRQUM3Q9BCgUr0jpo02Gby+QVThBeHDNU8Bg +PHg== X-Forwarded-Encrypted: i=1; AJvYcCVxpmgOUbsy99LV7vIJ3A0kUqij+ei4tmeep/Xk4He/FeOSQOBoDYIWdoosmFxfhvmMAKwBUfejzQ==@kvack.org X-Gm-Message-State: AOJu0YxyOd0gwvZPhl2IfEShlZozeJQO7PU2Pk//0WczgmJ2YHaamdhg z7sHPMk5CRDZNkc7SzJr26tYFquc+edcS4BUNVZjOn/vlLTzWYkgbPhLSBz+F3S1RMfQogNLJCC HV6nIMq5m3BJaWmqK9oBz1mMFH7M3RyshcdSrOMUoLrDx8mBA X-Gm-Gg: ASbGncukCMK/KfFwkkkHBsLew9Oi4nk7CQmjUBzFqlzqJ062f7JyaD2LBqaT0osQdXi zFoIuBGhJjYC7OA+7lkHccN7pUAg8nn/FlaXrO0uUZv8ymtxBA+60yMcvAqk7pWPxfsJiQI+tnG 5bBiwS1cyb5435V2pCPqj9wKU3xbanIu8SxcnCpIkr4C4Y1SfENn2KlnlRVs70LfTj/vQ+5G61p YMA5HAlEePDzkxkQcvESF5R0TkY0VlDsw7GnwkwOFbNoHnDJcpfxmQ9A3yYA1IT0Ggu0v5WTy9h Y2ki1Lh/0hJD X-Received: by 2002:a17:907:7293:b0:ac2:8faa:e037 with SMTP id a640c23a62f3a-ac6fb18b78amr664817266b.57.1743164360361; Fri, 28 Mar 2025 05:19:20 -0700 (PDT) X-Google-Smtp-Source: AGHT+IE1GEavxKBwaRCm19I6L9U7varWGhunOUuRoOm8gO/iikVOkfcliO5uRP1gnqbt25bX0x+OQw== X-Received: by 2002:a17:907:7293:b0:ac2:8faa:e037 with SMTP id a640c23a62f3a-ac6fb18b78amr664812266b.57.1743164359687; Fri, 28 Mar 2025 05:19:19 -0700 (PDT) Received: from alrua-x1.borgediget.toke.dk ([2a0c:4d80:42:443::2]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-ac71922bf79sm151646366b.35.2025.03.28.05.19.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 28 Mar 2025 05:19:18 -0700 (PDT) Received: by alrua-x1.borgediget.toke.dk (Postfix, from userid 1000) id 8B67518FCDC7; Fri, 28 Mar 2025 13:19:17 +0100 (CET) From: =?utf-8?q?Toke_H=C3=B8iland-J=C3=B8rgensen?= Date: Fri, 28 Mar 2025 13:19:09 +0100 Subject: [PATCH net-next v5 2/2] page_pool: Track DMA-mapped pages and unmap them when destroying the pool MIME-Version: 1.0 Message-Id: <20250328-page-pool-track-dma-v5-2-55002af683ad@redhat.com> References: <20250328-page-pool-track-dma-v5-0-55002af683ad@redhat.com> In-Reply-To: <20250328-page-pool-track-dma-v5-0-55002af683ad@redhat.com> To: "David S. Miller" , Jakub Kicinski , Jesper Dangaard Brouer , Saeed Mahameed , Leon Romanovsky , Tariq Toukan , Andrew Lunn , Eric Dumazet , Paolo Abeni , Ilias Apalodimas , Simon Horman , Andrew Morton , Mina Almasry , Yonglong Liu , Yunsheng Lin , Pavel Begunkov , Matthew Wilcox Cc: netdev@vger.kernel.org, bpf@vger.kernel.org, linux-rdma@vger.kernel.org, linux-mm@kvack.org, =?utf-8?q?Toke_H=C3=B8iland-J=C3=B8rgensen?= , Qiuling Ren , Yuying Ma X-Mailer: b4 0.14.2 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: 1MEroBZmgAgDiO1o1imZ6WP01x7Gx4Qtgvr2s3gEWuY_1743164361 X-Mimecast-Originator: redhat.com X-Rspamd-Queue-Id: 1D873C0002 X-Rspam-User: X-Rspamd-Server: rspam02 X-Stat-Signature: mx9rwwiwzwwy4wsnm1ccrj1jya6ioe8b X-HE-Tag: 1743164363-306520 X-HE-Meta: U2FsdGVkX1/bD55gZDwT6CMfR39FdQTfzdjVEg6uYNR3Zw3svOa+R6pGl+42YFWqq6YnKNgG8T4UJISYRt6REU1UWOhCODqXxtRlxq50Wqau9RzETkwfVtx0l/qv+RtSq9AvtHC+943BryXipLmmDAXbl3Kf5u0GaIHGVNaEVy/U/SH8LAtSU5gb1tIVmI7S2693ZIe59qiwcQdiw4FxQRYCx2YQwyEu14zSCjYi9gbHQ0/FTnkwGpKwCi94//ZYvNONRcHILbVfgz60RfMsBNBxCWq+CZIFtdhz8uv/D4I5QiGJYhmz/Zi1Ye9JgkU38P05fHgYhCX3sfuQ9EugNwAjSZmYeiwp3WpDE/HuUNR3X35BimFxtCjLqs/5wLZQbgztYRdZx7jEtkNaNZDZZuJDRFu2bGOqZkJ0oHD1/sc6UJpmnZEtQ8MMt9LeAKONkRAyG5Isbhav83vpiWgmJAcvmtLk0S7RjpE3YT+ffT82aXvt5VdATBBa/eVE3sGt7OLDnkbbpqlk8BCfjWjxk0RCAgrfqNZZuHGGYfZVBBtOTepdfHx0Si4tG38FiHuh5xRU1PNqy4ZholLVf1ZePY71WyAKQ7UZcT375p6CDJHd6ZURHT4N1zh7vF/LDTuhzbZWKjFW/2haYpeuMgB0RKAmsZCLp40xUcsmFOItcbbNyOuQ8d1M8EWEBI0tuqtlbrBSAzfL9TaNDtSLTHTENeJ4jwA22OqLfQwhVKHvsV0r9MQwqZhPi6gYiG/fq1aZM8zYRgf8ynpZFGcMuldpKa+gqJYY47VankABA0ygDJtKtK4F5UxBhXq6B9MkAgO+yZyeAZGdNjDe3C68ovf8xZNoFcDEHi23+nhrcE4J0oc0KjUvvjYl+UB8fEVS8wFszgxN8R1GbyD3Z7GpYzfjwINk3kzWPtITSLjmYXvaz3AkDGNzGpe4tvnZhm6bb71YOOgJlmIDBaUo3nw+mUC 7e7Liu+L MkRc/z38pYXgYNP7mRKazFLaEPrQ53v0P9ixtIonKoz+yqXgxRFBKJBISEcSNFH9n0K1aUHQP4z8DRJR8MboATxW7KD13b1Pbdjnkc08ZnsguH37r2pGZXPC/RhR6uqxQEB/2fKiJBPP2nW6HNe9EMxosho3zCU++CcGDL2wjrZdX738lCvhzkrr1Cr1IEu/ruAMt9uabOlQ8sVxPufANJRs6zptJ6Rao0WP8Fvy8zPqri3Lnz6TrgUPeAdHmjkbflm2jvCMN1chrU1OLEb+EUUWFXgMccA++gknNNMfcTMdlUVA4N3HgrHvLCfVEeeS/4aMD7p+rtWJ9Qtwybk0I3UzY0faazf5IhDqp0SFwuHqMAVztqmRsYou1xnpFSdHLW9/rVeQ/9rqP1jfzoLD/sqDKeSAs6K8S/nbGrlrwNZl0WYCYhM2Ci09pAMFS5tOh/J+JLvL/Tm/SqpnIxVWlHjbiW/U2kCaDCpsR4Bs8AgQaiedN7fMq3qpoBN6ehK5Z0tR9xSaBTtvdY23sVUHqfs8NkQolW7vjh3Fzc6M94e76/lx9KgBRXpSLAxFjm8+RFtL4DsuEFehMlOamd+I5PBZDxskJjJBIQ0KPoR7XkNZgnTo/3p+vG4Y9mkxyO5LHtTJjETEyLkk65rZARs/Wt9Q+WtSvkbUp70nuVP6wLwsXIkJ4klEMB63DbAw8ZKjY54KcNUf7LzUpP8k= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: When enabling DMA mapping in page_pool, pages are kept DMA mapped until they are released from the pool, to avoid the overhead of re-mapping the pages every time they are used. This causes resource leaks and/or crashes when there are pages still outstanding while the device is torn down, because page_pool will attempt an unmap through a non-existent DMA device on the subsequent page return. To fix this, implement a simple tracking of outstanding DMA-mapped pages in page pool using an xarray. This was first suggested by Mina[0], and turns out to be fairly straight forward: We simply store pointers to pages directly in the xarray with xa_alloc() when they are first DMA mapped, and remove them from the array on unmap. Then, when a page pool is torn down, it can simply walk the xarray and unmap all pages still present there before returning, which also allows us to get rid of the get/put_device() calls in page_pool. Using xa_cmpxchg(), no additional synchronisation is needed, as a page will only ever be unmapped once. To avoid having to walk the entire xarray on unmap to find the page reference, we stash the ID assigned by xa_alloc() into the page structure itself, using the upper bits of the pp_magic field. This requires a couple of defines to avoid conflicting with the POINTER_POISON_DELTA define, but this is all evaluated at compile-time, so does not affect run-time performance. The bitmap calculations in this patch gives the following number of bits for different architectures: - 23 bits on 32-bit architectures - 21 bits on PPC64 (because of the definition of ILLEGAL_POINTER_VALUE) - 32 bits on other 64-bit architectures Stashing a value into the unused bits of pp_magic does have the effect that it can make the value stored there lie outside the unmappable range (as governed by the mmap_min_addr sysctl), for architectures that don't define ILLEGAL_POINTER_VALUE. This means that if one of the pointers that is aliased to the pp_magic field (such as page->lru.next) is dereferenced while the page is owned by page_pool, that could lead to a dereference into userspace, which is a security concern. The risk of this is mitigated by the fact that (a) we always clear pp_magic before releasing a page from page_pool, and (b) this would need a use-after-free bug for struct page, which can have many other risks since page->lru.next is used as a generic list pointer in multiple places in the kernel. As such, with this patch we take the position that this risk is negligible in practice. For more discussion, see[1]. Since all the tracking added in this patch is performed on DMA map/unmap, no additional code is needed in the fast path, meaning the performance overhead of this tracking is negligible there. A micro-benchmark shows that the total overhead of the tracking itself is about 400 ns (39 cycles(tsc) 395.218 ns; sum for both map and unmap[2]). Since this cost is only paid on DMA map and unmap, it seems like an acceptable cost to fix the late unmap issue. Further optimisation can narrow the cases where this cost is paid (for instance by eliding the tracking when DMA map/unmap is a no-op). The extra memory needed to track the pages is neatly encapsulated inside xarray, which uses the 'struct xa_node' structure to track items. This structure is 576 bytes long, with slots for 64 items, meaning that a full node occurs only 9 bytes of overhead per slot it tracks (in practice, it probably won't be this efficient, but in any case it should be an acceptable overhead). [0] https://lore.kernel.org/all/CAHS8izPg7B5DwKfSuzz-iOop_YRbk3Sd6Y4rX7KBG9DcVJcyWg@mail.gmail.com/ [1] https://lore.kernel.org/r/20250320023202.GA25514@openwall.com [2] https://lore.kernel.org/r/ae07144c-9295-4c9d-a400-153bb689fe9e@huawei.com Reported-by: Yonglong Liu Closes: https://lore.kernel.org/r/8743264a-9700-4227-a556-5f931c720211@huawei.com Fixes: ff7d6b27f894 ("page_pool: refurbish version of page_pool code") Suggested-by: Mina Almasry Reviewed-by: Mina Almasry Reviewed-by: Jesper Dangaard Brouer Tested-by: Jesper Dangaard Brouer Tested-by: Qiuling Ren Tested-by: Yuying Ma Tested-by: Yonglong Liu Acked-by: Jesper Dangaard Brouer Signed-off-by: Toke Høiland-Jørgensen --- include/linux/poison.h | 4 +++ include/net/page_pool/types.h | 53 ++++++++++++++++++++++++---- net/core/netmem_priv.h | 28 ++++++++++++++- net/core/page_pool.c | 82 ++++++++++++++++++++++++++++++++++++------- 4 files changed, 148 insertions(+), 19 deletions(-) diff --git a/include/linux/poison.h b/include/linux/poison.h index 331a9a996fa8746626afa63ea462b85ca3e5938b..5351efd710d5e21cc341f7bb533b1aeea4a0808a 100644 --- a/include/linux/poison.h +++ b/include/linux/poison.h @@ -70,6 +70,10 @@ #define KEY_DESTROY 0xbd /********** net/core/page_pool.c **********/ +/* + * page_pool uses additional free bits within this value to store data, see the + * definition of PP_DMA_INDEX_MASK in include/net/page_pool/types.h + */ #define PP_SIGNATURE (0x40 + POISON_POINTER_DELTA) /********** net/core/skbuff.c **********/ diff --git a/include/net/page_pool/types.h b/include/net/page_pool/types.h index df0d3c1608929605224feb26173135ff37951ef8..5835d359ecd0ac75dd737736926914ef7dd60646 100644 --- a/include/net/page_pool/types.h +++ b/include/net/page_pool/types.h @@ -6,6 +6,7 @@ #include #include #include +#include #include #define PP_FLAG_DMA_MAP BIT(0) /* Should page_pool do the DMA @@ -54,13 +55,51 @@ struct pp_alloc_cache { netmem_ref cache[PP_ALLOC_CACHE_SIZE]; }; +/* + * DMA mapping IDs + * + * When DMA-mapping a page, we allocate an ID (from an xarray) and stash this in + * the upper bits of page->pp_magic. We always want to be able to unambiguously + * identify page pool pages (using page_pool_page_is_pp()). Non-PP pages can + * have arbitrary kernel pointers stored in the same field as pp_magic (since it + * overlaps with page->lru.next), so we must ensure that we cannot mistake a + * valid kernel pointer with any of the values we write into this field. + * + * On architectures that set POISON_POINTER_DELTA, this is already ensured, + * since this value becomes part of PP_SIGNATURE; meaning we can just use the + * space between the PP_SIGNATURE value (without POISON_POINTER_DELTA), and the + * lowest bits of POISON_POINTER_DELTA. On arches where POISON_POINTER_DELTA is + * 0, we make sure that we leave the two topmost bits empty, as that guarantees + * we won't mistake a valid kernel pointer for a value we set, regardless of the + * VMSPLIT setting. + * + * Altogether, this means that the number of bits available is constrained by + * the size of an unsigned long (at the upper end, subtracting two bits per the + * above), and the definition of PP_SIGNATURE (with or without + * POISON_POINTER_DELTA). + */ +#define PP_DMA_INDEX_SHIFT (1 + __fls(PP_SIGNATURE - POISON_POINTER_DELTA)) +#if POISON_POINTER_DELTA > 0 +/* PP_SIGNATURE includes POISON_POINTER_DELTA, so limit the size of the DMA + * index to not overlap with that if set + */ +#define PP_DMA_INDEX_BITS MIN(32, __ffs(POISON_POINTER_DELTA) - PP_DMA_INDEX_SHIFT) +#else +/* Always leave out the topmost two; see above. */ +#define PP_DMA_INDEX_BITS MIN(32, BITS_PER_LONG - PP_DMA_INDEX_SHIFT - 2) +#endif + +#define PP_DMA_INDEX_MASK GENMASK(PP_DMA_INDEX_BITS + PP_DMA_INDEX_SHIFT - 1, \ + PP_DMA_INDEX_SHIFT) +#define PP_DMA_INDEX_LIMIT XA_LIMIT(1, BIT(PP_DMA_INDEX_BITS) - 1) + /* Mask used for checking in page_pool_page_is_pp() below. page->pp_magic is * OR'ed with PP_SIGNATURE after the allocation in order to preserve bit 0 for - * the head page of compound page and bit 1 for pfmemalloc page. - * page_is_pfmemalloc() is checked in __page_pool_put_page() to avoid recycling - * the pfmemalloc page. + * the head page of compound page and bit 1 for pfmemalloc page, as well as the + * bits used for the DMA index. page_is_pfmemalloc() is checked in + * __page_pool_put_page() to avoid recycling the pfmemalloc page. */ -#define PP_MAGIC_MASK ~0x3UL +#define PP_MAGIC_MASK ~(PP_DMA_INDEX_MASK | 0x3UL) /** * struct page_pool_params - page pool parameters @@ -173,10 +212,10 @@ struct page_pool { int cpuid; u32 pages_state_hold_cnt; - bool has_init_callback:1; /* slow::init_callback is set */ + bool dma_sync; /* Perform DMA sync for device */ bool dma_map:1; /* Perform DMA mapping */ - bool dma_sync:1; /* Perform DMA sync for device */ bool dma_sync_for_cpu:1; /* Perform DMA sync for cpu */ + bool has_init_callback:1; /* slow::init_callback is set */ #ifdef CONFIG_PAGE_POOL_STATS bool system:1; /* This is a global percpu pool */ #endif @@ -229,6 +268,8 @@ struct page_pool { void *mp_priv; const struct memory_provider_ops *mp_ops; + struct xarray dma_mapped; + #ifdef CONFIG_PAGE_POOL_STATS /* recycle stats are per-cpu to avoid locking */ struct page_pool_recycle_stats __percpu *recycle_stats; diff --git a/net/core/netmem_priv.h b/net/core/netmem_priv.h index f33162fd281c23e109273ba09950c5d0a2829bc9..cd95394399b40c3604934ba7898eeeeacb8aee99 100644 --- a/net/core/netmem_priv.h +++ b/net/core/netmem_priv.h @@ -5,7 +5,7 @@ static inline unsigned long netmem_get_pp_magic(netmem_ref netmem) { - return __netmem_clear_lsb(netmem)->pp_magic; + return __netmem_clear_lsb(netmem)->pp_magic & ~PP_DMA_INDEX_MASK; } static inline void netmem_or_pp_magic(netmem_ref netmem, unsigned long pp_magic) @@ -15,6 +15,8 @@ static inline void netmem_or_pp_magic(netmem_ref netmem, unsigned long pp_magic) static inline void netmem_clear_pp_magic(netmem_ref netmem) { + WARN_ON_ONCE(__netmem_clear_lsb(netmem)->pp_magic & PP_DMA_INDEX_MASK); + __netmem_clear_lsb(netmem)->pp_magic = 0; } @@ -33,4 +35,28 @@ static inline void netmem_set_dma_addr(netmem_ref netmem, { __netmem_clear_lsb(netmem)->dma_addr = dma_addr; } + +static inline unsigned long netmem_get_dma_index(netmem_ref netmem) +{ + unsigned long magic; + + if (WARN_ON_ONCE(netmem_is_net_iov(netmem))) + return 0; + + magic = __netmem_clear_lsb(netmem)->pp_magic; + + return (magic & PP_DMA_INDEX_MASK) >> PP_DMA_INDEX_SHIFT; +} + +static inline void netmem_set_dma_index(netmem_ref netmem, + unsigned long id) +{ + unsigned long magic; + + if (WARN_ON_ONCE(netmem_is_net_iov(netmem))) + return; + + magic = netmem_get_pp_magic(netmem) | (id << PP_DMA_INDEX_SHIFT); + __netmem_clear_lsb(netmem)->pp_magic = magic; +} #endif diff --git a/net/core/page_pool.c b/net/core/page_pool.c index 7745ad924ae2d801580a6760eba9393e1cf67b01..79cc90ea1d3b5cfb9e7b200ae6b36bc40835386f 100644 --- a/net/core/page_pool.c +++ b/net/core/page_pool.c @@ -227,6 +227,8 @@ static int page_pool_init(struct page_pool *pool, return -EINVAL; pool->dma_map = true; + + xa_init_flags(&pool->dma_mapped, XA_FLAGS_ALLOC1); } if (pool->slow.flags & PP_FLAG_DMA_SYNC_DEV) { @@ -276,9 +278,6 @@ static int page_pool_init(struct page_pool *pool, /* Driver calling page_pool_create() also call page_pool_destroy() */ refcount_set(&pool->user_cnt, 1); - if (pool->dma_map) - get_device(pool->p.dev); - if (pool->slow.flags & PP_FLAG_ALLOW_UNREADABLE_NETMEM) { netdev_assert_locked(pool->slow.netdev); rxq = __netif_get_rx_queue(pool->slow.netdev, @@ -322,7 +321,7 @@ static void page_pool_uninit(struct page_pool *pool) ptr_ring_cleanup(&pool->ring, NULL); if (pool->dma_map) - put_device(pool->p.dev); + xa_destroy(&pool->dma_mapped); #ifdef CONFIG_PAGE_POOL_STATS if (!pool->system) @@ -463,13 +462,21 @@ page_pool_dma_sync_for_device(const struct page_pool *pool, netmem_ref netmem, u32 dma_sync_size) { - if (pool->dma_sync && dma_dev_need_sync(pool->p.dev)) - __page_pool_dma_sync_for_device(pool, netmem, dma_sync_size); + if (pool->dma_sync && dma_dev_need_sync(pool->p.dev)) { + rcu_read_lock(); + /* re-check under rcu_read_lock() to sync with page_pool_scrub() */ + if (READ_ONCE(pool->dma_sync)) + __page_pool_dma_sync_for_device(pool, netmem, + dma_sync_size); + rcu_read_unlock(); + } } -static bool page_pool_dma_map(struct page_pool *pool, netmem_ref netmem) +static bool page_pool_dma_map(struct page_pool *pool, netmem_ref netmem, gfp_t gfp) { dma_addr_t dma; + int err; + u32 id; /* Setup DMA mapping: use 'struct page' area for storing DMA-addr * since dma_addr_t can be either 32 or 64 bits and does not always fit @@ -483,15 +490,28 @@ static bool page_pool_dma_map(struct page_pool *pool, netmem_ref netmem) if (dma_mapping_error(pool->p.dev, dma)) return false; - if (page_pool_set_dma_addr_netmem(netmem, dma)) + if (in_softirq()) + err = xa_alloc(&pool->dma_mapped, &id, netmem_to_page(netmem), + PP_DMA_INDEX_LIMIT, gfp); + else + err = xa_alloc_bh(&pool->dma_mapped, &id, netmem_to_page(netmem), + PP_DMA_INDEX_LIMIT, gfp); + if (err) { + WARN_ONCE(1, "couldn't track DMA mapping, please report to netdev@"); goto unmap_failed; + } + if (page_pool_set_dma_addr_netmem(netmem, dma)) { + WARN_ONCE(1, "unexpected DMA address, please report to netdev@"); + goto unmap_failed; + } + + netmem_set_dma_index(netmem, id); page_pool_dma_sync_for_device(pool, netmem, pool->p.max_len); return true; unmap_failed: - WARN_ONCE(1, "unexpected DMA address, please report to netdev@"); dma_unmap_page_attrs(pool->p.dev, dma, PAGE_SIZE << pool->p.order, pool->p.dma_dir, DMA_ATTR_SKIP_CPU_SYNC | DMA_ATTR_WEAK_ORDERING); @@ -508,7 +528,7 @@ static struct page *__page_pool_alloc_page_order(struct page_pool *pool, if (unlikely(!page)) return NULL; - if (pool->dma_map && unlikely(!page_pool_dma_map(pool, page_to_netmem(page)))) { + if (pool->dma_map && unlikely(!page_pool_dma_map(pool, page_to_netmem(page), gfp))) { put_page(page); return NULL; } @@ -554,7 +574,7 @@ static noinline netmem_ref __page_pool_alloc_pages_slow(struct page_pool *pool, */ for (i = 0; i < nr_pages; i++) { netmem = pool->alloc.cache[i]; - if (dma_map && unlikely(!page_pool_dma_map(pool, netmem))) { + if (dma_map && unlikely(!page_pool_dma_map(pool, netmem, gfp))) { put_page(netmem_to_page(netmem)); continue; } @@ -656,6 +676,8 @@ void page_pool_clear_pp_info(netmem_ref netmem) static __always_inline void __page_pool_release_page_dma(struct page_pool *pool, netmem_ref netmem) { + struct page *old, *page = netmem_to_page(netmem); + unsigned long id; dma_addr_t dma; if (!pool->dma_map) @@ -664,6 +686,17 @@ static __always_inline void __page_pool_release_page_dma(struct page_pool *pool, */ return; + id = netmem_get_dma_index(netmem); + if (!id) + return; + + if (in_softirq()) + old = xa_cmpxchg(&pool->dma_mapped, id, page, NULL, 0); + else + old = xa_cmpxchg_bh(&pool->dma_mapped, id, page, NULL, 0); + if (old != page) + return; + dma = page_pool_get_dma_addr_netmem(netmem); /* When page is unmapped, it cannot be returned to our pool */ @@ -671,6 +704,7 @@ static __always_inline void __page_pool_release_page_dma(struct page_pool *pool, PAGE_SIZE << pool->p.order, pool->p.dma_dir, DMA_ATTR_SKIP_CPU_SYNC | DMA_ATTR_WEAK_ORDERING); page_pool_set_dma_addr_netmem(netmem, 0); + netmem_set_dma_index(netmem, 0); } /* Disconnects a page (from a page_pool). API users can have a need @@ -1080,8 +1114,32 @@ static void page_pool_empty_alloc_cache_once(struct page_pool *pool) static void page_pool_scrub(struct page_pool *pool) { + unsigned long id; + void *ptr; + page_pool_empty_alloc_cache_once(pool); - pool->destroy_cnt++; + if (!pool->destroy_cnt++ && pool->dma_map) { + if (pool->dma_sync) { + /* paired with READ_ONCE in + * page_pool_dma_sync_for_device() and + * __page_pool_dma_sync_for_cpu() + */ + WRITE_ONCE(pool->dma_sync, false); + + /* Make sure all concurrent returns that may see the old + * value of dma_sync (and thus perform a sync) have + * finished before doing the unmapping below. Skip the + * wait if the device doesn't actually need syncing, or + * if there are no outstanding mapped pages. + */ + if (dma_dev_need_sync(pool->p.dev) && + !xa_empty(&pool->dma_mapped)) + synchronize_net(); + } + + xa_for_each(&pool->dma_mapped, id, ptr) + __page_pool_release_page_dma(pool, page_to_netmem(ptr)); + } /* No more consumers should exist, but producers could still * be in-flight.