From patchwork Mon Mar 31 12:18:18 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bhupesh X-Patchwork-Id: 14033560 Received: from fanzine2.igalia.com (fanzine.igalia.com [178.60.130.6]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2A5F51DD525; Mon, 31 Mar 2025 12:18:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=178.60.130.6 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1743423531; cv=none; b=efgw0oe7YQlNvk/+4Gb/blqOKeqpbZB/wPwgJ+z+M2ZryBhCURDACG5YomWiwGd4Vwec57iOkOs0R2X4ngde+6sQfmXq7EfRRhRpya7/Zd0riT3parjYfXLCLhEl7a6iWja87vEYScXmCez6PPV3TmtXZp8gpo+ptBfNg0YbhXg= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1743423531; c=relaxed/simple; bh=3NK1xXrNlc0u/r0W44A+OrbUmrXRF9zO+adUHiLTgFo=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=l4lsSGOoZEL8T0Pc0SX2ucaWb1r0/fZCR/uBqC+PusZGJ+A1bJt7mz95vnCAS0ro9Nz8Qc7TwSqFh8xMwSHDAQbm0xPkT/yZ545w8d0A60Q2fD4adZD925HbT44D8CoNDyp6uqoDgRPkgZEkVFNc40s1NoVqMXZ/FkD4wQwF4AE= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=igalia.com; spf=pass smtp.mailfrom=igalia.com; dkim=pass (2048-bit key) header.d=igalia.com header.i=@igalia.com header.b=GLoQ8Gs7; arc=none smtp.client-ip=178.60.130.6 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=igalia.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=igalia.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=igalia.com header.i=@igalia.com header.b="GLoQ8Gs7" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=igalia.com; s=20170329; h=Content-Transfer-Encoding:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Sender:Reply-To:Content-Type:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=m2o+Mi9B+LLlSr1F+IZ6AiiYjWbrFv3KIUCOssd5KE4=; b=GLoQ8Gs7Pv63GbZtpCeznhHQZD uGrw3V2kkzc05t3W9WL4nTZX5nrNHWFnf2oI+TulxjbbjiBuH13I6FIwJmAxh+qaikLRf3yKZ9e0z HD2HPTVbcLIBMPpKCCNDYZNLYwDAMk5n0eNwKKqtHRFqZkh5X0CfkPs48QBJytxuJywPJmCPFb4Ib u9XW3oOch4MwZynhdtcLpW7cqx8XuMgcjx6Yf01DOmYLiIcDbPGgJ9AAt1oCmCpLswGouy5i/3ZQ0 76c3H2ssIWvhu42wYkEIJ+CiP9csFpnYwT9QyddFHdCDAOMxhAdUHpNDFggAQynJsn7TfsVUjmVv4 e7mlHXnw==; Received: from [223.233.69.2] (helo=localhost.localdomain) by fanzine2.igalia.com with esmtpsa (Cipher TLS1.3:ECDHE_X25519__RSA_PSS_RSAE_SHA256__AES_256_GCM:256) (Exim) id 1tzE6G-009Btr-G1; Mon, 31 Mar 2025 14:18:44 +0200 From: Bhupesh To: akpm@linux-foundation.org Cc: bhupesh@igalia.com, kernel-dev@igalia.com, linux-kernel@vger.kernel.org, bpf@vger.kernel.org, linux-perf-users@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, oliver.sang@intel.com, lkp@intel.com, laoar.shao@gmail.com, pmladek@suse.com, rostedt@goodmis.org, mathieu.desnoyers@efficios.com, arnaldo.melo@gmail.com, alexei.starovoitov@gmail.com, andrii.nakryiko@gmail.com, mirq-linux@rere.qmqm.pl, peterz@infradead.org, willy@infradead.org, david@redhat.com, viro@zeniv.linux.org.uk, keescook@chromium.org, ebiederm@xmission.com, brauner@kernel.org, jack@suse.cz, mingo@redhat.com, juri.lelli@redhat.com, bsegall@google.com, mgorman@suse.de, vschneid@redhat.com Subject: [PATCH v2 1/3] exec: Dynamically allocate memory to store task's full name Date: Mon, 31 Mar 2025 17:48:18 +0530 Message-Id: <20250331121820.455916-2-bhupesh@igalia.com> X-Mailer: git-send-email 2.38.1 In-Reply-To: <20250331121820.455916-1-bhupesh@igalia.com> References: <20250331121820.455916-1-bhupesh@igalia.com> Precedence: bulk X-Mailing-List: linux-fsdevel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Provide a parallel implementation for get_task_comm() called get_task_full_name() which allows the dynamically allocated and filled-in task's full name to be passed to interested users such as 'gdb'. Currently while running 'gdb', the 'task->comm' value of a long task name is truncated due to the limitation of TASK_COMM_LEN. For example using gdb to debug a simple app currently which generate threads with long task names: # gdb ./threadnames -ex "run info thread" -ex "detach" -ex "quit" > log # cat log NameThatIsTooLo This patch does not touch 'TASK_COMM_LEN' at all, i.e. 'TASK_COMM_LEN' and the 16-byte design remains untouched. Which means that all the legacy / existing ABI, continue to work as before using '/proc/$pid/task/$tid/comm'. This patch only adds a parallel, dynamically-allocated 'task->full_name' which can be used by interested users via '/proc/$pid/task/$tid/full_name'. After this change, gdb is able to show full name of the task: # gdb ./threadnames -ex "run info thread" -ex "detach" -ex "quit" > log # cat log NameThatIsTooLongForComm[4662] Signed-off-by: Bhupesh --- fs/exec.c | 21 ++++++++++++++++++--- include/linux/sched.h | 9 +++++++++ 2 files changed, 27 insertions(+), 3 deletions(-) diff --git a/fs/exec.c b/fs/exec.c index f45859ad13ac..4219d77a519c 100644 --- a/fs/exec.c +++ b/fs/exec.c @@ -1208,6 +1208,9 @@ int begin_new_exec(struct linux_binprm * bprm) { struct task_struct *me = current; int retval; + va_list args; + char *name; + const char *fmt; /* Once we are committed compute the creds */ retval = bprm_creds_from_file(bprm); @@ -1348,11 +1351,22 @@ int begin_new_exec(struct linux_binprm * bprm) * detecting a concurrent rename and just want a terminated name. */ rcu_read_lock(); - __set_task_comm(me, smp_load_acquire(&bprm->file->f_path.dentry->d_name.name), - true); + fmt = smp_load_acquire(&bprm->file->f_path.dentry->d_name.name); + name = kvasprintf(GFP_KERNEL, fmt, args); + if (!name) + return -ENOMEM; + + me->full_name = name; + __set_task_comm(me, fmt, true); rcu_read_unlock(); } else { - __set_task_comm(me, kbasename(bprm->filename), true); + fmt = kbasename(bprm->filename); + name = kvasprintf(GFP_KERNEL, fmt, args); + if (!name) + return -ENOMEM; + + me->full_name = name; + __set_task_comm(me, fmt, true); } /* An exec changes our domain. We are no longer part of the thread @@ -1399,6 +1413,7 @@ int begin_new_exec(struct linux_binprm * bprm) return 0; out_unlock: + kfree(me->full_name); up_write(&me->signal->exec_update_lock); if (!bprm->cred) mutex_unlock(&me->signal->cred_guard_mutex); diff --git a/include/linux/sched.h b/include/linux/sched.h index 56ddeb37b5cd..053b52606652 100644 --- a/include/linux/sched.h +++ b/include/linux/sched.h @@ -1166,6 +1166,9 @@ struct task_struct { */ char comm[TASK_COMM_LEN]; + /* To store the full name if task comm is truncated. */ + char *full_name; + struct nameidata *nameidata; #ifdef CONFIG_SYSVIPC @@ -2007,6 +2010,12 @@ extern void __set_task_comm(struct task_struct *tsk, const char *from, bool exec buf; \ }) +#define get_task_full_name(buf, buf_size, tsk) ({ \ + BUILD_BUG_ON(sizeof(buf) < TASK_COMM_LEN); \ + strscpy_pad(buf, (tsk)->full_name, buf_size); \ + buf; \ +}) + #ifdef CONFIG_SMP static __always_inline void scheduler_ipi(void) { From patchwork Mon Mar 31 12:18:19 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bhupesh X-Patchwork-Id: 14033561 Received: from fanzine2.igalia.com (fanzine.igalia.com [178.60.130.6]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 572291E7C19; Mon, 31 Mar 2025 12:18:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=178.60.130.6 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1743423536; cv=none; b=n/uYZhTHpVgbyT4DVK/874eeHkTUpavP0OqHQpIT1m36bouqg8lWko0BDNtPqOmNdFLvtMj6Df5ELJR6hTP2W9z+DSwFNK6ww+0yqQATtH2e3B35dz76NVMnZGlh4R/3PCqzM+mW3VMCX38ZXxXBhR4tTq7L8TQeo9YVm6mQjLA= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1743423536; c=relaxed/simple; bh=KdHzqtsGEaarH4qC3RnC2h6Djh19sDj4W+qW72GXONc=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=qrteHUjj1Dmt4QzRGWKY4gDpnljfirq6OURLG+uxEmya0Lo4bQF07HKmVUtCuX5DgovvSh+MOYN7O/bH1ItkkadqgRCtx7O5cxoHOO2/8Nccw6CONpxV86kTk+ugSH3bj338KWLoyyIyatg93r2e+OG9BkNRVN6Gycxmq5Mm/u8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=igalia.com; spf=pass smtp.mailfrom=igalia.com; dkim=pass (2048-bit key) header.d=igalia.com header.i=@igalia.com header.b=TqEYOS1L; arc=none smtp.client-ip=178.60.130.6 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=igalia.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=igalia.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=igalia.com header.i=@igalia.com header.b="TqEYOS1L" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=igalia.com; s=20170329; h=Content-Transfer-Encoding:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Sender:Reply-To:Content-Type:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=1vPxYQklOIhLFkReMGUcHBCTjGCn9JiiqKZjhqBdRYE=; b=TqEYOS1L0FuyNPN6TTGJbIhjWh Wv6kmaGcSFWdzjyJpWyzinSSBVAvoahZ250TPc1+V1nKbFfVCBHv+FvFswD5tjZsh2dAkXqtnmTqn 5zHVmbIIPu8Jo0kw6gSUSxx9FqGex6HFS2inBsaidT5/qFyGPtuKfYSej51pL3w2heC79jIeihsYX Bv+yr86mXTMVr04VBnoEKyF1IRgG84bZ0qFmsuV2jRLOhgTfXlx/Z4jwy4Sbkd/l9Rbs805RMbwSk em+a+oZX74gkW+JRxRK6rA1gPrTj5zz4XLyDTiurr4h06HWLoQEhfwFblTMYFQEazwBPiYZg7S4O1 pmUfRABg==; Received: from [223.233.69.2] (helo=localhost.localdomain) by fanzine2.igalia.com with esmtpsa (Cipher TLS1.3:ECDHE_X25519__RSA_PSS_RSAE_SHA256__AES_256_GCM:256) (Exim) id 1tzE6M-009Btr-UZ; Mon, 31 Mar 2025 14:18:51 +0200 From: Bhupesh To: akpm@linux-foundation.org Cc: bhupesh@igalia.com, kernel-dev@igalia.com, linux-kernel@vger.kernel.org, bpf@vger.kernel.org, linux-perf-users@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, oliver.sang@intel.com, lkp@intel.com, laoar.shao@gmail.com, pmladek@suse.com, rostedt@goodmis.org, mathieu.desnoyers@efficios.com, arnaldo.melo@gmail.com, alexei.starovoitov@gmail.com, andrii.nakryiko@gmail.com, mirq-linux@rere.qmqm.pl, peterz@infradead.org, willy@infradead.org, david@redhat.com, viro@zeniv.linux.org.uk, keescook@chromium.org, ebiederm@xmission.com, brauner@kernel.org, jack@suse.cz, mingo@redhat.com, juri.lelli@redhat.com, bsegall@google.com, mgorman@suse.de, vschneid@redhat.com Subject: [PATCH v2 2/3] fs/proc: Pass 'task->full_name' via 'proc_task_name()' Date: Mon, 31 Mar 2025 17:48:19 +0530 Message-Id: <20250331121820.455916-3-bhupesh@igalia.com> X-Mailer: git-send-email 2.38.1 In-Reply-To: <20250331121820.455916-1-bhupesh@igalia.com> References: <20250331121820.455916-1-bhupesh@igalia.com> Precedence: bulk X-Mailing-List: linux-fsdevel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Now that we have the get_task_full_name() implementation which allows the dynamically allocated and filled in task's full name to be passed to interested users, use it in proc_task_name() by default for task names so that user-land can see them through appropriate tools (such as 'ps'). Signed-off-by: Bhupesh --- fs/proc/array.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/proc/array.c b/fs/proc/array.c index d6a0369caa93..2cbeb1584f8a 100644 --- a/fs/proc/array.c +++ b/fs/proc/array.c @@ -109,7 +109,7 @@ void proc_task_name(struct seq_file *m, struct task_struct *p, bool escape) else if (p->flags & PF_KTHREAD) get_kthread_comm(tcomm, sizeof(tcomm), p); else - get_task_comm(tcomm, p); + get_task_full_name(tcomm, sizeof(tcomm), p); if (escape) seq_escape_str(m, tcomm, ESCAPE_SPACE | ESCAPE_SPECIAL, "\n\\"); From patchwork Mon Mar 31 12:18:20 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bhupesh X-Patchwork-Id: 14033562 Received: from fanzine2.igalia.com (fanzine.igalia.com [178.60.130.6]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0767C1E520E; Mon, 31 Mar 2025 12:19:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=178.60.130.6 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1743423543; cv=none; b=Yn09B7t0/i7M2xtFQeo4JKTsgexBqZOldFIdf+EqfDpv6vGG3gXZxGVqNhS3S+HHEs8TPMK0JCPKAKpgKSVW6YqItKmxv3ApyjLLHdlWzaMMWIsfjfL/dNOuaYGiVJTu/Evki/aj+B5YIu5fa0OjhZK76cnfhQ0li8Lmt2sl8os= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1743423543; c=relaxed/simple; bh=PtHxBraQ24vnyVeWep51sRq6RV1wdc6wiax6qMPd+JE=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=abUkYBGBOyfKh4bs0X5d6voPdNzEskEoKdp7HP3GtF9zP2nR4pzAZDfz2rWdnynzO1sE9XT+wy4M786Jgl+vhdMcPfxGiF/8tDKdOwEq/r4hyHJcVPUBi+tsMa37sqap5eRx3HERFKmAy2ZPXWr63yTvS3kMdYXWOfJ2jL1NmSs= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=igalia.com; spf=pass smtp.mailfrom=igalia.com; dkim=pass (2048-bit key) header.d=igalia.com header.i=@igalia.com header.b=L+o/M001; arc=none smtp.client-ip=178.60.130.6 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=igalia.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=igalia.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=igalia.com header.i=@igalia.com header.b="L+o/M001" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=igalia.com; s=20170329; h=Content-Transfer-Encoding:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Sender:Reply-To:Content-Type:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=1MkSIgjVP+CNberSoyFKkoWthULoTCREbX6XMJGd8lA=; b=L+o/M001kDp9zhtwVq6l7nKazt X33DiETYaftD/OyEKT64sHULD1LqxAwwGVw2p50uEMaK8Qxw903OL83zpimWSnT/AHZUoHF86VBDT icgPE3a6B0BK5o0wn1dBYthmgxXQyzbDDZq1kMesB+zKwc85ztragw76N+q/2nRszAE1/kYMvEZdA gs+dsWb+iugK2xp8P6uKnQMf9F1HBIzIcT9OOqwqnFbHCzaIy6x4thyVVAfgzGoM2ve5QKQo15BI1 KnWXeXxsk2+zHZljLGAKzCB7cD/Wxt1H3wBSb9Hfk8+ifIoOJoYdN3Q3YToOJG3eC8hGhbtDze8ai 5mrotbzg==; Received: from [223.233.69.2] (helo=localhost.localdomain) by fanzine2.igalia.com with esmtpsa (Cipher TLS1.3:ECDHE_X25519__RSA_PSS_RSAE_SHA256__AES_256_GCM:256) (Exim) id 1tzE6T-009Btr-M7; Mon, 31 Mar 2025 14:18:58 +0200 From: Bhupesh To: akpm@linux-foundation.org Cc: bhupesh@igalia.com, kernel-dev@igalia.com, linux-kernel@vger.kernel.org, bpf@vger.kernel.org, linux-perf-users@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, oliver.sang@intel.com, lkp@intel.com, laoar.shao@gmail.com, pmladek@suse.com, rostedt@goodmis.org, mathieu.desnoyers@efficios.com, arnaldo.melo@gmail.com, alexei.starovoitov@gmail.com, andrii.nakryiko@gmail.com, mirq-linux@rere.qmqm.pl, peterz@infradead.org, willy@infradead.org, david@redhat.com, viro@zeniv.linux.org.uk, keescook@chromium.org, ebiederm@xmission.com, brauner@kernel.org, jack@suse.cz, mingo@redhat.com, juri.lelli@redhat.com, bsegall@google.com, mgorman@suse.de, vschneid@redhat.com Subject: [PATCH v2 3/3] kthread: Use 'task_struct->full_name' to store kthread's full name Date: Mon, 31 Mar 2025 17:48:20 +0530 Message-Id: <20250331121820.455916-4-bhupesh@igalia.com> X-Mailer: git-send-email 2.38.1 In-Reply-To: <20250331121820.455916-1-bhupesh@igalia.com> References: <20250331121820.455916-1-bhupesh@igalia.com> Precedence: bulk X-Mailing-List: linux-fsdevel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Commit 6986ce24fc00 ("kthread: dynamically allocate memory to store kthread's full name"), added 'full_name' in parallel to 'comm' for kthread names. Now that we have added 'full_name' added to 'task_struct' itself, drop the additional 'full_name' entry from 'struct kthread' and also its usage. Signed-off-by: Bhupesh --- kernel/kthread.c | 9 +++------ 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/kernel/kthread.c b/kernel/kthread.c index 5dc5b0d7238e..46fe19b7ef76 100644 --- a/kernel/kthread.c +++ b/kernel/kthread.c @@ -66,8 +66,6 @@ struct kthread { #ifdef CONFIG_BLK_CGROUP struct cgroup_subsys_state *blkcg_css; #endif - /* To store the full name if task comm is truncated. */ - char *full_name; struct task_struct *task; struct list_head hotplug_node; struct cpumask *preferred_affinity; @@ -108,12 +106,12 @@ void get_kthread_comm(char *buf, size_t buf_size, struct task_struct *tsk) { struct kthread *kthread = to_kthread(tsk); - if (!kthread || !kthread->full_name) { + if (!kthread || !tsk->full_name) { strscpy(buf, tsk->comm, buf_size); return; } - strscpy_pad(buf, kthread->full_name, buf_size); + strscpy_pad(buf, tsk->full_name, buf_size); } bool set_kthread_struct(struct task_struct *p) @@ -153,7 +151,6 @@ void free_kthread_struct(struct task_struct *k) WARN_ON_ONCE(kthread->blkcg_css); #endif k->worker_private = NULL; - kfree(kthread->full_name); kfree(kthread); } @@ -430,7 +427,7 @@ static int kthread(void *_create) kthread_exit(-EINTR); } - self->full_name = create->full_name; + self->task->full_name = create->full_name; self->threadfn = threadfn; self->data = data;