From patchwork Tue Apr 1 02:29:21 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Swarna Prabhu X-Patchwork-Id: 14034307 Received: from mail-pj1-f44.google.com (mail-pj1-f44.google.com [209.85.216.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E41301A3150; Tue, 1 Apr 2025 02:30:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.44 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1743474605; cv=none; b=lZ8YbDr3NgGY3f5MSJmipqpeRDxBYvKBPPIRcohNxIFaMM6nlobQ3pR6v06oLWwizjYzE1p4lbm0yYUGabxtgZT67ZhwNXjQdf5Ek7r09VlWxwFQAPL0Or217cJxbT3z7TrgypPJJ0CrXu3zALCuIRJRqayVbIrMUHXqZyAWTJI= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1743474605; c=relaxed/simple; bh=29VXDcWnd6GwWwhNVGcFA8Q/jEaR9/JRzP81bru6kEg=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=tgxXKyvj+csfLK9wVd4FMI1E5V19yvX1Hp5KiHFFglMNoICJtdt5BsxDofu75xyTB9GWeNLpDsLOg6A4xVGlmyo3KiSG7S3up44iMqh5wG/0H4HX15wfRmgJCL6QrgMy+GVjgUNX7NCdTws/IYoPdqCU0g0LkJn/zEWThwqkBN4= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=WSUPWJTj; arc=none smtp.client-ip=209.85.216.44 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="WSUPWJTj" Received: by mail-pj1-f44.google.com with SMTP id 98e67ed59e1d1-301a4d5156aso8165329a91.1; Mon, 31 Mar 2025 19:30:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1743474603; x=1744079403; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=JOUHkYETfeYPlrfgUGhvuwroRGucs+Rm6+GwIDzHnL8=; b=WSUPWJTj76DNhz7Li4t3+38I0sF0Nnx2Rr3gat/9HV75OUMzIRwpqpyhPKOElsDyeY hl4SakLm6vl4fy90q5l7hykFIlQPn5IH4oQgEEir0mTOt/JLaoeQt2N2gia824W3td4A X/Gys7GNJLeobr2Cbb32jlY9R7rv9v0j+dEbu3kYibRkT2bmgU+InCPE2j/VedBlsDZl reOENuqcG2WrDOmDdps54XaFhdcz8/3AtkocVXN809NAUDqccY015PVD8G5moEbhnwig GIiM2exzh78h6UcCOvGr1nFyuKmDzKiuy7egKkP1uUUCqFDwIz3z7/FsYrawZPh1JLv6 vFXA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1743474603; x=1744079403; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=JOUHkYETfeYPlrfgUGhvuwroRGucs+Rm6+GwIDzHnL8=; b=MoKv4j8487UKe+O4oyqbsm7JtqxcLvMQp4D1WXujwORfZWlcx2AuRpzCmiSdZZaMQ8 +5QGwfiUFEaxuq54vY+QNtlDPAd+AGxc/cCBglwYCPG62bijfE1Rl9hNdhH/w0I/7TTo max9qwmnnmYPnI6BuStJ3v21ycKyazTf6k/02c2iF9nlNEVXZdq4cDY4IE4jDU0wUBlg XqQL/nBq2EyeryvIdiSF/K+eUcULXlM1AWdVM0NsTgHFYXXXChz/gnNv7SpryOQ8kyxF pFZ2Kf6tEXZCAp7CwA+gNdz+GUjOLYXZbRg4v4uWU6IWxaJ+49vhiaBNWxJuoG5yIMW1 3kYg== X-Forwarded-Encrypted: i=1; AJvYcCV6yyo+zQ9SZ/GCN0A9fae09b3d3BL8LJ51/a80ZFpfnNUl3FqYTuLmKlYjGUnC3lRxJLrMidrQ0eoFLHE=@vger.kernel.org, AJvYcCWdwJZauJjFZyVQleqquTBUXXCrSE5BGuxm3mALbPt2q+ockcJ2Z9Bt6w7Xo5/C3ja9e4aT35u2@vger.kernel.org, AJvYcCWi93OsH3BHn4va5tYo1HZ0MRsyj7+rf322zZvl7DVUH7KrVGrCA7Y0IOmgk92buZ0HGwM38OONsR4bk54ZQw==@vger.kernel.org X-Gm-Message-State: AOJu0YzbUEM4qfUzPb4LcDuaczMe9F56KBCGZ/ffHSgw1Ei0X29xnDTJ hzi4fNgeQdoaxV0d6xG9ufnuzSiFJ6ptBH31zerEJQuHx7RD0yJH X-Gm-Gg: ASbGnct9dqNHh+YNDYXG/Rsgipu7DxRik67P4RZvqwxOM4Cc7uQDLV9e3j/FKbl0/Oj 4Ab9sJXUM70YqGX5XcKubLjX61xEu5C2a8/A9LSVjiRFoz7jAhq8MSJwdFBqfgyTpB1Ae4FSIkj nRUyN5tv8opIzkwCmJj1V3xxdxVJg8saGVq9R6ckwU67JOfgYrUnOVKAR7DdyfRDZ9eAV6vyhuV Md6kPVQ9m1454iaIumO9rkabQP/C/JbHq4t5g2wLU8LFqn8jReTsnXzjF18Ft6p26xW2pbGJheE IKM00TBi48dpj5nl7p/XjAgfeeFpZAOFrQkwcdQzSabEdd9sskM3CwfnA0cXDAGb X-Google-Smtp-Source: AGHT+IEB0G2OAa0GElWwPece4cn1mGoI/Q9XaFxX+v953Ea03pxcHznVory5eAjLwxHMOkYTehrrXA== X-Received: by 2002:a17:90b:33cb:b0:2ee:d024:e4fc with SMTP id 98e67ed59e1d1-3053215c6ccmr19674215a91.33.1743474602963; Mon, 31 Mar 2025 19:30:02 -0700 (PDT) Received: from deb-101020-bm01.dtc.local ([149.97.161.244]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-305170e1b9esm8032843a91.36.2025.03.31.19.30.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 31 Mar 2025 19:30:02 -0700 (PDT) From: Swarna Prabhu X-Google-Original-From: Swarna Prabhu To: patches@lists.linux.dev, fstests@vger.kernel.org, linux-mm@kvack.org Cc: linux-btrfs@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-block@vger.kernel.org, xiang@kernel.org, david@redhat.com, huang.ying.caritas@gmail.com, willy@infradead.org, jack@suse.cz, mcgrof@kernel.org, p.raghav@samsung.com, da.gomez@samsung.com, dave@stgolabs.net, gost.dev@samsung.com, Swarna Prabhu Subject: [PATCH] generic/750 : add missing _fixed_by_git_commit line to the test Date: Tue, 1 Apr 2025 02:29:21 +0000 Message-ID: <20250401022921.983259-1-s.prabhu@samsung.com> X-Mailer: git-send-email 2.47.2 Precedence: bulk X-Mailing-List: linux-fsdevel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Testing generic/750 with older kernels indicated that more work has to be done, since we were able to reproduce a hang with v6.10-rc7 with 2.5 hours soak duration. We tried to reproduce the same issue on v6.12 and could no longer reproduce the original hang. This motivated us to identify the commit 2e6506e1c4ee ("mm/migrate: fix deadlock in migrate_pages_batch() on large folios") that fixes the originally reported deadlock hang annotated as pending work to evaluate on generic/750. Hence if you are using kernel older than v6.11-rc4 this commit is needed. Below is the kernel trace collected on v6.10-rc7 without the above commit and CONFGI_PROVE_LOCKING enabled: [ 8942.920967] ret_from_fork_asm+0x1a/0x30 [ 8942.921450] [ 8942.921711] INFO: task 750:2532 blocked for more than 241 seconds. [ 8942.922413] Not tainted 6.10.0-rc7 #9 [ 8942.922894] "echo 0 > /proc/sys/kernel/hung_task_timeout_secs" disables this message. [ 8942.923770] task:750 state:D stack:0 pid:2532 tgid:2532 ppid:2349 flags:0x00004002 [ 8942.924820] Call Trace: [ 8942.925109] [ 8942.925362] __schedule+0x465/0xe10 [ 8942.925756] schedule+0x39/0x140 [ 8942.926114] io_schedule+0x42/0x70 [ 8942.926493] folio_wait_bit_common+0x10e/0x330 [ 8942.926986] ? __pfx_wake_page_function+0x10/0x10 [ 8942.927506] migrate_pages_batch+0x765/0xeb0 [ 8942.927986] ? __pfx_compaction_alloc+0x10/0x10 [ 8942.928488] ? __pfx_compaction_free+0x10/0x10 [ 8942.928983] migrate_pages+0xbfd/0xf50 [ 8942.929377] ? __pfx_compaction_alloc+0x10/0x10 [ 8942.929838] ? __pfx_compaction_free+0x10/0x10 [ 8942.930553] compact_zone+0xa4d/0x11d0 [ 8942.930936] ? rcu_is_watching+0xd/0x40 [ 8942.931332] compact_node+0xa9/0x120 [ 8942.931704] sysctl_compaction_handler+0x71/0xd0 [ 8942.932177] proc_sys_call_handler+0x1b8/0x2d0 [ 8942.932641] vfs_write+0x281/0x530 [ 8942.932993] ksys_write+0x67/0xf0 [ 8942.933381] do_syscall_64+0x69/0x140 [ 8942.933822] entry_SYSCALL_64_after_hwframe+0x76/0x7e [ 8942.934415] RIP: 0033:0x7f8a460215c7 [ 8942.934843] RSP: 002b:00007fff75cf7bb0 EFLAGS: 00000202 ORIG_RAX: 0000000000000001 [ 8942.935720] RAX: ffffffffffffffda RBX: 00007f8a45f8f740 RCX: 00007f8a460215c7 [ 8942.936550] RDX: 0000000000000002 RSI: 000055e89e3a7790 RDI: 0000000000000001 [ 8942.937405] RBP: 000055e89e3a7790 R08: 0000000000000000 R09: 0000000000000000 [ 8942.938236] R10: 0000000000000000 R11: 0000000000000202 R12: 0000000000000002 [ 8942.939068] R13: 00007f8a4617a5c0 R14: 00007f8a46177e80 R15: 0000000000000000 [ 8942.939902] [ 8942.940169] Future hung task reports are suppressed, see sysctl kernel.hung_task_warnings [ 8942.941150] INFO: lockdep is turned off. With the commit cherry picked to v6.10-rc7 , the test passes successfully without any hang/deadlock, however with CONFIG_PROVE_LOCKING enabled we do see the below trace for the passing case: BUG: MAX_LOCKDEP_CHAIN_HLOCKS too low! turning off the locking correctness validator. CPU: 1 PID: 2959 Comm: kworker/u34:5 Not tainted 6.10.0-rc7+ #12 Hardware name: QEMU Standard PC (Q35 + ICH9, 2009), BIOS 2024.11-5 01/28/2025 Workqueue: btrfs-endio-write btrfs_work_helper [btrfs] Call Trace: dump_stack_lvl+0x68/0x90 __lock_acquire.cold+0x186/0x1b1 lock_acquire+0xd6/0x2e0 ? btrfs_get_alloc_profile+0x27/0x90 [btrfs] seqcount_lockdep_reader_access+0x70/0x90 [btrfs] ? btrfs_get_alloc_profile+0x27/0x90 [btrfs] btrfs_get_alloc_profile+0x27/0x90 [btrfs] btrfs_reserve_extent+0xa9/0x290 [btrfs] btrfs_alloc_tree_block+0xa5/0x520 [btrfs] ? lockdep_unlock+0x5e/0xd0 ? __lock_acquire+0xc6f/0x1fa0 btrfs_force_cow_block+0x111/0x5f0 [btrfs] btrfs_cow_block+0xcc/0x2d0 [btrfs] btrfs_search_slot+0x502/0xd00 [btrfs] ? stack_depot_save_flags+0x24/0x8a0 btrfs_lookup_file_extent+0x48/0x70 [btrfs] btrfs_drop_extents+0x108/0xce0 [btrfs] ? _raw_spin_unlock_irqrestore+0x35/0x60 ? __create_object+0x5e/0x90 ? rcu_is_watching+0xd/0x40 ? kmem_cache_alloc_noprof+0x280/0x320 insert_reserved_file_extent+0xea/0x3a0 [btrfs] ? btrfs_init_block_rsv+0x51/0x60 [btrfs] btrfs_finish_one_ordered+0x3ea/0x840 [btrfs] btrfs_work_helper+0x103/0x4b0 [btrfs] ? lock_release+0x177/0x2e0 process_one_work+0x21a/0x590 ? lock_is_held_type+0xd5/0x130 worker_thread+0x1bf/0x3c0 ? __pfx_worker_thread+0x10/0x10 kthread+0xdd/0x110 ? __pfx_kthread+0x10/0x10 ret_from_fork+0x2d/0x50 ? __pfx_kthread+0x10/0x10 ret_from_fork_asm+0x1a/0x30 Started fstests-check.scope - [systemd-run] /usr/bin/bash -c "exit 77". fstests-check.scope: Deactivated successfully. Signed-off-by: Swarna Prabhu Reviewed-by: Luis Chamberlain --- tests/generic/750 | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/tests/generic/750 b/tests/generic/750 index a0828b50..abce6a59 100755 --- a/tests/generic/750 +++ b/tests/generic/750 @@ -26,11 +26,13 @@ _cleanup() _require_scratch _require_vm_compaction -# We still deadlock with this test on v6.10-rc2, we need more work. -# but the below makes things better. _fixed_by_git_commit kernel d99e3140a4d3 \ "mm: turn folio_test_hugetlb into a PageType" +#merged on v6.11-rc4 +_fixed_by_git_commit kernel 2e6506e1c4ee \ + "mm/migrate: fix deadlock in migrate_pages_batch() on large folios" + echo "Silence is golden" _scratch_mkfs > $seqres.full 2>&1