From patchwork Fri Apr 4 09:16:51 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ryosuke Yasuoka X-Patchwork-Id: 14038238 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id CE8DEC369A1 for ; Fri, 4 Apr 2025 09:17:43 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 11F8E10EB90; Fri, 4 Apr 2025 09:17:43 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.b="fGG3cCsh"; dkim-atps=neutral Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by gabe.freedesktop.org (Postfix) with ESMTPS id 71E2110EB90 for ; Fri, 4 Apr 2025 09:17:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1743758257; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=jdt0UC5Y+YSICWNN9M7UpOd4+QGCXUQrqY/ZjKnsARY=; b=fGG3cCshquFG0rzvVS2cee7KpdoMZoiFjj+f99QP0QBqdAp0j7jXqAwBjuDyIToyFqf+tp 69jbjvsgbDPYUvvYizgSnOydf08fWT5fHkOTaQak0tr062U5koXmlBNMyYUwchmmgO0FN3 FKsTABKn6V0FYkYt+jgmamVZpOizUxM= Received: from mail-pf1-f200.google.com (mail-pf1-f200.google.com [209.85.210.200]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-149-Uu_-bt8oMl-kCjvgJ-91HQ-1; Fri, 04 Apr 2025 05:17:36 -0400 X-MC-Unique: Uu_-bt8oMl-kCjvgJ-91HQ-1 X-Mimecast-MFC-AGG-ID: Uu_-bt8oMl-kCjvgJ-91HQ_1743758255 Received: by mail-pf1-f200.google.com with SMTP id d2e1a72fcca58-736c1ea954fso1099874b3a.3 for ; Fri, 04 Apr 2025 02:17:36 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1743758255; x=1744363055; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=jdt0UC5Y+YSICWNN9M7UpOd4+QGCXUQrqY/ZjKnsARY=; b=Rm7RM8ulsOF8kHbDMtW62msGY+g7dvutcazgCK4GjP/pisF4N/HRMbthkxT6cbon9F 1hHl6g2Wed9wrD3g9CGvk2Nl3ri3eZ5QcXrEhJoeMxo1oLinBB0PRxbxDCUNoy/vZFQt aj/+8fwBNB7A0b7grKCesoHuX8tFz6Mip2+IQgIHLVVCtyyu3D5YlIuY75bCGZM3Yg3R Yg0uixma05gmyfuWho14gOHKo6tfYs3mb/fHddtwUvwb9O4sUSC+GebGO7MS838ogMn5 ABx0+/7WRIKbyrSu/WwGGXrAz3EKBAv7CE4HL+5NSr40i2tGILXCM2RTeBsnc6hpzWZI QhHg== X-Forwarded-Encrypted: i=1; AJvYcCWoh483N9gpY+UA07+U/L0uMofbJBVGrF2FpbFOIYP13xe1EIttcX/VkRrZUBhUqMf2yUKH0mSCPPc=@lists.freedesktop.org X-Gm-Message-State: AOJu0YwAwtjgw8F8oHHpb/FO0u4gfNz3XlK5VVUOAwXLrup75PBcryrg ouzBrr2T2oxeavb0xljanYrwYIvPrmAu2UyWY2Vz7ep9VNc+/yzL61G687ODSczP9LZaGcrQLWT zgYlI0H7jjYdvpvBbTmUefTNrvjEdyQezCtKf7CRN675ijLsPom3mu4guvphxndAZqA== X-Gm-Gg: ASbGncsP4SgH6nWzqCSfc8LtFTKvPQimMKTd0gEuU5S9zSCd/xgDo1VJ8269kQFuHnE /+BSyVNH8G/RgGZ38IN/nR89BH9dzaSi1ahIcN+8QjjfAbxJxaZHD2ItvR/bzG9tgmjmN9Qt3kl yg8e3736dsN092v+3rP1avYktRw8X06+V1LqxUJg1G8fQpu/dHt8vO3852QdTlfj4VJmBuCmDSp XbVbB5aHwGsFxFXz26i6c4KhQhZCqXrrRvNAFs1m3vzRBsMfIBx4ZDaoDAdt0kiSQ1znXiuP+QF QMwVdh+rr5+ESaQy X-Received: by 2002:a05:6a20:2d14:b0:1f5:55b7:1bb4 with SMTP id adf61e73a8af0-201045a6c2dmr4306809637.11.1743758255242; Fri, 04 Apr 2025 02:17:35 -0700 (PDT) X-Google-Smtp-Source: AGHT+IG4cF4AJ9IrgwOr6kkgUgDT+AZY2Wj7fW+I4Ga378jGkThhOH+aHldzacKBbkECHVRoyItLUQ== X-Received: by 2002:a05:6a20:2d14:b0:1f5:55b7:1bb4 with SMTP id adf61e73a8af0-201045a6c2dmr4306786637.11.1743758254905; Fri, 04 Apr 2025 02:17:34 -0700 (PDT) Received: from zeus.elecom ([240b:10:83a2:bd00:6e35:f2f5:2e21:ae3a]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-af9bc3fd411sm2432493a12.52.2025.04.04.02.17.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 04 Apr 2025 02:17:34 -0700 (PDT) From: Ryosuke Yasuoka To: airlied@redhat.com, kraxel@redhat.com, maarten.lankhorst@linux.intel.com, mripard@kernel.org, tzimmermann@suse.de, airlied@gmail.com, simona@ffwll.ch Cc: Ryosuke Yasuoka , virtualization@lists.linux.dev, spice-devel@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Subject: [PATCH] drm/qxl: Remove unused argument from qxl_alloc_release_reserved Date: Fri, 4 Apr 2025 18:16:51 +0900 Message-ID: <20250404091654.1664838-1-ryasuoka@redhat.com> X-Mailer: git-send-email 2.48.1 MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: N98QbIk-asiWp8QmSEJeOn5b0I5CR-CQSe0c-gsU6mI_1743758255 X-Mimecast-Originator: redhat.com content-type: text/plain; charset="US-ASCII"; x-default=true X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" The `size` argument in the `qxl_alloc_release_reserved` function is currently unused and has no effect on the function's logic. So remove this argument to clean up the code. No functional changes are expected. Signed-off-by: Ryosuke Yasuoka --- drivers/gpu/drm/qxl/qxl_display.c | 9 +++------ drivers/gpu/drm/qxl/qxl_draw.c | 3 +-- drivers/gpu/drm/qxl/qxl_drv.h | 5 ++--- drivers/gpu/drm/qxl/qxl_ioctl.c | 7 +------ drivers/gpu/drm/qxl/qxl_release.c | 8 +++----- 5 files changed, 10 insertions(+), 22 deletions(-) base-commit: e48e99b6edf41c69c5528aa7ffb2daf3c59ee105 diff --git a/drivers/gpu/drm/qxl/qxl_display.c b/drivers/gpu/drm/qxl/qxl_display.c index 70aff64ced87..c0c65efbfa32 100644 --- a/drivers/gpu/drm/qxl/qxl_display.c +++ b/drivers/gpu/drm/qxl/qxl_display.c @@ -496,8 +496,7 @@ static int qxl_primary_apply_cursor(struct qxl_device *qdev, if (!qcrtc->cursor_bo) return 0; - ret = qxl_alloc_release_reserved(qdev, sizeof(*cmd), - QXL_RELEASE_CURSOR_CMD, + ret = qxl_alloc_release_reserved(qdev, QXL_RELEASE_CURSOR_CMD, &release, NULL); if (ret) return ret; @@ -541,8 +540,7 @@ static int qxl_primary_move_cursor(struct qxl_device *qdev, if (!qcrtc->cursor_bo) return 0; - ret = qxl_alloc_release_reserved(qdev, sizeof(*cmd), - QXL_RELEASE_CURSOR_CMD, + ret = qxl_alloc_release_reserved(qdev, QXL_RELEASE_CURSOR_CMD, &release, NULL); if (ret) return ret; @@ -714,8 +712,7 @@ static void qxl_cursor_atomic_disable(struct drm_plane *plane, struct qxl_cursor_cmd *cmd; int ret; - ret = qxl_alloc_release_reserved(qdev, sizeof(*cmd), - QXL_RELEASE_CURSOR_CMD, + ret = qxl_alloc_release_reserved(qdev, QXL_RELEASE_CURSOR_CMD, &release, NULL); if (ret) return; diff --git a/drivers/gpu/drm/qxl/qxl_draw.c b/drivers/gpu/drm/qxl/qxl_draw.c index 3a3e127ce297..b4c41545fb06 100644 --- a/drivers/gpu/drm/qxl/qxl_draw.c +++ b/drivers/gpu/drm/qxl/qxl_draw.c @@ -64,8 +64,7 @@ static struct qxl_rect *drawable_set_clipping(struct qxl_device *qdev, static int alloc_drawable(struct qxl_device *qdev, struct qxl_release **release) { - return qxl_alloc_release_reserved(qdev, sizeof(struct qxl_drawable), - QXL_RELEASE_DRAWABLE, release, NULL); + return qxl_alloc_release_reserved(qdev, QXL_RELEASE_DRAWABLE, release, NULL); } static void diff --git a/drivers/gpu/drm/qxl/qxl_drv.h b/drivers/gpu/drm/qxl/qxl_drv.h index cc02b5f10ad9..fbc15338ae3c 100644 --- a/drivers/gpu/drm/qxl/qxl_drv.h +++ b/drivers/gpu/drm/qxl/qxl_drv.h @@ -372,9 +372,8 @@ int qxl_alloc_surface_release_reserved(struct qxl_device *qdev, enum qxl_surface_cmd_type surface_cmd_type, struct qxl_release *create_rel, struct qxl_release **release); -int qxl_alloc_release_reserved(struct qxl_device *qdev, unsigned long size, - int type, struct qxl_release **release, - struct qxl_bo **rbo); +int qxl_alloc_release_reserved(struct qxl_device *qdev, int type, + struct qxl_release **release, struct qxl_bo **rbo); int qxl_push_command_ring_release(struct qxl_device *qdev, struct qxl_release *release, diff --git a/drivers/gpu/drm/qxl/qxl_ioctl.c b/drivers/gpu/drm/qxl/qxl_ioctl.c index 506ae1f5e099..5e0321b6f319 100644 --- a/drivers/gpu/drm/qxl/qxl_ioctl.c +++ b/drivers/gpu/drm/qxl/qxl_ioctl.c @@ -171,12 +171,7 @@ static int qxl_process_single_command(struct qxl_device *qdev, if (!reloc_info) return -ENOMEM; - ret = qxl_alloc_release_reserved(qdev, - sizeof(union qxl_release_info) + - cmd->command_size, - release_type, - &release, - &cmd_bo); + ret = qxl_alloc_release_reserved(qdev, release_type, &release, &cmd_bo); if (ret) goto out_free_reloc; diff --git a/drivers/gpu/drm/qxl/qxl_release.c b/drivers/gpu/drm/qxl/qxl_release.c index 05204a6a3fa8..52c444a482be 100644 --- a/drivers/gpu/drm/qxl/qxl_release.c +++ b/drivers/gpu/drm/qxl/qxl_release.c @@ -279,13 +279,11 @@ int qxl_alloc_surface_release_reserved(struct qxl_device *qdev, return 0; } - return qxl_alloc_release_reserved(qdev, sizeof(struct qxl_surface_cmd), - QXL_RELEASE_SURFACE_CMD, release, NULL); + return qxl_alloc_release_reserved(qdev, QXL_RELEASE_SURFACE_CMD, release, NULL); } -int qxl_alloc_release_reserved(struct qxl_device *qdev, unsigned long size, - int type, struct qxl_release **release, - struct qxl_bo **rbo) +int qxl_alloc_release_reserved(struct qxl_device *qdev, int type, + struct qxl_release **release, struct qxl_bo **rbo) { struct qxl_bo *bo, *free_bo = NULL; int idr_ret;