From patchwork Mon Apr 7 07:09:18 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bartosz Golaszewski X-Patchwork-Id: 14039809 Received: from mail-wm1-f51.google.com (mail-wm1-f51.google.com [209.85.128.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AD9A82248AA for ; Mon, 7 Apr 2025 07:09:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.51 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744009769; cv=none; b=ceP+u8zjIb2ObJGMVbT9Vjhzgq37weAaI1hMMjv1+KrO1dQZ8ylv91gUC1iou7w0mz/AlXHZFoHvTOe4OwtuGTrIRgQcMogJdvBQZSpSH42tzNn7WdxfZCh/oMKCWm64UFL5ief+A7f7/4y/EUVOJSWuZggBjB0dXGMo2A27Cho= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744009769; c=relaxed/simple; bh=QDLHMBZTpiBivDqp5pKtEBIW4NMS9LwrxmbdzYFamjk=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=pVKWAXGVoF7lp1TrjUbO1XlFTFh21c7SG4EqFi6R/ZYyM4MgrO60dbHKyfz91XlhxYzTwKi8fLrrzNwKn2ONyGFBwYcoxBK7iP53jdi2Ql5SQM7zMr0yCuWjHPB3dACKClPs3TPVPQrIbba+HRVQ+541Y3ihbqfExSJC8ZgXR58= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl; spf=none smtp.mailfrom=bgdev.pl; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b=YGaokiYn; arc=none smtp.client-ip=209.85.128.51 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b="YGaokiYn" Received: by mail-wm1-f51.google.com with SMTP id 5b1f17b1804b1-43cebe06e9eso25252695e9.3 for ; Mon, 07 Apr 2025 00:09:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bgdev-pl.20230601.gappssmtp.com; s=20230601; t=1744009766; x=1744614566; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=1oJEkpaKzk7KM5O+yA10t99Sq6/Y0ezDYdwYB3ESkdY=; b=YGaokiYnQNNRQaZous63gK6mZCrRiczGNpihvLSBeSeP276SOW8ULpL9P3+y1e83PQ vwd6pbL46AIUdkZSKmeyopjHsfOiok91z/HYST40UwZ6/4ZjdmI9ncffITh2c4AYSgWa 1baBq00Yhd3elKt+6JJAdXIpPJ6HsHTIdbN0r4ivdWKF5Rw5Y9RjFgt4DCyEsep/eDVc kc5zZXxE9XQQ5kuZh6b+TpYpJxkHDAsepFDhUFrTn1b84GBBfUqLCSLHSS2d0jTd7zPW 923EgzBHZwuuuCmOjqP7T7Bbb715CwvYklSMMzFq1XvD3up91Y4MQjCk2eF5zkVZ1p7h xytg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1744009766; x=1744614566; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=1oJEkpaKzk7KM5O+yA10t99Sq6/Y0ezDYdwYB3ESkdY=; b=aU5abinXdvX7DZE8ecKfqnWWQY14+3HYMxBNDfLcM+aH8KplNdvdJJGPUQWZUSD8xH FlghxzNb20aNJRs0ICN87Ej9OG9ibKU1cwTWMdfu6ATFsvqYv0VLjTWRrryC0TbAZfam 1m/3FN/J/NppFxD6vTtoIj3nbX4Il9c43nE4UD8FGIIusGZPEOAO+zpqCfh9IvAivK1m NfRCICPrtjPc3JgHspj+p5MwLGIshf7HZtru6dtsBrJ/0Xb8DcfwoIDr+YjLzyMoRghn kFbzgQAGKX+z0ecP6HfeVDCD3pTKWa4W0Hz3pHfHyXzr8c+prwEimiQvqJoU8dNYGO8h huoQ== X-Forwarded-Encrypted: i=1; AJvYcCUCFYtselquMcpYxMmhdnHHECZlwUfGalGl9vN/5BwfiVRzCmvePsglaR87nzDZJ4NG1K3CLHUYREs2o597K4LP/A==@vger.kernel.org X-Gm-Message-State: AOJu0YyeJ93RZcy2aIaj0flfoLTsZCjzulR7nrVg05o6xf1AcHP6BWoE OVUHplEpdX/nqolb9P95DrM2ZaqFSXPNKVEif1U18tPpLr//XvZ9LRcxLEZRnYk= X-Gm-Gg: ASbGnctwZZDiW/jdIAsbpCG7kGD/5gy7nv7GTWofMCMr23h7pFKaQk0WQ35Stp0CJwm yKRx72StkQfdsY4fGQ4JoerBa22g6zSLeGLXmQX4qZqT23qJtze6LVYRXEM9dlyMZtdpFcuU0zG gmfMvsi1b2PenIeJDPuzX9UKGOrRTTW5lTH7VmdseXvnJIhwA5v4p6RrmU7AuO0eoEXzu2h5iRF dhZWZZYtQTEXgxdmnY5c3IClljci3I+TGYNA0yQzfW8K22vfnrUKvEPm8QYO+6U+JK2nrfBgt93 a6BwEZ+gbzdwH2ij7X4/V+BEkorUMXDYSCAM6E/YskTo12gV X-Google-Smtp-Source: AGHT+IGFE6oyFiQ9CpLcLlV+haks6tvvNCLBB+aF4dXus3yMP1Llx4O8MohrwYM8rVwVT69R0foFDA== X-Received: by 2002:a05:600c:8719:b0:43c:f85d:1245 with SMTP id 5b1f17b1804b1-43ecf8e7321mr124503985e9.17.1744009766064; Mon, 07 Apr 2025 00:09:26 -0700 (PDT) Received: from [127.0.1.1] ([2a01:cb1d:dc:7e00:8c64:734d:705a:39a7]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-43ec1663060sm124622795e9.14.2025.04.07.00.09.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 07 Apr 2025 00:09:25 -0700 (PDT) From: Bartosz Golaszewski Date: Mon, 07 Apr 2025 09:09:18 +0200 Subject: [PATCH 1/4] ARM: orion/gpio: use new line value setter callbacks Precedence: bulk X-Mailing-List: linux-samsung-soc@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-Id: <20250407-gpiochip-set-rv-arm-v1-1-9e4a914c7fd4@linaro.org> References: <20250407-gpiochip-set-rv-arm-v1-0-9e4a914c7fd4@linaro.org> In-Reply-To: <20250407-gpiochip-set-rv-arm-v1-0-9e4a914c7fd4@linaro.org> To: Andrew Lunn , Sebastian Hesselbarth , Gregory Clement , Russell King , Linus Walleij , Bartosz Golaszewski , Krzysztof Kozlowski , Alim Akhtar Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org, linux-samsung-soc@vger.kernel.org, Bartosz Golaszewski X-Mailer: b4 0.14.1 X-Developer-Signature: v=1; a=openpgp-sha256; l=1612; i=bartosz.golaszewski@linaro.org; h=from:subject:message-id; bh=6854LsY/CEKL9LDW7nLKKhBRDGj/vD8F0/gksPec/Gs=; b=owEBbQKS/ZANAwAKARGnLqAUcddyAcsmYgBn83ojv0NTNspg6Wx5Fggczg/6It7m8U2gT0lPo rxrHkr6h86JAjMEAAEKAB0WIQQWnetsC8PEYBPSx58Rpy6gFHHXcgUCZ/N6IwAKCRARpy6gFHHX chutD/0cndTpas2Wdg5qBWP1Y3VKSiVXC6hIuu1om0Dd6+1pvJPesqjLF2JFC6zXuYLNkg0+5Jg rGlvPXMOI1t9FgiAdbgKurXOq+HFhT4k2qSnOquBOC/PNHNbPYOOlpJuZidhiPkiCKltu3o92pr K7HivuuUnrD3r2PaQXoLjhIhZ+jnddu7iDYZQQYgSjAF2FXJVs/TOgQY+fnL2rRRAXZ4kfA/ll7 6dbIgHm1IM735m+b5kQW+9UuDG14bt/y9uWTJbvgK+xvtRhl5k9jyTWi/P6P3K93ceJolsL+zdC WUj/jWB0+TrXlKsF57cr4miv9xpRtfcFOM68jyZJYP/8RT/B5CCxCMHxW7L7SpUkcHnwtwhj6p5 Iz9NnHrsLZdZsytg+wpvHk5roaSVuWDVE77oA8uClfW6LB+PcAYTI3kuSkoVRVI7dfSXJWSLVn/ ouOOd1MUVkGTz++pCGaCtcnKe176tnqXb5Wm5MNK93LUMpg2F7KMVNZUW0NBY47bKkYN3Wz9ANJ hLKVuAzR5UxbPRdG3dHLIKEHknx3vm0Ac7/z0V1wh99rz6jMLZWAHXAY+/BJPRpl9jTJQEazQ6e 7nKzWccg6Qhy55gudCDhtyMQvrJPacNqZJ+cdOXjly/IYjPEwBorwqoF/42IPiZqADwOvawnQ1U Ns/4rCW8lnZP6Rw== X-Developer-Key: i=bartosz.golaszewski@linaro.org; a=openpgp; fpr=169DEB6C0BC3C46013D2C79F11A72EA01471D772 From: Bartosz Golaszewski struct gpio_chip now has callbacks for setting line values that return an integer, allowing to indicate failures. Convert the driver to using them. Signed-off-by: Bartosz Golaszewski --- arch/arm/plat-orion/gpio.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/arch/arm/plat-orion/gpio.c b/arch/arm/plat-orion/gpio.c index 595e9cb33c1d..766036fdd792 100644 --- a/arch/arm/plat-orion/gpio.c +++ b/arch/arm/plat-orion/gpio.c @@ -211,7 +211,7 @@ orion_gpio_direction_output(struct gpio_chip *chip, unsigned pin, int value) return 0; } -static void orion_gpio_set(struct gpio_chip *chip, unsigned pin, int value) +static int orion_gpio_set(struct gpio_chip *chip, unsigned int pin, int value) { struct orion_gpio_chip *ochip = gpiochip_get_data(chip); unsigned long flags; @@ -219,6 +219,8 @@ static void orion_gpio_set(struct gpio_chip *chip, unsigned pin, int value) spin_lock_irqsave(&ochip->lock, flags); __set_level(ochip, pin, value); spin_unlock_irqrestore(&ochip->lock, flags); + + return 0; } static int orion_gpio_to_irq(struct gpio_chip *chip, unsigned pin) @@ -540,7 +542,7 @@ void __init orion_gpio_init(int gpio_base, int ngpio, ochip->chip.direction_input = orion_gpio_direction_input; ochip->chip.get = orion_gpio_get; ochip->chip.direction_output = orion_gpio_direction_output; - ochip->chip.set = orion_gpio_set; + ochip->chip.set_rv = orion_gpio_set; ochip->chip.to_irq = orion_gpio_to_irq; ochip->chip.base = gpio_base; ochip->chip.ngpio = ngpio; From patchwork Mon Apr 7 07:09:19 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bartosz Golaszewski X-Patchwork-Id: 14039810 Received: from mail-wm1-f50.google.com (mail-wm1-f50.google.com [209.85.128.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 20710225412 for ; Mon, 7 Apr 2025 07:09:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.50 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744009770; cv=none; b=qCdTm4JQCUTsXE6fln89jjWsXmWiAeyupq1h6FGpmMDY8Mg1kWg4sII3WbH5XqalPk4l8/gqHjGErHYie8EX61vDPqVGCIoB1kXh694aDws8ddSMgVkBRLKuHTIt6md8rEcajEeUAONAuIfrFyWhDUD0hDiLzl29KE+ZW1wI59w= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744009770; c=relaxed/simple; bh=ozAN40jinl+xXLgyl7TwyrqEYX1yW7hYhTChwsJoIiM=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=jLcX5FRmUT/JIl9p7a7oaUnFLpqi9QOwqF2s9w9aRfw/OIzZUfCxx9wggYtMdIkpLKCvL4xBIwKGidCCJz0fbwEl2VgkZt3t6T8xD1iypIThw7g5SEBlbP254L5Dht2/LhjZT3z9w7um95cQnUOycr8D7kei82rYbRZZTFu5c3w= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl; spf=none smtp.mailfrom=bgdev.pl; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b=Zq78gfjk; arc=none smtp.client-ip=209.85.128.50 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b="Zq78gfjk" Received: by mail-wm1-f50.google.com with SMTP id 5b1f17b1804b1-43cfe63c592so38149105e9.2 for ; Mon, 07 Apr 2025 00:09:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bgdev-pl.20230601.gappssmtp.com; s=20230601; t=1744009767; x=1744614567; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=P54VA/QfQ5VWCZa2DrfOM44F5qJ8PR9WzkkmyLvWpKo=; b=Zq78gfjkMdK17dFmwMiWgGWIjk4vEMM/LqKKh8VCfgXh3Uj/K4CGZ07sLe0Qkl2FxD UHUa3lBW2P7H3qph9EHUbpxCJ7Va1l7PgI8WkoqR0DKSTDnE6pf3FiwC373gKP13Stis tCOV7Ux774VYH5a5415qCH1u+zu9D/Omgg1cqCaDBIKWdi+hgQGEFIyOuh864PCg6Bqh dJ83o3QU/hKFjVIvBUrdOvZunHrbDN3aC9hB04ZBVgyalzIgiWGZ4+wGOSMnDmKeCxI8 KT/u5CASQeKFPPj2liovOnloK8xP5rTuxCxGFEkWog03/9JqdiZcIAEO/oHl+2uY36RS ry0A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1744009767; x=1744614567; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=P54VA/QfQ5VWCZa2DrfOM44F5qJ8PR9WzkkmyLvWpKo=; b=KWwP5nojc10G4+xBalz19DKVp/x2ZHq2awYQlrKno3vezMj9JWvTvBbNXU34jnI9rg BcgD8j+rHOujBKMGP9Fhs7c74kg3HwhYBUVwp5mPX3JX7acGAtvJaWFyUsoKyt2DjFB+ aciShTAO/9QFOuAMNdL+vx8cHatUNILW1lbwFY/f12GhqyfZMRG0Cm+GfVCh4yADXSHr ZdIVBhLDLK5PyOPWN1hrh4soor32dG17riCsa9lbJq81FIPCnGJOAyzkkfGLuCgmGm21 zPrHT4XJMGFqfVCtCTvi9ZM6TZgzUicsQXvjANUyFxPLhUSsn+2tFm8fALTE0EQvEu5S oySQ== X-Forwarded-Encrypted: i=1; AJvYcCUnXmPJpGk/tywWduhd3j9GqUK10ivXtDSLOrxGpD8SSBjV74SlHWOA6eXCPRR4/uxF+gRB2vLwtnCaaGOzU/JsRw==@vger.kernel.org X-Gm-Message-State: AOJu0YyE8N5aQgEkxy6IDLmVncHPe3+uqxMG7JKnip5xu0zAXqtEsCNa wD4BU4jz7n6VhypDhVSQV/WEBFDLQ9CTYpzZw+OGDMhfHYMNYMP9IzetGogNtkA= X-Gm-Gg: ASbGncuZXdZ46agoZzp19tMVmdoAbIoagQkj+P8irQFKCWL7vL5CA1c0DYDNRD5YMMu uJF3LVlbO6tPip1nBeyWpZTDnkFLN9Ek1uc9dTdRHECShiH1lVY/PMQPqvSqKQBHsry9J1+MIyW /KNrqFHNuUog5/Z4Sky6DKZttMKjVJ0sPdZU1CRFX/qAzTvADCsloMBG1TEeN0cSFd3PdVqx8ad eDwL4yiAboV9UfoU9/kjI+52Jd1L7h3Q4EHhFI+Y+f7vplJ1REm5BuzyZmNIgB9aV47/XbvIKcX f5OGB3GVz6lOb1eHV0UXb8ksyLh70ieShikVjg== X-Google-Smtp-Source: AGHT+IHlbYVaSeQ4i6pCJ+5QwB6SPB1j4w0/Dq7AFXUieSOfltPppg5yQl42lc4SWdhOL/4TY1MnaQ== X-Received: by 2002:a05:600c:1912:b0:43c:fcbc:9680 with SMTP id 5b1f17b1804b1-43ed0d98e11mr66774425e9.25.1744009767393; Mon, 07 Apr 2025 00:09:27 -0700 (PDT) Received: from [127.0.1.1] ([2a01:cb1d:dc:7e00:8c64:734d:705a:39a7]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-43ec1663060sm124622795e9.14.2025.04.07.00.09.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 07 Apr 2025 00:09:26 -0700 (PDT) From: Bartosz Golaszewski Date: Mon, 07 Apr 2025 09:09:19 +0200 Subject: [PATCH 2/4] ARM: sa1100/gpio: use new line value setter callbacks Precedence: bulk X-Mailing-List: linux-samsung-soc@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-Id: <20250407-gpiochip-set-rv-arm-v1-2-9e4a914c7fd4@linaro.org> References: <20250407-gpiochip-set-rv-arm-v1-0-9e4a914c7fd4@linaro.org> In-Reply-To: <20250407-gpiochip-set-rv-arm-v1-0-9e4a914c7fd4@linaro.org> To: Andrew Lunn , Sebastian Hesselbarth , Gregory Clement , Russell King , Linus Walleij , Bartosz Golaszewski , Krzysztof Kozlowski , Alim Akhtar Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org, linux-samsung-soc@vger.kernel.org, Bartosz Golaszewski X-Mailer: b4 0.14.1 X-Developer-Signature: v=1; a=openpgp-sha256; l=1726; i=bartosz.golaszewski@linaro.org; h=from:subject:message-id; bh=xsWx6NHlIxnhL6jtmZVFoxqhJ5i8IDr9WwAEXelZLcc=; b=owEBbQKS/ZANAwAKARGnLqAUcddyAcsmYgBn83ojCLYV8dzwcSNLnX4bkKX+gH1+RDkz/zjfu UvxHKlCXuyJAjMEAAEKAB0WIQQWnetsC8PEYBPSx58Rpy6gFHHXcgUCZ/N6IwAKCRARpy6gFHHX chMGD/9WaglQntxBb+rFUYx9pTpsQhM2cuIhUhgxNCX/UTl/3szgAcD06UaZbzpECecUIUvcZcf xHvg9m/8zUqjvoulvOdHUUhu1M/64mJr08Mc59L7LYUNUP5DJgPZnDIFvclIIyXxgl2/R2TD2gb W1iJTaMePwcZgWSB00BZBRYxN/q8f/2O6XISU6cNUdJ0zYvgkW9M9tZhSzGQ65VB2MsoracdfiO Isfwpu60HyoH7bKqnCU3/NT3fn472ynWuWAOAKCLl5g5Bkv810i9mWpnLDn+db8t6hU86JhbldJ l/BNF2J2U4O74bHUDEVQwSDyvbHN1YOYCsTfOLgvQmlU7umqx+iCfPGsaqpp52oYItloneBpuWv HKWWkhv2YftZY44ytOEUa0y1HknhvANP18iKzjY+k4ZouGO45TXtsRrtHsYDOLk+c/DhqwwOmPF aDX2XQ3DsiwI6Jx3zvTNp5vT4FYSEwoSroABjT7ADXDkrS0mfbIwAAPYt60KWKhIQgj3OWAXJuM 0a7oF0P4c5rvq5KFVG9hl6GsbYufNkx6PVx+uslfrKQBjHZuV0EL7wCO8V6y10cEZBBeeUTTK+n kGGs5+XXX1fhdeD5Y3suIaahWADJWI5MkDd+0OajiUpvCEENwVBvEsmdNIW0nm3nk7OTSTKfVTD wjA0QNCPuSn2sHA== X-Developer-Key: i=bartosz.golaszewski@linaro.org; a=openpgp; fpr=169DEB6C0BC3C46013D2C79F11A72EA01471D772 From: Bartosz Golaszewski struct gpio_chip now has callbacks for setting line values that return an integer, allowing to indicate failures. Convert the driver to using them. Signed-off-by: Bartosz Golaszewski --- arch/arm/common/sa1111.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/arch/arm/common/sa1111.c b/arch/arm/common/sa1111.c index 9846f30990f7..70dca9937644 100644 --- a/arch/arm/common/sa1111.c +++ b/arch/arm/common/sa1111.c @@ -563,7 +563,7 @@ static int sa1111_gpio_get(struct gpio_chip *gc, unsigned offset) return !!(readl_relaxed(reg + SA1111_GPIO_PXDRR) & mask); } -static void sa1111_gpio_set(struct gpio_chip *gc, unsigned offset, int value) +static int sa1111_gpio_set(struct gpio_chip *gc, unsigned int offset, int value) { struct sa1111 *sachip = gc_to_sa1111(gc); unsigned long flags; @@ -574,6 +574,8 @@ static void sa1111_gpio_set(struct gpio_chip *gc, unsigned offset, int value) sa1111_gpio_modify(reg + SA1111_GPIO_PXDWR, mask, value ? mask : 0); sa1111_gpio_modify(reg + SA1111_GPIO_PXSSR, mask, value ? mask : 0); spin_unlock_irqrestore(&sachip->lock, flags); + + return 0; } static void sa1111_gpio_set_multiple(struct gpio_chip *gc, unsigned long *mask, @@ -613,7 +615,7 @@ static int sa1111_setup_gpios(struct sa1111 *sachip) sachip->gc.direction_input = sa1111_gpio_direction_input; sachip->gc.direction_output = sa1111_gpio_direction_output; sachip->gc.get = sa1111_gpio_get; - sachip->gc.set = sa1111_gpio_set; + sachip->gc.set_rv = sa1111_gpio_set; sachip->gc.set_multiple = sa1111_gpio_set_multiple; sachip->gc.to_irq = sa1111_gpio_to_irq; sachip->gc.base = -1; From patchwork Mon Apr 7 07:09:20 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bartosz Golaszewski X-Patchwork-Id: 14039811 Received: from mail-wr1-f52.google.com (mail-wr1-f52.google.com [209.85.221.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1AE4B225403 for ; Mon, 7 Apr 2025 07:09:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.52 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744009772; cv=none; b=UOLKm14plk+V09zebGulw2DtAKb7cKNmqF3Q8ZNQAF02JLvACFAa8lDqSfnulq6ko55YDfZ+t3QLyCBGyNSCE4AzwT9Hytsopnqmde6+q/lcZu1T6StVPy9I4yM6PQ0IcXuRPrWaXcWNDz/hAyHAaHX8dct51AFhPltX6nnoHpY= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744009772; c=relaxed/simple; bh=rI3gM6wyr+LS8B0fWYZHHkyFOI/0ZbvX5npXKPrWiT8=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=IWZgXu3+eGXPOa237jOMT91RtnZCIaA2FNeQFc5zZRX37RFZCfOqYgQQ1Df4XjJKDKQs02PtzZmcLuLYymA+CgtLhypYTN/BeovbZqLgQLiTT0fX+O14Ii0HQZX2NcksLrbJL1AkWZVU/NP73+a+pzhEQxKtbR2BeDTnwcz0QYI= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl; spf=none smtp.mailfrom=bgdev.pl; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b=KHgeipwt; arc=none smtp.client-ip=209.85.221.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b="KHgeipwt" Received: by mail-wr1-f52.google.com with SMTP id ffacd0b85a97d-39c1efbefc6so2168795f8f.1 for ; Mon, 07 Apr 2025 00:09:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bgdev-pl.20230601.gappssmtp.com; s=20230601; t=1744009768; x=1744614568; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=mKHBQhlPmU3j6804TJoiY+lijz2sviuHoc3u/Cr+n0I=; b=KHgeipwtVFv3mYwiYWPvfhiHqpBJmAGyZfKFvXY8oZkzOgMy/QO2HRRh1+K18Qcfc5 xdcoa1i4hh5T891v7nCR3UpuFpBuV0Y89WtlwTKBnL4XS+kkDE+BISts2656qHUN+kaS NHG+AAYXRyz/iLZ0EYtZbggOUdLNOfpyS2r9obCIGRnPa45IkwFLu2ej+wtMzu3Bu2Cd OzAJYNvP0ouX1784XnNg8UNuX3kDY2LpiOJvvVQ2H3ImA6yYdiDXmftsMG1m+gLXxWuo IXOzDijckEorrxQ+61Rvs6o59ij1qSc76q6+H5OcXzS5Sl0manicJrTdd4Wi3BtjSLK0 OFjA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1744009768; x=1744614568; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=mKHBQhlPmU3j6804TJoiY+lijz2sviuHoc3u/Cr+n0I=; b=ivLsTosiORDiygbgWxWeTBH0D/S59aP+E0xXUkMPOJPJrITaNAsuQzLnVsI8siqxse QB+7Xe1E/bKRZfwh9Mn0o95YDOzoFlU+OPJX0Db3IZaG+hSPx0W08+CKPU5snPNSdm2e XLXM0Vid3DaxLohYScr9XaBg5iHaD4OwB2NK5kKSFoeCXOJJE83TmFTcxXuGjgIyW/uS /XxavwjdQhm8L3Mg3+1WPZvS38ZzFLjrVpw3t/pPa+QMOHjLD3cpgfyFzA5RHQVylA7a rGei3EVYsN2vNlBlyUG+4yt0UfgeppfB2JVvZ3SAy/ehQVS/ymGOIho4phAf/bSyRPB1 6M6Q== X-Forwarded-Encrypted: i=1; AJvYcCWlAvmZsdKkWIozOWPCQjI2VehfidGVj3Xr043oVMDuEX+sS/jBP6ICi/+nbIExr6yZPCow1HfdWOBsqpUU7Edz3g==@vger.kernel.org X-Gm-Message-State: AOJu0YwVqmp45GpIieJtSpzn2LXLHVp+fdN0HrMSU8RnuI5+yN/Gszs/ nSl33U7VPGaOr4FXZmmk1XjxewbzNz6O1x7GwxWHr27KuMLBJCEfgWK4ViGsr8w= X-Gm-Gg: ASbGncsCHUC+uOwNsbH8yFVxn3tj/WHzLjkkrB2yw3qdT1eQhwu7TLdCc221NFgRpI7 d2pMazVBSZRcTkeMMxRf2DarbGOgqBrk/XzkS+VAzSrNx2MBlikeY2nfxpQpKx7FaENXtCdSjPj bhct+8nX2FBNK3dlVVLChXUaLyOKuXNr8F2S/cpnlY2he17eQbY1LkLNB4m9Fu/uRZMtrPIfQ36 BhatUWLVvClXubpmEVtGJfUNfRl3DEURJ0yCsjF8b1txDdm3iGaVDWnYGiN+XqrIAmidsWsZ2kB lLoMOfIFzE02UNWn3jZy2h4RI16S4EWIGBA1JyKdN2H/uTxn X-Google-Smtp-Source: AGHT+IEOVwEvDvK/VaX877azSHwhGwB+qG3k0uZPl7enDJ5MXPhr/6Jl2r6haw04RdA5keAMOfMCAQ== X-Received: by 2002:a05:6000:440d:b0:399:7f44:5c74 with SMTP id ffacd0b85a97d-39d6fd06920mr4321098f8f.55.1744009768449; Mon, 07 Apr 2025 00:09:28 -0700 (PDT) Received: from [127.0.1.1] ([2a01:cb1d:dc:7e00:8c64:734d:705a:39a7]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-43ec1663060sm124622795e9.14.2025.04.07.00.09.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 07 Apr 2025 00:09:27 -0700 (PDT) From: Bartosz Golaszewski Date: Mon, 07 Apr 2025 09:09:20 +0200 Subject: [PATCH 3/4] ARM: scoop/gpio: use new line value setter callbacks Precedence: bulk X-Mailing-List: linux-samsung-soc@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-Id: <20250407-gpiochip-set-rv-arm-v1-3-9e4a914c7fd4@linaro.org> References: <20250407-gpiochip-set-rv-arm-v1-0-9e4a914c7fd4@linaro.org> In-Reply-To: <20250407-gpiochip-set-rv-arm-v1-0-9e4a914c7fd4@linaro.org> To: Andrew Lunn , Sebastian Hesselbarth , Gregory Clement , Russell King , Linus Walleij , Bartosz Golaszewski , Krzysztof Kozlowski , Alim Akhtar Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org, linux-samsung-soc@vger.kernel.org, Bartosz Golaszewski X-Mailer: b4 0.14.1 X-Developer-Signature: v=1; a=openpgp-sha256; l=1649; i=bartosz.golaszewski@linaro.org; h=from:subject:message-id; bh=ehKRyvYg5rUoJTMfe9/Qu0Sq86m2y/6ATgEJ9xwP4+c=; b=owEBbQKS/ZANAwAKARGnLqAUcddyAcsmYgBn83ok4MKKf0abAA3OAYKfP6+RbRvjSZlJeEPjq onYoqwKNmOJAjMEAAEKAB0WIQQWnetsC8PEYBPSx58Rpy6gFHHXcgUCZ/N6JAAKCRARpy6gFHHX cg+gEACBTJJGVlRuVE35u0vd0TPLco/EUqtFuji2MMq9tgOsFcm+6EyEyHEQWYwVXELmtyi+pgs v47ssFCyjuUpRiTQuoDAiz+kNGhhbedC/Y81QS9HhmIiqRr7+4or1ntC0EF6w5bDaCJ8czd5b1u r+uHTdRr3K0PH7leknEkF03e2e8FaUoC6DfVhGDgiKSNujP+zHMI7CTLP1CCLMw6Vni4z5rnZ+B DTtwtPu/nStaMeYbGVVXdRHMfuzLqGHhT/vURx7RlT8x4ozmQCC+hRgjMeokIALearKmc9fxYGB 6mLjyWbGDqlKg7ewiYLhs4/hVQqxrveH8fwxGUhqb9gu761NA6BXH6uqRGupXN1Yfb9bQBJDv0U 8egk07IK/MjZ3r1pBfvICWR7mPPe+WPaiEIZYJdVU0FZr3n5qbj5Cvx3cxDbMawDkChProIlGKB La8MSZeeryoNdDhNqBCuTQDl5LzdUCQEZgr6a750ft2Lx8NJRckIBa9+xlwydt5/Sed6G5FqBtj mb8BBh21dARgYpr76EntXsciH5RifmwOuKMO8WhVzLwM920GOuBCc0KnVZjgE3BBSRyLZnjsLEj S6Uy6Iibd+lHLM8ACyvhERmG9VK2xhyBVzAKzEjp7D8UMlGaSjXznkrvHdePu3ybRMH4hftvDol VtUkDFktum4jREg== X-Developer-Key: i=bartosz.golaszewski@linaro.org; a=openpgp; fpr=169DEB6C0BC3C46013D2C79F11A72EA01471D772 From: Bartosz Golaszewski struct gpio_chip now has callbacks for setting line values that return an integer, allowing to indicate failures. Convert the driver to using them. Signed-off-by: Bartosz Golaszewski --- arch/arm/common/scoop.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/arch/arm/common/scoop.c b/arch/arm/common/scoop.c index 0b08b6621878..2d3ee76c8e17 100644 --- a/arch/arm/common/scoop.c +++ b/arch/arm/common/scoop.c @@ -63,7 +63,8 @@ static void __scoop_gpio_set(struct scoop_dev *sdev, iowrite16(gpwr, sdev->base + SCOOP_GPWR); } -static void scoop_gpio_set(struct gpio_chip *chip, unsigned offset, int value) +static int scoop_gpio_set(struct gpio_chip *chip, unsigned int offset, + int value) { struct scoop_dev *sdev = gpiochip_get_data(chip); unsigned long flags; @@ -73,6 +74,8 @@ static void scoop_gpio_set(struct gpio_chip *chip, unsigned offset, int value) __scoop_gpio_set(sdev, offset, value); spin_unlock_irqrestore(&sdev->scoop_lock, flags); + + return 0; } static int scoop_gpio_get(struct gpio_chip *chip, unsigned offset) @@ -215,7 +218,7 @@ static int scoop_probe(struct platform_device *pdev) devptr->gpio.label = dev_name(&pdev->dev); devptr->gpio.base = inf->gpio_base; devptr->gpio.ngpio = 12; /* PA11 = 0, PA12 = 1, etc. up to PA22 = 11 */ - devptr->gpio.set = scoop_gpio_set; + devptr->gpio.set_rv = scoop_gpio_set; devptr->gpio.get = scoop_gpio_get; devptr->gpio.direction_input = scoop_gpio_direction_input; devptr->gpio.direction_output = scoop_gpio_direction_output; From patchwork Mon Apr 7 07:09:21 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bartosz Golaszewski X-Patchwork-Id: 14039812 Received: from mail-wm1-f42.google.com (mail-wm1-f42.google.com [209.85.128.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 442BF227BA9 for ; Mon, 7 Apr 2025 07:09:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.42 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744009776; cv=none; b=us52HcKfONhg0G0IDUz6ekklkCljoO7mFkoNwYzPgqqbWFJaedbHXnK26P5/CYpOZJIdfdDdlsvhr36auo0Sd7hRAoLWpys9JMrpbmZXsBP612oPheCH01xAUm+AfJJkQTtdPndZ5gZE+PhapsidzasM717Gid1d616cF+C0/sY= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744009776; c=relaxed/simple; bh=Xs8kT13TgDgVr1qQQSggiPnN5GRLN0/V9PojPokFU8s=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=JT/NQJaAX7BbF9pGLUcLDND2riaajQL6qNSRrDegWIoEsz3REBsxsF+VENSacYnt7NTUxNC1OGnhFrJKps8ubsemcRbjABJUTLzOSOSpJwCVYnsV8+TMW7H0e+gX3bZn1wlrsxRSBilNv87Cc6isRctbq+PclFvz4t+/zr9bYDg= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl; spf=none smtp.mailfrom=bgdev.pl; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b=y9qsAOZE; arc=none smtp.client-ip=209.85.128.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b="y9qsAOZE" Received: by mail-wm1-f42.google.com with SMTP id 5b1f17b1804b1-43ce71582e9so25552705e9.1 for ; Mon, 07 Apr 2025 00:09:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bgdev-pl.20230601.gappssmtp.com; s=20230601; t=1744009772; x=1744614572; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=HsaSC2HaVJRroJP0HwzWYTmvmXosq879cETOeyvqI4E=; b=y9qsAOZE3aXcGVeE+keirS7xSue1e0qBvX6PiZvBhYZ5MnHNWyETOlBiSah0TbqTzZ +aPBX2p+irUYpJUmgTd0GhOtp6GhjzgcU/409BQumWNt1/3lPu+NqkL2vy7l4WWKp99J BQ7IVAy1R6bCTbsUSJhzcfWfJKtedUrszE8IMZ2/k0Ips8k1/NBFhftdhilQWc09pwOa aywRrHm6qwqaHXfGiWQaeQlq5y2vUZMjtrX/02MdvgLpzk9TBquOg2lIVZyv5IYbncvo DjXmNapHLAptvOqew2jVZgtCAbHRRFGurCL48sAN8bKQ5kxSAaMFPLNuFmO0MkGGsumn JSvw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1744009772; x=1744614572; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=HsaSC2HaVJRroJP0HwzWYTmvmXosq879cETOeyvqI4E=; b=gMwvyutnjfK9FJZm1sol7+SmncLlq7jWYy0PLPOz0hLcg16lAtfQeM9zkZIUi4wejt L1Yp+o/KE+gGQHJFDqaBiOStElq45Ua0q4ymSPeBnl4NM30gEPh6SV4vh3itw3mdstA8 iiGq64B9nI1Vp/s8Blq+br7VJFzyjaGebojpDF7YOsKHyTdf6fJEgETMILTnqUKgpNDI o5aIQE+2izTVSha/TEPwYqqUdp2XMEIj34dU4mCvVd9dZWcLYLT8EGCANh5MYhiKfrdQ pSVCdmT0+K4vE5W6xnLLtpVlJT75Lq5NN/YB6mBm5olxGtgxjMCxFmXK31V4PYnonkyw MnAA== X-Forwarded-Encrypted: i=1; AJvYcCXItL6fPrg8bHP9RaFmWIqVZqc9kMsxdt5v7lpZb1aW+XHiv3Ape7KkEtbWJimeSnHa56ks7ETDgd6tczC7+yBQlw==@vger.kernel.org X-Gm-Message-State: AOJu0YzQ+Qtw98quOrzGgNiUX4wG678+VJO3uHkSGDDF0Gx26g4jk698 Go6dlF31CJzJI0M4bq1AX1fLRPrNCNXnFC+O8zoWbRglPI1vYLE0HPCP1fh9UeQ= X-Gm-Gg: ASbGnct4Ur9DrVvB493+ho6Rno3OgxJB+qd1/u00CaurJNgr8gG8z8m9HKNLFlY4b4X kChb1mPWkEP6AUtXRqO2cYbKU7s1XLGf0cwXQ2fy9p55nwBbZlTyOn7pBW3aEYf7EIXFVxtGRiW hvYqbvKAvfzHN5rVpmc5WpzkVyeGF0MKmeAGR/ebWx+bYq0uY8cvXrWyuptJyej4aIhue4BdEms 2/cq3jahqYMoox0Qa8yfl32gMVzbZ7qEPvRMprmxgDVNWgis/D0h+Ead//zMqi/Q61vNj92AxM2 GqLcrcADmL/BgIbi80KaESRqXbAezdvfXxHUhg== X-Google-Smtp-Source: AGHT+IFoq+Y3x3L+TzUAPfnpayxhMl0EXTH8ChvoeKZsiBjolFAg72wzCsqeqv6HGqtEWqKDzyAzpA== X-Received: by 2002:a05:600c:5394:b0:43e:bdf7:7975 with SMTP id 5b1f17b1804b1-43ed0db4aa5mr81239825e9.32.1744009769231; Mon, 07 Apr 2025 00:09:29 -0700 (PDT) Received: from [127.0.1.1] ([2a01:cb1d:dc:7e00:8c64:734d:705a:39a7]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-43ec1663060sm124622795e9.14.2025.04.07.00.09.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 07 Apr 2025 00:09:28 -0700 (PDT) From: Bartosz Golaszewski Date: Mon, 07 Apr 2025 09:09:21 +0200 Subject: [PATCH 4/4] ARM: s3c/gpio: use new line value setter callbacks Precedence: bulk X-Mailing-List: linux-samsung-soc@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-Id: <20250407-gpiochip-set-rv-arm-v1-4-9e4a914c7fd4@linaro.org> References: <20250407-gpiochip-set-rv-arm-v1-0-9e4a914c7fd4@linaro.org> In-Reply-To: <20250407-gpiochip-set-rv-arm-v1-0-9e4a914c7fd4@linaro.org> To: Andrew Lunn , Sebastian Hesselbarth , Gregory Clement , Russell King , Linus Walleij , Bartosz Golaszewski , Krzysztof Kozlowski , Alim Akhtar Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org, linux-samsung-soc@vger.kernel.org, Bartosz Golaszewski X-Mailer: b4 0.14.1 X-Developer-Signature: v=1; a=openpgp-sha256; l=1523; i=bartosz.golaszewski@linaro.org; h=from:subject:message-id; bh=abv30zYA5XuyGwoeP1ru48ZEwjgixTtNG3nmu6YE3a4=; b=owEBbQKS/ZANAwAKARGnLqAUcddyAcsmYgBn83oktedBQx8pZUxbFWhdPQr1mhvAceAMNekvM eg9/SFm5bCJAjMEAAEKAB0WIQQWnetsC8PEYBPSx58Rpy6gFHHXcgUCZ/N6JAAKCRARpy6gFHHX cr4uD/920+W4HTn/DythHwMtCVrHef5JpB0YFglUyOJ4l+wrZNhV0VZcDRiw3F4l9uygDSEhyso biZUtfnWodZkYBVGq/dILl7oXl7vF8oWyBJBOzWK3dQxlFdzjiwjxS61wFDTiJtDqrwoHDBGvTP cdZzcOKwYrcWrxD1m8tsHEr4sYBaocCBaMA2DwOBsmTMuwLcnEhYE5HaoI7qjMdz+F5QjH+F5lT F4ogzhuGDbEZ6J5R06tmUkVr48izLrPyCCplJRhaREIq62mx+mTilrFqFpqxB2iDdfr46vmCzuJ 7xIvHs5P4COrgPm6/I5bKr+h3+1VzO7HQFBoDKY2Xuzejttwa3sTTD2RzFuKJiHYYkQM0Oxw178 Evb4gwQE/VxyQWocnlavibF52tIaBu3yLnHlf677OVaESjEllEOiw4lWfYVjj0vfVMDeR1OMO1/ +KBoC+MsYFiv2hkzvDRonuAMQITxCp1ygc3x2w6s9X7KYWS1CkudDWlCs/NRSMobunZUcYUkspl nsvorsS0oxCLJ07Oetc1JL7Q7A9uln5YELWlRQEIIT8hUBtLX7zVdJtvH6QwPqg5flDaNLjrTz/ O4tqaQq1mIozfl75z4Xn3k4+O6OudAZzvKN7VnXBJAK8HhrKrll2cDu2DajhxBcH61elXnqtFyn KFr7Ne2L2ryXdeA== X-Developer-Key: i=bartosz.golaszewski@linaro.org; a=openpgp; fpr=169DEB6C0BC3C46013D2C79F11A72EA01471D772 From: Bartosz Golaszewski struct gpio_chip now has callbacks for setting line values that return an integer, allowing to indicate failures. Convert the driver to using them. Signed-off-by: Bartosz Golaszewski --- arch/arm/mach-s3c/gpio-samsung.c | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/arch/arm/mach-s3c/gpio-samsung.c b/arch/arm/mach-s3c/gpio-samsung.c index 87daaa09e2c3..ea496958f488 100644 --- a/arch/arm/mach-s3c/gpio-samsung.c +++ b/arch/arm/mach-s3c/gpio-samsung.c @@ -430,8 +430,8 @@ static int samsung_gpiolib_4bit2_output(struct gpio_chip *chip, return 0; } -static void samsung_gpiolib_set(struct gpio_chip *chip, - unsigned offset, int value) +static int samsung_gpiolib_set(struct gpio_chip *chip, unsigned int offset, + int value) { struct samsung_gpio_chip *ourchip = to_samsung_gpio(chip); void __iomem *base = ourchip->base; @@ -447,6 +447,8 @@ static void samsung_gpiolib_set(struct gpio_chip *chip, __raw_writel(dat, base + 0x04); samsung_gpio_unlock(ourchip, flags); + + return 0; } static int samsung_gpiolib_get(struct gpio_chip *chip, unsigned offset) @@ -515,7 +517,7 @@ static void __init samsung_gpiolib_add(struct samsung_gpio_chip *chip) if (!gc->direction_output) gc->direction_output = samsung_gpiolib_2bit_output; if (!gc->set) - gc->set = samsung_gpiolib_set; + gc->set_rv = samsung_gpiolib_set; if (!gc->get) gc->get = samsung_gpiolib_get;