From patchwork Mon Apr 7 11:18:22 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Anthony Wang X-Patchwork-Id: 14040265 Received: from mail-ed1-f45.google.com (mail-ed1-f45.google.com [209.85.208.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E11B623BCEE for ; Mon, 7 Apr 2025 11:18:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.45 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744024715; cv=none; b=cRwStI1TncbpFy2ym16rpOBmXoXwRAAbKxMkIafDqSfnc0wJeKJyjKOPN/ITlreZJHRmRutRZwDeWsLl2Mw1GEnSnrUDibaVF7dH6P54pnnCLSW4TOSbhjcnXUpk5LkD324gqDjgpxMrEcMo9J62FwMn9AiUol61Wp1l68u+/wk= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744024715; c=relaxed/simple; bh=DrguJfPN8GUt+YEOLN7rkf7ipujmM9iqowID8r/N+Ac=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=RmWE5vyemGFxq0WWxgrL0R2b/TrXwsI/BcwCt46rGJhFUw3hU/pniSKKQp1GEFFZpXnTTbL0PWptmkyMDC60lIG1Rava5is+MkcXO2cVLcTkdfdWzCDeJxR08kWkC5JIylF2oJGfhtSLKOoGvnpELCUcnP2kMjHT/NErkQ8jeN4= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=CbBBQ2nC; arc=none smtp.client-ip=209.85.208.45 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="CbBBQ2nC" Received: by mail-ed1-f45.google.com with SMTP id 4fb4d7f45d1cf-5e6ff035e9aso8313420a12.0 for ; Mon, 07 Apr 2025 04:18:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1744024712; x=1744629512; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=OF3xzJyUHV0PXVg0dOiVOTM/IK6avPHTzjkcBoZ0DUA=; b=CbBBQ2nCgh9fGcrFeEjpgPTgDvWOAYdbD74dS79GYCo1UZG8BtlfeHup5OX6Ll2ZTD bPrlgZndsMsydXnngWRVgmfvXYM0kMNPjs+I9dmNsn+gC8Yx7RssxLMOvopEzMcywg0a pzRjJKpzWuEQ0lsCnJIkFNPu0Pc0Qb3Tes4p82h9HTMwChdVMtDrVVU2jQ8s7n+FmOGB S+dqKA1bmF09qeTSbXl2sdylPHdIIKtJ0MAwVa+e6B4HB95566zlyNQ5cdxvaiLw3h0a kuKmizUnETbG0YFbtqV0reFOWbVxhlhz8prsU3RC8e+xFbs1sdULG0bINNiJHdNKfUNI FmWg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1744024712; x=1744629512; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=OF3xzJyUHV0PXVg0dOiVOTM/IK6avPHTzjkcBoZ0DUA=; b=kvjKqaWsBp73l42lZlAqT5+QXjdEtXZEVTpzV0jbp/f9xBiTv99JM5iGYomThM613I hOrFJTE2Cl4u/H9djRXfZDntKK4O8F2UDkzhOLXj91Kn6ltbQCvHHDyitqLxha1sewq5 K74SXFu8s1/pIx/oECdOX0NV7vATahg19aWEOTczqQVt+AE4xJnXgsZqkCHsMkepazQl HNR/P398nZ+EC1ptsr2O47s5Is1guelKvgQbE8VEmLcr9IquiD6s+OeDFT7DiYpzbRX0 Q3is1ddVm+hxGTGVkLcmqdgQbKQGeVabKwvXluTegDG5J18/tpueybgkPykVL9H7scY+ U6qA== X-Gm-Message-State: AOJu0YwKdtnalvGB5H1eaZuSzGyWzYbfb41NYnShROR5OeXDKbMo+vLP QGaawkbG7RekIM84KF8C9zzbVHFituEGmnY4yuzPWLdg1uSvs6u0ClIP/3esLw== X-Gm-Gg: ASbGncuSTjNpkDMtLCVnSdnU3lJDHfVIB7Xd4scjS5yWhoNBCYlOM78Cinuobb09Veb VzZQr3PWqRvuF//v2OPtvzWUf7/F/ulFdSvhS0ave/qfcAvMOOw+D79AlabSx0zVrHvBBzreVE8 S4nSEMS37Xm9bq8Ljw44fukYxp3NhKRepnw8mucZr1ysX0Kh3izr6LzYnfRju7iDM4Rp3Ko4Agd VCgfe+ihfTWBtVgVB2XUW2GnBih//06UHmpCo1cAGga88OTYaHumBQzcpWrTarBzSAhmw/c/fJI 8yRXiJEblYNJ3NAFBcY408F66UFQpO3qKfQVKq+jXpVSWsESYmKpT6kJLfzdzzDwE9rTH1/uF7t GOGk+BXtfJk9h4yaIIl+zZrz7zznv68q7ScvQSIVr0dtAhDJdTpHoGzeDqU8QW1S+qmohPg/gkY KjIhazQlvXGJaE9d+vRtQk+9g= X-Google-Smtp-Source: AGHT+IHWaqGHZyOPfkDtejW0VkmzJ7hFLITwJLvYyHMBBlHCi7EVIgqcAH0BcAQs0Aj191tsAfyTwg== X-Received: by 2002:a05:6402:34cd:b0:5e7:c773:ae35 with SMTP id 4fb4d7f45d1cf-5f0b3b6089dmr10267225a12.5.1744024711093; Mon, 07 Apr 2025 04:18:31 -0700 (PDT) Received: from Anthonys-MBP.homenet.telecomitalia.it.homenet.telecomitalia.it (host-79-1-195-126.business.telecomitalia.it. [79.1.195.126]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-5f088084f17sm6613826a12.61.2025.04.07.04.18.30 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Mon, 07 Apr 2025 04:18:30 -0700 (PDT) From: Anthony Wang X-Google-Original-From: Anthony Wang To: ps@pks.im Cc: git@vger.kernel.org, karthik.188@gmail.com, shejialuo@gmail.com, christian.couder@gmail.com, shyamthakkar001@gmail.com, Anthony Wang Subject: [GSoC] [PATCH v2 1/3] t9811: avoid using pipes to expose exit codes Date: Mon, 7 Apr 2025 13:18:22 +0200 Message-Id: <20250407111824.46518-2-anthonywang03@icloud.com> X-Mailer: git-send-email 2.39.5 (Apple Git-154) In-Reply-To: <20250407111824.46518-1-anthonywang03@icloud.com> References: <20250407111824.46518-1-anthonywang03@icloud.com> Precedence: bulk X-Mailing-List: git@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 The exit code of the upstream in a pipe is suppressed thus we lose any exit codes of git commands that are piped. In order to ensure we pick up the exit code, we can write the output of the git command to a file, testing the exit codes of both the commands. --- t/t9811-git-p4-label-import.sh | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/t/t9811-git-p4-label-import.sh b/t/t9811-git-p4-label-import.sh index 5ac5383fb7..5abac938d0 100755 --- a/t/t9811-git-p4-label-import.sh +++ b/t/t9811-git-p4-label-import.sh @@ -95,9 +95,10 @@ test_expect_success 'two labels on the same changelist' ' cd "$git" && git p4 sync --import-labels && - git tag | grep TAG_F1 && - git tag | grep -q TAG_F1_1 && - git tag | grep -q TAG_F1_2 && + git tag >output && + grep TAG_F1 output && + grep -q TAG_F1_1 output && + grep -q TAG_F1_2 output && cd main && @@ -208,7 +209,8 @@ test_expect_success 'use git config to enable import/export of tags' ' git p4 rebase --verbose && git p4 submit --verbose && git tag && - git tag | grep TAG_F1_1 + git tag >output && + grep TAG_F1_1 output ) && ( cd "$cli" && From patchwork Mon Apr 7 11:18:23 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Anthony Wang X-Patchwork-Id: 14040266 Received: from mail-ej1-f45.google.com (mail-ej1-f45.google.com [209.85.218.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C2CA723BCF4 for ; Mon, 7 Apr 2025 11:18:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.45 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744024716; cv=none; b=KMZ0CvkeSVfCfuqm+vAUnlh1kjVaVtHrj3gd0HqiDggSpLikxpdcyJ5VEYLNqbkgEJdpf4yzyWP9m4zNSJRsGufCQP/NYtwLrOIVEqfH7inp08NRAcDY7z0JuGFz70YKgAjdK8ZmUgctJhKI5G9I5joA3kJHyQRkwt2h5O1+izg= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744024716; c=relaxed/simple; bh=yFF5Lpjr4xHZWcLMyFgofAAD0ZrbgCf7lKDnG7ls/Gg=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=GAi2z3m1qFY9TYTmMbPXFc6BxfSpNIv+Xevkx8vZ9oK1wJPb+QnLyBth23w0myiX3NcBISSoEG3h4tndDu0y4uW+7rbaLRwN7prS14HGGvyySwvu1VNh4Ir818L60mFWCuILuuZdngXKKPbZPSm6Ou6STbUaMIHtwATSNhN/aLo= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=IbZFw2XB; arc=none smtp.client-ip=209.85.218.45 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="IbZFw2XB" Received: by mail-ej1-f45.google.com with SMTP id a640c23a62f3a-ac6ed4ab410so688826166b.1 for ; Mon, 07 Apr 2025 04:18:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1744024713; x=1744629513; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=RpTCC4ro5e3S3B4/6+FgFa/Zev8emrtv7xc5Mg5bG7I=; b=IbZFw2XBCuBF16ZKzGHozCphWvnbtn8OkqMZVtCfS+qb3cWwXLUq3wi4JGvaTjmYlJ o4FmLRkf/K2kuJofG9aSTLZUsEOYQYt8k6xUdr8IrKNeHHh+tw+HAHV1lqS3hHQ2oyFQ YHxE6dbZGqdDvdDOpl+1zcpZLgB3YvSJjfjTQnFaoCDCCnmejMoJ0HqBvdrHO0WsyGy7 x8SAwpi/jz6JZysPzgOS0fC4FUZi+akLkQIDzJ3RtnygE9KguF3Pp51asq2zEztmOHWF C41XyH6wN+n+M4Xd9JzD6JOeUH6WlrGtabMW3aKXtFh5p2HKjkDlGb3yxXvy/IottFUC FE8g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1744024713; x=1744629513; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=RpTCC4ro5e3S3B4/6+FgFa/Zev8emrtv7xc5Mg5bG7I=; b=tvyWAzym0Z/wJ5XtjrZusdRWhjGFIA0/rMQQCWb/Cc2JP6Y0rLWzcKoiDB1aXkEHd8 xaKVWo9KmeWL3x5GoW4OUr9D3ymBzCw6XqrHtiaEmm082NRstCh/9wFHkcc4wpt7chkA B0AXauUMnqXquTTdE1ra+xGmWmu6OG47GTwDKUrtjt93MGR9B82QpzO5D7doXBdTsU3t 0fYMby8uFvQNU+5THdcV7BbtXRMDsD348/u37XeQQcQ5VU95woy6WvbapIYOIz8uaSUl J6h9zdapo8RfZDuh7fZ9O01V2ahZLj6MWBtk+rgpVY+xRs5Ex0IvR0vD0pVnY0PBUCSS 770w== X-Gm-Message-State: AOJu0YzxnCwT+JpcZZlDlZp+SYHir2PmTPq9J1SZxcRC+vg38DIO0Xv0 INFSvlKgmG4WQ2fkrzkCgN+e//IfyJYkJNyjtXLSnleUmjuc6m+DrPFg87MuGQ== X-Gm-Gg: ASbGncsEZtY6OthzP2MkrFm1JKqkDl4wslwn4tXuS/n4BbMj9PvNL4w3Z2RhySqEMVn 0PpLv/yrcSA8w4BG3/lifxNap7+Ku2zSZhS6P9O/THHJWptMgYKGQufYLm7Y6ROxANS2nGpVO0J p64Zp0SYpOxtZK1Zky7QTQXmEZZ48vWBxlk4ibNNblekwfbt1Ca3w69YF4JTdgES/vy0gNffSKU sM470NBAiT6J6fxdxCIMzYQEcOWHuK1TrJhuvpS7/ipRWAk5qldOR96YobY+dP3tbwviZLhrnDR /p2PvkLU0SQszELUHp5Dj5cUqF/gF6W/lgh35Y4xVt5k6bza6pwWeqXNQ6vS6WnUwrwe8Gxd3VQ OYBL7ccUaM0vkW63xpK4naPpi4BG1G+CaV3QBf4vux3WKg/5IlKM0CGLJXTlpgT0J7N5g6WG4MU By2ZlBv0hsmjVeJmsyhTZ6ang= X-Google-Smtp-Source: AGHT+IHMgOlEEcZBswjSipfrw+UcLL49ByB29ZUn32j9K3jfHFXadWim51N5WbsNtGZzM9P+uwgmlw== X-Received: by 2002:a17:907:971f:b0:abf:3cb2:1c04 with SMTP id a640c23a62f3a-ac7d185c2d5mr1057040166b.9.1744024713024; Mon, 07 Apr 2025 04:18:33 -0700 (PDT) Received: from Anthonys-MBP.homenet.telecomitalia.it.homenet.telecomitalia.it (host-79-1-195-126.business.telecomitalia.it. [79.1.195.126]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-5f088084f17sm6613826a12.61.2025.04.07.04.18.32 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Mon, 07 Apr 2025 04:18:32 -0700 (PDT) From: Anthony Wang X-Google-Original-From: Anthony Wang To: ps@pks.im Cc: git@vger.kernel.org, karthik.188@gmail.com, shejialuo@gmail.com, christian.couder@gmail.com, shyamthakkar001@gmail.com, Anthony Wang Subject: [GSoC] [PATCH v2 2/3] t9811: Remove the -q quiet mode from some instances of grep Date: Mon, 7 Apr 2025 13:18:23 +0200 Message-Id: <20250407111824.46518-3-anthonywang03@icloud.com> X-Mailer: git-send-email 2.39.5 (Apple Git-154) In-Reply-To: <20250407111824.46518-1-anthonywang03@icloud.com> References: <20250407111824.46518-1-anthonywang03@icloud.com> Precedence: bulk X-Mailing-List: git@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Remove the `-q` quiet mode from some instances of `grep`, as the lack of `-q` on the `grep` on line 99 implies that its output is required, when that is not the case. This change ensures consistency and avoids confusion about whether the output of `grep` is used. --- t/t9811-git-p4-label-import.sh | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/t/t9811-git-p4-label-import.sh b/t/t9811-git-p4-label-import.sh index 5abac938d0..e69dae55dc 100755 --- a/t/t9811-git-p4-label-import.sh +++ b/t/t9811-git-p4-label-import.sh @@ -97,8 +97,8 @@ test_expect_success 'two labels on the same changelist' ' git tag >output && grep TAG_F1 output && - grep -q TAG_F1_1 output && - grep -q TAG_F1_2 output && + grep TAG_F1_1 output && + grep TAG_F1_2 output && cd main && From patchwork Mon Apr 7 11:18:24 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Anthony Wang X-Patchwork-Id: 14040267 Received: from mail-ed1-f51.google.com (mail-ed1-f51.google.com [209.85.208.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C8B7E23BF99 for ; Mon, 7 Apr 2025 11:18:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.51 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744024718; cv=none; b=utBbn8YE1xbghBu3DA/FYH00WMbiUKju1wcIlLUNxLFKuCkyGtZcIFUmZeuDlOhe3lrFIonJhJzPYjwMoxBdUmXw7xvTVbudFHw7KCusyPfC37Dipr2VUVq1XbfItk50P9dsk4SNAGb/bWlPwQ3cbNShuNT+yHj+VWFbSUZy3W4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744024718; c=relaxed/simple; bh=ifMuZG9Iz71h4ItnLnz3UIGQy1c4doz7EYuPldJjPaU=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=uWJABb4ZMDPKqgE4jnSk6i/JI9nExY4qD8Zysk8aQ2PW7zMO/3p0MOzlYwTBnY9dbk4QsA6pxI8WATDj+uu96PzW0QistxaWvGAChzLFfNUlpxW81+0kXmuEwrhlwd/2zdPXlSz4gSNCQe/0hRzLLQ+RcOdetOXerSabStHf0H0= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=kG/jiOp/; arc=none smtp.client-ip=209.85.208.51 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="kG/jiOp/" Received: by mail-ed1-f51.google.com with SMTP id 4fb4d7f45d1cf-5e614da8615so2760569a12.1 for ; Mon, 07 Apr 2025 04:18:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1744024715; x=1744629515; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=f4fLZ22f7JoRp4VTn7PF6r/KMIOlDWHlEUpf6u8IrmU=; b=kG/jiOp/ZFftUpcl3O2aejjZycoho0SmdITMpqcRtM3Y9Pr2bR4bWWRGjgTHzO51Hu EZU0Jt+b9U3cRl4EoVbh+n7eTWTk1jpU9S2f+8J5964tKfaCky9abWBW8gD08P4zPhJP H9zBsXjipIGTawm31nt68T3TIrjCet5Yib+Y+qGUpBlA0T5VBYzSdtv9f0Taj8SeUZIF JqX8krT7Ov7Jp9xVGvy7JJQi89xkLxBERdjwFwXmZ64st9AchpWLyp5lpj7kX1etJig/ w5xS7Uldn0JIV2XprYnKH197ZyGDiKNiuX+xPHrq4G2E1qgWxR//GH9fSgt80btXqUMd SthA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1744024715; x=1744629515; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=f4fLZ22f7JoRp4VTn7PF6r/KMIOlDWHlEUpf6u8IrmU=; b=u3DWBDhkVyq3MlNNut9x5G2ZPWhyDASvs2zZ26SoeaFHeXuc6yw0TfHUHhzs8RfbmW jLnCxhU2Eg4aI94mgXwVcatdCgz4T+MrvwkXFsKcM6N0O0vtD7ebKUbAEITN42JjVG7j 2+0y7tlvNh6Pegjt2pLTnF58HPqzug8JsH1laVAbP5BqX8maTTwJvu/NpGuOD9Dt1LS8 bv6ueoRNCoIInZnYwBcAUv9BJkrK42neXHSiMxupK2IgwuNP1dMjXsWZHf9IIqS6Kf3x qqwNJ3Xa0njGQ1KyDw5JSKsO1Qfrgnu5HYgnzL8dFGIdQ3ZPG/ZMW0XizbUxgCiCawUd ir1A== X-Gm-Message-State: AOJu0YwUsg7batVleE5ebW9HWA2u5S9CuX6w6sKgsbD2yX8L0Hzb0h/C FJaysg2WlPN0es3IOxuZdxIpNaJ379U1jjpSmTQZRNt4gmiiokI= X-Gm-Gg: ASbGncsETTKJsxQry9UCL28GGAwNJwON+REgpL+3ptKmlBcxpIAvFdNtYXy5K/WHs3h WCStDg9DAc4QyyaarzICgJFQjlhnIt0HuslESAA02y6XwaXYTX7EiWArAtqXJNDlVuVqbny8VxI /Ob8YhH4UXwaXJeJO7cbAIVMvbFYQAj8iggaYeyYg5W0gPcXmF4GoalPCzIlBWp08riLO6iCINa xlxgT2sGonAWatk+JmL8tLgAxzQPmSHz/HQwxMZI8E6euvgvOrodpXejZKlEeKMT0cPtK3Jq0Es 188aGEBaHV1NN0kob3S1dCJ36uicAUKx5acjTsxcnS4OYG6UX7di1cdJdBghXZ62IF/wEzSbwsQ F5OjjuCoPOcBcDrdbsMRtR92jPJSVpIUOdEnyYUU87cOd4dPpV7oF/VfKvdMoLJm8nGSBGP6/Kc 4b74z7gLOOhAGnmmklu1iO/W8= X-Google-Smtp-Source: AGHT+IGtj3n5kdIplWUid/4PZd4VdMjsN7RjTy3TpXNXHtlY2nAH9tAtT6vDPy1RszZcgTgufT6HUw== X-Received: by 2002:a05:6402:5204:b0:5e0:8840:5032 with SMTP id 4fb4d7f45d1cf-5f08412c8d4mr12703783a12.3.1744024714773; Mon, 07 Apr 2025 04:18:34 -0700 (PDT) Received: from Anthonys-MBP.homenet.telecomitalia.it.homenet.telecomitalia.it (host-79-1-195-126.business.telecomitalia.it. [79.1.195.126]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-5f088084f17sm6613826a12.61.2025.04.07.04.18.33 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Mon, 07 Apr 2025 04:18:34 -0700 (PDT) From: Anthony Wang X-Google-Original-From: Anthony Wang To: ps@pks.im Cc: git@vger.kernel.org, karthik.188@gmail.com, shejialuo@gmail.com, christian.couder@gmail.com, shyamthakkar001@gmail.com, Anthony Wang , Anthony Wang Subject: [GSoC] [PATCH v2 3/3] t9811: Change `grep` to `test_grep` for debug output Date: Mon, 7 Apr 2025 13:18:24 +0200 Message-Id: <20250407111824.46518-4-anthonywang03@icloud.com> X-Mailer: git-send-email 2.39.5 (Apple Git-154) In-Reply-To: <20250407111824.46518-1-anthonywang03@icloud.com> References: <20250407111824.46518-1-anthonywang03@icloud.com> Precedence: bulk X-Mailing-List: git@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Change `grep` to `test_grep` to provide helpful debug output in case of test failure by printing contents of the non-matching file. Signed-off-by: Anthony Wang --- t/t9811-git-p4-label-import.sh | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/t/t9811-git-p4-label-import.sh b/t/t9811-git-p4-label-import.sh index e69dae55dc..e9c2aad2aa 100755 --- a/t/t9811-git-p4-label-import.sh +++ b/t/t9811-git-p4-label-import.sh @@ -96,9 +96,9 @@ test_expect_success 'two labels on the same changelist' ' git p4 sync --import-labels && git tag >output && - grep TAG_F1 output && - grep TAG_F1_1 output && - grep TAG_F1_2 output && + test_grep TAG_F1 output && + test_grep TAG_F1_1 output && + test_grep TAG_F1_2 output && cd main &&