From patchwork Mon Apr 7 13:36:10 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Aditya Garg X-Patchwork-Id: 14040545 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 95D8BC3601E for ; Mon, 7 Apr 2025 13:36:31 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 139C110E45F; Mon, 7 Apr 2025 13:36:31 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=live.com header.i=@live.com header.b="qSRltc8i"; dkim-atps=neutral Received: from PNYPR01CU001.outbound.protection.outlook.com (mail-centralindiaazolkn19010005.outbound.protection.outlook.com [52.103.68.5]) by gabe.freedesktop.org (Postfix) with ESMTPS id E2E9F10E45F for ; Mon, 7 Apr 2025 13:36:29 +0000 (UTC) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=YbA04B8N6/V+hBCh+p9DIvXmSfH/dGW2T+YlXHBjtOsPd4hUcipP1QJU0fPc5wTQcql/CL3P/i01NoI0oYVOM67o0ZLSpwD4yK3E6BGbDJmGmvs7CmbzNJEyv+RYmvdUprYrFPyrLh67SVxhs1WSI4Tj/Hn16I1UsTLd8O1uXiFJNlLutbXPvdo/CiGbu5K7lRpC6+hwUeyfwuWzEcawdvHHlN58BmdbVu3kz7cGiDBz4cIvPsXCnFDgxC+h/arTj/1PQzX5B3hPpzBIRNhKlLazFfbDdWl/1u6YUkRx+GaHvOORq9ADYWMRnHDnOODqjav7qkg49v6EwVDk4/zQLQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=9BaK2sIbKkGMx/9FF6qJRdXWycczn6mmYQVjFvZlDi8=; b=c7edfXewyXYi1n4iW4sU4EYOS9mU6RLK0s8V/wQwHeXfoszfM/ySTlSizBW3S9QMVI0PC1vlFfyzR928LRMFopJ9En91uLmFYmxSou2Ea+O15b36v02p0kScT05YH7eQzVF4fArhlgxTGtGmOJUbQ7jWAu0YeQzzXnFoO0DSk6rOx+m5BVAn3U+yuvrj+kURul4gVWC0zh5YjbHhy3Drl/Qad2sDXA9xC2KRi/WGlMkx/0eUXex8WaQhsBj+n9D7kkBxoWm86T4lWp+GV873/JxtMoIlBMshpXSvPeSXfblDw2zDM3LjbdECwmw0w8xWH2sK5srO0Lf2H6VBIYHA8Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=live.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=9BaK2sIbKkGMx/9FF6qJRdXWycczn6mmYQVjFvZlDi8=; b=qSRltc8ixX/RcD4QEnduyYPUNm9zWFnuHfamisFY27CTMJupkyZV+9Y8Yt29W2xSwLXiF6LvEWoOgRLsAN2X7c7666eaRv7lHCwd1fbf9U6KFnT4Pg5QSa10T85LJYqUnZi+RpZZcQ2d+21UrEJ7FHmt9WuhOt0hgEBZv46TMRVjFdIzOIz3SXylrhBpwAQhJTCZPxBD0MwHz+OmZdy2W3KVHrQREEZj2knvivd/oPYtcYNwh3md0bdyOqlkz/M9TTWH3QBCgNtpxxI1izkPjP1z5gfDfZrgL48F9Y5xpwBA7IYob5ZcoFPN1cvEZAt/vfAh2p+A+CoxUbwfHSZN2g== Received: from PN3PR01MB9597.INDPRD01.PROD.OUTLOOK.COM (2603:1096:c01:f7::14) by PN3PR01MB6823.INDPRD01.PROD.OUTLOOK.COM (2603:1096:c01:94::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8606.34; Mon, 7 Apr 2025 13:36:14 +0000 Received: from PN3PR01MB9597.INDPRD01.PROD.OUTLOOK.COM ([fe80::324:c085:10c8:4e77]) by PN3PR01MB9597.INDPRD01.PROD.OUTLOOK.COM ([fe80::324:c085:10c8:4e77%7]) with mapi id 15.20.8606.029; Mon, 7 Apr 2025 13:36:14 +0000 Message-ID: Date: Mon, 7 Apr 2025 19:06:10 +0530 User-Agent: Mozilla Thunderbird Subject: [PATCH v3 1/3] lib/vsprintf: Add support for generic FourCCs by extending %p4cc From: Aditya Garg To: alyssa@rosenzweig.io, Petr Mladek , Andy Shevchenko , Sven Peter , Thomas Zimmermann , Aun-Ali Zaidi , Maxime Ripard , airlied@redhat.com, Simona Vetter , Steven Rostedt , Rasmus Villemoes , Sergey Senozhatsky , Jonathan Corbet , Andrew Morton , apw@canonical.com, joe@perches.com, dwaipayanray1@gmail.com, lukas.bulwahn@gmail.com, Kees Cook , tamird@gmail.com Cc: Linux Kernel Mailing List , dri-devel@lists.freedesktop.org, linux-doc@vger.kernel.org, Hector Martin , Asahi Linux Mailing List References: <8153cb02-d8f1-4e59-b2d5-0dfdde7a832e@live.com> Content-Language: en-US In-Reply-To: <8153cb02-d8f1-4e59-b2d5-0dfdde7a832e@live.com> X-ClientProxiedBy: PN3PR01CA0050.INDPRD01.PROD.OUTLOOK.COM (2603:1096:c01:98::11) To PN3PR01MB9597.INDPRD01.PROD.OUTLOOK.COM (2603:1096:c01:f7::14) X-Microsoft-Original-Message-ID: MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PN3PR01MB9597:EE_|PN3PR01MB6823:EE_ X-MS-Office365-Filtering-Correlation-Id: ee6174f1-33f6-494d-8862-08dd75d92af9 X-Microsoft-Antispam: BCL:0; ARA:14566002|8060799006|7092599003|6090799003|5072599009|19110799003|15080799006|461199028|440099028|3412199025|41001999003; X-Microsoft-Antispam-Message-Info: =?utf-8?q?GArVTR7KVvbFKFw/bT53Xem6jTO3EDv?= =?utf-8?q?AoRRljgo3FrmWgplSgpmTV2vixhEaH62gILI32NcMdLU8Q6bDcsqECqGAlu+Uosr8?= =?utf-8?q?eLq24d1ZOwPjQpJCoVsQ44QKMhGHphOV+Fychh+85VtHfqOyG168ce8ufi5MnSWta?= =?utf-8?q?g3oG64ceaMnAWvvQqOa2l/2mVcFDOO1VFVFQaS1ygtOIDi1QVGCdK4rpyTkFBpJ8o?= =?utf-8?q?H8IEg8RHfhrPenV/lKPCwYdFG4Az8rJRsxmnXgWH3/vjf16uBWkfIpL7F1qvkFKRs?= =?utf-8?q?eBnyfbwjE9kMjVvBuJTLnJL1SZ8GCos7iZsq4T1Md02bnCqZFVX9a07cIHNUjUA9m?= =?utf-8?q?huwmsvHoGegB75HbMveGTGQyNOdz9WMGQjm1rpeDKtQDCxdIOyi7cp7UFCU5fbcre?= =?utf-8?q?7K0NojOlMDekSxssf7TUhybQhCRuxCZbPs2es8usj+KeAavnipJSv60ygwyCUk56B?= =?utf-8?q?5w3zqJGBBTj6Yw778kE91ghDJPoh2bREWRdk78QpKjnhuf2T/QgIcfvOMYTchh769?= =?utf-8?q?AL5zq8TrinGOgw9cYTcbs7HEJkpSLMl4xye12BLiWIkGTUJoCxy3sP3h6qSrssu0r?= =?utf-8?q?VaLMS9fE7J3NCbWo0Yuotact2mut5cpQXSwuEL53oL0/7Jtdcywrs+ZuMbaVXzS0n?= =?utf-8?q?nF0IExyGTEBeEpPpzWxNj+u35wRHULy24IfH5/Gw3T/nYRu7hWQ0g3ESKqHKxjxXd?= =?utf-8?q?7uu3gbPslMfFkaVkyBU8OiKzW/AAwOvctqVnNtW7nMI+POlahaqLdsXik1g0tijyb?= =?utf-8?q?E6d/xjhVDTMNtQdEY3yJXqkI2YXp96Ydo4/J4GKYbM8FPI2sRPFl8wiI5D614/NuO?= =?utf-8?q?/OdkL3AzB3qAnZ9W9V3R0wvCN0p6C8JEBfjVjcuUdYpu2VWR2+3kFEJ6drLNh4l0l?= =?utf-8?q?N4R15lspbQI07xfeMis0O1COBb4zzR9GL5S6WhrPFvhirkLNEsjU0O45WQq6oFi4I?= =?utf-8?q?UmJF1BwtRHfnSaPhey1pOoNuqwfMdTzOHYh8YOg9Ne9Y0qHA0JeS/1X7wueD0iwKq?= =?utf-8?q?LTgPbDeghR4UfPEnA7yJF+I1Kc+4YTQLpsLzaQTJBxE0D73v2hH9UdnaJx2Io3ZNe?= =?utf-8?q?mcQwpsk6xd/ITiHA9d0c1Kq3Ie1l0QuwT94WP02hfU55SHFldYIopA7bNYc=3D?= X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?q?mvJ4ax/h6mfYuIXY07UQ+2hj4Q0E?= =?utf-8?q?0747F+V2e1MVmVCXt5w82gDoRU3eP6/lNhsqNd+dmuKeatABX603+WDRI0eSLbE9c?= =?utf-8?q?Bur6aiOwgXOVkJEf1bV36DxhQ6UZUscnwkQ9ephUNnadsaT7jRN8YGC0Fg4z2si48?= =?utf-8?q?Z4gQVbQjGJ6HpDkyPzxFxnye3C3pz/FNu0oiZbUu4FuTSrq433YQQLaaraHbfapw8?= =?utf-8?q?r7FrBAKmVdyrYGov3RLdACg2Jjjtlr7/aBLzRfSxnw4eiTjnd/5yOOw7/qiE4/7i8?= =?utf-8?q?se1rmrhsdgiuk+xitMyLULlGwoBfCI5I/SmiBbbw3YT7Ava1T9c6QScYjYJDKJTWS?= =?utf-8?q?ngAqJS16CuoF7rUIsEa+vrjjc0FXprjuN8Cr/4e/jYXtUHkEXm1Oce7y4aAo33o4J?= =?utf-8?q?nBn38E3lb5RfF3VTF5AbZu5iOpgaxgiQdI54g8rn7cYpdGDDTDeaYGSf4LMoZdQhV?= =?utf-8?q?/vr8zVRPxvh/eXu/aAis1QQBXBUv9t7jZKC4TImPY07G19tEpOhDuFXMySHgChz+8?= =?utf-8?q?EEkcd7mU8MMej60dPDikONu7Za7XSp+r2DFIAFUsHq82CbHmPN9zoZLq8ILwDEyc9?= =?utf-8?q?FSG7F0whKMdx/51dXwSQbDMLd3jUUygm1BLOrBbwuTvOdb1rWG4FfsWYur9azlJrE?= =?utf-8?q?PfzREV1GdGuayzDPMLIdf41oT4GkHrb1+5fAc/siusrir/fWpVvWfRg6HmwcwwAz5?= =?utf-8?q?Z+9ONoJigTa+6OvT8qSYeExhAF1yorQIWMXhob7QoIOn3VUCzScs82MX7AJiS5Y+4?= =?utf-8?q?cqa/vO/oDM7EjM5c1rZmrvfrx2BdT4YPSWChgwP8pJjzS+xfClqTveqtMECp50G2F?= =?utf-8?q?EwVg+cOBKmOCanW8VlE0nc+lixmKSHj+Ufs3PR/T2G9EoPDJpJ/iO7a1IT1ucesUY?= =?utf-8?q?XenY/hp/WlqSV2MGYibfeBb7IjZKgaqQn1DI/83HVSZsxscOgi+g/W2T2utvZSMVf?= =?utf-8?q?cvdPXIf/PJsnqdKEJcTgo1m2q5o76T5Tv+mzLe/YjQ2VUaL+RaSoqqOFXSMhazlLO?= =?utf-8?q?sQC2KmkEYdwgGfpTvMVEwI4L465qD31PhACcph0UJlunlPt8SMhjz6llZHneXz3ZJ?= =?utf-8?q?clg1ANj5Vf1Osx/8TAiacVdjAI8FYq1czA3We3G9fgadtBSa/gOJcN8imJ5EGUPtD?= =?utf-8?q?XcUu+n0M7JhHNyGDHLRy+4aRczpG4bv7z4p+3BJNB7vzsjDAqJI8MvJD6DA4EnVEU?= =?utf-8?q?mMwl1Qx4nOZiBUgA0ZIpLBuhXka9BwrQhXJoAMpDOfmM2jt6y0t5xSyFk/txKNwjA?= =?utf-8?q?3A164DFdwB1YxNd1?= X-OriginatorOrg: sct-15-20-7719-20-msonline-outlook-ae5c4.templateTenant X-MS-Exchange-CrossTenant-Network-Message-Id: ee6174f1-33f6-494d-8862-08dd75d92af9 X-MS-Exchange-CrossTenant-AuthSource: PN3PR01MB9597.INDPRD01.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Apr 2025 13:36:14.7747 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: PN3PR01MB6823 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" From: Hector Martin %p4cc is designed for DRM/V4L2 FourCCs with their specific quirks, but it's useful to be able to print generic 4-character codes formatted as an integer. Extend it to add format specifiers for printing generic 32-bit FourCCs with various endian semantics: %p4ch Host byte order %p4cn Network byte order %p4cl Little-endian %p4cb Big-endian The endianness determines how bytes are interpreted as a u32, and the FourCC is then always printed MSByte-first (this is the opposite of V4L/DRM FourCCs). This covers most practical cases, e.g. %p4cn would allow printing LSByte-first FourCCs stored in host endian order (other than the hex form being in character order, not the integer value). Acked-by: Rasmus Villemoes Reviewed-by: Andy Shevchenko Reviewed-by: Petr Mladek Tested-by: Petr Mladek Signed-off-by: Hector Martin Signed-off-by: Aditya Garg --- Documentation/core-api/printk-formats.rst | 32 +++++++++++++++++++++ lib/vsprintf.c | 35 +++++++++++++++++++---- scripts/checkpatch.pl | 2 +- 3 files changed, 62 insertions(+), 7 deletions(-) diff --git a/Documentation/core-api/printk-formats.rst b/Documentation/core-api/printk-formats.rst index 4bdc394e8..125fd0397 100644 --- a/Documentation/core-api/printk-formats.rst +++ b/Documentation/core-api/printk-formats.rst @@ -648,6 +648,38 @@ Examples:: %p4cc Y10 little-endian (0x20303159) %p4cc NV12 big-endian (0xb231564e) +Generic FourCC code +------------------- + +:: + %p4c[hnlb] gP00 (0x67503030) + +Print a generic FourCC code, as both ASCII characters and its numerical +value as hexadecimal. + +The generic FourCC code is always printed in the big-endian format, +the most significant byte first. This is the opposite of V4L/DRM FourCCs. + +The additional ``h``, ``n``, ``l``, and ``b`` specifiers define what +endianness is used to load the stored bytes. The data might be interpreted +using the host byte order, network byte order, little-endian, or big-endian. + +Passed by reference. + +Examples for a little-endian machine, given &(u32)0x67503030:: + + %p4ch gP00 (0x67503030) + %p4cn 00Pg (0x30305067) + %p4cl gP00 (0x67503030) + %p4cb 00Pg (0x30305067) + +Examples for a big-endian machine, given &(u32)0x67503030:: + + %p4ch gP00 (0x67503030) + %p4cn 00Pg (0x30305067) + %p4cl 00Pg (0x30305067) + %p4cb gP00 (0x67503030) + Rust ---- diff --git a/lib/vsprintf.c b/lib/vsprintf.c index 01699852f..6bc64ae52 100644 --- a/lib/vsprintf.c +++ b/lib/vsprintf.c @@ -1793,27 +1793,50 @@ char *fourcc_string(char *buf, char *end, const u32 *fourcc, char output[sizeof("0123 little-endian (0x01234567)")]; char *p = output; unsigned int i; + bool pixel_fmt = false; u32 orig, val; - if (fmt[1] != 'c' || fmt[2] != 'c') + if (fmt[1] != 'c') return error_string(buf, end, "(%p4?)", spec); if (check_pointer(&buf, end, fourcc, spec)) return buf; orig = get_unaligned(fourcc); - val = orig & ~BIT(31); + switch (fmt[2]) { + case 'h': + break; + case 'n': + orig = swab32(orig); + break; + case 'l': + orig = (__force u32)cpu_to_le32(orig); + break; + case 'b': + orig = (__force u32)cpu_to_be32(orig); + break; + case 'c': + /* Pixel formats are printed LSB-first */ + pixel_fmt = true; + break; + default: + return error_string(buf, end, "(%p4?)", spec); + } + + val = pixel_fmt ? swab32(orig & ~BIT(31)) : orig; for (i = 0; i < sizeof(u32); i++) { - unsigned char c = val >> (i * 8); + unsigned char c = val >> ((3 - i) * 8); /* Print non-control ASCII characters as-is, dot otherwise */ *p++ = isascii(c) && isprint(c) ? c : '.'; } - *p++ = ' '; - strcpy(p, orig & BIT(31) ? "big-endian" : "little-endian"); - p += strlen(p); + if (pixel_fmt) { + *p++ = ' '; + strcpy(p, orig & BIT(31) ? "big-endian" : "little-endian"); + p += strlen(p); + } *p++ = ' '; *p++ = '('; diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl index 3d22bf863..44e233b6f 100755 --- a/scripts/checkpatch.pl +++ b/scripts/checkpatch.pl @@ -6891,7 +6891,7 @@ sub process { ($extension eq "f" && defined $qualifier && $qualifier !~ /^w/) || ($extension eq "4" && - defined $qualifier && $qualifier !~ /^cc/)) { + defined $qualifier && $qualifier !~ /^c[hnlbc]/)) { $bad_specifier = $specifier; last; } From patchwork Mon Apr 7 13:37:06 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Aditya Garg X-Patchwork-Id: 14040546 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id DC172C36010 for ; Mon, 7 Apr 2025 13:37:27 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 465A410E466; Mon, 7 Apr 2025 13:37:27 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=live.com header.i=@live.com header.b="SgWvmS8w"; dkim-atps=neutral Received: from PNYPR01CU001.outbound.protection.outlook.com (mail-centralindiaazolkn19010000.outbound.protection.outlook.com [52.103.68.0]) by gabe.freedesktop.org (Postfix) with ESMTPS id 7BB1310E468 for ; Mon, 7 Apr 2025 13:37:25 +0000 (UTC) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=X84+/YWvKjgoa+xm3vINYidqpavE7o73eYcDBsikR1aMvag+/UkBIj7+Ck5r27QTpZm1u99FdnewhAEq6oVE4JXway127OoPGlu9cxs8sayUWtf/sfJW8ggaa8S8rSOBBIge00utk9+CTmJvZ3XPMKSccDQJXz+uAWVTxd5uO4ksGe/sQXwL+DKeTUrvwjkomfvSb8pXrfTuOwjbUyqeK9j6YtbyuEE9VbPf7O5bb451/lVicGI8DH6El947XSOBrKWb5tJYJ4GxgMUsmlYPDoTXGnFbwZ8aNwdpNrUz4sbrM/BSmC9ID+dQghnkTwkKY7jxBKGJcz7D9POFqChGtw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=QfNeWfrMMaGwq416VG2bniGNOJIbQQt7ZtmJ1bM4fIc=; b=q8yG/uhL7hxlgf5T7Bvdm9rsIh3ErTPgLy2AsfK3oAOd+5EpJvTXgPRbQj5wKwz10TM6Hvp8o4f3teXz3WyFu5f8BfEt7RoOXvehFM+HlwD5tdGkevs6aHP9P1FGR0XDQgkFuNGof7iQe0QvQAbk62aOYzyQVDGzfVWXyBazJ8AFXEyJIokRPSkbvtaPM8ka67ZSkzGni0R8Gnpwc/WTcIxwhB7DMI2hQPegEG115OXKbIAGvM3sYjX7suYzVtlS2Uez8aqc3xw5iJCSkweky9Si8KkihhyaYFc6nRsCr8BKki1Hz9z/zOPf7P4U3/FZzNAmvGzx7tP+IxNu4CqiYg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=live.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=QfNeWfrMMaGwq416VG2bniGNOJIbQQt7ZtmJ1bM4fIc=; b=SgWvmS8w5qFM8zmPefMIBNBmJGqivQRVllaVRBlcDn4RaX9JeZ+wwlP8WWMaIpqI9RbRGBvVDkAR7dsfSWf597LC+MTcXjVHOlXspm0KEmOEcFctKVmFZ4EqwdeQtxGJOqoFxdAcIk4L/yMxgP2OGJ8VsnbwpY8Ratk8YyZ7T7BlNZXkm2XXoGD9T5Hff7+SNyo215CpJXZRkTjycQwWjkwLCcbkchgdaKMFI3srW07ddHq02TLmeW9vL5sK/MqRAcwAyUP9giHjdkIHPE2ir6GU57s6K/4jOIH8tLkvDL97x3ZEFg8fIIwzVDogmsM/p1sifKb0w2xdVEVqsv4z4Q== Received: from PN3PR01MB9597.INDPRD01.PROD.OUTLOOK.COM (2603:1096:c01:f7::14) by PN3PR01MB6823.INDPRD01.PROD.OUTLOOK.COM (2603:1096:c01:94::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8606.34; Mon, 7 Apr 2025 13:37:10 +0000 Received: from PN3PR01MB9597.INDPRD01.PROD.OUTLOOK.COM ([fe80::324:c085:10c8:4e77]) by PN3PR01MB9597.INDPRD01.PROD.OUTLOOK.COM ([fe80::324:c085:10c8:4e77%7]) with mapi id 15.20.8606.029; Mon, 7 Apr 2025 13:37:10 +0000 Message-ID: Date: Mon, 7 Apr 2025 19:07:06 +0530 User-Agent: Mozilla Thunderbird Subject: [PATCH v3 2/3] printf: add tests for generic FourCCs From: Aditya Garg To: alyssa@rosenzweig.io, Petr Mladek , Andy Shevchenko , Sven Peter , Thomas Zimmermann , Aun-Ali Zaidi , Maxime Ripard , airlied@redhat.com, Simona Vetter , Steven Rostedt , Rasmus Villemoes , Sergey Senozhatsky , Jonathan Corbet , Andrew Morton , apw@canonical.com, joe@perches.com, dwaipayanray1@gmail.com, lukas.bulwahn@gmail.com, Kees Cook , tamird@gmail.com Cc: Linux Kernel Mailing List , dri-devel@lists.freedesktop.org, linux-doc@vger.kernel.org, Hector Martin , Asahi Linux Mailing List References: <8153cb02-d8f1-4e59-b2d5-0dfdde7a832e@live.com> Content-Language: en-US In-Reply-To: <8153cb02-d8f1-4e59-b2d5-0dfdde7a832e@live.com> X-ClientProxiedBy: PN3PR01CA0053.INDPRD01.PROD.OUTLOOK.COM (2603:1096:c01:98::14) To PN3PR01MB9597.INDPRD01.PROD.OUTLOOK.COM (2603:1096:c01:f7::14) X-Microsoft-Original-Message-ID: <618b20cf-1418-4c5d-9b9a-544d97a76401@live.com> MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PN3PR01MB9597:EE_|PN3PR01MB6823:EE_ X-MS-Office365-Filtering-Correlation-Id: 7d97ebba-4192-42dd-3ef4-08dd75d94c3b X-Microsoft-Antispam: BCL:0; ARA:14566002|8060799006|7092599003|6090799003|5072599009|19110799003|15080799006|461199028|440099028|3412199025; X-Microsoft-Antispam-Message-Info: =?utf-8?q?czpJRv8/HrEf4O2QPEbf7lOzAzFgu3w?= =?utf-8?q?xf+pF00Os7j26ek5l7KncJVNilHIS96MoE1VdV4GkEeuGer3Xbx7mbTXgJ5hxtrck?= =?utf-8?q?jM3O+aYb96KDrCJVAEd60WZvy9//p1EJQdYr6RMmcQrTmeDdpBisugIoO0FAF7aya?= =?utf-8?q?SxdHVq/sf5Iy+1TLPMfIfRaGAEeWnGwoT1UcbTo2a4qgJgbz4Q4xy5/QfwDjfBzR7?= =?utf-8?q?cyiltNCvl0grGsU6BTb0XBjCvgbmlihDJcl1kHSBQ9XT8+/nrXAEHda/osUO1DrkY?= =?utf-8?q?yUpOEK+5rq6yAAgv+TS33w4VIUuNr4YNSmDRHmxGAaDV7vMuXZm6NyvibxmN1Znor?= =?utf-8?q?EmORQNqKcgLFUT5VEZjPEVFtYWIKD0+iHf4IttbnxMg81kvL/JJIQRhGaBg1V8sRy?= =?utf-8?q?BVIxTnLo+0/v1MjZflnfQb+0aV9DAvXPPIeemERGINUHlKqrIJDi5qiN+PTB/ussV?= =?utf-8?q?fMtV/Xa7ncrCu4NxcT/MkZMYQuG54ZuATPTct7Xw5O2Z/5e3/prXSj6HkQnUTqjAS?= =?utf-8?q?/Z5fWbJnsWOvn8QO13WbCfVfIppw7QS1uuDK+OjQSPUztF59HYZYfwjcKyTYW5cpd?= =?utf-8?q?J9h6vjX8qb/ElRxrQLUFUgzm2B7RUXdIjKpWkrKmUpJme5BOT1gw7o0F8G5SigRvJ?= =?utf-8?q?osDVeWXQxyx5ZgzUHxORrUIr7fxv8u93ZCnsbqXK/hSHtRVjK/e60/1l7i5q1WMsr?= =?utf-8?q?qAbc2jKfmGfjoIagYwfg8e6gpg7VA+9g4OJ5leczSclu/+BIeiXAMCxGQy0muG8+s?= =?utf-8?q?oPv/P8jRhjNPSMRYEoIp/ryLB5UuTjf2ZhY5XOfxK53qlBbl0egJipWBs8tETyz9L?= =?utf-8?q?4K5vx14OMAN/WJ/T1wQpk59kbkc9878LsXIHXJ7M4LOu0pzePX6JKysYRFONinSQE?= =?utf-8?q?UfdUNhqeyTq7CyhvIRr8Ofgl01ZbPLNC+tTQQvtyWktY2U17TkBQR+VBCeLOmCA5j?= =?utf-8?q?bhn1/hByD9DJEV7FIhT00Y6y2u7SHFMYCRMo+tfcy7zuSTHIizaUOwUR9KuIAw+6I?= =?utf-8?q?QlIGPv4e9REcA3vQA3Di1d0IjzNybY2ikOzad+J82jyW1SY8n5ex0HqvcdAyxSa+Z?= =?utf-8?q?WK1vZ3d9FOh+0OtD?= X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?q?5hLUVGJIfFFAhRTaRVYpqUHTQiwy?= =?utf-8?q?uoAuY086/t+aEfJ6CK7iT8eYahJcOJH1zHUvW9s1ExZKMwZN9stpyqfFNtCF1wnB0?= =?utf-8?q?Y2ntaQDm8WNovmQcHicPAGoJ9oyw1wvGpm8TdjelxGWi/Zq5jDGeKoTi7AcVgFFdb?= =?utf-8?q?Bw0mM6DMeQOSMIeWyJ9cr73VCB8lRi4O9WB8SMACJFafydDW8okB2J5+aoUx4JMos?= =?utf-8?q?hXcQP9mw140NdRmpAxWLBRpEDW8Z2Do9bb7T5vY24hL6b81oAO1Pgue1bMgV9S9ZI?= =?utf-8?q?1KbKhz0qORE4OOtmTOoQtC8MU6g7+45f15nhdHrzsyKKyFNol1+7RHRi6fklKTKMl?= =?utf-8?q?zj6tiMMB9bfZL4g1kbKn+IdhrFGSVjbCHY/gNg9ENoeOUBsbNgZIWROtf1TRj8snD?= =?utf-8?q?0iMTdFTG6NaTi6XjHjmqcb9AUf76bPWICbSIpjU4VAxgm2TiAixr0GosalAgGR6Bq?= =?utf-8?q?vsrBX0TM8h7ENbTxDSgw04cDJSWF7957IkGNt0nVNomhG5o9Sqzlo/6vxoxwP6vZW?= =?utf-8?q?m+OBX0V9dHMY974MtpwZzTi5OBVaj8Ml+JusAh6WTdyCQHIWGfBaIfFYAbOFfccgb?= =?utf-8?q?Qj1VRoYPmoDxJFrmu7PTYhBKA6MNHAJjmU7kro8NE1YIM6o2hHlUNnEnSfKrXdCw3?= =?utf-8?q?B8X+7asZfs6Im0fBBqcBUs9VI0/SpJlieGwF/fmEQ8xiFQDGnihmJ3FVR849BR+iy?= =?utf-8?q?Fj12bNqMkTSqdmIsiRkJKcHywW25fAMbxy3cbZIE7fMo6Bi98WvQgvPFgAFt6ZagD?= =?utf-8?q?1zEs7NOQfw7ro32tUUKHWlq+Pc0Wjf7QcLvap5iNoPQEQdO6LVuzFvcb8sDFlyeWu?= =?utf-8?q?RFwmFyoeQ+DxhicYrv19EIPWg+aTeVIg53U8Xec53zddlGSs3QQoJ5T+bEJdxlex1?= =?utf-8?q?xmjjHB2D1wK2nJrSf15vjyaGYgWTQbpSZrFAiEagSU/FDqh0Yz0Tit5lvf29f93lj?= =?utf-8?q?bqxqJ47cZUurtCn/ey+PZ10ddvdEuWoCY5965IeLF0u4qkNDA9i8hYRiNOj0AjAuu?= =?utf-8?q?Hm9CYqoFxa63DcnlBb3BLuDnuvQhasGTl7huMkkUImYzngs16EQ1wbaKqRt5+7TVJ?= =?utf-8?q?4mdhhq5cCHK2+Z/oJ4FMsHDfnRAptmJRAzUyb0xjoEo94CyqnmxUXrfqsJDjSprNe?= =?utf-8?q?4LTAD0vYOyrWG5RcGjcxVUWchH68HNQ6Xfs/eFFxMyRgUK4C0uMKluWhhEEEwBJZS?= =?utf-8?q?4cEAf2H3VxsGGM8QbYdPSH72bibWWnsB1dESxKHjrpY1WHt2XTw3E/XY0lsyLe8ce?= =?utf-8?q?iDS5Q6wBTh0VMhln?= X-OriginatorOrg: sct-15-20-7719-20-msonline-outlook-ae5c4.templateTenant X-MS-Exchange-CrossTenant-Network-Message-Id: 7d97ebba-4192-42dd-3ef4-08dd75d94c3b X-MS-Exchange-CrossTenant-AuthSource: PN3PR01MB9597.INDPRD01.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Apr 2025 13:37:10.5635 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: PN3PR01MB6823 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" From: Aditya Garg This patch adds support for kunit tests of generic 32-bit FourCCs added to vsprintf. Acked-by: Tamir Duberstein Reviewed-by: Andy Shevchenko Signed-off-by: Aditya Garg Reviewed-by: Petr Mladek Tested-by: Petr Mladek --- lib/tests/printf_kunit.c | 39 ++++++++++++++++++++++++++++++++------- 1 file changed, 32 insertions(+), 7 deletions(-) diff --git a/lib/tests/printf_kunit.c b/lib/tests/printf_kunit.c index 2c9f6170b..b1fa0dcea 100644 --- a/lib/tests/printf_kunit.c +++ b/lib/tests/printf_kunit.c @@ -701,21 +701,46 @@ static void fwnode_pointer(struct kunit *kunittest) software_node_unregister_node_group(group); } +struct fourcc_struct { + u32 code; + const char *str; +}; + +static void fourcc_pointer_test(struct kunit *kunittest, const struct fourcc_struct *fc, + size_t n, const char *fmt) +{ + size_t i; + + for (i = 0; i < n; i++) + test(fc[i].str, fmt, &fc[i].code); +} + static void fourcc_pointer(struct kunit *kunittest) { - struct { - u32 code; - char *str; - } const try[] = { + static const struct fourcc_struct try_cc[] = { { 0x3231564e, "NV12 little-endian (0x3231564e)", }, { 0xb231564e, "NV12 big-endian (0xb231564e)", }, { 0x10111213, ".... little-endian (0x10111213)", }, { 0x20303159, "Y10 little-endian (0x20303159)", }, }; - unsigned int i; + static const struct fourcc_struct try_ch[] = { + { 0x41424344, "ABCD (0x41424344)", }, + }; + static const struct fourcc_struct try_cn[] = { + { 0x41424344, "DCBA (0x44434241)", }, + }; + static const struct fourcc_struct try_cl[] = { + { (__force u32)cpu_to_le32(0x41424344), "ABCD (0x41424344)", }, + }; + static const struct fourcc_struct try_cb[] = { + { (__force u32)cpu_to_be32(0x41424344), "ABCD (0x41424344)", }, + }; - for (i = 0; i < ARRAY_SIZE(try); i++) - test(try[i].str, "%p4cc", &try[i].code); + fourcc_pointer_test(kunittest, try_cc, ARRAY_SIZE(try_cc), "%p4cc"); + fourcc_pointer_test(kunittest, try_ch, ARRAY_SIZE(try_ch), "%p4ch"); + fourcc_pointer_test(kunittest, try_cn, ARRAY_SIZE(try_cn), "%p4cn"); + fourcc_pointer_test(kunittest, try_cl, ARRAY_SIZE(try_cl), "%p4cl"); + fourcc_pointer_test(kunittest, try_cb, ARRAY_SIZE(try_cb), "%p4cb"); } static void From patchwork Mon Apr 7 13:37:54 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Aditya Garg X-Patchwork-Id: 14040547 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D9B09C3601E for ; Mon, 7 Apr 2025 13:38:16 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 331CD10E469; Mon, 7 Apr 2025 13:38:16 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=live.com header.i=@live.com header.b="g5QYR7Sx"; dkim-atps=neutral Received: from PNYPR01CU001.outbound.protection.outlook.com (mail-centralindiaazolkn19010010.outbound.protection.outlook.com [52.103.68.10]) by gabe.freedesktop.org (Postfix) with ESMTPS id C143610E46B for ; Mon, 7 Apr 2025 13:38:14 +0000 (UTC) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=aC9Le8BQ+l63vIOCRk6IRayyx04ZAd8p9bDaYG4UQGM54l+Ih46CJyh0bBKdc9DODdG2V7t2azMj/A93hBCY6A+54LgLow6onXgbBiESkgapnU8OvsYE7Hc6gsL26oSUh5LvVEY5UCLPSM3IHwSVqfcwrpqWAnlggb57RRQWH0XZX9n55hT7jtjdfrPWK5nML8PkHsaNGT9+Mfrzmdpx3PqTL6ZshDxoj73kAGEOv4xweqsuNtYXW3H0PdDuNQKNzyAitAS0Q1jx0KdIeQ2S1jB9dyAYFIEjnDpgqKyOgogPnro6s0RGhcRr8MY4evlbDFCIYkWRrJ4ACEX+oNP8OQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=XQeZ+h7jk0KS4dpMaymYhL5l8BSaREklpUecC5FBtUI=; b=n9VSFm+aBr27xIQ9Q+3+j25KwUt7MXpGKfP2MFyETVYAKNGePReYMyOMUfg/ioDM9cSHSqmFdUfPfvoI9vs98R/qYUS83YS54ixWWeB8s8DVmCIwAtokn3t6IceqMDN8Ce84VkfqhIBobG6VHpkt0N8z++KVD8Qh4NMQO0k/6To4kgUq2Y4PxVog2f3zPdrGTE4n0qoMvdsWfJTtUu8hXa1ziysCWta+kVccoOEy0I1v5hEvqPXQNzqvmjRU1Z3B4df98zGn/10+X2e7hmP9SfTz6A1Y0gZ1Wn0Ir0ER0cqb58KJTGiXdJk6kTt5hZQddjB4XkvSP/ylzcsP/T2SWQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=live.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=XQeZ+h7jk0KS4dpMaymYhL5l8BSaREklpUecC5FBtUI=; b=g5QYR7Sx3d6R3/LAkEGTdJXHnA246M18bYbnm4Z9lUUwHpnmlarIllZQF6/zKOdHh5vMQK8lFKrSfeo1QGHNOThtR+9t6EqhCnQKUzOs5n4HCJUTu8qMbOrEKWPvhBXynuDZ2o3z0tvnCdn9gWLHnHO9oZW0hqIhwqhz/mqt7YV4buMrNw8kRHJ2ZJGMFKzHBRZ5tTn1Kx8gFiZFy8/mJrhwfdohwKUCvWMXJunF3PPhZ/nzbSFloMeOSm2pnJBDuXMEDt+LamK5BDNbXAPjYW3BB96rr3tBd2LhyE5ke7AlDDAJDEUa3XoGROvzYuQkQbo70zUSpMCfdxf16aBghQ== Received: from PN3PR01MB9597.INDPRD01.PROD.OUTLOOK.COM (2603:1096:c01:f7::14) by PN3PR01MB6823.INDPRD01.PROD.OUTLOOK.COM (2603:1096:c01:94::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8606.34; Mon, 7 Apr 2025 13:37:58 +0000 Received: from PN3PR01MB9597.INDPRD01.PROD.OUTLOOK.COM ([fe80::324:c085:10c8:4e77]) by PN3PR01MB9597.INDPRD01.PROD.OUTLOOK.COM ([fe80::324:c085:10c8:4e77%7]) with mapi id 15.20.8606.029; Mon, 7 Apr 2025 13:37:58 +0000 Message-ID: Date: Mon, 7 Apr 2025 19:07:54 +0530 User-Agent: Mozilla Thunderbird Subject: [PATCH v3 3/3] drm/appletbdrm: use %p4cl instead of %p4cc From: Aditya Garg To: alyssa@rosenzweig.io, Petr Mladek , Andy Shevchenko , Sven Peter , Thomas Zimmermann , Aun-Ali Zaidi , Maxime Ripard , airlied@redhat.com, Simona Vetter , Steven Rostedt , Rasmus Villemoes , Sergey Senozhatsky , Jonathan Corbet , Andrew Morton , apw@canonical.com, joe@perches.com, dwaipayanray1@gmail.com, lukas.bulwahn@gmail.com, Kees Cook , tamird@gmail.com Cc: Linux Kernel Mailing List , dri-devel@lists.freedesktop.org, linux-doc@vger.kernel.org, Hector Martin , Asahi Linux Mailing List References: <8153cb02-d8f1-4e59-b2d5-0dfdde7a832e@live.com> Content-Language: en-US In-Reply-To: <8153cb02-d8f1-4e59-b2d5-0dfdde7a832e@live.com> X-ClientProxiedBy: BM1PR01CA0152.INDPRD01.PROD.OUTLOOK.COM (2603:1096:b00:68::22) To PN3PR01MB9597.INDPRD01.PROD.OUTLOOK.COM (2603:1096:c01:f7::14) X-Microsoft-Original-Message-ID: <58537fd7-eb7f-488c-a315-ffab4414ec2b@live.com> MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PN3PR01MB9597:EE_|PN3PR01MB6823:EE_ X-MS-Office365-Filtering-Correlation-Id: 238c263d-d9bb-4553-4fcc-08dd75d968de X-Microsoft-Antispam: BCL:0; ARA:14566002|8060799006|7092599003|6090799003|5072599009|19110799003|15080799006|461199028|440099028|3412199025|41001999003|12091999003; X-Microsoft-Antispam-Message-Info: =?utf-8?q?VlkhpJxkf2dOK3b4fNKNuxeYJwRyfVz?= =?utf-8?q?++MFlnpoD0GdAUTs6JvzxkQCYXbUiZA61KBtGct23o1BbQvy4W9MiwXE3fKDujppm?= =?utf-8?q?KZD2CHbDa7Vqdf0rjt5ibvtQxYTiJFDSxgSHWhCHjzQxRh5VAvYltlETan4jYT9Vj?= =?utf-8?q?aIdYVWu+lSeeNj6gA0EsjYGGxXY4Z9EPz2HRwjl2S+48Q23MBncXo6UKxAGVHRl7J?= =?utf-8?q?tjOFV964SxutQw+VB8EL1UmoyyPA2z4MBhvYyZKz3UBjTilwHs/dcmAhd5BN39YLV?= =?utf-8?q?PW4NpPV/3FNK3LgmxYMQhLqHr0+uH4pnW8jcXP0ODzQj1aatpXbN59Rxo2d/nzKnc?= =?utf-8?q?hXNSKCSTSvOHf4X9iFsX4U5RdSy0wdwEiDQgKtJDx5th0YDjRjgxwRb/JZQ6wyoPE?= =?utf-8?q?/7MjXyTo/PZbBa/GenonKj5cVVNdUXhYiyi1K8omOSpTtX5Yuw/LzkZzufvxoRR9W?= =?utf-8?q?0fyjn291QsUEGwrgIOWI2XlsS3oCMmMPJ0raJxSPJtSzZptedpyH40InDUN7/PAgh?= =?utf-8?q?xENzAyMCQlR4GjUucTvmf6PamDhhmmiftGefZAe/Fb7ZrcmTYhfiu90wIlp9hPOtw?= =?utf-8?q?SM8sjho+BOFrNWpz+fjXFgNdgmmrR7L41t4btihjk5eEKxYym5rGSD/bw+rdDLFui?= =?utf-8?q?b/iNFJDpj5CKpY+6K4lMUbn3h6tu8aPxaZKkE1E8y037kLLO/5CwJMIXeu6QciZue?= =?utf-8?q?i5QZZ4vsolSd5Kc3Jm+65Ah9dRz27MP2xwQuS4fuz4fNLPB75deCXoButPUkjogAX?= =?utf-8?q?7OC7B5PWDEKgYG8W9DazP86UQnDgolFRfZ4hw0+W7TxPuyGoRJ++Apl/20ggzJRwE?= =?utf-8?q?Jolnkh7be+DaY117EGV+t2tii3G/mk8uzPv8eOH+i+BOneIbs8ESmPoEnmJ8vwoBB?= =?utf-8?q?txfT/8UAX/JHGSpdHXzeqtQmTUWtJjRlTLSQD6m51qXNofstq6HVpI8rwVUuOTkP1?= =?utf-8?q?nBG/Qsv+wGeUCP3uP2CGH1NYaHr3VXLuTowRgyaISJ3XpW0SvHKsXwABb+UmzsGlW?= =?utf-8?q?4aoRULl9U9OeiwKwdECnxf71s0BOyBjKo/IMjVOe/EZjHARUCrMyHjX/wMsVuj71M?= =?utf-8?q?aPIVQaisNQnDkKNy+RdXuqgl7FZ4Y2QbRfycQx+0Lb8uT1ao4gBnWVphchl02YlNX?= =?utf-8?q?ReXa3uHQUcHTRI9?= X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?q?wbLPRqAc1+XrFFTCht53dd/010Z9?= =?utf-8?q?dl2TfGTml9+RSmUUaWzI8KGf+/hG67WjedbmmY3dcteZKIgo7kiYdXNbw2N7s0KCc?= =?utf-8?q?Nhe7nov0KB5XRzB5wzeH5x089Z3E1yJpQjYVpouDqqbnQyvgVLEwyiqcVOKUn59sk?= =?utf-8?q?IzHKAc0GOTe2pEbKKxjSItLawbr4CV7T7w8cj4HmpkDFQK+HDKeLV9eWwtTRKL9lK?= =?utf-8?q?k8xOTb+ergjSyrH0l1aHpCTYIjgL6uOBAhPDJYxcepcdyQTUTsLoYXMDpwUaXwd3L?= =?utf-8?q?w0aL7ogMurTZf49hvkgJX/U9msGSI5FBFGpqvtVEW0n/8qnJK1Y5QK1FsFjVwJWm2?= =?utf-8?q?VWgWRZmbypwacTJ7hoBfA8Qu/PronB1YekDoJVfQdcZ+sx65W31yH5u+tYYkJ3Dxg?= =?utf-8?q?JMqt2pAb/HIecgDj+UYM5meHTH4atP01hF5ClByX/Fo3ox29WGsEBKtwOWuVH17cd?= =?utf-8?q?KCwaNh73EwfqIvDDM+9GOxyb5hLNYF94GVsc30e0hVaWxovps6nhFDSnmcbcgpf3b?= =?utf-8?q?U/HmXMAUMWLLoY1Fr8lIshLnYPCHZIk9VkYmW0SyvLC+LT7nUgUmpckn0F0yzQxOh?= =?utf-8?q?Ipnys0fGew9/k2Si7Ysc4BHI2qTVZwlWt5MODHWeW2phwv64CNohcTs+CLv9CzI9M?= =?utf-8?q?P4ijSv1mbTU0yC/+TW9dP2moIxFfF7TdSeiw57SByj7klS/qgVdWpSt7m9Ez18qJZ?= =?utf-8?q?ZshIvPEmudRdJZJgo9tpH4BDvVxjZVFT1zfL3W+8PwFSsX34vnuxy1PMP/XiRGDDa?= =?utf-8?q?UDSFLGo//23T1I7+ExFzbtWsfIsYatlYV9OAnNYvnAI4m9O8dXD/Y+d1kkOPz3vzT?= =?utf-8?q?O/G7H5FzrdAfFE4yszQUUfQAyg/eKJ+5JzaGSp/Th9kVcc+6aMQJzB5onI8UL+yc2?= =?utf-8?q?STDggWqF8fAr5VysAkqKajtxnsWRZoEzz5GW+bFivwta4V5opQVFKJMRSXaP46KED?= =?utf-8?q?vv6ITzQJFSIJRvGN06EdFTzgvE7tF+QcQtBSs+lE1X12++f5RJUlKGehlgHWT2T6r?= =?utf-8?q?NUpRcDYTMIkBSQHRLVDhPV2eG4MF7NOI6gL44psjBzETAgJdS5mHiiDR/OzrR8zsD?= =?utf-8?q?C+4Zu1wF8Pb1CWRE+UMH/9EkD0CL2BuKRxZBdRIpvMcx5VY3Ec2e/44IW3OjMuq9T?= =?utf-8?q?ViHMuxe6vnI0hYVutv7sD8XYq1fW1kwlTnKrD+ZQKv+Lf1y6f97wQnn29+M7uGhU0?= =?utf-8?q?mIAvicNjs+Dl+98uMZt8T3CcSbCjU2q47MW0eMMYpara3XNoaaG+7thSb74MQD9V5?= =?utf-8?q?/WRPOtzpgLHL5ff5?= X-OriginatorOrg: sct-15-20-7719-20-msonline-outlook-ae5c4.templateTenant X-MS-Exchange-CrossTenant-Network-Message-Id: 238c263d-d9bb-4553-4fcc-08dd75d968de X-MS-Exchange-CrossTenant-AuthSource: PN3PR01MB9597.INDPRD01.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Apr 2025 13:37:58.6267 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: PN3PR01MB6823 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" From: Aditya Garg Due to lack of a proper printk format, %p4cc was being used instead of %p4cl for the purpose of printing FourCCs. But the disadvange was that they were being printed in a reverse order. %p4cl should correct this issue. Signed-off-by: Aditya Garg Reviewed-by: Alyssa Rosenzweig --- drivers/gpu/drm/tiny/appletbdrm.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/tiny/appletbdrm.c b/drivers/gpu/drm/tiny/appletbdrm.c index 703b9a41a..751b05753 100644 --- a/drivers/gpu/drm/tiny/appletbdrm.c +++ b/drivers/gpu/drm/tiny/appletbdrm.c @@ -212,7 +212,7 @@ static int appletbdrm_read_response(struct appletbdrm_device *adev, } if (response->msg != expected_response) { - drm_err(drm, "Unexpected response from device (expected %p4cc found %p4cc)\n", + drm_err(drm, "Unexpected response from device (expected %p4cl found %p4cl)\n", &expected_response, &response->msg); return -EIO; } @@ -286,7 +286,7 @@ static int appletbdrm_get_information(struct appletbdrm_device *adev) } if (pixel_format != APPLETBDRM_PIXEL_FORMAT) { - drm_err(drm, "Encountered unknown pixel format (%p4cc)\n", &pixel_format); + drm_err(drm, "Encountered unknown pixel format (%p4cl)\n", &pixel_format); ret = -EINVAL; goto free_info; }