From patchwork Mon Apr 7 17:25:02 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Anthony Wang X-Patchwork-Id: 14041365 Received: from mail-ej1-f41.google.com (mail-ej1-f41.google.com [209.85.218.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C8F1921638A for ; Mon, 7 Apr 2025 17:25:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.41 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744046714; cv=none; b=nyixX7W83zmR3fxLP1L+dI6GrNccqANqKTuyCBhJ2OiSFUjDoEmX0wRrsbBd5sqxEBZB2sDlBMVBeWx0nOv7s7y4VYu/Dp/jfFtb9n6ReMBfN02hz3wackz7YcIK2w9pkur4mAkc0zSQi8VLKVG2Xtfd2hBdq57ebES0IvD7xpc= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744046714; c=relaxed/simple; bh=WMGuvGoIpiwIhLsre++9ytwZeX3fAh/+rbStHpf1FLo=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=LCWN5yOjPIZ+lASHo2kUxvsILsjzE94hySRSHzcXAqg+BxruByOwV0TEGmL7Q36GMOO8gTNz2zfJ8phjs2h5u31/oh6rSDeOdpMI0t+VoufwlH2kMjqwNhatK4GHuM1fGQB/tNUhAewDnMy1YubQbRSpOep9QI8GNN3VIH1Yp8U= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=T1/UljcM; arc=none smtp.client-ip=209.85.218.41 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="T1/UljcM" Received: by mail-ej1-f41.google.com with SMTP id a640c23a62f3a-ac2a81e41e3so840543066b.1 for ; Mon, 07 Apr 2025 10:25:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1744046711; x=1744651511; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=Lv4ms7Kz1hKDwH4hsfrfRh0tE2Tev//BGbvXQi2MC2Q=; b=T1/UljcMyNDB882azEZwEP3XgN2Lz9T22uwgpsYBMhVmMU4ShE26YdrJNPNMeOGNJE C/BFbZeph5Gz/Hvg7Ws86yPjOBXmtUT4XJxFSnh9DzZAQg5hroAuB/JXX+DxknMNPMoO +innNehj4Q1dTMwkK5CfRkF6SiXI0PsI7nSrD+h5BHr8FgWuwaJxPby/ZdglbyMAKwC4 4scdAAZpkaO/kmNxr0pSD705mPo1MkhMAEnOr1lnCW8mfff46YGp5AmJbqfB7/mmK2KP /I5DZLusX3rJbYg1u5fsQtrcmd2Wy6sHGHypWwKgtAcRVtc9WfUQ6UuPi9Q8RXsp2Rdy XG6w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1744046711; x=1744651511; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Lv4ms7Kz1hKDwH4hsfrfRh0tE2Tev//BGbvXQi2MC2Q=; b=nxAfVfegK4JjzRVElSv2IfvnlhA/T3qQVwKQQDum+8vvFSqhz1KY9LDA9zVe70d3NR LxOZlJ2HDcVKwmwLitGrz33QkvgiZDOyTa9lIoHcXRUUjk2LAz1KJu04wTy9yYwUAQjG l6g2p54/o/yZh3KvV2CL65uco1iCI0qEj/CPhsS9IEof5dg/d6/IQHKMxWcuWPktQdRN 374xlFlMh/pL0wJjDlV8FiqsXaHcBnKxbhhAvbGVBN6bl8J0fE2oy3LPGpdFrGPuNOTl BdLQonKM0HD46+7dbGHEtrA/w30+TlcvfmFhFO6h/w0Rw7I++GIE642HcFs2aj/rhYdt UpsQ== X-Gm-Message-State: AOJu0YwfNHllf8GxG5cJOgjk0EzUIQleNzfAHlY5xaGbEwF6RqkL8ey8 B6X+nY2gkSDlPgkzfHOyX+1Pqkv5xbhOlLByiHtDoMIPpOsKdFc= X-Gm-Gg: ASbGnctUDNeMpoEOBQ4jPM/u6r1dpBA6LMugEMrnxeBy0gIcCgrrS67uVNxnqJExQgM mbkfAmm+9BFXL5y0OXDav0rqSQwiOq9MQoqF1paUVswEwM7mCojNN9kAafhPQ5w4KRXx/wpg07v zn4PgMXzSki09uPLm3AWJYQs1euWiYVt8BoFXFgnljF8tdlujcsFARgtsDffJLYC4bh3xLhWaWs zYT3xYNRwojZ7pPKVe9Sl1M0l8mQD4OKYggVJ03A2UgbvZg+2RR+YkSFW95maaT9wm6tTIRw2aY qW/d71sZ96eaJP+N7ylFZ2BlelUdqOOfVVnd+PQbtCCNW1ZizYuAZZaU2xbHtG09lQJoLQldaKq 8d+0NQVp3AS98HcaLtSGheAs= X-Google-Smtp-Source: AGHT+IEtjH0cjzcqUS37XL/5Yo+oCxKsgxT8KdsaY3Fqk/zwnQyQf/HR5OmRHSij92r706G/uidP1Q== X-Received: by 2002:a17:907:3f9d:b0:ac7:18c9:2975 with SMTP id a640c23a62f3a-ac7e7771f7bmr822469566b.48.1744046710960; Mon, 07 Apr 2025 10:25:10 -0700 (PDT) Received: from localhost.localdomain (generic-nat.unisi.it. [193.205.5.2]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-ac7c01c0fb1sm790193966b.179.2025.04.07.10.25.10 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Mon, 07 Apr 2025 10:25:10 -0700 (PDT) From: Anthony Wang X-Google-Original-From: Anthony Wang To: ps@pks.im Cc: git@vger.kernel.org, karthik.188@gmail.com, shejialuo@gmail.com, christian.couder@gmail.com, shyamthakkar001@gmail.com, sunshine@sunshineco.com, Anthony Wang , Anthony Wang Subject: [GSoC] [PATCH v3 1/3] t9811: avoid using pipes to expose exit codes Date: Mon, 7 Apr 2025 19:25:02 +0200 Message-Id: <20250407172504.50849-2-anthonywang03@icloud.com> X-Mailer: git-send-email 2.39.5 (Apple Git-154) In-Reply-To: <20250407172504.50849-1-anthonywang03@icloud.com> References: <20250405103718.25160-1-anthonywang03@icloud.com> <20250407172504.50849-1-anthonywang03@icloud.com> Precedence: bulk X-Mailing-List: git@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 The exit code of the upstream in a pipe is suppressed thus we lose any exit codes of git commands that are piped. In order to ensure we pick up the exit code, we can write the output of the git command to a file, testing the exit codes of both the commands. Signed-off-by: Anthony Wang --- t/t9811-git-p4-label-import.sh | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/t/t9811-git-p4-label-import.sh b/t/t9811-git-p4-label-import.sh index 5ac5383fb7..5abac938d0 100755 --- a/t/t9811-git-p4-label-import.sh +++ b/t/t9811-git-p4-label-import.sh @@ -95,9 +95,10 @@ test_expect_success 'two labels on the same changelist' ' cd "$git" && git p4 sync --import-labels && - git tag | grep TAG_F1 && - git tag | grep -q TAG_F1_1 && - git tag | grep -q TAG_F1_2 && + git tag >output && + grep TAG_F1 output && + grep -q TAG_F1_1 output && + grep -q TAG_F1_2 output && cd main && @@ -208,7 +209,8 @@ test_expect_success 'use git config to enable import/export of tags' ' git p4 rebase --verbose && git p4 submit --verbose && git tag && - git tag | grep TAG_F1_1 + git tag >output && + grep TAG_F1_1 output ) && ( cd "$cli" && From patchwork Mon Apr 7 17:25:03 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Anthony Wang X-Patchwork-Id: 14041366 Received: from mail-ej1-f45.google.com (mail-ej1-f45.google.com [209.85.218.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 83803217663 for ; Mon, 7 Apr 2025 17:25:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.45 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744046717; cv=none; b=elKRheIwSthWCTX0VwOs4l2bIoq18GgHD2qxQI9fUZbuoVNbGB5L51gSfwq3KjbD6+v81wz47JvUkOH/W0usnGwodZF/qc+jgN1HDbXXGtt/b1kbdbERC/6JImU7vWMj9/lZ2SOvwhgyhQfh5b0Gc7UMjsCsJALimBisVPEHs/s= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744046717; c=relaxed/simple; bh=zO5NuZSc/5QKpxw6nkSer/VUV479W1c6DWz3JVxWGqw=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=LXfu2dolBiZvlNMHiAij4t68tLCYHckQ7t5sMm6v0wICvYg9Hcbgk0tDA4ravwpmj9kGBQfpCJDF5DhhvYecSsh18wLZe5okKJNI47hKdsuIUYmciphaU01dTD5GgR+Dx9TV3/C3ybT+8OxURJGvjIXTR2TBGJPFwKyJiL0KTJc= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=N3s0M6hq; arc=none smtp.client-ip=209.85.218.45 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="N3s0M6hq" Received: by mail-ej1-f45.google.com with SMTP id a640c23a62f3a-ac2a089fbbdso836375866b.1 for ; Mon, 07 Apr 2025 10:25:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1744046714; x=1744651514; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=XfdsbpsPxMG7xSh58eXa9dD3duB+SHJ9c8UsSQ3GTJk=; b=N3s0M6hq+CVUsmynPCGxCcrK6xfzHq5XZjyR1l0OJ/QdMzhq0G9fjoWSPwI8+HTHW6 aK2NNpL2HQ5S4xgbkel4hDxvwufsIsewDhTqxXIAze6KbcAwwPGnndaLOsvwCKKhLTwt p+chH+U5MRq7Ua6P6QmmnSsynPmmPhxnzXJRZaZ5rGNBie/azB+vMVSbNJ25YpnDxpKu bqtjfcAMo/g2ZG8vG8apLyqaPnHfosgGFG8UDgz6wfnlJ5Locqg6qDaskwyv3liRbMzb oEicReYH92Z0HeviTGvLZLLamYcLUULgbARjO2euwsom0V0ek4VElDZAB1O1XlaUjBeo 4Msw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1744046714; x=1744651514; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=XfdsbpsPxMG7xSh58eXa9dD3duB+SHJ9c8UsSQ3GTJk=; b=UZm6zdYjUgmbFicOY/Ty70a6rcGokA7t36qqJwIgxC/ZIm2esFzGbKzJt+YuKQookl T7qMGtpwEKjjvvA0xkl+zxSeRr57GCJ2Iyt5HKhX2IyDRj2nKf8Qi5ZA/vFzwtWxmCO3 YXOp4xmC4vtDsHIWiRtC7QmV+xgiGSC2QlmxuSz4Rltb0vc+obEa3YLDaj5bVMEYiWg1 IyCf0boe0cDPWv0iFmAI0MSIe8IM4JALDvYGdewQ3VLHJsmpsSKPcVY7zc/G4SmeBYWp KUZHuL1SB6YgtK6BOXYSgE8NR8UNGUXXxAK70/fGV2JuB1zA7EsHriQycOuZ+h3D0RIS Whww== X-Gm-Message-State: AOJu0YwvVp36LKJKxkT9u6xf3tvIkd17u2HQUTlwROckeg9t5qS4OaTe VrP/8Dq5NjIml5NcZ+Q+wTHmlGoqPoZU1yhgI3kaZTlPg28wgDY= X-Gm-Gg: ASbGncsNZCnCVc439y5mzq+WnSBULyjumf9MctiKVUBrR7vq8jAmEplxqUs8yMCChzo qG0OjNKHuh48C97yqJNwvLdPwYQqHjanbQugt//0cEKAEzBrDKerinfzS3iSasSCAZjPxul8/FD rkunB+RPBsTq7/E/eQF8DLCFi7XpjlGSm2nlrG+RR0K8mEN9DIEMRpZsqg7AnHuhwzxJClndJmt 8xg8Zd1Tk2gC17/vskL6gMmti9VCdTluDnM3uv2/l292u7bTmNyiou5pMRLsklKTvZBY1i3e+oT allH/yWPijJ/ddsvV0cn8CYQEyVpgSTlR9hSXSkaFKQ5i8MJSdQT/5VI004whTzmdqEzsgD6CxV Crq/GVBEZNUSS X-Google-Smtp-Source: AGHT+IHzDzeqz9d/yzN85rtXl9jDx/VBBjrU8eTfuDlnnkNYnphr2c+iAD77qejuUGCuoMmOQQgcwQ== X-Received: by 2002:a17:907:7f8b:b0:ac1:ecb0:ca98 with SMTP id a640c23a62f3a-ac81a8790cdmr19543366b.26.1744046713691; Mon, 07 Apr 2025 10:25:13 -0700 (PDT) Received: from localhost.localdomain (generic-nat.unisi.it. [193.205.5.2]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-ac7c01c0fb1sm790193966b.179.2025.04.07.10.25.12 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Mon, 07 Apr 2025 10:25:13 -0700 (PDT) From: Anthony Wang X-Google-Original-From: Anthony Wang To: ps@pks.im Cc: git@vger.kernel.org, karthik.188@gmail.com, shejialuo@gmail.com, christian.couder@gmail.com, shyamthakkar001@gmail.com, sunshine@sunshineco.com, Anthony Wang , Anthony Wang Subject: [GSoC] [PATCH v3 2/3] t9811: Remove the -q quiet mode from some instances of grep Date: Mon, 7 Apr 2025 19:25:03 +0200 Message-Id: <20250407172504.50849-3-anthonywang03@icloud.com> X-Mailer: git-send-email 2.39.5 (Apple Git-154) In-Reply-To: <20250407172504.50849-1-anthonywang03@icloud.com> References: <20250405103718.25160-1-anthonywang03@icloud.com> <20250407172504.50849-1-anthonywang03@icloud.com> Precedence: bulk X-Mailing-List: git@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Remove the `-q` quiet mode from some instances of `grep`, as the lack of `-q` on the "TAG_F1" `grep` implies that its output is required, when that is not the case. This change ensures consistency and avoids confusion about whether the output of `grep` is used. Signed-off-by: Anthony Wang --- t/t9811-git-p4-label-import.sh | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/t/t9811-git-p4-label-import.sh b/t/t9811-git-p4-label-import.sh index 5abac938d0..e69dae55dc 100755 --- a/t/t9811-git-p4-label-import.sh +++ b/t/t9811-git-p4-label-import.sh @@ -97,8 +97,8 @@ test_expect_success 'two labels on the same changelist' ' git tag >output && grep TAG_F1 output && - grep -q TAG_F1_1 output && - grep -q TAG_F1_2 output && + grep TAG_F1_1 output && + grep TAG_F1_2 output && cd main && From patchwork Mon Apr 7 17:25:04 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Anthony Wang X-Patchwork-Id: 14041367 Received: from mail-ej1-f51.google.com (mail-ej1-f51.google.com [209.85.218.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8439C21638C for ; Mon, 7 Apr 2025 17:25:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.51 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744046719; cv=none; b=ThThY3vef7LL0Q0tEsAPKMxObQel5tsNK9exJ2zrPM+5ewS5XGa7EoGsKbE+cghASLBibrMKZs34BMFj36A/0byfulACdfJ6xrYGNHUJJWFbf7oG5+7GHK9Ck7QdgnKayA2ravePmBGih43k4NkXov7COm7PNEhg7imCtwRvayY= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744046719; c=relaxed/simple; bh=ifMuZG9Iz71h4ItnLnz3UIGQy1c4doz7EYuPldJjPaU=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=CvsnjEi02ASVqz541T/md7lM4KhQCsGrc953pNjyzJS4MS7+WYx7UYcsxhIWb3A1YcjxDuL+K45fwpnrJ4ifhN4iMZKxPfDpIVMhHozh3Il4D7DHr+uVM31WsHqdhyXNTfqIxMUSjTmRSgR7oKf0/tRcSI8og+me9gSr1vatkR0= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=jxPQqR25; arc=none smtp.client-ip=209.85.218.51 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="jxPQqR25" Received: by mail-ej1-f51.google.com with SMTP id a640c23a62f3a-ac298c8fa50so778835066b.1 for ; Mon, 07 Apr 2025 10:25:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1744046716; x=1744651516; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=f4fLZ22f7JoRp4VTn7PF6r/KMIOlDWHlEUpf6u8IrmU=; b=jxPQqR25RRK2VWwWFzsAkb3nmMzAoR5s+31Ll1rS3YQZd8os0bv++ccdeC1LzjTvi/ ZdW9g1z57AlPStkOcYE8+kBSAvQDTJl14As5cOFSHyQNMZANLjM2GYLYabJ+F8DLvlKr vlkjfis54vqrmPM8RtrGyYnpRsDSRnifDWtQ7XutA2xaGiidSq0hlefldZbMyjWWJnhI YkgCwuzAvC7bc6Ukz5181ZfO+/iC8FhCJxkzzRRuhXB5puGA1xeNxYwkA1/cEr+LAiq0 EDUQ5nQOqE0Y7SxslHKGCrwgD9rf9LfP/vF4NGc9CUu0tHAv0Q8n77H5p8xpO60E/xXA ojeg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1744046716; x=1744651516; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=f4fLZ22f7JoRp4VTn7PF6r/KMIOlDWHlEUpf6u8IrmU=; b=Hmcb+cWMO4olVgySLkcOFjKtnAdr1BdvGsXrV9hf0HYVFVQCisanslmSaGFZT8WwnM evzVoEQHGgGma0MZ1QtYziadEyXFW2tWDPOYBUpurqATZkKfWQvA1aqkxwdzWFr1NalP HK3SfYV8ehC+gg4AEm6RN/iRNwC12g0Hx7y+SHxdllWOlAxk6tNc/P67Y6W3IF/GL4jI 6MSXV2meaKJYcOsCKO4UKqaxv6dtkBm4hgXNkbgL1t7J+TMSAdS2lc3KjGT73XSqZV4H sEZiKMtyymPeTmWgGB3B22ULpCArV+2sjRBWYaqYDNtAOc+6cU78AbM7GBQA8LjlCAMf cQTQ== X-Gm-Message-State: AOJu0YwGkbVEE+HEq3e+2n/68E5zPqMh5FoUndea57EQl0jMp1SClcW1 J1TUtrHwrysxwlsFqgHWReJm+UDYJqls5wEx3Ev0gtaHg/nn/c4= X-Gm-Gg: ASbGnctMqnttOvMfAjnDb/uUoPwGM18TPC3i1vXmIJHvF5A0vD043zDOLdtDqJ37fSf l38L2RoxQR35+MVqrZTC35XWIDDhRfeyKnY0mI0UFf6xhb1gjmOt6KihBO88hJEOi5U1eeg0y8T 2lJ+DyPgJewW453xmXYEKN7PnHC5p8PuZHGCnv9M8+vJwXBeN9GQasDrkfeEfzsIzwkbGq5e0ch +8cByMgRjzJ3TjzZ1GMzVFt94vs13pyOAh5nLUkjdHjQGwfUUvi68u6LPVcJWnXik+yixW3R+cN md51ZJx1ICYw94Rgjh5jToqSdbjVhcE8kucNHDLCbmmeprKD3YOQ2/xlEVROhbTn+pvI6MzRM0o AzrAHo2KG1u7Z X-Google-Smtp-Source: AGHT+IFzj49m/3Gd5sc3CTHC+dzGmYcf8v0ZtsAAhQ6pAkDqtSqP0ulnFvgdbnfi4hQNpKweFJcmgw== X-Received: by 2002:a17:906:6a22:b0:ac7:805f:905a with SMTP id a640c23a62f3a-ac7d17d8758mr1128924166b.28.1744046715642; Mon, 07 Apr 2025 10:25:15 -0700 (PDT) Received: from localhost.localdomain (generic-nat.unisi.it. [193.205.5.2]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-ac7c01c0fb1sm790193966b.179.2025.04.07.10.25.14 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Mon, 07 Apr 2025 10:25:15 -0700 (PDT) From: Anthony Wang X-Google-Original-From: Anthony Wang To: ps@pks.im Cc: git@vger.kernel.org, karthik.188@gmail.com, shejialuo@gmail.com, christian.couder@gmail.com, shyamthakkar001@gmail.com, sunshine@sunshineco.com, Anthony Wang , Anthony Wang Subject: [GSoC] [PATCH v3 3/3] t9811: Change `grep` to `test_grep` for debug output Date: Mon, 7 Apr 2025 19:25:04 +0200 Message-Id: <20250407172504.50849-4-anthonywang03@icloud.com> X-Mailer: git-send-email 2.39.5 (Apple Git-154) In-Reply-To: <20250407172504.50849-1-anthonywang03@icloud.com> References: <20250405103718.25160-1-anthonywang03@icloud.com> <20250407172504.50849-1-anthonywang03@icloud.com> Precedence: bulk X-Mailing-List: git@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Change `grep` to `test_grep` to provide helpful debug output in case of test failure by printing contents of the non-matching file. Signed-off-by: Anthony Wang --- t/t9811-git-p4-label-import.sh | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/t/t9811-git-p4-label-import.sh b/t/t9811-git-p4-label-import.sh index e69dae55dc..e9c2aad2aa 100755 --- a/t/t9811-git-p4-label-import.sh +++ b/t/t9811-git-p4-label-import.sh @@ -96,9 +96,9 @@ test_expect_success 'two labels on the same changelist' ' git p4 sync --import-labels && git tag >output && - grep TAG_F1 output && - grep TAG_F1_1 output && - grep TAG_F1_2 output && + test_grep TAG_F1 output && + test_grep TAG_F1_1 output && + test_grep TAG_F1_2 output && cd main &&