From patchwork Mon Apr 7 19:50:51 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Frank Li X-Patchwork-Id: 14041889 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id BE573C369A1 for ; Mon, 7 Apr 2025 21:47:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:MIME-Version:Cc:To: In-Reply-To:References:Message-Id:Content-Transfer-Encoding:Content-Type: Subject:Date:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=fBhEmQ+5keqgx7M1lTMSB3Zen5LLbLZOcXbwQxpRbuU=; b=i8brqqPs5zvf3DKXyPUiWb98hT nB7/h8+WvKtNADv3+kT5+9QWET0Y6yLzO6ruac9jdr9ar6mHXBT1Mge70+7iXr+/XWOVU1JY9xfKc JXv16ZdoSDSpmd0erNlJ6rIsOsw2v+RDvBgKjo5UMXHvuBY6+2W8D9fNja33YUVAkMSlsv11omKEK OB00Ir10Hn/LrVDwG3IlZpUZZ5Ffe8xaKU5PoR+Xqcm2Ofa3+ynlITd3L+GKT9OmTVan/o4vU4zY+ KC2k+1dkw6ufER7K2mCaT5kaUVjGf+gAeWgqdox6i0pjqrg8wj7foALCcWAAGYLujU2N0kNR+TkpP O9nzXxqw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.1 #2 (Red Hat Linux)) id 1u1uJj-000000025fX-1hyk; Mon, 07 Apr 2025 21:47:43 +0000 Received: from mail-db8eur05on20602.outbound.protection.outlook.com ([2a01:111:f403:2614::602] helo=EUR05-DB8-obe.outbound.protection.outlook.com) by bombadil.infradead.org with esmtps (Exim 4.98.1 #2 (Red Hat Linux)) id 1u1sV7-00000001sMJ-1vXn for linux-arm-kernel@lists.infradead.org; Mon, 07 Apr 2025 19:51:22 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=suynrumez5XVDqD4MTEk4qTYwNZUr+tJa8sZG1WD2orJg/Ya9cHOn+/qN00jcUNHUKgbh1aEF9m8pugNTR4V6agHEr4farz2mF0mYEN2HZvOVCc1OrNMdWVJdjukzMF6D83wkljtlAOvPE+4BZTeXytjffGx3jZE36/Tw12jPRNWEDaBOE9KR9K9Wj2wA16+5Tz7IcGXkxiaiJoEJx1Kl61QhAyEjmvtE7E8eeW/yP0YJUpVaWjpQfWH7GxzZU7IMIFyHEMqfc3jb+Cj4VGzOpAksxlfSEgypBDQFXqANriUK20LskkOsoV5j2pgcW/3jucrSbB4iUKKOnRmRjwJcg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=fBhEmQ+5keqgx7M1lTMSB3Zen5LLbLZOcXbwQxpRbuU=; b=gJMs0Tyfc5PuYpDbyI0hyuKyWPm97c4+CgQFwtELEBJdz9COzlFnLQtEXJtxqWvYwM0qiAvVTcnGuneD5CoBtitU1c2XqUi7oPiJ4PYgRqBeRNiF+VleLPuGri3DUJ8t2OIx/ydMf4h626f3FmCQAveRRSRg8F8i9R1RDfjJNnm8FvATWu3B0rKQADetAHuJ53JGquoE/q+cz718KCA3OSSRg6r/upOipYyaany6ruOhmwDWLyNdJyDLPVAGrr/7E7AWqKQNrbttcdz3kInwilY+HKA/UQWJkFqgT9PqiYmfzy+NAC0eYl8abUzb8m5ii6fykNrJx1xaK64QeKCDaw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=fBhEmQ+5keqgx7M1lTMSB3Zen5LLbLZOcXbwQxpRbuU=; b=U+3C8QAOF9zkv0IUDe7h1pa5BPlZf3eTodVFeFCBZyyKoj0j4K8WlDn371kvQ0W7Sg0E92o5rXOcrk2gCVJf4usa1AoTJLXx7uYsOZpTbu/F1aCAoiFflQnoMlfrI16EXsfUmr1sJehNdwkcv66JPO3FsOi9CxZ8QyZED8yJYSgSqqHCIaL5aWEOHvrSwCR67eX1GUlU+DfZsJnwAca+5bkivSQOFEP9Z4jSGImDTrSCfudSTRs1+ezrs0djfancbm+fH/M0hC/b08/+LrPEloOg7pt1M7ZbJoCkunmrsLnz2VL3N+3oqzw8/KHI38Inq6w6mnaq2zoC1LInE2KhBg== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nxp.com; Received: from PAXPR04MB9642.eurprd04.prod.outlook.com (2603:10a6:102:240::14) by PR3PR04MB7452.eurprd04.prod.outlook.com (2603:10a6:102:80::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8606.34; Mon, 7 Apr 2025 19:51:18 +0000 Received: from PAXPR04MB9642.eurprd04.prod.outlook.com ([fe80::9126:a61e:341d:4b06]) by PAXPR04MB9642.eurprd04.prod.outlook.com ([fe80::9126:a61e:341d:4b06%2]) with mapi id 15.20.8606.029; Mon, 7 Apr 2025 19:51:18 +0000 From: Frank Li Date: Mon, 07 Apr 2025 15:50:51 -0400 Subject: [PATCH v17 01/15] platform-msi: Add msi_remove_device_irq_domain() in platform_device_msi_free_irqs_all() Message-Id: <20250407-ep-msi-v17-1-633ab45a31d0@nxp.com> References: <20250407-ep-msi-v17-0-633ab45a31d0@nxp.com> In-Reply-To: <20250407-ep-msi-v17-0-633ab45a31d0@nxp.com> To: Kishon Vijay Abraham I , "Rafael J. Wysocki" , Thomas Gleixner , Anup Patel , Kishon Vijay Abraham I , Marc Zyngier , Greg Kroah-Hartman , "Rafael J. Wysocki" , Danilo Krummrich , Manivannan Sadhasivam , =?utf-8?q?Krzysz?= =?utf-8?q?tof_Wilczy=C5=84ski?= , Kishon Vijay Abraham I , Bjorn Helgaas , Arnd Bergmann , Shuah Khan , Richard Zhu , Lucas Stach , Lorenzo Pieralisi , Rob Herring , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Krzysztof Kozlowski , Conor Dooley Cc: Niklas Cassel , dlemoal@kernel.org, jdmason@kudzu.us, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-pci@vger.kernel.org, linux-kselftest@vger.kernel.org, imx@lists.linux.dev, devicetree@vger.kernel.org, Frank Li X-Mailer: b4 0.13-dev-e586c X-Developer-Signature: v=1; a=ed25519-sha256; t=1744055467; l=1529; i=Frank.Li@nxp.com; s=20240130; h=from:subject:message-id; bh=ThyZOhwaDsp4V1j223U0prTZIbMrn8Rf6YEorwRizOA=; b=o1HYfMoY917YNLPLCMC0xmqaTJLB7tkp+9gfD4zitOgYHeNgY5jDb9S4aRR4yVfoZWdB7p04V jm05nDxbmuGBzq9qWDFiyr4WgDlK13UJF39OZnkUfzcBivybgc1Uja1 X-Developer-Key: i=Frank.Li@nxp.com; a=ed25519; pk=I0L1sDUfPxpAkRvPKy7MdauTuSENRq+DnA+G4qcS94Q= X-ClientProxiedBy: AS4P189CA0041.EURP189.PROD.OUTLOOK.COM (2603:10a6:20b:5dd::15) To PAXPR04MB9642.eurprd04.prod.outlook.com (2603:10a6:102:240::14) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PAXPR04MB9642:EE_|PR3PR04MB7452:EE_ X-MS-Office365-Filtering-Correlation-Id: 389e9db2-7142-4a95-13e0-08dd760d9066 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|376014|7416014|52116014|366016|1800799024|38350700014|921020; X-Microsoft-Antispam-Message-Info: =?utf-8?q?7Tg7TjnlzCb5gnlPodaRpvq1bJ69kM6?= =?utf-8?q?qMAqBw9B5h1CfQaz9VEzu7mc9brExWMzrQ8zrx25ATMt1hdpBFCqu4sG24/Wexd+f?= =?utf-8?q?aOKPdw9OaFJ4BhQBo2CtudciKsecfdvuoznPu47ML06XZM2MKhbs+KzfqJHod/tdq?= =?utf-8?q?L1tfXoVqOWbE6jeHcV4r5f5YXJsyRfb6LEiropRboi0psTBxIZe6m3d/4TdcRwExF?= =?utf-8?q?EoQwVXP3K3CyteZD6TQOvDk6Zky2B+0dypwWgpmlCLxXrtc2lZtviMBErOPWSK7ev?= =?utf-8?q?E5aoQ/uN0oR6K2rTnfHThlFOeBj4gYvDj0mn8fkI6TGOprTVdeOLFuyDXgm0+hDSw?= =?utf-8?q?nUtWsxpns2XOSlDMCo2BjKMZtvW1OQ+9z+cC4u97x8rEMBFbczRnE894BT3fO1Qx2?= =?utf-8?q?E6+lQyvYzrNV7eRyuSxkZYeR/86UqR1VxZ06yybM8TCadsAXpLXEA4+IeyISBL7xK?= =?utf-8?q?1ELTgnJbBJHBrwv3xOYfROCsvq7lT6Z97M9YSwP2V6DxHyqnod3JkTkXn2A1noKOw?= =?utf-8?q?OOeqVQc5Ifzn+cRESTtFVCQ3le7Yes1zwgP0fx0BOlBP7Pr/DRQjlkk7J92Qr8zZg?= =?utf-8?q?w5a59hg9VvKq4qVrXylEcCMnb7a1DId45ci51+BpkiFOkoKGFrKlOCe1op++MsHPd?= =?utf-8?q?Dk9K8BXkADfKFng88aH39/WkVmGJMJenTUE96pTwhT4NG4LQnLuYnDOXeV+awkw76?= =?utf-8?q?1HHwUiyGxMlP7RgivftsY7C7G4jfxa3HdaGZDbIk/eScKqbh0w+hgRuj1eX+0PcYD?= =?utf-8?q?mQdOL6NLUHzRWwhSPYjQThlVmolqorCX0zUprSIzft8wCTcndAeWkqN1wy8lX40G4?= =?utf-8?q?PmVNtAaOTKji7+ZoFwQlk8Asui1h6t7QHpKZSQaZSvAyaXt/4yNdg9FmoI3p3cmUP?= =?utf-8?q?8bbZQ6vNuqowTa2RzHQfKNSUS146LjyT3xcumQpRxTzYNUU5G5FmziIGVLoK+Iy78?= =?utf-8?q?o3edo8xhdfzR8cz0V5CJT/ocDRmaDLgE6GrMR8bTa4MOUrmfKlWIEqOmBLSW2VHqg?= =?utf-8?q?SwD8QV5l8/NW3bzvn7Fi2jIbkQsJuxz6fOQAaKvmGk79BU7MyWpIa3EzussHL1dlu?= =?utf-8?q?jaYwyoad6c2wDUKg8B+m1MfTwwyG7WIpO2qnPvfST7sSB4RVXL/AtywrWXWWPUSUv?= =?utf-8?q?BkpjFMCt3vB2mBgW57BNqaF97EBOnPk0ywiKkRB5aUOCcS6vOrMWM5sIIFFHJc78E?= =?utf-8?q?6NWyYgYZ12tTE5UdvZoGCQSfjnatgbYm4r3QK0/JU4qsn/k4XwB/JZEFvveNYemKB?= =?utf-8?q?v4VQZzFSvVMyAJQLeXNVUK9p/wpSP6lkAKhe9yvrHJua1EarU2fGUcPnFBdYs25QR?= =?utf-8?q?bMExzI/GgUJ3NHQ5K0YW0MGUCDQKjBr4iJJFwVfqzSUu4BUpu45FkiJKHMF4L7wvl?= =?utf-8?q?HdlIj2gjayr5ofTmYcJ+0JIQW54epZkRA=3D=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PAXPR04MB9642.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(376014)(7416014)(52116014)(366016)(1800799024)(38350700014)(921020);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?q?AMQ5jOrJdhQoEGQsAwFgNtiU/8nw?= =?utf-8?q?TZm38eOQvW77CJoJU5QezCRxJDYjV3nyLqid4N2/sd7KOxvA88hifB54LIQpBJ6I4?= =?utf-8?q?AX403d6isvNqywgYvgEczQT6UMw+W+43cWpEGLfGeyktIvMVbYjVpz6q42TFtLAyV?= =?utf-8?q?+2m+8ziUwkCGYS9S3qDA4F4pj+DLgbIN4mXrYE9xIZkaclUb5A+17jUvCCgBQQ/+8?= =?utf-8?q?4Aa8ZEi7HaC25446R+iIa8bsuKNEz1FTXeX1sGRMHkf2LtYCmV7Nxc8LhVVYpxJ62?= =?utf-8?q?DPXfDPuUMac7n9UcB/N6DumVO5RggKsBjM3/3OGy2qgTfJvurWc19LTlz3F4swx3d?= =?utf-8?q?PNBcK4FdQ5Hvq9TfHPDuzYDv5yq/SVMxG9jVvBcbEQKxF0HTiaWm6qCyxJubJDfaZ?= =?utf-8?q?6rKZAUiDDDqDgDf9yFr73qEJH2TfbPiGQ+FPAdLLl3IIx6perTaZFxfAE/V0yymqi?= =?utf-8?q?QlM1/l7YY4k40zaaeaGtsDA/0z+NvvXioe/vNhrQzNWudzEoSGEWTmyx9ghBX5lwQ?= =?utf-8?q?aM5gNTih9JfYdkAIRzvEB1fCIIDzV2GNJe/2EaeqC+W+NM+lWsBp62sojo4KyfLjo?= =?utf-8?q?0li7r5CWaI6yWp19R/FXb3Fvlff+VQ3KxG0ibJnQxHPJ23cQMeNdJoy7cTzDFBAfz?= =?utf-8?q?oNMg3CWq833kqgejCr0N7lioDl2nH9PVIXYaQgStuY0fHqlPF39/qIiJWCvrtq0ml?= =?utf-8?q?FFXA8cM4ob3gp6yrI7t8/jBFOGIWhvSQ9KnpRLg5EcDFi4w8bXqa6HnAMG6QK0+sL?= =?utf-8?q?Jwa0mCJ/IMp+XJyFHpc6qmPf8j3joaQUwVLt3/QRxnh1jONlQkSTeJgbyxjzFM5gL?= =?utf-8?q?pa8Xt3QoiGETPOs5BKDfbdi7UD62ojlfG09lv4x9cw/BO++1IyLyaopbS8Z9mSlP7?= =?utf-8?q?Ijhhe1D4Io5D61yrc746ijGjXybldwh1cqiDi2uH9HB9cFCDFMh80/I+/4nMupERb?= =?utf-8?q?klavlxrrnh4HZWxelJQOD/iEGU4ZhRJng+tIle/aZuXTF2NTi1OF10ecCEoi1Uysg?= =?utf-8?q?QXMWOyZaWFzVl/EpqkzlhV4b0J0okmNu54szdPUyPbQyUG96SHd3xlfYfmvX7u65K?= =?utf-8?q?CFBV2FSGOV0gyLheaWKUN5aHwpEztpTZA+k9QPiOEf3dmQcslxom20vGTeS9qogFK?= =?utf-8?q?aevoEpJy2cadfnW1zZ6BJzhf0nhbWskTSTmJLM4YbFjFSQTKRJcc73SFTrDz6/S61?= =?utf-8?q?qw+wkuj0MZSRe+LgOTBPIiUNRB9ZZ8qBjMNtSYG0HvQD1lFFWl4INI5PHbYuHCg3K?= =?utf-8?q?7kO13u4PzEZGTfzLT8ZuuQY2au2pPqnrl1dCn2Qq7Zt8u2TZ5B6KREPaeDrtjGSQA?= =?utf-8?q?L9Odx+SCuLe+14nohLJb53Gqb4JIeZbIm/rJDZIBJzv4TQd+TtrIjUdCQa9nNtta7?= =?utf-8?q?ifTk0xDV6KU6dcklmkkp9Q+xpulWOttL8OZcg9LialvTPTKfd2dV8AmrMs2KPEAhc?= =?utf-8?q?B2WU6HbTNbKxxHnm++8o+N9YnHGxOb3B3x52BRNXwdt4UuZ2RV+iHNzkwl42JR0oj?= =?utf-8?q?bDx5+Tb5vsIz?= X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 389e9db2-7142-4a95-13e0-08dd760d9066 X-MS-Exchange-CrossTenant-AuthSource: PAXPR04MB9642.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Apr 2025 19:51:18.7027 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: EIXUtUqKHbQOvvBoGjip4EgMQnizhjgZh7Lt3wd0QrxCtA+1NWHhWB3ZXgIE+4MQRLPQIszUb/MXw4Zi/K/apw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PR3PR04MB7452 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250407_125121_493387_92E029A5 X-CRM114-Status: GOOD ( 13.44 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org platform_device_msi_init_and_alloc_irqs() performs two tasks: allocating the MSI domain for a platform device, and allocate a number of MSIs in that domain. platform_device_msi_free_irqs_all() only frees the MSIs, and leaves the MSI domain alive. Given that platform_device_msi_init_and_alloc_irqs() is the sole tool a platform device has to allocate platform MSIs, it would make sense for platform_device_msi_free_irqs_all() to teardown the MSI domain at the same time as the MSIs. This also avoids warnings and unexpected behaviours when a driver repeatedly allocates and frees MSIs. Acked-by: Marc Zyngier Signed-off-by: Frank Li --- Change from v14 to v16 - use Marc Zyngier's suggested commit message - Add Marc Zyngier's ack tag change from v14 to v15 - none change from v13 to v14 - bring back from v9 and remove fixup and cc stable before it is new use case. --- drivers/base/platform-msi.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/base/platform-msi.c b/drivers/base/platform-msi.c index 0e60dd650b5e0..70db08f3ac6fa 100644 --- a/drivers/base/platform-msi.c +++ b/drivers/base/platform-msi.c @@ -95,5 +95,6 @@ EXPORT_SYMBOL_GPL(platform_device_msi_init_and_alloc_irqs); void platform_device_msi_free_irqs_all(struct device *dev) { msi_domain_free_irqs_all(dev, MSI_DEFAULT_DOMAIN); + msi_remove_device_irq_domain(dev, MSI_DEFAULT_DOMAIN); } EXPORT_SYMBOL_GPL(platform_device_msi_free_irqs_all); From patchwork Mon Apr 7 19:50:52 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Frank Li X-Patchwork-Id: 14041888 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id F372AC369A4 for ; Mon, 7 Apr 2025 21:47:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:MIME-Version:Cc:To: In-Reply-To:References:Message-Id:Content-Transfer-Encoding:Content-Type: Subject:Date:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=GR0Z1iTOQebA6NDkRDEaFkcBL+OLXn2bv7Llb/KWBuc=; b=zX0vJ0sMyl3WGDtAzC3TxDgTj+ La+x5dTEzbmSMZXWdZCMdekxNndMrlWNLGzu6x5n7SBqWOhSXAWmEPkJGrdi62CXlZ2WJhZp2OU69 oemILPzdP0qhM3i/KnLMlXIqEX2FG5hSVhu5TkCoTGp1i8fX+5RztOc5D3eyE1CWBlycOViWexeHa Y0Pfk91KEnYVeaBzLLHl2/BHTlDcvqCGUrw6XLeLJh23K6sn+APwhj1pPPJu559/6M9+mEH4dXbLd AX3AH6coJuh+91qDZ4mtDoVa7VI4dNzDHIGaGkNPMyS+Qu/unQlwW+pKfree4f4YeNinrQxnE1PKF tmET0Ipg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.1 #2 (Red Hat Linux)) id 1u1uJk-000000025iF-3GWf; Mon, 07 Apr 2025 21:47:44 +0000 Received: from mail-am6eur05on20608.outbound.protection.outlook.com ([2a01:111:f403:2612::608] helo=EUR05-AM6-obe.outbound.protection.outlook.com) by bombadil.infradead.org with esmtps (Exim 4.98.1 #2 (Red Hat Linux)) id 1u1sVD-00000001sNP-0BVf for linux-arm-kernel@lists.infradead.org; Mon, 07 Apr 2025 19:51:28 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=ajtx3Hdx/wl6XYGT59QRTr+M7rtCjcjtqpDFOZm/7s8IDXSLMbmgPC2HUQttROQcv8jYrZQBlGTISZzuUOOZgl2UC3W49/tXsM3C8IxYv6K6JfLB424iVuccrYYdkyRRP6SogevUPfkQzrHEwsQX+KSjsvYCtuFafARSPpGafr6FgGkdv9XdoJXkerDUvCI/2TXUv3sUz7Vg/cD5/lC03s7awlFQ4gW7/+GrkfnoaWnM2Xek5UYI79T466x6Vxet6HnhzCBUfOpzGDngZl0ceNhAZ9eeAcpJ7SuKEewrrOdkspPACzvaSBkk2Cu5ypk6CEzjv1ddjBSo9j4uSWSZRA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=GR0Z1iTOQebA6NDkRDEaFkcBL+OLXn2bv7Llb/KWBuc=; b=sh2NjDUZMQInp+dUm+dciQfghigXdGOUmpcu+5au/ooerT2hx93Y6rSrMl0Syn5niFMVjFzm4qBLMBQ6o5VF9nj+r0jfaUPwjRF61CXbJudpWiFun8TRlQaSTOAtic2Iy9I9S7nOGUsFfegQ8aZ33yfBLcpkwPnHWZ+rjz2HnrcECeqglNnQH7OyP0w1tm0wgkdGX69BqghykyVbhwGj5qGgjMh3tE7tpFNBnJ5wvbHCZco7v9CskoF+DKAtvHWOrdpIkqAvlzNNqzN3yyvT6AJtMKzNX08WBn1Hz2UYz3ocsUE0Q5NMg3PrM77S/DIVZy6rBErF7ddhgwrxxO2CdQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=GR0Z1iTOQebA6NDkRDEaFkcBL+OLXn2bv7Llb/KWBuc=; b=PQw/JY/OqY051e32NRI2x/SHQyIcopDr1B24qL8iyf8kI9GFx0fOu4PsO5Z7h0cJ5RMTAc2YUji8vZUdia50tqD2Rlk8QyaOt/jxcHlR/M3wGeEX3a15eH+wwxZW2oW53jyrzr/XGo9fpzQcBeKMOKBJ83kFJnbJJ/F6qnbK/d1HE3yxf9nm11FF+2ifEJNLIlEzdk+yAGN2jHE5xxeQfNhgiJyzyIw9owpJXjOwp9YPqYNpkc0dk+O8zHarZBYs1cAJBDp4mOv4DkgWJwKv0KTz5oi0xWVpUjIm3g7Bg6LKvfziqesbXeoREvqt1E00XESEpEWUj5sxRskmjNcaZQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nxp.com; Received: from PAXPR04MB9642.eurprd04.prod.outlook.com (2603:10a6:102:240::14) by PR3PR04MB7452.eurprd04.prod.outlook.com (2603:10a6:102:80::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8606.34; Mon, 7 Apr 2025 19:51:24 +0000 Received: from PAXPR04MB9642.eurprd04.prod.outlook.com ([fe80::9126:a61e:341d:4b06]) by PAXPR04MB9642.eurprd04.prod.outlook.com ([fe80::9126:a61e:341d:4b06%2]) with mapi id 15.20.8606.029; Mon, 7 Apr 2025 19:51:24 +0000 From: Frank Li Date: Mon, 07 Apr 2025 15:50:52 -0400 Subject: [PATCH v17 02/15] irqdomain: Add IRQ_DOMAIN_FLAG_MSI_IMMUTABLE and irq_domain_is_msi_immutable() Message-Id: <20250407-ep-msi-v17-2-633ab45a31d0@nxp.com> References: <20250407-ep-msi-v17-0-633ab45a31d0@nxp.com> In-Reply-To: <20250407-ep-msi-v17-0-633ab45a31d0@nxp.com> To: Kishon Vijay Abraham I , "Rafael J. Wysocki" , Thomas Gleixner , Anup Patel , Kishon Vijay Abraham I , Marc Zyngier , Greg Kroah-Hartman , "Rafael J. Wysocki" , Danilo Krummrich , Manivannan Sadhasivam , =?utf-8?q?Krzysz?= =?utf-8?q?tof_Wilczy=C5=84ski?= , Kishon Vijay Abraham I , Bjorn Helgaas , Arnd Bergmann , Shuah Khan , Richard Zhu , Lucas Stach , Lorenzo Pieralisi , Rob Herring , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Krzysztof Kozlowski , Conor Dooley Cc: Niklas Cassel , dlemoal@kernel.org, jdmason@kudzu.us, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-pci@vger.kernel.org, linux-kselftest@vger.kernel.org, imx@lists.linux.dev, devicetree@vger.kernel.org, Frank Li X-Mailer: b4 0.13-dev-e586c X-Developer-Signature: v=1; a=ed25519-sha256; t=1744055467; l=1874; i=Frank.Li@nxp.com; s=20240130; h=from:subject:message-id; bh=p7gntWoxGh4gHuQtzBxv9euNYS3wHZIeRIkw2TEkLdk=; b=zG4QdGGdfqxDzshMU7Ve7oQJlFKli2a6ZVYWvGb/TGaz4n0XHmKNqynlcFyI+BEZ72WuuWoZT CDPTrvS18HQCCFgZIu/vituhjD+febT193Yu6L/YXCad3GJEQqEWjlZ X-Developer-Key: i=Frank.Li@nxp.com; a=ed25519; pk=I0L1sDUfPxpAkRvPKy7MdauTuSENRq+DnA+G4qcS94Q= X-ClientProxiedBy: AS4P189CA0041.EURP189.PROD.OUTLOOK.COM (2603:10a6:20b:5dd::15) To PAXPR04MB9642.eurprd04.prod.outlook.com (2603:10a6:102:240::14) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PAXPR04MB9642:EE_|PR3PR04MB7452:EE_ X-MS-Office365-Filtering-Correlation-Id: 3470ed2d-29ea-4c20-86b7-08dd760d9392 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|376014|7416014|52116014|366016|1800799024|38350700014|921020; X-Microsoft-Antispam-Message-Info: =?utf-8?q?BvVQUq0P6pFGOs/xv3TADyeXzC7OLJc?= =?utf-8?q?r5QohTQK+HTwHVRRBIogQfW4U+mtSXCE301v55LidCPcGuQIQgPDoze/vHiXetrjc?= =?utf-8?q?AtQ4uH0wYNK0KErcgrzA7wS5CqNuWU/ylJqBz/8kAOmbLLEkXF3cOuVDC5Ug4lHRZ?= =?utf-8?q?lbQ36M0r3MCQMB6IlaTmRdsXFkLO87f4kA0f3CqYNK8D1Bhzi4NI9poWNl7ppIM5M?= =?utf-8?q?JIcujnxextSDch9MJtTxvVDafwdco6Idjx2DPISkKK5YGWgz6HA+aNrMt5tp7QRgf?= =?utf-8?q?FIIPpewLQ/UacMf6JXrOgN/ExWKJLcVtzi1Y+jeYsCvoQKlE52PgDEzhkqcO09X76?= =?utf-8?q?N6qORsIN6Y7+7HTONGLF2LJ3heMbg5WY/Exf5rkhodihOVjNqN3wo2yHYl6sTmlIg?= =?utf-8?q?7TtOvVLMaLwedlA8Muy62qptz0jdtr9RjMcHPsFkXHKSBRjREiSk/lBXtJysUtpqL?= =?utf-8?q?vVM3qF8aI+hbSb1uzoiCncPDon8g2wBvaVLUvjKxDW3qgI74qkFKwnEDRKI5AdMci?= =?utf-8?q?iODJWUA7bWvAzLOzeSnxwaj8Cd8SylJVhJ3yRYm/DtHTdHhaaKPpaeVrjMOXkxV/r?= =?utf-8?q?q0Wer7JaISYSIvisBmj1meNUwtrgoOFgpgfBjgz8jwKLcvygsr+kUnvqFITCfz6Z1?= =?utf-8?q?0kE1BySSnysQTidhNkoZwgXug9ge0fQreMZA8UCOi4ezKDuxuPNVF3JqkBU6Zug5G?= =?utf-8?q?Q7hmsxI0p5Z65dk/RkTAnVnJW6i1Y+rPRqcuoCe/UFb3HiomiMtgVOKSk5MiV/Jck?= =?utf-8?q?1m0BFKg27Gh/uhkmmUrBFGYjegzYeIv06nq3icdegPp5lsCDXsAXog0k2dn+SqaS2?= =?utf-8?q?/XQHJBSW68aWAy1RQJpNl5D+frYgRLySTtjk5LKV7FSZZR1J/vHk3yX8i7YqTom46?= =?utf-8?q?j/PWqtBsqMYpk4wCq0pSpwk5LR1Dyuia3pcruiMGarer8wBj22XGToZYSRGQXGN4k?= =?utf-8?q?oWoiDR2PROyPH846G86cd6fxNI6zC/B4CYF216hY2srMngVKNdT3bx3WH9WF6FM5j?= =?utf-8?q?4GRnBhJNXLEMNz1vQobfwaqYhbl5TKySmJWpDd/egkZgY/xTRHHFMw0CAVWWogfmE?= =?utf-8?q?2GcxwLBi4WlvXP90SNWm/txD4yy9AeZc7aJKfjQVTvkrk0x3cVGwYayBW24uwXuJ4?= =?utf-8?q?p7dY4x2pI6S1Rhxs0TZMh7MhnOjSDdo9gvX4/zxWQipQKVylIGpaZqQX4DV7l1ELW?= =?utf-8?q?YCSvql6aisET+7Jxl2t5q126FDMSsi4sthI+V/t2D/+EqGI+b4k5Cw4id/yUl6QOV?= =?utf-8?q?a42J3hxCdGc+wD9UwqxGNCk6rJAhcQ3udH8wsA/4fMMSbzeay+ZzNMdenT+1aZHg9?= =?utf-8?q?8SgIWBaczwOCNzVGPQ1fz7xBfQwsCfzH4rNxMdsYlwkT6JwBH0biCvxWNlhwME8e+?= =?utf-8?q?I28l7eu1jPSSjK5EPAga9JmgGUTz4D4xw=3D=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PAXPR04MB9642.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(376014)(7416014)(52116014)(366016)(1800799024)(38350700014)(921020);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?q?TIovcYaOsPhWcuEJufElpD1mqz8C?= =?utf-8?q?eQ60PEXzsKPz86ffjTMFw4zj5aH0yIVog4Z9EnsJshMM2Rbqk9F+SZ0rYeB7KKOL6?= =?utf-8?q?y5SNTp2bSOBcqukG4lfCDiRtHWkX9OF/pr1j1/krFpscPDAvOC+GKL7TGGUfwn33h?= =?utf-8?q?i8LWf2SvSpvxSw6Mv3aodv02agqUi/sJ3L9NTxF4qzZo4dc1xFUX9DYCm46yEthbd?= =?utf-8?q?AkNh37RC/WUuX8Xg6hsEII43olHDowngtbXnNxNT+11MkffrScStM/E12chV4WLKN?= =?utf-8?q?XTmR6XsXUG338yyDZgxWdNJIpEgMoA2o5dAQS5BZEd2YZDznp0DbgKbDmjr+kIZZZ?= =?utf-8?q?4x6Ngl+Au11w2k4yuT24FtQqNf8QOijyZVyxuWPPQaZQ1ydRDELe8zkV5DOq7ioxq?= =?utf-8?q?ell8OCmC+CQ4Md2fm3iCIUzlSecieOv6JhpZU4MbhEt9sXVyMa9P3iLlaMdVkZHxL?= =?utf-8?q?g9L+yaMoEC5SqLyC4zME1TlCkn0Lv2t9O70GuNXaff5BYvY/M/pl5JZlckJ7ZT4dF?= =?utf-8?q?pL0DkFxqr7+xuKDPpLYB0CWRrKPkJvM0u1eMQFfJ60WrDj/CcTkG1Kq7y4NJ/BS0T?= =?utf-8?q?ae/CBfoNH2Boo2Q9OxS0Z5aqHTA0IQorMmHqHtJ7vf/JA2fOdE/7rcyJg9n+h+AEr?= =?utf-8?q?aNoLwWUJ33mTKZmsbhrV/NjshBgjmsJAecz2k8MQpZRuYfD8NYZqbp/30+RStlwhN?= =?utf-8?q?/A1Mp2foCZ+IYMUSM9PJ50qKLMZeZoFl3FtmpMAncTW4Uxuv8DaBaM6X2+Nc+qf9w?= =?utf-8?q?533yP8twkqetQWgT8lMRJTm/BiB44mhEKgbk3qWFTtpFISBZUtAXKnNKpMQo13fcz?= =?utf-8?q?NtfIpt7LRhMMLHjX6okyZjwSYDkyDraaYRwzUfWN4wNCu7n4xlySGv8NCuO94zFs8?= =?utf-8?q?36AuyEzgfE6Chv3Z01dZ7xbC1SUe9dLKllwmB+yCHydvXyvtVGDXS7hMJEepjZc6r?= =?utf-8?q?+EOBTTkEJ05rLD1NEU1BeX98X11LHzApkJYDWD9RgwWn9UUbk18H93iHPkbYgx5KO?= =?utf-8?q?rdsEjItE/KfXB0lhRqAziX9sbfLdHS4m00P6bZp+X1NxQaye1cI0RXSomSVKbt1El?= =?utf-8?q?dHEk/FtDufFa3Qj7jmjXqs5NkGxRxRlZIXR4sTdsLQ3utdaTcGx+wBrDK1hE7wdi4?= =?utf-8?q?rqbcsuE3OHq+aXWtl7Ymj/DTRc8tTUhndT/UBsN2WY7RxRdqXDTnt+QypE3LH8qOj?= =?utf-8?q?MMbgjXc5UZc+ndZ5sPw7Fn/MuJ8k5GT47d/JOO36WesR/pugwlYOhbDggcTTX2yGP?= =?utf-8?q?UmeBG1fv9BlfG3K3gmdUiy2xRi1+yWgCy7NhZxqQ27e1MSjrXMHyuMHWK0BkAplRi?= =?utf-8?q?6+ynkMqV0Y95raHIBuMp1QC5khMLcEqPl/xL3DBc91u7sthLCfCeucN86Q7tvWpiK?= =?utf-8?q?Mf75PlnDg6Mq9aZzAPuOw/mtR6RtjSLBsx2IlnysS549qUqLQuB211F9AkmHEC8Ox?= =?utf-8?q?wGKkxnw6uxHBPp8guRpZ6nUeLVGBqk6eSGu82L72wv+MFQJAuN2H4ALv2dBnZQVkh?= =?utf-8?q?DDqFY8FrtRqD?= X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 3470ed2d-29ea-4c20-86b7-08dd760d9392 X-MS-Exchange-CrossTenant-AuthSource: PAXPR04MB9642.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Apr 2025 19:51:24.0193 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: om0VB3FGAcAxZ/EaaRFlb0Z5JKtG35bdnz47GG/8uDCfHUTmURSDwUhdxMvMv7Y9d8fiKzJ+p/NRCxSjFFdjww== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PR3PR04MB7452 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250407_125127_079375_D9322F3C X-CRM114-Status: GOOD ( 13.27 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Add the flag IRQ_DOMAIN_FLAG_MSI_IMMUTABLE and the API function irq_domain_is_msi_immutable() to check if the MSI controller retains an immutable address/data pair during irq_set_affinity(). Ensure compatibility with MSI users like PCIe Endpoint Doorbell, which require the address/data pair to remain unchanged after setup. Use this function to verify if the MSI controller is immutable. Signed-off-by: Frank Li --- change from v14 to v16 - none change from v13 to v14 - Roll back to v12 version because Marc Zyngier have concern about add DOMAIN_BUS_DEVICE_PCI_EP_MSI. https://lore.kernel.org/imx/861pxfq315.wl-maz@kernel.org/ Change from v11 to v12 - change to IRQ_DOMAIN_FLAG_MSI_IMMUTABLE to minimized the code change. --- include/linux/irqdomain.h | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/include/linux/irqdomain.h b/include/linux/irqdomain.h index 33ff41eef8f73..86222602744e9 100644 --- a/include/linux/irqdomain.h +++ b/include/linux/irqdomain.h @@ -231,6 +231,9 @@ enum { /* Irq domain must destroy generic chips when removed */ IRQ_DOMAIN_FLAG_DESTROY_GC = (1 << 10), + /* Address and data pair is mutable when irq_set_affinity() */ + IRQ_DOMAIN_FLAG_MSI_IMMUTABLE = (1 << 11), + /* * Flags starting from IRQ_DOMAIN_FLAG_NONCORE are reserved * for implementation specific purposes and ignored by the @@ -691,6 +694,10 @@ static inline bool irq_domain_is_msi_device(struct irq_domain *domain) return domain->flags & IRQ_DOMAIN_FLAG_MSI_DEVICE; } +static inline bool irq_domain_is_msi_immutable(struct irq_domain *domain) +{ + return domain->flags & IRQ_DOMAIN_FLAG_MSI_IMMUTABLE; +} #else /* CONFIG_IRQ_DOMAIN_HIERARCHY */ static inline int irq_domain_alloc_irqs(struct irq_domain *domain, unsigned int nr_irqs, int node, void *arg) From patchwork Mon Apr 7 19:50:53 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Frank Li X-Patchwork-Id: 14041890 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 3C645C369A1 for ; Mon, 7 Apr 2025 21:48:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:MIME-Version:Cc:To: In-Reply-To:References:Message-Id:Content-Transfer-Encoding:Content-Type: Subject:Date:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=Wvzvkawi1c4jyl+gIIApohWSfi73eTZ55zDdwaLFIxs=; b=MBJj2glhnr7tzH2N0idFF1H0gC A1pb3zizw50Y3vN9QNt895Mxqd935vdXU8H+8UsivM8dSLQdgJy9BxEjpOzo/1Ayih1j1HwpvKuCg 3xyUKyeoD/wGwLs6pLaaewL7SUi/MUeKR/Bmpy2zHcsu0AHwI85XXxrUDoOhdGDSnp2B1AlPNbVSW 5KOF3O19TDgp0+0PO3AtXYhJ+2lPVT/RdTZi9YbdH5a8rQASQzxenjGRzljXo3wkt/+YGzmXaN0JF hWx5RlyXxuDNApUAIPlC/IQTL9w/4D9A0pPuMKIOEW/vfgyx3VJxNc0Emw6RbhX313pqmF3F3zaWU BkQP7B/w==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.1 #2 (Red Hat Linux)) id 1u1uJo-000000025o4-0aTP; Mon, 07 Apr 2025 21:47:48 +0000 Received: from mail-db8eur05on20609.outbound.protection.outlook.com ([2a01:111:f403:2614::609] helo=EUR05-DB8-obe.outbound.protection.outlook.com) by bombadil.infradead.org with esmtps (Exim 4.98.1 #2 (Red Hat Linux)) id 1u1sVI-00000001sOr-2Ia3 for linux-arm-kernel@lists.infradead.org; Mon, 07 Apr 2025 19:51:33 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=yDcW3vFV1jgt2nJNvOoJG8Kv5X9e4+YZFpGsMEUcEyQWg7WptAgHz+Zz+lO0J4kiguQ50Y1Fy6I6B05EJWXGUMUTBjyxQBitlJC7qDhspng/DEj0dwIOsfMxsYX91Dx8PINh7qHcPX5nlvfeFFk+tIAwqoPuUG8UYGUxu1cCwhDg+VpjtXTQmfSSlfa/64cc93OGWeMMwSJJGrik4HKXZdlmj6XMU9VaHarC7wHbtQNA1fvyT7toeL1QGK69/Z0ZCIUatQyEOE0kW50tqVtaxTuYi8qaB3ra2ntpRC9vbKFW6+zOmDnR2kr3Zgd6AYDG2Ljcgbcxk9tm0wx1SIjJxg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Wvzvkawi1c4jyl+gIIApohWSfi73eTZ55zDdwaLFIxs=; b=AjxsyHuGONiW6Z1Sg9NZhuMl7bVDlZ1QkTWt1vbPaYWzWJzKWxzDe/EYhpt0Le+Ycmg9xKNE24hsFItMAXnu+AIa+MDOhFnLDwYhqqEK4F4+bYVf7VgdaqwRMvaf+oJivU6zQ1Ea+EDLcEzYY4/iglI8VFibXIpYvSdn2wyyE49uoDySrR/4jQNq4orJpp1vYOzAtVIY3m2bGCY6j+/IcDyxeLVzmSICWCn8zFV6BCZIaZSAVqagEHWy0TwBNm0aEPZhjZ06ZoPAuxLa+lLrQKkUVDF+t6MCuL91HClG6ovB2ba4q1wp0zQHyLvWCxq1f7NA0bMcj9GacWpsZmQZLg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Wvzvkawi1c4jyl+gIIApohWSfi73eTZ55zDdwaLFIxs=; b=ebPGrtVYxCDBXzrw3gAax2sNztAlDDVxXqSU6rUmgrkn3zvO7LFAyq53zhL+PYs+qr+B8mpzE2MC0DrUA+T/TK9KooaucZgGBjGL20g02CP0c9uRhHVxOu9GhC7jGnARmXhZLrLRaA1J2XNMCjOHH+F/E+3f5hWxT9qAmROqgdSintAve9QoHmP6UEmSJO4S5PD9I4LuzGqbXb88HfYaiU1gmzxN1GBn6z323mV860gtgQqTWfP6TeT5otPTjzfT6DWLrYguwuJN3s4/KZ8oP2XaPekPuKXdxQi2Mbu7ZAcWn7NQZs2mQ0q/7SkN3O/2SjydbGZNSUBuTkYEWwLczg== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nxp.com; Received: from PAXPR04MB9642.eurprd04.prod.outlook.com (2603:10a6:102:240::14) by PR3PR04MB7452.eurprd04.prod.outlook.com (2603:10a6:102:80::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8606.34; Mon, 7 Apr 2025 19:51:29 +0000 Received: from PAXPR04MB9642.eurprd04.prod.outlook.com ([fe80::9126:a61e:341d:4b06]) by PAXPR04MB9642.eurprd04.prod.outlook.com ([fe80::9126:a61e:341d:4b06%2]) with mapi id 15.20.8606.029; Mon, 7 Apr 2025 19:51:29 +0000 From: Frank Li Date: Mon, 07 Apr 2025 15:50:53 -0400 Subject: [PATCH v17 03/15] irqchip/gic-v3-its: Set IRQ_DOMAIN_FLAG_MSI_IMMUTABLE for ITS Message-Id: <20250407-ep-msi-v17-3-633ab45a31d0@nxp.com> References: <20250407-ep-msi-v17-0-633ab45a31d0@nxp.com> In-Reply-To: <20250407-ep-msi-v17-0-633ab45a31d0@nxp.com> To: Kishon Vijay Abraham I , "Rafael J. Wysocki" , Thomas Gleixner , Anup Patel , Kishon Vijay Abraham I , Marc Zyngier , Greg Kroah-Hartman , "Rafael J. Wysocki" , Danilo Krummrich , Manivannan Sadhasivam , =?utf-8?q?Krzysz?= =?utf-8?q?tof_Wilczy=C5=84ski?= , Kishon Vijay Abraham I , Bjorn Helgaas , Arnd Bergmann , Shuah Khan , Richard Zhu , Lucas Stach , Lorenzo Pieralisi , Rob Herring , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Krzysztof Kozlowski , Conor Dooley Cc: Niklas Cassel , dlemoal@kernel.org, jdmason@kudzu.us, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-pci@vger.kernel.org, linux-kselftest@vger.kernel.org, imx@lists.linux.dev, devicetree@vger.kernel.org, Frank Li X-Mailer: b4 0.13-dev-e586c X-Developer-Signature: v=1; a=ed25519-sha256; t=1744055467; l=1326; i=Frank.Li@nxp.com; s=20240130; h=from:subject:message-id; bh=nuOSilx0xFIrmQ7q/FNnVVZ6I8tKFEDBakFZ9GZOgfU=; b=PcUhYKWS1SR4vgc58OsEydvBMUyrg5N1ER0xvmGfhYNVqZQ5S03z9S36ypATFHJtO0kN34kiI DMPoU3Q27ZoApOv4RZ/N/UYv4jnfQXOqX/wn/9txpdibq9fe9cptYo0 X-Developer-Key: i=Frank.Li@nxp.com; a=ed25519; pk=I0L1sDUfPxpAkRvPKy7MdauTuSENRq+DnA+G4qcS94Q= X-ClientProxiedBy: AS4P189CA0041.EURP189.PROD.OUTLOOK.COM (2603:10a6:20b:5dd::15) To PAXPR04MB9642.eurprd04.prod.outlook.com (2603:10a6:102:240::14) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PAXPR04MB9642:EE_|PR3PR04MB7452:EE_ X-MS-Office365-Filtering-Correlation-Id: 69c3ff6f-92ca-41a2-d64e-08dd760d96ec X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|376014|7416014|52116014|366016|1800799024|38350700014|921020; X-Microsoft-Antispam-Message-Info: =?utf-8?q?MCZerYbVBp2bKBBqpp2gW+Z6sRZkaGA?= =?utf-8?q?FRL8lOBAoAXHX79wpIOUH0LlcCD9csyn8SAPhJblBU0R8AyiCg8M4MK4nE4WvHrX+?= =?utf-8?q?ittHGk5JRP2+jETb+rv+Ddd2jmnnCN94GFKGVTXG5xs/dB6U0DU2LWzY3EmbLNf+l?= =?utf-8?q?zBlP/dOX9rYcBRqOmgqsrB9JHNmX99C8ApaS+o79t1X0PFLY9bGuQzrwH2UqWLTOs?= =?utf-8?q?+IGNhCG9b6JfUNcPE5kM3TkaTCUXZGv9vHLTtDgadyH5wO0bL82Ax0y+9gndOf9Qk?= =?utf-8?q?tapi8fYh7CcySkBsHismAUGKBitNhpMn0ZyST/G8UBJScWNlw02NqmEQy4ca7kmjq?= =?utf-8?q?gbHf1WHBmK+HNJHQ91nBRczpPHUpyXUkS+tJMBA+4EEy8IV9X8OElSEoc+Npnsjtu?= =?utf-8?q?+i0Uewv73nHIerCEgNiHP0UP2f2laGkyaWFA6ewV5FeaCXmqq55TgOZwvQFR/Zb9r?= =?utf-8?q?DYVHtTA0qtbng1zC0kNYqLuqvUiYAT6RGpwn57jeFF40xJvIGyIGYRYMBapM83zP1?= =?utf-8?q?w7ml3cjy89Ow0gtchAlrLkZwdmbBxjKJOybwvo1S140JoCBQqySV78Bvnzh66bL3X?= =?utf-8?q?lUvbkDL77QC7gmEwqkh/ltnoVYZ506PZjChalq20jYof3T4/dZ78Mnmul/aOx8kvg?= =?utf-8?q?0Ygs2UgeQGaG8q/edoEwQJPTNj9oWB2Q8Syrfo6AecYwQ/ZKo9OzQeLUFPffjUZHp?= =?utf-8?q?kUIW5WDMnSlcRlzXkN9M/dB83L610gqHkmGW8WQXlIkSn/VHNi5nloCIiaMRz5LKK?= =?utf-8?q?Vp8mUURlFL9GKa1bALwK9n5qsiryHOwwFq2Fs8YoOugk9KaQArQ3NB6+DP2180qhe?= =?utf-8?q?MVNnyNYRU3AhWNlrekacBxtFXuTVy2iMQzndds5x783778rY85mYX6pYroEcVtUl6?= =?utf-8?q?3ZBGvan7u0xXKLOsDNr8fIYcz3zkt91lhNYVyJZhfga1AGe6O+L5gXRv8/B1VL784?= =?utf-8?q?CJ3L0a4aJezHddba+Ygl6Z18OM9NN3KsdiNLCXYkyJJgodsc/JCDX/pFpwMv4ljuo?= =?utf-8?q?LFD3tANA0DZJ64Gw0F9tHrYOkPMrAhw5qvKdyuU5LgQ/YIAkgvMzzu1AsfOwzikuN?= =?utf-8?q?YSFQ8X9fVPG0jrEaYuo+p33XM17gZXs2G/PuL4VnC/TpWQxVdbuHoWPhDAecjoRDg?= =?utf-8?q?gkAAbV64bXsXEXPLstAHdFeziRzqNT0fJmyzEZcd96vly3/5mVtNZp0ezSCSblbvd?= =?utf-8?q?UdXrtllq/FbaBXtXILrRakMWerMfagWZ2mab5AZS/NHp8pK740i5Jy4lullnXqzeN?= =?utf-8?q?S4X+Z0rX+vu+2m9UD1tfJVKYbhL9TbdxjkXbdqDSw+ttJdWyZ/q9DW7q7giF3S2z7?= =?utf-8?q?LJEc0DGuNqYugVb3F/qQRSOC8Jeq9K+XwwTFgICf3G5lT62phdl+Jr2rrOh+YRqFh?= =?utf-8?q?+YB4AQ8xEuov59fYswdchCJ+6ibJ/TtLQ=3D=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PAXPR04MB9642.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(376014)(7416014)(52116014)(366016)(1800799024)(38350700014)(921020);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?q?Y1n3/7DHiDrV7q9/yMKvzrzQlVIQ?= =?utf-8?q?HHFdqvidBF2jvbWHrz4DVHeonSLC4YEXBm6UwaOLHk3RXzsXYOprPN7n2jHwm02DP?= =?utf-8?q?rGqVouQ0Xy1kkcWZAqB9KXQ2iOnOZAxvbEYm4xt7+DT+vawty1ii0cAnfdKb+wpxY?= =?utf-8?q?/DLRgep+50YiDcLSNikDZrCL6P4IKYgYzJux696AOy24nFt3G9qjkJtnJtaM5aPy3?= =?utf-8?q?zPcxy9aZ7ju5FkNhemjDPe4hSPusRbcoJI0Zm4J0+eXpQ25xrb8l15OHCvVibDf9W?= =?utf-8?q?ak0LXZYsHDrIUMWt2WkeaeCPGX6R0vCD0oQWgq5/sLmRKfcrWvrk0/QFGg8htXuqF?= =?utf-8?q?5l4cYAlNTMoZ5w8pNjHPx9xDCfb+ngfTKBiT8my7hh2YHzlxd4NGzPyBYXPOE4pIr?= =?utf-8?q?P5ZZhISHPUCqVOxVwPaS9fQjqn2MxedoCdG6EuP8LuYFG2jSMPp2/eHqJFVnfG4Bd?= =?utf-8?q?ShjhZTVZt7FDc4O/Opkq+P+f1+nM1gkHZxCqid+3F3HfMxWtzTQBe+ELJSEaKH9Q0?= =?utf-8?q?LQ5v0cjQjc+Vm+Br2n94DV281VKIUj7qZMtswd8AaA4dyrAQ45VxizU0sGd6MPYHy?= =?utf-8?q?Vl6T1YZsEw8uz6kVkTbFeUz0OHg0r4zbt98bf6COHW6YYeu4LwBjQQLnrDH4Bp+PJ?= =?utf-8?q?PSoVScfkDEnn8ie1YOVWmEBazuSAYpUo6ytLapI8vuxOkw3Inox0XsFQkUK40pHXz?= =?utf-8?q?GQj+SZcnlgoynD7ql7dMo3k+bRpCdPFqrbYrlNmWgCraRXiFTlw5qDEEPasUW2oFH?= =?utf-8?q?T/e5oe4Rc926/ThMZzf+pgmYB2lG+RnftaTn+QM6ylIJKkAywY6MgkUrvYePyvkiS?= =?utf-8?q?w8b8lF6DyNq/AzAupjUsxE7LmWY0aje8IfXfi12vzr0iIzMbCPUbE7I9Bla+rBc0b?= =?utf-8?q?/bDqXsk+2cSgOe1d+TefIQ+7jYOLLZJqDt4DuDtZDREPGEicHyYOsk1XRH+YeVdML?= =?utf-8?q?KTpoMduUcgnE1BsLWkuLR2vTa0ywbiJCc/zK0i4XoBAV/rr7LoMxvH8Vm8rCzEND4?= =?utf-8?q?QFr3YpaznWq17P1TCLktgeDQfULjvnFYbohHQk07Y/r+pjU1UshVqS/xXR7bTSJgu?= =?utf-8?q?h+dLJgwKs2XGDOpVul5WvcmY425N+JOTz5yS7FbTTonDc8otQLPSWml3g7hrTusza?= =?utf-8?q?1eryAsofNNIyN8ceVZzA3nba7BB2wxkeQkYaoI+7Noq3oxAXLJ5kSS9oy3qFnmpKv?= =?utf-8?q?vwj7R29Eah0FhS8hnajMEMV+JeK/7WaUs3DbVqTLbUusZ6bNH8YmumZNmLdHbZ9LR?= =?utf-8?q?66PtL8qfMwQWeNQgR+HblzXpiVyW0Mcdn3JBU5mdCOIi32hYPZBnBdMqFYwJUKadD?= =?utf-8?q?e+bBh41mdS6ZnxGWOC1wV8jpOzXqbNq1rGX6wDNmWZzi7JU4gMIMP3RqCs1gOXjjD?= =?utf-8?q?HL8yJy8gES/Pk1G6lU//HkL/6Xqh+PJJdYDnxhng9M3mEX735BoM7YrtYdhRSvFUu?= =?utf-8?q?BAEX++wvj2tXQ+l8VYJjCkeKlMpDONRX8wh+OelLdAMkbFrgbiCfFYlfoRZYaoEu4?= =?utf-8?q?QGU7+8rfXuoY?= X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 69c3ff6f-92ca-41a2-d64e-08dd760d96ec X-MS-Exchange-CrossTenant-AuthSource: PAXPR04MB9642.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Apr 2025 19:51:29.6336 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: NnBrHxR4niWqIMmdHJdj0R7p5bixHwZIK3aBWtR+myVER4fgGZiWo5NECyERF7lR6P8n1JavjdNUpUVpugitSQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PR3PR04MB7452 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250407_125132_587914_CE58FCAE X-CRM114-Status: GOOD ( 13.35 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Set the IRQ_DOMAIN_FLAG_MSI_IMMUTABLE flag for ITS, as it does not change the address/data pair after setup. Ensure compatibility with MSI users, such as PCIe Endpoint Doorbell, which require the address/data pair to remain unchanged. Enable PCIe endpoints to use ITS for triggering doorbells from the PCIe Root Complex (RC) side. Signed-off-by: Frank Li --- change from v14 to v16 - none change from v13 to v12 - roll back to v12 version because Marc Zyngier have concern about add DOMAIN_BUS_DEVICE_PCI_EP_MSI. https://lore.kernel.org/imx/861pxfq315.wl-maz@kernel.org/ change from v11 to v12 - new patch --- drivers/irqchip/irq-gic-v3-its.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/irqchip/irq-gic-v3-its.c b/drivers/irqchip/irq-gic-v3-its.c index 0115ad6c82593..fd6e7c170d37e 100644 --- a/drivers/irqchip/irq-gic-v3-its.c +++ b/drivers/irqchip/irq-gic-v3-its.c @@ -5140,7 +5140,7 @@ static int its_init_domain(struct its_node *its) irq_domain_update_bus_token(inner_domain, DOMAIN_BUS_NEXUS); inner_domain->msi_parent_ops = &gic_v3_its_msi_parent_ops; - inner_domain->flags |= IRQ_DOMAIN_FLAG_MSI_PARENT; + inner_domain->flags |= IRQ_DOMAIN_FLAG_MSI_PARENT | IRQ_DOMAIN_FLAG_MSI_IMMUTABLE; return 0; } From patchwork Mon Apr 7 19:50:54 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Frank Li X-Patchwork-Id: 14041944 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 7FBF6C36010 for ; Mon, 7 Apr 2025 22:57:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:MIME-Version:Cc:To: In-Reply-To:References:Message-Id:Content-Transfer-Encoding:Content-Type: Subject:Date:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=4JrBsZtAlcOj29e5c0bW2M2CW0PWqPaa73Lwja/s/W0=; b=Fcw9aEUc7rWIrcc1K6NKljPh3m A1+lLZJKaoSiDzlbKoB4j4uzma2qncE5HiE3u1z4R61yvZLgRKFsPSfM4P9w7ZIEVUigA5IKc7D2e fxV5Z8WLTqTxi10eW2n+dxOZ4qUYF9BY+I+VBjeDCby6zyck0leswJ8kiqqp8zWCgkeoh3MsGzfop K2SFEBcMvoZBqg45kosi5IhOlSS6Y+hZJ6pobqLVfMzSd4Eyybcx980AugnY5yygfrf1CvwFOeggr Fkoav97m3MjqqL1PR0Ibfr2gZQSUFcBqT5MiZLMbWeC3BgD1FaVsB7FU9WgL/pZZernMfqDsXnCCN I9JMHQ4g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.1 #2 (Red Hat Linux)) id 1u1vPV-00000002Ea3-2WXb; Mon, 07 Apr 2025 22:57:45 +0000 Received: from mail-vi1eur05on20620.outbound.protection.outlook.com ([2a01:111:f403:2613::620] helo=EUR05-VI1-obe.outbound.protection.outlook.com) by bombadil.infradead.org with esmtps (Exim 4.98.1 #2 (Red Hat Linux)) id 1u1sVP-00000001sQa-2xVO for linux-arm-kernel@lists.infradead.org; Mon, 07 Apr 2025 19:51:41 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=YfLvh87chlf20+02gN2m+yEPyWkQXjv6QgT0rza9uE9Rd8gU7PGQhx97vYEygWR12e6hKjRiw8Cr4w7jxyAOiQmurluHcnBP6ixm7kfKPwQIrjbHg7ZVNO5c9uxeI1HWe+pIN9MAR+nYL/5mydNpogTsAEPHQyOld5bpg3nVgTk5vRNdD4wjDodIKfJNUEycfbEWlJ1GVmHe7Pqjiw0URflpiyfekpckVn9QHqsgfJ+N1KIv1iKqVGmS7h7PijayXYa2r1PthRbcIOEEbjHVstiuqLAEd8aXEif0aXdhZwrQ7kzQmHQS8EHf9OwSNG2tr992qOZkYh22DwCNiGXsOQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=4JrBsZtAlcOj29e5c0bW2M2CW0PWqPaa73Lwja/s/W0=; b=frKH0fV1DMZ3ANgEgJAB7hUoyEKPhIEhi0qdWrPoUWkTByBaIvUG7T/CDCdKfr6Q4ashGrBXm9nCt1/mCxgh7nqHHkhsj1h7jZ6ttj+Nd/C/iheYDYU/dFiznr+u8I80+YjuBd56o0AeTmXPE/nTOEbAbR+q+5CtyW2kqbhzf5YQy09BDETayDqV0URFhFLVFlVpRGPyOIxhC/uYYBi265DAcw/1/K8rfeSD1p1+P5zs3csIbqkEUnmOxGuxXR/+qUU1mMCVd1SQBt4F53M83+zYOIe4v8ap+Wk7R7LQfBLMbvn3UzsojNGbtBqaZatl68W/z+mdXDJUZ0JdRyU7mw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=4JrBsZtAlcOj29e5c0bW2M2CW0PWqPaa73Lwja/s/W0=; b=QiT+i9k/NZat/FKX+8XOeCWJUL7z4WTgqGvy6NhVgsiVpKTyt7azj6hD1Wd63TQ5DL3HooYFo6MypUSCDmbcqowDfbcRO/he43y5tXPSEeC5r4kZ1Si7Q2AjS22MjReGYdbXP8Ejj9yiUR/t2wkqAuHacl2tKPAFkNw1YpapOn2EpMZY5Jxk9P/IAyfQetDC7+pKyP/R4AVzypnLfsq/m/GZFGBwV2+5VCUeHywWb7DYJD9+EIanLKXvMrMHhpz4SPyUESjeGIZEcNbZqxnSKkBCaSxVyn+n54O8I67++U7xfGcRqczwevRtS1P3vJ+KJHxJByTbLxt/+M4x6zRzOA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nxp.com; Received: from PAXPR04MB9642.eurprd04.prod.outlook.com (2603:10a6:102:240::14) by PR3PR04MB7452.eurprd04.prod.outlook.com (2603:10a6:102:80::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8606.34; Mon, 7 Apr 2025 19:51:35 +0000 Received: from PAXPR04MB9642.eurprd04.prod.outlook.com ([fe80::9126:a61e:341d:4b06]) by PAXPR04MB9642.eurprd04.prod.outlook.com ([fe80::9126:a61e:341d:4b06%2]) with mapi id 15.20.8606.029; Mon, 7 Apr 2025 19:51:35 +0000 From: Frank Li Date: Mon, 07 Apr 2025 15:50:54 -0400 Subject: [PATCH v17 04/15] dt-bindings: PCI: pci-ep: Add support for iommu-map and msi-map Message-Id: <20250407-ep-msi-v17-4-633ab45a31d0@nxp.com> References: <20250407-ep-msi-v17-0-633ab45a31d0@nxp.com> In-Reply-To: <20250407-ep-msi-v17-0-633ab45a31d0@nxp.com> To: Kishon Vijay Abraham I , "Rafael J. Wysocki" , Thomas Gleixner , Anup Patel , Kishon Vijay Abraham I , Marc Zyngier , Greg Kroah-Hartman , "Rafael J. Wysocki" , Danilo Krummrich , Manivannan Sadhasivam , =?utf-8?q?Krzysz?= =?utf-8?q?tof_Wilczy=C5=84ski?= , Kishon Vijay Abraham I , Bjorn Helgaas , Arnd Bergmann , Shuah Khan , Richard Zhu , Lucas Stach , Lorenzo Pieralisi , Rob Herring , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Krzysztof Kozlowski , Conor Dooley Cc: Niklas Cassel , dlemoal@kernel.org, jdmason@kudzu.us, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-pci@vger.kernel.org, linux-kselftest@vger.kernel.org, imx@lists.linux.dev, devicetree@vger.kernel.org, Frank Li X-Mailer: b4 0.13-dev-e586c X-Developer-Signature: v=1; a=ed25519-sha256; t=1744055467; l=4116; i=Frank.Li@nxp.com; s=20240130; h=from:subject:message-id; bh=lx8wFQA410Ulvs80/pKL4VcApSvR4ds/sEngpDV8Kd4=; b=I1R+jDG3YY35ycOben6Uf+GFMbs3NADfpUIB+/Lejqv8MZQ/THhseBoBuWYYBlww5NEQQEie7 tQ6xWc5mfZFCVpG8bw+bLzee6GopcdR0M+ULD+7pbLa7z6SCCOF5exP X-Developer-Key: i=Frank.Li@nxp.com; a=ed25519; pk=I0L1sDUfPxpAkRvPKy7MdauTuSENRq+DnA+G4qcS94Q= X-ClientProxiedBy: AS4P189CA0041.EURP189.PROD.OUTLOOK.COM (2603:10a6:20b:5dd::15) To PAXPR04MB9642.eurprd04.prod.outlook.com (2603:10a6:102:240::14) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PAXPR04MB9642:EE_|PR3PR04MB7452:EE_ X-MS-Office365-Filtering-Correlation-Id: 913b0e73-9d4a-480d-9298-08dd760d9a14 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|376014|7416014|52116014|366016|1800799024|38350700014|921020; X-Microsoft-Antispam-Message-Info: =?utf-8?q?Hs3qbIkZrNEG/FD6gCltV7TZJFYcxtd?= =?utf-8?q?1h8H64Rqt0vUn5JS6DRPWhbJP4cdlzO7z4CBN4SWLYckJ0mQzjd1LJMZuMIqWhP9R?= =?utf-8?q?TSyD6HL2J3EH5FQSE5Kimmtxcx+RwwMVby3rWN/73SpX+MEgjDXnRi1QrWFspnavN?= =?utf-8?q?2NoCiecCwRE59Ot6oicagbWNY2uwoQY8a5/44i1opKGTMMsIb6PxrKU44eo363rnC?= =?utf-8?q?kC3A6vwYbcu+oeEyzKZ5pWqB+ngXaRdd7z+jWlEjMokn4SR1wzB/kAe6TGjux/Ran?= =?utf-8?q?vra1H8FCjjiSbxTUiPpmIjve+yu17NSKkuol8JuEZ2e9sAcI/UW1IAUIEy3FFigy4?= =?utf-8?q?DfwSm/DJ90S8sQh3FNq2/KERfQvxfFyoqlhw6u7vsaj9T1yVjqyYhw+v1na1Dvwt9?= =?utf-8?q?TJUfOjImiut1FSyNT3Zoa45BR8hk1xx38crFT9/7YgMti0/L55JxNUUIlLuD2R+2w?= =?utf-8?q?URmbjo22LyctShZ79buCvXRisClrbE1DCJtCoCzrzMybLVmca/VfNKHd6P6bVTYfk?= =?utf-8?q?FkkGRZjuZBLP3I4iPRYXUkSIXwiXoQxyn5Bq9i4Ow9+/wAQdBJ2BBsiK4oXChALuk?= =?utf-8?q?rejqNgAJOlTbm9yOiHMxeFpqAzJj8guejI3Vi0cUnpPbuQbpUsRd8UL/np14tOtiB?= =?utf-8?q?j3ytKhOTZ1bxeuCRWYseW8Qq1iVpYaPNY4kvOjvRW4GcxY/EWujIYGI7fwrcBVBYP?= =?utf-8?q?baXWnKL6J1KYu3xa+y+1AHKi2dG360vaIJlZc8kncdKBbz8DN1QNtn57jf6pp43CP?= =?utf-8?q?6f+uAR9AeQ6MZy6vCM7Ai2IqCIdHbJoUD9PA5wwvGybAxQYfcHrmSTWkT1lzNpY2N?= =?utf-8?q?XZaZqEahDeIPL2qKB33v8PDMTA0+/yN+KtGexGUx2mc4Gi3W//KGVuFETY56Mpbx/?= =?utf-8?q?2kAANk1h/7sgkOGALbMB9giUo23tOIWISCsyvXp/lwsuXZsx0GLJIP0/CQZSN54bu?= =?utf-8?q?QtHA1qlhbBshV9l4FUakzKdSVTitMcOMTiBnnbg9zKQ+69tbaXWSmLyWUw3qeyD3x?= =?utf-8?q?QaLvOqRgHud0dmIuozo1g3IFc6FupW4/55RHyo4EnbDR1d0AYFXRX9CBA0z+Fd7jQ?= =?utf-8?q?1Dc2FF1gC56FawB41+XHE+JC4b7vNOdylpjbLzx3Mt77R25xufwWSFRn7+UkDctZR?= =?utf-8?q?CrwzmPpPldgiXl5ym436Kmjc71SXdhkbt4/3Mw4MA3cTIBlQamUi6PjCd1GOHHstg?= =?utf-8?q?z36u90CgkWF5eCkRgaiL+bQk5nKVfWMxjaqiCDTxVH8o/atoM0oeBslj/srTPBNLT?= =?utf-8?q?xij/RA4dc+JBZVB4GjZJZ3aszKJdNWGi422xMQkp1hCqlrd7m6i4vi3LPKt/8xDZB?= =?utf-8?q?4AbbGOZuqmMjtoE55S6xjk9UckxVv3/ep+mOTbG1e2oJt+4JEYcdIUHGYikOdIaAm?= =?utf-8?q?hp5whwpg7S/BlkSQQnfct0TfOS4qnNbaw=3D=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PAXPR04MB9642.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(376014)(7416014)(52116014)(366016)(1800799024)(38350700014)(921020);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?q?vlPXQ5043uQxmYjhafVA8DSGAseK?= =?utf-8?q?Q0114HgyikCxDlrs4DSsiUv5x3cpgeqt+HvWam14PXZyHhiWay+8dJOe06HeyJ5ud?= =?utf-8?q?svlua1N6vT+X6EXHWURuvs6CF2yfWWxCeyV+lXWkwxtnsg0W1h++zyuUZpHU9aRDm?= =?utf-8?q?Fkfp5VR+8ZG5IKncsRE3QJffdCNSQDI+GFTwd9p7iUcclGtwdeu9CS/BaDUaGCV2J?= =?utf-8?q?l6ykssjzZXu6XCiitut1jE7BOS7FElzXETsX5yj/YZ+0AkdIeVJaPPEdi2fNFD9pk?= =?utf-8?q?Q3NytyXwTZvY9TSjNwLmQY6GbCAU57Ps78bVGQS/hQ8yiovRzoANrusNa+vR+ICe3?= =?utf-8?q?NjlqPqSSRfeYBt9KeGGuV/obYbYFykkHBeAaVlvIBccaBaA6q8qbqyx2QI0hOHdNL?= =?utf-8?q?78z5wY/TPem5LYsevB9HhtSoaWuDAAuz1pBAsqjhhGh6Q1CTSs69sG/DRtj8lXKfT?= =?utf-8?q?NULFzmE97GjpFH16HcGuYyo0v/USpj0x13fvxkB16BnmTZoR1XZJ23R+Ia2vNHmWr?= =?utf-8?q?WPDiJZyd9JHihEc6CvpIp3U+ap7+izrTjg8S5ptljbUNZA0HQjq1Br80cgE/Uw2Pq?= =?utf-8?q?tHyYVIq4bXWdf/zXPzV2DYE5vGnsn7N2/FSXmfbGTpqnaoLf7vS/7ny6ik2Scqq0G?= =?utf-8?q?0fpZqtBOBCsA/zsTyYIY6VYYB9wKk0b0t8jH8pa3Dj2Gw2vZrw+nbP5fcSfMG2/Xy?= =?utf-8?q?tbJMqAL4bfYLABELABTucPkrCrjFSdFDiWpkAOHK2v3azppuM8UJ44XBEDufiPoAP?= =?utf-8?q?0WeZ5WucyMYCKuNOkgfZQLuz+T5d29yj6gZmDy4kYxmht0i0pyz8U/qqnCDDZCfq3?= =?utf-8?q?Rxp0cKFUMcO79BPxDdfVsE9fkvnDGOFD1Kx4bId7wBpp5VkZY3IiNaqvhxdBVpPNR?= =?utf-8?q?MapPTyRjfa5VY5wxCbK3/9cm2n76izz1NMsxeDuuEgfIo8NwIPVsBG8+jd05h8vCa?= =?utf-8?q?bcW24emQ0eIQA07wUFc8AyvQGGBYDo92c2yv1eDYDd286MlzpIP+Ut3W/b8rJQ9U5?= =?utf-8?q?2yyCC93jYOgSNnFgctpbLlFBH4MYTl/Z7VyPcGh0Jph99FJZbiyGselgHgUErjeMD?= =?utf-8?q?wXP02DBrcOJL/Rhg+b/3k0GZ7cSlww/HtKHRMkt2RLGEYRNb46OmbGWLYdeoO+FIS?= =?utf-8?q?XSbgU4a1D3KUU8jKES27OQiMUc0KKdutGUXnOXpNvnAjpnLwE/P/ZttVgoJoFVNCT?= =?utf-8?q?+eNCNb6O+NfeV9BmV0sf0CQ81V/SytTSuS+BP8qdN+VYE9u4OoO7pKNhIkmS+XLxx?= =?utf-8?q?Vp3443VA6diCEp6sB35zO29aEqPZSm6t9/KBg8i5lr9o62g8CQXMmKd9ojObRReNo?= =?utf-8?q?kFnSTDcFFX67ogItA05FrnvNnf7CcZOuEK7/+vhMq7b4XKBBSVTrQ3UdCw1wyB1i/?= =?utf-8?q?82MeLy88DMINGgnvupSw1F99++OKRys3NuzYU1ApahxQ0x5ysLe3eB3GvwWTg/9Gs?= =?utf-8?q?BY1HO+i8AycVVzmB02O88hcHhfJliTUJNzSpxMZvuC44aEjzd7e/j9jRxhP1Vc2LT?= =?utf-8?q?h/dql0+Mku+W?= X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 913b0e73-9d4a-480d-9298-08dd760d9a14 X-MS-Exchange-CrossTenant-AuthSource: PAXPR04MB9642.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Apr 2025 19:51:34.9618 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: P8AE2vEpby+mbjoIk8nfaOBf58IET3EClHbSxvwli/RBIYRKXIz62qIXuo2OoWJD6FCZcQ1awx67CkpnmH4BWA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PR3PR04MB7452 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250407_125139_916441_E92B7CA5 X-CRM114-Status: GOOD ( 16.90 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Document the use of (msi|iommu)-map for PCI Endpoint (EP) controllers, which can use MSI as a doorbell mechanism. Each EP controller can support up to 8 physical functions and 65,536 virtual functions. Define how to construct device IDs using function bits [2:0] and virtual function index bits [31:3], enabling (msi|iommu)-map to associate each child device with a specific (msi|iommu)-specifier. The EP cannot rely on PCI Requester ID (RID) because the RID is determined by the PCI topology of the host system. Since the EP may be connected to different PCI hosts, the RID can vary between systems and is therefore not a reliable identifier. Signed-off-by: Frank Li --- Change from v16 to v17 - new patch --- Documentation/devicetree/bindings/pci/pci-ep.yaml | 67 +++++++++++++++++++++++ 1 file changed, 67 insertions(+) diff --git a/Documentation/devicetree/bindings/pci/pci-ep.yaml b/Documentation/devicetree/bindings/pci/pci-ep.yaml index f75000e3093db..a1a5b9b8ef859 100644 --- a/Documentation/devicetree/bindings/pci/pci-ep.yaml +++ b/Documentation/devicetree/bindings/pci/pci-ep.yaml @@ -53,6 +53,73 @@ properties: must be unique. $ref: /schemas/types.yaml#/definitions/uint32 + msi-map: + description: | + Maps a Device ID to an MSI and associated MSI specifier data. + + A PCI Endpoint (EP) can use MSI as a doorbell function. This is achieved by + mapping the MSI controller's address into PCI BAR. The PCI Root Complex + can write to this BAR, triggering the EP to generate IRQ. This notifies + the EP-side driver of an event, eliminating the need for the driver to + continuously poll for status changes. + + However, the EP cannot rely on Requester ID (RID) because the RID is + determined by the PCI topology of the host system. Since the EP may be + connected to different PCI hosts, the RID can vary between systems and is + therefore not a reliable identifier. + + Each EP can support up to 8 physical functions and up to 65,536 virtual + functions. To uniquely identify each child device, a device ID is defined + as + - Bits [2:0] for the function number (func) + - Bits [18:3] for the virtual function index (vfunc) + + The resulting device ID is computed as: + + (func & 0x7) | (vfunc << 3) + + The property is an arbitrary number of tuples of + (device-id-base, msi, msi-base,length). + + Any Device ID id in the interval [id-base, id-base + length) is + associated with the listed MSI, with the MSI specifier + (id - id-base + msi-base). + $ref: /schemas/types.yaml#/definitions/uint32-matrix + items: + items: + - description: The Device ID base matched by the entry + maximum: 0x7ffff + - description: phandle to msi-controller node + - description: (optional) The msi-specifier produced for the first + Device ID matched by the entry. Currently, msi-specifier is 0 or + 1 cells. + - description: The length of consecutive Device IDs following the + Device ID base + maximum: 0x80000 + + msi-map-mask: + description: A mask to be applied to each Device ID prior to being + mapped to an msi-specifier per the msi-map property. + $ref: /schemas/types.yaml#/definitions/uint32 + + iommu-map: + $ref: /schemas/types.yaml#/definitions/uint32-matrix + items: + items: + - description: Device ID (see msi-map) base + maximum: 0x7ffff + - description: phandle to IOMMU + - description: IOMMU specifier base (currently always 1 cell) + - description: Number of Device IDs + maximum: 0x80000 + + iommu-map-mask: + description: + A mask to be applied to each Device ID prior to being mapped to an + IOMMU specifier per the iommu-map property. + $ref: /schemas/types.yaml#/definitions/uint32 + maximum: 0xffff + required: - compatible From patchwork Mon Apr 7 19:50:55 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Frank Li X-Patchwork-Id: 14041891 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 5961DC369A1 for ; Mon, 7 Apr 2025 21:48:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:MIME-Version:Cc:To: In-Reply-To:References:Message-Id:Content-Transfer-Encoding:Content-Type: Subject:Date:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=mGHcDy0qLXRPv9bDtIJ2M7IEz1TWHDvcXEwtams7Bbg=; b=b430zMBXlMIfPKzm8wVglSPyKv 8yt/Ad7St/Sw15xtkvSomDkdjefgk46cC6FrlrwgleoZi67crtHIOJItL3alZF4q8lqJoBlK6rFqp 1mGw4o0g7WGrz64ebuUYatjTGy3qdsz8tlIchkX4UGPa3BWeSE6Z7fef2bq9Zrfbnn7T3EV08/OSG dwBHZAgvsu5e2Ecxo9T5IgnIp1U05iIrD9onbkbcLQc5EdmtM47kPLtYUsAk1G04qmHvLEISc3BWs ax/NkRhS9075lvP/jElkoinKvBjHpGJGhSYhaBz8jr5mODIpAkks7/7DGfoqtXMJrARPOnzQ2jtN+ O5y8g6SA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.1 #2 (Red Hat Linux)) id 1u1uJt-000000025y9-2sUa; Mon, 07 Apr 2025 21:47:53 +0000 Received: from mail-db8eur05on20626.outbound.protection.outlook.com ([2a01:111:f403:2614::626] helo=EUR05-DB8-obe.outbound.protection.outlook.com) by bombadil.infradead.org with esmtps (Exim 4.98.1 #2 (Red Hat Linux)) id 1u1sVS-00000001sRY-39NT for linux-arm-kernel@lists.infradead.org; Mon, 07 Apr 2025 19:51:43 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=qOSh7mgP8yUnB7MwxZr/2GAGlH01Alys+e9xxRzIwqW8pJemcdp+34UW4VA2c7TJBeR96drsOBv7+LcS29AZn56v/VIP8RPIc6ToERfdUfdUp2dZjCI7Wc+21tasX5axXybeOk1Chndv5XX4qlDRUHeHKVmcy8dM3rAaf6tRyxAAup66RYFCsJ/uRqoxj0b1OQEMej9yt8bJeQeTkzBRvwJUVZOaEFO0cw4U9cRMKDOcmDCXwntlrFG/jbIn+haN5oXNPNR3aFHPpP7qJMoWTpi3JvykeJMfi6JIFd71PSa7zCrWQ8S5BZGVqm8VEPKN+sv1k99lC93eoZAFfzaonQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=mGHcDy0qLXRPv9bDtIJ2M7IEz1TWHDvcXEwtams7Bbg=; b=eB0b4pfmwS2vNCnb8PYRL0Ppri7QBIWbw/tYJLF5fMiKitbfodzHgb0wQTxg/P0+7vVUcBv3bujzr5hmxa9+bhRA2wBAydT0yph56CHIyMtiQwnpEUZIN7UZQoCs3xryDW0GZLczHaEAcGK8lbB0WC5/MVvp7wTqoKSYuNt7AEF66ydMqqleF4NoOM+oaYKPMyYzxEO1xfoBgbmBimlcwLZ1vN+ZQzNTCHKOyB68QGtEYX1CvQ+51LppNhZTgdtg7UjUPPWYEzGgPD6fVmsCNA+QYGrQRATrOvRvJNMDAAR4Lnf0MrcuWoEqKSCVv/wVZa++JQRhqwkQXZZlf9ayGA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=mGHcDy0qLXRPv9bDtIJ2M7IEz1TWHDvcXEwtams7Bbg=; b=gPL/8AG3Wp3e3qhbtN+HUY90yYJb0NbGH5dnCC5uWyFDSipMt0sNp24au3VVwTHBermaUOye90RS7N/0U2pEWRFVgHQWcZXXusxcYRZLV4YzrX8VMx4PBAotGcrX7Q3vV2YmqoOCQWzRIGZuZV1gDUFyuKZS6d2HjHsPvdciJk7AIFniGTUoBekDEkK9zmZ/IAGH4GXWJZYs4bDuOXY7lnMXD8wBi/8Ewyt/B9ePF4nzVfEXyS7LU0hiOsvG15pKOTL548ed5PB80en67hkGEMVOhdJSBLHZJNPHE6JuWUoc/d9W1zRgxKEvKiZd1zQVeUCVX9sArVQi5Li2wzMGfw== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nxp.com; Received: from PAXPR04MB9642.eurprd04.prod.outlook.com (2603:10a6:102:240::14) by PR3PR04MB7452.eurprd04.prod.outlook.com (2603:10a6:102:80::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8606.34; Mon, 7 Apr 2025 19:51:40 +0000 Received: from PAXPR04MB9642.eurprd04.prod.outlook.com ([fe80::9126:a61e:341d:4b06]) by PAXPR04MB9642.eurprd04.prod.outlook.com ([fe80::9126:a61e:341d:4b06%2]) with mapi id 15.20.8606.029; Mon, 7 Apr 2025 19:51:40 +0000 From: Frank Li Date: Mon, 07 Apr 2025 15:50:55 -0400 Subject: [PATCH v17 05/15] irqchip/gic-v3-its: Add support for device tree msi-map and msi-mask Message-Id: <20250407-ep-msi-v17-5-633ab45a31d0@nxp.com> References: <20250407-ep-msi-v17-0-633ab45a31d0@nxp.com> In-Reply-To: <20250407-ep-msi-v17-0-633ab45a31d0@nxp.com> To: Kishon Vijay Abraham I , "Rafael J. Wysocki" , Thomas Gleixner , Anup Patel , Kishon Vijay Abraham I , Marc Zyngier , Greg Kroah-Hartman , "Rafael J. Wysocki" , Danilo Krummrich , Manivannan Sadhasivam , =?utf-8?q?Krzysz?= =?utf-8?q?tof_Wilczy=C5=84ski?= , Kishon Vijay Abraham I , Bjorn Helgaas , Arnd Bergmann , Shuah Khan , Richard Zhu , Lucas Stach , Lorenzo Pieralisi , Rob Herring , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Krzysztof Kozlowski , Conor Dooley Cc: Niklas Cassel , dlemoal@kernel.org, jdmason@kudzu.us, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-pci@vger.kernel.org, linux-kselftest@vger.kernel.org, imx@lists.linux.dev, devicetree@vger.kernel.org, Frank Li X-Mailer: b4 0.13-dev-e586c X-Developer-Signature: v=1; a=ed25519-sha256; t=1744055468; l=1711; i=Frank.Li@nxp.com; s=20240130; h=from:subject:message-id; bh=jis4uAlk2Y8+00RUPuARjfibBzjm61NUigLnBik7ARw=; b=iI9pwtljBuLt5jIUX+ZiQVLS/Az2zUc43cUiYGvdxPHQqUiPYE96L0dFFJM6hMF56AuSdFiV6 Xp5R9HVp69/Dk37YPzvJqnG7sp9relzlf6xlXaDke9NP02aSuqcd/u5 X-Developer-Key: i=Frank.Li@nxp.com; a=ed25519; pk=I0L1sDUfPxpAkRvPKy7MdauTuSENRq+DnA+G4qcS94Q= X-ClientProxiedBy: AS4P189CA0041.EURP189.PROD.OUTLOOK.COM (2603:10a6:20b:5dd::15) To PAXPR04MB9642.eurprd04.prod.outlook.com (2603:10a6:102:240::14) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PAXPR04MB9642:EE_|PR3PR04MB7452:EE_ X-MS-Office365-Filtering-Correlation-Id: 4cafad40-d60c-468a-70f6-08dd760d9d3e X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|376014|7416014|52116014|366016|1800799024|38350700014|921020; X-Microsoft-Antispam-Message-Info: =?utf-8?q?bLoAKc47m0z9rgUCfDXyHeu7U3okL1k?= =?utf-8?q?RgKbwjicLJe7IMUjkT4Ypmsec9GwUlUMcbx1rC4F7t+MmwuRnuiNVcgaDkBOwEcjX?= =?utf-8?q?8J7YIpXto2kj3kt6nNOUufAKU+BzuY6a1uz45xXKtlfeB1Uj+dFoa2kmfxC1HyxOi?= =?utf-8?q?UXTzmOIKqxYIUnyrx+SXY8WWLyMGQJr+3p5f8hnL3mBPLBBKXoeVTzM8pwXhlTf9s?= =?utf-8?q?3ABB1D4xMa/3++Oytyz02AtHE1BIToXiUm9m0rJ4oDhCQJ0L1pMsvxh/kRLnfo4TT?= =?utf-8?q?qgg3O2ImoLo0X9vti92HZM2CL/D8QgyyWCjWl+JHKCF9BAuOB3wEr7ySahaYIwNcb?= =?utf-8?q?Mb7Zowj9+2avBC2WNbxurMSJ2mboi3eZpIhdXk3BkbViuXIkKN6NBRD2pKmXJoYGO?= =?utf-8?q?q2XPMfR30gusqLmVVYkMHM36Sj8nQUuQ+ob0k7Q5J7PMqNbyjpnU2bSvSpW0Lf35Y?= =?utf-8?q?UwfmgIM/Da2EZooJlo4wqNlOYSgUlX6XhjIvgFF5VDVJIQ4RRJ/5RgsDAbkyFvE6+?= =?utf-8?q?hI36dxYxuzxkfJZ7I0Hxmj0tYaLqSwELt05o6Yj/BpLUc/hPkOKBs53Ci1pVphI2J?= =?utf-8?q?UiqhzHCjp7npFP8amn7R7fvalDOmMeeY4MTlW03gEiAeYmrvgT1yfxEdhfh9LvRzZ?= =?utf-8?q?9ERxPrGCRzgW2fdnkFtFsE2p9+PE/UcztoMjr7SB7STrPUdFZXL6Kba+GS4qfDd4l?= =?utf-8?q?Ej91dT5XeeuoJuTsw1e9+BSwiE+B0P53c8KaK7ChDBSXoGk0eb3mIYADrCDixRvzc?= =?utf-8?q?OP1iRj/SoWY+NfKJOnu2shcZKzfIpXBhHO2GKoy/X3nRCdNR3M7BKAuKiOxANJB1u?= =?utf-8?q?IeT/pTXPtSomh6s/wcSD0NuoJLxlT1q9OjJ7hwFokHZBgtBgTvZQrTHr6boMQHn5L?= =?utf-8?q?vzmKm9aIi1ozi9+16v+9cJCy+paPhqwt+drWpcj3C4AYixAQjNXr5wtG5rTjUVcM0?= =?utf-8?q?aaYt05GhZCVik99Ydpyu7s9uUhycSvSn3JyQhjjDxPDZhguEeo/Kt578WMhPNKW8r?= =?utf-8?q?iXh1CM8F/oKJv6ytoFchJLvElg17OZHWRxbmSLYARSfzknhTN/xO7VhNC5PGnLhfF?= =?utf-8?q?UQyY5ayIg5PvQS1TkWLgRERQlfrg/LCygw5oILmEqf19CA0qL+YjzsQA9GbCr1O4Z?= =?utf-8?q?5eWfyTTLtoajVFD4leZ9RzGB+2iDghqfbcsZadrM5q5Gl13jYqE2mP2S00cMiNegr?= =?utf-8?q?/+qTTDYUyOPuWpX4jzIpkjHoni0pS/51uYEBqZvjMYXUm4Z262M0CcQtp4aVym4AD?= =?utf-8?q?bbQTi8Ch/EEGgcGZw9N8dA7WAezTc30vX9oEX5FvdcPWp/1ZwW6v/quOBD4sc/0y3?= =?utf-8?q?5sZ9ZZw2A7zv1qabDFlPM22Hs5ksKUYUbC6kHu68x1SqKbWeygQZKiAt/DuboE2Ia?= =?utf-8?q?awVBL332aVYUblUiiHUiFZqHDLQVSm8QA=3D=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PAXPR04MB9642.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(376014)(7416014)(52116014)(366016)(1800799024)(38350700014)(921020);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?q?XRvrb1Jgf7DN9GA+vumF/o6jQTMR?= =?utf-8?q?8C2LFyM8/Nv624E3A7C0Bt75Gm12bWIsUd3eVFbUwv7+APRydsv06vUSYsxBoDmnE?= =?utf-8?q?3QNdOd/egfZLwC4fLNLdkkA1igUiorPZAet8qSdQGK4slUGAFh8QelrGcZrr90Q1k?= =?utf-8?q?uUjYA07KvMt0K8yH/p8VlnUJM/+C4Xmoc9GXMuBz5v5kPFzh1C9kynpgRfuEZ44ar?= =?utf-8?q?J6pOumFgaOVIzXf9AyWogDuGI+6lu25kNtGsy/gzM8cOKjWiX3Qtu655sUTtpHKXB?= =?utf-8?q?AyWF8YgSQDTPnCBbYb8nwksjC/YmwSNU9ouPYGaevmyC3k7S2hPu083By7OCoZXnu?= =?utf-8?q?F6Uwud/yINoB1iUvOo9g7qXaXajWX1+FshF+y6NE84zA7trHNcBW+On6G15ebbBEd?= =?utf-8?q?TORdv1HDdsDauMXEig6A+n1DedTkzif6Jvz69oXnVDwzRqd6Bh00gsrPsdiasAL5T?= =?utf-8?q?gg3TljR8QolnRFA1Fj2hWNBLOXFEpJorVctBnZA4Feck/8YIM/zK9jVpfxPG35onT?= =?utf-8?q?fQCCj4s8iEVjK+JnCs2rCGC2ZpZCt2zJxNX8gFNYbCJd+0YVEK7b2NzjOw3aP4xGx?= =?utf-8?q?ZBXEbnd0QI02Sk+INXkrPgvYAmxJOCTfehys/GUv8mjJkE+ALNRUvXji02OMfuj37?= =?utf-8?q?OzIo+e/9QvvEjLro9vwJfl6bsnWFFWhkgTX6O6ev82XVzTJ28FuWSPiBGzFSLRL/w?= =?utf-8?q?o9/QW3oAMH1M5gBcvPsXMSIN5HlkbsSxXXcqraLEV4kSYjnzxqUeAabNGdJhUKf47?= =?utf-8?q?1PooFh6bTV3Ga4vDNOKMXuNKhzGv/qhyh94ZkKAP0BMnPzH58dYv1aiE/sHxO8Ql9?= =?utf-8?q?T2pDQXSyVK59n7KiYhnvGehvVIHPYaDXDAGCSaQMF8SMRXDOhETTFpdeR4BJyoZg7?= =?utf-8?q?nhwnM3E3oI0DNeiCdYDemC8loOF2Lee1WWkq2GvpV48jZM1srsjooDU6n9U76lkBT?= =?utf-8?q?KBLTzghyUPnhTAyHhF+YpCa3XL0WQaaCa7xMDB4hLDa8gvy2HBy75Z0+UEX0CAofG?= =?utf-8?q?mNygPwt1V4WgUKIONOvPRSGR0OOREExUue4N+v0WKz6cS7FdbajHzfptFeNV1Xmb/?= =?utf-8?q?R9sNhRZuZfqn2AMKsp7exnpJFRgMwxrW+lXOO56w6SN32Rd1bt2jSZ5sufCyxbmLf?= =?utf-8?q?IjeuXhNXuBaCXELIflZO7EAR053QEm+QScFJoce3z8ktVmJfXijzVBgEcPjwg6pR0?= =?utf-8?q?W/fBsItTdKHHa7WfWPCvU/PyPSEFn9C9o0XvSXI/9HBaCSPOgbpJs7Y19WNFkK3Vw?= =?utf-8?q?A6uvaBdE3u1G4oLfrAhQR/ctNjOs3vxGycc2KZs9cTP9U9v5ynYXjm2SVNxdsBhaL?= =?utf-8?q?Yj07GJ634pc7t6WDrFR8z50pQfSY/tToaNa9+pyHUyX1ANjep8Vl5YM1wgAo02UxY?= =?utf-8?q?YwrHfrnKvPqBYCTycM8jrOiXcqhBQzDqoV9QUhmdZKRR7SnuldkuiuMgnS/L0Tsx7?= =?utf-8?q?s3jxkJHOgShtwOiY39uDoEmKDRqVA9sMI4d+6X1kXyB9t3mYAzoMZ01TmV+wzxNTa?= =?utf-8?q?oB9P78lrpW71?= X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 4cafad40-d60c-468a-70f6-08dd760d9d3e X-MS-Exchange-CrossTenant-AuthSource: PAXPR04MB9642.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Apr 2025 19:51:40.2783 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: E14KVPTbC+Rr44E/Ac8QVTxfWTUcxaSCf6bTUgLNLb66xjNpgRkQVXbd6DJwhOLpsi2EgxdKNhY1NmePCOvytg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PR3PR04MB7452 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250407_125142_784717_C993FA42 X-CRM114-Status: GOOD ( 14.01 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Some platform devices create child devices dynamically and require the parent device's msi-map to map device IDs to actual sideband information. A typical use case is using ITS as a PCIe Endpoint Controller(EPC)'s doorbell function, where PCI hosts send TLP memory writes to the EP controller. The EP controller converts these writes to AXI transactions and appends platform-specific sideband information. EPC's DTS will provide such information by msi-map and msi-mask. A simplified dts as pcie-ep@10000000 { ... msi-map = <0 &its 0xc 8>; ^^^ 0xc is implement defined sideband information, which append to AXI write transaction. ^ 0 is function index. msi-mask = <0x7> } Check msi-map if msi-parent missed to keep compatility with existed system. Signed-off-by: Frank Li --- change from v15 to v16 - remove ascii figures in commit message change from v14 to v15 - none change from v13 to v14 new patch --- drivers/irqchip/irq-gic-v3-its-msi-parent.c | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/drivers/irqchip/irq-gic-v3-its-msi-parent.c b/drivers/irqchip/irq-gic-v3-its-msi-parent.c index bdb04c8081480..68f9ba4085ce5 100644 --- a/drivers/irqchip/irq-gic-v3-its-msi-parent.c +++ b/drivers/irqchip/irq-gic-v3-its-msi-parent.c @@ -118,6 +118,14 @@ static int of_pmsi_get_dev_id(struct irq_domain *domain, struct device *dev, index++; } while (!ret); + if (ret) { + struct device_node *np = NULL; + + ret = of_map_id(dev->of_node, dev->id, "msi-map", "msi-map-mask", &np, dev_id); + if (np) + of_node_put(np); + } + return ret; } From patchwork Mon Apr 7 19:50:56 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Frank Li X-Patchwork-Id: 14041892 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 6F77EC36010 for ; Mon, 7 Apr 2025 21:48:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:MIME-Version:Cc:To: In-Reply-To:References:Message-Id:Content-Transfer-Encoding:Content-Type: Subject:Date:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=CV43Lv9xcy4k1Ss3c5nbEs7m6Hdf2yF4V9lxFdIqHso=; b=1gOcxFbs+HkCH6ffyZks4HCE/V R/ETAGDgNWFgmzEQuQzoENOQouzUBBU4I1ahfUchn/3tJFTBAPGdBFCIY4XpOAYDlAbpK7vbDKhFm eG5KICGEHdGbHvEt60w18RUV4QzOgxX3FWLVukdU1OZxynhkLS7aRI4ljE9wWMllodacD8HpXrjhh a82XahNaickUqcgT+tj7YBjwYwXyPd0Z2ODDNRc9UC8+kmJm+eIfe7HT2Cp9F3CLoRptCJkR7G1mX lkUZcWwittmKFdYM+qtFM0rrBx2QKCb6YyBi52mdQlDJdeUha5L54TbUjDk3kMo1CzANidE+aN6KX G0vqNePQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.1 #2 (Red Hat Linux)) id 1u1uJv-0000000261d-4Bhe; Mon, 07 Apr 2025 21:47:56 +0000 Received: from mail-db8eur05on20608.outbound.protection.outlook.com ([2a01:111:f403:2614::608] helo=EUR05-DB8-obe.outbound.protection.outlook.com) by bombadil.infradead.org with esmtps (Exim 4.98.1 #2 (Red Hat Linux)) id 1u1sVY-00000001sSE-3X62 for linux-arm-kernel@lists.infradead.org; Mon, 07 Apr 2025 19:51:50 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=Wu4Nu5YIArSDixcJzNK77ajacM9iKsF/0xJdXaFTlWojHuyn7H+b3iAWG0YVMxNrVRhoymdw9Ac0MD/8bRn0mZBF1/U8Q9zYGdNI+s3Nbd/XMueiYsP8w6ZVR2jvLGUw9jkXP/ShwasRIvcoQKI8o8EYxAifF21pAwcvYpbtHz3h2FaAK2yro3/2/bq6b/Js+VI62uRYKPbA94xZnanx+fq6jtn1JV3T/KeAjbI9/nWMvSV25EXfftdiErTB5fjyPoUmlCNWTcK8fttrJaj162FPL1xAZl44xzi54yHJH+aHfeFGboPIMjzBsCAa9XfwKwlaGnQa2iVW7bnyXKBJag== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=CV43Lv9xcy4k1Ss3c5nbEs7m6Hdf2yF4V9lxFdIqHso=; b=KkN32I93RiEQqzyFzyMqXgi6N5PNkOCiIec3xE+XZ6tM4LB+i3FhstnpueRr3ya8/f7fGfgVVheEd25UIKU+yKHDYMfyu6xteDmfmTf+RaHxURLvRCIhKsrDHwG9nQBmpkqk2ibdA6lF+AChTfx9aQM+K8nYmfrGvtdA/ZNu5EPrUlefspNamIfUaaOdeUCr0l316eeXFmmmKBMRHYGLkepjtLNj9ROKXnFhED4tO6iIiyLRCSwTB1KfZ6VOF6+qPD2rJh+oS9wk1ZiQ8z99NyGMMX5jcfPdR26h8KcBuiqJuZT61yA1vAAnYFuwRfVtySmYmx9jw8q4DIegmR24Tg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=CV43Lv9xcy4k1Ss3c5nbEs7m6Hdf2yF4V9lxFdIqHso=; b=lgd+DL1I3cmTAal+0GMwGW8WvSOM6d+yiMEGEjhtj7qbPv8xKllnGTK3O8pr8UX4GlK3epw9szU3MHqY7wN+RUYyLkqqmqiqp5DF/rMn8iLYpPBhR7WwH9aSSGOP6Jj+zSIjxBdVZYih5CQalk5tqL7lHveBwBzuH7don7wIccyZUKRInKsA9XPUmiXQYHvoAQs9ZpVr7Y3VXZUJXNzdzOZn1T4ruKfreGecpqTAHrM6JrGxWXD4zNlvtXPtaj9v2d029HpsgvWdqU7/CJbn8hG6i79J5HzswyDIP4Csm3NP74z6/r5ROs72mCzSAm/P7U1037U+WcJh22t0/oZVoA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nxp.com; Received: from PAXPR04MB9642.eurprd04.prod.outlook.com (2603:10a6:102:240::14) by PR3PR04MB7452.eurprd04.prod.outlook.com (2603:10a6:102:80::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8606.34; Mon, 7 Apr 2025 19:51:45 +0000 Received: from PAXPR04MB9642.eurprd04.prod.outlook.com ([fe80::9126:a61e:341d:4b06]) by PAXPR04MB9642.eurprd04.prod.outlook.com ([fe80::9126:a61e:341d:4b06%2]) with mapi id 15.20.8606.029; Mon, 7 Apr 2025 19:51:45 +0000 From: Frank Li Date: Mon, 07 Apr 2025 15:50:56 -0400 Subject: [PATCH v17 06/15] PCI: endpoint: Set ID and of_node for function driver Message-Id: <20250407-ep-msi-v17-6-633ab45a31d0@nxp.com> References: <20250407-ep-msi-v17-0-633ab45a31d0@nxp.com> In-Reply-To: <20250407-ep-msi-v17-0-633ab45a31d0@nxp.com> To: Kishon Vijay Abraham I , "Rafael J. Wysocki" , Thomas Gleixner , Anup Patel , Kishon Vijay Abraham I , Marc Zyngier , Greg Kroah-Hartman , "Rafael J. Wysocki" , Danilo Krummrich , Manivannan Sadhasivam , =?utf-8?q?Krzysz?= =?utf-8?q?tof_Wilczy=C5=84ski?= , Kishon Vijay Abraham I , Bjorn Helgaas , Arnd Bergmann , Shuah Khan , Richard Zhu , Lucas Stach , Lorenzo Pieralisi , Rob Herring , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Krzysztof Kozlowski , Conor Dooley Cc: Niklas Cassel , dlemoal@kernel.org, jdmason@kudzu.us, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-pci@vger.kernel.org, linux-kselftest@vger.kernel.org, imx@lists.linux.dev, devicetree@vger.kernel.org, Frank Li X-Mailer: b4 0.13-dev-e586c X-Developer-Signature: v=1; a=ed25519-sha256; t=1744055468; l=2203; i=Frank.Li@nxp.com; s=20240130; h=from:subject:message-id; bh=1rniyVcGag0eNeLrwWvT+jPUnbYZckhT5xHhMRAAH+k=; b=0wbGcuTZJV1FBhS/OROYoVZ/OFMxs94KHXJjBaeh9UE+WAlsijRXB6h7zVmvDOcbitJ+zIiT+ 3B0wZaq8YHiAl2SbduxHs040S9lAWwMRYkGu/Wu5/kEkb1KAL5FTnvj X-Developer-Key: i=Frank.Li@nxp.com; a=ed25519; pk=I0L1sDUfPxpAkRvPKy7MdauTuSENRq+DnA+G4qcS94Q= X-ClientProxiedBy: AS4P189CA0041.EURP189.PROD.OUTLOOK.COM (2603:10a6:20b:5dd::15) To PAXPR04MB9642.eurprd04.prod.outlook.com (2603:10a6:102:240::14) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PAXPR04MB9642:EE_|PR3PR04MB7452:EE_ X-MS-Office365-Filtering-Correlation-Id: 6c4de032-8c27-4160-fc33-08dd760da066 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|376014|7416014|52116014|366016|1800799024|38350700014|921020; X-Microsoft-Antispam-Message-Info: =?utf-8?q?qiTNU8aOgU7Hr60EeQgzMl+vs3cJlWL?= =?utf-8?q?YNW+tpCSWB0qJEhzxMgAcv1SwkUquY/ScmZ7fIWTGs1Rga5V6joqi1wDjCtBfDlp1?= =?utf-8?q?vM7T2UyAl4GUfYTXozExj2NTNCy+YuZnYWV36Ajy5NjmcNeG8xuwgxc30Z7tPteZz?= =?utf-8?q?QyGTu0jfjHw5tz5a36lSW2jh4wlLZDzlhJp7/6thtSU2u7qCxjPGdcdv44M2pkVu+?= =?utf-8?q?XFXwOzGeEJZO3pGpthEVv7ULS35BcJ7/rjzJqXi8M9epuvhCPelt8GIpsQ63ndE4i?= =?utf-8?q?fL4sTAsRGgAW3RW4hrYYwcfPFY+XwudCjXiXZt2WQeQFKxRD/FIeDyh4qztin11OQ?= =?utf-8?q?1Oc4mbM+YN3jwSKRJ+r3kIXcMo0io51/T7oJPZh9ZqV6OZIKlp888VudAwrGB5f+j?= =?utf-8?q?GsUEPeZEedhOOuAKmQYiaYaMO48sMHpDytoirIuEHtQSSfxXJiSvkRntIt/sCQq3E?= =?utf-8?q?udxb/PZuQ0yYZQ0dNa+wcpHvBYs3bVlU/wa8Gt7Bsv1mVUcGaEdP0PW8varDWxYEa?= =?utf-8?q?hpTnPDJAlbUbp0DQbooDy5tHWlYp3PmBVTvvvrp7frsWd4nPwXw47GFDTQyR7zZuf?= =?utf-8?q?xiPDMx0JDTsTNyRHK9wIjQ7JPCNuifJb2b9YGo5cSNHuls58/AsSlUkp6IGnYV76I?= =?utf-8?q?uyvihoda/QhUURKjykQZnavFMwuf+61a+uK0F/MNh040ixuM/+TOqQBJpiATIrX7d?= =?utf-8?q?0Yv282R/RufiTAByu5VYlZep8vx+SiT2YFcJD0iP93ixPTnsZMvadm664JEZy02vG?= =?utf-8?q?WsI0RBPcGlp/jgDkV3htfcKG+80lvxo0Iba1UOORSFQ88y6Bb4cCOasoVLhQC/Nvj?= =?utf-8?q?VCcaC0JTu46FZ1BM6YCybgbi5uATJvAEeC+yNtK0bpNzrfTCteow0nNorLS4bTEu1?= =?utf-8?q?lC5Oz1FnUK6yju0TLNAvBa/D4TJZSfvWL5dITIEDTrTml3roi/Kbzx7s94Pad/Vr5?= =?utf-8?q?APZrmHs57ik0AUEQfEco1co1KkVVvw1zWVsmVYru0ywe99B9+tcD0vTU29jS8YSs+?= =?utf-8?q?5rjoisxxg/kCEaObRXVl2YyLCXhJ8A5rPRLi2dIHW9L4kZ2y0H5ofybQAaOhhW+LX?= =?utf-8?q?S50Uc+dorIWs0yuCQC0tG1PhO6GcUrINhAzhIz7Tttvn15+NvtnAQAi/fXrS6251E?= =?utf-8?q?slfcT0/mowPZ4SYS/WebJ2Z3o3LVAzosTxruvqMF9inHicQ/hKPFX7Sv6+fhtMEKY?= =?utf-8?q?g/E4quZr1ha8xhPY3t9+pq17BNV8c2C4fMc7yn8Leeo4sYASkZGf4CVObsT4tcCtd?= =?utf-8?q?4u2ZOmOJ9Rpb8j17vgnkN21GxBp17Y5i4gAA//r2Mn2b9AnHXBm4USEQaHVW73qRi?= =?utf-8?q?uUcFowxp6pAkP50VOVgb6bQ/pQiqjP0UpulzEuMVPAn5UY/uR9LlzWFeofy/MeyBa?= =?utf-8?q?J/AAtRsBVmvsBEDh4vFTbkFqcsTf7grfg=3D=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PAXPR04MB9642.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(376014)(7416014)(52116014)(366016)(1800799024)(38350700014)(921020);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?q?+Fl/yIyDmFgIfnRxiIJB1odHUimN?= =?utf-8?q?n2Y4KzJL+bf/x7AF68FKViWuwBGFndEDl9LkX8Q0sjcKB4VIRtnkJvBa5rg71LFfb?= =?utf-8?q?jIYzCNJ0ocfC8kYRkMfIqfFkyOHNPgVjP3Fa9x75owFLo76a9jRgAF8mwwuUv0E1Z?= =?utf-8?q?vm66uhYLhhCizy7MDvfz5DxjhroVltFjuxIQr+wnzL8nbMjKsUQDNsaX2mVF5l7Ks?= =?utf-8?q?WhVUEolzR5ofzConJ4qHvN3egl4DjlU04apFur34C7m4iwTco00F+NljxeP85jIhT?= =?utf-8?q?Dgdb1AcmK+J4YcXc79MZLgJYwu3/98lsBBJ8dB2V8rqN7dqUyS5ECHy4e10vz6NpE?= =?utf-8?q?DpEoe2aLSjcYxAikuwsz0VvEcK4rSn5ZMlyQVIVf2SfwMxcsDVcn52qV1kXqSjUx9?= =?utf-8?q?vNoiDwHiypYEsr6StZJXXQRJAjmbCaRrlaQGtbSouqZEsAbKoqHwIyeYtkFtLg2Dc?= =?utf-8?q?Un8g5FTyVqR4N+U5TCU324RhZyIbh7LzvSYlzuC4M7XS/kRH3qwlbNZLD8o3whzU4?= =?utf-8?q?ImjNlPokwNEm9pDBPr0QNzl/lnXI+iBX6g++LXxLZN+VTWJHDGMxse8ZmylboNoid?= =?utf-8?q?aOnccf4Mt0OWHytzyMOqmS4EXcDu/VKzANUxx31ZBPgz9M8Aih5Eol2WsgOeT+SQf?= =?utf-8?q?kg/9BA+cKnBoTStc63XhASOQKW9fVubo9pixJ9JeSCxj0v1fNiuIsE9M6MJ6H9S1h?= =?utf-8?q?3iMU5RUw4xWlyJKNnq3RTFg+J8GEU+qYV1tvp+3BMFXzfevNdapiQGLHI9lhzcovl?= =?utf-8?q?l2r93bToBjCnXeKCtNsZnluSgit2c5fSytK4RBxrSrgPigEB5kziTWE5Z6f2aSS+k?= =?utf-8?q?IJ2cImWvz/L4QxKdzVXgMvah7SSZU/OETFwt5ufz+kpBt6+BJnYH4fozAGAklZbhI?= =?utf-8?q?Bgx+y9xfpPn8P0nhxNYkpjdlhw0NAySdtC9PVcLRiGp/CQ3rTsbqh7pVsfW3FZ1zd?= =?utf-8?q?IRLhGLIDkhi5JVidUrfDVl94+B8in+Vxm0jpAiTaYaucuqvxts4g/YS3p3mfKeVhG?= =?utf-8?q?ZoVPiG9PkzyAPQQYeUXDTbpTz9LLayFRTqP1x9SiRfX411Mff+0WfMtnwASZTOVLD?= =?utf-8?q?eepALHQrSN9DYq/MdbaqBXGqQcrRC9ii5mvo0DIoKhQ4zLZj7RtKuPjEhPTeIFiZ0?= =?utf-8?q?IA2i3syGY0O1a30oScGRQbM/rrOqgOqgEC3EWd9aQTpTR3eBz253j3k4S7BgXx/Cy?= =?utf-8?q?9yUEMrVRgDzy0O8M1v9FMNS8vs614PRqEo+vtTsthTRmYiPSTHuITu3uQnKuuswTW?= =?utf-8?q?2WrwyoWyXBAjtpG+2XZj1pf2qSNzv2SV+k91kNKvSb1DwwWtrfMxOcMQlhNV4/xcY?= =?utf-8?q?6jEPdeyHnHxK/8GCwOnR5FbENmtMhuL2I4/3mWnP33v+oMmXSvSZ3J+pj1Gk7cmdh?= =?utf-8?q?TCjyERx9CtJJk0a2PMct6C4b3OYe03mIGjqFeMKKbC+VR2Blpp2VlruGNYzazqkDC?= =?utf-8?q?EOP1fFk/nJdP8S76/hS3iveeTnRAX1E74nZwW1zcH7CNWmdIqR8kNxkMe3CsjQEnu?= =?utf-8?q?lxhCja4TeZBG?= X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 6c4de032-8c27-4160-fc33-08dd760da066 X-MS-Exchange-CrossTenant-AuthSource: PAXPR04MB9642.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Apr 2025 19:51:45.5484 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 09xSdF4sLvfT5EcIPKi2pbkxXXYW/wWvM3meFhBkP5BaRMe2yF2+Pkpd5vNpfvBBp+sx78MMknIGM5GvOTHG+Q== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PR3PR04MB7452 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250407_125148_882100_284AFAAA X-CRM114-Status: GOOD ( 12.91 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Set device ID as 'vfunc_no << 3 | func_no' and use 'device_set_of_node_from_dev()' to set 'of_node' the same as the EPC parent device. Currently, EPF 'of_node' is NULL, but many functions depend on 'of_node' settings, such as DMA, IOMMU, and MSI. At present, all DMA allocation functions use the EPC's device node, but they should use the EPF one. For multiple function drivers, IOMMU/MSI should be different for each function driver. If multiple function devices share the same EPC device, there will be no isolation between them. Setting the ID and 'of_node' prepares for proper support. Signed-off-by: Frank Li --- change from v14 to v16 - none change from v13 to v14 new patch --- drivers/pci/endpoint/pci-epf-core.c | 4 ++++ include/linux/pci-epf.h | 2 ++ 2 files changed, 6 insertions(+) diff --git a/drivers/pci/endpoint/pci-epf-core.c b/drivers/pci/endpoint/pci-epf-core.c index 394395c7f8dec..d04224b8e1631 100644 --- a/drivers/pci/endpoint/pci-epf-core.c +++ b/drivers/pci/endpoint/pci-epf-core.c @@ -120,12 +120,16 @@ int pci_epf_bind(struct pci_epf *epf) epf_vf->sec_epc_func_no = epf->sec_epc_func_no; epf_vf->epc = epf->epc; epf_vf->sec_epc = epf->sec_epc; + epf_vf->dev.id = PCI_EPF_DEVID(epf->func_no, vfunc_no); + device_set_of_node_from_dev(&epf_vf->dev, epc->dev.parent); ret = epf_vf->driver->ops->bind(epf_vf); if (ret) goto ret; epf_vf->is_bound = true; } + epf->dev.id = PCI_EPF_DEVID(epf->func_no, 0); + device_set_of_node_from_dev(&epf->dev, epc->dev.parent); ret = epf->driver->ops->bind(epf); if (ret) goto ret; diff --git a/include/linux/pci-epf.h b/include/linux/pci-epf.h index 879d19cebd4fc..1040d83740f9a 100644 --- a/include/linux/pci-epf.h +++ b/include/linux/pci-epf.h @@ -213,6 +213,8 @@ static inline void *epf_get_drvdata(struct pci_epf *epf) return dev_get_drvdata(&epf->dev); } +#define PCI_EPF_DEVID(func_no, vfunc_no) ((vfunc_no) << 3 | (func_no)) + struct pci_epf *pci_epf_create(const char *name); void pci_epf_destroy(struct pci_epf *epf); int __pci_epf_register_driver(struct pci_epf_driver *driver, From patchwork Mon Apr 7 19:50:57 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Frank Li X-Patchwork-Id: 14041894 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 45907C369A4 for ; Mon, 7 Apr 2025 21:48:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:MIME-Version:Cc:To: In-Reply-To:References:Message-Id:Content-Transfer-Encoding:Content-Type: Subject:Date:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=+xqxkgKvm1gj3A6xt5BIY8xtOtyrPDV5+Mm8vHnWShk=; b=PQsuSv1j5dPIVzQ9/f198xi5Gf TopGxVl5Xx6+Q/MuW07uHnP2Ar7pnQhm2OQ0zf57vE8V/hlvLeoVnAbCXUKKM18bn80ThZY7F9e8x aGZzLCil2pMgKdEZHyIOq1tztvHpT3kynWNhORYiOXZj/yBeO25I7SxQEsRVW9QOU0jECLCf0mtEF pYAcJJbbkN5QMa5pWh9ocTe/tcN/DkLU1iLslOCjBGAYyXRZfU4Ri5IPPw4CmbhYibpLkE7Fl7hay DiHo+5GTqLZO+FDrOt24SxCh4Qdq1XysBM7XtaxR7H2DLtUY/bPtfKPKZ4Nt8rS4k17FlCNj2HU/w MyR5vAoA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.1 #2 (Red Hat Linux)) id 1u1uJy-0000000267n-2tyi; Mon, 07 Apr 2025 21:47:58 +0000 Received: from mail-vi1eur05on2062c.outbound.protection.outlook.com ([2a01:111:f403:2613::62c] helo=EUR05-VI1-obe.outbound.protection.outlook.com) by bombadil.infradead.org with esmtps (Exim 4.98.1 #2 (Red Hat Linux)) id 1u1sVf-00000001sU0-1IwV for linux-arm-kernel@lists.infradead.org; Mon, 07 Apr 2025 19:51:56 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=Pplpb5pvxn0F6o8pzx0bfRBbO8N2a9rMQgKLFvFAtucg/QE9MFT1nXbtMuynrgBEECU9rbPmSou4eo3ZchzyvLVFWKmzEU6HoianwRRecNk7jaiNNuWXm+I+CHsNvR8N+I7v2C9x7y1FALL9J3g97cWW8IeU3OOhUKp+RHvEOLX+C3qVKWXd66Hv4qAIz/jv6UZW5NyKIzXqwsH/KfCQGNVwX7ueeT7dqzKdnoDhoC3l6Wv4fE07prYhWdvNWxryq4uk3hAAKYuOVfv+Auwkeeorho0xThUnN//D+ijtL804gwtcKYmrgh4UnWQhXzdL6FgKKAkGJiECyCJs6cDWgg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=+xqxkgKvm1gj3A6xt5BIY8xtOtyrPDV5+Mm8vHnWShk=; b=BNPUIF+Zv3zoaB8qcXZuG9jSUHV07jklHDpmQ1QtIZdP5eJ4Qv3YxLEzluH6TfIbMQZ7jzaawtDifCc2DgJ3xV6gEnuKqyiPe0+jqBxuMSFGfm/DMEO5n8QN5AqvGelFVk4i8sThgu3wSrUEgmwcsKc6ZU8E358FxuBxxTD7IW1Q7cUU28wrNcUKzKph83sNCS+z7KEwHvx3eI+gORK96j3zewf+PN7jvOy4+gNmkHm1WqxbxTvBETXfvrgy9TbtLZuZWatqkXsSec8H75XFJuS0VnLLS+pKF7IwkXGcc2AaWKk8a9VHRlWlM2BsieqxV4DX5+sX8Aq9Hzts6Qr1kg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=+xqxkgKvm1gj3A6xt5BIY8xtOtyrPDV5+Mm8vHnWShk=; b=EPPJ5Zt8j4mFsnZmULvylHXYejpGFiwYwzC4EudWNI6zGTuzvptfxec8R6AA30csU1hwZzwB+06Nb6AvudKQfnkPXZRdSGnfhYGPJkqgN0KaVLoymazasDTgW+6TDHEd7joMCjOy3cg9Euxf4ZUai/DxLdu74LPKGokbzAWGlSCCG+bIaZKdDRwOyXgydz1ErvQi31SL4jiJZd22y1vGt/Xot3iz454sKaLIYkmdY6FuUgWOTesv5VVu1dYSJqcXurd8wAkIi0DG+LHfYAg/zAfhlGeZOIzuCPWhuODQbgJ8mdoen8aOS3zT+fMMmT6NAtMXqQxurf7o+6RdACMj9g== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nxp.com; Received: from PAXPR04MB9642.eurprd04.prod.outlook.com (2603:10a6:102:240::14) by PR3PR04MB7452.eurprd04.prod.outlook.com (2603:10a6:102:80::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8606.34; Mon, 7 Apr 2025 19:51:51 +0000 Received: from PAXPR04MB9642.eurprd04.prod.outlook.com ([fe80::9126:a61e:341d:4b06]) by PAXPR04MB9642.eurprd04.prod.outlook.com ([fe80::9126:a61e:341d:4b06%2]) with mapi id 15.20.8606.029; Mon, 7 Apr 2025 19:51:51 +0000 From: Frank Li Date: Mon, 07 Apr 2025 15:50:57 -0400 Subject: [PATCH v17 07/15] PCI: endpoint: Add RC-to-EP doorbell support using platform MSI controller Message-Id: <20250407-ep-msi-v17-7-633ab45a31d0@nxp.com> References: <20250407-ep-msi-v17-0-633ab45a31d0@nxp.com> In-Reply-To: <20250407-ep-msi-v17-0-633ab45a31d0@nxp.com> To: Kishon Vijay Abraham I , "Rafael J. Wysocki" , Thomas Gleixner , Anup Patel , Kishon Vijay Abraham I , Marc Zyngier , Greg Kroah-Hartman , "Rafael J. Wysocki" , Danilo Krummrich , Manivannan Sadhasivam , =?utf-8?q?Krzysz?= =?utf-8?q?tof_Wilczy=C5=84ski?= , Kishon Vijay Abraham I , Bjorn Helgaas , Arnd Bergmann , Shuah Khan , Richard Zhu , Lucas Stach , Lorenzo Pieralisi , Rob Herring , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Krzysztof Kozlowski , Conor Dooley Cc: Niklas Cassel , dlemoal@kernel.org, jdmason@kudzu.us, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-pci@vger.kernel.org, linux-kselftest@vger.kernel.org, imx@lists.linux.dev, devicetree@vger.kernel.org, Frank Li X-Mailer: b4 0.13-dev-e586c X-Developer-Signature: v=1; a=ed25519-sha256; t=1744055468; l=8330; i=Frank.Li@nxp.com; s=20240130; h=from:subject:message-id; bh=zWJgc1SPoeJ2QBwxQHqDEE5KTaCTR3/w/iApYH7Ymro=; b=nyiPRymdCierydURI7G85DVyUcFwDYVhdXO19FuXKamDTweoqe/VNTOrbd5hce1x8SB2o070n 1U57YAJTyh+AtIsKns62s+iUTPPVLoKPBadcGpX+TGjCoqXKNajljmQ X-Developer-Key: i=Frank.Li@nxp.com; a=ed25519; pk=I0L1sDUfPxpAkRvPKy7MdauTuSENRq+DnA+G4qcS94Q= X-ClientProxiedBy: AS4P189CA0041.EURP189.PROD.OUTLOOK.COM (2603:10a6:20b:5dd::15) To PAXPR04MB9642.eurprd04.prod.outlook.com (2603:10a6:102:240::14) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PAXPR04MB9642:EE_|PR3PR04MB7452:EE_ X-MS-Office365-Filtering-Correlation-Id: 63b14766-e444-4fcc-54b6-08dd760da385 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|376014|7416014|52116014|366016|1800799024|38350700014|921020; X-Microsoft-Antispam-Message-Info: =?utf-8?q?fXcKMfLYaLQAattqJwb8W8Ot2FjJgjB?= =?utf-8?q?ibCTpYqakJpaPb0c/K/470+BCRlqtH766KrIbrOE/BzG5gYmZACjrVgL/jpMflcHQ?= =?utf-8?q?EulVcdlvk3cbb5N9i1ohPvwrgRJ7Jh7ExhvnyNnKx6YZATa/x98Joh+nr6GxaeRph?= =?utf-8?q?yUWqPSWzJdy49TBbgNRw3SAr7GNDOnORgIB0vuM+fPeu6P4GfqAM9BDxjiJkJrzWW?= =?utf-8?q?fnjo5kzI0bGgzcg75IwovRVjfBSwEq3UEq62rAF5Qli0AcnuIm0B49Ms+anzbr1VU?= =?utf-8?q?pOrOY3rvUir1+W1Rb7/nHZR6TKeYL4A6d4n5Ksrv+rqzYBxCnJymqVYDMmaGTyNKe?= =?utf-8?q?QzI8YdSiBnJZgaHBpx5v/KHhdc9ycXYuHocmnSAx0h1aAtynEk2Kyiov0J1Rw+gQ4?= =?utf-8?q?lWzyGz7FYS3EM3Na4VQS1gW/hmkp622vgro88rPMyl+qqUwG9/9DmRc5C3xcFDUyE?= =?utf-8?q?y1l8l3s1jN4Pkyi48/FOqlcZNpobc9GlrFgNcLyVmqj0R2ASeH+o9ntJ/HD+dJfa1?= =?utf-8?q?ezIA8dIzw3xlWct3NforNULqMSe6jfAfFR8aIb01JFD8Bm118C8O7ATpeHCaosf5s?= =?utf-8?q?Y0BhX2d8shLUPKs99/hNXGMavp1AtL52VIYD3byztkS/u9c+iUqqcCkp0a1fugb4L?= =?utf-8?q?tRUBnUxKnP81dWkiYR+JkVWZbhNcI2IH3qZRHAVQtAuBhJ5oXeuy8DW7MlrASNOH5?= =?utf-8?q?4L8k2CgBbMXgrV/JaszJ9oA/L/qc9wKDesfMLKgykMAWlVA+odPVTPcggkpPsmSbq?= =?utf-8?q?jjUpkC6TnGXCwzVR5dqUwFQ+X01KR5MOQbimgAD9LshGN9TTKDbjaCqmxis/PeStB?= =?utf-8?q?KDNgSmUpno2Km9TLNA10dT/SfcGG1zNTe63OGTg0Ng/EyGbLifzY4dSdjSQsF2Ism?= =?utf-8?q?SraX3rv5c0EacjrJDj87L4Xv1Giiuo4QfusRMdi+/ooousfnigX8MRFWno+AVRp5G?= =?utf-8?q?3HElErajsDO8Sg9CCAjV8QyAwBnSWyXtHHSrGMwzuIUQaA+efFJEa4TB4jETUAcII?= =?utf-8?q?30FoUqDrgKDYUjFRVTmPBoVsA6/sZDQb0U7DVAvju2d/GMEvc7pirgNxe37JUrUUk?= =?utf-8?q?sGIWKUPlR8bl9oLe8t1ceuBLfSwBiY+Ht5j+piiPc5OJIHLHFGNm2sG56l0KdOuHW?= =?utf-8?q?MV8xXJt20jquNAFXvSkzhexTjC/cFt+ra9s/zBJg9Q1I+Ffd3WwQ4W4I2GHawBozv?= =?utf-8?q?NJ+C+rq37Up8vl3+5UbEkAgVGyO2QrWCMIx0QhRVeY8caLhaXE8SMyGRkicHOOV6q?= =?utf-8?q?NfxDzTLhaQTx++tiWuOeoAVzIk8BkZyyrJV5ixqFjNeiMqfu8V/GsPVD9MJL+jIFH?= =?utf-8?q?l/wrC84SWtu+ghS/+CoVUDeUtyXlWzqJLPk7xQytkVyGObKtCeNejNlztfhpZhnYQ?= =?utf-8?q?B/eiULUu2yQW7eGxHyI5lxMv5E7jO1JcQ=3D=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PAXPR04MB9642.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(376014)(7416014)(52116014)(366016)(1800799024)(38350700014)(921020);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?q?G33T1ZpPm9zVdxErd9sn9zAxFUiW?= =?utf-8?q?eW97v/b1kCdgPHrecS6qCZJoi4/3xdQdgIOx8qkK1Ly6yQPbOplcuSQ3dTPXEInr9?= =?utf-8?q?glM3jYD4sFOyYYmDIhdfzaP4lizeoKvS/sVaKHzgnSVca5B3X5afEwhDEUj0P8Fgv?= =?utf-8?q?nho8xzx3nl9uwMrgpKUfqPU9ODqeC2Z1bkIHCSzuiSgfMMJQBWOPE9EHQfC5rZVSy?= =?utf-8?q?ojA6MdDY1oxI+694hZunGuqAPpftcyISOl1794LxSPn4eD4sJxWD2Q0K6BXygVuSv?= =?utf-8?q?2O2r99an94746PEcAfVXTSeDVTYoa2gdSYnBPd1Hj0Je8y6bS30bcPvq309f9nPEe?= =?utf-8?q?VSNUTv+LVJFN4OyqfEp+FvxJhJDGhmlBluTPE5w9G8oyulJgp9Fnj9TflIpglex0B?= =?utf-8?q?UX81RO/T1cEowFs4HGF5VWsT8XV760YK4I/SaGH3CprVYXBNXF3aQaGKp5dWWo5OC?= =?utf-8?q?njsHYHKwEIHujCDusx7LyLo636+GUCaDocbvYltKbFYrE+kd6EsbuY6Kc3kmJw0H5?= =?utf-8?q?YGtRS4IYlttvaki+bz/ZIhPJx2kmHTE+V8lL2UOcNsEgZTqkm6cKbtk6jk1xq7ahY?= =?utf-8?q?MnLm1Y8f2AB4SOCgp9kBN4LQiBqd4NPQHSEG+gPpUFJ2s0d6RI8coLdHXw765GeTG?= =?utf-8?q?UMHY6MBS4zA4ijHuuC3g1h4E3mlZFK3NKdBeLTuQJ3AMGaXT7km0XxdZRIQ7+Hlwb?= =?utf-8?q?G3F0c8eTXQIMWxu69OT0j6OOB5/rLeC4wUUKNoYsQmTdjszJ6HWG1g69QOKCggINZ?= =?utf-8?q?CXFjbYj6ze0HmNxQOGcTE6Zwik+wMcO/8hhVti7G2Wclqd/xSn16yeFaflfAPPLb7?= =?utf-8?q?McYUxHWixSqNRIx2NDh6DNyB2WXnW0l6lkhKhFpTZuFhhlb87c9zgfo9GCRZhqGOl?= =?utf-8?q?cDxNB4P+SnB9ffJZJBYw1H309Wcc5CuDf/YuOI+mMhJUzoVPwWmQo94iWpcBI6Tii?= =?utf-8?q?5YvLPcTDMZIeQsMmqX2ZmFCuKjH2Z6iFXOPOxIOu7fBWz8i7EXOIMczZJ0DBjtwbO?= =?utf-8?q?66JMuBRJXxFSBaFNP+MNpaxYDJjpz5TeLnzIiVMrpa4/kS4wssbYoPGoA7SFsCj1e?= =?utf-8?q?Vz2GQ4RvJ3MlaaZIos+zXas9Pw//mictqy4QFC3IHZf8gB+3AAt2SlKVwKVIxoJ3a?= =?utf-8?q?itxRVwb7Ny+dz8ZFPZAN7JYaS24shlHl9X42izKP8Md5snlk4inAZZdO8hBMvyPoO?= =?utf-8?q?QmSxlHbxCGeVvEGWLZtlI2t/dnaiu7weknuGOEh/D0569yqBtSsvfwMG72p9sJtdl?= =?utf-8?q?9GN8LlYIL8Uf3mhyxf69wNKtU2Bi06sw7WTHSjlKbXWxN0NT+2wI9NUCC17GqVjoM?= =?utf-8?q?LKl5ucvRyXEKoSUjCSYiJjsc9xKKG5bArKLMqCamFhucvERwPMxMfvDK6KSlH94h7?= =?utf-8?q?XHyNNzYB6QNc3noMTUosJb1g9B+TT4qc2hOZMmy12EwRTo4qOOqyBEhsGCr5WXu5I?= =?utf-8?q?zJs1GI5BKiwE7xCSQIL956XNkPn4R4ndIGHTqYm+8jZpTgx5Dq0Yn7XbuvT/2dHZ7?= =?utf-8?q?YCEsPwO540+Z?= X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 63b14766-e444-4fcc-54b6-08dd760da385 X-MS-Exchange-CrossTenant-AuthSource: PAXPR04MB9642.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Apr 2025 19:51:50.9429 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 5qx4hLbfvhkT23KyI3KwBT2GETc6hkEZH0Gx3iQY+pLB26zQHtAvFB7D/l9s/hGm3fJwmuapKzb+dUoR5EikMw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PR3PR04MB7452 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250407_125155_525568_EB0EFD1F X-CRM114-Status: GOOD ( 21.37 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Doorbell feature is implemented by mapping the EP's MSI interrupt controller message address to a dedicated BAR in the EPC core. It is the responsibility of the EPF driver to pass the actual message data to be written by the host to the doorbell BAR region through its own logic. Tested-by: Niklas Cassel Signed-off-by: Frank Li --- Change from v15 to v16 - fix rebase conflict Change from v14 to v15 - check CONFIG_GENERIC_MSI Fix below build error | Reported-by: kernel test robot | Closes: https://lore.kernel.org/oe-kbuild-all/202502082204.6PRR3cfG-lkp@intel.com/ All errors (new ones prefixed by >>): drivers/pci/endpoint/pci-ep-msi.c: In function 'pci_epf_alloc_doorbell': >> drivers/pci/endpoint/pci-ep-msi.c:53:15: error: implicit declaration of function 'platform_device_msi_init_and_alloc_irqs' [-Werror=implicit-function-declaration] 53 | ret = platform_device_msi_init_and_alloc_irqs(&epf->dev, num_db, pci_epf_write_msi_msg); | Reported-by: kernel test robot | Closes: https://lore.kernel.org/oe-kbuild-all/202502082242.pOq1hB1d-lkp@intel.com/ All errors (new ones prefixed by >>): drivers/pci/endpoint/pci-ep-msi.c: In function 'pci_epf_alloc_doorbell': >> drivers/pci/endpoint/pci-ep-msi.c:49:14: error: implicit declaration of function 'irq_domain_is_msi_immutable'; did you mean 'irq_domain_is_msi_device'? [-Werror=implicit-function-declaration] 49 | if (!irq_domain_is_msi_immutable(dom)) { Change from v13 to v14 - basic roll back to v9 - use device:id as msi-map input, its will handle it - use existed platform_device_msi_init_and_alloc_irqs() - pass down epf->dev point, because epf->dev of-node will be the same as epc's parent. Change from v12 to v13 - Use DOMAIN_BUS_DEVICE_PCI_EP_MSI Change from v10 to v12 - none Change from v9 to v10 - Create msi domain for each function device. - Remove only function support limiation. My hardware only support one function, so not test more than one case. - use "msi-map" descript msi information msi-map = ; Chagne from v8 to v9 - sort header file - use pci_epc_get(dev_name(msi_desc_to_dev(desc))); - check epf number at pci_epf_alloc_doorbell - Add comments for miss msi-parent case change from v5 to v8 -none Change from v4 to v5 - Remove request_irq() in pci_epc_alloc_doorbell() and leave to EP function driver, so ep function driver can register differece call back function for difference doorbell events and set irq affinity to differece CPU core. - Improve error message when MSI allocate failure. Change from v3 to v4 - msi change to use msi_get_virq() avoid use msi_for_each_desc(). - add new struct for pci_epf_doorbell_msg to msi msg,virq and irq name. - move mutex lock to epc function - initialize variable at declear place. - passdown epf to epc*() function to simplify code. --- drivers/pci/endpoint/Makefile | 1 + drivers/pci/endpoint/pci-ep-msi.c | 82 +++++++++++++++++++++++++++++++++++++++ include/linux/pci-ep-msi.h | 28 +++++++++++++ include/linux/pci-epf.h | 16 ++++++++ 4 files changed, 127 insertions(+) diff --git a/drivers/pci/endpoint/Makefile b/drivers/pci/endpoint/Makefile index 95b2fe47e3b06..c502ea7ef367c 100644 --- a/drivers/pci/endpoint/Makefile +++ b/drivers/pci/endpoint/Makefile @@ -6,3 +6,4 @@ obj-$(CONFIG_PCI_ENDPOINT_CONFIGFS) += pci-ep-cfs.o obj-$(CONFIG_PCI_ENDPOINT) += pci-epc-core.o pci-epf-core.o\ pci-epc-mem.o functions/ +obj-$(CONFIG_GENERIC_MSI_IRQ) += pci-ep-msi.o diff --git a/drivers/pci/endpoint/pci-ep-msi.c b/drivers/pci/endpoint/pci-ep-msi.c new file mode 100644 index 0000000000000..549b55b864d0e --- /dev/null +++ b/drivers/pci/endpoint/pci-ep-msi.c @@ -0,0 +1,82 @@ +// SPDX-License-Identifier: GPL-2.0 +/* + * PCI Endpoint *Controller* (EPC) MSI library + * + * Copyright (C) 2025 NXP + * Author: Frank Li + */ + +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include + +static void pci_epf_write_msi_msg(struct msi_desc *desc, struct msi_msg *msg) +{ + struct pci_epf *epf = to_pci_epf(desc->dev); + + if (epf && epf->db_msg && desc->msi_index < epf->num_db) + memcpy(&epf->db_msg[desc->msi_index].msg, msg, sizeof(*msg)); +} + +int pci_epf_alloc_doorbell(struct pci_epf *epf, u16 num_db) +{ + struct pci_epc *epc = epf->epc; + struct device *dev = &epf->dev; + struct irq_domain *dom; + void *msg; + u32 rid; + int ret; + int i; + + rid = PCI_EPF_DEVID(epf->func_no, epf->vfunc_no); + dom = of_msi_map_get_device_domain(epc->dev.parent, rid, DOMAIN_BUS_PLATFORM_MSI); + if (!dom) { + dev_err(dev, "Can't find msi domain\n"); + return -EINVAL; + } + + dev_set_msi_domain(dev, dom); + + msg = kcalloc(num_db, sizeof(struct pci_epf_doorbell_msg), GFP_KERNEL); + if (!msg) + return -ENOMEM; + + epf->num_db = num_db; + epf->db_msg = msg; + + ret = platform_device_msi_init_and_alloc_irqs(&epf->dev, num_db, pci_epf_write_msi_msg); + if (ret) { + /* + * The pcie_ep DT node has to specify 'msi-parent' for EP + * doorbell support to work. Right now only GIC ITS is + * supported. If you have GIC ITS and reached this print, + * perhaps you are missing 'msi-map' in DT. + */ + dev_err(dev, "Failed to allocate MSI\n"); + kfree(msg); + return -ENOMEM; + } + + for (i = 0; i < num_db; i++) + epf->db_msg[i].virq = msi_get_virq(dev, i); + + return ret; +} +EXPORT_SYMBOL_GPL(pci_epf_alloc_doorbell); + +void pci_epf_free_doorbell(struct pci_epf *epf) +{ + platform_device_msi_free_irqs_all(&epf->dev); + + kfree(epf->db_msg); + epf->db_msg = NULL; + epf->num_db = 0; +} +EXPORT_SYMBOL_GPL(pci_epf_free_doorbell); diff --git a/include/linux/pci-ep-msi.h b/include/linux/pci-ep-msi.h new file mode 100644 index 0000000000000..6dfbe9353f0d8 --- /dev/null +++ b/include/linux/pci-ep-msi.h @@ -0,0 +1,28 @@ +/* SPDX-License-Identifier: GPL-2.0 */ +/* + * PCI Endpoint *Function* side MSI header file + * + * Copyright (C) 2024 NXP + * Author: Frank Li + */ + +#ifndef __PCI_EP_MSI__ +#define __PCI_EP_MSI__ + +struct pci_epf; + +#ifdef CONFIG_GENERIC_MSI_IRQ +int pci_epf_alloc_doorbell(struct pci_epf *epf, u16 nums); +void pci_epf_free_doorbell(struct pci_epf *epf); +#else +static inline int pci_epf_alloc_doorbell(struct pci_epf *epf, u16 nums) +{ + return -EINVAL; +} + +static inline void pci_epf_free_doorbell(struct pci_epf *epf) +{ +} +#endif /* CONFIG_GENERIC_MSI_IRQ */ + +#endif /* __PCI_EP_MSI__ */ diff --git a/include/linux/pci-epf.h b/include/linux/pci-epf.h index 1040d83740f9a..dcc6e2a2c6b3c 100644 --- a/include/linux/pci-epf.h +++ b/include/linux/pci-epf.h @@ -12,6 +12,7 @@ #include #include #include +#include #include struct pci_epf; @@ -125,6 +126,17 @@ struct pci_epf_bar { int flags; }; +/** + * struct pci_epf_doorbell_msg - represents doorbell message + * @msi_msg: MSI message + * @virq: irq number of this doorbell MSI message + * @name: irq name for doorbell interrupt + */ +struct pci_epf_doorbell_msg { + struct msi_msg msg; + int virq; +}; + /** * struct pci_epf - represents the PCI EPF device * @dev: the PCI EPF device @@ -152,6 +164,8 @@ struct pci_epf_bar { * @vfunction_num_map: bitmap to manage virtual function number * @pci_vepf: list of virtual endpoint functions associated with this function * @event_ops: callbacks for capturing the EPC events + * @db_msg: data for MSI from RC side + * @num_db: number of doorbells */ struct pci_epf { struct device dev; @@ -182,6 +196,8 @@ struct pci_epf { unsigned long vfunction_num_map; struct list_head pci_vepf; const struct pci_epc_event_ops *event_ops; + struct pci_epf_doorbell_msg *db_msg; + u16 num_db; }; /** From patchwork Mon Apr 7 19:50:58 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Frank Li X-Patchwork-Id: 14041893 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 38996C36010 for ; Mon, 7 Apr 2025 21:48:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:MIME-Version:Cc:To: In-Reply-To:References:Message-Id:Content-Transfer-Encoding:Content-Type: Subject:Date:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=1IZAfUVaAOa7chBgO8REmAJsb14Zp8lXTUd7dS+omz0=; b=uW4E9dM+Z74Sl8799K+wVDW2+D AbeIDd8RrtNtr3tqjFeBbw9oxfQBT8VxHxaoD6xYFUWVC5UFilCmh3SxJIGF+s1kE/87SBgVdl5J/ pcM/Eb+boSywA3s8a5qpHX7uJBQwCo/4qalSvv+ZATHzUB+ofXhnR2FkUVd8/jkDh+OPWe5Rv9eyd 7ret8dM+KSZOmHadw6uUUVI0ZOwE6ifZEUyf5zX4ULJscPkuCF1SBJQqeMuNeFyMVbf1jsYdqO8kE Onx3bvLEHiDFQGpSKOooyoTnQL5+PorJokXeO6UcXZkzAaRrJMg23H6+KJpq4L31UnoF5ZO2ng/Ty rt0JWq8A==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.1 #2 (Red Hat Linux)) id 1u1uK1-000000026Bc-02fC; Mon, 07 Apr 2025 21:48:01 +0000 Received: from mail-db8eur05on2060f.outbound.protection.outlook.com ([2a01:111:f403:2614::60f] helo=EUR05-DB8-obe.outbound.protection.outlook.com) by bombadil.infradead.org with esmtps (Exim 4.98.1 #2 (Red Hat Linux)) id 1u1sVi-00000001sUU-35DT for linux-arm-kernel@lists.infradead.org; Mon, 07 Apr 2025 19:52:00 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=k91y7Nod0P5K8uWHTgCJfbPM0DlmqEHpMNEv2NeVtl1deFrZPPQUrh6mNNtYP+elNAxcvykeVmy50oxz+VTPEItI7B3oQK6cReRAJIQ/gQbeOHRsBhGTaT1uIWXCm2UBbAFOYxqNFa8KSNO5hHmD5LwNIKlD+VZpt1XqrCi37BK8ooHrtADmsEIjogWmf1NeJzINCbKsVbUlNhuEVNR2lR76ibZ922LmLrjnq/Kjw28aR7/d//FKoFxmTZn6ZzYsPYwtX5+zO3qdN0feV3ieuKFT5AheFZhCPCOfoxW0bYSf1FCtf12rAHxOyI5AhUfk3Druhs8yelftm5xzMjlJCQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=1IZAfUVaAOa7chBgO8REmAJsb14Zp8lXTUd7dS+omz0=; b=JRWe2Kggf9nxIu7yAK9oyMj+dr1XhfX0oWCFdvxEHXYUBCMty1spEnsSJm35UKWL/kVrjdE3ouSp3vKMOzaZ8g7AX2Cbb4ONuEt14qYPuVulBLsl/XrjYEPV/+XHidknmk8BmB68rnH3PTvNBDR2zanjHyypBceC1Qb9WtIboBOrr52+ck5vFHbXc7zCCwW/2SZLT98qY6PNgMTd7bUxC9ebbIx8N+aZucFTFUVitTUBW6vIHVciJKHs225v9i34L1Lw5LrPQcPsnHhE9XUMV35Fj2iOnBvJjTAeC2TTxe5zQn/oadGPIgsZlUv2z0GukblJ0m5COxDanDBQ2GF3pw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=1IZAfUVaAOa7chBgO8REmAJsb14Zp8lXTUd7dS+omz0=; b=VDNU7lWCNPP7oHaO05OgFRASCgE/1+LIjpElVBB9aElCrd94QcjidbLHX1KCvoJYojpxrEnVnMg6qxnuZMDskBHGWMiWzv8Ejg+PL2EnBXfPgW5UKZJeM4caDcRGKcs2SibmRxgIwlhQnpqRKX0GeTMEd56UcUvGxp1pOdiWFun1Anp9Zag81IL96ZFYX4OlwdzBTXIT8hMOHY8ifFdPqVC8WTmsTE9jwMLtIPnNc0nd1t1ScNNAYCzgk++dBV/bfLWWD+5zkE+rQU+Tb4/1iU8wfjYucP6u1SxqH3kksikgmS6zb5tcmMv4T8AfXpyGqbmOc/3uCjmSenkdt/69rw== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nxp.com; Received: from PAXPR04MB9642.eurprd04.prod.outlook.com (2603:10a6:102:240::14) by PR3PR04MB7452.eurprd04.prod.outlook.com (2603:10a6:102:80::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8606.34; Mon, 7 Apr 2025 19:51:56 +0000 Received: from PAXPR04MB9642.eurprd04.prod.outlook.com ([fe80::9126:a61e:341d:4b06]) by PAXPR04MB9642.eurprd04.prod.outlook.com ([fe80::9126:a61e:341d:4b06%2]) with mapi id 15.20.8606.029; Mon, 7 Apr 2025 19:51:56 +0000 From: Frank Li Date: Mon, 07 Apr 2025 15:50:58 -0400 Subject: [PATCH v17 08/15] PCI: endpoint: pci-ep-msi: Add MSI address/data pair mutable check Message-Id: <20250407-ep-msi-v17-8-633ab45a31d0@nxp.com> References: <20250407-ep-msi-v17-0-633ab45a31d0@nxp.com> In-Reply-To: <20250407-ep-msi-v17-0-633ab45a31d0@nxp.com> To: Kishon Vijay Abraham I , "Rafael J. Wysocki" , Thomas Gleixner , Anup Patel , Kishon Vijay Abraham I , Marc Zyngier , Greg Kroah-Hartman , "Rafael J. Wysocki" , Danilo Krummrich , Manivannan Sadhasivam , =?utf-8?q?Krzysz?= =?utf-8?q?tof_Wilczy=C5=84ski?= , Kishon Vijay Abraham I , Bjorn Helgaas , Arnd Bergmann , Shuah Khan , Richard Zhu , Lucas Stach , Lorenzo Pieralisi , Rob Herring , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Krzysztof Kozlowski , Conor Dooley Cc: Niklas Cassel , dlemoal@kernel.org, jdmason@kudzu.us, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-pci@vger.kernel.org, linux-kselftest@vger.kernel.org, imx@lists.linux.dev, devicetree@vger.kernel.org, Frank Li X-Mailer: b4 0.13-dev-e586c X-Developer-Signature: v=1; a=ed25519-sha256; t=1744055468; l=1143; i=Frank.Li@nxp.com; s=20240130; h=from:subject:message-id; bh=N/Rcdz4WASrCVzB40i3dK6NDhujmvhnmUfU9wknM7Kw=; b=x1agWhk/JrxhYpfxdC044J20GwJzerSWTXt1mhoHZX1kbec7aSPHPZePWBh2+4dzuvyMeX47Q LEVluQQR1YsARtlTMO+Kjqa8Vi1gks7s/5nboX74KBMhiFsuKiQCzmw X-Developer-Key: i=Frank.Li@nxp.com; a=ed25519; pk=I0L1sDUfPxpAkRvPKy7MdauTuSENRq+DnA+G4qcS94Q= X-ClientProxiedBy: AS4P189CA0041.EURP189.PROD.OUTLOOK.COM (2603:10a6:20b:5dd::15) To PAXPR04MB9642.eurprd04.prod.outlook.com (2603:10a6:102:240::14) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PAXPR04MB9642:EE_|PR3PR04MB7452:EE_ X-MS-Office365-Filtering-Correlation-Id: 1879ff02-e958-4c4c-1440-08dd760da6be X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|376014|7416014|52116014|366016|1800799024|38350700014|921020; X-Microsoft-Antispam-Message-Info: =?utf-8?q?Lvp5EWqItJWAGGXaTzA+WVoud6xDsfX?= =?utf-8?q?fpJa++f2g2TRAdPT4TZrD0zHWmQNCG9Fmxr3wZ/xc5YR/JAoJqLS4cvarTA3umGHA?= =?utf-8?q?3OKuCyE7jf0lgYoAC1UjYtGyNkjU4Xrktv8DGDSZRH0jmxGQJyhtAuhlAILxgCSvo?= =?utf-8?q?vhrbn85RoBKEgQWiJ20ri97wLXJRQGYNRzjM6kto5DqgvZO0ZRudjgpQfWMDUBEjQ?= =?utf-8?q?YgvsO+8Y3OtfHxo2Dwl22IO79TAautOvDZzCSUt4JcEd9lm/GK5k7rhDShMPOmP79?= =?utf-8?q?Mng8B1qJas8EvoTp7Z4iyg9OWKbLM9p72B2ikwYxxlo40Aq4i5eRPFBX7NcmIxRWD?= =?utf-8?q?Uwh8CcKSCK+P6bjq+4bsZOvwVnC32lckOP9QQGqLjBIUgTH6aOmjHUd3W2h4tAlUz?= =?utf-8?q?pAvJbLhnALNfJdu23Tq9eW4VjYmFRSjTUD7Zqce/of9RuPSOqNwe+add2NcQP1Ud4?= =?utf-8?q?GdFgqthsyI7PUkoltqYAj6m/jTmK158yrqMvl6R10u38P3eQoHn393GWbrafrM8ww?= =?utf-8?q?jB2OaQ1e0yPBqdSQKERkZuufe2Hl3V85l69kU4ZsK0vnWU3apyCBsNKSOCDpqZMZv?= =?utf-8?q?AHQWhOMlv7cw1U8827S3IRGyUglPQssIDLmiTU6X4v8P51MRpBW8aRyH8SkBYhNM4?= =?utf-8?q?lKko9PF76pCtBo5m9XfzmSU5kcDNwiAv/sIiITrMLZgTeUIsuVQBoeYm6gvMjhtnV?= =?utf-8?q?pXlznJ9Ag4kwKjbYgUs3EwCat/IBg17775/UkIKhVGqLUinaU528qK+hFW2ZtqFIw?= =?utf-8?q?N9ItQIdmXqN5Nh51aIU6PhCf9vXRA6CCT0Yj8h5wSAwgNY05cEkjS6loP9+9m3Y2d?= =?utf-8?q?NW9QkoN9l6mh9uclemXWCZl/ENkApdWGFiVG8B55XXPvcd1shuuI/ufTNAYq4XfoD?= =?utf-8?q?2nJGzvS2DxW4ll35tT6y6uaqkrZ/2B/hP+TumP4hURy4pYYhs7FcrkPuH5CKPvUq/?= =?utf-8?q?VzPA+xKFYcAzb9e0fSAIiMcRjk4ilXfTJeOCJ0lE53nKo9aSGe+DK4eY6VYSa00bg?= =?utf-8?q?sum/103QALnvdwhphvKQCUw7dJGARbQU0F/d0f966MY30hTuIc36aZYO0QSspqde6?= =?utf-8?q?mzp/hB/1Eze51z0CpH21DDLbE24mM1nf5XHSFqN2H8uALVTUL24iX1ojTcuXHJsr6?= =?utf-8?q?OqveAnpJgCz6HvUbf35K1oZdMmExPkWh5Qq/AidebhRLu9Sjs/ZeL6HTbPwYgtTpQ?= =?utf-8?q?Mw3fBUPjnnKGrmzAUVCUrKn+lTvf5z9jSU5kalamHRy2YA8cMydP/HQiin+C+mZWy?= =?utf-8?q?jtCf9m3JLL40+xekflsNnI6Ckj/d7BCpOIOloUBTrlXY8llPy83VE1k7wzSsEs175?= =?utf-8?q?MEOnPrj0yw+yavjWfvxfZI2GtG3bO0wjGI4wzAwwwCuhEvSgq37x/e32UZ13qQ1pv?= =?utf-8?q?eny8E/+nb4+jb80Z583D1DoNNWLkIph8w=3D=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PAXPR04MB9642.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(376014)(7416014)(52116014)(366016)(1800799024)(38350700014)(921020);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?q?NRFXaP3o+aNTXykn14Rq3iu/U3L8?= =?utf-8?q?l0gFE49bd/yGPte4R4XVF+Y1ZguijBX6J8/He6MHf0cyCow0ExI7/QviSjKOvjkAf?= =?utf-8?q?W6m7ZBdhRArAcTvor0YR/1DSXWqvEH2gboszxSDszjOzOJ9oCRLblNqmThNpT5o80?= =?utf-8?q?RoHLVp0op2EtG2marql4ruyhoHzgJcNVWF8MvsnOpVsw7C4F4qFQfsGq9r1DlmLrO?= =?utf-8?q?1eHQR/RN8jK1dD0s1VdxzGhAFPF1X3dDKTRI+oZYFQv7tblFGqdOujG457yXi9RRc?= =?utf-8?q?SL3DkHbx3BJNJLw+KRUj8KuW9TUoXoZwBie1tOqfwc58uRigjf22s8tnZj53Sniqj?= =?utf-8?q?05sCjkKjv1CEyqL1S7guWKnV1hZqk+pdTb3FvTRGjohJ+LGOp/tT/qMYDo/Oy5U3C?= =?utf-8?q?h17wRvTsA3OfimnMUfaflP0Q1aMcbypI49qvHeBJfMxA91Zg7AdIH3B21hT5ky/4c?= =?utf-8?q?WggkBzaRk8JXNQ9me8xGeBjf7Q5nGevdGLg6YnpTUm/Jw0mIgmmAGkKCp7A9pqN6i?= =?utf-8?q?Rv4XvhMI+H5fuaUMisbgeM8UMXD8LWjiVS4LT3CYVcxEBxmWa9k44h3+f7601poq6?= =?utf-8?q?RGpX20bY2T2ZQBroXQGVqWaZXPvwRpCZVPHm3BmJCuEfo3ohMB/d2DsrdJbz/4KiH?= =?utf-8?q?UQYt3jgBbchJ8TVq7B3L80Mbg5VZGLORAnzPXpjjVwkCh0iCiGD8cJZeENrVdvk4d?= =?utf-8?q?Pxq8FRDGUZ5q9z6LXU9RAN3yTxDiHDFhviYtNjD9S0lCSzjXfcc5pf/Zr+fy1/H2A?= =?utf-8?q?cCHiFFFxUg2VUMCCI28FekaKbyCKeW7WT7iLPnPWKrtEcF2EzaXBCD+w9tX9zV9NB?= =?utf-8?q?IXhdIFBJjVCyWxwpfMkGhob1ePI8aG8UlTleWvzCCQ4OByrAzoRKJGc9eXf2Wvlox?= =?utf-8?q?gjdNh9FHIupi4FhnjqUP8G19uGgZ8ESHpY1jB/A6pHQk/alrWffoDMIMim5TlS24N?= =?utf-8?q?sjXEak95uqXzcXYv97ICgbI/zjPSvFKXTUByS1T1EWVbdWjyypa9mQQdUOJbc/ixn?= =?utf-8?q?D/W9wpZLjhLYphuetK1CRglhbmp7bGMkZ/W09Lj0w4CzvbhXCUFnMR+JdMeBN6eTW?= =?utf-8?q?saLQXQNcaI/P82Ma9fau1YHXEflEjzn8AKgLlaVX2L4V6YmwRPIbIxvTbOFuDAqCr?= =?utf-8?q?c6WQmSxJn6H00E7eeWr9E0Hk1BZV3sS+QddMLwuWLc0Ser04AYK2xPB/Od+RbFlSO?= =?utf-8?q?JXmyl7vZN7m+FKwd+6ksHffnWcc8MwMEn0j0pW778mm+j7/7NHgK+Ou84PwFj7Ui4?= =?utf-8?q?t/oqAmWW3BJbBU/oChwFgNAvWJ07jEemLpSpu+TJfGsev5QmDPi+7VUYik5moq/L+?= =?utf-8?q?yd4UFobjQWHm/lrt9r5otAnVFSoPLi2DdTo7TKnOVITAp/XFIpDbanQ3LH6yVng64?= =?utf-8?q?/Y47LY9R4ETkpQClbmzd5/wU591UDWJZ7wXVTj4N6MrDrRNpYhrj0uKFtAXJ+sx2R?= =?utf-8?q?mAbr3g3uXUhB64EgEpnMEJYgADU3Cw0yXvnMiAzJZiuwKztbAYIBoABulhCiKM580?= =?utf-8?q?adUkBbM4B/H7?= X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 1879ff02-e958-4c4c-1440-08dd760da6be X-MS-Exchange-CrossTenant-AuthSource: PAXPR04MB9642.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Apr 2025 19:51:56.1958 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: ysVHIsQPVUDB45c+Ickd5wMO0qAjWmq3kldshgf1qcPx+VwIp6kmOnaczQJvig3eWvJmpBY76KhMeDkDqzaRNg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PR3PR04MB7452 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250407_125158_773095_773D703A X-CRM114-Status: GOOD ( 11.24 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Some MSI controller change address/data pair when irq_set_affinity(). Current PCI endpoint can't support this type MSI controller. So add flag MSI_FLAG_MUTABLE in include/linux/msi.h and check it when allocate doorbell. Signed-off-by: Frank Li --- change from v14 to v16 - none change from v13 to v14 - bring v10 back Change from v9 to v10 - new patch --- drivers/pci/endpoint/pci-ep-msi.c | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/drivers/pci/endpoint/pci-ep-msi.c b/drivers/pci/endpoint/pci-ep-msi.c index 549b55b864d0e..c0e2d806ee658 100644 --- a/drivers/pci/endpoint/pci-ep-msi.c +++ b/drivers/pci/endpoint/pci-ep-msi.c @@ -44,6 +44,14 @@ int pci_epf_alloc_doorbell(struct pci_epf *epf, u16 num_db) dev_set_msi_domain(dev, dom); + if (!irq_domain_is_msi_parent(dom)) + return -EINVAL; + + if (!irq_domain_is_msi_immutable(dom)) { + dev_err(dev, "Can't support mutable address/data pair MSI controller\n"); + return -EINVAL; + } + msg = kcalloc(num_db, sizeof(struct pci_epf_doorbell_msg), GFP_KERNEL); if (!msg) return -ENOMEM; From patchwork Mon Apr 7 19:50:59 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Frank Li X-Patchwork-Id: 14041896 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 815B5C369A5 for ; Mon, 7 Apr 2025 21:48:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:MIME-Version:Cc:To: In-Reply-To:References:Message-Id:Content-Transfer-Encoding:Content-Type: Subject:Date:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=u+qwraQmG61cZxMtmXO5VrRkCys/e7X2Bx0RuL0d/hk=; b=BFIYvL4hjR+edaAAhtFz8XOfEw dL9ycxCpLCjxOJPDgKYgfpDDfUwaTsYQVK7Rw/2wHLEeRZCxBVpfJf5tBnajS+iq+CUL1r18/CKer oOKpgGz8CIZfmEsj7ygqrLlpFuhKb6YI0mZMAzLgZKC/NyFgLuHkq1B9JUP+Y/xZ3LI8rrF2xmkIM VNfZhl+V5sX6L+jvlzGN4jlU82oE+IS7PRPzyPTssyLqKMw2YlCMYZGh66P/ahaZpwyaZ7Dk2R3UH czu2oEd3mcxouurxpEzA8XybBoT61g8NvwfVmMn3y56bkwYyviyuMjguBaP/6IrPEXVq3M6bB8Feq kf/1O7kA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.1 #2 (Red Hat Linux)) id 1u1uK2-000000026Ew-0vFC; Mon, 07 Apr 2025 21:48:02 +0000 Received: from mail-am6eur05on20623.outbound.protection.outlook.com ([2a01:111:f403:2612::623] helo=EUR05-AM6-obe.outbound.protection.outlook.com) by bombadil.infradead.org with esmtps (Exim 4.98.1 #2 (Red Hat Linux)) id 1u1sVo-00000001sVm-0ACw for linux-arm-kernel@lists.infradead.org; Mon, 07 Apr 2025 19:52:05 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=advJ3Yt4aIL43uXKbCX7tf9efx+fMZdo9UJ0KEVNDqZwUl7g9lmWfen3yTqFHHlWBlE1AvcS5d4Xa0NNz2fUGaGnmbeiazLAcjJZdU4Jbq9XcjDdhvU0ZrhwQf0bK5zTHxXte48jVTPde82L7bDn/nmPiie64YmItkrBZU61eO2v4xNEhvprVROwpQKGHG/Iz7F11QjDBZe1FX+B6sDAOiH7iQJfTk1tGlEajzqdBC3YTluXwfsOp6PckyvmN4BebGh2P4StC3tdSH1vCGuA8gx9cxepaRdK9XOey7ksPEBeW/eRls24Pi8zfdFq8X9IP621iqVFl6wUm868bt0qAg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=u+qwraQmG61cZxMtmXO5VrRkCys/e7X2Bx0RuL0d/hk=; b=cDTzUP7CwAnCIPv/7OsFKYWt29fFa+mMTP79GX6j5uqctvx5+Bc6kwzAJxs9T0PC6tqigJgOaLPQHfj4Ov1uG2CsYVllTnwTqvSKnD/RAaRzecManOaRe2v53lcPhUdUZcPOmLS0vPrsnXqIPv4ukTiRdUoiJ++WhbG9HlS957nFOma9PASM43jF+6rX8COqhfkkzw3wRPUrFINVs0Cx0ZQl+bdlTWDNIwWEViLtY5TVxhDsWvt3rZ9APRrQUCrB6UYuOwMTDlO1bdjmSYav6y4kV6ce4vHGSMQGq1jR9KbAJ5raJV16SkDk30CkpvKUPUsKA7cCqch5AE5ZBeWqSg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=u+qwraQmG61cZxMtmXO5VrRkCys/e7X2Bx0RuL0d/hk=; b=cHQ+Kjx5xgcsntn83ZBrKhVchIaok/IcdZmqb8BsL26uDtc5tz8PYhcHTLqXssd/2eLBxCMUuOs4E6/5x7YyKv4Iqv+2fOmwM/sBedjG69yHP8Z4s6Rc+7tmIL1WBxJeMQYUMsRXQpA4Eqcj1X2AFnQkQR2vlYaiYZxYpFRSCbpz0cOseyfhW6Vt83Z4ERqE4QEgY3FugyLnD5golgAII4HgWspRasbOfmLgAs8cT9MmWbsW/r9VPCNZL556U084/874d4XD/qJM+gFXjtVLoqDPOaXEq7pMOBqNHZS5PAI2v7LrPnVrsCGPXtPnmBd5sii2mHqBNFl4Pu/M/3pHvw== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nxp.com; Received: from PAXPR04MB9642.eurprd04.prod.outlook.com (2603:10a6:102:240::14) by PR3PR04MB7452.eurprd04.prod.outlook.com (2603:10a6:102:80::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8606.34; Mon, 7 Apr 2025 19:52:01 +0000 Received: from PAXPR04MB9642.eurprd04.prod.outlook.com ([fe80::9126:a61e:341d:4b06]) by PAXPR04MB9642.eurprd04.prod.outlook.com ([fe80::9126:a61e:341d:4b06%2]) with mapi id 15.20.8606.029; Mon, 7 Apr 2025 19:52:01 +0000 From: Frank Li Date: Mon, 07 Apr 2025 15:50:59 -0400 Subject: [PATCH v17 09/15] PCI: endpoint: Add pci_epf_align_inbound_addr() helper for address alignment Message-Id: <20250407-ep-msi-v17-9-633ab45a31d0@nxp.com> References: <20250407-ep-msi-v17-0-633ab45a31d0@nxp.com> In-Reply-To: <20250407-ep-msi-v17-0-633ab45a31d0@nxp.com> To: Kishon Vijay Abraham I , "Rafael J. Wysocki" , Thomas Gleixner , Anup Patel , Kishon Vijay Abraham I , Marc Zyngier , Greg Kroah-Hartman , "Rafael J. Wysocki" , Danilo Krummrich , Manivannan Sadhasivam , =?utf-8?q?Krzysz?= =?utf-8?q?tof_Wilczy=C5=84ski?= , Kishon Vijay Abraham I , Bjorn Helgaas , Arnd Bergmann , Shuah Khan , Richard Zhu , Lucas Stach , Lorenzo Pieralisi , Rob Herring , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Krzysztof Kozlowski , Conor Dooley Cc: Niklas Cassel , dlemoal@kernel.org, jdmason@kudzu.us, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-pci@vger.kernel.org, linux-kselftest@vger.kernel.org, imx@lists.linux.dev, devicetree@vger.kernel.org, Frank Li X-Mailer: b4 0.13-dev-e586c X-Developer-Signature: v=1; a=ed25519-sha256; t=1744055468; l=4364; i=Frank.Li@nxp.com; s=20240130; h=from:subject:message-id; bh=Mp2cXn9FsMWsG/hvucQeIBBPPQdjWFLzH+Ukbq7aPzU=; b=bu7W0Gd7iqvfen6lNHjsKxdp4mp6yDtX2bwdge7ROfaPPW3yvQyRvV0mGPIi04ZeV+9fRgK0Q eSIsYrSQT8vDiX6Mgvl4YU3pnHhzoGuo8obByiuVlODe8X8CtMmjymt X-Developer-Key: i=Frank.Li@nxp.com; a=ed25519; pk=I0L1sDUfPxpAkRvPKy7MdauTuSENRq+DnA+G4qcS94Q= X-ClientProxiedBy: AS4P189CA0041.EURP189.PROD.OUTLOOK.COM (2603:10a6:20b:5dd::15) To PAXPR04MB9642.eurprd04.prod.outlook.com (2603:10a6:102:240::14) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PAXPR04MB9642:EE_|PR3PR04MB7452:EE_ X-MS-Office365-Filtering-Correlation-Id: 078c17ba-dc83-469d-6514-08dd760da9e2 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|376014|7416014|52116014|366016|1800799024|38350700014|921020; X-Microsoft-Antispam-Message-Info: =?utf-8?q?Mgpk4+SNFPILx02lFhBRELHK5Ip98vd?= =?utf-8?q?4uXJ8DqRTrwUZAEBB2QEbfszu04LOv699uUgTQZk3vDfhRPdQWNF614Z/o7OnjCr/?= =?utf-8?q?9EyZ8fl4kRGQWrukxm1wosA1KPKb9aW+6EunVK2UD6m9g2MUGpwYokJ6rmUo95+xl?= =?utf-8?q?4ng1/MIn0qhVA5BRhPMZq/utuj1FI0p4/LZbZZ4QVTmowUEizriaqR6C4jMi5EUM5?= =?utf-8?q?5BvKzvqWXIFgz4iZloXqGm5besicB4aIrPfjvaLymRd2QJ/H/B6lhqgm73blRUpFB?= =?utf-8?q?hEv9W3t3ueDe3KGproVYrp7ksFpSgx5F6ia+OGa5VuRxMAQtgnC9+d0FiT++VcO4y?= =?utf-8?q?7xHb1QUXqA7uKe4WZUtFqGF3OL1X8KCHuMFOKRxViQXDLn7dzNZC2zkuowagWpGUg?= =?utf-8?q?16gi7LnRqEA8k1rH634GeUE6NUpw/mnZPB7JKyKhRC7RhMlR8kM01DL6sHdpgppp+?= =?utf-8?q?uWz3kSlhhRjPs9uPGfkNvfZaeVeRc/d0s2P0Pf3dDC8R22rLnORAWGKPr7iLfbIEW?= =?utf-8?q?pjF3vg7CZNwYCHglkAehpeYuJKauFfGxwsOw+GbOoYJAXBosGL1tmOwrcEqCDVPxD?= =?utf-8?q?RNl8dtyqHoVt/tjHuZp2F//bhSUMOYU8qrx0Pbm7lkQnUV1epSU7VsPfr9OKravdm?= =?utf-8?q?9DRk612rSCItRkTlfruqSu6jIP+M6AmIsZgmhk2VjqKFhvHT6nxaWeuHlQ05k2CMx?= =?utf-8?q?/aNkQvqRfm+pczhCawpU9GLQ7ffz/6XJugRWJELcsQtpz9UJ1GjA54Q4Jx4hNUID4?= =?utf-8?q?H1zzZX1b3Jq9ihMcACpBunwV6/o3oeH4t73js610jAOdXz03MzZeNhBlmKyNGOXA/?= =?utf-8?q?QynOaRsu9rHO7nV6RvV0xj1ndfxvMKGp4WNRRS3XwQccCq2+WU0YcTdL+GrY24UXL?= =?utf-8?q?HAmyChcQPaVkQl3W4seLOOLbC5LW9Es+4dJta66jZg/teQgna7byxN8OCr7rcLQKn?= =?utf-8?q?+WFjRFpVebFIUukv37TAgGNh47P+d9gZbxNZgquYJLHzNyY3HdV+nKAzVq8gXLypl?= =?utf-8?q?SQSqB5zO8yPrfj5MvmiyKnoMExBwW2wyEyvtKfrDE91wfUeDw9XLk6e3aYQdm35lV?= =?utf-8?q?EmrFOaHA1yMthJlcT64GxUJZw0Hva0G2Gm2S7KdTZa33vy1lkBuzfu0VvxouABOHD?= =?utf-8?q?9zeeRmLYoGPpbzSDZI2+bjWkHZYo8wrwvrLSJWkalW3JqKQfAPNG0cMIylLT7QraL?= =?utf-8?q?ylYm23CoDcMTmqmdClk80YheCT/Wwg+Ht4NsuWo8lCNBKZneTuGB49K17RQtj6fNb?= =?utf-8?q?u+oW2WZwyFXgl3ZOSxtgeR0p+mFaCVHBJxJm6Oftwab2STVrg/JfGSSs3MjjS5SPK?= =?utf-8?q?Rp4zkBZlWR2Qes4gUC0VkvqbUgr/yXZ3wqYPIcI8t29QH4esMfu3LMVta5KrdMfVK?= =?utf-8?q?/DyE6fSpUEE5iZ328Qb2wGi2NU3ywOHOg=3D=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PAXPR04MB9642.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(376014)(7416014)(52116014)(366016)(1800799024)(38350700014)(921020);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?q?nq5TSP1ZPnj5wLbY7y75dYKTDbsf?= =?utf-8?q?pDEr5RVz7uLp3LN9YZ6LMzy1UAQmUJU2Ao16YzpYY4D2Ceh1SY/JupIBVTo4qs7zb?= =?utf-8?q?D/XQ9XGHYve08mGlaty54D0V/4SnYrUin2JoLOa4kY7RgsekPF0j8t6og2kRfHSs1?= =?utf-8?q?XxL6OjJb870/Jq+v9krKnzxA6zzMELoy33Qh5sZ9KWL9s42wg0stqsJQifu4K0dzl?= =?utf-8?q?1BJclYXsVR1H1Ee9rqIAlhBu/03ZF4BUp+b1820F1HOfn2mqRiqCYmKepGBaDTH7E?= =?utf-8?q?ud20WTxpcMqHdT5su9gwSZIFIv6HeDPGEkB4GfJnNkd9ATSOq4UDihBUF6FnPYjTH?= =?utf-8?q?irHpCEAtTuzTVdLAeCb/DOQhSQmBnNHBHoFfwfQTauMIHuVZSqMiNTyYbanIGwigl?= =?utf-8?q?cSRLNfTO1GSG5Lou6SJJG8ktuba6SyoYXcIjUE0gGyWIZiINVByZfjXgDV7NBI5rQ?= =?utf-8?q?wltUc2EqERAsCqpMLDgWEtU3yLjBv33KcVv58bJG7zRM6K/2damS7sq0mbmVWxNDL?= =?utf-8?q?kLa+6m2R7V2jghM3wiLlku8fPr33zxR1ZVBScvw4ntK8GICx3Hl46ohGnhOrTN4xc?= =?utf-8?q?mqXdjwVKHfcuDD0C1VQ2zPiXA1m9w1lyWc0IvUO+whZmhA/9KzvxHq5NnqqHKzDsj?= =?utf-8?q?eivJxkbXsgNMj7B4+3kDdOnC+Ay/iQt8eO2XKBNawrwbMIGP0XJs8pJ9OGfoqzUHV?= =?utf-8?q?kGYTzHxy5xaVpFDoauhLzSx3ewkyIQILmLR4QzplfCats+iZ9+drOWff8mULWlWN9?= =?utf-8?q?OJXdg2riV2ldw37AFo0EctMzGKR7H2bUg7MgKsRjRhIDFuj6Ns88n54eOkrwwPCuo?= =?utf-8?q?/6GmoYAY4nuXicLTVa028DU6b2m/HnGGCLbhpcGaUH/mcMDEFTPY3Om5VxysecX1N?= =?utf-8?q?fC6ppX6cHPFHrz8yoSN4CmgrDlRiNwd0zFie14vLkUTBnDFPY7F4Rp7pJVC6x2KCd?= =?utf-8?q?KV4LGRGYdouDG+UINvgzMfalrq2VP6IPax5woHfkb8j8Sfp4kFwyoCLfDS4ibOxG2?= =?utf-8?q?s0BDSU9F0otRD52Dp36n+o1m59NwZZH864jliA/31y+O8S0xBE8Xrn3Burvb2T99M?= =?utf-8?q?HO1lSQ+xkB2wSoel33n2p0NeuT2KxpbyCmBIsCj8VTXUgTttI+hv6OJ9rMcXUGJHi?= =?utf-8?q?p86MLHofDR2xAx8x5YBr+wiDOfB8tiD9/tnDVDIy/rlmgszkedCsHCSMESPXgnvoJ?= =?utf-8?q?4VcEbHustRDezge4qiF4cR/f1ZmL7bfpEqi7ECG1XXUXkRTY1skhRAa52eoBRw6XS?= =?utf-8?q?7WGLILnxQnynRBIlEL02PPYZzgFsB53+0IGxWhTuV4rRkg7B9/l+ggcp+G0TiYbeY?= =?utf-8?q?hiBZlSj1aNlQTHCuVMxQS8TPomlMck617/U6T0nEF/JLLx/XqzM9J5dMxGz/K/w6s?= =?utf-8?q?XyOnVV21P1YVW2x9zVddEpc726QEz66wa+5rPpyrK+ytgnO3HvrDRc2FWUebHST3v?= =?utf-8?q?h6+OYFTJ78gDpsf1lEpP+ky8zn4bU/3uX/pZWpJ5dF0GYkkDeMwMvUMCbliyLnTLZ?= =?utf-8?q?NnAPNkTGR3o2?= X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 078c17ba-dc83-469d-6514-08dd760da9e2 X-MS-Exchange-CrossTenant-AuthSource: PAXPR04MB9642.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Apr 2025 19:52:01.4606 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: TgXSQ8t8/IAczhTv+Iwzk4f8MJvh3wAiL3Q7bWDhP9jFXE+iYJE7g+jh5WJ69yDQIouZoDwS3gvc3DjetwLy1A== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PR3PR04MB7452 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250407_125204_229998_788DD004 X-CRM114-Status: GOOD ( 19.54 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Introduce the helper function pci_epf_align_inbound_addr() to adjust addresses according to PCI BAR alignment requirements, converting addresses into base and offset values. Signed-off-by: Frank Li --- Change from v15 to v16 - none Change from v14 to v15 - change out address type to dma_addr_t to fix below build issue | Reported-by: kernel test robot | Closes: https://lore.kernel.org/oe-kbuild-all/202502082311.G1hWGggF-lkp@intel.com/ All errors (new ones prefixed by >>): drivers/pci/endpoint/functions/pci-epf-test.c: In function 'pci_epf_test_enable_doorbell': >> drivers/pci/endpoint/functions/pci-epf-test.c:726:42: error: passing argument 4 of 'pci_epf_align_inbound_addr' from incompatible pointer type [-Werror=incompatible-pointer-types] 726 | &epf_test->db_bar.phys_addr, &offset); | ^~~~~~~~~~~~~~~~~~~~~~~~~~~ | | | dma_addr_t * {aka unsigned int *} In file included from include/linux/pci-epc.h:12, Change form v9 to v14 - none change from v8 to v9 - pci_epf_align_inbound_addr(), base and off must be not NULL - rm pci_epf_align_inbound_addr_lo_hi() change from v7 to v8 - change name to pci_epf_align_inbound_addr() - update comment said only need for memory, which not allocated by pci_epf_alloc_space(). change from v6 to v7 - new patch --- drivers/pci/endpoint/pci-epf-core.c | 44 +++++++++++++++++++++++++++++++++++++ include/linux/pci-epf.h | 3 +++ 2 files changed, 47 insertions(+) diff --git a/drivers/pci/endpoint/pci-epf-core.c b/drivers/pci/endpoint/pci-epf-core.c index d04224b8e1631..529dbaaf76750 100644 --- a/drivers/pci/endpoint/pci-epf-core.c +++ b/drivers/pci/endpoint/pci-epf-core.c @@ -473,6 +473,50 @@ struct pci_epf *pci_epf_create(const char *name) } EXPORT_SYMBOL_GPL(pci_epf_create); +/** + * pci_epf_align_inbound_addr() - Get base address and offset that match BAR's + * alignment requirement + * @epf: the EPF device + * @addr: the address of the memory + * @bar: the BAR number corresponding to map addr + * @base: return base address, which match BAR's alignment requirement. + * @off: return offset. + * + * Helper function to convert input 'addr' to base and offset, which match + * BAR's alignment requirement. + * + * The pci_epf_alloc_space() function already accounts for alignment. This is + * primarily intended for use with other memory regions not allocated by + * pci_epf_alloc_space(), such as peripheral register spaces or the trigger + * address for a platform MSI controller. + */ +int pci_epf_align_inbound_addr(struct pci_epf *epf, enum pci_barno bar, + u64 addr, dma_addr_t *base, size_t *off) +{ + const struct pci_epc_features *epc_features; + u64 align; + + if (!base || !off) + return -EINVAL; + + epc_features = pci_epc_get_features(epf->epc, epf->func_no, epf->vfunc_no); + if (!epc_features) { + dev_err(&epf->dev, "epc_features not implemented\n"); + return -EOPNOTSUPP; + } + + align = epc_features->align; + align = align ? align : 128; + if (epc_features->bar[bar].type == BAR_FIXED) + align = max(epc_features->bar[bar].fixed_size, align); + + *base = round_down(addr, align); + *off = addr & (align - 1); + + return 0; +} +EXPORT_SYMBOL_GPL(pci_epf_align_inbound_addr); + static void pci_epf_dev_release(struct device *dev) { struct pci_epf *epf = to_pci_epf(dev); diff --git a/include/linux/pci-epf.h b/include/linux/pci-epf.h index dcc6e2a2c6b3c..299ce1f1e2d80 100644 --- a/include/linux/pci-epf.h +++ b/include/linux/pci-epf.h @@ -241,6 +241,9 @@ void *pci_epf_alloc_space(struct pci_epf *epf, size_t size, enum pci_barno bar, enum pci_epc_interface_type type); void pci_epf_free_space(struct pci_epf *epf, void *addr, enum pci_barno bar, enum pci_epc_interface_type type); + +int pci_epf_align_inbound_addr(struct pci_epf *epf, enum pci_barno bar, + u64 addr, dma_addr_t *base, size_t *off); int pci_epf_bind(struct pci_epf *epf); void pci_epf_unbind(struct pci_epf *epf); int pci_epf_add_vepf(struct pci_epf *epf_pf, struct pci_epf *epf_vf); From patchwork Mon Apr 7 19:51:00 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Frank Li X-Patchwork-Id: 14041895 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 8157FC369A1 for ; Mon, 7 Apr 2025 21:48:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:MIME-Version:Cc:To: In-Reply-To:References:Message-Id:Content-Transfer-Encoding:Content-Type: Subject:Date:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=kKlGqegoRweF1++Jqh2S5594pr64Kj2EekHsAJSq3y8=; b=x7GmDa+F4EsoN0QXtOWVfQVzCy xTgQZGor7WHUTb/kpqkGvteY0yhuBQ7VWAQTOkV7/8b+VwprPLg2xBP9lwlnN2CAkUCpdd96cfxNC 2EdC7Deo6XrdmlcJJpXBqZK/hi1U7jBvtxH6mwsO2ee1ThhgGfaXpMvPq3/PaAdO9uRkuhtnK9rzn 76WxBg7BDkG7qQ6mSGBbkZxXpG07eAD2FhI8UOBMmaTHyuXEyTYHePlMl7HLuadEPauGuGtqxyVXI K2RNYOIU7fxgpqATAGrBgTn5+fx1gw9b83KiLOq57fBa86owaeDfYkbm9LWmFdaQ4bWHpQOz3BAqY u5zEvthg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.1 #2 (Red Hat Linux)) id 1u1uK3-000000026HU-1XWm; Mon, 07 Apr 2025 21:48:03 +0000 Received: from mail-db8eur05on2061e.outbound.protection.outlook.com ([2a01:111:f403:2614::61e] helo=EUR05-DB8-obe.outbound.protection.outlook.com) by bombadil.infradead.org with esmtps (Exim 4.98.1 #2 (Red Hat Linux)) id 1u1sVt-00000001sWy-0wx6 for linux-arm-kernel@lists.infradead.org; Mon, 07 Apr 2025 19:52:10 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=W0DjktY4ZR9fjVTvV3baX00VJ0S7tZuj2Zw3v2e/glhXMopZzf5/qLGp2yREa/4aRvQsqLP9X9jflOnhu/NC6xbCckJlEzGnylNlSUC6I7R9vSWSFToHZde7PjN+3KgddMVeEY/d8JAwUrvYg0hFn25POw2Mx04bDMSiWuZlIKEhRCHSWz9JWI9/q1RsKfhODGUhcThzMQSaHTlAj6LkWZXpEFzyFD2GL3eDtzxp7fqynN4mX7fqCJ3GmLG1K3dC6uL4AUOuQc76YSQxX/wEvec3M1bj9FTtwBvjbdrWteHmKBBRzWEDKdb51Stjclzk5wR8Ri9HluEzsowZGBj+Pw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=kKlGqegoRweF1++Jqh2S5594pr64Kj2EekHsAJSq3y8=; b=tt6YYDAq6uEeuT/zeG93WpmG80lpnr/HxxdfWQ/zjsBaTTLOt5727ELJfRWuvV/ukD4cwaEmGE+Vs1SMILIbHk2Oht2u6uhiOu43sqPFkn+6YzZj1B3ObgMMydmvq5XWnyXgb2CwynhbqV//xedVqBW0wZ1VA/MccaHbrWcRSjPH3vpRapMrcNUgZsOTk0xNDRnPj4AmzE4EJ6eTx5X0l3/axt0n0k7SRTW5eyR3l7ta1WPR+ymUPb9k+pEeJJgNvtIPfJBxMy/QG7IIb3Orwxe+hQXd1wpX9rpgFitrqyyAZ36BQVNFOyX7t64CNl2AmRXfAlhX0GjSAUMXCTipqw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=kKlGqegoRweF1++Jqh2S5594pr64Kj2EekHsAJSq3y8=; b=S1bgTBOxF+w7153eM4HeNssbO6JWlmpvryF/CVVacaq1BNDe9ld5uPasbQe05MPrY3w2DMeNnxUShrA8exjBKp9qtjY5BK8Hc0Fsvkae08Xx0uivRhIizu32pQICCDoLMa5aBglhvgUCEA0EnoiVYa0rQtrpoPO1IHIrswxKmKEfn4AXFA3AybKlO9PPTl3hg2APVsAqUZfmb9LmZzSrrCElgldcvBJABA9HaGVGONWkjg0UAkpiIXG+G4cgAGi8/wRPMSgR5x7gi5nKr/yqY6yUYD8aKJsd6yVYaFIaPno9tvcTEs3Dfl/8FT8EF9vkSTqczYYJq+t8jWQcjayEgA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nxp.com; Received: from PAXPR04MB9642.eurprd04.prod.outlook.com (2603:10a6:102:240::14) by PR3PR04MB7452.eurprd04.prod.outlook.com (2603:10a6:102:80::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8606.34; Mon, 7 Apr 2025 19:52:06 +0000 Received: from PAXPR04MB9642.eurprd04.prod.outlook.com ([fe80::9126:a61e:341d:4b06]) by PAXPR04MB9642.eurprd04.prod.outlook.com ([fe80::9126:a61e:341d:4b06%2]) with mapi id 15.20.8606.029; Mon, 7 Apr 2025 19:52:06 +0000 From: Frank Li Date: Mon, 07 Apr 2025 15:51:00 -0400 Subject: [PATCH v17 10/15] PCI: endpoint: pci-epf-test: Add doorbell test support Message-Id: <20250407-ep-msi-v17-10-633ab45a31d0@nxp.com> References: <20250407-ep-msi-v17-0-633ab45a31d0@nxp.com> In-Reply-To: <20250407-ep-msi-v17-0-633ab45a31d0@nxp.com> To: Kishon Vijay Abraham I , "Rafael J. Wysocki" , Thomas Gleixner , Anup Patel , Kishon Vijay Abraham I , Marc Zyngier , Greg Kroah-Hartman , "Rafael J. Wysocki" , Danilo Krummrich , Manivannan Sadhasivam , =?utf-8?q?Krzysz?= =?utf-8?q?tof_Wilczy=C5=84ski?= , Kishon Vijay Abraham I , Bjorn Helgaas , Arnd Bergmann , Shuah Khan , Richard Zhu , Lucas Stach , Lorenzo Pieralisi , Rob Herring , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Krzysztof Kozlowski , Conor Dooley Cc: Niklas Cassel , dlemoal@kernel.org, jdmason@kudzu.us, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-pci@vger.kernel.org, linux-kselftest@vger.kernel.org, imx@lists.linux.dev, devicetree@vger.kernel.org, Frank Li X-Mailer: b4 0.13-dev-e586c X-Developer-Signature: v=1; a=ed25519-sha256; t=1744055468; l=8739; i=Frank.Li@nxp.com; s=20240130; h=from:subject:message-id; bh=GZxnLuC67KA9+f1ZFFupamn6BH671XQaImre37vE7/Q=; b=G1y6ZNLM9mWS55DqIMI5QiC45Wq4mZe5ca3M9jQw9S75HY429CPq+WwLzN/uU/mNDy0MRRbVx wqbn+o3LMwFBJTlbmKZIZ9zAR4a1hPlBUE70oQm4ZWbZOufxQXnG5/N X-Developer-Key: i=Frank.Li@nxp.com; a=ed25519; pk=I0L1sDUfPxpAkRvPKy7MdauTuSENRq+DnA+G4qcS94Q= X-ClientProxiedBy: AS4P189CA0041.EURP189.PROD.OUTLOOK.COM (2603:10a6:20b:5dd::15) To PAXPR04MB9642.eurprd04.prod.outlook.com (2603:10a6:102:240::14) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PAXPR04MB9642:EE_|PR3PR04MB7452:EE_ X-MS-Office365-Filtering-Correlation-Id: 4f1d7dfb-9567-43aa-6624-08dd760dad09 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|376014|7416014|52116014|366016|1800799024|38350700014|921020; X-Microsoft-Antispam-Message-Info: =?utf-8?q?/SE28wyoDk9C1RdqTAK2fSPla/LDc/w?= =?utf-8?q?As2aX4VGYaVaIM+qVu5wFCWuqdalQdTwScWSt5A9racG+vjoTUWPRcoUtYmwWlaBc?= =?utf-8?q?iRxnjw7mJN+Ir1ZBg6tgKvRjGOaZ/aLAfp2+b8JbsHKZ9Prk2gTJ2EbdHH41I6fgQ?= =?utf-8?q?yke/rHrLK+931LwTDhZ1YpydFn4sp9oN31ebOl37ozZF+zQtKRZMjIpHZyKL4AeDf?= =?utf-8?q?Af+6HePrxzCTFi7i1LqgqWLf6QLgMmxffxi5pXdZ5/d6I9R58VJfFbqTrE+PKIRHu?= =?utf-8?q?vRwm73IQTv5ru/SXxzDgf5UBHzPUYVeliZVs6kQ11gFMzTMpzgKlFeTUWP8FP6IBR?= =?utf-8?q?vsajRWlWWgU2OytHCkDQvqJKvUb/CB/nbOo6Yol82CI6fDGGt71OoQ6NBPVLC+Twm?= =?utf-8?q?sQm5qOB9y1qfyABiUBI9L5YJIolciNvbsHo5CpqJehbwDIqVI8lQmGzzXtFYQ1X2I?= =?utf-8?q?SIu55JYTIrTIRVAcEhcew1joOj+3CLKDFrl1LuYWc1AILYD/GnJ/h/2eLsZVAXT9o?= =?utf-8?q?Bjve4k+vgeZ2MXMnvQcF0Z6kM9QWE4iAPY5L7FGhZEqB/klc1eSJ8WSSMIP93FYWq?= =?utf-8?q?/pSCLn4jR/K78QQNaQotygwy5+K+KdOHN5HVdx5uPsPIyAAZ296KJcdaxOaVxmf9U?= =?utf-8?q?yzE9lYxTfSW3vZ2TuAAY6O7idEhqHGhIWy7EdNkrrItkPP1YQMzahVm9PAsYIJ9cq?= =?utf-8?q?HDTD2k1aWIRMxbIZQyZDspnU0CLUUP3iRpW2EPyQbsVkc83ZV9XgVM1YbED1KjUCE?= =?utf-8?q?TLN2JKb8CZMPk3T3ULlqI68Xh5SLZfLpvAnufBqtIgzRK9/juFm4879pbXWh2SD8Z?= =?utf-8?q?4DH2W2gAL8yr+Oo/a3YvsODcFKldmmYLsDMvERJ8yFgaiFIpfNpL7nyfb9EwW2w6O?= =?utf-8?q?tg9BKa+gaDr/qTXqZINKLong+CYeynRwEFqy47iXmw75MJEQl5Hg2c/C5HqZfxpC5?= =?utf-8?q?PnqQpz6bzUmTKbcjQ2m+bOTcs/BfRIX4ybBhQopcWc2QklxDFmcjVBQUqvBUJixCR?= =?utf-8?q?iaaZNLgB6WRnxnbvfHhhswZaC8z9mosoLZfsNyQgTwWl+LOIA4GrO/ItNfqoGRy7/?= =?utf-8?q?bfCkHY31DQ7YscUOSAysxjnynaQNenPQahXXix9zjDf7815rHc79Udh8PXI4YQ51L?= =?utf-8?q?nOl8icyUb1/KW1Bg64NmKn4V9ZtjSAIoC5F39iQnSeKmK1e8UjATs0xHijlRQGJwr?= =?utf-8?q?GXw7VtDxSuPTH9FtjqtZHwPNDkn3u8qz2r3WsTc8kE7I/ivSuGM6AVkK2sUBgKhzp?= =?utf-8?q?ZaO7jNXocCOvKqMQmHWjZc+mox+EM4CaXvR8+m6zt4UxK+TF7V1YBKAkvPVgfhxvW?= =?utf-8?q?/VJ1Xg8uZG9pxIWvSHfixJqJ5h0mE7hm+NWtZe+b99WxyWBA9XIIFp0H4WIPdX5YR?= =?utf-8?q?P+P/LEX30iBmPoVoDVF03sNHLY6t99uFA=3D=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PAXPR04MB9642.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(376014)(7416014)(52116014)(366016)(1800799024)(38350700014)(921020);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?q?WGPucLY2msun+auLi8S9LpTH7uIU?= =?utf-8?q?d+B7vr+QfsOn+M1P06G9pxJQ7C4wTV0+xzCvunoIHnwsUgi6wNIZ8sB4AnT4LXBoC?= =?utf-8?q?XtoTpybf4qqjDNVmawbsJCxYJVziYzWttirr08PMVvjIUXU6w0fv/uH7Guz2QQPMt?= =?utf-8?q?DO3XL3nnC6LIcihL0ZZYqq8+jdvm0iNE84kRiumSAczr31jxoa54H2fCQ5RGfqKiF?= =?utf-8?q?jhcbk7pLubceNi/k1b8Z54BXWYC384ubo1nMDXH+HRCk7E6yK4zPwJAE64WLcSn4I?= =?utf-8?q?4ahaw5DO8SCsZOFgbWHy2Q3AW+j8ygNZYwAyNKZgABu1Y/OdImyy7RHUms69lyxT+?= =?utf-8?q?ts2G6XAOgiT7MJswYWPWvPyNFJsrHLmsJnGdPxPOyk1UJwucII4Uo5w5Gi3IDEO1v?= =?utf-8?q?L4CWlpi1aId69uiHkoumNPZrIqJqdhQusJ3Ohl2oeJr3jdFOKp7nJ/HyIuW1E0ZD7?= =?utf-8?q?8Zpvtnhb5DYjihrTB6CZslT7sZknqbpQSDHVDSnVsRD1o39/s58ATY/DIoZ0irL7w?= =?utf-8?q?ScfhgjwD3gWZLle7X2Az1fRv2L1/jh8VSi1p8bjwjPcjinbsrfLJOYrEUQtQSmXpL?= =?utf-8?q?9ZADEFAhc8dwVH+V7SUUjlEx5aNaPMewBaM1f/GVWWVFY/WXz/ZuM8nFIChPgyosn?= =?utf-8?q?aYKd8PpdlbSXbyLIpQRCtgyoVO9sCcx/HC3ced7GWUWRByLDk9Mc4SovepDZ+7K6F?= =?utf-8?q?Ka1z4qR55wuKyBlyR+BWeXTD0R8RJA1Vk1FioDvmygou76HtfTkDPFrlGSmIObpVS?= =?utf-8?q?LpKk1GZgKofN26F4NONVMojzwiu1vfN5A3fmBa7vzgpezXLWFW8rClZei85n1rDeH?= =?utf-8?q?igJ4avcPVNX1EPEzpLMLwN99L+PqhSBaiLwA/JUeGvu4E1ksrcySIddQcLUCJpDr8?= =?utf-8?q?cbF38BrH0O3PaWl5yrSX7f8oQybg+AwOfcqRtp25PJnKdCSPZwtbOoy/EmfP7JYZI?= =?utf-8?q?SJjvRu9jkjwsk1w2d/b6/FWxgcp5scDL4Wc7h/EpOhMCDidMOHeB1YprBQL1yTs26?= =?utf-8?q?6Eu6JDEHU8aR7dO3DlSAxoE2FYCp0/r37GVTXEf64ymp1yv6ZbbBMh5axtvkMfn2Y?= =?utf-8?q?LbzNT16gizVUHMn7UR2LVBxh/3sYQ0708ek7s/CyydyvKnbHHq9Bd4sYduRJGd2Y/?= =?utf-8?q?4b9QJta2QpT+Y+7zLw3OoFAg3ToKwyBnj1UY9Hbcz8OT+RlaREYwlwSWHv26i9ZeF?= =?utf-8?q?jPfz2hBfRb9BK39ynhegQpzuUfsl+aD58U7xCMkGFESAeWW62vvtEq7uVXdWv2wwa?= =?utf-8?q?aL5V0sYljcKEh8adhvmtnVz6nscuY6cIv3OGNZHE22iBJoudTQqORmGpKcsHFoirF?= =?utf-8?q?61dpWMmHErPFdVegJlfQTC/1LKM+xiiUc6HiaN6nXDtN9a67g32z/UfcA4fdWZlZj?= =?utf-8?q?yeN/vD0D245NRc79CaDmfQoy1mkgWuKYNIPHe+6xll8EjzFpbYY5t0dIpqlwp89Z3?= =?utf-8?q?bzn7m57CuAXQ/aoL8KcMElKVh1QB8n1g2OpS3AwfvoGs5Kdz3CY/mug6878JOqz/h?= =?utf-8?q?9D5wwsW7V9Ci?= X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 4f1d7dfb-9567-43aa-6624-08dd760dad09 X-MS-Exchange-CrossTenant-AuthSource: PAXPR04MB9642.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Apr 2025 19:52:06.7350 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 9sUCmRmC5nqxDFt7FQrPOzJuHzVVdSOnxwqT/7qaoUKQJLeh+0Xdx4lAWdhDTKo9U6UsPP1bA77gqSg+5IQ7Ug== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PR3PR04MB7452 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250407_125209_405632_6F8D0B89 X-CRM114-Status: GOOD ( 16.85 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Add three registers: doorbell_bar, doorbell_addr, and doorbell_data. Use pci_epf_alloc_doorbell() to allocate a doorbell address space. Enable the Root Complex (RC) side driver to trigger pci-epc-test's doorbell callback handler by writing doorbell_data to the mapped doorbell_bar's address space. Set STATUS_DOORBELL_SUCCESS in the doorbell callback to indicate completion. Avoid breaking compatibility between host and endpoint, add new command COMMAND_ENABLE_DOORBELL and COMMAND_DISABLE_DOORBELL. Host side need send COMMAND_ENABLE_DOORBELL to map one bar's inbound address to MSI space. the command COMMAND_DISABLE_DOORBELL to recovery original inbound address mapping. Host side new driver Host side old driver EP: new driver S F EP: old driver F F S: If EP side support MSI, 'pci_endpoint_test -f pcie_ep_doorbell' return success. If EP side doesn't support MSI, the same to 'F'. F: 'pci_endpoint_test -f pcie_ep_doorbell' return failure, other case as usual. Tested-by: Niklas Cassel Signed-off-by: Frank Li --- change from v15 to v16 - use le32 for doorbell_* register and use cpu_to_le32() and le32_to_cpu() when use it. change from v14 to v15 - none Change from v9 to v14 - update commit message by use pci_endpoint_test -f pcie_ep_doorbell Change from v8 to v9 - move pci_epf_alloc_doorbell() into pci_epf_{enable/disable}_doorbell(). - remove doorbell_done in commit message. - rename pci_epf_{enable/disable}_doorbell() to pci_epf_test_{enable/disable}_doorbell() to align corrent code style. Change from v7 to v8 - rename to pci_epf_align_inbound_addr_lo_hi() Change from v6 to v7 - use help function pci_epf_align_addr_lo_hi() Change from v5 to v6 - rename doorbell_addr to doorbell_offset Chagne from v4 to v5 - Add doorbell free at unbind function. - Move msi irq handler to here to more complex user case, such as differece doorbell can use difference handler function. - Add Niklas's code to handle fixed bar's case. If need add your signed-off tag or co-developer tag, please let me know. change from v3 to v4 - remove revid requirement - Add command COMMAND_ENABLE_DOORBELL and COMMAND_DISABLE_DOORBELL. - call pci_epc_set_bar() to map inbound address to MSI space only at COMMAND_ENABLE_DOORBELL. --- drivers/pci/endpoint/functions/pci-epf-test.c | 142 ++++++++++++++++++++++++++ 1 file changed, 142 insertions(+) diff --git a/drivers/pci/endpoint/functions/pci-epf-test.c b/drivers/pci/endpoint/functions/pci-epf-test.c index 50eb4106369f4..b9cb1ab218f2b 100644 --- a/drivers/pci/endpoint/functions/pci-epf-test.c +++ b/drivers/pci/endpoint/functions/pci-epf-test.c @@ -11,12 +11,14 @@ #include #include #include +#include #include #include #include #include #include +#include #include #define IRQ_TYPE_INTX 0 @@ -29,6 +31,8 @@ #define COMMAND_READ BIT(3) #define COMMAND_WRITE BIT(4) #define COMMAND_COPY BIT(5) +#define COMMAND_ENABLE_DOORBELL BIT(6) +#define COMMAND_DISABLE_DOORBELL BIT(7) #define STATUS_READ_SUCCESS BIT(0) #define STATUS_READ_FAIL BIT(1) @@ -39,6 +43,11 @@ #define STATUS_IRQ_RAISED BIT(6) #define STATUS_SRC_ADDR_INVALID BIT(7) #define STATUS_DST_ADDR_INVALID BIT(8) +#define STATUS_DOORBELL_SUCCESS BIT(9) +#define STATUS_DOORBELL_ENABLE_SUCCESS BIT(10) +#define STATUS_DOORBELL_ENABLE_FAIL BIT(11) +#define STATUS_DOORBELL_DISABLE_SUCCESS BIT(12) +#define STATUS_DOORBELL_DISABLE_FAIL BIT(13) #define FLAG_USE_DMA BIT(0) @@ -66,6 +75,7 @@ struct pci_epf_test { bool dma_supported; bool dma_private; const struct pci_epc_features *epc_features; + struct pci_epf_bar db_bar; }; struct pci_epf_test_reg { @@ -80,6 +90,9 @@ struct pci_epf_test_reg { __le32 irq_number; __le32 flags; __le32 caps; + __le32 doorbell_bar; + __le32 doorbell_offset; + __le32 doorbell_data; } __packed; static struct pci_epf_header test_header = { @@ -667,6 +680,126 @@ static void pci_epf_test_raise_irq(struct pci_epf_test *epf_test, } } +static irqreturn_t pci_epf_test_doorbell_handler(int irq, void *data) +{ + struct pci_epf_test *epf_test = data; + enum pci_barno test_reg_bar = epf_test->test_reg_bar; + struct pci_epf_test_reg *reg = epf_test->reg[test_reg_bar]; + u32 status = le32_to_cpu(reg->status); + + status |= STATUS_DOORBELL_SUCCESS; + reg->status = cpu_to_le32(status); + pci_epf_test_raise_irq(epf_test, reg); + + return IRQ_HANDLED; +} + +static void pci_epf_test_doorbell_cleanup(struct pci_epf_test *epf_test) +{ + struct pci_epf_test_reg *reg = epf_test->reg[epf_test->test_reg_bar]; + struct pci_epf *epf = epf_test->epf; + + if (le32_to_cpu(reg->doorbell_bar) > 0) { + free_irq(epf->db_msg[0].virq, epf_test); + reg->doorbell_bar = cpu_to_le32(NO_BAR); + } + + if (epf->db_msg) + pci_epf_free_doorbell(epf); +} + +static void pci_epf_test_enable_doorbell(struct pci_epf_test *epf_test, + struct pci_epf_test_reg *reg) +{ + u32 status = le32_to_cpu(reg->status); + struct pci_epf *epf = epf_test->epf; + struct pci_epc *epc = epf->epc; + struct msi_msg *msg; + enum pci_barno bar; + size_t offset; + int ret; + + ret = pci_epf_alloc_doorbell(epf, 1); + if (ret) { + status |= STATUS_DOORBELL_ENABLE_FAIL; + goto set_status; + } + + msg = &epf->db_msg[0].msg; + bar = pci_epc_get_next_free_bar(epf_test->epc_features, epf_test->test_reg_bar + 1); + if (bar < BAR_0 || bar == epf_test->test_reg_bar || !epf->db_msg) { + status |= STATUS_DOORBELL_ENABLE_FAIL; + goto set_status; + } + + ret = request_irq(epf->db_msg[0].virq, pci_epf_test_doorbell_handler, 0, + "pci-test-doorbell", epf_test); + if (ret) { + dev_err(&epf->dev, + "Failed to request irq %d, doorbell feature is not supported\n", + epf->db_msg[0].virq); + status |= STATUS_DOORBELL_ENABLE_FAIL; + pci_epf_test_doorbell_cleanup(epf_test); + goto set_status; + } + + reg->doorbell_data = cpu_to_le32(msg->data); + reg->doorbell_bar = cpu_to_le32(bar); + + msg = &epf->db_msg[0].msg; + ret = pci_epf_align_inbound_addr(epf, bar, ((u64)msg->address_hi << 32) | msg->address_lo, + &epf_test->db_bar.phys_addr, &offset); + + if (ret) { + status |= STATUS_DOORBELL_ENABLE_FAIL; + pci_epf_test_doorbell_cleanup(epf_test); + goto set_status; + } + + reg->doorbell_offset = cpu_to_le32(offset); + + epf_test->db_bar.barno = bar; + epf_test->db_bar.size = epf->bar[bar].size; + epf_test->db_bar.flags = epf->bar[bar].flags; + + ret = pci_epc_set_bar(epc, epf->func_no, epf->vfunc_no, &epf_test->db_bar); + if (ret) { + status |= STATUS_DOORBELL_ENABLE_FAIL; + pci_epf_test_doorbell_cleanup(epf_test); + } else { + status |= STATUS_DOORBELL_ENABLE_SUCCESS; + } + +set_status: + reg->status = cpu_to_le32(status); +} + +static void pci_epf_test_disable_doorbell(struct pci_epf_test *epf_test, + struct pci_epf_test_reg *reg) +{ + enum pci_barno bar = le32_to_cpu(reg->doorbell_bar); + u32 status = le32_to_cpu(reg->status); + struct pci_epf *epf = epf_test->epf; + struct pci_epc *epc = epf->epc; + int ret; + + if (bar < BAR_0 || bar == epf_test->test_reg_bar || !epf->db_msg) { + status |= STATUS_DOORBELL_DISABLE_FAIL; + goto set_status; + } + + ret = pci_epc_set_bar(epc, epf->func_no, epf->vfunc_no, &epf->bar[bar]); + if (ret) + status |= STATUS_DOORBELL_DISABLE_FAIL; + else + status |= STATUS_DOORBELL_DISABLE_SUCCESS; + + pci_epf_test_doorbell_cleanup(epf_test); + +set_status: + reg->status = cpu_to_le32(status); +} + static void pci_epf_test_cmd_handler(struct work_struct *work) { u32 command; @@ -714,6 +847,14 @@ static void pci_epf_test_cmd_handler(struct work_struct *work) pci_epf_test_copy(epf_test, reg); pci_epf_test_raise_irq(epf_test, reg); break; + case COMMAND_ENABLE_DOORBELL: + pci_epf_test_enable_doorbell(epf_test, reg); + pci_epf_test_raise_irq(epf_test, reg); + break; + case COMMAND_DISABLE_DOORBELL: + pci_epf_test_disable_doorbell(epf_test, reg); + pci_epf_test_raise_irq(epf_test, reg); + break; default: dev_err(dev, "Invalid command 0x%x\n", command); break; @@ -987,6 +1128,7 @@ static void pci_epf_test_unbind(struct pci_epf *epf) pci_epf_test_clean_dma_chan(epf_test); pci_epf_test_clear_bar(epf); } + pci_epf_test_doorbell_cleanup(epf_test); pci_epf_test_free_space(epf); } From patchwork Mon Apr 7 19:51:01 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Frank Li X-Patchwork-Id: 14041945 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D3E43C369A6 for ; Mon, 7 Apr 2025 22:57:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:MIME-Version:Cc:To: In-Reply-To:References:Message-Id:Content-Transfer-Encoding:Content-Type: Subject:Date:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=F8Qp5FfqRuQHFYCFtVEMJWoCYl4K1g4dfDwvdzdP/uM=; b=sGEdhpk5JioGePxZzKC3ULtQ27 7voQ62EYzvCizRBRM2FsNlGQLhuHarJskC/8KZ+Esq4zZmxYLwHUzZtNk9nE45B2UpqUiWDQ5rYha OR+ZRwtncytSJyls4OThBc2ywAUt5Cfs747BOgJAclSaeqnLvvQOYDO4uW9mMP/QdJOBexRorUMfM vAbNL+eAnU0/O5LByw6a0jpFQ9/I/HGEAF2E+BoNfdc7JwTQytVal9zHZ13JvrgOXeS/6TGY6zdUt clnELoqfkRUlsiuyW81WLpp8ZNRoBGeBIwQrINFne2DM7eZwksP1rC4XGQUolc0lDm8/Ro//2c9th cSErmT2g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.1 #2 (Red Hat Linux)) id 1u1vPV-00000002EaU-3eE2; Mon, 07 Apr 2025 22:57:45 +0000 Received: from mail-db8eur05on20612.outbound.protection.outlook.com ([2a01:111:f403:2614::612] helo=EUR05-DB8-obe.outbound.protection.outlook.com) by bombadil.infradead.org with esmtps (Exim 4.98.1 #2 (Red Hat Linux)) id 1u1sVy-00000001sXQ-23Ih for linux-arm-kernel@lists.infradead.org; Mon, 07 Apr 2025 19:52:15 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=ypHZ8S3TNF7HQpIXRFvjoJSyvyfd4d+Yy0yniKndgvdJmUNCxBQUmsIHSFC51rBhmc2jM0v5jiEPXOIw0UrePl0Dezve/eXPex0ByzSYYQGrr4QRkB/w5Gz/GkSLUjS+22XHflhdq4u3tqYHHfFGLLljH9M0ONQkBlWgYDpnHXoHEJLPazXysugdM4QMz9YlknpkS9HQLZ1PciXFhhFx+jwGRxT/0Q7qTTgHznS25qLenBgIiFyeM6v0TEy73AICe8WOXagewT+fDvYGqla/lqbNHoseEp/ruPjy0nxnFvktELEubrBT9RMafwoUdqYs6wLoncBZblEngFltRHjjXQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=F8Qp5FfqRuQHFYCFtVEMJWoCYl4K1g4dfDwvdzdP/uM=; b=mktFofOzYEeE5xNcYY2LXJ7r6I9bsK6llZdNHBxSDklKTHOrtuKQw0huN9ho+zI9nHHVY2P7f5yDnvgxtdtFCoL1ra9+KF7YquYtEGL0RUXW1nA/ezPy9gsibvIYixnlpZ7kAF0UkG5WzFZcXYYxbFP26nZqASbwPAkhOj88E5DZtzAyJ7bs0wC+dlx6uhBTbSrwGhUYOLOi3+qqMi3fijNxgpZ/1gcExvpHrafNgeUACLD8akghaviJUcoq+m3FsFktZ1LYe65daClF0eIEwbZmBxGDJCHuLlnitMMH0Fdy4U4mN2b3LGvJjkXyfSn8MkAX9DL0Lj+FIv/HUe98ag== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=F8Qp5FfqRuQHFYCFtVEMJWoCYl4K1g4dfDwvdzdP/uM=; b=fNtuPEvm2G8kHCGS3shUXjG9PS4ygnYCKMfWM1Xs1fT/pizXQVO6CqFkIK20appS1fYcyD7F7xWl/oOc7pl25mopfFtXOKBN+bWCkep+OiyDq7CWCtGtqV4l9GZchM1JEWl4zFLSUG3VBbhB9ksFnzC2OqfQ3Uh8eqsQi5wpMZJ7/pv0QEiRs9R9S4daYpOND7IRvrA3w3DHNU9cIVbyracHeLnH7C5LE4aINybIUITMua5H6cSDCqq2uk4DfZuOTcDnsTKS4TFOv27bk7cKdUwaNuTj+YJQTIr51N2xI8s3wdL3nqvmzLPHOEordqwyAvb1qlcgHi9ooOg0IMq+cw== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nxp.com; Received: from PAXPR04MB9642.eurprd04.prod.outlook.com (2603:10a6:102:240::14) by PR3PR04MB7452.eurprd04.prod.outlook.com (2603:10a6:102:80::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8606.34; Mon, 7 Apr 2025 19:52:12 +0000 Received: from PAXPR04MB9642.eurprd04.prod.outlook.com ([fe80::9126:a61e:341d:4b06]) by PAXPR04MB9642.eurprd04.prod.outlook.com ([fe80::9126:a61e:341d:4b06%2]) with mapi id 15.20.8606.029; Mon, 7 Apr 2025 19:52:12 +0000 From: Frank Li Date: Mon, 07 Apr 2025 15:51:01 -0400 Subject: [PATCH v17 11/15] misc: pci_endpoint_test: Add doorbell test case Message-Id: <20250407-ep-msi-v17-11-633ab45a31d0@nxp.com> References: <20250407-ep-msi-v17-0-633ab45a31d0@nxp.com> In-Reply-To: <20250407-ep-msi-v17-0-633ab45a31d0@nxp.com> To: Kishon Vijay Abraham I , "Rafael J. Wysocki" , Thomas Gleixner , Anup Patel , Kishon Vijay Abraham I , Marc Zyngier , Greg Kroah-Hartman , "Rafael J. Wysocki" , Danilo Krummrich , Manivannan Sadhasivam , =?utf-8?q?Krzysz?= =?utf-8?q?tof_Wilczy=C5=84ski?= , Kishon Vijay Abraham I , Bjorn Helgaas , Arnd Bergmann , Shuah Khan , Richard Zhu , Lucas Stach , Lorenzo Pieralisi , Rob Herring , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Krzysztof Kozlowski , Conor Dooley Cc: Niklas Cassel , dlemoal@kernel.org, jdmason@kudzu.us, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-pci@vger.kernel.org, linux-kselftest@vger.kernel.org, imx@lists.linux.dev, devicetree@vger.kernel.org, Frank Li X-Mailer: b4 0.13-dev-e586c X-Developer-Signature: v=1; a=ed25519-sha256; t=1744055468; l=6407; i=Frank.Li@nxp.com; s=20240130; h=from:subject:message-id; bh=Q75HpsG7AQZeyq/78WIzVSdGpQ6JBJuHxf6b6uNsmfE=; b=mliM/Q5aCS4NzJ3tRmVPyAgxfZb08QVmxcdVK3+/7GN+kHsiKzL6RdwWBwR67l+FHZ6cj5kYa O1H4DMIdy/VBBUITOGa1aKQZ4CVFLMAl1GZvxTFjenin0AUWpqx1R3x X-Developer-Key: i=Frank.Li@nxp.com; a=ed25519; pk=I0L1sDUfPxpAkRvPKy7MdauTuSENRq+DnA+G4qcS94Q= X-ClientProxiedBy: AS4P189CA0041.EURP189.PROD.OUTLOOK.COM (2603:10a6:20b:5dd::15) To PAXPR04MB9642.eurprd04.prod.outlook.com (2603:10a6:102:240::14) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PAXPR04MB9642:EE_|PR3PR04MB7452:EE_ X-MS-Office365-Filtering-Correlation-Id: 27ef522e-e225-4968-7a6d-08dd760db027 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|376014|7416014|52116014|366016|1800799024|38350700014|921020; X-Microsoft-Antispam-Message-Info: =?utf-8?q?Dtm45raXaejGSBX3UgfSVlvXEvH8ZTl?= =?utf-8?q?tQQOzfYIhO7fLH+AtKs9B4K76OOmJaZHWBVtXekW3D1XbmMFbJN+MQhHVl+JCDeBs?= =?utf-8?q?/aeYRz6cSYCUQnTyQI/bBD25OOB+TPGjX+l9SOb+tGO0NZvCRrp32qltnq/Yaqzt/?= =?utf-8?q?VGWW/Bb1Xo5lZdbn4/ulyxjVlzg+y2pNZCsysYgh7P4P0NToR0vXiimGmO9LnNdGW?= =?utf-8?q?Uyr7VcXuRif/jkB1TEQkd/Kgah84gZECfq2nAj7cBU5v8D+285D3WhrjjbCTcIhD+?= =?utf-8?q?BsYJ/JbQtXMXWUQNNFrJUAAFvq4A6lsBMDXohqimBHFdKY2k1ucofBR24qGt1WWYk?= =?utf-8?q?rWzSGfX05E7k8Iu29eeUitdPqhu8sNkX4RQSYmA4ocsGuRhgShe5PakopK+OBTtJh?= =?utf-8?q?HDTu8KU5gGjxHz8WezhBceXNgOzXsfFf1lcWMB+dQDsqkXDM3z3Dyzrl/uOrOS901?= =?utf-8?q?itiMELT21HXMt8ln6vo7b4ZtkMf2GwWrWZ7TJV/JJBu5IQSSMucZ+2IqSGq2Zlwh4?= =?utf-8?q?dsg1/QyNg01OPVxuVol1Kah3cNxdmuBewarLWQpDNOdk58Peu8LtxKkkbYoXhWc6B?= =?utf-8?q?JHecLxGftnefFdcqdB1zyu/YrMEVDIKtuywEax+MfvtbyV456X3PH6YzEazNiZV0Z?= =?utf-8?q?B6bqpimiYlCJlYy5+QjgqtwsNVnBJ6u5QhC6PWSO98vDOaV/drS3ttcKeZM78hMKm?= =?utf-8?q?L+n9CuDAnrGsdlWCP++wtw8vB0hdc2BBTY9nVTjgoz1Q/EjQnjorbKNvMxVHKQUqP?= =?utf-8?q?WIb2wyzVcm3F5bleBBMIloNyKfDcj4XIcmgEdCzapiA3rZ7Rmd2KsV5gRqnPRSS7k?= =?utf-8?q?u8wjhB5JGpulAlSOmnc1r1KFwPDI4/UdLl+7hTCwMVfP5s6ECWZ3lpfjAoQlhzR+L?= =?utf-8?q?rzgJNYs19m9b+f78DvCLWSHarIiFDFpNsE90P0JMzK8l6JIMu0Of6S8Drnrdwlz0i?= =?utf-8?q?KfuFYvIXhidLD3qBZnm3JgsUHq76gv75eIM6bcLsq7Sp9maEcq0LcJPSIINxHKgr0?= =?utf-8?q?WBhsKvteq5aKKDZ6ZstSPuH8s0+VzbyFFCiPRiSuCvRnRqVuH1r1W+w6d4mkCes38?= =?utf-8?q?WaF2wwE/YpT6sc5+LuJWViW0qNK5nZQtYnufj1Dm3MS+1rZ1OlEAFxA8MxYbUrCDa?= =?utf-8?q?CsezVJfnelBQNHrQjvoiPiAS7KiO/Iq0fJmrl0FLlK2ZhEI2cCr+ZqSB+PR3sZtQ8?= =?utf-8?q?Zs4lwUD9z4GLIgbZI2Ivpxdo1aYdyiFZblhAoZ5MyO87T9zco5uoNaX54s4oysR1H?= =?utf-8?q?MWnGTxXO5wGamE4Tzxh5+j6urWd7zVZx4DvmLihfIeN6mGiGaYlDkcuDelLGXqIqL?= =?utf-8?q?X7cC+R5ZN5rV2jWOAUm1c6nnoJV3LaUlS/AshbHZT6Goo+P6kVTgLP2LJc2KXpMWD?= =?utf-8?q?4DU+zD0wLs0OsZz0cxgPANevmS/fr1GHg=3D=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PAXPR04MB9642.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(376014)(7416014)(52116014)(366016)(1800799024)(38350700014)(921020);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?q?P9Xdfw+2WV7j6qP19s5eMnvB4yYx?= =?utf-8?q?s+XydcicYG0iL0O7SWE4l2lC4lXHy3RIv6Ij+t0Nj3x5dX028Vj6kvWdFleybHHBN?= =?utf-8?q?L9mx69tszE2mEFd0ugUvMl6eYCfPYiYqrS5PYtr9wEpfB35/Efb7WQ87NudC51a73?= =?utf-8?q?Y4ptUU0U67Tla8dkGdVaM+v5A2qCxdWcYpuLRkGsODJGTdD0Xaq/ein7cnC0lgfJC?= =?utf-8?q?MY4Y1XPjjpwcfE6qQtcbpI2XazjYjgg21YYFqS16fpdjXwaTaBP4Ys75GH6L6jv9q?= =?utf-8?q?EOOk9k3ljlq/lfIw1BmYOPYI5RLNiIttYMxPHnbijhdXbXcYNnwyGz1StnNkW2Q36?= =?utf-8?q?B0gb1qfGLMhY8Lc39EmZNH1K9ztTDIxl1j4keHlscALr/I2eqdAzrtFlcjZ4WDQf4?= =?utf-8?q?Fi5df1gRDgvlk+1PZabDNmHCv0uwRAu3QN2Y+gnnMzac97kxcXsBNddBKTW6hwYTE?= =?utf-8?q?c2hLc7NvAXaGqSnwPl6NVwm+cuXzXMYfavfnlwgAp+d24cd0NAJOghTsXzx1RDM+y?= =?utf-8?q?dE3asBOew9pu9dmDzurAXFDWSY91zBZnRrR0l703coanzBNx6XDro+6WxSTbeckrr?= =?utf-8?q?0bzT/PmJSAOUdQVa1cAYhfJ9k0uTcn5nb8usus1O1WxqZyz4ufb2Y+FYN2Klszig0?= =?utf-8?q?HXofiZ2hpCLu28W+s7P66U1YZc60U82RlQPOBzsO4KQykA/I4tLjOv30qOYNJvhQx?= =?utf-8?q?m9oTDwmCGlqjMXAGCuWW/g+7+2MMjG+sPMOWtqRMVUi3bPyorxTxB4qSRAT5bXynt?= =?utf-8?q?7IrzFML7sw6liLERNikVG2h6cQcolePBtZhxMsixAF9QorT3Z5qUS4YGsz0fb64LG?= =?utf-8?q?Q8lOS7lfn/SovfmTLqp/6i7NcXLyUwJ8j5Z/Q/3iY/pn2ZB5fRJNoWrppW6Mnz6ZE?= =?utf-8?q?YAeHGq0ZrNgLl6ofL6gqgRJhNCP4cOsZOZ3pPnqhcBH1b7NUxxfdsxzmpoQlKwZBP?= =?utf-8?q?E+4CAdFgM58vIr7Xv+Zm58xvyUaLs1YWMZplq2P3G6bOP5ZzrSje71iSadTPtT7+H?= =?utf-8?q?bxT2D2TmEzRHQPcrLOLM+TQrvLOBHfqZQudMBD2rzamC0/73fINpQ7pYAWMYNGta0?= =?utf-8?q?+OaRnNKIdfSmesXuU+fSkQAkDWAYwbYJa3ha17csugprpgANhYduYvNrwMlneri0E?= =?utf-8?q?P1pIZw2nX9DiX1Qr8a8KiYRa62OL3pW9AVbVt49eh4FAfLnVKaV4CC/nDK0E5YTNH?= =?utf-8?q?5Y97qnJbu4a1uYF7zlaUPN+4AoIRSEw7HstANqpqYkFycIzGZIh8o4Y6w8f/CaAki?= =?utf-8?q?SFa7Z9eCeLamb8jtJqbz50gjJEO6+Njch451xU0CEJkN8ZI+y+OieK+yTPkZlBLCn?= =?utf-8?q?amInGG6GjbrpKh3rCSGQ+28USlutjChfE6sCtnLLkDJoXQGkJs3dI3yRp9j8f/JrC?= =?utf-8?q?+P4IhaLfsuTnyQbdv2mRV9v+Tpp3qwpJlfKK2aCYWZT+oKRET4hypfsn2tMt/r9KS?= =?utf-8?q?2KUu8V/nz7f6KGmEkfWTDS6fAhnPuJtiyv32U5hfOzf1T/maDwXpZPA37HTvzxHqi?= =?utf-8?q?rj4WBHM6T5h7?= X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 27ef522e-e225-4968-7a6d-08dd760db027 X-MS-Exchange-CrossTenant-AuthSource: PAXPR04MB9642.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Apr 2025 19:52:11.9916 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: l6lPVb/KUVV5euzsVhpr6Wi/9jfQ79Nhvg2L4FhfN4jhKxHNwM7oRXsSQvcAhona6t35HoZRsTDlgN9ESikH7A== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PR3PR04MB7452 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250407_125214_678637_545039EF X-CRM114-Status: GOOD ( 15.88 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Add three registers: PCIE_ENDPOINT_TEST_DB_BAR, PCIE_ENDPOINT_TEST_DB_ADDR, and PCIE_ENDPOINT_TEST_DB_DATA. Trigger the doorbell by writing data from PCI_ENDPOINT_TEST_DB_DATA to the address provided by PCI_ENDPOINT_TEST_DB_OFFSET and wait for endpoint feedback. Add two command to COMMAND_ENABLE_DOORBELL and COMMAND_DISABLE_DOORBELL to enable EP side's doorbell support and avoid compatible problem, which host side driver miss-match with endpoint side function driver. See below table: Host side new driver Host side old driver EP: new driver S F EP: old driver F F S: If EP side support MSI, 'pci_endpoint_test -f pcie_ep_doorbell' return success. If EP side doesn't support MSI, the same to 'F'. F: 'pci_endpoint_test -f pcie_ep_doorbell' return failure, other case as usual. Tested-by: Niklas Cassel Signed-off-by: Frank Li --- change from v14 to v16 - none Change from v13 to v14 - update to use pci_endpoint_test -f pcie_ep_doorbell - change ioctrl id to fix conflict Change from v9 to v13 - none Change from v8 to v9 - change PCITEST_DOORBELL to 0xa Change form v6 to v8 - none Change from v5 to v6 - %s/PCI_ENDPOINT_TEST_DB_ADDR/PCI_ENDPOINT_TEST_DB_OFFSET/g Change from v4 to v5 - remove unused varible - add irq_type at pci_endpoint_test_doorbell(); change from v3 to v4 - Add COMMAND_ENABLE_DOORBELL and COMMAND_DISABLE_DOORBELL. - Remove new DID requirement. --- drivers/misc/pci_endpoint_test.c | 82 ++++++++++++++++++++++++++++++++++++++++ include/uapi/linux/pcitest.h | 1 + 2 files changed, 83 insertions(+) diff --git a/drivers/misc/pci_endpoint_test.c b/drivers/misc/pci_endpoint_test.c index c4e5e2c977be2..0f3af7adea107 100644 --- a/drivers/misc/pci_endpoint_test.c +++ b/drivers/misc/pci_endpoint_test.c @@ -37,6 +37,8 @@ #define COMMAND_READ BIT(3) #define COMMAND_WRITE BIT(4) #define COMMAND_COPY BIT(5) +#define COMMAND_ENABLE_DOORBELL BIT(6) +#define COMMAND_DISABLE_DOORBELL BIT(7) #define PCI_ENDPOINT_TEST_STATUS 0x8 #define STATUS_READ_SUCCESS BIT(0) @@ -48,6 +50,11 @@ #define STATUS_IRQ_RAISED BIT(6) #define STATUS_SRC_ADDR_INVALID BIT(7) #define STATUS_DST_ADDR_INVALID BIT(8) +#define STATUS_DOORBELL_SUCCESS BIT(9) +#define STATUS_DOORBELL_ENABLE_SUCCESS BIT(10) +#define STATUS_DOORBELL_ENABLE_FAIL BIT(11) +#define STATUS_DOORBELL_DISABLE_SUCCESS BIT(12) +#define STATUS_DOORBELL_DISABLE_FAIL BIT(13) #define PCI_ENDPOINT_TEST_LOWER_SRC_ADDR 0x0c #define PCI_ENDPOINT_TEST_UPPER_SRC_ADDR 0x10 @@ -62,6 +69,7 @@ #define PCI_ENDPOINT_TEST_IRQ_NUMBER 0x28 #define PCI_ENDPOINT_TEST_FLAGS 0x2c + #define FLAG_USE_DMA BIT(0) #define PCI_ENDPOINT_TEST_CAPS 0x30 @@ -70,6 +78,10 @@ #define CAP_MSIX BIT(2) #define CAP_INTX BIT(3) +#define PCI_ENDPOINT_TEST_DB_BAR 0x34 +#define PCI_ENDPOINT_TEST_DB_OFFSET 0x38 +#define PCI_ENDPOINT_TEST_DB_DATA 0x3c + #define PCI_DEVICE_ID_TI_AM654 0xb00c #define PCI_DEVICE_ID_TI_J7200 0xb00f #define PCI_DEVICE_ID_TI_AM64 0xb010 @@ -100,6 +112,7 @@ enum pci_barno { BAR_3, BAR_4, BAR_5, + NO_BAR = -1, }; struct pci_endpoint_test { @@ -841,6 +854,72 @@ static int pci_endpoint_test_set_irq(struct pci_endpoint_test *test, return 0; } +static int pci_endpoint_test_doorbell(struct pci_endpoint_test *test) +{ + struct pci_dev *pdev = test->pdev; + struct device *dev = &pdev->dev; + int irq_type = test->irq_type; + enum pci_barno bar; + u32 data, status; + u32 addr; + + if (irq_type < PCITEST_IRQ_TYPE_INTX || + irq_type > PCITEST_IRQ_TYPE_MSIX) { + dev_err(dev, "Invalid IRQ type option\n"); + return -EINVAL; + } + + pci_endpoint_test_writel(test, PCI_ENDPOINT_TEST_IRQ_TYPE, irq_type); + pci_endpoint_test_writel(test, PCI_ENDPOINT_TEST_IRQ_NUMBER, 1); + pci_endpoint_test_writel(test, PCI_ENDPOINT_TEST_COMMAND, + COMMAND_ENABLE_DOORBELL); + + wait_for_completion_timeout(&test->irq_raised, msecs_to_jiffies(1000)); + + status = pci_endpoint_test_readl(test, PCI_ENDPOINT_TEST_STATUS); + if (status & STATUS_DOORBELL_ENABLE_FAIL) { + dev_err(dev, "Failed to enable doorbell\n"); + return -EINVAL; + } + + data = pci_endpoint_test_readl(test, PCI_ENDPOINT_TEST_DB_DATA); + addr = pci_endpoint_test_readl(test, PCI_ENDPOINT_TEST_DB_OFFSET); + bar = pci_endpoint_test_readl(test, PCI_ENDPOINT_TEST_DB_BAR); + + pci_endpoint_test_writel(test, PCI_ENDPOINT_TEST_IRQ_TYPE, irq_type); + pci_endpoint_test_writel(test, PCI_ENDPOINT_TEST_IRQ_NUMBER, 1); + + pci_endpoint_test_writel(test, PCI_ENDPOINT_TEST_STATUS, 0); + + bar = pci_endpoint_test_readl(test, PCI_ENDPOINT_TEST_DB_BAR); + + writel(data, test->bar[bar] + addr); + + wait_for_completion_timeout(&test->irq_raised, msecs_to_jiffies(1000)); + + status = pci_endpoint_test_readl(test, PCI_ENDPOINT_TEST_STATUS); + + if (!(status & STATUS_DOORBELL_SUCCESS)) + dev_err(dev, "Endpoint have not received Doorbell\n"); + + pci_endpoint_test_writel(test, PCI_ENDPOINT_TEST_COMMAND, + COMMAND_DISABLE_DOORBELL); + + wait_for_completion_timeout(&test->irq_raised, msecs_to_jiffies(1000)); + + status |= pci_endpoint_test_readl(test, PCI_ENDPOINT_TEST_STATUS); + + if (status & STATUS_DOORBELL_DISABLE_FAIL) { + dev_err(dev, "Failed to disable doorbell\n"); + return -EINVAL; + } + + if (!(status & STATUS_DOORBELL_SUCCESS)) + return -EINVAL; + + return 0; +} + static long pci_endpoint_test_ioctl(struct file *file, unsigned int cmd, unsigned long arg) { @@ -891,6 +970,9 @@ static long pci_endpoint_test_ioctl(struct file *file, unsigned int cmd, case PCITEST_CLEAR_IRQ: ret = pci_endpoint_test_clear_irq(test); break; + case PCITEST_DOORBELL: + ret = pci_endpoint_test_doorbell(test); + break; } ret: diff --git a/include/uapi/linux/pcitest.h b/include/uapi/linux/pcitest.h index d3aa8715a525e..d6023a45a9d03 100644 --- a/include/uapi/linux/pcitest.h +++ b/include/uapi/linux/pcitest.h @@ -21,6 +21,7 @@ #define PCITEST_SET_IRQTYPE _IOW('P', 0x8, int) #define PCITEST_GET_IRQTYPE _IO('P', 0x9) #define PCITEST_BARS _IO('P', 0xa) +#define PCITEST_DOORBELL _IO('P', 0xb) #define PCITEST_CLEAR_IRQ _IO('P', 0x10) #define PCITEST_IRQ_TYPE_UNDEFINED -1 From patchwork Mon Apr 7 19:51:02 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Frank Li X-Patchwork-Id: 14041897 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id AEB64C36010 for ; Mon, 7 Apr 2025 21:48:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:MIME-Version:Cc:To: In-Reply-To:References:Message-Id:Content-Transfer-Encoding:Content-Type: Subject:Date:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=mO0i/b34tXG//kvU4HGnKVOSOCmwct33MArJWNqY/sY=; b=MAqszcBEVYkzeX+PsrzkxdENLI ewA6Sf2+JhqlaMEZXk06BeKoYswFGSIpFbxDGSgE2Ev9vQAAEMLkDEby4+qxeQNq4d8MTDstp60Fd m5zCyn+MyJVDX9VAPpBhFl8XHlb/umbNTpXuU12pibjPslqVvilg8NI59K+2S8nXIIj4ckUmsHrbf xq5ytH8voalabNT/PqIFhb22SGvZ/c1cp+JMKDb/Jxy6vhFLu29+8Uz80R/n00s78x0w1LwCqYTo6 3Ntv4R1Spa9X6v3AmdGf6MNu/Vqyd9nI3niCwA7nWQJThNslfuZuxy0v2VuK1tNf7R7/dyrdX/Jnj 1bx/UVEg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.1 #2 (Red Hat Linux)) id 1u1uK9-000000026UG-1pQc; Mon, 07 Apr 2025 21:48:09 +0000 Received: from mail-am6eur05on20627.outbound.protection.outlook.com ([2a01:111:f403:2612::627] helo=EUR05-AM6-obe.outbound.protection.outlook.com) by bombadil.infradead.org with esmtps (Exim 4.98.1 #2 (Red Hat Linux)) id 1u1sW4-00000001sYF-264s for linux-arm-kernel@lists.infradead.org; Mon, 07 Apr 2025 19:52:21 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=Rq72KNCU/a6+zSCxxJwgI9AE2ltFQL1g2Iuy88b5g37tTRsUNjinAR7Za4czRo/RJyXm+lTiNgu2+AjRUqSisznYXw08k/GtiGhbfufmPLmUxqoTvJoYGPSucaSmcAGFZNhUjXOWuacdaIchy9MQz+/r8CR1nyIDGEJRmRC9IB43ouHo4B2j0OTXXR0c6mYX9J4BYRH1L6v5GLDV4+Vcf77eTZASLU8pK26ouQpsJeLQr5P2vBvpMGYTFbcPb4Hb37DtOeE5IlDiqcnBBpbfEpGN5WX9HV1OYtjfuFjdhMKU3ZW4Ii3SDWRFxVp7iK3nBZaTPl3RI3EEopbfgVDGdw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=mO0i/b34tXG//kvU4HGnKVOSOCmwct33MArJWNqY/sY=; b=QG9+i4vhSz9jeOhQ6AiUSNMA8cl3GJjkyY0o6jrXF4Cuqvg2xQaoBLcrKua3TzbDXGMIJiWuwDvygLVSsxEvcLHEin+9RhyPUcN3BKbOQCjH07Dw43Pqz4aSTT/h3prnWH1HJkwHRdsSBLgEKUXqGxYyYbsANuclPOkilV1qKMkwfuO4KNOBcIor3vxtkRc4eu/bbXsEAWC+FCKUVssuxGyVrHJ22AyxCgaKK3ALFaeYX7BOQ8zExKBZRghHDwTCsVhxjUDxsjTJwHxU8/oDQlsGolM9z0z9vR/kDKz7tTbWhuEE94HuPAMG/9NirAwF4CqltLUDUKvqKaM4ZO97oA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=mO0i/b34tXG//kvU4HGnKVOSOCmwct33MArJWNqY/sY=; b=Fpw1u9BCSwy8xFz++T01AS1+R79wzb+/DVYAMQYt5KO1AtSfpJJuY07lRUvCax/S5qLePL7QaqTFHzFUADTU9GZ1b+O5UpNpCJreOXQ4jmCJtMOqfp9ynpCsmmQpcf/XMp4TbbAT+Yy38xL0itN0nAY/DxR7a7xaHcJpLy4xa/Skxm6GVaCPhSjYtk6QJImsE7PyJIDPQuH3IL7i9jVD4MZKLqPAQxFMWsJucJ51BTiQSIAaZhWBtiKMzna+855vv76gSxVtserdYJQQhJdR4SOhxcVNqsOSHxC6266NcYbTSAqC26pOKNxv8WGsX5ovOlQgTluiwnBfXi+2Xji8vQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nxp.com; Received: from PAXPR04MB9642.eurprd04.prod.outlook.com (2603:10a6:102:240::14) by PR3PR04MB7452.eurprd04.prod.outlook.com (2603:10a6:102:80::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8606.34; Mon, 7 Apr 2025 19:52:17 +0000 Received: from PAXPR04MB9642.eurprd04.prod.outlook.com ([fe80::9126:a61e:341d:4b06]) by PAXPR04MB9642.eurprd04.prod.outlook.com ([fe80::9126:a61e:341d:4b06%2]) with mapi id 15.20.8606.029; Mon, 7 Apr 2025 19:52:17 +0000 From: Frank Li Date: Mon, 07 Apr 2025 15:51:02 -0400 Subject: [PATCH v17 12/15] selftests: pci_endpoint: Add doorbell test case Message-Id: <20250407-ep-msi-v17-12-633ab45a31d0@nxp.com> References: <20250407-ep-msi-v17-0-633ab45a31d0@nxp.com> In-Reply-To: <20250407-ep-msi-v17-0-633ab45a31d0@nxp.com> To: Kishon Vijay Abraham I , "Rafael J. Wysocki" , Thomas Gleixner , Anup Patel , Kishon Vijay Abraham I , Marc Zyngier , Greg Kroah-Hartman , "Rafael J. Wysocki" , Danilo Krummrich , Manivannan Sadhasivam , =?utf-8?q?Krzysz?= =?utf-8?q?tof_Wilczy=C5=84ski?= , Kishon Vijay Abraham I , Bjorn Helgaas , Arnd Bergmann , Shuah Khan , Richard Zhu , Lucas Stach , Lorenzo Pieralisi , Rob Herring , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Krzysztof Kozlowski , Conor Dooley Cc: Niklas Cassel , dlemoal@kernel.org, jdmason@kudzu.us, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-pci@vger.kernel.org, linux-kselftest@vger.kernel.org, imx@lists.linux.dev, devicetree@vger.kernel.org, Frank Li X-Mailer: b4 0.13-dev-e586c X-Developer-Signature: v=1; a=ed25519-sha256; t=1744055468; l=1300; i=Frank.Li@nxp.com; s=20240130; h=from:subject:message-id; bh=+SgZEl+0x0mkZbAhvLt5Evhno7zgilVYjrIje6KjXVc=; b=lFDtqU4A0MnBXndoG2ULwuCm04/pUNkF6jinLSs4lMRAKb4hoKHqnUMogC3vSqH3VMk98CYdx MxUZQc2M8QkDczSlw2jT/S8fPotVRc7z/Cev4jH8bk9Qw46CxHv4We3 X-Developer-Key: i=Frank.Li@nxp.com; a=ed25519; pk=I0L1sDUfPxpAkRvPKy7MdauTuSENRq+DnA+G4qcS94Q= X-ClientProxiedBy: AS4P189CA0041.EURP189.PROD.OUTLOOK.COM (2603:10a6:20b:5dd::15) To PAXPR04MB9642.eurprd04.prod.outlook.com (2603:10a6:102:240::14) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PAXPR04MB9642:EE_|PR3PR04MB7452:EE_ X-MS-Office365-Filtering-Correlation-Id: 2b89c8dd-a8f0-495d-7848-08dd760db352 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|376014|7416014|52116014|366016|1800799024|38350700014|921020; X-Microsoft-Antispam-Message-Info: =?utf-8?q?nfsfRV01UeKa2L/rLjMLHJzGpbvbb8X?= =?utf-8?q?Aa0G3hF3NWz0Cy3/AjdIcpFYr/OHDj4502i9xpsziHGsBnMy4nyiYCqwXl49LYb9z?= =?utf-8?q?1UCCXsmcPvVMMq/OqivgWZ9Wx/z0lll7FHGBFRcNOwFhuvzr0fraI3PkDVJTcVPRZ?= =?utf-8?q?o2px3mCDmRhaFNQIOOACOK3fEPel4yeVmnjWyIWz5dNqt9nLVjeyDV7QQ1hGMljCd?= =?utf-8?q?OcqJqgu0kPGRoCl591zrBFpfN5Ub2KvRODBe2Xq17InmdUHSgMecWGO7UmpPg2HXq?= =?utf-8?q?pPAiaObq7sU1/nvLDkHNJx+1johqYm8bdY7c21aX5bQpROvskD7ronOrn+777IkCf?= =?utf-8?q?WL2WXbcKx8imc+V+C4aFecQPvMhj1bihL5vPaznj3BRq7gskg5+cx+Ys955oZ95w2?= =?utf-8?q?TIXanIH0kfiSP5CjzByDPLEqZZLBaSIcPkJV8VUUJZYUvZvPFYQK7klNa8As2Njd5?= =?utf-8?q?WpnAEyshtKS3OVTCuLGddh5u6WroQfvfD5HEpkiibGrfani3EPDGDg5msO0E2PrB9?= =?utf-8?q?kDiBiP3rR+9rdJf6ka3dhkyQeFgOAtHEQk79INCWndCv8EnqdVaYIMUx/7mb0KSa4?= =?utf-8?q?btEBwORF/KPQk02IyePXCNxx4zhwtSc/xQvtX6ffubZI/8QMAWmFuUcUEXD0m81w+?= =?utf-8?q?s4Nxvl+28r6KIKs082xt3KhyzXbtruH9lcFEIk3msJyZmks2+Ue9ImLEX0vdz6c6C?= =?utf-8?q?o6VozC2YZJA2htm3nRQTZVUO7uJbWzuLB/fFbswZY45eq9IOysm2ML86BbtIL2p1p?= =?utf-8?q?qDDjVZ9S7APCRTycmIRbRtA6X66MASag96N5CFDrDDl4NuIxyXbX+OM5Zkl6NehI/?= =?utf-8?q?pc9hzmOipnNTF1FP4AAAH/Rt1iBkxxCKMbiMOzZRkQpkjAZ1TXksN7XChv9H8VfMZ?= =?utf-8?q?418n7GBsMVT6Dm/CA4Ncqga4UXmZ6g+ibh2CTKPo3qIrv+WC9mzGQehop9LTdSoyl?= =?utf-8?q?glUIlXUlkQ+MnOw3churh9uDrnSw1XwgXSkUSi5iPIqrO4su3P0O+0XStDIuBev2x?= =?utf-8?q?ndsRorZJkA2KmR0djf7jeASiQHMO561syIzzBz/hEUOaetApNfmsA2MM0ePdN5O0r?= =?utf-8?q?AmN7dA80qVC/lAHvxglavGdEkF6HL578bTeqbIEvwdAh5r1I31RJnNy2xtrDh8FNk?= =?utf-8?q?RASdqeM0rGjiw5BCHvekegA09Uq9UC0/2V1bZWf/wHdkX9XjHmIF71i6ijrsqhnK4?= =?utf-8?q?SyA8N1/WsyymX3ixFRbyM0pzHbqcjl00Jpz0354we+B3znc2ueAtgEG1av8XbuQMb?= =?utf-8?q?E53Gea8UwLo+GClLlVyDgRiHK1LuSxmsW6xEoWgqxjM+TTwIAockbH3BHV5AA5CbT?= =?utf-8?q?1NitcM+YzyLTM4PCp34scoJRe9KFbn7wAuymxPFeJvOABb5R1aZhcD+jWlTqGUfgq?= =?utf-8?q?lj6JE1KIVX3pJdUyvfwUnCfU4bJ7Cej0g=3D=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PAXPR04MB9642.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(376014)(7416014)(52116014)(366016)(1800799024)(38350700014)(921020);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?q?BS7vBltRSzDLYq2dzZ2ojywCQTK3?= =?utf-8?q?pllOQ5TwFaVJ18uIGh7UfOH7yGvsTn/wIdYWaBtV1020HfY9F7HzrkstOWwPG9aLl?= =?utf-8?q?WTwJyClqMnb+tQ0rI01srOWA9WneNWXFFI5DBBaruHM8NtF/7IHVRZDIXMnzzSnup?= =?utf-8?q?dmMv6VkUGehbqxpeYZc7pWYDv42spvCmaJDZKbK99rt3B0QmZRluuzARk1m3He7Es?= =?utf-8?q?DhZwZrc0qRJoD6a5hpVhMG0RlibDMTxGJEdcO1WHScKxIKacQZpeS5ocfSOoHkzRB?= =?utf-8?q?ot0l67SXOX2u98pSfN3rJ3PQvlKS3K5ZF39O35MZTjgEHU1u8tIl2XhoVjn0qh1oT?= =?utf-8?q?i3F1N2RPGKDi/zBLY2vzneArirKd41hBu1j27hQSxTJ6crybVNAX762YFTTE0fOqy?= =?utf-8?q?7QVFYzJ5+ts5ob5IotOyNy9gXCkgtocX1SYcgyvALiMxZoWIxxntspladIEIklvBM?= =?utf-8?q?7YoXwdXjM0qUc9EukkJ9u4N12pqDb6nXS/EwkpWnJQEob9zSBp0t1v85BQEx+tGOV?= =?utf-8?q?y9StDwkeFyzPuTmiWTEfBIOxyCQzPP8onYD0kI1nsaM5mtqYA33iDZLToaQjDXlUz?= =?utf-8?q?LRgMcZTPIwjOIEjplq6OIkE9Pb5uhofjx9xneF1Q8MQnQznlm7yPNFybHJBPLl2Wh?= =?utf-8?q?rwcTTPPMpTvPkVa0T2YCweWGjmv+CTEC7KH8ASoZntSB3FsTCE8kvoZjSn1c0IGQd?= =?utf-8?q?rt2bJoRQA336feZhQPw7STl83ibmp7qcSqQn6a5GNkzAapRcI2I2RdDcMfjFMQ30r?= =?utf-8?q?pikwKrUiygd9VisPU4UzohM4BSgH10mIXpjyuDqhnA+lB3ft+hDc/f8ImKNtFZ155?= =?utf-8?q?72EN4to2s4NF5YJAO7UDCPTPgj6QNLB3dO3M3RaRZ1bkqv+TaENmR6qc/c1gN74C2?= =?utf-8?q?+OzKdIw4clSjotUsMdhJnHILyonaD7BMICPnl5l41g06p6VmLqUYZFddIL8qBp58I?= =?utf-8?q?UT9tD8vAGd9in3xZTfC7a/XmHKEBJ3JvncQB9X7KmVdVJY1hxpipCKjGFjrceyGv6?= =?utf-8?q?9bbQ5dWxEmlVjvGAyCWhtEFxCeAbadHJ+j4yGO4bmtKkCxuuWgYIOhouI1e9jgmyv?= =?utf-8?q?Z6A9+Pt6XVtJdgXBc4zFWCFKm8VAz/r0jtkmUZDG8PyMqxAsToZk7z8oAiRSZ5KbM?= =?utf-8?q?mRp3QnwJz8c7bgFrJGKxyCbkWK1rZgGxa5Xa/m5e6QL7Rje8Nisg3t/6FiOJREVbi?= =?utf-8?q?A9alE+YYxiysTp9PFdAuXXAQKKNCXQ+HgGJ6YjIvgQu8z+jwYWS5IZt8q4gwqG0yc?= =?utf-8?q?UGDS1p2O7DaI410+fWM05E4nhrXyjFA1PmJ9jEI1aYUe1AInUMwwXmrAAPxBuafKE?= =?utf-8?q?zDRVERcxU75J+Zf6DBkJ1NyY54cOwHahIBayPMu8WiIlg0dFvzYk9TOC7P5TvLt5Z?= =?utf-8?q?OYvGH6pVati3zGKFIJsl0CKjPGlm8kMEcJQelDnmqBAT2v299zF7MEhKlUFMMsmF8?= =?utf-8?q?l/A7+PFoDmuwXZfWC5QEb1/Yf4ke/TUj9fk/mWmP8sJ56lC9ollLRi8oAcjZ/JIqd?= =?utf-8?q?8HLToGIGBhzl?= X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 2b89c8dd-a8f0-495d-7848-08dd760db352 X-MS-Exchange-CrossTenant-AuthSource: PAXPR04MB9642.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Apr 2025 19:52:17.3387 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: jvYJ4S7Foyr6pE0syC+TMjLM2UKDE7ja0+/lGyDKfEK8PsQN3/dXAWuPuWoe2lCKbRenpi7zozJLaLsf/Khryg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PR3PR04MB7452 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250407_125220_538291_C6A95148 X-CRM114-Status: UNSURE ( 9.99 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Add doorbell test case. Signed-off-by: Frank Li --- change from v14 to v16 - Add set IRQ type change from v13 to v14 - merge to selftests framework --- .../selftests/pci_endpoint/pci_endpoint_test.c | 28 ++++++++++++++++++++++ 1 file changed, 28 insertions(+) diff --git a/tools/testing/selftests/pci_endpoint/pci_endpoint_test.c b/tools/testing/selftests/pci_endpoint/pci_endpoint_test.c index ac26481d29d9d..da0db0e7c9693 100644 --- a/tools/testing/selftests/pci_endpoint/pci_endpoint_test.c +++ b/tools/testing/selftests/pci_endpoint/pci_endpoint_test.c @@ -229,4 +229,32 @@ TEST_F(pci_ep_data_transfer, COPY_TEST) test_size[i]); } } + +FIXTURE(pcie_ep_doorbell) +{ + int fd; +}; + +FIXTURE_SETUP(pcie_ep_doorbell) +{ + self->fd = open(test_device, O_RDWR); + + ASSERT_NE(-1, self->fd) TH_LOG("Can't open PCI Endpoint Test device"); +}; + +FIXTURE_TEARDOWN(pcie_ep_doorbell) +{ + close(self->fd); +}; + +TEST_F(pcie_ep_doorbell, DOORBELL_TEST) +{ + int ret; + + pci_ep_ioctl(PCITEST_SET_IRQTYPE, PCITEST_IRQ_TYPE_AUTO); + ASSERT_EQ(0, ret) TH_LOG("Can't set AUTO IRQ type"); + + pci_ep_ioctl(PCITEST_DOORBELL, 0); + EXPECT_FALSE(ret) TH_LOG("Test failed for Doorbell\n"); +} TEST_HARNESS_MAIN From patchwork Mon Apr 7 19:51:03 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Frank Li X-Patchwork-Id: 14041899 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B678AC36010 for ; Mon, 7 Apr 2025 21:48:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:MIME-Version:Cc:To: In-Reply-To:References:Message-Id:Content-Transfer-Encoding:Content-Type: Subject:Date:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=7Uw8VyfQPkoGAJ9vh4Z/t75FAVRHjabfWtBpwRAHpq0=; b=pHyuJADN6yC+a3xhBl0AGD7zCZ 7+6D5Yy8jZgn8HlvRL+6vx+5E2XuKiARFsm8oyZd0F0SHDnConCWSGBJdTiWAcepFfhjZD4Z3WOvP GcIIxLSP6bCspkFYMbj5jaYreXVDdgZGTYnZY+EteaT/mOgM7zw3H42lrrnREWmMavqeBtc5QbegN kj6KMpHOzvFRMbPMRT3WKj+7tdHl9vNBVUhvr7r+v59bJye97fGF+/Htd4z6j0ZKdFZ5gsLuTD6OL lbsinqiimfQ1gXQ0OZ0MVd96Cn+0mXUblsPQOyrnckErFuW1Mva9gVq5RfW6uZH1ZiGE4xsiQPcRZ 2XmbWxMg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.1 #2 (Red Hat Linux)) id 1u1uKA-000000026WV-1Y7h; Mon, 07 Apr 2025 21:48:10 +0000 Received: from mail-vi1eur05on20610.outbound.protection.outlook.com ([2a01:111:f403:2613::610] helo=EUR05-VI1-obe.outbound.protection.outlook.com) by bombadil.infradead.org with esmtps (Exim 4.98.1 #2 (Red Hat Linux)) id 1u1sWA-00000001sZb-0lNt for linux-arm-kernel@lists.infradead.org; Mon, 07 Apr 2025 19:52:27 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=R9cXi3ahbTCIzajZL+g6Oq68FP4qM6bl9NkWQTYs9DyX606RJbbn2ocrFtcZp3OtjDRaNTF2ntNNv9Z/XtADZRyftLFeThx/3P4ENogfWd2EJHGHvFJAKMH8XEnZlomSBrClClVk29BGV3LcK0fkZeSTkFWMniCPy31eqLhPmKdKEoJ9YkZ5Us9IayzTprrHzcgGYe2fZPRUGO6EMQ2jmtk+vYUtNLfQXhY0FElUnUiaNGDMqaRutDuWYL4eQMr16gMB2FQpa8iL8kn92A6e2rXBSrdI9uuJQnOD3Yv1QYCZrpOLPbiwkqoq05ibuFxb+ytcmIwFtPW+4HF3FVLdrA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=7Uw8VyfQPkoGAJ9vh4Z/t75FAVRHjabfWtBpwRAHpq0=; b=rgwQaz0KqOGjrqTpMe9UDb8NPyD55+EJc1jaDXHtr/Wx6+hNqh+C0EZ89imPg0mU8lq6iXzNXzAZq92C2RgIkfDGgxrIGy0WIgwY5B90M0NqBzIBOT+7seN1/QmdpWbDzbjd13AfpsO+zUu6H92IvCSZddNhJ+9vxzkFWvpwbBuYGtSMLv9d/FCpwu5T5mnuGaxiWlGhi9fRuIahXmwMci9rdK/Rrh3NmpLzbqJKMu0zkRKcUt7uT4z9jiLkMyOX0aD2QNNYEbGQRJvTtrChykgC5MZkrgYEBbxoDVOULsg3qaXuKUNVG2xderoaTzbpCbdGXO6tbbEjZcKlvDHj5Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=7Uw8VyfQPkoGAJ9vh4Z/t75FAVRHjabfWtBpwRAHpq0=; b=ILZatc8wp1NEdXwu0GIpY0FR/Vxy3XzgNbcvizmYMzY2LssvuF0lGUtW2GJo2T60aB/S3VC90z0xCiqyJFp2qyFhrbILxU9YK+gcOmNll63YPODte5/59pJgSYqwiaKLreGBUHd3vmYHFOx11kxtkYLgoKt6HppXW6c9KAIg5+AS2BqK8rpR5Cgj8qH0iGFrWvbK1Qv5ZlxDXGNIXQh7DUy8H5vq56j50let7XGLDx7rUAAuAcCTesXL5wt7GtJQDSejza6jcQ9xgeQLlQ0JoM/oiat9HydQnaqZWqIiohYUV6IvPntbMIV44Sp6Sq6KNKI7ojIZkGtMsJ49PRiQnw== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nxp.com; Received: from PAXPR04MB9642.eurprd04.prod.outlook.com (2603:10a6:102:240::14) by PR3PR04MB7452.eurprd04.prod.outlook.com (2603:10a6:102:80::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8606.34; Mon, 7 Apr 2025 19:52:22 +0000 Received: from PAXPR04MB9642.eurprd04.prod.outlook.com ([fe80::9126:a61e:341d:4b06]) by PAXPR04MB9642.eurprd04.prod.outlook.com ([fe80::9126:a61e:341d:4b06%2]) with mapi id 15.20.8606.029; Mon, 7 Apr 2025 19:52:22 +0000 From: Frank Li Date: Mon, 07 Apr 2025 15:51:03 -0400 Subject: [PATCH v17 13/15] pci: imx6: Add helper function imx_pcie_add_lut_by_rid() Message-Id: <20250407-ep-msi-v17-13-633ab45a31d0@nxp.com> References: <20250407-ep-msi-v17-0-633ab45a31d0@nxp.com> In-Reply-To: <20250407-ep-msi-v17-0-633ab45a31d0@nxp.com> To: Kishon Vijay Abraham I , "Rafael J. Wysocki" , Thomas Gleixner , Anup Patel , Kishon Vijay Abraham I , Marc Zyngier , Greg Kroah-Hartman , "Rafael J. Wysocki" , Danilo Krummrich , Manivannan Sadhasivam , =?utf-8?q?Krzysz?= =?utf-8?q?tof_Wilczy=C5=84ski?= , Kishon Vijay Abraham I , Bjorn Helgaas , Arnd Bergmann , Shuah Khan , Richard Zhu , Lucas Stach , Lorenzo Pieralisi , Rob Herring , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Krzysztof Kozlowski , Conor Dooley Cc: Niklas Cassel , dlemoal@kernel.org, jdmason@kudzu.us, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-pci@vger.kernel.org, linux-kselftest@vger.kernel.org, imx@lists.linux.dev, devicetree@vger.kernel.org, Frank Li X-Mailer: b4 0.13-dev-e586c X-Developer-Signature: v=1; a=ed25519-sha256; t=1744055468; l=1816; i=Frank.Li@nxp.com; s=20240130; h=from:subject:message-id; bh=E/+49PZzSike5Srwi1bFi+VTiZ02VK7QUYMJGqtvfmU=; b=j8w0fAmlCpqyPHrV4N0qSmptnnmRiClhov/GE7Jurx7cOKQCHc6slb6gL0VhVirpzo66hJaiv L8kPU2Ejzk3ClgeorH8mvGFmW3dcOAtVnUGFoqpZuKuk6ysIMlMV5nT X-Developer-Key: i=Frank.Li@nxp.com; a=ed25519; pk=I0L1sDUfPxpAkRvPKy7MdauTuSENRq+DnA+G4qcS94Q= X-ClientProxiedBy: AS4P189CA0041.EURP189.PROD.OUTLOOK.COM (2603:10a6:20b:5dd::15) To PAXPR04MB9642.eurprd04.prod.outlook.com (2603:10a6:102:240::14) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PAXPR04MB9642:EE_|PR3PR04MB7452:EE_ X-MS-Office365-Filtering-Correlation-Id: f6183e42-0ff8-4491-7235-08dd760db68a X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|376014|7416014|52116014|366016|1800799024|38350700014|921020; X-Microsoft-Antispam-Message-Info: =?utf-8?q?uqQnHTWbZdChWMBJh0FKJA9XpdZez1W?= =?utf-8?q?LO7wjTBjAgKENEldkXOZ7L6XXotEsiZS21hluerFVrqBUG6M6eKV1w770PacM/CKc?= =?utf-8?q?vBZYR5S7u9///rD+jv+BKQWmBl2tf72XbD3r5/DmD1Qy+47ky3g03waLCT9CqYcUm?= =?utf-8?q?pVAdw53q9Yb8uLsxEmvBixhIL3ykYiMurhBl+1psQoTFsmvRICmJHZP9nGkn/TUPP?= =?utf-8?q?t3ezwtWdBKHhHYG2X1xeDOFGYpvC4Hid2UCduHESYGa0ClMgmmtuJVoij+2vvcbbq?= =?utf-8?q?yBDwDEvcwQBJq1x+iLry3Zw0kw4k+BFrw5S3rPYDjlLGmDlzbNUltqSE9aTRtbCP7?= =?utf-8?q?aCrywqBoYjl7V6A0wh9KefzsBWkYXB4VqFRgoPhlhZbCb4sTK0VhoNRRAm6ATv2M1?= =?utf-8?q?BOFn5vd44/RHkbjXNMjPUlM8nUVnGMVcccS4HdxnprSHdb3QEB7B+ysnrzrByDM5z?= =?utf-8?q?/ivxmhN1huBhABLfpHl4qSxAi5dxUX85tMTdvi6lZ5musP4an8nB2golPSJmb6fwV?= =?utf-8?q?3UALJT8u6bgE/YYfEkn4WVU9tIePctJayQxDTADUFCQAVyY2n8acmTMheV0zeCFki?= =?utf-8?q?ZT2BMQLMwZtM3QJax1eRzl3jN/ITyTvZD/sOE00ZSqc6GfWbbldo6R7153dpek2Ve?= =?utf-8?q?RaMSPnNCJUryNn49pgBbkj/LHSx1MuBSboCLLNissQoMFrjP0WNxXaN1sgP7kY6P9?= =?utf-8?q?r7dt/Gg6HpjWD76sh31KCDn+AM32/6sezaQ5fiJfSrbY6JYY9ppaI3kk0ojCnZmtG?= =?utf-8?q?ABeHN3WCJ+RuD7uI8q0a0UxHDhfzAnAO3c6yFnnkXScI5yG4L33yh/4y69wIJxq9C?= =?utf-8?q?WDf5QCZ4fkXcsNXsMVhxpfCoYRgzLENATSfcnwg0zLy8NiinuODxt9H2NjZODLaae?= =?utf-8?q?rDHjcxn2yXdRYoQ7dJvELdDj3oJuTuf8CrN6qJtX8FCWn80gVcNYl1c15pyk+m/jE?= =?utf-8?q?RJAMaMn90yUgi4+R/UN+M0f/8ehszd3dbmOy+rW5I4aoFbLq8oQ7oyvOI5TegO8ZG?= =?utf-8?q?asxyS9gewAi9o75sN6NVIildwCdZYdZJrE3btQz1gOwr34LcbptFqBZiQm1SMMRRY?= =?utf-8?q?qg0aSDw/zafN92qC+EdNBVU00pwnvaMTs+aqRzj6no1mUCFbRIt7W4hBSF6Ftivin?= =?utf-8?q?35YpwSza3nNQwPFIK6qR8GsNfSat5HOK6NiVbxuIe7sZzncwXFYVmhfNMPdLkt9XO?= =?utf-8?q?TpaQd9kheXZXi31h3du3MZSIHoHmuwMqcB7GmgEqkqdg+ssuisD/sI5SwGDsHm26H?= =?utf-8?q?AWVmkybXDnZ6QBf4e/uttudQ9eXTlRrr/lEfMm2xjjSl6wCbTbuLyH27XPZ23+wh4?= =?utf-8?q?DOByUpvucTi7NkIVNEGSKsRsTLb1aDLJiWE+uYhuLMsqF57vmw1JX9aymLJ2grEhv?= =?utf-8?q?hNv7fgY4DBp6lmMQdkfOSuy1jGOM9/cQQ=3D=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PAXPR04MB9642.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(376014)(7416014)(52116014)(366016)(1800799024)(38350700014)(921020);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?q?Q0s46/h/H0ebeFSznudB+ro5J4jb?= =?utf-8?q?yGCd4qYJwBRAlmpAYjgYaVkoiz/XXhQnO1XZbKX/x2Gu0ns/ZPmKwX/fa9nH9wxY8?= =?utf-8?q?Yb5dTiDrXIbIEKq56NRn7XaOL25BfD6z4tlHWIZJHMg9Bm7/MVfWKImZsSN+VWtAC?= =?utf-8?q?oopRYDR09x6I2QNcaqlZHGZOTORfFqeo1L4WKWSO1YuW7JklOhT+LYpsRi1sEdn+c?= =?utf-8?q?qh+C5VIBQiZwhf6rX2524I3rOU+SpBhUqmEMg2UsVi3TclivKSZsoS6FKMeiuVBgh?= =?utf-8?q?2FcFAt5re/zWqo/jkzI1pK0N4KBNrQdrriK6PYQ++TC+lS3XIzTktQ5w/8K8WQpX2?= =?utf-8?q?TIPn4ewkWLDfFY2ZAvkN1SwBz7toTSpOLHRjvC0Mkb21nFKrTk6R7VcKA8h2Mij0R?= =?utf-8?q?JCyUaxT96DX4UpAPyENM/ysu0QotbpIw/P0RpzPiAZXp4rgEgXnS/GWdIYDlqT5ke?= =?utf-8?q?II3r/MRwV/N5DfxqJ/7KTxayvuB+34ZFU5iPOOhgh3c/grMXm/uZvmoThVbKzaIZo?= =?utf-8?q?G3oF4St+N7fYTZ1JWsiQhmK2BqwguSJUKGUVrlhLIFcOxVRUk8vmJDXoYBRWAQ+uN?= =?utf-8?q?VugPqU//89Nqtjr8ODtk0ZyYJ9gkARy8QAr6YebN/1m1ZxrOOsDESnSAbsoXMzMmW?= =?utf-8?q?UyYVLzYt7G60F1dN9yKQGUHFGa/f3tbXfXeFa7rHs6jvCiBrV182lcyqnD3bR1ljo?= =?utf-8?q?+PFqk9u+jXE2EFYN0+UhdcYatUXRkAcL3N4G65ym81Ah3yxyrE0lFJv4iX16u1Q34?= =?utf-8?q?3i+hDitN6di1lQ23XB+2AL+NkvCgvfCsHGGZrb1tmYVBShA7r2HTgbT3/OUVvNk4b?= =?utf-8?q?xA85WOtDhtwKAUjO1hondX4i+GOk46n9ZMpIbHzisnNe/4uVPZy41gFL7wNpy3oFj?= =?utf-8?q?lZwM2gnx7jcIL+ULSGXDAXf9LRjUfaMM90chQ+MCceUQwZlX8G0LwU9bJUwCcFzJ4?= =?utf-8?q?JH+/3Vge4+2rx2TaqBKpUIaPdkpNQgwVuU6Mzlk/aatkYJTdsXn2jV99d4BKCtCgJ?= =?utf-8?q?Rpcq1a2gSFboXLH8YZ54TRYDki5UiNxQOBQAw2EYDiech2JrW3DXDEqq5KDzzu3vZ?= =?utf-8?q?JG5GRfpcT8xxIHj85fAMVoylVG42AAkkThl4Palzjn356Ibbp3m4s0IJkGUQ9v+qf?= =?utf-8?q?N3vknD4MUo5KvuQknS1hZja5v8qVYFjwlmFzjVUupP5IMaqAdqo7dVhwpJPprD3KG?= =?utf-8?q?Mo9A0oASQIPkaIz4eDKfz2JzyHO2UA7BH6JNF03f4DwmfI7b0hGNQ6W90VrTn7XLD?= =?utf-8?q?r9BxAyQT+7LTHjxfjulMAi84KTrJyMlNWjbVLFTqkfqh0dneVUI8MxGV1SShzvQe0?= =?utf-8?q?eI3cSYPK9Ih/eLkyPJEKuPu0juhDc1Y4P6tDdLQXGyalBdEC2XP5UrOcPW7j/HfZZ?= =?utf-8?q?7TeGkk/Dd3omB84zfKGjPwTLBYG/c7T9g2TuCovCeQA3PdjwS9G7USSlW5YQGUs7q?= =?utf-8?q?BTWNGfX9Nd8FlJ4XMlmxe+oKqRTFohmhJBVvFf/d2biQRCkFC4ffwQwmbaG0K46ag?= =?utf-8?q?6SbK6LbtWrVg?= X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: f6183e42-0ff8-4491-7235-08dd760db68a X-MS-Exchange-CrossTenant-AuthSource: PAXPR04MB9642.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Apr 2025 19:52:22.6833 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: iV28CizdVmiUin/P0LMbj9D83t969PCeLiHPFFXQGHcbUr43z+dSO18qxKK2+Etsatq6CU3spKKjT8yB6PnOQg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PR3PR04MB7452 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250407_125226_216372_63BE3AED X-CRM114-Status: GOOD ( 13.56 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Add helper function imx_pcie_add_lut_by_rid(), which will be used for Endpoint mode in the future. No functional change. Signed-off-by: Frank Li --- change from v14 to v16 - none change from v13 to v14 - new patch --- drivers/pci/controller/dwc/pci-imx6.c | 17 ++++++++++------- 1 file changed, 10 insertions(+), 7 deletions(-) diff --git a/drivers/pci/controller/dwc/pci-imx6.c b/drivers/pci/controller/dwc/pci-imx6.c index 5f267dd261b51..d1b1365e7469e 100644 --- a/drivers/pci/controller/dwc/pci-imx6.c +++ b/drivers/pci/controller/dwc/pci-imx6.c @@ -1025,18 +1025,14 @@ static void imx_pcie_remove_lut(struct imx_pcie *imx_pcie, u16 rid) } } -static int imx_pcie_enable_device(struct pci_host_bridge *bridge, - struct pci_dev *pdev) +static int imx_pcie_add_lut_by_rid(struct imx_pcie *imx_pcie, u32 rid) { - struct imx_pcie *imx_pcie = to_imx_pcie(to_dw_pcie_from_pp(bridge->sysdata)); - u32 sid_i, sid_m, rid = pci_dev_id(pdev); + struct device *dev = imx_pcie->pci->dev; struct device_node *target; - struct device *dev; + u32 sid_i, sid_m; int err_i, err_m; u32 sid = 0; - dev = imx_pcie->pci->dev; - target = NULL; err_i = of_map_id(dev->of_node, rid, "iommu-map", "iommu-map-mask", &target, &sid_i); @@ -1111,6 +1107,13 @@ static int imx_pcie_enable_device(struct pci_host_bridge *bridge, return imx_pcie_add_lut(imx_pcie, rid, sid); } +static int imx_pcie_enable_device(struct pci_host_bridge *bridge, struct pci_dev *pdev) +{ + struct imx_pcie *imx_pcie = to_imx_pcie(to_dw_pcie_from_pp(bridge->sysdata)); + + return imx_pcie_add_lut_by_rid(imx_pcie, pci_dev_id(pdev)); +} + static void imx_pcie_disable_device(struct pci_host_bridge *bridge, struct pci_dev *pdev) { From patchwork Mon Apr 7 19:51:04 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Frank Li X-Patchwork-Id: 14041898 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 4D2E1C369A4 for ; Mon, 7 Apr 2025 21:48:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:MIME-Version:Cc:To: In-Reply-To:References:Message-Id:Content-Transfer-Encoding:Content-Type: Subject:Date:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=MbXHpTIvY3lK/PUhp27uVmw/pyQFw3cH2yjbLrE9G6w=; b=ObsiTh/ThLxLvLkDIkkC6ygWz8 sz2xXllBuozLxYFlzEvk9D10pN0mB7Ro5FCfiK+K1aE/J2fxARFQzXXbA9ckveMzyasSs1nlrDtm0 Xr6mPyvRXmSBiGYu6QRnoXOUYuETJK9wxSdfIXMMwFfjFVTzUxWH6AjewWgZPtfXfFcXWCRcUli+z AZvygJ9g6zJeS7c7ONOsnaF4BkG+aHn33oznOA499NUmknzX/j5eqlDN74hGhOjGbifFRtT7coi1+ gYWpYQ1o2gLJi0enwoY7X1VCZ7R9OyTVNx1Ig4bskQLPqHix6uN4dix/cqqYvM5Ya0oBmf3/PrsPk okzfr7PQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.1 #2 (Red Hat Linux)) id 1u1uKB-000000026YZ-1JKZ; Mon, 07 Apr 2025 21:48:11 +0000 Received: from mail-db8eur05on20630.outbound.protection.outlook.com ([2a01:111:f403:2614::630] helo=EUR05-DB8-obe.outbound.protection.outlook.com) by bombadil.infradead.org with esmtps (Exim 4.98.1 #2 (Red Hat Linux)) id 1u1sWE-00000001saN-3S6a for linux-arm-kernel@lists.infradead.org; Mon, 07 Apr 2025 19:52:31 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=eld8ufndr6/CzTXVFfTkdU+WInJQqwnCa+Ts+xTLMIvTSVXMjntnFAe/oQf1++2LiHrw7FqtnfzFlB7iZDLC3CGdZCSKevDKLWXdbzA4tJImymv89Aa3IGEiz+Vy6rTckDUzTPOlYOjGvXKn3QDRGVrZyie1CMPrJLHMsVeudOQnHZVfNZyaXz992lGndC457uTiw2YHUgScJCSjrmn2+eWK3T32LFvioHkvj7DTTDTdCeYxo/aeazhFoHOUOGVLySsozsUSkNVICtRdN3cmBolw7nn0DbueaAyBsqKw8oEeG6VJeflI0kHFWxcawZ9lQ9HLa79954X+RkOvqqtf7Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=MbXHpTIvY3lK/PUhp27uVmw/pyQFw3cH2yjbLrE9G6w=; b=bYqM19LYN8j3XwxpVmO4vsgZa1fjj80duU4Hq/qWPioF0Rhz0MqbyFYxyaOQ/+xiKLrSJHhDkH4ov+abrVzL+CUQxvPURSmM5i4yXWfc4cD1mgE9Th+n6u5BzaBX9SIHsJcoO3TKrT4NXNes0dzA0e19XbANb6ISkLg0gYTsgOEoWNzBLft9DIFpzURTqaCdGGWAX8pXuPK+Wx2gq2kHbcAKVpDAVIoMU/fuAmCbT6/UBw8jWtF/nlYPbWgp9FASZ5pqaKG8UILkwdJuvcuF9oaip2+9moe5fa8toskA2Xq2ZnDIT/fattHr/Pw71vwDpgQUUfB7KsFaOheh+szUyg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=MbXHpTIvY3lK/PUhp27uVmw/pyQFw3cH2yjbLrE9G6w=; b=ZP2Wpigx9Tzn2QK77vaI66xLPTSp/Z8dUZJHanKd8gvZ/E6/Lc43H2Bjz7iCCUMHaL+/iZDJZ9uiu3KhmeGZG4RbRJYnvaobuLMscpl2uFBpntccTJhI3T7zuHO2s+j7xYX+g0Ib6jK+jglNJYeXUUmZ98hjov19NEN8Gwt325o4dvxNPhFvLm+XCpcxQ+2TEEKfh1OhUdgGPExyhRI3CtsViSKBT5PKPKg0azekuTOSlm8dexrV4GAeFzo651k84tPIeE+Wp0RDqsk+QUnZqE60tZyfSNSZeP2p53px1sn/fGIP1JjsSQlOqDRch7B70lyulE/SekVZ9a2SN7VgdA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nxp.com; Received: from PAXPR04MB9642.eurprd04.prod.outlook.com (2603:10a6:102:240::14) by PR3PR04MB7452.eurprd04.prod.outlook.com (2603:10a6:102:80::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8606.34; Mon, 7 Apr 2025 19:52:28 +0000 Received: from PAXPR04MB9642.eurprd04.prod.outlook.com ([fe80::9126:a61e:341d:4b06]) by PAXPR04MB9642.eurprd04.prod.outlook.com ([fe80::9126:a61e:341d:4b06%2]) with mapi id 15.20.8606.029; Mon, 7 Apr 2025 19:52:28 +0000 From: Frank Li Date: Mon, 07 Apr 2025 15:51:04 -0400 Subject: [PATCH v17 14/15] pci: imx6: Add LUT setting for MSI/IOMMU in Endpoint mode Message-Id: <20250407-ep-msi-v17-14-633ab45a31d0@nxp.com> References: <20250407-ep-msi-v17-0-633ab45a31d0@nxp.com> In-Reply-To: <20250407-ep-msi-v17-0-633ab45a31d0@nxp.com> To: Kishon Vijay Abraham I , "Rafael J. Wysocki" , Thomas Gleixner , Anup Patel , Kishon Vijay Abraham I , Marc Zyngier , Greg Kroah-Hartman , "Rafael J. Wysocki" , Danilo Krummrich , Manivannan Sadhasivam , =?utf-8?q?Krzysz?= =?utf-8?q?tof_Wilczy=C5=84ski?= , Kishon Vijay Abraham I , Bjorn Helgaas , Arnd Bergmann , Shuah Khan , Richard Zhu , Lucas Stach , Lorenzo Pieralisi , Rob Herring , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Krzysztof Kozlowski , Conor Dooley Cc: Niklas Cassel , dlemoal@kernel.org, jdmason@kudzu.us, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-pci@vger.kernel.org, linux-kselftest@vger.kernel.org, imx@lists.linux.dev, devicetree@vger.kernel.org, Frank Li X-Mailer: b4 0.13-dev-e586c X-Developer-Signature: v=1; a=ed25519-sha256; t=1744055468; l=1486; i=Frank.Li@nxp.com; s=20240130; h=from:subject:message-id; bh=y13NGoBJeE1mUHUBweMBxtJI2C8OON0QvH2vvgiDgJs=; b=Aw+d+Gamxsf/Lhl1B/XKnOYRNdM+fzI+azX0X92agdxDe4V7Xm8Bpd3gaeyVSO2unvLzg5X9M o9vQwdsfpisCcNjR0TmIhfpw1BVlBKkjJgpVyl9DipBU1gWlTLRrGjf X-Developer-Key: i=Frank.Li@nxp.com; a=ed25519; pk=I0L1sDUfPxpAkRvPKy7MdauTuSENRq+DnA+G4qcS94Q= X-ClientProxiedBy: AS4P189CA0041.EURP189.PROD.OUTLOOK.COM (2603:10a6:20b:5dd::15) To PAXPR04MB9642.eurprd04.prod.outlook.com (2603:10a6:102:240::14) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PAXPR04MB9642:EE_|PR3PR04MB7452:EE_ X-MS-Office365-Filtering-Correlation-Id: 7fbd6d77-a6ac-4e0a-93c6-08dd760db9cd X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|376014|7416014|52116014|366016|1800799024|38350700014|921020; X-Microsoft-Antispam-Message-Info: =?utf-8?q?SJsgLVDq7qwzN0rViZuez9Il4eoO1Yy?= =?utf-8?q?f85wd1yMaV2KDSOh57Cn7W8bFKoMontSxhowHzEuN9fpXfnk5ubZkxHUAG84HjudE?= =?utf-8?q?+adEJuIDzEwcp/s1jGhCsJ1TO1el2OaFOA6LYeYgd3Tys0MXCeylIN44tXeb6ZxuN?= =?utf-8?q?Ve4ZHGyQS/dOR2b1REKv/cdzQ7bTzXaCfOTsJjSY7bG/HpD+pa7DCkc8IGEbuPblB?= =?utf-8?q?A8v8ac6NGxG2KwJcpFcsCESD59mbLQBA9XynShkeldILxIZz3FhOM72VcER9poJoP?= =?utf-8?q?JjFLFZfaecLN4308XpKxesA54GLG72cIoB6BWvFcny5IH2AQUtnCvO9zQgGLtkIjL?= =?utf-8?q?lplxEXdSwOetsscZD7ak4mc7Bv472Ua/RcysMtBK9S2kTLAGIRZXpMyhRqpfkNxn0?= =?utf-8?q?ikRzcaXLbrs7T9EvCsGmt3EK5ANCAnFeBFUxnofe8b7HYTRqqA8kVy4dic4+rQycj?= =?utf-8?q?lrO04iAObBmfgASU+Ab215Fzi1dqTqdAygGQgkoL0Y4yFgRgkvsihtXZJU5N4t88S?= =?utf-8?q?KRCymBMEf0q6gGvrIYqMK7/h6QEgW+xBku7OMaL8kgcjYy8eu5NZ9PcTPFnl1N8kj?= =?utf-8?q?iUHYxvCd5FywAvI2M6NzKTvBsHmYSGRxgr6pn6hR/rLxCjllhP7zKs7QWMQgxY6mP?= =?utf-8?q?VC/wWkiBH7IYrMVO311x7pyO7MGPkx9xlzbhQB3mJirU73kKnkKdwxwzOF5f0iUzZ?= =?utf-8?q?AmAkYK8aN8O5DLgoWB7FOSJ4QpxyfgAQfjprtiPSyV8QWnlYsqtzqDXvzAxK2VjSf?= =?utf-8?q?dMCBDNt9CwZNh5qRzmye5XP0ZI2NiLcV2LdNugbfW0Q7zV1oRQLM2fndG3OfAMlpS?= =?utf-8?q?utyLaNnZNVeMqvm8ADZj4orhYGzvYhN7d7Wq2R+G3Ii3X6J4b4oMhXIEaH4pb9d+z?= =?utf-8?q?LTtNJOOIZFDjA+Ph5K+HoiJpdqn9k96LqASwea+VHqaSI/Ix3zRR7GhvKZOKMpbCu?= =?utf-8?q?mS2eXjN5yzMRwemWvyQrHkxDeCkUkjfU47+GJPeWT7mVJhUMv56BFd5alt3si2WCM?= =?utf-8?q?hn8k6CmBPTqsAtL7wJ6bp4uW8i7L4lQOVUaq79H637QAqUt3HeOCMT7vD+XUw9iE1?= =?utf-8?q?A+2k1TITkFm9mW0jGHNOPBDBHwsvnrjiFBo5x9LroQ3akbGoNMawFIbuveKbJWmS2?= =?utf-8?q?Mraa+CnAvM9/mQbD7aWiXM9WOtpl4UxGUvO66A2TTThk52pIognsziTjyluB2KzR+?= =?utf-8?q?scxZNh0hoTcxqp2gZfvTR5Ky+IGstYk6onJI8xwG6afZMoPuLY8HwO50Ksfc2Atoj?= =?utf-8?q?fQ7ZZSsrvmOIiOaUNqzlblpFINRRZx9HWenrWfztckRAZwp92qTeFGLIgvZv2OBPr?= =?utf-8?q?uY5kx7/hYPlU7vddnklsdaRVESy9vkaBRhS9YsNYMO7FeQ0Kci8KYAowVpMf8lZNb?= =?utf-8?q?N/Ahw8HmsRE/m7OOK9SH5+Qotm7OwIKKQ=3D=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PAXPR04MB9642.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(376014)(7416014)(52116014)(366016)(1800799024)(38350700014)(921020);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?q?byocNhRgz6qtOR4h51eSi6ByU0cB?= =?utf-8?q?lRUwaWRwc6A7BEAyHtv6qQVwZaAwXR0ZX0JpB2LgtZuskqtBhyxo48Be1HLlCE8NC?= =?utf-8?q?HLeyb4Mfnlg/3ryTIluoD/l3lJpzY1swuggYxKdN+ovQfEIrc2eNOyXYSg3a22Etc?= =?utf-8?q?MkPI0eCecsDJ+8vAnBuor1jmgSY44NfRXgjftIZwTnGhbavNqN9xEkwRPR57Hr4a/?= =?utf-8?q?J6eB3ZRtp+aKwIzAu6J8V9lj0pbbRuhDOVTV4iyhCKVxEcXDmWyvEn5UVbeT0WqD6?= =?utf-8?q?bWgG37fReossko2COj+WV6XbgGivrsOqJcULDscGBwQ7aWb4zOgDemn8B1lMlIgmc?= =?utf-8?q?4sv2NAYFhxYT7R0asvCJYkG86od/ulNqF+cssC1qCRgcfl2M0aq5dGyZdGUR81vFc?= =?utf-8?q?Z7mwT4iH9poIbxqqgv/+xWkoHw7PFrL+hZrbs/1zB7oIFFDZuhHYmOh6rTRQbRKcW?= =?utf-8?q?AinkmqeSyGrgvNzUZeywdCFrOj9HfHDCPAOPZoL6dhWD6MObMAy+RZ7TI/HpSFyt5?= =?utf-8?q?zj7bObGsLigl9FovG0ybTDb2346pYlka6B+7pjGazKBTAYhncBGvWtzKRp3FLbQtQ?= =?utf-8?q?T0cXJy9R9E61/EMS/PZWcmXQEw09lbtKFMNZWMgF5edMcYXqQAO32xcoUpm7dJFTY?= =?utf-8?q?fdQ/aNsYEhPvdJ+cG4vbbTC6Zb4UjWzErZ1mak6eJEgm9X+dnhQCyglYZ/8wGBJ1f?= =?utf-8?q?tXGoIV2EBZiGSv8dPt2lPXrAedwell8asxZMI5LGLlSD+mAQej1h6vELh70DHTPGd?= =?utf-8?q?+YIDD16BGokaNM1XDSLH9tmu8/tsxfKG1XzQwoVw62CpID+VQiRWtI19AY11SJeyM?= =?utf-8?q?j0tUyAumpfOZzGiAvXMgybGwM4OoeXWO/rv4OoeTbP7NkLzvdUMYv5zdahI1Ubbe6?= =?utf-8?q?VuFRpIs/1PSwJZEt1Ra/lzGIuU43ckTfhOc8enlYyeagZ549St7yV2jeZY3cWIhun?= =?utf-8?q?JiLKcHytXeQtjGp95eR1AlgJHBgyvR/v7pXWerMGfUr5CIl1xoJ+oWcvLneMw+BlR?= =?utf-8?q?nGdZI4lKXz/ylby+BjEhWPhu/cZQhyvplDYg7H+wjMXtWAjIPYdA8XYJSlzjpmh9c?= =?utf-8?q?E88kBJ+Q548FslVK/64TvmkmUn3wqYWJq7djhiP+ugJ3IF+QmXNQTGnkkUd2JdCx+?= =?utf-8?q?sefLD6u4XnUSaUJGvtZ7pup4al1TgOU3qql6pGP28wPIbCDNo0obA7o77n+nJ3SMl?= =?utf-8?q?vzf8Z77hpB8e6qvHQnJCPhGyU450dXioDiuWSPvGocDM3lH3It5afZSxmM+ePVC5C?= =?utf-8?q?muQaRBp44LyRQ2b6eDEXhTQmogr/5ktVsjP4jKl0GsAk+vGtd0OVvsWqrxAkkc1ew?= =?utf-8?q?hzLJKCrhpcOVlAQwYXgb8IJlyyr6j7l/bscodDhX9MEuNPRYIyYlZda62lXlIw/5U?= =?utf-8?q?pGqivK+/fXRdpAGrQlV/Be9t5Jb1f585fsi5ijMInrIBxD6c0zx5NEfhTTcA/5sxr?= =?utf-8?q?osmKoVxoSLo3YX04EIXDO1JsbKkN2PwwENQ5FGGz3hHYkFJ0pi+R+YQNbOCtJf4+P?= =?utf-8?q?zmCDF6y7Scaj?= X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 7fbd6d77-a6ac-4e0a-93c6-08dd760db9cd X-MS-Exchange-CrossTenant-AuthSource: PAXPR04MB9642.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Apr 2025 19:52:28.1336 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: RSTKlSmeQW9FCavh73R7WUlFx1lHJ9cX4/iMnxr6NQ+3AgCzaKPB3XJaBbi8NPhWt1WKRSosI3cAGcAnTEBNwg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PR3PR04MB7452 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250407_125230_866482_C8200C7D X-CRM114-Status: GOOD ( 15.14 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Support only one physical function, so call imx_pcie_add_lut_by_rid(0) to add a single LUT entry when operating in EP mode. Signed-off-by: Frank Li --- change from v14 to v16 - none change from v13 to v14 - new patch --- drivers/pci/controller/dwc/pci-imx6.c | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/drivers/pci/controller/dwc/pci-imx6.c b/drivers/pci/controller/dwc/pci-imx6.c index d1b1365e7469e..a6e4630fcf530 100644 --- a/drivers/pci/controller/dwc/pci-imx6.c +++ b/drivers/pci/controller/dwc/pci-imx6.c @@ -992,7 +992,10 @@ static int imx_pcie_add_lut(struct imx_pcie *imx_pcie, u16 rid, u8 sid) data1 |= IMX95_PE0_LUT_VLD; regmap_write(imx_pcie->iomuxc_gpr, IMX95_PE0_LUT_DATA1, data1); - data2 = IMX95_PE0_LUT_MASK; /* Match all bits of RID */ + if (imx_pcie->drvdata->mode == DW_PCIE_EP_TYPE) + data2 = 0x7; /* EP side's RID from RC, only 'D' is meansful */ + else + data2 = IMX95_PE0_LUT_MASK; /* Match all bits of RID */ data2 |= FIELD_PREP(IMX95_PE0_LUT_REQID, rid); regmap_write(imx_pcie->iomuxc_gpr, IMX95_PE0_LUT_DATA2, data2); @@ -1622,6 +1625,9 @@ static int imx_pcie_probe(struct platform_device *pdev) ret = imx_add_pcie_ep(imx_pcie, pdev); if (ret < 0) return ret; + + /* Only support one physical function */ + imx_pcie_add_lut_by_rid(imx_pcie, 0); } else { pci->pp.use_atu_msg = true; ret = dw_pcie_host_init(&pci->pp); From patchwork Mon Apr 7 19:51:05 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Frank Li X-Patchwork-Id: 14041901 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 6AADAC369A1 for ; Mon, 7 Apr 2025 21:48:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:MIME-Version:Cc:To: In-Reply-To:References:Message-Id:Content-Transfer-Encoding:Content-Type: Subject:Date:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=3HXJMXZ9LGUTZustVJgA/C/zKgpGDb31Acgkq44bsAc=; b=iKRgoRXto6gKgHLtKwqlD2zdgv IiNHFrOUfflX8BeN/J1mB8BLq+QCvDCweeC/0X4iA3QT1PB5XDU8qPeHyrPinqImNWT4BBZVSLLlP lrJRTGlrb2cph1sMFPVSeOYa2AQ99nxYvcWTgnGG4YwOA0qF0SqYDilp+1qHXizMNQqzSNI0tP2Iy tDC/wSDwB1Y3thfP8RD/kdITM0ohBlQBY7zxu935a6bFcF/s4YOmEppxuL3cymX9SddXdk7RgDtaZ F10GfRhjSanK+Lh/sSZiRQIoDaL1ltgM6MDjeNAVgSH7BPT8ttFcjkqFkKDjMP9oOhMp1xQ+6xPaN PPCR+ijQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.1 #2 (Red Hat Linux)) id 1u1uKC-000000026bD-1Vm9; Mon, 07 Apr 2025 21:48:12 +0000 Received: from mail-am6eur05on20623.outbound.protection.outlook.com ([2a01:111:f403:2612::623] helo=EUR05-AM6-obe.outbound.protection.outlook.com) by bombadil.infradead.org with esmtps (Exim 4.98.1 #2 (Red Hat Linux)) id 1u1sWK-00000001sbf-0xEE for linux-arm-kernel@lists.infradead.org; Mon, 07 Apr 2025 19:52:37 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=Qp06LB8Bek7Ua4jXlJlSb8ao3XYfSO/NQEY8XFizwWLTGL+6bZVdnVLyOHxAaDErmNkUEZxyIjRp6HeaaWi2X4cbkBBrF/QGsnm2yph1MQUcc0MT4b5+esT1Ey+INm5gLAhRGt+pIyGWaGbtX+ogUDidtSnXual88g9eq+XvdjbywblcnDYgclE5eu2b+Z7G4W0n99cU2MoVC/9TSZDHIMrkVxkdBVlbhr+N7I0G2VhuvBZPYCCupC63DPAMtXzOza4378mwIDuX0hPVl6QpEN0Zzihbe0dKAJ5WQ9uX9x91aNACurLXGnzNKbL2qDvFMMoJiXudXyMYo9SHZvdBUA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=3HXJMXZ9LGUTZustVJgA/C/zKgpGDb31Acgkq44bsAc=; b=FXSAd+YHTG8o0LSf/nB6U4faFM7pd2BixGY1d7yskMv/pxXCdRxwlILYAclNIw8NcDBwHrJXdRl0uqJ2vHavG2rd1U18AkwbRSREMb3UeQeG34y9KT3TBDmuE3Bd5LQfzLLjAXYkzBHDW82RxcGPJL5u+c+fSXhL7j9JJm77njW9168Uf/8eQrYUKQfnQjDNBJ8Kaa4EnG6KQNOcvcupOJvgL7/TVGciC0zQGG9jah0pNXlI8on/5Gx4kny/H0CunUdi/rLNNtaiLDmLpk7Sk0VIZz5ehY84Kcfeq89JtI1HH8g9v90SzwSZraDqzq1CfRvgZMgJw6LfO6GyNjuLJA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=3HXJMXZ9LGUTZustVJgA/C/zKgpGDb31Acgkq44bsAc=; b=d752ZsQNlLkRl+iX7nsN2I1hAwTL8q1PIOGI3zQcHCv+2m5H0wHbGI3kG+D+Hhe5i5j/MbgEDQIA3k39np8E8B0CLr0K+8R80oxQ4IohfzeP+nXL0fPqXmH6mXBzy/+KLv2gZYIlKDq2gFURztZIXUdU9YEZDSLm7BN4+aQXhnK+7ejYPO7bpCRMHjAUGCH6qBLyv19GXjc6ZbLYKAnLlpOqk1jDHkRrI7dm+0peVQUE5IJmvrw6mIk0KkRZTe6x2kevWanH6LvXGsN1W3HX5ON1yVid6RWkAt1blYoUHQxybjTR3NtdlbxRpeHvURPkUa6Bw89DycuEG8cagS/1YQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nxp.com; Received: from PAXPR04MB9642.eurprd04.prod.outlook.com (2603:10a6:102:240::14) by PR3PR04MB7452.eurprd04.prod.outlook.com (2603:10a6:102:80::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8606.34; Mon, 7 Apr 2025 19:52:33 +0000 Received: from PAXPR04MB9642.eurprd04.prod.outlook.com ([fe80::9126:a61e:341d:4b06]) by PAXPR04MB9642.eurprd04.prod.outlook.com ([fe80::9126:a61e:341d:4b06%2]) with mapi id 15.20.8606.029; Mon, 7 Apr 2025 19:52:33 +0000 From: Frank Li Date: Mon, 07 Apr 2025 15:51:05 -0400 Subject: [PATCH v17 15/15] arm64: dts: imx95: Add msi-map for pci-ep device Message-Id: <20250407-ep-msi-v17-15-633ab45a31d0@nxp.com> References: <20250407-ep-msi-v17-0-633ab45a31d0@nxp.com> In-Reply-To: <20250407-ep-msi-v17-0-633ab45a31d0@nxp.com> To: Kishon Vijay Abraham I , "Rafael J. Wysocki" , Thomas Gleixner , Anup Patel , Kishon Vijay Abraham I , Marc Zyngier , Greg Kroah-Hartman , "Rafael J. Wysocki" , Danilo Krummrich , Manivannan Sadhasivam , =?utf-8?q?Krzysz?= =?utf-8?q?tof_Wilczy=C5=84ski?= , Kishon Vijay Abraham I , Bjorn Helgaas , Arnd Bergmann , Shuah Khan , Richard Zhu , Lucas Stach , Lorenzo Pieralisi , Rob Herring , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Krzysztof Kozlowski , Conor Dooley Cc: Niklas Cassel , dlemoal@kernel.org, jdmason@kudzu.us, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-pci@vger.kernel.org, linux-kselftest@vger.kernel.org, imx@lists.linux.dev, devicetree@vger.kernel.org, Frank Li X-Mailer: b4 0.13-dev-e586c X-Developer-Signature: v=1; a=ed25519-sha256; t=1744055468; l=827; i=Frank.Li@nxp.com; s=20240130; h=from:subject:message-id; bh=qxV51hE9iVaqehK/qn4rz9KrbxpDkLsIBLjf7RRGT20=; b=r2+4fvsAkmquI/lDxL6ovaIFymtnoci8MOwzny0OC8txBlZqw8k4FA2/YUz17OfVfYmxv/mGm iuXOBfZVv4TC13rhFmXvJLx8G3wlQplCtBogmVwohaGgMRmCGywMwEH X-Developer-Key: i=Frank.Li@nxp.com; a=ed25519; pk=I0L1sDUfPxpAkRvPKy7MdauTuSENRq+DnA+G4qcS94Q= X-ClientProxiedBy: AS4P189CA0041.EURP189.PROD.OUTLOOK.COM (2603:10a6:20b:5dd::15) To PAXPR04MB9642.eurprd04.prod.outlook.com (2603:10a6:102:240::14) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PAXPR04MB9642:EE_|PR3PR04MB7452:EE_ X-MS-Office365-Filtering-Correlation-Id: 0da3af99-c323-42d5-0832-08dd760dbcf8 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|376014|7416014|52116014|366016|1800799024|38350700014|921020; X-Microsoft-Antispam-Message-Info: =?utf-8?q?Ld3NxFLmhwt+m99hSFpMuszfNj2SbYJ?= =?utf-8?q?coOQS/UPYtM2gJXnnyl6kzzeCLiUy0p/f0rp6mOoAQ/KcsPIc/7rV/xR1cpa63xVQ?= =?utf-8?q?YOdGPsOli3NhPj3ouybDD/iWk9FyE7qODzGVg6wZAizKA3k9URCowJJ5q1y6LdvRD?= =?utf-8?q?ly87yXxmKsc7BwKWeeoyr3tQ4WFIJfYXFmCP9M9b28vo1LPDu0fxT1jzcoeZqdS0u?= =?utf-8?q?6V9a+jNfvomtloCXfC0imeUepaZUqL1XCJSagJfFAH8ndlnJOUvAh/EY9eaAUrw9d?= =?utf-8?q?OG92mNXegVnn2Eg3XE3b8FXC7P6D9E2+lQiEYIJX3aM1TJEvpHdCMXJUclo1cc2Id?= =?utf-8?q?jGHuVq0Ykt3WC7q8OIInT6REK2YH1lAa09J2HxrQ8KyRrgbMXbWvDbaNN3T9iWK8y?= =?utf-8?q?j3jdlm9FY1z/SoD/I2DCs5NZewtrtbVPCPo5QbJhKdPcQC/4esKDWuwSn6Owg7nyV?= =?utf-8?q?b2LTLX2KYfAYVjvasn8W5O/GY/X8YnCOQ7HKMJCdI9zRcJ/iHu+WUdUy5HjLpazir?= =?utf-8?q?PJwrB/RoRB4xfoi545fiJ65bTr+a7dnrfv1w7TUjRdC+NrMICfrTa4uC1hcf+sk+J?= =?utf-8?q?nsrKEwU9P0bKBmJKYQ1xPy58WFA2d9hGqp2yYfY/Qtq876T7ro+d74tvCAK6DtQHB?= =?utf-8?q?f4ZJcXIIeirbDgCSgwgE3r7QXf64doNqnvpgG1C3nFdRmMAZ4Zo3utqB6TLrIo6HZ?= =?utf-8?q?pOQ0tOF10ySgP6kQynK0iSZVv0dhXCzSXvZt71aQ7uQqqDw1u+KcWb3oblbyNuMWf?= =?utf-8?q?TRLHkF5tlIm99ih6U3eFWOBkfCoUtANKfYpkyc4z8iwY6GQZpDkxJtZ4/aPHpAAEG?= =?utf-8?q?FsIaYqUgxsLfjUQuX6QPn0oGY+ndCHcLsh9dTTAFJ9vPimXXde8NjXW16dU2HB2Yo?= =?utf-8?q?gII9ziYjQQEAZWVVXGXwz08wHcttVRVl+8SwNeBss4Apu31DvcNfLLQA0293sT2+W?= =?utf-8?q?dvxU1WSbQDRCO0FFEukT5rz6S9qzb7lHFQ0ph7nG/2nQmX3ozVA3V44KDt0Y74OPS?= =?utf-8?q?im2GowZ4UvoAwE4G8oTwr/R8jWZWpYPFeU8tucBhqChkiz8ys8q+AiNzSvItenGYk?= =?utf-8?q?b0pA1m9s9kYZp0kUNkLPYFpaPkLTUSLJzt4HBWDBtR5gQN6bg8FjPlamCjBruSrOE?= =?utf-8?q?deDxeDeCv/zqhwto24wr1amlycs/dh8CRvLXZ9X43D454BNdwqfgcakKrDoQ8eoXu?= =?utf-8?q?p//H/ur3LX95cZ+HvTUY86LdXsA5Z4EBwr5nU1hTR1es3sonjhfda+e5NiBkYDD4p?= =?utf-8?q?uwCEWH58kB1AgKmCJvp1Nq7vaC9WFU776qfMnKrf6uFulsmTyZAU07kZmzkajhs8t?= =?utf-8?q?Lbya9r6nuyjXmkkHhGs75Oi2otrG+/8eTRrEvUXtiyo8Yk+cwu6/yASkfRF2jnNZW?= =?utf-8?q?GOWc+/pDcUMY61iuyhGmCLxsFpyYQcFbw=3D=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PAXPR04MB9642.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(376014)(7416014)(52116014)(366016)(1800799024)(38350700014)(921020);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?q?FTzpNWS2KkqiOCjY8fiPvCITAMAf?= =?utf-8?q?b6GkJc2QoszYI3P9EDzIN55UIX0/649KznWOXWbyhQWzWj8GRMmFOvC5u6+Waq8kk?= =?utf-8?q?nwD1gZoyG1xcUPtYBoZVCJaK3Xjc8RfaRkR9qW35PIPQFPsBGpkuaxYH3cIkpOXP3?= =?utf-8?q?YbKTEvvfG59XNmBsfU3+DpMepBEFQsEDYa9z9qht94XtBkCSv4aoWw4CxRa/9U2ko?= =?utf-8?q?W4KKKaZvuSjnvVLQ4HYCr4DDfi+2mk0hV+i1z1gAx9lSrATC6bDjdffD3fqmWyKUX?= =?utf-8?q?zJZH7VfGODU0TyADUnqu342dhANaEGoeHYfXUU2z2i4lCzUmRgFlmM6lnwhoOV5y6?= =?utf-8?q?cGo6tqPgPQQoUndRpOQLYc3+unTIYaOdRnbTG8IDpXC52fWXMIRmJVO9Ls7qc83J3?= =?utf-8?q?o6FdsPyvvbyKv3mVTE6aMpfGVq44Mf+MwwGsFpOtGcFqGzgEFGHEv8XntaZTKk6+N?= =?utf-8?q?pcXpYJi+VzBYV0ziwJ5EQC5uR8Vbs30HF12QrWJRI6dW9jG8XOgLtF1OgPvLWXTVe?= =?utf-8?q?hXg5l3J9GBITXO44Q0sSCs91f7Pntlj3xcE+FmT0vw8qYxEYbrFBSSoQJ42h+Y3cL?= =?utf-8?q?Qncv7HvDMH+kPkdhKM3cFfGdsgsPFYIOqlzdjHsfNkf8OE20t3CUfYdJg9Q0Drnpc?= =?utf-8?q?aEyXOSS3i4lTfHLsX6iK21qUlNFsXEwLpt7Xl4wSG8XK4AjEMX8D7vbRgCK9Ys6SQ?= =?utf-8?q?ITFtNm9fR/xq1UeUDBrOEQ1OUUpR5o8t4xGaN9dSczkTLNgfb5ikgnUEeaPIxwc+p?= =?utf-8?q?jSAzuDf0qXTfZ806fBzkhIIZ78epLEDSzYq/dDOA4tEySee7gHWow6KbHlN5Qe5Vq?= =?utf-8?q?I5e9zSr++aJ1jHZiN9izL0o4NNDbOqwjqKHTtDXK/t/3SE4Syi8lLVvhix4+7LtN8?= =?utf-8?q?PrU7tKCRcHd1Bqo0oO8V1JfIfdsmpUWF4tBtzCL1EdGdAcU8/eY/t0ADtjnF80CEH?= =?utf-8?q?oTd5Ae57P7eCQgBwzTBUBbtbLQL6GCmGkNnOCjqEXH+MYjgEVfnncQzQR2LpmQTrS?= =?utf-8?q?trI18SsdcMcsHYjrozb1rfHCw8oxdrGPtTRFNkzRu2kbd0t83Vx3wjzBgopmqIHtH?= =?utf-8?q?P8tpcZ4xE7HJEjfBc0gyXGExmaSFuC5wPJMy1OeD9jQv1kZEfWJsNHXnqrHw+2WQi?= =?utf-8?q?OddLqJ8zCXb29+NyYXq3cULisTIhi+IbkOziQv7BxuC/NuJenjEl7+wD/XTOXA6zz?= =?utf-8?q?85qBY31zjNWzVnVgqo257+ZZlwLdsd7CiVHT/9QokEw8uxoH+rgB3XQYFfHcB04p6?= =?utf-8?q?MU8TqMQ4JCt93ocEaXkLDBa6jQT/kJ8UiEY7OUjOWnx/i8qSkONNW6/hH0I4Ljihx?= =?utf-8?q?1voZgCtVADvun4Y66RdpCdnalAgBGMu5TY7Mwn4EbtL1MXvow7j0UHXoAOrNo1e5R?= =?utf-8?q?lLMlgPHwd1wfFCCdX4T2XpEPAtjMrmYCcbVls7EOugoMV79qUDn8UgpUvQSC9uwvy?= =?utf-8?q?TJ05hPgZPxONac05yAC0jrKqEehrIMW9GpBdOCtohsK2/Qx+EIUDYYkvoySe764/3?= =?utf-8?q?fwezxr9rLZIZ?= X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 0da3af99-c323-42d5-0832-08dd760dbcf8 X-MS-Exchange-CrossTenant-AuthSource: PAXPR04MB9642.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Apr 2025 19:52:33.4607 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: v/kYlHgUn37NfHzz8yWaww88PoOvzMxELgOCoSF1Y+iZV9siMn1mt0C9iKiKw4jPYJaVXxnZ8usQMyp/fvZXaA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PR3PR04MB7452 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250407_125236_267052_5C25FF56 X-CRM114-Status: GOOD ( 10.39 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Add msi-map for pci-ep device. Signed-off-by: Frank Li --- change from v14 to v16 - none change from v13 to v14 - new patch --- arch/arm64/boot/dts/freescale/imx95.dtsi | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm64/boot/dts/freescale/imx95.dtsi b/arch/arm64/boot/dts/freescale/imx95.dtsi index 15ba83ce691f4..c3c76991f1c8e 100644 --- a/arch/arm64/boot/dts/freescale/imx95.dtsi +++ b/arch/arm64/boot/dts/freescale/imx95.dtsi @@ -1768,6 +1768,7 @@ pcie1_ep: pcie-ep@4c380000 { assigned-clock-rates = <3600000000>, <100000000>, <10000000>; assigned-clock-parents = <0>, <0>, <&scmi_clk IMX95_CLK_SYSPLL1_PFD1_DIV2>; + msi-map = <0x0 &its 0x98 0x1>; power-domains = <&scmi_devpd IMX95_PD_HSIO_TOP>; status = "disabled"; };