From patchwork Tue Apr 8 02:57:17 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Ming Qian(OSS)" X-Patchwork-Id: 14042099 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 38183C36010 for ; Tue, 8 Apr 2025 03:02:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:MIME-Version:Content-Type: Content-Transfer-Encoding:References:In-Reply-To:Message-ID:Date:Subject:Cc: To:From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=qyzSGzcIB9WApT7pOJjc5JCv3c99WWflyCpN5HHaISg=; b=GG9RHRqEkhmPxwiCXvfaavnJqy rFjQe/jkElAq5UWw2tBjRLR4pDO3aJK4r8yieW61DyIbUE4sbxBa4CvPXDxGAy/TXsGWj6LJ/1dDF pC/2tAVVllqbrSTJfKRNnCjQChxOrTZ2nxRdzlFYaOx0tsX1UZ+6TRZDzDmCuciMSAfFh4//OR4wj Ep2Lk6i43rDFAz+BHKgeQShFgaftuyNBsGWdnbPW7Z3w3VWDRhVKhclHW5QFUMumXN6ExlYWuz1sz agLVQkCS0h7tvjTuRqJfW/HPVtmVdLdeP0jvJ7kLm7v/1yGhvDas4Zr5MKZU0hGcAoDghr/J0jHIq 26jUV+LA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.1 #2 (Red Hat Linux)) id 1u1zDk-00000002ZqG-3KxE; Tue, 08 Apr 2025 03:01:52 +0000 Received: from mail-westeuropeazlp170100001.outbound.protection.outlook.com ([2a01:111:f403:c201::1] helo=AM0PR83CU005.outbound.protection.outlook.com) by bombadil.infradead.org with esmtps (Exim 4.98.1 #2 (Red Hat Linux)) id 1u1zAJ-00000002Z3M-1Plc for linux-arm-kernel@lists.infradead.org; Tue, 08 Apr 2025 02:58:20 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=VjVA+FXOH/SUXA8l7m7Ywb+ZXSe9SYLrTMNGHDOoQWzIkNMcOhaV7qY8j19bdge8OQGk9qZmifkHICUDA2g31p2quY3d1E0nJY6BeokHdwdMO0z01ArTJIZpyI6gyenbFKuXEwXIPjU+RWOSRNaJqC8fSsdAVSk1v36aWgew23EGwCP+T13Y75CX965U4QdmtGC61BIq5EFUERsKszxcq/KBDp41vkyygYQAKaGvF/jcVM/s6PCh4cRYwjzB7T/FyAR+djXCyAb/m5NVuBX8N5FayDpYMdcadxwbI5jpq+rWYxwPF5kwwyOaDRsZCPQbuY4i9RrEdyhXOZ7UlZDQQw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=qyzSGzcIB9WApT7pOJjc5JCv3c99WWflyCpN5HHaISg=; b=HhCSLl/AqK2gIxXJvcHXSpcrL2I+CHoWgLyCY5IJyGRQ/bXzpIl1bHQOd1qXFczGiLOoVecYTLHQQnFmkWLObhYa8TzhsFLkJOZHkhfpyKVQAjiyTyc4xdrNOCTBdwbDFHhjsyt4moXcZAa+aQ260mAKGK2adImYrFVMRQSMtUMPkRFCC90B7FOqGuA5uVTlR4REvDfDMSs1Bp+2gNwxY+XZCXCi2XH9t78wx+jFL+7Fy9V3yonYrUibqblGXmfSQssmHKMgMjn3lxSaLZ8R+R6en6FlMDO8TIbUVKQiKjl6oh7Fcl+kZOYO3H9EkYHosp0A0YeLS3R8wCuYoODSaQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oss.nxp.com; dmarc=pass action=none header.from=oss.nxp.com; dkim=pass header.d=oss.nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=NXP1.onmicrosoft.com; s=selector1-NXP1-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=qyzSGzcIB9WApT7pOJjc5JCv3c99WWflyCpN5HHaISg=; b=Y9P8BoW8v3PRiuQLHp9eHNXoCI2jS5ErA1wuDb/8aDObrbXEsnDLUB+b5hw9OzZ+JTQ7YArGZtRiA9QNxAKIBucnDiZuof0KVXF5wKwr2dAtW5wFMIRlVTMBdOwwKFgF8GqGlUH6MpEdUPh3+4YOeFGpxp13CyXi+U8ln1H/rJVTSz3SlKWZrlDCw6r+iljPDiEjA+qn+o90aqQXdXEeMgA8yQXBjwMub2xur+h7ZQ5wwEHxn1s8Pr5NC3udh2P6luxn5OFvuk4qM0MtGDa1CGNiE0jChPws3YAZks2rtsMcD59AjRkvnGbvVFBDgeF6Rn3MKc6amK7fUutIs9rUqg== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=oss.nxp.com; Received: from PAXPR04MB8254.eurprd04.prod.outlook.com (2603:10a6:102:1cd::24) by VI1PR04MB6944.eurprd04.prod.outlook.com (2603:10a6:803:133::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8606.34; Tue, 8 Apr 2025 02:58:16 +0000 Received: from PAXPR04MB8254.eurprd04.prod.outlook.com ([fe80::2755:55ac:5d6f:4f87]) by PAXPR04MB8254.eurprd04.prod.outlook.com ([fe80::2755:55ac:5d6f:4f87%4]) with mapi id 15.20.8606.033; Tue, 8 Apr 2025 02:58:16 +0000 From: ming.qian@oss.nxp.com To: mchehab@kernel.org, hverkuil-cisco@xs4all.nl, mirela.rabulea@oss.nxp.com Cc: shawnguo@kernel.org, s.hauer@pengutronix.de, kernel@pengutronix.de, festevam@gmail.com, xiahong.bao@nxp.com, eagle.zhou@nxp.com, linux-imx@nxp.com, imx@lists.linux.dev, linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: [PATCH v3 1/4] media: imx-jpeg: Move mxc_jpeg_free_slot_data() ahead Date: Tue, 8 Apr 2025 10:57:17 +0800 Message-ID: <20250408025725.1244-2-ming.qian@oss.nxp.com> X-Mailer: git-send-email 2.48.1.windows.1 In-Reply-To: <20250408025725.1244-1-ming.qian@oss.nxp.com> References: <20250408025725.1244-1-ming.qian@oss.nxp.com> X-ClientProxiedBy: SI2P153CA0019.APCP153.PROD.OUTLOOK.COM (2603:1096:4:190::10) To PAXPR04MB8254.eurprd04.prod.outlook.com (2603:10a6:102:1cd::24) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PAXPR04MB8254:EE_|VI1PR04MB6944:EE_ X-MS-Office365-Filtering-Correlation-Id: adaac867-bc4b-4cbd-2ed1-08dd764935c0 X-MS-Exchange-SharedMailbox-RoutingAgent-Processed: True X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|366016|1800799024|52116014|7416014|376014|38350700014; X-Microsoft-Antispam-Message-Info: xA2RTt6rBeJaDv1yq9+b6vMkKiLuZK5gcU00grg9yzi1aigyWW0MMUZhchtgz3CIf69QLdE3gqVoI6kQWuJBMCaFx1mQdZ0vKiTarAD6cE9TJmCiBinkF3k+fX5rO7M+TGHreupPy46bQAvUbJJSIiUZ2a6dUozme5uO7u+cqrfkRfA+taq6qajNmvOUDW1PGKMPBqc+Zq2RXvm1EEJcl93Qewsapf1QunseDYVMWv/dvimwT4HQx8NFpr05uk6RKdAPPNeQOJbXEl6id7JJYI6zjoaDtTPJARl5fQIvQmRCRvW9OvqYhHM02Xz5uvkMgEqeC6lQ+MHAgjLhkAknVERbz3wUPn8qMKlni69VGjNUXw3qstnIlfZFL6wqzhAOr/E6WzvVRlJfn6JIfV04g9F3N72z8lrvR+xZZsPpSzkCutYe2lLAiXWeJSq8ac8mCSFwl8HcAzk2nv3DA/p9+ha+zbODT1ZVMjOH4+h/oDDJnr/6qCDvDGDfbbMxToBeQ74EX1cwFnsCtxYrlvidSr7+BAHmuPfC88f6e+zCzYurnfPP/djUXem7h4ENUU4/jbpweoRLpzH8l69GVBjmtvLTC87ts2OA0QDu1WX19DK5zfPfxOW8uCMBSe68U2rVIIXFHKT3ZPAWt1Je6YuElcsxPjNZbOy7l7k9HPeainYY807mT5OGoqeEg7gEYPiQgratQ67Wtrj8KDV4NuYjAYZBisdre0MgFFuZsS+CGExkhSMNy2BpysYrrIbFu5ItVhh0nHRLD1f0CEuiTOSEk/wgdKcmGkAy9AJ++7WboenbfFRkGIBqb0QFOpEGGn546lrMCLuqqCMmPGMrd70J8oUcE+Wmp3rWtRPqDHfYc0RxvuCsPmjZRbRdwEEN1ecf/TxNCC7z76ejVF9aB18aI4Qsb+uyZqTBuQTnmEQwVjIA9zsihdE1smjS7QADRG/7t3Zq+jrOlZshW41ps2rubbv82c8rKJuPuUDfVjcrOsIk512ZEz7aikw80aP5sM9aqErECCPijY1hi5v9Fl3nixMKECy7CoCi1KnRm4B8uo7AbB9dW1qT6D41N6HBumXgHc5qSNTSo1RCUKS0ReVl6GoMXISH95qyueIYUwj+CC1BC87Y0My30CvMNysT7DeR3dD9X8cUlXLp1qI69lnibVlqzUK0yN5bUXIxs0bUrKNoRGTiAfTs1Tvoc9HNL0ToxRIu9JnP2K2cyZhb/s/KX/Y07MHoZcfJCi+rY3uQfMJw24VdTahhLvdw8VrAggoL7QlK4382+7qLQK9O7BARNiFqCS3e/GXAQSIQ25ZJQ7h1JtUc7cc4AJzEcEv19x9c78B31ZDoP6HnCBnkNV/4AEfJOJHbkNeSC2vcOaKAaDU0aqS7ikSYqjooKl68pgVrYhHUOmMQay6hA6P20KATM4urGLng7bRxb7/zat8tjVJ5PD5IPMWk6ZiKpWWZKZhp X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PAXPR04MB8254.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(366016)(1800799024)(52116014)(7416014)(376014)(38350700014);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: qLRQkzC3RmpNswPqMNPqOaVNchujehfhsyEwh0yqI/AsopJE9l0c4gP++msDqPjSKUrsrDwTba38mE7cDSAkxRhPU/6Rj6wTDjxIs7SnE0HLhn2XyLpNOBAO8m4OlO+oZG1JodieqCMum3jJ4mAHWMrpog3UDubQhLHSfljMV7iO3U1JQNzWrqAbdiVzHv/YzgH+smjsWcqbAgRufJZKLfQb0cuc7hN9yZummfo5H9qnfyV1DSYn11tNedzK/j3rxl82PBki9F6txmss1nrbTpquMZESsiS5Kum2Nx+L9DmVpNQvfPbpXaGLg1O3hV0Ni5s4ObecMVrb2AbiXFTb7BtwwsYGfXZFifmc0EaVAMk7wtnFzJOBWh1X+HsQ5M5GD/rXREy0VhBWVxDzCoir4GU7bMjUeaqcBWilraI4dtQTVrQZwWtROW7xvVl8E8xGeKRWIvmd2yM0OvAdQ9oGEkgEXPWD/FLZzBY1bEcGvGTm3jDMKNxYZ4gMi4UmqrwWgcUvORxAV3DhGK7iXvrvOziqob5gswfc3PNu8d86AOQQa+YY/QSX937VT1rnn5Gzg7L+b7pacPkMbvb24JVvkHkM2ESuDpsewkgFX2ZtFuKsuds15e0Cw7r+FSQmWqbUz7SvZ43M03T7WtZO/bfurPVA9RmYFYGZ7utMegP5UwngyJ9sywlumkCEuUn6Q8XqMMjjoO6UpVYO6VY+3JBD/l4uwC+Ws7U1BnhdzWTVl6Db+x0kRLMf2f/pjVoadzfVLeDUo4nV01V0DLoH67NYGRfp9a5LbIw/U0pBHQU6wbWwEFfP37gKahmbE0iHB88jmQjUBQq2v9e7+578JljCDYlh9XVX0JytA26UYlMVIlBBbuYzjAwPt/8bYZe2guUaR5h4izy7WN4tDVWnnX6OSqT3QdyZi1Mx5zbtov7nV2psuIPvGtOC7tKeODRCJ+FHhvW5ZExpiCQY2yZ6lQIf0CMauIYeLzTGAScPXTj7UYJbSRvnuA6KcsHc3/6eY9hrGFdRpQcEJ76qiGaADixQI1V2hyzMGFxNGuGg3GYj7xtS2OsXPy7AW88wKMplAfwNj3YgwMtbIG52lLpfvSvWa3/cpRgTn+5Y1SEEngSN5UZED606L8CHK8/RhkrLNS1ZgEzRbg8Z0jSMPLrNFrSBCVv0AjE62ubhai+UDyzni45HyiYMFVhBce7aIymByTssxwIQuSrWD+azRs2Y1EkenowqcFwAFKWILtVjI287wTr3W7kghEQ2j5/X+HsR00j9mbPNkmn8B1hWFr6fy9P0cWLeREiL/tucadhy7/lc1qdqdhlOHhxq3kh1T5fOAcXh8o8WgmhOos5DlGgWbKheiXG+qeu94QfGff3aPGLOk/YGTVST3gMiRn+ONXAmfHrf+MQPECam6k4PPKdcwid8dwVIg/umWEfFPfkN0KMUwnT5+jF6Nj13w2LNagyZi6XjGkaA1/6KsviDZJ+CFGigUYpNuXkfxv8dB6aU1u0zIhw5Lh2/E+9kjt3TTSEjEWICDi+Oqh72g6IvSmztXZLfk0Ly9wIYyLgHl6TTIGF5J1ZiVGv9DOvtHss7+BWxGef5 X-OriginatorOrg: oss.nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: adaac867-bc4b-4cbd-2ed1-08dd764935c0 X-MS-Exchange-CrossTenant-AuthSource: PAXPR04MB8254.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Apr 2025 02:58:16.7657 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: ULL38n2msliCXX1zCZT6E6TajsGtN8EwnE/sbsqSxhsb9lXGnDIWb/b6QTABouaXwZBGTBbgtD24cCJMR/Ea1A== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB6944 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250407_195819_376471_3E458582 X-CRM114-Status: GOOD ( 11.32 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org From: Ming Qian Move function mxc_jpeg_free_slot_data() ahead of mxc_jpeg_alloc_slot_data(). Then when allocation fails, can call it to clean up erros accordingly. Signed-off-by: Ming Qian Reviewed-by: Nicolas Dufresne --- v3 - Split the moving of code into a separate patch .../media/platform/nxp/imx-jpeg/mxc-jpeg.c | 46 +++++++++++-------- 1 file changed, 26 insertions(+), 20 deletions(-) diff --git a/drivers/media/platform/nxp/imx-jpeg/mxc-jpeg.c b/drivers/media/platform/nxp/imx-jpeg/mxc-jpeg.c index 0e6ee997284b..b2f7e9ad1885 100644 --- a/drivers/media/platform/nxp/imx-jpeg/mxc-jpeg.c +++ b/drivers/media/platform/nxp/imx-jpeg/mxc-jpeg.c @@ -752,6 +752,32 @@ static int mxc_get_free_slot(struct mxc_jpeg_slot_data *slot_data) return -1; } +static void mxc_jpeg_free_slot_data(struct mxc_jpeg_dev *jpeg) +{ + /* free descriptor for decoding/encoding phase */ + dma_free_coherent(jpeg->dev, sizeof(struct mxc_jpeg_desc), + jpeg->slot_data.desc, + jpeg->slot_data.desc_handle); + jpeg->slot_data.desc = NULL; + jpeg->slot_data.desc_handle = 0; + + /* free descriptor for encoder configuration phase / decoder DHT */ + dma_free_coherent(jpeg->dev, sizeof(struct mxc_jpeg_desc), + jpeg->slot_data.cfg_desc, + jpeg->slot_data.cfg_desc_handle); + jpeg->slot_data.cfg_desc_handle = 0; + jpeg->slot_data.cfg_desc = NULL; + + /* free configuration stream */ + dma_free_coherent(jpeg->dev, MXC_JPEG_MAX_CFG_STREAM, + jpeg->slot_data.cfg_stream_vaddr, + jpeg->slot_data.cfg_stream_handle); + jpeg->slot_data.cfg_stream_vaddr = NULL; + jpeg->slot_data.cfg_stream_handle = 0; + + jpeg->slot_data.used = false; +} + static bool mxc_jpeg_alloc_slot_data(struct mxc_jpeg_dev *jpeg) { struct mxc_jpeg_desc *desc; @@ -798,26 +824,6 @@ static bool mxc_jpeg_alloc_slot_data(struct mxc_jpeg_dev *jpeg) return false; } -static void mxc_jpeg_free_slot_data(struct mxc_jpeg_dev *jpeg) -{ - /* free descriptor for decoding/encoding phase */ - dma_free_coherent(jpeg->dev, sizeof(struct mxc_jpeg_desc), - jpeg->slot_data.desc, - jpeg->slot_data.desc_handle); - - /* free descriptor for encoder configuration phase / decoder DHT */ - dma_free_coherent(jpeg->dev, sizeof(struct mxc_jpeg_desc), - jpeg->slot_data.cfg_desc, - jpeg->slot_data.cfg_desc_handle); - - /* free configuration stream */ - dma_free_coherent(jpeg->dev, MXC_JPEG_MAX_CFG_STREAM, - jpeg->slot_data.cfg_stream_vaddr, - jpeg->slot_data.cfg_stream_handle); - - jpeg->slot_data.used = false; -} - static void mxc_jpeg_check_and_set_last_buffer(struct mxc_jpeg_ctx *ctx, struct vb2_v4l2_buffer *src_buf, struct vb2_v4l2_buffer *dst_buf) From patchwork Tue Apr 8 02:57:18 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Ming Qian(OSS)" X-Patchwork-Id: 14042100 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 071D1C36010 for ; Tue, 8 Apr 2025 03:03:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:MIME-Version:Content-Type: Content-Transfer-Encoding:References:In-Reply-To:Message-ID:Date:Subject:Cc: To:From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=m1Ac+L/I0BFd1HFvzVe1qKU/ZoRPc7kB+7Wuw9Q2kJY=; b=Oe6bbjVt1135tIGGt3AG/vx2/H ZivcsQM06OSHYGp0qn2YtxofK0cCGmC2k7SWncsO4y8GEakKXQgNz71VF2KaitJX9M6aG/oeaOibv IN30ZrmB0/dH2fpWIw8RmXe9Beu//4CAKHz5iaCHZ7JmFotBsg2twem4kiEvVIR26xGmEcZj4sdXe IyaAV43YfTRD+yb8oZx18qM3DGPQvjOFv9Z7HVSWr4ELCnvOq2UFOb1SATUYeXqkqfgfD6SSsnvX2 D2UB9HXoVsYg0cY0CzISlO4pixHF015n/sfQey/+uFxbgOd77n46x7v/2YIiM2+DFW5XD7cr60Eko M4Uifbuw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.1 #2 (Red Hat Linux)) id 1u1zFT-00000002aDV-23cS; Tue, 08 Apr 2025 03:03:39 +0000 Received: from mail-westeuropeazlp170110003.outbound.protection.outlook.com ([2a01:111:f403:c201::3] helo=AS8PR04CU009.outbound.protection.outlook.com) by bombadil.infradead.org with esmtps (Exim 4.98.1 #2 (Red Hat Linux)) id 1u1zAR-00000002Z56-3Gqd for linux-arm-kernel@lists.infradead.org; Tue, 08 Apr 2025 02:58:28 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=AISxqdZiBIOpVSKk1865AEhRw6KDQ7T2XkX9x0TVAiGOurf3uRPyT2hG9I+I8GHQS7noMZdId3MSjA8XHED3TAhvfDo1h2DIyMsEsOEv5m3HqiLKcjSPxMRvuc/zsmOoklllFjRfv1Hhl29PUPaYYBWlFVEO13PgTPpd9ONmXC+nsXG7GbYfL3EPnE1V/I8mw7c9INfprFetgSkKByeajqMfVRwLk8b7yqMukddTsk3fDrh+Lu5hDw/i+rW9I2DEXkliICZ3k0nPNAxMbn88E4qEkj7/CZ+b8/vwxeObX7acTd4LSIADwe9pb/uJuQvlj0zxyQCBGpiFXqIn8NBdmw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=m1Ac+L/I0BFd1HFvzVe1qKU/ZoRPc7kB+7Wuw9Q2kJY=; b=hgJVlIFUWKXKoRRvg/F3xehT6qpSzXOUJsNPEcdA5IwUZwuC6H7JmcbtSdkL54qGLPgugdnB1E3UL5QymjDuIrFHu8Dp4oZcMNHgHKnUEZTK2C01ine0unKVmv+IbTRuz7F+MORnOWisJXLvX89BNbNJOwA09V1d3PZDjISwNgBLyUNCtSBYFI7jYDZk3hMxef+QYPp7nbsafRLafq77s89i44KW3HHro8ZNFSHNJIKB9v+ywDQLobMmeW9A2X0SXTEBZemg27TQHcI3iR5HCC1ZaAzXontM1pYTVwzegU7bIawXp1EljsJcwdd+HQlqBJVfRuyraPYX0ul0/EfJzA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oss.nxp.com; dmarc=pass action=none header.from=oss.nxp.com; dkim=pass header.d=oss.nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=NXP1.onmicrosoft.com; s=selector1-NXP1-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=m1Ac+L/I0BFd1HFvzVe1qKU/ZoRPc7kB+7Wuw9Q2kJY=; b=tMM+bzTDOngGm1pfE6ral+Dt4nJLtl1gxs1EcTd4+rNZ0wy1hv2Ra93U2VuO0WWp6pInm/cBcTHsrRJ1JYT/RpSAgzKy7ExQJdbblIX1W5n1UfhcKLjhbBpqlsBRgxaevcldqQ7d7fP3VFKwpo0g4jRQJtAQEgMPRsz0M+EgObu+/8AdM9icBXZrZkaEscCwGfEhhcDyTNvrW0fgM/Pm6XLP23g9NEzJhClDO7UCouxVWM8lyL+dB+PNrUGAVDq2HQOaEP5SBnflIlvAFm9OIa59tWMeFzXKY0MJLcZD5g4rO5mUpFDFdNr/gG+RVRbQ587p6MWz7wJtIwuikntDHg== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=oss.nxp.com; Received: from PAXPR04MB8254.eurprd04.prod.outlook.com (2603:10a6:102:1cd::24) by VI1PR04MB6944.eurprd04.prod.outlook.com (2603:10a6:803:133::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8606.34; Tue, 8 Apr 2025 02:58:22 +0000 Received: from PAXPR04MB8254.eurprd04.prod.outlook.com ([fe80::2755:55ac:5d6f:4f87]) by PAXPR04MB8254.eurprd04.prod.outlook.com ([fe80::2755:55ac:5d6f:4f87%4]) with mapi id 15.20.8606.033; Tue, 8 Apr 2025 02:58:22 +0000 From: ming.qian@oss.nxp.com To: mchehab@kernel.org, hverkuil-cisco@xs4all.nl, mirela.rabulea@oss.nxp.com Cc: shawnguo@kernel.org, s.hauer@pengutronix.de, kernel@pengutronix.de, festevam@gmail.com, xiahong.bao@nxp.com, eagle.zhou@nxp.com, linux-imx@nxp.com, imx@lists.linux.dev, linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: [PATCH v3 2/4] media: imx-jpeg: Cleanup after an allocation error Date: Tue, 8 Apr 2025 10:57:18 +0800 Message-ID: <20250408025725.1244-3-ming.qian@oss.nxp.com> X-Mailer: git-send-email 2.48.1.windows.1 In-Reply-To: <20250408025725.1244-1-ming.qian@oss.nxp.com> References: <20250408025725.1244-1-ming.qian@oss.nxp.com> X-ClientProxiedBy: SI2P153CA0019.APCP153.PROD.OUTLOOK.COM (2603:1096:4:190::10) To PAXPR04MB8254.eurprd04.prod.outlook.com (2603:10a6:102:1cd::24) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PAXPR04MB8254:EE_|VI1PR04MB6944:EE_ X-MS-Office365-Filtering-Correlation-Id: fa06cef8-1310-494d-8c8b-08dd764938cc X-MS-Exchange-SharedMailbox-RoutingAgent-Processed: True X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|366016|1800799024|52116014|7416014|376014|38350700014; X-Microsoft-Antispam-Message-Info: uid4VD0cLHtrMLtqrLqZBgpjYPddeievDUfZ/90PiQnnYD/z/D3TqvWf3UIzSyihCXDqgSb9agXNpC+/jZkka94TaEQA89/ExtR/2kWPWp8btyZoD2/0NGWJIEjgRQpA7xUvy97MaYOFgbSFmC+KFmUYfhdesi1fHDsjAsRYS7dE/xD8P/hLRw056V/Py1inp8e6Zq1mGiWB0kMv1vrt72GkMTkETi7oqK3P8hfsL9BHiqfzvMD58DRDAKmqpYXXxEI7hj9UgvkvXk/8Jop0MP6lUxZ5rGWetIcHu2vUSR2U2p6GlYY2noHaH/I/txqUyOS17wSTDf5T2iS/HEC4bjI+CJzfcfrLzzaxG80XjnxUuLiwWy/3uQ2IkDxiyD2aWi9LJvar4lmkFmNTJNw993D8RY+NFLPsrKWi4bztrVm7Mkh1fa6NSHFZCJhrrCW56SpRCjyEBzvmhEbEgI8KX96bmO89yoBqJCOMnDZ1IaI4yUef8L8U9PQNSugTPSDkxan+cAY01ayBH98jE1SWTTLn8bAU+govzrPRocYJGvimmdbKBR1NuYsFsL9SA65ieC8YQrAMAbWbTB49RZ3gQbtY9VsiKUMp78OMx8hhLJ+N+VEDMhsEmCDUmuh/J3c3DWgSku0FJwf72nuPIx0/y9Onxly1GCRJOX9sX2uDBiI/x7/rVl4RtHA/M/bS62vxzi4QXzZRut+J2IgVhPN0CBIHzBjwI4uq9u/jh6L8HvnYFGusSU8hFUuplvfGRO76WoNdpqrcz6vniu8wcmn9puT4vn8ON5IJSi+fvg+e16V5woXKDzRwQxTYq5lWFUKTm10Tyhn+E1+Axs9U/kcskGa08/egOXX9pVYOuWplrJiZzY9cWaXrWTXhIi3Oxd0WmZmU5mKZh39ickXy3lzJWTQh5+hrZAWsR/IznstyYUsYJ/OYhs8P21rAMi+WN5UfA6Fwa47MPxjI/thNvKaE6fyUeTu4yx8yhkr2Cf2cSZrlYXdR1g66sZBVwAQ71eJhkAhxtKkUIRY7zMopuDEHpHwg899CNtGOP45ptOVeAGmISY9hG6TdgMwWLuzv6bFOFJuLbSzEV4PZrRt4l1IVc4e5YTiRFlNGUjWKh/Q1J7ZuJTJUl6HW7/lZh+qIIqI7DJsO7z1SyzlE4NzvjCX506gyO+A7mPrKAAeuM3oQEsHua281jJ8sV1A0s34+PAf1AA3624BUp3F34dipshig8EiJLHG1i5L0x6KJPUKaaY/OtNxzCT3B/cLUm5BiNO7zxVbVo7N0zMqUxGe9+QflZ5rXUtkSUKTkEMdhBTDQm8MsNMC1dPf9P7IBW9Bj8NdSyvsPcNsR65FMQ12N0kztSyTjqI7whLn62OSTHqgVYljahLLkHcCYKe2WLHIeo58kpYjpeQ5j0Y/AvJ6JkK7USRRc6+bQhlqCp5dAAShGNSua87RyXWzOABgu7dFdboV/ X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PAXPR04MB8254.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(366016)(1800799024)(52116014)(7416014)(376014)(38350700014);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: DtqVAl0jG+mwBgqrhPnRFQAwY3KIdDVG7w7+rnezW3pe0PsKhlWMHtuzSeylqmuy4DnxtHC+9vbQR5V/v470FD2OMaFbamsDcVrGNDOYDVOT2nw9e4QxleS5b4Rz6pHiXpGYOsOO3DNe2B+d1wc6uZJmWhl0sDV8sXsnK7lnNy/7ynNVVq8D5iuYHdS2ppAwMFDI+GCAkmQutBsiZMB02bC+6y9xh5I3/nWpRQi36aFGQYCoTQDX7VgJZnOX6y8aYOvB/uocp2HRS5sYiAOUk1idJbgf+GHt/hvoDkn10x+zk45Bmn8euAneV7KHgUdB7bZo9kAeo71/NlMttL331LChahs7i5bYhhZIM0673CRMIY5Jt2O/pHzZYFBTycrp0s3bDxyxLEHZmse/WWhvZpaIF9XREZke2WG+eyDk7P4jXOf8mDggcz8YIFUP456Qv8eI5RDGsvsyeREbMpVvuri1hsjGMk1zLndlWAHQwNbPUl6JpqQM2pkkkaDUIp3bh5FajipiscpF7jE8UICAHeeXAPdUHePSsJpHdNzrs6W31VSuNX+aq8ZKKFU7O3uco9MlqFvAdpiROTawunHlzebuCVfTuPUKDltrxMxt8OCeGaBMvXR5glb7LjeSbhHGXaRCF2WBe1IfUaPnVqdBUBHUtDuLy1kzDtMQ12bUEAF9Mnki2wYkERvhPmpUqgeCyPa5k34Yr7xqF4Zra/h4eqrnps1EnQRfwz6CfbdkfbyZ+P0zQ06cseC9H7ii1GyqeSHJV/GBbo+gb0y4cESfwA3Olql0peE0GTOOKiDy5SoUSxxlJIiB+g7FZ3GFc0Tql1llTwzTNtQsam7KtGmCr5YxyUD8ETt4UefLzXrhdw8yeHVLkbdqfGHax3V5sdMfSkUte40gvBrUo6/AkDm+EpI3HiENwhgJvLQmOrfJJx9XRg6//vap2tlUXappXL4sQPQiF9zSR1bYeLV+e9Zoqy/2buNxybgD3GTkbnbG9txmop1re5TonYJLbu/cJS1BFYd3NTctGbPotC4lmYmtyhUYQOjGBeScC53ATTyMoxSTIOhRvY3Ke/MPM1g3LMK1U3BFTJ1WwCGVrcfnSre9iJslNZG+cofnn/pNSmPwAREr7hwOe9QYdBIwTr9+DnFpSUJycgdTr5xj7l8RqaEce5ASp7/5dYnGVx6/Gd2J/SRFDf1bDzJUQF0g9UGLV9HREKUtONTve7rX4JulnoCuUfUF/ncVN8tpKuorAT8+Qd2UNnSmg5447tZ7E2773yB0jVyvM7KN+DvanHpnHvMPULeCfQMoD0fZRgE3njjnNZQMJArcm/6whobZS0GrVOy9RHBRhsGkWwPc6R1R2PzxJQ7D2M0mp0Gac9E+vv4MkHXJhlESVPrib7BEak42pOfuyJvQXQ0cmurFHpuKYYWa/oi+XK9JfFK7Ii0e918owHvgMbdVIFDLGFyP6koOyjTvaCK6eA7UZSIR0G8RX+CdwoPwuSb6g1ybajw/Y/ef20IR61IvmGMU3LqykieAAtIbw3Uxpzcq/vKEm2Mp8WWPw+nj4mD0XWHgHNUQZOIXNJZTUgH9nbhLww8mjRBY0kRI X-OriginatorOrg: oss.nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: fa06cef8-1310-494d-8c8b-08dd764938cc X-MS-Exchange-CrossTenant-AuthSource: PAXPR04MB8254.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Apr 2025 02:58:22.1758 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: iCbY0C0e7GEUuxRLQdV+AVE3vI1SZRGTgmJhTajUa21v5Z+owuubS/plljAw9kvWT2KEsyInFRR9RN4v58/eBQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB6944 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250407_195827_818673_BFED7EAB X-CRM114-Status: UNSURE ( 8.98 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org From: Ming Qian When allocation failures are not cleaned up by the driver, further allocation errors will be false-positives, which will cause buffers to remain uninitialized and cause NULL pointer dereferences. Clean up the errors accordingly. Fixes: 2db16c6ed72c ("media: imx-jpeg: Add V4L2 driver for i.MX8 JPEG Encoder/Decoder") Signed-off-by: Ming Qian Reviewed-by: Frank Li --- v3 - Split the moving of code into a separate patch v2 - Add the Fixes tag drivers/media/platform/nxp/imx-jpeg/mxc-jpeg.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/media/platform/nxp/imx-jpeg/mxc-jpeg.c b/drivers/media/platform/nxp/imx-jpeg/mxc-jpeg.c index b2f7e9ad1885..12661c177f5a 100644 --- a/drivers/media/platform/nxp/imx-jpeg/mxc-jpeg.c +++ b/drivers/media/platform/nxp/imx-jpeg/mxc-jpeg.c @@ -820,6 +820,7 @@ static bool mxc_jpeg_alloc_slot_data(struct mxc_jpeg_dev *jpeg) return true; err: dev_err(jpeg->dev, "Could not allocate descriptors for slot %d", jpeg->slot_data.slot); + mxc_jpeg_free_slot_data(jpeg); return false; } From patchwork Tue Apr 8 02:57:19 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Ming Qian(OSS)" X-Patchwork-Id: 14042101 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B383BC36010 for ; Tue, 8 Apr 2025 03:05:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:MIME-Version:Content-Type: Content-Transfer-Encoding:References:In-Reply-To:Message-ID:Date:Subject:Cc: To:From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=nEwnsUOYFD8PB9vSTS06sKHvcoQ+lMaOkizrKjAAqko=; b=NVXeWFn5VOQ2An3Bnsw7/DIzEu 5HJt/i0Osc79HEgjJ2zSrwZ5r3C7FEilNPYE7C6nnz134XIu8nrK6QyCwzUYqm3KpOC4Y0+RfAKSk 7sGne43SqpskiJ7SKe9rTVuSGmwJp9XH3aUTq5be6Kbl5dtInFHT+oHtG57aNgQ7+4pJfmG+LhP0S N9tvV1JArQKtC2RnlLYlzOiyVM2oS5zb7sAqi7ubp5oNK2rgc4kHaNlO4ZCU0k0AGUgO3W+Xbj8SM /JZp/Ty30lTbT+8+SdkdHXokTfxRRBjuF7cJJA453j07PLqAzQ2n8q1JQyFARORM4tJC1kryLo4Yq vG/N5Jxg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.1 #2 (Red Hat Linux)) id 1u1zHD-00000002aOG-12ra; Tue, 08 Apr 2025 03:05:27 +0000 Received: from mail-westeuropeazlp170110003.outbound.protection.outlook.com ([2a01:111:f403:c201::3] helo=AS8PR04CU009.outbound.protection.outlook.com) by bombadil.infradead.org with esmtps (Exim 4.98.1 #2 (Red Hat Linux)) id 1u1zAT-00000002Z56-0lfp for linux-arm-kernel@lists.infradead.org; Tue, 08 Apr 2025 02:58:31 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=AvJagqf70MIXCUi15CDVruDzZs08+I3QvzG+jhDeYuv+BWTIZCEed5i1mLlKPeDau4/pt7KXQlQVpcTGC8iJi3HxfiiDRtJksSLKd0ZDhMpgWmYBHF9TsJ3JM1lDjODpkFQKoaFnJFH+pNTro5NYX6lWEzfxPQMKRKe143hUa20Nme/n1w7Cqq/FGhWUOj/eGKBj+eR6GNDGE9LlUaT/Z48nQ80ifNXnXg9JQ274CVtuKOcgUEQ/zU93BnyF1lWv6jQQdPfrEeanXRYH2j61qF9gIPuF73TcDepxgminFwXqQb0e2oEB/seQ37CdnMsOtpd7ylLpO1Zmn6ZWmV1Xzw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=nEwnsUOYFD8PB9vSTS06sKHvcoQ+lMaOkizrKjAAqko=; b=efmHdGaxNC+t2vLLtSxBnBdX45ZY/ofzvP/5eR1i/U533LtC9UmKvccVse0PhxVkQR88f4/6a6loGZTxwvDYPVClABJ0mF5U9V0RCQPRWmS2vHRDhR2PTtV46YUT7tfEkbjfVoqOYN7Uso7bDSYsufPLv7qpIUJtGt81Dhs97W7CUkCmPMhtF5pZGj8mxnlRe/LWqcneUxGfHIw6bInu/nDnHamfmEKcabuqQKjzt93ISedCN4hvbUCTnbQjbwTW6wTsDUiH3VE8zDNxlqHNvig6YQgaeVWzOWgDRirw3Sd5hYjzV7xwb8abxU2DU2T51+s3IZiUZCyRVjK1E5Jxng== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oss.nxp.com; dmarc=pass action=none header.from=oss.nxp.com; dkim=pass header.d=oss.nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=NXP1.onmicrosoft.com; s=selector1-NXP1-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=nEwnsUOYFD8PB9vSTS06sKHvcoQ+lMaOkizrKjAAqko=; b=a/KxxtfiUvMWBNMc02TcqZIXm+Y47C51OkH9rnuUeV7woAZE3eEIyHtM/n+cx+IPyU0wDNYEWshY2g4MEpZNYznUAPMENQiZYnuJIiKGSdj3TM6z25NI+mwy0jvrwyZ81rcd+SQL40a36cenqgOuInjmfNY+inf+rRhi2E/zrksuSaKso354YytI866UaN3pbVymiosQEJKa7y0nS7O1vxXoasvDj+2UC39cynxorlAoYwTR5X3k6naUgzv11l+OnoTIycyfB6ML3DdEb4wRTFwrEGyH2vF/+eCw8UYf4Zm44N1GcSg+76qwwhw6qfY134LlhwBcqI0wotV+lXJ6QQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=oss.nxp.com; Received: from PAXPR04MB8254.eurprd04.prod.outlook.com (2603:10a6:102:1cd::24) by VI1PR04MB6944.eurprd04.prod.outlook.com (2603:10a6:803:133::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8606.34; Tue, 8 Apr 2025 02:58:27 +0000 Received: from PAXPR04MB8254.eurprd04.prod.outlook.com ([fe80::2755:55ac:5d6f:4f87]) by PAXPR04MB8254.eurprd04.prod.outlook.com ([fe80::2755:55ac:5d6f:4f87%4]) with mapi id 15.20.8606.033; Tue, 8 Apr 2025 02:58:27 +0000 From: ming.qian@oss.nxp.com To: mchehab@kernel.org, hverkuil-cisco@xs4all.nl, mirela.rabulea@oss.nxp.com Cc: shawnguo@kernel.org, s.hauer@pengutronix.de, kernel@pengutronix.de, festevam@gmail.com, xiahong.bao@nxp.com, eagle.zhou@nxp.com, linux-imx@nxp.com, imx@lists.linux.dev, linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: [PATCH v3 3/4] media: imx-jpeg: Change the pattern size to 128x64 Date: Tue, 8 Apr 2025 10:57:19 +0800 Message-ID: <20250408025725.1244-4-ming.qian@oss.nxp.com> X-Mailer: git-send-email 2.48.1.windows.1 In-Reply-To: <20250408025725.1244-1-ming.qian@oss.nxp.com> References: <20250408025725.1244-1-ming.qian@oss.nxp.com> X-ClientProxiedBy: SI2P153CA0019.APCP153.PROD.OUTLOOK.COM (2603:1096:4:190::10) To PAXPR04MB8254.eurprd04.prod.outlook.com (2603:10a6:102:1cd::24) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PAXPR04MB8254:EE_|VI1PR04MB6944:EE_ X-MS-Office365-Filtering-Correlation-Id: 7ceb8768-9418-47b4-7a93-08dd76493c21 X-MS-Exchange-SharedMailbox-RoutingAgent-Processed: True X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|366016|1800799024|52116014|7416014|376014|38350700014; X-Microsoft-Antispam-Message-Info: 7xXkgeeOEF+PCSX2a120+Z+IRLVQfOUlslfjA4zUoh4viWQawwAiF4sW07pgFsBGmEfc5/y6VGx9iaSLYQ+xRYBqYl3BvFNAChcMUE40TxSZFnI2zUnKZ+9zjLo/BfJ+iy139MlqR4kRqwOTWldH93VKa0eDUsGq4qh8vmPI+kS+i79qg6T1MmZy+Xf391QVNx8BLQkSofzgGS8lxSzZ7pBhAuDRf9edn1xQ+h6T+Anx5b2qkfNpVcZ5Z7koBj3/Y8ETVDtA8ImC1HuzVgfgcrcNSUzIO5zTPW3fx/khuvzdMqlh6kJk0fHtb9I8qWn1oB/2qK8fIEv43T3TpJShJrUdydEJlSX8JYXy5KHNwfUWxWhNt2MqxorizqPPgLc91ATm60CQ43PpMDF+obsHds+UfR0V7rfjLbp7eaYvI7ZEEzKu3JVCjuOqyH0PYvOgGMiKcAIlbYi1+xN4DXbdQNjlHy4U7gNJFfSLn6yyFAW2f30VgZNN50HFWySguvXMOTOJy9wGrvQVWv46dH/4WxduAO6ZPp+HeulVrVxF2+idksgqs4YEI7YfgF9/nkYHQSREcRMC0BHqhTHBbBHyc09M+mJnsSyxYeU/KVzja/D1hq/LrcLbOGbQl35/w+cMWzEmgI/1WV5kIhNUipS+L2NF//FZE23IJr4PVQd18nL/SDO/XeUc1gtPbkNrg+MsPYAsXb6NjZ+25iIWAgNOxbnO42CzmAx+aw/Y6dd3l8bNp0ayHYpUWOE6ZIiPkkjuezITCH8XXkSXb85rO5dav9XlKFyNWGviBmRKaoypiP0uQdhD6r1POKq6Z0bhS759kewq6pR7wGu9gjnAGcfahNE+kiPhuIbt8Z1+8Va1q+4DYBz3aM06U8GMA5N5uchfrACtP9f6pEa74JjPbS3XBg+L002uUU8w4plLAw9W7zilxDDstsjk6yQqX1q9uOtP9Au0Uh2W9m/teOTf6vcbwtlvYPaXJDGOqUow9KpMa2IcCekl0TblPNdTyvvAz4w0+g1KLuqSLFNUnwgYDnjLx8/6y29QPTh/muMGbnacxdt9XxYHaZhBqT2B57qj8MVSTBIRQA4upZti7Z6Ij6rlhMOzoK0NgRrlL1ecuFa4C0PKzSnivs851DdQuoGUZ7BKCoiQyzinsfWhOAoFxzZ0DbrRfX/qSzpIHLY5kPGNs/0O3wwzlY47atkjnvfGOP1MKJjBdPnxGhOtbZAAdhBxT1Kpu4LvYXzVIfuhRPMB6KEU9GrlCr+JOULtZK3twN/I7SOu73YUHWh1bzD68/DxSpBAK6VZgwgDFnzBVE+YMFf6KulyihsaeyjKKkw2C0dgOgjV6KRHB75lTKKRMi6dTh9uvEHDrTuOXXUOBm8ZZlSx6O+gw1c9Q6oEm/q1EE36uV3eJTUOoA/ullsd2j2J8hqgV687n6mt+a/01Rd5xiADE/sFVdJR/OOI1Pqso2b3 X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PAXPR04MB8254.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(366016)(1800799024)(52116014)(7416014)(376014)(38350700014);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: PB8q4fXlxSHIhcxbP2/bXcUFeymrTYFYTILB2xl+8sVAZLw32X5Kbv6GEJjAalHz+SU7KRBh+tZ+QsBfN9iOC0zjA85gCWwzhAbM65N028u52zuxPT2LExgs2qMEIArUm98kVjRLPrO9OsKfrKgVvpphcvOZDuO5BAVToV2ExAuYmj9uB+xTsfBsRNsmRWj9EDBPOTgGgUXh+8OerR9EqhdJV3nFXK2r9WbuCcKo3VDTlyKnW57d+l8A4mUhM5MjBo1YcnbP+Pn8xYmaeMS7ESAytKhMRdrS1nYi6zErNqhVIJz181/QxxdRHX2sxYOSk4k3LxxE/nQw/PQUhRnPBstzMrwYKJ15LfzLE+jVxXqjB+KY+V5cKlu8dxx6f0Jy5uLuMoSGFNBVTCDqFYQG3+Vz8z4D3JBjwFkVs5ciQCs4s4Ms4s/6HOv2MubZtA5WyfN9jxk3XDo9ROjysoXqfxuJprN6DjppSxJCgObVDLvQmXTSsb2XaAz3B1XwNyLlWu1L58uMGege5Zvq9ck8vjJ3pC62oxh0q9H+efhWeg2kXIM8ZH+IIjJrp6ZLNg+KayZZx0/wK/DKGzMTm6jatg9qUpMrir96Fwqd5VNtSvxg1jm6zoGya7rm2r+VSNhnzTNKeFlj95wfw11u2jeOCS8LcQ/NtNdvjGnOStitvTXihM3Bmq1WvGBUtSI99xww0gbt9Jg4YQZCWR22B3qwisQKjs01/NIMYrXtNJtjFt6hRU/4fo6EtJ58ZTgvNIDEqxjdFRh9hqvtFUa7FY/sK1NZ+3zjifvO8pbpHUlytGU+lvCcW7lQaKmMtdkxxx283cjZkGh5rD5KeEtIMQC4BSd5lTVIw4X3++N8MtBrWYzBgyovkFRAKOp0eWRHdCGIyL1X/BU5rljnY84yvg5e8fRfSqXxsBPEJhh+BcEyUe+MSV0idpxLIEmPIPVat5vzYg4Tj4j5xDwdPdV+croNm4xa2LNO7Exiar9B5HqwnUFUkeIALGMwqK53C8J7p0lsJhxMIDaJjbSrWWtXlwjPpy+iIO82idEt0VBNvkOKjR12zoQgdtDUi/QHauPcQaEDHat5/Ok9Sx1fFHTwB4oL4QHXkt8y6i3ciVZMiRmPLD7FoP1PKCaQT13g7U6AkMAx4wW7I5QZDsZkrFjQlgRCJ1r92QufhY1FZpnaQX0DPcF/OjeX5WQFFoINGGLDY/TXeZdExsL6Rf4bAfKjsxJykFezmMW3FzTa/8Rlu/UH+nAKzKE3jsGpT7K57+cnMwjlKiWpYzdIXIo2t/J8p18tUKM3T9qWqBYvguY7IkD02vDrD2u8NuztVXKvPuLCyoc7CPQcc1YiLbMSC+1APfbCs/gwIo9ux5LhOep0mTvnZ+jThzNjrJO8ROOjSoNfdWVELGPQhzpaF2zzeY1pIWbMmzUHISS9fp6qlblZgpzYzChhUdhSTXNeSVSl76LpT/NPRvZsWocrLnpGjN7RM+IOHnxbenBw18VRufh24NvkESzdWnW3fGu4EWJuJsf97Ua7AaKNekiP8o9T/EWM+YdLkSoo8LnJA/WaLTTYtg9Btd6oSnCwozQxDQ4rdlo9vTcd X-OriginatorOrg: oss.nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 7ceb8768-9418-47b4-7a93-08dd76493c21 X-MS-Exchange-CrossTenant-AuthSource: PAXPR04MB8254.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Apr 2025 02:58:27.2847 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: EhG592xggi4/LTSNiycVLSBAAi2elirXdapK/bMEli/1jROgn3uyG4VHVjOpuWtcuUFjmz0YR0HTDE0F347EmQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB6944 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250407_195829_225919_D5684A3B X-CRM114-Status: GOOD ( 16.01 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org From: Ming Qian In order to decode a motion-jpeg bitstream, which doesn't provide a DHT, the driver will first decode a pattern jpeg and use the DHT found in the pattern to decode the first actual frame. This mode is called "repeat-mode" and it utilizes linked descriptors. The smallest supported resolution of 64x64 was used for that pattern to not cause unneeded performance delay. This choice, however, can cause a corrupted decoded picture of the first frame after the pattern, when the resolution of that frame is larger than the pattern and is not aligned to 64. By altering the pattern size to 128x64, this corruption can be avoided. That size has been confirmed to be safe by the hardware designers. Additionally, a DMA buffer needs to be allocated to store the decoded picture of the pattern image. Signed-off-by: Ming Qian Reviewed-by: Frank Li --- v3 - Improve commit message .../media/platform/nxp/imx-jpeg/mxc-jpeg.c | 42 +++++++++++++++---- .../media/platform/nxp/imx-jpeg/mxc-jpeg.h | 5 +++ 2 files changed, 39 insertions(+), 8 deletions(-) diff --git a/drivers/media/platform/nxp/imx-jpeg/mxc-jpeg.c b/drivers/media/platform/nxp/imx-jpeg/mxc-jpeg.c index 12661c177f5a..45705c606769 100644 --- a/drivers/media/platform/nxp/imx-jpeg/mxc-jpeg.c +++ b/drivers/media/platform/nxp/imx-jpeg/mxc-jpeg.c @@ -535,7 +535,18 @@ static const unsigned char jpeg_sos_maximal[] = { }; static const unsigned char jpeg_image_red[] = { - 0xFC, 0x5F, 0xA2, 0xBF, 0xCA, 0x73, 0xFE, 0xFE, + 0xF9, 0xFE, 0x8A, 0xFC, 0x34, 0xFD, 0xC4, 0x28, + 0xA0, 0x02, 0x8A, 0x00, 0x28, 0xA0, 0x02, 0x8A, + 0x00, 0x28, 0xA0, 0x02, 0x8A, 0x00, 0x28, 0xA0, + 0x02, 0x8A, 0x00, 0x28, 0xA0, 0x02, 0x8A, 0x00, + 0x28, 0xA0, 0x02, 0x8A, 0x00, 0x28, 0xA0, 0x02, + 0x8A, 0x00, 0x28, 0xA0, 0x02, 0x8A, 0x00, 0x28, + 0xA0, 0x02, 0x8A, 0x00, 0x28, 0xA0, 0x02, 0x8A, + 0x00, 0x28, 0xA0, 0x02, 0x8A, 0x00, 0x28, 0xA0, + 0x02, 0x8A, 0x00, 0x28, 0xA0, 0x02, 0x8A, 0x00, + 0x28, 0xA0, 0x02, 0x8A, 0x00, 0x28, 0xA0, 0x02, + 0x8A, 0x00, 0x28, 0xA0, 0x0F, 0xFF, 0xD0, 0xF9, + 0xFE, 0x8A, 0xFC, 0x34, 0xFD, 0xC4, 0x28, 0xA0, 0x02, 0x8A, 0x00, 0x28, 0xA0, 0x02, 0x8A, 0x00, 0x28, 0xA0, 0x02, 0x8A, 0x00, 0x28, 0xA0, 0x02, 0x8A, 0x00, 0x28, 0xA0, 0x02, 0x8A, 0x00, 0x28, @@ -545,7 +556,7 @@ static const unsigned char jpeg_image_red[] = { 0x28, 0xA0, 0x02, 0x8A, 0x00, 0x28, 0xA0, 0x02, 0x8A, 0x00, 0x28, 0xA0, 0x02, 0x8A, 0x00, 0x28, 0xA0, 0x02, 0x8A, 0x00, 0x28, 0xA0, 0x02, 0x8A, - 0x00, 0x28, 0xA0, 0x02, 0x8A, 0x00 + 0x00, 0x28, 0xA0, 0x0F }; static const unsigned char jpeg_eoi[] = { @@ -775,6 +786,13 @@ static void mxc_jpeg_free_slot_data(struct mxc_jpeg_dev *jpeg) jpeg->slot_data.cfg_stream_vaddr = NULL; jpeg->slot_data.cfg_stream_handle = 0; + dma_free_coherent(jpeg->dev, jpeg->slot_data.cfg_dec_size, + jpeg->slot_data.cfg_dec_vaddr, + jpeg->slot_data.cfg_dec_daddr); + jpeg->slot_data.cfg_dec_size = 0; + jpeg->slot_data.cfg_dec_vaddr = NULL; + jpeg->slot_data.cfg_dec_daddr = 0; + jpeg->slot_data.used = false; } @@ -814,6 +832,14 @@ static bool mxc_jpeg_alloc_slot_data(struct mxc_jpeg_dev *jpeg) goto err; jpeg->slot_data.cfg_stream_vaddr = cfg_stm; + jpeg->slot_data.cfg_dec_size = MXC_JPEG_PATTERN_WIDTH * MXC_JPEG_PATTERN_HEIGHT * 2; + jpeg->slot_data.cfg_dec_vaddr = dma_alloc_coherent(jpeg->dev, + jpeg->slot_data.cfg_dec_size, + &jpeg->slot_data.cfg_dec_daddr, + GFP_ATOMIC); + if (!jpeg->slot_data.cfg_dec_vaddr) + goto err; + skip_alloc: jpeg->slot_data.used = true; @@ -1216,14 +1242,14 @@ static void mxc_jpeg_config_dec_desc(struct vb2_buffer *out_buf, */ *cfg_size = mxc_jpeg_setup_cfg_stream(cfg_stream_vaddr, V4L2_PIX_FMT_YUYV, - MXC_JPEG_MIN_WIDTH, - MXC_JPEG_MIN_HEIGHT); + MXC_JPEG_PATTERN_WIDTH, + MXC_JPEG_PATTERN_HEIGHT); cfg_desc->next_descpt_ptr = desc_handle | MXC_NXT_DESCPT_EN; - cfg_desc->buf_base0 = vb2_dma_contig_plane_dma_addr(dst_buf, 0); + cfg_desc->buf_base0 = jpeg->slot_data.cfg_dec_daddr; cfg_desc->buf_base1 = 0; - cfg_desc->imgsize = MXC_JPEG_MIN_WIDTH << 16; - cfg_desc->imgsize |= MXC_JPEG_MIN_HEIGHT; - cfg_desc->line_pitch = MXC_JPEG_MIN_WIDTH * 2; + cfg_desc->imgsize = MXC_JPEG_PATTERN_WIDTH << 16; + cfg_desc->imgsize |= MXC_JPEG_PATTERN_HEIGHT; + cfg_desc->line_pitch = MXC_JPEG_PATTERN_WIDTH * 2; cfg_desc->stm_ctrl = STM_CTRL_IMAGE_FORMAT(MXC_JPEG_YUV422); cfg_desc->stm_ctrl |= STM_CTRL_BITBUF_PTR_CLR(1); cfg_desc->stm_bufbase = cfg_stream_handle; diff --git a/drivers/media/platform/nxp/imx-jpeg/mxc-jpeg.h b/drivers/media/platform/nxp/imx-jpeg/mxc-jpeg.h index 86e324b21aed..fdde45f7e163 100644 --- a/drivers/media/platform/nxp/imx-jpeg/mxc-jpeg.h +++ b/drivers/media/platform/nxp/imx-jpeg/mxc-jpeg.h @@ -28,6 +28,8 @@ #define MXC_JPEG_W_ALIGN 3 #define MXC_JPEG_MAX_SIZEIMAGE 0xFFFFFC00 #define MXC_JPEG_MAX_PLANES 2 +#define MXC_JPEG_PATTERN_WIDTH 128 +#define MXC_JPEG_PATTERN_HEIGHT 64 enum mxc_jpeg_enc_state { MXC_JPEG_ENCODING = 0, /* jpeg encode phase */ @@ -117,6 +119,9 @@ struct mxc_jpeg_slot_data { dma_addr_t desc_handle; dma_addr_t cfg_desc_handle; // configuration descriptor dma address dma_addr_t cfg_stream_handle; // configuration bitstream dma address + dma_addr_t cfg_dec_size; + void *cfg_dec_vaddr; + dma_addr_t cfg_dec_daddr; }; struct mxc_jpeg_dev { From patchwork Tue Apr 8 02:57:20 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Ming Qian(OSS)" X-Patchwork-Id: 14042102 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B741BC36010 for ; Tue, 8 Apr 2025 03:07:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:MIME-Version:Content-Type: Content-Transfer-Encoding:References:In-Reply-To:Message-ID:Date:Subject:Cc: To:From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=84aNYvgmNEoDC/iKgGv/7Y0P+wErvEPnSmSSfmVRKpk=; b=XwgWR0fbfxAHQn4paYzPdngr1U NZqa6eO64cquLd7MZFSBqt4qHXBtwwKf0nlmDimKPjXFT1mQENpk3LjxheTTMyO7D88MZmnVgzD7c TgE+nhEybFMk8uzcXpfsr/rhWdOAfGhHccvq6AHcMgtHXbUXHoP3wcUq74sGV8+lqUqYntqIG9HrB V/Hvy3uVJ3j3YoF7oEfVo8RuiY/Aq2wAAGwZzLgQ7KBOS4KV4mkg2IfKSuPXMiBAFGocW4kKte7Gu lBlobdMWzjbgH7QtHWzgvr0HL3QiEMVOtzV+aq7R8FflTt57JX5HyBZFDkYOUpPpK/vqeZNAFjy+W jw+iEENg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.1 #2 (Red Hat Linux)) id 1u1zIv-00000002acO-4Bjb; Tue, 08 Apr 2025 03:07:14 +0000 Received: from mail-norwayeastazlp170130007.outbound.protection.outlook.com ([2a01:111:f403:c20f::7] helo=OSPPR02CU001.outbound.protection.outlook.com) by bombadil.infradead.org with esmtps (Exim 4.98.1 #2 (Red Hat Linux)) id 1u1zAZ-00000002Z7Y-4459 for linux-arm-kernel@lists.infradead.org; Tue, 08 Apr 2025 02:58:37 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=SZv72Z3u4RBRJakKDDa4w1YmifO4OGPAWmiW9U3cPv68nyZTdH7/Iq6nliw01/J++veYLT6YdGoESHsWNU7wGCEgr5kuRz2bGhyIaHu8u+BaYM8wlHNudWD615ybpKI/y8QCp2OC+Ep5umI1cMrifJDHGoxS3qwrrfE8hdtgnF4aPauZJmohhGhRz1uVKwS0vhVUhl0N616z3/uXJxbzN8q9o9UpoMqNlPclq6Zc84iL8oLDH5I2N2EyWS22VE+UqxZlWphi5YviS+ZxKWdscu8ftcY5UHF7FKVNe7cnzx0GqXaqkzmAA0AwCo+evcp28CW8iA8qPNZOU3lMvSw8Fw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=84aNYvgmNEoDC/iKgGv/7Y0P+wErvEPnSmSSfmVRKpk=; b=DHHIDpARLCtds+gKFAgO+hIz4a6WU8yV0jct7ulbR1fznIwBzejK3OjPK5BMoe0Tae9h/0j8/VHn414AT18OysAeuqdpUIAHc+vB1N1vOO5ejiirgz/OFzxQI6GDyllBjioNFJQKDyWu7yeVkE0yk0FguLW5HHaAtL6pghqmAh0NIGwf5KlvB5NVEfEdGPx6JZELmlbW1dIfRs4ZsXy95XrrP/Fz04OoSDKASY8ckMv66TzbLBeOoIh0LftPuEvjHvl4zAMarLXEjgYxJdnmkZEx8yIlF/N+hxahBb5bRKrTa3yGqqkL5jk33yxN1/96f3UuvW2F7yZm/XZZiqo7+g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oss.nxp.com; dmarc=pass action=none header.from=oss.nxp.com; dkim=pass header.d=oss.nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=NXP1.onmicrosoft.com; s=selector1-NXP1-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=84aNYvgmNEoDC/iKgGv/7Y0P+wErvEPnSmSSfmVRKpk=; b=giZhAjmyovJ08LHBV0hzinjJTYTTiAaA6IDZI3L0uKRyaAaYepE26p3UAdvBum2eDj6Luqp679US9SLmafXZb2z1TuyQIuFFZa0jNqxQJy4/jvSLQXaA6bvsrC2s4ZQGL5Hdqi20FG9+dOrrXRA7mF6njuQ8adRpnk2VlmIL6B9WfOjEkiVPQ/uX9DT03EeYUVUduOxsv6gThVKFA9Uj5oST5aRW/MH+BJXdBDgQsV9pcqeoBUG68f1Q1qY4VFO/xSj43yKKkWx7aPvWIzhRhv5pjWTCrMIk5ruFM/aoC2SSPckeS/4vTyVn4fIbRzaSuJK1HfBzCRHPjAmhqmuyAw== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=oss.nxp.com; Received: from PAXPR04MB8254.eurprd04.prod.outlook.com (2603:10a6:102:1cd::24) by VI1PR04MB6944.eurprd04.prod.outlook.com (2603:10a6:803:133::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8606.34; Tue, 8 Apr 2025 02:58:32 +0000 Received: from PAXPR04MB8254.eurprd04.prod.outlook.com ([fe80::2755:55ac:5d6f:4f87]) by PAXPR04MB8254.eurprd04.prod.outlook.com ([fe80::2755:55ac:5d6f:4f87%4]) with mapi id 15.20.8606.033; Tue, 8 Apr 2025 02:58:32 +0000 From: ming.qian@oss.nxp.com To: mchehab@kernel.org, hverkuil-cisco@xs4all.nl, mirela.rabulea@oss.nxp.com Cc: shawnguo@kernel.org, s.hauer@pengutronix.de, kernel@pengutronix.de, festevam@gmail.com, xiahong.bao@nxp.com, eagle.zhou@nxp.com, linux-imx@nxp.com, imx@lists.linux.dev, linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: [PATCH v3 4/4] media: imx-jpeg: Check decoding is ongoing for motion-jpeg Date: Tue, 8 Apr 2025 10:57:20 +0800 Message-ID: <20250408025725.1244-5-ming.qian@oss.nxp.com> X-Mailer: git-send-email 2.48.1.windows.1 In-Reply-To: <20250408025725.1244-1-ming.qian@oss.nxp.com> References: <20250408025725.1244-1-ming.qian@oss.nxp.com> X-ClientProxiedBy: SI2P153CA0019.APCP153.PROD.OUTLOOK.COM (2603:1096:4:190::10) To PAXPR04MB8254.eurprd04.prod.outlook.com (2603:10a6:102:1cd::24) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PAXPR04MB8254:EE_|VI1PR04MB6944:EE_ X-MS-Office365-Filtering-Correlation-Id: 15d38531-3f7b-443e-f3ed-08dd76493f1f X-MS-Exchange-SharedMailbox-RoutingAgent-Processed: True X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|366016|1800799024|52116014|7416014|376014|38350700014; X-Microsoft-Antispam-Message-Info: owxMwVgnlOmDc6w91vMe8MT12tMCf/zQTkr6Clx7lO+YE1mado637r++mDz27RSsH6XSEfkNo46zzcwSkz4f8wZ1S2+YCXnHI9h0c8ZkMATKaWIs/52JrRvGDgxb9oD47iUudHNESRCBwxS2f/ShD3rIM9cbUPTIQEJlDGQV7sWu/ysuS4MDJ1pl3Oxq/XSryCptl2KcJHPTqzULIstRJa2IHSihOzCx1E9ekKSisyY9/DnRVuaYBKl/NRWdqnDFJ62/l/SIZhAjn4EyVVpHPMvEa1ZO5/noj3k6ekcbG+m0FNjHoIG6N7gwdAAJjgkPyZv+jZ3NFwzx5+7ShhcxfpkSlfBBtOnUCgA9xq5iI1a0J5Ji5j3H2PXvlYrv6V4cXlhNDlLKCWk7CwQy2w4J89mEhEJyW4A9yroB2FNne9QY61F/Pt9Y42PzQSFncP7xeIpLTCYSj7hGhVsW5/QrRnShsDNTbMHan3seFxBlEiQSiJH/qayVT55kUSvVa0cjzW2MzG1iamH1U5pzdbltmKrpD7fQPZqyL8JjUZJ55XCnLx5vj0oz31J5+tDLFtcHUIT+Gi9V/Ws1Z7G/anNtN1u5Yru19T+/b9YumMrdcpUWGc2i5dpVDmrED7hiXS3iEJU4MMTo6BeCQdSuQQcf2LpY4BT3E5vIPWDAvMMnqczY3S/HnYX2de3xqFHUSNQMY+uHMbPIo7LqVn/aHMPF8tf/vJk+b/ypXoAIOdcKjYMKcBS8DZGp6eG9COIpYHNK29H3xV6xGqoL2h7PNXxtHcQQWQAOgA4aI3ry9KqoTU0FYc+ulhUbVHT4naziDX5HWnU2Yf1aO05inM9R16gNt5aoY/35/2gpvUK753ita1zAIEKfvNbdUQvarRoVt7s52aD2YIFPvTgAlSmjYDM6S52U9+54wwvgCeeFSLe9I+JrNt6YF218psF5bfTzdyQy2/aYElofV4p8b5Z5xuoRzWMbb/lttBJdjp9Z3uAiw0RKlTXkBBpuTnBOiq11PNjBZ1T+2oAFZXjpM7U6nIBFEadS7gXM3G+FqWvp1C+8x+oyQrz399KQIEK7JqWDsufLBj4aYF2NSnFANUj+68wHXNbrMgERE3Fa+YKJYyoQEaAWpipJ1xkvyFrOrpfuetwnqtZOJBZE19f1PiVoq/ShV6+3ytMBZ1QOPdEpdROs+2ROuhLlGYuEvtAd6Ej28H2y9f3kAwa2b1s3cZMf7cH9MDYL4+DShown2AQblNDDFgDoG7CQrLGllTNXx76hcsxhSjV2Fn+Plg2VGVpJZjK+d2sq06Zpwc26AGX48t4Ymj+864/vDq01K6/r+xzqoVo1H5qdCyLcplzJ0si1sWFDh+aMzL3O7SJ27Y4LoW7KfK0UXibiHbqvjFzs3cenPAerodCy4Bm9OTkxxavSsbXvYe5EMSMZgR/0CP4FOArZv7i0TEVsobhOs/LCMT5LoEHy X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PAXPR04MB8254.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(366016)(1800799024)(52116014)(7416014)(376014)(38350700014);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: pbOiQa7n6dsNk4O9YXjiKRpl5rq4v2T2X/QkZgnonmlansXbSjxpKPMjFMa9tPz7f5d5XqtinrsX48iBjxhVHptlRJQ3RJQU3JOi+CW0NUGAKyL6KjtXfOImohKEVCYk3m1qZhYaOGwCSeREwDUV+rX7B+DFcqSvOumJkASzGuku046nqMJeK5r9k3Psq0cYbHll4wn6y9/bU+uz35lZOEjdl94V1GL4N9fqX5jr+S5fYG80ZoQlnRDS9OxW6fi9k1ABiObLmi+qMyP567gEswFCzYZDieeStAaaiHIhtdkJKjdKbrzPPSmdEORXW2pacuAXj/DYBDGJNflTTgLxNWwqLPOfd2AkVYn0CG9k+wm0ugHfKqI3GVF34gEAsHaLCW6zfPi/U2aTxoCqPdv7VepzgtVtf7J38Zeahw9BzUGdkPO7a8BPyzBBYW5v/B/ATYYo66WFwC9vf+QrCJN80w21TMy9SIinllgmj9Q+gE1yUd4cTsr0Qi/o77MbI3CNaQ1GCA4cmMQITGGS1mj7i7x6J/aawXwowVSlikkr8feaPhreXU1ybkzKUxuALsllOBPm4GXE1xo6LeuFpqtRVC41CtugcgQLtxhdAD7XzdUwdP7kIuxePq6UQtjnd5fKmH9t30EYvRoKITFhlX/gRG/cnOCtwjhPOjFVLxtrCNCRVDD2IPnxeCLs2rK0meBuZdTlaE22xPm8DVdpDvDLZvGscSPRDIqqV+hOJDG6lOgh2+BEK7xpsEmIKMHEX5XX48+/aqBGyzB2PqHJxE36Fsw0n0ucAdqQNv4C3EzbJyNFUXZ/a3Nlwa8EUYuod6a98nwdlrlRQpjmq3fQ0dIRRosxrSDUsFH4/qwxOZQlC7806IEBfYEjA78SmRkKB10dBIQ+gouNiFPddTdHmAnrA+dLZ3lRf1+3QlF9sZNPD5ExYf8riTgGthZyIDTTa0c+CfP1ga1dnQD8yMZP03eAl2bVz7e8zMLw40rEMS5K97LyL4jy4P40czSEzTU2f6lV6QBQgvOtNcKEHQ1+uCUZojC9ZlAl3InWa1BN3Q4c9ZXgQb/62BlZMmqnrFDaALxDXNXx88MUUBr4kNTMARgSaT6hAsszwoHhH8McLVwx1OPR37jQf1vhtmE2Sa0swn+LtE6pykHkMFU3WaoYZkBwYxMseznXnCVW9EIPgXCXB8carvYrEHcQHFOK0OPngdREySwuQvra8HesduhtgvE17lHJjNEOTC3qta7xHUjKdmRJJS2kU1fKgKwwQUWU4ATMDL+jkPMAvY/HXbgeiLfrceEUa9abNy8UY8mBrLL/PnzLHPBErJpAFHOsZ4lgn5VaiB2CiNfByehM52CUdWl033ssvmY9jhiQaSdAIQgGX/JJ+BQcqPklR3qaUK811ieFglgaHfjgnIC3xpTgkr539VP1BSg+WMvbd2WBMjrV/DsvbP7rjx9rLn/iGIwi7PE/wPMI4h7GCTs3fUhSUMpvRiu1KydLZNUZZnq6Xt6KPJROyTH8ic/OY7ibZZqHMJSiWDIt61Ckfle/eECHNSmhJnv7NBLrIF2UAfjBBtOOx9stlborPAzKQOqVnVO3KLFt X-OriginatorOrg: oss.nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 15d38531-3f7b-443e-f3ed-08dd76493f1f X-MS-Exchange-CrossTenant-AuthSource: PAXPR04MB8254.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Apr 2025 02:58:32.3173 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 2nz7bARx61YRafSytWtVnF7J+5Jw148o2+LH0UqL9COKCJ0GO2mm87FsumocnzlLaQvTzHlrFhF9VL560eALiA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB6944 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250407_195836_012144_C432530F X-CRM114-Status: GOOD ( 21.26 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org From: Ming Qian As the first frame in "repeat-mode" is the pattern, the first interrupt is ignored by the driver. With small resolution bitstreams, the interrupts might fire too quickly and thus the driver might miss the second interrupt from the first actual frame. In order to avoid the driver wait for the missed second interrupt, driver will check the curr_desc and slot_status registers to figure out if the decoding of actual frame is finished or not. Firstly we check the curr_desc register, if it is still pointing to the pattern descripor, the second actual frame is not started, we can wait for its frame-doen interrupt. if the curr_desc has pointed to the frame descriptor, then we check the ongoing bit of slot_status register. if the ongoing bit is set to 1, the decoding of the actual frame is not finished, we can wait for its frame-doen interrupt. if the ongoing bit is set to 0, the decoding of the actual frame is finished, we can't wait for the second interrupt, but mark it as done. But there is still a small problem, that the curr_desc and slot_status registers are not synchronous. curr_desc is updated when the next_descpt_ptr is loaded, but the ongoing bit of slot_status is set after the 32 bytes descriptor is loaded, there will be a short time interval in between, which may cause fake false. Reading slot_status twice can basically reduce the probability of fake false to 0. Signed-off-by: Ming Qian --- v3 - Read the slot_status register twice - Improve commit message .../media/platform/nxp/imx-jpeg/mxc-jpeg-hw.h | 1 + .../media/platform/nxp/imx-jpeg/mxc-jpeg.c | 30 ++++++++++++++++++- 2 files changed, 30 insertions(+), 1 deletion(-) diff --git a/drivers/media/platform/nxp/imx-jpeg/mxc-jpeg-hw.h b/drivers/media/platform/nxp/imx-jpeg/mxc-jpeg-hw.h index d579c804b047..adb93e977be9 100644 --- a/drivers/media/platform/nxp/imx-jpeg/mxc-jpeg-hw.h +++ b/drivers/media/platform/nxp/imx-jpeg/mxc-jpeg-hw.h @@ -89,6 +89,7 @@ /* SLOT_STATUS fields for slots 0..3 */ #define SLOT_STATUS_FRMDONE (0x1 << 3) #define SLOT_STATUS_ENC_CONFIG_ERR (0x1 << 8) +#define SLOT_STATUS_ONGOING (0x1 << 31) /* SLOT_IRQ_EN fields TBD */ diff --git a/drivers/media/platform/nxp/imx-jpeg/mxc-jpeg.c b/drivers/media/platform/nxp/imx-jpeg/mxc-jpeg.c index 45705c606769..85795ac4cc71 100644 --- a/drivers/media/platform/nxp/imx-jpeg/mxc-jpeg.c +++ b/drivers/media/platform/nxp/imx-jpeg/mxc-jpeg.c @@ -910,6 +910,33 @@ static u32 mxc_jpeg_get_plane_size(struct mxc_jpeg_q_data *q_data, u32 plane_no) return size; } +static bool mxc_dec_is_ongoing(struct mxc_jpeg_ctx *ctx) +{ + struct mxc_jpeg_dev *jpeg = ctx->mxc_jpeg; + u32 curr_desc; + u32 slot_status; + + curr_desc = readl(jpeg->base_reg + MXC_SLOT_OFFSET(ctx->slot, SLOT_CUR_DESCPT_PTR)); + if (curr_desc == jpeg->slot_data.cfg_desc_handle) + return true; + + slot_status = readl(jpeg->base_reg + MXC_SLOT_OFFSET(ctx->slot, SLOT_STATUS)); + if (slot_status & SLOT_STATUS_ONGOING) + return true; + + /* + * The curr_desc register is updated when next_descpt_ptr is loaded, + * the ongoing bit of slot_status is set when the 32 bytes descriptor is loaded. + * So there will be a short time interval in between, which may cause fake false. + * Reading slot_status twice can basically reduce the probability of fake false to 0. + */ + slot_status = readl(jpeg->base_reg + MXC_SLOT_OFFSET(ctx->slot, SLOT_STATUS)); + if (slot_status & SLOT_STATUS_ONGOING) + return true; + + return false; +} + static irqreturn_t mxc_jpeg_dec_irq(int irq, void *priv) { struct mxc_jpeg_dev *jpeg = priv; @@ -979,7 +1006,8 @@ static irqreturn_t mxc_jpeg_dec_irq(int irq, void *priv) mxc_jpeg_enc_mode_go(dev, reg, mxc_jpeg_is_extended_sequential(q_data->fmt)); goto job_unlock; } - if (jpeg->mode == MXC_JPEG_DECODE && jpeg_src_buf->dht_needed) { + if (jpeg->mode == MXC_JPEG_DECODE && jpeg_src_buf->dht_needed && + mxc_dec_is_ongoing(ctx)) { jpeg_src_buf->dht_needed = false; dev_dbg(dev, "Decoder DHT cfg finished. Start decoding...\n"); goto job_unlock;