From patchwork Tue Apr 8 06:47:57 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Aditya Garg X-Patchwork-Id: 14042233 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D4D60C3600C for ; Tue, 8 Apr 2025 06:48:16 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 4EC6410E216; Tue, 8 Apr 2025 06:48:16 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=live.com header.i=@live.com header.b="Rzk3VnFq"; dkim-atps=neutral Received: from PNZPR01CU001.outbound.protection.outlook.com (mail-centralindiaazolkn19011036.outbound.protection.outlook.com [52.103.68.36]) by gabe.freedesktop.org (Postfix) with ESMTPS id E2B9310E216 for ; Tue, 8 Apr 2025 06:48:14 +0000 (UTC) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=aXaCTB9P5lk42Vf1+cRUz88zm6IaJlHD/w0S3pLarNXpq7GNLzDx7+KMBndh3qhbgYh591Cu6Y62cNgfgHGCV1Y8zcJeToG20I5rh+ebgmJbD7ivYTFmDc6LyspU9JLZCmc1SVZV04qxzSAz4tc1whjKQorY2HCUaMTXVavUXgxIX1zlmujIVElH/PbyHkZxSUC7N5Fge9H4A1Oz7a7uTMt1CDLNIDOU4JGrT4xSZWlaWHy6XD0VZP6R26gwa7NyvRWu4XcOJWafhMYvupA4v4PEHo2pN7/Pwoy/IpKttPJiMtOby6V5Qs2npoDhUSLZYVCAkIACyLEnuuzr0rLo3A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=9BaK2sIbKkGMx/9FF6qJRdXWycczn6mmYQVjFvZlDi8=; b=OufoNkMz4NA9PV9HJWkPtDfZSHdz6sFLmpjL7I5RcZwJ2jUt2qsWccj1dO1rMK7UZQ0XWe4EoxRvS9YfzZf1wlSrbiymEi89vEZZnodpSXCWiTMmQ9QRBOup8pTvzr7/aGizut1em2j6W+JUuXiWD+B+VRGtO8jX0LQEsDB26s9vZtgk4sNQaZBm7Tnq0oEqqsqDdj3pTAYCjGQy0bujY0CV3sHn5j4xWg+uHKOHIbsZzBM6MyBHXJjXV5PmMsULZImE17gUwrxjiTjeGptDiXvCRL350u9+JsAn6LAISURryP8LWgzcPqLLaSBocMMocpnKSQcsJRZe77B0Z4lPfg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=live.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=9BaK2sIbKkGMx/9FF6qJRdXWycczn6mmYQVjFvZlDi8=; b=Rzk3VnFqu7mu9f9eqHK3uYwwwVCv93ExBinNxJ8SVgCi9ZcXFY3yXjvbGCGl8N9Thq9KFQWwZtolzn54pdUfrFRyZzv0pzmTa8wp1bM8Y6HjtwJ7fAR8YQjTHKKhpqzxNSp34lAvReX7B0Y7c6w+t2ba4B68HSrVReMSR6kMWwMcy20Tc9r8jkv40i9kqDBR1wVv1I0GNx9s7n/Eej/92tkLq/t+uap3lAKo2x42VQGR1sZaV8DcZjzf9WT0Mod+zbXxUvHpmBk4OTJF493buZNTvq3lQft/nz17DP3oSd5bmo8256oP1DiPilDVLakBBKmdG1Ga2UNMxC/FQLJZmg== Received: from PN3PR01MB9597.INDPRD01.PROD.OUTLOOK.COM (2603:1096:c01:f7::14) by PN0PR01MB9261.INDPRD01.PROD.OUTLOOK.COM (2603:1096:c01:11e::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8606.35; Tue, 8 Apr 2025 06:48:02 +0000 Received: from PN3PR01MB9597.INDPRD01.PROD.OUTLOOK.COM ([fe80::324:c085:10c8:4e77]) by PN3PR01MB9597.INDPRD01.PROD.OUTLOOK.COM ([fe80::324:c085:10c8:4e77%7]) with mapi id 15.20.8606.029; Tue, 8 Apr 2025 06:48:02 +0000 Message-ID: Date: Tue, 8 Apr 2025 12:17:57 +0530 User-Agent: Mozilla Thunderbird Subject: [PATCH v4 1/3] lib/vsprintf: Add support for generic FourCCs by extending %p4cc From: Aditya Garg To: alyssa@rosenzweig.io, Petr Mladek , Andy Shevchenko , Sven Peter , Thomas Zimmermann , Aun-Ali Zaidi , Maxime Ripard , airlied@redhat.com, Simona Vetter , Steven Rostedt , Rasmus Villemoes , Sergey Senozhatsky , Jonathan Corbet , Andrew Morton , apw@canonical.com, joe@perches.com, dwaipayanray1@gmail.com, lukas.bulwahn@gmail.com, Kees Cook , tamird@gmail.com Cc: Linux Kernel Mailing List , dri-devel@lists.freedesktop.org, linux-doc@vger.kernel.org, Hector Martin , Asahi Linux Mailing List References: Content-Language: en-US In-Reply-To: X-ClientProxiedBy: PN3PR01CA0090.INDPRD01.PROD.OUTLOOK.COM (2603:1096:c01:9a::9) To PN3PR01MB9597.INDPRD01.PROD.OUTLOOK.COM (2603:1096:c01:f7::14) X-Microsoft-Original-Message-ID: <65855c14-4158-423b-8d0c-0afaadeca8ae@live.com> MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PN3PR01MB9597:EE_|PN0PR01MB9261:EE_ X-MS-Office365-Filtering-Correlation-Id: 55964a5f-a61a-420c-b890-08dd76694e8f X-Microsoft-Antispam: BCL:0; ARA:14566002|8060799006|7092599003|15080799006|6090799003|5072599009|461199028|19110799003|3412199025|440099028|41001999003; X-Microsoft-Antispam-Message-Info: =?utf-8?q?J7/UMbH6hsP3GJjTGK7d9o4zcHO2yTl?= =?utf-8?q?KCTIZ67QbpbYpoRHJKi5jQwiDJ24kUwxkArvnKpPkDPBt4xnzSaH0QDnjW4G9foJu?= =?utf-8?q?DsXcfaRFlByRovlYvfNbtEGTQWyE0IPNBP4mhm/UVFSHWykTUHIdcq0x5ZD61FlHG?= =?utf-8?q?wfWk9770DL+YLJwgNsuJABicVnvCxSfW7Nxwu9Fk6pvfpaDRFEAQqZaIuGl7CX4wQ?= =?utf-8?q?IV4rsUc+DzzMJPOWuZnPw5x+L4K6Ku6/0+plltBfLXtYo/hxVegypqD+qpP84jVtk?= =?utf-8?q?DLmTvlO/cEBWp9Q2JOJzuEaimt4Ok+0QKrWUew+D1acf4OsZNs+Dj63Q3FdMzadSF?= =?utf-8?q?+9jA6T1T5sp+aSxI55iJVDx1deAFpfXTnlb9ZfCxKacUx6WhjW9jGp8tZTYBMYbWS?= =?utf-8?q?qBDWBcAjM3GZ4ydaMlJjrn/c1obBsQhaDpfOKnqGxLUSfMD4tm2SbJpb1MO91Ak/6?= =?utf-8?q?P9/8OQ4ToA/pDYMuMTXnvl7MzuaDAgxf68DEtsFyNMr0OfGHC8/qkd/4RjhmyIweG?= =?utf-8?q?/9DEctJ5Y6CwpKD+Naasq3J5c9bTsk3BbfCy82OGsWQs+uMIMsBaY5HYWHA7KzNPq?= =?utf-8?q?yYbbXuVmkji1ksY0JdvoC3NUV9xkLJI/795xo9wcZP3q9lr5FKGLAY3ABmfzprw4n?= =?utf-8?q?PoETR/Nm76SXJDW0mEpX4WpiKSfHSjxUTfv2I+EN63r2cRaBZMv5GJM/68tXR9qiO?= =?utf-8?q?jVXCg+QS//M/afXGIp2+ZxDDM4NIS7QD+xMq0AWCIX3XRUzO7fDipaUSOZUtNwf9B?= =?utf-8?q?+EV9dDEotMc+2DhKyZ1mgJKLevVpikzk6X+q9Q1/kLzZcewGYDjZ8/JAI5j5vecQn?= =?utf-8?q?3uO6zai01KCeHmwy5GZTg0RMSGnLbD1rG+s9o/OsD9Mpw9jpe10jF4ZcS2Qg6zycD?= =?utf-8?q?4DLEsKIEemlrvbOP5teVYCFmK4wqv5oBqSfKkYeN+83/8h7jzCfPYLd98AtNIJ94D?= =?utf-8?q?odyPnjG6k4rjOu98gfbAz7HnXpG5+BAYTay8D3u0iROo7gnI6HT2tZw8aDbtFrnrO?= =?utf-8?q?lZikM1NJbrHQYs6smLnWyMgXOI4gJs95FoI5zgQqJ4/xL6BFZuBS4zmZ1OZQfDmkw?= =?utf-8?q?C3PLjrShOmV3lJr4uynPJYVkKvB5OlRHS23Ma5gYYiidABy6qAhN6nSbTxs=3D?= X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?q?j6+9UAI4LAwglzTHucVmZ+X6vgkU?= =?utf-8?q?WSoIw1aqeGw8P33Pmh6hwNxxH4XiPN0O0P9X/vONL5u1y0JQKAPzrmo47Ky66GvHz?= =?utf-8?q?4RKweVWtQA31mkbvv6sLjW88rxmjyN4x8Tl3RiqtvCG4Xf7pA76IlujJG21Y1OO2w?= =?utf-8?q?xxbJ00DywHpx419j8PRctpOv1+iHiCH26A8VGcqULhD+zP8yNGKCu6gyrVToNJ5rq?= =?utf-8?q?ccjj8s9QQd0o/TzRdLulF3FG7Qkd6gnT0Rfm5aYrjZrGV62vqsrUK++ZMWBPLH4uJ?= =?utf-8?q?ZYsZRAkrwknrukmhjI4PXFsMs45uBaWH7eP/mnEdvMaS7XywdF7Qrvb38LIuv90lD?= =?utf-8?q?xYcPbNYC+IioG1Tf7uqy1qrgDeX4lzkm4QVXrTG1hE1ZNA5fGCL3H/VBi2vYTbFZd?= =?utf-8?q?g8UNdU+tZ1FMILGN9xv2/RWD64xe69fYDRbcvUKjBuockh6RGxgenNj0cuHkgmKo9?= =?utf-8?q?ktpa/l4TKXFWuTOXc2bkSlznb0pwhmn2d9c/Z1Qvpa4nbm1qHrsRMV2mkc/BgtPEb?= =?utf-8?q?ReF8ktaoAjm7BqoBnM1pmcjMFOw+U8D0J8Ld/ZniBEv8Q4zLdcoBpFGxb7ERq/xvb?= =?utf-8?q?kmo04otw1cDGqNLL9IVx6V3eU+nxA+/1HAT65xSeKzUyj8gkZkCn1ipeBXqM/0AMN?= =?utf-8?q?MUs3Xmp6wIPNLgQqlIbUKFM3uSU58TsrbAP3wjgRpdwGhCEHfevdNpbbJQXozjPZz?= =?utf-8?q?LNkNuChaDDiaDtIe7NQQh1HkVR+dcHNdRp7SpuwVhCh1VsVYYAnrV11z4Wblyl/IE?= =?utf-8?q?Xj8Fa46b8cpsnAHYksDObB/QII1x9tkuSbw9RZsIq5ft1LVWo+v7YGb5lf4BPLYDm?= =?utf-8?q?j0/kiKMBdIQ5osgTnT7KP/03JftiJuhcHzUQXjtJF+3SBrjmDt84Y8eziZ64cNbj3?= =?utf-8?q?CqTTMbJfM9XufzU22ZxHJf4RQolYFKL9StN30sN3HTrxjGJfO/NpIQ2/NquUOHXWE?= =?utf-8?q?ThwkKfwEzqivfr5oE2VbmdPMczSOBLslAy2NJvAsrm1wEMBetPQasssEb6rRLX8mV?= =?utf-8?q?fFiW8p5C5urOa8atmAP5AaEu3choUc664CHdJPwvgGo3q4mQMfhMOF4b5WIFD/c5k?= =?utf-8?q?3gMimdIWxqFtGSvOCFTvza/i6uZubRdxYhYMLxGfZjPe/8ZsAWf2Vn8s12hjP9ALy?= =?utf-8?q?DVTNoqq4eYpe74b5939RrnylFZu51V+n6CZmLKr2RsDNJKW+FKGXltJajJPKXs2pM?= =?utf-8?q?RQx3gF/GU1ESV9SF12ddyrsc0NuhVCy4PXYFqIKE5VRQA2qU33pBhwZtYrHRjYLXH?= =?utf-8?q?OLGpnstKpWM/x9tz?= X-OriginatorOrg: sct-15-20-7719-20-msonline-outlook-ae5c4.templateTenant X-MS-Exchange-CrossTenant-Network-Message-Id: 55964a5f-a61a-420c-b890-08dd76694e8f X-MS-Exchange-CrossTenant-AuthSource: PN3PR01MB9597.INDPRD01.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Apr 2025 06:48:02.0516 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: PN0PR01MB9261 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" From: Hector Martin %p4cc is designed for DRM/V4L2 FourCCs with their specific quirks, but it's useful to be able to print generic 4-character codes formatted as an integer. Extend it to add format specifiers for printing generic 32-bit FourCCs with various endian semantics: %p4ch Host byte order %p4cn Network byte order %p4cl Little-endian %p4cb Big-endian The endianness determines how bytes are interpreted as a u32, and the FourCC is then always printed MSByte-first (this is the opposite of V4L/DRM FourCCs). This covers most practical cases, e.g. %p4cn would allow printing LSByte-first FourCCs stored in host endian order (other than the hex form being in character order, not the integer value). Acked-by: Rasmus Villemoes Reviewed-by: Andy Shevchenko Reviewed-by: Petr Mladek Tested-by: Petr Mladek Signed-off-by: Hector Martin Signed-off-by: Aditya Garg Reviewed-by: Kees Cook --- Documentation/core-api/printk-formats.rst | 32 +++++++++++++++++++++ lib/vsprintf.c | 35 +++++++++++++++++++---- scripts/checkpatch.pl | 2 +- 3 files changed, 62 insertions(+), 7 deletions(-) diff --git a/Documentation/core-api/printk-formats.rst b/Documentation/core-api/printk-formats.rst index 4bdc394e8..125fd0397 100644 --- a/Documentation/core-api/printk-formats.rst +++ b/Documentation/core-api/printk-formats.rst @@ -648,6 +648,38 @@ Examples:: %p4cc Y10 little-endian (0x20303159) %p4cc NV12 big-endian (0xb231564e) +Generic FourCC code +------------------- + +:: + %p4c[hnlb] gP00 (0x67503030) + +Print a generic FourCC code, as both ASCII characters and its numerical +value as hexadecimal. + +The generic FourCC code is always printed in the big-endian format, +the most significant byte first. This is the opposite of V4L/DRM FourCCs. + +The additional ``h``, ``n``, ``l``, and ``b`` specifiers define what +endianness is used to load the stored bytes. The data might be interpreted +using the host byte order, network byte order, little-endian, or big-endian. + +Passed by reference. + +Examples for a little-endian machine, given &(u32)0x67503030:: + + %p4ch gP00 (0x67503030) + %p4cn 00Pg (0x30305067) + %p4cl gP00 (0x67503030) + %p4cb 00Pg (0x30305067) + +Examples for a big-endian machine, given &(u32)0x67503030:: + + %p4ch gP00 (0x67503030) + %p4cn 00Pg (0x30305067) + %p4cl 00Pg (0x30305067) + %p4cb gP00 (0x67503030) + Rust ---- diff --git a/lib/vsprintf.c b/lib/vsprintf.c index 01699852f..6bc64ae52 100644 --- a/lib/vsprintf.c +++ b/lib/vsprintf.c @@ -1793,27 +1793,50 @@ char *fourcc_string(char *buf, char *end, const u32 *fourcc, char output[sizeof("0123 little-endian (0x01234567)")]; char *p = output; unsigned int i; + bool pixel_fmt = false; u32 orig, val; - if (fmt[1] != 'c' || fmt[2] != 'c') + if (fmt[1] != 'c') return error_string(buf, end, "(%p4?)", spec); if (check_pointer(&buf, end, fourcc, spec)) return buf; orig = get_unaligned(fourcc); - val = orig & ~BIT(31); + switch (fmt[2]) { + case 'h': + break; + case 'n': + orig = swab32(orig); + break; + case 'l': + orig = (__force u32)cpu_to_le32(orig); + break; + case 'b': + orig = (__force u32)cpu_to_be32(orig); + break; + case 'c': + /* Pixel formats are printed LSB-first */ + pixel_fmt = true; + break; + default: + return error_string(buf, end, "(%p4?)", spec); + } + + val = pixel_fmt ? swab32(orig & ~BIT(31)) : orig; for (i = 0; i < sizeof(u32); i++) { - unsigned char c = val >> (i * 8); + unsigned char c = val >> ((3 - i) * 8); /* Print non-control ASCII characters as-is, dot otherwise */ *p++ = isascii(c) && isprint(c) ? c : '.'; } - *p++ = ' '; - strcpy(p, orig & BIT(31) ? "big-endian" : "little-endian"); - p += strlen(p); + if (pixel_fmt) { + *p++ = ' '; + strcpy(p, orig & BIT(31) ? "big-endian" : "little-endian"); + p += strlen(p); + } *p++ = ' '; *p++ = '('; diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl index 3d22bf863..44e233b6f 100755 --- a/scripts/checkpatch.pl +++ b/scripts/checkpatch.pl @@ -6891,7 +6891,7 @@ sub process { ($extension eq "f" && defined $qualifier && $qualifier !~ /^w/) || ($extension eq "4" && - defined $qualifier && $qualifier !~ /^cc/)) { + defined $qualifier && $qualifier !~ /^c[hnlbc]/)) { $bad_specifier = $specifier; last; } From patchwork Tue Apr 8 06:48:32 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Aditya Garg X-Patchwork-Id: 14042234 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 7EF61C369A1 for ; Tue, 8 Apr 2025 06:48:50 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id EB88A10E0E9; Tue, 8 Apr 2025 06:48:49 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=live.com header.i=@live.com header.b="n1GxuTdu"; dkim-atps=neutral Received: from MA0PR01CU012.outbound.protection.outlook.com (mail-southindiaazolkn19011027.outbound.protection.outlook.com [52.103.67.27]) by gabe.freedesktop.org (Postfix) with ESMTPS id 8328A10E0E9 for ; Tue, 8 Apr 2025 06:48:48 +0000 (UTC) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=CBko4/dYStnxNm+vT8aS7CpoPjHWCWTnz494dCA4e7vN06uGwy5dFHKGTv2DZmU6Z5UJcIQzXnOA2K6hGHaqtkCKr07WAoXMKJoI7+GucoFvnGzX5lNgXxPahRVX8PvsMdd7ZNF5Pk38rAwMUWOBK9/qXitIlOy2z6mYTjPvSjTSjnPaUe/1nLgi7+xoLOWktXVZMskXBVkefUVqv8wZDUoYgfm5pXieptrqlA7a0qT4ifVzOSKcY2NadNdy6MkzDaFBWTXP3CEydyUsLnsYuyHdQeW5dH+tOPMAynpumeitdvi/AGSY1H4b0wfEb7LMpy41LqWkwM/aPswrJS8PGg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=EfKNRZZ4wSX/GVjiAu61b39RPWBTnYTKKt8RDZMGdPQ=; b=I+8QFuqDJmFj5P5b/j2oklVeShRfhsvBn4JGP3zYuWw8ehbp8USnYxzEPYiaTmsjkbWtGiIDQhyXxPBVswhHhTr1czfD/C69ipQoJ1MvBp/tOuDJDlsmojsr+dHODYrJz4Jz00eDtP5kDy7CEiQmWbErpkf2D5DFhIF8fGdWBCjdDG/GA9J9WVbQZ+JfSKnkZwiz3GDK5tdGA9Qcu5FEUvP0advwovkPZN/emNMvGQTHLOCtfGbCY0JfFaCcnYdWzp66nVvE7fJo5YxvReT65jDkTSutHrIJlHRZHTJCtfWJWpyWU58auzTMszXH6wApLU7BdTtp49JHuHuwbVYxyA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=live.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=EfKNRZZ4wSX/GVjiAu61b39RPWBTnYTKKt8RDZMGdPQ=; b=n1GxuTduwTdvOj3V8sHpMuCq3cS/+vfKfDctqfttGE4I56phkMvEkyv7OVuAgzLBEiac59WQ1StGPump2mZDw2qZzRH2ExwKklG2i0H8MM5P/iV9vJfsP9dwx0lXrujNCpykXL/x7Vjm9de404chzJ/e1TsvZQF7niHD4WXAMjZ59U8v+L5NJj/OwK22F1wMgY9BT8hQtNwMxDjCSk0fBGDFjiaSPGnyCAGPBL/VxujBaIF3F/CuZYgP7X5f+TGAPZsJGfClBHTVrG/oky3wrjsP33kbqttgHUkB8wPRDuUuhmd43bhHVSW+gQsl4AGJbzYhEuH8f411uqY05xe+ng== Received: from PN3PR01MB9597.INDPRD01.PROD.OUTLOOK.COM (2603:1096:c01:f7::14) by MA0PR01MB7052.INDPRD01.PROD.OUTLOOK.COM (2603:1096:a01:5e::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8606.33; Tue, 8 Apr 2025 06:48:36 +0000 Received: from PN3PR01MB9597.INDPRD01.PROD.OUTLOOK.COM ([fe80::324:c085:10c8:4e77]) by PN3PR01MB9597.INDPRD01.PROD.OUTLOOK.COM ([fe80::324:c085:10c8:4e77%7]) with mapi id 15.20.8606.029; Tue, 8 Apr 2025 06:48:36 +0000 Message-ID: Date: Tue, 8 Apr 2025 12:18:32 +0530 User-Agent: Mozilla Thunderbird Subject: [PATCH v4 2/3] printf: add tests for generic FourCCs From: Aditya Garg To: alyssa@rosenzweig.io, Petr Mladek , Andy Shevchenko , Sven Peter , Thomas Zimmermann , Aun-Ali Zaidi , Maxime Ripard , airlied@redhat.com, Simona Vetter , Steven Rostedt , Rasmus Villemoes , Sergey Senozhatsky , Jonathan Corbet , Andrew Morton , apw@canonical.com, joe@perches.com, dwaipayanray1@gmail.com, lukas.bulwahn@gmail.com, Kees Cook , tamird@gmail.com Cc: Linux Kernel Mailing List , dri-devel@lists.freedesktop.org, linux-doc@vger.kernel.org, Hector Martin , Asahi Linux Mailing List References: Content-Language: en-US In-Reply-To: X-ClientProxiedBy: PN3PR01CA0090.INDPRD01.PROD.OUTLOOK.COM (2603:1096:c01:9a::9) To PN3PR01MB9597.INDPRD01.PROD.OUTLOOK.COM (2603:1096:c01:f7::14) X-Microsoft-Original-Message-ID: <170a9e37-5e3d-4628-acb5-04959f8a6224@live.com> MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PN3PR01MB9597:EE_|MA0PR01MB7052:EE_ X-MS-Office365-Filtering-Correlation-Id: 9e00d81c-22df-4861-7f4e-08dd766962de X-Microsoft-Antispam: BCL:0; ARA:14566002|6090799003|5072599009|15080799006|7092599003|8060799006|19110799003|461199028|440099028|3412199025; X-Microsoft-Antispam-Message-Info: =?utf-8?q?cFdw/btSZ+ArZ9iwntr94Fc+DC/j39r?= =?utf-8?q?WmUoyPLYKclYnMCfqFwNvHBM0cJtERNj8c/6N2RHvLf0KZFPwhT6sztI+caJEr998?= =?utf-8?q?TmiYtvO7lz4MbaGJL48myKZmoyTKImwO3lEF1Wo23CJzkqLicpJkOktWb39vo6srH?= =?utf-8?q?oEo4Cxb4ZMJNXmc66uVqPihCcGV4A81iBIZD/YYC8BCtwtLUe0p+InY6jt5ilwjYL?= =?utf-8?q?/jFLuSTVEuOHbVAuYMT9DeyK4N6LGEk56Qn0s7INRtwD6kqX9IxWNjmESG4itv7as?= =?utf-8?q?y70yHhdS94TqzWpQm7/6C72XgsFdGvFoysvQQw2AzXVxTWywhui5TqBnCBZrqSsF3?= =?utf-8?q?RceX+WAR7LiToP21wf5Dj0Zm1whIQf+qtFVixcnMl/ZfX691ECBGvnp8KOmlT6SL9?= =?utf-8?q?USCQuR0BEyX44yhipoKsgvMz9fAmBTXIuIwFR7pRqMKF4n6M7Ox0YyQPWjYIwQvIR?= =?utf-8?q?mTaFC5rSsB6W15nxstSYANfIyVkyykgBaLqe8xC32amxbatI6hO1uCP7K7vGmygJ8?= =?utf-8?q?xt56kl0Uiuqu0p8I/3hpljPq+xCva3vlgLNoh6ztJ0Gf8c7hAqNEcT9TJ73kGxlSZ?= =?utf-8?q?NH+owzyv5OMi0lyoiVfqB017UYU9HFK4INzm9QMubdHkB/VNaU6pLJ5l3ivRW11PK?= =?utf-8?q?UK1zHnmKWB8PKh6TX2ceTOOu40KsLCFDykWUw+c8OiNumdemX88T/W++DIiFZSGvy?= =?utf-8?q?3PAzi8dS8RhZz+3Bl9oAe0umU8si/U+5j1ndtvO2wSWHjm1AtMM/281U+bnU21g4f?= =?utf-8?q?byy1NsjczjgBuGrK+naI9fFz38iehnWKemcj/Vf1JGP+F34tkg5emv2r3+SUFBima?= =?utf-8?q?caU06oESzL0GxTQtpUimzolh4WLA3Z/5uzill7E1qAIwkX3+Dzri1oXujq6T9lElP?= =?utf-8?q?/NCzI2tZ1Jhaq1fMW37GhkTOPiu5UMWm2FFRjuH9NP5M2DZNueJTHcKbShAryIpM0?= =?utf-8?q?mloGrafmKtm0YNhueQ/Vz5uy8FsQlTdv1qhs0neVo0MrPxCOACnPdJBjok+Nes49G?= =?utf-8?q?RJEVaLTt9eBRK/auvx4HIaHlNk0Lhp6Y2jJjVFyKtOUbA4h4ML5mHRr4P+boOcveO?= =?utf-8?q?WqvdhjwLM+A9S8k8?= X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?q?nt5N/U7gSPKtIhzACvWTfd5icQlv?= =?utf-8?q?EjVlUwaWBatReowZuCOY3BkCQh3siyxMb2eOgYngIkJQKvB3raf3zcUhx3AVRn4C6?= =?utf-8?q?xNWlFfx0C2U1tJ4gKi0PFmSEjw4CUnub1wLfLaRXOr166vHb4o0mEfvbLCQjrwnRn?= =?utf-8?q?fVA2pmTcQAPovUl4Ev1TPpTu6LQq5qUqdk08q+0C4wUr7IzjA8a/bJD/TnaUjqrMB?= =?utf-8?q?pMY69Z5OP9ZFO2P5ZakT6q5ICSk7ULhQv7Xr850OWhkVuayGsbPjBf3ifd3VI/Nfc?= =?utf-8?q?fDXvKDp08wOMrGMCaIw+fT20J5ZIYGREj8ipmf6X0C4/Vq9Pop3JA6lAFeiRPHvTq?= =?utf-8?q?xYYR9PBvkj1r3MBYaVbTWXFZfNutfBXcf/5ltdfbfof9aDm4wWMQBFmcC2XEv3ndb?= =?utf-8?q?ynLOSFhisnqg/E/Uyz7O+QrYRBvr9PYtvHBBEikIRU6oZI6GuP2S8tiOzEP7sCuSh?= =?utf-8?q?MkKdmaGG6g/wdrNEwitysVRc4xyVhftgx59badjYBE6ICfl96Ac2z8TuWg95JI9c8?= =?utf-8?q?eHArQWn5wWsWqLCOo8YKDI8c4mggFWT/aLc3iyjjZmqtlxBERBn0awoH94uxy3c8a?= =?utf-8?q?X+7+/ZHvRnRDXXY0tkVjLjmFzCtxkSQ7GwSznL1warQgg+sle4uVN2q7yxlMQIdvh?= =?utf-8?q?GsnXOPwxAJ1+iBlWiRu5VtyRc72As5c2nPpZGqiVU1jmbu8ArxDGO/ByJfx8+nsHn?= =?utf-8?q?ZpicRiDAR9i1cJFIxp2d7sye94i2wjLeIAAklaaUoy+SAAauIl5/42avqF3U5E3kE?= =?utf-8?q?RtDdG7ERT0yOulYiX88/w+oZYGm9moTBubCfSvMLxEhK6o7gaNMPF6i22qfqawkWk?= =?utf-8?q?VZN6JDL/BM1NvoxsDVk0DA07Q25nTfbJXAOWu84YwC7IlKpOWlhjGXd2ubtOyJlTZ?= =?utf-8?q?fPghGqlbWoam8DJBNcX9I24A/0DAM4MapxJJGfQ7HZ0XF/4nshDDv4kFpvw8E3PF4?= =?utf-8?q?8UciDyzpwmhGEuKQklqcnQnqHeSVN40IDYnr0zu5IA5ZSjvKyuyjsYtrrOYEPY5Fs?= =?utf-8?q?zGl6QrwtaeFHh8dGC+DOaJaFyC4ty8gFRYsfrnB1dCl5VC19deyKHCeQaOhSS6E5q?= =?utf-8?q?qzJWl6BBGQ8VOJzWe/ud88qEdQgtZPSu7BkDJBROgk2ypn4QLfhy6NYeSWm414CzF?= =?utf-8?q?QeRUorxktY6Ey2ps8j5qrANSXXGmUehYbJ3io6T0qCl8ZehSS021YIflZYQt4Iqk2?= =?utf-8?q?M7G2fvutnIdPdk8bRwVPQWsMnvOSFZCYzE5u8b5V7mYr8rl62PsKJIaHeM8LF+fx5?= =?utf-8?q?62IQlqTUSkS7NBaB?= X-OriginatorOrg: sct-15-20-7719-20-msonline-outlook-ae5c4.templateTenant X-MS-Exchange-CrossTenant-Network-Message-Id: 9e00d81c-22df-4861-7f4e-08dd766962de X-MS-Exchange-CrossTenant-AuthSource: PN3PR01MB9597.INDPRD01.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Apr 2025 06:48:36.1130 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: MA0PR01MB7052 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" From: Aditya Garg This patch adds support for kunit tests of generic 32-bit FourCCs added to vsprintf. Acked-by: Tamir Duberstein Reviewed-by: Andy Shevchenko Reviewed-by: Petr Mladek Tested-by: Petr Mladek Signed-off-by: Aditya Garg Reviewed-by: Kees Cook --- lib/tests/printf_kunit.c | 39 ++++++++++++++++++++++++++++++++------- 1 file changed, 32 insertions(+), 7 deletions(-) diff --git a/lib/tests/printf_kunit.c b/lib/tests/printf_kunit.c index 2c9f6170b..b1fa0dcea 100644 --- a/lib/tests/printf_kunit.c +++ b/lib/tests/printf_kunit.c @@ -701,21 +701,46 @@ static void fwnode_pointer(struct kunit *kunittest) software_node_unregister_node_group(group); } +struct fourcc_struct { + u32 code; + const char *str; +}; + +static void fourcc_pointer_test(struct kunit *kunittest, const struct fourcc_struct *fc, + size_t n, const char *fmt) +{ + size_t i; + + for (i = 0; i < n; i++) + test(fc[i].str, fmt, &fc[i].code); +} + static void fourcc_pointer(struct kunit *kunittest) { - struct { - u32 code; - char *str; - } const try[] = { + static const struct fourcc_struct try_cc[] = { { 0x3231564e, "NV12 little-endian (0x3231564e)", }, { 0xb231564e, "NV12 big-endian (0xb231564e)", }, { 0x10111213, ".... little-endian (0x10111213)", }, { 0x20303159, "Y10 little-endian (0x20303159)", }, }; - unsigned int i; + static const struct fourcc_struct try_ch[] = { + { 0x41424344, "ABCD (0x41424344)", }, + }; + static const struct fourcc_struct try_cn[] = { + { 0x41424344, "DCBA (0x44434241)", }, + }; + static const struct fourcc_struct try_cl[] = { + { (__force u32)cpu_to_le32(0x41424344), "ABCD (0x41424344)", }, + }; + static const struct fourcc_struct try_cb[] = { + { (__force u32)cpu_to_be32(0x41424344), "ABCD (0x41424344)", }, + }; - for (i = 0; i < ARRAY_SIZE(try); i++) - test(try[i].str, "%p4cc", &try[i].code); + fourcc_pointer_test(kunittest, try_cc, ARRAY_SIZE(try_cc), "%p4cc"); + fourcc_pointer_test(kunittest, try_ch, ARRAY_SIZE(try_ch), "%p4ch"); + fourcc_pointer_test(kunittest, try_cn, ARRAY_SIZE(try_cn), "%p4cn"); + fourcc_pointer_test(kunittest, try_cl, ARRAY_SIZE(try_cl), "%p4cl"); + fourcc_pointer_test(kunittest, try_cb, ARRAY_SIZE(try_cb), "%p4cb"); } static void From patchwork Tue Apr 8 06:49:11 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Aditya Garg X-Patchwork-Id: 14042235 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E05D3C3600C for ; Tue, 8 Apr 2025 06:49:29 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 42B9F10E1F7; Tue, 8 Apr 2025 06:49:29 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=live.com header.i=@live.com header.b="gb7eDIw4"; dkim-atps=neutral Received: from PNYPR01CU001.outbound.protection.outlook.com (mail-centralindiaazolkn19010009.outbound.protection.outlook.com [52.103.68.9]) by gabe.freedesktop.org (Postfix) with ESMTPS id 8596310E1F7 for ; Tue, 8 Apr 2025 06:49:27 +0000 (UTC) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=DkFOpcQnQDhyJTsFzsNBCw62aJNt67cqROleDh+jfABeXFU90UqGhlkvtGVmns7zRM+0nMFldombHq2sdljeXVv9cCX8s6hUDrfcKWS8CZFIyAGbZfogefX0qGIdlOTGr8UFsippeM4RQ0vrdb3wCaAQRVOdsJ98s/9Km9yJ8mWMkFZ9uqD+6ksyBt12NdKRgGDBpRxsE+HzlR4xf471hG8mwhjDfTFqQwEs++U1wIEyjmJCf39biJ+RT9aUHpULpytX7DWG0831+cP8npyWgzc37VqnhrIMbx7uF9v+Ho+qPC5UQbOWG/2+lblKnk1znttHI9omyYJ+nmWZH3T/wA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=PxCbrftVY4dmEBHU29MzLWAFfws2qVVZjTjU3bOQ4yU=; b=xcqpFyeNf2lwjz0k7D+xL78XTzFtNyXItM+QhZF5uP6Zzo2WK8LmekwW/LwX4YH2VB/fTjKliG8lVgTBmBDnSXvltaCvuO8vi7OPwSOE3lwfLihGrF5xvwYXlMdbU3mJyb1vEKgsqAbmb4bVn8p0tINfB31bzdgqoflZDefgaZSDqmlG1pcWmzmFD/KiLvfreySBI8QBJmQOydzVwV14dbTyT5umgyYcvvyMKoxkXUbp84NRK8LsLL3kkMsr0Vi0MA/sOpf7RiKm+OXfCgKZn4E2crWvUoUV/07W4nSjoZdjiBAAaOhjWMku/tGV65tOYDoBnRIYIIOUBylUrr1EqA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=live.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=PxCbrftVY4dmEBHU29MzLWAFfws2qVVZjTjU3bOQ4yU=; b=gb7eDIw4660Qh2CSzcoYWnxqfkFX+2AtAtT2hpqgEeIlAVl+GmVgWi3faWUOGS8HP8O4pg30M3BEkV8RzU+NCzoTlCT88kRT8nMXNMEjrtV6N6Du02+Uvm2DUvo1xdZoUGL8bbB9Fne3wSsXMU8w3IckvW9CikDkdJ+DUdALQA1hArEAyXSXOyvxKfWQDkEj8ABigqtR7cg+PdcGaHPPCC9bElmZWg1ey92Cz9ZABH5IPHEO1AUcSBF8tsQ77GUI5SNvT+OGgNw0a74/y/eLnHDMgmfhqCkBwF11+pASuJfrOs0pqJIzhG/Gea1fzq+o9gcM81b7rm0ATzCS/UfMcQ== Received: from PN3PR01MB9597.INDPRD01.PROD.OUTLOOK.COM (2603:1096:c01:f7::14) by MA0PR01MB7052.INDPRD01.PROD.OUTLOOK.COM (2603:1096:a01:5e::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8606.33; Tue, 8 Apr 2025 06:49:16 +0000 Received: from PN3PR01MB9597.INDPRD01.PROD.OUTLOOK.COM ([fe80::324:c085:10c8:4e77]) by PN3PR01MB9597.INDPRD01.PROD.OUTLOOK.COM ([fe80::324:c085:10c8:4e77%7]) with mapi id 15.20.8606.029; Tue, 8 Apr 2025 06:49:16 +0000 Message-ID: Date: Tue, 8 Apr 2025 12:19:11 +0530 User-Agent: Mozilla Thunderbird Subject: [PATCH v4 3/3] drm/appletbdrm: use %p4cl instead of %p4cc From: Aditya Garg To: alyssa@rosenzweig.io, Petr Mladek , Andy Shevchenko , Sven Peter , Thomas Zimmermann , Aun-Ali Zaidi , Maxime Ripard , airlied@redhat.com, Simona Vetter , Steven Rostedt , Rasmus Villemoes , Sergey Senozhatsky , Jonathan Corbet , Andrew Morton , apw@canonical.com, joe@perches.com, dwaipayanray1@gmail.com, lukas.bulwahn@gmail.com, Kees Cook , tamird@gmail.com Cc: Linux Kernel Mailing List , dri-devel@lists.freedesktop.org, linux-doc@vger.kernel.org, Hector Martin , Asahi Linux Mailing List References: Content-Language: en-US In-Reply-To: X-ClientProxiedBy: PN4PR01CA0034.INDPRD01.PROD.OUTLOOK.COM (2603:1096:c01:273::7) To PN3PR01MB9597.INDPRD01.PROD.OUTLOOK.COM (2603:1096:c01:f7::14) X-Microsoft-Original-Message-ID: MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PN3PR01MB9597:EE_|MA0PR01MB7052:EE_ X-MS-Office365-Filtering-Correlation-Id: 4da374a2-c1a5-48e3-9464-08dd76697aba X-Microsoft-Antispam: BCL:0; ARA:14566002|6090799003|5072599009|15080799006|7092599003|8060799006|19110799003|461199028|440099028|3412199025|41001999003|12091999003; X-Microsoft-Antispam-Message-Info: =?utf-8?q?X3O2yRDpJC+rnDAweqScDuZTtCUAm6J?= =?utf-8?q?6NUP1x/NMNxdjWsDiLAi0+d9m6yEK08el9rkwcPjnoiAWG9zZPYjrG883WeOWsrfO?= =?utf-8?q?1u31IWg/DbJLb0nrfbzO452lkGxMo3Ikgvx6GYOJD2mktqvCkJbphtspB4W4h4wYZ?= =?utf-8?q?DJn4eOka9tUz8qiJgEC2iG3rdnBCzUD2qvUGffkojEJdxkpECUFgUC5o8QCWDGQV5?= =?utf-8?q?LCi8wbLl1rEKIiu9nPjUm18G+wmU2Op6A4TOXeNF1rilSa10ldSn6jAvtwxrgFDQk?= =?utf-8?q?YdfV8naECzbsWutgXBWZlRVA1LGrmAYJ2dWxJCSKJayLYn87z5DcYMw0qYdc5ay1E?= =?utf-8?q?CFZIMOL1QpmgDbi2u6aDQuSA9W+BkuLeet8H8ANC5gffzhM8KZ8+yXKlGi29r/Lo5?= =?utf-8?q?ZeXtZELMIa+zObad8UPJrJ7a77UXBfWIGHm7qnSIRbBGZ2fsgHrYwN8SdOx6KeEfP?= =?utf-8?q?YngZKHamWMvUEtx3y1eSUu9Iun50vTCNXImwmy59mstsvqvR88AoFQutluAC97DsO?= =?utf-8?q?SvQJT2WTEgj4NZXp8/8RI53U+6dft19XH14BxIRq351s2j8xwN4LnPiiATEW2QnaP?= =?utf-8?q?POgxE17DjNDeWClxn2hQGS8I9pgJ1LHWGfGdtDPwjYW2+RQCje78nc08mOXdm/rMK?= =?utf-8?q?j5kvl+sIa3RKNdI32pjdAPEj6jxxr7okhcOV4iJEyTNpVxpyilCD0GlBcReVhGc/P?= =?utf-8?q?lzE4PlRe4VbaT6jOCtf6Sg2uyojPENMbv3N6HGw2zt+Wq1wsPiJRGC16yfx1EnvsS?= =?utf-8?q?lX+8UqhliEHR0fYkfSo/v5jQ4LSM1FfLIjQoV1Sr2MoCO8fN4hQFCf6wipq4LkgKj?= =?utf-8?q?uulK1DX1Q66wScUwWDHQ2GMRlrji90A7xMkpFJ51KL9NCHfGHfmMyGAhYYBOnniXB?= =?utf-8?q?8JxCb9Hltga4m0ZZMsNP+fcZmeS+1lNb6X2BHq1UlTgc6xZA/uvLvv8vXFB9FKMWz?= =?utf-8?q?hv6IZslvy+b1Q8rBS5kklABr5VjyLcABWT9e5JOShqf948v902uSWiTxEaZKU64Pd?= =?utf-8?q?3Z21o58h3ORhLSjbieY1bcx/knMpQqOdn1wXUbpkP1wiYwM9NM/plhNUNxsRxJQBs?= =?utf-8?q?l2NpIEGlfY/PqvaO3DSt+nkp44p6a1aa7rhfuaaQObCmF0jf2cAnDH0PvZkVCIln7?= =?utf-8?q?JlP/GSvV7Yfne9G?= X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?q?HOBt3VWPQ00jfRmStDSOrSB/h9bz?= =?utf-8?q?BYgGhDVTpxCweUUL225UDp+e3ZuNFo3Toi5xwLxLfe8EiLO4p6GjPzAoiFLeReWj7?= =?utf-8?q?aCbFeQsjHZQFvk8KC1j+0dPbRco+20esnt7eaFypcNyXoNoqVYRYO4NcBgJkpJX+a?= =?utf-8?q?3qp59VfDoaiFBbWX25M3xqsj9LcfRizJCigf2EMvaqNvc8AjD2ZvpZ0ek2kN5f4WD?= =?utf-8?q?ALhZ/aWFdQHfhYvUmtG9opzUQ+y1t5D/Ulse3elHMG2YBSOnaog6gRjGFGCLYNWYp?= =?utf-8?q?sZoWZCdxs/QwsCO0mBrAcXlD7BDXeqQNiMf39nKAL5ooE/LKZat9Ztfij1bIcKCCN?= =?utf-8?q?6D1LQgYfQeQUsqvrLlXVwOIvkfIHnnsnu+uiZ0nswpQBU3eMS87F/VzqCHQRi7IlP?= =?utf-8?q?Q0vvaEgh5unBFnT4oVOq/20mIM30b+Lz2l10O6Bieh2pNzIqV75v8q4NDJqCTduDe?= =?utf-8?q?gQP2sFd0Wv/cJ7LsQ+gUCN7JANjg7XLts3wSCR8VNQNR/Akb5SKB6L6VlG6L07ph4?= =?utf-8?q?rFfu1JtZOIOHpqY62HR2pO4HrSf6PfqeEgXEEbMuV+8ckjJ5DuXYSZU5jBI4ZKbhi?= =?utf-8?q?bT+C2UE50OjNDPPuimuBop+Tll4eJWOuEPlvOQR+rzm6JeD4e2ys2oW8RM+hbpU8f?= =?utf-8?q?eRoQ9FzWFlLRn5+J43Cqst4/vU8nxxALlP40knmt3QNqVtOyUtMRJpmWuDDeoIwjB?= =?utf-8?q?tZwaG+12Ux8s2l0nHsuvrMzNvYeo4kpyMOzpNxd1xV2PeZ4nCgjrqwxJ21cf4rAMG?= =?utf-8?q?g96YXTzyYvpgE3t8qEzKkPW0xPXT5lRIuVZr8C34pwh+KK1HAopIh07wGHFY6VmJT?= =?utf-8?q?jEtUH462mHO8j01Q7OtcWZg617fsTE0PuEem5NWXAKmFnI38iWJrHCa9Ru0WLt2wH?= =?utf-8?q?Z638lm5saeJC/lf1lbrkym/XlgOU870i7cWyYSnp0ZlLQ7dJHIKIu3miYjjU9eMUe?= =?utf-8?q?LdDSs2UF2LayRPmu2HtwRr19DF7bMmLqozkGir8ryo1l1ShVJMrUquOIvj5QfreCZ?= =?utf-8?q?1VAth/nCeRE0tYaUJ5Segor9hSyH2bYnw0/4o9bQqILU4m6I1x/Xc7zvoGxdZQzPu?= =?utf-8?q?9K+DqlN/E/UwUeUvwbTJmEwgn2ex5cVL48zwuHZ6qfdbgWewsSI5EuAqJSL9MQ4yA?= =?utf-8?q?w6/0TjfamuP/xjgoWUEFxQnPO8Jg/RoHL5QIBrw7rCBhKLBUPKSRva8a8TXfTyCvZ?= =?utf-8?q?EjwmhN5VPbzwKv+JL2u0liix1054IUg/t9IIkOy7geXPnImQg51oXkGQnFaGLPgpT?= =?utf-8?q?ovgrMYD6Z4ARIyiE?= X-OriginatorOrg: sct-15-20-7719-20-msonline-outlook-ae5c4.templateTenant X-MS-Exchange-CrossTenant-Network-Message-Id: 4da374a2-c1a5-48e3-9464-08dd76697aba X-MS-Exchange-CrossTenant-AuthSource: PN3PR01MB9597.INDPRD01.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Apr 2025 06:49:16.1201 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: MA0PR01MB7052 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" From: Aditya Garg Due to lack of a proper format specifier, %p4cc was being used instead of %p4cl for the purpose of printing FourCCs. But the disadvange was that they were being printed in a reverse order. %p4cl should correct this issue. Reviewed-by: Alyssa Rosenzweig Signed-off-by: Aditya Garg --- drivers/gpu/drm/tiny/appletbdrm.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/tiny/appletbdrm.c b/drivers/gpu/drm/tiny/appletbdrm.c index 703b9a41a..751b05753 100644 --- a/drivers/gpu/drm/tiny/appletbdrm.c +++ b/drivers/gpu/drm/tiny/appletbdrm.c @@ -212,7 +212,7 @@ static int appletbdrm_read_response(struct appletbdrm_device *adev, } if (response->msg != expected_response) { - drm_err(drm, "Unexpected response from device (expected %p4cc found %p4cc)\n", + drm_err(drm, "Unexpected response from device (expected %p4cl found %p4cl)\n", &expected_response, &response->msg); return -EIO; } @@ -286,7 +286,7 @@ static int appletbdrm_get_information(struct appletbdrm_device *adev) } if (pixel_format != APPLETBDRM_PIXEL_FORMAT) { - drm_err(drm, "Encountered unknown pixel format (%p4cc)\n", &pixel_format); + drm_err(drm, "Encountered unknown pixel format (%p4cl)\n", &pixel_format); ret = -EINVAL; goto free_info; }