From patchwork Tue Apr 8 07:17:38 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bartosz Golaszewski X-Patchwork-Id: 14042336 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E22CEC3600C for ; Tue, 8 Apr 2025 07:34:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:In-Reply-To:References:Message-Id :MIME-Version:Subject:Date:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=o/r+G6Kot2tAVanaGs0vt1/odX+gqI7loGUP287kmFo=; b=G5YMkajr10biKA lF0qthDemYMxe9KYfnMKSgaN2wbxNSgjJHnESgNJk7li9UsSpR5HBJZK8NRgxLuExwlVSaRediB5D N9w2wcrTKvgOaojnVWdz+rDs9iw1TApa5bd80TUYoUSkPl3Rg2pLr0jM99RE4qh28S8nALW4TmjpO OWwaB/Z1GN6jqXo5GaB1fowykksnXc0Nlw19Lms0ys8sW9BG257zmNrgOIyle/8Sn+BudaCiJ5vJy axmEavA69hnxxzJLXYoaRjbO+eMjd/Mxlw8Wm87IcEKS5sHSLlFKO1RJWX5r+LwQDheizoIiP7chk cE8RJpGnfFnLAGNVCUsw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.1 #2 (Red Hat Linux)) id 1u23T9-000000035IW-142o; Tue, 08 Apr 2025 07:34:03 +0000 Received: from mail-lf1-x12e.google.com ([2a00:1450:4864:20::12e]) by bombadil.infradead.org with esmtps (Exim 4.98.1 #2 (Red Hat Linux)) id 1u23Je-0000000331i-3sPe for linux-amlogic@lists.infradead.org; Tue, 08 Apr 2025 07:24:16 +0000 Received: by mail-lf1-x12e.google.com with SMTP id 2adb3069b0e04-5499c5d9691so5915763e87.2 for ; Tue, 08 Apr 2025 00:24:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bgdev-pl.20230601.gappssmtp.com; s=20230601; t=1744097053; x=1744701853; darn=lists.infradead.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=6bblWb/A3f8Vp31ZlZJvX8Y6uILdxWWSmqIBQEBD8XE=; b=TIkULY0G55+hSIJqzLnGL/KpEHN9Z6kuwe/zshQQpckDQxB20glI+QfBmR+GODCHMP g3iHSaJ5SbuBj6WciZZkqcky8xZA1Hd8kIy1PhiY3PnlmMsXX99k0zGal2PRU3pHtSsm 7rYupgUt4mEk8DfUjlEzdOdVpUbSSUXW6VEZfuB665gKy5btl98DpJ0uCHHWGree0urA DoeX6lSBQ8F/Tv6SuzpUbDuJFuXvh4aDgOsEl8rF/0hRfdlcUGnDomQgVdA6M9jYvWPi PIgajNpPbjo5Rvks7oFgPJJ00G7lKzGMcVYK0YL0+z1dQnYgqvZb34tXobnD0ZpL02G5 YB9g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1744097053; x=1744701853; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=6bblWb/A3f8Vp31ZlZJvX8Y6uILdxWWSmqIBQEBD8XE=; b=LzdK9UdsI/L9ObZ0HC4dGDyRuIbJ5+Ebht/BSWi6AGUXInOARvc47ydvdb7D+BmZ9l HMn3ec1jcIcWaTG51VmFgGrZgolWQuNBqF74vDYNpu+6MzxrhBL12Ie+jfkh6lP+Y3r8 kp59LRf1jUNK/MOO7nBcnjo3oaqNLj7Nog79SHGC/7tWNntbCkqiYWMLPbpPmHtnVplB AoMewS9SVJFV1dfelN+LGnw6WCvyyQ9BmcxG69dAoHO4jzAcexHw34PxEVP51oJlUlCK XosDgLWd2Pn9g/qb4xGVUTr4+RX48v7R2C6WOzPuygLddartFEUZjTE728Ne1090lCYW zbpw== X-Forwarded-Encrypted: i=1; AJvYcCXDAvRZE6bKs9KqEUoYuZxctoZYbzweoNTPixX0KBOCM989vVqhcFC2f+4haOMGR5IT2SO7N5689ZB/HruH@lists.infradead.org X-Gm-Message-State: AOJu0Yxf2nYUjuTbJYpBMca1tO3zQyvEM4VvjZ0a73KnEGxeMk2RdR8e pbkdf2pkpjNWbgmcUVnwm2ANfhCJTCkVLxx2r/2QIQ2ki7WM1oJ5e2BIz02h8jHARiZIyTkOJSa oZSQ= X-Gm-Gg: ASbGncvw2jiVpNZ9WmmFfzNWZ62WTkbpr3dYB3PP8KR0+2htnrHLY5omCrzzYJ0uMFm Yg1v2LX2x2OqPNhtGTAvvImuEX2UUKDzLxDTXHVFJH+MGlS6+WMB5BrPQbbZ1UYjXwoRriZaTU/ +EHtO1rapnN4TJsAnE943/NPOlr7o6JJt+TTq0HuA5v9/FJvPWupgNSKEAovNYKjDZCQp9NMC9E sUKC1ruUyGE1x7yTiBeDpj3uIP0L+WijTQ2o4qzz/vPoqeaPcVYKRk4WA9UNgghsKYpN3XjJYki Gilktk2oDpIC3p+mMZXxHHFEBpyZH0esoeQV3A== X-Google-Smtp-Source: AGHT+IHqIWuX5sWz9MJQWDS2IT6lTfF85m614lClDoVvdHMGky/Ix50ZxwKNqFgfUZCLhjcPg/Mzog== X-Received: by 2002:a05:6000:4313:b0:39c:2669:d786 with SMTP id ffacd0b85a97d-39cb359830amr12025582f8f.19.1744096669312; Tue, 08 Apr 2025 00:17:49 -0700 (PDT) Received: from [127.0.1.1] ([2a01:cb1d:dc:7e00:2adf:eaae:f6ea:1a73]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-39c3020d5d1sm14257694f8f.77.2025.04.08.00.17.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 08 Apr 2025 00:17:48 -0700 (PDT) From: Bartosz Golaszewski Date: Tue, 08 Apr 2025 09:17:38 +0200 Subject: [PATCH 01/10] pinctrl: at91-pio4: use new GPIO line value setter callbacks MIME-Version: 1.0 Message-Id: <20250408-gpiochip-set-rv-pinctrl-part1-v1-1-c9d521d7c8c7@linaro.org> References: <20250408-gpiochip-set-rv-pinctrl-part1-v1-0-c9d521d7c8c7@linaro.org> In-Reply-To: <20250408-gpiochip-set-rv-pinctrl-part1-v1-0-c9d521d7c8c7@linaro.org> To: Ludovic Desroches , Linus Walleij , Nicolas Ferre , Alexandre Belloni , Claudiu Beznea , Bartosz Golaszewski , Neil Armstrong , Kevin Hilman , Jerome Brunet , Martin Blumenstingl , Xianwei Zhao , Patrick Rudolph Cc: linux-arm-kernel@lists.infradead.org, linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, linux-amlogic@lists.infradead.org, Bartosz Golaszewski X-Mailer: b4 0.14.1 X-Developer-Signature: v=1; a=openpgp-sha256; l=2256; i=bartosz.golaszewski@linaro.org; h=from:subject:message-id; bh=6oXQdDn+JiYI7kPrR9MR4Ulr8BlxDaIdgOQst72f6aI=; b=owEBbQKS/ZANAwAKARGnLqAUcddyAcsmYgBn9M2ZS1CVSr+OpPpLt+g73dsnxK7Cn+5jOBkEm S4RhLYFpI2JAjMEAAEKAB0WIQQWnetsC8PEYBPSx58Rpy6gFHHXcgUCZ/TNmQAKCRARpy6gFHHX ckshEADgmKAecLNRDwbY5cLUNohPOOEtx7wPD6IeqZgsOFSImxcR1AYiTklwNvcEyx4WnHhAmzb oG3lzRmS0xFVCzQi9mX4uHbuIJXP1MxN2ddsgnB6lg1CEj1b4qv6DNNxxtBQ0ipnDwRNuawQcwH aeYqABy61n2vfrZJBJVOSi9TQAkdSEJwgvanfueiX/vJnvVKET+cxjJqHSgRCxlPdre/sm0kKMI CCPKVMovBcpT7OOGP0j4+p0kCB6NCqevlaTewuoV/h4tWjYpF6SH9gESREPjsk7R213eO+DWr4n UFTfB1ByxQw7vd5agHmcng2yl1ZV7SUNOsT5kf6nSoI4cvkeO4ons+t63tePlkRUDoQumIQzhga N/mIkjV7W2xjVvZrcZEGS63D38/fzY4sA7sVuWaWgZwWrCrfhPajPxotxjxOsvTWXSWJkfh6ixI f2yLdNBgi9wSYNat2UoYPTLeRh3lzFjphWxPajFb+ZQczTx/bXcjtpDXNQewa78BXhZ30rEIrF/ M3gIErsXpEjyv3RmSJV7CGPdxfLwaxjHq9SZNfNqeeYValUtoqirxITK0jSaQrmdUBMmUx/IqJs XwWZMdG3msE++lZ6NvgjhT2WFVsie3VhFAI2l/WdsxXhiwXItFE0r0m2V8VtqyUKn2/YCh5ew2+ nnZya7p1LkYH6fg== X-Developer-Key: i=bartosz.golaszewski@linaro.org; a=openpgp; fpr=169DEB6C0BC3C46013D2C79F11A72EA01471D772 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250408_002414_955720_971E6EB7 X-CRM114-Status: GOOD ( 12.43 ) X-BeenThere: linux-amlogic@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-amlogic" Errors-To: linux-amlogic-bounces+linux-amlogic=archiver.kernel.org@lists.infradead.org From: Bartosz Golaszewski struct gpio_chip now has callbacks for setting line values that return an integer, allowing to indicate failures. Convert the driver to using them. Signed-off-by: Bartosz Golaszewski Reviewed-by: Claudiu Beznea --- drivers/pinctrl/pinctrl-at91-pio4.c | 14 +++++++++----- 1 file changed, 9 insertions(+), 5 deletions(-) diff --git a/drivers/pinctrl/pinctrl-at91-pio4.c b/drivers/pinctrl/pinctrl-at91-pio4.c index 8b01d312305a..5db839fa9b3f 100644 --- a/drivers/pinctrl/pinctrl-at91-pio4.c +++ b/drivers/pinctrl/pinctrl-at91-pio4.c @@ -390,7 +390,7 @@ static int atmel_gpio_direction_output(struct gpio_chip *chip, return 0; } -static void atmel_gpio_set(struct gpio_chip *chip, unsigned int offset, int val) +static int atmel_gpio_set(struct gpio_chip *chip, unsigned int offset, int val) { struct atmel_pioctrl *atmel_pioctrl = gpiochip_get_data(chip); struct atmel_pin *pin = atmel_pioctrl->pins[offset]; @@ -398,10 +398,12 @@ static void atmel_gpio_set(struct gpio_chip *chip, unsigned int offset, int val) atmel_gpio_write(atmel_pioctrl, pin->bank, val ? ATMEL_PIO_SODR : ATMEL_PIO_CODR, BIT(pin->line)); + + return 0; } -static void atmel_gpio_set_multiple(struct gpio_chip *chip, unsigned long *mask, - unsigned long *bits) +static int atmel_gpio_set_multiple(struct gpio_chip *chip, unsigned long *mask, + unsigned long *bits) { struct atmel_pioctrl *atmel_pioctrl = gpiochip_get_data(chip); unsigned int bank; @@ -431,6 +433,8 @@ static void atmel_gpio_set_multiple(struct gpio_chip *chip, unsigned long *mask, bits[word] >>= ATMEL_PIO_NPINS_PER_BANK; #endif } + + return 0; } static struct gpio_chip atmel_gpio_chip = { @@ -438,8 +442,8 @@ static struct gpio_chip atmel_gpio_chip = { .get = atmel_gpio_get, .get_multiple = atmel_gpio_get_multiple, .direction_output = atmel_gpio_direction_output, - .set = atmel_gpio_set, - .set_multiple = atmel_gpio_set_multiple, + .set_rv = atmel_gpio_set, + .set_multiple_rv = atmel_gpio_set_multiple, .to_irq = atmel_gpio_to_irq, .base = 0, }; From patchwork Tue Apr 8 07:17:39 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bartosz Golaszewski X-Patchwork-Id: 14042292 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A70F5C3600C for ; Tue, 8 Apr 2025 07:21:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:In-Reply-To:References:Message-Id :MIME-Version:Subject:Date:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=K4HPzpStZ+hBRN9D090DW/8UjF33sKgqPYrJrtql3x0=; b=hVrqF+afcnqIN8 icrmiBw0iY9cURgtfXmlldNo7T8q9RWHTcnETh7IpEGMXWQW5slz7isSJOrpa8d+LWbMIdz+93lUN WDeEfFYZ02gf5RRB+NmDfET/86KwLlfUkDM/P3aJBkwVOxYqXofBOZEa3d4Wv/57xs/FHLKfuwP/U hga24YDIZT71/T+hiHJIiBMDZzJaIxm4Lx6gKKPeQDCcJXSW6BlQBhGwPQfgBy6lo+oP6nohN+XmD glOycsNeF5bBObdYdawr56TSY0PsTsDA1QlsgHmO+b5viM3uAqZKqfDAApW+OtOAnN+Gstpbsb/D0 UlmziEoM+PxpKggU5amw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.1 #2 (Red Hat Linux)) id 1u23Gz-000000032Nz-1bLk; Tue, 08 Apr 2025 07:21:29 +0000 Received: from mail-wr1-x42c.google.com ([2a00:1450:4864:20::42c]) by bombadil.infradead.org with esmtps (Exim 4.98.1 #2 (Red Hat Linux)) id 1u23DV-000000031e6-3kgq for linux-amlogic@lists.infradead.org; Tue, 08 Apr 2025 07:17:55 +0000 Received: by mail-wr1-x42c.google.com with SMTP id ffacd0b85a97d-39c1ef4acf2so3061470f8f.0 for ; Tue, 08 Apr 2025 00:17:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bgdev-pl.20230601.gappssmtp.com; s=20230601; t=1744096672; x=1744701472; darn=lists.infradead.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=KHbdZ8I5zBJbhRifEOkTpCnTw3e9jVPzpvQJpqCzg30=; b=w0tMD1QQ3CrVrwot2hVqwf+UUBr2I0A83Sh/N0n0ST6U4mGmYjWOvqLYiC7l8iJUY2 Rt4/kqR4ga/a4koGK7AHaff77tDUGzSdqf7WbTcLA2JXZdWMzLjmpGiZKbkCoUCK4KHN +0YRu+65pDbOW3LcsaYqBPeEfN1aPKlGnpGKIRrbIzFHpmTibNJ6k0r/D+vuCmq4ypKn zKKMcSfYXBA2daQ5YKdZSmi1V1LhLYhDiyHY/KGMvVcL0TDek877uyo81QrSrkT+fuBA pWdGbmDEW3qIIvmyRPHm7Re/pGYphcx5oGZQb1UsOLTlX5KcLhOL1enivfIN+pODeCmO ZolQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1744096672; x=1744701472; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=KHbdZ8I5zBJbhRifEOkTpCnTw3e9jVPzpvQJpqCzg30=; b=TRbY175LaQgqe5zuuphLzdbTYK0MJ6Vwme6/lfb95KCGn9O1E6XnyahrxKozBZIx4z Ur0mpV04uJNQ3wp/xucEAymZGRlj4OB539pOV9wla3p0mh+HmbVhzY1erdawQz035qWb DxCBuMbCyMHdTDDCMGaKRetiU+xy9EN3El/ozaNmqtuU1i3AxAVjA9oVU5S7zLTuL76p 14TqT1wUBMz9NxGyXuy2AHJxUyEyxy7Mj2GbEFIFKUyUuHomWA/OuFqhaNJKA7AoYYEu qtyk2iDhGxlTt8gwRb75XWZNNmOF+R4Wt3FD2Yp17L2QIC5yK9mjzmQ3EMYP2O2buS0E 5QMw== X-Forwarded-Encrypted: i=1; AJvYcCW1Ob4h8T9uGBQ3ENNHH0haiErQ6J2QMGmMz8n6v78i4i/g1HojU6u1TVXHzMgBOPBvDM4gYidrKY5Lk7L5@lists.infradead.org X-Gm-Message-State: AOJu0YzCvoMfnx/VM2wAImHB43/ORx9DPQEAX+CcE5iCDSLexrBaHT/7 KQ5szmzvEWiXEfuTP+DCTEcK+tV0NqFh3Q/sjkcbLSs696Wa33v+e2/TUYO5614= X-Gm-Gg: ASbGncvY/z1a4LLl8kvUqU62yttEs03EUR+m+pY+N+PleukiS1tE2w2X6w2CJHwfzUe DvMIZYQrKbB/xK8fr+E6hTqPCnwrndJwJG1DHrcarJ3jxbd8428wlPPHlNAnmKsuLQBOcmEgWTO drSaYxoK+JMqahOGf1cilxI/Mi65gsz3Hokf5O/dAksgrLNCqr0EcTqqxbIiDnVtGJ4EfQWSBTh 17oGYDBEeq+PQO5HfYYsAm83FMjVrIq1lyPDlWEuTOp3qQbBesI8Mk9tbhab4iOynPyHOf6GCc4 oJ/3Zw4n7QQcgPbwRLAV7+U0RL2A9uN9QsxUug== X-Google-Smtp-Source: AGHT+IG66JLNMA6/+F4yvPGqakGWzMF6ZtCNetVsbjFv2aPqMbejsIAN56v674i7htexv9OZa2w1UA== X-Received: by 2002:a5d:5f96:0:b0:390:f2f1:2a17 with SMTP id ffacd0b85a97d-39d1466229bmr14181138f8f.53.1744096672155; Tue, 08 Apr 2025 00:17:52 -0700 (PDT) Received: from [127.0.1.1] ([2a01:cb1d:dc:7e00:2adf:eaae:f6ea:1a73]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-39c3020d5d1sm14257694f8f.77.2025.04.08.00.17.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 08 Apr 2025 00:17:51 -0700 (PDT) From: Bartosz Golaszewski Date: Tue, 08 Apr 2025 09:17:39 +0200 Subject: [PATCH 02/10] pinctrl: rk805: use new GPIO line value setter callbacks MIME-Version: 1.0 Message-Id: <20250408-gpiochip-set-rv-pinctrl-part1-v1-2-c9d521d7c8c7@linaro.org> References: <20250408-gpiochip-set-rv-pinctrl-part1-v1-0-c9d521d7c8c7@linaro.org> In-Reply-To: <20250408-gpiochip-set-rv-pinctrl-part1-v1-0-c9d521d7c8c7@linaro.org> To: Ludovic Desroches , Linus Walleij , Nicolas Ferre , Alexandre Belloni , Claudiu Beznea , Bartosz Golaszewski , Neil Armstrong , Kevin Hilman , Jerome Brunet , Martin Blumenstingl , Xianwei Zhao , Patrick Rudolph Cc: linux-arm-kernel@lists.infradead.org, linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, linux-amlogic@lists.infradead.org, Bartosz Golaszewski X-Mailer: b4 0.14.1 X-Developer-Signature: v=1; a=openpgp-sha256; l=2092; i=bartosz.golaszewski@linaro.org; h=from:subject:message-id; bh=sUTrzWuOo7PVik1QzFjSyEGMbbgvgdGB1epc3LKWdY4=; b=owEBbQKS/ZANAwAKARGnLqAUcddyAcsmYgBn9M2ZtGmml6ycwEzk3KhRs/YW0AQqsaUfB686c +V6uDVoAR+JAjMEAAEKAB0WIQQWnetsC8PEYBPSx58Rpy6gFHHXcgUCZ/TNmQAKCRARpy6gFHHX cttsEACbtqoZ/RYzP/rSItzAm6RyIKDSI67qmiaM3eZO+Qwuz4UvIvJ/GL6pV94KgneXWwmwPKo P7ywI2W0szbMsr9K+DM7p2BGeLSS8pyImHtM3ITgmaayPUvVb3Y7MrTj+v9MYNRnjYl5sGRlIjK 1EmAEesdJqsGiDikg07oXYnqGVad+4NJ2zxDtQ5n7tB3ShEJusRuIFA35sixjIGRTR4Nr+0DmSH ARiPMtTFkfjtgsXBEDCv0PRzyup4961wgfvFgQ7GRwqsXxRacjsZAEmoYduAjZjqdJ1dny8C8i/ Evwq8RUqfgTcjvwjmVDu3klH9BEGNcZX9frolFeag0oRT7/RZHWm0ZxaKaU4rlH/E0Io6pd73nU sw0vsjb8AZuD4il5knSflEdQN3RuRoPp/QdnpHdPim0zwLKdIVMyzNu6p2O0tRQGmQi3tJnf6+/ +iwIO4FrFQOgX9vh4VdG91Tuu+BBuoCRJMWkbcnWF5dZaX6tREBxwtDhCsxPH58+4G5NQgX0XN+ IJgHJLn/R/KYnp/l1eWewkxcLXRRPGbcaEUJ5lTHuvd6fGpdv0Af4X3rK0WZJ6UwBJw5u6pQLY5 8YdLZCYvmvA8jSXhIocYAmemyaGKAMW/JnBi6mtMkH5dOwmpnp+SvX5iwwf+9a5m+kDEg4dWidg WpA2txNtQ9d547g== X-Developer-Key: i=bartosz.golaszewski@linaro.org; a=openpgp; fpr=169DEB6C0BC3C46013D2C79F11A72EA01471D772 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250408_001753_949123_1C3CFD34 X-CRM114-Status: GOOD ( 11.20 ) X-BeenThere: linux-amlogic@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-amlogic" Errors-To: linux-amlogic-bounces+linux-amlogic=archiver.kernel.org@lists.infradead.org From: Bartosz Golaszewski struct gpio_chip now has callbacks for setting line values that return an integer, allowing to indicate failures. Convert the driver to using them. Signed-off-by: Bartosz Golaszewski --- drivers/pinctrl/pinctrl-rk805.c | 26 +++++++++++++------------- 1 file changed, 13 insertions(+), 13 deletions(-) diff --git a/drivers/pinctrl/pinctrl-rk805.c b/drivers/pinctrl/pinctrl-rk805.c index c42f1bf93404..fc0e330b1d11 100644 --- a/drivers/pinctrl/pinctrl-rk805.c +++ b/drivers/pinctrl/pinctrl-rk805.c @@ -325,26 +325,26 @@ static int rk805_gpio_get(struct gpio_chip *chip, unsigned int offset) return !!(val & pci->pin_cfg[offset].val_msk); } -static void rk805_gpio_set(struct gpio_chip *chip, - unsigned int offset, - int value) +static int rk805_gpio_set(struct gpio_chip *chip, unsigned int offset, + int value) { struct rk805_pctrl_info *pci = gpiochip_get_data(chip); - int ret; - ret = regmap_update_bits(pci->rk808->regmap, - pci->pin_cfg[offset].reg, - pci->pin_cfg[offset].val_msk, - value ? pci->pin_cfg[offset].val_msk : 0); - if (ret) - dev_err(pci->dev, "set gpio%d value %d failed\n", - offset, value); + return regmap_update_bits(pci->rk808->regmap, + pci->pin_cfg[offset].reg, + pci->pin_cfg[offset].val_msk, + value ? pci->pin_cfg[offset].val_msk : 0); } static int rk805_gpio_direction_output(struct gpio_chip *chip, unsigned int offset, int value) { - rk805_gpio_set(chip, offset, value); + int ret; + + ret = rk805_gpio_set(chip, offset, value); + if (ret) + return ret; + return pinctrl_gpio_direction_output(chip, offset); } @@ -378,7 +378,7 @@ static const struct gpio_chip rk805_gpio_chip = { .free = gpiochip_generic_free, .get_direction = rk805_gpio_get_direction, .get = rk805_gpio_get, - .set = rk805_gpio_set, + .set_rv = rk805_gpio_set, .direction_input = pinctrl_gpio_direction_input, .direction_output = rk805_gpio_direction_output, .can_sleep = true, From patchwork Tue Apr 8 07:17:40 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bartosz Golaszewski X-Patchwork-Id: 14042293 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D719DC369A4 for ; Tue, 8 Apr 2025 07:21:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:In-Reply-To:References:Message-Id :MIME-Version:Subject:Date:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=lRW/HW8tIuuOmph9+Gbg4ApY29rrYn/BemXY9k+e5Sg=; b=BOdyvDNsZYzsDO /j1Z1XgtLvrDpNHOaaIWMRYsIZ7+BuUWUDrLueEVe8TxBJOwcDdivjMvK/MlngL+hPYfdsfZHD+hl n+1ds1zfGtkTsZaMHIQUR/kalnC7CuyZPIz9MVrodyV1a7ZCh80NG2oyAw9BqvctUKdRvl6WIqm61 +NNwplx5tAMZ+hH+EUX2qqYIdYzui34iLvpJqtfSPguzp5S6l6skouqj4mh4B4ejbFttfp1Gx8OxS /VvdHxR4JtWptM+hxCFNqsvh/W9s7JBbU6o4zLXcx7G36c7dfAvP47JlwXVZEiWW3evMXU0NMDKFw 1g6BO2YRRi+s2oQByRVA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.1 #2 (Red Hat Linux)) id 1u23Gz-000000032OL-32zk; Tue, 08 Apr 2025 07:21:29 +0000 Received: from mail-wm1-x32b.google.com ([2a00:1450:4864:20::32b]) by bombadil.infradead.org with esmtps (Exim 4.98.1 #2 (Red Hat Linux)) id 1u23DW-000000031eH-3bBT for linux-amlogic@lists.infradead.org; Tue, 08 Apr 2025 07:17:55 +0000 Received: by mail-wm1-x32b.google.com with SMTP id 5b1f17b1804b1-43cf680d351so36280015e9.0 for ; Tue, 08 Apr 2025 00:17:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bgdev-pl.20230601.gappssmtp.com; s=20230601; t=1744096673; x=1744701473; darn=lists.infradead.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=kgKpi2eMQzrwoQvXzcbqAzy5xxQOgpVGvK0+n6zqybM=; b=WJww3g8PjrYpTaphVdOKHc2Nh+nHI+oACWaNsBvm7Y8368n4bE1nmqz25mkgitMVrQ 9yd4i1HdD017vEtzjOe73UjN7pPUax61onolN7YGmUzSTtqwCDZgEqJ+IEyKt+fIa/1U yK7ASpQK2SFrM7WF6tYz2Jcxv+GYM+qkL+m+Dfd3C3+4yHI1Z8D3Z5nbroLVtRQtlG8V oRkL/qJFGG+TV2ACQlmB96tm6JyAAJtVluz3H7uD8KN49mv1QUZwRTkDBwsk3dHXt/CZ I7+GNC8Tfclofi/kfGZLDrtgf0Cy5QOCVX9MehN8F07B6dnFX/ceAZfd/GWrkK4TmdtD iOzA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1744096673; x=1744701473; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=kgKpi2eMQzrwoQvXzcbqAzy5xxQOgpVGvK0+n6zqybM=; b=Lh01UbRu+NzXq+BS6zitGmad7SWIL/w10nSc65h8XanlTdlA366QDTFWjSLhZ/ge2L 9OMxdcO9X/N/8n0+DI7pq9lPcThFDKELHxhoAExIKE07zMwAjGALH3quZltAdTfFJd5W Of1kCrpp6Joimtu/Exh/zQCezk0CJK75WBL/NooSEE89Zc9xQKd7OVJJdqp15IS4j0qP yrgZpAboYdNrbFsNJyi5CQwtsd5Euq2wSIGbhDUqah6jtDeeXtQL94+zCwePptXkKKL3 yU97wpy841PNwnU+4VeVH0JwTTsLnMdqewh/kKE4RDoqV0S6GDhRpoTFIJarZdufiNA2 uorQ== X-Forwarded-Encrypted: i=1; AJvYcCUxZqb0A7MFU4w2bL+kAzgV6+wTLHuix3d8uN+HoU1LfWe7XJnz43PAyNnid5ujqAt/GPE9MZDXyMGTB4eL@lists.infradead.org X-Gm-Message-State: AOJu0YxGVtTGKYWyOIQvjoudl2M3wn6Fx/LES6WIS8NMyvVkm1cBthnl Hw1iVKQxDZ5WRmBnP8iIi+VWFXgEl0P4MPYWq1SAqQkHhzLOozIiV4K9EVpMca8= X-Gm-Gg: ASbGncuBwU7xnADcRpUjMjclL9cAPznhWDPyAXB7dlr6FH3yu4LYRZvy9jRi3ZXNOda fay7aF1P2RbNzc0/yRNjln/T6wgUXmw53NdoTEFqF+sxSGNZ2X3KWHCX5SK/47N34SSOJd1y+GR 60CFq3InDE3d5lmkbLHuKDOn32KcJX73KDyoOweO6p6setuFk8YC6Z0MPPQB5H77DZOPgV3K8Tv DrA9ccMYVXErJ93++4QC1CfZRjGiLiJHMKw3G3EPTJqTTlZIuRX4ZRWDNEUhuJueg1Q93OsBZ2h He3/3iBtPQ+DEFz2zwd7y0mdbTzGAneZB8Arfw== X-Google-Smtp-Source: AGHT+IFIDoEgtgjZmRm76oLe4qBixaJVFcxIWBxSgP9eQc/+muRPjB5OZ4DhcXqFSFfMWbn8IPCLNw== X-Received: by 2002:a05:6000:2484:b0:38d:ae1e:2f3c with SMTP id ffacd0b85a97d-39d820eb1f9mr1593525f8f.25.1744096673169; Tue, 08 Apr 2025 00:17:53 -0700 (PDT) Received: from [127.0.1.1] ([2a01:cb1d:dc:7e00:2adf:eaae:f6ea:1a73]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-39c3020d5d1sm14257694f8f.77.2025.04.08.00.17.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 08 Apr 2025 00:17:52 -0700 (PDT) From: Bartosz Golaszewski Date: Tue, 08 Apr 2025 09:17:40 +0200 Subject: [PATCH 03/10] pinctrl: abx500: enable building modules with COMPILE_TEST=y MIME-Version: 1.0 Message-Id: <20250408-gpiochip-set-rv-pinctrl-part1-v1-3-c9d521d7c8c7@linaro.org> References: <20250408-gpiochip-set-rv-pinctrl-part1-v1-0-c9d521d7c8c7@linaro.org> In-Reply-To: <20250408-gpiochip-set-rv-pinctrl-part1-v1-0-c9d521d7c8c7@linaro.org> To: Ludovic Desroches , Linus Walleij , Nicolas Ferre , Alexandre Belloni , Claudiu Beznea , Bartosz Golaszewski , Neil Armstrong , Kevin Hilman , Jerome Brunet , Martin Blumenstingl , Xianwei Zhao , Patrick Rudolph Cc: linux-arm-kernel@lists.infradead.org, linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, linux-amlogic@lists.infradead.org, Bartosz Golaszewski X-Mailer: b4 0.14.1 X-Developer-Signature: v=1; a=openpgp-sha256; l=1197; i=bartosz.golaszewski@linaro.org; h=from:subject:message-id; bh=7gT59a+ieEBoRyUfHtp8d/jvYbZrPQXR8M3Rkb54480=; b=owEBbQKS/ZANAwAKARGnLqAUcddyAcsmYgBn9M2Z62HjgrUOk13umM6zCKtt5wsF8hMyPqGii +FbeYzWZu2JAjMEAAEKAB0WIQQWnetsC8PEYBPSx58Rpy6gFHHXcgUCZ/TNmQAKCRARpy6gFHHX cr+9D/4pVK6myjhrhbvOnoR4PHJ367IIWOAh/Zh8cc762qftCq98AjRSHWjpi3KMWk+T1SoewR6 yd9FAaYyN5ggStwHN8ifchYiv+JA8sO+i6UuSIOQUVQzey/SsbW1SeTgmZ3o/GsdKPG/HjoxejZ M1kbfrXMCRWGU5zTxGwLAZl126dUhXDTKScOqGDG6ZLFctZH0MSBmu4Nu7uWpRWQK3R+Xr6OGfa +BSLVhz77RThlP5bmwNejIlKFQNdlTKOpKLwZ4d0FEN5QJPa8Epbb+Vvkputkda+ERCCbCEvjf9 8ZSHC0SCNCcLyorbyOA6rgYWiPo+GZMHSqoF/Pl1OFZzp2mCtAXPyQrKJ2wv0I5KYUJSLuNstbX pAA8HtMWVKN2o8VTfFf0kYbEFAo7BM5D+3B86ctemR78XtjX9vA/33qPRw6qbRuWNjF2jLMxwGg 7sr3CLWFwcyqt8oNdhyjEWmfnIO2z+BYPCo7Btr52pKon7rbGIyJAAG4gxmUqgjRO/PJ06aCPjV erKdtcafZvxLT9Mf2jX/+expNbOTo5PKgOvekHmSlI2xdATbBZgMQPxFNUNJVlXLL3UGV8fR/Zh +ApMwVs12NjHuf/sT9aZDxPH2zbKJvARpXLKynmGD52HIn+u06LPHHbZH2+obwAez7+Tde1ydSJ G1AuErL37JcATMA== X-Developer-Key: i=bartosz.golaszewski@linaro.org; a=openpgp; fpr=169DEB6C0BC3C46013D2C79F11A72EA01471D772 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250408_001754_901529_E2C07461 X-CRM114-Status: UNSURE ( 9.43 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-amlogic@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-amlogic" Errors-To: linux-amlogic-bounces+linux-amlogic=archiver.kernel.org@lists.infradead.org From: Bartosz Golaszewski Increase the build coverage by enabling the abx500 modules with COMPILE_TEST=y. Signed-off-by: Bartosz Golaszewski --- drivers/pinctrl/nomadik/Kconfig | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/pinctrl/nomadik/Kconfig b/drivers/pinctrl/nomadik/Kconfig index aafecf348670..2c1f8a4f5d24 100644 --- a/drivers/pinctrl/nomadik/Kconfig +++ b/drivers/pinctrl/nomadik/Kconfig @@ -1,20 +1,20 @@ # SPDX-License-Identifier: GPL-2.0-only -if ARCH_U8500 +if (ARCH_U8500 || COMPILE_TEST) config PINCTRL_ABX500 bool "ST-Ericsson ABx500 family Mixed Signal Circuit gpio functions" - depends on AB8500_CORE + depends on AB8500_CORE || COMPILE_TEST select GENERIC_PINCONF help Select this to enable the ABx500 family IC GPIO driver config PINCTRL_AB8500 bool "AB8500 pin controller driver" - depends on PINCTRL_ABX500 && ARCH_U8500 + depends on PINCTRL_ABX500 && (ARCH_U8500 || COMPILE_TEST) config PINCTRL_AB8505 bool "AB8505 pin controller driver" - depends on PINCTRL_ABX500 && ARCH_U8500 + depends on PINCTRL_ABX500 && (ARCH_U8500 || COMPILE_TEST) endif From patchwork Tue Apr 8 07:17:41 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bartosz Golaszewski X-Patchwork-Id: 14042294 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id F3A9AC3600C for ; Tue, 8 Apr 2025 07:23:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:In-Reply-To:References:Message-Id :MIME-Version:Subject:Date:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=QIZ8MAWji6opuSbs6/bbQQUTydmxg8NogD64PBJWuOk=; b=1p51Q0N5URvj+I D5RFerFDhgchvp/edsL7kCSa5+zo/octAgqLYG8dCaOfMJN/JBu3ca9gmHmY2Yn51Jg/gq8prlysE fTxGCJmPxaa2Nbm29QnoE1r9kmvGrGn7gf9xKXza5mElQJ6+Tioga1P01RcAaqihdgdB/eTeCDnb3 WF8XnxrUY+RZWSmBKfTmAfWLGSd2R2rpXEQKtp7AWkakXxS7/pe5VZUV3fkcAvqRTn/lr8XgIogwo lrUpY3Y6GyEAeJrmQ2SwSuNY8cz6Q18a0RcxsY5jyYYfRaH+x1m7wcSzwPq1697UOFjk2XDQDG0Zc xKHUgEQRoyOg/jd5jqpQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.1 #2 (Red Hat Linux)) id 1u23Ii-000000032pL-3Szc; Tue, 08 Apr 2025 07:23:16 +0000 Received: from mail-wm1-x32b.google.com ([2a00:1450:4864:20::32b]) by bombadil.infradead.org with esmtps (Exim 4.98.1 #2 (Red Hat Linux)) id 1u23DX-000000031eu-1tDg for linux-amlogic@lists.infradead.org; Tue, 08 Apr 2025 07:17:56 +0000 Received: by mail-wm1-x32b.google.com with SMTP id 5b1f17b1804b1-43cf628cb14so40734255e9.1 for ; Tue, 08 Apr 2025 00:17:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bgdev-pl.20230601.gappssmtp.com; s=20230601; t=1744096674; x=1744701474; darn=lists.infradead.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=oinSzm+bMahZJYAUWu862y4MPTAeTqz9q0Fj/pnJpP0=; b=igWbW1iAw3FYGURemyDT7qynBLbtmjtoSINC03Nh+DjJGxvseSSf7NTW/c1fvdHdnJ ZTf02CsSqCooKZnR0JHE9UegJVmok/kAfXagFZNhQ9FV/7RO20a6jA78c2fCQ/6mXKVW BxyUagxlO/EQ8yIVHzjOyCCOOWRmZoapcd+P+/6/XxONphk9k2N1mByFWb+0pEL21QbT hjj4TAOUSPyUlp+QUxgABZRrM9TK6Jua+JgSTCdqJwGwS46D6v52NreJtI6T8op7k4Pi FHNreF4K51uwImA+fWwVsV//edGwqgOtVhDjGGhMyIqXWs70MhnwHOBdSgJ9K6OIoKhK OGCA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1744096674; x=1744701474; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=oinSzm+bMahZJYAUWu862y4MPTAeTqz9q0Fj/pnJpP0=; b=Zh3h2NyQXy9BN6Zm8dbrXOqLGkTAN8RaSC1Ub/lwzVjsdsk4cXP8oTy0UdxCVmnVFa ArTs0AnUlHNBVgO+uxo7+VdPK6lFAwDEIv1z7VYV99ew5Hi5vNp1ZQPSdsis1CEoUxiP kC7vRLmtAMzWhRKjy46EifGyIo0QmcXsQDE1NDDzC53SVf5Ln6O+LsrJdE1FOYi0KnAp 0cKqMJAaem/MhNDNOLTLKv30EmOIMZaYqynQvii7Nav3MLkQG4l7bxTOIgGHc4hn4ExS 3khvzEt/flR9hGmz52sfRitm2Y1Cpq/WVRLezJT/NihlDzj5tsXvrQteF/f+VNVFgTpZ iYoA== X-Forwarded-Encrypted: i=1; AJvYcCXH7WRZYyUuV1PvHH8QWH1CPOgzHy1u3jfzVlaVFDbOPcTRU4UUeAwPMOO9IwnNOfxeUMZRivo9FiDKyBzm@lists.infradead.org X-Gm-Message-State: AOJu0YwZeqqvPa8idOcTg4SA0xQnB3myXFQwbig43zb7jdKY29g3xSJM lhBL+QqFWiV4gjzudkZw/j3KNrGIFYk4BkNO0vt6E35IGrqo7BipZP4pEC4/Jqk= X-Gm-Gg: ASbGnctRUhWwDZFYc35qyLhIUxQasALQ1/xw8fyPJC6dRBs6JwB7/ZEn3dxjvDye+yf e4/+LWn0lQd5g/9wejtYG9zdztvRzDeRt4lqWocyR4GsEtbKDbVZZgFwV8EfX63Dh5FkDgkr9pV c7MWZUXS3uljK0CkT+QCNI4yP6RiUTyrOkONujgKuVs2JuA1dbAJOgipALm/ak35TNnhA8b6xXp 4R8cH/beRRnJQKZWUB5GPU0kO6HL4Qd/ou6IgB6/rTScSpz5Oocwb6SidPzvs11yDplm0z97bXp 4m4B8UkmCQM+PCtRsGlJlT9tyPDGARTb0580sQ== X-Google-Smtp-Source: AGHT+IHrjnllwruX19f7P/GJ6q4XihZ8rfCQK9jOXGEEswSMIiSKCV482ACd4hwI02zSsicA1Cwvhg== X-Received: by 2002:a05:6000:2289:b0:39c:30f7:a599 with SMTP id ffacd0b85a97d-39d820f7f4emr1793514f8f.18.1744096674126; Tue, 08 Apr 2025 00:17:54 -0700 (PDT) Received: from [127.0.1.1] ([2a01:cb1d:dc:7e00:2adf:eaae:f6ea:1a73]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-39c3020d5d1sm14257694f8f.77.2025.04.08.00.17.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 08 Apr 2025 00:17:53 -0700 (PDT) From: Bartosz Golaszewski Date: Tue, 08 Apr 2025 09:17:41 +0200 Subject: [PATCH 04/10] pinctrl: abx500: use new GPIO line value setter callbacks MIME-Version: 1.0 Message-Id: <20250408-gpiochip-set-rv-pinctrl-part1-v1-4-c9d521d7c8c7@linaro.org> References: <20250408-gpiochip-set-rv-pinctrl-part1-v1-0-c9d521d7c8c7@linaro.org> In-Reply-To: <20250408-gpiochip-set-rv-pinctrl-part1-v1-0-c9d521d7c8c7@linaro.org> To: Ludovic Desroches , Linus Walleij , Nicolas Ferre , Alexandre Belloni , Claudiu Beznea , Bartosz Golaszewski , Neil Armstrong , Kevin Hilman , Jerome Brunet , Martin Blumenstingl , Xianwei Zhao , Patrick Rudolph Cc: linux-arm-kernel@lists.infradead.org, linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, linux-amlogic@lists.infradead.org, Bartosz Golaszewski X-Mailer: b4 0.14.1 X-Developer-Signature: v=1; a=openpgp-sha256; l=1591; i=bartosz.golaszewski@linaro.org; h=from:subject:message-id; bh=nW8gbeASZZPGvCfMjx4XcSCJQKXVyNGKry+o6wrAY6k=; b=owEBbQKS/ZANAwAKARGnLqAUcddyAcsmYgBn9M2ZVzNUI3VgRQMzfUNu5ztBdbgFOzKCX2cTD gqJRJh5fnqJAjMEAAEKAB0WIQQWnetsC8PEYBPSx58Rpy6gFHHXcgUCZ/TNmQAKCRARpy6gFHHX ckcMD/9lHTxFJCt7mJF9tP1pyTVlOFcI4iTV1L1QK53z5FW2Z3SMIbsg/WP0Ox+KZTEQhQIH3rM wwqGzcFbxbursx8+r7+ZvVqkU4QZIBUyACF7u1pek1/n8JBWnexyzkfimQ/4dv84Mg8fblHxX6/ e9AxG0M296lr/4pAiXZ1OD25/6m9fmgaetnGniuV57A4pLBJe9hlfZ2YzB5mYUgkf1H//Jbwa+A 6XaU8J7I4WJxHP8tl6QsF4nWHGmtgm2fhT82RFptXXjqk4O4soM7AG+Ss+tjQK6UQz9anNLU6Lm rmqduN1o+po7YG+d9QycugTfQLY+ldfFNdSba874x5yFE0yN5u6hWFUlf7kqCSA9/ShGC3h1b1d P3SrzAAp/KzpaZ0qz4k3uHr8AWzjtoebNiQLf0np9Rhj6QlsXMPTjpRvO8qu6TwbjgMUVwXs+ML LAU2zu2R1fixy6aGTWSrsqOHHB7OOlUsUa2Gx4LvWVk5suCmM1xbfDPoByv89XnsFLphWZVxUvK aJGTZoxqeRJVCy+Hfx8X9v29LWuxTlLQC6oNMkvVpk9Pycf8fKsnjpKqnwNQ8Of16WN8gMmVTAb w4ONrOgUNVqfGiBiUJqcKD1U3JafBOwIdNX7SuEwqraaSC6bMhiSiynASp0nnYhkZEAuJMLEqV9 8aWIUWj5E3JEMig== X-Developer-Key: i=bartosz.golaszewski@linaro.org; a=openpgp; fpr=169DEB6C0BC3C46013D2C79F11A72EA01471D772 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250408_001755_508450_ACE435E4 X-CRM114-Status: GOOD ( 11.37 ) X-BeenThere: linux-amlogic@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-amlogic" Errors-To: linux-amlogic-bounces+linux-amlogic=archiver.kernel.org@lists.infradead.org From: Bartosz Golaszewski struct gpio_chip now has callbacks for setting line values that return an integer, allowing to indicate failures. Convert the driver to using them. Signed-off-by: Bartosz Golaszewski --- drivers/pinctrl/nomadik/pinctrl-abx500.c | 12 ++++-------- 1 file changed, 4 insertions(+), 8 deletions(-) diff --git a/drivers/pinctrl/nomadik/pinctrl-abx500.c b/drivers/pinctrl/nomadik/pinctrl-abx500.c index 8cd4ba5cf0bd..2f55f83127cf 100644 --- a/drivers/pinctrl/nomadik/pinctrl-abx500.c +++ b/drivers/pinctrl/nomadik/pinctrl-abx500.c @@ -167,14 +167,10 @@ static int abx500_gpio_get(struct gpio_chip *chip, unsigned offset) return bit; } -static void abx500_gpio_set(struct gpio_chip *chip, unsigned offset, int val) +static int abx500_gpio_set(struct gpio_chip *chip, unsigned int offset, + int val) { - struct abx500_pinctrl *pct = gpiochip_get_data(chip); - int ret; - - ret = abx500_gpio_set_bits(chip, AB8500_GPIO_OUT1_REG, offset, val); - if (ret < 0) - dev_err(pct->dev, "%s write failed (%d)\n", __func__, ret); + return abx500_gpio_set_bits(chip, AB8500_GPIO_OUT1_REG, offset, val); } static int abx500_gpio_direction_output(struct gpio_chip *chip, @@ -540,7 +536,7 @@ static const struct gpio_chip abx500gpio_chip = { .direction_input = abx500_gpio_direction_input, .get = abx500_gpio_get, .direction_output = abx500_gpio_direction_output, - .set = abx500_gpio_set, + .set_rv = abx500_gpio_set, .to_irq = abx500_gpio_to_irq, .dbg_show = abx500_gpio_dbg_show, }; From patchwork Tue Apr 8 07:17:42 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bartosz Golaszewski X-Patchwork-Id: 14042300 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D5BB9C3600C for ; Tue, 8 Apr 2025 07:26:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:In-Reply-To:References:Message-Id :MIME-Version:Subject:Date:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=/ltZ2jcDCaEn7dknqAVoPYIGatIkTBYGhtgZZgfqOnI=; b=Cvw4hvEidE9iZx AWOOe3nSttkYVUfgQCt1vQSFrJ4awl1tS9593fwGnwjptJ4OfaNNmIW8oxTAbq8AsRpQ7K8X320Z0 Vw4OEmbdb94bSBDJNJh1tNQ8NGOUjgz/r7tvFQx5vAXirg4burGyBTyW21Slj2FWS9qq1r4/cKPcz cOuSIrZc4LAJYUt7ylwcmSy1sFm5ygw76w1soD0xbBy8N7zDmyDF1TEWXVpZigJmic8AblaWH0VHh AJLKvq+bPOpS08nHH0XN3PvCbRf0MF65fz1ZLRS5GANQ3NDF0nTqhRQgjBaVIxBh0WoE3lBh4+37D iKp3EEEQarKeK3UjtVxw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.1 #2 (Red Hat Linux)) id 1u23MB-000000033Vy-2L2E; Tue, 08 Apr 2025 07:26:51 +0000 Received: from mail-wr1-x433.google.com ([2a00:1450:4864:20::433]) by bombadil.infradead.org with esmtps (Exim 4.98.1 #2 (Red Hat Linux)) id 1u23DY-000000031g2-3xDc for linux-amlogic@lists.infradead.org; Tue, 08 Apr 2025 07:17:58 +0000 Received: by mail-wr1-x433.google.com with SMTP id ffacd0b85a97d-391342fc1f6so4559748f8f.1 for ; Tue, 08 Apr 2025 00:17:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bgdev-pl.20230601.gappssmtp.com; s=20230601; t=1744096675; x=1744701475; darn=lists.infradead.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=WVFJWADW/y0RMccjVQrvsZvTL6Kql3Z12L3/megvx2A=; b=P5L+fkuIKBj1aFekzclEylg1x7sz6YuH6XFHbIFChe+DSxC8z4UzW/rzRp5gS/8RTi JHmRRhaQClGkP4CXe9TnNqVwfps1Jcw2npDuD9eep5AD+V10be3wzFrbr+E7z9joNHng nJuaxqLc01Mw3BhCfkIsUVwHW5J+ltckIwm8uRpbwQdf1+PYvR30uv76+VsmZY+6Y9X3 r4ieWkzMEu1gPC14zezDA9DwF8Z4H5hOTiT3jmTCjsKsiCQ8jJ3z+4A86OAmNcGszp1y ocKNmrbH7BlBqaIhcS9518r1op3e1VeTALX4E9iorwrYHrBfcrAGF1+YUrBjhsbXCT8l H5nA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1744096675; x=1744701475; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=WVFJWADW/y0RMccjVQrvsZvTL6Kql3Z12L3/megvx2A=; b=uCZqpknBiaBZYWhubfjTD6gz310i9sZ7cyNwW8NOx6UOqHw9UfO5M2yx9kLOUC3uBo Gb/fdTrs1oDL8sAjE8zdssd2/YsTGT2fmjJvPS3aYjkVsHwChYY/MTJFE7tAjQ6WAZiK K3vU5aMY26i/s4DZTdHWI32Ma80wgg1xdiuLSGIO/oBusYhM+imrz45yG92VKS3iOGRF Y3usfbc9fD2ZVilRvb3+IEENnDKFEjY4qPnQPaVTK0PDhvuOrUH8Mn62cjvu6M7UfLBE wJmAYpSU+fTY54G2GMm7a8tzlaC7iMz99lJUvZBGGKfE19rBGKD0N24iKusEYIUWQ9Vp 7FKQ== X-Forwarded-Encrypted: i=1; AJvYcCWHceWxTb6freoTOpJOzJZ+4cXUhLKTi61eHYqIddXuExx4R0rlP7VCq59RMkZHUPMT5IkCzz5RSQ14ZMOw@lists.infradead.org X-Gm-Message-State: AOJu0Yzh6DLMhIXOR16LOj0GdNEdqDuLYme6VaKvl4cdxFoWNav7IbMu g5vwQ84FMn3JFr8zXrWCCMYX/3gS1uO7FXK4JDeBg9IFEaNJNL6XVVXuPauDJpk= X-Gm-Gg: ASbGncutj6RX5pQ4rrW8UJ0xb1w0CPAtlEB54s6UOWIcI8Vt6TukgqGZD3zKgcvT1kE Jztr5BLXfwbo7he3Klwol05tN05hJw7fi0DLkvst9ZX6A6++OjAMvvUySDm6PQbgA/O4CbtSYhV 2X/FpH+ckNfSKhbsqUR1q9NFsuCcSwzdw/OUxitzF47yHt+guZ5CClrXmnhadtqRMvddoHV2Yy+ k4aO4834QRNTMEa7LcHuEEBCgwAfGd8jtcvLksCvC1ecYR0omJff+6ZphVs+klj5oDnzkR0RGXf bcGXi6ai/9IShvF1dnt3vqy1FtmaztQTzt2iSQ== X-Google-Smtp-Source: AGHT+IGb12K5x3MyGax1/meWBHx/ceb2e/LqJgU9QQIZHIFbzKHDCky62yygJ2VTuSCj50YJyfE4bw== X-Received: by 2002:a05:6000:4313:b0:38f:2413:2622 with SMTP id ffacd0b85a97d-39d0de679d1mr13305391f8f.47.1744096675082; Tue, 08 Apr 2025 00:17:55 -0700 (PDT) Received: from [127.0.1.1] ([2a01:cb1d:dc:7e00:2adf:eaae:f6ea:1a73]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-39c3020d5d1sm14257694f8f.77.2025.04.08.00.17.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 08 Apr 2025 00:17:54 -0700 (PDT) From: Bartosz Golaszewski Date: Tue, 08 Apr 2025 09:17:42 +0200 Subject: [PATCH 05/10] pinctrl: meson: use new GPIO line value setter callbacks MIME-Version: 1.0 Message-Id: <20250408-gpiochip-set-rv-pinctrl-part1-v1-5-c9d521d7c8c7@linaro.org> References: <20250408-gpiochip-set-rv-pinctrl-part1-v1-0-c9d521d7c8c7@linaro.org> In-Reply-To: <20250408-gpiochip-set-rv-pinctrl-part1-v1-0-c9d521d7c8c7@linaro.org> To: Ludovic Desroches , Linus Walleij , Nicolas Ferre , Alexandre Belloni , Claudiu Beznea , Bartosz Golaszewski , Neil Armstrong , Kevin Hilman , Jerome Brunet , Martin Blumenstingl , Xianwei Zhao , Patrick Rudolph Cc: linux-arm-kernel@lists.infradead.org, linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, linux-amlogic@lists.infradead.org, Bartosz Golaszewski X-Mailer: b4 0.14.1 X-Developer-Signature: v=1; a=openpgp-sha256; l=1477; i=bartosz.golaszewski@linaro.org; h=from:subject:message-id; bh=S3igGGikbfII9kNPL0KKjqnS8YUnpBiOi6WZKLdujUk=; b=owEBbQKS/ZANAwAKARGnLqAUcddyAcsmYgBn9M2a21smivbrNX7hovJ5AmOVQjkGrJhwqOgTw 9GIegrUEM2JAjMEAAEKAB0WIQQWnetsC8PEYBPSx58Rpy6gFHHXcgUCZ/TNmgAKCRARpy6gFHHX ci67EADKEh90ymTKMGsCY74l9LHK8QIQ4v/81+Rc6Eqfw4wVjL+lPNaGTcSBP2utqyO2KrQMMFw Ud7MCMHcZm7kzMCKgZhr4Q5hxKegKb2tXZsgsyhV8YdIebBSZmZS3xjHm1FTslGntrxTtZfUcgD 9Ncx7bkinKF9GE+JhCUYTwm5rX/ImXZPua18/+263zoA9IcowGvpu+sHiPYBinPQTG/NzQUeczO GStvT8lo/PvFW5C2evtDAAac3WkpMH72Zd++nH3ZSzFjmh6wa+JuZj4++IaVtdQvf34/rVmBvxm 6lfHwsxcLCcvsiKLGQvJ0pyMUTgjTXWuCVx1yI4OFqh/vGStiEpFn/FM4m6cgY2+8721nFS0XSg skTUnIqE+icmuFIxh33ZNyBinNKoXfA262Dd1FT4UU/UGWwK/zVzRXebNxxuWVofBCrpGfvckJj 5An31hmmubXfJwwqfo1WCobGVNTYhODCiiFTT1nEEdIOgEF1ogNVoLg7ND2vY3mbvxs/m59mrBt Ghvcu71zj2ubCbOCger+FJ91d0OXgTTDx3l6RxskE+/H9YiT3YVPYtaxsW15NZ/wrgk3dpqh3Pb pxgF2SOpd2n46VLipFyjCU5PmDaB9KG2fyxu5yKFQym8Uk1AbdlkcgldvEzqzVK06tjwV4yQehq CrMwCr4lgCvIlLQ== X-Developer-Key: i=bartosz.golaszewski@linaro.org; a=openpgp; fpr=169DEB6C0BC3C46013D2C79F11A72EA01471D772 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250408_001756_990511_A8766672 X-CRM114-Status: GOOD ( 10.44 ) X-BeenThere: linux-amlogic@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-amlogic" Errors-To: linux-amlogic-bounces+linux-amlogic=archiver.kernel.org@lists.infradead.org From: Bartosz Golaszewski struct gpio_chip now has callbacks for setting line values that return an integer, allowing to indicate failures. Convert the driver to using them. Signed-off-by: Bartosz Golaszewski Reviewed-by: Neil Armstrong Reviewed-by: Martin Blumenstingl --- drivers/pinctrl/meson/pinctrl-meson.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/pinctrl/meson/pinctrl-meson.c b/drivers/pinctrl/meson/pinctrl-meson.c index 253a0cc57e39..e7485c82089c 100644 --- a/drivers/pinctrl/meson/pinctrl-meson.c +++ b/drivers/pinctrl/meson/pinctrl-meson.c @@ -580,9 +580,9 @@ static int meson_gpio_direction_output(struct gpio_chip *chip, unsigned gpio, gpio, value); } -static void meson_gpio_set(struct gpio_chip *chip, unsigned gpio, int value) +static int meson_gpio_set(struct gpio_chip *chip, unsigned int gpio, int value) { - meson_pinconf_set_drive(gpiochip_get_data(chip), gpio, value); + return meson_pinconf_set_drive(gpiochip_get_data(chip), gpio, value); } static int meson_gpio_get(struct gpio_chip *chip, unsigned gpio) @@ -616,7 +616,7 @@ static int meson_gpiolib_register(struct meson_pinctrl *pc) pc->chip.direction_input = meson_gpio_direction_input; pc->chip.direction_output = meson_gpio_direction_output; pc->chip.get = meson_gpio_get; - pc->chip.set = meson_gpio_set; + pc->chip.set_rv = meson_gpio_set; pc->chip.base = -1; pc->chip.ngpio = pc->data->num_pins; pc->chip.can_sleep = false; From patchwork Tue Apr 8 07:17:43 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bartosz Golaszewski X-Patchwork-Id: 14042335 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E6A82C369A1 for ; Tue, 8 Apr 2025 07:34:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:In-Reply-To:References:Message-Id :MIME-Version:Subject:Date:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=jkIKL4PXjX6ywLMJ5l3hRef0OlZIYPWMrW0kasLsybk=; b=gsqjmBSLTgDgaW lUEIp5iMRiVtmHcz/S8gYvosw3aeqUgDURH2QiCUpk11prIoZ7fiuoAFsHAbBKb1szHYOSI32JdIm InsjFOSuX/3UGibYNfYhQc4EUxedAAxVxVBj4hqenwcKTIyAQWGk75TjflA04l4btZTnuR0X6KhvQ XJrbLiwViZdq/G+GgGU+LhFYEw0ON7NA9sUovtCoSLRYV0gcmJmsl3vbTI8Uij1F93Qko5Ypr/SO3 DFt1m5g6LE4ioPoYgAmtD7BZ2mxRBisFN9NQcIDuKneV00eSbUE0DmomsK11l0bpT/waMXkZug+My PkFWmy8CdcUYh7oT7X6g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.1 #2 (Red Hat Linux)) id 1u23TA-000000035It-00ZT; Tue, 08 Apr 2025 07:34:04 +0000 Received: from mail-ej1-x630.google.com ([2a00:1450:4864:20::630]) by bombadil.infradead.org with esmtps (Exim 4.98.1 #2 (Red Hat Linux)) id 1u23KR-000000033CD-2ImX for linux-amlogic@lists.infradead.org; Tue, 08 Apr 2025 07:25:08 +0000 Received: by mail-ej1-x630.google.com with SMTP id a640c23a62f3a-ac339f53df9so909809966b.1 for ; Tue, 08 Apr 2025 00:25:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bgdev-pl.20230601.gappssmtp.com; s=20230601; t=1744097102; x=1744701902; darn=lists.infradead.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=XOjNNeHzyY58LMv3k+FTJZV8HBjSzUrYs1slCEoFb4s=; b=bcu71875aPWcVKmaT5yc7G57I2UHXAtMwxp0JZJj3z2BAVzdY2CGvu18n1Pirm4zbi UgF+3xN3Q8EFk/UfUhqwZGqqC3l3yAsmFIEKH8Lx1QVKEM5bojWReh3kHF03rtftwT/Q xHdsPHkKGToH7iYqHROFZ8qGoHRQ2YyRQSN0j7wg0DaERRHjlAD9mTdKPk+jKAX9pBGD JSrvn2usGJTGUzifVSwMrukHNXpg8u+fQE9MAVcswEzjRKv8b69a71keoIvSeYJ1OX7q OtiXIWrVGgPJaQ5Ujl12FiOMk0HbacD5Zp3v7Eq8m3r3qCbgZ500+tFrjf5FUbG5kYcX dnMg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1744097102; x=1744701902; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=XOjNNeHzyY58LMv3k+FTJZV8HBjSzUrYs1slCEoFb4s=; b=fAPAHA5+t90R1+5jFI77lpGlyEpDjb+FBRbdNSlL86uN/hwuHRVqUWDFExfyvE2K+I fjgzTehd/YRpAvaT0yqTkr/fT+E3NcCWizqIqB34Gtz6+sRpn1n3fer1IzVJ2I+AX1CL byFkBaL2ZDPyz7djcZrkGAtwYyzyzyx4/P1OII0lsgdr42uz+yrbuu0J+9/wJ0D+IWxZ aLeyDqIS92peBS+mJ3KuPVxHWqWxWCBkbVoiq7JCZdRg6R1/yrvjCD9geve/eROTuozS wmdQergmc8CnC/uvHDPZay3o1cS5/Zrz54J/T8YOh9gEtyTnpNuofFtDZpUgNGlDigmg X8Ng== X-Forwarded-Encrypted: i=1; AJvYcCWWBGOYWVnBNg7xS8DOK7erz3xm6LwRH9C1iYTEhAnH+DKlC87rCw84pGpczN/Tfrteg50nuBwklv+stI2o@lists.infradead.org X-Gm-Message-State: AOJu0YwRuRW5Qi5bE9ksT7piapBmlle/7WNIdPoyJhPsChjstzUnF1n4 t2HR0hk4+o6s3c1RL5VkY5ztA9Fs3QCuRdqarPQ3g97gTp2/hnIqha2FZsAocIhaG+XHi6kLGUC ObtY= X-Gm-Gg: ASbGncv+rHvcvhkmhixKq9w/wSqSUxOeKWxPKvfvW3Vr4b/OqAH8jjcnmQ3DRLPhp/u fKUYrgDbQ4XUp9nl6PhTtzDoORLUPUUo1HpJlh+8vCwN9Qfubkg7qP35cOuUWfSNdgJ1t3ha91r bp85t7mlTRAcZE5a0/a3/z9+CoT/9rczf7dpVb+Exf0GA/LZN9T4awUnce2HvLm2ifzMfjx2UC6 3JY81iyoDXZZeyNpPRLgKpmT439bPEDYzHosZrEkt9jXbBQYT1LJh3NMKe2Bo8AcdhR3nFYlK8f wrFwS2v2iW4kbIIfx8+hjooW7hEBS9zv+t6sjQ== X-Google-Smtp-Source: AGHT+IGDlv/Wz2Tv0JI+8Hx2njCPUM9rczyDR5EAPHa4oqor0nd3oFYHO3dEgeKjIpQ3eleoyeURtg== X-Received: by 2002:a5d:59ae:0:b0:39c:27cc:7ba3 with SMTP id ffacd0b85a97d-39cb35aa8ecmr14702868f8f.33.1744096676320; Tue, 08 Apr 2025 00:17:56 -0700 (PDT) Received: from [127.0.1.1] ([2a01:cb1d:dc:7e00:2adf:eaae:f6ea:1a73]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-39c3020d5d1sm14257694f8f.77.2025.04.08.00.17.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 08 Apr 2025 00:17:55 -0700 (PDT) From: Bartosz Golaszewski Date: Tue, 08 Apr 2025 09:17:43 +0200 Subject: [PATCH 06/10] pinctrl: amlogic-a4: use new GPIO line value setter callbacks MIME-Version: 1.0 Message-Id: <20250408-gpiochip-set-rv-pinctrl-part1-v1-6-c9d521d7c8c7@linaro.org> References: <20250408-gpiochip-set-rv-pinctrl-part1-v1-0-c9d521d7c8c7@linaro.org> In-Reply-To: <20250408-gpiochip-set-rv-pinctrl-part1-v1-0-c9d521d7c8c7@linaro.org> To: Ludovic Desroches , Linus Walleij , Nicolas Ferre , Alexandre Belloni , Claudiu Beznea , Bartosz Golaszewski , Neil Armstrong , Kevin Hilman , Jerome Brunet , Martin Blumenstingl , Xianwei Zhao , Patrick Rudolph Cc: linux-arm-kernel@lists.infradead.org, linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, linux-amlogic@lists.infradead.org, Bartosz Golaszewski X-Mailer: b4 0.14.1 X-Developer-Signature: v=1; a=openpgp-sha256; l=1680; i=bartosz.golaszewski@linaro.org; h=from:subject:message-id; bh=zFDAJ44H3rDElvqiaNPmVwvOeCsvopBV8K2+vzPv+N0=; b=owEBbQKS/ZANAwAKARGnLqAUcddyAcsmYgBn9M2aCcCPhwuF/Scl+dWhUvbWutpdgADlyzo6E dkwEIOpAkiJAjMEAAEKAB0WIQQWnetsC8PEYBPSx58Rpy6gFHHXcgUCZ/TNmgAKCRARpy6gFHHX cnRjEACRE1eo2DpKjHGbPlQbMpv86tO6SMwS6frSIq+KfYxOaODnxG0vYoNPl1XeTMMPfKWxuKo MspJKWTkvUN0QuIxmjcZ8vBjIh2Ssf2biltkgH+3Ut1/ExIvxXr/M7gT0UOy2/r94+c7DkVzBEK MXr/4KXQXVZ4OSvLf588xywzpAYfsAPShtYaqDz9OdGk8uc9fPG5lzGH4ccc++V5cuv0ZlY9tD3 ZXnb+hLdVs0BvC1ESV29eq9xcIkTRj/KhdzH4WdJDJB4Fx4xRvCBxuTrv9+Hv2FE6VyVgnX8Knt wPQY7lA3cwjzj0sWtwauKnLeZ0x1DD6IMexNhfxrfvgGpEXh0w3i09yOn6vnAvTxetgrzUoiZsq 5210n+9CVXDRsBqfEUuqtBOx2/HJBwMibEOeyf/tK8wVBtbrEFq1ji769lP5H/PGJUFNT0bPXLd vnKVHrJiJUiyX0REr7gSm1AjTYXZb/jNq6PcBIY1JG8vYGaruh/7KsvN5PbWlmeIxn2DIKitoEB 5c3paQ4gObhMQ1lHal6NduGavNkTb99awzhp7MjrFLQ7vHEkk6LWPVdn1/obav1Qnh7bwi6/RYI rfIeivF5Tge1zaLyASFLrEOQUIffbwsDEofBTf4iFicbK3EDjEXXtUNKuD4DDgO+q2/1XPzUYDj IgJ4xDux3XMrr+w== X-Developer-Key: i=bartosz.golaszewski@linaro.org; a=openpgp; fpr=169DEB6C0BC3C46013D2C79F11A72EA01471D772 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250408_002503_579506_78BA4F3F X-CRM114-Status: GOOD ( 11.01 ) X-BeenThere: linux-amlogic@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-amlogic" Errors-To: linux-amlogic-bounces+linux-amlogic=archiver.kernel.org@lists.infradead.org From: Bartosz Golaszewski struct gpio_chip now has callbacks for setting line values that return an integer, allowing to indicate failures. Convert the driver to using them. Signed-off-by: Bartosz Golaszewski Reviewed-by: Neil Armstrong Reviewed-by: Martin Blumenstingl Reviewed-by: Xianwei Zhao --- drivers/pinctrl/meson/pinctrl-amlogic-a4.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/pinctrl/meson/pinctrl-amlogic-a4.c b/drivers/pinctrl/meson/pinctrl-amlogic-a4.c index ee7bbc72f9b3..a76f266b4b94 100644 --- a/drivers/pinctrl/meson/pinctrl-amlogic-a4.c +++ b/drivers/pinctrl/meson/pinctrl-amlogic-a4.c @@ -806,15 +806,15 @@ static int aml_gpio_direction_output(struct gpio_chip *chip, unsigned int gpio, value ? BIT(bit) : 0); } -static void aml_gpio_set(struct gpio_chip *chip, unsigned int gpio, int value) +static int aml_gpio_set(struct gpio_chip *chip, unsigned int gpio, int value) { struct aml_gpio_bank *bank = gpiochip_get_data(chip); unsigned int bit, reg; aml_gpio_calc_reg_and_bit(bank, AML_REG_OUT, gpio, ®, &bit); - regmap_update_bits(bank->reg_gpio, reg, BIT(bit), - value ? BIT(bit) : 0); + return regmap_update_bits(bank->reg_gpio, reg, BIT(bit), + value ? BIT(bit) : 0); } static int aml_gpio_get(struct gpio_chip *chip, unsigned int gpio) @@ -832,7 +832,7 @@ static const struct gpio_chip aml_gpio_template = { .request = gpiochip_generic_request, .free = gpiochip_generic_free, .set_config = gpiochip_generic_config, - .set = aml_gpio_set, + .set_rv = aml_gpio_set, .get = aml_gpio_get, .direction_input = aml_gpio_direction_input, .direction_output = aml_gpio_direction_output, From patchwork Tue Apr 8 07:17:44 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bartosz Golaszewski X-Patchwork-Id: 14042337 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 7D483C369A5 for ; Tue, 8 Apr 2025 07:34:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:In-Reply-To:References:Message-Id :MIME-Version:Subject:Date:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=E1tfv4heTH8s5csib2Gso+wHS7Wr1+8P/gylq6cuaoM=; b=34unIHMJb8dI+w PeJQO/MgyaQNkFYCUSHzgM0loA4Ss3dNulDNqskGgElnGUxEcJAU/IwojEucbh96W7NVisQWeKX2F rkGml15HYlO9fVezUgykhGPKdN8/aciiSZf8fvXjAIG7FSwVn7NZan2BKwKZqxTjG9gE2w+XP2P63 jcGmVQjc8d+YAMrVfO2J7JaSTPh35hzt+lOAXuS8GO1birvPVBz3HNKQG+lMZNLHhmh+tVtOJdN5c hXYaL28T6pts7/XBJ+v7XaF7H7vZmeiVkHl9fXvuYnXaz0LVxMAEEsHU+7Q3EC2CwANUFnt6EB4aG qWO6Bdnp5MlLMBx6hutA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.1 #2 (Red Hat Linux)) id 1u23T9-000000035Ij-2gNA; Tue, 08 Apr 2025 07:34:03 +0000 Received: from mail-wm1-x334.google.com ([2a00:1450:4864:20::334]) by bombadil.infradead.org with esmtps (Exim 4.98.1 #2 (Red Hat Linux)) id 1u23KR-000000033CE-3SRM for linux-amlogic@lists.infradead.org; Tue, 08 Apr 2025 07:25:04 +0000 Received: by mail-wm1-x334.google.com with SMTP id 5b1f17b1804b1-43cfba466b2so51293425e9.3 for ; Tue, 08 Apr 2025 00:25:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bgdev-pl.20230601.gappssmtp.com; s=20230601; t=1744097102; x=1744701902; darn=lists.infradead.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=o6prcSe997utkmrj2Wk6sqfMRushEUX5sURGCDCfQ/A=; b=Vz6Geq9q2+zUYRrxxp6MASbOhaLXImkz5UoBp5ZHi0fP79Bq2GmrK6b6QTUfKDpok6 hYkmX2cvYR/V2oeH10oOShWk1zvBI+KE0//K2HmbiIM6A5yS4B/ATB/GycK3Gm8x86hn z3Sb/wUnUB1RK0j4WQJlQ2K0xDgPR410bNlUbQkwPe7HcIejTNBc73fiHRAbCtPRyt+E vJjvN9uHaC5isfqs/OlhVgj3AeyATxD0nfHnDe4oZfq5MeCo7EAJfnP+a7LFgxLtiMuz nJO27xeoDQDT6bXKWFcsxrMzcQGoeESaSq4l4KMOHw66/WJyOWufrQ+p2b1HT6Kw976K hAOA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1744097102; x=1744701902; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=o6prcSe997utkmrj2Wk6sqfMRushEUX5sURGCDCfQ/A=; b=m0N64RkKRcWso5/L40fCyKXTXlU7cfK6VgMxI01usFRGnQyK/U2zZK6DOYrR9BJk6n VWYJEQKJex8oxEbCBfNoGfbZIr7b4s9SFj7Q5JTZT8VDKdhtiYko0IegOlo2nn4YWhH1 De9QreGlwSweDwcjIP+EW08TLuVXvv1e94N7vCtSbMFv/5GwIihqRbc+B4Futbu8YWpr h1OqsSZ7Ila4nYgAwdq7ZL4SfWV3i8No/clSIE37myYwIzDKyq0nooV+drbMgP4DPMvs yVF7t6DUVRCYR0Z6dvxhC05UDfEPNxIJBUUfcOdhAExCVhNMQyBCHi06y1ees0U/pCWI Spwg== X-Forwarded-Encrypted: i=1; AJvYcCVwaRODoEKR4UnxDvI1pW4AwTJroo7qevHRMXEHmEGimnTLXFOgj/7A+2XBEhz2qrUiISaViPHs2/YHXA0S@lists.infradead.org X-Gm-Message-State: AOJu0YxXyBATeDDW6FstPBDkg0Md6A9zBUgp9FWMYQJGCF0TKNVpFwzu tLUY3mZNwzZ3hCpf/vbDG6ojUggtjFGY75Pnesl9pHxFZ8NqFIoWmRI72+iMymQ= X-Gm-Gg: ASbGnctbgvNnsI7Vi/a6x9/1I4GxdKvFWwiRF8xJTuBA+97qD/5y2p1SDs6604b1YbJ h0RWNNlwB27NfzV+7YRkT68xlFS0vqAtNULJrf+K3BbTlPIiVURkTXaBa/1xh4m8oMHiwYs9bu2 N2SSUndF8OK/SVwhgz4F54KN/KXpJ9FqIAvMFdhNzY004mkO6xDukWgUn90mpBRW733dJjlHRpk +R5o4zXsOYg6PGPLwNnaVL6OLooX4KRVSCslS3VofHswciKUixFvgVJQ+UG7l0/x4mS06W98p0O T80BpTHTnPlMEe+8qCd+a/PA2ODCd+LnQQW5hw== X-Google-Smtp-Source: AGHT+IHzySH+p8lRsbpEKp8XdjRw3BmN8WdHjMLgCKHMXaLLom4rGv3xsF4growXW8khurtrZ60whA== X-Received: by 2002:a05:6000:1846:b0:390:eb6f:46bf with SMTP id ffacd0b85a97d-39cb36b298fmr15212511f8f.5.1744096677281; Tue, 08 Apr 2025 00:17:57 -0700 (PDT) Received: from [127.0.1.1] ([2a01:cb1d:dc:7e00:2adf:eaae:f6ea:1a73]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-39c3020d5d1sm14257694f8f.77.2025.04.08.00.17.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 08 Apr 2025 00:17:57 -0700 (PDT) From: Bartosz Golaszewski Date: Tue, 08 Apr 2025 09:17:44 +0200 Subject: [PATCH 07/10] pinctrl: sx150x: enable building modules with COMPILE_TEST=y MIME-Version: 1.0 Message-Id: <20250408-gpiochip-set-rv-pinctrl-part1-v1-7-c9d521d7c8c7@linaro.org> References: <20250408-gpiochip-set-rv-pinctrl-part1-v1-0-c9d521d7c8c7@linaro.org> In-Reply-To: <20250408-gpiochip-set-rv-pinctrl-part1-v1-0-c9d521d7c8c7@linaro.org> To: Ludovic Desroches , Linus Walleij , Nicolas Ferre , Alexandre Belloni , Claudiu Beznea , Bartosz Golaszewski , Neil Armstrong , Kevin Hilman , Jerome Brunet , Martin Blumenstingl , Xianwei Zhao , Patrick Rudolph Cc: linux-arm-kernel@lists.infradead.org, linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, linux-amlogic@lists.infradead.org, Bartosz Golaszewski X-Mailer: b4 0.14.1 X-Developer-Signature: v=1; a=openpgp-sha256; l=667; i=bartosz.golaszewski@linaro.org; h=from:subject:message-id; bh=YmzRn8TzGA6hsDQ4Ls1ViAlvgo7b9jMn9Wlo//Y9vfE=; b=owEBbQKS/ZANAwAKARGnLqAUcddyAcsmYgBn9M2a3aI8tyRJWFB0j50+lYKjuGbu/ifeaeFQ/ 4M0t4m17MyJAjMEAAEKAB0WIQQWnetsC8PEYBPSx58Rpy6gFHHXcgUCZ/TNmgAKCRARpy6gFHHX cnJ4EACh4EPB2PiBQrpFxrQpn3I5/hHOewyCLs6D3bGW26OisrbJ6BrXg5SN88KZnurmvDHsuP3 MvwP+6leXhNTitXtnj5TQxtJin6NVZ0Al8MJyd9xwa21k8YTlRMm7rgA4Vx9CNvjDV9gf5XOdBF o3JYv1QhJr/SgcdkDr5Ox/diUgdt5Z+bjO2zMLW0i90TN8XxW/blNaWT5xnj070aBbwHIva6E+l v1y1VlHp/I4MrpZmV4MtqxBFHCOAQZEOd+itR+n/S8LP50+qens7NAVqfZhfaQQ7KSmLbRKJpm5 kiG1CDXKTkVqJunSULnVtRahqu1J6ZcmwDJeXTo5PtKQZiFIlUHRjOs60Av24wdhwd+FY4ptQOp pU+EYeQcKSLcEMkga3AqSlN+IrU5XJAo9Y4FLczzGc6/9kTe7Y/MLq04J3fmVsp5KDuJR98aytJ 6m/1/sJrIyiE38hKgq9Ta2I/s9/NjynRehGmP87FTcRsCV1bnl97G4/o6CZtPg/knk7WmCFCogS WBIkWDQrNxAYw16mjSeY+350vXO3jYh+7OIbRVqdjqYiZKSAy9A2h4HULcXVra+fEX2z6ALsNmI gsWEWEJpEXYy62lnL9J9OTf1+ihsnQZFt0jOnnge9cZzyJTQW7bhCj2GDkVkcgK5wezSQQbuork C6IVZWbEkEfQnFg== X-Developer-Key: i=bartosz.golaszewski@linaro.org; a=openpgp; fpr=169DEB6C0BC3C46013D2C79F11A72EA01471D772 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250408_002503_863121_BD72AC60 X-CRM114-Status: GOOD ( 10.37 ) X-BeenThere: linux-amlogic@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-amlogic" Errors-To: linux-amlogic-bounces+linux-amlogic=archiver.kernel.org@lists.infradead.org From: Bartosz Golaszewski Increase the build coverage by enabling the sx150x modules with COMPILE_TEST=y. Signed-off-by: Bartosz Golaszewski Reviewed-by: Neil Armstrong --- drivers/pinctrl/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/pinctrl/Kconfig b/drivers/pinctrl/Kconfig index 464cc9aca157..94eb41bb9cf2 100644 --- a/drivers/pinctrl/Kconfig +++ b/drivers/pinctrl/Kconfig @@ -541,7 +541,7 @@ config PINCTRL_STMFX config PINCTRL_SX150X bool "Semtech SX150x I2C GPIO expander pinctrl driver" - depends on I2C=y + depends on I2C=y || COMPILE_TEST select PINMUX select PINCONF select GENERIC_PINCONF From patchwork Tue Apr 8 07:17:45 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bartosz Golaszewski X-Patchwork-Id: 14042301 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A9F88C3600C for ; Tue, 8 Apr 2025 07:28:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:In-Reply-To:References:Message-Id :MIME-Version:Subject:Date:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=l66hi82Rtqfng/JOljKDiOdMfyFwnEMTzbik2bhFuJ8=; b=Ih+g7WG+fGKK5k tvKbG/S+d/iVm5S90Br+JGOBD4NhTnBRHBE+SgZLh96GC+YFzxfO0dknP+5D4nKeynx4302zhTHOQ 4cyrgPiWrWkEnKwEzjgqs5FSBP+Amypk+8DeMd9A3QxLtvT8Vg+3OAxhNJGt+RuXgnJNFRB7MTEQn F2fCNOBy1ItEQZnf4mUCofXZ8oGRmu23mX628cJOKxjK/AkgPNgVxdXWD5HxS/DXk4hzU3rHRUNSu f/xhPVNsG7OlQP7P56GMR/7tfgL9ic+SfD1V/FG5NLgyGT5XYmv3UV9Mwv5MQybeonHKUgHYK/n0C 2hUhIoplGQhKQgnWtyDQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.1 #2 (Red Hat Linux)) id 1u23Nv-0000000340n-2pif; Tue, 08 Apr 2025 07:28:39 +0000 Received: from mail-wr1-x431.google.com ([2a00:1450:4864:20::431]) by bombadil.infradead.org with esmtps (Exim 4.98.1 #2 (Red Hat Linux)) id 1u23Dh-000000031jR-2Vs0 for linux-amlogic@lists.infradead.org; Tue, 08 Apr 2025 07:18:07 +0000 Received: by mail-wr1-x431.google.com with SMTP id ffacd0b85a97d-39149bccb69so4774368f8f.2 for ; Tue, 08 Apr 2025 00:18:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bgdev-pl.20230601.gappssmtp.com; s=20230601; t=1744096684; x=1744701484; darn=lists.infradead.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=XD5pUwvjF21WHvNYwLGg3m0Hf3jMmd7qTIORgnVtv+o=; b=BJXueTru7PlYa08crIeV9MmrHoZCNguzOIDzvgioHh/XV0GQVdbqOun1iqJqXm6Irp +jJ8I0uBiTzU7l0NDQp32Fg4/D+q2ZJ5EjRUxtZJQTQ2bQNwzXg4JoXtTLXN47DKCHeL i8cDh+7U1l4xaYIGo0QAnrKG+Px6W1AR28z3Oa5ZnXWS6fisjPl8ieTIsJbsXll0AOvx t0uzvtFiAY3yDPxFlsfLv1mzy//93P77uLAjVXoUOaNrR0xpO7y9gT644Zlg1cQWrsGt 3t88nKVe8cYDEz9OWn/kncd5E5W/GWrwgu167qZedRjAd44pque1Ho+WhXuxEM3ptzMj t4NQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1744096684; x=1744701484; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=XD5pUwvjF21WHvNYwLGg3m0Hf3jMmd7qTIORgnVtv+o=; b=KRZJbWFnblr2fI1EIkhcOfbKZF117OXyVWLdcs5tc/aVohq9PIxc+a/aSCupy5pv98 pOKDYSveKlXxSVH/ADk43AXqBxwwxsgIu7Aa0qay+6KuPkhfD5DZLXRc3/qYOK55vOTs jIyYIn3+Wb830yryVw/4kO5W8HzAoLtLTnxrk2xVvsZ3xUDy6GRBk/Yh9+6Sf19ROOE/ lTKy6mCwfgq5UWkTmjTwykmNLbL5q2Twtpg+eSMSUBk5iLuCouuLhMCmavHO/fx0nx6R A8LduyFDuIF2EC3UcaVEjajE7bt3ObdoL3X0QJkR6KB27vr2x29ywWR/9QTP8oUDx26J t83g== X-Forwarded-Encrypted: i=1; AJvYcCW4rSKu8hSR7ASAMh09Wau6mTlSCEjhc7O90l2d2DcMX83M89+/kdkejSFFIjarkTHr+ecZp014owgdbvDW@lists.infradead.org X-Gm-Message-State: AOJu0Yy6fT8BoR6USm09RHNwhEU6q2bwPOLfa2WDLF7inSgjig8S9A+n 3wYfizMJgWrrs3aUZWi9tPguTXJ4iAZryjl9eAog0z4lBcMpZnuH0bl33FogtKQ= X-Gm-Gg: ASbGncsxPn15fWmHtd7LeS5ATlZ/M8e32pgceMa9srBj38OsvYLwQDSZRzInPx++WZn 56RdCoxx4jHpWXQP5I3wtCnm5nPj7fEjAAY++VvHHfSeVmOC8Daacn0EwXnzXpsJuAoA/ZBKYDW fDGhTFrj5Dl8lE6PmegEOOiQIiQTxLfcQ7QJBQiQhKsHYRkfN4U4zQ7VeXhunsC5FJrBulamaDw rLR78yTQpj14oKMmwRxhl+gAzIZS7dniQ8jl6qlYsB3zMG/ptKZwcT7csa+WcGWLdKoJsplE85z nm/5QMFo4QJ8bfMxdeZgyuCoC09CGQFLnzLKEQG3vMxveWNY X-Google-Smtp-Source: AGHT+IFABP+0NyYfjrmBkKOY8Qu8GHG07RX08meqZeJWYd12gU6oEH77JekbQo0tofcJZaJ2znOR0A== X-Received: by 2002:a5d:64cb:0:b0:38f:4d20:4a17 with SMTP id ffacd0b85a97d-39d6fc48b9fmr10149766f8f.13.1744096683833; Tue, 08 Apr 2025 00:18:03 -0700 (PDT) Received: from [127.0.1.1] ([2a01:cb1d:dc:7e00:2adf:eaae:f6ea:1a73]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-39c3020d5d1sm14257694f8f.77.2025.04.08.00.18.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 08 Apr 2025 00:18:03 -0700 (PDT) From: Bartosz Golaszewski Date: Tue, 08 Apr 2025 09:17:45 +0200 Subject: [PATCH 08/10] pinctrl: sx150x: use new GPIO line value setter callbacks MIME-Version: 1.0 Message-Id: <20250408-gpiochip-set-rv-pinctrl-part1-v1-8-c9d521d7c8c7@linaro.org> References: <20250408-gpiochip-set-rv-pinctrl-part1-v1-0-c9d521d7c8c7@linaro.org> In-Reply-To: <20250408-gpiochip-set-rv-pinctrl-part1-v1-0-c9d521d7c8c7@linaro.org> To: Ludovic Desroches , Linus Walleij , Nicolas Ferre , Alexandre Belloni , Claudiu Beznea , Bartosz Golaszewski , Neil Armstrong , Kevin Hilman , Jerome Brunet , Martin Blumenstingl , Xianwei Zhao , Patrick Rudolph Cc: linux-arm-kernel@lists.infradead.org, linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, linux-amlogic@lists.infradead.org, Bartosz Golaszewski X-Mailer: b4 0.14.1 X-Developer-Signature: v=1; a=openpgp-sha256; l=2534; i=bartosz.golaszewski@linaro.org; h=from:subject:message-id; bh=nW90rn+BHn4CcA4KM6329dEBeQrDE0H95eIQ6kXIjjg=; b=owEBbQKS/ZANAwAKARGnLqAUcddyAcsmYgBn9M2anp9vmc2BpNT/BOe9JwVC3uov6dAPDjgly g/s/D9FRDaJAjMEAAEKAB0WIQQWnetsC8PEYBPSx58Rpy6gFHHXcgUCZ/TNmgAKCRARpy6gFHHX cjUhEACQA8gdiny3H0cIs/eCXCdyJOM9rKhuf2+4gj2/MdJ4pjxMDZN3V2spjwTYGEBIvnaD2aw 8YI4+5YrJ/gacqwT5jdjBrv5M86+lRF5x86+aNRAFzrvKT1fp2ZQOSVCdFg5c/pDmPEU8HMJu85 eZM4/n8/sw0vlUHZ6wC5A3oX5Sbxxq0ODdGC1dCdre8Msr4AIZF9Rud/U0l/y22pDHy5AKDsEBJ 45mZjH1OmDd53+rAicyRRakUYgVM4hjGDmZuiAYrNQATMYnENj+DH367L8luvpChW7o8fHoDRZ8 SOKri5vWh0/qd01aZY1waCCyH/8jjdOf3v663xcAX+vBZg0z11mfZY544nqEXoIPun+NYhC9goA +elwZSvzY6TjL5X3SaNFiWSrcNSGObk3otEPfb1/Rys5r5iJNEucwjKiGjKDVc0/WJC9BLewaBE yHyUqES98sh2Ku2o6e40CjdKDsXHwa4Nu4U873+GjpDrypUhlpb83ax2OzzkXuHv4mvLvUQu9lx Op0AGrK6iBc7LT0wuW6I63145+LILkjBnDCErF8JdK9Kjq1HYTLQvslx8onmZ3l8ge9yrQfWCGV i29GbD3Msfrbsdl06ZuAND29xiKUyTaL39tudfMlz6CPR/ii5YZmxVuFSe0vVWBkc3Pxb7B/FM8 aL2+h9Qb3cin5zQ== X-Developer-Key: i=bartosz.golaszewski@linaro.org; a=openpgp; fpr=169DEB6C0BC3C46013D2C79F11A72EA01471D772 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250408_001805_658138_3D3BCEBB X-CRM114-Status: GOOD ( 12.27 ) X-BeenThere: linux-amlogic@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-amlogic" Errors-To: linux-amlogic-bounces+linux-amlogic=archiver.kernel.org@lists.infradead.org From: Bartosz Golaszewski struct gpio_chip now has callbacks for setting line values that return an integer, allowing to indicate failures. Convert the driver to using them. Signed-off-by: Bartosz Golaszewski Reviewed-by: Neil Armstrong --- drivers/pinctrl/pinctrl-sx150x.c | 23 ++++++++++++----------- 1 file changed, 12 insertions(+), 11 deletions(-) diff --git a/drivers/pinctrl/pinctrl-sx150x.c b/drivers/pinctrl/pinctrl-sx150x.c index 98262b8ce43a..d3a12c1c0de2 100644 --- a/drivers/pinctrl/pinctrl-sx150x.c +++ b/drivers/pinctrl/pinctrl-sx150x.c @@ -432,24 +432,25 @@ static int sx150x_gpio_oscio_set(struct sx150x_pinctrl *pctl, (value ? 0x1f : 0x10)); } -static void sx150x_gpio_set(struct gpio_chip *chip, unsigned int offset, - int value) +static int sx150x_gpio_set(struct gpio_chip *chip, unsigned int offset, + int value) { struct sx150x_pinctrl *pctl = gpiochip_get_data(chip); if (sx150x_pin_is_oscio(pctl, offset)) - sx150x_gpio_oscio_set(pctl, value); - else - __sx150x_gpio_set(pctl, offset, value); + return sx150x_gpio_oscio_set(pctl, value); + + return __sx150x_gpio_set(pctl, offset, value); } -static void sx150x_gpio_set_multiple(struct gpio_chip *chip, - unsigned long *mask, - unsigned long *bits) +static int sx150x_gpio_set_multiple(struct gpio_chip *chip, + unsigned long *mask, + unsigned long *bits) { struct sx150x_pinctrl *pctl = gpiochip_get_data(chip); - regmap_write_bits(pctl->regmap, pctl->data->reg_data, *mask, *bits); + return regmap_write_bits(pctl->regmap, pctl->data->reg_data, *mask, + *bits); } static int sx150x_gpio_direction_input(struct gpio_chip *chip, @@ -1175,7 +1176,7 @@ static int sx150x_probe(struct i2c_client *client) pctl->gpio.direction_input = sx150x_gpio_direction_input; pctl->gpio.direction_output = sx150x_gpio_direction_output; pctl->gpio.get = sx150x_gpio_get; - pctl->gpio.set = sx150x_gpio_set; + pctl->gpio.set_rv = sx150x_gpio_set; pctl->gpio.set_config = gpiochip_generic_config; pctl->gpio.parent = dev; pctl->gpio.can_sleep = true; @@ -1190,7 +1191,7 @@ static int sx150x_probe(struct i2c_client *client) * would require locking that is not in place at this time. */ if (pctl->data->model != SX150X_789) - pctl->gpio.set_multiple = sx150x_gpio_set_multiple; + pctl->gpio.set_multiple_rv = sx150x_gpio_set_multiple; /* Add Interrupt support if an irq is specified */ if (client->irq > 0) { From patchwork Tue Apr 8 07:17:46 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bartosz Golaszewski X-Patchwork-Id: 14042313 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D9562C369A1 for ; Tue, 8 Apr 2025 07:30:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:In-Reply-To:References:Message-Id :MIME-Version:Subject:Date:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=uQ3aEyLlz7TweJx5WamOpC3fQVPVkIs05R4OtUUQPBk=; b=IDohPaFl5bmLoH P6b/OOWn4Ox7uCcq1nEqvwWWq6Dbz70xyz1d3OTo8F2wZPdkwuHKP9ERBy1YWLcyIo8HJ94kzrIxS Rn3hwo31dqa6kZjZhv922gu2WUoLtFJuOo0yisy1GgDdhdIErT4TSX8I+EMmVKRDtAndgHXy8+TWh Ph2xr90FRdULwqGpTTvLwK9bDpkT4UYODFLX6ZjRJ6vQgYB6u4zoPQKAeAiqnkds1BpYhQPga2Vwr YRWjgmgHlO9ac+x3gmV217Q+koZ4G9azB8uEyCUMmM2DMc/mQHExLK8egdWvLG4JDo1sgA7JezmPf fDUpuxUWDair32hFByfQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.1 #2 (Red Hat Linux)) id 1u23Pf-000000034QO-2lJ7; Tue, 08 Apr 2025 07:30:27 +0000 Received: from mail-wm1-x335.google.com ([2a00:1450:4864:20::335]) by bombadil.infradead.org with esmtps (Exim 4.98.1 #2 (Red Hat Linux)) id 1u23Di-000000031k1-3Jf3 for linux-amlogic@lists.infradead.org; Tue, 08 Apr 2025 07:18:08 +0000 Received: by mail-wm1-x335.google.com with SMTP id 5b1f17b1804b1-43ede096d73so20959855e9.2 for ; Tue, 08 Apr 2025 00:18:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bgdev-pl.20230601.gappssmtp.com; s=20230601; t=1744096685; x=1744701485; darn=lists.infradead.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=5HVOt+4srGnvQwsP1v9+2VHPQ1xwkV/AAlcGkzlseiw=; b=TA9Oxg/CfmO1mA2TeThTBq/VCGMTMAk7uFwafrweSYmEdc+OgglsI6GoMMKm6pA6Sg mcCqKwAe5e//ZK5tCVk/JuKJPSt1Dvb8Bz9dYWx/aG0EezQJovhaARLTst0qLFa35xpO Tcx/82bIKwkrJa+amuaueflhdRJOLoM7VeZFoDvSAXHy3xl98A+yUjLK9ABp0/omC72R +/jue3Tm+Ai7oM07FN4eJ30hzO8TX/EXSXRKEH5GVqrOe9//mKkq82zoRkp8tHb4qIaN a/wtyIB6QQ2wut9O+F9sFbDupwd5x050VQYRgCd87Ry9/Y42ycktYOXCwuugcGj+wSbB NmGQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1744096685; x=1744701485; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=5HVOt+4srGnvQwsP1v9+2VHPQ1xwkV/AAlcGkzlseiw=; b=JTtM2cjAIHt7GrGK8zoMVhahedw0EYO3k6sg+SoVzxEi67wd5z9m8t3kVufsowZmxF 98OhwokgEajPiylrOwgI30/XKQTwmys3ThIIwovRA/+Ed/6V2Zy64qygfNMDPMnzNBxi rfT7Xp6rKKZJg/3P01CsQqpYDTf/xpK7Zw2anqlZOfX7HFoVdOTpXXdsBOOVw1K/Jvrp bH6qr8JmdIwbysv+Z7ajoyFilpQCWcVD/dnuxP4RT5KqyQFo0Qk5AWWqsngo9m4JSP7C Eto783Q+6i6V9zvo1G+loXJtugPX+K0ncvLvC9tVYJ82vw8rN/V9aRvQC2JGrDbn24nO RGTQ== X-Forwarded-Encrypted: i=1; AJvYcCX+zpGwgjrohp/oDiKcWHZ6/q/SGWaXTMzc+xMIOQ4Gm+JmUsVpxfcMWbQlJ0CkmGzJzn2RVH3JCcXRmQab@lists.infradead.org X-Gm-Message-State: AOJu0YwJbUyPyfsCDoqD6nQDoX0uRJYWXhzrdqooXyhjXV6jAlWD9XsC moEyZhS7jC0CTgOYIXg1teTDTMVQydnaU8XXIZ+a3i28/mJjgCOKe6Zpw6EJ2qQ= X-Gm-Gg: ASbGncuc/9T5/TVCg93ep3yyevBH5FnThHwnKBIZBnQTy2Od+JBncFWTlSxdkJIGx0b dYOEawp1/ThomqiHBDd1mBOyuGWc90qxMZh6kkueA5Udpy6BDgne2PaNg6JcN51782gP/Aikpbs qJX6gB/aW7nDrKfzS3gZbIomtr2CFWAID9myOpmad3gVtXfYx7Atksolx+0NTVysZpYjqPyGACZ 0GxbR6lfDKVnn8VRixtEnn/8U1PRS0MjwDWJzpSrmscoT3at4i12i+UvR9rZI7MHFq6ABV4Y3Jl 8CcHdYAM8XoltzjGMWROvuqtxJpfKMu0Y9e9dQ== X-Google-Smtp-Source: AGHT+IGSySduYIODYDDBNhKW+V8JxaftIxx0mbfbLM56e4WvjRuBEIilNZOQDJkJo2kY1AIOFFw1zA== X-Received: by 2002:a05:600c:1d28:b0:43d:7de:16e3 with SMTP id 5b1f17b1804b1-43ed0d9d18emr123594385e9.24.1744096684912; Tue, 08 Apr 2025 00:18:04 -0700 (PDT) Received: from [127.0.1.1] ([2a01:cb1d:dc:7e00:2adf:eaae:f6ea:1a73]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-39c3020d5d1sm14257694f8f.77.2025.04.08.00.18.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 08 Apr 2025 00:18:04 -0700 (PDT) From: Bartosz Golaszewski Date: Tue, 08 Apr 2025 09:17:46 +0200 Subject: [PATCH 09/10] pinctrl: ocelot: use new GPIO line value setter callbacks MIME-Version: 1.0 Message-Id: <20250408-gpiochip-set-rv-pinctrl-part1-v1-9-c9d521d7c8c7@linaro.org> References: <20250408-gpiochip-set-rv-pinctrl-part1-v1-0-c9d521d7c8c7@linaro.org> In-Reply-To: <20250408-gpiochip-set-rv-pinctrl-part1-v1-0-c9d521d7c8c7@linaro.org> To: Ludovic Desroches , Linus Walleij , Nicolas Ferre , Alexandre Belloni , Claudiu Beznea , Bartosz Golaszewski , Neil Armstrong , Kevin Hilman , Jerome Brunet , Martin Blumenstingl , Xianwei Zhao , Patrick Rudolph Cc: linux-arm-kernel@lists.infradead.org, linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, linux-amlogic@lists.infradead.org, Bartosz Golaszewski X-Mailer: b4 0.14.1 X-Developer-Signature: v=1; a=openpgp-sha256; l=1855; i=bartosz.golaszewski@linaro.org; h=from:subject:message-id; bh=spvpQCaMJt/FlIsnba8JPp3MhbofiKGgIiv9FJg4rZg=; b=owEBbQKS/ZANAwAKARGnLqAUcddyAcsmYgBn9M2agt3O6aR1vCS8hOqHTDKX4aiCLJ+nYrJpF NCIW4f85ciJAjMEAAEKAB0WIQQWnetsC8PEYBPSx58Rpy6gFHHXcgUCZ/TNmgAKCRARpy6gFHHX cij6EADKyrhyl0qDS61cTLux6MOWrF0i8ovx0ZQmpwIhr0Bg5B+CblqHxvZat19Nu7Z/KQuhoxa 5a4ZjXS8zPhwsmNHcJL8XmmCO7AuZyzbIw/dJAygTYI6OrSzueQYkwP5vZpAyxet7FuT1YH5JCw AKvK5JuGVvzXt/1+S0QhyqRa1DBk/r9qW/PGztC+Q+1JIP2r7feH6HlncUVIUwcUmAtz47d1GKU d9WdVpTnCDHkoQOSX43tLjkyf+bWEUz35UYdBYvlfQ691lbhiEgyJZo8cU56ecomEvyTazRrZel IPsNTSh1TYRxmQ/gG/yks6vYRor8W09Gaw0FrsS6r5ifS5/BdkYI0/W5gX6I54YDaQYReRflW6G e96ttMnq/Z8KuMsKIUEteJbJMqomGgb5fJ9q5gEIw3QafPDTn9G5b99Jco4HVa6RwDPA5/LAXmY ttBiDSb/t7dTmdHdHxNHdzkYKzwk2MxkH34FBOX0/wo+7HoCuAeePRR1D72+DhbDm40qtzwPhIW Tkd+O16r6I0zfcX4kMUD7znBhtCMNTTSCyKjzQofWO3wqRQmC/lxZU+m+9WjsnCobS2jV6bTGb/ 6HE1y+gTQLWisUWQCGbsYviBPph9oEM1aA7O3zarkvGGcMtGx5/W0bKBdZ2nCh/us7+xv45Qh88 jH2gOpx/XG01JmA== X-Developer-Key: i=bartosz.golaszewski@linaro.org; a=openpgp; fpr=169DEB6C0BC3C46013D2C79F11A72EA01471D772 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250408_001806_837366_9377B93C X-CRM114-Status: GOOD ( 10.19 ) X-BeenThere: linux-amlogic@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-amlogic" Errors-To: linux-amlogic-bounces+linux-amlogic=archiver.kernel.org@lists.infradead.org From: Bartosz Golaszewski struct gpio_chip now has callbacks for setting line values that return an integer, allowing to indicate failures. Convert the driver to using them. Signed-off-by: Bartosz Golaszewski --- drivers/pinctrl/pinctrl-ocelot.c | 17 +++++++++-------- 1 file changed, 9 insertions(+), 8 deletions(-) diff --git a/drivers/pinctrl/pinctrl-ocelot.c b/drivers/pinctrl/pinctrl-ocelot.c index 329d54b11529..fbb3d43746bb 100644 --- a/drivers/pinctrl/pinctrl-ocelot.c +++ b/drivers/pinctrl/pinctrl-ocelot.c @@ -1950,17 +1950,18 @@ static int ocelot_gpio_get(struct gpio_chip *chip, unsigned int offset) return !!(val & BIT(offset % 32)); } -static void ocelot_gpio_set(struct gpio_chip *chip, unsigned int offset, - int value) +static int ocelot_gpio_set(struct gpio_chip *chip, unsigned int offset, + int value) { struct ocelot_pinctrl *info = gpiochip_get_data(chip); if (value) - regmap_write(info->map, REG(OCELOT_GPIO_OUT_SET, info, offset), - BIT(offset % 32)); - else - regmap_write(info->map, REG(OCELOT_GPIO_OUT_CLR, info, offset), - BIT(offset % 32)); + return regmap_write(info->map, + REG(OCELOT_GPIO_OUT_SET, info, offset), + BIT(offset % 32)); + + return regmap_write(info->map, REG(OCELOT_GPIO_OUT_CLR, info, offset), + BIT(offset % 32)); } static int ocelot_gpio_get_direction(struct gpio_chip *chip, @@ -1996,7 +1997,7 @@ static int ocelot_gpio_direction_output(struct gpio_chip *chip, static const struct gpio_chip ocelot_gpiolib_chip = { .request = gpiochip_generic_request, .free = gpiochip_generic_free, - .set = ocelot_gpio_set, + .set_rv = ocelot_gpio_set, .get = ocelot_gpio_get, .get_direction = ocelot_gpio_get_direction, .direction_input = pinctrl_gpio_direction_input, From patchwork Tue Apr 8 07:17:47 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bartosz Golaszewski X-Patchwork-Id: 14042314 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id BE3E2C3600C for ; Tue, 8 Apr 2025 07:32:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:In-Reply-To:References:Message-Id :MIME-Version:Subject:Date:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=qZPHeB72rL3kXlDK9+fjA25MSsxNRrxyLMLrSrjnuMs=; b=37/jYn9xQDKqdn ihoeJ4ujKR+LCdwCao+DXheGkGO9KjP+liGK/0STHrtca65CVedwwXnN0qJ8cy4AOuApqWpxv5O0w +or7jgySMl9yrG2ywEk/MKN1DLMMD4MWJsASGAMMjB0omWmXml1RzyWVM2sQIOqzhB8x3KGtjj6ow 20S/z5YAh9QYdbhsHj7UA7b85Ffb3HXQhZKFVb8LJUg0XZ0OFan7BOqAkwifKani0tQN+/plcS35x sVvJOh+NnVRQVCejZCoqT8HSFc30SN+peKxPuKAP4D/2M2Ms9HZgWS4WHhSrD+V4DdxIc9pePIOpq 7HUxn8jJeBPyzcQdzeqQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.1 #2 (Red Hat Linux)) id 1u23RO-000000034ij-2pCY; Tue, 08 Apr 2025 07:32:14 +0000 Received: from mail-wm1-x32f.google.com ([2a00:1450:4864:20::32f]) by bombadil.infradead.org with esmtps (Exim 4.98.1 #2 (Red Hat Linux)) id 1u23Dj-000000031kX-3MRW for linux-amlogic@lists.infradead.org; Tue, 08 Apr 2025 07:18:08 +0000 Received: by mail-wm1-x32f.google.com with SMTP id 5b1f17b1804b1-43edecbfb94so32303095e9.1 for ; Tue, 08 Apr 2025 00:18:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bgdev-pl.20230601.gappssmtp.com; s=20230601; t=1744096686; x=1744701486; darn=lists.infradead.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=lsLjcRrGKuzDX9mvNJ2l1Pj3maW/MPJjpEEItwHgjBM=; b=dWBO1n+wU7VZglteaBDB7xffD1nLM3rsQdruTrGN0iRkuiV9oc/TUSCBygc5FSVyV+ p3jLuD4f+JM0L7nrvuWltFYv9cepzzDlnkOLl/fMrENnaRwQZ+LorqaGFGT0V6D3HsjD 1HJmNxsNMd7fY+qo5QVpfOUudyRT/qWLHviUcnrU5FU0lJ0ocfw/6QBs0/DlvCjesszm yPe8i5j5cvbOf6x6EVNNKUKDHujwE0gyZftSJhb/bFzWUDJ8u9gmzz4MM5xiaCpQT77V xC14orCqb8nlNSOE6ZSX7d3LsJuoGmVmG6tZhs9cGsr5leot995BbU2+Gkv/sZXE2NeL 5EEg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1744096686; x=1744701486; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=lsLjcRrGKuzDX9mvNJ2l1Pj3maW/MPJjpEEItwHgjBM=; b=EiGNAklvAns37BaC/1pXaTTg889cW5Ks7gQt6c9lQLlQHNFpUvut2qugZ1RLrD2DSG 2UfES+/CsPZzef3irooMMpjJwNtto1l+HGmw4+o+lU2CXz9Fz6diNtvXe5l6CWxx5JEz blA+Hqhdu1KrKCvR3QuTKsiODVQI7788n55ocHB8UcNtFvAEqQYmIJN+NxexobkrmxaJ cdlChceAp43X9GvwHM/J8Iv7CoKC/sHRuSqhqRaAYAhChJ9PkpzgBFxMsMsv08HhnOMl W4BomEZCYwbjAt0F+vfakaNIoCRQv3NqFz+H7YVEbkL6/v0sXxunFqtSPnCfrNUHX4dC 7YTA== X-Forwarded-Encrypted: i=1; AJvYcCWOYaWx8icJ6YAW1s4OsXBHWYQ1a4I0SEiKo37w4DHhJteE4PkLXrR5ndIBv5K4S+D38+4c6DJJ8/wBcFMc@lists.infradead.org X-Gm-Message-State: AOJu0YxtbKLD/NxMelxgYx34NipWN/0udRo7+xgkwU5wRTu4B9L5YD6u NSL9BvqEkYPJXRFdS1PgVTc7Bd/rsvJT55DUEP4A7/hl6lRqvQkmExJZxfpVmYU= X-Gm-Gg: ASbGncv98LvBCTkg4eEMZ5zRv5UWBeW9rjD32JP4w88PevujjGMEfdVpqeDfCZ/6M0g 5J+M8VTBOnlrVM/oZKIIDDfcurjG0oELReyUqurdEK3odtZVt1bwWjAkbxDiSdMR0pLGQhQjZHD GIsy2Hxo/WmCeG1Ks8y8QALK0rRN3TaqrwbZQMS3JNZaPwDWm+M2yWMMyPIVixQF+5APwWJsk5X KJiXrZrtZuq3jHA4nHTwt3ECMFV18r/6XHFC2eJ9qOKeJ8SBLE5VHXUttXfysEVihbYCaUO51H3 Uq2AGOL2PVWBRzqiT3xSwUKzDljr+QnGa9l3Pg== X-Google-Smtp-Source: AGHT+IFVLY1WNvAayiNBB006bFO4nSra7Yx4DcKw1yaLoj6yk4wJfEbc8yNlS2Lbk6qsNo9ohgkRog== X-Received: by 2002:a05:6000:40cc:b0:39c:142a:ed6c with SMTP id ffacd0b85a97d-39d0de66a15mr12602862f8f.40.1744096686025; Tue, 08 Apr 2025 00:18:06 -0700 (PDT) Received: from [127.0.1.1] ([2a01:cb1d:dc:7e00:2adf:eaae:f6ea:1a73]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-39c3020d5d1sm14257694f8f.77.2025.04.08.00.18.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 08 Apr 2025 00:18:05 -0700 (PDT) From: Bartosz Golaszewski Date: Tue, 08 Apr 2025 09:17:47 +0200 Subject: [PATCH 10/10] pinctrl: cy8c95x0: use new GPIO line value setter callbacks MIME-Version: 1.0 Message-Id: <20250408-gpiochip-set-rv-pinctrl-part1-v1-10-c9d521d7c8c7@linaro.org> References: <20250408-gpiochip-set-rv-pinctrl-part1-v1-0-c9d521d7c8c7@linaro.org> In-Reply-To: <20250408-gpiochip-set-rv-pinctrl-part1-v1-0-c9d521d7c8c7@linaro.org> To: Ludovic Desroches , Linus Walleij , Nicolas Ferre , Alexandre Belloni , Claudiu Beznea , Bartosz Golaszewski , Neil Armstrong , Kevin Hilman , Jerome Brunet , Martin Blumenstingl , Xianwei Zhao , Patrick Rudolph Cc: linux-arm-kernel@lists.infradead.org, linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, linux-amlogic@lists.infradead.org, Bartosz Golaszewski X-Mailer: b4 0.14.1 X-Developer-Signature: v=1; a=openpgp-sha256; l=2609; i=bartosz.golaszewski@linaro.org; h=from:subject:message-id; bh=nFz0ZQu1wB25C83nAY0bNQ02w+UniTfC+j0g7wZb9Vw=; b=owEBbQKS/ZANAwAKARGnLqAUcddyAcsmYgBn9M2b7PYpEd1QYwzkZOLJp94uziWDLFCT9+cRZ 6jtV1w9v+CJAjMEAAEKAB0WIQQWnetsC8PEYBPSx58Rpy6gFHHXcgUCZ/TNmwAKCRARpy6gFHHX cphiEAC83D/t8tFMiLHRxWuKzVZS6TAwB9yfLq3bsdR9gOgBqJaavIsx28w0liHuZZIj8w3UHJ3 te5PhEz/S5S7Osm2h1k+wsZovOT4+g7Tn/BqJ04NbpBDccfDwNlRHz9dp5oTqhX/I9BxlNdAM6j nw2qiHcJBTD+wKKdTworBCco10+UdxKyIVJZ1xIEUUha9S7j83VF0X/lo/D6JFLOPf7hVAxpMUg UAs4h9Zmbh+zfoE3OX3QPGFNlwtL/UHFHuKx8uHYrmKv0tOmFEJL2FpJ1Dpt21Ue0har4mN7d+z XYTh2aZ5lZBpTRONkVjKs17D58wvSoBeJSXBp60u0KOD5isuDZxUWicE89i2IY9+jkffOPFNBBj hwVA2QcAYCAUMMtWb4BzW4sg02wn+SwW/2TRCl5aUXcF7n+rRnYBTlfmliRX2kHJ3PA3532UUS4 0qF0kn7hDbX9yY7oX/aD3N97/Eyh9HrOfWH13ZdvF5Hh+MT56nrovr0kjLQFazEgd8IYV8CEPDg ZoCCrIrePRmAOUTYwyZAb/qrH/mEh2qLVE5EAVKijNbE+LV0QR4DWDglwYmR6LbjrmcfnyoOS3U 1/73A3TxYyCRipzULEk7VLJXFMw5u8ROVTWk+4s4XCehemi1NJRDj9ORfPUJMTW0b8refz8JnQW hv7fa/dGOTU4VTg== X-Developer-Key: i=bartosz.golaszewski@linaro.org; a=openpgp; fpr=169DEB6C0BC3C46013D2C79F11A72EA01471D772 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250408_001807_831420_571EBCB5 X-CRM114-Status: GOOD ( 10.04 ) X-BeenThere: linux-amlogic@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-amlogic" Errors-To: linux-amlogic-bounces+linux-amlogic=archiver.kernel.org@lists.infradead.org From: Bartosz Golaszewski struct gpio_chip now has callbacks for setting line values that return an integer, allowing to indicate failures. Convert the driver to using them. Signed-off-by: Bartosz Golaszewski --- drivers/pinctrl/pinctrl-cy8c95x0.c | 17 +++++++++-------- 1 file changed, 9 insertions(+), 8 deletions(-) diff --git a/drivers/pinctrl/pinctrl-cy8c95x0.c b/drivers/pinctrl/pinctrl-cy8c95x0.c index 3cfbcaee9e65..8a2fd632bdd4 100644 --- a/drivers/pinctrl/pinctrl-cy8c95x0.c +++ b/drivers/pinctrl/pinctrl-cy8c95x0.c @@ -742,14 +742,15 @@ static int cy8c95x0_gpio_get_value(struct gpio_chip *gc, unsigned int off) return reg_val ? 1 : 0; } -static void cy8c95x0_gpio_set_value(struct gpio_chip *gc, unsigned int off, - int val) +static int cy8c95x0_gpio_set_value(struct gpio_chip *gc, unsigned int off, + int val) { struct cy8c95x0_pinctrl *chip = gpiochip_get_data(gc); u8 port = cypress_get_port(chip, off); u8 bit = cypress_get_pin_mask(chip, off); - cy8c95x0_regmap_write_bits(chip, CY8C95X0_OUTPUT, port, bit, val ? bit : 0); + return cy8c95x0_regmap_write_bits(chip, CY8C95X0_OUTPUT, port, bit, + val ? bit : 0); } static int cy8c95x0_gpio_get_direction(struct gpio_chip *gc, unsigned int off) @@ -908,12 +909,12 @@ static int cy8c95x0_gpio_get_multiple(struct gpio_chip *gc, return cy8c95x0_read_regs_mask(chip, CY8C95X0_INPUT, bits, mask); } -static void cy8c95x0_gpio_set_multiple(struct gpio_chip *gc, - unsigned long *mask, unsigned long *bits) +static int cy8c95x0_gpio_set_multiple(struct gpio_chip *gc, + unsigned long *mask, unsigned long *bits) { struct cy8c95x0_pinctrl *chip = gpiochip_get_data(gc); - cy8c95x0_write_regs_mask(chip, CY8C95X0_OUTPUT, bits, mask); + return cy8c95x0_write_regs_mask(chip, CY8C95X0_OUTPUT, bits, mask); } static int cy8c95x0_add_pin_ranges(struct gpio_chip *gc) @@ -938,10 +939,10 @@ static int cy8c95x0_setup_gpiochip(struct cy8c95x0_pinctrl *chip) gc->direction_input = cy8c95x0_gpio_direction_input; gc->direction_output = cy8c95x0_gpio_direction_output; gc->get = cy8c95x0_gpio_get_value; - gc->set = cy8c95x0_gpio_set_value; + gc->set_rv = cy8c95x0_gpio_set_value; gc->get_direction = cy8c95x0_gpio_get_direction; gc->get_multiple = cy8c95x0_gpio_get_multiple; - gc->set_multiple = cy8c95x0_gpio_set_multiple; + gc->set_multiple_rv = cy8c95x0_gpio_set_multiple; gc->set_config = gpiochip_generic_config; gc->can_sleep = true; gc->add_pin_ranges = cy8c95x0_add_pin_ranges;