From patchwork Tue Apr 8 15:15:47 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Uladzislau Rezki X-Patchwork-Id: 14043188 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0FE1CC369A4 for ; Tue, 8 Apr 2025 15:15:57 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 2E6CE6B002A; Tue, 8 Apr 2025 11:15:55 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 298156B002B; Tue, 8 Apr 2025 11:15:55 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 15EBF6B002C; Tue, 8 Apr 2025 11:15:55 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id E78766B002A for ; Tue, 8 Apr 2025 11:15:54 -0400 (EDT) Received: from smtpin04.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id DDD4E80DA4 for ; Tue, 8 Apr 2025 15:15:55 +0000 (UTC) X-FDA: 83311226670.04.DDCB4AC Received: from mail-lf1-f48.google.com (mail-lf1-f48.google.com [209.85.167.48]) by imf13.hostedemail.com (Postfix) with ESMTP id 0F72E20016 for ; Tue, 8 Apr 2025 15:15:53 +0000 (UTC) Authentication-Results: imf13.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=Z23AkQHy; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf13.hostedemail.com: domain of urezki@gmail.com designates 209.85.167.48 as permitted sender) smtp.mailfrom=urezki@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1744125354; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:references:dkim-signature; bh=pjI1b2spCBCPygGiM6HRgXBUJIW/FFg35fPOa9S+028=; b=HyyxKB45tCwV5ODvEHZrgAOb9Ym1JUZ+qIiICHuv16HIj8VpzCGNTFLvuZpgFFIC0Dlf6s q7rv4TJnMM8mDyX3g0dlQIlv+gNHjs3yj1AW5BtnAge9oJxuywXdEAorKZsWOSp3hLDTT+ tmlOvWdAeTB4x98sBPSAfsTeSpsxdEk= ARC-Authentication-Results: i=1; imf13.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=Z23AkQHy; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf13.hostedemail.com: domain of urezki@gmail.com designates 209.85.167.48 as permitted sender) smtp.mailfrom=urezki@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1744125354; a=rsa-sha256; cv=none; b=fdfuhhpCiqWsMFUfQ+CxipiWyR248wjlKGlkJ4zyV4oGVc4/kULwu5e32rKDvyFbi/inp8 eX4CRHZPWWOrtJLR7WyIy4ptTjSjTYw9hoQRmjobDQXFDY8ovCp5ci45eYkgKtMCy2VG6D 7Dzzq/0maLYKBFVDNSVwmTqO1grDKOY= Received: by mail-lf1-f48.google.com with SMTP id 2adb3069b0e04-54963160818so7127337e87.2 for ; Tue, 08 Apr 2025 08:15:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1744125352; x=1744730152; darn=kvack.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=pjI1b2spCBCPygGiM6HRgXBUJIW/FFg35fPOa9S+028=; b=Z23AkQHybV3mQ6uQOSI1FtgzWSEe2/dq+WGt1G9t5z2RjIUC+nKIqKT1/VNEiIthFV pBab4Qw3uTlPolG/nuo7rb8zuTwZDHJpsZsAJCY0yGJmKgnNJMYaKz9E07uqxhpESxOT VUkU/xKAy5o6o+9IENiPSkkKqUeKB7A00n9pM88Zt9zlaDlQitXxX1Up+ioFM9Gcwx2n wTkpsUvzg+prYySht88jkzMguEH+AtfA6TT+1fkpz3kAXMfmjiDPRX+lEHNNew4Llt3Q v0dPqN5CvVpD6bULKGmODUXqSW+naOtWbYHQFJ2UfTV5YggBWr5mkQja0NzJVvNU3/e0 3CWQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1744125352; x=1744730152; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=pjI1b2spCBCPygGiM6HRgXBUJIW/FFg35fPOa9S+028=; b=UY8CX4BXTkMaaf9S/By5WvTc5auvmCyor3pivWIR6dQyDA7Ua0JYVAAXxjBrCPn4O0 jQQo9GHxf8wZr/AqKAL2LCJ1nfTdESIfUAW4G1LTYvZyu0P6tYfRrI7aPKL+KlFZ84rH Eq/weykWwlZNGSljKyR9SNtDW5J7cs0QfbAQDEcfFos5eMHewRxrEho1kzAzggtl8glL GMeAKmC90nFsV/+gARyrHXn2Yr7Flnl9+hyKwNzLX+MjzuBdAAtIXodNANWXfUq+YRzp DUiq9du+MlKV3IslsrDIn/QdxACoy2ytQOGRslMD7UMI9TSwljp5mQ69+eA7iM9uoiyS eNxA== X-Gm-Message-State: AOJu0YyZCnu2fie97Nidd6ArZ04ewfMK+XvZP9WBLZGU+A7cqQ3kgmdX OMGRoxKclk4l4KmRLeM6ykZnLLoEEmgcZLflaqxoLCF1Ux2UA6qJ+CHr/Syk X-Gm-Gg: ASbGnctX2v9W8SgcnBdpl8ygDyNazkr9Vj3kx18xkuhm2J64wcmCNJMq/yodU9zVbGm JxQ1SIBZhCuf5ChHQixEvzGTEu4gEXBJlIUZaj8XePwHw7uPwEGCO7PN+T5PvoDEpsOUaHMbl0A sYoLa+Kxh52cpUr1/evskBFTzLMw5TKGKaFC0P9ZlWmruk5J3d1NBbUa1iOMn1Xv4y7f0XqpG5A SUQ+HpWkf9WvryZBZRrRC1JXQ/j3H3PoKPDnxoXqOk0ds64lkc3qWKV1FEX6h3M++O9w0sb+AfF DxHxwmU6rKJii564laW8Qa07RjSvSBu9F/71LBWq X-Google-Smtp-Source: AGHT+IE5UgLce1CQFdWXTbdofd7Mybd692NItZFZpyyUK2Ug2JYAskRQb4EDLK6PRjY+sJHYePT5zw== X-Received: by 2002:a05:6512:2250:b0:549:55df:8af6 with SMTP id 2adb3069b0e04-54c2335dcc9mr4505739e87.53.1744125352043; Tue, 08 Apr 2025 08:15:52 -0700 (PDT) Received: from pc638.lan ([2001:9b1:d5a0:a500:2d8:61ff:fec9:d743]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-54c1e65db49sm1548603e87.206.2025.04.08.08.15.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 08 Apr 2025 08:15:51 -0700 (PDT) From: "Uladzislau Rezki (Sony)" To: Andrew Morton Cc: linux-mm@kvack.org, LKML , Christoph Hellwig , Uladzislau Rezki , Oleksiy Avramchenko Subject: [PATCH 1/3] vmalloc: Add for_each_vmap_node() helper Date: Tue, 8 Apr 2025 17:15:47 +0200 Message-Id: <20250408151549.77937-1-urezki@gmail.com> X-Mailer: git-send-email 2.39.5 MIME-Version: 1.0 X-Rspamd-Server: rspam11 X-Rspamd-Queue-Id: 0F72E20016 X-Stat-Signature: dkjy1enfheq11ykt73fk7f8aase7qjmg X-Rspam-User: X-HE-Tag: 1744125353-32153 X-HE-Meta: U2FsdGVkX19/8YNiPYmwfkwAcpuamsryd6JNFtEs7nJ6VaMgZ6vdU/0RtLzlAn6gnV/+As+chFSVWOTiVncDvSm3atEnYPji/5BmSuEkSW6U5zszFwGBKFWWvY405JDADZ7RSLuPTof8Q3DTO3Yy6tHwck3hbbhyBjv9WcRomPWY/v7hnf8/9VoPoM6Hd+1ZxJfslsDJL6FrSc8J9gzQFFstRRVUnHFvseCYGskUhwY/nSypw0rEx6izvQFQ017vHwyZ5UXiFoQiRZTJDecAWGtpLeBx8fiYT7szAF14PwV53ZyDYzVNItOXJmNQdvNLJMmFFGHsBw7NQxT2qPJAClRv6+pPpF9eGmFKGq9MY83ZLeVDmMT3AoNmQ60K+rbiNeD9t8Q77gpwrDurF5JUHyHzIkAYfIflel3FfGu7VPkQWTi/eJ9BdejJyOaNER6Ydl/dqs9l5EiExfTIw94wjc36oPpxxXpp9XYuAdYQ2Achz4lNLCg0aOvi9W4kMChY3Lf8JQXlT47h7SsxB1tY/Mtsd1gXD53vlwd6hyxToGGuFYPDbQWIE11dMlNVdn3Ny/+LEMgw7Mq3Bh56WZcl1FJ9i+aKln0djg3jg7WSiSIt6wJ1fIHIsENVxKZSVfVRXhVaiGAYB4d7d3/1mwyyPEg2UGCyNF9v5A9gguqrbjHHgS7BKCjVUzoHxOp1Xhcq1B6/Im6kkX7FY/PPLu3KOmrpLs31kLhpTaJStkjnSpXRKSl7iUpGEj8791O47BOUQ5THraF5BwOYHgoEY1r6gGO4vhhF90QPDGWOIKRuQGpG/wcKX4qlW5qtlo+2OwWzMldvbePa9sof+YZlzHtAonHEL9LRBZMwUXKIVI60jszHpflhiO2rYtxsUMTkadrzQukqmE6C0QIiVrQfIPr+T2zZ+W1poubAwrnE5hGPmhcBKaFqtQCv8SekIo9qrxc0/5NzTWCCxrpUOgk+wba aw00tn4E o+X6s9iYwviuOVCAG44j91T7B7zEbJbMdI7mJFCPYDwAXmutCK36CJaQCwXo1PZdLcWL8+TeCcDCkzFMhOO51SR1IaIPLtiCiCDZrt3vnn1XFyAHPXLLLJdabyWE78LIO9Bj10gnJ9uqZkWOhgxq0o4C4vf2SMCPUyX+17FZI4JJgzJvFQNTKxMoMbE7SeJIOMDWKKEl+ocobRsUdbfHXaCOWNwWMhK8byv2U8RFpn46nNlb31BPPR9P9nZkMFuUuyCGgJQh0M8PaCxLOvlEMfbHrqinSoWqJrz9FKQi2mAti0VYvVdW/gUvGEucxNZ+QGonHKkAAUxwN4Ex0Y7+Y3IQgLvl+BdWx9y2wWVLsEOKrBS8YqOCnATdC+JBJxFBuCCpFZHvghyMTP4YXsTkA0CoPADtZOQdxLN6ssGmjBRTviTM= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: To simplify iteration over vmap-nodes, add the for_each_vmap_node() macro that iterates over all nodes in a system. It tends to simplify the code. Signed-off-by: Uladzislau Rezki (Sony) --- mm/vmalloc.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/mm/vmalloc.c b/mm/vmalloc.c index bcc90d4357e48..e42ea20713dc7 100644 --- a/mm/vmalloc.c +++ b/mm/vmalloc.c @@ -900,6 +900,11 @@ static struct vmap_node *vmap_nodes = &single; static __read_mostly unsigned int nr_vmap_nodes = 1; static __read_mostly unsigned int vmap_zone_size = 1; +/* A simple iterator over all vmap-nodes. */ +#define for_each_vmap_node(vn) \ + for ((vn) = &vmap_nodes[0]; \ + (vn) < &vmap_nodes[nr_vmap_nodes]; (vn)++) + static inline unsigned int addr_to_node_id(unsigned long addr) { From patchwork Tue Apr 8 15:15:48 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Uladzislau Rezki X-Patchwork-Id: 14043189 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 37054C369A5 for ; Tue, 8 Apr 2025 15:15:58 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 66FE36B002B; Tue, 8 Apr 2025 11:15:56 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 5A8B26B002C; Tue, 8 Apr 2025 11:15:56 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 35F6B6B002D; Tue, 8 Apr 2025 11:15:56 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 122AF6B002B for ; Tue, 8 Apr 2025 11:15:56 -0400 (EDT) Received: from smtpin01.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id EA28F1CB2B7 for ; Tue, 8 Apr 2025 15:15:56 +0000 (UTC) X-FDA: 83311226712.01.65DAC33 Received: from mail-lf1-f53.google.com (mail-lf1-f53.google.com [209.85.167.53]) by imf26.hostedemail.com (Postfix) with ESMTP id 084C2140016 for ; Tue, 8 Apr 2025 15:15:54 +0000 (UTC) Authentication-Results: imf26.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=AD+6+8Cr; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf26.hostedemail.com: domain of urezki@gmail.com designates 209.85.167.53 as permitted sender) smtp.mailfrom=urezki@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1744125355; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=KsXh5DQxErvfpk4smRVJmZEnTcpSTG4dia/PFYIhGps=; b=0QSC/TI4tZ1Kghzs1vTm7Gw8XIxuFS+Q8FWPZ10F6p6tyC7zWpHm//mxiT1G/BMJuGdyRB VGA5FeUhjRMEEUi6mJoj7BymuC+6oFab4rdsgDNg/iPrdpEyFSH7NHPYgUq7HYuAfnToXL 8QcmoB4c1xhUgXfJApbbL/sI+wVWvOs= ARC-Authentication-Results: i=1; imf26.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=AD+6+8Cr; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf26.hostedemail.com: domain of urezki@gmail.com designates 209.85.167.53 as permitted sender) smtp.mailfrom=urezki@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1744125355; a=rsa-sha256; cv=none; b=rwm8ud/4lWqjyYzJc69D1Lh0PKI7ehGVuyZAgyJSINvwC+cIgvmJyOMaQDfp9hAzmMtgHB zenpYXTRiE7P7oysfntnegeORlZ8ehfCYWVfuMDHwjPtOQnpJreg3gB6cH3Lsc1PrkSSzF bvvbiQvYeyFu36zGkebyjW1/2vcFsAs= Received: by mail-lf1-f53.google.com with SMTP id 2adb3069b0e04-5497590ffbbso1499602e87.1 for ; Tue, 08 Apr 2025 08:15:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1744125353; x=1744730153; darn=kvack.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=KsXh5DQxErvfpk4smRVJmZEnTcpSTG4dia/PFYIhGps=; b=AD+6+8CrIbd1nSsMp+GaP9otlPVsdJCprKqvVfwPcaJoqZKxpV2FMd5vFsQe7Na+ns 7Sigxg9ezkzC9EMna37UJoVZzqRn6DVSCtOsiGisxDHJjRXekxHw9P53kH7mSaCtJPeV OO1CKVINI9BgqLl/AvK5TyI2P2GuRIh3t0sdtUiTyv9wuThmn891szduB0SBS4Z/9CbJ IpE1h1kAKHpptwo1Q9dsAgJaf4ujQ4pqrr9k3WCQq++FoJeD+Gb18W69bqwo8qXVCenB loNlAmqEu0yZxUPHE9fkXJN8E6BM9FbGxtlOiaImujqBEalCngmeah8DnAfP0QNN07c2 vzjA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1744125353; x=1744730153; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=KsXh5DQxErvfpk4smRVJmZEnTcpSTG4dia/PFYIhGps=; b=qrCsE8iHht/GsCSw06uraI6USBXtd344rlM0ESRSNQp4xhaTeGCUHsE9qa0p7Hml5W IuCA/1qD4j2kaEQEyeXKNysvjhQAkOEAxJfbnrRupG5myrBEZaXyFl6LtvYHu8TP7zeO CCUrR1stXn6nXxSTlkQ3c7Gw4f5VbXmklPNYUr/6EzjhKfS5pBULRpbS240eJAvglOog dcnQY4RWx9puODy1/pyxndzoKwK3usU/jEh1vSj7fRTbws1Ur01/PNrKgfyYta9lwytm ceoKEd6FL2m25LWN7VuAsZnMsCZjNyMakSElD++jWraXFOz92840n6jS9SiWotYTLuas 3D2w== X-Gm-Message-State: AOJu0YzFjjHyCMz4pyiI+GIkHA2OYl7rTaKngNGuxJgeD28Hv8EUl5Li TOu/WBG0ydTV4MTApKiAyWjOOAS2zxSCKDMAeYzI0LglF6xhzVSC X-Gm-Gg: ASbGncs1SEJUpqARwuXhx/g6oCt+KffZTFcREaXiPxDDZmYPGzKv3p2r0zMJBdGmTsu DBE2FIyaMeal3Vd8Oq5XWR+bWEzS6Ak4FQSXtAALWI0shy9U9JQGNcQ3vg5/c5ytfMxhmXZg6Rx yUNkP3DMBLTr3dVxME2htXReYkvCprhiVitTTmZIrBGdwyBGnbZe1xWzA+CnXTJu1WVcDxpN/Kb XdMB/okCdeRvGb8H43jcno4maoFzuWrauym6gSW5JHK8HTIWqHmQ+S+98eWVMwAaA7g0r5XM0ZQ RhlQ+TfgYD6g4tAXyUK3Q7D2rMFQawjdpT7XFA12 X-Google-Smtp-Source: AGHT+IG3TspJwCuKgEmft6MBazVSp/G5+tumxJQNv+3l09dfWKlmBOe4Xrw0OAYyhJ1p2HPzq8wT2g== X-Received: by 2002:ac2:4bcc:0:b0:54b:ec1:63dd with SMTP id 2adb3069b0e04-54c232e259dmr4514605e87.20.1744125353086; Tue, 08 Apr 2025 08:15:53 -0700 (PDT) Received: from pc638.lan ([2001:9b1:d5a0:a500:2d8:61ff:fec9:d743]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-54c1e65db49sm1548603e87.206.2025.04.08.08.15.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 08 Apr 2025 08:15:52 -0700 (PDT) From: "Uladzislau Rezki (Sony)" To: Andrew Morton Cc: linux-mm@kvack.org, LKML , Christoph Hellwig , Uladzislau Rezki , Oleksiy Avramchenko Subject: [PATCH 2/3] vmalloc: Switch to for_each_vmap_node() helper Date: Tue, 8 Apr 2025 17:15:48 +0200 Message-Id: <20250408151549.77937-2-urezki@gmail.com> X-Mailer: git-send-email 2.39.5 In-Reply-To: <20250408151549.77937-1-urezki@gmail.com> References: <20250408151549.77937-1-urezki@gmail.com> MIME-Version: 1.0 X-Rspamd-Server: rspam01 X-Stat-Signature: o9r4xa36ohhkmmgbgi11q5wmcffz8x3k X-Rspam-User: X-Rspamd-Queue-Id: 084C2140016 X-HE-Tag: 1744125354-82612 X-HE-Meta: U2FsdGVkX1/WUBZ9iIH5HRC1ZfyZudDDo5AjwjbDdG6KT073yEvrpJR8wrc0OmXAo4RsWhBGLRZ/KDcD7yWLO9NWYr55f4rNYVC3VgO2x49zwY3ZjF7SmPXsaSKEg+0PgOj1G0rJv0f4c4kq4gRIXM+VWukUfwbbfs55mdfnICjo3KZa5jEpufyBgKacBx/nDlN6LYWMVNM4EFv995UTPswIquz7Y5uVTlgutO+A6bIkNy1iznPVYuARo6bKeAchPTIkZs3Xo8EmesanXuP0XvA+0Zut9NULoG6eHulqx7sSzCqBHP/ChmbxbFgJ8vWi1ILSUCSJFpC2bKR0IBRvAndtNeMGty9+y4/4cHoZnJObxyDC9YqUlYoUGvgo67ZoVt2Cr2s90MbiqdjN+/V1LvrAAUHOGMyuZDsnUW0D3QRygWsjp8aC9XUOk6CdwvUwQW2N0tqFaSOAcK3BZJ8yM6O+r8/26n90VZYJaWSDxIbhWpjDJv8FK4lS2dCO7JiL5hqoALa1sOp8TWRfwSOBYbJaeqjHgDJTpmCm/QzND7UmOW1dD/vTKMKa8SvGhtBeIMDjiWxTXzp7AkDbxaGvJlpq1KYybmkuLqCohu1PBFjzZ5EXOfbbv1OMe1OGgSNuUwH0AYX7fop/bAxw74RSSgWyNic5EBNkKUNCDhK/IIQk+tFoeblG37dOfs6EAiN5H6XewTO94eg7pfQzY9f6D8SEZxBawsYClYmNgQEsY114c3MYfogcTIChoT6B7eoiWTYpOBKOye2jEhTR/w5hZxz93rYCgFzZLFjcZpQ16y3JJr727vgXsqYdg7najJFIOYdaGu94XsUT+1cBdattaBpPeM3GNlPKBNaF7cZ4jz+2Km5aI5Brjyz8FwfEXssTGoLeWzIcitmgAde4sKPnCK7WjZug6mPIH8s20xcF88cBbsPT35eOqeEmPQ2gdoXUqNc82BnwA9CgswCO3E6 8GHaiSAs QEZ7zMC0rSCq3K8Mnc8zssFLI5gFzwcFWqONdxVwk7BRF/cgyNjsyTlSgS/dRlqSA/Pi43vX3mP6K+uuQ8MH0j2F4B3dDXBDDBa3hlcvVdvYCaUvy4ATJtflEDV597tELAefTgrp6oWtcdZ5e99PlEfpW/Tm3pSgarNKd6hA7e9aw/c293XEfvf2sKnsX81/lnI81uZjXs7lD8jCMMAXvrdXmNyyV0SWISi2DwD0JgaDXxWysaDKCWf8qdiUbFvlpOoph236UO4nIXxowP+dM+tVcaiWNy3TkW+Q6GMInSAkKYA1B12J+gGmbtYc/jki+a8IhMMcwAdJN/OClG/LEGKtNVvAckVocbtQJpsZ8nOyatjMq53TED9IDxS2gr3o25qnlGB24NEPawbejGoG4eevVMpJmn876+kocecf418vFIJQ= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: There are places which can be updated easily to use the helper to iterate over all vmap-nodes. This is what this patch does. The aim is to improve readability and simplify the code. Signed-off-by: Uladzislau Rezki (Sony) --- mm/vmalloc.c | 36 +++++++++++++----------------------- 1 file changed, 13 insertions(+), 23 deletions(-) diff --git a/mm/vmalloc.c b/mm/vmalloc.c index e42ea20713dc7..3ff9acd64c077 100644 --- a/mm/vmalloc.c +++ b/mm/vmalloc.c @@ -1061,12 +1061,11 @@ find_vmap_area_exceed_addr_lock(unsigned long addr, struct vmap_area **va) { unsigned long va_start_lowest; struct vmap_node *vn; - int i; repeat: - for (i = 0, va_start_lowest = 0; i < nr_vmap_nodes; i++) { - vn = &vmap_nodes[i]; + va_start_lowest = 0; + for_each_vmap_node(vn) { spin_lock(&vn->busy.lock); *va = __find_vmap_area_exceed_addr(addr, &vn->busy.root); @@ -4946,11 +4945,8 @@ static void show_purge_info(struct seq_file *m) { struct vmap_node *vn; struct vmap_area *va; - int i; - - for (i = 0; i < nr_vmap_nodes; i++) { - vn = &vmap_nodes[i]; + for_each_vmap_node(vn) { spin_lock(&vn->lazy.lock); list_for_each_entry(va, &vn->lazy.head, list) { seq_printf(m, "0x%pK-0x%pK %7ld unpurged vm_area\n", @@ -4966,11 +4962,8 @@ static int vmalloc_info_show(struct seq_file *m, void *p) struct vmap_node *vn; struct vmap_area *va; struct vm_struct *v; - int i; - - for (i = 0; i < nr_vmap_nodes; i++) { - vn = &vmap_nodes[i]; + for_each_vmap_node(vn) { spin_lock(&vn->busy.lock); list_for_each_entry(va, &vn->busy.head, list) { if (!va->vm) { @@ -5123,8 +5116,7 @@ static void vmap_init_nodes(void) } #endif - for (n = 0; n < nr_vmap_nodes; n++) { - vn = &vmap_nodes[n]; + for_each_vmap_node(vn) { vn->busy.root = RB_ROOT; INIT_LIST_HEAD(&vn->busy.head); spin_lock_init(&vn->busy.lock); @@ -5145,15 +5137,13 @@ static void vmap_init_nodes(void) static unsigned long vmap_node_shrink_count(struct shrinker *shrink, struct shrink_control *sc) { - unsigned long count; + unsigned long count = 0; struct vmap_node *vn; - int i, j; - - for (count = 0, i = 0; i < nr_vmap_nodes; i++) { - vn = &vmap_nodes[i]; + int i; - for (j = 0; j < MAX_VA_SIZE_PAGES; j++) - count += READ_ONCE(vn->pool[j].len); + for_each_vmap_node(vn) { + for (i = 0; i < MAX_VA_SIZE_PAGES; i++) + count += READ_ONCE(vn->pool[i].len); } return count ? count : SHRINK_EMPTY; @@ -5162,10 +5152,10 @@ vmap_node_shrink_count(struct shrinker *shrink, struct shrink_control *sc) static unsigned long vmap_node_shrink_scan(struct shrinker *shrink, struct shrink_control *sc) { - int i; + struct vmap_node *vn; - for (i = 0; i < nr_vmap_nodes; i++) - decay_va_pool_node(&vmap_nodes[i], true); + for_each_vmap_node(vn) + decay_va_pool_node(vn, true); return SHRINK_STOP; } From patchwork Tue Apr 8 15:15:49 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Uladzislau Rezki X-Patchwork-Id: 14043190 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 21C3FC369A2 for ; Tue, 8 Apr 2025 15:16:00 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 0A3B66B002C; Tue, 8 Apr 2025 11:15:57 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 02BF46B002D; Tue, 8 Apr 2025 11:15:56 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E35776B002E; Tue, 8 Apr 2025 11:15:56 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id C829D6B002C for ; Tue, 8 Apr 2025 11:15:56 -0400 (EDT) Received: from smtpin18.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id DE3D1BAEB7 for ; Tue, 8 Apr 2025 15:15:57 +0000 (UTC) X-FDA: 83311226754.18.6B1F15F Received: from mail-lj1-f181.google.com (mail-lj1-f181.google.com [209.85.208.181]) by imf03.hostedemail.com (Postfix) with ESMTP id 05F502000D for ; Tue, 8 Apr 2025 15:15:55 +0000 (UTC) Authentication-Results: imf03.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=fqJ24MsX; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf03.hostedemail.com: domain of urezki@gmail.com designates 209.85.208.181 as permitted sender) smtp.mailfrom=urezki@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1744125356; a=rsa-sha256; cv=none; b=thGOaMYU8O57JX7h0MsG3Rd1Dd2rboMGeutl7V9pUso2d7vIfosoZNz0epJzLyWl8jyirM XQMgZsV0N1p8y3G6EQcMLdvw8Qc81zI/wEWZYwh6c6NJ3lkvP6rwKaMLvyo7QqXVMIpcfr jLR/oQMZc2tZF39FfX1jNXqq3SpC4Z4= ARC-Authentication-Results: i=1; imf03.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=fqJ24MsX; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf03.hostedemail.com: domain of urezki@gmail.com designates 209.85.208.181 as permitted sender) smtp.mailfrom=urezki@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1744125356; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=C987dsaCFSnQpOspzfFowBGnUvHHdcohVT9+02heJfk=; b=DTrKIAzN3lQv5hxu9KoEOWX/vVOl3QyLd00kziVJaJKTM9lcjtQrBzuf08lU32Z4nuQmjd 8eEM6GfOUi8CLEeyxaIGO8lay3hZ/cis3Sr68pB7SF3q+4+bOHEnpSJcytwyK2vcCnUSgr lreoea2gGjg6Ed6N/rLeS+6iWeL9PkI= Received: by mail-lj1-f181.google.com with SMTP id 38308e7fff4ca-30f30200b51so15991261fa.3 for ; Tue, 08 Apr 2025 08:15:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1744125354; x=1744730154; darn=kvack.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=C987dsaCFSnQpOspzfFowBGnUvHHdcohVT9+02heJfk=; b=fqJ24MsXqHqt4SdJvPPxGNVL9IGDEBDh93Hv75YSI8H7L7sLfwMm3zfdytYgJtVP14 JtXNNgmJywiBuiDpQGo1QRLawrRV1uMWQgQEQJu+aWd77R0BPzxt0uusk3NmHg2VCwJo C8N0fylgxngWJJ4o/uDGoNo49ac/iEKtLG2qTkEdXTb9Rew6xND8w56hDFRomkJeHxLh JwrQwXwYejzLrceuhs3U14y1a95w3+4hieXxMOTOnDDg9OamOSzefhbGrTK/QHz8PFYz JSgKAhRYmpIwE/mwn9qZHnNNuol9vA06wpTpTTMI5M0g/d3S/nMppbh8uPD0mwpY/GsA BqBw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1744125354; x=1744730154; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=C987dsaCFSnQpOspzfFowBGnUvHHdcohVT9+02heJfk=; b=s/+2y7PHIZIH6HXyx/8EcrPyX+Jgl18N/GtGiEH2o1rDbKE31YjLrvQCc+NDp6r5YY oew/BwbKDnHUMX+/CYN9/+RVy4/4SYuYPGEQ7oAcEbP6MfffHjt/3L30/qcJ1/Z729BB ybwrb8q12ZEW6yfU5F6RefhMD70cmQodr+RVt0sgZlrc5sO5o0JBPGXl608oQJGHDFjg cd9jKlkXv0/Uk6lZs+NDpxIU+9mNBKly8tyZY6x0gju1DS2mLKk5buTu/lXSt+VS/le7 1WBKP47FG7o88gY9ESYjT87LwhpwA448E6MAFx33HDPXeda1cQHnKkY7iwGlhO9RLYnK M52g== X-Gm-Message-State: AOJu0YxBN03Gml8chsDYlPYxYkGLSRJHVBVWhaXW1uoERK+Y4GJwgeU8 A7p55nmkvRAhyhX9/H5O8NGyF8JtQXYaHTwXSKY2tUpkrjLCLzAC X-Gm-Gg: ASbGncv9CAS99kWDL2s4E8JtNcyw8uQ7rGZ1PIb1ukcvwC7hqRhry1u2YXufRbdhdMI 2BgPQZhld6yi0gli0ZOR/rVLUxep7+ibRIHc90o/d7dhrXtpSXQRkBZFE438Ao0eLFnswj+9yPV S6adIN9Gr7B+7LFUg5EzinxJXBLtRJgl/XyvpzlLni1fWxsmNfcbcMeT/j9WDCocMOG2rvDYGdz nuzp8QIl3hw5BPgaBulwhy/27ez6kXGePguiOWuycMS1DWEgRVql+vP8JkZyXzCorLxSasf3JFv VennZ4Kw7x/ozTjJJ8/n7DN/P2of6wdpzfOruh2F X-Google-Smtp-Source: AGHT+IGSF2HnP3yRze+As2thftbPhIbuKmnguOUsoyY3r1XcM9ZtXg/ca94vPr1eGcrAnz6wMQyT7A== X-Received: by 2002:a05:6512:1154:b0:545:2f0c:a29c with SMTP id 2adb3069b0e04-54c23346c48mr4241134e87.36.1744125354157; Tue, 08 Apr 2025 08:15:54 -0700 (PDT) Received: from pc638.lan ([2001:9b1:d5a0:a500:2d8:61ff:fec9:d743]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-54c1e65db49sm1548603e87.206.2025.04.08.08.15.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 08 Apr 2025 08:15:53 -0700 (PDT) From: "Uladzislau Rezki (Sony)" To: Andrew Morton Cc: linux-mm@kvack.org, LKML , Christoph Hellwig , Uladzislau Rezki , Oleksiy Avramchenko Subject: [PATCH 3/3] vmalloc: Use for_each_vmap_node() in purge-vmap-area Date: Tue, 8 Apr 2025 17:15:49 +0200 Message-Id: <20250408151549.77937-3-urezki@gmail.com> X-Mailer: git-send-email 2.39.5 In-Reply-To: <20250408151549.77937-1-urezki@gmail.com> References: <20250408151549.77937-1-urezki@gmail.com> MIME-Version: 1.0 X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 05F502000D X-Stat-Signature: 7d6shoxkwdq3h8bed114mtwr4swfyy4r X-Rspam-User: X-HE-Tag: 1744125355-815088 X-HE-Meta: U2FsdGVkX18O4DWUgBBJkABQd76r+dJJSQOXzoX5pWi1rzsFCi4fEOyNCKnE9yrW2eo+zp9ByJFkW0XefDW7npa1BQm9rQbKQAptutUDWQvW+uxn4CtwnBbXfWBS5eIEAWgsPgEx9jz7u3EK/0FOjTAwtkps4WVmTzHt/D4cRVKGh92K+K0DG8zMCSzqBdG3L1yQ5MFKOCzZUyXt9uU/9GoTMP1HQHI1OV+3gGrcdhvrhiCJXm3pITFcRQm/EjLXLGme7aavOljOYzRyOcXHULsYrDHKmfqF51Qx3T80iIVevNonm/ZKLJlL1db1dxMihaVgmaMPQ4uAQLNSZynUfPP1+p9hYHKJ4ZBWVSmIpyCMCYqDOQI3fHmjbuHc4C3CGC7Z9I9/uAn12oeZTkJASn3qLbYF+scEyjGjjkTDB4UGi41plElhhrEZvtYKvuh6EoBU4W87IcING8EZQhg3Fp1n4H1KzH3HUUUmOY+x+mKRizSugvbRkYrzmNJVsW+wemitbgzQsBtwUvVOnoJlb6dZnVDgHHbuFA88sTwhg1Ung/aIbiBFPuhl6o7TVO+ss7P2HS667XHIsevLVTZn4mzlvCNTOx7fol+5NFwtmDt3mXaXHfjJgZn/M+fLIFOun6bvd81JFz1j2YS/uJCCpMLN1ZBDw7uO72EkPVOWt5zv1Bynv1d+fCIq1+HHAwzoT6Yrc3fRuadu9M2i1I8EFu1ByJTCAq5WvFPI89yWYOtolLJjBO5V08V7yJO7ikYpmz8YjXq7mHpxnednN019EIS+czfVXrb3opGbvOxncT/SFt7gIpji1I21zqtefRCh6MjSrTRl8KifhMPVak4vtniSE2sHNNF9hUqt5xGCOfphm7Rje51IAXZ7AtkNZ3pN0vYKmaqiuoRi8WeHD0S91/kpc5e6zyKRw6RLd3gcOdLQAXbPW5M7AmzUrOxrols/2x5mPMjzH2FohwRu8OA GjTdyyqN VCpTWcBG1yiarjUPRs0iXDTOshE/+BT35aLSrFrBXfX9kGUEz0qSUt5/UxCYlPBYfFqjgTWuoa02jmbeSCB/Ln2KN0O9eX1qC2IPZtONppXbcYWibaUsoeWJeVqdTTCtA4knstcbeadiRL3oYTxppFU+nGULOmp5EA28/EaIcvHf8NZ9uVLtj/y6G+c4vr1DpG1K99TCqoGgeetinFdcuuvJsH+7R0mw+Gah9iKiBaI3aiv52X6owUC8rFZ5YqC1QltE3y6rCRTX3WUeTNmsLfaUCD+MdBYL96+PQewTlSIWrbTJlITTyTMNDLH1WNZy32Sl9g3ToThdlIKzsnNVXmtgjHltPOBt9Kk4+kBjXDQdqSshFGIB67HHp13dOmPvpymjA0WuEz50bpVzX2MAP83bGe4CdXZcJOG8SSffK/ENf+H9sNWQSW9KyroJJlpD67i/OAzRGaVejB86bRLAFpbWF52x7cw75XUZ9 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Update a __purge_vmap_area_lazy() to use introduced helper. This is last place in vmalloc code. Also this patch introduces an extra function which is node_to_id() that converts a vmap_node pointer to an index in array. __purge_vmap_area_lazy() requires that extra function. Signed-off-by: Uladzislau Rezki (Sony) --- mm/vmalloc.c | 19 +++++++++++++++---- 1 file changed, 15 insertions(+), 4 deletions(-) diff --git a/mm/vmalloc.c b/mm/vmalloc.c index 3ff9acd64c077..409b8f372647f 100644 --- a/mm/vmalloc.c +++ b/mm/vmalloc.c @@ -923,6 +923,19 @@ id_to_node(unsigned int id) return &vmap_nodes[id % nr_vmap_nodes]; } +static inline unsigned int +node_to_id(struct vmap_node *node) +{ + /* Pointer arithmetic. */ + unsigned int id = node - vmap_nodes; + + if (likely(id < nr_vmap_nodes)) + return id; + + WARN_ONCE(1, "An address 0x%p is out-of-bounds.\n", node); + return 0; +} + /* * We use the value 0 to represent "no node", that is why * an encoded value will be the node-id incremented by 1. @@ -2259,9 +2272,7 @@ static bool __purge_vmap_area_lazy(unsigned long start, unsigned long end, */ purge_nodes = CPU_MASK_NONE; - for (i = 0; i < nr_vmap_nodes; i++) { - vn = &vmap_nodes[i]; - + for_each_vmap_node(vn) { INIT_LIST_HEAD(&vn->purge_list); vn->skip_populate = full_pool_decay; decay_va_pool_node(vn, full_pool_decay); @@ -2280,7 +2291,7 @@ static bool __purge_vmap_area_lazy(unsigned long start, unsigned long end, end = max(end, list_last_entry(&vn->purge_list, struct vmap_area, list)->va_end); - cpumask_set_cpu(i, &purge_nodes); + cpumask_set_cpu(node_to_id(vn), &purge_nodes); } nr_purge_nodes = cpumask_weight(&purge_nodes);