From patchwork Wed Apr 9 15:43:44 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kuan-Wei Chiu X-Patchwork-Id: 14045021 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B1E03C36002 for ; Wed, 9 Apr 2025 15:44:43 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 2218010E14E; Wed, 9 Apr 2025 15:44:43 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="lxmptkiK"; dkim-atps=neutral Received: from mail-pl1-f182.google.com (mail-pl1-f182.google.com [209.85.214.182]) by gabe.freedesktop.org (Postfix) with ESMTPS id 8C64A10E146 for ; Wed, 9 Apr 2025 15:44:42 +0000 (UTC) Received: by mail-pl1-f182.google.com with SMTP id d9443c01a7336-227d6b530d8so64361045ad.3 for ; Wed, 09 Apr 2025 08:44:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1744213482; x=1744818282; darn=lists.freedesktop.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=lW4oOCfCNW1Ikfi6N7oqyzQRlobsbPmX3F7QqOKxP+I=; b=lxmptkiKifn/mPyJI2Jk0EEUZJBGp7mlqhSwg00GLe09/C4yvSj+fmyCKXMdtw2+a+ snYKL8dB16Ig0Ok1jSY8+HFbVCuN3iBxzDGSmmDsvEDfSB+Xxi66cPsvtfGyJymnzuPV j+KEUU+vBqtFiqdi7AhWCmTk2Ucxa34d4UPV8vVnJvtuCBr4aww2/gQV/PM7241pNLqS Lxmy/hQ3jqiIIE9HuK6gD5SVkAQBBwIUtI1mo038d/eXRIq2KCG9jnlqxO64jrfuG/EJ xS2jkWnI/fmSt5wNzZDNZENKfUPR7VzzsnXW0Qv45nxzfpPSlajyy4ZhOwRH+ztNXWNZ SPSA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1744213482; x=1744818282; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=lW4oOCfCNW1Ikfi6N7oqyzQRlobsbPmX3F7QqOKxP+I=; b=dEaIU/NljSqRNH6BQNYiCQPUeyO3tIDz7f2n8bMlP4ulGtV7Xow9he+UEIzTqRfBhD lBbxQb6D/a8/10Wrm5AE+BH+6T8l3EvW0ICavizYjCrANMr6ClmFa5KnwIIFdBDloeFk lNQOQvw0+6dfAc0g0JCu/bwLiyvm2cDTJ3rdyI4FRDjPTorz4yY2DwDg7SqYaoBFzXXD AH/LnKKl9Acrtm7JFXSIQKDKGSHlAZfQCUWzFjSTrJR2UTlN8e7gomYlPynzEQi0jzJP isAAmHH3l4MLv/kf7tYG8goCyth2b3vDGKYiHzO4Q563twXmTSBTpiix+HgjDn+My6vW m21A== X-Forwarded-Encrypted: i=1; AJvYcCUQpQIF97p2gzpV7FlX7gXWr6KNKMsPSKuCm9BCuLty4TsstbWlbvy9kWZ8otpF5WEYsAMGI1pcLr8=@lists.freedesktop.org X-Gm-Message-State: AOJu0Yxa7NCrweb9B428hNjJCr/pVLs4z6g4sDAUAcFW1E7j7w9BqZ4Q dmPukcIwq/gXpLnF0+Xlm47TMxbLVi5XcECVwEUEmrg28DZCiGr+ X-Gm-Gg: ASbGncvg3i3uGq3gXzSK4nOoVpE5OyPjIMONalKji4g5yfVDAaTXfaAWa686VLDgkRs WIhzXks7iShWLk5hb8YzKBYzxXI285WLH1YsM4EjMrGhV8VBofLNR+xkf3LztAKTPmxxeplHFJz msQCeD1xObhiBHLz2c7Igy0BB4BWNB7gEgSinM2RqZHu4hMBP87A1MnCE5V3v4kDAiRDWp0H32m dfwVt/kJ5JSdKXQBj6KdIg5XpsY5HjuJJWRSUhek2sfjLLFZtkf3SqnQH7pDlSTzLN7MMfUDvF1 U1Y/nY0ia+spxOid7mgpijYwxgkOwIxUfbThFGnOdLleygiVFgF5CflwkH4rKes91hPVb0E= X-Google-Smtp-Source: AGHT+IGgg0DBuH33oW+E+873bMYyZA/oUaltEXJsqFjgXBWTSXKYJ4mXYIMoJApL4m1vTMrn1nnOpQ== X-Received: by 2002:a17:90a:f946:b0:2ff:4bac:6fa2 with SMTP id 98e67ed59e1d1-306dbbc1e1emr5446016a91.16.1744213481930; Wed, 09 Apr 2025 08:44:41 -0700 (PDT) Received: from visitorckw-System-Product-Name.. ([140.113.216.168]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-306dd171991sm1952304a91.37.2025.04.09.08.44.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 09 Apr 2025 08:44:41 -0700 (PDT) From: Kuan-Wei Chiu To: tglx@linutronix.de, mingo@redhat.com, bp@alien8.de, dave.hansen@linux.intel.com, x86@kernel.org, jk@ozlabs.org, joel@jms.id.au, eajames@linux.ibm.com, andrzej.hajda@intel.com, neil.armstrong@linaro.org, rfoss@kernel.org, maarten.lankhorst@linux.intel.com, mripard@kernel.org, tzimmermann@suse.de, airlied@gmail.com, simona@ffwll.ch, dmitry.torokhov@gmail.com, mchehab@kernel.org, awalls@md.metrocast.net, hverkuil@xs4all.nl, miquel.raynal@bootlin.com, richard@nod.at, vigneshr@ti.com, louis.peens@corigine.com, andrew+netdev@lunn.ch, davem@davemloft.net, edumazet@google.com, pabeni@redhat.com, parthiban.veerasooran@microchip.com, arend.vanspriel@broadcom.com, johannes@sipsolutions.net, gregkh@linuxfoundation.org, jirislaby@kernel.org, yury.norov@gmail.com, akpm@linux-foundation.org, jdelvare@suse.com, linux@roeck-us.net, alexandre.belloni@bootlin.com, pgaj@cadence.com Cc: hpa@zytor.com, alistair@popple.id.au, linux@rasmusvillemoes.dk, Laurent.pinchart@ideasonboard.com, jonas@kwiboo.se, jernej.skrabec@gmail.com, kuba@kernel.org, linux-kernel@vger.kernel.org, linux-fsi@lists.ozlabs.org, dri-devel@lists.freedesktop.org, linux-input@vger.kernel.org, linux-media@vger.kernel.org, linux-mtd@lists.infradead.org, oss-drivers@corigine.com, netdev@vger.kernel.org, linux-wireless@vger.kernel.org, brcm80211@lists.linux.dev, brcm80211-dev-list.pdl@broadcom.com, linux-serial@vger.kernel.org, bpf@vger.kernel.org, jserv@ccns.ncku.edu.tw, Frank.Li@nxp.com, linux-hwmon@vger.kernel.org, linux-i3c@lists.infradead.org, david.laight.linux@gmail.com, andrew.cooper3@citrix.com, Kuan-Wei Chiu , Yu-Chun Lin Subject: [PATCH v4 01/13] bitops: Change parity8() to parity_odd() with u64 input and bool return type Date: Wed, 9 Apr 2025 23:43:44 +0800 Message-Id: <20250409154356.423512-2-visitorckw@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20250409154356.423512-1-visitorckw@gmail.com> References: <20250409154356.423512-1-visitorckw@gmail.com> MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Redesign the parity8() helper as parity_odd(), changing its input type from u8 to u64 to support broader use cases and its return type from int to bool to clearly reflect the function's binary output. The function now returns true for odd parity and false for even parity, making its behavior more intuitive based on the name. Also mark the function with __attribute_const__ to enable better compiler optimization, as the result depends solely on its input and has no side effects. While more efficient implementations may exist, further optimization is postponed until a use case in performance-critical paths arises. Co-developed-by: Yu-Chun Lin Signed-off-by: Yu-Chun Lin Signed-off-by: Kuan-Wei Chiu --- arch/x86/kernel/bootflag.c | 4 ++-- drivers/hwmon/spd5118.c | 2 +- drivers/i3c/master/dw-i3c-master.c | 2 +- drivers/i3c/master/i3c-master-cdns.c | 2 +- drivers/i3c/master/mipi-i3c-hci/dat_v1.c | 2 +- include/linux/bitops.h | 19 ++++++++++++------- 6 files changed, 18 insertions(+), 13 deletions(-) diff --git a/arch/x86/kernel/bootflag.c b/arch/x86/kernel/bootflag.c index 73274d76ce16..86aae4b2bfd5 100644 --- a/arch/x86/kernel/bootflag.c +++ b/arch/x86/kernel/bootflag.c @@ -26,7 +26,7 @@ static void __init sbf_write(u8 v) unsigned long flags; if (sbf_port != -1) { - if (!parity8(v)) + if (!parity_odd(v)) v ^= SBF_PARITY; printk(KERN_INFO "Simple Boot Flag at 0x%x set to 0x%x\n", @@ -57,7 +57,7 @@ static bool __init sbf_value_valid(u8 v) { if (v & SBF_RESERVED) /* Reserved bits */ return false; - if (!parity8(v)) + if (!parity_odd(v)) return false; return true; diff --git a/drivers/hwmon/spd5118.c b/drivers/hwmon/spd5118.c index 358152868d96..15761f2ca4e9 100644 --- a/drivers/hwmon/spd5118.c +++ b/drivers/hwmon/spd5118.c @@ -298,7 +298,7 @@ static umode_t spd5118_is_visible(const void *_data, enum hwmon_sensor_types typ */ static bool spd5118_vendor_valid(u8 bank, u8 id) { - if (parity8(bank) == 0 || parity8(id) == 0) + if (!parity_odd(bank) || !parity_odd(id)) return false; id &= 0x7f; diff --git a/drivers/i3c/master/dw-i3c-master.c b/drivers/i3c/master/dw-i3c-master.c index 611c22b72c15..dc61d87fcd94 100644 --- a/drivers/i3c/master/dw-i3c-master.c +++ b/drivers/i3c/master/dw-i3c-master.c @@ -867,7 +867,7 @@ static int dw_i3c_master_daa(struct i3c_master_controller *m) master->devs[pos].addr = ret; last_addr = ret; - ret |= parity8(ret) ? 0 : BIT(7); + ret |= parity_odd(ret) ? 0 : BIT(7); writel(DEV_ADDR_TABLE_DYNAMIC_ADDR(ret), master->regs + diff --git a/drivers/i3c/master/i3c-master-cdns.c b/drivers/i3c/master/i3c-master-cdns.c index fd3752cea654..df14f978a388 100644 --- a/drivers/i3c/master/i3c-master-cdns.c +++ b/drivers/i3c/master/i3c-master-cdns.c @@ -889,7 +889,7 @@ static u32 prepare_rr0_dev_address(u32 addr) ret |= (addr & GENMASK(9, 7)) << 6; /* RR0[0] = ~XOR(addr[6:0]) */ - ret |= parity8(addr & 0x7f) ? 0 : BIT(0); + ret |= parity_odd(addr & 0x7f) ? 0 : BIT(0); return ret; } diff --git a/drivers/i3c/master/mipi-i3c-hci/dat_v1.c b/drivers/i3c/master/mipi-i3c-hci/dat_v1.c index 85c4916972e4..d692a299607d 100644 --- a/drivers/i3c/master/mipi-i3c-hci/dat_v1.c +++ b/drivers/i3c/master/mipi-i3c-hci/dat_v1.c @@ -114,7 +114,7 @@ static void hci_dat_v1_set_dynamic_addr(struct i3c_hci *hci, dat_w0 = dat_w0_read(dat_idx); dat_w0 &= ~(DAT_0_DYNAMIC_ADDRESS | DAT_0_DYNADDR_PARITY); dat_w0 |= FIELD_PREP(DAT_0_DYNAMIC_ADDRESS, address) | - (parity8(address) ? 0 : DAT_0_DYNADDR_PARITY); + (parity_odd(address) ? 0 : DAT_0_DYNADDR_PARITY); dat_w0_write(dat_idx, dat_w0); } diff --git a/include/linux/bitops.h b/include/linux/bitops.h index c1cb53cf2f0f..7c4c8afccef1 100644 --- a/include/linux/bitops.h +++ b/include/linux/bitops.h @@ -230,35 +230,40 @@ static inline int get_count_order_long(unsigned long l) } /** - * parity8 - get the parity of an u8 value - * @value: the value to be examined + * parity_odd - get the parity of an u64 value + * @val: the value to be examined * - * Determine the parity of the u8 argument. + * Determine the parity of the u64 argument. * * Returns: - * 0 for even parity, 1 for odd parity + * false for even parity, true for odd parity * * Note: This function informs you about the current parity. Example to bail * out when parity is odd: * - * if (parity8(val) == 1) + * if (parity_odd(val)) * return -EBADMSG; * * If you need to calculate a parity bit, you need to draw the conclusion from * this result yourself. Example to enforce odd parity, parity bit is bit 7: * - * if (parity8(val) == 0) + * if (!parity_odd(val)) * val ^= BIT(7); */ -static inline int parity8(u8 val) +#ifndef parity_odd +static inline __attribute_const__ bool parity_odd(u64 val) { /* * One explanation of this algorithm: * https://funloop.org/codex/problem/parity/README.html */ + val ^= val >> 32; + val ^= val >> 16; + val ^= val >> 8; val ^= val >> 4; return (0x6996 >> (val & 0xf)) & 1; } +#endif /** * __ffs64 - find first set bit in a 64 bit word From patchwork Wed Apr 9 15:43:45 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kuan-Wei Chiu X-Patchwork-Id: 14045022 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D38ECC36002 for ; Wed, 9 Apr 2025 15:44:55 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 1DC2010E146; Wed, 9 Apr 2025 15:44:55 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="UMJB0xFu"; dkim-atps=neutral Received: from mail-pg1-f177.google.com (mail-pg1-f177.google.com [209.85.215.177]) by gabe.freedesktop.org (Postfix) with ESMTPS id 537F310E146 for ; Wed, 9 Apr 2025 15:44:53 +0000 (UTC) Received: by mail-pg1-f177.google.com with SMTP id 41be03b00d2f7-afc857702d1so4243003a12.3 for ; Wed, 09 Apr 2025 08:44:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1744213493; x=1744818293; darn=lists.freedesktop.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=v49ZwnZIj2AOJhsRco4puem3oLXi78jqbt8BbW57LpM=; b=UMJB0xFuh7kJkB39DBWphQuXb3xpYDlSSnfVIL3Rbso2wxFrGB6USessQVRfPsaCNR KnITJa85JWm0NBw2Mdq72+bIQjMVk/n6CT/NqYUSNA28h+oez1P4I17uSvGCatGNvN0g mYjV2OlhMk5H6oMIwP5PbiQb/jr4NHB6TU+wIYy2OdwhTV1Ql+V44OjQA4J89ocTFVPc lY9fqE2LT5ajuYlz6biSPjYaFf6Cg0kZ9K8pSOpzBiDq+Na+HG63qayxBacGK8c7H1Cb sdxc+pSpYtmcyFdZyMSfp8+CA8Jff6CiS62sRaxOe3RMNEnE18HW/zr0pLUAWswYaDtr VEWA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1744213493; x=1744818293; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=v49ZwnZIj2AOJhsRco4puem3oLXi78jqbt8BbW57LpM=; b=UkJOFP35mvnY/+dZdLhBJkA3ZElPOBTDwi0O7G/T7S3P8krRn7erazXOpLbtfqrd1u TyabWyWu0dsEYCKNWOJKHl0FiR8Bpj8oL63lmZBXe/6c4VkiEJ2vTpX2COZGyqK+gjY5 Z2OF+R1YjzrkhNSNDPNo4Rin1rRgfsZlz7PVPUdbn6zfv5cpqqV8Cn0uOabugXPBv3Ck ExRkx4y7vJavX3kWLv2qx6PYqgm3N9j7HSHrB3fxWkeYJQl7C+iWCj4hghqSBoZrZXAQ OVtm2xHaSOj09334423lwrVW+6drDx94Af63b3uc1SaUHeGVQ8L8bxovtiRU2CSMeWvO cD/A== X-Forwarded-Encrypted: i=1; AJvYcCUh8AXxNR70NMRLeLAj4/h2wGhGlul7IyLJOzajKkPP1+4v7BPPbmVa68R4JzdUmBkhy9Wp6+uYXgU=@lists.freedesktop.org X-Gm-Message-State: AOJu0YxVdvkYddMtyLpA37SmRNJAq0LwvEEBvcQrjldiRb0FyHsbc9En mkN8gl+UVl3+1kkRvWIOE7B3wE76ou2Qwr/GJ0QH9r+K8wrvuzZz X-Gm-Gg: ASbGnctxJh1Ehugv6XDBgUT6cib7OURls0vG6uYTC13A0Q7fOKVAwp62CNy5GPcBMVD m6mYn2d0DPERc96PBxcjshH6mHoJB+64IlOpfYi9h1eH3A9cJINyWyDijgRcoZjr8UYzBK4IMEA TKV7VYMhh2o+ILnYRGoKWLnFXJbfvrLdMp+pOjg5KoPWDvmDvDuNt23Mo6mu27s/oxCQhnw/gsA CVhAzVuCxEQWF6KvSUUERUNG8jTxPZrwWkz6ZjKhcCFMu4noZiLdBp0ZUhyGN4FF7BnK6aILj5/ X2z6SVfGjyQDz38dnUuyCaMft4nttsSLWjaqiD+0iBGJn25sSCUAWtfEAdzIZu9TqwmkczkWyla uSJGQfA== X-Google-Smtp-Source: AGHT+IHDjC6NZDKGKeJbiK4hibwKJCoZJOXppnGBHSYZ9kKUia5ispG3D8M0PIfVIJ8M4eMwylwt9g== X-Received: by 2002:a17:90b:1f8f:b0:305:2d28:c8fd with SMTP id 98e67ed59e1d1-306dbc2bf43mr5380309a91.24.1744213492550; Wed, 09 Apr 2025 08:44:52 -0700 (PDT) Received: from visitorckw-System-Product-Name.. ([140.113.216.168]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-306dd171991sm1952304a91.37.2025.04.09.08.44.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 09 Apr 2025 08:44:52 -0700 (PDT) From: Kuan-Wei Chiu To: tglx@linutronix.de, mingo@redhat.com, bp@alien8.de, dave.hansen@linux.intel.com, x86@kernel.org, jk@ozlabs.org, joel@jms.id.au, eajames@linux.ibm.com, andrzej.hajda@intel.com, neil.armstrong@linaro.org, rfoss@kernel.org, maarten.lankhorst@linux.intel.com, mripard@kernel.org, tzimmermann@suse.de, airlied@gmail.com, simona@ffwll.ch, dmitry.torokhov@gmail.com, mchehab@kernel.org, awalls@md.metrocast.net, hverkuil@xs4all.nl, miquel.raynal@bootlin.com, richard@nod.at, vigneshr@ti.com, louis.peens@corigine.com, andrew+netdev@lunn.ch, davem@davemloft.net, edumazet@google.com, pabeni@redhat.com, parthiban.veerasooran@microchip.com, arend.vanspriel@broadcom.com, johannes@sipsolutions.net, gregkh@linuxfoundation.org, jirislaby@kernel.org, yury.norov@gmail.com, akpm@linux-foundation.org, jdelvare@suse.com, linux@roeck-us.net, alexandre.belloni@bootlin.com, pgaj@cadence.com Cc: hpa@zytor.com, alistair@popple.id.au, linux@rasmusvillemoes.dk, Laurent.pinchart@ideasonboard.com, jonas@kwiboo.se, jernej.skrabec@gmail.com, kuba@kernel.org, linux-kernel@vger.kernel.org, linux-fsi@lists.ozlabs.org, dri-devel@lists.freedesktop.org, linux-input@vger.kernel.org, linux-media@vger.kernel.org, linux-mtd@lists.infradead.org, oss-drivers@corigine.com, netdev@vger.kernel.org, linux-wireless@vger.kernel.org, brcm80211@lists.linux.dev, brcm80211-dev-list.pdl@broadcom.com, linux-serial@vger.kernel.org, bpf@vger.kernel.org, jserv@ccns.ncku.edu.tw, Frank.Li@nxp.com, linux-hwmon@vger.kernel.org, linux-i3c@lists.infradead.org, david.laight.linux@gmail.com, andrew.cooper3@citrix.com, Kuan-Wei Chiu , Yu-Chun Lin Subject: [PATCH v4 02/13] media: media/test_drivers: Replace open-coded parity calculation with parity_odd() Date: Wed, 9 Apr 2025 23:43:45 +0800 Message-Id: <20250409154356.423512-3-visitorckw@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20250409154356.423512-1-visitorckw@gmail.com> References: <20250409154356.423512-1-visitorckw@gmail.com> MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Refactor parity calculations to use the standard parity_odd() helper. This change eliminates redundant implementations. Co-developed-by: Yu-Chun Lin Signed-off-by: Yu-Chun Lin Signed-off-by: Kuan-Wei Chiu --- drivers/media/test-drivers/vivid/vivid-vbi-gen.c | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/drivers/media/test-drivers/vivid/vivid-vbi-gen.c b/drivers/media/test-drivers/vivid/vivid-vbi-gen.c index 70a4024d461e..5e1b7b1742e4 100644 --- a/drivers/media/test-drivers/vivid/vivid-vbi-gen.c +++ b/drivers/media/test-drivers/vivid/vivid-vbi-gen.c @@ -5,6 +5,7 @@ * Copyright 2014 Cisco Systems, Inc. and/or its affiliates. All rights reserved. */ +#include #include #include #include @@ -165,12 +166,7 @@ static const u8 vivid_cc_sequence2[30] = { static u8 calc_parity(u8 val) { - unsigned i; - unsigned tot = 0; - - for (i = 0; i < 7; i++) - tot += (val & (1 << i)) ? 1 : 0; - return val | ((tot & 1) ? 0 : 0x80); + return val | (parity_odd(val) ? 0 : 0x80); } static void vivid_vbi_gen_set_time_of_day(u8 *packet) From patchwork Wed Apr 9 15:43:46 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kuan-Wei Chiu X-Patchwork-Id: 14045023 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C8EF0C36002 for ; Wed, 9 Apr 2025 15:45:04 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 2DB0410E1A6; Wed, 9 Apr 2025 15:45:04 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="AB12/GQu"; dkim-atps=neutral Received: from mail-pj1-f51.google.com (mail-pj1-f51.google.com [209.85.216.51]) by gabe.freedesktop.org (Postfix) with ESMTPS id 9110A10E1A6 for ; Wed, 9 Apr 2025 15:45:03 +0000 (UTC) Received: by mail-pj1-f51.google.com with SMTP id 98e67ed59e1d1-2ff69365e1dso5622101a91.3 for ; Wed, 09 Apr 2025 08:45:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1744213503; x=1744818303; darn=lists.freedesktop.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=lU43UpH11wLCdsjhsyHst5iurlQ+ThcWcqMooUtxxjY=; b=AB12/GQu7Q0uSoKNH7m3VJSKAM7DdrRn3DYuvglbL/RChqNpyKn2AP9WCDYfUYtjUR S+VQ+YzJmtZGeBPvLbSxoVCZYmvGRBeUpuOpqSaiNSKlzrsvlX65iZVPsVU9BQP3V8VH 0YNRj3iXTk3qX9pF1VhiKs7XIpzdD2tOWcXylLM3QdOyKyTEAIVYO5z+/XptJT0tIU1/ PrqlVOLydzOh7SAAE1Y6aKGhmol92Z9j9wl9y/yGfg4loFukBtY/LwJXqi5JP8dxPhk+ IqdnYbL/XC4Ouh5f+T8fbkkn4CVJ8S5fK9QlGHND5Rr/1BhmfcHFr5ia73RMkkKqtc+q QLuw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1744213503; x=1744818303; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=lU43UpH11wLCdsjhsyHst5iurlQ+ThcWcqMooUtxxjY=; b=GvhN9Y5JphIJj9q34Tqjh2i4cqsczAnlqrXGD7qclVnUBPeqoLF2oxgH8OQlef7WAe +2fy7UtuZDGW6ACq4SmYxTl2y1o9xYAnJhODqJV8GXE9JaScOBLtlPMQL7pfgTCi9vVE hOjHSHYjg26RAvGcX1G3w/nUhLjnHp7KhvatPyelBimRbGKNdInODrFis4ENXBKsYqPD 8O9ke008AUATYyRtSz6UENN4xGeuXQtOojoG4V/KVCPZ0W5Pe4Zg4mTkb3o7CVS7j0ZE h54yOr4PpcDxMePa2eAqGjJpuHh9Sqbau8gglQrYtJiSLbLYrOyXTwLO9VPcJ6JiGS+H lIbw== X-Forwarded-Encrypted: i=1; AJvYcCUNlWWBlHMf3NuhrsHHNNMuxXPVJ3TeivnByZb7nlsYvlwo4v7gt1vD6470zS8vAQVnf7JKdlf7w/E=@lists.freedesktop.org X-Gm-Message-State: AOJu0Yy/i/p8axPEFrjmrEU4Ad1t/K92UZfblfl3r84/5LZLf1EYAYUd 0XCgiMAyt2Xq18JDaOgl8gYmYsC0Jz8S/Tfsp4VIu6szibgESnnF X-Gm-Gg: ASbGnct+MSXfT0fs3LA8xtKF8mWVSVehy/ol1IiBBeXewdZ+6LpY5le20+CitsRfVFX holRYo3fjcV7O5rkkjMshe6r8wsH4ZOby+8oNWJ1/WemWnFVAEOANQdA44ocB5NfBhBtXWdnlUX O/wvgzUvywxC+1XnB8SatF93odNLGpcBFdtRPSpi+LUiZDPE4YnGi7M3lQnQmO60spgmjERKvoA qrSau3jz2SUlVorjx/VWoZefUOanzzAJ+bSog/csG44bbYgPxr3fhhHSP/Rg7vUWmPzEumN+f8a crA5NNH3ncifWKl1Ja8KIxDu8PSgZeUS27XJjRvpSzp5KXqfI0bZ1iboPn8a79+pjZ8ISko= X-Google-Smtp-Source: AGHT+IEs9q8P41yMEf/AWjN7idtRUGM7Z4tfe1JBSuODcHBz5h8hVFHXITrRQEV2h0IxkqA/pyunWg== X-Received: by 2002:a17:90b:4a47:b0:2ff:7b28:a51a with SMTP id 98e67ed59e1d1-306dd52d43amr4827521a91.17.1744213503051; Wed, 09 Apr 2025 08:45:03 -0700 (PDT) Received: from visitorckw-System-Product-Name.. ([140.113.216.168]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-306dd171991sm1952304a91.37.2025.04.09.08.44.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 09 Apr 2025 08:45:02 -0700 (PDT) From: Kuan-Wei Chiu To: tglx@linutronix.de, mingo@redhat.com, bp@alien8.de, dave.hansen@linux.intel.com, x86@kernel.org, jk@ozlabs.org, joel@jms.id.au, eajames@linux.ibm.com, andrzej.hajda@intel.com, neil.armstrong@linaro.org, rfoss@kernel.org, maarten.lankhorst@linux.intel.com, mripard@kernel.org, tzimmermann@suse.de, airlied@gmail.com, simona@ffwll.ch, dmitry.torokhov@gmail.com, mchehab@kernel.org, awalls@md.metrocast.net, hverkuil@xs4all.nl, miquel.raynal@bootlin.com, richard@nod.at, vigneshr@ti.com, louis.peens@corigine.com, andrew+netdev@lunn.ch, davem@davemloft.net, edumazet@google.com, pabeni@redhat.com, parthiban.veerasooran@microchip.com, arend.vanspriel@broadcom.com, johannes@sipsolutions.net, gregkh@linuxfoundation.org, jirislaby@kernel.org, yury.norov@gmail.com, akpm@linux-foundation.org, jdelvare@suse.com, linux@roeck-us.net, alexandre.belloni@bootlin.com, pgaj@cadence.com Cc: hpa@zytor.com, alistair@popple.id.au, linux@rasmusvillemoes.dk, Laurent.pinchart@ideasonboard.com, jonas@kwiboo.se, jernej.skrabec@gmail.com, kuba@kernel.org, linux-kernel@vger.kernel.org, linux-fsi@lists.ozlabs.org, dri-devel@lists.freedesktop.org, linux-input@vger.kernel.org, linux-media@vger.kernel.org, linux-mtd@lists.infradead.org, oss-drivers@corigine.com, netdev@vger.kernel.org, linux-wireless@vger.kernel.org, brcm80211@lists.linux.dev, brcm80211-dev-list.pdl@broadcom.com, linux-serial@vger.kernel.org, bpf@vger.kernel.org, jserv@ccns.ncku.edu.tw, Frank.Li@nxp.com, linux-hwmon@vger.kernel.org, linux-i3c@lists.infradead.org, david.laight.linux@gmail.com, andrew.cooper3@citrix.com, Kuan-Wei Chiu , Yu-Chun Lin Subject: [PATCH v4 03/13] media: pci: cx18-av-vbi: Replace open-coded parity calculation with parity_odd() Date: Wed, 9 Apr 2025 23:43:46 +0800 Message-Id: <20250409154356.423512-4-visitorckw@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20250409154356.423512-1-visitorckw@gmail.com> References: <20250409154356.423512-1-visitorckw@gmail.com> MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Refactor parity calculations to use the standard parity_odd() helper. This change eliminates redundant implementations. Co-developed-by: Yu-Chun Lin Signed-off-by: Yu-Chun Lin Signed-off-by: Kuan-Wei Chiu --- drivers/media/pci/cx18/cx18-av-vbi.c | 12 ++---------- 1 file changed, 2 insertions(+), 10 deletions(-) diff --git a/drivers/media/pci/cx18/cx18-av-vbi.c b/drivers/media/pci/cx18/cx18-av-vbi.c index 65281d40c681..15b515b95956 100644 --- a/drivers/media/pci/cx18/cx18-av-vbi.c +++ b/drivers/media/pci/cx18/cx18-av-vbi.c @@ -8,6 +8,7 @@ */ +#include #include "cx18-driver.h" /* @@ -56,15 +57,6 @@ struct vbi_anc_data { /* u8 fill[]; Variable number of fill bytes */ }; -static int odd_parity(u8 c) -{ - c ^= (c >> 4); - c ^= (c >> 2); - c ^= (c >> 1); - - return c & 1; -} - static int decode_vps(u8 *dst, u8 *p) { static const u8 biphase_tbl[] = { @@ -278,7 +270,7 @@ int cx18_av_decode_vbi_line(struct v4l2_subdev *sd, break; case 6: sdid = V4L2_SLICED_CAPTION_525; - err = !odd_parity(p[0]) || !odd_parity(p[1]); + err = !parity_odd(p[0]) || !parity_odd(p[1]); break; case 9: sdid = V4L2_SLICED_VPS; From patchwork Wed Apr 9 15:43:47 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kuan-Wei Chiu X-Patchwork-Id: 14045066 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 1974BC369A1 for ; Wed, 9 Apr 2025 15:45:15 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 7F0E610E1B2; Wed, 9 Apr 2025 15:45:14 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="MLfNp7C7"; dkim-atps=neutral Received: from mail-pj1-f50.google.com (mail-pj1-f50.google.com [209.85.216.50]) by gabe.freedesktop.org (Postfix) with ESMTPS id 1B60710E6AB for ; Wed, 9 Apr 2025 15:45:14 +0000 (UTC) Received: by mail-pj1-f50.google.com with SMTP id 98e67ed59e1d1-30155bbbed9so5428842a91.1 for ; Wed, 09 Apr 2025 08:45:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1744213513; x=1744818313; darn=lists.freedesktop.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=0vmckaFkj9v1ziFLew45kxKFqGeGwuFVGwp5LAE34T4=; b=MLfNp7C7oNt/kScWh5JllWHBBCOaT2LzuakRqhESj4WptctzUfHudF7OSXjV5ryWn6 4vlzqyagNUy7dFVrOSGB3krjw2butoyx5W8CCQxHihY8h8byt8XqDUlq9MfOe8gWjU/6 56KR55UBGeR+fynejLyBWxhovtbNKL7TnE6xyWx5ZsTeTQLOoZhjFgSWtaepJuWD4fE2 VCM5lzDR2gSiOiVIT4sHbUdmloRsvF2AMfylGc3Gxjm4pfGCqj3VD56hVkb/2O8r7GMm lapL3FlLVQAR0wbYAIWiw2KQ2M8BGEwQWq2OjpazekFuNvRp3xar0uc/qceirzb/Ki3C aVKA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1744213513; x=1744818313; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=0vmckaFkj9v1ziFLew45kxKFqGeGwuFVGwp5LAE34T4=; b=lkCd97aLX3VfCiHgTe+42D+8CBRXUH42KDYzyu78TtsXNjVTQtCOxImacSV9QcuCdh mBq9DKhV84RtLu3gyVW16/hX4wAPKRzTKXhuHH0juk4gM3LXqoIanImW2C75FjRmrkOh Ig4nJ3HOvnUj2sGbs7uyR/1cBV3yj47JLYD4nbHPqWrycJPxBDEq56/wYxcQzsn3kcXt Tt/9xkp1OO7oIdQNfLQb3/VD9JyLDYTgVZmFxGhHRblwmp0O28v0iH3TWd0mznS3CMx/ emFk/NvlwK6HzMyKIg4OzRrE+/rU5S6HdgbnYo0FCCo1JtGvSLHIgOFz9un0s6LlOax7 BP6A== X-Forwarded-Encrypted: i=1; AJvYcCW7tU/FOxXNs/fdPnv086FSn8JMQPuVlRg9nL/c5yGV/qWNG7WfyKXGBvphIyg/R8Qgwa631qRXPB4=@lists.freedesktop.org X-Gm-Message-State: AOJu0YzcoUs+QauL2IGQ8qZ2pEJ39qd622lJeBEVqBbAf12xfQlbko82 ZLaDqG/li7wusrxEWWgyF6D6EAHVlVriPiEBoUn0xHrPKAgTrAfH X-Gm-Gg: ASbGncu82M6apqzCKTAsbx2EYx52s/XK1aTISSmIrrXtIPSnEnelELblQ1uSR5REzdi 0QOdX/9w+uwSY5ds184vzE9B3DJY2mR4mpMKlLyVDj3ePLLJBeMEekEP2kouaiTj6qujGksaqf7 qf1m23fESj9NyGGyKOlWvrctc/qYEh1XIWLCbSrV8KKUHpqHchjgFKuGL3PYPfbatBSx/uPSBnm 6PETAzsGfDyS4wB2wl4gQsMhpBBv+3un8rIfS1AHeuUuHownz060CBGUyFluIretaAmjGx3l8/g bVLr1F0M0TATTarK5LenNwyPNtjU5iUk3i0RUiyShffRYjCNMcjxJPZhJOJBbiHi/AIcIpk= X-Google-Smtp-Source: AGHT+IFGakXWHWi8mPXKxnYyjY+QGe+hrJ1DKxm8mqQTtmCR5lZ2ol4+lqNevSMOwq7LjWocz+r/eA== X-Received: by 2002:a17:90a:da88:b0:2f9:c139:b61f with SMTP id 98e67ed59e1d1-306dbbb557amr5410743a91.14.1744213513621; Wed, 09 Apr 2025 08:45:13 -0700 (PDT) Received: from visitorckw-System-Product-Name.. ([140.113.216.168]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-306dd171991sm1952304a91.37.2025.04.09.08.45.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 09 Apr 2025 08:45:13 -0700 (PDT) From: Kuan-Wei Chiu To: tglx@linutronix.de, mingo@redhat.com, bp@alien8.de, dave.hansen@linux.intel.com, x86@kernel.org, jk@ozlabs.org, joel@jms.id.au, eajames@linux.ibm.com, andrzej.hajda@intel.com, neil.armstrong@linaro.org, rfoss@kernel.org, maarten.lankhorst@linux.intel.com, mripard@kernel.org, tzimmermann@suse.de, airlied@gmail.com, simona@ffwll.ch, dmitry.torokhov@gmail.com, mchehab@kernel.org, awalls@md.metrocast.net, hverkuil@xs4all.nl, miquel.raynal@bootlin.com, richard@nod.at, vigneshr@ti.com, louis.peens@corigine.com, andrew+netdev@lunn.ch, davem@davemloft.net, edumazet@google.com, pabeni@redhat.com, parthiban.veerasooran@microchip.com, arend.vanspriel@broadcom.com, johannes@sipsolutions.net, gregkh@linuxfoundation.org, jirislaby@kernel.org, yury.norov@gmail.com, akpm@linux-foundation.org, jdelvare@suse.com, linux@roeck-us.net, alexandre.belloni@bootlin.com, pgaj@cadence.com Cc: hpa@zytor.com, alistair@popple.id.au, linux@rasmusvillemoes.dk, Laurent.pinchart@ideasonboard.com, jonas@kwiboo.se, jernej.skrabec@gmail.com, kuba@kernel.org, linux-kernel@vger.kernel.org, linux-fsi@lists.ozlabs.org, dri-devel@lists.freedesktop.org, linux-input@vger.kernel.org, linux-media@vger.kernel.org, linux-mtd@lists.infradead.org, oss-drivers@corigine.com, netdev@vger.kernel.org, linux-wireless@vger.kernel.org, brcm80211@lists.linux.dev, brcm80211-dev-list.pdl@broadcom.com, linux-serial@vger.kernel.org, bpf@vger.kernel.org, jserv@ccns.ncku.edu.tw, Frank.Li@nxp.com, linux-hwmon@vger.kernel.org, linux-i3c@lists.infradead.org, david.laight.linux@gmail.com, andrew.cooper3@citrix.com, Kuan-Wei Chiu , Yu-Chun Lin Subject: [PATCH v4 04/13] media: saa7115: Replace open-coded parity calculation with parity_odd() Date: Wed, 9 Apr 2025 23:43:47 +0800 Message-Id: <20250409154356.423512-5-visitorckw@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20250409154356.423512-1-visitorckw@gmail.com> References: <20250409154356.423512-1-visitorckw@gmail.com> MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Refactor parity calculations to use the standard parity_odd() helper. This change eliminates redundant implementations. Co-developed-by: Yu-Chun Lin Signed-off-by: Yu-Chun Lin Signed-off-by: Kuan-Wei Chiu --- drivers/media/i2c/saa7115.c | 12 ++---------- 1 file changed, 2 insertions(+), 10 deletions(-) diff --git a/drivers/media/i2c/saa7115.c b/drivers/media/i2c/saa7115.c index a1c71187e773..a7886269dcfc 100644 --- a/drivers/media/i2c/saa7115.c +++ b/drivers/media/i2c/saa7115.c @@ -25,6 +25,7 @@ #include "saa711x_regs.h" +#include #include #include #include @@ -664,15 +665,6 @@ static const unsigned char saa7115_init_misc[] = { 0x00, 0x00 }; -static int saa711x_odd_parity(u8 c) -{ - c ^= (c >> 4); - c ^= (c >> 2); - c ^= (c >> 1); - - return c & 1; -} - static int saa711x_decode_vps(u8 *dst, u8 *p) { static const u8 biphase_tbl[] = { @@ -1227,7 +1219,7 @@ static int saa711x_decode_vbi_line(struct v4l2_subdev *sd, struct v4l2_decode_vb vbi->type = V4L2_SLICED_TELETEXT_B; break; case 4: - if (!saa711x_odd_parity(p[0]) || !saa711x_odd_parity(p[1])) + if (!parity_odd(p[0]) || !parity_odd(p[1])) return 0; vbi->type = V4L2_SLICED_CAPTION_525; break; From patchwork Wed Apr 9 15:43:48 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kuan-Wei Chiu X-Patchwork-Id: 14045067 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 7C222C36002 for ; Wed, 9 Apr 2025 15:45:28 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id EE83110E1C0; Wed, 9 Apr 2025 15:45:27 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="ep2t8SWn"; dkim-atps=neutral Received: from mail-pj1-f52.google.com (mail-pj1-f52.google.com [209.85.216.52]) by gabe.freedesktop.org (Postfix) with ESMTPS id 4225910E1C0 for ; Wed, 9 Apr 2025 15:45:27 +0000 (UTC) Received: by mail-pj1-f52.google.com with SMTP id 98e67ed59e1d1-301c4850194so5657316a91.2 for ; Wed, 09 Apr 2025 08:45:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1744213527; x=1744818327; darn=lists.freedesktop.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=eUZBDj1ge3+4V9XGnjqkyMjyFYeNbBPtxuQpoO8Pkmo=; b=ep2t8SWnlWVCK3B6HjZJojBOxk9trqDpd8dxx5Srsg7HU4SrDrhql3venoVuhATBL+ SGfv0fngnlmqJjkXC1j4g66Tl+G8BvhrRjrhYIlQ4GyoGPwcAnOzrjwsEEcpg3M+mcJH vlJklUYvfjs+ugB2qeRGnW0vaeouOugHdwU7F4x3JUqrnIqoqGWZ0y8ytlyJbhCwSh5D bcgbSDpXkBBoe9YLLKrADa7rQkKaHVtDrNMvfmzgEdrYxPjXY+47dF532HinT0WzmviC mbY/jM3cR7KXdjaj0n9+yt4xQDmS14TBzv687hyUIAXry3gvVruzmd3XdTFBYT5JOsBX asJQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1744213527; x=1744818327; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=eUZBDj1ge3+4V9XGnjqkyMjyFYeNbBPtxuQpoO8Pkmo=; b=JA29Wm7rqVYt40DosLLS/3c+/HjbvM0qpk0Lsr0F+ZGIfhJw+AN0ymk1lIzc1+elA8 4o4LLKidsiY8VGZRb0F8EMi8anHPoGpoL4wP03FGkxfc4QiU0b4ez+v8Wjouu4K9FRkN gNrCn/mxcQVgV+wP5YxjjdXHP5AcRpSk7KjZlSET7Nns8NzgsthpiVBdcCewuKPJWD3j Miy6siI3V0oCVaBPQGby0ozz9wQSVhY5SSyW5GoTOCtMqw1uKJZHAHxFsxMhk3BlLXSL SPN+pUFkQqd6U35ogtuUiZAUwdYj7SOkiQwvTC+j3hbv1wJhf1pVYx4yJoF8kVcES98v mTeg== X-Forwarded-Encrypted: i=1; AJvYcCXuPogcQpQ4ZDHTm7M5Y/e1PP3fxD8pzKLaf2t8Sl8+7bM6zZMHbjZVET0PeNKT7lTdjewYMD9Tz3E=@lists.freedesktop.org X-Gm-Message-State: AOJu0YxhjHg3bmwrogpCjtW/GI9f9luHolDgcztzJafPfpJmgC7ASJvm +XlnGbMFK3wXQc2E9IQioQ2hb73tFS1kzfrWnLsmMWkHTstAvt0D X-Gm-Gg: ASbGncs85SrF0uXnnBrq2I+Rmc/3tk9dmi5yUxihqUdhXuepLCMYPBG4e5+aHXapHZh 27DZkFHMtYbbFTVcP961UUKRv01t1uNs4JDjwlzzuoLKJY1ZEFzboH1/qpO4PWC22+P3erNVKc4 yylReQLoveh/FLlLnMK3pw4jOHH5q3QHfMjP4EFO0L7EhIYApSwf+9pfEXOFbeU7ggy80Ht7lF3 uULF43T+9zQ4PK5vkJKMao+taRU5vKXQ3aS4nyc87nku7labD2ahhSFNw0BdRNVNqHHIMEDjhPv FJv7oDkyvwAdckqQgv4QrzPIeU9WXk3r/zbTp4OpE9cOgWIIYcgKiq0TX+3uOufl6WeL3k8= X-Google-Smtp-Source: AGHT+IGnNb2L5TPy8ZRk67DQoWNz3EnKr3D/3b81/wzKSzl4+H+Bebt+R4hGqZaj7Jkg168nL9a84w== X-Received: by 2002:a17:90b:2e4b:b0:2eb:140d:f6df with SMTP id 98e67ed59e1d1-306dd3247b3mr3471228a91.1.1744213526748; Wed, 09 Apr 2025 08:45:26 -0700 (PDT) Received: from visitorckw-System-Product-Name.. ([140.113.216.168]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-306dd171991sm1952304a91.37.2025.04.09.08.45.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 09 Apr 2025 08:45:26 -0700 (PDT) From: Kuan-Wei Chiu To: tglx@linutronix.de, mingo@redhat.com, bp@alien8.de, dave.hansen@linux.intel.com, x86@kernel.org, jk@ozlabs.org, joel@jms.id.au, eajames@linux.ibm.com, andrzej.hajda@intel.com, neil.armstrong@linaro.org, rfoss@kernel.org, maarten.lankhorst@linux.intel.com, mripard@kernel.org, tzimmermann@suse.de, airlied@gmail.com, simona@ffwll.ch, dmitry.torokhov@gmail.com, mchehab@kernel.org, awalls@md.metrocast.net, hverkuil@xs4all.nl, miquel.raynal@bootlin.com, richard@nod.at, vigneshr@ti.com, louis.peens@corigine.com, andrew+netdev@lunn.ch, davem@davemloft.net, edumazet@google.com, pabeni@redhat.com, parthiban.veerasooran@microchip.com, arend.vanspriel@broadcom.com, johannes@sipsolutions.net, gregkh@linuxfoundation.org, jirislaby@kernel.org, yury.norov@gmail.com, akpm@linux-foundation.org, jdelvare@suse.com, linux@roeck-us.net, alexandre.belloni@bootlin.com, pgaj@cadence.com Cc: hpa@zytor.com, alistair@popple.id.au, linux@rasmusvillemoes.dk, Laurent.pinchart@ideasonboard.com, jonas@kwiboo.se, jernej.skrabec@gmail.com, kuba@kernel.org, linux-kernel@vger.kernel.org, linux-fsi@lists.ozlabs.org, dri-devel@lists.freedesktop.org, linux-input@vger.kernel.org, linux-media@vger.kernel.org, linux-mtd@lists.infradead.org, oss-drivers@corigine.com, netdev@vger.kernel.org, linux-wireless@vger.kernel.org, brcm80211@lists.linux.dev, brcm80211-dev-list.pdl@broadcom.com, linux-serial@vger.kernel.org, bpf@vger.kernel.org, jserv@ccns.ncku.edu.tw, Frank.Li@nxp.com, linux-hwmon@vger.kernel.org, linux-i3c@lists.infradead.org, david.laight.linux@gmail.com, andrew.cooper3@citrix.com, Kuan-Wei Chiu , Yu-Chun Lin Subject: [PATCH v4 05/13] serial: max3100: Replace open-coded parity calculation with parity_odd() Date: Wed, 9 Apr 2025 23:43:48 +0800 Message-Id: <20250409154356.423512-6-visitorckw@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20250409154356.423512-1-visitorckw@gmail.com> References: <20250409154356.423512-1-visitorckw@gmail.com> MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Refactor parity calculations to use the standard parity_odd() helper. This change eliminates redundant implementations. Co-developed-by: Yu-Chun Lin Signed-off-by: Yu-Chun Lin Signed-off-by: Kuan-Wei Chiu --- drivers/tty/serial/max3100.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/tty/serial/max3100.c b/drivers/tty/serial/max3100.c index f2dd83692b2c..36ed41eef7b1 100644 --- a/drivers/tty/serial/max3100.c +++ b/drivers/tty/serial/max3100.c @@ -16,6 +16,7 @@ /* 4 MAX3100s should be enough for everyone */ #define MAX_MAX3100 4 +#include #include #include #include @@ -133,7 +134,7 @@ static int max3100_do_parity(struct max3100_port *s, u16 c) else c &= 0xff; - parity = parity ^ (hweight8(c) & 1); + parity = parity ^ parity_odd(c); return parity; } From patchwork Wed Apr 9 15:43:49 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kuan-Wei Chiu X-Patchwork-Id: 14045068 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 52909C36002 for ; Wed, 9 Apr 2025 15:45:46 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id B703A10E236; Wed, 9 Apr 2025 15:45:45 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="SIdJqW8f"; dkim-atps=neutral Received: from mail-pj1-f54.google.com (mail-pj1-f54.google.com [209.85.216.54]) by gabe.freedesktop.org (Postfix) with ESMTPS id 9306210E236 for ; Wed, 9 Apr 2025 15:45:44 +0000 (UTC) Received: by mail-pj1-f54.google.com with SMTP id 98e67ed59e1d1-3014ae35534so5779452a91.0 for ; Wed, 09 Apr 2025 08:45:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1744213544; x=1744818344; darn=lists.freedesktop.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=sTd+jcAteb5XQtuvZoTF72DclP9q3bsZAYfMztua9WA=; b=SIdJqW8fGR3zzeMr8sB+aaX9UcEPscqkfKWobAgaSt/JqcuwC4vocAMi3DZqXQd4qw vf2zvFGW4dw0ntvugOldDfu4RHTZXN0Lp6sQ814GwaJfTpegU6187dNspinQYB47OjoZ AdkutouyqPcCq0tw3JVTVcynmR5u1m/O73Uquk7u/ISyL7TdW2+rxSHNRDyO9D6oBvhn nyJNi8QVDl7vZBX3F6W6mBmK+6FBDbfWCctCTgW7Rh3FxQ7Jji06ob+1mBbQCaz3K5s8 akqZUqtJMrGEhSgojkIt0Gs0VsWJDLMuMgtOuvQYvy9Vt7FnoaLeEREVfUYcYfDlMf4Z k0wg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1744213544; x=1744818344; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=sTd+jcAteb5XQtuvZoTF72DclP9q3bsZAYfMztua9WA=; b=Wl2SKgAAzrF79eq8OMJEmRT0XYrNoo4qQc3fKYvS03s+vzIhtKfDEjJ3BWLZxtaHNW dALB9QX9GNrGVkHV3AREnydOK5y6yP1fUgytagXL9zYT55af06H/PZV5Kqunyg6vgxrF 6TrHJAIRTnbKAMgeqDerF+2QuyuhZr8AmX8/+pbwjKEzUZYMncykrEYE3yneXaQMaiMq nTlh7rA3o0gByP2FJ6ubimOgSLFii1OD4x5VjFat0btnaUWsFJHUQSwOzpXdZz1XDarU Zb02dlcvRsRqSiBO8/PVv7/SAVQw2ObORFQo0NObcsQe/odJKv5OJKXP0btgVu1tv6o+ VfEg== X-Forwarded-Encrypted: i=1; AJvYcCXwjZijMBZXfP9kFpVzcjNV/HT/bOCPt/BUxP8JfhTFp4sjIIZ9TnoeWGAQmtzKFYfLkN1JI1LD3Sw=@lists.freedesktop.org X-Gm-Message-State: AOJu0YzHkzR2aNOSSsFZpBQEwDOOPpKEMrDgK9P/zGdfgwVZsYO6PXKS jQYGKR90g7Ssd1iXuTnap8NIc9Aig7P4GaMm57szZ9/nfoMcDz9x X-Gm-Gg: ASbGncsKjaRxCK5OVEh9/zpo9u9A9d0apbm1ALBE07TEDMGGn7Y9k5y6lon5aPfTJRs XjjqP4mRjRCjFdwe4yQ4q7CdnOmHpaye25TeXrT7eKis7B2cYrX0wH+XT3SVhgEN2DNmSZJjJoS F+gdjusb0+TNSNhfC2e6RHD5brj/5t8uLyX6FZCcomoQE/ybAK7s60vZnIdOJZbmb2b/GLDd+0W Vaq4qb7BimWC7su32DiyP2wCaNUrxyz1giQ44ikt84oPk/HHEDrJYw47JDpt1wxcmH2s+OH6ukV eG1pHzSCJpR8DL7o8wI8gRYWOeg2yPNUwi99+pguXf3TJ2ixmicI/ZbxJo+d5k4vV3Z2vy4= X-Google-Smtp-Source: AGHT+IEJ7Jl6M7/jx+b0QfG2QtnETYXioK/EteWOwSUQmw7SIb5H5CEFmuEhS1eLp2rAJpsPWE7AMg== X-Received: by 2002:a17:90b:3d09:b0:2ff:6fc3:79c4 with SMTP id 98e67ed59e1d1-306dd56b507mr3990247a91.27.1744213544132; Wed, 09 Apr 2025 08:45:44 -0700 (PDT) Received: from visitorckw-System-Product-Name.. ([140.113.216.168]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-306dd171991sm1952304a91.37.2025.04.09.08.45.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 09 Apr 2025 08:45:43 -0700 (PDT) From: Kuan-Wei Chiu To: tglx@linutronix.de, mingo@redhat.com, bp@alien8.de, dave.hansen@linux.intel.com, x86@kernel.org, jk@ozlabs.org, joel@jms.id.au, eajames@linux.ibm.com, andrzej.hajda@intel.com, neil.armstrong@linaro.org, rfoss@kernel.org, maarten.lankhorst@linux.intel.com, mripard@kernel.org, tzimmermann@suse.de, airlied@gmail.com, simona@ffwll.ch, dmitry.torokhov@gmail.com, mchehab@kernel.org, awalls@md.metrocast.net, hverkuil@xs4all.nl, miquel.raynal@bootlin.com, richard@nod.at, vigneshr@ti.com, louis.peens@corigine.com, andrew+netdev@lunn.ch, davem@davemloft.net, edumazet@google.com, pabeni@redhat.com, parthiban.veerasooran@microchip.com, arend.vanspriel@broadcom.com, johannes@sipsolutions.net, gregkh@linuxfoundation.org, jirislaby@kernel.org, yury.norov@gmail.com, akpm@linux-foundation.org, jdelvare@suse.com, linux@roeck-us.net, alexandre.belloni@bootlin.com, pgaj@cadence.com Cc: hpa@zytor.com, alistair@popple.id.au, linux@rasmusvillemoes.dk, Laurent.pinchart@ideasonboard.com, jonas@kwiboo.se, jernej.skrabec@gmail.com, kuba@kernel.org, linux-kernel@vger.kernel.org, linux-fsi@lists.ozlabs.org, dri-devel@lists.freedesktop.org, linux-input@vger.kernel.org, linux-media@vger.kernel.org, linux-mtd@lists.infradead.org, oss-drivers@corigine.com, netdev@vger.kernel.org, linux-wireless@vger.kernel.org, brcm80211@lists.linux.dev, brcm80211-dev-list.pdl@broadcom.com, linux-serial@vger.kernel.org, bpf@vger.kernel.org, jserv@ccns.ncku.edu.tw, Frank.Li@nxp.com, linux-hwmon@vger.kernel.org, linux-i3c@lists.infradead.org, david.laight.linux@gmail.com, andrew.cooper3@citrix.com, Kuan-Wei Chiu , Yu-Chun Lin Subject: [PATCH v4 06/13] lib/bch: Replace open-coded parity calculation with parity_odd() Date: Wed, 9 Apr 2025 23:43:49 +0800 Message-Id: <20250409154356.423512-7-visitorckw@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20250409154356.423512-1-visitorckw@gmail.com> References: <20250409154356.423512-1-visitorckw@gmail.com> MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Refactor parity calculations to use the standard parity_odd() helper. This change eliminates redundant implementations. Co-developed-by: Yu-Chun Lin Signed-off-by: Yu-Chun Lin Signed-off-by: Kuan-Wei Chiu --- lib/bch.c | 14 +------------- 1 file changed, 1 insertion(+), 13 deletions(-) diff --git a/lib/bch.c b/lib/bch.c index 1c0cb07cdfeb..3f14d69f373e 100644 --- a/lib/bch.c +++ b/lib/bch.c @@ -311,18 +311,6 @@ static inline int deg(unsigned int poly) return fls(poly)-1; } -static inline int parity(unsigned int x) -{ - /* - * public domain code snippet, lifted from - * http://www-graphics.stanford.edu/~seander/bithacks.html - */ - x ^= x >> 1; - x ^= x >> 2; - x = (x & 0x11111111U) * 0x11111111U; - return (x >> 28) & 1; -} - /* Galois field basic operations: multiply, divide, inverse, etc. */ static inline unsigned int gf_mul(struct bch_control *bch, unsigned int a, @@ -524,7 +512,7 @@ static int solve_linear_system(struct bch_control *bch, unsigned int *rows, tmp = 0; for (r = m-1; r >= 0; r--) { mask = rows[r] & (tmp|1); - tmp |= parity(mask) << (m-r); + tmp |= parity_odd(mask) << (m-r); } sol[p] = tmp >> 1; } From patchwork Wed Apr 9 15:43:50 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kuan-Wei Chiu X-Patchwork-Id: 14045069 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id CAA61C36002 for ; Wed, 9 Apr 2025 15:45:57 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 3917910E247; Wed, 9 Apr 2025 15:45:57 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="LTddxGGj"; dkim-atps=neutral Received: from mail-pj1-f41.google.com (mail-pj1-f41.google.com [209.85.216.41]) by gabe.freedesktop.org (Postfix) with ESMTPS id C5C9410E247 for ; Wed, 9 Apr 2025 15:45:55 +0000 (UTC) Received: by mail-pj1-f41.google.com with SMTP id 98e67ed59e1d1-2ff64550991so5570344a91.0 for ; Wed, 09 Apr 2025 08:45:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1744213555; x=1744818355; darn=lists.freedesktop.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=3GTX40p8Eu+tWq8rarx+bIs4dwN06BcTyPGidfavgSc=; b=LTddxGGjiNLQFPy59YI3KpIVXyIpCdKUVR7LZ1LtvvwfO0LPj6p44MnDkSKeaeEVSK vb6EIehv+DEA6KVT/2bERVhuDBwS8K0xiRYl3TTiw1X1lyET1Vf/urHLjmpluCsQtkEV 8TKMeAOrQF6oyBkNZDOK4ju9sIAoX3CIlHgHRNO2NAMpnF9gFly86xFXySm8/bJ/auyQ /h73HBA2yL1XYBkI5Mvi2alvbns9y536ddLjEAThQcgXoEM+MXEm+I5azgKh8Azonh8e RA+TwYtYyxUUHd1Z1vJckQBDzVErK/6lxBFjioqsQ8G/KyamFCpLUlw6bJiz2Vajhifc M/1A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1744213555; x=1744818355; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=3GTX40p8Eu+tWq8rarx+bIs4dwN06BcTyPGidfavgSc=; b=qd0LRUjhsYYFCGT2675KxKQF37UqsMW9pAexq2ZTY3w58UJZgTFxVQkroGTfxWZYbT IlzgKJZqHL/y8BwwqmgazCkWN2gsIO8rGZoPX+uoc0ZDjjOg0M7Tf3PXvBRpch4k/GkK g0uaTuJOl1yrlZvuvtbjI4G0o968VoOZsOsGdjUQzW+1ruDt7/yy/pB/a68fPNU44iph iO0WFDF7mlpTYQxcMMUIlmJPW4Cim/i//Kyx3UVtFYtEoliXOzDBo2jpRAbBOkofiplB y1cYLEgsOM5zy9g3fc6m5AnyVxcJk0hwG64NpLookBjfUBXguEr8neWz0luiJDrosxZ2 Ykjg== X-Forwarded-Encrypted: i=1; AJvYcCWrqDQDykoR7gmLfCaCTRkJk5J9ruKmXdH/wenPXI11V0uG8VYnhmmhG2Wv3hkVesD+LD8w4qdrJjk=@lists.freedesktop.org X-Gm-Message-State: AOJu0Yzv2qnCu8YLth+VGN8k9Ie5Pdy7+GcJ6SL+dTY3vLTMNDWFKfH+ Ms9Ih0T+kWOuVohnODt+DcxDSlYkOjmZgtzhcuVJQcYUSYahGdQK X-Gm-Gg: ASbGncsPGyUvXRZQ+UIqJ19KHYg3p8Yu0r1PFznZgGIc+ElEOAspgRm0dL4i652IywR 997F/VSEzPX2bSujfxn4KgjaaAIxfHI3S2PWsInkqVfAQk9dzDwIjIS4czeYuEdUoclH1PqS6+4 9g/gdWe58yjcj/fIDAOtPPaC1A3ikeNPIPwG1LSeQTf1Vp9omQW1ugc66AX2Qfar2gWIjtG2LPK LGeGSzy+gdXNPIdot3MQVzfZK+sdnrA5hBHPJ6YZK+e7A5q3QeSRIIaAKsTMwCFKtrIFpfKGeKf fdJlTA1W9hTMfxtzbiMg6DqcpVOpaDfvbREGZLRPkBQhxYpDLHWfdE9r55DpqnImNEC/N1I= X-Google-Smtp-Source: AGHT+IG+nlKBY0fzC5EpfikKx++hN068mStMCGrKOPeFQ0KT+ZFhaeW1hEnEku5KKvT2BN4jgM2ClA== X-Received: by 2002:a17:90b:2dca:b0:305:2d28:e435 with SMTP id 98e67ed59e1d1-306dbb8e7d2mr5088169a91.7.1744213555184; Wed, 09 Apr 2025 08:45:55 -0700 (PDT) Received: from visitorckw-System-Product-Name.. ([140.113.216.168]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-306dd171991sm1952304a91.37.2025.04.09.08.45.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 09 Apr 2025 08:45:54 -0700 (PDT) From: Kuan-Wei Chiu To: tglx@linutronix.de, mingo@redhat.com, bp@alien8.de, dave.hansen@linux.intel.com, x86@kernel.org, jk@ozlabs.org, joel@jms.id.au, eajames@linux.ibm.com, andrzej.hajda@intel.com, neil.armstrong@linaro.org, rfoss@kernel.org, maarten.lankhorst@linux.intel.com, mripard@kernel.org, tzimmermann@suse.de, airlied@gmail.com, simona@ffwll.ch, dmitry.torokhov@gmail.com, mchehab@kernel.org, awalls@md.metrocast.net, hverkuil@xs4all.nl, miquel.raynal@bootlin.com, richard@nod.at, vigneshr@ti.com, louis.peens@corigine.com, andrew+netdev@lunn.ch, davem@davemloft.net, edumazet@google.com, pabeni@redhat.com, parthiban.veerasooran@microchip.com, arend.vanspriel@broadcom.com, johannes@sipsolutions.net, gregkh@linuxfoundation.org, jirislaby@kernel.org, yury.norov@gmail.com, akpm@linux-foundation.org, jdelvare@suse.com, linux@roeck-us.net, alexandre.belloni@bootlin.com, pgaj@cadence.com Cc: hpa@zytor.com, alistair@popple.id.au, linux@rasmusvillemoes.dk, Laurent.pinchart@ideasonboard.com, jonas@kwiboo.se, jernej.skrabec@gmail.com, kuba@kernel.org, linux-kernel@vger.kernel.org, linux-fsi@lists.ozlabs.org, dri-devel@lists.freedesktop.org, linux-input@vger.kernel.org, linux-media@vger.kernel.org, linux-mtd@lists.infradead.org, oss-drivers@corigine.com, netdev@vger.kernel.org, linux-wireless@vger.kernel.org, brcm80211@lists.linux.dev, brcm80211-dev-list.pdl@broadcom.com, linux-serial@vger.kernel.org, bpf@vger.kernel.org, jserv@ccns.ncku.edu.tw, Frank.Li@nxp.com, linux-hwmon@vger.kernel.org, linux-i3c@lists.infradead.org, david.laight.linux@gmail.com, andrew.cooper3@citrix.com, Kuan-Wei Chiu , Yu-Chun Lin Subject: [PATCH v4 07/13] Input: joystick - Replace open-coded parity calculation with parity_odd() Date: Wed, 9 Apr 2025 23:43:50 +0800 Message-Id: <20250409154356.423512-8-visitorckw@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20250409154356.423512-1-visitorckw@gmail.com> References: <20250409154356.423512-1-visitorckw@gmail.com> MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Refactor parity calculations to use the standard parity_odd() helper. This change eliminates redundant implementations. Co-developed-by: Yu-Chun Lin Signed-off-by: Yu-Chun Lin Signed-off-by: Kuan-Wei Chiu Acked-by: Dmitry Torokhov --- drivers/input/joystick/grip_mp.c | 17 ++--------------- drivers/input/joystick/sidewinder.c | 25 +++++-------------------- 2 files changed, 7 insertions(+), 35 deletions(-) diff --git a/drivers/input/joystick/grip_mp.c b/drivers/input/joystick/grip_mp.c index 5eadb5a3ca37..e7f60a83a89b 100644 --- a/drivers/input/joystick/grip_mp.c +++ b/drivers/input/joystick/grip_mp.c @@ -18,6 +18,7 @@ #include #include #include +#include #define DRIVER_DESC "Gravis Grip Multiport driver" @@ -112,20 +113,6 @@ static const int axis_map[] = { 5, 9, 1, 5, 6, 10, 2, 6, 4, 8, 0, 4, 5, 9, 1, 5 static int register_slot(int i, struct grip_mp *grip); -/* - * Returns whether an odd or even number of bits are on in pkt. - */ - -static int bit_parity(u32 pkt) -{ - int x = pkt ^ (pkt >> 16); - x ^= x >> 8; - x ^= x >> 4; - x ^= x >> 2; - x ^= x >> 1; - return x & 1; -} - /* * Poll gameport; return true if all bits set in 'onbits' are on and * all bits set in 'offbits' are off. @@ -236,7 +223,7 @@ static int mp_io(struct gameport* gameport, int sendflags, int sendcode, u32 *pa pkt = (pkt >> 2) | 0xf0000000; } - if (bit_parity(pkt) == 1) + if (parity_odd(pkt)) return IO_RESET; /* Acknowledge packet receipt */ diff --git a/drivers/input/joystick/sidewinder.c b/drivers/input/joystick/sidewinder.c index 3a5873e5fcb3..fb6f7004a485 100644 --- a/drivers/input/joystick/sidewinder.c +++ b/drivers/input/joystick/sidewinder.c @@ -7,6 +7,7 @@ * Microsoft SideWinder joystick family driver for Linux */ +#include #include #include #include @@ -240,22 +241,6 @@ static void sw_init_digital(struct gameport *gameport) local_irq_restore(flags); } -/* - * sw_parity() computes parity of __u64 - */ - -static int sw_parity(__u64 t) -{ - int x = t ^ (t >> 32); - - x ^= x >> 16; - x ^= x >> 8; - x ^= x >> 4; - x ^= x >> 2; - x ^= x >> 1; - return x & 1; -} - /* * sw_ccheck() checks synchronization bits and computes checksum of nibbles. */ @@ -316,7 +301,7 @@ static int sw_parse(unsigned char *buf, struct sw *sw) for (i = 0; i < sw->number; i ++) { - if (sw_parity(GB(i*15,15))) + if (parity_odd(GB(i*15,15))) return -1; input_report_abs(sw->dev[i], ABS_X, GB(i*15+3,1) - GB(i*15+2,1)); @@ -333,7 +318,7 @@ static int sw_parse(unsigned char *buf, struct sw *sw) case SW_ID_PP: case SW_ID_FFP: - if (!sw_parity(GB(0,48)) || (hat = GB(42,4)) > 8) + if (!parity_odd(GB(0,48)) || (hat = GB(42,4)) > 8) return -1; dev = sw->dev[0]; @@ -354,7 +339,7 @@ static int sw_parse(unsigned char *buf, struct sw *sw) case SW_ID_FSP: - if (!sw_parity(GB(0,43)) || (hat = GB(28,4)) > 8) + if (!parity_odd(GB(0,43)) || (hat = GB(28,4)) > 8) return -1; dev = sw->dev[0]; @@ -379,7 +364,7 @@ static int sw_parse(unsigned char *buf, struct sw *sw) case SW_ID_FFW: - if (!sw_parity(GB(0,33))) + if (!parity_odd(GB(0,33))) return -1; dev = sw->dev[0]; From patchwork Wed Apr 9 15:43:51 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kuan-Wei Chiu X-Patchwork-Id: 14045070 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 94D2FC36002 for ; Wed, 9 Apr 2025 15:46:07 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 0D05A10E279; Wed, 9 Apr 2025 15:46:07 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="fW4Hqw4x"; dkim-atps=neutral Received: from mail-pj1-f41.google.com (mail-pj1-f41.google.com [209.85.216.41]) by gabe.freedesktop.org (Postfix) with ESMTPS id 97C1210E279 for ; Wed, 9 Apr 2025 15:46:06 +0000 (UTC) Received: by mail-pj1-f41.google.com with SMTP id 98e67ed59e1d1-301c4850194so5658049a91.2 for ; Wed, 09 Apr 2025 08:46:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1744213566; x=1744818366; darn=lists.freedesktop.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=dXLi2SRJHleL6i4thZNOgy64MnVVDpLvymelzP4O5VU=; b=fW4Hqw4xuTr6JLhCaNDZRdy7HexZ2Ai5fd7OMUjHD5vPoPrVYpMqyq4wgcSAZn61yo R2ZMMI7ySqClHUQ0I1dKivHMIZuGz7O8ZuD4RV43SznZnQ0GdmLrvKm330dq2uZF8ISH L2M0IsYwbKgmgkTnbEqE35BYg2Hier/IbtS3D0o5wV39/eVazVfTNNfuywmepPBtI0Gx VBdic0v321IV/EvMtx8yWZfOGywfMfZvXFequ6vMz4rDssXBLEn/Sfd8QH3JM2aXV7xX JWZ3/l+YO2ljFUzMvuyA8KYAZr4O2RgjyU6FbJ6LJWDvFScop8+RBFlPlNUOq9KIlBhG fD7g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1744213566; x=1744818366; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=dXLi2SRJHleL6i4thZNOgy64MnVVDpLvymelzP4O5VU=; b=CFxJfWQUEspfSvDu4ZIeqEQBt1RgxQtMgg+hTLlohvkVid/AWBJ0wS+MStxDYs5dd2 TDXo3/qvF6j1gqXGV6Fy4UZUM04nWhtZQ2KdnSr/KwaIfdZS+l/10HBqKXBEMJEmDP35 f3NWlUn6bk68PEgsERQ+lcwHQvVgtFqnfp/1j6+uNKffJcoc6DLhyLABTj2xtxomQl96 RULuEXatWEICor4eHKz/JPg5eC1LiZT2dvXtdkROx6T41MbMQUUFXLKHc7QngSXmBF1v mPuEpCYO3EYqAg5GT3s7IIlj42gmMd21EbZRZeBByHR84CynV7nAof55oP7ZNPx5OK5M qQsw== X-Forwarded-Encrypted: i=1; AJvYcCUDWVlMv8U7qrAi3L1M/dBhxt4PD1fU7F+vvt5FC9EtPmlntX7X+6B5LEn2wXsXi+UpTZDFGh5b428=@lists.freedesktop.org X-Gm-Message-State: AOJu0YwZJ4DvQlDQi1Vpc4h2Vyz0ZeDZF3mTu1XttsKEFSzeT/TdZzBv yOb5WTsnatmqzu1XENh3OoKTqQn7UrtcV6tVzGflVHFnKf09SwnO X-Gm-Gg: ASbGnct2z6PbgGd1G3hQrSFtXTlwFyPvtX5Jvd8OLqkAia2PL1isqk3Vn9WuUceaVja RydxKsutaXBCr3eFgNT/Dj2MnnkdWqrjiJm/jSBoRNTjjkfhtrCG2C0QJ+ub/R71XOnihfGqySK 3SISb2NDIvncaUhRxUCoQ/bPduFRqCquU4pO2zl58S1CUIGbI80KIUp/eMbfk39B5Z9OyX5PxCL ZDtplnrp4uBP4Gk9Bpp2r2prWzAT2xdS9tHTMgVci887pBd1/c3salUgUxqDFcoNeCMQhyRwJZy veaB2tGcKvAsdbBZjBea5D7ZwBV7VROr/VkHpfc6Unt82mhaoXH8SbJgmGTqGaZ2/I15Rzw= X-Google-Smtp-Source: AGHT+IGweN+KZRMZ3CYcrqcq5iC29qaxOJUe/Q8yFuoByE0YY1D6tXNucvOC/QvWbivmYcNL8OhrUw== X-Received: by 2002:a17:90b:584b:b0:2f4:4500:bb4d with SMTP id 98e67ed59e1d1-306dd52eaadmr4119633a91.20.1744213565972; Wed, 09 Apr 2025 08:46:05 -0700 (PDT) Received: from visitorckw-System-Product-Name.. ([140.113.216.168]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-306dd171991sm1952304a91.37.2025.04.09.08.45.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 09 Apr 2025 08:46:05 -0700 (PDT) From: Kuan-Wei Chiu To: tglx@linutronix.de, mingo@redhat.com, bp@alien8.de, dave.hansen@linux.intel.com, x86@kernel.org, jk@ozlabs.org, joel@jms.id.au, eajames@linux.ibm.com, andrzej.hajda@intel.com, neil.armstrong@linaro.org, rfoss@kernel.org, maarten.lankhorst@linux.intel.com, mripard@kernel.org, tzimmermann@suse.de, airlied@gmail.com, simona@ffwll.ch, dmitry.torokhov@gmail.com, mchehab@kernel.org, awalls@md.metrocast.net, hverkuil@xs4all.nl, miquel.raynal@bootlin.com, richard@nod.at, vigneshr@ti.com, louis.peens@corigine.com, andrew+netdev@lunn.ch, davem@davemloft.net, edumazet@google.com, pabeni@redhat.com, parthiban.veerasooran@microchip.com, arend.vanspriel@broadcom.com, johannes@sipsolutions.net, gregkh@linuxfoundation.org, jirislaby@kernel.org, yury.norov@gmail.com, akpm@linux-foundation.org, jdelvare@suse.com, linux@roeck-us.net, alexandre.belloni@bootlin.com, pgaj@cadence.com Cc: hpa@zytor.com, alistair@popple.id.au, linux@rasmusvillemoes.dk, Laurent.pinchart@ideasonboard.com, jonas@kwiboo.se, jernej.skrabec@gmail.com, kuba@kernel.org, linux-kernel@vger.kernel.org, linux-fsi@lists.ozlabs.org, dri-devel@lists.freedesktop.org, linux-input@vger.kernel.org, linux-media@vger.kernel.org, linux-mtd@lists.infradead.org, oss-drivers@corigine.com, netdev@vger.kernel.org, linux-wireless@vger.kernel.org, brcm80211@lists.linux.dev, brcm80211-dev-list.pdl@broadcom.com, linux-serial@vger.kernel.org, bpf@vger.kernel.org, jserv@ccns.ncku.edu.tw, Frank.Li@nxp.com, linux-hwmon@vger.kernel.org, linux-i3c@lists.infradead.org, david.laight.linux@gmail.com, andrew.cooper3@citrix.com, Kuan-Wei Chiu , Yu-Chun Lin Subject: [PATCH v4 08/13] net: ethernet: oa_tc6: Replace open-coded parity calculation with parity_odd() Date: Wed, 9 Apr 2025 23:43:51 +0800 Message-Id: <20250409154356.423512-9-visitorckw@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20250409154356.423512-1-visitorckw@gmail.com> References: <20250409154356.423512-1-visitorckw@gmail.com> MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Refactor parity calculations to use the standard parity_odd() helper. This change eliminates redundant implementations. Co-developed-by: Yu-Chun Lin Signed-off-by: Yu-Chun Lin Signed-off-by: Kuan-Wei Chiu --- drivers/net/ethernet/oa_tc6.c | 19 +++---------------- 1 file changed, 3 insertions(+), 16 deletions(-) diff --git a/drivers/net/ethernet/oa_tc6.c b/drivers/net/ethernet/oa_tc6.c index db200e4ec284..6734b49357e7 100644 --- a/drivers/net/ethernet/oa_tc6.c +++ b/drivers/net/ethernet/oa_tc6.c @@ -6,6 +6,7 @@ */ #include +#include #include #include #include @@ -177,19 +178,6 @@ static int oa_tc6_spi_transfer(struct oa_tc6 *tc6, return spi_sync(tc6->spi, &msg); } -static int oa_tc6_get_parity(u32 p) -{ - /* Public domain code snippet, lifted from - * http://www-graphics.stanford.edu/~seander/bithacks.html - */ - p ^= p >> 1; - p ^= p >> 2; - p = (p & 0x11111111U) * 0x11111111U; - - /* Odd parity is used here */ - return !((p >> 28) & 1); -} - static __be32 oa_tc6_prepare_ctrl_header(u32 addr, u8 length, enum oa_tc6_register_op reg_op) { @@ -202,7 +190,7 @@ static __be32 oa_tc6_prepare_ctrl_header(u32 addr, u8 length, FIELD_PREP(OA_TC6_CTRL_HEADER_ADDR, addr) | FIELD_PREP(OA_TC6_CTRL_HEADER_LENGTH, length - 1); header |= FIELD_PREP(OA_TC6_CTRL_HEADER_PARITY, - oa_tc6_get_parity(header)); + !parity_odd(header)); return cpu_to_be32(header); } @@ -940,8 +928,7 @@ static __be32 oa_tc6_prepare_data_header(bool data_valid, bool start_valid, FIELD_PREP(OA_TC6_DATA_HEADER_END_BYTE_OFFSET, end_byte_offset); - header |= FIELD_PREP(OA_TC6_DATA_HEADER_PARITY, - oa_tc6_get_parity(header)); + header |= FIELD_PREP(OA_TC6_DATA_HEADER_PARITY, !parity_odd(header)); return cpu_to_be32(header); } From patchwork Wed Apr 9 15:43:52 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kuan-Wei Chiu X-Patchwork-Id: 14045071 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D6FBEC36002 for ; Wed, 9 Apr 2025 15:46:23 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 4A36910E1E0; Wed, 9 Apr 2025 15:46:23 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="B7NHd6JP"; dkim-atps=neutral Received: from mail-pg1-f179.google.com (mail-pg1-f179.google.com [209.85.215.179]) by gabe.freedesktop.org (Postfix) with ESMTPS id 7B04310E1E0 for ; Wed, 9 Apr 2025 15:46:22 +0000 (UTC) Received: by mail-pg1-f179.google.com with SMTP id 41be03b00d2f7-af519c159a8so6358294a12.3 for ; Wed, 09 Apr 2025 08:46:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1744213582; x=1744818382; darn=lists.freedesktop.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=jbWQUZQwY5O/XbpqxBGOs/Motht++mnKBdeylhl46Ro=; b=B7NHd6JPTR6/h8/CB+yiL6rAZ43xVJvAm3W13AK/7CrQWFhBvXJJUVkeCwZzcGdHWr G604v5VtxyXQ/dBXGAeXcblil35kw/+WsxlVIONdjjMP0zE1zu01HQDjdCzgSwKEEdmE +ztrorMmLoVTYhF65WH7QR+TMONeu0h3HasAgwUpMNolJw5ij3xAx4oP4pCgf3hoZWVh tOeomDDrQ6LwnFq+DSOabHGsr3p1CBlZ+lFsJ+gmI+bWBrn7cAKlcutSsOvCBuKeoS5P jFeWZIBIKBap/IY8Xfa0lABItt4LJp1P9DlkPazViqpvn2dB11JnbhsHbHlQvUkcvhNi TF0A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1744213582; x=1744818382; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=jbWQUZQwY5O/XbpqxBGOs/Motht++mnKBdeylhl46Ro=; b=iU8FKW9gp8laI4/4iS99s1jHp753AyJRKcpaYDdtNDN+952QsmxfGqTNN1s/nOyPYA RxG+5WxYyNCL6leQa6GzUB1twiquqaPCNgpavGlFy7d6mGsxo9kWus8vstk5XfYp9bIG GWeLJ57ZSr2zyiWPftOFJkFgn0K6CqfLIl0hhqbisQsJiY2ufNJTgvcan/SHEtOEvq4z eFMMH7s98egWMkcIzZYdElK2/lEEQGfUn1slxmG1SUjiP32u4bFlIfUpoTttzmSFsSgU A6lEy3TyKID0L2SaISH4H1jT4JWogaL82MiTIkc7AI4Gv3tNlfdcbNXai5/7NEAT9qS+ OEcA== X-Forwarded-Encrypted: i=1; AJvYcCUNjy9qd707Az7PasUA0X70zReTBDjTcKueguBltwA1JWQwyZHEAdSjoOAFJMlvvQSZ6cKG7fGr6cw=@lists.freedesktop.org X-Gm-Message-State: AOJu0Yxw3PC0d5al+x2NFoUfD0o0iZNLxy5fbC80nZ4OlZEqyP2hCTsi IxxcUDVmxwizo1k09huPbnTgT4WlsEiIDvlv3I6YsT1tii6OFmUU X-Gm-Gg: ASbGncs9PIJ2YENbS9JNmpPdGZLPFPbfkPY5FX7v1YBB2N6jGP4bGDl8kjW8+LlIbDv hbqahov4ywRJIRkXW4EueFFCRV/niMQZg6fviyIUz/vWEjtaksG0qJW3OLfOCXvJ7EHlDiMtVNp t6gyjsdwbHnnJ3U5fNqlsb8YFnxQlTNOUbMr2CTlbAfuZ1e680BkSv/Jx27FO/11vpEYxwj5Elw izK2Jbyr60VbbtKVST4VlErw2RJyvOjTbolCvc38kPsrcQaAUrfPdchy+iHNAZf70h7P/8Gqbuo HaJHjDV+iuotTHwiO/ixb7PBiK0Z//hdXuXQ+kY+TOErAzh+oziDdXUWtYq8MxGZQXwtRwY= X-Google-Smtp-Source: AGHT+IEd3EC/Z0ac7A9mI3otjelgXE3L0dUH+HAICIEWTo12gF8GwwD4nirjVp0rJrYl27/5nkbmDA== X-Received: by 2002:a17:90a:d60e:b0:2f4:4003:f3d4 with SMTP id 98e67ed59e1d1-306dbc2a7dbmr4740684a91.30.1744213582002; Wed, 09 Apr 2025 08:46:22 -0700 (PDT) Received: from visitorckw-System-Product-Name.. ([140.113.216.168]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-306dd171991sm1952304a91.37.2025.04.09.08.46.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 09 Apr 2025 08:46:21 -0700 (PDT) From: Kuan-Wei Chiu To: tglx@linutronix.de, mingo@redhat.com, bp@alien8.de, dave.hansen@linux.intel.com, x86@kernel.org, jk@ozlabs.org, joel@jms.id.au, eajames@linux.ibm.com, andrzej.hajda@intel.com, neil.armstrong@linaro.org, rfoss@kernel.org, maarten.lankhorst@linux.intel.com, mripard@kernel.org, tzimmermann@suse.de, airlied@gmail.com, simona@ffwll.ch, dmitry.torokhov@gmail.com, mchehab@kernel.org, awalls@md.metrocast.net, hverkuil@xs4all.nl, miquel.raynal@bootlin.com, richard@nod.at, vigneshr@ti.com, louis.peens@corigine.com, andrew+netdev@lunn.ch, davem@davemloft.net, edumazet@google.com, pabeni@redhat.com, parthiban.veerasooran@microchip.com, arend.vanspriel@broadcom.com, johannes@sipsolutions.net, gregkh@linuxfoundation.org, jirislaby@kernel.org, yury.norov@gmail.com, akpm@linux-foundation.org, jdelvare@suse.com, linux@roeck-us.net, alexandre.belloni@bootlin.com, pgaj@cadence.com Cc: hpa@zytor.com, alistair@popple.id.au, linux@rasmusvillemoes.dk, Laurent.pinchart@ideasonboard.com, jonas@kwiboo.se, jernej.skrabec@gmail.com, kuba@kernel.org, linux-kernel@vger.kernel.org, linux-fsi@lists.ozlabs.org, dri-devel@lists.freedesktop.org, linux-input@vger.kernel.org, linux-media@vger.kernel.org, linux-mtd@lists.infradead.org, oss-drivers@corigine.com, netdev@vger.kernel.org, linux-wireless@vger.kernel.org, brcm80211@lists.linux.dev, brcm80211-dev-list.pdl@broadcom.com, linux-serial@vger.kernel.org, bpf@vger.kernel.org, jserv@ccns.ncku.edu.tw, Frank.Li@nxp.com, linux-hwmon@vger.kernel.org, linux-i3c@lists.infradead.org, david.laight.linux@gmail.com, andrew.cooper3@citrix.com, Kuan-Wei Chiu , Yu-Chun Lin Subject: [PATCH v4 09/13] wifi: brcm80211: Replace open-coded parity calculation with parity_odd() Date: Wed, 9 Apr 2025 23:43:52 +0800 Message-Id: <20250409154356.423512-10-visitorckw@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20250409154356.423512-1-visitorckw@gmail.com> References: <20250409154356.423512-1-visitorckw@gmail.com> MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Refactor parity calculations to use the standard parity_odd() helper. This change eliminates redundant implementations. Co-developed-by: Yu-Chun Lin Signed-off-by: Yu-Chun Lin Signed-off-by: Kuan-Wei Chiu Acked-by: Arend van Spriel --- .../wireless/broadcom/brcm80211/brcmsmac/dma.c | 18 ++---------------- 1 file changed, 2 insertions(+), 16 deletions(-) diff --git a/drivers/net/wireless/broadcom/brcm80211/brcmsmac/dma.c b/drivers/net/wireless/broadcom/brcm80211/brcmsmac/dma.c index 80c35027787a..5d7500ee2d3b 100644 --- a/drivers/net/wireless/broadcom/brcm80211/brcmsmac/dma.c +++ b/drivers/net/wireless/broadcom/brcm80211/brcmsmac/dma.c @@ -17,6 +17,7 @@ #include #include #include +#include #include #include @@ -283,24 +284,9 @@ struct dma_info { bool aligndesc_4k; }; -/* Check for odd number of 1's */ -static u32 parity32(__le32 data) -{ - /* no swap needed for counting 1's */ - u32 par_data = *(u32 *)&data; - - par_data ^= par_data >> 16; - par_data ^= par_data >> 8; - par_data ^= par_data >> 4; - par_data ^= par_data >> 2; - par_data ^= par_data >> 1; - - return par_data & 1; -} - static bool dma64_dd_parity(struct dma64desc *dd) { - return parity32(dd->addrlow ^ dd->addrhigh ^ dd->ctrl1 ^ dd->ctrl2); + return parity_odd(dd->addrlow ^ dd->addrhigh ^ dd->ctrl1 ^ dd->ctrl2); } /* descriptor bumping functions */ From patchwork Wed Apr 9 15:43:53 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kuan-Wei Chiu X-Patchwork-Id: 14045072 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 41BD1C36002 for ; Wed, 9 Apr 2025 15:46:34 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 9F8BB10E2EC; Wed, 9 Apr 2025 15:46:33 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="G0trf5Pd"; dkim-atps=neutral Received: from mail-pg1-f172.google.com (mail-pg1-f172.google.com [209.85.215.172]) by gabe.freedesktop.org (Postfix) with ESMTPS id 5884410E2EC for ; Wed, 9 Apr 2025 15:46:33 +0000 (UTC) Received: by mail-pg1-f172.google.com with SMTP id 41be03b00d2f7-af6b02d9e5eso4883026a12.0 for ; Wed, 09 Apr 2025 08:46:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1744213593; x=1744818393; darn=lists.freedesktop.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=GxwU2Eo6SZITicqBQinN6iBaz5ky/0lGxu1bDy42GZ4=; b=G0trf5Pdt2fqz5tmv1ie4b1v/PIYMsXF0t4QiuQYpZ03XRMApoeFX2Tr1S2DkfRawX oVZGq1VPX1kKON1EVkM7xVJUfsq4BTcQC/MC9TZSbiYFnWQpxh6W/r6rqHLWUxNo49Dt msyN3MV6RS6YxfX0bRHOPhkksRyeTd9P3PtQKU/1aVKxqoeaLT8ZqjXwn5xB2qzZQiDQ LICfdgNvCtXRbtmzML1Ybl2lZ4x2bj42N2hW7IKm21IRJm/kd5PjCQRgl50TRtG9Ug+N Eed3/ML12tofqXI8pjbOV3SlMsWZshLb8TXa5tHbocELv+vE5xj5tVn9Rsqz2RJlYLHs bOcA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1744213593; x=1744818393; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=GxwU2Eo6SZITicqBQinN6iBaz5ky/0lGxu1bDy42GZ4=; b=nDrqXI/zKb8viqdnttcqMSnC0Xl2Lz8Uhv+H9HABZl2lUI4ox9ieV6zfrmR/EB6Qvw AJPsbQ8qbjBtjEQTknMO1XVr34ZurrMPEFNwlc3Duma6vNNuu7CU3TK/5U1/GmsQPtYq MvDE6Xzo6UvUTNjMTiI68y8z7fMGIv3xQxjV9ek7PEOd9zU5Dm6gOzj4fEKguQu4vp4D 8eE/a0yM4RUTbkNdSSM1NZAkTUIXTvqNYt8LCgQEQpFIwsJ4Zy5fdqRngDkHv/nRKb+d LemdUKXLulVY9SJ6SmYCmSwr+6JfxybgJvysvNVrfTornj9oYUN3siu//ksYBziQxSPR F9XQ== X-Forwarded-Encrypted: i=1; AJvYcCXH3GtFfEDMHIXKPpdygULk1DoHrTt2cOv+4ldHXpG1sph7VjzusoKt0Z/XnV+hNJBqq407IKt8KpM=@lists.freedesktop.org X-Gm-Message-State: AOJu0Yw54OX+P7Kf+DAgBsFjUnkjuXTiPpckwfC+6x7F//RLhSzenXwZ Efuz/Ukgkon8qMKyrsdRENuL8fr2lv3Aq/UusIc+oAK1DB+X6Fs/ X-Gm-Gg: ASbGncuiEqvnrEfBUQ2prQoiSQ2JP6RaCMLUBZvaqOp2kvupQr9m59p3666owSfnVMc pAVU9Za9gqaDmUILppUYxoNJFy6bBK2tgacvsGejlcFxg208kDAFpWUz1MZTX0tntEjR0o50BN5 qcpwlRJ/jPFEAPLs8NsBilLlbbYhTmKibjOQbXkysU4yz4hzZJSZ3wErJ9yp8BmsUn6CyQX0Lia SMtY5LJd/gQOGitrFyZL9/8UDHsbU6WRUh8NyquIrNwPLki7pUxL382yOtPk4oJReoz+xQtNbwQ PtntI3IwRLZAoAeZlIrrymoz7k0ppMWvT1e2FnIDgxL2ANx3+SpKBIPZDfH3SWD/UbElPRo= X-Google-Smtp-Source: AGHT+IGJskC9aR+5Dgsn/0q7tVfn/b9wEb0pUAkxSpjYPK7zbEkvmX2PCK7JdW0DCG7ccVky18srmw== X-Received: by 2002:a17:90a:c887:b0:301:a0e9:66f with SMTP id 98e67ed59e1d1-306dd521d88mr4820575a91.14.1744213592804; Wed, 09 Apr 2025 08:46:32 -0700 (PDT) Received: from visitorckw-System-Product-Name.. ([140.113.216.168]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-306dd171991sm1952304a91.37.2025.04.09.08.46.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 09 Apr 2025 08:46:32 -0700 (PDT) From: Kuan-Wei Chiu To: tglx@linutronix.de, mingo@redhat.com, bp@alien8.de, dave.hansen@linux.intel.com, x86@kernel.org, jk@ozlabs.org, joel@jms.id.au, eajames@linux.ibm.com, andrzej.hajda@intel.com, neil.armstrong@linaro.org, rfoss@kernel.org, maarten.lankhorst@linux.intel.com, mripard@kernel.org, tzimmermann@suse.de, airlied@gmail.com, simona@ffwll.ch, dmitry.torokhov@gmail.com, mchehab@kernel.org, awalls@md.metrocast.net, hverkuil@xs4all.nl, miquel.raynal@bootlin.com, richard@nod.at, vigneshr@ti.com, louis.peens@corigine.com, andrew+netdev@lunn.ch, davem@davemloft.net, edumazet@google.com, pabeni@redhat.com, parthiban.veerasooran@microchip.com, arend.vanspriel@broadcom.com, johannes@sipsolutions.net, gregkh@linuxfoundation.org, jirislaby@kernel.org, yury.norov@gmail.com, akpm@linux-foundation.org, jdelvare@suse.com, linux@roeck-us.net, alexandre.belloni@bootlin.com, pgaj@cadence.com Cc: hpa@zytor.com, alistair@popple.id.au, linux@rasmusvillemoes.dk, Laurent.pinchart@ideasonboard.com, jonas@kwiboo.se, jernej.skrabec@gmail.com, kuba@kernel.org, linux-kernel@vger.kernel.org, linux-fsi@lists.ozlabs.org, dri-devel@lists.freedesktop.org, linux-input@vger.kernel.org, linux-media@vger.kernel.org, linux-mtd@lists.infradead.org, oss-drivers@corigine.com, netdev@vger.kernel.org, linux-wireless@vger.kernel.org, brcm80211@lists.linux.dev, brcm80211-dev-list.pdl@broadcom.com, linux-serial@vger.kernel.org, bpf@vger.kernel.org, jserv@ccns.ncku.edu.tw, Frank.Li@nxp.com, linux-hwmon@vger.kernel.org, linux-i3c@lists.infradead.org, david.laight.linux@gmail.com, andrew.cooper3@citrix.com, Kuan-Wei Chiu , Yu-Chun Lin Subject: [PATCH v4 10/13] drm/bridge: dw-hdmi: Replace open-coded parity calculation with parity_odd() Date: Wed, 9 Apr 2025 23:43:53 +0800 Message-Id: <20250409154356.423512-11-visitorckw@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20250409154356.423512-1-visitorckw@gmail.com> References: <20250409154356.423512-1-visitorckw@gmail.com> MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Refactor parity calculations to use the standard parity_odd() helper. This change eliminates redundant implementations. Co-developed-by: Yu-Chun Lin Signed-off-by: Yu-Chun Lin Signed-off-by: Kuan-Wei Chiu --- drivers/gpu/drm/bridge/synopsys/dw-hdmi-ahb-audio.c | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/drivers/gpu/drm/bridge/synopsys/dw-hdmi-ahb-audio.c b/drivers/gpu/drm/bridge/synopsys/dw-hdmi-ahb-audio.c index cf1f66b7b192..abf2c72be622 100644 --- a/drivers/gpu/drm/bridge/synopsys/dw-hdmi-ahb-audio.c +++ b/drivers/gpu/drm/bridge/synopsys/dw-hdmi-ahb-audio.c @@ -4,6 +4,7 @@ * * Written and tested against the Designware HDMI Tx found in iMX6. */ +#include #include #include #include @@ -171,12 +172,7 @@ static void dw_hdmi_reformat_iec958(struct snd_dw_hdmi *dw, static u32 parity(u32 sample) { - sample ^= sample >> 16; - sample ^= sample >> 8; - sample ^= sample >> 4; - sample ^= sample >> 2; - sample ^= sample >> 1; - return (sample & 1) << 27; + return parity_odd(sample) << 27; } static void dw_hdmi_reformat_s24(struct snd_dw_hdmi *dw, From patchwork Wed Apr 9 15:43:54 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kuan-Wei Chiu X-Patchwork-Id: 14045073 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 32486C36002 for ; Wed, 9 Apr 2025 15:46:46 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 93C0F10E2FE; Wed, 9 Apr 2025 15:46:45 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="QEKg4W3y"; dkim-atps=neutral Received: from mail-pg1-f175.google.com (mail-pg1-f175.google.com [209.85.215.175]) by gabe.freedesktop.org (Postfix) with ESMTPS id 3724510E2E0 for ; Wed, 9 Apr 2025 15:46:44 +0000 (UTC) Received: by mail-pg1-f175.google.com with SMTP id 41be03b00d2f7-879d2e419b9so5673833a12.2 for ; Wed, 09 Apr 2025 08:46:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1744213604; x=1744818404; darn=lists.freedesktop.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=+BuIdzO9eB2TbumWIHS4Jh+TQPJAfCKqhpNNx8Z0il0=; b=QEKg4W3yS+UGe03yFKQIs3pz6MySzbEoxwCrrbgKfB33n0zSE0yKmvlM+xuvrucEnp I1XlBcURA5BcGl8zSFwybdybZMiNwx9t3dAhIBooL11BlyfZRf3HVD2Jo9Acs0CZovSf rOpIelPquawCsP9RMM/7O4zxz2UBI/2e8VAa6mD+WiaZT9nNxPG9ttGuGtTvZ7ivuO5Y GH7q/HDvOL8hOHZBTrw/IvhudFUG95UJS/tKc2W3mWoMFIXaoHZUZcSgLM0Tg4clJ1Hb Rr6iE+p6dffEThPQ5QY28DT5jVshbWTKq3H8dmXGlu1UY62WLL8DmReMF/YjrGKlY9s8 +olw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1744213604; x=1744818404; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=+BuIdzO9eB2TbumWIHS4Jh+TQPJAfCKqhpNNx8Z0il0=; b=gFQ0yfyTrGAcRN1ejFUoyLGZ4W/m4OZGw3JY4wcbDLADwd4H3GQfgDshZritDBcUV4 U1eEtHS2i32B1gsfOuJTpAgqIs8a8uYxnkP4lR11ZQSugikiyVWLtFK24dTJrFrY2NFX 7ZZEIr2Y4/qsk8F7bU2M0MmlkZei0f8n3soMHAIRy62knMK0kFwnRqkG2KfRMps0eH4J zHCuZWE9mE0vm5iYkgeJbZjfpgRN7vecbVJv1Z64OZhw8ZWDtVWXcCGgESvRE39ejHMJ KobO4aiQkS7ikPfWg+1S8Rt6LsBlROaIkzEL3y2PryxzML1BvmJ3NFwNMaxUJ/C4fsoF HFXw== X-Forwarded-Encrypted: i=1; AJvYcCUruOGf00YDvRfOStgAe7dRVfdYE3d8hSEqlq5CGQxWmRu0Y2L422jjMSwVCnLXuqoaGU64dXH02SI=@lists.freedesktop.org X-Gm-Message-State: AOJu0Yy1HHaRBSwL6qjZK1mGOoOLul7Gh+p402sThJeKHqQSRg2iQK+c HwWKvIEsqGYJUAq8tV4V7cxFVHzineqzjjvWwsgrWsa6CYYIBUCI X-Gm-Gg: ASbGncuX5mOk75hFDmOLL6nl7aP/oOv4Iw07xucRsaCWwfqfYS7yoMaE0j4cnaiGjNT hKCGAYLhLHWWwiGXQZju1NLF+chnlvT6Cmw5CJcgWyQYcGjBI2t2E7tiqX0TrWvNX1r7D/PNt5v eFFS/r8j35SymvBnIHk0phPqYfywthbtdsdcStxUTFZDqp5GXK8rfbQJzOC+4zymm2EBcUvIq9B cKUHJAz9btfXt0ryRLi+XBISDI7cyLJHpnl71X3ikRvxUQpcf/C/NEeQohWzuytxHsVy3LPShBu JD7rt0rEZFvZi5m9xfmciGhxzICPDJK+AXzDZ+KdAW+uLaPN60aaC0bBxrAqYRSHziDsE3w= X-Google-Smtp-Source: AGHT+IHJFVNSWnOegw3VgIiiuGFrSpWrUrgalLTX98dIPQMejjp36YTfz+PTZSsEbZDfgQmuBjYI5A== X-Received: by 2002:a17:90b:2b8e:b0:2ee:90a1:5d42 with SMTP id 98e67ed59e1d1-306dba636c9mr5272799a91.0.1744213603675; Wed, 09 Apr 2025 08:46:43 -0700 (PDT) Received: from visitorckw-System-Product-Name.. ([140.113.216.168]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-306dd171991sm1952304a91.37.2025.04.09.08.46.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 09 Apr 2025 08:46:43 -0700 (PDT) From: Kuan-Wei Chiu To: tglx@linutronix.de, mingo@redhat.com, bp@alien8.de, dave.hansen@linux.intel.com, x86@kernel.org, jk@ozlabs.org, joel@jms.id.au, eajames@linux.ibm.com, andrzej.hajda@intel.com, neil.armstrong@linaro.org, rfoss@kernel.org, maarten.lankhorst@linux.intel.com, mripard@kernel.org, tzimmermann@suse.de, airlied@gmail.com, simona@ffwll.ch, dmitry.torokhov@gmail.com, mchehab@kernel.org, awalls@md.metrocast.net, hverkuil@xs4all.nl, miquel.raynal@bootlin.com, richard@nod.at, vigneshr@ti.com, louis.peens@corigine.com, andrew+netdev@lunn.ch, davem@davemloft.net, edumazet@google.com, pabeni@redhat.com, parthiban.veerasooran@microchip.com, arend.vanspriel@broadcom.com, johannes@sipsolutions.net, gregkh@linuxfoundation.org, jirislaby@kernel.org, yury.norov@gmail.com, akpm@linux-foundation.org, jdelvare@suse.com, linux@roeck-us.net, alexandre.belloni@bootlin.com, pgaj@cadence.com Cc: hpa@zytor.com, alistair@popple.id.au, linux@rasmusvillemoes.dk, Laurent.pinchart@ideasonboard.com, jonas@kwiboo.se, jernej.skrabec@gmail.com, kuba@kernel.org, linux-kernel@vger.kernel.org, linux-fsi@lists.ozlabs.org, dri-devel@lists.freedesktop.org, linux-input@vger.kernel.org, linux-media@vger.kernel.org, linux-mtd@lists.infradead.org, oss-drivers@corigine.com, netdev@vger.kernel.org, linux-wireless@vger.kernel.org, brcm80211@lists.linux.dev, brcm80211-dev-list.pdl@broadcom.com, linux-serial@vger.kernel.org, bpf@vger.kernel.org, jserv@ccns.ncku.edu.tw, Frank.Li@nxp.com, linux-hwmon@vger.kernel.org, linux-i3c@lists.infradead.org, david.laight.linux@gmail.com, andrew.cooper3@citrix.com, Kuan-Wei Chiu , Yu-Chun Lin Subject: [PATCH v4 11/13] mtd: ssfdc: Replace open-coded parity calculation with parity_odd() Date: Wed, 9 Apr 2025 23:43:54 +0800 Message-Id: <20250409154356.423512-12-visitorckw@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20250409154356.423512-1-visitorckw@gmail.com> References: <20250409154356.423512-1-visitorckw@gmail.com> MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Refactor parity calculations to use the standard parity_odd() helper. This change eliminates redundant implementations. Co-developed-by: Yu-Chun Lin Signed-off-by: Yu-Chun Lin Signed-off-by: Kuan-Wei Chiu --- drivers/mtd/ssfdc.c | 20 ++++---------------- 1 file changed, 4 insertions(+), 16 deletions(-) diff --git a/drivers/mtd/ssfdc.c b/drivers/mtd/ssfdc.c index 46c01fa2ec46..0db4776424d0 100644 --- a/drivers/mtd/ssfdc.c +++ b/drivers/mtd/ssfdc.c @@ -7,6 +7,7 @@ * Based on NTFL and MTDBLOCK_RO drivers */ +#include #include #include #include @@ -178,24 +179,11 @@ static int read_raw_oob(struct mtd_info *mtd, loff_t offs, uint8_t *buf) return 0; } -/* Parity calculator on a word of n bit size */ -static int get_parity(int number, int size) -{ - int k; - int parity; - - parity = 1; - for (k = 0; k < size; k++) { - parity += (number >> k); - parity &= 1; - } - return parity; -} - /* Read and validate the logical block address field stored in the OOB */ static int get_logical_address(uint8_t *oob_buf) { - int block_address, parity; + int block_address; + bool parity; int offset[2] = {6, 11}; /* offset of the 2 address fields within OOB */ int j; int ok = 0; @@ -215,7 +203,7 @@ static int get_logical_address(uint8_t *oob_buf) block_address &= 0x7FF; block_address >>= 1; - if (get_parity(block_address, 10) != parity) { + if (parity_odd(block_address & 0x3ff) == parity) { pr_debug("SSFDC_RO: logical address field%d" "parity error(0x%04X)\n", j+1, block_address); From patchwork Wed Apr 9 15:43:55 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kuan-Wei Chiu X-Patchwork-Id: 14045074 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id AAEC3C36002 for ; Wed, 9 Apr 2025 15:46:57 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 1222F10E311; Wed, 9 Apr 2025 15:46:57 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="PJ4mE9QK"; dkim-atps=neutral Received: from mail-pg1-f177.google.com (mail-pg1-f177.google.com [209.85.215.177]) by gabe.freedesktop.org (Postfix) with ESMTPS id BCBFA10E2E5 for ; Wed, 9 Apr 2025 15:46:55 +0000 (UTC) Received: by mail-pg1-f177.google.com with SMTP id 41be03b00d2f7-af9925bbeb7so5316650a12.3 for ; Wed, 09 Apr 2025 08:46:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1744213615; x=1744818415; darn=lists.freedesktop.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=qmHMxU2w78+CVBOj7SKK51/xntQtWaTeeSMBQ6WnTFU=; b=PJ4mE9QKgc5TeKqdJycVizlaLobyRQtHg1syYu9zescxtjCj27z83d8IaynzZDzTz9 lgoE6bXDj2YLRityz7OsRcQosqnocDV2i0RYKELB4YEHCXb67WihzBC1hWDuYmOJKJQl o6DOZLNsAMeX3LjDt3GIH6/G8xjmo5ygq+BfobhIlLvbROWFQx81VqxxwSj/5vOlYw0e cftym0S3PVZpLmtLX114KyCA4+kpY3d9cs3ycMEBynBaNTsIGcADhAlA9piqQCXLXeDd gSxB7sP1NSmgqUp9lDPViigBvYNPiN0ZSwhLRag1XeF9FKNW8n2koFY3ltX5codmdQcs s9SQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1744213615; x=1744818415; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=qmHMxU2w78+CVBOj7SKK51/xntQtWaTeeSMBQ6WnTFU=; b=OU++TYT461OIRN+OxcT+e1iXU4DQeoKkIJ0pU6sZ5cF1LI9T8CpcswPHrnXNqTEquZ 4B1/bNyP6utOcifp8nr9wHyP70aSwgcEj8vNWO8/NdjMoo5o6p2K8W5+U4OMvFOkm6Ap R+3pPo0o+5FH8QKjer6wiVOd59A57BbHauddIz2cOr/NgFfoMV1L/6G+tc3dLL7KyDHG OVaQGbQyv0MWVJZQmGTcQZnjVLZ9HZFB+umb6AjVZ5JQZKcrFI1wMlfNSMF0cGyCCUOC J9BQsVerGSIRhHCNq3gH8B3PD/PJ8Mdfff55gYFhvkptsFXa8txrUyOKdzkMJ00No3wE PUlA== X-Forwarded-Encrypted: i=1; AJvYcCVkEejOg65lJoyFrSvVnBGTPDioxhunav4AAUQNfpgNuUSSHDLn4bnKA6EK7giJdD+B5i2DAvgurkI=@lists.freedesktop.org X-Gm-Message-State: AOJu0YzX54znAMP2oQetrXXrFzaEsJmtKLUGXYS7AVWUNHumBHWOTUWD pXfi1Zb3WQix4OZvn1m/3d1moKD+qxwPXEItJpd/sxnWxttFnqaE X-Gm-Gg: ASbGncuMS3j6jQ4hI022+n6kNqUs4JFCuaejd1H9/SJZ/U6pU/hvabx9XjM4pxXmQ66 PvfmmH64lGUHFa/2mMSRDx8cs1Y0qIhPmxHXrXJOIFomZtnq0hMQLSB1ZzZZGdhBRWkWu03yHSx nhuJICRfrgTWoZp+PvT28XVsvfk2ff0NkIaQ4CC4mZFzR9+LnQY/+4BkjGDdACKdAdDRc9xQjd/ EBFTUWdqVmDWzO08GbaQsBlrB0laR6KfjD9xhNyf4nP4IZE3okpadj9PQyHltOVMwFeOFTrcaiM 7HpLKYe5douNB5AsJlJOUZ41iD3pGEhX8qlHGzHXsK0+QlYpdXAfKB0WU2VU9u4yEnFoIlg= X-Google-Smtp-Source: AGHT+IFODj+q3bMay4dU940pWbrerSwhoQdYamKxEyheU1FRVVU9x2vDvw1G0LxNRVOTtBzOvt8phw== X-Received: by 2002:a17:90b:2e4b:b0:2eb:140d:f6df with SMTP id 98e67ed59e1d1-306dd3247b3mr3476749a91.1.1744213615281; Wed, 09 Apr 2025 08:46:55 -0700 (PDT) Received: from visitorckw-System-Product-Name.. ([140.113.216.168]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-306dd171991sm1952304a91.37.2025.04.09.08.46.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 09 Apr 2025 08:46:54 -0700 (PDT) From: Kuan-Wei Chiu To: tglx@linutronix.de, mingo@redhat.com, bp@alien8.de, dave.hansen@linux.intel.com, x86@kernel.org, jk@ozlabs.org, joel@jms.id.au, eajames@linux.ibm.com, andrzej.hajda@intel.com, neil.armstrong@linaro.org, rfoss@kernel.org, maarten.lankhorst@linux.intel.com, mripard@kernel.org, tzimmermann@suse.de, airlied@gmail.com, simona@ffwll.ch, dmitry.torokhov@gmail.com, mchehab@kernel.org, awalls@md.metrocast.net, hverkuil@xs4all.nl, miquel.raynal@bootlin.com, richard@nod.at, vigneshr@ti.com, louis.peens@corigine.com, andrew+netdev@lunn.ch, davem@davemloft.net, edumazet@google.com, pabeni@redhat.com, parthiban.veerasooran@microchip.com, arend.vanspriel@broadcom.com, johannes@sipsolutions.net, gregkh@linuxfoundation.org, jirislaby@kernel.org, yury.norov@gmail.com, akpm@linux-foundation.org, jdelvare@suse.com, linux@roeck-us.net, alexandre.belloni@bootlin.com, pgaj@cadence.com Cc: hpa@zytor.com, alistair@popple.id.au, linux@rasmusvillemoes.dk, Laurent.pinchart@ideasonboard.com, jonas@kwiboo.se, jernej.skrabec@gmail.com, kuba@kernel.org, linux-kernel@vger.kernel.org, linux-fsi@lists.ozlabs.org, dri-devel@lists.freedesktop.org, linux-input@vger.kernel.org, linux-media@vger.kernel.org, linux-mtd@lists.infradead.org, oss-drivers@corigine.com, netdev@vger.kernel.org, linux-wireless@vger.kernel.org, brcm80211@lists.linux.dev, brcm80211-dev-list.pdl@broadcom.com, linux-serial@vger.kernel.org, bpf@vger.kernel.org, jserv@ccns.ncku.edu.tw, Frank.Li@nxp.com, linux-hwmon@vger.kernel.org, linux-i3c@lists.infradead.org, david.laight.linux@gmail.com, andrew.cooper3@citrix.com, Kuan-Wei Chiu , Yu-Chun Lin Subject: [PATCH v4 12/13] fsi: i2cr: Replace open-coded parity calculation with parity_odd() Date: Wed, 9 Apr 2025 23:43:55 +0800 Message-Id: <20250409154356.423512-13-visitorckw@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20250409154356.423512-1-visitorckw@gmail.com> References: <20250409154356.423512-1-visitorckw@gmail.com> MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Refactor parity calculations to use the standard parity_odd() helper. This change eliminates redundant implementations. Co-developed-by: Yu-Chun Lin Signed-off-by: Yu-Chun Lin Signed-off-by: Kuan-Wei Chiu --- drivers/fsi/fsi-master-i2cr.c | 20 +++----------------- 1 file changed, 3 insertions(+), 17 deletions(-) diff --git a/drivers/fsi/fsi-master-i2cr.c b/drivers/fsi/fsi-master-i2cr.c index 40f1f4d231e5..692d73e892e3 100644 --- a/drivers/fsi/fsi-master-i2cr.c +++ b/drivers/fsi/fsi-master-i2cr.c @@ -1,6 +1,7 @@ // SPDX-License-Identifier: GPL-2.0 /* Copyright (C) IBM Corporation 2023 */ +#include #include #include #include @@ -38,27 +39,12 @@ static const u8 i2cr_cfam[] = { static bool i2cr_check_parity32(u32 v, bool parity) { - u32 i; - - for (i = 0; i < 32; ++i) { - if (v & (1u << i)) - parity = !parity; - } - - return parity; + return parity != parity_odd(v); } static bool i2cr_check_parity64(u64 v) { - u32 i; - bool parity = I2CR_INITIAL_PARITY; - - for (i = 0; i < 64; ++i) { - if (v & (1llu << i)) - parity = !parity; - } - - return parity; + return parity_odd(v) != I2CR_INITIAL_PARITY; } static u32 i2cr_get_command(u32 address, bool parity) From patchwork Wed Apr 9 15:43:56 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kuan-Wei Chiu X-Patchwork-Id: 14045075 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 56E9DC36002 for ; Wed, 9 Apr 2025 15:47:08 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 9B79010E2E5; Wed, 9 Apr 2025 15:47:07 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="MGB4ecrY"; dkim-atps=neutral Received: from mail-pl1-f180.google.com (mail-pl1-f180.google.com [209.85.214.180]) by gabe.freedesktop.org (Postfix) with ESMTPS id 691F210E698 for ; Wed, 9 Apr 2025 15:47:06 +0000 (UTC) Received: by mail-pl1-f180.google.com with SMTP id d9443c01a7336-2264aefc45dso90325305ad.0 for ; Wed, 09 Apr 2025 08:47:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1744213626; x=1744818426; darn=lists.freedesktop.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=sCEd/+juUKZOFlQ/4SCoGPbjU2jFBlmcZeDTBbgWCik=; b=MGB4ecrYXIieBe863q5DTRQw3ZOq+5q7EkFeWB66GWrzwFmL9KVb4duicE4QiPKPmg NYCY6RfLygc2yl4kt6XeOZtuY8DCuuOY/CI/WVi2/i6qzsLigpiVCdCEfjLsZrXeid6l zga5x7vLNZsagw4iv+mytYrmoR0+JKt6SIkV52sT3/kxngWskucfzsTkIxmh0ur1xRFl tE6rTOI6/4jntlcgll6zzLbgFQ11rKiwkNnPuYib11ChAl0rPTumPj2XAHnjvmq76z8h Wv8Q4p9RMjrvpjAWJFpSpqOPGB2tW4tyb9aGY8v6LEUjDXTHn/BdcB90vIv8c2o20M3D UmNQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1744213626; x=1744818426; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=sCEd/+juUKZOFlQ/4SCoGPbjU2jFBlmcZeDTBbgWCik=; b=tu2/2uNP7/t7cpC0dxebYu169O5tOBzZ7iM1mhLn66lAvJeCrqe9D+Yh/f7/DQD0oz 9e50Ii3iBgtnqTUt4sxr3Qx1LxQxwUIcK+H/p+HdRxrAWs2CrPSBwceunMbfpBQ6TNke A3hvu20YAP02+1BbD/xPPMQh8duNibjg67+E9ZkCMXT0/deEo0Ia2HTAxV8phzz8LIpw O5ey74JlMKqGGoSNtHA3SWBJ5mBc2YqI1r+4fmpkPeDsQUBX9xAMO1/aS67kKTqZTHPB x94VHQGnS4vPOkcdbMxFkqT/E8r9GS5V9CEA/tTUoCZh/vXXeaRhF4reKnqWSmtQRjrr /Fig== X-Forwarded-Encrypted: i=1; AJvYcCU6WNna1ur/WvxE1x/uK6nr0uKtR5gMupjAZdJV9oR34kI+LJYzeh+YBHCcioteDyGX9BA181S69I0=@lists.freedesktop.org X-Gm-Message-State: AOJu0YyNSFYHt2GOOvfqWRKciP0Z47uBplVzRRfFFLGjS71uy9x7ClON ldc+YbX3CfyXTDXCcVB2OGJdKRpQOuPJqFAxLHOykhmLIHiKRe87MpXQYQ== X-Gm-Gg: ASbGnct8X8RR5dTXV5kG7+CAxi9uIBrUf1LiT8SD7N13+aHD8NYRUfNbct8p8PmPb2/ P81gvNryQVMveULYBGCyNywvndlle9gM8DMdUIGhaOg7zYwxwhUQGLOY3Bb3k27M3xr/rVToYyu 2eJD7Scz2PpI/8lC5JlcJncoveiLhyV3VkLeFocPuG33VmVOOreKCpFiXgiIYAqk7YCTOLNmAsZ oy8nsHDKEhG8n/HPdQC8cRcItDXB5K2teEmBA/1JJxLuAUSfHhtDqxzpCH2/zk38RKIiF9VKwbv gaclvMaNR5vg1GpNgTQu3BQK87SmIcAwmPJuGTAmxizTqM9hfZcPMROk/ai4dEid2NcP0pg= X-Google-Smtp-Source: AGHT+IF8SQ2JgM5sFunT9Xi0DOo/QXgkDUpLAzWqHE4Pm6PBSNMIs+CrkMQPqWas8YcuXm51yI9Ehg== X-Received: by 2002:a17:90b:58cf:b0:2f9:9ddd:68b9 with SMTP id 98e67ed59e1d1-306dbc0c8abmr4476592a91.26.1744213625892; Wed, 09 Apr 2025 08:47:05 -0700 (PDT) Received: from visitorckw-System-Product-Name.. ([140.113.216.168]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-306dd171991sm1952304a91.37.2025.04.09.08.46.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 09 Apr 2025 08:47:05 -0700 (PDT) From: Kuan-Wei Chiu To: tglx@linutronix.de, mingo@redhat.com, bp@alien8.de, dave.hansen@linux.intel.com, x86@kernel.org, jk@ozlabs.org, joel@jms.id.au, eajames@linux.ibm.com, andrzej.hajda@intel.com, neil.armstrong@linaro.org, rfoss@kernel.org, maarten.lankhorst@linux.intel.com, mripard@kernel.org, tzimmermann@suse.de, airlied@gmail.com, simona@ffwll.ch, dmitry.torokhov@gmail.com, mchehab@kernel.org, awalls@md.metrocast.net, hverkuil@xs4all.nl, miquel.raynal@bootlin.com, richard@nod.at, vigneshr@ti.com, louis.peens@corigine.com, andrew+netdev@lunn.ch, davem@davemloft.net, edumazet@google.com, pabeni@redhat.com, parthiban.veerasooran@microchip.com, arend.vanspriel@broadcom.com, johannes@sipsolutions.net, gregkh@linuxfoundation.org, jirislaby@kernel.org, yury.norov@gmail.com, akpm@linux-foundation.org, jdelvare@suse.com, linux@roeck-us.net, alexandre.belloni@bootlin.com, pgaj@cadence.com Cc: hpa@zytor.com, alistair@popple.id.au, linux@rasmusvillemoes.dk, Laurent.pinchart@ideasonboard.com, jonas@kwiboo.se, jernej.skrabec@gmail.com, kuba@kernel.org, linux-kernel@vger.kernel.org, linux-fsi@lists.ozlabs.org, dri-devel@lists.freedesktop.org, linux-input@vger.kernel.org, linux-media@vger.kernel.org, linux-mtd@lists.infradead.org, oss-drivers@corigine.com, netdev@vger.kernel.org, linux-wireless@vger.kernel.org, brcm80211@lists.linux.dev, brcm80211-dev-list.pdl@broadcom.com, linux-serial@vger.kernel.org, bpf@vger.kernel.org, jserv@ccns.ncku.edu.tw, Frank.Li@nxp.com, linux-hwmon@vger.kernel.org, linux-i3c@lists.infradead.org, david.laight.linux@gmail.com, andrew.cooper3@citrix.com, Kuan-Wei Chiu , Yu-Chun Lin Subject: [PATCH v4 13/13] nfp: bpf: Replace open-coded parity calculation with parity_odd() Date: Wed, 9 Apr 2025 23:43:56 +0800 Message-Id: <20250409154356.423512-14-visitorckw@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20250409154356.423512-1-visitorckw@gmail.com> References: <20250409154356.423512-1-visitorckw@gmail.com> MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Refactor parity calculations to use the standard parity_odd() helper. This change eliminates redundant implementations. Co-developed-by: Yu-Chun Lin Signed-off-by: Yu-Chun Lin Signed-off-by: Kuan-Wei Chiu --- drivers/net/ethernet/netronome/nfp/nfp_asm.c | 7 +------ 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/drivers/net/ethernet/netronome/nfp/nfp_asm.c b/drivers/net/ethernet/netronome/nfp/nfp_asm.c index 154399c5453f..2f8f78abb6f5 100644 --- a/drivers/net/ethernet/netronome/nfp/nfp_asm.c +++ b/drivers/net/ethernet/netronome/nfp/nfp_asm.c @@ -295,11 +295,6 @@ static const u64 nfp_ustore_ecc_polynomials[NFP_USTORE_ECC_POLY_WORDS] = { 0x0daf69a46910ULL, }; -static bool parity(u64 value) -{ - return hweight64(value) & 1; -} - int nfp_ustore_check_valid_no_ecc(u64 insn) { if (insn & ~GENMASK_ULL(NFP_USTORE_OP_BITS, 0)) @@ -314,7 +309,7 @@ u64 nfp_ustore_calc_ecc_insn(u64 insn) int i; for (i = 0; i < NFP_USTORE_ECC_POLY_WORDS; i++) - ecc |= parity(nfp_ustore_ecc_polynomials[i] & insn) << i; + ecc |= parity_odd(nfp_ustore_ecc_polynomials[i] & insn) << i; return insn | (u64)ecc << NFP_USTORE_OP_BITS; }