From patchwork Thu Apr 10 07:17:38 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Peter Seiderer X-Patchwork-Id: 14046003 X-Patchwork-Delegate: kuba@kernel.org Received: from mout.gmx.net (mout.gmx.net [212.227.17.20]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E5B8A20E703; Thu, 10 Apr 2025 07:18:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=212.227.17.20 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744269502; cv=none; b=OZiIY8ywLrnjSylwuM77UiwJrcI9x2yhlSneScH1Poswo2Pd06LobL4p49y606b66z73dSNItZXnKSOPMNDcuyou2Gp1VMQIOoCEOSiC93of5ry16QXRioOWfK37oB20WArB+LTervgO+ceTBWzuWKjOvcKQpVztebo6+AMnoc8= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744269502; c=relaxed/simple; bh=KlNaIGSmY/cxwxFm873Op22eUAKNBXsFzNciq9lkiw0=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=scDTLb4O6L8XCAIoO4KRqZOBLvLS3XvBbcpNUMLKnXBgXt/btujL63SnTMJVf2VRarFnLSiNzumWyeI8s6S6eebSLQOwhgKa1iJSXZOEx28GdsDYsJhbLKkRrZ9AJk5ftvSP8xpEXC3g6kFd5ZMttyqQOG+IR5DNEMkK990ml5c= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=gmx.net; spf=pass smtp.mailfrom=gmx.net; dkim=pass (2048-bit key) header.d=gmx.net header.i=ps.report@gmx.net header.b=pQCJfq1h; arc=none smtp.client-ip=212.227.17.20 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=gmx.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmx.net Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmx.net header.i=ps.report@gmx.net header.b="pQCJfq1h" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmx.net; s=s31663417; t=1744269481; x=1744874281; i=ps.report@gmx.net; bh=KlNaIGSmY/cxwxFm873Op22eUAKNBXsFzNciq9lkiw0=; h=X-UI-Sender-Class:From:To:Cc:Subject:Date:Message-ID:In-Reply-To: References:MIME-Version:Content-Transfer-Encoding:cc: content-transfer-encoding:content-type:date:from:message-id: mime-version:reply-to:subject:to; b=pQCJfq1hq4NcRPDxWMxmydg2HMYlB49n+FKySYY7gg5XjwwuFMJQG5Fa9b/5k5gC 3r7qgp0rjvrtEjUDJJY6ixLIr9vipXonvIJVg20WhrJHSdJw58XwfUK6jl6PIhnuc 3aYWyPtt+AKMyLwFt4uTuzSje76dOTUdtRUyXOrDGAcPeLqb6OIP24sBUNEIQwLY1 XVENAgN6EoIKZpRSfPnVHa/1wdOacjrvhaHbT6KqcnfLADklUxKMIn5MaSqSqcfoc Dsk95wqOpDc5UQv9Kumr/78WK9AlfDhfTwFDDbJZSMPFV3MXUMDBz6P7MLmTJOnXX IVJGlVW22NWDjBy15w== X-UI-Sender-Class: 724b4f7f-cbec-4199-ad4e-598c01a50d3a Received: from localhost.fritz.box ([82.135.81.74]) by mail.gmx.net (mrgmx104 [212.227.17.168]) with ESMTPSA (Nemesis) id 1N3se8-1t3DK524G0-00zdHu; Thu, 10 Apr 2025 09:18:01 +0200 From: Peter Seiderer To: netdev@vger.kernel.org Cc: linux-kernel@vger.kernel.org, "David S . Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Simon Horman , Peter Seiderer Subject: [PATCH net-next v1 01/11] net: pktgen: fix code style (ERROR: "foo * bar" should be "foo *bar") Date: Thu, 10 Apr 2025 09:17:38 +0200 Message-ID: <20250410071749.30505-2-ps.report@gmx.net> X-Mailer: git-send-email 2.49.0 In-Reply-To: <20250410071749.30505-1-ps.report@gmx.net> References: <20250410071749.30505-1-ps.report@gmx.net> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Provags-ID: V03:K1:zEfPRes/7lffLsDAzcbLi5TCSHON2zDIcqu7+XfAGCdwAUiUCrV Fr7heltgjsiiIYeyQ/B0wliRxHAoyCIOuwUTi8EZ4rHU/dsT+uRp1c7UG0+qYGNVSloJkOR MoUKeVZAtcdSv+0PuoJheVW/wSeDGW9ag0VGg4rLt411NnBwZqQfr5I2vSv3ksaB7rlnsqY mbi2RC0YoxLDb6eUfQjfw== X-Spam-Flag: NO UI-OutboundReport: notjunk:1;M01:P0:mrQVI29ArUE=;4V5m59bymhROUMBd47xtMXCMefd jPCnFzlViVoz6TEaVMA6cY7ReMt9CNaON6AsiXuSYbwbK0eK/4IFjPljteh0OuOyPPdx1LdmG RFUeHnzM2T6KIUViAtSyrvhJtZLiCwCpbmxCE8biVe3CkcZFFKRSkwo3k2uExOaW+JZPrlu7C bhXeT1g93vk/kMnC+9nSt3n7YCBGSbXPNjRZSJgadNjf7yo3mERKn9yrxBTpQPiCJyECetby+ qac/59hyrQkqRYFbW6Gpfh2Sna+Hncqgu9UlbWZc8EaOgG6b6m7A1Vmf0etBwB123DE2WWI8k UFJ7zdZ120PEuBRfRmsy52bD3NLeW50BA/FLeJyhZtIjRPFt9VPTx6cFbv2+pDZmcrxu6uU4D oOmiVWdfrfUZb458wSMeAGQiW0+6DYNsY0OmS8yx/OjXVa1961jYHUr2UBpG/kQGxle/sdGJ8 AK6JZA//ktRuOdXeNIK5+jAK+uK1/5EivpaSOZRMyN2nz9RyuNShODqEhsHST67A2MMN1wPu/ 42RKnA9DPsg/cYz/tLyUi95znIrXojHD4X3VDbTxfH0wyt6aM2VJMki6I07qrm52GSCjQkD/a CI6aqNnue/fU1ODfvbaYHMlJYjkgClVG+JirjrutWlgg94shvK8+n6EN2SAS6YW6SjfgIkllw ctMpoH7MDd0i/AQGy1xOtjOWEaDr1cJ692Hlc1G6qgueGf66dCOdoSqoXpkUm+Ur21uCj2lTi zJuu9gsWWE+6LgTHHRgVOt03k8OYATz5jI9eSPC6HmzObsunL1k2jAX5wK0ujD/BUCTDefQtd pBUwZql2fI7gvITpe+BktznVEYpd3TuPW+8Lw7BOBfq9mijfhc8OcZIdZdqzbG9RNz4wyNMGu J/piqEGOz6L8eoeuw/QsOtNu+UqFOOF8XDQJSq4LKm/5a4U+RDFMdM0jz8kzzBmchtWOYv07w 2CQGYrvHrnUsdoaMXAD/SZrEBQ5nv9JUuugnp3rWqSBQhRLdv4X2rErWKpdCZ7vxAv4pm5lNJ j7eeKHKxK9dphlfLLMN+iDZnoGZf4eVJfWsDVwKEwX6X90nJN5upKezI9SvGE1gVAri1i7q7c jPkn3Cx0OXGFzRVSztTp7Y/NnL00pfCALXCEVz2lpT1KHgpxvvt3ULGsFGtevDV7/SYFGWozK UwCiFDCQ1isWsVsZXRU1+7c8Umz2dL1AmB/wKkcGF6oD/ayMrqG563VwPUSqxfL8Akit/D9rX fVp7PnmT1MDxDA5l+s3AfnooO0n8jtmY2y9OtEIYTGcZWdc7ZnXngvaQhBLenG3mmargorldU CgiWr9mW8jqM2e/YgrGSWU4B+WgrEcahhJwKYX3RKidE26RFcy0vD6P3wtHmCdYZCv89H8zBh UG1qtjnwdybw1TfAPB4Mc09ae2Z5YqJm7UDCIi6PaqBK8ZZxPyny2lzrt8NOgEQz31vFhCd2k 979452dYUsXndcvVFsGwXcFzkrPs= X-Patchwork-Delegate: kuba@kernel.org Fix checkpatch code style errors: ERROR: "foo * bar" should be "foo *bar" #977: FILE: net/core/pktgen.c:977: + const char __user * user_buffer, size_t count, ERROR: "foo * bar" should be "foo *bar" #978: FILE: net/core/pktgen.c:978: + loff_t * offset) ERROR: "foo * bar" should be "foo *bar" #1912: FILE: net/core/pktgen.c:1912: + const char __user * user_buffer, ERROR: "foo * bar" should be "foo *bar" #1913: FILE: net/core/pktgen.c:1913: + size_t count, loff_t * offset) Signed-off-by: Peter Seiderer --- net/core/pktgen.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/net/core/pktgen.c b/net/core/pktgen.c index fe7fdefab994..fe89384d56d0 100644 --- a/net/core/pktgen.c +++ b/net/core/pktgen.c @@ -974,8 +974,8 @@ static __u32 pktgen_read_flag(const char *f, bool *disable) } static ssize_t pktgen_if_write(struct file *file, - const char __user * user_buffer, size_t count, - loff_t * offset) + const char __user *user_buffer, size_t count, + loff_t *offset) { struct seq_file *seq = file->private_data; struct pktgen_dev *pkt_dev = seq->private; @@ -1909,8 +1909,8 @@ static int pktgen_thread_show(struct seq_file *seq, void *v) } static ssize_t pktgen_thread_write(struct file *file, - const char __user * user_buffer, - size_t count, loff_t * offset) + const char __user *user_buffer, + size_t count, loff_t *offset) { struct seq_file *seq = file->private_data; struct pktgen_thread *t = seq->private; From patchwork Thu Apr 10 07:17:39 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Peter Seiderer X-Patchwork-Id: 14046000 X-Patchwork-Delegate: kuba@kernel.org Received: from mout.gmx.net (mout.gmx.net [212.227.17.21]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9638B20CCD0; Thu, 10 Apr 2025 07:18:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=212.227.17.21 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744269499; cv=none; b=d5C+5rDs4GUPKk6mka4xZnhtw8OTZAg8VlFTZcGn2/tZ8uUAnXYMngNNfsT/h6Xm6FcwvNNntVpB0pj0RFwbRnspc1AxT1D+fSNx7X3xIxG6ZG771X8CCOwoJOgZM6Ps+7aglgUbY6HIkSscL21BbgHLSwt3So92IRTcI5uRB+o= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744269499; c=relaxed/simple; bh=IgECv3hjYg1JSen2eCxwSIQ9w/POgvVNdDJiBiLTi3U=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=a8C//sZep7d1NzEF/mDN3dXVJcq1KnVd25SQ8t0KOfY4e76P6FZ/Xp39r+51ilObie/egoki547fFXYVQgeVDAZfVD7wdGSjuhhry6M9Xa+CA4YBaBkOV66CJQ+fkQpBfNQm8nwbgNHiMlj0vFa40xxJ3SpdCEEOXjH/Zon+2/w= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=gmx.net; spf=pass smtp.mailfrom=gmx.net; dkim=pass (2048-bit key) header.d=gmx.net header.i=ps.report@gmx.net header.b=FycS+Ctr; arc=none smtp.client-ip=212.227.17.21 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=gmx.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmx.net Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmx.net header.i=ps.report@gmx.net header.b="FycS+Ctr" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmx.net; s=s31663417; t=1744269482; x=1744874282; i=ps.report@gmx.net; bh=IgECv3hjYg1JSen2eCxwSIQ9w/POgvVNdDJiBiLTi3U=; h=X-UI-Sender-Class:From:To:Cc:Subject:Date:Message-ID:In-Reply-To: References:MIME-Version:Content-Transfer-Encoding:cc: content-transfer-encoding:content-type:date:from:message-id: mime-version:reply-to:subject:to; b=FycS+CtrjTymDnCYu+nncJhyZfSXtn2I8Yo/nC2PbG7p4pnbG3zVUlmHGt/kq7wF hRmxhW0OQFIG7A1OkT5SG+04B73fecOhJwlrJn3is1NfSIcVzJtnxSjMTmWRuEVdA XVZXbNkpVipeNtnOS7WOIwR6Wgyw5dj1Q1XvepT+QU76qNHgDSbPPk2m7yjrcjwZ7 1748DYQulPuUWxXr9Ra6yymWFLA3lmtj0zP+9VZc+AQixaoLdsQpsZ9RJDcvXOaD1 Us6sfitdJnZ+0xcOhvOk9PdAam2dcxM+4jwzNq3iqA8WtC+E8l72JJ+OWr307MCGH k3vKBIF6XtnY3Zli6g== X-UI-Sender-Class: 724b4f7f-cbec-4199-ad4e-598c01a50d3a Received: from localhost.fritz.box ([82.135.81.74]) by mail.gmx.net (mrgmx104 [212.227.17.168]) with ESMTPSA (Nemesis) id 1MhD2Y-1tOkax3FA2-00eEZ6; Thu, 10 Apr 2025 09:18:01 +0200 From: Peter Seiderer To: netdev@vger.kernel.org Cc: linux-kernel@vger.kernel.org, "David S . Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Simon Horman , Peter Seiderer Subject: [PATCH net-next v1 02/11] net: pktgen: fix code style (ERROR: space prohibited after that '&') Date: Thu, 10 Apr 2025 09:17:39 +0200 Message-ID: <20250410071749.30505-3-ps.report@gmx.net> X-Mailer: git-send-email 2.49.0 In-Reply-To: <20250410071749.30505-1-ps.report@gmx.net> References: <20250410071749.30505-1-ps.report@gmx.net> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Provags-ID: V03:K1:ZEFMZBN5BPNv9NgQYKWgVv+rSzqBUCYIX7S1ODeL+MCR8VOc8Ae ZiZmzkscbNYNG+3/oBl+xFWoN+DDHsD+17o0cynQcv0yMq+/9e1NFJppkyr1QlQPa3gQLC6 IDAJQjwSN3L92V0pXKrzo/K67oShvCSJvX6M9SMJFzMnz18k8vjNBox7m8AGjd6kYDoRMBx 3x5EnHiAHbTh5u6g9CcoA== X-Spam-Flag: NO UI-OutboundReport: notjunk:1;M01:P0:48xfYmTJP6k=;2JClBxMsLBMO/1RLbyg439g/uAF WD+YP1bwsVzz33VICvk1bcQonoSoHJO2hxhUlHMVRILujEbM6etr8nzeU/zc0gkKuqzdBFEh3 PxeAZ5H8QWFORr4geq+9PiwwgFck1DtxhNKcgGmGOUEoAP4B7ga+r2mC3X45ElNi1bWI105Sr pHMHXn+bgQqchaAC31epfmmeEUB3NdmSxvge3v0VMvSpnAnqt9duCmO0nbsno419rsv4zSY5o 0eM8/FLdKyM50k45ywIas21Z1k2qORZXJJZ8GdGyBx46AjS6yNOwWgve/uKVeUIOBohaRt66J ksrcHBPqJhHbI+5nQOn/Gc/TqeNwknNupO8FLYxC5GHMjXDl8Msw+snlSRH3+VzF4fCPPy78O pFW7525FIedJxvnWh3omGTCWIZ7tBq4kwMM1UqYAXJbvDgEHFnEf0jP+HGukJG47KnIllddUA ft9YSmufd++uTk0gt8TiyNIfQ8P91EZZQf0rrwInbouD8RSHFsIJ9BD/rr2SL3ZnREXJH76Iw UeoZWI4w08pyPUb9rr8zNAp/1Cwpe4uMcsUzkhviavnVcthRfzPmrnxEjg15zP/UBhR23K8rG D/ZWJ81tncvC9h1jRZcyNN5luykOTy08EEV7uqeboCCo0uZpFh2hH+Xs4qx9JW3R8/JreWAeI e+rPdSXwt0v9b5+8+fCAaPLSRN06K5KJS0ZtlQYIPOW8FHucEmm4Wi5giuTzv6jl4M+2uvUwh MkSPvdSexLaQXI45klA2cjsbT6kgXp2yif3Ft/nZTSed3Sbnw9tEbftW/izSJmgXbW472KUHk oF07l2RyZQo5VGsh1p97UsXsE4+aAUQy6FMs8ilqGVHx59/1uotAv5dQPIBCC7dXNGX1skQ8U igASalhLRegEFntkinXGgHmZ0qqVGPmsXj/tE7x9Ll8B20+X7u0VdRty/vOe1sjtf0FoFRmud hl0jbGrgLblE1m0D7s007JdfrBnQZ5PF/DZ9t7/y/ga8frMuOQ5Si+7KTVHulVcTbmqVDHBoh ClYEPMVdtO0A1mlOEgvCXLgYVYKgeuRh3gL4Ga+Q1U55Bm26Q2CgIps9Wt6P0Dc3vbhODTPFz dgfoa94VVRIL8Is3qMou5rxsy0bdeFUyYNexyplBJiUs680X/MsUuHv/OKlL4n/6P//C4+X6v 5upPcR8gL2c5Py7NQTfdcLy1+KcAySOge/ZknJsOQDHgfRDuaP8I+9n6ywmMk9l+XGvvMqRBX D/xpu15FCqaw3nqnGs7XWVVzmD9hgkb48uj5sKFi8zsIU9xdw46ZtNd84ZE1vHHM1N3vzoBF8 ip5O/eesOP0N2cXM559pKhMoqTGYmztNsyoj5NA61SDjaEmf6e33oYA0ld2v81V/iv0RyWZqv Az7vJqzZjBc41hmdgXDMOJOfX60Ms5wmeAzKiNwjDyJJaOOtKydJAZ7QygwMiuvxTWkgzALiu IpQqgatuRO/l3YK3TyiK71Kspyms= X-Patchwork-Delegate: kuba@kernel.org Fix checkpatch code style errors/checks: CHECK: No space is necessary after a cast #2984: FILE: net/core/pktgen.c:2984: + *(__be16 *) & eth[12] = protocol; ERROR: space prohibited after that '&' (ctx:WxW) #2984: FILE: net/core/pktgen.c:2984: + *(__be16 *) & eth[12] = protocol; Signed-off-by: Peter Seiderer --- net/core/pktgen.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/core/pktgen.c b/net/core/pktgen.c index fe89384d56d0..a54683d9d44a 100644 --- a/net/core/pktgen.c +++ b/net/core/pktgen.c @@ -2981,7 +2981,7 @@ static struct sk_buff *fill_packet_ipv4(struct net_device *odev, skb->priority = pkt_dev->skb_priority; memcpy(eth, pkt_dev->hh, 12); - *(__be16 *) & eth[12] = protocol; + *(__be16 *)ð[12] = protocol; /* Eth + IPh + UDPh + mpls */ datalen = pkt_dev->cur_pkt_size - 14 - 20 - 8 - From patchwork Thu Apr 10 07:17:40 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Peter Seiderer X-Patchwork-Id: 14046004 X-Patchwork-Delegate: kuba@kernel.org Received: from mout.gmx.net (mout.gmx.net [212.227.17.22]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4D64421CC51; Thu, 10 Apr 2025 07:18:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=212.227.17.22 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744269507; cv=none; b=cdQZg75eafAwn5INyOF4fp/sLm6itQza9TpDHvCDNGePZTAnWk5ghsK3TaFaKNxWAfFbBnId+/xu/ytEZnI3mz1Pq3mUk0Xbdqnw1Mlg9DE98jOsCNfHLtRxkuInSAgjgEXhhvvMSD9GqN1wJLCidhR3OZ/Ns0G1FQYyE3NycOg= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744269507; c=relaxed/simple; bh=jAPDXbbnOMui6iJert3qx26bwyEH/LXDawHVAmrL5/I=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=X8a6Frw9bneNbmqAbZS7ZIXEIlCkhQr5B+84dOZ7yAJXLMc8THXAbFNaUZoTepkLhNOaFvqC2d14Bnoh6wAjlBL6tdQDCs04Cwx4Ak28aqegGXiM9WbMAEmxMKI1TGJowe7UJLaw3lQ3t9FY3bzpDet6AQ0KwuNghjBbn74lA5U= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=gmx.net; spf=pass smtp.mailfrom=gmx.net; dkim=pass (2048-bit key) header.d=gmx.net header.i=ps.report@gmx.net header.b=rUsy3Vsx; arc=none smtp.client-ip=212.227.17.22 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=gmx.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmx.net Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmx.net header.i=ps.report@gmx.net header.b="rUsy3Vsx" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmx.net; s=s31663417; t=1744269482; x=1744874282; i=ps.report@gmx.net; bh=jAPDXbbnOMui6iJert3qx26bwyEH/LXDawHVAmrL5/I=; h=X-UI-Sender-Class:From:To:Cc:Subject:Date:Message-ID:In-Reply-To: References:MIME-Version:Content-Transfer-Encoding:cc: content-transfer-encoding:content-type:date:from:message-id: mime-version:reply-to:subject:to; b=rUsy3VsxHuuVTKSNWf6+KTkTWZpaRylF5oXNg9uTP9W17LGD3135Nk8tajBSZHBF UvVFPAXrWh23PPFPXgoAX5Qy+u8F3teWNDpXHTMxmSo8vWGomjybYch0gU12gOON+ teR68BaqhlaMC68cIjKGEs9dcjFiL1yv/sQuN5+roow4WGDmJjhzy5tAA3k5zc5dj EnVrShb4zRv1WuJjxWImtyKmgbkM7wxccEGDzsEDu2NjHQSurtyQ5s3+u8/afiQW5 bQWoA0Cdtzrv3//d9sXsJUMgVV0Xt4dsp1ERsQWEDVqwNDMmebUXbgZH/RPv7be+m rwL4EvBKLM8atH9ZBQ== X-UI-Sender-Class: 724b4f7f-cbec-4199-ad4e-598c01a50d3a Received: from localhost.fritz.box ([82.135.81.74]) by mail.gmx.net (mrgmx104 [212.227.17.168]) with ESMTPSA (Nemesis) id 1M3UV8-1u2ECu0Cmo-000l0i; Thu, 10 Apr 2025 09:18:02 +0200 From: Peter Seiderer To: netdev@vger.kernel.org Cc: linux-kernel@vger.kernel.org, "David S . Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Simon Horman , Peter Seiderer Subject: [PATCH net-next v1 03/11] net: pktgen: fix code style (ERROR: else should follow close brace '}') Date: Thu, 10 Apr 2025 09:17:40 +0200 Message-ID: <20250410071749.30505-4-ps.report@gmx.net> X-Mailer: git-send-email 2.49.0 In-Reply-To: <20250410071749.30505-1-ps.report@gmx.net> References: <20250410071749.30505-1-ps.report@gmx.net> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Provags-ID: V03:K1:vOwXFYa22EWz3upkIUKaSb723sCTwGF96PpS7MMJVNzAL6wR+yc pyaombuj69YfnHsqW1czMoXxWW8mnMW3zNKIexpL9waxOSiiwSRzmEOK8fmMzzqCbF8kz7G OqXY6xpUfy47BkW/rI9l+bQPKvngW5ahvb/06vpNoa9bLaY7CaDuOZDkRE58+JOosuYEEqh TRZ7wpwyf7wXafDCZn7dg== X-Spam-Flag: NO UI-OutboundReport: notjunk:1;M01:P0:m5MDacci0P0=;DiafUh+Xgx8tM3fB+SEak5pNe1c uLSt7wm8giER5VK7doGQklC82/qjggo7XFJGHhDlD78w+qWp4x1SzGVfpEORzaVGrmdsvI4iO x/jboJilZiN+PXNiZOiYywCZn+K4W0xl5Zye5+JWweKabD5068gUfMkXZMdAbQM0R9V4jacsf EFezso+vyLtCTy7swuONRBHx12FvefUQ17vsHxNWZH+LeIhnm5CKYTWm6e+U3pn++DO2Qwy1y 6tj+LzrLx941Mcyt73O0W7bqY732hYPmsvjAH2detzFAO4hFSvcS21YJpVxIZs6gh48Rqd08j /+AA3RaPApBiDx10rvmCb7dwdz7wifIwAsn9wjtajlnKlj7PRcW1+zlXFZuxgORFdmHmOOWx0 Tl8xUuGqXyvtD/P03DCqyY/OnwlM0O0xJceXX4bkrPfIDptoaRALavUfk9EUSrzV1seDWfIpz lCEf49z9wy6pATs5SPSttx2NCh0yR693/iSxTfJGLqlFBC+x2fso5W+x/xNyNmLJFCavFOJcQ Aqat6Sg8aqr5+tYLBweFhtyrAi9oNqZhe49rnmtdkZgoe8ese8b9alYIhSM1m7iZz8gviTOee qh2gL6ttgt1ianc2MXTNu/xdi6Nw9DFmCZMU1bP3OOYFqItScvt6tR8EuOEbujfG4ytYLm2xO 4PgUSjVX0aabx9KHBqFY74PwjpRbB0bFbg+7U60GJd2mf8LxWg7xh6N+qFO90Jg0Ksx/SGuLB 0km9v7wKhBAFg01YLSQlULX6vJuo5jJwG0qJbz3KyyLpokezWp1j1gwPK9SahSqJP1SN5bLhi Tz7KXVHpgpi8P6iPQwMea7SNtBhsUn1b6ADKGcb+42WHjWgqCvQotYCrRwJ8YWdSATHzE0rI+ 1L8JEzkbCdPLixvc8d+pJsLB8CFRhnwsyBmocCBw2PGdDKGO3W5mdfvQrwsD9V2HSKZ0F7Nlu yMpX+8e6pYkozcFUvQkn3ww9gVV4X853YW3tU+9z/agGKAg/HEwabZ2bC3XFmK8PBf5P8ZMiy gZlBeH6goomOQpZu8FexC7XdQdwbwevpXS+A1K+bpUj9d+QxyjBd/hTQ1QVh5cHMumXx9URNn P87YSy9pWc1rNA0KPcJC9BXvZuGC8UxMUFNq9P2vCvpvePjGsq6kjzjjeA/9FJeQy6pRUU7c0 40PbWu/1t/l3S2Vx2RCmRrFWpco+nzACMs74AaghRZgRbwZJjNG6ADdnd4PEgrjRSiexhYPvS KSULHGncLxrDjKjEauu0CdkEnq2LKq+SCa8SedrxaToWxE1NaPUAyhbB1jhPkK3ttHKh9Sfkq nMxUcR9RhtYrb5Fwhb5r1y7tIyn+EiHXKrEH8HTFcKFZka36vN532wyvvAje0m9IGJPloETtX D0gZ+yDpBDvfeFZMPH5kBwkqmCHSgmttho4qg5kxXIiTuOeC6e19WozFQxEjgprdPQI5HNwnk RLzkKeIo9+iGiKgulrI4fVpWWGKQ= X-Patchwork-Delegate: kuba@kernel.org Fix checkpatch code style errors: ERROR: else should follow close brace '}' #1311: FILE: net/core/pktgen.c:1311: + } + else Signed-off-by: Peter Seiderer --- net/core/pktgen.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/net/core/pktgen.c b/net/core/pktgen.c index a54683d9d44a..50ed4eb792a8 100644 --- a/net/core/pktgen.c +++ b/net/core/pktgen.c @@ -1307,8 +1307,7 @@ static ssize_t pktgen_if_write(struct file *file, put_page(pkt_dev->page); pkt_dev->page = NULL; } - } - else + } else sprintf(pg_result, "ERROR: node not possible"); return count; } From patchwork Thu Apr 10 07:17:41 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Peter Seiderer X-Patchwork-Id: 14045993 X-Patchwork-Delegate: kuba@kernel.org Received: from mout.gmx.net (mout.gmx.net [212.227.17.21]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 96E20205E0F; Thu, 10 Apr 2025 07:18:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=212.227.17.21 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744269488; cv=none; b=FHk51ViC4rX+680q5QFXS/WkCa2njgrC8EC8702T8gtt8Ryj0paP8SUaSqJGQYYEKhvGFHDKmzOjHP8ikUcg43gKdMm2xgXR1CDNAPT0AlLGHrNOU8OJ3hnyDyDXPi6WDKsUC1Za6UxC+DKOkuJU/e6I/wD2HCSuSUTxy1Im/u4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744269488; c=relaxed/simple; bh=Hgq5oFqXjkRbkUlIbSDqwNERy8+yX/nYxw/Zqsyei50=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=IxwWxIJdDz5Y7xZA+F1bRpZZqgIEt/OggR6WpUExUhi0kgrgy/10kBwg+IeXgykVSgxqOEqMxQ6LsyjCYpRzOJ0i1Ay6qeuwHRLc83IDkiBV1IofF+8jv7bFfFUhcdYOfcAEhpb7FH9Z+oAaDpvu9AgSO3qlH4Bkp8UuaCmM1lU= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=gmx.net; spf=pass smtp.mailfrom=gmx.net; dkim=pass (2048-bit key) header.d=gmx.net header.i=ps.report@gmx.net header.b=enjcfm23; arc=none smtp.client-ip=212.227.17.21 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=gmx.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmx.net Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmx.net header.i=ps.report@gmx.net header.b="enjcfm23" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmx.net; s=s31663417; t=1744269482; x=1744874282; i=ps.report@gmx.net; bh=Hgq5oFqXjkRbkUlIbSDqwNERy8+yX/nYxw/Zqsyei50=; h=X-UI-Sender-Class:From:To:Cc:Subject:Date:Message-ID:In-Reply-To: References:MIME-Version:Content-Transfer-Encoding:cc: content-transfer-encoding:content-type:date:from:message-id: mime-version:reply-to:subject:to; b=enjcfm235AM9EF971EepM0WAxN0kVRivPMFJMCQWMSwDG/DbTm2kwWRbKITDtevK /jjPVdsmwYzfxHQijsOTJ76l0w2B3tRnAnocJx2mrTOUUyr7r93CGPvqffVLgWLWD mmD2z5RIxdV1IX5o1RuXfohNBEtrghdEVUPVcTyHeX8+0SGDqLn5sn0q/Gx5aOrGH gRx6SvxOmCieFr+pTPHfobdUgoKVBlEQLLY9A2YuqEvq09hRSoGJeKLnf/FygQx5e IfYIyjAEF93hvYoDbyAVULO0i4Dz+gT3j3Ifvsqgr1ENdG4Pm1UaWM190fZJ63xH0 KTWw9QeqkZOlfR2BHQ== X-UI-Sender-Class: 724b4f7f-cbec-4199-ad4e-598c01a50d3a Received: from localhost.fritz.box ([82.135.81.74]) by mail.gmx.net (mrgmx104 [212.227.17.168]) with ESMTPSA (Nemesis) id 1MEFzx-1tsZYd1Ve1-00AQBD; Thu, 10 Apr 2025 09:18:02 +0200 From: Peter Seiderer To: netdev@vger.kernel.org Cc: linux-kernel@vger.kernel.org, "David S . Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Simon Horman , Peter Seiderer Subject: [PATCH net-next v1 04/11] net: pktgen: fix code style (WARNING: please, no space before tabs) Date: Thu, 10 Apr 2025 09:17:41 +0200 Message-ID: <20250410071749.30505-5-ps.report@gmx.net> X-Mailer: git-send-email 2.49.0 In-Reply-To: <20250410071749.30505-1-ps.report@gmx.net> References: <20250410071749.30505-1-ps.report@gmx.net> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Provags-ID: V03:K1:ND2vOrofi8JmxmlRXSCn9zJC6mlcvE4uh29qu8HYLH2KSAM2WfC xI1w7r/cOOlUNR3kRyYXc8gXNYAiERBFobE1kzdKtydluUFGlLkYS0R6/TcyPN8vXFnqpEs +RE8HzwzIPF6KGHKBM4BhILw3LBYHUy7tfh9w6oxecyyQftEFwrp/fYqZqS2+KWSHFj9CWr c6kKk8wsj+pZ/sct2wcWQ== X-Spam-Flag: NO UI-OutboundReport: notjunk:1;M01:P0:cnMXTjEx9CE=;hNhQB8Y7G/NO14hk/TsM2lwlRom uH07s/E4DBFZBnQKV7bJqn3oRe8CtQWdtIaHtGSfSoMyRwl1O3Ely3a/LF8arXVXUHMRIQ8D/ Gi8W3FC/wPeims8HzcVOLV3PAlMR93K8/XQ6DHtm8UyK2bPipYUR0qUYJ4OfNmvXYiEIdRyTi 02u+Nm+c5/fcyXj4+5f4RYRdUKctSjOXWJ/5b1RQDP6MeTR4Q9YPayna4e1ZtsifF1HbiDSGv kdmG9PEqa2yniPmJ+8KNiqtuKpKBQfIxXg7AxtTOuaO2K1hs33J4s6fysuipm+93gTfzSzDvZ tMUCh0DPXPiIS5l69MltvlqTNIHEqG9OlyLZpyVoce5H+ox2OW7tbDL7p0gDpiKvavKOh2z4r I/I0ITQxD1OZbGawUb8RvcTwjREkXINnBT48UZveQV0Tqa9Uuj7RfP4Nt+bDzPDuGoBHXgavg JO/GbvCmvxzoh6oGZt3eOa2Aqqp2yW5NS99ZFtB86YZAjP9inw7TgkuiSwEkhbBo0Rj2iXLIT alg4tyc2w8DuuDZv6zdu6UldGbLnXM5LQ0VdlM9Gmtfi4o73Wx61D4grYwXOFkkX2KJDkqqN4 6Qe0EM/CGb8Pb71ZqCjvpeYjuo25AcylQdUK24mk/oCfC+0Pq5Bo9R+ec4et4kIV6svTMwPFO r/tnyur7wqRUS0rzUmAmr0/817sGHQCsgLNYVIl2N9/2oUtPzDMtzzOC1xBP/HFfhHJXvsteT FPuC7G16GyURJOhMdieDzOc1/DUkOy+eANnGhRJkA5f1xjBWCd2AZRig78qwHLIwccaUOymf0 oBLinW4Ot++hpScmLsEJA94ZiCTuxeHa8XSYPTg/Frk6IYTh8SvaR4AgCQGwpcliTqwnRmY6y D0R4w+Hsmq7LVCEIBncOjOicuKkqrWuJi6nJol8LO3KH7L9re5sUnnc9GBQC5AgoDBXKa7mQl 1PgWn6YHtrNYneOKNpL+C0444L7uLktC0v/wuGo4datgVTQDMrIm2Xq4v+HRl3yODsBgoYYef Y7fp4ndSytH0Uo2YVsAdcbp5HXqyzFxIYxGdGK2Jq+WzFqya9kga0KPr6waDnyJ04sDQJK4Vp JfmgzZ+mzm5NM6zAtB0yEXdcHftNFlquZFJce+2V6ekapvhEZg2mnGBkFwFAJJzqkCJVF+yMR 8w3mbCGLiTvVMxkC8+5CZE5xZplgLHWrxIUe/odz4wkf1Dqlg97upLQqy1XvN9fnOvNFa8kdF /But9SOhzlrCdWzuNHbhKI5pJ7Ewe9xvSphDgoTOa1mbFfLgngqWtOAUHi4fveunfcM4PYHLR 5cUjhMSTftSir3vH35ZfGwz9k7dbEgYKCPkhIr8ChW/rRuuTb5ohpQF/oqkRPq+Eg4UG1itlD OhhG1tziFeyVCPlfFeo+1bh/FCm/HxU1+ZSL2092mf9Z7vNhvrAfpuL9fkTWkyOKCeBbr+ul9 LTpRoUCo7kcZWHRqL9fm1sl+qbaE= X-Patchwork-Delegate: kuba@kernel.org Fix checkpatch code style warnings: WARNING: please, no space before tabs #230: FILE: net/core/pktgen.c:230: +#define M_NETIF_RECEIVE ^I1^I/* Inject packets into stack */$ Signed-off-by: Peter Seiderer --- net/core/pktgen.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/net/core/pktgen.c b/net/core/pktgen.c index 50ed4eb792a8..766c4a1515f4 100644 --- a/net/core/pktgen.c +++ b/net/core/pktgen.c @@ -226,9 +226,9 @@ static char *pkt_flag_names[] = { #define T_REMDEV (1<<3) /* Remove one dev */ /* Xmit modes */ -#define M_START_XMIT 0 /* Default normal TX */ -#define M_NETIF_RECEIVE 1 /* Inject packets into stack */ -#define M_QUEUE_XMIT 2 /* Inject packet into qdisc */ +#define M_START_XMIT 0 /* Default normal TX */ +#define M_NETIF_RECEIVE 1 /* Inject packets into stack */ +#define M_QUEUE_XMIT 2 /* Inject packet into qdisc */ /* If lock -- protects updating of if_list */ #define if_lock(t) mutex_lock(&(t->if_lock)); From patchwork Thu Apr 10 07:17:42 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Peter Seiderer X-Patchwork-Id: 14046002 X-Patchwork-Delegate: kuba@kernel.org Received: from mout.gmx.net (mout.gmx.net [212.227.17.22]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6776C20E318; Thu, 10 Apr 2025 07:18:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=212.227.17.22 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744269500; cv=none; b=KNjDNjgZ5zCAku9RcWCTCp8tnNhCUl8Xu52tf2eqRZ7ui230p88nLB7Azb+wRl6f/Wo0ockx0F6q5sYYOLq/tSWRSLPOWmZ3043dh6AafOLVaQn/huUROd9Ryif2PFFQ7VwMhjIB2kAYqZwUO5LBoh2pSS6pnkdjgxa9kftC8vg= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744269500; c=relaxed/simple; bh=mbXSmKdij6xo9gTLepW2thrfrVVNI6g7LQ1n0yUoOjE=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=rUrFf+bk7ksaSURaB5bDSUEzAxJSzLFj8r9bBenvteSYwvgTgigatkzRsnSxZsArlPFwe/t3D/nhD5OCAUAQjGc8583S7XJRAPsDt8JPM7PdVBZSuEPqVd5knFBrZkxvuc5eQnBTPxnIGUzaYmWG0fC+Zk+XtIJy/iic0MiCd0A= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=gmx.net; spf=pass smtp.mailfrom=gmx.net; dkim=pass (2048-bit key) header.d=gmx.net header.i=ps.report@gmx.net header.b=VXLVB0nO; arc=none smtp.client-ip=212.227.17.22 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=gmx.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmx.net Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmx.net header.i=ps.report@gmx.net header.b="VXLVB0nO" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmx.net; s=s31663417; t=1744269482; x=1744874282; i=ps.report@gmx.net; bh=mbXSmKdij6xo9gTLepW2thrfrVVNI6g7LQ1n0yUoOjE=; h=X-UI-Sender-Class:From:To:Cc:Subject:Date:Message-ID:In-Reply-To: References:MIME-Version:Content-Transfer-Encoding:cc: content-transfer-encoding:content-type:date:from:message-id: mime-version:reply-to:subject:to; b=VXLVB0nO+bPR6r1oOmuePHmdc9pvmVLZWygOZORGWe6ks1ENDtrmxvMWxv8wZvaL 9nyjePn1GBI+u4Ol9HEPtVrQFTPsWFfaEVR98/H79reoJRev32pyAryF1rmL8g0vy 4jY2CCZqG+o3i7ekZylQYDraqo8ilJOtGvm/9EH2hIU2OTWXbXHkY2OH+Gzm0HQCG JqQUWNk354o3+VjoN6foteq49Z1TMsq+p6lStFkiaq/KR+rkyd4tAE2GG1G60nwXJ 5mkZnwI1TrWoKN0M2FaLe/wX+PBXy+la8l85W41fIMmETYFEExxBO0/u8SAhhFMwy U9btFSFjsolwUPibBw== X-UI-Sender-Class: 724b4f7f-cbec-4199-ad4e-598c01a50d3a Received: from localhost.fritz.box ([82.135.81.74]) by mail.gmx.net (mrgmx104 [212.227.17.168]) with ESMTPSA (Nemesis) id 1MMXUN-1tjBvB2eiF-00JfJ7; Thu, 10 Apr 2025 09:18:02 +0200 From: Peter Seiderer To: netdev@vger.kernel.org Cc: linux-kernel@vger.kernel.org, "David S . Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Simon Horman , Peter Seiderer Subject: [PATCH net-next v1 05/11] net: pktgen: fix code style (WARNING: suspect code indent for conditional statements) Date: Thu, 10 Apr 2025 09:17:42 +0200 Message-ID: <20250410071749.30505-6-ps.report@gmx.net> X-Mailer: git-send-email 2.49.0 In-Reply-To: <20250410071749.30505-1-ps.report@gmx.net> References: <20250410071749.30505-1-ps.report@gmx.net> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Provags-ID: V03:K1:U2T/Q+vxsK93QE4PWYgVnwbtIqTI9LpoTAQPldjlb8ZwFaXTzbm G018huIj7ob85oMnhvSAxvmpc5zNgWyoCn6EZGx0fe7/7u6q5gtUwtafKiHLLe7wPVhgXl7 /1BuU3g5NnpDqtCB1v+cWi6KUeHD+ylDMm/at9atvgtLP9Sj+ucT2/Akbkkkks2/qYgaIqF IGT7oP4UOqZbVJuAw1Xpg== X-Spam-Flag: NO UI-OutboundReport: notjunk:1;M01:P0:0kr4ffX+fj0=;uvFbSt+R//l+gDUmQV4+qr2Qc/F jIWgBvvvX++eqyxyLSgkGzZNlKsSWxPO6TnNLNPn7V5ymNEJ6CWeBUkVHDBZqV2MtBOhid+Wr R+GLNfQRPPtSDgPUSrXgdt0JlWASBbr/HEiz5udcmXjBgNiz9X5+qv7VXFRdB5YUKZIMvp7xM dERgNqsYe99IcFjNtd1UO2jCQDGnrCtXC8ktYvXlgH3JVMQF55WZVB5XlKW19Bof7CzAbHijk tXe65oiwEa2q7tqmqbFRAUCG8DJLAfTaOrC34d7CNACuGqnzneLl8YsftfLGMRDnsaBJIMJFH t1t4dVaqIXX2vMWE2aS3crTZEPpHl4DiBPK82fKwpXjAon3SiNiLW0TfoeufUdfxz899yFxxF ctbLladWT59ZyjaP83KaHYOcXKQyoAGL+MhPjOXNX2g5nqJv2+PFD1d6pmW0SW9U2YAmtO2/9 gGSboXHHVp+5ax8C7zqLlX/0AnJreh41emrj2SfPJdLpjmIEqP848IkPuyfqbvEuuYd+pfDoO q/bUwGQDIjm9r+MD/ZxRKCNI+TJehYTZvbljeKst6XeAKhSGGiZKPiRuf+h9/1c3ZWVUzLYZJ 4AHCn9teDCN9MeDwfCXqas1tLLn5ke20CUAUUhsgNc+rIrVcD4xE5f4LbI4Ojivvs8RjDJUpi VW/v0ggQrOdLe3E0rbPNhfZqr8e6C/N/bzNqd3TDViwb7oQFGDoUV8BMb4x3Axbza4cx3j70W w6e2ukvx7aeAo2vHaAvTfiYqCV1zNpgU+71RVyQ5ZvEa1hDCu8OitVWB2dJsLHDkupV35LSKm KMPXFvVJ495A4IlHBD5NQgsz7lCHKQlEVMGAfXkgNQT/0r8yiUpcvrhkpTzwis4pTmIHhgjdE vDykjM6nfw+GpMj2kqhvXLuJZEMMW18vhjpZTjD0fs8pNJvYc3AUf90ijf8RHI/CVWdXVgYy/ nWHMB+z6qWvCOshJ+EYUGy6m/Yp7F1KEG3bFMJ9pSuP/cw8Fve7hOJlvdaUhEsXJ9mIoAoURF /EYe8o6qEgl53cwWwNOOI7Ab6d9E66vg3G1GWjiPLp6yiPC3X+rJ6Qv/EHLmTh2GrBLlCRQtJ xis/sEfSzT8kb3feeXsLZHrb644sxUswj9t+ap2SyZQKbvGDfY8TTNcTR1kgCmYCQf+pYsbGR l6t+MWOJu88f7zD+Y60x/NWMNAu5h3xG95hMzJfp6g0DFlz3hoLmRyXL9U7bmYVgzxomXgeG4 gF+An9KTmmHxCBm4fQN43qneARjbFR75nWsIQla8dYMUGJZ07Q8VibIeK9YdMeaEstRp8ajrh SNCmxk82Bbqj9cJ2J19bxsi2is+fkeOdwSXN0nFkKd7EySlVE2n5IVVvM2d4IcoTFW6TY7/Io FsIShePKeJqVvgGlnaOqoRy0pNsSvDFWjdLJU8JlaNkYLI8BP49YXraYFMgL3J2EHvjOFzwWR BIU614SNHCvDOirifC2L4I4a0IZCppDLwU6H77awHwMIdoxfb X-Patchwork-Delegate: kuba@kernel.org Fix checkpatch code style warnings: WARNING: suspect code indent for conditional statements (8, 17) #2901: FILE: net/core/pktgen.c:2901: + } else { + skb = __netdev_alloc_skb(dev, size, GFP_NOWAIT); Signed-off-by: Peter Seiderer --- net/core/pktgen.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/core/pktgen.c b/net/core/pktgen.c index 766c4a1515f4..c7caaf68ffee 100644 --- a/net/core/pktgen.c +++ b/net/core/pktgen.c @@ -2899,7 +2899,7 @@ static struct sk_buff *pktgen_alloc_skb(struct net_device *dev, skb->dev = dev; } } else { - skb = __netdev_alloc_skb(dev, size, GFP_NOWAIT); + skb = __netdev_alloc_skb(dev, size, GFP_NOWAIT); } /* the caller pre-fetches from skb->data and reserves for the mac hdr */ From patchwork Thu Apr 10 07:17:43 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Peter Seiderer X-Patchwork-Id: 14045997 X-Patchwork-Delegate: kuba@kernel.org Received: from mout.gmx.net (mout.gmx.net [212.227.17.20]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 504CE20E032; Thu, 10 Apr 2025 07:18:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=212.227.17.20 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744269498; cv=none; b=e9qjxIl4vFFg1wk4amLLv0rFgS70Y156utj5NRP/ULgJo60Vf4ccYtEmPrNjIXXpSUaz8/N/xCZOn21rXQAQOer+EyAtRt8lsJx8cde9NgX90jUPrpPbDaaceVCHjgF/p1/UruoLgdR1fjftc7HJnk2YdPaLfmWPgHEaeoSIuAY= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744269498; c=relaxed/simple; bh=6SgfvwQv5FBg8s1TO9Ad3KQChhb5Himk1suKQuXSsA0=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=YY2iRb7jHUZTtMIt/E9+Z0R0+zOuTHcItf/wIMcJUJ7wE7l/CNSm1GqDk4Lr4qI7w11D8cSW6knlZx1ObKIyV+W5PrEaRI2qAHZi0ryZ4Q/HgYLXm2+iMVrCAbsrEfRv68OvZZ3pYm7IjtvCIA87O0+gVecj0uurmngnB8lpckc= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=gmx.net; spf=pass smtp.mailfrom=gmx.net; dkim=pass (2048-bit key) header.d=gmx.net header.i=ps.report@gmx.net header.b=ZvLY403D; arc=none smtp.client-ip=212.227.17.20 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=gmx.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmx.net Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmx.net header.i=ps.report@gmx.net header.b="ZvLY403D" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmx.net; s=s31663417; t=1744269483; x=1744874283; i=ps.report@gmx.net; bh=6SgfvwQv5FBg8s1TO9Ad3KQChhb5Himk1suKQuXSsA0=; h=X-UI-Sender-Class:From:To:Cc:Subject:Date:Message-ID:In-Reply-To: References:MIME-Version:Content-Transfer-Encoding:cc: content-transfer-encoding:content-type:date:from:message-id: mime-version:reply-to:subject:to; b=ZvLY403DgddwcknCOyJGWlNqfdrx6OwgOtte8l61OU0lj4Gfg/8haGUmqtT4EFc8 wGHngCmjOPr/i2hiaEmnajk4IMpzEFQfew5K2p04SXU1LLe6BX07GbqDHgDUCWUsM 4c/b65zK4MtqRckNnhRvFy/VhL6z1LlUkgSf0z8XVzH98Xl9WS2madpcu78Cyo3aq aoE4VAjBYdGCSobacR6O+tXQ22VmWlf0uY/dcBuTS3pYTpnAx8XCN420uKHqDK9MW hAqYDJaIsHpaklowTov+rRYvW6CzMugsKgdzUKf674Rs7yz79KhfMvsF1JsW1vcdV Cvy3/kiG5Bva9CI36w== X-UI-Sender-Class: 724b4f7f-cbec-4199-ad4e-598c01a50d3a Received: from localhost.fritz.box ([82.135.81.74]) by mail.gmx.net (mrgmx104 [212.227.17.168]) with ESMTPSA (Nemesis) id 1M42jQ-1u2mAk3n1M-000D2w; Thu, 10 Apr 2025 09:18:02 +0200 From: Peter Seiderer To: netdev@vger.kernel.org Cc: linux-kernel@vger.kernel.org, "David S . Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Simon Horman , Peter Seiderer Subject: [PATCH net-next v1 06/11] net: pktgen: fix code style (WARNING: Block comments) Date: Thu, 10 Apr 2025 09:17:43 +0200 Message-ID: <20250410071749.30505-7-ps.report@gmx.net> X-Mailer: git-send-email 2.49.0 In-Reply-To: <20250410071749.30505-1-ps.report@gmx.net> References: <20250410071749.30505-1-ps.report@gmx.net> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Provags-ID: V03:K1:hJxJH/bnaxYOV77W11U2dX4DhVtAXzYuTXigP/eZM7tnL2bWhcc tC/CnmZ+P5BfUB4RTRxdBbCl5MATmeTYdESFetOfUE8Uix6wjkq7LEE6zRy8z7MWsPcbgzT AyUM5r2U+CJxnj6y0oqrP7tm4YTwd6QcONvtEd7cSx8ZuNBhim9uyqxWnvthR6ikxbgMi1w RAT1XqssbcNgEdbCuTBhA== X-Spam-Flag: NO UI-OutboundReport: notjunk:1;M01:P0:hy9D6/AtdAs=;U3H9Fx89zC3+C3He3LJk8QPXoS7 lIcbi5KpBJ9jw5h/Ww7JhzNhAvIg5mRMuBr9yGbL/eNyirwO9uOGSeTd2E1o9H4k4IOeJL+hA tPiei1f3ywnQnnDMbjTL0VMMqjWBTOOiQpAXxxzM6m13MP7oJlhdE/Esf3dX5vL9sC1OBdcm7 ZbV4p+YqsKG1A1QYPUGwdUZ/m8XLlLY+jPk/Nit1KEFeriDWGpkyG6AR78+YS2E99jD2s9Tht DJmyJ7ASvrLgBErT1F5AX6ho3GTEOwNfFgaoaYPWPAimVCldlSKxMH0UUvwhGLF/zoO8pP85Z U2887h8bVTaF7uVk9lka0SoG0YU9m0O/oYaFg3xX7fm1Z3Ky9IvHUy/bwrz0AhQYgpgg8PnuF 7HLCsB18J6ddIubHayAkRcO6dEMWQiSaofT3nLI5oIL/ZemugkxO95UibR20tXIhAZJgJN9rk tD6AcXYaLSZotCUnKAhx8MbbS7HA9O1jgJBOXDUYt1lTiKAPthBFs3u/8w0LHuyt4tAgOtUIy KI/l7syGZod9QP5EQZk40kJE6r50pqHzNOXWL7zepRH1QxUdEN7FDJkYZw0nqHo3cn5wuRIx6 S5QD5CTFD05yX9j9LNNDMitOvG5Y3mwATEMZVY2aMp/kyHxvvRzhWZ9O+FkIlxWtuqDpwNwh7 5rIvM1fUewEZzFK7lIsWF93W8dc2VJehKrN/ejVpHOFROC7EBVxRWr+OCoFkqBlFmOus1YlKR Z+738fbh3WdKr5FXBSOVJ9FxdfYuU8bDY7xLn/eMYJBn6kum6U+i4VY1jCrZ/WPqMSkoPUsYW 2HMZ6u6r8VUT/YlsGVuamry7gE3glc1+xLzhwFuWh3TeCfdB8ouOeEtEoAiZvUWh+gH1YQN7i Ez6RY2KTHQXq4UmgmuP4Gz+T9+0rYiCH1melCDO85UUXiYMt0hAg4pteiOEk/C7R6z6uEiPwC cTO1AC+D6QyOwgUVnT4LbD9vjKQUxIy/uA4W2dwgi73iAigE+5vM2MHlcgkylhGrFUXS8284M eKVAdetcoQuIyOaupfSfrxxWHvE/IRuw08iKGeu5VvCkWfb/Cp7Pgi4gywFhCRVZ1wsZxOq5O sa5cLHB/id/2qtGNtrjmRG3uBTxL7qrnzHX5jf5fts18Ghf+q47qhfR/Vfp/axLzrq8X6L+da eP00i87gjy/lUcPfb6UWslHn+x/4ZHPOCJJUbJfRZJ0B+m4SqPNOMgjAEqvp8vRnnj8shjfnr xghGT4D8Zq6IyFBc1DvcMHofI/Mb1YAX/iRiAyXwTagGPXOg07hNASHxVlVk+YLcKcDuouwkb x3JYk0U3jIDg3aEgyzP1ccMcoCwjfegcwVP9FcUpKNKxcA1emfzIf48AFFcdUsmqgZccdYpzJ lgaBgMSvPXZg5x/mTEQfyQfvlJUugVp7LUuycVbVQEma/kO8lnU3LIil9vuDilg+uusGEGv7Q kqDOzcMoi/k98pSTzJ/iVkAzJRac= X-Patchwork-Delegate: kuba@kernel.org Fix checkpatch code style warnings: WARNING: Block comments use a trailing */ on a separate line + * removal by worker thread */ WARNING: Block comments use * on subsequent lines + __u8 tos; /* six MSB of (former) IPv4 TOS + are for dscp codepoint */ WARNING: Block comments use a trailing */ on a separate line + are for dscp codepoint */ WARNING: Block comments use * on subsequent lines + __u8 traffic_class; /* ditto for the (former) Traffic Class in IPv6 + (see RFC 3260, sec. 4) */ WARNING: Block comments use a trailing */ on a separate line + (see RFC 3260, sec. 4) */ WARNING: Block comments use * on subsequent lines + /* = { + 0x00, 0x80, 0xC8, 0x79, 0xB3, 0xCB, WARNING: Block comments use * on subsequent lines + /* Field for thread to receive "posted" events terminate, + stop ifs etc. */ WARNING: Block comments use a trailing */ on a separate line + stop ifs etc. */ WARNING: Block comments should align the * on each line + * we go look for it ... +*/ WARNING: Block comments use a trailing */ on a separate line + * we resolve the dst issue */ WARNING: Block comments use a trailing */ on a separate line + * with proc_create_data() */ Signed-off-by: Peter Seiderer --- net/core/pktgen.c | 39 +++++++++++++++++++++++---------------- 1 file changed, 23 insertions(+), 16 deletions(-) diff --git a/net/core/pktgen.c b/net/core/pktgen.c index c7caaf68ffee..6d2bf1ae5eb9 100644 --- a/net/core/pktgen.c +++ b/net/core/pktgen.c @@ -283,7 +283,8 @@ struct pktgen_dev { int pkt_overhead; /* overhead for MPLS, VLANs, IPSEC etc */ int nfrags; int removal_mark; /* non-zero => the device is marked for - * removal by worker thread */ + * removal by worker thread + */ struct page *page; u64 delay; /* nano-seconds */ @@ -346,10 +347,12 @@ struct pktgen_dev { __u16 udp_dst_max; /* exclusive, dest UDP port */ /* DSCP + ECN */ - __u8 tos; /* six MSB of (former) IPv4 TOS - are for dscp codepoint */ - __u8 traffic_class; /* ditto for the (former) Traffic Class in IPv6 - (see RFC 3260, sec. 4) */ + __u8 tos; /* six MSB of (former) IPv4 TOS + * are for dscp codepoint + */ + __u8 traffic_class; /* ditto for the (former) Traffic Class in IPv6 + * (see RFC 3260, sec. 4) + */ /* IMIX */ unsigned int n_imix_entries; @@ -389,12 +392,12 @@ struct pktgen_dev { __u8 hh[14]; /* = { - 0x00, 0x80, 0xC8, 0x79, 0xB3, 0xCB, - - We fill in SRC address later - 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, - 0x08, 0x00 - }; + * 0x00, 0x80, 0xC8, 0x79, 0xB3, 0xCB, + * + * We fill in SRC address later + * 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, + * 0x08, 0x00 + * }; */ __u16 pad; /* pad out the hh struct to an even 16 bytes */ @@ -458,7 +461,8 @@ struct pktgen_thread { char result[512]; /* Field for thread to receive "posted" events terminate, - stop ifs etc. */ + * stop ifs etc. + */ u32 control; int cpu; @@ -2396,7 +2400,7 @@ static inline int f_pick(struct pktgen_dev *pkt_dev) /* If there was already an IPSEC SA, we keep it as is, else * we go look for it ... -*/ + */ #define DUMMY_MARK 0 static void get_ipsec_sa(struct pktgen_dev *pkt_dev, int flow) { @@ -2693,7 +2697,8 @@ static int pktgen_output_ipsec(struct sk_buff *skb, struct pktgen_dev *pkt_dev) if (!x) return 0; /* XXX: we dont support tunnel mode for now until - * we resolve the dst issue */ + * we resolve the dst issue + */ if ((x->props.mode != XFRM_MODE_TRANSPORT) && (pkt_dev->spi == 0)) return 0; @@ -3787,7 +3792,8 @@ static int add_dev_to_thread(struct pktgen_thread *t, * userspace on another CPU than the kthread. The if_lock() * is used here to sync with concurrent instances of * _rem_dev_from_if_list() invoked via kthread, which is also - * updating the if_list */ + * updating the if_list + */ if_lock(t); if (pkt_dev->pg_thread) { @@ -3982,7 +3988,8 @@ static int pktgen_remove_device(struct pktgen_thread *t, /* Remove proc before if_list entry, because add_device uses * list to determine if interface already exist, avoid race - * with proc_create_data() */ + * with proc_create_data() + */ proc_remove(pkt_dev->entry); /* And update the thread if_list */ From patchwork Thu Apr 10 07:17:44 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Peter Seiderer X-Patchwork-Id: 14045996 X-Patchwork-Delegate: kuba@kernel.org Received: from mout.gmx.net (mout.gmx.net [212.227.17.20]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5ACDC20CCD0; Thu, 10 Apr 2025 07:18:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=212.227.17.20 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744269492; cv=none; b=dshHwzudHq/7EJC4I7DqqfhyzzoclIeYYwp5zuGm60HYLEiUS2yJZAofjhhbN8OZyv/Ll8zL6FQi7+awaN1Ko+bqbkPkS4w8fX/wZEpJK8thXrwUZ+/GvOh84dashI9AfL1UcGpTEC+gqA1oqXSKRzkpzdmH2y1hkhx1jiAGqFA= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744269492; c=relaxed/simple; bh=2gXd9w/b1brVEYRsxS3GP4N+Vzgt56PJau7/375ytls=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=IHuLgWRuzRqSTuo5pXECDWWhWftr7CFXD1g/MHReiqJb/A8P9kR68ovD56Xlyzo3walPdYXiSMC03EK45INQHMVIcc7zqSteQInlOdoc1eJWqabbCj5FfAOQtO78Q0eW0FEYxJB/hM+77TDYxO1Lyy6uXYY690+bRO+KJwefkps= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=gmx.net; spf=pass smtp.mailfrom=gmx.net; dkim=pass (2048-bit key) header.d=gmx.net header.i=ps.report@gmx.net header.b=tSsRld4m; arc=none smtp.client-ip=212.227.17.20 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=gmx.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmx.net Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmx.net header.i=ps.report@gmx.net header.b="tSsRld4m" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmx.net; s=s31663417; t=1744269483; x=1744874283; i=ps.report@gmx.net; bh=2gXd9w/b1brVEYRsxS3GP4N+Vzgt56PJau7/375ytls=; h=X-UI-Sender-Class:From:To:Cc:Subject:Date:Message-ID:In-Reply-To: References:MIME-Version:Content-Transfer-Encoding:cc: content-transfer-encoding:content-type:date:from:message-id: mime-version:reply-to:subject:to; b=tSsRld4mlkedWjcZH8zF3qe3OhXCAG5cew5lV/jn9sTSPB2U+wGeUon8Vr8DSDRj cZ9OooucV7EIEMNIqu/3/Kl9XSjKT/wDkw61KLnSwLjoof/Yc1UJjoz5qpwqvxtIs Yix+PTkQG2eOJVsnhZzLroTyU4+o80bLtN6++sO+NUeQ7fo71QZoIAQOMhNjnwuRJ nqnkYGOdvKBTV4d385Hg4qUosLCh0CkGy1gjDJgouoPfWMix8ck/ZQEi2zyTgjo5/ CRPP/NDYpuwF3m120hL+4Jf4mIKWFHnCtbJBzPu9Wx5ZoYD3Xr83dPpoKN0VQiwAD 4w3FJ9TeHz6wSdERuA== X-UI-Sender-Class: 724b4f7f-cbec-4199-ad4e-598c01a50d3a Received: from localhost.fritz.box ([82.135.81.74]) by mail.gmx.net (mrgmx104 [212.227.17.168]) with ESMTPSA (Nemesis) id 1MDysm-1tsqXX0o9k-00A9CI; Thu, 10 Apr 2025 09:18:03 +0200 From: Peter Seiderer To: netdev@vger.kernel.org Cc: linux-kernel@vger.kernel.org, "David S . Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Simon Horman , Peter Seiderer Subject: [PATCH net-next v1 07/11] net: pktgen: fix code style (WARNING: Missing a blank line after declarations) Date: Thu, 10 Apr 2025 09:17:44 +0200 Message-ID: <20250410071749.30505-8-ps.report@gmx.net> X-Mailer: git-send-email 2.49.0 In-Reply-To: <20250410071749.30505-1-ps.report@gmx.net> References: <20250410071749.30505-1-ps.report@gmx.net> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Provags-ID: V03:K1:DRQM3oqiJL8GXAXCmoM3CCwZ4Ye3qi8EieOxWmsBD+sjUr2B8rm VeauWXXpf6s2zGyYDlsJj0cwAlds37QuViqBO2bQc8G1SwNz2EESln7xo/QJlaecieZRBx0 sYvzyYOgsoaXWMbIuqwnZ5twqoR1PyIhaxYFA5MYLcOEf+Hsvsr1miyjz5zBlzzec2xj3jw JCS0ofBBVndUSBL676p5g== X-Spam-Flag: NO UI-OutboundReport: notjunk:1;M01:P0:0Vb4fycjxbc=;E90ANPOYCdeETurPsPfVfytAn7K yFfifi9F7UFeAqG2HdFdLKqlSA0pjZxjl6xZp4k0xhgjirJTRkVQLCxAdEuRL/4vDF4oepbmq 7rjEXMBmznUsOwg1i0kQG4TLVgmEXPM8EsvUifbbL1vPqOYI/nPOQEjP2c0XkjsXwAk56SW0J LL2qCR47zcR8iTbG/gbuJeC8Wxdjk0nq2Zm08FnR54vhPJ0i7v5UnjhXzgPNFV1wDBooxdCEc Zieb/TMUEICeZv28N2h2y1/bFRL8XxEQWjLJlghe/UOuXclDL7u97YDlcVh9alglsCxMva4+S utZC0UhMiMb7zzSfqiVR/KVMbpgz9gRZ8znYuYcacEMnO8+Ntg30d2vevTBrrRUwBU/cgj4lc tVEQWH2ufiNfjNw5fQbVeRuDSDYaUPosRniNHkA5P0BpzeZoFdF+4K82Beddt97BzWnbx2K5O uopGUMhHt0r/5+0J1UReCZsOKHSk3v5gmFVYulLLAoyHu9zNU05R35IS5xx7N2jwYsdr+1J4v 1RNltVsJGv9vs66uf1kpDJwhRm1p9vk9w8Gik97aBKdLLVVnH75tt0J2tGZHy8dbsnN4h4aKC lvs5EBWQgVhHGTbzXJYoOM35BeaJgXmuJNu0oj9P6yt/aF+zDKZMrondc0KYgpIFUZiL6Z7NF rDcGjNka7oFvlz/UQ/PER2gCa/J9P3dj+7QS51ikRV9irUISPOP6t1zIsP9M96Ezf7srgAsrZ TlO4jgayBmlBzCV508GrF/82e6OdWanneXtkzNuLg45IKm4eKLWSmx6X+jIKDm6UgNdjBquVb 7fpr6PnkF2B1HJTJS5hRRoebQJqSmGCJzHWXvx3diisKTbF31O+1+rUPnWmgvT2HfaFMfbPfX Q0mzqKr9k7ilSMM899J+ybKt+A/jf9Aut2JpnX242Slqs1VXPv1mhU+8gMDkXjLCBwvyOOg1F pCoopyfkg2LXptdHe7Ws/NtdEqH1R3MSzTASY0eM9y9vreMyErko4d8ZjwjTxrl4HJgcWOGhV pl4oYTvRWJlLfqIBOxjV8h1P0Xo8bq2Iam90bKSlNThLNyI2xQVP6iy2GdsahY0ZIuZYGI1kK RcDfOrf0xjLbRnNwDzXot7Fr8AxYZOq1ZLFZ+z2PRpqIa6fztiI7vBb9Lv+SDtp5T/Mwbkkkm w2O3w02ps9qnjBkUNes0m7wFMz1pCTCDji+3YNNVXFWCIAbqcY+5A6U1fnI1xxplnqQogve9b 7oL+F9WCPmXzqX8YUANg7nG/4gQxiiFo6/AlcFr9jTK5qbi+LPtAYhWGnUBtodEzF83NKOpBK XkhkWQM2LXejGdTbN48JGDta4oD7noYqQxGTd8m7tgJTvB8OtefK6q7h7tfQeSWAZ2NCOGeZH Lu0wxU2HJsvz9lMSZCpGmmCw0bIxLod09d3W05lMaeu3Upx9l8PE+CPOCLKTEOUt0e5mKa3YL BGTUKxzJ4f+bQqjmQdJ7DKNt2kB0= X-Patchwork-Delegate: kuba@kernel.org Fix checkpatch code style warnings: WARNING: Missing a blank line after declarations #761: FILE: net/core/pktgen.c:761: + char c; + if (get_user(c, &user_buffer[i])) WARNING: Missing a blank line after declarations #780: FILE: net/core/pktgen.c:780: + char c; + if (get_user(c, &user_buffer[i])) WARNING: Missing a blank line after declarations #806: FILE: net/core/pktgen.c:806: + char c; + if (get_user(c, &user_buffer[i])) WARNING: Missing a blank line after declarations #823: FILE: net/core/pktgen.c:823: + char c; + if (get_user(c, &user_buffer[i])) WARNING: Missing a blank line after declarations #1968: FILE: net/core/pktgen.c:1968: + char f[32]; + memset(f, 0, 32); WARNING: Missing a blank line after declarations #2410: FILE: net/core/pktgen.c:2410: + struct pktgen_net *pn = net_generic(dev_net(pkt_dev->odev), pg_net_id); + if (!x) { WARNING: Missing a blank line after declarations #2442: FILE: net/core/pktgen.c:2442: + __u16 t; + if (pkt_dev->flags & F_QUEUE_MAP_RND) { WARNING: Missing a blank line after declarations #2523: FILE: net/core/pktgen.c:2523: + unsigned int i; + for (i = 0; i < pkt_dev->nr_labels; i++) WARNING: Missing a blank line after declarations #2567: FILE: net/core/pktgen.c:2567: + __u32 t; + if (pkt_dev->flags & F_IPSRC_RND) WARNING: Missing a blank line after declarations #2587: FILE: net/core/pktgen.c:2587: + __be32 s; + if (pkt_dev->flags & F_IPDST_RND) { WARNING: Missing a blank line after declarations #2634: FILE: net/core/pktgen.c:2634: + __u32 t; + if (pkt_dev->flags & F_TXSIZE_RND) { WARNING: Missing a blank line after declarations #2736: FILE: net/core/pktgen.c:2736: + int i; + for (i = 0; i < pkt_dev->cflows; i++) { WARNING: Missing a blank line after declarations #2738: FILE: net/core/pktgen.c:2738: + struct xfrm_state *x = pkt_dev->flows[i].x; + if (x) { WARNING: Missing a blank line after declarations #2752: FILE: net/core/pktgen.c:2752: + int nhead = 0; + if (x) { WARNING: Missing a blank line after declarations #2795: FILE: net/core/pktgen.c:2795: + unsigned int i; + for (i = 0; i < pkt_dev->nr_labels; i++) WARNING: Missing a blank line after declarations #3480: FILE: net/core/pktgen.c:3480: + ktime_t idle_start = ktime_get(); + schedule(); Signed-off-by: Peter Seiderer --- net/core/pktgen.c | 16 ++++++++++++++++ 1 file changed, 16 insertions(+) diff --git a/net/core/pktgen.c b/net/core/pktgen.c index 6d2bf1ae5eb9..72063f3f8c61 100644 --- a/net/core/pktgen.c +++ b/net/core/pktgen.c @@ -758,6 +758,7 @@ static ssize_t hex32_arg(const char __user *user_buffer, size_t maxlen, for (; i < maxlen; i++) { int value; char c; + if (get_user(c, &user_buffer[i])) return -EFAULT; value = hex_to_bin(c); @@ -777,6 +778,7 @@ static ssize_t count_trail_chars(const char __user *user_buffer, size_t maxlen) for (i = 0; i < maxlen; i++) { char c; + if (get_user(c, &user_buffer[i])) return -EFAULT; switch (c) { @@ -803,6 +805,7 @@ static ssize_t num_arg(const char __user *user_buffer, size_t maxlen, for (i = 0; i < maxlen; i++) { char c; + if (get_user(c, &user_buffer[i])) return -EFAULT; if ((c >= '0') && (c <= '9')) { @@ -820,6 +823,7 @@ static ssize_t strn_len(const char __user *user_buffer, size_t maxlen) for (i = 0; i < maxlen; i++) { char c; + if (get_user(c, &user_buffer[i])) return -EFAULT; switch (c) { @@ -1965,6 +1969,7 @@ static ssize_t pktgen_thread_write(struct file *file, if (!strcmp(name, "add_device")) { char f[32]; + memset(f, 0, 32); max = min(sizeof(f) - 1, count - i); len = strn_len(&user_buffer[i], max); @@ -2407,6 +2412,7 @@ static void get_ipsec_sa(struct pktgen_dev *pkt_dev, int flow) #ifdef CONFIG_XFRM struct xfrm_state *x = pkt_dev->flows[flow].x; struct pktgen_net *pn = net_generic(dev_net(pkt_dev->odev), pg_net_id); + if (!x) { if (pkt_dev->spi) { @@ -2439,6 +2445,7 @@ static void set_cur_queue_map(struct pktgen_dev *pkt_dev) else if (pkt_dev->queue_map_min <= pkt_dev->queue_map_max) { __u16 t; + if (pkt_dev->flags & F_QUEUE_MAP_RND) { t = get_random_u32_inclusive(pkt_dev->queue_map_min, pkt_dev->queue_map_max); @@ -2520,6 +2527,7 @@ static void mod_cur_headers(struct pktgen_dev *pkt_dev) if (pkt_dev->flags & F_MPLS_RND) { unsigned int i; + for (i = 0; i < pkt_dev->nr_labels; i++) if (pkt_dev->labels[i] & MPLS_STACK_BOTTOM) pkt_dev->labels[i] = MPLS_STACK_BOTTOM | @@ -2564,6 +2572,7 @@ static void mod_cur_headers(struct pktgen_dev *pkt_dev) imx = ntohl(pkt_dev->saddr_max); if (imn < imx) { __u32 t; + if (pkt_dev->flags & F_IPSRC_RND) t = get_random_u32_inclusive(imn, imx - 1); else { @@ -2584,6 +2593,7 @@ static void mod_cur_headers(struct pktgen_dev *pkt_dev) if (imn < imx) { __u32 t; __be32 s; + if (pkt_dev->flags & F_IPDST_RND) { do { @@ -2631,6 +2641,7 @@ static void mod_cur_headers(struct pktgen_dev *pkt_dev) if (pkt_dev->min_pkt_size < pkt_dev->max_pkt_size) { __u32 t; + if (pkt_dev->flags & F_TXSIZE_RND) { t = get_random_u32_inclusive(pkt_dev->min_pkt_size, pkt_dev->max_pkt_size - 1); @@ -2733,8 +2744,10 @@ static void free_SAs(struct pktgen_dev *pkt_dev) if (pkt_dev->cflows) { /* let go of the SAs if we have them */ int i; + for (i = 0; i < pkt_dev->cflows; i++) { struct xfrm_state *x = pkt_dev->flows[i].x; + if (x) { xfrm_state_put(x); pkt_dev->flows[i].x = NULL; @@ -2749,6 +2762,7 @@ static int process_ipsec(struct pktgen_dev *pkt_dev, if (pkt_dev->flags & F_IPSEC) { struct xfrm_state *x = pkt_dev->flows[pkt_dev->curfl].x; int nhead = 0; + if (x) { struct ethhdr *eth; struct iphdr *iph; @@ -2792,6 +2806,7 @@ static int process_ipsec(struct pktgen_dev *pkt_dev, static void mpls_push(__be32 *mpls, struct pktgen_dev *pkt_dev) { unsigned int i; + for (i = 0; i < pkt_dev->nr_labels; i++) *mpls++ = pkt_dev->labels[i] & ~MPLS_STACK_BOTTOM; @@ -3477,6 +3492,7 @@ static void pktgen_rem_thread(struct pktgen_thread *t) static void pktgen_resched(struct pktgen_dev *pkt_dev) { ktime_t idle_start = ktime_get(); + schedule(); pkt_dev->idle_acc += ktime_to_ns(ktime_sub(ktime_get(), idle_start)); } From patchwork Thu Apr 10 07:17:45 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Peter Seiderer X-Patchwork-Id: 14045998 X-Patchwork-Delegate: kuba@kernel.org Received: from mout.gmx.net (mout.gmx.net [212.227.17.21]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4BE39207E17; Thu, 10 Apr 2025 07:18:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=212.227.17.21 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744269499; cv=none; b=QLnPg2yK1ttfl/dXrr9LndS5YpUdm1aIh3Vnzf+HJnSt9Hzrl2n5Rcke8b8sIgYQ2vd2RIyor7vs0fAELaUNJN3fIlPM/bo3YgXiG+oPWe2bqsywm6W8tF75MJ1mfUp8XBP4RESAP/zAjX82n3/4PiHUljQmrCiRbeH/g3zSmcY= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744269499; c=relaxed/simple; bh=654WS9Anirx/zCI0C0fiytG5Li7a1695HnpYwZUGJAg=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=Jy0B3gyr0aRJa2gCDvszj/O1C11b/hb99bTk/P0sx7JZkY4a0SilOB6plhkAvgBOkLjK6+gcakDv1Sr7qc7mUAbTxmKGosXgNVVu6WSxqRrGLQB4xko2i9CyHkeOTqDhgzRjPqwt4D43Ia0PaehrqBM4GRDzsG2xZEbAcRBd4Pc= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=gmx.net; spf=pass smtp.mailfrom=gmx.net; dkim=pass (2048-bit key) header.d=gmx.net header.i=ps.report@gmx.net header.b=oe6ErT8p; arc=none smtp.client-ip=212.227.17.21 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=gmx.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmx.net Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmx.net header.i=ps.report@gmx.net header.b="oe6ErT8p" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmx.net; s=s31663417; t=1744269483; x=1744874283; i=ps.report@gmx.net; bh=654WS9Anirx/zCI0C0fiytG5Li7a1695HnpYwZUGJAg=; h=X-UI-Sender-Class:From:To:Cc:Subject:Date:Message-ID:In-Reply-To: References:MIME-Version:Content-Transfer-Encoding:cc: content-transfer-encoding:content-type:date:from:message-id: mime-version:reply-to:subject:to; b=oe6ErT8pMfudNrU6tuPJg1fRiilaDRkBFxI9YUvBp2vLk5jTKyw8r5uqrZpuz3CS Ay4h7/8WyDXd3I+95umcy3i64fdGlsT2a/PZalupwCeAoNLHYEqjBBI5/nIaoxcsg yfV/Gg06drwVcuKIyBwHBjJLmr8WrKULdqfVujvrg1fm/Fl+HPguTAT14w0JKWVuy BLvG6UeeaHfPnj1/vekClhdefzPlM6r572qjkzs9mzn9ralrFY2JlX1exIuStdnrA 6tctqmBx1ZUkp6qt1DKUzvgLvrvzWbGam4SpVCsWRiKOfhtQl/3gxhTHYjEfzoZ/x 36d7rwi9aw839sFhdQ== X-UI-Sender-Class: 724b4f7f-cbec-4199-ad4e-598c01a50d3a Received: from localhost.fritz.box ([82.135.81.74]) by mail.gmx.net (mrgmx104 [212.227.17.168]) with ESMTPSA (Nemesis) id 1M2O2Q-1u3LCX1zbi-0044Oa; Thu, 10 Apr 2025 09:18:03 +0200 From: Peter Seiderer To: netdev@vger.kernel.org Cc: linux-kernel@vger.kernel.org, "David S . Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Simon Horman , Peter Seiderer Subject: [PATCH net-next v1 08/11] net: pktgen: fix code style (WARNING: macros should not use a trailing semicolon) Date: Thu, 10 Apr 2025 09:17:45 +0200 Message-ID: <20250410071749.30505-9-ps.report@gmx.net> X-Mailer: git-send-email 2.49.0 In-Reply-To: <20250410071749.30505-1-ps.report@gmx.net> References: <20250410071749.30505-1-ps.report@gmx.net> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Provags-ID: V03:K1:hWjbZCNQv5uqVklpaIo/DrtDXyvjsW52QBLHbHukE+gLC14LeQh MJYcQ513szJFt/iodZTGwy4jbaOca+DwyUTu/k1vj7HvmkCReylQxwZ9Zwo/GrAiPlxJmPS mTaA49sWpz6ds4qrMNZFxUKFYmQsLoxuH/tS5pBdI4Rz9DGereKAuX8QNbey0Ya6kmmj1fb F2WzBPPHj2a3png6OEaGA== X-Spam-Flag: NO UI-OutboundReport: notjunk:1;M01:P0:BTWyb3gJdzs=;Inka7+cAO8Vd/gaxRgou7vzP/R+ E+U89vjvvwj8LNop29SDDM05doV1IGgE+hFOZiAhKLB4/cr/tAy+k0kY7UPuTlDwLTGGV9GsP IEOFdjmTRGk0a0us2nf+aiFyBCdfGhswgfvbIDsk+hvFIPHV2aJWxjqRGTzzE6Tb6/q3Qbft+ DxIbuT15MUYpy9hVWzhcZ3lUCuba1Xtf2QutXAlWbXFLTNgzYIkMY567fVj+O+sty6pLlNFmf qTSFXh5USib+OpPHMz9Xo6ENJ7BAuM893KQLn9kSYRA0+t2eVHvR5QfeafCXhw+pqkUlq4L3A gf0iPbZmuHwUecaGwNFRuNuL16mmYY/2jzjPjxD6ScrZ9Y2tcLH84uo2lYnYDxxiXDseXLmMA dwHQoI46MHh4WoxrmChQJ6Ir56yjXho42BOms17NDdqnJp0q2rcWExkmH3uXrkWD1G5X0/iD/ TPude3dKniUfQCtqLXI+YtZaKjS71/bAwyGv1ywBd6FKZ4MCtANxdBnWHPX7acrw9KPLhH8xk mb74rQ94x4NYWIZxcYXf/3Zvsucen5glQ/Uo1wHRTQ1ZZcbVVb1Z0WixK3E/MX1ayHV21aQPN I3rJFaq6hsA9HIhJ3k8rFZlNMJ6Dv7IujkzSzC2AMnnRW5VDOsCmhmWRYVsy4bP/1w3wlXdpS sZXpyED1oLVXPRDw6QIJNXWtf5dDSAXd+5dkLlmkBafIWOxICvCHjCNrgydMhK8dYVwvlhUlH wJBYFozwi/Zja2gBQCTURSM+CsR4zrb94SR8zgBzjcxTY35M9NSbAmPphwn+nX57vFj9pLSo1 9bdW4Ye2dCtN7e36ugmtT3tarHEzGlL3RVunIYUXQsYCThqOh7+hjtIS7mxEQj2ZKU0h+DEjX u1CJ1bFzmZ+pOzmOClWJA3ZhKaffDYR1vS0HNUB2cRZiHZie0yJ6TsDca3RRzU3pzUAQ/lvtH onXndFU9pIOa6Mr4EZr538Objqhc0DQaC7KKb8501secIjZXFyNC48H0TtGUJOD4TSwgND5Yq h4ntYEjAi4PgfeaGVOWANfU8Oo9fUPUl5Xn5ZQ9FgJ4rHnWLgVGv0b8wCvl5OBH0rwuxVuvgM mkyLwzeFCgT+216wtGSKreJ1DjwYBo+wvD5fKwV/55M0JUlYs2nGvwF0wYkCARUtmBwauWrtW r2U25gv46zDyeH68mx2/Mkq9N3+aBX0pHCbij7pK54VuoizWtaxkiTXsTR8YlOmwhK/6o20er 3Y9MZx5IX2+f/SVC60l9IJ3qd8R1dSX/vzDjud7zCMHy9DGOOgfqe70LEQcTc9oBxknk3HPXn ueAevr/ciY3rtlKyTdlWAETF6rFWHAmz2YpOJfL1RtNWPmysLnK0ZCP6npxpWxHKODtHLHOdc u3ayhzor8bBF9f8EkayKih5vIF/J6FaZhVSL1Hoy90HVfRdh2EejUTmMmNgmpgLa6bnj5n4u/ JAhk8U/vYwVNuOtP7SFZY+zoCe88= X-Patchwork-Delegate: kuba@kernel.org Fix checkpatch code style warnings: WARNING: macros should not use a trailing semicolon #180: FILE: net/core/pktgen.c:180: +#define func_enter() pr_debug("entering %s\n", __func__); WARNING: macros should not use a trailing semicolon #234: FILE: net/core/pktgen.c:234: +#define if_lock(t) mutex_lock(&(t->if_lock)); CHECK: Unnecessary parentheses around t->if_lock #235: FILE: net/core/pktgen.c:235: +#define if_unlock(t) mutex_unlock(&(t->if_lock)); Signed-off-by: Peter Seiderer --- net/core/pktgen.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/net/core/pktgen.c b/net/core/pktgen.c index 72063f3f8c61..a1268be1edc6 100644 --- a/net/core/pktgen.c +++ b/net/core/pktgen.c @@ -177,7 +177,7 @@ #define MAX_IMIX_ENTRIES 20 #define IMIX_PRECISION 100 /* Precision of IMIX distribution */ -#define func_enter() pr_debug("entering %s\n", __func__); +#define func_enter() pr_debug("entering %s\n", __func__) #define PKT_FLAGS \ pf(IPV6) /* Interface in IPV6 Mode */ \ @@ -231,8 +231,8 @@ static char *pkt_flag_names[] = { #define M_QUEUE_XMIT 2 /* Inject packet into qdisc */ /* If lock -- protects updating of if_list */ -#define if_lock(t) mutex_lock(&(t->if_lock)); -#define if_unlock(t) mutex_unlock(&(t->if_lock)); +#define if_lock(t) mutex_lock(&(t->if_lock)) +#define if_unlock(t) mutex_unlock(&(t->if_lock)) /* Used to help with determining the pkts on receive */ #define PKTGEN_MAGIC 0xbe9be955 From patchwork Thu Apr 10 07:17:46 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Peter Seiderer X-Patchwork-Id: 14045994 X-Patchwork-Delegate: kuba@kernel.org Received: from mout.gmx.net (mout.gmx.net [212.227.17.21]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1A074205E31; Thu, 10 Apr 2025 07:18:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=212.227.17.21 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744269488; cv=none; b=EImK6kNVJFpD+0R9igxkXUjUjoCtq8AbktOGPSvazaIaTAlyIH+5WnTig1ouQE1OQ1Sx8qOZ7T5Q1WqGB1QqX2Ac6JGwd1r0czuf2JM1/Ab00o0UNugiraH8y9hiJgS8jAnDW5z5XyFPA0K/zDb+59YvXzj+elKG+QW5dnle5WI= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744269488; c=relaxed/simple; bh=Pb9fhhNlRDXFLApQGjgSX564cAnPyXxob7s56veHzsw=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=No3Ay34TE9VTNtRsAvQcIG4ArMsjXiEBcMAjfM/m5WO9uAjAS71bMp+wCtCQVsyF0tZbXhMLesWX0+4pU/HZAifgS5ga+AsjV0ndDwYm18Yw/zVigmRcHFfVeZReuIUKYhABjTOosKq3PrD5DHPAeFulvtodjjANXM7lnQ/NM7g= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=gmx.net; spf=pass smtp.mailfrom=gmx.net; dkim=pass (2048-bit key) header.d=gmx.net header.i=ps.report@gmx.net header.b=tuwPakjw; arc=none smtp.client-ip=212.227.17.21 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=gmx.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmx.net Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmx.net header.i=ps.report@gmx.net header.b="tuwPakjw" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmx.net; s=s31663417; t=1744269483; x=1744874283; i=ps.report@gmx.net; bh=Pb9fhhNlRDXFLApQGjgSX564cAnPyXxob7s56veHzsw=; h=X-UI-Sender-Class:From:To:Cc:Subject:Date:Message-ID:In-Reply-To: References:MIME-Version:Content-Transfer-Encoding:cc: content-transfer-encoding:content-type:date:from:message-id: mime-version:reply-to:subject:to; b=tuwPakjw9QjAjCLt9ajAYNCYcVvnu4bQLX3IOv3GZM9wYdD8dYTsE4Af80jYdYxd 534dc34OGTTJUOY7pkiwc4dy3ZDcs6efyrHOT3HUL0DIlq8glVorSskdIxQZ1JiB4 lCweYChvZyDPvLAtBeC9uSSbubN7vGyzVF5uY+MTciWHaOWJ5ZKQj7PtoN2YHpzKw 571EkN+NMWzhdiGugi5LDPYeK4frf4WLiF2qDWchYrToUW39Iw6PSGC6nBZqbzfRT 5TotCcVmrdKP6R0FutYxNs9i609NuskObF6zpILyxZMEb5sktiB2BiqaY5b2ZLUrl CEqSOWRW2HV9SOzIMg== X-UI-Sender-Class: 724b4f7f-cbec-4199-ad4e-598c01a50d3a Received: from localhost.fritz.box ([82.135.81.74]) by mail.gmx.net (mrgmx104 [212.227.17.168]) with ESMTPSA (Nemesis) id 1N1fii-1t5QFH3EBU-011qD4; Thu, 10 Apr 2025 09:18:03 +0200 From: Peter Seiderer To: netdev@vger.kernel.org Cc: linux-kernel@vger.kernel.org, "David S . Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Simon Horman , Peter Seiderer Subject: [PATCH net-next v1 09/11] net: pktgen: fix code style (WARNING: braces {} are not necessary for single statement blocks) Date: Thu, 10 Apr 2025 09:17:46 +0200 Message-ID: <20250410071749.30505-10-ps.report@gmx.net> X-Mailer: git-send-email 2.49.0 In-Reply-To: <20250410071749.30505-1-ps.report@gmx.net> References: <20250410071749.30505-1-ps.report@gmx.net> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Provags-ID: V03:K1:xxII8a/JaxjpUB34YoW12Xu8FOQu7OjbwVTOfK84CSFLol5C+Sa TMg+Btb0tuNGrgLpTob1XcNcSykQRN3v91kCxacnE3ru6SLaVWNbITqeLp21Jtcb7SWV0Oj Bm4XixNy6RNggE52XbgecX111GpRDtgUSU3TJd28HaxUwo/53D+6WYc+Jr2D4Sk48zmMqjf Qs1hfwap0TOU8SLnTyo+w== X-Spam-Flag: NO UI-OutboundReport: notjunk:1;M01:P0:bqBWwJH3wGM=;Er30y8j0C7cRasSE1fthzubPMjS mOj6k5su7znl+C09VwMM9TY2eWIcyjlDmaIFFJslntyIJzI5ib9mkBSIG4PwZva05puoHUy7M pEabutNhW/RY5YkBRR4kyKNSCMUnQ2Gjh3V87QQJtusoB1CZuYbWQDyet8yrM5fTefAkpMXrm Wx1hIi76C3SQGqlwyRjpw740ViSVqRsSO1ybLs0e5EyqXdeYM7uqjmnLftRbF0y3k5dysRq9m fLTA7C+WHf1LNA/cBbFJhGnJJvhcH+Ve/agA3i3kuVlsPHIEozjFfcMLfDJ7szIf0IEbk5sOI 0Qdt4pGQTI10j1jmWKRe6eppieCh6a5aofH6lmnTNEV/sPXC6DvbD06IsvMyHkp5l1tOe8HIc 1kBe1h2WaCyCnY5fmEVVTDBAX+q34iI3L9ZqRn0O58917jYIPElaMdKX5spLX5cjlRMX/B06g FN62rIOiL8wpNyMbOfyXQn+Hxc+qHtckLgOtyhjr+UMtZ/49x/JdfApSHXTmIMDsKuM7rkLSl RT7SThqGLpcBOzTrB2F7M5H/xqfXamezdRo8hiNYodI0aJEVYqN403vQrrLWuekQIQDK6UW74 Rxm8tMGxbnZJ03i1ZdShHW99mqMRwll4m8fdPUAZzMcpdOtQaOZocW5g0eJPIxIwsaDUd4YaR iAeAZnd3WH9pFXKjjogmf/muupoXR1ORh2cU0ngnLHJ28R+HleBsmFKWOTwCIY3d0QyIkTxUD H3MjFLIZIo2UTO2vypdaU6eD2zMNoGpwGBNQVrD4Ve8s/s3jk101F52IVmNx1XeDhO1jPAvfI gTgTtb19Rn+arJeYuvkDxMlmcPBURRmZJ8R6pgeiE/4aJxyJxZHheGosYdFlfosc4yp5oDrC0 7OW1/LlD2ZsLPrdZeAqNrkEd2/6VrO/wTBxBKn5DeLZq1x4zeh2WL1L4UO1X9xwqxEsJgawjS sragO+V5xun6pAa0ou19ZFVtNOAjukWDYPpA2714R9AjBNq3uy79kDoVxF6+h6iQjgx7JUK0f 3eVuUeqKzlAn7ltXTzzNKun0jZIW4gHL4GXOEfujlGFpryI/YlfvPpZtc+jzo8NoNAf+OkC/D rRp+FJUzOEsJavSCm3WNyha6m6QBo9s0Rx5shn4AQslyQYFuVuIqVs1ncYZbQXZr5WJBd3/ES vN7tmwU9UGcvlHW1oos5S4wbEucevjDxMP5jJvrnFejxd7b03aSRardj/xvalD3pVdmIt6pgP Nmg+4WKacypdqxrHWHquesMM/BPyiW/Wus8bPC8jrRoevqyV41zW2j7v6CR9SlNT56Rj5hpjS TAIZw1IGtxolPM90jMmf1gclESjognOXACYY9qWg2tY5K13LIEi09yMsGr+5YseUbXsflXLln FsbSP+AIm47aViISj50XOlaZzMtwsobRVffvh0Rc/6jL3AHfXD8OGw8atDH75xpHPAwman4gR JU8GyH7vqy8V2r5M9I0Mke2Mb7oA= X-Patchwork-Delegate: kuba@kernel.org Fix checkpatch code style warnings: WARNING: braces {} are not necessary for single statement blocks #2538: FILE: net/core/pktgen.c:2538: + if ((pkt_dev->flags & F_VID_RND) && (pkt_dev->vlan_id != 0xffff)) { + pkt_dev->vlan_id = get_random_u32_below(4096); + } WARNING: braces {} are not necessary for single statement blocks #2542: FILE: net/core/pktgen.c:2542: + if ((pkt_dev->flags & F_SVID_RND) && (pkt_dev->svlan_id != 0xffff)) { + pkt_dev->svlan_id = get_random_u32_below(4096); + } WARNING: braces {} are not necessary for single statement blocks #2611: FILE: net/core/pktgen.c:2611: + if (t > imx) { + t = imn; + } Signed-off-by: Peter Seiderer --- net/core/pktgen.c | 9 +++------ 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/net/core/pktgen.c b/net/core/pktgen.c index a1268be1edc6..56472d56313c 100644 --- a/net/core/pktgen.c +++ b/net/core/pktgen.c @@ -2535,13 +2535,11 @@ static void mod_cur_headers(struct pktgen_dev *pkt_dev) htonl(0x000fffff)); } - if ((pkt_dev->flags & F_VID_RND) && (pkt_dev->vlan_id != 0xffff)) { + if ((pkt_dev->flags & F_VID_RND) && (pkt_dev->vlan_id != 0xffff)) pkt_dev->vlan_id = get_random_u32_below(4096); - } - if ((pkt_dev->flags & F_SVID_RND) && (pkt_dev->svlan_id != 0xffff)) { + if ((pkt_dev->flags & F_SVID_RND) && (pkt_dev->svlan_id != 0xffff)) pkt_dev->svlan_id = get_random_u32_below(4096); - } if (pkt_dev->udp_src_min < pkt_dev->udp_src_max) { if (pkt_dev->flags & F_UDPSRC_RND) @@ -2608,9 +2606,8 @@ static void mod_cur_headers(struct pktgen_dev *pkt_dev) } else { t = ntohl(pkt_dev->cur_daddr); t++; - if (t > imx) { + if (t > imx) t = imn; - } pkt_dev->cur_daddr = htonl(t); } } From patchwork Thu Apr 10 07:17:47 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Peter Seiderer X-Patchwork-Id: 14046001 X-Patchwork-Delegate: kuba@kernel.org Received: from mout.gmx.net (mout.gmx.net [212.227.17.21]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 963E820E309; Thu, 10 Apr 2025 07:18:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=212.227.17.21 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744269499; cv=none; b=ICbvWLWaR7y4BnhNSR68Kjf+xTEnZloQfdRdo7TquXonBEJ1w80+lggGQVBtZq/MCpIvHVc49g20OomOWO1M1WEOJwKekW3NpePfdoGxUD+f6/KccWBKM5ODbVlSv587qm4+dXjPMbH0KETmGCzkx7585PAujssWtbv2vA3Zws4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744269499; c=relaxed/simple; bh=5snIeQHYhrmxrByOJHCnvEq6FwIapMi+d6Of6zeuQvc=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=ivEOhXHXUwiPSFLGullT0nrB9pylvC1hV9LQhF7ti/NuafG1BGGqNZ8So+r7UfTJeboOzGnOrtKY1VTl0gaHJIUjrKZVMrt5Wltf0zHsnX5H0ALVSl/LlQ7U2F5wc5gsIdH8UPj8l6NxFW28nc24Ag6lxmxGy8rwIRqrgwxCTo4= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=gmx.net; spf=pass smtp.mailfrom=gmx.net; dkim=pass (2048-bit key) header.d=gmx.net header.i=ps.report@gmx.net header.b=IaB1NQTd; arc=none smtp.client-ip=212.227.17.21 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=gmx.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmx.net Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmx.net header.i=ps.report@gmx.net header.b="IaB1NQTd" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmx.net; s=s31663417; t=1744269484; x=1744874284; i=ps.report@gmx.net; bh=5snIeQHYhrmxrByOJHCnvEq6FwIapMi+d6Of6zeuQvc=; h=X-UI-Sender-Class:From:To:Cc:Subject:Date:Message-ID:In-Reply-To: References:MIME-Version:Content-Transfer-Encoding:cc: content-transfer-encoding:content-type:date:from:message-id: mime-version:reply-to:subject:to; b=IaB1NQTdfMV9ExVaHpEvFNRtVGp/EugHSDlFQOwUeaR2FHT55AGniPbNd21LyrFp Zl7ITa5uTG7dYe0k3orrq0QPPYiKHQSFUc2wNEv/irc0I0KCyyLnGgnoMQRRun1w1 c9NSOvX0pN2hrYNji8DcPZyBtVJS6x+LJjEYWtIw4IZeEnFk/zNMh73OFLZy2EDaF D/nk+8006aUW5EVLAq935kAH3EV90KHrZs76zOIOi06uWESnE/zAR5HlZWGDQ0K6z 9FgHmA2H2WZC4X4PXybhIUTHczfNs02iE0oSdZOVNgP/qogVNq+RUvJSs8l6afgIU Im88zIF6pKhYi6wY+Q== X-UI-Sender-Class: 724b4f7f-cbec-4199-ad4e-598c01a50d3a Received: from localhost.fritz.box ([82.135.81.74]) by mail.gmx.net (mrgmx104 [212.227.17.168]) with ESMTPSA (Nemesis) id 1M4Jqb-1u2VBt0QIz-000U1r; Thu, 10 Apr 2025 09:18:04 +0200 From: Peter Seiderer To: netdev@vger.kernel.org Cc: linux-kernel@vger.kernel.org, "David S . Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Simon Horman , Peter Seiderer Subject: [PATCH net-next v1 10/11] net: pktgen: fix code style (WARNING: quoted string split across lines) Date: Thu, 10 Apr 2025 09:17:47 +0200 Message-ID: <20250410071749.30505-11-ps.report@gmx.net> X-Mailer: git-send-email 2.49.0 In-Reply-To: <20250410071749.30505-1-ps.report@gmx.net> References: <20250410071749.30505-1-ps.report@gmx.net> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Provags-ID: V03:K1:cShGLuAELr5fW8iK2NyAiJ8p7G5Io6wMAFcctVfirXqUKO7xwpC DxHIUgM9OnpPDRAbRqDgL5HdfmqzxLPTwYdJ/hSG2M8BrGAXwwZA1jFHI0ascko3eofeQtm eRR7bjR6OR2ytOtXW1q7foiasn4QN36ZQL0YZIvzSOhaHaSD3VMlBe4+FK77IOhs+BvH5QG CsHcBFT1ADmqLTT2MNsdA== X-Spam-Flag: NO UI-OutboundReport: notjunk:1;M01:P0:0gsCMVcZOzA=;zfdve+7nc45L0ygYqQ0PFQXWFsp qYb+NYAPvwAeKUrc74xO5t+jhkTfDtY6WGPe9AMkuolml8SnIVJMIQrZSKANw9XcwzCPVdeOV 61xz9y6P/MkroxB6TEcWPuNXhVav8DooCPVBIvBEB3eFaYsxcz+1+YXuMO9gpuqF4dl6cRmFh bIeeQ6s2TjY5eY4tWwAIF8khOFg2TMsCNZ+HJWcNH+MSmoVwmSKfdBiI4zEPnjd5sIaya/Ozw EmUEJOd2ziyFZYPBc+dB63/c9khN6hh723x0O4F5+NtHij4xSxLkqNsRWOPUvYuYaA8rk0ERO iOII9LH2FFTcV6bhrZtPS91hO7wxa+SXbFwdrvEEpDy+94iMF5nFmpcj+ork6a1k3kF9aZO3B xWdhfdqjp3zmtDaS4P2lmEYjr2NVbNZj7JJNzaLVDWSWoTQ+Syo3pb66ASrIoBdlFf/7mM72e WEwYPoZqDmcUUW4+Q2iC1XVHtHLTNr7er7Bm1RrP6s3Ap6kJAehZ2gTPfPPixxeZSBEdnDBbm dRt86i0Jqf/T4JgxAt59P8e2kcovmb17aboHmzZAOVWL6St027ORU6KOZPxPjad5WGcVxXPs1 BNFPV1RN5+mNv2MsrVpaRbJ+PUKBs/2BYWusSFBGZ096IKGT1vL58Y2un8NtuFcwgYIX459cf AvC9Us9JulwJaYMRkkpM5cBwVfTj8mpkouxJnZhm+V++xBk3bCB773BrgT0yGSZ3yK6xhoVZS HgSMj7HVX/Ymf+PZ6hYr5I7eGnatpmBXHrY9YLOKhWLz15sZyEjtCmdyiuwpCPX3RMg/KeU36 lKdnKewf9zrdck5BWHTfrZmi6o2W9j/a5whkS9i5r3SAP4rGIjAnqFVHpCA6Noaqi1XvB+imt wbBE6z8NI+6lI4GX/3STW0E8qJZldD4/KGpMR9uk3oYz+PaeHGlZp2ew8AGnUQ70jvXRAc0CH Yld/HlhbOUzpzMrEEWmTXSZpgnp+SCTHbGsdtP5Kw5fswG2Y1lgXIf9XRZPeatLluxI0Opk0G 6Kxy9pGHSydG1SOdZBN9U9outqc54KZVXLcQqcQO02Gv0HCMLYBVkSef/odNx0XHBdwpqX/57 coiyMI2Yl488cUrnOIWC0NIzCwln8qrBWeRGTdHCN+ujBzCVRmdpyag4VgnkounLWJYvOksZo KJyNoVr7KFaXvGRBD3zus+M9evVnm8gmxDy0KLEaOeR2QPqgcq+gYye+hQ9zfSUXfpRKScpCm n4qN5eCK2R2VKfBxZmsP4xtpUuWcfUk2aWmfu2hczZnYxXMvUTwvP5doHdm+gTqC9m8a8ZFR8 iCl9WRjty6Dc6b11NMXr4HnIIoVuFXPpg7CP0SrtA6Cd+ff2y14Fqw2xbqB7NhjCgcnnjB0zK rGHjxAQsi8ZTWUg7wHldzzY4635vcqoZC6nwR2lBOFJOE+Hz0jtrZU7T/TfEkbH2gNavBHwwO MdkrDonQohaMnLckp3jGUhRvhgDA= X-Patchwork-Delegate: kuba@kernel.org Fix checkpatch code style warnings: WARNING: quoted string split across lines #480: FILE: net/core/pktgen.c:480: + "Packet Generator for packet performance testing. " + "Version: " VERSION "\n"; WARNING: quoted string split across lines #632: FILE: net/core/pktgen.c:632: + " udp_src_min: %d udp_src_max: %d" + " udp_dst_min: %d udp_dst_max: %d\n", Signed-off-by: Peter Seiderer --- net/core/pktgen.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/net/core/pktgen.c b/net/core/pktgen.c index 56472d56313c..0d18fd932ed9 100644 --- a/net/core/pktgen.c +++ b/net/core/pktgen.c @@ -476,8 +476,7 @@ struct pktgen_thread { #define FIND 0 static const char version[] = - "Packet Generator for packet performance testing. " - "Version: " VERSION "\n"; + "Packet Generator for packet performance testing. Version: " VERSION "\n"; static int pktgen_remove_device(struct pktgen_thread *t, struct pktgen_dev *i); static int pktgen_add_device(struct pktgen_thread *t, const char *ifname); @@ -628,8 +627,7 @@ static int pktgen_if_show(struct seq_file *seq, void *v) seq_printf(seq, "%pM\n", pkt_dev->dst_mac); seq_printf(seq, - " udp_src_min: %d udp_src_max: %d" - " udp_dst_min: %d udp_dst_max: %d\n", + " udp_src_min: %d udp_src_max: %d udp_dst_min: %d udp_dst_max: %d\n", pkt_dev->udp_src_min, pkt_dev->udp_src_max, pkt_dev->udp_dst_min, pkt_dev->udp_dst_max); From patchwork Thu Apr 10 07:17:48 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Peter Seiderer X-Patchwork-Id: 14045999 X-Patchwork-Delegate: kuba@kernel.org Received: from mout.gmx.net (mout.gmx.net [212.227.17.20]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 65D7D20E316; Thu, 10 Apr 2025 07:18:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=212.227.17.20 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744269499; cv=none; b=QcV/N7145EylGrgFKmDQD5L49fcDOVEL43OzLoTwkQkBngoAkildw0//uYQ5AabuzuyQ6SiC57/N41CyGH6brIE7IUT+k/i767zd9tQtiNg4WVjQhx5P9hRPdSrZkRt45Gp/U/xIVZcDZClf6H6C8OWdHl5tk3yo8BeIY/UI/oY= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744269499; c=relaxed/simple; bh=QHFMGT7825aLf9CCNjJ13QgmK6RJ8FFKkBaM863mKyk=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=qM4dbjNUtawyJtpjeX4tuxPLTop1Vm+Luwpcfqg7+8HjdN4jBh7F50FZX5AP/XGF2uPLmf0NfNvGzLSGy3Xodsy11k+wmazK9aNSkAUHvoCm9JChdkcGy8wYmzPvECbJ1boCO72pz+3anTB5Gj+YE6EH2b6jmuTESsbwZc5fJAc= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=gmx.net; spf=pass smtp.mailfrom=gmx.net; dkim=pass (2048-bit key) header.d=gmx.net header.i=ps.report@gmx.net header.b=SPsPSUQe; arc=none smtp.client-ip=212.227.17.20 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=gmx.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmx.net Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmx.net header.i=ps.report@gmx.net header.b="SPsPSUQe" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmx.net; s=s31663417; t=1744269484; x=1744874284; i=ps.report@gmx.net; bh=QHFMGT7825aLf9CCNjJ13QgmK6RJ8FFKkBaM863mKyk=; h=X-UI-Sender-Class:From:To:Cc:Subject:Date:Message-ID:In-Reply-To: References:MIME-Version:Content-Transfer-Encoding:cc: content-transfer-encoding:content-type:date:from:message-id: mime-version:reply-to:subject:to; b=SPsPSUQe7J69mO4qvsV5jGcZQeDcF0LCydFPE+NWw+1zszmy2rClVkMwaCEa+J3c s+pAL/JpwfpDEKzukMpUOkfZqBP3sxQl5VKnaiIM3ZY1U4VFd75WYZq/PHVU8eFyJ yw5+GsAwqfHEV5BKIalfk9lFntA9cQE84C+M9/Z1NI6/WWBtUBGaUC8yJ0NqIhDU0 tPLsKdNU3Jsb8lqJb4Roh8zRSovpNRRBmqH64Rhp0C4Fls2QBZL3W6/2ThcPNyaXu MNDpFC4W6auvvxDOTtiI5lRptaBB9pBULVwQci6Ggr7cExrnHRhrSoSjB9hNgDCkH bgWMwyYVtKp99+KrjQ== X-UI-Sender-Class: 724b4f7f-cbec-4199-ad4e-598c01a50d3a Received: from localhost.fritz.box ([82.135.81.74]) by mail.gmx.net (mrgmx104 [212.227.17.168]) with ESMTPSA (Nemesis) id 1MxDkm-1t9q6e1XQG-00xQNG; Thu, 10 Apr 2025 09:18:04 +0200 From: Peter Seiderer To: netdev@vger.kernel.org Cc: linux-kernel@vger.kernel.org, "David S . Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Simon Horman , Peter Seiderer Subject: [PATCH net-next v1 11/11] net: pktgen: fix code style (WARNING: Prefer strscpy over strcpy) Date: Thu, 10 Apr 2025 09:17:48 +0200 Message-ID: <20250410071749.30505-12-ps.report@gmx.net> X-Mailer: git-send-email 2.49.0 In-Reply-To: <20250410071749.30505-1-ps.report@gmx.net> References: <20250410071749.30505-1-ps.report@gmx.net> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Provags-ID: V03:K1:ndIQyKXD72T7ZtrQT18eDtqgwfyCjLsquOJhoZkuZs0nCfo/ToB nlebgxxesCvHrvUA3kw0WhY2oDDyHjI/tzl350KAzOMbxp8XSz8qb7yn06bdWg5qYhdHFuT qoPDo0EpLYJH23i36rCZAH8pNyzcc7MRmVA2q8rcV99g2RQRBUo3FEI7O2L245QYAqHqfif TR4uqTuNQO6sWjNesmsQA== X-Spam-Flag: NO UI-OutboundReport: notjunk:1;M01:P0:VqfOQYDHX/4=;dkZZXsXi1ra7wYudIvAVEDmeSas XTAmOHYf8quG/HY0kyRphV74+djWeDPE2FCFRZa9qmfZu+09UOmSMvOnKhlygbsK4/L8pVt2L M8StHIaVdCmRUYiZgZCEZ/78XoQ+87MdmBvrs2Q9GUfru6czt1Q3lJGfFQ/kYxoxVHUNq2fCg qp2USA1C6d+yt0bR6YxsyWOBWueCABwt4+s/p3XSbHYtRkYQIdI7ZPX9tz2CinrS1PLNuhLCP u9d1RWYACgTzIG+hU7tkOrSzvZyfJwsU2aYvhOqdiNSs0qsJftdI3PVDvnENhSrl+3zpWW7lK jmZXHoQsYOxRLGB2pdAIVNd54hajK0zkLp4TrGYhIr6oOwO+CSoWGZ1VkcABCWB3n4E9ev2tw jLHa7rHu7Y65i0TtzRQJfckbkVH9iklBtSXK3AoMvOpHUoc2W9SVP4QgHl/acaZEajeidbZcp wvZ9kmwRceXOzbvEkRcghZfHEDgnD6xIJitryDAfgnuP4ZHwSytg7LutVEzDFmQfH706zCvFU 5hxENTo1Ul0GMV8Kna4eNVDzshgaYy4HqAdFqFgM4zK9VRlJNUCfoNB6uSknZ/QL2pKgpcMyc ABg1K6Qh2sGctdjzTgmSH19s6wUvcLoTClo+guaKPPm9TYfRgNqgGlNpCJD6elmWgqcoOrr1M BjBaXsBUHidRFOVD1kOT39aKMrvuVaiBy/i120zIggIHJ1VlujjELptt0giK0O1lbZ0KHD5v3 WkcBSzZPp/knsmsut2daBuIpDLDGFP8Kj768044QiPTJ8L2gcQmWUR7dQ/63xf110CjZvHHd6 NFnLzExyrnAf8qbgBc8Oln8Ofitls8q+RN9kkctVuL+q9//7TqklmjPzPEfRBpqxv53pHNqIo WMpdyh1u+LjLakUm2PZFsS81nrKnCTXUz1IIGTexUp3vi04/OB6D/CGhoXZlCNs/u5ikz+Pvs uCaiObywkeX1lTGo/I21FkobbDcKplSiy2VmaIfKNUVevUDGwvhWWHUaC3ljL8zPZIht1eZEK HO9/dC+yVqZuB14vkIyHmXcoKF4sJdzbg8VIxLJy7bDLSNj5z/WBe6HIb9ThZF4CjubSCfZmQ FABmAaq1tWhdVb4KQ4D41z4/P+A1tHk/7JQytLsiS8Ed1JX6LVWdjQ9ky6X6btS2HyYDmQEqB Ia7L3SVseAde6kHGTSy0Ecazui0fRglnJUnI3shGR5jvy2+xpJvZ4hrZWHZir7+GWcth33wTh UeT0c9Dbk1Pio/vcVzA5lnP2yfIDkkXobBiKLbnMD3X/A/er18LPP57DGuOAlGNdgYuYt8VMp GlFWOhoe/vMMvOEbnxshfMQzoVKSYXXt+iUge/8R+lOGamRZwaYQ+kYIpuH5YZrhjCJHrhfXx fI3Vd/ke/s5zI1mvQtuxdtRMEb9daDkalpKv8MzC8xLBJ4lj2CQOQ/o21dh44LIgwVaufA0vU J1TXYhSqQvj+bBhU2dLt1WMKaavwOVTrBAosUVIqxelslbovCmp49S/Zb+9EhsPjWgOPy9w== X-Patchwork-Delegate: kuba@kernel.org Fix checkpatch code style warnings: WARNING: Prefer strscpy over strcpy - see: https://github.com/KSPP/linux/issues/88 #1422: FILE: net/core/pktgen.c:1422: + strcpy(pkt_dev->dst_min, buf); WARNING: Prefer strscpy over strcpy - see: https://github.com/KSPP/linux/issues/88 #1443: FILE: net/core/pktgen.c:1443: + strcpy(pkt_dev->dst_max, buf); WARNING: Prefer strscpy over strcpy - see: https://github.com/KSPP/linux/issues/88 #1553: FILE: net/core/pktgen.c:1553: + strcpy(pkt_dev->src_min, buf); WARNING: Prefer strscpy over strcpy - see: https://github.com/KSPP/linux/issues/88 #1574: FILE: net/core/pktgen.c:1574: + strcpy(pkt_dev->src_max, buf); WARNING: Prefer strscpy over strcpy - see: https://github.com/KSPP/linux/issues/88 #3227: FILE: net/core/pktgen.c:3227: + strcpy(pkt_dev->result, "Starting"); WARNING: Prefer strscpy over strcpy - see: https://github.com/KSPP/linux/issues/88 #3231: FILE: net/core/pktgen.c:3231: + strcpy(pkt_dev->result, "Error starting"); WARNING: Prefer strscpy over strcpy - see: https://github.com/KSPP/linux/issues/88 #3845: FILE: net/core/pktgen.c:3845: + strcpy(pkt_dev->odevname, ifname); Signed-off-by: Peter Seiderer --- net/core/pktgen.c | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/net/core/pktgen.c b/net/core/pktgen.c index 0d18fd932ed9..3f76cae9cf57 100644 --- a/net/core/pktgen.c +++ b/net/core/pktgen.c @@ -1419,7 +1419,7 @@ static ssize_t pktgen_if_write(struct file *file, buf[len] = 0; if (strcmp(buf, pkt_dev->dst_min) != 0) { memset(pkt_dev->dst_min, 0, sizeof(pkt_dev->dst_min)); - strcpy(pkt_dev->dst_min, buf); + strscpy(pkt_dev->dst_min, buf); pkt_dev->daddr_min = in_aton(pkt_dev->dst_min); pkt_dev->cur_daddr = pkt_dev->daddr_min; } @@ -1440,7 +1440,7 @@ static ssize_t pktgen_if_write(struct file *file, buf[len] = 0; if (strcmp(buf, pkt_dev->dst_max) != 0) { memset(pkt_dev->dst_max, 0, sizeof(pkt_dev->dst_max)); - strcpy(pkt_dev->dst_max, buf); + strscpy(pkt_dev->dst_max, buf); pkt_dev->daddr_max = in_aton(pkt_dev->dst_max); pkt_dev->cur_daddr = pkt_dev->daddr_max; } @@ -1550,7 +1550,7 @@ static ssize_t pktgen_if_write(struct file *file, buf[len] = 0; if (strcmp(buf, pkt_dev->src_min) != 0) { memset(pkt_dev->src_min, 0, sizeof(pkt_dev->src_min)); - strcpy(pkt_dev->src_min, buf); + strscpy(pkt_dev->src_min, buf); pkt_dev->saddr_min = in_aton(pkt_dev->src_min); pkt_dev->cur_saddr = pkt_dev->saddr_min; } @@ -1571,7 +1571,7 @@ static ssize_t pktgen_if_write(struct file *file, buf[len] = 0; if (strcmp(buf, pkt_dev->src_max) != 0) { memset(pkt_dev->src_max, 0, sizeof(pkt_dev->src_max)); - strcpy(pkt_dev->src_max, buf); + strscpy(pkt_dev->src_max, buf); pkt_dev->saddr_max = in_aton(pkt_dev->src_max); pkt_dev->cur_saddr = pkt_dev->saddr_max; } @@ -3224,11 +3224,11 @@ static void pktgen_run(struct pktgen_thread *t) set_pkt_overhead(pkt_dev); - strcpy(pkt_dev->result, "Starting"); + strscpy(pkt_dev->result, "Starting"); pkt_dev->running = 1; /* Cranke yeself! */ started++; } else - strcpy(pkt_dev->result, "Error starting"); + strscpy(pkt_dev->result, "Error starting"); } rcu_read_unlock(); if (started) @@ -3842,7 +3842,7 @@ static int pktgen_add_device(struct pktgen_thread *t, const char *ifname) if (!pkt_dev) return -ENOMEM; - strcpy(pkt_dev->odevname, ifname); + strscpy(pkt_dev->odevname, ifname); pkt_dev->flows = vzalloc_node(array_size(MAX_CFLOWS, sizeof(struct flow_state)), node);