From patchwork Fri Apr 11 14:36:41 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kurt Borja X-Patchwork-Id: 14048461 Received: from mail-pj1-f41.google.com (mail-pj1-f41.google.com [209.85.216.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8C8871607B4; Fri, 11 Apr 2025 14:36:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.41 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744382218; cv=none; b=QHN5oeK2l3HkwkMDnltFgBLeGs9fQbn4lhk5NOr4Eh8u6E9gGJVfc2eusCvTV82QmEMgGdGNraRGoZ+jUy+TXyqss1GVFtDrWJU60YS9zMMzzruBm1K7ZPY0lAC6XWZHEJA9hL9J/xQOYWqc2gwQqOxb5TmWx9AjuFGC9+oh6Z4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744382218; c=relaxed/simple; bh=SrM3/nW46b/Up1uYmcAJVJKRqJerTsXY35JIMkLNcaI=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=ncrS2ZQwX2/OFMN+sil8RmGQ5DfPsHtVvZyybrypPCLfeEROvI2nkcoFhf0WcOTHlVcJFqbfc5JCKpkVzWI2NpD96VEhUSBYmASZmAE39a7m7PZ6mWIo/HQRaim/qtSy9wZSQj7xwOsTvzi4jMxKE4irQnHmBl/ejm/9hN2yYW4= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=TRQELaie; arc=none smtp.client-ip=209.85.216.41 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="TRQELaie" Received: by mail-pj1-f41.google.com with SMTP id 98e67ed59e1d1-30820167b47so1515126a91.0; Fri, 11 Apr 2025 07:36:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1744382217; x=1744987017; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=JmStyPiy4hw3LWA0hjvsecRLO8wk5l4wDE5cpFveI9w=; b=TRQELaiebilzLX7u+LFHGi3VE/Osa8L4KlvsbnSM0YViPXq/tz01hPrJvg4NkGJlhE GbCLzcCBh1IF2Yc8ddPfW1fS4M1gB6vmtHGZs5o1RI9U5UXMcFZ2L6Veiak7hV9Pyiqt /4+IASP/l5gPzeQRekFIJ5O7yKQvNMbvhZWyQyYPkMCElS+Z7tEap5+KSABQNHoFGriX dGgbbMv8XQykTspdMNJcElQPexLO3cOdGFC0MWxyxJLrnVM/0s4Isnrh81emDFyoSlsw 4vev6nAdij2ABcJxNZDd2s4kb8jyEZSqLkmFgKEkOIjU6VVFAlZoBEknhLjQHbpWy0ZB EMNQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1744382217; x=1744987017; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=JmStyPiy4hw3LWA0hjvsecRLO8wk5l4wDE5cpFveI9w=; b=Xo8QJ6NLcw49oo7yiJoDskOKslK0jSVMkV6dCO1cCOVMYYmqnO4ZKf0xdV/G+apqCk qYj2U/ZOqbx3YwD8wU58/6MUO08IsfxyWTflMnNwa9eX+B+mpY/CpuJ7ztsbgOp9VjNd NX2VhWnB9wRwuNUkWp+HUVnYBA5lE3ksKk/tvjAJQVPQv5W/PWR9DWaPkAWRovmVEOSM y/LmHu7Swo+XeUY+zIVLosIajweyLFNxwP7c32WDo/LhuVgZfLVFzHcDMWXhfMBqHvuq 6jzlJp5XX73FFF5ywImWESPzYeVnbspazX34nKmGw1lJESQ/hs6Y5fdfHWwZiPk0ASGE tIMA== X-Forwarded-Encrypted: i=1; AJvYcCVbWPusIVwO0jeMcJgxiwsKSSWG7yUCkxKv2YFJwW7l8zzgQ6d/svkk4OaR5bYIJkUOCfMQjJJ3NNBsWq8=@vger.kernel.org X-Gm-Message-State: AOJu0Yz30pupRiiziU4bVLQG+QumDmCVqFt6bfdyQ4v410C4UC9Qk7i3 cd8X5NS9ZBVI36KS8l2xRqEACH9R4jIos7Ab8ZguENf9/wXdutcy X-Gm-Gg: ASbGncsFHtTwPgqFPV8BZEy0YeAcIvWgwePwEmxfzzGVkLjMnbgP5xFUUAlbtZH+35j IHNF/oIc1PrnShSRDe1rCwwWT6XX4KwdgyWIbHtAvwLH9vn1SVl44P+4N3sSnntfcWtz9UiTF5g ea2zjDRsvPdL/G7OAo8lpLEeXzyaWdSRTDiITSY9EPwO+N/03eDUbWAwzuCXJUFgRqJiq3f0VuB SLokuz4nTjYL9/f3qVXxbePAwpgc+IpanzNcn5t2h/6aY3lX+GZH9lPeUE+0j6Wi++NN/4oCR2j 5bK7QiX4pVk3p9KqREhpajuSX4r69xN/1RvAwWGN X-Google-Smtp-Source: AGHT+IEPpzHRyCtkekhPOaZLwY2OqbUef4IqAFen1PMWIynzEewjeDHUOYVEVgWaguQ5f5cyn8PgZQ== X-Received: by 2002:a17:90b:5608:b0:2ff:5267:e7da with SMTP id 98e67ed59e1d1-3082362265bmr4491874a91.3.1744382216799; Fri, 11 Apr 2025 07:36:56 -0700 (PDT) Received: from [192.168.1.26] ([181.91.133.137]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-306df06a14bsm5630754a91.1.2025.04.11.07.36.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 11 Apr 2025 07:36:56 -0700 (PDT) From: Kurt Borja Date: Fri, 11 Apr 2025 11:36:41 -0300 Subject: [PATCH 1/3] platform/x86: dell-pc: Propagate errors when detecting feature support Precedence: bulk X-Mailing-List: platform-driver-x86@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-Id: <20250411-dell-faux-v1-1-ea1f1c929b7e@gmail.com> References: <20250411-dell-faux-v1-0-ea1f1c929b7e@gmail.com> In-Reply-To: <20250411-dell-faux-v1-0-ea1f1c929b7e@gmail.com> To: Lyndon Sanche , Hans de Goede , =?utf-8?q?Ilpo_J=C3=A4rvinen?= , Mario Limonciello Cc: platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org, Kurt Borja X-Mailer: b4 0.14.2 The dell-pc module only supports the thermal management Dell SMBIOS feature, therefore it is pointless to have it loaded if this is not available. Signed-off-by: Kurt Borja --- drivers/platform/x86/dell/dell-pc.c | 12 +----------- 1 file changed, 1 insertion(+), 11 deletions(-) diff --git a/drivers/platform/x86/dell/dell-pc.c b/drivers/platform/x86/dell/dell-pc.c index 483240bb36e77d2118dfcbd6bf271e12e82e042f..38f198a7330006333b01787a9934b8eb146ce75e 100644 --- a/drivers/platform/x86/dell/dell-pc.c +++ b/drivers/platform/x86/dell/dell-pc.c @@ -146,11 +146,6 @@ static int thermal_get_supported_modes(int *supported_bits) dell_fill_request(&buffer, 0x0, 0, 0, 0); ret = dell_send_request(&buffer, CLASS_INFO, SELECT_THERMAL_MANAGEMENT); - /* Thermal function not supported */ - if (ret == -ENXIO) { - *supported_bits = 0; - return 0; - } if (ret) return ret; *supported_bits = FIELD_GET(DELL_THERMAL_SUPPORTED, buffer.output[1]); @@ -255,16 +250,12 @@ static int thermal_init(void) struct device *ppdev; int ret; - /* If thermal commands are not supported, exit without error */ if (!dell_smbios_class_is_supported(CLASS_INFO)) - return 0; + return -ENODEV; - /* If thermal modes are not supported, exit without error */ ret = thermal_get_supported_modes(&supported_modes); if (ret < 0) return ret; - if (!supported_modes) - return 0; platform_device = platform_device_register_simple("dell-pc", PLATFORM_DEVID_NONE, NULL, 0); if (IS_ERR(platform_device)) @@ -297,7 +288,6 @@ static int __init dell_init(void) if (!dmi_check_system(dell_device_table)) return -ENODEV; - /* Do not fail module if thermal modes not supported, just skip */ ret = thermal_init(); if (ret) goto fail_thermal; From patchwork Fri Apr 11 14:36:42 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kurt Borja X-Patchwork-Id: 14048462 Received: from mail-pj1-f47.google.com (mail-pj1-f47.google.com [209.85.216.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CA2311F866A; Fri, 11 Apr 2025 14:36:59 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.47 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744382221; cv=none; b=R5Q4BcbzW25g9hQpdNlK8Gcy6oPNgtoRhXob0/pObvAS1I1T0y6ont/DQd8iBmW/rkOXj5lomMeKEvESrQdyKStuDt8bU0fsAfGbM0s1j7IFu4qgiqIi3TyAWHhjEDWEZUpbltqgROQzzCPxrJlzZhffZgdP3h7GiRlxaKuMn1c= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744382221; c=relaxed/simple; bh=4EGh63XRuAuHB8a4onBFSdynXxbrJNaPSvsOKaz9hpQ=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=vGY5zBAz1Oe26NPFyF//Jo2HZl215b47cGApBlV6UYh1DfwEnnZtbX95zYu/fYcswmwhAn2JEe72bE12xgOcpuAo3TUbi0tF8d2dzzNRlQfc+IXXEk2XrmJuUi7QjOJyaA/mNStxVzQduL9i7857VlcOPCJAejpyxTMtkhoyVHg= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=h22/21C5; arc=none smtp.client-ip=209.85.216.47 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="h22/21C5" Received: by mail-pj1-f47.google.com with SMTP id 98e67ed59e1d1-301302a328bso2038919a91.2; Fri, 11 Apr 2025 07:36:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1744382219; x=1744987019; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=XqTAVted7iqBPlcImi6frgF4C0JiTn/d3SQ/Bon2Kfk=; b=h22/21C5iBTi7aZaAG9Iia2hCMX8V48pzFHX5BGbH24VVncUFLOkyOLQkv8ZLTq2oJ JG5ywu08wUaGp67pT2x6GvF2IrFV1VTCriEjPZBtVCodOaduCXn0ZRGAclZdduNi2p20 2TOxD+CiPCFa3S8j9aTALv7lhD5yFFeVxYJrziJzaPr4Z/EH5/G4VaUkTb5XncLajO9J ru9tbpw4Q5yJKMf0htyKYKlw4x2yXiwGU0tdvmH8NSeV0eOvIN4r88N5OXV2t78yLa84 BkHW/dRf45RiCKP+xoc00Ulf1Iix8OhVhGQMBVGo3jfeq0yUncWW1NgcWDwTtxqK3tn5 I8Mg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1744382219; x=1744987019; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=XqTAVted7iqBPlcImi6frgF4C0JiTn/d3SQ/Bon2Kfk=; b=OrF9pwys9aBS3xtnlv7gNykxyy3aWSHO2zFT0f2QIjc0+ihWkS0qIW5voeuFxYuRiW +Q8Np3YGnIh4PhgGBzuGQOe2ADBW7L27p4W1ikBN/LF8qSC2C3R4NgXuDQLc09YVcUCd sOal/FnWww2p//OxB1hdhg+2xBPfIhX1Fk8EdWg90YOG3bz0Vu9OCepGr+FWd5E8d7lZ 3TV9yCYWGMgPP5QE4DPO5JZYWz+0Gyx4lUxRzt2TwTR/o9zj7tEy/+Sx87lwssGjYZyY 41p0IoE8BnjctfmOoPajVsHOf3JKsMGAnbSXn4kMy2t1fzvO387tS6e6Z1cRCcaEOasa kY1w== X-Forwarded-Encrypted: i=1; AJvYcCVPo9O/W8/3JEnRoODUpTNkhuSCWa9LR9EqDk1f7S0YqZGCMS9sOxUFDRRztWlTuWj/5QBZAnKGAzev4JE=@vger.kernel.org X-Gm-Message-State: AOJu0YwM3R7D9tUFYogcJ0C9nKRD5ryiniwyJxX20iCH+FLfxartDKR2 ZYx7MqeyakJvgoyGo1fjLLnv4LrGO+nC2Kj2m0bpPUKGNKm1Frt+ X-Gm-Gg: ASbGncuYm5EGn2MAsNfBotlK4EIKbIxUuodCeXN9HVeYapG4XgKPxjQgaLoBNFflz3J VPxqgSHuyUft4xm6Vwgm4VhK0vIWXteuSjm1MQvRCeqnmcsp4rIeevrp5koZEIhooyXOvTO+Zvj 1QYblv68KZsknvupDGaAG+tRkM9BYGfeFIziJPf8E0G9tNDCulLYaKVmn/altPzZmcea/VDkO7d OPcRwLx6yG1BGujLs84Caf9M0JGuCphLI+IOJC5PiCKsKJrI1tAX11ajFUC6A59PNkcJ0JyAFlK DKWZ0TErmEMp6E78PLm6Osr/D4pJFbLSUjPDnZSO X-Google-Smtp-Source: AGHT+IHp1fJp4vdoR7Bp2bZlgPyQkt+WYPsZWerRsS3J0wN3uhGugf3hfcYa1h0FQXbLnsmWiMN31Q== X-Received: by 2002:a17:90b:5445:b0:2ff:5cb7:5e73 with SMTP id 98e67ed59e1d1-3082367ee62mr4132466a91.23.1744382218925; Fri, 11 Apr 2025 07:36:58 -0700 (PDT) Received: from [192.168.1.26] ([181.91.133.137]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-306df06a14bsm5630754a91.1.2025.04.11.07.36.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 11 Apr 2025 07:36:58 -0700 (PDT) From: Kurt Borja Date: Fri, 11 Apr 2025 11:36:42 -0300 Subject: [PATCH 2/3] platform/x86: dell-pc: Use non-atomic bitmap operations Precedence: bulk X-Mailing-List: platform-driver-x86@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-Id: <20250411-dell-faux-v1-2-ea1f1c929b7e@gmail.com> References: <20250411-dell-faux-v1-0-ea1f1c929b7e@gmail.com> In-Reply-To: <20250411-dell-faux-v1-0-ea1f1c929b7e@gmail.com> To: Lyndon Sanche , Hans de Goede , =?utf-8?q?Ilpo_J=C3=A4rvinen?= , Mario Limonciello Cc: platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org, Kurt Borja X-Mailer: b4 0.14.2 The choices bitmap belongs only to this thread, therefore we can use the non-atomic version of set_bit(). Signed-off-by: Kurt Borja --- drivers/platform/x86/dell/dell-pc.c | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/drivers/platform/x86/dell/dell-pc.c b/drivers/platform/x86/dell/dell-pc.c index 38f198a7330006333b01787a9934b8eb146ce75e..794924913be0c6f13ed4aed8b01ffd21f1d34dea 100644 --- a/drivers/platform/x86/dell/dell-pc.c +++ b/drivers/platform/x86/dell/dell-pc.c @@ -11,6 +11,7 @@ #define pr_fmt(fmt) KBUILD_MODNAME ": " fmt #include +#include #include #include #include @@ -228,13 +229,13 @@ static int thermal_platform_profile_get(struct device *dev, static int thermal_platform_profile_probe(void *drvdata, unsigned long *choices) { if (supported_modes & DELL_QUIET) - set_bit(PLATFORM_PROFILE_QUIET, choices); + __set_bit(PLATFORM_PROFILE_QUIET, choices); if (supported_modes & DELL_COOL_BOTTOM) - set_bit(PLATFORM_PROFILE_COOL, choices); + __set_bit(PLATFORM_PROFILE_COOL, choices); if (supported_modes & DELL_BALANCED) - set_bit(PLATFORM_PROFILE_BALANCED, choices); + __set_bit(PLATFORM_PROFILE_BALANCED, choices); if (supported_modes & DELL_PERFORMANCE) - set_bit(PLATFORM_PROFILE_PERFORMANCE, choices); + __set_bit(PLATFORM_PROFILE_PERFORMANCE, choices); return 0; } From patchwork Fri Apr 11 14:36:43 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kurt Borja X-Patchwork-Id: 14048463 Received: from mail-pj1-f44.google.com (mail-pj1-f44.google.com [209.85.216.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D40C41EB5D9; Fri, 11 Apr 2025 14:37:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.44 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744382223; cv=none; b=k0mcS4zY0H55qUoLSouUaY/AKiR94tKE93mJSVK/JGC5xVDCOF6c2GjUXjn2JDFBxlsLaO3pwGrGBQ/ih1KgGofBbHdf46NlljZMdag4g0CaINk9TGYyy+pHFnLw9lY8um4c8a9MUV9usY4Fa8npzw+hE5T24FN3Rwh84i8txwY= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744382223; c=relaxed/simple; bh=Syd1lDbqlM7R+mGNi8fT1pBl5F1yrvGgk0SfomYYKT0=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=m4mc/Piw85ZDSoR2eYDkEBVl15LJw6LgeGPHT8/ZdY0xwp5M8wYj1D0nh1ElhZepr8ZXyUPlPPGD3nac8Ycxdr0Pf8w8jPAeClA5aXVsZUa058RXmMJY1KTkfBWxcvU0XaA93EE8HrIyvjpUil4L7qJxOmxsv9a61QHQ/mKI4JE= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=aPY+zD0u; arc=none smtp.client-ip=209.85.216.44 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="aPY+zD0u" Received: by mail-pj1-f44.google.com with SMTP id 98e67ed59e1d1-2ff85fec403so3089663a91.1; Fri, 11 Apr 2025 07:37:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1744382221; x=1744987021; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=qN83a4vtJr3jkDTP8/AnjFdICARlWdVcbsRDYISkcqs=; b=aPY+zD0uc+rdh8M3LQG7rG3ei0rSqR5kJeDMl2wAlMY4krM4PXFsqsa85JTK8ItDux D6p0PEwztYFqKOzuQvTI6zKi2IW5OW9f/+O6vXSq1jnM0NgMFurWyFZJXa8HRSMGRz53 ABY7bGh2Cl3TShODgKlmk8fFu7AYYt/KsP+wG9YGJY2mOktqvEYogk0xulQjPsG4YvTa isQiVMXpoWFr7M9WhNEDZJ7NMtgdkDrYf2de0kQqHqVMof1mtGG7Y5SN/h7Ctzrl7Lqj Nfhxi0gCZmWT1tiC2W2H27qleX5/YabSRqoqJTfm57GZaw1mL9ZMzEDD2YkHR0GuEFfr gFyQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1744382221; x=1744987021; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=qN83a4vtJr3jkDTP8/AnjFdICARlWdVcbsRDYISkcqs=; b=jgPZaFccPShzczVpuln2TAOwX6JTdls+QpICpbdqH3vEcnXON9ZPTfkJmGmt5+1uwL FkQAHWbpyZBY9xg3Ofh+zbqm68+p+yU2UAze/KcHbIhjc2kYVMYnZKBP6Cw7KpJ0LDYs dVqaJSzHluqNqxFmJzvTnxWWCGuYW3tr3V2VStkY6afIVy1wzlj+6U1OlQ5QunP3+n9N gi+UBgjagLKHV6+BUOyU1FxNZQ/x/mlGVPxqHC1gxgk9r8e/xT1m9qGcCiVa6CvvUu5v 2MB4WwZRjU8bBJaXS7ZafWML+QUi1eLzkFO55d5VbwkNjQM2yXzoTEbFbkfDgAWWoq+H IQ4w== X-Forwarded-Encrypted: i=1; AJvYcCUxGkiTq0+cf8xX7WePjQlG8etv1YE/gZZPH/K1GumEihqaThwPs+H2HRXsPdE+VnHbjc2arpUrQ6yna4k=@vger.kernel.org X-Gm-Message-State: AOJu0Yw0zjVkSWabXhsAZ7POeE5Xf9K3lUIiGoa6nAO9rkNpViAx+wN3 pfDimn6Visz/AgyHVeqEv6L+1WVYYqnwYXSK34QfjP+7x/l9WPid X-Gm-Gg: ASbGnctnzRYgdiNBCoQtc0fCsikIovPs4fE5yz4NzqQKDiIz9R9Vw9ijDlXYsmzL2Ey w9CtY3wDROiwdiIgkwQzUVSHbx82vcstLK/teJcrZ8rIXt9jFbgNbNE1h1NwevhPfTXZ8aqr+0h K0KfteJ4/FqpYTXUVeOG2a8xuQDWj5GEsaxPHeGoHKCw5ASnK5v+Lyo12Zsb1ecX5mBCNUmw/Vc xQIf0JOPuU0SE3KMDOw3zDL/QU4If1piHU0q8s30KQNdgK+3WDoEQf3tvOJ90wF9ZS6eALS+5Mi LSTxrZdt5zVY21OYDQRHtc2pl2KzQg6/UcDDdr+Q X-Google-Smtp-Source: AGHT+IFUf++OgAgcgEE/jllAqe/2xp+HKZXduxPSgKSJzuJy0O2KnPlRozOobSvaE2OdSSt5BeiCYA== X-Received: by 2002:a17:90b:5845:b0:2fa:603e:905c with SMTP id 98e67ed59e1d1-307730fecd7mr10266507a91.2.1744382220922; Fri, 11 Apr 2025 07:37:00 -0700 (PDT) Received: from [192.168.1.26] ([181.91.133.137]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-306df06a14bsm5630754a91.1.2025.04.11.07.36.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 11 Apr 2025 07:37:00 -0700 (PDT) From: Kurt Borja Date: Fri, 11 Apr 2025 11:36:43 -0300 Subject: [PATCH 3/3] platform/x86: dell-pc: Transition to faux device Precedence: bulk X-Mailing-List: platform-driver-x86@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-Id: <20250411-dell-faux-v1-3-ea1f1c929b7e@gmail.com> References: <20250411-dell-faux-v1-0-ea1f1c929b7e@gmail.com> In-Reply-To: <20250411-dell-faux-v1-0-ea1f1c929b7e@gmail.com> To: Lyndon Sanche , Hans de Goede , =?utf-8?q?Ilpo_J=C3=A4rvinen?= , Mario Limonciello Cc: platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org, Kurt Borja X-Mailer: b4 0.14.2 Use a faux device parent for registering the platform_profile instead of a "fake" platform device. The faux bus is a minimalistic, single driver bus designed for this purpose. Signed-off-by: Kurt Borja --- drivers/platform/x86/dell/dell-pc.c | 46 +++++++++++-------------------------- 1 file changed, 13 insertions(+), 33 deletions(-) diff --git a/drivers/platform/x86/dell/dell-pc.c b/drivers/platform/x86/dell/dell-pc.c index 794924913be0c6f13ed4aed8b01ffd21f1d34dea..48cc7511905a62d2828e3a7b593b3d2dae893e34 100644 --- a/drivers/platform/x86/dell/dell-pc.c +++ b/drivers/platform/x86/dell/dell-pc.c @@ -13,18 +13,18 @@ #include #include #include +#include #include #include #include #include #include #include -#include #include #include "dell-smbios.h" -static struct platform_device *platform_device; +static struct faux_device *dell_pc_fdev; static int supported_modes; static const struct dmi_system_id dell_device_table[] __initconst = { @@ -246,7 +246,7 @@ static const struct platform_profile_ops dell_pc_platform_profile_ops = { .profile_set = thermal_platform_profile_set, }; -static int thermal_init(void) +static int dell_pc_faux_probe(struct faux_device *fdev) { struct device *ppdev; int ret; @@ -258,51 +258,31 @@ static int thermal_init(void) if (ret < 0) return ret; - platform_device = platform_device_register_simple("dell-pc", PLATFORM_DEVID_NONE, NULL, 0); - if (IS_ERR(platform_device)) - return PTR_ERR(platform_device); + ppdev = devm_platform_profile_register(&fdev->dev, "dell-pc", NULL, + &dell_pc_platform_profile_ops); - ppdev = devm_platform_profile_register(&platform_device->dev, "dell-pc", - NULL, &dell_pc_platform_profile_ops); - if (IS_ERR(ppdev)) { - ret = PTR_ERR(ppdev); - goto cleanup_platform_device; - } - - return 0; - -cleanup_platform_device: - platform_device_unregister(platform_device); - - return ret; + return PTR_ERR_OR_ZERO(ppdev); } -static void thermal_cleanup(void) -{ - platform_device_unregister(platform_device); -} +static const struct faux_device_ops dell_pc_faux_ops = { + .probe = dell_pc_faux_probe, +}; static int __init dell_init(void) { - int ret; - if (!dmi_check_system(dell_device_table)) return -ENODEV; - ret = thermal_init(); - if (ret) - goto fail_thermal; + dell_pc_fdev = faux_device_create("dell-pc", NULL, &dell_pc_faux_ops); + if (!dell_pc_fdev) + return -ENODEV; return 0; - -fail_thermal: - thermal_cleanup(); - return ret; } static void __exit dell_exit(void) { - thermal_cleanup(); + faux_device_destroy(dell_pc_fdev); } module_init(dell_init);