From patchwork Sat Apr 12 04:36:34 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Ritesh Harjani (IBM)" X-Patchwork-Id: 14048879 Received: from mail-pf1-f173.google.com (mail-pf1-f173.google.com [209.85.210.173]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8EBAB2581; Sat, 12 Apr 2025 04:36:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.173 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744432609; cv=none; b=dS0ZfZyNdvqsGRTetAmI6SF08h3zJWgaWLEors01HtcnUkOwI5XOYNKcph9I7lcPi2wwPikonCmS9dprLBVQk+NHrtk/Zhl5TvN+K1+U/ggEeDmM7j9U1zvYWDjfh2DCx6g41gCa4G4Cv0atm+u7TUFSNEkDd8ZjZV4Nl/Bj8q0= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744432609; c=relaxed/simple; bh=dWpwNE+IEv5xEZqrdy2zX8cbD9eo0N6vof2jy7LY22o=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=JmZoNNGxtGGUcbSwgwKcHoi3W2v8rnVG1IE8/uNS5B2DTKNgXzMqThhTKbtyNbJLH+dEDvp1gE9fZetdWRFkMW7gPfVvg0pKNPvkNDlzKP0Xo9+2Djsu6Kb19qbRt6NyTDDF2wPguafET9UcoOvzOaerJNPdrk2zqtJCvIRtGAU= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Xr0M3GaW; arc=none smtp.client-ip=209.85.210.173 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Xr0M3GaW" Received: by mail-pf1-f173.google.com with SMTP id d2e1a72fcca58-73972a54919so2453124b3a.3; Fri, 11 Apr 2025 21:36:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1744432605; x=1745037405; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=sMzyYTn4WuE4EsdB76LiGyB9L2UxItf7Sltpxk5CpzM=; b=Xr0M3GaWKhQ0JEsq21lQ4dPbDR2fWfau0sVo+6h0ARgGP79qgKpbTwmnbVLM5qvxEz T6ibwTXS5Czf5ZqCXr2J3yF85yq9umn0ia9qg5ua4IQn9uxRvtGacO3FTVzo5tsm1v7L 7nmBfjHhUy82Vlgpxk9WwBFb7go4nMB37/Q0lsfsAnFQchZOWhzoGsoFqg9/RoUHDLoL EVPeybFKubfXg39pc5rRD38HkhfMD7k71B1Zbd8UDOq2riBaxGYEBB9bV8a4D1MTmpJU pGz+Q04eoAe7Np+pYZs7BQhitB64CM7VT8v0x60I2rUBntvJ5qcQRphM9XpTYmqKAh4h kyJw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1744432605; x=1745037405; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=sMzyYTn4WuE4EsdB76LiGyB9L2UxItf7Sltpxk5CpzM=; b=Lw4JwlfAgTH4dlmtzXh7w5Ah0kF6c6QorJZ3G7Mf9O2HguVoVImjhZApNe/PueDRDo 1gOQgxX11sAEaB0ZrkOCartbnKPe2kZT6DtdGVeBI4fbSkJLXVN60XfxrpWfth81vxvb ADAZ/FQP1VTfHfN0Azp0SLS29pZseq7cUAkplmxW5eW2zJSua5/pQ4YCxOM1gsjJ7HQQ 0OrE+9ruV5uolYSQg0+ABI4nu/IzpJ563uQcspWSVraJHu9s5/xrd8vNn4KXZVamrNTb kk+XvQjCIXxWm8ixw9Rn1IlW5DhJIsm9aW3cxYED6GkL1Mw+IvahaCKXt7tBIYh9XrK+ UkZA== X-Forwarded-Encrypted: i=1; AJvYcCVs6bicZiDWFCDwMQi7l3/Hy/zMfQveCCYTCJ8qoh4BFT6gW0Uy95iE35/LSwku8iEGXxCNsKz+tXh4oo5b@vger.kernel.org X-Gm-Message-State: AOJu0Yw/iDuFv8/DKZ2l7ZjKxF7RKQY93UpHB2/LFamPrdsaYDmZIRhJ 5rkCn6qPImiyPix+Nnrn5STGGlrt8RJ6N/1u1T2F4PiEKoZedjjbE55EKQ== X-Gm-Gg: ASbGncsbQJl2VcJepLakHvQTYdzx7hL6oWE4DY91TeXtiwdw4D8nY/C/mvcFjKSEt8J HuHQQDwFN8/6ue4dchR2aZfT8fF7o//wV6I83/PS0ngpAGG4BGQEU3SIJ9Rzphsv9+/iAs5QHM3 V3mHnBSWz9ZPIu9jK6fNs9PvClbjQ+VXg8g9FlT3PR3i7bveyNTwv9Sbb381upka4j91+zvyoGn UYswuzgyXdHxXBGE3YNlCxq4gMzzWs/CRITs0z7pxYMleIO9Af68ggh47kOw9wMPFTTAUF6zqyj /ZSs5N2f8ynxh9bnCxQ4+nKtIwOfVwx4HWPG8f1OtbpurAE= X-Google-Smtp-Source: AGHT+IEgr5KTviOB2Umr9g8y1ydPg/5WYIV2avsiB0hTb4uzPdBkD2czjwUa66AjeJKZjDMfw1csrA== X-Received: by 2002:a05:6a20:e616:b0:1f5:5b77:3818 with SMTP id adf61e73a8af0-2017997314bmr8120745637.27.1744432604556; Fri, 11 Apr 2025 21:36:44 -0700 (PDT) Received: from dw-tp.ibmuc.com ([49.205.218.89]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-b02a0de8926sm4827993a12.30.2025.04.11.21.36.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 11 Apr 2025 21:36:43 -0700 (PDT) From: "Ritesh Harjani (IBM)" To: linux-xfs@vger.kernel.org Cc: John Garry , djwong@kernel.org, ojaswin@linux.ibm.com, linux-fsdevel@vger.kernel.org, "Ritesh Harjani (IBM)" Subject: [PATCH v2 1/2] Documentation: iomap: Add missing flags description Date: Sat, 12 Apr 2025 10:06:34 +0530 Message-ID: <8d8534a704c4f162f347a84830710db32a927b2e.1744432270.git.ritesh.list@gmail.com> X-Mailer: git-send-email 2.48.1 Precedence: bulk X-Mailing-List: linux-xfs@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Let's document the use of these flags in iomap design doc where other flags are defined too - - IOMAP_F_BOUNDARY was added by XFS to prevent merging of I/O and I/O completions across RTG boundaries. - IOMAP_F_ATOMIC_BIO was added for supporting atomic I/O operations for filesystems to inform the iomap that it needs HW-offload based mechanism for torn-write protection. While we are at it, let's also fix the description of IOMAP_F_PRIVATE flag after a recent: commit 923936efeb74b3 ("iomap: Fix conflicting values of iomap flags") Signed-off-by: Ritesh Harjani (IBM) Reviewed-by: "Darrick J. Wong" --- Documentation/filesystems/iomap/design.rst | 16 ++++++++++++++-- 1 file changed, 14 insertions(+), 2 deletions(-) -- 2.48.1 diff --git a/Documentation/filesystems/iomap/design.rst b/Documentation/filesystems/iomap/design.rst index e29651a42eec..f2df9b6df988 100644 --- a/Documentation/filesystems/iomap/design.rst +++ b/Documentation/filesystems/iomap/design.rst @@ -243,13 +243,25 @@ The fields are as follows: regular file data. This is only useful for FIEMAP. - * **IOMAP_F_PRIVATE**: Starting with this value, the upper bits can - be set by the filesystem for its own purposes. + * **IOMAP_F_BOUNDARY**: This indicates I/O and its completion must not be + merged with any other I/O or completion. Filesystems must use this when + submitting I/O to devices that cannot handle I/O crossing certain LBAs + (e.g. ZNS devices). This flag applies only to buffered I/O writeback; all + other functions ignore it. + + * **IOMAP_F_PRIVATE**: This flag is reserved for filesystem private use. * **IOMAP_F_ANON_WRITE**: Indicates that (write) I/O does not have a target block assigned to it yet and the file system will do that in the bio submission handler, splitting the I/O as needed. + * **IOMAP_F_ATOMIC_BIO**: This indicates write I/O must be submitted with the + ``REQ_ATOMIC`` flag set in the bio. Filesystems need to set this flag to + inform iomap that the write I/O operation requires torn-write protection + based on HW-offload mechanism. They must also ensure that mapping updates + upon the completion of the I/O must be performed in a single metadata + update. + These flags can be set by iomap itself during file operations. The filesystem should supply an ``->iomap_end`` function if it needs to observe these flags: From patchwork Sat Apr 12 04:36:35 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Ritesh Harjani (IBM)" X-Patchwork-Id: 14048880 Received: from mail-pf1-f178.google.com (mail-pf1-f178.google.com [209.85.210.178]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9C7E91891A9; Sat, 12 Apr 2025 04:36:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.178 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744432611; cv=none; b=m1t70T3wc3aVkkefAxZYlzHLFvYJacu9JKuKtODAnpVtiDukT752jzIwy8zSHvweKW9LbRpvWXRI1zexoo06BQWbxICvs5cs+csM8dchcFMIrrt7KNdn5tHwE2f8plp+1ZpeTUTpUhBqzR0D2frLvg9kdSSTbcgJZ7f8JdJ4pBw= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744432611; c=relaxed/simple; bh=QY1wKDOkQEl1CFDWXIAC6g+nrvMtAmRCujAFfyijgoo=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=Y9Yv0Ou6qJOpCe94FqvnnM7qEEmVb1PMFp3N+1AsWaESQrNrYV43xO8ryLQ5e8oU4Vk2Sb4pYVt284saEZ9VXlhrjRa1Y0/JenH4rmhePuaAyQ/i2KMkOz+6G6S166uJOxCf0Pk+ggVqimQTkEkNNdQDEj59eACTckfWIwTRo2Y= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=bTOJgBIK; arc=none smtp.client-ip=209.85.210.178 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="bTOJgBIK" Received: by mail-pf1-f178.google.com with SMTP id d2e1a72fcca58-736dd9c4b40so3272786b3a.0; Fri, 11 Apr 2025 21:36:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1744432608; x=1745037408; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=9kMrbL7tcvDz5lUAbPFrHkOsQ+u9gKHcRszVAuDybPY=; b=bTOJgBIKfAVRj2bfOBGnn9M/x0Q4aG1Vm/+7NtR4e1TyfdUalgV92wa/YBBeZ47yNR lf1VSyLbaeUWayRNz/dPW3Qn8fJl9wdc4n3eTNPtXBeByOtaZzqAb29fD/e1f0cU6hX7 S/iB5xHMsaDml6BslrzO39qSOtz5XpbhBIAuDudDfYkR61dr05/GoutYkANobQmh/44H wDK9hzfGFSlD5NaQ00YKkvmv21gsqydmm4XJsjv/G5hrntg1SBnsAjIFLfmw2ZrS2FVa ebka/lBc3gYldqWkYL4LBCWrnN3FEN520JJKNw/6CME1xgz1oyPaX86A5cI4SsIpJzCU 7GTg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1744432608; x=1745037408; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=9kMrbL7tcvDz5lUAbPFrHkOsQ+u9gKHcRszVAuDybPY=; b=Tx0oulUP3ERHW/niOriwj4J7qdfmYVDZhI0SR+JFhuWO14OQ/TlXYtNc9Jeh0aHSxW aIyAAgHOHXN8Sdv7tLXr9iRO3kIKFrptcX/gPRkByIiT8TyckZti+ENnc9/6LgCaBzs2 irshGk/Mtiz1n/fzcxnW9f2DX+qkimMzxLiLXnxftLkd5NFhDaX8TPriY4f2jvCY2Tvu gdABAZyTg/iQLGo6/jQM4jFaKEfa9MYHW3+n/CrnvEclryiVqpkPrFoethph00g2yUWX snxNfAL/ECrQ92E7SEOgY2zBbuRC5PhhSAiT+b1NUa4gi1sc4Y4yK/2EnUaWpoRUTSdO /r+w== X-Forwarded-Encrypted: i=1; AJvYcCXjBfiCHFX/tqF8bmfIlEmOYHEGGybtyBEXmZsezSWn+mtPDga8TzttAUkpwC+1q7zEdmK5Fx9BDlpFo6Rn@vger.kernel.org X-Gm-Message-State: AOJu0Yy4HaLjLySQfnASDT4BTHMyx3VNTPoByc86sUOwIvVmqcd1boHX ODT8R6Iwv2FfF/mqjO0H5m1pjc1x42jpo5vO315O9VWkFSoHNNmZGkDCBQ== X-Gm-Gg: ASbGncsBqppo2iUeaAuDrplxmV6QtlfQvbfrGkbwrDvpqDhnEahoX72TaH9HTtOymm3 mwWGkkmapG6M21LGWqII+3OnkJz+mP01Y+ErvOio9MDgYBtGpW0NV2Pux2Niapuecu/S/Sv2V73 8KFj12wqis1Vth0xId5Sbny4uKP5pllvu3/L8FPeUS9W6OZ7YezjPN7Or9Z+ngk1apeIda0zJ57 R409Nw5feILG8cHhHdzi50v6wjoU9GD7tiUiUzKYcEUUSNnYd6OdS7jhVuils4DQu5su8Hl+s5I fGfiSNplziRWycidJSsaaD5WnXeAMFX9Awq+Zh6oXC0tQJDZOXntWG2RCw== X-Google-Smtp-Source: AGHT+IEirL+fbFsivnxUVPQjJ/lWWd7BF9FTt+vFvXtvuJ6WLMEj7i9MdTqBq9lXrro98T6722jtFQ== X-Received: by 2002:a05:6a21:1507:b0:1f3:34a4:bf01 with SMTP id adf61e73a8af0-2016a283f28mr13103993637.17.1744432607571; Fri, 11 Apr 2025 21:36:47 -0700 (PDT) Received: from dw-tp.ibmuc.com ([49.205.218.89]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-b02a0de8926sm4827993a12.30.2025.04.11.21.36.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 11 Apr 2025 21:36:47 -0700 (PDT) From: "Ritesh Harjani (IBM)" To: linux-xfs@vger.kernel.org Cc: John Garry , djwong@kernel.org, ojaswin@linux.ibm.com, linux-fsdevel@vger.kernel.org, "Ritesh Harjani (IBM)" Subject: [PATCH v2 2/2] iomap: trace: Add missing flags to [IOMAP_|IOMAP_F_]FLAGS_STRINGS Date: Sat, 12 Apr 2025 10:06:35 +0530 Message-ID: X-Mailer: git-send-email 2.48.1 In-Reply-To: <8d8534a704c4f162f347a84830710db32a927b2e.1744432270.git.ritesh.list@gmail.com> References: <8d8534a704c4f162f347a84830710db32a927b2e.1744432270.git.ritesh.list@gmail.com> Precedence: bulk X-Mailing-List: linux-xfs@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 This adds missing iomap flags to IOMAP_FLAGS_STRINGS & IOMAP_F_FLAGS_STRINGS for tracing. While we are at it, let's also print values of iomap->type & iomap->flags. e.g. trace for ATOMIC_BIO flag set xfs_io-1203 [000] ..... 183.001559: iomap_iter_dstmap: dev 8:32 ino 0xc bdev 8:32 addr 0x84200000 offset 0x0 length 0x10000 type MAPPED (0x2) flags DIRTY|ATOMIC_BIO (0x102) e.g. trace with DONTCACHE flag set xfs_io-1110 [007] ..... 238.780532: iomap_iter: dev 8:16 ino 0x83 pos 0x1000 length 0x1000 status 0 flags WRITE|DONTCACHE (0x401) ops xfs_buffered_write_iomap_ops caller iomap_file_buffered_write+0xab/0x0 Reviewed-by: Darrick J. Wong Signed-off-by: Ritesh Harjani (IBM) Reviewed-by: Ojaswin Mujoo --- fs/iomap/trace.h | 27 +++++++++++++++++++++------ 1 file changed, 21 insertions(+), 6 deletions(-) -- 2.48.1 diff --git a/fs/iomap/trace.h b/fs/iomap/trace.h index 9eab2c8ac3c5..455cc6f90be0 100644 --- a/fs/iomap/trace.h +++ b/fs/iomap/trace.h @@ -99,7 +99,11 @@ DEFINE_RANGE_EVENT(iomap_dio_rw_queued); { IOMAP_FAULT, "FAULT" }, \ { IOMAP_DIRECT, "DIRECT" }, \ { IOMAP_NOWAIT, "NOWAIT" }, \ - { IOMAP_ATOMIC, "ATOMIC" } + { IOMAP_OVERWRITE_ONLY, "OVERWRITE_ONLY" }, \ + { IOMAP_UNSHARE, "UNSHARE" }, \ + { IOMAP_DAX, "DAX" }, \ + { IOMAP_ATOMIC, "ATOMIC" }, \ + { IOMAP_DONTCACHE, "DONTCACHE" } #define IOMAP_F_FLAGS_STRINGS \ { IOMAP_F_NEW, "NEW" }, \ @@ -107,7 +111,14 @@ DEFINE_RANGE_EVENT(iomap_dio_rw_queued); { IOMAP_F_SHARED, "SHARED" }, \ { IOMAP_F_MERGED, "MERGED" }, \ { IOMAP_F_BUFFER_HEAD, "BH" }, \ - { IOMAP_F_SIZE_CHANGED, "SIZE_CHANGED" } + { IOMAP_F_XATTR, "XATTR" }, \ + { IOMAP_F_BOUNDARY, "BOUNDARY" }, \ + { IOMAP_F_ANON_WRITE, "ANON_WRITE" }, \ + { IOMAP_F_ATOMIC_BIO, "ATOMIC_BIO" }, \ + { IOMAP_F_PRIVATE, "PRIVATE" }, \ + { IOMAP_F_SIZE_CHANGED, "SIZE_CHANGED" }, \ + { IOMAP_F_STALE, "STALE" } + #define IOMAP_DIO_STRINGS \ {IOMAP_DIO_FORCE_WAIT, "DIO_FORCE_WAIT" }, \ @@ -138,7 +149,7 @@ DECLARE_EVENT_CLASS(iomap_class, __entry->bdev = iomap->bdev ? iomap->bdev->bd_dev : 0; ), TP_printk("dev %d:%d ino 0x%llx bdev %d:%d addr 0x%llx offset 0x%llx " - "length 0x%llx type %s flags %s", + "length 0x%llx type %s (0x%x) flags %s (0x%x)", MAJOR(__entry->dev), MINOR(__entry->dev), __entry->ino, MAJOR(__entry->bdev), MINOR(__entry->bdev), @@ -146,7 +157,9 @@ DECLARE_EVENT_CLASS(iomap_class, __entry->offset, __entry->length, __print_symbolic(__entry->type, IOMAP_TYPE_STRINGS), - __print_flags(__entry->flags, "|", IOMAP_F_FLAGS_STRINGS)) + __entry->type, + __print_flags(__entry->flags, "|", IOMAP_F_FLAGS_STRINGS), + __entry->flags) ) #define DEFINE_IOMAP_EVENT(name) \ @@ -185,7 +198,7 @@ TRACE_EVENT(iomap_writepage_map, __entry->bdev = iomap->bdev ? iomap->bdev->bd_dev : 0; ), TP_printk("dev %d:%d ino 0x%llx bdev %d:%d pos 0x%llx dirty len 0x%llx " - "addr 0x%llx offset 0x%llx length 0x%llx type %s flags %s", + "addr 0x%llx offset 0x%llx length 0x%llx type %s (0x%x) flags %s (0x%x)", MAJOR(__entry->dev), MINOR(__entry->dev), __entry->ino, MAJOR(__entry->bdev), MINOR(__entry->bdev), @@ -195,7 +208,9 @@ TRACE_EVENT(iomap_writepage_map, __entry->offset, __entry->length, __print_symbolic(__entry->type, IOMAP_TYPE_STRINGS), - __print_flags(__entry->flags, "|", IOMAP_F_FLAGS_STRINGS)) + __entry->type, + __print_flags(__entry->flags, "|", IOMAP_F_FLAGS_STRINGS), + __entry->flags) ); TRACE_EVENT(iomap_iter,