From patchwork Mon Apr 14 14:45:46 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jeff Layton X-Patchwork-Id: 14050534 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8C3E2279788; Mon, 14 Apr 2025 14:45:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744641957; cv=none; b=GqhmIyaq6Aeyk/ftgQWGgfTlnk6ypaRPzW4CbFnJN/TsCd0cIYApyyR7O7qQkEXj7wLiaFMvJQwtCTszrglIPFCvuGI0GtsmvUO/EQkWY/kynjcMhuMOsvKkDJVDIyqOp+TAJH6SbK/l5XgoVX1Vh4y2vGY8KVc9PZKHsVI/JNY= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744641957; c=relaxed/simple; bh=SSajUPnbQSKVzXF6E1uLVagrvTLcwv8/FusW/NRPovQ=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=me0rgAwy6rH4v6tkItJk5J4hybFStMxvZwuUFikBWLFCx2Sx6D6SMZAJNqStSmJrEpQVjtZ6YKBr5jpGx71K4qom1jFDr/ArKjpSugljHKh+Mte/QKTVKCxYzuzlTARaT0py6A1r1NEdCD2l+FJJVozV30N/H/KM/zXE23BHtOo= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=GRy9ocqh; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="GRy9ocqh" Received: by smtp.kernel.org (Postfix) with ESMTPSA id E875CC4CEE9; Mon, 14 Apr 2025 14:45:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1744641956; bh=SSajUPnbQSKVzXF6E1uLVagrvTLcwv8/FusW/NRPovQ=; h=From:Date:Subject:References:In-Reply-To:To:Cc:From; b=GRy9ocqh4N8HQI21DVIv78Zw1urvsw+0pRLfcePBTeb2plz/oV2iUkT8br3pCFAJz nqty22Xj40WazHZO3TH39/mqXI9RREEZUiYb1a2AmGnQG2z7L+TY2Cb06jkg29Awqz EwmC9S+MUOrALB74saINuju6c9yyePzTbvz9wPBDoYnbNB48UIrammCnIvlSSfnNKp 8vMQh/AlDnEWEiKTLqjHZXbNLQRUHBdpMMTJdz2aA9L/73DZ+1/GLxVMCWlA2Qbklt qncYO2giRTjgC0yztuAfy17X60p8eAcx4wfgWQg27obSMYsboieHTxTt+1miBhYoq1 /e9h97Jw1CRbQ== From: Jeff Layton Date: Mon, 14 Apr 2025 10:45:46 -0400 Subject: [PATCH 1/4] ref_tracker: add a top level debugfs directory for ref_tracker Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-Id: <20250414-reftrack-dbgfs-v1-1-f03585832203@kernel.org> References: <20250414-reftrack-dbgfs-v1-0-f03585832203@kernel.org> In-Reply-To: <20250414-reftrack-dbgfs-v1-0-f03585832203@kernel.org> To: Andrew Morton , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Simon Horman Cc: Qasim Ijaz , Nathan Chancellor , Andrew Lunn , linux-kernel@vger.kernel.org, netdev@vger.kernel.org, Jeff Layton X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=1356; i=jlayton@kernel.org; h=from:subject:message-id; bh=SSajUPnbQSKVzXF6E1uLVagrvTLcwv8/FusW/NRPovQ=; b=owEBbQKS/ZANAwAIAQAOaEEZVoIVAcsmYgBn/R+hj2kUX5eXDLiaWqm4WPGSrs9x61tpKod4K XzgMxKqzV+JAjMEAAEIAB0WIQRLwNeyRHGyoYTq9dMADmhBGVaCFQUCZ/0foQAKCRAADmhBGVaC FbCDEACQ2POkqnjyopUj3rPvwD1Sk20Xb2xJJV2km9vgHog0f6k6z9/xx2IsTN02nMlrQHFfACZ Q7bVotWODf1jlKfqAyqSXdhD59y6MTZyZpXWWBRpRIbVLgKyKaGNCrK67cKMBc8AR2FSpx/4+Sa ZJMBBKOwzzZtF7RXfxxFnsBC4CPSXQ1eh91h9m7BES3mA5QOR7IgaBex/hz12FizW1BMyYYtC/X L2zcwvk3KwP6NRder4LAtjkzJhhbx9z0U5Iq+y+qBT6N5wtRABZN1H52JQVnzbIbVUa1fNWy2zy 7TwqIe/ixuIfCQ0zMC+XCEIWeXX9T88kVRULYwbUUY8jGcE5fTNOxUIShuClXJW6DG5tSBoo7cj imMK9zg8QeUvBBNGcVfvNCqB8atrDU4cfdRiT/P4t9FvOvJ+VZUuKpIF4IIba2wDuotLiszLpz3 /4jQc4FWMlZpx2vqm5OieMZsH77BgXLag/BLJkpywBFh8LSp4OWdbkvRRGVANZusVBkv+5l2e9X CRITIyybwDK7bUUMuPTHIYuiSBXTdOUgNK9CW5AmT8wfXTb1HAjow4U0C3p6CB7C3uaUIq4Jbqm c99WIewg/NrsV80adSm70IVUmHA0HHm+GpAb2zmDAdov7hvFVD3mIynHH8n+MLElLDpdBdjJwJh 3GLYxLl07LV59Rg== X-Developer-Key: i=jlayton@kernel.org; a=openpgp; fpr=4BC0D7B24471B2A184EAF5D3000E684119568215 Add a new "ref_tracker" directory in debugfs. Each individual refcount tracker can register files under there to display info about currently-held references. Signed-off-by: Jeff Layton --- lib/ref_tracker.c | 18 ++++++++++++++++++ 1 file changed, 18 insertions(+) diff --git a/lib/ref_tracker.c b/lib/ref_tracker.c index cf5609b1ca79361763abe5a3a98484a3ee591ff2..c96994134fe1ddfcbf644cc75b36b7e94461ec48 100644 --- a/lib/ref_tracker.c +++ b/lib/ref_tracker.c @@ -12,6 +12,8 @@ #define REF_TRACKER_STACK_ENTRIES 16 #define STACK_BUF_SIZE 1024 +static struct dentry *ref_tracker_debug_dir; + struct ref_tracker { struct list_head head; /* anchor into dir->list or dir->quarantine */ bool dead; @@ -273,3 +275,19 @@ int ref_tracker_free(struct ref_tracker_dir *dir, return 0; } EXPORT_SYMBOL_GPL(ref_tracker_free); + +#ifdef CONFIG_DEBUG_FS +#include + +static int __init ref_tracker_debug_init(void) +{ + ref_tracker_debug_dir = debugfs_create_dir("ref_tracker", NULL); + if (IS_ERR(ref_tracker_debug_dir)) { + pr_warn("ref_tracker: unable to create debugfs ref_tracker directory: %pe\n", + ref_tracker_debug_dir); + ref_tracker_debug_dir = NULL; + } + return 0; +} +late_initcall(ref_tracker_debug_init); +#endif /* CONFIG_DEBUG_FS */ From patchwork Mon Apr 14 14:45:47 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jeff Layton X-Patchwork-Id: 14050535 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C234E27990C; Mon, 14 Apr 2025 14:45:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744641958; cv=none; b=TyqRGRMY2DoYQ41h1w89QgNqvqNJurnu00SXJ6JI90M96wcf86q+2ZY0WC8jyJ1OPtqfb5U2LabxkRB3laTpaAOoHkKrA4uE82P3iwXdn+sSOTyIQOeV9b3xvZA9xgYAKCO4kznuc+NbakEao858YSfrkkB07RtaWtoat8gD9Kg= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744641958; c=relaxed/simple; bh=XBZvlZ0SdxFGpx32+WA7hNOkQ8CEyXU9W3CJef/2nwI=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=htLjd1p1AXvsFfMdFUtbjLdxxDfqBkFODVEeYxEPPuU5ZI/fEcpgeLMC2xfxI+s4i7cLxYe1kbEoca7Cadle611lrNYru1oy+f/p8zWzW6E4v43CvE7GQZdbEdAXSfJQBb5wVhQx1lTu6Nz+hl2Kd33qj/8YJQAY4EC1cEc4PDs= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=fHix8buo; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="fHix8buo" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 2FE47C4CEE2; Mon, 14 Apr 2025 14:45:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1744641958; bh=XBZvlZ0SdxFGpx32+WA7hNOkQ8CEyXU9W3CJef/2nwI=; h=From:Date:Subject:References:In-Reply-To:To:Cc:From; b=fHix8buosuw5Fbb92XljZVxg3l/vMz8JaAAY9AOgrU/668RpduCK7U4FP0EJSiF9r huET3sXyNMzpA1zpDUocq1XDjqNYmirolz6Y2In6Qlpt2BsMsByUbolv6zu2e4dnKk gaFT3S2PuLPpA4Bo5kK0ZIMm9GAcMAGLIIJkQLr0KXuc6XYi0tUKL/vmFH9KvLneFU 3MJRZwzxzritAXNFJy1T7C5CueB+LCYx/Gy5j4l7Kd11s20OQeo69S8LyEu3RDJu27 iHtEYV7EqiIJEnP7OZM2vH3d65eBgIpUoHHI4ccl3X50IkCIlKkg8w8DcO9llqxNiM RotzkV8zGTrDA== From: Jeff Layton Date: Mon, 14 Apr 2025 10:45:47 -0400 Subject: [PATCH 2/4] ref_tracker: add ability to register a file in debugfs for a ref_tracker_dir Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-Id: <20250414-reftrack-dbgfs-v1-2-f03585832203@kernel.org> References: <20250414-reftrack-dbgfs-v1-0-f03585832203@kernel.org> In-Reply-To: <20250414-reftrack-dbgfs-v1-0-f03585832203@kernel.org> To: Andrew Morton , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Simon Horman Cc: Qasim Ijaz , Nathan Chancellor , Andrew Lunn , linux-kernel@vger.kernel.org, netdev@vger.kernel.org, Jeff Layton X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=6233; i=jlayton@kernel.org; h=from:subject:message-id; bh=XBZvlZ0SdxFGpx32+WA7hNOkQ8CEyXU9W3CJef/2nwI=; b=owEBbQKS/ZANAwAIAQAOaEEZVoIVAcsmYgBn/R+h472UuOZ40DXg7VKHLHPxuZREfFp4Z5CwF DelGmrR1mSJAjMEAAEIAB0WIQRLwNeyRHGyoYTq9dMADmhBGVaCFQUCZ/0foQAKCRAADmhBGVaC FceOD/0T4cwLe0yu3aODVe1oYuCSAuXSk+F83nKl/+M/G6QIq6GBOPPe6neFp7qoeawBXOTfFi4 KwkX6hPuUxx+2PU2zSE7Zkv+TXOU19q1ADvaFuPNQhdjB48NBOj7dMQdnDrgKjOE7KSKyeFlgnW NlpEzFLwrC17Ak+seU2/cPDBijabQTgGtk50jDmcP60gqPMwnGDjcmAKLnHyTYdTxC/tgUQZaP+ SnpHzlMwsUMt6wQQCHKBqc5tWc2Xan8HbG3kRIZtYgtjSvPxlTeleYMtUEdK0rzNWz97xSgM4E+ kaQK+KXVsyX4tKJWtH2R+1/xC1flmWA3bVPbuIIxy+KAcV9jRsByRgJp/PdHN8YJQZcqrjszSjd CP1HB7Rzv3ZHNxM3/xYn5XaNSrzuEuGUCOeWQL7EGm43CygjmOzSwghePcAa2BbfaNyqgzo9rCF 5ZwjBFJliB2ykrxvOXQyiLw2dyQZt7lAd59j/Pab3TFvhjWun4/BOsBZXirT7+f0/eXZAncyFxb 6ax2ZILuOTCB2wZo/SngPTMlNwmjq4MWv7dPIV835gvENRdRVcrRfZPgGoqDcQfx8+ykwmqMcTY 7RhGxk/hpbAYP0ZSalg03HhghuqymjJKYUOs0nSGdVTYlbfGNBji7YbRZIiCWTv9l0Es7kJ3IQA st6Ml+IgO6+jdew== X-Developer-Key: i=jlayton@kernel.org; a=openpgp; fpr=4BC0D7B24471B2A184EAF5D3000E684119568215 Currently, there is no convenient way to see the info that the ref_tracking infrastructure collects. Add a new function that other subsystems can optionally call to update the name field in the ref_tracker_dir and register a corresponding seq_file for it in the top-level ref_tracker directory. Also, alter the pr_ostream infrastructure to allow the caller to specify a seq_file to which the output should go instead of printing to an arbitrary buffer or the kernel's ring buffer. Signed-off-by: Jeff Layton Signed-off-by: Jeff Layton --- include/linux/ref_tracker.h | 13 +++++++ lib/ref_tracker.c | 84 +++++++++++++++++++++++++++++++++++++++++++-- 2 files changed, 94 insertions(+), 3 deletions(-) diff --git a/include/linux/ref_tracker.h b/include/linux/ref_tracker.h index 8eac4f3d52547ccbaf9dcd09962ce80d26fbdff8..77a55a32c067216fa02ba349498f53bd289aee0c 100644 --- a/include/linux/ref_tracker.h +++ b/include/linux/ref_tracker.h @@ -5,6 +5,7 @@ #include #include #include +#include struct ref_tracker; @@ -17,6 +18,9 @@ struct ref_tracker_dir { bool dead; struct list_head list; /* List of active trackers */ struct list_head quarantine; /* List of dead trackers */ +#ifdef CONFIG_DEBUG_FS + struct dentry *dentry; +#endif char name[32]; #endif }; @@ -34,10 +38,15 @@ static inline void ref_tracker_dir_init(struct ref_tracker_dir *dir, dir->dead = false; refcount_set(&dir->untracked, 1); refcount_set(&dir->no_tracker, 1); +#ifdef CONFIG_DEBUG_FS + dir->dentry = NULL; +#endif strscpy(dir->name, name, sizeof(dir->name)); stack_depot_init(); } +void ref_tracker_dir_debugfs(struct ref_tracker_dir *dir, const char *name); + void ref_tracker_dir_exit(struct ref_tracker_dir *dir); void ref_tracker_dir_print_locked(struct ref_tracker_dir *dir, @@ -62,6 +71,10 @@ static inline void ref_tracker_dir_init(struct ref_tracker_dir *dir, { } +static inline void ref_tracker_dir_debugfs(struct ref_tracker_dir *dir, const char *name) +{ +} + static inline void ref_tracker_dir_exit(struct ref_tracker_dir *dir) { } diff --git a/lib/ref_tracker.c b/lib/ref_tracker.c index c96994134fe1ddfcbf644cc75b36b7e94461ec48..10452f66283b081460ef7f4f5640e30487bb1595 100644 --- a/lib/ref_tracker.c +++ b/lib/ref_tracker.c @@ -8,6 +8,7 @@ #include #include #include +#include #define REF_TRACKER_STACK_ENTRIES 16 #define STACK_BUF_SIZE 1024 @@ -30,6 +31,14 @@ struct ref_tracker_dir_stats { } stacks[]; }; +#ifdef CONFIG_DEBUG_FS +static void ref_tracker_debugfs_remove(struct ref_tracker_dir *dir); +#else +static inline void ref_tracker_debugfs_remove(struct ref_tracker_dir *dir) +{ +} +#endif + static struct ref_tracker_dir_stats * ref_tracker_get_stats(struct ref_tracker_dir *dir, unsigned int limit) { @@ -66,6 +75,7 @@ ref_tracker_get_stats(struct ref_tracker_dir *dir, unsigned int limit) struct ostream { char *buf; + struct seq_file *seq; int size, used; }; @@ -73,7 +83,9 @@ struct ostream { ({ \ struct ostream *_s = (stream); \ \ - if (!_s->buf) { \ + if (_s->seq) { \ + seq_printf(_s->seq, fmt, ##args); \ + } else if (!_s->buf) { \ pr_err(fmt, ##args); \ } else { \ int ret, len = _s->size - _s->used; \ @@ -163,6 +175,7 @@ void ref_tracker_dir_exit(struct ref_tracker_dir *dir) bool leak = false; dir->dead = true; + ref_tracker_debugfs_remove(dir); spin_lock_irqsave(&dir->lock, flags); list_for_each_entry_safe(tracker, n, &dir->quarantine, head) { list_del(&tracker->head); @@ -279,7 +292,72 @@ EXPORT_SYMBOL_GPL(ref_tracker_free); #ifdef CONFIG_DEBUG_FS #include -static int __init ref_tracker_debug_init(void) +static int ref_tracker_dir_seq_print(struct ref_tracker_dir *dir, struct seq_file *seq) +{ + struct ostream os = { .seq = seq }; + unsigned long flags; + + spin_lock_irqsave(&dir->lock, flags); + __ref_tracker_dir_pr_ostream(dir, 16, &os); + spin_unlock_irqrestore(&dir->lock, flags); + + return os.used; +} + +static int ref_tracker_debugfs_show(struct seq_file *f, void *v) +{ + struct ref_tracker_dir *dir = f->private; + + return ref_tracker_dir_seq_print(dir, f); +} + +static int ref_tracker_debugfs_open(struct inode *inode, struct file *filp) +{ + struct ref_tracker_dir *dir = inode->i_private; + + return single_open(filp, ref_tracker_debugfs_show, dir); +} + +static const struct file_operations ref_tracker_debugfs_fops = { + .owner = THIS_MODULE, + .open = ref_tracker_debugfs_open, + .read = seq_read, + .llseek = seq_lseek, + .release = single_release, +}; + +/** + * ref_tracker_dir_debugfs - create debugfs file for ref_tracker_dir + * @dir: ref_tracker_dir to finalize + * @name: updated name of the ref_tracker_dir + * + * In some cases, the name given to a ref_tracker_dir is based on incomplete information, + * and may not be unique. Call this to finalize the name of @dir, and create a debugfs + * file for it. + */ +void ref_tracker_dir_debugfs(struct ref_tracker_dir *dir, const char *name) +{ + strscpy(dir->name, name, sizeof(dir->name)); + + if (ref_tracker_debug_dir) { + dir->dentry = debugfs_create_file(dir->name, S_IFREG | 0400, + ref_tracker_debug_dir, dir, + &ref_tracker_debugfs_fops); + if (IS_ERR(dir->dentry)) { + pr_warn("ref_tracker: unable to create debugfs file for %s: %pe\n", + dir->name, dir->dentry); + dir->dentry = NULL; + } + } +} +EXPORT_SYMBOL(ref_tracker_dir_debugfs); + +static void ref_tracker_debugfs_remove(struct ref_tracker_dir *dir) +{ + debugfs_remove(dir->dentry); +} + +static int __init ref_tracker_debugfs_init(void) { ref_tracker_debug_dir = debugfs_create_dir("ref_tracker", NULL); if (IS_ERR(ref_tracker_debug_dir)) { @@ -289,5 +367,5 @@ static int __init ref_tracker_debug_init(void) } return 0; } -late_initcall(ref_tracker_debug_init); +late_initcall(ref_tracker_debugfs_init); #endif /* CONFIG_DEBUG_FS */ From patchwork Mon Apr 14 14:45:48 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jeff Layton X-Patchwork-Id: 14050536 X-Patchwork-Delegate: kuba@kernel.org Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 97746289345; Mon, 14 Apr 2025 14:45:59 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744641959; cv=none; b=rvAVrbMwDHqv5VnXCOgrfURvvewi6VB2U+Ik1xD0Y0Fe71gpyMijJJc8t7ny7taFxCYjpYuVgvbTkDuPyO2OQKu61R9GgFz89e0zBkBD7i0HvHK83d2plVAkFZPFHiTcQAk3+CXwcj1BQ+AGgGDyK+kFUjLeGyr6DDXimvbGze4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744641959; c=relaxed/simple; bh=RWMKEsJSPzuLYx/7kTIAtozDlcdMPNgssbNFi3pA2/k=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=C1lGCTbiJMsQ1lGFA5xPIchWww5NbqqUIbjH1FfLWtftmBtTw19PwrmpniWC3+PLR6ZiG6NLC4lpx0i/0ymdosuI45sq6oWCRqFN/MqezPLh3HPr+ztMZDsthFAkkM7lRsTNOQ0bmPTIFn5LKmGZjf7yC810AAR1JvpiGgXe/sw= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=NhUPEjDi; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="NhUPEjDi" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 6DB64C4CEE9; Mon, 14 Apr 2025 14:45:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1744641959; bh=RWMKEsJSPzuLYx/7kTIAtozDlcdMPNgssbNFi3pA2/k=; h=From:Date:Subject:References:In-Reply-To:To:Cc:From; b=NhUPEjDi7Rm7gXSkhKAsj6TMk6RQqpKc4Vg1XzAj+MK3Tl8fyNHRxQO3LMTZRwxar ceJ4+BsPJV4P5cDRnHfCY/u5w0m2yKITjl0MD/kzg9pom6IjllLvlb7oWKpOhpIulW 96SwIlCphrV+WTgnpsapbOse4nks3E6BTDW+iufrxbeg6CFFCcnN7SumnYu7sYyhq0 oXE9iDYXdbgP9+I1UUfLfpQjTDJLzyYBicdBJedmK4yGKyRelgHSE62PQhzfrBYHHz EM2dfIbogO7IK+gP/zLJyp+VRTjShoeNoJLarv2FszcApEY896Fa2hSphwCetJa4ZM HGLriWRabO6iA== From: Jeff Layton Date: Mon, 14 Apr 2025 10:45:48 -0400 Subject: [PATCH 3/4] net: add ref_tracker_dir_debugfs() calls for netns refcount tracking Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-Id: <20250414-reftrack-dbgfs-v1-3-f03585832203@kernel.org> References: <20250414-reftrack-dbgfs-v1-0-f03585832203@kernel.org> In-Reply-To: <20250414-reftrack-dbgfs-v1-0-f03585832203@kernel.org> To: Andrew Morton , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Simon Horman Cc: Qasim Ijaz , Nathan Chancellor , Andrew Lunn , linux-kernel@vger.kernel.org, netdev@vger.kernel.org, Jeff Layton X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=1829; i=jlayton@kernel.org; h=from:subject:message-id; bh=RWMKEsJSPzuLYx/7kTIAtozDlcdMPNgssbNFi3pA2/k=; b=owEBbQKS/ZANAwAIAQAOaEEZVoIVAcsmYgBn/R+icrDr2F1lIudHMWk7Ge8BOz9Vax3aXig3N gbOXTI9TgCJAjMEAAEIAB0WIQRLwNeyRHGyoYTq9dMADmhBGVaCFQUCZ/0fogAKCRAADmhBGVaC FbieEACddz1w+oDatN7I3ozYJDPN7XPvXlNJg81TzzOQPAqcDL6DSpNqtcsFyTB97YRPquhgym7 oJmlkCWNUzU/5Qt81lEBiU3juPoTE83ObGt9lT5tlgMB23sI5sd8lIf2CcEkS0+NQWfGeOgPinU /TZ+7VY43jnF0NTmXqiDBlirhCHKYiUhPgUUa9j+J10GwVCBI+R9W6teKfJCsKRiiV852wHi79n vTV2R4WUrlVciL6cd9/oh9KLmt47E7yoeApv7+A/DSB44djBM9j4XHMTohnl65oOWTOWwcVFfyu IhWG9SBDFMjmI3O2tB5DG837DtdiM7zQg/Fxp6W9xL+vdFzeLN1P6VW+E2+6LG4NWvFtL/GjpOS GVsKLsWo21DEn55QRk0sEfCBm8eAiOVg+Rr4Ui1StqfBnnu0L9wcv8xvwQwttsXHp61lbfMKx4+ IbShY3vMOakDmLi39PE4z7xO2iDj0HcgW5gRSuL3lSr+MAqtzIGi7sxNnxybK3RzsSSIbyQJge9 LYgUQcpn1T8G9jHK/bLd6SxPWGdoiAKAk85ZLxWq9qfDuIaVNdPHGUkbjGfB+G2WWuZGSDOA0Cl 60Q8oWfg2aPDLqpfqq+5GDEsLcfsC86q5LDwsI3glQn77PNVTE05Rps8v5vpP9b2KHf8B+VOSTm VaQfcDdX0oYxozQ== X-Developer-Key: i=jlayton@kernel.org; a=openpgp; fpr=4BC0D7B24471B2A184EAF5D3000E684119568215 X-Patchwork-Delegate: kuba@kernel.org After assigning the inode number to the namespace, use it to create a unique name for each netns refcount tracker and register the debugfs files for them. The init_net is registered early in the boot process before the ref_tracker dir is created, so add a late_initcall() to register its files. Signed-off-by: Jeff Layton --- net/core/net_namespace.c | 34 +++++++++++++++++++++++++++++++++- 1 file changed, 33 insertions(+), 1 deletion(-) diff --git a/net/core/net_namespace.c b/net/core/net_namespace.c index 4303f2a4926243e2c0ff0c0387383cd8e0658019..6ffd8aa05c38512e26572d6eada96a36e4aa1ef3 100644 --- a/net/core/net_namespace.c +++ b/net/core/net_namespace.c @@ -761,12 +761,44 @@ struct net *get_net_ns_by_pid(pid_t pid) } EXPORT_SYMBOL_GPL(get_net_ns_by_pid); +#ifdef CONFIG_NET_NS_REFCNT_TRACKER +static void net_ns_net_debugfs(struct net *net) +{ + char name[32]; + size_t len; + + len = snprintf(name, sizeof(name), "net-%u-refcnt", net->ns.inum); + if (len < sizeof(name)) + ref_tracker_dir_debugfs(&net->refcnt_tracker, name); + + len = snprintf(name, sizeof(name), "net-%u-notrefcnt", net->ns.inum); + if (len < sizeof(name)) + ref_tracker_dir_debugfs(&net->notrefcnt_tracker, name); +} + +static int __init init_net_debugfs(void) +{ + net_ns_net_debugfs(&init_net); + return 0; +} +late_initcall(init_net_debugfs); +#else +static void net_ns_net_debugfs(struct net *net) +{ +} +#endif + static __net_init int net_ns_net_init(struct net *net) { + int ret; + #ifdef CONFIG_NET_NS net->ns.ops = &netns_operations; #endif - return ns_alloc_inum(&net->ns); + ret = ns_alloc_inum(&net->ns); + if (!ret) + net_ns_net_debugfs(net); + return ret; } static __net_exit void net_ns_net_exit(struct net *net) From patchwork Mon Apr 14 14:45:49 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jeff Layton X-Patchwork-Id: 14050537 X-Patchwork-Delegate: kuba@kernel.org Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 41A7A28937D; Mon, 14 Apr 2025 14:46:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744641961; cv=none; b=CU3JzcGMSlhV4uSsB5HN0SV3SP5e4UHpvSOubPaWT5LO3g3jpv3W0UpGCy5R/FXtH87+OEKHkfthN0TiBVc1hKMv4Twuki3yliyVdShm9EjkR6r0qktRQOfIeh32mtEMCvEiJCUpdUQ8KZbwtLK7agHlrCkASytSY3eWZH8IyxA= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744641961; c=relaxed/simple; bh=LtVONm9f6LVh+uOhagzHyX5XyhmKUXGOJrHT4/14OCI=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=WAJvf4WjLHF0NXxIi7AUbAkcBB4wpXD1zJJrj5hvIE1TQoHGOk2yFMuBSP68tqRY6ANvYdRnZpZeYAk9Uml+uNj83HWcDs+acvGwQC33N1StdACsNI4Ui6gsq5ttswtfPXNE0+phDP/9CuKcJAB3H3ie6Zu1TSoiewbrmo0luT8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=TPx99ufO; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="TPx99ufO" Received: by smtp.kernel.org (Postfix) with ESMTPSA id A9B13C4CEEB; Mon, 14 Apr 2025 14:45:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1744641960; bh=LtVONm9f6LVh+uOhagzHyX5XyhmKUXGOJrHT4/14OCI=; h=From:Date:Subject:References:In-Reply-To:To:Cc:From; b=TPx99ufO5L0EEqnYXv1CL8LWYSsBHXFHzSazl078qNA3sTcq3n3JwiGJuAaMR+j8E KfPmX24fo5HPapGHtqOjhpFwv4oEXQQLXBnL2ztdzA6okGjFSZoVi/GmClBaHBB8KK Oyzu1kT2MfsdBcnpcVNGU9ZVGmDmqYAiwOYZHGIIQ7QkKQBI1tq5q5+NR9XTr+/izU oDUO3GMMG1LnB8YprjjfGPzP4F5KqFO60l32P3f9MZnS+BQUzzLt/WoCiEir4Ycbtf kS7LOWAsY0LHHEuFvhQ6hakNIhWuthZlyRsKmD1+5KRYZXqVbF4NEDxi0Rljjd99su P80WzjWBHl3sQ== From: Jeff Layton Date: Mon, 14 Apr 2025 10:45:49 -0400 Subject: [PATCH 4/4] net: register debugfs file for net_device refcnt tracker Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-Id: <20250414-reftrack-dbgfs-v1-4-f03585832203@kernel.org> References: <20250414-reftrack-dbgfs-v1-0-f03585832203@kernel.org> In-Reply-To: <20250414-reftrack-dbgfs-v1-0-f03585832203@kernel.org> To: Andrew Morton , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Simon Horman Cc: Qasim Ijaz , Nathan Chancellor , Andrew Lunn , linux-kernel@vger.kernel.org, netdev@vger.kernel.org, Jeff Layton X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=780; i=jlayton@kernel.org; h=from:subject:message-id; bh=LtVONm9f6LVh+uOhagzHyX5XyhmKUXGOJrHT4/14OCI=; b=owEBbQKS/ZANAwAIAQAOaEEZVoIVAcsmYgBn/R+iIfOuXFQqARGbygeisj/5a536bm6dqV6+g bhATKwQcz+JAjMEAAEIAB0WIQRLwNeyRHGyoYTq9dMADmhBGVaCFQUCZ/0fogAKCRAADmhBGVaC FbInD/9q4YHd1P32c1dDYiQoHRKo14yZQ7HGWWTIoiE4RMAY4GmtVn5JdCFG6k+b2ktMJpmiiYN 4/tfxYpOibfpc2QjtJIznVrFHfB3No6xw4REAIKYq0rAKCaJSf0LoPkJybdLlb5wS2X5LP+FwSE vRuM76sKzWOenGefZkNcdg1Zrd+HXi9SMpjLu4fGfWz5PzsbrCzADodMJ0ui2cOpKZgfgzw0L72 ztqXAmLlzi4cGV7B681oJTbihdVBZpXNO4qVqYLOx1T1RGrlHoZ/erNT2txpF0JAuZQ+nkJ7nMe PvJ84TeMIiXRzAL8y2CG4Oom/lX2CMwxU4hLYDZTA3MGXhdCkSgHKZDtZXz+K02APeZum12LfNF VKYCIsTsRCuWkWXEbTIgRiuYYpZZjikAL0T2ru4GwBFUufJmPWU8pRjXIdVMzNsV+2yz2lVc76/ ZF/05VYAYWMlmcbyvF1SijAnrHFQf9sbtgQ90inXxv7da2PDZiqdTZSaq9hoi0omMk/Cmxdru9Q AWbt2sdWCEEBL9OcPwU08u2JTh7xjzyMiX7qmNEw86GlzfGWI8PFs080qKVHNEiX4mRkk0UsmlY s5njbFZEr9Wyl4u1aREbrgOn8k0V//3e5bFujRl7NZzwZhBBsIbimevSQd90tlIDwJulFHPJEZ9 hgbgxcHAD1D7RPg== X-Developer-Key: i=jlayton@kernel.org; a=openpgp; fpr=4BC0D7B24471B2A184EAF5D3000E684119568215 X-Patchwork-Delegate: kuba@kernel.org As a nearly-final step in register_netdevice(), finalize the name in the refcount tracker, and register a debugfs file for it. Signed-off-by: Jeff Layton --- net/core/dev.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/net/core/dev.c b/net/core/dev.c index 2f7f5fd9ffec7c0fc219eb6ba57d57a55134186e..db9cac702bb2230ca2bbc2c04ac0a77482c65fc3 100644 --- a/net/core/dev.c +++ b/net/core/dev.c @@ -10994,6 +10994,8 @@ int register_netdevice(struct net_device *dev) dev->rtnl_link_state == RTNL_LINK_INITIALIZED) rtmsg_ifinfo(RTM_NEWLINK, dev, ~0U, GFP_KERNEL, 0, NULL); + /* Register debugfs file for the refcount tracker */ + ref_tracker_dir_debugfs(&dev->refcnt_tracker, dev->name); out: return ret;