From patchwork Tue Apr 15 17:48:15 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Michael Chan X-Patchwork-Id: 14052510 X-Patchwork-Delegate: kuba@kernel.org Received: from mail-oo1-f45.google.com (mail-oo1-f45.google.com [209.85.161.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DEFA122068B for ; Tue, 15 Apr 2025 17:48:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.161.45 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744739339; cv=none; b=pX64vg9oaNehvIzU1INtJCjlNl5g3Jk0KhWo79d5HeQ/yGiSi7ZxMAjrhEu4GJ+9oEQaHdZLl/P2pC4Rz99j/fbcBjP92q3/ioTlK3xXqPVWjF6pSUPQaj1Pj0niipfA7BdOfLp7YMfkeeGuPvYNLAeFJaL2AI7XoL0y4VaH3Gc= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744739339; c=relaxed/simple; bh=xR1fVkn1wNqkaw3ORky7nMlg669ti+csesnvz1DWjcE=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=HEc2+GWstbLNfPdkCZIwO3nz4qzQKEliaHOVpw67/r2CFaPfmaqxeGWuBdXkzMlVaTgUcG5eTVdk9YEQ6idVPnNM2I1cbwD3vhU4837/AVHc6Hp9vMqfPs/ilzCLY6o1nUkOFhnQaHHtFQ90+id6KtJZiVfwPPsIv2f3RupRArA= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=broadcom.com; spf=fail smtp.mailfrom=broadcom.com; dkim=pass (1024-bit key) header.d=broadcom.com header.i=@broadcom.com header.b=AfGja+uv; arc=none smtp.client-ip=209.85.161.45 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=broadcom.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=broadcom.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=broadcom.com header.i=@broadcom.com header.b="AfGja+uv" Received: by mail-oo1-f45.google.com with SMTP id 006d021491bc7-603f54a6cb5so2656962eaf.0 for ; Tue, 15 Apr 2025 10:48:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; t=1744739337; x=1745344137; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=zKkupBbuDOJKK8+xfemEK/+fkXeDRge9t/ewMfGoknk=; b=AfGja+uvcq32znKX8gHVO3exCz49IYvcnDZtjx9Av0SNin+o68Mt2a7Q8qMRl03Rk0 YkqMQdwopugBhUrvFXyJ6w1TQb/Bt768YkDpukdesYAeLghd5wuKdZXx5i0/4zA2K9DE /1JKuqsvd0yPJ72PVtK6AcBUuCd1JrIJxU8yM= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1744739337; x=1745344137; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=zKkupBbuDOJKK8+xfemEK/+fkXeDRge9t/ewMfGoknk=; b=iNdFmov3pfV/+3jX5ncTTeWhtTasRJT6khwDzFRzEnSu/qITDLS6FhmB9JdEoPNni4 ZiRCY+vT6eJkB6+oa4AliO99AWiIZ/g0ywvBrLVE1Vq6yKc6FVg/AqxewuFmSMd0lvvL x4km+fR7lRG02bF03wvFWJBnbtDUbH1RbdDxrFdRceuJfN15b/5UnmqcVdB7kAnlGARJ rvnp5emNqqvOT1z2091qA0OMstZKEOxyJ3w7JlhPHqlux/PJXoAIR3SbAZDtku+LlCyf ehxyrhwZOLkuj/3JRopkreWuE7eLMDeqrDkVihYzYvHHhTQ2Uq6zw0iXC1QxVVKF/rhm CBog== X-Gm-Message-State: AOJu0YyuO8A3YYSSswFLHmmCWKYE3AW5dIxBxhKhAJhgPFppR6R34tRy 7hod6+6l9Sy7B2wxpjCr4zhlvqpx2ixI5UPhw6UyWQzVNngOJX/Mzn1PpP4OJw== X-Gm-Gg: ASbGnctF8Fj0aX7Ibw/EqMMply1krM2Ax6T+XXCekAfUhH3jyQA7DeUjXiN1RE/ftHc raV8R4Tv5EnQJMwkVXKOfHGXsMqxjszqwPnpv9+bTlpA7pl6VEKUGKsQCA4lpb0RZN+l3BzJDND h8bWkfaP3QAoax61wHysc0FQROPRYBHQN9Ye1vBUsRNcFX0OPCS5MxKyTsIGenz6hQUy5lZfp7Y V6ShJDKZKA3OLW8l7zPbQ95AytD1JwJkNTd20skITWDYZ/10gjgCP4/fBnTDfOgkxTledEUxhpe Ya/q5/XAAp4S3dvS0aJfq8Qj/isrqwGij7cFmZDjhS4ZDYyOQXhvsIFCYiGcAFOm1dVGH6Kca3n 0CWeT498QNE3HWAFehlRFl5U+r+8= X-Google-Smtp-Source: AGHT+IEPHzUGZah0t1K1gUDxskdOTdRdcEbGrXOPTMcmpQ1E5uRHXWBDjwtCrFHW4+wozsVQLTmLWg== X-Received: by 2002:a05:6820:3087:b0:602:2bd5:121c with SMTP id 006d021491bc7-6046f584f01mr10279931eaf.3.1744739336868; Tue, 15 Apr 2025 10:48:56 -0700 (PDT) Received: from lvnvda3289.lvn.broadcom.net ([192.19.161.250]) by smtp.gmail.com with ESMTPSA id 006d021491bc7-6045f50ee87sm2457073eaf.7.2025.04.15.10.48.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 15 Apr 2025 10:48:56 -0700 (PDT) From: Michael Chan To: davem@davemloft.net Cc: netdev@vger.kernel.org, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, andrew+netdev@lunn.ch, pavan.chebbi@broadcom.com, andrew.gospodarek@broadcom.com, Kalesh AP Subject: [PATCH net-next 1/4] bnxt_en: Change FW message timeout warning Date: Tue, 15 Apr 2025 10:48:15 -0700 Message-ID: <20250415174818.1088646-2-michael.chan@broadcom.com> X-Mailer: git-send-email 2.43.4 In-Reply-To: <20250415174818.1088646-1-michael.chan@broadcom.com> References: <20250415174818.1088646-1-michael.chan@broadcom.com> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Patchwork-Delegate: kuba@kernel.org The firmware advertises a "hwrm_cmd_max_timeout" value to the driver for NVRAM and coredump related functions that can take tens of seconds to complete. The driver polls for the operation to complete under mutex and may trigger hung task watchdog warning if the wait is too long. To warn the user about this, the driver currently prints a warning if this advertised value exceeds 40 seconds: Device requests max timeout of %d seconds, may trigger hung task watchdog The original hope was that newer FW would be able to reduce this timeout below 40 seconds. But 60 seconds is the timeout on most production FW and cannot be reduced further. Change the driver's warning threshold to 60 seconds to avoid triggering this warning on all production devices. Reviewed-by: Kalesh AP Reviewed-by: Pavan Chebbi Reviewed-by: Andy Gospodarek Signed-off-by: Michael Chan --- drivers/net/ethernet/broadcom/bnxt/bnxt_hwrm.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/broadcom/bnxt/bnxt_hwrm.h b/drivers/net/ethernet/broadcom/bnxt/bnxt_hwrm.h index 15ca51b5d204..fb5f5b063c3d 100644 --- a/drivers/net/ethernet/broadcom/bnxt/bnxt_hwrm.h +++ b/drivers/net/ethernet/broadcom/bnxt/bnxt_hwrm.h @@ -58,7 +58,7 @@ void hwrm_update_token(struct bnxt *bp, u16 seq, enum bnxt_hwrm_wait_state s); #define BNXT_HWRM_MAX_REQ_LEN (bp->hwrm_max_req_len) #define BNXT_HWRM_SHORT_REQ_LEN sizeof(struct hwrm_short_input) -#define HWRM_CMD_MAX_TIMEOUT 40000U +#define HWRM_CMD_MAX_TIMEOUT 60000U #define SHORT_HWRM_CMD_TIMEOUT 20 #define HWRM_CMD_TIMEOUT (bp->hwrm_cmd_timeout) #define HWRM_RESET_TIMEOUT ((HWRM_CMD_TIMEOUT) * 4) From patchwork Tue Apr 15 17:48:16 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Michael Chan X-Patchwork-Id: 14052511 X-Patchwork-Delegate: kuba@kernel.org Received: from mail-oo1-f42.google.com (mail-oo1-f42.google.com [209.85.161.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1C36B1F3FDC for ; Tue, 15 Apr 2025 17:48:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.161.42 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744739340; cv=none; b=ppCKfiaIEiUNMjpEfeSwGxnrGISkBE96E7fTDDWxsFq0bzkO4Bdc0QLFw9XGGbH/NDHgfGAW7hvS2aVerAvBVUvgIMXL0bVT24MgEx7odc+aCyAtSsy+LhiCQMmvGOPDa7PgmalGlH4Pzmkgj7oKBna5eHrEu3Ber28agAhgIuY= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744739340; c=relaxed/simple; bh=P4grIgMcFBx6uX0VhGtxuvQCENvc2Rsj2FroJKBMbDQ=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=R9idrMeG/g6QCDh5Oj5x5dcSTpFYNNG8BGlyMfqm2licVl0wB/pNDdqx/Dj2bMM5/I6ii+e+CLuz6M4FEdnzI3L4/FGv+RtD0D67LdP/zD003mDHlN4QD67QXdScm6J4IfiR1FC0GRsYFxdS3ObZgkNwip02HqgblRdpnn+SiNc= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=broadcom.com; spf=fail smtp.mailfrom=broadcom.com; dkim=pass (1024-bit key) header.d=broadcom.com header.i=@broadcom.com header.b=YWDQbDgN; arc=none smtp.client-ip=209.85.161.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=broadcom.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=broadcom.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=broadcom.com header.i=@broadcom.com header.b="YWDQbDgN" Received: by mail-oo1-f42.google.com with SMTP id 006d021491bc7-603ff8e915aso1664907eaf.3 for ; Tue, 15 Apr 2025 10:48:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; t=1744739338; x=1745344138; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=YgSwWLJCnsmrTM6Kf/YHkuzpzYvCE+MfEaXp8mEkXW0=; b=YWDQbDgNNrhR3uQCV7eu3nacB158z+UNmdP3szVzk0GMfrJbznsdw67RVNOp8ZuSng Pklt0AT8P+K7Jo0AsoH4RtfFWW5/TtN0Dljwz8qFWYi9LrrzAPUmdRMNxmRVQB1PySzx WijHqZz5X/XfY50Nk6RUcCPbresSWIhjkrhGY= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1744739338; x=1745344138; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=YgSwWLJCnsmrTM6Kf/YHkuzpzYvCE+MfEaXp8mEkXW0=; b=pR3VN4Ok1yZUTyc4HF8Sb3Qf1qQ3EQSNHfPkeelUgYUkqdTYLfHoYczHpPUVaLVTBw bCDoBXybNyJL+8WJyz25vunxj7oZzttPB66AZELrY9S75Gm5Dw0jGxOJoLPZMm4Cxj4Z dyuS1oX/RLhOC1Vv6oNGB4d7dyxMbzkWgHhHApYK6VSLTMp+55IExhr79GEXje0rWMOb ADwJ2RuGfdoNG4z2U1v63xdrbwPnuh8oZc9tM33pmBWRWVWRV8lb7kw4YmAX6TNeok3+ PstvuPYe5fTglPplh96RnIrhfrAxOeNoos3Y9xMRRroe4QnKKDZwz7kP5BAlczr6cemQ RvpQ== X-Gm-Message-State: AOJu0YxSCgaNTZIvaW02JlNqp6nSbaw79ln+cf+21q2A5ENUURWRb1nj SpEB7tz2q2c/N5EdBxcjDgUG/2vMqaw387UMF01QEa/KsaJNjoKk449/kKCBq+T6oTvEJSMydo4 = X-Gm-Gg: ASbGncsZI74yzTswVE7ZyQPyR0qRU8m11WllHa4a4oty8R14JohhOzmM3/AQDQe6cz3 BopbifAH2LBDhLdcMUcGjBuMXefORPvZtTmk9Mu+dFZUxXotOY+DqshFktmXhVDKHyxo1PWN1H9 Fh9AaDcCMcOr5IrvV19C0W9QkUPIRAd/iF12NB0cTDKOVjVjzMarbSPK1G/ept5m2mvijY34D/A fc7gm8+6VKj3f9UIXdrqcUXwwrsJbbV945YGUhZWhT+NQq9Jg6o069Z5DZGNguMHkZwv1U3Ar07 n8Zyh03+Ini56HNX7qQQq5JOYrhKfmTH8jIqUAcnM2BN0eqhq/qcnX4y+Rlmr2CnojWPsYpFq38 ROqorQJhpFunHVCJz X-Google-Smtp-Source: AGHT+IFXklvxW0G5/85K69JyhI5pYnciRqWEUyJ/OgBrcHD3g2epaGat13qd2dU3ptOg0IpSpbYEwg== X-Received: by 2002:a05:6820:2087:b0:601:d595:3b1f with SMTP id 006d021491bc7-6046f590ac6mr9698025eaf.6.1744739338086; Tue, 15 Apr 2025 10:48:58 -0700 (PDT) Received: from lvnvda3289.lvn.broadcom.net ([192.19.161.250]) by smtp.gmail.com with ESMTPSA id 006d021491bc7-6045f50ee87sm2457073eaf.7.2025.04.15.10.48.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 15 Apr 2025 10:48:57 -0700 (PDT) From: Michael Chan To: davem@davemloft.net Cc: netdev@vger.kernel.org, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, andrew+netdev@lunn.ch, pavan.chebbi@broadcom.com, andrew.gospodarek@broadcom.com, Shruti Parab , Damodharam Ammepalli Subject: [PATCH net-next 2/4] bnxt_en: Report the ethtool coredump length after copying the coredump Date: Tue, 15 Apr 2025 10:48:16 -0700 Message-ID: <20250415174818.1088646-3-michael.chan@broadcom.com> X-Mailer: git-send-email 2.43.4 In-Reply-To: <20250415174818.1088646-1-michael.chan@broadcom.com> References: <20250415174818.1088646-1-michael.chan@broadcom.com> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Patchwork-Delegate: kuba@kernel.org From: Shruti Parab ethtool first calls .get_dump_flags() to get the dump length. For coredump, the driver calls the FW to get the coredump length (L1). The min. of L1 and the user specified length is then passed to .get_dump_data() (L2) to get the coredump. The actual coredump length retrieved by the FW (L3) during .get_dump_data() may be smaller than L1. This length discrepancy will trigger a WARN_ON() in ethtool_get_dump_data(). ethtool has already vzalloc'ed a buffer with size L1. Just report the coredump length as L2 even though the actual coredump length L3 may be smaller. The extra zero padding does not matter. This will prevent the warning that may alarm the user. For correctness, only do the final length update if there is no error. Reviewed-by: Andy Gospodarek Reviewed-by: Damodharam Ammepalli Signed-off-by: Shruti Parab Signed-off-by: Michael Chan --- drivers/net/ethernet/broadcom/bnxt/bnxt_coredump.c | 11 +++++++++-- 1 file changed, 9 insertions(+), 2 deletions(-) diff --git a/drivers/net/ethernet/broadcom/bnxt/bnxt_coredump.c b/drivers/net/ethernet/broadcom/bnxt/bnxt_coredump.c index 5576e7cf8463..9b6489e417fc 100644 --- a/drivers/net/ethernet/broadcom/bnxt/bnxt_coredump.c +++ b/drivers/net/ethernet/broadcom/bnxt/bnxt_coredump.c @@ -496,9 +496,16 @@ static int __bnxt_get_coredump(struct bnxt *bp, u16 dump_type, void *buf, start_utc, coredump.total_segs + 1, rc); kfree(coredump.data); - *dump_len += sizeof(struct bnxt_coredump_record); - if (rc == -ENOBUFS) + if (!rc) { + *dump_len += sizeof(struct bnxt_coredump_record); + /* The actual coredump length can be smaller than the FW + * reported length earlier. Use the ethtool provided length. + */ + if (buf_len) + *dump_len = buf_len; + } else if (rc == -ENOBUFS) { netdev_err(bp->dev, "Firmware returned large coredump buffer\n"); + } return rc; } From patchwork Tue Apr 15 17:48:17 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Michael Chan X-Patchwork-Id: 14052512 X-Patchwork-Delegate: kuba@kernel.org Received: from mail-oo1-f41.google.com (mail-oo1-f41.google.com [209.85.161.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 466A4222565 for ; Tue, 15 Apr 2025 17:49:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.161.41 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744739342; cv=none; b=cR76Uq5mxZA3u3zwxMBSIghjnrCBxtKAX6Y1CFKcs2VqGYmu4DiOAdVv3wmILVugbajnVRiOMUVh6AacTAEkdjkmIXetaxXisvfOoSvh0wcOtJQKiOTOevPGDEgS6StGJ5zbDG8CHVpmPkoizAQn03GNTrRp0E+UDWL6+7/8b5U= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744739342; c=relaxed/simple; bh=SL9PCqtts6Mv/ggwdLxgp+QFbDaOWxeKY8izfswvdWA=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=lw/E3F5+tDh26GwgX/FNUFYYDqfYkVm6A5VLwvSLm/Gv2P7VTn8lV725Fm3L2PtYv9fiygAQQ3zRAHR5d/nc5VCnDqHjxajTvjNjH7uixus/5r37M9VLHmGwKeHTVYUDWWPklc+OTLNxinHxr/ofJjhwn7A6tX+1fQwAqbI15+8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=broadcom.com; spf=fail smtp.mailfrom=broadcom.com; dkim=pass (1024-bit key) header.d=broadcom.com header.i=@broadcom.com header.b=Gsf0URvi; arc=none smtp.client-ip=209.85.161.41 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=broadcom.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=broadcom.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=broadcom.com header.i=@broadcom.com header.b="Gsf0URvi" Received: by mail-oo1-f41.google.com with SMTP id 006d021491bc7-603ff8e915aso1664930eaf.3 for ; Tue, 15 Apr 2025 10:49:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; t=1744739340; x=1745344140; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=r9yHAaw/uQvwxq1qnIfTLfjQQMXVxIDQXkvOd3fiXj0=; b=Gsf0URviHyvI3QOMC9qmKeLFboIDHF0UPasE9idihZ+Goiv5rDr5BV/mri8Zc19hrA T2GrQ+vfVbnpym+bZUE2oSNL22pi3WNZjAhmD8XISggi4Dmtiu6LWuhvhaFXts3ws60G S70Pfy1YzTHz6uucvpiPKW970xh9XicK1kRcE= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1744739340; x=1745344140; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=r9yHAaw/uQvwxq1qnIfTLfjQQMXVxIDQXkvOd3fiXj0=; b=MC6L+V6EYZkpuA+bmnCFhRM/QaPYIeGTielHQLh6nq8QJ6abk0UTC5BjjC82rO4xli 2E80FEOF7ci3qWSLS15uVa1Wij48dhgSIkBtcAjbcGKaOrkA1rzXHcka9jtuwrxWKTUF lSLmuXR1VppIsp0SQfPPtGdlKBrKrizYivY5XpaT/Q2+VEs3DYw97XiFTHUR2GbsPGVb 3CEsjvDnXDLXXm+F4a7XsPrc9liBeCUKumFCAYR/vrCnoQeGLZxM94eX30n27KAfI1+e GvTtRHeuTkCrUH23huiClA8j294GccgT89PI5XSb4al+RRRMyA13fq3/eA99nt5PnCgj gMRw== X-Gm-Message-State: AOJu0YyCTrSJnQWVrVxIIclsL9XA/YyhR0/nie98/wORVP4HQX4FBR1S kppef3y35L33sV1uaCkHnTnNZ3S+0kLVH/kbRR6vT1JpKU3uvqmmg8nhdNRQzQ== X-Gm-Gg: ASbGncthJQnIFsFItmawV52tfBGtEZ05wp5Rcla54l4+RZpZCCBpKxhSKMlhsVjO4y9 8bkTdvKEZyiGwPo0Cg19ggjv9q6z2WOfmZPnboaDif106dFfcIN3FMz1xT6Azs/r/e7xvE2oUI+ wBVrxgV1lxb6C9E556B+fiaCcYb34bHcFwrwRUEoCyb0uA0epiTY8+n1E/7FrBQtndFT9Uj3mYF 563A+06uShvicY4+KSbOafVBjpQGxJVpjY8xSWetQMMa8Sc+ZIRlzRoWgS3XcJpjszcLG0ztqQz 30B1pirkSq7eyINreB+xG+SyNzEuS2odZKLl5u09JpVZ6ZvyMSgO54MWaSW8/VmW1LhMUxybRZg 7jeIBbKzexwXfCCn0 X-Google-Smtp-Source: AGHT+IH6Gn0nrpeLJUhAuDgJnOIsUCmYyuEvycwFjavQIGdYNEZ6u80kcGtns44BQgDCyHUEkCFjfA== X-Received: by 2002:a05:6820:4c01:b0:604:4846:78a with SMTP id 006d021491bc7-6046f4dcea9mr9400318eaf.2.1744739340126; Tue, 15 Apr 2025 10:49:00 -0700 (PDT) Received: from lvnvda3289.lvn.broadcom.net ([192.19.161.250]) by smtp.gmail.com with ESMTPSA id 006d021491bc7-6045f50ee87sm2457073eaf.7.2025.04.15.10.48.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 15 Apr 2025 10:48:58 -0700 (PDT) From: Michael Chan To: davem@davemloft.net Cc: netdev@vger.kernel.org, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, andrew+netdev@lunn.ch, pavan.chebbi@broadcom.com, andrew.gospodarek@broadcom.com, Kalesh AP , Somnath Kotur Subject: [PATCH net-next 3/4] bnxt_en: Remove unused field "ref_count" in struct bnxt_ulp Date: Tue, 15 Apr 2025 10:48:17 -0700 Message-ID: <20250415174818.1088646-4-michael.chan@broadcom.com> X-Mailer: git-send-email 2.43.4 In-Reply-To: <20250415174818.1088646-1-michael.chan@broadcom.com> References: <20250415174818.1088646-1-michael.chan@broadcom.com> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Patchwork-Delegate: kuba@kernel.org From: Kalesh AP The "ref_count" field in struct bnxt_ulp is unused after commit a43c26fa2e6c ("RDMA/bnxt_re: Remove the sriov config callback"). So we can just remove it now. Reviewed-by: Somnath Kotur Signed-off-by: Kalesh AP Signed-off-by: Michael Chan --- drivers/net/ethernet/broadcom/bnxt/bnxt_ulp.c | 5 ----- drivers/net/ethernet/broadcom/bnxt/bnxt_ulp.h | 1 - 2 files changed, 6 deletions(-) diff --git a/drivers/net/ethernet/broadcom/bnxt/bnxt_ulp.c b/drivers/net/ethernet/broadcom/bnxt/bnxt_ulp.c index a8e930d5dbb0..238db9a1aebf 100644 --- a/drivers/net/ethernet/broadcom/bnxt/bnxt_ulp.c +++ b/drivers/net/ethernet/broadcom/bnxt/bnxt_ulp.c @@ -148,7 +148,6 @@ void bnxt_unregister_dev(struct bnxt_en_dev *edev) struct net_device *dev = edev->net; struct bnxt *bp = netdev_priv(dev); struct bnxt_ulp *ulp; - int i = 0; ulp = edev->ulp_tbl; netdev_lock(dev); @@ -164,10 +163,6 @@ void bnxt_unregister_dev(struct bnxt_en_dev *edev) synchronize_rcu(); ulp->max_async_event_id = 0; ulp->async_events_bmap = NULL; - while (atomic_read(&ulp->ref_count) != 0 && i < 10) { - msleep(100); - i++; - } mutex_unlock(&edev->en_dev_lock); netdev_unlock(dev); return; diff --git a/drivers/net/ethernet/broadcom/bnxt/bnxt_ulp.h b/drivers/net/ethernet/broadcom/bnxt/bnxt_ulp.h index 7fa3b8d1ebd2..f6b5efb5e775 100644 --- a/drivers/net/ethernet/broadcom/bnxt/bnxt_ulp.h +++ b/drivers/net/ethernet/broadcom/bnxt/bnxt_ulp.h @@ -50,7 +50,6 @@ struct bnxt_ulp { unsigned long *async_events_bmap; u16 max_async_event_id; u16 msix_requested; - atomic_t ref_count; }; struct bnxt_en_dev { From patchwork Tue Apr 15 17:48:18 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Michael Chan X-Patchwork-Id: 14052513 X-Patchwork-Delegate: kuba@kernel.org Received: from mail-oo1-f43.google.com (mail-oo1-f43.google.com [209.85.161.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 23899222578 for ; Tue, 15 Apr 2025 17:49:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.161.43 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744739344; cv=none; b=HqoE5MOAf4N9ruC7ldoSMv4J5yGR+KJ0o+4B/Y7TQSZr5Z3BPqXQRKp2Gh0NhoTHXEse6KrhpNnqrriLd8wko7/cHAXusaySkAXVyOfIHPsuZSCJXSaGfx+RYy904dqpUPXZnh2KN6pRv8c+gv4vT3Z8MaTYMwA9942GN9qAFNk= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744739344; c=relaxed/simple; bh=dJxRfYEp2QuH4TryMHj3DfMxIJ06gv4yfAAKnOyob3E=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=HWtUkBaTS1GtSWT0g4MfSRhzRBLIF/r2gdbBFmsvl/iZTii3zO7aaxiW84XoSwdqSc7sqImMfQv4Z5MtnKSPR4Q8llvuxroH6tt+tAZ6Ka7i9lzf+bFJKjhs6d03lZdDPOrsMSGHMT8985YtlHKnZNLQM6bD4oM8tWwvSgU78O4= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=broadcom.com; spf=fail smtp.mailfrom=broadcom.com; dkim=pass (1024-bit key) header.d=broadcom.com header.i=@broadcom.com header.b=dAfn01Uk; arc=none smtp.client-ip=209.85.161.43 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=broadcom.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=broadcom.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=broadcom.com header.i=@broadcom.com header.b="dAfn01Uk" Received: by mail-oo1-f43.google.com with SMTP id 006d021491bc7-60245c7309bso1428614eaf.3 for ; Tue, 15 Apr 2025 10:49:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; t=1744739342; x=1745344142; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=tsBl+7evj4S3BwRvVEmsLlhXAkdHNshIeD4Nby9HkP0=; b=dAfn01UknO9PSfzRxjBEbPDdBr5QtdaWlBqwtQ7ObV8iy7tEX7AIqJDkwdCXKfJvgD I/k7zXRQ/qz3gYuHEaOIKXZGvlDFmu6ovx51q6Ur3VjRNbR8pY4IkvV8OVgFOVSy8eXG xT9A+Ls5/rt84f7yFpilGXgttknZvdd+juPig= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1744739342; x=1745344142; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=tsBl+7evj4S3BwRvVEmsLlhXAkdHNshIeD4Nby9HkP0=; b=HerYVxCYEYPdyQDW4SRl8mTLgvqdajPgBqlxrHKubX1s958N8h2L7HM5A+hZw3L5kU 4J7blwlSozhbFc8L8AJArWqf/SZg31TUhO3w1VXjk8LCLsVS+G9Wqu5mBfHUE7k8/Rx2 eGLPfWnA0EfJ5Mi98I0qyzsSsvwGt6dZi043GGSJfy1U90/1C6Q09s/la8tvN7HPnK7B aef34TfRfwGeTTJUiUc4E3Fkxt7KWX5F8vNaI1S7D/VPJ1SCNZCqGnkBmOFh3SI0WXal 4D//vUE41bLdbB1MerkcPJ4EX1LLnFU5I9MmixmsDlMNT2zX9XGDl3cRt6YeAABvQuVe K3hQ== X-Gm-Message-State: AOJu0Ywkap26PwqUCgRYnt4TKjod6ULPiIezsnyE4xahgG9PF6vlv9WI FNJleHdgba7NsyVaDMqMYwV3+ZO9pvL3+5bA+INxUhEJ5ANP5B61o+lCmK6pdA== X-Gm-Gg: ASbGncvKlZxBltuT3GBRFjWyidvpiJ3MYQsVQeb6FSJl2VbB8UV5HUm6Ym7Hdwd5Yr5 jm5ok/PTY9cNtxyx9TlEO36wthj0/uctUmpwyD3ynH5Gfqjc1dSYKrv84PpdK4TuDPliiipwKel NSFmvHQRfyuFUSsylCsrbsfJVhh4GGpb2G2nXT2+bFhiH/BzjoGj5O37SseLjVI52a4oKwFBho/ 6ZLNqv7+2SyHLhJPMq9hj0PhMdXsGBuXnulDpRDmFl+QezUQjvgDpdNIdVXXa6WkCfwnDlWG940 RXIe0JQB1oCAQBQkDNwVWWJaku4djrbz2op6PaagGR/1d+rwDSuglzP3XuH42+8rpdic4UIR7uv saF1TX5xCcb85KQ4A X-Google-Smtp-Source: AGHT+IFNcmbW7ktns5Jay6yqphO94w+ZT0e7wMbDZwii9eRNe04vOhW8Xmr7gJF/ZPy4r7tGmbpQLg== X-Received: by 2002:a05:6820:1c8c:b0:603:f1b5:ca0e with SMTP id 006d021491bc7-6046f584d84mr8659999eaf.3.1744739342175; Tue, 15 Apr 2025 10:49:02 -0700 (PDT) Received: from lvnvda3289.lvn.broadcom.net ([192.19.161.250]) by smtp.gmail.com with ESMTPSA id 006d021491bc7-6045f50ee87sm2457073eaf.7.2025.04.15.10.49.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 15 Apr 2025 10:49:00 -0700 (PDT) From: Michael Chan To: davem@davemloft.net Cc: netdev@vger.kernel.org, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, andrew+netdev@lunn.ch, pavan.chebbi@broadcom.com, andrew.gospodarek@broadcom.com, Kalesh AP , Shruti Parab Subject: [PATCH net-next 4/4] bnxt_en: Remove unused macros in bnxt_ulp.h Date: Tue, 15 Apr 2025 10:48:18 -0700 Message-ID: <20250415174818.1088646-5-michael.chan@broadcom.com> X-Mailer: git-send-email 2.43.4 In-Reply-To: <20250415174818.1088646-1-michael.chan@broadcom.com> References: <20250415174818.1088646-1-michael.chan@broadcom.com> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Patchwork-Delegate: kuba@kernel.org From: Kalesh AP BNXT_ROCE_ULP and BNXT_MAX_ULP are no longer used. Remove them to clean up the code. Reviewed-by: Shruti Parab Signed-off-by: Kalesh AP Signed-off-by: Michael Chan --- drivers/net/ethernet/broadcom/bnxt/bnxt_ulp.h | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/net/ethernet/broadcom/bnxt/bnxt_ulp.h b/drivers/net/ethernet/broadcom/bnxt/bnxt_ulp.h index f6b5efb5e775..7b9dd8ebe4bc 100644 --- a/drivers/net/ethernet/broadcom/bnxt/bnxt_ulp.h +++ b/drivers/net/ethernet/broadcom/bnxt/bnxt_ulp.h @@ -10,9 +10,6 @@ #ifndef BNXT_ULP_H #define BNXT_ULP_H -#define BNXT_ROCE_ULP 0 -#define BNXT_MAX_ULP 1 - #define BNXT_MIN_ROCE_CP_RINGS 2 #define BNXT_MIN_ROCE_STAT_CTXS 1