From patchwork Thu Apr 17 06:06:32 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Shivank Garg X-Patchwork-Id: 14054948 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 08B76C369B2 for ; Thu, 17 Apr 2025 06:10:07 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 7E31E280121; Thu, 17 Apr 2025 02:10:05 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 7918A28011E; Thu, 17 Apr 2025 02:10:05 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 63434280121; Thu, 17 Apr 2025 02:10:05 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 45A3F28011E for ; Thu, 17 Apr 2025 02:10:05 -0400 (EDT) Received: from smtpin30.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id AE4BB160E45 for ; Thu, 17 Apr 2025 06:10:05 +0000 (UTC) X-FDA: 83342510370.30.604889C Received: from NAM10-DM6-obe.outbound.protection.outlook.com (mail-dm6nam10on2051.outbound.protection.outlook.com [40.107.93.51]) by imf30.hostedemail.com (Postfix) with ESMTP id C688F8000E for ; Thu, 17 Apr 2025 06:10:02 +0000 (UTC) Authentication-Results: imf30.hostedemail.com; dkim=pass header.d=amd.com header.s=selector1 header.b=t8sKJ0fl; dmarc=pass (policy=quarantine) header.from=amd.com; arc=pass ("microsoft.com:s=arcselector10001:i=1"); spf=pass (imf30.hostedemail.com: domain of shivankg@amd.com designates 40.107.93.51 as permitted sender) smtp.mailfrom=shivankg@amd.com ARC-Seal: i=2; s=arc-20220608; d=hostedemail.com; t=1744870202; a=rsa-sha256; cv=pass; b=lOOpmygr7x2nFFAuuIpCJl6PRUaQc8320+wRrrdoP1hSwEJaxkOdVTNasm5o2okXB7badX pvASXqUu6bKaZeVwOkuJIDLW2vllZkiP2aDdrtg4WbyN9wagmbwWpV/sFbZkxx+2+bn01/ 93jKed4FG8KHuq+cnYj4RggwQKupceg= ARC-Authentication-Results: i=2; imf30.hostedemail.com; dkim=pass header.d=amd.com header.s=selector1 header.b=t8sKJ0fl; dmarc=pass (policy=quarantine) header.from=amd.com; arc=pass ("microsoft.com:s=arcselector10001:i=1"); spf=pass (imf30.hostedemail.com: domain of shivankg@amd.com designates 40.107.93.51 as permitted sender) smtp.mailfrom=shivankg@amd.com ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1744870202; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=76khvO0poRuCvreRg3JvNl1lJMM7D8X1ZRniHN8NBWo=; b=nQZQoFHO2XLVTY57C8XtB7fMriA/YLYZXXU//mOBGpzEKYEN/Yrvu0Twu0X12YiEuW9dmc zkJrfv8tn2/8H6uT2b9eAaAmbUfr6Sbl9fMJa7EHYNjvTRUfIm8mbYPKDSHcl5DvH54Y0t 13uYV3pF02AuWTALu/n27DGKH47lyJ0= ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=Dy1IZFaFrpKFj8960VZCJj9kZFMPTApM880PV0YNYD7IgvIMrBwk85by4CU/jz6UYnwlJL6+gFNCzQm8pTR6jzJVYUzox3DaPezL1AFZz37XKqDAWTP+eZP8VgJWZlvi4SWRvtLdIUY5+Hm9AP4shAWrEqOtvdXnaJB13lj6G7GMkx0JDVY5gE3BzB9fKKgaZTwSb0m53vVULtzvjWh+xs5PCqavCV75aFfDVUUl2B/WnwylIHfUj34+LmPS56TfHukhyeLHUklUuGzgAofdlw4ZzK/JLTmy+AKPVZskTVRipt9lLKnW7pF931yRiruK/diwaI36Z7GrmBa2cDGreg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=76khvO0poRuCvreRg3JvNl1lJMM7D8X1ZRniHN8NBWo=; b=xC79+9O7elNuVgfM9iTGeb6jHYHmSMItchRhav3VPjDjVBf8nwObJRYptN1RU9u286OnScCNjmgXlRASGNIycFOXmMqVtaMc1Vu6Kn4vTtFImeeWBOhpMUQwgSaINYKo35kFwNths/pXlZT82BjWrirEvLpGOvMeOqZW1ZifAP6US/IT54yTk9H3Mzbxhd0Xo4tbk6UmChjx1ZlIS62Dlzqjv0XwHCfuAO7ynYWPV85ZQb92MAEVXD0C2ikLhfrKBcU2M8njsdF1Ml2wiKRMwNZx+s/QMnnJ7eBcMaM8SuewbJpw5a8/95YcyBIlD1+xweyxfsbeVyvwkiEwsBkYxw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=kernel.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=76khvO0poRuCvreRg3JvNl1lJMM7D8X1ZRniHN8NBWo=; b=t8sKJ0flV8LXA+jZuPmw+hDWE5lVdHvI/M/IL5oBepj2f5LDkjyztTZK3ld2Os1bwuXOtO9H+YVILpm7dIx7PjbrJY07VlGxqg1MP7wdgigyW72V2Xu4S9fbjzOCuixgzGMpGdz48kfIrCIIfJewKia4/qVEtA0T+le8z/oI8lw= Received: from PH7PR17CA0011.namprd17.prod.outlook.com (2603:10b6:510:324::20) by DS0PR12MB9039.namprd12.prod.outlook.com (2603:10b6:8:de::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8655.22; Thu, 17 Apr 2025 06:09:56 +0000 Received: from CY4PEPF0000E9D7.namprd05.prod.outlook.com (2603:10b6:510:324:cafe::d1) by PH7PR17CA0011.outlook.office365.com (2603:10b6:510:324::20) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.8655.23 via Frontend Transport; Thu, 17 Apr 2025 06:09:55 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C Received: from SATLEXMB04.amd.com (165.204.84.17) by CY4PEPF0000E9D7.mail.protection.outlook.com (10.167.241.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.8655.12 via Frontend Transport; Thu, 17 Apr 2025 06:09:55 +0000 Received: from kaveri.amd.com (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Thu, 17 Apr 2025 01:09:50 -0500 From: Shivank Garg To: , CC: , , , , , , , , , , , Subject: [PATCH V3 1/2] mm: export folio_expected_refs for JFS migration handler Date: Thu, 17 Apr 2025 06:06:32 +0000 Message-ID: <20250417060630.197278-2-shivankg@amd.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20250417060630.197278-1-shivankg@amd.com> References: <20250417060630.197278-1-shivankg@amd.com> MIME-Version: 1.0 X-Originating-IP: [10.180.168.240] X-ClientProxiedBy: SATLEXMB04.amd.com (10.181.40.145) To SATLEXMB04.amd.com (10.181.40.145) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CY4PEPF0000E9D7:EE_|DS0PR12MB9039:EE_ X-MS-Office365-Filtering-Correlation-Id: 2984443b-8969-46d6-2416-08dd7d7679b2 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|7416014|376014|82310400026|36860700013|1800799024; X-Microsoft-Antispam-Message-Info: 0F+4f7Mnt2y2Q3ABxIXDv/2F1/RcVpkI16t4XxO30FjuWYyf7tpBWVKv7L7r83LlWe03C2cV2eYdvnUrLsjdKqlOR1/nsyHFiyn2kB26zeiy06VQ1IHmAoAOnumeVakEqCkeFZPIdaVOgRnyAejw0zKqCeB61CATfA+A6OgZqev3o/uLadZymaSF7ArV0e6hTq3uiv0IkTmPPX7SGFGmavxSY8qFQlg9d9KbaetSR+K4ftAQ6cr1uOnjJHlv526KJmGog1oW1gWy+VRapHugFw0uSj5rSzVpLLgz+/ChPH93to9+8lajTYputV0vBgUeTcGkqnVomdyjyMTQJbJdvM4hmTI3/QmiRXdl09pMJ0VCQc1LUKfMV2naO+Pbs1gp6zkB1FM3q1v2/Uske5cEtCW/FUcZJoc5F+/aUpMYJUoMv0Lf2fyH/hbx/mu97T0Qks1gM2dy+JJ1brn0LCT12ZGYl3H6fqj65F8aFkf5DIQ/sraNskT39IVXzFEGqLGYPGWZlBvP84Fppr9L9lzt/bMleAjkldy2DWUh2hQizDbgXKKhQHbIHs20TQNDGHaEx+Ruj04kZrFkDwz0VlmdgDk9Hll/mJPEoFrfsDGMvVE0BiG8zTsxC/CUZ8I1bSiw2FMhRqkMj1tyt79gT5NHoxP2j9MrwhKjEjjjiduR/W2k97wcUfyeSMUSZHEWdSIApamsw5oJIXTyz64o9a0k6EWPWSMNEGSlX74bMdjYHZosCHXNAssgPxFiTzcmxO6crzDc9WNHR9JnD6y7dC2EhlnFQ8+kZWsidH/Bo3XM2W6cJtrY8QHG33NqaDfZQyhMFUrGaLN8e76ux+0oS191R9MluVY1uaGqCSRLdZieMXBomgu1936pKH2f89Zcro03PedFXgdjxfTpA1Knxw9zoYSXzPGhF/a0FqOsBj+zhJAkxUPG/cTK7vOw8INgPV+n2PcVDV447nI2TnUixBEkc5aMsQFfezsZ1STRH1Y/yaGLscPAmDi/oGqDnHNPcQ6EdE6pQDgR2/O3ZyGbKTQODvstWAABGvQiTXcwG2VKba4E4/98OqocEJfOLDD4CEntHv6lpb3AxToqGvg42UDcCQ+u3ZgyJkU524QTqKyN1rP1R8v5zcF3w9ptdBPrKwvfwww95uNsaRhOO3bXgKznjMB4PPLa4U+W89FhOplh6QfOd8UCKqLYZjIO/YUFj/Q+iaHJCfQW8SxuIknyWJ0nIDYqHMU/u1l20EM6i9GDuf3e8t6NJCOVfOrBffzX0RIFPkBV8WWHPRkBeK0D8/E5mDeFKLPASt5BipitBr6rZOf1VXTqQpOXPloyrHvkw32Uuiaztr6seg3cH2aHmuGm9XjYE6sNuU0c/PRElWu6scgx9blxggpxp69svpX77q2vqzyio1M7Z07qEoD696JaAC+2pc1PN/RJcE8d1X14lGAdir/xh5kNq4141bZOg+JIIH5ChYM/L4jF2MwVzlFX3beZZ8eX338LPYizZ1hMrsgSERcllommrwHZWYnogJR/ X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB04.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230040)(7416014)(376014)(82310400026)(36860700013)(1800799024);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Apr 2025 06:09:55.6246 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 2984443b-8969-46d6-2416-08dd7d7679b2 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: CY4PEPF0000E9D7.namprd05.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS0PR12MB9039 X-Rspamd-Queue-Id: C688F8000E X-Rspam-User: X-Rspamd-Server: rspam07 X-Stat-Signature: b34jygg6qobw76wfcrzqacw3qxj6gfbr X-HE-Tag: 1744870202-159174 X-HE-Meta: U2FsdGVkX19f8G8A6Ma+SG+yI/D45PVRfOkHIBOodAPWwVJ0AM8hVpCfq89XDLg0jrPiiFW7l3UYfa1pjlmUrOUSObatiqooHdFr/3cd1Q1pmyqBa9xVOrNyj2LrelpzolcXnHj5RVCZ8F0XElcpA2CqCOYpmJ9HrBCrNX7lRZU3snP2uHoIt+uFLYXOkxu+DkOAUqackyFfh+J1yNAvBcHoOkPTUM/nNJcVw5gPWnUKBw+pXl64C2Kh4RydmCTEGly1Fibf/bGVqVkfuG1gyNr18nrhT03wtxdkJ1sotiYLF3NbV+C6Tf+GLx3nm0ePjrc6aG7rmTfe2C6Xb8kTkyosgovhYdndp9ITrTTO8FvRmTaM0YPhODoeOpKpG13VPWox0kSjz7QBB/LYkeejb2TrqyKQx1xG8wHzjgE9D3zAEvIzClqlFMt5TO9acSjMSVk3y8EPGHtyE1agHHo/xluWPPmVNVSfXxkgUJEmpTQo0FRawQKA8CzLoL8XVpEzVe8Hm099HEaT9M5CMOXOvcuH9HiTcyn3bzFhd4zNK0QHuadRPpqnFRB8+LKIzmSFjAVBJ5Q3/CfiyJge8PWtuPjQWLnZ5kqLCOkyXxUIoxFFF0ixcSDlL+W1Gm4tGQ7b8CD1etB0yqyzExPa3cmoO9j+/J6naaB4TCcQ90hrWTI/jM9EMFijQ4I4SG1Q4PwP6SQqMzaijfwE5aS47ziauS96KUdnz92xRAeN3LQCJ1+WQsh6CVh2tj9E/nOIlUt81FLZ+DTpf3i3aDIKMkygM1LyYDpj7lJSN06enQYtRK08m0Ydq6l0vVylMgwqTMwCAvTD21Egk6P1qJ6nh79DDvTYPl6lxOz/hD3oyX3xevdUo7FDmOFR6fWqw/wSi2hupXTKkWgFIW2TxoG7jCo8Fb/iAWpTATjPcwffOBEXkuhMOElp36PAFQpip+9wcOdpAxKaUJyDOY5gnEB0zfX s6h2N0pw xQNM+Pbdx6Er+PZLy1xVKY9DpyLBozMoLC62fi2v43Ia4rDIs2TIYRe32fiWcfY+oiuKX0Wq8NMSUZ+XI+1TYB/QO9jbMdFhav04aCjN2mE2xoMAZ0A6+O6xd7CShfD5kmWfILUifiAHagFmz12vG89Mgp1lr64cX2kIiqgyeNEMKGdM1Fcjh35nAr4OeCpZfa7RvQSZJ7nY6aTa9UA9E2+UKbG6eT/mQHsBGJz1pkLvr5kmJYpw5IX9FCPDUjxDQTrrmFYbaS6uj2UDXubDNguPeF3NcGr7Y07AIBQiJHhJKSJLnkDHUE3Byagz5oA5ZAjQrXje4hZilHZKMtrVNCR3Hsnxm6GRBL5txNPOE1oN/ZbeQEfKDL8E1MPx3T1pbFQ6Sfctr/1tF7Ym1m5yxIkZebxb+amSKt1no9KdnCd+TVmn1C3QOfzRdz5lY/hQAQ6mRZZPBR/puoVaAkmlDRLcMezZDHWw9OALBHCyI/sCmAdYKDv1AbI+vlukAuvHnRhGb5MhqVeqgQ8zMHwYHp8OLcSoD0nZ1uJBGi6urywK2zRJFHInzRgqI3tMz6tjm+JtMj3mWPU4OY9wk1ZSoMUEEHWnrAMx/i/U+5MdXunKARXvfqw66lpXhbzkvDxW6w3LQ7rynhT3FQFU= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Export folio_expected_refs() to allow filesystem-specific migration handlers like JFS metapage_migrate_folio to properly verify reference counts before migration. Signed-off-by: Shivank Garg --- include/linux/migrate.h | 1 + mm/migrate.c | 3 ++- 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/include/linux/migrate.h b/include/linux/migrate.h index aaa2114498d6..cb31c5b1eb6a 100644 --- a/include/linux/migrate.h +++ b/include/linux/migrate.h @@ -60,6 +60,7 @@ struct movable_operations { /* Defined in mm/debug.c: */ extern const char *migrate_reason_names[MR_TYPES]; +int folio_expected_refs(struct address_space *mapping, struct folio *folio); #ifdef CONFIG_MIGRATION void putback_movable_pages(struct list_head *l); diff --git a/mm/migrate.c b/mm/migrate.c index 6e2488e5dbe4..0f01b8a87dec 100644 --- a/mm/migrate.c +++ b/mm/migrate.c @@ -445,7 +445,7 @@ void pmd_migration_entry_wait(struct mm_struct *mm, pmd_t *pmd) } #endif -static int folio_expected_refs(struct address_space *mapping, +int folio_expected_refs(struct address_space *mapping, struct folio *folio) { int refs = 1; @@ -458,6 +458,7 @@ static int folio_expected_refs(struct address_space *mapping, return refs; } +EXPORT_SYMBOL_GPL(folio_expected_refs); /* * Replace the folio in the mapping. From patchwork Thu Apr 17 06:06:34 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Shivank Garg X-Patchwork-Id: 14054949 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id CDDFCC369B2 for ; Thu, 17 Apr 2025 06:10:28 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 44A58280122; Thu, 17 Apr 2025 02:10:27 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 41FFA28011E; Thu, 17 Apr 2025 02:10:27 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 29AD1280122; Thu, 17 Apr 2025 02:10:27 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 0900428011E for ; Thu, 17 Apr 2025 02:10:27 -0400 (EDT) Received: from smtpin05.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id BACD3160E35 for ; Thu, 17 Apr 2025 06:10:27 +0000 (UTC) X-FDA: 83342511294.05.105EBBE Received: from NAM02-DM3-obe.outbound.protection.outlook.com (mail-dm3nam02on2056.outbound.protection.outlook.com [40.107.95.56]) by imf10.hostedemail.com (Postfix) with ESMTP id CCE0FC0005 for ; Thu, 17 Apr 2025 06:10:24 +0000 (UTC) Authentication-Results: imf10.hostedemail.com; dkim=pass header.d=amd.com header.s=selector1 header.b=LOtTnpuE; dmarc=pass (policy=quarantine) header.from=amd.com; arc=pass ("microsoft.com:s=arcselector10001:i=1"); spf=pass (imf10.hostedemail.com: domain of shivankg@amd.com designates 40.107.95.56 as permitted sender) smtp.mailfrom=shivankg@amd.com ARC-Seal: i=2; s=arc-20220608; d=hostedemail.com; t=1744870224; a=rsa-sha256; cv=pass; b=OFd7YAp2w6KN2kT+cMrVqhEwB66SGYsjCRK3dQX2PAcWzwTxPHsv9NT2RyuDB4yOL+Jzt3 phUiBllk8UubhFZbAsH4/Idw2Up/hLckoBYj7heLDsuPiHi1cZAv/FaWscOZI1eMk2SeFs QJ9b8UUlW3lUnA+G8oR1EljFLpiIFAA= ARC-Authentication-Results: i=2; imf10.hostedemail.com; dkim=pass header.d=amd.com header.s=selector1 header.b=LOtTnpuE; dmarc=pass (policy=quarantine) header.from=amd.com; arc=pass ("microsoft.com:s=arcselector10001:i=1"); spf=pass (imf10.hostedemail.com: domain of shivankg@amd.com designates 40.107.95.56 as permitted sender) smtp.mailfrom=shivankg@amd.com ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1744870224; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=y7QQ4PRCsUbYHEX8v5XuML6LSHV9JQqcocqGFMNAD4Q=; b=WxS8Xu6RPNHSL2wvRuNd12sUUCHhSVajsDvwO9P2dftETVcNC+pwPAaP3/X+aIaG8ta3QA 8aDvjH5b0VYd8ZH0THfUQywT8+wQM3+/ZD0ouRVESnLrsWT86T6QbdPEbWXm3PV27+AxL+ 0r42BEn3rJvnBXTePmzSfCwuSFa26Ks= ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=BopvfqRXp6+d5IZX25j8V70GfERtOIM6ayd0aSKO44XrO9swgyt75Fsk/pQ2EwmP/R8oyXWAUjO1Tbw6HazZjQZqfeEJbtEfnjVe6qr05Kcs03DRntifIzNMdcbD0fYkz9kHhYUUrQFzgqIebSIQ7HZXtEJrFTQhHaLqF7fVaShgjlDnUg7ikD+ILX60KkiTx1AWq3WTvySDxChfP1jUET9h5rjlUAU/Sz5aqDAUjA81LYVwFsfYifcyBRRuIYMm363vEfEBWVPLBubu53yHMY1fyt7z0pgCqT4igHx0JzmmNPFCMu7ou5QXy3SEWi+d6cWGk320XknnXAMOtiiWwA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=y7QQ4PRCsUbYHEX8v5XuML6LSHV9JQqcocqGFMNAD4Q=; b=IW31mlwTKJEkex/Kcrr3mdceHe8deOiQo2vLwCAWqKXXQwKnJXuexH5vNFyuA+egpPwsAiDMBUlzDX1a3ZvUUc+RO8NSzrG00sl3mlurV2FeNsOS6JnnLpM6sQ5o+iNEZGLBZ+DtODszk/9SFRdYZlPy3BN0583Gsk7flHLyPSAvmpifx1dQ1Bjh3OHzpwGP31iG1Na/6sR0FxJo82AsG3TKVh3I2ZdfuG/ZuJRMR492A9/cYeR0mZArUYT5xDTNmnVGBQemuW3dsxVW8wZm9oeYkuDhO8M33SKRq6zznzA9YMXrXimcBqEKOS9WIZndX76vqTw3gHrXE05cS0R1pA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=kernel.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=y7QQ4PRCsUbYHEX8v5XuML6LSHV9JQqcocqGFMNAD4Q=; b=LOtTnpuEB8d7eBcFoRCztiBokv1R9Q2K6EivJmY78tnf/egnenEn3eJ2AZXskcr19EtdhfdNL9gvymcsXauSQaOSdyUYy+mkG0aNt1u8bk5RKrTmFnl8chNaVm/Y+oj2smBQ8+/tW/+TPFTEph/FZKLvJs4SGu19n0K+VBadfR0= Received: from CYZPR17CA0010.namprd17.prod.outlook.com (2603:10b6:930:8c::12) by SJ0PR12MB6927.namprd12.prod.outlook.com (2603:10b6:a03:483::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8655.22; Thu, 17 Apr 2025 06:10:19 +0000 Received: from CY4PEPF0000E9DC.namprd05.prod.outlook.com (2603:10b6:930:8c:cafe::91) by CYZPR17CA0010.outlook.office365.com (2603:10b6:930:8c::12) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.8655.22 via Frontend Transport; Thu, 17 Apr 2025 06:10:19 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C Received: from SATLEXMB04.amd.com (165.204.84.17) by CY4PEPF0000E9DC.mail.protection.outlook.com (10.167.241.75) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.8655.12 via Frontend Transport; Thu, 17 Apr 2025 06:10:18 +0000 Received: from kaveri.amd.com (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Thu, 17 Apr 2025 01:10:12 -0500 From: Shivank Garg To: , CC: , , , , , , , , , , , Subject: [PATCH V3 2/2] jfs: implement migrate_folio for jfs_metapage_aops Date: Thu, 17 Apr 2025 06:06:34 +0000 Message-ID: <20250417060630.197278-3-shivankg@amd.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20250417060630.197278-1-shivankg@amd.com> References: <20250417060630.197278-1-shivankg@amd.com> MIME-Version: 1.0 X-Originating-IP: [10.180.168.240] X-ClientProxiedBy: SATLEXMB04.amd.com (10.181.40.145) To SATLEXMB04.amd.com (10.181.40.145) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CY4PEPF0000E9DC:EE_|SJ0PR12MB6927:EE_ X-MS-Office365-Filtering-Correlation-Id: 4df3a607-488c-4968-b090-08dd7d76878b X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|36860700013|1800799024|82310400026|376014|7416014|13003099007; X-Microsoft-Antispam-Message-Info: llVlJuyOhC0d2yV9c0yIG9ftgooYdUDZPFJND89RECUKc0iIlUnFLeDnKa5hx4Sth66NEyzOs4Sb5yELKXsvUI4Bo1/hAQ4yCM5iX3ArgjDPM+c834JUOtYOzqx13ARmNirG2B1AiVbNqbspVnqi7QW1Q761HKhHKhhy3udjztBTJqH1Hf/qMYxr2x8m6xKwwxWG/JqwcvLlb+GxnI7ZQh46XqW+7FkVUPmmRWeJYTyzgHV/Evt9RjzDw9/ASV4qveYWjbe9/6QtdGW45lpSMtfEGGamZ/VsAX8nLylH/XnXMeVZuPYLhG1yVB+gPg+R1ZJyWDv+GV5Jl/JMNUdKPfOrO46qTTuVnM/tfJ9PC6zFXO+7k+X6OwQh2faDWYC/pmi/lvfaVTtU++EhLuEkW8aH0WlgakrvlkmZ9DhDFI8qMjGfFr/39DPlslFzKrMv9n+o/rvNBR2n4YPAVbk0w40o7JG8IiiTh6SRWwWPgkv+VrVWv1RqV5IKlETRJjE2K3qRUuDINg5VbKsmO9Rg9Zpdx935D/dzYzi6sxNovld6EXsYVHQUOeQtBCx2G8nI3JuzJAXdsX0O8PYP/6VYrpFc7+rth7DSAINqRofskiu62Whd91BzGmGfEEx8izvaMXEsVPHuud56Oi0mUPiZe2y8f8Yug4Dndj84+VxpQvzm38IqyVnr5JPSx+MxdkmTA0CDZKYLxs1RaiLPNIiWpEz+bCM5Qlpa5lBzFY+IUcWyuQjK4BHrIcOxfx1dGZRFSq1vLrZC5Fa0gTgm67VSigOUacAF42dnf1R2thWUmEjKeD13Q+MXZBDrXksjNpc74STyubfkxW1P+Jfjkp/fJyQQoe4pR8jJjckWbiAV1pqLKDe8TQPqaOPXVgA6S+f/sK0KtBYnjDaxxi9FuJkdtbRwxT9rYW9ANVWCLia3EtX+2a+wuLQuhmy5J5jg9QQHiUdNmqBnr8VDxFEowpFn+PdIiWeDSzuY8IDyGbs3uMBTLm1LbJSggZUgLJqX+h0OkiAP+oGfalnHZ5d+c9u3DC9ycQYXJAE7G5CHN3FwikNQKcmnfFU/E6coFadAo7nZTTMPZoxwtq3TxL87bRhIFvX4gHWtIrcnTfxMu3aD7t+hAFnHhlsb8aDRAK2gRT1O6/xzhiD0dOO+lpF7iqXSO8S/8V00PhGAmLKmVUgBWIx5XYnrdBtn+LnVHKYgPkT0E6R1qBLkzkvGq5la05y6B/Ij2LajDt4sSv3Bg7XxP5edPSjstar8wD6IQrruQukj1TWSz1Ivt7cm5u4CA6PqAKXbyKKz6D9TA8iT0v8ZjvHwWWDlD0osOVRfyNG7X30tQyi3z8ZtvhOoQerYiymwaPa21X7JieRCQK+Chuk0K0aHGDyfK9TKSXRg51S90dwB+NuMGBhIkCNaNgG4+1AxQ0+P3EDXzpM70n0zGOYMmWTwhWFKixK+TzjL6LFWPrradn2mKR+eBiQ/nBmc4Ei7gwt9Tzk0wnTkAv5d2bUdjcTJPhjiWKinkn4VSCbBOlW4fhoG1X0Lp9EEdqGWSzhPuA== X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB04.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230040)(36860700013)(1800799024)(82310400026)(376014)(7416014)(13003099007);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Apr 2025 06:10:18.8607 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 4df3a607-488c-4968-b090-08dd7d76878b X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: CY4PEPF0000E9DC.namprd05.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR12MB6927 X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: CCE0FC0005 X-Stat-Signature: uikappzbruitj8mjci5m81kwckk3ar1p X-Rspam-User: X-HE-Tag: 1744870224-689775 X-HE-Meta: U2FsdGVkX18qdOrDbWhnfJ5agzw4EXGqZYy0t2uqcSuAiIiwR2Sx/LtVf6Jhw+Pn666v1oWL1SkWUgqf4aSdbdibfD3uYqhDVqVVlCBiNHgtE1UHBiVTRUON0gNWiubWjaRcrxcqyvXXnSRzTS1Q4zJFWNypdq2OGIlzGL5pDGq7OsUr4rjIPUCANmdBdfadgaNp+2rNo0qKZz/XvphdT+ODQzbZq89+gpWgWLe8auCVTNfhqFm3xQxGPuf8jNmahUWD+nBQBKiZM8wXSsDsB/nm/J3YFdgLP6mMW1AOUioXhbJRp2efJF//Rf/JBm+irryuGY9FgRPo/5PTMCHU5lLO/CZgZVVxpQN7TAXrZeDVwBZtrN/SgmT7YoRflHey1zpEVaeXgnV0ZlKh8XRu+CqWQmYD/z0snxlDcYVmc6MeMubfc+L6STsoP+N8mISzfiEk9pXtn44q0tWHEwJoDkcJMi/slxQuu50C21LG7o+0KLW/UAJkchW5UAWNUAMwQ1am7QBby46KLDSJuaVN6A4AB5DASQw1nnYYRHFWUfPOnZGYm2qYbKsbEGXMZ/T7p0UtQvr6Gf1Kr4lIE09zYnk2vNYomHHoe7kBTMW6pGj4mKIZAjWfdcriXg7VIPUEuC/jolxWios44NZPZBbQ4kPOQX+2AdFPpXeBIBMQ3ndd8pYlFtI5YzbQBUrHzoaFek4iln1zEoTUcws8W/g3QNVxb9Tg6puXTzTNcaIaFGU7dGEMzf4fYnSSBJSyFgsgKexrESWKn7ze5OJMloTbaYkgUKL8+kX5B7+KFtG9ojoaA+JV9NyW/bgqin7bN7ck+ZUfkwKLY7mAaDgheq3X67KVZqVkUCRrHmb7Mtb0sVe77IFDo4Vxsne5jS0yM44afjNFnyBWyLRpvc4zNM2oY5tmwp90G0UAdEH+lYbV+4MfOrH3xlCliI6I1c6r54rS8mM9qzcwL7bOlUtC+Wp /Xt+FnBA 7RiuBSOyfeNv9/jb9TGD4K0o8o9FMrzRfKE+hjcAVheu7XfqIhd/2DHExoUFuk0KjvmbKArW6kGBVtaYC2SQxD0P6Q6OvFzczyWsy4CcY0zBtq0buqAL/Bk5F1tV5mi7RZxFrPNdOSHa7xFnAQ14tru/UROGc2WASc3u7xTAIGUGtOajRAIPrIJTi0cwpQyQudwIVZv6JMPIlmIc7TShxjVawiVWgJJwlY04QCAaQvzrORUkNu1eMOwAVV8sK+wpPwdOgg8KLpUM2Z3b9la9Z1cGRtiK524BTZTD/XJYg00nIW0NrEw0Kc7vzVDHojk6L1jXASBUT10UbsrWyXbCo5HvQVNaXvAVpwVK+j7XEO5gXGIbJMJ2Q21F/dUjKAy8mng9IKPdcCEzRm3dtcTpQmSfs3kiF+qdYaqt5ZIZtviBkYTq4hyAfmg8si8jEbIzpukKjVN9ExW6d1IwrsB8x3rVd5i8zirizX//1DpvEXkly5p3XwvV/o9MJL5CGEpxL9s3JeezUNUfoVdVRE3SbnY8Xa7mcZcH4OeqpwC4Zluh0brah7+RSIFiFxSBJ4Tj0NwDNCCTsh86c/rKOWzL32WVZuK+KxAPG1snUE9sOm8UWhzzP72gqLx692AU0YErlEaxRqp0KiFnao/ckpzFDXzcnGJVzlI8Wc5FKWCEKL0vm9XlxznqM2+pvmu4skTIAhPcr51kph6Tp2FATZIP46iCVto/HchRh5HVUV920e6mOLLJJAmezIdUQow== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Add the missing migrate_folio operation to jfs_metapage_aops to fix warnings during memory compaction. These warnings were introduced by commit 7ee3647243e5 ("migrate: Remove call to ->writepage") which added explicit warnings when filesystems don't implement migrate_folio. System reports following warnings: jfs_metapage_aops does not implement migrate_folio WARNING: CPU: 0 PID: 6870 at mm/migrate.c:955 fallback_migrate_folio mm/migrate.c:953 [inline] WARNING: CPU: 0 PID: 6870 at mm/migrate.c:955 move_to_new_folio+0x70e/0x840 mm/migrate.c:1007 Implement metapage_migrate_folio which handles both single and multiple metapages per page configurations. Fixes: 35474d52c605 ("jfs: Convert metapage_writepage to metapage_write_folio") Reported-by: syzbot+8bb6fd945af4e0ad9299@syzkaller.appspotmail.com Closes: https://lore.kernel.org/all/67faff52.050a0220.379d84.001b.GAE@google.com Signed-off-by: Shivank Garg --- fs/jfs/jfs_metapage.c | 94 +++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 94 insertions(+) diff --git a/fs/jfs/jfs_metapage.c b/fs/jfs/jfs_metapage.c index df575a873ec6..8bf33c0a1b8c 100644 --- a/fs/jfs/jfs_metapage.c +++ b/fs/jfs/jfs_metapage.c @@ -15,6 +15,7 @@ #include #include #include +#include #include "jfs_incore.h" #include "jfs_superblock.h" #include "jfs_filsys.h" @@ -151,6 +152,54 @@ static inline void dec_io(struct folio *folio, blk_status_t status, handler(folio, anchor->status); } +static int __metapage_migrate_folio(struct address_space *mapping, struct folio *dst, + struct folio *src, enum migrate_mode mode) +{ + struct meta_anchor *src_anchor = src->private; + struct metapage *mps[MPS_PER_PAGE] = {0}; + struct metapage *mp; + int i, rc; + + for (i = 0; i < MPS_PER_PAGE; i++) { + mp = src_anchor->mp[i]; + if (mp && metapage_locked(mp)) + return -EAGAIN; + } + + rc = filemap_migrate_folio(mapping, dst, src, mode); + if (rc != MIGRATEPAGE_SUCCESS) + return rc; + + for (i = 0; i < MPS_PER_PAGE; i++) { + mp = src_anchor->mp[i]; + if (!mp) + continue; + if (unlikely(insert_metapage(dst, mp))) { + /* If error, roll-back previosly inserted pages */ + for (int j = 0 ; j < i; j++) { + if (mps[j]) + remove_metapage(dst, mps[j]); + } + return -EAGAIN; + } + mps[i] = mp; + } + + /* Update the metapage and remove it from src */ + for (i = 0; i < MPS_PER_PAGE; i++) { + mp = mps[i]; + if (mp) { + int page_offset = mp->data - folio_address(src); + + mp->data = folio_address(dst) + page_offset; + mp->folio = dst; + remove_metapage(src, mp); + } + } + + return MIGRATEPAGE_SUCCESS; +} + #else static inline struct metapage *folio_to_mp(struct folio *folio, int offset) { @@ -175,6 +224,32 @@ static inline void remove_metapage(struct folio *folio, struct metapage *mp) #define inc_io(folio) do {} while(0) #define dec_io(folio, status, handler) handler(folio, status) +static int __metapage_migrate_folio(struct address_space *mapping, struct folio *dst, + struct folio *src, enum migrate_mode mode) +{ + struct metapage *mp; + int page_offset; + int rc; + + mp = folio_to_mp(src, 0); + if (mp && metapage_locked(mp)) + return -EAGAIN; + + rc = filemap_migrate_folio(mapping, dst, src, mode); + if (rc != MIGRATEPAGE_SUCCESS) + return rc; + + if (unlikely(insert_metapage(dst, mp))) + return -EAGAIN; + + page_offset = mp->data - folio_address(src); + mp->data = folio_address(dst) + page_offset; + mp->folio = dst; + remove_metapage(src, mp); + + return MIGRATEPAGE_SUCCESS; +} + #endif static inline struct metapage *alloc_metapage(gfp_t gfp_mask) @@ -554,6 +629,24 @@ static bool metapage_release_folio(struct folio *folio, gfp_t gfp_mask) return ret; } +/** + * metapage_migrate_folio - Migration function for JFS metapages + */ +static int metapage_migrate_folio(struct address_space *mapping, struct folio *dst, + struct folio *src, enum migrate_mode mode) +{ + int expected_count; + + if (!src->private) + return filemap_migrate_folio(mapping, dst, src, mode); + + /* Check whether page does not have extra refs before we do more work */ + expected_count = folio_expected_refs(mapping, src); + if (folio_ref_count(src) != expected_count) + return -EAGAIN; + return __metapage_migrate_folio(mapping, dst, src, mode); +} + static void metapage_invalidate_folio(struct folio *folio, size_t offset, size_t length) { @@ -570,6 +663,7 @@ const struct address_space_operations jfs_metapage_aops = { .release_folio = metapage_release_folio, .invalidate_folio = metapage_invalidate_folio, .dirty_folio = filemap_dirty_folio, + .migrate_folio = metapage_migrate_folio, }; struct metapage *__get_metapage(struct inode *inode, unsigned long lblock,