From patchwork Fri Apr 18 09:55:59 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ye Liu X-Patchwork-Id: 14057120 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3D1A3C369C9 for ; Fri, 18 Apr 2025 09:56:16 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 7F588440009; Fri, 18 Apr 2025 05:56:14 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 77B19280159; Fri, 18 Apr 2025 05:56:14 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5F843440009; Fri, 18 Apr 2025 05:56:14 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 3B7CD280159 for ; Fri, 18 Apr 2025 05:56:14 -0400 (EDT) Received: from smtpin08.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 1D81463E43 for ; Fri, 18 Apr 2025 09:56:15 +0000 (UTC) X-FDA: 83346709110.08.447D1F6 Received: from out-182.mta0.migadu.com (out-182.mta0.migadu.com [91.218.175.182]) by imf08.hostedemail.com (Postfix) with ESMTP id 4D5C5160005 for ; Fri, 18 Apr 2025 09:56:13 +0000 (UTC) Authentication-Results: imf08.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=eGDAELos; dmarc=pass (policy=none) header.from=linux.dev; spf=pass (imf08.hostedemail.com: domain of ye.liu@linux.dev designates 91.218.175.182 as permitted sender) smtp.mailfrom=ye.liu@linux.dev ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1744970173; a=rsa-sha256; cv=none; b=pusi0FgNQ81WlrS+jQxyHBVvBhhjqSPxyhyWPW1F/GoZQgYbS6JsOdrHBut0cOlovaLdgz 6Tkyo1LdUntLz7cNddYzxoz9ILWZ6K5jwvPk3nLOHR85wJnDteN+r1LkmWbUE3z05NyNvR dMNYgn5YFUz3oR+6m0zSDMEdRzGKK8U= ARC-Authentication-Results: i=1; imf08.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=eGDAELos; dmarc=pass (policy=none) header.from=linux.dev; spf=pass (imf08.hostedemail.com: domain of ye.liu@linux.dev designates 91.218.175.182 as permitted sender) smtp.mailfrom=ye.liu@linux.dev ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1744970173; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=OBuEFz8FseY66OhdFa8eDqvIegINB5zk/KQ3fZF4sJY=; b=Qw/OoD6NcsX0ka8YA+bvF8fHn1FsQ7BnsRiUkW22qJqrj5OJUz9mRM4jelLFKGYBEMICbx HPD6d5hToaF70HbCDuyU0iPLMGhKUnFfWbKrfF5VvmREfXZ8A1nLoAI/HhEExyhq/OOi6a jew76F2q/p1faO6rPR55yS5s5sIx4fQ= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1744970171; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=OBuEFz8FseY66OhdFa8eDqvIegINB5zk/KQ3fZF4sJY=; b=eGDAELosMUAD5BaGg9cc9dAakH4IyAztwtxaTwlLa+bELIKJWLThYPMimNn797X3lLKCVF PBqZrU1Dj90s0yoyblf6ufcs+xLL+gNoptqRiIryjvmjXMY06V9TZ6NxlEqUpdNJx9aifQ PxiMh2NoYzoYRj05gLypTyT2+GGvlTY= From: Ye Liu To: akpm@linux-foundation.org, nao.horiguchi@gmail.com, linmiaohe@huawei.com Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, lorenzo.stoakes@oracle.com, Liam.Howlett@oracle.com, david@redhat.com, harry.yoo@oracle.com, riel@surriel.com, vbabka@suse.cz, liuye@kylinos.cn, ye.liu@linux.dev Subject: [PATCH v2 1/2] mm/rmap: rename page__anon_vma to page_anon_vma for consistency Date: Fri, 18 Apr 2025 17:55:59 +0800 Message-Id: <20250418095600.721989-2-ye.liu@linux.dev> In-Reply-To: <20250418095600.721989-1-ye.liu@linux.dev> References: <20250418095600.721989-1-ye.liu@linux.dev> MIME-Version: 1.0 X-Migadu-Flow: FLOW_OUT X-Rspam-User: X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: 4D5C5160005 X-Stat-Signature: ekfphuu9rpbb6pcz84jqcnngw353btmn X-HE-Tag: 1744970173-447460 X-HE-Meta: U2FsdGVkX18RM7oegKtP2vLGiwBBZaITrIIwDPHmg3bMK3KgLOzjSwe+u20Mvy8MWn56w2v/+COv+DmFcI6M+ABjgjR0WqkxF9nMGM2DODATFn7WSNpfiMckneCLb1DEzEXOkt2UK5plL0BZW+M5dyDmiTyCkeOn/YGiBQUmbQXOG6iS+UdPlLom3FO26Y1IvgUMuttF7pYBTZC5jXbrGU2wss30y8bqRYwOEySeUc/UgsuJEc5VPqyfAlI/MgVchrxPcqYWsctjPgmIStXZjI044YNrptMykTbdssQE1OdzBNT2RzRLfnGtFvcYb7AEMpUr/4cBz40o/Il1rUDLEjna1XlKDdYp3PFLIPRYFokbL1JU+lDw2jTr6xS6JNNgm7+Ma/sAvdaLf7s2eY4lXvnPnH0b306D34mtTFXJgTaTtNVWD2tcCTnE2H+b4/2jkSWlIe8LU/eVsusgFrXu+MtSFKDwW8/82Y7i5wnW2GnqABb1WYErs6ENqwEgoRBXI81WiE9/FG0B0NqRp9xNX5ao5tSXuQTt5ImVxofUGc6auVI/Uga4YJTEH0UwgLy6CxDwezN6GBTkEfGskp4ieV+z6edSUE9IV+neFnpLN0Wt9S/xSKG6AwUuYnFT3vxT2W9bt7lnaK3ekF3xHdqn5HIyd3ULtqyr6Pd0EMejWc1nEH7+iWbRRDe1mjydV5e+MbnRM1ghEmNANOpvpaij29r5UbGLRpW18MbMkYS1K8beHdKb0GwSZ5K8VtuLY4bIC2TeaRh26oxl4t253eHcNCvI40sRxrgScpZzbnIMnMmSJUcmdm4O5joescSmSLasogBIIgMCTKPurszUvI2JXQHyRWNlWfCNoUJBCtaPb35DUSGtnZ5X/s16LJevTgg3bstUTh0f9ZTLLhVFK5LHndq1peBKDg6JePCasFuFqeeyAbII/wFG9PUZcZalVuI3adZeKZ6RxBN2uJ0Mr+Z o/KthAJC NglvonPicsC4cDiWx6Z25Jxy18E5Mx94MBc1HoPhGPSICCLqses9Ad2PAWv7k4+41aUMlXTx27xM+i+AtxCICQqCF50MxQBO1EpGnALFPhJeVsT5XMyTlGEeaoFWmn3ShutP5SvkjYvfZlyHEoK7yk+YF2ttWNjZuA4VST7VndYfuVGlxqoxZ059twTHcjYdUqkoZ/CDQmhtxxZPEuegxSLiLyhRwGB9O7fp9Awn/xh0GE5KVQ4FHkqkhtI/1MWcoDerdcReHzNqgMHEB09bDDFTnIItmoWfFlkU5 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: From: Ye Liu Renamed local variable page__anon_vma in page_address_in_vma() to page_anon_vma. The previous naming convention of using double underscores (__) is unnecessary and inconsistent with typical kernel style, which uses single underscores to denote local variables. Also updated comments to reflect the new variable name. Functionality unchanged. Signed-off-by: Ye Liu Reviewed-by: Lorenzo Stoakes --- mm/rmap.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/mm/rmap.c b/mm/rmap.c index 67bb273dfb80..b509c226e50d 100644 --- a/mm/rmap.c +++ b/mm/rmap.c @@ -789,13 +789,13 @@ unsigned long page_address_in_vma(const struct folio *folio, const struct page *page, const struct vm_area_struct *vma) { if (folio_test_anon(folio)) { - struct anon_vma *page__anon_vma = folio_anon_vma(folio); + struct anon_vma *page_anon_vma = folio_anon_vma(folio); /* * Note: swapoff's unuse_vma() is more efficient with this * check, and needs it to match anon_vma when KSM is active. */ - if (!vma->anon_vma || !page__anon_vma || - vma->anon_vma->root != page__anon_vma->root) + if (!vma->anon_vma || !page_anon_vma || + vma->anon_vma->root != page_anon_vma->root) return -EFAULT; } else if (!vma->vm_file) { return -EFAULT; @@ -803,7 +803,7 @@ unsigned long page_address_in_vma(const struct folio *folio, return -EFAULT; } - /* KSM folios don't reach here because of the !page__anon_vma check */ + /* KSM folios don't reach here because of the !page_anon_vma check */ return vma_address(vma, page_pgoff(folio, page), 1); } From patchwork Fri Apr 18 09:56:00 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Ye Liu X-Patchwork-Id: 14057121 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8E679C369AB for ; Fri, 18 Apr 2025 09:56:19 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E17EF440147; Fri, 18 Apr 2025 05:56:17 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id DC568280159; Fri, 18 Apr 2025 05:56:17 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C6A53440147; Fri, 18 Apr 2025 05:56:17 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id A18CA280159 for ; Fri, 18 Apr 2025 05:56:17 -0400 (EDT) Received: from smtpin22.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 83D4FC147D for ; Fri, 18 Apr 2025 09:56:18 +0000 (UTC) X-FDA: 83346709236.22.7B944FC Received: from out-186.mta0.migadu.com (out-186.mta0.migadu.com [91.218.175.186]) by imf22.hostedemail.com (Postfix) with ESMTP id C207EC000D for ; Fri, 18 Apr 2025 09:56:16 +0000 (UTC) Authentication-Results: imf22.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=nV2Dgi2j; dmarc=pass (policy=none) header.from=linux.dev; spf=pass (imf22.hostedemail.com: domain of ye.liu@linux.dev designates 91.218.175.186 as permitted sender) smtp.mailfrom=ye.liu@linux.dev ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1744970176; a=rsa-sha256; cv=none; b=UTB1Ck8TRqCtxaPOsSZTvHXp/yOULutJRYjpNECuM6vVVVtJFqe2/1ByK5bN9+Pb051PMD 35z48sWoAdspjhq89QQbNNsq2u/yUlmADw+h2ACUg0a2f7Y2ZhxUtiD1dJQ4sTQpnkZ8JZ /P86Fr27EOPXulkFW0rrYWobtkuZwAI= ARC-Authentication-Results: i=1; imf22.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=nV2Dgi2j; dmarc=pass (policy=none) header.from=linux.dev; spf=pass (imf22.hostedemail.com: domain of ye.liu@linux.dev designates 91.218.175.186 as permitted sender) smtp.mailfrom=ye.liu@linux.dev ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1744970176; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=oGO08xLxOYFwCfCougkQzxDVIQkhT4UpNDlADOdXRwg=; b=HFUWo6OgysofnIljcQDJKt8vwhmHbZsZzY8jh34sWKyBBeZMNUQMiRSH1R0aekLKfvCJGl 8wL+E6Z61caReV14LAniEOicMUJn2fZCUtj6406YdAu8doFcfFj2omrXC5qxIIzDmTlzt8 AHtvceFeOIsG5hicR233h/hi05NUP/s= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1744970175; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=oGO08xLxOYFwCfCougkQzxDVIQkhT4UpNDlADOdXRwg=; b=nV2Dgi2jGfZeEa/GVr3gLRUCxK0hfFB3KQB52i0/xewU0X2qg90lCUqafrPQ1jdjDA/q/a IXA6abaerCkiLduWWL09cymItVyH2TSF1JMDiEVOBU79YjSuQrM0mAjAAIwxNNaWRwfFut 5vSsZWlsbnYoUItGRJiDPmaD5b+OUL8= From: Ye Liu To: akpm@linux-foundation.org, nao.horiguchi@gmail.com, linmiaohe@huawei.com Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, lorenzo.stoakes@oracle.com, Liam.Howlett@oracle.com, david@redhat.com, harry.yoo@oracle.com, riel@surriel.com, vbabka@suse.cz, liuye@kylinos.cn, ye.liu@linux.dev Subject: [PATCH v2 2/2] mm/rmap: fix typo in comment in page_address_in_vma Date: Fri, 18 Apr 2025 17:56:00 +0800 Message-Id: <20250418095600.721989-3-ye.liu@linux.dev> In-Reply-To: <20250418095600.721989-1-ye.liu@linux.dev> References: <20250418095600.721989-1-ye.liu@linux.dev> MIME-Version: 1.0 X-Migadu-Flow: FLOW_OUT X-Rspam-User: X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: C207EC000D X-Stat-Signature: 9n5coywtgtebdxni1d5np6rseu153p4d X-HE-Tag: 1744970176-149313 X-HE-Meta: U2FsdGVkX1+MX/60mVqnBpUvW2H1r4p9RgtABtKGB4CpAQh5Wd0YnsT1lkI+97EgR4wdtWIJtel+DxKDXjchaZyAufhFi7BVg8PYI2F31eOzyxmmsAZSvqicJlreXcxjVt4o94mVERInxAZhJiL4rhZZu40aZ+kxPvVYHmY4sqQd4E7DaybLnkN35JEiWv8rR2LlCU2SxeeR50mWieMyLwXhIqQijKZrmwB1qomGS2uuZxbsFxjpqRxbeDhd3t+65jj8QvL/spiX6FDnDURmBgEM0ZYg46YfQ+kVnn3LJeRzlkmxad7jl0a35m+vD+wtrxiw8XR4mY/IRpI3n113LNptE7PNxIx59I7F+GIinjyDm3eSwsCU9d7lpONiNz70C2YS8pQHMWgkq99Cdj5/t8hvOje/XD+ZNN6TIckr/vqJwZGI0wvSk1iutqGj0rGGWAO45gQLieh2n+UZZ+CgP9yoST0N9uClduiICOAx9jS67nBaqZ1xyuESob7VzyydAnbxX3qHh4C8ygtZPg7XHJ3gBaf1u/RWMzmod209k6UY/M2e3ZSqDO9BEXMogRLK7VvnlpPzTXS4jd1hpbyY1i84i1V8We62N0Q/HBeGYhDcumqdEMeGfGZTKp4y4LnfCBm4oCEeJoode8BDzzX6X2nMWKtte7ZqKkbDmOYNN5hmFtg4MSMeZOiRhYPN6owuzoz2wiQo9gpeZHYxn562r7iEx/tCofajDWkqU3z/VAN4qoU0RPBGzPkDuv2ElW/+GjKQnoYLlcDUPKnA0T74bDMnszAGYKH0YusUMDl90Aw0xQiHRPVVW+DQ1rGx8ZSb5f95ZJifMlih6StMU+7dtXVA0DcegY+6VXYuqY3kOz87ZHATE2vIRqBxohQABRYiyUk+LycRXZdZ0/EbiVBz9zxkiU3hgarYxZfb3PDFW6zsSuNtijsPw3XOJfj78ZKgQ5jtGL5N/yCvb4lKHwE 4NaRS67Q IwvWSTKCMsdKZjeT8aMxteY31Vf0lN6Y8QeKKdHjbYVT2GRj937PJ5AacSeuudYTA/A+BJQjZsx1NYdDqBT5EyM0LZEa76AbV4OnXuCSb6mB9LcOt+8sP1RvhOu7QU9G2B7U4GLmLz3rOvNN7SKOZFqflo/7JzQHqXeJsbhdBqUCGMOskaHIx+5hNs1NxXkK2aFth4rMEJetbPMGITtkCJlTAaHtVL9HhNsPs3CU42U/uG6t5iVgYUSYRH3OszBby6/lelIjkswO+MQNVYdo6oeqrwpBMuEMRHk4aaQCHHt15EACRlQLRSiKipvvR9rmUVN0sWssS/iSKvtQ= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: From: Ye Liu Fixes a minor typo in the comment above page_address_in_vma(): "responsibililty" → "responsibility" Signed-off-by: Ye Liu Reviewed-by: Lorenzo Stoakes --- mm/rmap.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/mm/rmap.c b/mm/rmap.c index b509c226e50d..a9eed8981e18 100644 --- a/mm/rmap.c +++ b/mm/rmap.c @@ -774,7 +774,7 @@ static bool should_defer_flush(struct mm_struct *mm, enum ttu_flags flags) * @vma: The VMA we need to know the address in. * * Calculates the user virtual address of this page in the specified VMA. - * It is the caller's responsibililty to check the page is actually + * It is the caller's responsibility to check the page is actually * within the VMA. There may not currently be a PTE pointing at this * page, but if a page fault occurs at this address, this is the page * which will be accessed.