From patchwork Sun Mar 24 02:46:01 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "J. R. Okajima" X-Patchwork-Id: 10867321 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 81CB9922 for ; Sun, 24 Mar 2019 02:54:12 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 6557B28A5E for ; Sun, 24 Mar 2019 02:54:12 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 561AB28A20; Sun, 24 Mar 2019 02:54:12 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.9 required=2.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, FREEMAIL_FROM,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI,UNPARSEABLE_RELAY autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id E29E328988 for ; Sun, 24 Mar 2019 02:54:11 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727746AbfCXCyL (ORCPT ); Sat, 23 Mar 2019 22:54:11 -0400 Received: from mfb02-md.ns.itscom.net ([175.177.155.110]:42070 "EHLO mfb02-md.ns.itscom.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727628AbfCXCyK (ORCPT ); Sat, 23 Mar 2019 22:54:10 -0400 X-Greylist: delayed 487 seconds by postgrey-1.27 at vger.kernel.org; Sat, 23 Mar 2019 22:54:09 EDT Received: from mail03-md.ns.itscom.net (mail03-md.ns.itscom.net [175.177.155.113]) by mfb02-md.ns.itscom.net (Postfix) with ESMTP id 140591748078 for ; Sun, 24 Mar 2019 11:46:03 +0900 (JST) Received: from scan25-mds.s.noc.itscom.net (scan25-md.ns.itscom.net [175.177.155.79]) by mail03-md-outgoing.ns.itscom.net (Postfix) with ESMTP id 90963FF0527; Sun, 24 Mar 2019 11:46:01 +0900 (JST) Received: from unknown (HELO mail02-md-outgoing.ns.itscom.net) ([175.177.155.112]) by scan25-mds.s.noc.itscom.net with ESMTP; 24 Mar 2019 11:46:01 +0900 Received: from jromail.nowhere (h219-110-50-034.catv02.itscom.jp [219.110.50.34]) by mail02-md-outgoing.ns.itscom.net (Postfix) with ESMTP; Sun, 24 Mar 2019 11:46:01 +0900 (JST) Received: from jro by jrobl id 1h7t97-00070K-65 ; Sun, 24 Mar 2019 11:46:01 +0900 From: "J. R. Okajima" To: ZhangXiaoxu , Trond Myklebust Cc: linux-fsdevel@vger.kernel.org Subject: Q. set_cached_acl() on NFSv3 MIME-Version: 1.0 Content-ID: <26926.1553395561.1@jrobl> Date: Sun, 24 Mar 2019 11:46:01 +0900 Message-ID: <26927.1553395561@jrobl> Sender: linux-fsdevel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP By the commit for v5.1-rc1, ded52fbe7020 2019-02-20 nfs: fix xfstest generic/099 failed on nfsv3 NFSv3 stopped calling set_cached_acl(). And the behaviour changed. Is this intentional? Here is the example. (test script) f=fileA > $f getfacl --omit-header $f | tee $tmp setfacl -m u:$USER:rx,g:nogroup:x $f getfacl --omit-header $f | + : + setfacl -x u:jro,g:nogroup fileA + getfacl --omit-header fileA + diff -u /tmp/2351 - (there is no diff output) diff -u $tmp - || : setfacl -x u:$USER,g:nogroup $f getfacl --omit-header $f | diff -u $tmp - || : - on linux-v5.0, there is no difference between ext4 and nfs3. - on linux-v5.1-rc1, ext4 behaves same, but nfs3 doesn't show the "mask" entry in the last output. - removing user:$USER and group:nogroup entries looks "mask" entry gone too. J. R. Okajima ######################################## linux-v5.0 ext4 + getfacl --omit-header fileA + tee /tmp/6311 user::rw- group::r-- other::r-- + setfacl -m u:jro:rx,g:nogroup:x fileA + getfacl --omit-header fileA + diff -u /tmp/6311 - --- /tmp/6311 2019-03-24 11:16:18.000000000 +0900 +++ - 2019-03-24 11:16:18.053867096 +0900 @@ -1,4 +1,7 @@ user::rw- +user:jro:r-x group::r-- +group:nogroup:--x +mask::r-x other::r-- + setfacl -x u:jro,g:nogroup fileA + getfacl --omit-header fileA + diff -u /tmp/6311 - --- /tmp/6311 2019-03-24 11:16:18.000000000 +0900 +++ - 2019-03-24 11:16:18.062265271 +0900 @@ -1,4 +1,5 @@ user::rw- group::r-- +mask::r-- other::r-- ######################################## linux-v5.0 nfs3 + getfacl --omit-header fileA + tee /tmp/6579 user::rw- group::r-- other::r-- + setfacl -m u:jro:rx,g:nogroup:x fileA + getfacl --omit-header fileA + diff -u /tmp/6579 - --- /tmp/6579 2019-03-24 11:16:27.000000000 +0900 +++ - 2019-03-24 11:16:27.360407625 +0900 @@ -1,4 +1,7 @@ user::rw- +user:jro:r-x group::r-- +group:nogroup:--x +mask::r-x other::r-- + : + setfacl -x u:jro,g:nogroup fileA + getfacl --omit-header fileA + diff -u /tmp/6579 - --- /tmp/6579 2019-03-24 11:16:27.000000000 +0900 +++ - 2019-03-24 11:16:27.369262067 +0900 @@ -1,4 +1,5 @@ user::rw- group::r-- +mask::r-- other::r-- ######################################## linux-v5.1-rc1 ext4 + f=fileA + + getfacl --omit-header fileA + tee /tmp/2065 user::rw- group::r-- other::r-- + setfacl -m u:jro:rx,g:nogroup:x fileA + getfacl --omit-header fileA + diff -u /tmp/2065 - --- /tmp/2065 2019-03-24 11:19:24.000000000 +0900 +++ - 2019-03-24 11:19:24.223903353 +0900 @@ -1,4 +1,7 @@ user::rw- +user:jro:r-x group::r-- +group:nogroup:--x +mask::r-x other::r-- + : + setfacl -x u:jro,g:nogroup fileA + getfacl --omit-header fileA + diff -u /tmp/2065 - --- /tmp/2065 2019-03-24 11:19:24.000000000 +0900 +++ - 2019-03-24 11:19:24.230741358 +0900 @@ -1,4 +1,5 @@ user::rw- group::r-- +mask::r-- other::r-- ######################################## linux-v5.1-rc1 nfs3 + f=fileA + + getfacl --omit-header fileA + tee /tmp/2351 user::rw- group::r-- other::r-- + setfacl -m u:jro:rx,g:nogroup:x fileA + getfacl --omit-header fileA + diff -u /tmp/2351 - --- /tmp/2351 2019-03-24 11:19:30.000000000 +0900 +++ - 2019-03-24 11:19:30.706744795 +0900 @@ -1,4 +1,7 @@ user::rw- +user:jro:r-x group::r-- +group:nogroup:--x +mask::r-x other::r--