From patchwork Sun Mar 24 22:43:30 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kangjie Lu X-Patchwork-Id: 10867771 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 5B513925 for ; Sun, 24 Mar 2019 22:43:48 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 3500A291D7 for ; Sun, 24 Mar 2019 22:43:48 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 2696B2922E; Sun, 24 Mar 2019 22:43:48 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED autolearn=ham version=3.3.1 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 2109D291D7 for ; Sun, 24 Mar 2019 22:43:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:Cc:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:Message-Id:Date: Subject:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To: References:List-Owner; bh=HTA5YsEEL0iAOovCsl0EAVk3GMhCqTbV9+uSvJZVItc=; b=Ftl GFw9OBH3v5cqlGFONH0bsOzIrl7jS3eaM+s5SACvoHbrvYz8fLDunVNMnNjTKOT6LByTUj8zJjFOS iL9B527EH8FsG/C5sVC0JIyI/stY77ld8WAUgx0yVjhXoO9W5ZVA1IlNqfY8/POuAt6Hoe+XOO9DY u3tAYAesF4gGssKboFxGkPV8ic0HZkio6TJzhoe8GKo7nS/4wUzL5kV/LeZ4gs+HF04itEVKwUkqM NALR2UXhdtfaKwS86eIDp0irOHeOnbHrDAtW92xixgQu2lxpTDI7oxEtuQAMZcyAJd09w74rZ6UUM THk5wrXqpO1ccmHvos+zXq7RVA5cAng==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1h8BqD-0003zi-Fz; Sun, 24 Mar 2019 22:43:45 +0000 Received: from mta-p6.oit.umn.edu ([134.84.196.206]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1h8BqB-0003yg-69 for linux-arm-kernel@lists.infradead.org; Sun, 24 Mar 2019 22:43:44 +0000 Received: from localhost (unknown [127.0.0.1]) by mta-p6.oit.umn.edu (Postfix) with ESMTP id 419ACB36 for ; Sun, 24 Mar 2019 22:43:38 +0000 (UTC) X-Virus-Scanned: amavisd-new at umn.edu Received: from mta-p6.oit.umn.edu ([127.0.0.1]) by localhost (mta-p6.oit.umn.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 5g6ZnlQZAxaa for ; Sun, 24 Mar 2019 17:43:38 -0500 (CDT) Received: from mail-io1-f71.google.com (mail-io1-f71.google.com [209.85.166.71]) (using TLSv1.2 with cipher AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mta-p6.oit.umn.edu (Postfix) with ESMTPS id 19CB7B34 for ; Sun, 24 Mar 2019 17:43:38 -0500 (CDT) Received: by mail-io1-f71.google.com with SMTP id r21so6497680iod.12 for ; Sun, 24 Mar 2019 15:43:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=umn.edu; s=google; h=from:to:cc:subject:date:message-id; bh=sul76dv3STc5/UWpJ9vmSfm2gGDqU8QZqXwdwOQU5TY=; b=OiFCf2Rcvcde0rQcfubl62GwfWlDHhfYhlykKz5XlwGmQcfApV+fqeL1DPL7eTZRF0 zIb5ajAgkE/XUoKQGNWDPMwpML6NURRd3tPJeJ8baEFO2+ftwJBIje3WLP7ZOSVZd4FZ 7d3BlVvzuimlUK8WT51YO3VKa8edLI9I+sRlYPXxCpmVMRw24QjefIiperBcRpf8ZoGQ ZRqPaxDEQ5ojQldUD1iOGOqDq+hHLbwqkipWAsViu/02kdcgEfbSW6jn0aXcFDBK0TLH ZzaZk10jYTWMx3lD1CwSzTFnLVrU0/q8HJZ8G5SyHNFyq6jSK4Dmy8Djcx/lmsPhCqR1 0r2A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=sul76dv3STc5/UWpJ9vmSfm2gGDqU8QZqXwdwOQU5TY=; b=YK+axTC9MDTS6DnBDbwNCS0NKF5D+Fop5GlOb9Y0CYL5REIPMcuu1j8W+zS/R/RUbA S+PJhrloEggLr6+5JFeXku7/gUwrzNF8wO0oib9ixstCBdtEfOewjpiwd1Ww4AQZyjDb k70C+2aU4usi69NuyVvNlgLdWPugpqIpXF38EzaPUwf8VwqZSGIC4he3CQ0+DCLqxwbn +77bKrwJtwG5gV6CiY25iGpUI0PlJSu5ZOQ8mGsWd6VtbK4PtbF7b/dmqwSQ6masO0h7 zaHgKmZT9wWjJDM9eLs/cfLzhpPPICxge/YgRnn60XaSQz/9c3ObIhyuVoJbGE4ir+a1 B1tw== X-Gm-Message-State: APjAAAWo4pP9AI09OL5EykHWEmUGInBs5xNACk9to/UjhruonBi6BJIo x1i0vR74Vnf8T/9ftkkIsNopDoJFj3xvwcIYJ0j4yYi6lTepmBXeT1g1Xq0liI98ghjnUt6vMJR RoWNrECURRSNzr6up/9mI6OmtkXTq0PcHN7nCZak= X-Received: by 2002:a24:738e:: with SMTP id y136mr8595815itb.147.1553467417704; Sun, 24 Mar 2019 15:43:37 -0700 (PDT) X-Google-Smtp-Source: APXvYqzUO7Bn5GLpNWzElf5/ivicSmFq6GXcjoX7+4cfOKgYh8GN51FbrJhA3d+3pNiUNn9c1S59IA== X-Received: by 2002:a24:738e:: with SMTP id y136mr8595803itb.147.1553467417518; Sun, 24 Mar 2019 15:43:37 -0700 (PDT) Received: from bee.dtc.umn.edu (cs-bee-u.cs.umn.edu. [128.101.106.63]) by smtp.gmail.com with ESMTPSA id u197sm4849059itb.9.2019.03.24.15.43.36 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sun, 24 Mar 2019 15:43:36 -0700 (PDT) From: Kangjie Lu To: kjlu@umn.edu Subject: [PATCH] vc04_services: vchiq_arm: fix a NULL pointer dereference Date: Sun, 24 Mar 2019 17:43:30 -0500 Message-Id: <20190324224331.1163-1-kjlu@umn.edu> X-Mailer: git-send-email 2.17.1 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190324_154343_311305_50BAD30E X-CRM114-Status: GOOD ( 11.26 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Stefan Wahren , devel@driverdev.osuosl.org, Greg Kroah-Hartman , Phil Elwell , linux-kernel@vger.kernel.org, =?utf-8?q?Tobias_B=C3=BCttner?= , Eric Anholt , Luis Chamberlain , linux-rpi-kernel@lists.infradead.org, pakki001@umn.edu, Dominic Braun , Nicolas Saenz Julienne , linux-arm-kernel@lists.infradead.org MIME-Version: 1.0 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Virus-Scanned: ClamAV using ClamSMTP When kzalloc fails, "platform_state->inited = 1" is a NULL pointer dereference. The fix returns VCHIQ_ERROR in case it failed to avoid NULL pointer dereference. Signed-off-by: Kangjie Lu Reviewed-by: Mukesh Ojha --- .../staging/vc04_services/interface/vchiq_arm/vchiq_2835_arm.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_2835_arm.c b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_2835_arm.c index dd4898861b83..0f12fe617575 100644 --- a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_2835_arm.c +++ b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_2835_arm.c @@ -209,6 +209,8 @@ vchiq_platform_init_state(struct vchiq_state *state) struct vchiq_2835_state *platform_state; state->platform_state = kzalloc(sizeof(*platform_state), GFP_KERNEL); + if (!state->platform_state) + return VCHIQ_ERROR; platform_state = (struct vchiq_2835_state *)state->platform_state; platform_state->inited = 1;