From patchwork Tue Mar 26 23:55:57 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Huang Zijiang X-Patchwork-Id: 10872319 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 05A1E922 for ; Tue, 26 Mar 2019 23:56:11 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id E6BC628B95 for ; Tue, 26 Mar 2019 23:56:10 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id DA4CE28C3B; Tue, 26 Mar 2019 23:56:10 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.9 required=2.0 tests=BAYES_00,MAILING_LIST_MULTI, RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 90D7628B95 for ; Tue, 26 Mar 2019 23:56:10 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732579AbfCZX4F (ORCPT ); Tue, 26 Mar 2019 19:56:05 -0400 Received: from mxhk.zte.com.cn ([63.217.80.70]:41008 "EHLO mxhk.zte.com.cn" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731666AbfCZX4E (ORCPT ); Tue, 26 Mar 2019 19:56:04 -0400 Received: from mse01.zte.com.cn (unknown [10.30.3.20]) by Forcepoint Email with ESMTPS id B40239CDBA527FE662B0; Wed, 27 Mar 2019 07:56:02 +0800 (CST) Received: from notes_smtp.zte.com.cn ([10.30.1.239]) by mse01.zte.com.cn with ESMTP id x2QNtxhs093440; Wed, 27 Mar 2019 07:55:59 +0800 (GMT-8) (envelope-from huang.zijiang@zte.com.cn) Received: from fox-host8.localdomain ([10.74.120.8]) by szsmtp06.zte.com.cn (Lotus Domino Release 8.5.3FP6) with ESMTP id 2019032707561816-6463566 ; Wed, 27 Mar 2019 07:56:18 +0800 From: Huang Zijiang To: jejb@linux.ibm.com Cc: martin.petersen@oracle.com, linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org, wang.yi59@zte.com.cn, Huang Zijiang Subject: [PATCH] scsi: sun_esp: : Fix object reference leaks in esp_sbus_probe Date: Wed, 27 Mar 2019 07:55:57 +0800 Message-Id: <1553644557-35817-1-git-send-email-huang.zijiang@zte.com.cn> X-Mailer: git-send-email 1.8.3.1 X-MIMETrack: Itemize by SMTP Server on SZSMTP06/server/zte_ltd(Release 8.5.3FP6|November 21, 2013) at 2019-03-27 07:56:18, Serialize by Router on notes_smtp/zte_ltd(Release 9.0.1FP7|August 17, 2016) at 2019-03-27 07:55:51, Serialize complete at 2019-03-27 07:55:51 X-MAIL: mse01.zte.com.cn x2QNtxhs093440 Sender: linux-scsi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP The of_find_device_by_node() takes a reference to the underlying device structure, we should release that reference whatever of_find_device_by_node reutrns. Signed-off-by: Huang Zijiang Reviewed-by: Mukesh Ojha --- drivers/scsi/sun_esp.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/scsi/sun_esp.c b/drivers/scsi/sun_esp.c index a11efbc..a74605a 100644 --- a/drivers/scsi/sun_esp.c +++ b/drivers/scsi/sun_esp.c @@ -543,9 +543,8 @@ static int esp_sbus_probe(struct platform_device *op) return -ENODEV; ret = esp_sbus_probe_one(op, dma_of, hme); - if (ret) - put_device(&dma_of->dev); + put_device(&dma_of->dev); return ret; }