From patchwork Thu Mar 28 18:06:17 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bart Van Assche X-Patchwork-Id: 10875661 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id BBF3D17E0 for ; Thu, 28 Mar 2019 18:06:41 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 9CAE128DE7 for ; Thu, 28 Mar 2019 18:06:41 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 908C228E1D; Thu, 28 Mar 2019 18:06:41 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.9 required=2.0 tests=BAYES_00,MAILING_LIST_MULTI, RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 5C0F328DE7 for ; Thu, 28 Mar 2019 18:06:33 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726380AbfC1SGd (ORCPT ); Thu, 28 Mar 2019 14:06:33 -0400 Received: from mail-pl1-f194.google.com ([209.85.214.194]:44619 "EHLO mail-pl1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726171AbfC1SGc (ORCPT ); Thu, 28 Mar 2019 14:06:32 -0400 Received: by mail-pl1-f194.google.com with SMTP id g12so5328096pll.11 for ; Thu, 28 Mar 2019 11:06:32 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=8j5GKW1xuwkoqPjZP9cIK5cwlCLPoKMIwrXjCwpsgfw=; b=l6tAoq4llZVq8PJeVsffqaC4dh5g4sveu++jRvv3nZTC/7WIv8i4b94r/ZPfrsfmDl gTEypI3vA0BTN2NTv15/QN5+vPwFyIAza8XejS1IzCLJfLfPwFGZg+LUAFIbbmm4TNam EtULzblW1wgHJgU1vqmi4NbrQZ3A/ZM4PGs5xCApPakFaBWU1bstqdhkAF/guXmQ6quB yLbJg7HnQP6HH7d5dYbGlg0fgceOdaEmD4O0lsBBG1lvwLlhjF5XTMVP6fFyFXiZSBbw FeQPB7o9X0c/xEhWY1akLneoLqsyYnG3z0MS/pyVQ9/tDwpn5B7wWlsftvOh70ri9wNR uk4A== X-Gm-Message-State: APjAAAWV+ACvyYuth386xU2sn2OteoR8Qwl7TLdofKKYLihdQq99wos7 WN0+1UlCyeCOv1NXVcyRvlw= X-Google-Smtp-Source: APXvYqwkQi58/AdPyjs6spiKy2wgnU58cQqf4e733dNhkblkVvofp7aTBBO3X5YqSYfXAEcmUdruvg== X-Received: by 2002:a17:902:2927:: with SMTP id g36mr16250172plb.57.1553796392040; Thu, 28 Mar 2019 11:06:32 -0700 (PDT) Received: from desktop-bart.svl.corp.google.com ([2620:15c:2cd:203:5cdc:422c:7b28:ebb5]) by smtp.gmail.com with ESMTPSA id k72sm72025267pfb.122.2019.03.28.11.06.30 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 28 Mar 2019 11:06:31 -0700 (PDT) From: Bart Van Assche To: "Martin K . Petersen" , "James E . J . Bottomley" Cc: linux-scsi@vger.kernel.org, Christoph Hellwig , Bart Van Assche , James Smart Subject: [PATCH 2/7] lpfc: Fix indentation and balance braces Date: Thu, 28 Mar 2019 11:06:17 -0700 Message-Id: <20190328180622.34984-3-bvanassche@acm.org> X-Mailer: git-send-email 2.20.GIT In-Reply-To: <20190328180622.34984-1-bvanassche@acm.org> References: <20190328180622.34984-1-bvanassche@acm.org> MIME-Version: 1.0 Sender: linux-scsi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP This patch avoid that smatch complains about misleading indentation. Cc: James Smart Signed-off-by: Bart Van Assche --- drivers/scsi/lpfc/lpfc_sli.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/scsi/lpfc/lpfc_sli.c b/drivers/scsi/lpfc/lpfc_sli.c index ea9bcb3431b4..e0e655cb75f2 100644 --- a/drivers/scsi/lpfc/lpfc_sli.c +++ b/drivers/scsi/lpfc/lpfc_sli.c @@ -907,10 +907,10 @@ lpfc_handle_rrq_active(struct lpfc_hba *phba) mod_timer(&phba->rrq_tmr, next_time); list_for_each_entry_safe(rrq, nextrrq, &send_rrq, list) { list_del(&rrq->list); - if (!rrq->send_rrq) + if (!rrq->send_rrq) { /* this call will free the rrq */ - lpfc_clr_rrq_active(phba, rrq->xritag, rrq); - else if (lpfc_send_rrq(phba, rrq)) { + lpfc_clr_rrq_active(phba, rrq->xritag, rrq); + } else if (lpfc_send_rrq(phba, rrq)) { /* if we send the rrq then the completion handler * will clear the bit in the xribitmap. */