From patchwork Fri Mar 29 09:20:27 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Daniel Vetter X-Patchwork-Id: 10876693 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id A6A5D1575 for ; Fri, 29 Mar 2019 09:20:40 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 93B1228B38 for ; Fri, 29 Mar 2019 09:20:40 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 84FCA28E57; Fri, 29 Mar 2019 09:20:40 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=2.0 tests=BAYES_00,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED autolearn=unavailable version=3.3.1 Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 182FD28E5A for ; Fri, 29 Mar 2019 09:20:39 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 2AC9C6E891; Fri, 29 Mar 2019 09:20:37 +0000 (UTC) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from mail-ed1-x543.google.com (mail-ed1-x543.google.com [IPv6:2a00:1450:4864:20::543]) by gabe.freedesktop.org (Postfix) with ESMTPS id 9F9426E891 for ; Fri, 29 Mar 2019 09:20:35 +0000 (UTC) Received: by mail-ed1-x543.google.com with SMTP id s39so1423054edb.2 for ; Fri, 29 Mar 2019 02:20:35 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=32e1use73Phweym1kB7nnOCXz3EbNNdTl1BwJ6Yi1Vo=; b=WFLCpI9IPQl8K5xyzD/bbRKcmD67xmbJZF1ZjYpwfN7d2GXgYWNX5rE0nXZSJKZpmN 9awVC1X1pfffBYCEWcd74jaF6A2WbFcmyGNcTukUJtV3NFu05Oxtx5DydrzEDAuuWzH/ bEH0BTtkiMzwbSjVuJtUwudVbeaMSwxP9ihdYlcZbOt+dwM9+r07gZgLsVAk5FckT6uf 7HjJ5KBHEXC5jpZpti/GsxREfiOaqcEWoV12kXur6BIPZ+QXimeS7ztN9JA1iBxN8rGV mmIe3vp2Uz8AfFHau/h+L3kVGO4XAN4SeZAcVdhei2CpXjIbymDu+5yMUyG+kySJirel xx3A== X-Gm-Message-State: APjAAAV9c7Ct6pnbB4sXgvV7G0ONOP+Wn2H5/0arfqHeYXy8dFcqljbf St7M1gsDzishB/7yv63SDmP2opK0ekQ= X-Google-Smtp-Source: APXvYqzWkfNClQXRtPGLfG3vDwaZKeEy/5v8dHDXTVVRPHUZhxQQxP5cLzW4Yb1vQdlub4YIlneF3w== X-Received: by 2002:a50:e712:: with SMTP id a18mr9677346edn.155.1553851233969; Fri, 29 Mar 2019 02:20:33 -0700 (PDT) Received: from phenom.ffwll.local ([2a02:168:569e:0:3106:d637:d723:e855]) by smtp.gmail.com with ESMTPSA id r12sm274554ejs.16.2019.03.29.02.20.32 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 29 Mar 2019 02:20:33 -0700 (PDT) From: Daniel Vetter To: DRI Development Subject: [PATCH] drm/gamma: Clarify gamma lut uapi Date: Fri, 29 Mar 2019 10:20:27 +0100 Message-Id: <20190329092027.3430-1-daniel.vetter@ffwll.ch> X-Mailer: git-send-email 2.20.1 MIME-Version: 1.0 X-Mailman-Original-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ffwll.ch; s=google; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=32e1use73Phweym1kB7nnOCXz3EbNNdTl1BwJ6Yi1Vo=; b=QTiLUCPbg7NDyhvQVaoTAbYGOu3u1kGj3JVr4tNZX+KNmAS7tDkF78qUhSxQ/nTedr qI52QtFBYQpOF8yHq5V9col9d2jPUPyW6os8ha9m76FSJXFbWcQOLApF9kLrmpf1lq6f fWHDPTMFbYEcaSim3Xr4X1DMEpE6iOZ9X+93k= X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Rob Bradford , Daniel Vetter , Liviu Dudau , Stefan Schake , Tomi Valkeinen , Vincent Abriou , amd-gfx@lists.freedesktop.org, Uma Shankar , James Wang , "Kumar, Kiran S" , Mali DP Maintainers , Daniel Stone , Leo Li , Intel Graphics Development , Boris Brezillon , Philippe Cornu , Yannick Fertre , Kausal Malladi Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" X-Virus-Scanned: ClamAV using ClamSMTP Interpreting it as a 0.16 fixed point means we can't accurately represent 1.0. Which is one of the values we really should be able to represent. Since most (all?) luts have lower precision this will only affect rounding of 0xffff. Cc: Uma Shankar Cc: Ville Syrjälä Cc: Shashank Sharma Cc: "Kumar, Kiran S" Cc: Kausal Malladi Cc: Lionel Landwerlin Cc: Matt Roper Cc: Rob Bradford Cc: Daniel Stone Cc: Stefan Schake Cc: Eric Anholt Cc: Maarten Lankhorst Cc: Harry Wentland Cc: Leo Li Cc: amd-gfx@lists.freedesktop.org Cc: James (Qian) Wang Cc: Liviu Dudau Cc: Mali DP Maintainers Cc: CK Hu Cc: Philipp Zabel Cc: Yannick Fertre Cc: Philippe Cornu Cc: Benjamin Gaignard Cc: Vincent Abriou Cc: Tomi Valkeinen Cc: Boris Brezillon Signed-off-by: Daniel Vetter Signed-off-by: Daniel Vetter Acked-by: Liviu Dudau Acked-by: Lionel Landwerlin Reviewed-by: Ville Syrjälä Reviewed-by: Matt Roper Reviewed-by: Philippe Cornu Reviewed-by: Maarten Lankhorst --- include/uapi/drm/drm_mode.h | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/include/uapi/drm/drm_mode.h b/include/uapi/drm/drm_mode.h index 09d72966899a..83cd1636b9be 100644 --- a/include/uapi/drm/drm_mode.h +++ b/include/uapi/drm/drm_mode.h @@ -621,7 +621,8 @@ struct drm_color_ctm { struct drm_color_lut { /* - * Data is U0.16 fixed point format. + * Values are mapped linearly to 0.0 - 1.0 range, with 0x0 == 0.0 and + * 0xffff == 1.0. */ __u16 red; __u16 green;