From patchwork Fri Mar 29 15:33:23 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jerome Brunet X-Patchwork-Id: 10877431 X-Patchwork-Delegate: neil.armstrong@linaro.org Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 7CC041708 for ; Fri, 29 Mar 2019 15:34:06 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 62F88299AD for ; Fri, 29 Mar 2019 15:34:06 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 60ECE299AF; Fri, 29 Mar 2019 15:34:06 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED autolearn=ham version=3.3.1 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 094AE295E4 for ; Fri, 29 Mar 2019 15:34:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=RpH7dh7vdIxx/kfst24qyPyt4GD6/3oxI6Auza7T29I=; b=Ss+xnT9E7PYDd1 FFkZsLWWOmWTqwPP4eRlatnM16JrBqU58mu36EqjuIg2jLHDIyDnvcxLibQ+8lKanpFN9wTpaatA1 yWveq4DoA62Y5LIrf0fiDcjrtSlpDE1C+xzm6CV+k9Qjegyys/p0Tr+LHlJAlmM7jhOuoHWaLmTh8 1fR7H9Vg4fLw1sUChyqfU3bR5grGWGUaQgQHxUOfeqKNlnt+exvl3zOxkc7jkXPSLD5hnEDsPAUBj 0BIVGEzCkqDUEsIrrNRcOYsto/NJPsVhEVbOU9o8RhIpU1X6JBIBoq1XtLPn3FFAO+pzHqbx3snW7 VtaG3q1hPrWZ2lWk9TVw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1h9tW7-0005Xl-Vv; Fri, 29 Mar 2019 15:34:04 +0000 Received: from mail-wr1-x442.google.com ([2a00:1450:4864:20::442]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1h9tVg-00050K-3y for linux-amlogic@lists.infradead.org; Fri, 29 Mar 2019 15:33:43 +0000 Received: by mail-wr1-x442.google.com with SMTP id g3so3100721wrx.9 for ; Fri, 29 Mar 2019 08:33:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=GPit8v+Q7DtocOZEXU4jiFZqiXXyIE54mF68t3axNAg=; b=JFlOjZCuBF4USFLbmGUtrAoPYawoUOO5wzWamoY/Tyuudb+4Gu2K4bS484QHyG0il3 GOq9ccl7t08dBEtKgSNnmy554RdlGvJs9vcKT20n7kZq2+WSD4fjeic11WWGQudS2z+9 L5jhk/mBV3ZShqtJnnDPv+b8OcPLQ0G9GXNXSffdzMc+AWP3KjrQkJlnFormY9M74haX ijyHZ5Pab+pbsIfSSR7/1q0WElWoAPw4ob70hS2m3xPFQkSZb8bIkbgrUXPnicKQE0ss gmT/YLwB7QlBtEe9HfXfZF1mv7UUt+4FjMoYv7KcugC+hW6TEZ/VDjtU/WSlEdnPIm1E 8FIQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=GPit8v+Q7DtocOZEXU4jiFZqiXXyIE54mF68t3axNAg=; b=gDs0mn/gHSMwCh2ujBgplfp8GRab/rdcJ3+X9+TpdMZmfmXd1XyrAPZtsPmNfZmgIK QJ29NEXAmeVBVT8YWt7HdAnrPTEI6UeHnnbuzC/j4sI/GvG5QI9B/c4OupOgWuQVr8Gr jZMoFh+ijwZt7j7auLLKCtg1EE5Qsu8PD3QjJY+jDGIOKFvOMLhiPQQbEUwTJYxf6yc2 YWwkWSdD5Snrri7xAXrSBPRmfyIFIaOR1037486chBx4GxkT8yIJqahJ8Acb0UHWc48T 43VwNGHByVaryVAh00wf7tC1AbEllsPwKj3JLs9gh4C7nWUWEMCAYqgEkIxlPSHeqNqd d2JA== X-Gm-Message-State: APjAAAVCJ6/hWJhGDfgU4OiY9AM5xEoHFHyyjK3tyMlDMqad2/YcnBNF fM6uvNHZpAdHMvZ6TIJLIcjMCQ== X-Google-Smtp-Source: APXvYqwGgnk+y67GmSfAmgzYWFvp/+mQnKnCZOHwrdAllmxhqeMRmGvfJSQ3hwjYPPM9OpM+pidCzA== X-Received: by 2002:adf:db10:: with SMTP id s16mr23886951wri.181.1553873614583; Fri, 29 Mar 2019 08:33:34 -0700 (PDT) Received: from boomer.local ([2a01:e34:eeb6:4690:106b:bae3:31ed:7561]) by smtp.googlemail.com with ESMTPSA id s18sm1930173wmc.41.2019.03.29.08.33.33 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 29 Mar 2019 08:33:34 -0700 (PDT) From: Jerome Brunet To: Neil Armstrong Subject: [PATCH 1/3] clk: meson: mpll: properly handle spread spectrum Date: Fri, 29 Mar 2019 16:33:23 +0100 Message-Id: <20190329153325.23869-2-jbrunet@baylibre.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20190329153325.23869-1-jbrunet@baylibre.com> References: <20190329153325.23869-1-jbrunet@baylibre.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190329_083336_548655_28C0E3E8 X-CRM114-Status: GOOD ( 13.51 ) X-BeenThere: linux-amlogic@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-amlogic@lists.infradead.org, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, Jerome Brunet Sender: "linux-amlogic" Errors-To: linux-amlogic-bounces+patchwork-linux-amlogic=patchwork.kernel.org@lists.infradead.org X-Virus-Scanned: ClamAV using ClamSMTP The bit 'SSEN' available on some MPLL DSS outputs is not related to the fractional part of the divider but to the function called 'Spread Spectrum'. This function might be used to solve EM issues by adding a jitter on clock signal. This widens the signal spectrum and weakens the peaks in it. While spread spectrum might be useful for some application, it is problematic for others, such as audio. This patch introduce a new flag to the MPLL driver to enable (or not) the spread spectrum function. Fixes: 1f737ffa13ef ("clk: meson: mpll: fix mpll0 fractional part ignored") Signed-off-by: Jerome Brunet Tested-by: Martin Blumenstingl --- drivers/clk/meson/clk-mpll.c | 9 ++++++--- drivers/clk/meson/clk-mpll.h | 1 + 2 files changed, 7 insertions(+), 3 deletions(-) diff --git a/drivers/clk/meson/clk-mpll.c b/drivers/clk/meson/clk-mpll.c index 64d31c8ba3d0..2d39a8bc367c 100644 --- a/drivers/clk/meson/clk-mpll.c +++ b/drivers/clk/meson/clk-mpll.c @@ -141,9 +141,12 @@ static void mpll_init(struct clk_hw *hw) /* Enable the fractional part */ meson_parm_write(clk->map, &mpll->sdm_en, 1); - /* Set additional fractional part enable if required */ - if (MESON_PARM_APPLICABLE(&mpll->ssen)) - meson_parm_write(clk->map, &mpll->ssen, 1); + /* Set spread spectrum if possible */ + if (MESON_PARM_APPLICABLE(&mpll->ssen)) { + unsigned int ss = + mpll->flags & CLK_MESON_MPLL_SPREAD_SPECTRUM ? 1 : 0; + meson_parm_write(clk->map, &mpll->ssen, ss); + } /* Set the magic misc bit if required */ if (MESON_PARM_APPLICABLE(&mpll->misc)) diff --git a/drivers/clk/meson/clk-mpll.h b/drivers/clk/meson/clk-mpll.h index 2925fb939fdd..a991d568c43a 100644 --- a/drivers/clk/meson/clk-mpll.h +++ b/drivers/clk/meson/clk-mpll.h @@ -25,6 +25,7 @@ struct meson_clk_mpll_data { }; #define CLK_MESON_MPLL_ROUND_CLOSEST BIT(0) +#define CLK_MESON_MPLL_SPREAD_SPECTRUM BIT(1) extern const struct clk_ops meson_clk_mpll_ro_ops; extern const struct clk_ops meson_clk_mpll_ops; From patchwork Fri Mar 29 15:33:24 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jerome Brunet X-Patchwork-Id: 10877429 X-Patchwork-Delegate: neil.armstrong@linaro.org Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 3534B922 for ; Fri, 29 Mar 2019 15:34:03 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 19C60299A0 for ; Fri, 29 Mar 2019 15:34:03 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 17C74299A4; Fri, 29 Mar 2019 15:34:03 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED autolearn=ham version=3.3.1 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id C8B13299A8 for ; Fri, 29 Mar 2019 15:34:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=SA7dN1BpQhtJeIvv4yfSgdf0eGwG6mzKTnpAqJgH+a4=; b=j6NUhs4924cs2O E914W3nkVomGEscGtn4gMopzZ9ZTIhAW8wfC6GoH37irTIY2EuEOkxnpqXvfx70ii3O0BbJ7/lryZ bIS3ua9GHGnpBZu949rvxFyViqMPE3K+wT8GsdzgrZPR4W03QzsQ7/eaz52d0HJm515a/7dq2KeNm cEQYiUIPw4o851SMhLkoK1dK48H65PEaOHPzQtbSM7faKuZprHR4IFnGn67mgxcAyVWKCUFugzeJ3 oVymJ/VmjkoydNb9hBPG/ODzSlZJ5pyLtufDCFA5E6jMLCtm5zO9cE2+8sg1mRCbJ1eUlu6MIBuq7 +iQwVyYsJTlWBDv0o54g==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1h9tW5-0005U3-Jx; Fri, 29 Mar 2019 15:34:01 +0000 Received: from mail-wm1-x342.google.com ([2a00:1450:4864:20::342]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1h9tVh-00052e-Pt for linux-amlogic@lists.infradead.org; Fri, 29 Mar 2019 15:33:42 +0000 Received: by mail-wm1-x342.google.com with SMTP id w15so3307802wmc.3 for ; Fri, 29 Mar 2019 08:33:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=FWfQp5+ZZrqhqHBdYBd1fS5YgiYNyIDWJS2WXanIlaU=; b=pYS1SpzwcqPn03mG5ybxNzW305QTPzPCQZN263IXlWMguaxWwsEMBYjnXbcCHLgUwE fPH+js9vlzVc2+Eu+zV/J/qRA2bEk7q7ZGQdJK7o556F7K76c5LkxkgpOASIB0NUdQbo mwNZ4bd+82iSvruITeR0gIhLo/Zg5LWPo2ZSFNTOCXeyqJs6mAPBtKgR7D/WxPExfndZ YmhxNF4OX1zYm07GCzwBHvtIslQSb2pZ1GZzwoXlBmtQX+p2/oDSS/8+KhAmDjqy7zcV O4U85x6VYdjnzcXit5A3CNCMdKSTa4OyR1sqhu0DdOejiZISh2hua7PuBgqjTwmwbVY5 PENg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=FWfQp5+ZZrqhqHBdYBd1fS5YgiYNyIDWJS2WXanIlaU=; b=YXYxgL2+OIiYy6zn+u3ef5QWho9lUfEpQ+DLfynILeTvLjb24HSMtM18n/+SlZuDnu K0KnWBxO+qo7rHyB+1cP5kow28xdg2Lk5K3Dak/esggyOtsv/+UeKmArS4E+vsTqWOX5 HQOu+DiO+phLwXYcqfezlyBjV2lw8w33b2EeHzv7SORegafRR2KY6xhgH92dEAfaOhjY a06obuFrkOPyn0s2YCn6X8KjNGucmX17fPtv8/1rC2cJWpkz//G6pFYE1mESGeGXqykP /paa496SGJXDTJttMK0Ti0PWP/D2qJ9Ix/W/tvPbTVLY08Z+J/EaUetw1BsmfxretZIs bm/g== X-Gm-Message-State: APjAAAU4yFYRTbgNJBG5GKt+X8bAe2EvOafx+vFNLqK57ClxaxUzDaUh RehoP9H1NRzllRK5yPPNSZZZXg== X-Google-Smtp-Source: APXvYqykcHi1Bbu3B94IurmTjSfeqUhpdghDB5ixIbNF4oVr9EDQj4dbbKldpJNI4UMntOaj0KmBnQ== X-Received: by 2002:a1c:e70b:: with SMTP id e11mr3828070wmh.17.1553873615975; Fri, 29 Mar 2019 08:33:35 -0700 (PDT) Received: from boomer.local ([2a01:e34:eeb6:4690:106b:bae3:31ed:7561]) by smtp.googlemail.com with ESMTPSA id s18sm1930173wmc.41.2019.03.29.08.33.34 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 29 Mar 2019 08:33:35 -0700 (PDT) From: Jerome Brunet To: Neil Armstrong Subject: [PATCH 2/3] clk: meson: gxbb: no spread spectrum on mpll0 Date: Fri, 29 Mar 2019 16:33:24 +0100 Message-Id: <20190329153325.23869-3-jbrunet@baylibre.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20190329153325.23869-1-jbrunet@baylibre.com> References: <20190329153325.23869-1-jbrunet@baylibre.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190329_083338_314709_FC7799BB X-CRM114-Status: UNSURE ( 9.60 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-amlogic@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-amlogic@lists.infradead.org, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, Jerome Brunet Sender: "linux-amlogic" Errors-To: linux-amlogic-bounces+patchwork-linux-amlogic=patchwork.kernel.org@lists.infradead.org X-Virus-Scanned: ClamAV using ClamSMTP The documentation says there is an SSEN bit on mpll0 but, after testing it, no spread spectrum function appears to be enabled by this bit on any of the MPLLs. Let's remove it until we know more Fixes: 1f737ffa13ef ("clk: meson: mpll: fix mpll0 fractional part ignored") Signed-off-by: Jerome Brunet --- drivers/clk/meson/gxbb.c | 5 ----- 1 file changed, 5 deletions(-) diff --git a/drivers/clk/meson/gxbb.c b/drivers/clk/meson/gxbb.c index 04df2e208ed6..17d4e85bde65 100644 --- a/drivers/clk/meson/gxbb.c +++ b/drivers/clk/meson/gxbb.c @@ -679,11 +679,6 @@ static struct clk_regmap gxbb_mpll0_div = { .shift = 16, .width = 9, }, - .ssen = { - .reg_off = HHI_MPLL_CNTL, - .shift = 25, - .width = 1, - }, .lock = &meson_clk_lock, }, .hw.init = &(struct clk_init_data){ From patchwork Fri Mar 29 15:33:25 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jerome Brunet X-Patchwork-Id: 10877433 X-Patchwork-Delegate: neil.armstrong@linaro.org Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id E65EA1708 for ; Fri, 29 Mar 2019 15:34:08 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id CDEDB297D6 for ; Fri, 29 Mar 2019 15:34:08 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id CC5FC29967; Fri, 29 Mar 2019 15:34:08 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED autolearn=ham version=3.3.1 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 617BB299B3 for ; Fri, 29 Mar 2019 15:34:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=o5jirVh8kUE5NbCf3mkeTf5eVHFtv6Jj18pYpuLfwto=; b=n/KsZD55IeEcE2 PbGKV9TwFPY+ZCvSlq9OE93v2SFWgGFDRMxaMeOMr6ZCrsR/o+thr04SKxUSEyShSQKmXt7KBKdCM XiO9aRjGIX+sLdnee9Q3ISmPaN4HVS7RYoz/RGB+N/9k+nwwAVJbfTr6UZx+FEG9MTrVPFOMbVBKY ticSKpSKRhBFHI8siQ52sgsGSXOXNzURJw+7AHv25POQHWmMwf6KDUFhFhll/iMH+wIl9aKvYBjc4 VkfJ0FqmHvdCNPXTgy9SvplsnMQh9gCLUzNHiSITkpFCFhInf0G5OW/eF8VpHsg/BAEcyjumFDukV d+b0Zb7687l2ERrsbk0g==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1h9tWA-0005ah-5W; Fri, 29 Mar 2019 15:34:06 +0000 Received: from mail-wm1-x342.google.com ([2a00:1450:4864:20::342]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1h9tVi-00054q-Sb for linux-amlogic@lists.infradead.org; Fri, 29 Mar 2019 15:33:45 +0000 Received: by mail-wm1-x342.google.com with SMTP id y197so3321568wmd.0 for ; Fri, 29 Mar 2019 08:33:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=StsbiAbV0Vt+lXEMy/BJGmoZrMBaAxbvBsCBZl1IPto=; b=cFyX65t+guMxH0r6wwSuBGb7zt9F3l3OAKQIUEhzCLXzE9CP1DjsgeoNuVQfOmgQ9y 3E/6EPaEtzmqGcEH9hfmtSE7ExYLYk9jyUkcSonbTaAG0Q3Qg/SKCR6whaIsLf2y0pe0 p1TmqbeqhCmxnkBkINo/3nH2dQ8k+Hay49Ayh6DwhFa+fwuJtSUi7FP3LxePzFlJpRJp zN3NkuPjWOXkDWZzcO9QaOPs+4MMfYbXS428Oj+P3uT/N7oHtV/j215UkGowhHb6JFyn kgS4PwzsxbTByarKfja5OCK9EBCgaGjwGaRlp7Ex0fp55rpLgW+SU7NIFFj/Gr/Cx+ix CoMA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=StsbiAbV0Vt+lXEMy/BJGmoZrMBaAxbvBsCBZl1IPto=; b=aTZVN08p+SJMiVGIoWe0UP6RiM6IEs2DtZcqtlSfa2v84+CC8nBZ7uT+tDWpDCI2Dh PRUftEtaXVb197IIzWO2UIMPaQxelsB42hiR0U51l8yI2YSkaFhCmrAJ/JXuw1iIFtr3 2hKOZXts488ilgm1kZCrdL6yWh8e9X1Ins+DnRpfbCP0cgnGm75yy7P77k6EKmXivf5h 6zF7blOmcvfQ43SWNMEaxcw2JBjS+hEzhgVmR60uVNLzzQPu6VjzIPlZ/ewfaVim78eJ LRzuHpDfJwCc9pjNVA5HCPDWZxYa4zDCmvoNT9Q9I9hegz9JPCdmPpURGb0+I9k4A9r/ lyrQ== X-Gm-Message-State: APjAAAUDVw/OeK0ict59OnMcBkRD2l83URQiPot+kITZcBTEpCr7c3jy j0wW/f8ZtO8cAeMajPhmJYCy0g== X-Google-Smtp-Source: APXvYqzNbjnC9hVvavPvh6hiCMbrxTVwkUIlSPcCZxicH/X9jL4cLAFyRnst0XB/BIatQc++j61sgA== X-Received: by 2002:a1c:2d91:: with SMTP id t139mr4275362wmt.102.1553873617383; Fri, 29 Mar 2019 08:33:37 -0700 (PDT) Received: from boomer.local ([2a01:e34:eeb6:4690:106b:bae3:31ed:7561]) by smtp.googlemail.com with ESMTPSA id s18sm1930173wmc.41.2019.03.29.08.33.36 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 29 Mar 2019 08:33:36 -0700 (PDT) From: Jerome Brunet To: Neil Armstrong Subject: [PATCH 3/3] clk: meson: axg: spread spectrum is on mpll2 Date: Fri, 29 Mar 2019 16:33:25 +0100 Message-Id: <20190329153325.23869-4-jbrunet@baylibre.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20190329153325.23869-1-jbrunet@baylibre.com> References: <20190329153325.23869-1-jbrunet@baylibre.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190329_083339_426466_04B6085F X-CRM114-Status: GOOD ( 11.54 ) X-BeenThere: linux-amlogic@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-amlogic@lists.infradead.org, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, Jerome Brunet Sender: "linux-amlogic" Errors-To: linux-amlogic-bounces+patchwork-linux-amlogic=patchwork.kernel.org@lists.infradead.org X-Virus-Scanned: ClamAV using ClamSMTP After testing, it appears that the SSEN bit controls the spread spectrum function on MPLL2, not MPLL0. Fixes: 78b4af312f91 ("clk: meson-axg: add clock controller drivers") Signed-off-by: Jerome Brunet --- drivers/clk/meson/axg.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/clk/meson/axg.c b/drivers/clk/meson/axg.c index 7a8ef80e5f2c..3ddd0efc9ee0 100644 --- a/drivers/clk/meson/axg.c +++ b/drivers/clk/meson/axg.c @@ -469,11 +469,6 @@ static struct clk_regmap axg_mpll0_div = { .shift = 16, .width = 9, }, - .ssen = { - .reg_off = HHI_MPLL_CNTL, - .shift = 25, - .width = 1, - }, .misc = { .reg_off = HHI_PLL_TOP_MISC, .shift = 0, @@ -568,6 +563,11 @@ static struct clk_regmap axg_mpll2_div = { .shift = 16, .width = 9, }, + .ssen = { + .reg_off = HHI_MPLL_CNTL, + .shift = 25, + .width = 1, + }, .misc = { .reg_off = HHI_PLL_TOP_MISC, .shift = 2,