| Message ID | 1409329464-768-1-git-send-email-geert@linux-m68k.org (mailing list archive) |
|---|---|
| State | Not Applicable, archived |
| Headers | show |
Hi Geert, On 8/29/2014 9:24 AM, Geert Uytterhoeven wrote: > If NO_DMA=y: > > drivers/built-in.o: In function `brcmf_msgbuf_release_array': > msgbuf.c:(.text+0x34dbbe): undefined reference to `dma_unmap_single' > drivers/built-in.o: In function `brcmf_proto_msgbuf_detach': > (.text+0x34dca4): undefined reference to `dma_free_coherent' > drivers/built-in.o: In function `brcmf_msgbuf_get_pktid': > msgbuf.c:(.text+0x34dd2a): undefined reference to `dma_unmap_single' > drivers/built-in.o: In function `brcmf_msgbuf_alloc_pktid': > msgbuf.c:(.text+0x34de12): undefined reference to `dma_map_single' > msgbuf.c:(.text+0x34de20): undefined reference to `dma_mapping_error' > drivers/built-in.o: In function `brcmf_msgbuf_remove_flowring': > msgbuf.c:(.text+0x34e3d6): undefined reference to `dma_free_coherent' > drivers/built-in.o: In function `brcmf_msgbuf_flowring_create': > msgbuf.c:(.text+0x34e4f8): undefined reference to `dma_alloc_coherent' > drivers/built-in.o: In function `brcmf_proto_msgbuf_attach': > (.text+0x34f5fe): undefined reference to `dma_alloc_coherent' > drivers/built-in.o: In function `brcmf_proto_msgbuf_attach': > (.text+0x34f798): undefined reference to `dma_free_coherent' > > Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org> > --- > drivers/net/wireless/brcm80211/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/wireless/brcm80211/Kconfig b/drivers/net/wireless/brcm80211/Kconfig > index b8e2561ea645..2e0da8925834 100644 > --- a/drivers/net/wireless/brcm80211/Kconfig > +++ b/drivers/net/wireless/brcm80211/Kconfig > @@ -19,7 +19,7 @@ config BRCMSMAC > > config BRCMFMAC > tristate "Broadcom IEEE802.11n embedded FullMAC WLAN driver" > - depends on CFG80211 > + depends on CFG80211A && HAS_DMA > select BRCMUTIL > ---help--- > This module adds support for embedded wireless adapters based on Thanks for reporting this. All complaints are from msgbuf code. So the dependency should belong to BRCMFMAC_PCIE not BRCMFMAC. Thanks, Franky -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Hi Franky, On Fri, Aug 29, 2014 at 8:18 PM, Franky Lin <frankyl@broadcom.com> wrote: >> config BRCMFMAC >> tristate "Broadcom IEEE802.11n embedded FullMAC WLAN driver" >> - depends on CFG80211 >> + depends on CFG80211A && HAS_DMA >> select BRCMUTIL >> ---help--- >> This module adds support for embedded wireless adapters based on > > Thanks for reporting this. All complaints are from msgbuf code. So the > dependency should belong to BRCMFMAC_PCIE not BRCMFMAC. I have PCI=n, hence BRCMFMAC_PCIE=n. IIRC, I did try adding the HAS_DMA dependencies to the suboptions, but then it still failed to link. Hence I restored to the main BRCMFMAC. Besides, msgbuf.o is part of the core. I've just tried moving it to brcmfmac-$(CONFIG_BRCMFMAC_PCIE), but that doesn't help. Other parts use msgbuf, too. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Fri, Aug 29, 2014 at 9:23 PM, Geert Uytterhoeven
<geert@linux-m68k.org> wrote:
> but then it still failed to link. Hence I restored to the main BRCMFMAC.
s/restored/resorted/
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
On 8/29/2014 12:23 PM, Geert Uytterhoeven wrote: > Besides, msgbuf.o is part of the core. > I've just tried moving it to brcmfmac-$(CONFIG_BRCMFMAC_PCIE), > but that doesn't help. Other parts use msgbuf, too. > I was about to send my ACK but had a second thought. If the dependency is added, SDIO driver may not work on no DMA platform. Shall we separate the protocol as a selectable option that selects by bus option? Thanks, Franky -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On 08/29/14 18:24, Geert Uytterhoeven wrote: > If NO_DMA=y: > > drivers/built-in.o: In function `brcmf_msgbuf_release_array': > msgbuf.c:(.text+0x34dbbe): undefined reference to `dma_unmap_single' > drivers/built-in.o: In function `brcmf_proto_msgbuf_detach': > (.text+0x34dca4): undefined reference to `dma_free_coherent' > drivers/built-in.o: In function `brcmf_msgbuf_get_pktid': > msgbuf.c:(.text+0x34dd2a): undefined reference to `dma_unmap_single' > drivers/built-in.o: In function `brcmf_msgbuf_alloc_pktid': > msgbuf.c:(.text+0x34de12): undefined reference to `dma_map_single' > msgbuf.c:(.text+0x34de20): undefined reference to `dma_mapping_error' > drivers/built-in.o: In function `brcmf_msgbuf_remove_flowring': > msgbuf.c:(.text+0x34e3d6): undefined reference to `dma_free_coherent' > drivers/built-in.o: In function `brcmf_msgbuf_flowring_create': > msgbuf.c:(.text+0x34e4f8): undefined reference to `dma_alloc_coherent' > drivers/built-in.o: In function `brcmf_proto_msgbuf_attach': > (.text+0x34f5fe): undefined reference to `dma_alloc_coherent' > drivers/built-in.o: In function `brcmf_proto_msgbuf_attach': > (.text+0x34f798): undefined reference to `dma_free_coherent' > > Signed-off-by: Geert Uytterhoeven<geert@linux-m68k.org> > --- > drivers/net/wireless/brcm80211/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/wireless/brcm80211/Kconfig b/drivers/net/wireless/brcm80211/Kconfig > index b8e2561ea645..2e0da8925834 100644 > --- a/drivers/net/wireless/brcm80211/Kconfig > +++ b/drivers/net/wireless/brcm80211/Kconfig > @@ -19,7 +19,7 @@ config BRCMSMAC > > config BRCMFMAC > tristate "Broadcom IEEE802.11n embedded FullMAC WLAN driver" > - depends on CFG80211 > + depends on CFG80211A&& HAS_DMA Hi Geert, Not sure what happened here, but CFG80211 kconfig option did was not renamed as far as I know. Anyway, I would like to propose a different solution. Will get back to you when I have it ready. Regards, Arend > select BRCMUTIL > ---help--- > This module adds support for embedded wireless adapters based on -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Hi Arend, On Mon, Sep 1, 2014 at 10:21 AM, Arend van Spriel <arend@broadcom.com> wrote: >> config BRCMFMAC >> tristate "Broadcom IEEE802.11n embedded FullMAC WLAN driver" >> - depends on CFG80211 >> + depends on CFG80211A&& HAS_DMA > > Not sure what happened here, but CFG80211 kconfig option did was not renamed > as far as I know. Anyway, I would like to propose a different solution. Will Oops, that was me typing the vim append-command twice :-( Thanks for noticing! > get back to you when I have it ready. OK. Thanks again! Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/net/wireless/brcm80211/Kconfig b/drivers/net/wireless/brcm80211/Kconfig index b8e2561ea645..2e0da8925834 100644 --- a/drivers/net/wireless/brcm80211/Kconfig +++ b/drivers/net/wireless/brcm80211/Kconfig @@ -19,7 +19,7 @@ config BRCMSMAC config BRCMFMAC tristate "Broadcom IEEE802.11n embedded FullMAC WLAN driver" - depends on CFG80211 + depends on CFG80211A && HAS_DMA select BRCMUTIL ---help--- This module adds support for embedded wireless adapters based on
If NO_DMA=y: drivers/built-in.o: In function `brcmf_msgbuf_release_array': msgbuf.c:(.text+0x34dbbe): undefined reference to `dma_unmap_single' drivers/built-in.o: In function `brcmf_proto_msgbuf_detach': (.text+0x34dca4): undefined reference to `dma_free_coherent' drivers/built-in.o: In function `brcmf_msgbuf_get_pktid': msgbuf.c:(.text+0x34dd2a): undefined reference to `dma_unmap_single' drivers/built-in.o: In function `brcmf_msgbuf_alloc_pktid': msgbuf.c:(.text+0x34de12): undefined reference to `dma_map_single' msgbuf.c:(.text+0x34de20): undefined reference to `dma_mapping_error' drivers/built-in.o: In function `brcmf_msgbuf_remove_flowring': msgbuf.c:(.text+0x34e3d6): undefined reference to `dma_free_coherent' drivers/built-in.o: In function `brcmf_msgbuf_flowring_create': msgbuf.c:(.text+0x34e4f8): undefined reference to `dma_alloc_coherent' drivers/built-in.o: In function `brcmf_proto_msgbuf_attach': (.text+0x34f5fe): undefined reference to `dma_alloc_coherent' drivers/built-in.o: In function `brcmf_proto_msgbuf_attach': (.text+0x34f798): undefined reference to `dma_free_coherent' Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org> --- drivers/net/wireless/brcm80211/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)