diff mbox

iwlwifi: add 4c70 subdevice ID for 7260 series

Message ID 1410889186-28991-1-git-send-email-peter@lekensteyn.nl (mailing list archive)
State Not Applicable, archived
Headers show

Commit Message

Peter Wu Sept. 16, 2014, 5:39 p.m. UTC
This card appears in an Asus TP300LA laptop (from Chris Mens). lspci
output:

    02:00.0 Network controller [0280]: Intel Corporation Wireless 7260
[8086:08b1] (rev cb)
        Subsystem: Intel Corporation Device [8086:4c70]

Verified against v3.10.54 and v3.17-rc5-13-g2324067.

Cc: <stable@vger.kernel.org> # 3.10+
Tested-by: Peter Wu <peter@lekensteyn.nl>
Signed-off-by: Peter Wu <peter@lekensteyn.nl>
---
Hi,

Without patch the iwlwifi/iwldvm driver does not accept the 7260 AC card in an
Asus TP300LA laptop of a friend. Another report can be found on
<https://answers.launchpad.net/ubuntu/+source/gnome-nettool/+question/254548>.

By the way, initially I tried to write '8086 08b1 8086 4c70' (and also just the
first two words) to /sys/bus/pci/drivers/iwlwifi/new_id, and '0000:02:00.0' to
/sys/bus/pci/drivers/iwlwifi/bind, but I got EINVAL and ENODEV respectively.
Why did this not work?

Kind regards,
Peter
---
 drivers/net/wireless/iwlwifi/pcie/drv.c | 1 +
 1 file changed, 1 insertion(+)

Comments

Emmanuel Grumbach Sept. 16, 2014, 6:48 p.m. UTC | #1
> 
> This card appears in an Asus TP300LA laptop (from Chris Mens). lspci
> output:
> 
>     02:00.0 Network controller [0280]: Intel Corporation Wireless 7260
> [8086:08b1] (rev cb)
>         Subsystem: Intel Corporation Device [8086:4c70]
> 
> Verified against v3.10.54 and v3.17-rc5-13-g2324067.
> 
> Cc: <stable@vger.kernel.org> # 3.10+
> Tested-by: Peter Wu <peter@lekensteyn.nl>
> Signed-off-by: Peter Wu <peter@lekensteyn.nl>

Thanks for this. We will check the ID you requested.
We will also check for other IDs we might have missed.


> ---
> Hi,
> 
> Without patch the iwlwifi/iwldvm driver does not accept the 7260 AC card in
> an Asus TP300LA laptop of a friend. Another report can be found on
> <https://answers.launchpad.net/ubuntu/+source/gnome-
> nettool/+question/254548>.
> 
> By the way, initially I tried to write '8086 08b1 8086 4c70' (and also just the
> first two words) to /sys/bus/pci/drivers/iwlwifi/new_id, and '0000:02:00.0' to
> /sys/bus/pci/drivers/iwlwifi/bind, but I got EINVAL and ENODEV respectively.
> Why did this not work?
> 
> Kind regards,
> Peter
> ---
>  drivers/net/wireless/iwlwifi/pcie/drv.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/net/wireless/iwlwifi/pcie/drv.c
> b/drivers/net/wireless/iwlwifi/pcie/drv.c
> index f0e722c..eb83c89f 100644
> --- a/drivers/net/wireless/iwlwifi/pcie/drv.c
> +++ b/drivers/net/wireless/iwlwifi/pcie/drv.c
> @@ -297,6 +297,7 @@ static const struct pci_device_id iwl_hw_card_ids[] = {
>  	{IWL_PCI_DEVICE(0x08B1, 0x4560, iwl7260_2n_cfg)},
>  	{IWL_PCI_DEVICE(0x08B2, 0x4370, iwl7260_2ac_cfg)},
>  	{IWL_PCI_DEVICE(0x08B2, 0x4360, iwl7260_2n_cfg)},
> +	{IWL_PCI_DEVICE(0x08B1, 0x4c70, iwl7260_2ac_cfg)},
>  	{IWL_PCI_DEVICE(0x08B1, 0x5070, iwl7260_2ac_cfg)},
>  	{IWL_PCI_DEVICE(0x08B1, 0x5072, iwl7260_2ac_cfg)},
>  	{IWL_PCI_DEVICE(0x08B1, 0x5170, iwl7260_2ac_cfg)},
> --
> 2.1.0

--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Emmanuel Grumbach Sept. 17, 2014, 7:45 a.m. UTC | #2
> >
> > This card appears in an Asus TP300LA laptop (from Chris Mens). lspci
> > output:
> >
> >     02:00.0 Network controller [0280]: Intel Corporation Wireless 7260
> > [8086:08b1] (rev cb)
> >         Subsystem: Intel Corporation Device [8086:4c70]
> >
> > Verified against v3.10.54 and v3.17-rc5-13-g2324067.
> >
> > Cc: <stable@vger.kernel.org> # 3.10+
> > Tested-by: Peter Wu <peter@lekensteyn.nl>
> > Signed-off-by: Peter Wu <peter@lekensteyn.nl>
> 
> Thanks for this. We will check the ID you requested.
> We will also check for other IDs we might have missed.
> 

We found other devices that were missing. Thank you for your report.
I'll drop your patch and apply another patch that adds a few more devices.

> 
> > ---
> > Hi,
> >
> > Without patch the iwlwifi/iwldvm driver does not accept the 7260 AC
> > card in an Asus TP300LA laptop of a friend. Another report can be
> > found on
> > <https://answers.launchpad.net/ubuntu/+source/gnome-
> > nettool/+question/254548>.
> >
> > By the way, initially I tried to write '8086 08b1 8086 4c70' (and also
> > just the first two words) to /sys/bus/pci/drivers/iwlwifi/new_id, and
> > '0000:02:00.0' to /sys/bus/pci/drivers/iwlwifi/bind, but I got EINVAL and
> ENODEV respectively.
> > Why did this not work?
> >
> > Kind regards,
> > Peter
> > ---
> >  drivers/net/wireless/iwlwifi/pcie/drv.c | 1 +
> >  1 file changed, 1 insertion(+)
> >
> > diff --git a/drivers/net/wireless/iwlwifi/pcie/drv.c
> > b/drivers/net/wireless/iwlwifi/pcie/drv.c
> > index f0e722c..eb83c89f 100644
> > --- a/drivers/net/wireless/iwlwifi/pcie/drv.c
> > +++ b/drivers/net/wireless/iwlwifi/pcie/drv.c
> > @@ -297,6 +297,7 @@ static const struct pci_device_id iwl_hw_card_ids[]
> = {
> >  	{IWL_PCI_DEVICE(0x08B1, 0x4560, iwl7260_2n_cfg)},
> >  	{IWL_PCI_DEVICE(0x08B2, 0x4370, iwl7260_2ac_cfg)},
> >  	{IWL_PCI_DEVICE(0x08B2, 0x4360, iwl7260_2n_cfg)},
> > +	{IWL_PCI_DEVICE(0x08B1, 0x4c70, iwl7260_2ac_cfg)},
> >  	{IWL_PCI_DEVICE(0x08B1, 0x5070, iwl7260_2ac_cfg)},
> >  	{IWL_PCI_DEVICE(0x08B1, 0x5072, iwl7260_2ac_cfg)},
> >  	{IWL_PCI_DEVICE(0x08B1, 0x5170, iwl7260_2ac_cfg)},
> > --
> > 2.1.0

--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/drivers/net/wireless/iwlwifi/pcie/drv.c b/drivers/net/wireless/iwlwifi/pcie/drv.c
index f0e722c..eb83c89f 100644
--- a/drivers/net/wireless/iwlwifi/pcie/drv.c
+++ b/drivers/net/wireless/iwlwifi/pcie/drv.c
@@ -297,6 +297,7 @@  static const struct pci_device_id iwl_hw_card_ids[] = {
 	{IWL_PCI_DEVICE(0x08B1, 0x4560, iwl7260_2n_cfg)},
 	{IWL_PCI_DEVICE(0x08B2, 0x4370, iwl7260_2ac_cfg)},
 	{IWL_PCI_DEVICE(0x08B2, 0x4360, iwl7260_2n_cfg)},
+	{IWL_PCI_DEVICE(0x08B1, 0x4c70, iwl7260_2ac_cfg)},
 	{IWL_PCI_DEVICE(0x08B1, 0x5070, iwl7260_2ac_cfg)},
 	{IWL_PCI_DEVICE(0x08B1, 0x5072, iwl7260_2ac_cfg)},
 	{IWL_PCI_DEVICE(0x08B1, 0x5170, iwl7260_2ac_cfg)},